_ Git - rust-lightning/blob - lightning/src/ln/payment_tests.rs

   1 // This file is Copyright its original authors, visible in version control
   2 // history.
   3 //
   4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
   5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
   6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
   7 // You may not use this file except in accordance with one or both of these
   8 // licenses.
   9
  10 //! Tests that test the payment retry logic in ChannelManager, including various edge-cases around
  11 //! serialization ordering between ChannelManager/ChannelMonitors and ensuring we can still retry
  12 //! payments thereafter.
  13
  14 use chain::{Confirm, Watch};
  15 use chain::channelmonitor::ChannelMonitor;
  16 use ln::{PaymentPreimage, PaymentHash};
  17 use ln::channelmanager::{ChannelManager, ChannelManagerReadArgs, PaymentId, PaymentSendFailure};
  18 use ln::features::InitFeatures;
  19 use ln::msgs;
  20 use ln::msgs::{ChannelMessageHandler, ErrorAction};
  21 use util::events::{ClosureReason, Event, MessageSendEvent, MessageSendEventsProvider};
  22 use util::test_utils;
  23 use util::errors::APIError;
  24 use util::enforcing_trait_impls::EnforcingSigner;
  25 use util::ser::{ReadableArgs, Writeable};
  26
  27 use bitcoin::hashes::sha256::Hash as Sha256;
  28 use bitcoin::hashes::Hash;
  29 use bitcoin::BlockHash;
  30
  31 use prelude::*;
  32
  33 use ln::functional_test_utils::*;
  34
  35 #[test]
  36 fn retry_single_path_payment() {
  37         let chanmon_cfgs = create_chanmon_cfgs(3);
  38         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
  39         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
  40         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
  41
  42         let _chan_0 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
  43         let _chan_1 = create_announced_chan_between_nodes(&nodes, 2, 1, InitFeatures::known(), InitFeatures::known());
  44         // Rebalance to find a route
  45         send_payment(&nodes[2], &vec!(&nodes[1])[..], 3_000_000);
  46
  47         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], 100_000);
  48
  49         // Rebalance so that the first hop fails.
  50         send_payment(&nodes[1], &vec!(&nodes[2])[..], 2_000_000);
  51
  52         // Make sure the payment fails on the first hop.
  53         let payment_id = nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret)).unwrap();
  54         check_added_monitors!(nodes[0], 1);
  55         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
  56         assert_eq!(events.len(), 1);
  57         let mut payment_event = SendEvent::from_event(events.pop().unwrap());
  58         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
  59         check_added_monitors!(nodes[1], 0);
  60         commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
  61         expect_pending_htlcs_forwardable!(nodes[1]);
  62         expect_pending_htlcs_forwardable!(&nodes[1]);
  63         let htlc_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
  64         assert!(htlc_updates.update_add_htlcs.is_empty());
  65         assert_eq!(htlc_updates.update_fail_htlcs.len(), 1);
  66         assert!(htlc_updates.update_fulfill_htlcs.is_empty());
  67         assert!(htlc_updates.update_fail_malformed_htlcs.is_empty());
  68         check_added_monitors!(nodes[1], 1);
  69         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_updates.update_fail_htlcs[0]);
  70         commitment_signed_dance!(nodes[0], nodes[1], htlc_updates.commitment_signed, false);
  71         expect_payment_failed!(nodes[0], payment_hash, false);
  72
  73         // Rebalance the channel so the retry succeeds.
  74         send_payment(&nodes[2], &vec!(&nodes[1])[..], 3_000_000);
  75
  76         // Mine two blocks (we expire retries after 3, so this will check that we don't expire early)
  77         connect_blocks(&nodes[0], 2);
  78
  79         // Retry the payment and make sure it succeeds.
  80         nodes[0].node.retry_payment(&route, payment_id).unwrap();
  81         check_added_monitors!(nodes[0], 1);
  82         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
  83         assert_eq!(events.len(), 1);
  84         pass_along_path(&nodes[0], &[&nodes[1], &nodes[2]], 100_000, payment_hash, Some(payment_secret), events.pop().unwrap(), true, None);
  85         claim_payment_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], false, payment_preimage);
  86 }
  87
  88 #[test]
  89 fn mpp_failure() {
  90         let chanmon_cfgs = create_chanmon_cfgs(4);
  91         let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
  92         let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
  93         let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
  94
  95         let chan_1_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
  96         let chan_2_id = create_announced_chan_between_nodes(&nodes, 0, 2, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
  97         let chan_3_id = create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
  98         let chan_4_id = create_announced_chan_between_nodes(&nodes, 2, 3, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
  99
 100         let (mut route, payment_hash, _, payment_secret) = get_route_and_payment_hash!(&nodes[0], nodes[3], 100000);
 101         let path = route.paths[0].clone();
 102         route.paths.push(path);
 103         route.paths[0][0].pubkey = nodes[1].node.get_our_node_id();
 104         route.paths[0][0].short_channel_id = chan_1_id;
 105         route.paths[0][1].short_channel_id = chan_3_id;
 106         route.paths[1][0].pubkey = nodes[2].node.get_our_node_id();
 107         route.paths[1][0].short_channel_id = chan_2_id;
 108         route.paths[1][1].short_channel_id = chan_4_id;
 109         send_along_route_with_secret(&nodes[0], route, &[&[&nodes[1], &nodes[3]], &[&nodes[2], &nodes[3]]], 200_000, payment_hash, payment_secret);
 110         fail_payment_along_route(&nodes[0], &[&[&nodes[1], &nodes[3]], &[&nodes[2], &nodes[3]]], false, payment_hash);
 111 }
 112
 113 #[test]
 114 fn mpp_retry() {
 115         let chanmon_cfgs = create_chanmon_cfgs(4);
 116         let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
 117         let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
 118         let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
 119
 120         let chan_1_id = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
 121         let chan_2_id = create_announced_chan_between_nodes(&nodes, 0, 2, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
 122         let chan_3_id = create_announced_chan_between_nodes(&nodes, 1, 3, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
 123         let chan_4_id = create_announced_chan_between_nodes(&nodes, 3, 2, InitFeatures::known(), InitFeatures::known()).0.contents.short_channel_id;
 124         // Rebalance
 125         send_payment(&nodes[3], &vec!(&nodes[2])[..], 1_500_000);
 126
 127         let (mut route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[3], 1_000_000);
 128         let path = route.paths[0].clone();
 129         route.paths.push(path);
 130         route.paths[0][0].pubkey = nodes[1].node.get_our_node_id();
 131         route.paths[0][0].short_channel_id = chan_1_id;
 132         route.paths[0][1].short_channel_id = chan_3_id;
 133         route.paths[1][0].pubkey = nodes[2].node.get_our_node_id();
 134         route.paths[1][0].short_channel_id = chan_2_id;
 135         route.paths[1][1].short_channel_id = chan_4_id;
 136
 137         // Initiate the MPP payment.
 138         let payment_id = nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret)).unwrap();
 139         check_added_monitors!(nodes[0], 2); // one monitor per path
 140         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
 141         assert_eq!(events.len(), 2);
 142
 143         // Pass half of the payment along the success path.
 144         let success_path_msgs = events.remove(0);
 145         pass_along_path(&nodes[0], &[&nodes[1], &nodes[3]], 2_000_000, payment_hash, Some(payment_secret), success_path_msgs, false, None);
 146
 147         // Add the HTLC along the first hop.
 148         let fail_path_msgs_1 = events.remove(0);
 149         let (update_add, commitment_signed) = match fail_path_msgs_1 {
 150                 MessageSendEvent::UpdateHTLCs { node_id: _, updates: msgs::CommitmentUpdate { ref update_add_htlcs, ref update_fulfill_htlcs, ref update_fail_htlcs, ref update_fail_malformed_htlcs, ref update_fee, ref commitment_signed } } => {
 151                         assert_eq!(update_add_htlcs.len(), 1);
 152                         assert!(update_fail_htlcs.is_empty());
 153                         assert!(update_fulfill_htlcs.is_empty());
 154                         assert!(update_fail_malformed_htlcs.is_empty());
 155                         assert!(update_fee.is_none());
 156                         (update_add_htlcs[0].clone(), commitment_signed.clone())
 157                 },
 158                 _ => panic!("Unexpected event"),
 159         };
 160         nodes[2].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &update_add);
 161         commitment_signed_dance!(nodes[2], nodes[0], commitment_signed, false);
 162
 163         // Attempt to forward the payment and complete the 2nd path's failure.
 164         expect_pending_htlcs_forwardable!(&nodes[2]);
 165         expect_pending_htlcs_forwardable!(&nodes[2]);
 166         let htlc_updates = get_htlc_update_msgs!(nodes[2], nodes[0].node.get_our_node_id());
 167         assert!(htlc_updates.update_add_htlcs.is_empty());
 168         assert_eq!(htlc_updates.update_fail_htlcs.len(), 1);
 169         assert!(htlc_updates.update_fulfill_htlcs.is_empty());
 170         assert!(htlc_updates.update_fail_malformed_htlcs.is_empty());
 171         check_added_monitors!(nodes[2], 1);
 172         nodes[0].node.handle_update_fail_htlc(&nodes[2].node.get_our_node_id(), &htlc_updates.update_fail_htlcs[0]);
 173         commitment_signed_dance!(nodes[0], nodes[2], htlc_updates.commitment_signed, false);
 174         expect_payment_failed!(nodes[0], payment_hash, false);
 175
 176         // Rebalance the channel so the second half of the payment can succeed.
 177         send_payment(&nodes[3], &vec!(&nodes[2])[..], 1_500_000);
 178
 179         // Make sure it errors as expected given a too-large amount.
 180         if let Err(PaymentSendFailure::ParameterError(APIError::APIMisuseError { err })) = nodes[0].node.retry_payment(&route, payment_id) {
 181                 assert!(err.contains("over total_payment_amt_msat"));
 182         } else { panic!("Unexpected error"); }
 183
 184         // Make sure it errors as expected given the wrong payment_id.
 185         if let Err(PaymentSendFailure::ParameterError(APIError::APIMisuseError { err })) = nodes[0].node.retry_payment(&route, PaymentId([0; 32])) {
 186                 assert!(err.contains("not found"));
 187         } else { panic!("Unexpected error"); }
 188
 189         // Retry the second half of the payment and make sure it succeeds.
 190         let mut path = route.clone();
 191         path.paths.remove(0);
 192         nodes[0].node.retry_payment(&path, payment_id).unwrap();
 193         check_added_monitors!(nodes[0], 1);
 194         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
 195         assert_eq!(events.len(), 1);
 196         pass_along_path(&nodes[0], &[&nodes[2], &nodes[3]], 2_000_000, payment_hash, Some(payment_secret), events.pop().unwrap(), true, None);
 197         claim_payment_along_route(&nodes[0], &[&[&nodes[1], &nodes[3]], &[&nodes[2], &nodes[3]]], false, payment_preimage);
 198 }
 199
 200 #[test]
 201 fn retry_expired_payment() {
 202         let chanmon_cfgs = create_chanmon_cfgs(3);
 203         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 204         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
 205         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 206
 207         let _chan_0 = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
 208         let _chan_1 = create_announced_chan_between_nodes(&nodes, 2, 1, InitFeatures::known(), InitFeatures::known());
 209         // Rebalance to find a route
 210         send_payment(&nodes[2], &vec!(&nodes[1])[..], 3_000_000);
 211
 212         let (route, payment_hash, _, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], 100_000);
 213
 214         // Rebalance so that the first hop fails.
 215         send_payment(&nodes[1], &vec!(&nodes[2])[..], 2_000_000);
 216
 217         // Make sure the payment fails on the first hop.
 218         let payment_id = nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret)).unwrap();
 219         check_added_monitors!(nodes[0], 1);
 220         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
 221         assert_eq!(events.len(), 1);
 222         let mut payment_event = SendEvent::from_event(events.pop().unwrap());
 223         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
 224         check_added_monitors!(nodes[1], 0);
 225         commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false);
 226         expect_pending_htlcs_forwardable!(nodes[1]);
 227         expect_pending_htlcs_forwardable!(&nodes[1]);
 228         let htlc_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 229         assert!(htlc_updates.update_add_htlcs.is_empty());
 230         assert_eq!(htlc_updates.update_fail_htlcs.len(), 1);
 231         assert!(htlc_updates.update_fulfill_htlcs.is_empty());
 232         assert!(htlc_updates.update_fail_malformed_htlcs.is_empty());
 233         check_added_monitors!(nodes[1], 1);
 234         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_updates.update_fail_htlcs[0]);
 235         commitment_signed_dance!(nodes[0], nodes[1], htlc_updates.commitment_signed, false);
 236         expect_payment_failed!(nodes[0], payment_hash, false);
 237
 238         // Mine blocks so the payment will have expired.
 239         connect_blocks(&nodes[0], 3);
 240
 241         // Retry the payment and make sure it errors as expected.
 242         if let Err(PaymentSendFailure::ParameterError(APIError::APIMisuseError { err })) = nodes[0].node.retry_payment(&route, payment_id) {
 243                 assert!(err.contains("not found"));
 244         } else {
 245                 panic!("Unexpected error");
 246         }
 247 }
 248
 249 #[test]
 250 fn no_pending_leak_on_initial_send_failure() {
 251         // In an earlier version of our payment tracking, we'd have a retry entry even when the initial
 252         // HTLC for payment failed to send due to local channel errors (e.g. peer disconnected). In this
 253         // case, the user wouldn't have a PaymentId to retry the payment with, but we'd think we have a
 254         // pending payment forever and never time it out.
 255         // Here we test exactly that - retrying a payment when a peer was disconnected on the first
 256         // try, and then check that no pending payment is being tracked.
 257         let chanmon_cfgs = create_chanmon_cfgs(2);
 258         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 259         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
 260         let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 261
 262         create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
 263
 264         let (route, payment_hash, _, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[1], 100_000);
 265
 266         nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
 267         nodes[1].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
 268
 269         unwrap_send_err!(nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret)),
 270                 true, APIError::ChannelUnavailable { ref err },
 271                 assert_eq!(err, "Peer for first hop currently disconnected/pending monitor update!"));
 272
 273         assert!(!nodes[0].node.has_pending_payments());
 274 }
 275
 276 fn do_retry_with_no_persist(confirm_before_reload: bool) {
 277         // If we send a pending payment and `send_payment` returns success, we should always either
 278         // return a payment failure event or a payment success event, and on failure the payment should
 279         // be retryable.
 280         //
 281         // In order to do so when the ChannelManager isn't immediately persisted (which is normal - its
 282         // always persisted asynchronously), the ChannelManager has to reload some payment data from
 283         // ChannelMonitor(s) in some cases. This tests that reloading.
 284         //
 285         // `confirm_before_reload` confirms the channel-closing commitment transaction on-chain prior
 286         // to reloading the ChannelManager, increasing test coverage in ChannelMonitor HTLC tracking
 287         // which has separate codepaths for "commitment transaction already confirmed" and not.
 288         let chanmon_cfgs = create_chanmon_cfgs(3);
 289         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 290         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
 291         let persister: test_utils::TestPersister;
 292         let new_chain_monitor: test_utils::TestChainMonitor;
 293         let nodes_0_deserialized: ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>;
 294         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 295
 296         let (_, _, chan_id, funding_tx) = create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
 297         create_announced_chan_between_nodes(&nodes, 1, 2, InitFeatures::known(), InitFeatures::known());
 298
 299         // Serialize the ChannelManager prior to sending payments
 300         let nodes_0_serialized = nodes[0].node.encode();
 301
 302         // Send two payments - one which will get to nodes[2] and will be claimed, one which we'll time
 303         // out and retry.
 304         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], 1_000_000);
 305         let (payment_preimage_1, _, _, payment_id_1) = send_along_route(&nodes[0], route.clone(), &[&nodes[1], &nodes[2]], 1_000_000);
 306         let payment_id = nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret)).unwrap();
 307         check_added_monitors!(nodes[0], 1);
 308
 309         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
 310         assert_eq!(events.len(), 1);
 311         let payment_event = SendEvent::from_event(events.pop().unwrap());
 312         assert_eq!(payment_event.node_id, nodes[1].node.get_our_node_id());
 313
 314         // We relay the payment to nodes[1] while its disconnected from nodes[2], causing the payment
 315         // to be returned immediately to nodes[0], without having nodes[2] fail the inbound payment
 316         // which would prevent retry.
 317         nodes[1].node.peer_disconnected(&nodes[2].node.get_our_node_id(), false);
 318         nodes[2].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
 319
 320         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
 321         commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false, true);
 322         // nodes[1] now immediately fails the HTLC as the next-hop channel is disconnected
 323         let _ = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 324
 325         reconnect_nodes(&nodes[1], &nodes[2], (false, false), (0, 0), (0, 0), (0, 0), (0, 0), (0, 0), (false, false));
 326
 327         let as_commitment_tx = get_local_commitment_txn!(nodes[0], chan_id)[0].clone();
 328         if confirm_before_reload {
 329                 mine_transaction(&nodes[0], &as_commitment_tx);
 330                 nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().clear();
 331         }
 332
 333         // The ChannelMonitor should always be the latest version, as we're required to persist it
 334         // during the `commitment_signed_dance!()`.
 335         let mut chan_0_monitor_serialized = test_utils::TestVecWriter(Vec::new());
 336         get_monitor!(nodes[0], chan_id).write(&mut chan_0_monitor_serialized).unwrap();
 337
 338         persister = test_utils::TestPersister::new();
 339         let keys_manager = &chanmon_cfgs[0].keys_manager;
 340         new_chain_monitor = test_utils::TestChainMonitor::new(Some(nodes[0].chain_source), nodes[0].tx_broadcaster.clone(), nodes[0].logger, node_cfgs[0].fee_estimator, &persister, keys_manager);
 341         nodes[0].chain_monitor = &new_chain_monitor;
 342         let mut chan_0_monitor_read = &chan_0_monitor_serialized.0[..];
 343         let (_, mut chan_0_monitor) = <(BlockHash, ChannelMonitor<EnforcingSigner>)>::read(
 344                 &mut chan_0_monitor_read, keys_manager).unwrap();
 345         assert!(chan_0_monitor_read.is_empty());
 346
 347         let mut nodes_0_read = &nodes_0_serialized[..];
 348         let (_, nodes_0_deserialized_tmp) = {
 349                 let mut channel_monitors = HashMap::new();
 350                 channel_monitors.insert(chan_0_monitor.get_funding_txo().0, &mut chan_0_monitor);
 351                 <(BlockHash, ChannelManager<EnforcingSigner, &test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestLogger>)>::read(&mut nodes_0_read, ChannelManagerReadArgs {
 352                         default_config: test_default_channel_config(),
 353                         keys_manager,
 354                         fee_estimator: node_cfgs[0].fee_estimator,
 355                         chain_monitor: nodes[0].chain_monitor,
 356                         tx_broadcaster: nodes[0].tx_broadcaster.clone(),
 357                         logger: nodes[0].logger,
 358                         channel_monitors,
 359                 }).unwrap()
 360         };
 361         nodes_0_deserialized = nodes_0_deserialized_tmp;
 362         assert!(nodes_0_read.is_empty());
 363
 364         assert!(nodes[0].chain_monitor.watch_channel(chan_0_monitor.get_funding_txo().0, chan_0_monitor).is_ok());
 365         nodes[0].node = &nodes_0_deserialized;
 366         check_added_monitors!(nodes[0], 1);
 367
 368         // On reload, the ChannelManager should realize it is stale compared to the ChannelMonitor and
 369         // force-close the channel.
 370         check_closed_event!(nodes[0], 1, ClosureReason::OutdatedChannelManager);
 371         assert!(nodes[0].node.list_channels().is_empty());
 372         assert!(nodes[0].node.has_pending_payments());
 373         let as_broadcasted_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0);
 374         assert_eq!(as_broadcasted_txn.len(), 1);
 375         assert_eq!(as_broadcasted_txn[0], as_commitment_tx);
 376
 377         nodes[1].node.peer_disconnected(&nodes[0].node.get_our_node_id(), false);
 378         nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: InitFeatures::known()});
 379         assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
 380
 381         // Now nodes[1] should send a channel reestablish, which nodes[0] will respond to with an
 382         // error, as the channel has hit the chain.
 383         nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: InitFeatures::known()});
 384         let bs_reestablish = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReestablish, nodes[0].node.get_our_node_id());
 385         nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
 386         let as_err = nodes[0].node.get_and_clear_pending_msg_events();
 387         assert_eq!(as_err.len(), 1);
 388         match as_err[0] {
 389                 MessageSendEvent::HandleError { node_id, action: msgs::ErrorAction::SendErrorMessage { ref msg } } => {
 390                         assert_eq!(node_id, nodes[1].node.get_our_node_id());
 391                         nodes[1].node.handle_error(&nodes[0].node.get_our_node_id(), msg);
 392                         check_closed_event!(nodes[1], 1, ClosureReason::CounterpartyForceClosed { peer_msg: "Failed to find corresponding channel".to_string() });
 393                         check_added_monitors!(nodes[1], 1);
 394                         assert_eq!(nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0).len(), 1);
 395                 },
 396                 _ => panic!("Unexpected event"),
 397         }
 398         check_closed_broadcast!(nodes[1], false);
 399
 400         // Now claim the first payment, which should allow nodes[1] to claim the payment on-chain when
 401         // we close in a moment.
 402         nodes[2].node.claim_funds(payment_preimage_1);
 403         check_added_monitors!(nodes[2], 1);
 404         let htlc_fulfill_updates = get_htlc_update_msgs!(nodes[2], nodes[1].node.get_our_node_id());
 405         nodes[1].node.handle_update_fulfill_htlc(&nodes[2].node.get_our_node_id(), &htlc_fulfill_updates.update_fulfill_htlcs[0]);
 406         check_added_monitors!(nodes[1], 1);
 407         commitment_signed_dance!(nodes[1], nodes[2], htlc_fulfill_updates.commitment_signed, false);
 408
 409         if confirm_before_reload {
 410                 let best_block = nodes[0].blocks.lock().unwrap().last().unwrap().clone();
 411                 nodes[0].node.best_block_updated(&best_block.0, best_block.1);
 412         }
 413
 414         // Create a new channel on which to retry the payment before we fail the payment via the
 415         // HTLC-Timeout transaction. This avoids ChannelManager timing out the payment due to us
 416         // connecting several blocks while creating the channel (implying time has passed).
 417         create_announced_chan_between_nodes(&nodes, 0, 1, InitFeatures::known(), InitFeatures::known());
 418         assert_eq!(nodes[0].node.list_usable_channels().len(), 1);
 419
 420         mine_transaction(&nodes[1], &as_commitment_tx);
 421         let bs_htlc_claim_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0);
 422         assert_eq!(bs_htlc_claim_txn.len(), 1);
 423         check_spends!(bs_htlc_claim_txn[0], as_commitment_tx);
 424         expect_payment_forwarded!(nodes[1], None, false);
 425
 426         mine_transaction(&nodes[0], &as_commitment_tx);
 427         mine_transaction(&nodes[0], &bs_htlc_claim_txn[0]);
 428         expect_payment_sent!(nodes[0], payment_preimage_1);
 429         connect_blocks(&nodes[0], TEST_FINAL_CLTV*4 + 20);
 430         let as_htlc_timeout_txn = nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0);
 431         check_spends!(as_htlc_timeout_txn[2], funding_tx);
 432         check_spends!(as_htlc_timeout_txn[0], as_commitment_tx);
 433         check_spends!(as_htlc_timeout_txn[1], as_commitment_tx);
 434         assert_eq!(as_htlc_timeout_txn.len(), 3);
 435         if as_htlc_timeout_txn[0].input[0].previous_output == bs_htlc_claim_txn[0].input[0].previous_output {
 436                 confirm_transaction(&nodes[0], &as_htlc_timeout_txn[1]);
 437         } else {
 438                 confirm_transaction(&nodes[0], &as_htlc_timeout_txn[0]);
 439         }
 440         nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().clear();
 441         expect_payment_failed!(nodes[0], payment_hash, false);
 442
 443         // Finally, retry the payment (which was reloaded from the ChannelMonitor when nodes[0] was
 444         // reloaded) via a route over the new channel, which work without issue and eventually be
 445         // received and claimed at the recipient just like any other payment.
 446         let (new_route, _, _, _) = get_route_and_payment_hash!(nodes[0], nodes[2], 1_000_000);
 447
 448         assert!(nodes[0].node.retry_payment(&new_route, payment_id_1).is_err()); // Shouldn't be allowed to retry a fulfilled payment
 449         nodes[0].node.retry_payment(&new_route, payment_id).unwrap();
 450         check_added_monitors!(nodes[0], 1);
 451         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
 452         assert_eq!(events.len(), 1);
 453         pass_along_path(&nodes[0], &[&nodes[1], &nodes[2]], 1_000_000, payment_hash, Some(payment_secret), events.pop().unwrap(), true, None);
 454         claim_payment_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], false, payment_preimage);
 455 }
 456
 457 #[test]
 458 fn retry_with_no_persist() {
 459         do_retry_with_no_persist(true);
 460         do_retry_with_no_persist(false);
 461 }