git.bitcoin.ninja Git - rust-lightning/blob - lightning/src/ln/priv_short_conf_tests.rs

   1 // This file is Copyright its original authors, visible in version control
   2 // history.
   3 //
   4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
   5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
   6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
   7 // You may not use this file except in accordance with one or both of these
   8 // licenses.
   9
  10 //! Tests that test ChannelManager behavior with fewer confirmations required than the default and
  11 //! other behavior that exists only on private channels or with a semi-trusted counterparty (eg
  12 //! LSP).
  13
  14 use crate::chain::ChannelMonitorUpdateStatus;
  15 use crate::sign::NodeSigner;
  16 use crate::events::{ClosureReason, Event, HTLCDestination, MessageSendEvent, MessageSendEventsProvider};
  17 use crate::ln::channelmanager::{ChannelManager, MIN_CLTV_EXPIRY_DELTA, PaymentId, RecipientOnionFields};
  18 use crate::routing::gossip::RoutingFees;
  19 use crate::routing::router::{PaymentParameters, RouteHint, RouteHintHop};
  20 use crate::ln::features::ChannelTypeFeatures;
  21 use crate::ln::msgs;
  22 use crate::ln::msgs::{ChannelMessageHandler, RoutingMessageHandler, ChannelUpdate, ErrorAction};
  23 use crate::ln::wire::Encode;
  24 use crate::util::config::UserConfig;
  25 use crate::util::ser::Writeable;
  26 use crate::util::test_utils;
  27
  28 use crate::prelude::*;
  29 use core::default::Default;
  30
  31 use crate::ln::functional_test_utils::*;
  32
  33 use bitcoin::blockdata::constants::genesis_block;
  34 use bitcoin::network::constants::Network;
  35
  36 #[test]
  37 fn test_priv_forwarding_rejection() {
  38         // If we have a private channel with outbound liquidity, and
  39         // UserConfig::accept_forwards_to_priv_channels is set to false, we should reject any attempts
  40         // to forward through that channel.
  41         let chanmon_cfgs = create_chanmon_cfgs(3);
  42         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
  43         let mut no_announce_cfg = test_default_channel_config();
  44         no_announce_cfg.accept_forwards_to_priv_channels = false;
  45         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(no_announce_cfg), None]);
  46         let persister: test_utils::TestPersister;
  47         let new_chain_monitor: test_utils::TestChainMonitor;
  48         let nodes_1_deserialized: ChannelManager<&test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestRouter, &test_utils::TestLogger>;
  49         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
  50
  51         let chan_id_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000).2;
  52         let chan_id_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 500_000_000).0.channel_id;
  53
  54         // We should always be able to forward through nodes[1] as long as its out through a public
  55         // channel:
  56         send_payment(&nodes[2], &[&nodes[1], &nodes[0]], 10_000);
  57
  58         // ... however, if we send to nodes[2], we will have to pass the private channel from nodes[1]
  59         // to nodes[2], which should be rejected:
  60         let route_hint = RouteHint(vec![RouteHintHop {
  61                 src_node_id: nodes[1].node.get_our_node_id(),
  62                 short_channel_id: nodes[2].node.list_channels()[0].short_channel_id.unwrap(),
  63                 fees: RoutingFees { base_msat: 1000, proportional_millionths: 0 },
  64                 cltv_expiry_delta: MIN_CLTV_EXPIRY_DELTA,
  65                 htlc_minimum_msat: None,
  66                 htlc_maximum_msat: None,
  67         }]);
  68         let last_hops = vec![route_hint];
  69         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), TEST_FINAL_CLTV)
  70                 .with_bolt11_features(nodes[2].node.invoice_features()).unwrap()
  71                 .with_route_hints(last_hops).unwrap();
  72         let (route, our_payment_hash, our_payment_preimage, our_payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 10_000);
  73
  74         nodes[0].node.send_payment_with_route(&route, our_payment_hash,
  75                 RecipientOnionFields::secret_only(our_payment_secret), PaymentId(our_payment_hash.0)).unwrap();
  76         check_added_monitors!(nodes[0], 1);
  77         let payment_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
  78         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
  79         commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false, true);
  80
  81         let htlc_fail_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
  82         assert!(htlc_fail_updates.update_add_htlcs.is_empty());
  83         assert_eq!(htlc_fail_updates.update_fail_htlcs.len(), 1);
  84         assert!(htlc_fail_updates.update_fail_malformed_htlcs.is_empty());
  85         assert!(htlc_fail_updates.update_fee.is_none());
  86
  87         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_fail_updates.update_fail_htlcs[0]);
  88         commitment_signed_dance!(nodes[0], nodes[1], htlc_fail_updates.commitment_signed, true, true);
  89         expect_payment_failed_with_update!(nodes[0], our_payment_hash, false, nodes[2].node.list_channels()[0].short_channel_id.unwrap(), true);
  90
  91         // Now disconnect nodes[1] from its peers and restart with accept_forwards_to_priv_channels set
  92         // to true. Sadly there is currently no way to change it at runtime.
  93
  94         nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id());
  95         nodes[2].node.peer_disconnected(&nodes[1].node.get_our_node_id());
  96
  97         let nodes_1_serialized = nodes[1].node.encode();
  98         let monitor_a_serialized = get_monitor!(nodes[1], chan_id_1).encode();
  99         let monitor_b_serialized = get_monitor!(nodes[1], chan_id_2).encode();
 100
 101         no_announce_cfg.accept_forwards_to_priv_channels = true;
 102         reload_node!(nodes[1], no_announce_cfg, &nodes_1_serialized, &[&monitor_a_serialized, &monitor_b_serialized], persister, new_chain_monitor, nodes_1_deserialized);
 103
 104         nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init {
 105                 features: nodes[1].node.init_features(), networks: None, remote_network_address: None
 106         }, true).unwrap();
 107         nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init {
 108                 features: nodes[0].node.init_features(), networks: None, remote_network_address: None
 109         }, false).unwrap();
 110         let as_reestablish = get_chan_reestablish_msgs!(nodes[0], nodes[1]).pop().unwrap();
 111         let bs_reestablish = get_chan_reestablish_msgs!(nodes[1], nodes[0]).pop().unwrap();
 112         nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &as_reestablish);
 113         nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
 114         get_event_msg!(nodes[0], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 115         get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
 116
 117         nodes[1].node.peer_connected(&nodes[2].node.get_our_node_id(), &msgs::Init {
 118                 features: nodes[2].node.init_features(), networks: None, remote_network_address: None
 119         }, true).unwrap();
 120         nodes[2].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init {
 121                 features: nodes[1].node.init_features(), networks: None, remote_network_address: None
 122         }, false).unwrap();
 123         let bs_reestablish = get_chan_reestablish_msgs!(nodes[1], nodes[2]).pop().unwrap();
 124         let cs_reestablish = get_chan_reestablish_msgs!(nodes[2], nodes[1]).pop().unwrap();
 125         nodes[2].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
 126         nodes[1].node.handle_channel_reestablish(&nodes[2].node.get_our_node_id(), &cs_reestablish);
 127         get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
 128         get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 129
 130         nodes[0].node.send_payment_with_route(&route, our_payment_hash,
 131                 RecipientOnionFields::secret_only(our_payment_secret), PaymentId(our_payment_hash.0)).unwrap();
 132         check_added_monitors!(nodes[0], 1);
 133         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 10_000, our_payment_hash, our_payment_secret);
 134         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], our_payment_preimage);
 135 }
 136
 137 fn do_test_1_conf_open(connect_style: ConnectStyle) {
 138         // Previously, if the minium_depth config was set to 1, we'd never send a channel_ready. This
 139         // tests that we properly send one in that case.
 140         let mut alice_config = UserConfig::default();
 141         alice_config.channel_handshake_config.minimum_depth = 1;
 142         alice_config.channel_handshake_config.announced_channel = true;
 143         alice_config.channel_handshake_limits.force_announced_channel_preference = false;
 144         let mut bob_config = UserConfig::default();
 145         bob_config.channel_handshake_config.minimum_depth = 1;
 146         bob_config.channel_handshake_config.announced_channel = true;
 147         bob_config.channel_handshake_limits.force_announced_channel_preference = false;
 148         let chanmon_cfgs = create_chanmon_cfgs(2);
 149         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 150         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[Some(alice_config), Some(bob_config)]);
 151         let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 152         *nodes[0].connect_style.borrow_mut() = connect_style;
 153
 154         let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001);
 155         mine_transaction(&nodes[1], &tx);
 156         nodes[0].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendChannelReady, nodes[0].node.get_our_node_id()));
 157         assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
 158
 159         mine_transaction(&nodes[0], &tx);
 160         let as_msg_events = nodes[0].node.get_and_clear_pending_msg_events();
 161         assert_eq!(as_msg_events.len(), 2);
 162         let as_channel_ready = if let MessageSendEvent::SendChannelReady { ref node_id, ref msg } = as_msg_events[0] {
 163                 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 164                 msg.clone()
 165         } else { panic!("Unexpected event"); };
 166         if let MessageSendEvent::SendChannelUpdate { ref node_id, msg: _ } = as_msg_events[1] {
 167                 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 168         } else { panic!("Unexpected event"); }
 169
 170         nodes[1].node.handle_channel_ready(&nodes[0].node.get_our_node_id(), &as_channel_ready);
 171         expect_channel_ready_event(&nodes[0], &nodes[1].node.get_our_node_id());
 172         expect_channel_ready_event(&nodes[1], &nodes[0].node.get_our_node_id());
 173         let bs_msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 174         assert_eq!(bs_msg_events.len(), 1);
 175         if let MessageSendEvent::SendChannelUpdate { ref node_id, msg: _ } = bs_msg_events[0] {
 176                 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 177         } else { panic!("Unexpected event"); }
 178
 179         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 180
 181         // After 6 confirmations, as required by the spec, we'll send announcement_signatures and
 182         // broadcast the channel_announcement (but not before exactly 6 confirmations).
 183         connect_blocks(&nodes[0], 4);
 184         assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
 185         connect_blocks(&nodes[0], 1);
 186         nodes[1].node.handle_announcement_signatures(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendAnnouncementSignatures, nodes[1].node.get_our_node_id()));
 187         assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 188
 189         connect_blocks(&nodes[1], 5);
 190         let bs_announce_events = nodes[1].node.get_and_clear_pending_msg_events();
 191         assert_eq!(bs_announce_events.len(), 2);
 192         let bs_announcement_sigs = if let MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } = bs_announce_events[0] {
 193                 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 194                 msg.clone()
 195         } else { panic!("Unexpected event"); };
 196         let (bs_announcement, bs_update) = if let MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } = bs_announce_events[1] {
 197                 (msg.clone(), update_msg.clone().unwrap())
 198         } else { panic!("Unexpected event"); };
 199
 200         nodes[0].node.handle_announcement_signatures(&nodes[1].node.get_our_node_id(), &bs_announcement_sigs);
 201         let as_announce_events = nodes[0].node.get_and_clear_pending_msg_events();
 202         assert_eq!(as_announce_events.len(), 1);
 203         let (announcement, as_update) = if let MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } = as_announce_events[0] {
 204                 (msg.clone(), update_msg.clone().unwrap())
 205         } else { panic!("Unexpected event"); };
 206         assert_eq!(announcement, bs_announcement);
 207
 208         for node in nodes {
 209                 assert!(node.gossip_sync.handle_channel_announcement(&announcement).unwrap());
 210                 node.gossip_sync.handle_channel_update(&as_update).unwrap();
 211                 node.gossip_sync.handle_channel_update(&bs_update).unwrap();
 212         }
 213 }
 214 #[test]
 215 fn test_1_conf_open() {
 216         do_test_1_conf_open(ConnectStyle::BestBlockFirst);
 217         do_test_1_conf_open(ConnectStyle::TransactionsFirst);
 218         do_test_1_conf_open(ConnectStyle::FullBlockViaListen);
 219 }
 220
 221 #[test]
 222 fn test_routed_scid_alias() {
 223         // Trivially test sending a payment which is routed through an SCID alias.
 224         let chanmon_cfgs = create_chanmon_cfgs(3);
 225         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 226         let mut no_announce_cfg = test_default_channel_config();
 227         no_announce_cfg.accept_forwards_to_priv_channels = true;
 228         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(no_announce_cfg), None]);
 229         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 230
 231         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000).2;
 232         let mut as_channel_ready = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 500_000_000).0;
 233
 234         let last_hop = nodes[2].node.list_usable_channels();
 235         let hop_hints = vec![RouteHint(vec![RouteHintHop {
 236                 src_node_id: nodes[1].node.get_our_node_id(),
 237                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 238                 fees: RoutingFees {
 239                         base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 240                         proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 241                 },
 242                 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
 243                 htlc_maximum_msat: None,
 244                 htlc_minimum_msat: None,
 245         }])];
 246         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
 247                 .with_bolt11_features(nodes[2].node.invoice_features()).unwrap()
 248                 .with_route_hints(hop_hints).unwrap();
 249         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 100_000);
 250         assert_eq!(route.paths[0].hops[1].short_channel_id, last_hop[0].inbound_scid_alias.unwrap());
 251         nodes[0].node.send_payment_with_route(&route, payment_hash,
 252                 RecipientOnionFields::secret_only(payment_secret), PaymentId(payment_hash.0)).unwrap();
 253         check_added_monitors!(nodes[0], 1);
 254
 255         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 100_000, payment_hash, payment_secret);
 256
 257         as_channel_ready.short_channel_id_alias = Some(0xeadbeef);
 258         nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &as_channel_ready);
 259         // Note that we always respond to a channel_ready with a channel_update. Not a lot of reason
 260         // to bother updating that code, so just drop the message here.
 261         get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 262
 263         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
 264
 265         // Now test that if a peer sends us a second channel_ready after the channel is operational we
 266         // will use the new alias.
 267         as_channel_ready.short_channel_id_alias = Some(0xdeadbeef);
 268         nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &as_channel_ready);
 269         // Note that we always respond to a channel_ready with a channel_update. Not a lot of reason
 270         // to bother updating that code, so just drop the message here.
 271         get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 272         let updated_channel_info = nodes[2].node.list_usable_channels();
 273         assert_eq!(updated_channel_info.len(), 1);
 274         assert_eq!(updated_channel_info[0].inbound_scid_alias.unwrap(), 0xdeadbeef);
 275         // Note that because we never send a duplicate channel_ready we can't send a payment through
 276         // the 0xdeadbeef SCID alias.
 277 }
 278
 279 #[test]
 280 fn test_scid_privacy_on_pub_channel() {
 281         // Tests rejecting the scid_privacy feature for public channels and that we don't ever try to
 282         // send them.
 283         let chanmon_cfgs = create_chanmon_cfgs(2);
 284         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 285         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
 286         let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 287
 288         let mut scid_privacy_cfg = test_default_channel_config();
 289         scid_privacy_cfg.channel_handshake_config.announced_channel = true;
 290         scid_privacy_cfg.channel_handshake_config.negotiate_scid_privacy = true;
 291         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(scid_privacy_cfg)).unwrap();
 292         let mut open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 293
 294         assert!(!open_channel.channel_type.as_ref().unwrap().supports_scid_privacy()); // we ignore `negotiate_scid_privacy` on pub channels
 295         open_channel.channel_type.as_mut().unwrap().set_scid_privacy_required();
 296         assert_eq!(open_channel.channel_flags & 1, 1); // The `announce_channel` bit is set.
 297
 298         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
 299         let err = get_err_msg(&nodes[1], &nodes[0].node.get_our_node_id());
 300         assert_eq!(err.data, "SCID Alias/Privacy Channel Type cannot be set on a public channel");
 301 }
 302
 303 #[test]
 304 fn test_scid_privacy_negotiation() {
 305         // Tests of the negotiation of SCID alias and falling back to non-SCID-alias if our
 306         // counterparty doesn't support it.
 307         let chanmon_cfgs = create_chanmon_cfgs(2);
 308         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 309         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
 310         let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 311
 312         let mut scid_privacy_cfg = test_default_channel_config();
 313         scid_privacy_cfg.channel_handshake_config.announced_channel = false;
 314         scid_privacy_cfg.channel_handshake_config.negotiate_scid_privacy = true;
 315         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(scid_privacy_cfg)).unwrap();
 316
 317         let init_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 318         assert!(init_open_channel.channel_type.as_ref().unwrap().supports_scid_privacy());
 319         assert!(nodes[0].node.list_channels()[0].channel_type.is_none()); // channel_type is none until counterparty accepts
 320
 321         // now simulate nodes[1] responding with an Error message, indicating it doesn't understand
 322         // SCID alias.
 323         nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage {
 324                 channel_id: init_open_channel.temporary_channel_id,
 325                 data: "Yo, no SCID aliases, no privacy here!".to_string()
 326         });
 327         assert!(nodes[0].node.list_channels()[0].channel_type.is_none()); // channel_type is none until counterparty accepts
 328
 329         let second_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 330         assert!(!second_open_channel.channel_type.as_ref().unwrap().supports_scid_privacy());
 331         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &second_open_channel);
 332         nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id()));
 333
 334         let events = nodes[0].node.get_and_clear_pending_events();
 335         assert_eq!(events.len(), 1);
 336         match events[0] {
 337                 Event::FundingGenerationReady { .. } => {},
 338                 _ => panic!("Unexpected event"),
 339         }
 340
 341         assert!(!nodes[0].node.list_channels()[0].channel_type.as_ref().unwrap().supports_scid_privacy());
 342         assert!(!nodes[1].node.list_channels()[0].channel_type.as_ref().unwrap().supports_scid_privacy());
 343 }
 344
 345 #[test]
 346 fn test_inbound_scid_privacy() {
 347         // Tests accepting channels with the scid_privacy feature and rejecting forwards using the
 348         // channel's real SCID as required by the channel feature.
 349         let chanmon_cfgs = create_chanmon_cfgs(3);
 350         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 351         let mut accept_forward_cfg = test_default_channel_config();
 352         accept_forward_cfg.accept_forwards_to_priv_channels = true;
 353         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(accept_forward_cfg), None]);
 354         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 355
 356         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
 357
 358         let mut no_announce_cfg = test_default_channel_config();
 359         no_announce_cfg.channel_handshake_config.announced_channel = false;
 360         no_announce_cfg.channel_handshake_config.negotiate_scid_privacy = true;
 361         nodes[1].node.create_channel(nodes[2].node.get_our_node_id(), 100_000, 10_000, 42, Some(no_announce_cfg)).unwrap();
 362         let mut open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[2].node.get_our_node_id());
 363
 364         assert!(open_channel.channel_type.as_ref().unwrap().requires_scid_privacy());
 365
 366         nodes[2].node.handle_open_channel(&nodes[1].node.get_our_node_id(), &open_channel);
 367         let accept_channel = get_event_msg!(nodes[2], MessageSendEvent::SendAcceptChannel, nodes[1].node.get_our_node_id());
 368         nodes[1].node.handle_accept_channel(&nodes[2].node.get_our_node_id(), &accept_channel);
 369
 370         let (temporary_channel_id, tx, _) = create_funding_transaction(&nodes[1], &nodes[2].node.get_our_node_id(), 100_000, 42);
 371         nodes[1].node.funding_transaction_generated(&temporary_channel_id, &nodes[2].node.get_our_node_id(), tx.clone()).unwrap();
 372         nodes[2].node.handle_funding_created(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendFundingCreated, nodes[2].node.get_our_node_id()));
 373         check_added_monitors!(nodes[2], 1);
 374
 375         let cs_funding_signed = get_event_msg!(nodes[2], MessageSendEvent::SendFundingSigned, nodes[1].node.get_our_node_id());
 376         expect_channel_pending_event(&nodes[2], &nodes[1].node.get_our_node_id());
 377
 378         nodes[1].node.handle_funding_signed(&nodes[2].node.get_our_node_id(), &cs_funding_signed);
 379         expect_channel_pending_event(&nodes[1], &nodes[2].node.get_our_node_id());
 380         check_added_monitors!(nodes[1], 1);
 381
 382         let conf_height = core::cmp::max(nodes[1].best_block_info().1 + 1, nodes[2].best_block_info().1 + 1);
 383         confirm_transaction_at(&nodes[1], &tx, conf_height);
 384         connect_blocks(&nodes[1], CHAN_CONFIRM_DEPTH - 1);
 385         confirm_transaction_at(&nodes[2], &tx, conf_height);
 386         connect_blocks(&nodes[2], CHAN_CONFIRM_DEPTH - 1);
 387         let bs_channel_ready = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReady, nodes[2].node.get_our_node_id());
 388         nodes[1].node.handle_channel_ready(&nodes[2].node.get_our_node_id(), &get_event_msg!(nodes[2], MessageSendEvent::SendChannelReady, nodes[1].node.get_our_node_id()));
 389         expect_channel_ready_event(&nodes[1], &nodes[2].node.get_our_node_id());
 390         let bs_update = get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
 391         nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &bs_channel_ready);
 392         expect_channel_ready_event(&nodes[2], &nodes[1].node.get_our_node_id());
 393         let cs_update = get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 394
 395         nodes[1].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &cs_update);
 396         nodes[2].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &bs_update);
 397
 398         // Now we can pay just fine using the SCID alias nodes[2] gave to nodes[1]...
 399
 400         let last_hop = nodes[2].node.list_usable_channels();
 401         let mut hop_hints = vec![RouteHint(vec![RouteHintHop {
 402                 src_node_id: nodes[1].node.get_our_node_id(),
 403                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 404                 fees: RoutingFees {
 405                         base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 406                         proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 407                 },
 408                 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
 409                 htlc_maximum_msat: None,
 410                 htlc_minimum_msat: None,
 411         }])];
 412         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
 413                 .with_bolt11_features(nodes[2].node.invoice_features()).unwrap()
 414                 .with_route_hints(hop_hints.clone()).unwrap();
 415         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 100_000);
 416         assert_eq!(route.paths[0].hops[1].short_channel_id, last_hop[0].inbound_scid_alias.unwrap());
 417         nodes[0].node.send_payment_with_route(&route, payment_hash,
 418                 RecipientOnionFields::secret_only(payment_secret), PaymentId(payment_hash.0)).unwrap();
 419         check_added_monitors!(nodes[0], 1);
 420
 421         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 100_000, payment_hash, payment_secret);
 422         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
 423
 424         // ... but if we try to pay using the real SCID, nodes[1] will just tell us they don't know
 425         // what channel we're talking about.
 426         hop_hints[0].0[0].short_channel_id = last_hop[0].short_channel_id.unwrap();
 427
 428         let payment_params_2 = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
 429                 .with_bolt11_features(nodes[2].node.invoice_features()).unwrap()
 430                 .with_route_hints(hop_hints).unwrap();
 431         let (route_2, payment_hash_2, _, payment_secret_2) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params_2, 100_000);
 432         assert_eq!(route_2.paths[0].hops[1].short_channel_id, last_hop[0].short_channel_id.unwrap());
 433         nodes[0].node.send_payment_with_route(&route_2, payment_hash_2,
 434                 RecipientOnionFields::secret_only(payment_secret_2), PaymentId(payment_hash_2.0)).unwrap();
 435         check_added_monitors!(nodes[0], 1);
 436
 437         let payment_event = SendEvent::from_node(&nodes[0]);
 438         assert_eq!(nodes[1].node.get_our_node_id(), payment_event.node_id);
 439         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
 440         commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, true, true);
 441
 442         nodes[1].logger.assert_log_regex("lightning::ln::channelmanager", regex::Regex::new(r"Refusing to forward over real channel SCID as our counterparty requested").unwrap(), 1);
 443
 444         let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 445         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
 446         commitment_signed_dance!(nodes[0], nodes[1], updates.commitment_signed, false);
 447
 448         expect_payment_failed_conditions(&nodes[0], payment_hash_2, false,
 449                 PaymentFailedConditions::new().blamed_scid(last_hop[0].short_channel_id.unwrap())
 450                         .blamed_chan_closed(true).expected_htlc_error_data(0x4000|10, &[0; 0]));
 451 }
 452
 453 #[test]
 454 fn test_scid_alias_returned() {
 455         // Tests that when we fail an HTLC (in this case due to attempting to forward more than the
 456         // channel's available balance) we use the correct (in this case the aliased) SCID in the
 457         // channel_update which is returned in the onion to the sender.
 458         let chanmon_cfgs = create_chanmon_cfgs(3);
 459         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 460         let mut accept_forward_cfg = test_default_channel_config();
 461         accept_forward_cfg.accept_forwards_to_priv_channels = true;
 462         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(accept_forward_cfg), None]);
 463         let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 464
 465         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 10_000_000, 0);
 466         let chan = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 10_000, 0);
 467
 468         let last_hop = nodes[2].node.list_usable_channels();
 469         let mut hop_hints = vec![RouteHint(vec![RouteHintHop {
 470                 src_node_id: nodes[1].node.get_our_node_id(),
 471                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 472                 fees: RoutingFees {
 473                         base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 474                         proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 475                 },
 476                 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
 477                 htlc_maximum_msat: None,
 478                 htlc_minimum_msat: None,
 479         }])];
 480         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
 481                 .with_bolt11_features(nodes[2].node.invoice_features()).unwrap()
 482                 .with_route_hints(hop_hints).unwrap();
 483         let (mut route, payment_hash, _, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 10_000);
 484         assert_eq!(route.paths[0].hops[1].short_channel_id, nodes[2].node.list_usable_channels()[0].inbound_scid_alias.unwrap());
 485
 486         route.paths[0].hops[1].fee_msat = 10_000_000; // Overshoot the last channel's value
 487
 488         // Route the HTLC through to the destination.
 489         nodes[0].node.send_payment_with_route(&route, payment_hash,
 490                 RecipientOnionFields::secret_only(payment_secret), PaymentId(payment_hash.0)).unwrap();
 491         check_added_monitors!(nodes[0], 1);
 492         let as_updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
 493         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_updates.update_add_htlcs[0]);
 494         commitment_signed_dance!(nodes[1], nodes[0], &as_updates.commitment_signed, false, true);
 495
 496         expect_pending_htlcs_forwardable!(nodes[1]);
 497         expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCDestination::NextHopChannel { node_id: Some(nodes[2].node.get_our_node_id()), channel_id: chan.0.channel_id }]);
 498         check_added_monitors!(nodes[1], 1);
 499
 500         let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 501         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
 502         commitment_signed_dance!(nodes[0], nodes[1], bs_updates.commitment_signed, false, true);
 503
 504         // Build the expected channel update
 505         let contents = msgs::UnsignedChannelUpdate {
 506                 chain_hash: genesis_block(Network::Testnet).header.block_hash(),
 507                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 508                 timestamp: 21,
 509                 flags: 1,
 510                 cltv_expiry_delta: accept_forward_cfg.channel_config.cltv_expiry_delta,
 511                 htlc_minimum_msat: 1_000,
 512                 htlc_maximum_msat: 1_000_000, // Defaults to 10% of the channel value
 513                 fee_base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 514                 fee_proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 515                 excess_data: Vec::new(),
 516         };
 517         let signature = nodes[1].keys_manager.sign_gossip_message(msgs::UnsignedGossipMessage::ChannelUpdate(&contents)).unwrap();
 518         let msg = msgs::ChannelUpdate { signature, contents };
 519
 520         let mut err_data = Vec::new();
 521         err_data.extend_from_slice(&(msg.serialized_length() as u16 + 2).to_be_bytes());
 522         err_data.extend_from_slice(&ChannelUpdate::TYPE.to_be_bytes());
 523         err_data.extend_from_slice(&msg.encode());
 524
 525         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
 526                 PaymentFailedConditions::new().blamed_scid(last_hop[0].inbound_scid_alias.unwrap())
 527                         .blamed_chan_closed(false).expected_htlc_error_data(0x1000|7, &err_data));
 528
 529         route.paths[0].hops[1].fee_msat = 10_000; // Reset to the correct payment amount
 530         route.paths[0].hops[0].fee_msat = 0; // But set fee paid to the middle hop to 0
 531
 532         // Route the HTLC through to the destination.
 533         nodes[0].node.send_payment_with_route(&route, payment_hash,
 534                 RecipientOnionFields::secret_only(payment_secret), PaymentId(payment_hash.0)).unwrap();
 535         check_added_monitors!(nodes[0], 1);
 536         let as_updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
 537         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_updates.update_add_htlcs[0]);
 538         commitment_signed_dance!(nodes[1], nodes[0], &as_updates.commitment_signed, false, true);
 539
 540         let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 541         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
 542         commitment_signed_dance!(nodes[0], nodes[1], bs_updates.commitment_signed, false, true);
 543
 544         let mut err_data = Vec::new();
 545         err_data.extend_from_slice(&10_000u64.to_be_bytes());
 546         err_data.extend_from_slice(&(msg.serialized_length() as u16 + 2).to_be_bytes());
 547         err_data.extend_from_slice(&ChannelUpdate::TYPE.to_be_bytes());
 548         err_data.extend_from_slice(&msg.encode());
 549         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
 550                 PaymentFailedConditions::new().blamed_scid(last_hop[0].inbound_scid_alias.unwrap())
 551                         .blamed_chan_closed(false).expected_htlc_error_data(0x1000|12, &err_data));
 552 }
 553
 554 #[test]
 555 fn test_simple_0conf_channel() {
 556         // If our peer tells us they will accept our channel with 0 confs, and we funded the channel,
 557         // we should trust the funding won't be double-spent (assuming `trust_own_funding_0conf` is
 558         // set)!
 559         // Further, if we `accept_inbound_channel_from_trusted_peer_0conf`, `channel_ready` messages
 560         // should fly immediately and the channel should be available for use as soon as they are
 561         // received.
 562
 563         let chanmon_cfgs = create_chanmon_cfgs(2);
 564         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 565         let mut chan_config = test_default_channel_config();
 566         chan_config.manually_accept_inbound_channels = true;
 567
 568         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 569         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 570
 571         open_zero_conf_channel(&nodes[0], &nodes[1], None);
 572
 573         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 574 }
 575
 576 #[test]
 577 fn test_0conf_channel_with_async_monitor() {
 578         // Test that we properly send out channel_ready in (both inbound- and outbound-) zero-conf
 579         // channels if ChannelMonitor updates return a `TemporaryFailure` during the initial channel
 580         // negotiation.
 581
 582         let chanmon_cfgs = create_chanmon_cfgs(3);
 583         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 584         let mut chan_config = test_default_channel_config();
 585         chan_config.manually_accept_inbound_channels = true;
 586         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(chan_config), None]);
 587         let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 588
 589         create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0);
 590
 591         chan_config.channel_handshake_config.announced_channel = false;
 592         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(chan_config)).unwrap();
 593         let open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 594
 595         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
 596         let events = nodes[1].node.get_and_clear_pending_events();
 597         assert_eq!(events.len(), 1);
 598         match events[0] {
 599                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 600                         nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(&temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).unwrap();
 601                 },
 602                 _ => panic!("Unexpected event"),
 603         };
 604
 605         let mut accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
 606         assert_eq!(accept_channel.minimum_depth, 0);
 607         nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &accept_channel);
 608
 609         let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&nodes[0], &nodes[1].node.get_our_node_id(), 100000, 42);
 610         nodes[0].node.funding_transaction_generated(&temporary_channel_id, &nodes[1].node.get_our_node_id(), tx.clone()).unwrap();
 611         let funding_created = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
 612
 613         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
 614         nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created);
 615         check_added_monitors!(nodes[1], 1);
 616         assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
 617
 618         let channel_id = funding_output.to_channel_id();
 619         nodes[1].chain_monitor.complete_sole_pending_chan_update(&channel_id);
 620         expect_channel_pending_event(&nodes[1], &nodes[0].node.get_our_node_id());
 621
 622         let bs_signed_locked = nodes[1].node.get_and_clear_pending_msg_events();
 623         assert_eq!(bs_signed_locked.len(), 2);
 624         chanmon_cfgs[0].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
 625
 626         match &bs_signed_locked[0] {
 627                 MessageSendEvent::SendFundingSigned { node_id, msg } => {
 628                         assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 629                         nodes[0].node.handle_funding_signed(&nodes[1].node.get_our_node_id(), &msg);
 630                         check_added_monitors!(nodes[0], 1);
 631                 }
 632                 _ => panic!("Unexpected event"),
 633         }
 634         match &bs_signed_locked[1] {
 635                 MessageSendEvent::SendChannelReady { node_id, msg } => {
 636                         assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 637                         nodes[0].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &msg);
 638                 }
 639                 _ => panic!("Unexpected event"),
 640         }
 641
 642         assert!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().is_empty());
 643
 644         assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
 645         nodes[0].chain_monitor.complete_sole_pending_chan_update(&channel_id);
 646
 647         let events = nodes[0].node.get_and_clear_pending_events();
 648         assert_eq!(events.len(), 2);
 649         match events[0] {
 650                 crate::events::Event::ChannelPending { ref counterparty_node_id, .. } => {
 651                         assert_eq!(nodes[1].node.get_our_node_id(), *counterparty_node_id);
 652                 },
 653                 _ => panic!("Unexpected event"),
 654         }
 655         match events[1] {
 656                 crate::events::Event::ChannelReady { ref counterparty_node_id, .. } => {
 657                         assert_eq!(nodes[1].node.get_our_node_id(), *counterparty_node_id);
 658                 },
 659                 _ => panic!("Unexpected event"),
 660         }
 661
 662         let as_locked_update = nodes[0].node.get_and_clear_pending_msg_events();
 663
 664         // Note that the funding transaction is actually released when
 665         // get_and_clear_pending_msg_events, above, checks for monitor events.
 666         assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
 667         assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0)[0], tx);
 668
 669         match &as_locked_update[0] {
 670                 MessageSendEvent::SendChannelReady { node_id, msg } => {
 671                         assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 672                         nodes[1].node.handle_channel_ready(&nodes[0].node.get_our_node_id(), &msg);
 673                 }
 674                 _ => panic!("Unexpected event"),
 675         }
 676         expect_channel_ready_event(&nodes[1], &nodes[0].node.get_our_node_id());
 677
 678         let bs_channel_update = get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
 679
 680         let as_channel_update = match &as_locked_update[1] {
 681                 MessageSendEvent::SendChannelUpdate { node_id, msg } => {
 682                         assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 683                         msg.clone()
 684                 }
 685                 _ => panic!("Unexpected event"),
 686         };
 687
 688         chanmon_cfgs[0].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
 689         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
 690
 691         nodes[0].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &bs_channel_update);
 692         nodes[1].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &as_channel_update);
 693
 694         assert_eq!(nodes[0].node.list_usable_channels().len(), 1);
 695         assert_eq!(nodes[1].node.list_usable_channels().len(), 2);
 696
 697         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 698
 699         // Now that we have useful channels, try sending a payment where the we hit a temporary monitor
 700         // failure before we've ever confirmed the funding transaction. This previously caused a panic.
 701         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], 1_000_000);
 702
 703         nodes[0].node.send_payment_with_route(&route, payment_hash,
 704                 RecipientOnionFields::secret_only(payment_secret), PaymentId(payment_hash.0)).unwrap();
 705         check_added_monitors!(nodes[0], 1);
 706
 707         let as_send = SendEvent::from_node(&nodes[0]);
 708         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_send.msgs[0]);
 709         nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_send.commitment_msg);
 710         check_added_monitors!(nodes[1], 1);
 711
 712         let (bs_raa, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 713         nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
 714         check_added_monitors!(nodes[0], 1);
 715
 716         nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_commitment_signed);
 717         check_added_monitors!(nodes[0], 1);
 718
 719         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
 720         nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id()));
 721         check_added_monitors!(nodes[1], 1);
 722         assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 723
 724         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
 725         let (outpoint, _, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&bs_raa.channel_id).unwrap().clone();
 726         nodes[1].chain_monitor.chain_monitor.channel_monitor_updated(outpoint, latest_update).unwrap();
 727         check_added_monitors!(nodes[1], 0);
 728         expect_pending_htlcs_forwardable!(nodes[1]);
 729         check_added_monitors!(nodes[1], 1);
 730
 731         let bs_send = SendEvent::from_node(&nodes[1]);
 732         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &bs_send.msgs[0]);
 733         commitment_signed_dance!(nodes[2], nodes[1], bs_send.commitment_msg, false);
 734         expect_pending_htlcs_forwardable!(nodes[2]);
 735         expect_payment_claimable!(nodes[2], payment_hash, payment_secret, 1_000_000);
 736         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
 737
 738         confirm_transaction(&nodes[0], &tx);
 739         confirm_transaction(&nodes[1], &tx);
 740
 741         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 742 }
 743
 744 #[test]
 745 fn test_0conf_close_no_early_chan_update() {
 746         // Tests that even with a public channel 0conf channel, we don't generate a channel_update on
 747         // closing.
 748         let chanmon_cfgs = create_chanmon_cfgs(2);
 749         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 750         let mut chan_config = test_default_channel_config();
 751         chan_config.manually_accept_inbound_channels = true;
 752
 753         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 754         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 755
 756         // This is the default but we force it on anyway
 757         chan_config.channel_handshake_config.announced_channel = true;
 758         open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
 759
 760         // We can use the channel immediately, but won't generate a channel_update until we get confs
 761         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 762
 763         nodes[0].node.force_close_all_channels_broadcasting_latest_txn();
 764         check_added_monitors!(nodes[0], 1);
 765         check_closed_event!(&nodes[0], 1, ClosureReason::HolderForceClosed);
 766         let _ = get_err_msg(&nodes[0], &nodes[1].node.get_our_node_id());
 767 }
 768
 769 #[test]
 770 fn test_public_0conf_channel() {
 771         // Tests that we will announce a public channel (after confirmation) even if its 0conf.
 772         let chanmon_cfgs = create_chanmon_cfgs(2);
 773         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 774         let mut chan_config = test_default_channel_config();
 775         chan_config.manually_accept_inbound_channels = true;
 776
 777         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 778         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 779
 780         // This is the default but we force it on anyway
 781         chan_config.channel_handshake_config.announced_channel = true;
 782         let (tx, ..) = open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
 783
 784         // We can use the channel immediately, but we can't announce it until we get 6+ confirmations
 785         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 786
 787         let scid = confirm_transaction(&nodes[0], &tx);
 788         let as_announcement_sigs = get_event_msg!(nodes[0], MessageSendEvent::SendAnnouncementSignatures, nodes[1].node.get_our_node_id());
 789         assert_eq!(confirm_transaction(&nodes[1], &tx), scid);
 790         let bs_announcement_sigs = get_event_msg!(nodes[1], MessageSendEvent::SendAnnouncementSignatures, nodes[0].node.get_our_node_id());
 791
 792         nodes[1].node.handle_announcement_signatures(&nodes[0].node.get_our_node_id(), &as_announcement_sigs);
 793         nodes[0].node.handle_announcement_signatures(&nodes[1].node.get_our_node_id(), &bs_announcement_sigs);
 794
 795         let bs_announcement = nodes[1].node.get_and_clear_pending_msg_events();
 796         assert_eq!(bs_announcement.len(), 1);
 797         let announcement;
 798         let bs_update;
 799         match bs_announcement[0] {
 800                 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
 801                         announcement = msg.clone();
 802                         bs_update = update_msg.clone().unwrap();
 803                 },
 804                 _ => panic!("Unexpected event"),
 805         };
 806
 807         let as_announcement = nodes[0].node.get_and_clear_pending_msg_events();
 808         assert_eq!(as_announcement.len(), 1);
 809         match as_announcement[0] {
 810                 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
 811                         assert!(announcement == *msg);
 812                         let update_msg = update_msg.as_ref().unwrap();
 813                         assert_eq!(update_msg.contents.short_channel_id, scid);
 814                         assert_eq!(update_msg.contents.short_channel_id, announcement.contents.short_channel_id);
 815                         assert_eq!(update_msg.contents.short_channel_id, bs_update.contents.short_channel_id);
 816                 },
 817                 _ => panic!("Unexpected event"),
 818         };
 819 }
 820
 821 #[test]
 822 fn test_0conf_channel_reorg() {
 823         // If we accept a 0conf channel, which is then confirmed, but then changes SCID in a reorg, we
 824         // have to make sure we handle this correctly (or, currently, just force-close the channel).
 825
 826         let chanmon_cfgs = create_chanmon_cfgs(2);
 827         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 828         let mut chan_config = test_default_channel_config();
 829         chan_config.manually_accept_inbound_channels = true;
 830
 831         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 832         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 833
 834         // This is the default but we force it on anyway
 835         chan_config.channel_handshake_config.announced_channel = true;
 836         let (tx, ..) = open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
 837
 838         // We can use the channel immediately, but we can't announce it until we get 6+ confirmations
 839         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 840
 841         mine_transaction(&nodes[0], &tx);
 842         mine_transaction(&nodes[1], &tx);
 843
 844         // Send a payment using the channel's real SCID, which will be public in a few blocks once we
 845         // can generate a channel_announcement.
 846         let real_scid = nodes[0].node.list_usable_channels()[0].short_channel_id.unwrap();
 847         assert_eq!(nodes[1].node.list_usable_channels()[0].short_channel_id.unwrap(), real_scid);
 848
 849         let (mut route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[1], 10_000);
 850         assert_eq!(route.paths[0].hops[0].short_channel_id, real_scid);
 851         send_along_route_with_secret(&nodes[0], route, &[&[&nodes[1]]], 10_000, payment_hash, payment_secret);
 852         claim_payment(&nodes[0], &[&nodes[1]], payment_preimage);
 853
 854         disconnect_blocks(&nodes[0], 1);
 855         disconnect_blocks(&nodes[1], 1);
 856
 857         // At this point the channel no longer has an SCID again. In the future we should likely
 858         // support simply un-setting the SCID and waiting until the channel gets re-confirmed, but for
 859         // now we force-close the channel here.
 860         check_closed_event!(&nodes[0], 1, ClosureReason::ProcessingError {
 861                 err: "Funding transaction was un-confirmed. Locked at 0 confs, now have 0 confs.".to_owned()
 862         });
 863         check_closed_broadcast!(nodes[0], true);
 864         check_added_monitors(&nodes[0], 1);
 865         check_closed_event!(&nodes[1], 1, ClosureReason::ProcessingError {
 866                 err: "Funding transaction was un-confirmed. Locked at 0 confs, now have 0 confs.".to_owned()
 867         });
 868         check_closed_broadcast!(nodes[1], true);
 869         check_added_monitors(&nodes[1], 1);
 870 }
 871
 872 #[test]
 873 fn test_zero_conf_accept_reject() {
 874         let mut channel_type_features = ChannelTypeFeatures::only_static_remote_key();
 875         channel_type_features.set_zero_conf_required();
 876
 877         // 1. Check we reject zero conf channels by default
 878         let chanmon_cfgs = create_chanmon_cfgs(2);
 879         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 880         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
 881         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 882
 883         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
 884         let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 885
 886         open_channel_msg.channel_type = Some(channel_type_features.clone());
 887
 888         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
 889
 890         let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 891         match msg_events[0] {
 892                 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg, .. }, .. } => {
 893                         assert_eq!(msg.data, "No zero confirmation channels accepted".to_owned());
 894                 },
 895                 _ => panic!(),
 896         }
 897
 898         // 2. Check we can manually accept zero conf channels via the right method
 899         let mut manually_accept_conf = UserConfig::default();
 900         manually_accept_conf.manually_accept_inbound_channels = true;
 901
 902         let chanmon_cfgs = create_chanmon_cfgs(2);
 903         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 904         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs,
 905                 &[None, Some(manually_accept_conf.clone())]);
 906         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 907
 908         // 2.1 First try the non-0conf method to manually accept
 909         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42,
 910                 Some(manually_accept_conf)).unwrap();
 911         let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel,
 912                 nodes[1].node.get_our_node_id());
 913
 914         open_channel_msg.channel_type = Some(channel_type_features.clone());
 915
 916         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
 917
 918         // Assert that `nodes[1]` has no `MessageSendEvent::SendAcceptChannel` in the `msg_events`.
 919         assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 920
 921         let events = nodes[1].node.get_and_clear_pending_events();
 922
 923         match events[0] {
 924                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 925                         // Assert we fail to accept via the non-0conf method
 926                         assert!(nodes[1].node.accept_inbound_channel(&temporary_channel_id,
 927                                 &nodes[0].node.get_our_node_id(), 0).is_err());
 928                 },
 929                 _ => panic!(),
 930         }
 931
 932         let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 933         match msg_events[0] {
 934                 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg, .. }, .. } => {
 935                         assert_eq!(msg.data, "No zero confirmation channels accepted".to_owned());
 936                 },
 937                 _ => panic!(),
 938         }
 939
 940         // 2.2 Try again with the 0conf method to manually accept
 941         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42,
 942                 Some(manually_accept_conf)).unwrap();
 943         let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel,
 944                 nodes[1].node.get_our_node_id());
 945
 946         open_channel_msg.channel_type = Some(channel_type_features);
 947
 948         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
 949
 950         let events = nodes[1].node.get_and_clear_pending_events();
 951
 952         match events[0] {
 953                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 954                         // Assert we can accept via the 0conf method
 955                         assert!(nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(
 956                                 &temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).is_ok());
 957                 },
 958                 _ => panic!(),
 959         }
 960
 961         // Check we would send accept
 962         let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 963         match msg_events[0] {
 964                 MessageSendEvent::SendAcceptChannel { .. } => {},
 965                 _ => panic!(),
 966         }
 967 }
 968
 969 #[test]
 970 fn test_connect_before_funding() {
 971         // Tests for a particularly dumb explicit panic that existed prior to 0.0.111 for 0conf
 972         // channels. If we received a block while awaiting funding for 0-conf channels we'd hit an
 973         // explicit panic when deciding if we should broadcast our channel_ready message.
 974         let chanmon_cfgs = create_chanmon_cfgs(2);
 975         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 976
 977         let mut manually_accept_conf = test_default_channel_config();
 978         manually_accept_conf.manually_accept_inbound_channels = true;
 979
 980         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(manually_accept_conf)]);
 981         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 982
 983         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100_000, 10_001, 42, None).unwrap();
 984         let open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 985
 986         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
 987         let events = nodes[1].node.get_and_clear_pending_events();
 988         assert_eq!(events.len(), 1);
 989         match events[0] {
 990                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 991                         nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(&temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).unwrap();
 992                 },
 993                 _ => panic!("Unexpected event"),
 994         };
 995
 996         let mut accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
 997         assert_eq!(accept_channel.minimum_depth, 0);
 998         nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &accept_channel);
 999
1000         let events = nodes[0].node.get_and_clear_pending_events();
1001         assert_eq!(events.len(), 1);
1002         match events[0] {
1003                 Event::FundingGenerationReady { .. } => {},
1004                 _ => panic!("Unexpected event"),
1005         }
1006
1007         connect_blocks(&nodes[0], 1);
1008         connect_blocks(&nodes[1], 1);
1009 }