_ Git - rust-lightning/blob - lightning/src/ln/priv_short_conf_tests.rs

   1 // This file is Copyright its original authors, visible in version control
   2 // history.
   3 //
   4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
   5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
   6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
   7 // You may not use this file except in accordance with one or both of these
   8 // licenses.
   9
  10 //! Tests that test ChannelManager behavior with fewer confirmations required than the default and
  11 //! other behavior that exists only on private channels or with a semi-trusted counterparty (eg
  12 //! LSP).
  13
  14 use crate::chain::ChannelMonitorUpdateStatus;
  15 use crate::chain::keysinterface::{Recipient, NodeSigner};
  16 use crate::ln::channelmanager::{ChannelManager, MIN_CLTV_EXPIRY_DELTA, PaymentId};
  17 use crate::routing::gossip::RoutingFees;
  18 use crate::routing::router::{PaymentParameters, RouteHint, RouteHintHop};
  19 use crate::ln::features::ChannelTypeFeatures;
  20 use crate::ln::msgs;
  21 use crate::ln::msgs::{ChannelMessageHandler, RoutingMessageHandler, ChannelUpdate, ErrorAction};
  22 use crate::ln::wire::Encode;
  23 use crate::util::events::{ClosureReason, Event, HTLCDestination, MessageSendEvent, MessageSendEventsProvider};
  24 use crate::util::config::UserConfig;
  25 use crate::util::ser::Writeable;
  26 use crate::util::test_utils;
  27
  28 use crate::prelude::*;
  29 use core::default::Default;
  30
  31 use crate::ln::functional_test_utils::*;
  32
  33 use bitcoin::blockdata::constants::genesis_block;
  34 use bitcoin::hashes::Hash;
  35 use bitcoin::hashes::sha256d::Hash as Sha256dHash;
  36 use bitcoin::network::constants::Network;
  37 use bitcoin::secp256k1::Secp256k1;
  38
  39 #[test]
  40 fn test_priv_forwarding_rejection() {
  41         // If we have a private channel with outbound liquidity, and
  42         // UserConfig::accept_forwards_to_priv_channels is set to false, we should reject any attempts
  43         // to forward through that channel.
  44         let chanmon_cfgs = create_chanmon_cfgs(3);
  45         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
  46         let mut no_announce_cfg = test_default_channel_config();
  47         no_announce_cfg.accept_forwards_to_priv_channels = false;
  48         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(no_announce_cfg), None]);
  49         let persister: test_utils::TestPersister;
  50         let new_chain_monitor: test_utils::TestChainMonitor;
  51         let nodes_1_deserialized: ChannelManager<&test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestRouter, &test_utils::TestLogger>;
  52         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
  53
  54         let chan_id_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000).2;
  55         let chan_id_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 500_000_000).0.channel_id;
  56
  57         // We should always be able to forward through nodes[1] as long as its out through a public
  58         // channel:
  59         send_payment(&nodes[2], &[&nodes[1], &nodes[0]], 10_000);
  60
  61         // ... however, if we send to nodes[2], we will have to pass the private channel from nodes[1]
  62         // to nodes[2], which should be rejected:
  63         let route_hint = RouteHint(vec![RouteHintHop {
  64                 src_node_id: nodes[1].node.get_our_node_id(),
  65                 short_channel_id: nodes[2].node.list_channels()[0].short_channel_id.unwrap(),
  66                 fees: RoutingFees { base_msat: 1000, proportional_millionths: 0 },
  67                 cltv_expiry_delta: MIN_CLTV_EXPIRY_DELTA,
  68                 htlc_minimum_msat: None,
  69                 htlc_maximum_msat: None,
  70         }]);
  71         let last_hops = vec![route_hint];
  72         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id())
  73                 .with_features(nodes[2].node.invoice_features())
  74                 .with_route_hints(last_hops);
  75         let (route, our_payment_hash, our_payment_preimage, our_payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 10_000, TEST_FINAL_CLTV);
  76
  77         nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret), PaymentId(our_payment_hash.0)).unwrap();
  78         check_added_monitors!(nodes[0], 1);
  79         let payment_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
  80         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
  81         commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false, true);
  82
  83         let htlc_fail_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
  84         assert!(htlc_fail_updates.update_add_htlcs.is_empty());
  85         assert_eq!(htlc_fail_updates.update_fail_htlcs.len(), 1);
  86         assert!(htlc_fail_updates.update_fail_malformed_htlcs.is_empty());
  87         assert!(htlc_fail_updates.update_fee.is_none());
  88
  89         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_fail_updates.update_fail_htlcs[0]);
  90         commitment_signed_dance!(nodes[0], nodes[1], htlc_fail_updates.commitment_signed, true, true);
  91         expect_payment_failed_with_update!(nodes[0], our_payment_hash, false, nodes[2].node.list_channels()[0].short_channel_id.unwrap(), true);
  92
  93         // Now disconnect nodes[1] from its peers and restart with accept_forwards_to_priv_channels set
  94         // to true. Sadly there is currently no way to change it at runtime.
  95
  96         nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
  97         nodes[2].node.peer_disconnected(&nodes[1].node.get_our_node_id(), false);
  98
  99         let nodes_1_serialized = nodes[1].node.encode();
 100         let monitor_a_serialized = get_monitor!(nodes[1], chan_id_1).encode();
 101         let monitor_b_serialized = get_monitor!(nodes[1], chan_id_2).encode();
 102
 103         no_announce_cfg.accept_forwards_to_priv_channels = true;
 104         reload_node!(nodes[1], no_announce_cfg, &nodes_1_serialized, &[&monitor_a_serialized, &monitor_b_serialized], persister, new_chain_monitor, nodes_1_deserialized);
 105
 106         nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: nodes[1].node.init_features(), remote_network_address: None }).unwrap();
 107         nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: nodes[0].node.init_features(), remote_network_address: None }).unwrap();
 108         let as_reestablish = get_chan_reestablish_msgs!(nodes[0], nodes[1]).pop().unwrap();
 109         let bs_reestablish = get_chan_reestablish_msgs!(nodes[1], nodes[0]).pop().unwrap();
 110         nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &as_reestablish);
 111         nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
 112         get_event_msg!(nodes[0], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 113         get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
 114
 115         nodes[1].node.peer_connected(&nodes[2].node.get_our_node_id(), &msgs::Init { features: nodes[2].node.init_features(), remote_network_address: None }).unwrap();
 116         nodes[2].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: nodes[1].node.init_features(), remote_network_address: None }).unwrap();
 117         let bs_reestablish = get_chan_reestablish_msgs!(nodes[1], nodes[2]).pop().unwrap();
 118         let cs_reestablish = get_chan_reestablish_msgs!(nodes[2], nodes[1]).pop().unwrap();
 119         nodes[2].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
 120         nodes[1].node.handle_channel_reestablish(&nodes[2].node.get_our_node_id(), &cs_reestablish);
 121         get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
 122         get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 123
 124         nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret), PaymentId(our_payment_hash.0)).unwrap();
 125         check_added_monitors!(nodes[0], 1);
 126         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 10_000, our_payment_hash, our_payment_secret);
 127         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], our_payment_preimage);
 128 }
 129
 130 fn do_test_1_conf_open(connect_style: ConnectStyle) {
 131         // Previously, if the minium_depth config was set to 1, we'd never send a channel_ready. This
 132         // tests that we properly send one in that case.
 133         let mut alice_config = UserConfig::default();
 134         alice_config.channel_handshake_config.minimum_depth = 1;
 135         alice_config.channel_handshake_config.announced_channel = true;
 136         alice_config.channel_handshake_limits.force_announced_channel_preference = false;
 137         let mut bob_config = UserConfig::default();
 138         bob_config.channel_handshake_config.minimum_depth = 1;
 139         bob_config.channel_handshake_config.announced_channel = true;
 140         bob_config.channel_handshake_limits.force_announced_channel_preference = false;
 141         let chanmon_cfgs = create_chanmon_cfgs(2);
 142         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 143         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[Some(alice_config), Some(bob_config)]);
 144         let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 145         *nodes[0].connect_style.borrow_mut() = connect_style;
 146
 147         let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001);
 148         mine_transaction(&nodes[1], &tx);
 149         nodes[0].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendChannelReady, nodes[0].node.get_our_node_id()));
 150         assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
 151
 152         mine_transaction(&nodes[0], &tx);
 153         let as_msg_events = nodes[0].node.get_and_clear_pending_msg_events();
 154         assert_eq!(as_msg_events.len(), 2);
 155         let as_channel_ready = if let MessageSendEvent::SendChannelReady { ref node_id, ref msg } = as_msg_events[0] {
 156                 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 157                 msg.clone()
 158         } else { panic!("Unexpected event"); };
 159         if let MessageSendEvent::SendChannelUpdate { ref node_id, msg: _ } = as_msg_events[1] {
 160                 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 161         } else { panic!("Unexpected event"); }
 162
 163         nodes[1].node.handle_channel_ready(&nodes[0].node.get_our_node_id(), &as_channel_ready);
 164         expect_channel_ready_event(&nodes[0], &nodes[1].node.get_our_node_id());
 165         expect_channel_ready_event(&nodes[1], &nodes[0].node.get_our_node_id());
 166         let bs_msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 167         assert_eq!(bs_msg_events.len(), 1);
 168         if let MessageSendEvent::SendChannelUpdate { ref node_id, msg: _ } = bs_msg_events[0] {
 169                 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 170         } else { panic!("Unexpected event"); }
 171
 172         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 173
 174         // After 6 confirmations, as required by the spec, we'll send announcement_signatures and
 175         // broadcast the channel_announcement (but not before exactly 6 confirmations).
 176         connect_blocks(&nodes[0], 4);
 177         assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
 178         connect_blocks(&nodes[0], 1);
 179         nodes[1].node.handle_announcement_signatures(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendAnnouncementSignatures, nodes[1].node.get_our_node_id()));
 180         assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 181
 182         connect_blocks(&nodes[1], 5);
 183         let bs_announce_events = nodes[1].node.get_and_clear_pending_msg_events();
 184         assert_eq!(bs_announce_events.len(), 2);
 185         let bs_announcement_sigs = if let MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } = bs_announce_events[0] {
 186                 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 187                 msg.clone()
 188         } else { panic!("Unexpected event"); };
 189         let (bs_announcement, bs_update) = if let MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } = bs_announce_events[1] {
 190                 (msg.clone(), update_msg.clone())
 191         } else { panic!("Unexpected event"); };
 192
 193         nodes[0].node.handle_announcement_signatures(&nodes[1].node.get_our_node_id(), &bs_announcement_sigs);
 194         let as_announce_events = nodes[0].node.get_and_clear_pending_msg_events();
 195         assert_eq!(as_announce_events.len(), 1);
 196         let (announcement, as_update) = if let MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } = as_announce_events[0] {
 197                 (msg.clone(), update_msg.clone())
 198         } else { panic!("Unexpected event"); };
 199         assert_eq!(announcement, bs_announcement);
 200
 201         for node in nodes {
 202                 assert!(node.gossip_sync.handle_channel_announcement(&announcement).unwrap());
 203                 node.gossip_sync.handle_channel_update(&as_update).unwrap();
 204                 node.gossip_sync.handle_channel_update(&bs_update).unwrap();
 205         }
 206 }
 207 #[test]
 208 fn test_1_conf_open() {
 209         do_test_1_conf_open(ConnectStyle::BestBlockFirst);
 210         do_test_1_conf_open(ConnectStyle::TransactionsFirst);
 211         do_test_1_conf_open(ConnectStyle::FullBlockViaListen);
 212 }
 213
 214 #[test]
 215 fn test_routed_scid_alias() {
 216         // Trivially test sending a payment which is routed through an SCID alias.
 217         let chanmon_cfgs = create_chanmon_cfgs(3);
 218         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 219         let mut no_announce_cfg = test_default_channel_config();
 220         no_announce_cfg.accept_forwards_to_priv_channels = true;
 221         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(no_announce_cfg), None]);
 222         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 223
 224         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000).2;
 225         let mut as_channel_ready = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 500_000_000).0;
 226
 227         let last_hop = nodes[2].node.list_usable_channels();
 228         let hop_hints = vec![RouteHint(vec![RouteHintHop {
 229                 src_node_id: nodes[1].node.get_our_node_id(),
 230                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 231                 fees: RoutingFees {
 232                         base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 233                         proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 234                 },
 235                 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
 236                 htlc_maximum_msat: None,
 237                 htlc_minimum_msat: None,
 238         }])];
 239         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id())
 240                 .with_features(nodes[2].node.invoice_features())
 241                 .with_route_hints(hop_hints);
 242         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 100_000, 42);
 243         assert_eq!(route.paths[0][1].short_channel_id, last_hop[0].inbound_scid_alias.unwrap());
 244         nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
 245         check_added_monitors!(nodes[0], 1);
 246
 247         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 100_000, payment_hash, payment_secret);
 248         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
 249
 250         // Now test that if a peer sends us a second channel_ready after the channel is operational we
 251         // will use the new alias.
 252         as_channel_ready.short_channel_id_alias = Some(0xdeadbeef);
 253         nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &as_channel_ready);
 254         // Note that we always respond to a channel_ready with a channel_update. Not a lot of reason
 255         // to bother updating that code, so just drop the message here.
 256         get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 257         let updated_channel_info = nodes[2].node.list_usable_channels();
 258         assert_eq!(updated_channel_info.len(), 1);
 259         assert_eq!(updated_channel_info[0].inbound_scid_alias.unwrap(), 0xdeadbeef);
 260         // Note that because we never send a duplicate channel_ready we can't send a payment through
 261         // the 0xdeadbeef SCID alias.
 262 }
 263
 264 #[test]
 265 fn test_scid_privacy_on_pub_channel() {
 266         // Tests rejecting the scid_privacy feature for public channels and that we don't ever try to
 267         // send them.
 268         let chanmon_cfgs = create_chanmon_cfgs(2);
 269         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 270         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
 271         let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 272
 273         let mut scid_privacy_cfg = test_default_channel_config();
 274         scid_privacy_cfg.channel_handshake_config.announced_channel = true;
 275         scid_privacy_cfg.channel_handshake_config.negotiate_scid_privacy = true;
 276         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(scid_privacy_cfg)).unwrap();
 277         let mut open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 278
 279         assert!(!open_channel.channel_type.as_ref().unwrap().supports_scid_privacy()); // we ignore `negotiate_scid_privacy` on pub channels
 280         open_channel.channel_type.as_mut().unwrap().set_scid_privacy_required();
 281         assert_eq!(open_channel.channel_flags & 1, 1); // The `announce_channel` bit is set.
 282
 283         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
 284         let err = get_err_msg!(nodes[1], nodes[0].node.get_our_node_id());
 285         assert_eq!(err.data, "SCID Alias/Privacy Channel Type cannot be set on a public channel");
 286 }
 287
 288 #[test]
 289 fn test_scid_privacy_negotiation() {
 290         // Tests of the negotiation of SCID alias and falling back to non-SCID-alias if our
 291         // counterparty doesn't support it.
 292         let chanmon_cfgs = create_chanmon_cfgs(2);
 293         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 294         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
 295         let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 296
 297         let mut scid_privacy_cfg = test_default_channel_config();
 298         scid_privacy_cfg.channel_handshake_config.announced_channel = false;
 299         scid_privacy_cfg.channel_handshake_config.negotiate_scid_privacy = true;
 300         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(scid_privacy_cfg)).unwrap();
 301
 302         let init_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 303         assert!(init_open_channel.channel_type.as_ref().unwrap().supports_scid_privacy());
 304         assert!(nodes[0].node.list_channels()[0].channel_type.is_none()); // channel_type is none until counterparty accepts
 305
 306         // now simulate nodes[1] responding with an Error message, indicating it doesn't understand
 307         // SCID alias.
 308         nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage {
 309                 channel_id: init_open_channel.temporary_channel_id,
 310                 data: "Yo, no SCID aliases, no privacy here!".to_string()
 311         });
 312         assert!(nodes[0].node.list_channels()[0].channel_type.is_none()); // channel_type is none until counterparty accepts
 313
 314         let second_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 315         assert!(!second_open_channel.channel_type.as_ref().unwrap().supports_scid_privacy());
 316         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &second_open_channel);
 317         nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id()));
 318
 319         let events = nodes[0].node.get_and_clear_pending_events();
 320         assert_eq!(events.len(), 1);
 321         match events[0] {
 322                 Event::FundingGenerationReady { .. } => {},
 323                 _ => panic!("Unexpected event"),
 324         }
 325
 326         assert!(!nodes[0].node.list_channels()[0].channel_type.as_ref().unwrap().supports_scid_privacy());
 327         assert!(!nodes[1].node.list_channels()[0].channel_type.as_ref().unwrap().supports_scid_privacy());
 328 }
 329
 330 #[test]
 331 fn test_inbound_scid_privacy() {
 332         // Tests accepting channels with the scid_privacy feature and rejecting forwards using the
 333         // channel's real SCID as required by the channel feature.
 334         let chanmon_cfgs = create_chanmon_cfgs(3);
 335         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 336         let mut accept_forward_cfg = test_default_channel_config();
 337         accept_forward_cfg.accept_forwards_to_priv_channels = true;
 338         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(accept_forward_cfg), None]);
 339         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 340
 341         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
 342
 343         let mut no_announce_cfg = test_default_channel_config();
 344         no_announce_cfg.channel_handshake_config.announced_channel = false;
 345         no_announce_cfg.channel_handshake_config.negotiate_scid_privacy = true;
 346         nodes[1].node.create_channel(nodes[2].node.get_our_node_id(), 100_000, 10_000, 42, Some(no_announce_cfg)).unwrap();
 347         let mut open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[2].node.get_our_node_id());
 348
 349         assert!(open_channel.channel_type.as_ref().unwrap().requires_scid_privacy());
 350
 351         nodes[2].node.handle_open_channel(&nodes[1].node.get_our_node_id(), &open_channel);
 352         let accept_channel = get_event_msg!(nodes[2], MessageSendEvent::SendAcceptChannel, nodes[1].node.get_our_node_id());
 353         nodes[1].node.handle_accept_channel(&nodes[2].node.get_our_node_id(), &accept_channel);
 354
 355         let (temporary_channel_id, tx, _) = create_funding_transaction(&nodes[1], &nodes[2].node.get_our_node_id(), 100_000, 42);
 356         nodes[1].node.funding_transaction_generated(&temporary_channel_id, &nodes[2].node.get_our_node_id(), tx.clone()).unwrap();
 357         nodes[2].node.handle_funding_created(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendFundingCreated, nodes[2].node.get_our_node_id()));
 358         check_added_monitors!(nodes[2], 1);
 359
 360         let cs_funding_signed = get_event_msg!(nodes[2], MessageSendEvent::SendFundingSigned, nodes[1].node.get_our_node_id());
 361         nodes[1].node.handle_funding_signed(&nodes[2].node.get_our_node_id(), &cs_funding_signed);
 362         check_added_monitors!(nodes[1], 1);
 363
 364         let conf_height = core::cmp::max(nodes[1].best_block_info().1 + 1, nodes[2].best_block_info().1 + 1);
 365         confirm_transaction_at(&nodes[1], &tx, conf_height);
 366         connect_blocks(&nodes[1], CHAN_CONFIRM_DEPTH - 1);
 367         confirm_transaction_at(&nodes[2], &tx, conf_height);
 368         connect_blocks(&nodes[2], CHAN_CONFIRM_DEPTH - 1);
 369         let bs_channel_ready = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReady, nodes[2].node.get_our_node_id());
 370         nodes[1].node.handle_channel_ready(&nodes[2].node.get_our_node_id(), &get_event_msg!(nodes[2], MessageSendEvent::SendChannelReady, nodes[1].node.get_our_node_id()));
 371         expect_channel_ready_event(&nodes[1], &nodes[2].node.get_our_node_id());
 372         let bs_update = get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
 373         nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &bs_channel_ready);
 374         expect_channel_ready_event(&nodes[2], &nodes[1].node.get_our_node_id());
 375         let cs_update = get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 376
 377         nodes[1].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &cs_update);
 378         nodes[2].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &bs_update);
 379
 380         // Now we can pay just fine using the SCID alias nodes[2] gave to nodes[1]...
 381
 382         let last_hop = nodes[2].node.list_usable_channels();
 383         let mut hop_hints = vec![RouteHint(vec![RouteHintHop {
 384                 src_node_id: nodes[1].node.get_our_node_id(),
 385                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 386                 fees: RoutingFees {
 387                         base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 388                         proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 389                 },
 390                 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
 391                 htlc_maximum_msat: None,
 392                 htlc_minimum_msat: None,
 393         }])];
 394         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id())
 395                 .with_features(nodes[2].node.invoice_features())
 396                 .with_route_hints(hop_hints.clone());
 397         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 100_000, 42);
 398         assert_eq!(route.paths[0][1].short_channel_id, last_hop[0].inbound_scid_alias.unwrap());
 399         nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
 400         check_added_monitors!(nodes[0], 1);
 401
 402         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 100_000, payment_hash, payment_secret);
 403         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
 404
 405         // ... but if we try to pay using the real SCID, nodes[1] will just tell us they don't know
 406         // what channel we're talking about.
 407         hop_hints[0].0[0].short_channel_id = last_hop[0].short_channel_id.unwrap();
 408
 409         let payment_params_2 = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id())
 410                 .with_features(nodes[2].node.invoice_features())
 411                 .with_route_hints(hop_hints);
 412         let (route_2, payment_hash_2, _, payment_secret_2) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params_2, 100_000, 42);
 413         assert_eq!(route_2.paths[0][1].short_channel_id, last_hop[0].short_channel_id.unwrap());
 414         nodes[0].node.send_payment(&route_2, payment_hash_2, &Some(payment_secret_2), PaymentId(payment_hash_2.0)).unwrap();
 415         check_added_monitors!(nodes[0], 1);
 416
 417         let payment_event = SendEvent::from_node(&nodes[0]);
 418         assert_eq!(nodes[1].node.get_our_node_id(), payment_event.node_id);
 419         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
 420         commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, true, true);
 421
 422         nodes[1].logger.assert_log_regex("lightning::ln::channelmanager".to_string(), regex::Regex::new(r"Refusing to forward over real channel SCID as our counterparty requested").unwrap(), 1);
 423
 424         let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 425         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
 426         commitment_signed_dance!(nodes[0], nodes[1], updates.commitment_signed, false);
 427
 428         expect_payment_failed_conditions(&nodes[0], payment_hash_2, false,
 429                 PaymentFailedConditions::new().blamed_scid(last_hop[0].short_channel_id.unwrap())
 430                         .blamed_chan_closed(true).expected_htlc_error_data(0x4000|10, &[0; 0]));
 431 }
 432
 433 #[test]
 434 fn test_scid_alias_returned() {
 435         // Tests that when we fail an HTLC (in this case due to attempting to forward more than the
 436         // channel's available balance) we use the correct (in this case the aliased) SCID in the
 437         // channel_update which is returned in the onion to the sender.
 438         let chanmon_cfgs = create_chanmon_cfgs(3);
 439         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 440         let mut accept_forward_cfg = test_default_channel_config();
 441         accept_forward_cfg.accept_forwards_to_priv_channels = true;
 442         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(accept_forward_cfg), None]);
 443         let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 444
 445         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 10_000_000, 0);
 446         let chan = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 10_000, 0);
 447
 448         let last_hop = nodes[2].node.list_usable_channels();
 449         let mut hop_hints = vec![RouteHint(vec![RouteHintHop {
 450                 src_node_id: nodes[1].node.get_our_node_id(),
 451                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 452                 fees: RoutingFees {
 453                         base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 454                         proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 455                 },
 456                 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
 457                 htlc_maximum_msat: None,
 458                 htlc_minimum_msat: None,
 459         }])];
 460         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id())
 461                 .with_features(nodes[2].node.invoice_features())
 462                 .with_route_hints(hop_hints);
 463         let (mut route, payment_hash, _, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 10_000, 42);
 464         assert_eq!(route.paths[0][1].short_channel_id, nodes[2].node.list_usable_channels()[0].inbound_scid_alias.unwrap());
 465
 466         route.paths[0][1].fee_msat = 10_000_000; // Overshoot the last channel's value
 467
 468         // Route the HTLC through to the destination.
 469         nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
 470         check_added_monitors!(nodes[0], 1);
 471         let as_updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
 472         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_updates.update_add_htlcs[0]);
 473         commitment_signed_dance!(nodes[1], nodes[0], &as_updates.commitment_signed, false, true);
 474
 475         expect_pending_htlcs_forwardable!(nodes[1]);
 476         expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCDestination::NextHopChannel { node_id: Some(nodes[2].node.get_our_node_id()), channel_id: chan.0.channel_id }]);
 477         check_added_monitors!(nodes[1], 1);
 478
 479         let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 480         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
 481         commitment_signed_dance!(nodes[0], nodes[1], bs_updates.commitment_signed, false, true);
 482
 483         // Build the expected channel update
 484         let contents = msgs::UnsignedChannelUpdate {
 485                 chain_hash: genesis_block(Network::Testnet).header.block_hash(),
 486                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 487                 timestamp: 21,
 488                 flags: 1,
 489                 cltv_expiry_delta: accept_forward_cfg.channel_config.cltv_expiry_delta,
 490                 htlc_minimum_msat: 1_000,
 491                 htlc_maximum_msat: 1_000_000, // Defaults to 10% of the channel value
 492                 fee_base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 493                 fee_proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 494                 excess_data: Vec::new(),
 495         };
 496         let msg_hash = Sha256dHash::hash(&contents.encode()[..]);
 497         let signature = Secp256k1::new().sign_ecdsa(&hash_to_message!(&msg_hash[..]), &nodes[1].keys_manager.get_node_secret(Recipient::Node).unwrap());
 498         let msg = msgs::ChannelUpdate { signature, contents };
 499
 500         let mut err_data = Vec::new();
 501         err_data.extend_from_slice(&(msg.serialized_length() as u16 + 2).to_be_bytes());
 502         err_data.extend_from_slice(&ChannelUpdate::TYPE.to_be_bytes());
 503         err_data.extend_from_slice(&msg.encode());
 504
 505         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
 506                 PaymentFailedConditions::new().blamed_scid(last_hop[0].inbound_scid_alias.unwrap())
 507                         .blamed_chan_closed(false).expected_htlc_error_data(0x1000|7, &err_data));
 508
 509         route.paths[0][1].fee_msat = 10_000; // Reset to the correct payment amount
 510         route.paths[0][0].fee_msat = 0; // But set fee paid to the middle hop to 0
 511
 512         // Route the HTLC through to the destination.
 513         nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
 514         check_added_monitors!(nodes[0], 1);
 515         let as_updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
 516         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_updates.update_add_htlcs[0]);
 517         commitment_signed_dance!(nodes[1], nodes[0], &as_updates.commitment_signed, false, true);
 518
 519         let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 520         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
 521         commitment_signed_dance!(nodes[0], nodes[1], bs_updates.commitment_signed, false, true);
 522
 523         let mut err_data = Vec::new();
 524         err_data.extend_from_slice(&10_000u64.to_be_bytes());
 525         err_data.extend_from_slice(&(msg.serialized_length() as u16 + 2).to_be_bytes());
 526         err_data.extend_from_slice(&ChannelUpdate::TYPE.to_be_bytes());
 527         err_data.extend_from_slice(&msg.encode());
 528         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
 529                 PaymentFailedConditions::new().blamed_scid(last_hop[0].inbound_scid_alias.unwrap())
 530                         .blamed_chan_closed(false).expected_htlc_error_data(0x1000|12, &err_data));
 531 }
 532
 533 #[test]
 534 fn test_simple_0conf_channel() {
 535         // If our peer tells us they will accept our channel with 0 confs, and we funded the channel,
 536         // we should trust the funding won't be double-spent (assuming `trust_own_funding_0conf` is
 537         // set)!
 538         // Further, if we `accept_inbound_channel_from_trusted_peer_0conf`, `channel_ready` messages
 539         // should fly immediately and the channel should be available for use as soon as they are
 540         // received.
 541
 542         let chanmon_cfgs = create_chanmon_cfgs(2);
 543         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 544         let mut chan_config = test_default_channel_config();
 545         chan_config.manually_accept_inbound_channels = true;
 546
 547         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 548         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 549
 550         open_zero_conf_channel(&nodes[0], &nodes[1], None);
 551
 552         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 553 }
 554
 555 #[test]
 556 fn test_0conf_channel_with_async_monitor() {
 557         // Test that we properly send out channel_ready in (both inbound- and outbound-) zero-conf
 558         // channels if ChannelMonitor updates return a `TemporaryFailure` during the initial channel
 559         // negotiation.
 560
 561         let chanmon_cfgs = create_chanmon_cfgs(3);
 562         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 563         let mut chan_config = test_default_channel_config();
 564         chan_config.manually_accept_inbound_channels = true;
 565         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(chan_config), None]);
 566         let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 567
 568         create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0);
 569
 570         chan_config.channel_handshake_config.announced_channel = false;
 571         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(chan_config)).unwrap();
 572         let open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 573
 574         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
 575         let events = nodes[1].node.get_and_clear_pending_events();
 576         assert_eq!(events.len(), 1);
 577         match events[0] {
 578                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 579                         nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(&temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).unwrap();
 580                 },
 581                 _ => panic!("Unexpected event"),
 582         };
 583
 584         let mut accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
 585         assert_eq!(accept_channel.minimum_depth, 0);
 586         nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &accept_channel);
 587
 588         let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&nodes[0], &nodes[1].node.get_our_node_id(), 100000, 42);
 589         nodes[0].node.funding_transaction_generated(&temporary_channel_id, &nodes[1].node.get_our_node_id(), tx.clone()).unwrap();
 590         let funding_created = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
 591
 592         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
 593         nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created);
 594         check_added_monitors!(nodes[1], 1);
 595         assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
 596
 597         let channel_id = funding_output.to_channel_id();
 598         nodes[1].chain_monitor.complete_sole_pending_chan_update(&channel_id);
 599
 600         let bs_signed_locked = nodes[1].node.get_and_clear_pending_msg_events();
 601         assert_eq!(bs_signed_locked.len(), 2);
 602         chanmon_cfgs[0].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
 603
 604         match &bs_signed_locked[0] {
 605                 MessageSendEvent::SendFundingSigned { node_id, msg } => {
 606                         assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 607                         nodes[0].node.handle_funding_signed(&nodes[1].node.get_our_node_id(), &msg);
 608                         check_added_monitors!(nodes[0], 1);
 609                 }
 610                 _ => panic!("Unexpected event"),
 611         }
 612         match &bs_signed_locked[1] {
 613                 MessageSendEvent::SendChannelReady { node_id, msg } => {
 614                         assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 615                         nodes[0].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &msg);
 616                 }
 617                 _ => panic!("Unexpected event"),
 618         }
 619
 620         assert!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().is_empty());
 621
 622         assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
 623         nodes[0].chain_monitor.complete_sole_pending_chan_update(&channel_id);
 624         let as_locked_update = nodes[0].node.get_and_clear_pending_msg_events();
 625
 626         // Note that the funding transaction is actually released when
 627         // get_and_clear_pending_msg_events, above, checks for monitor events.
 628         assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
 629         assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0)[0], tx);
 630
 631         match &as_locked_update[0] {
 632                 MessageSendEvent::SendChannelReady { node_id, msg } => {
 633                         assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 634                         nodes[1].node.handle_channel_ready(&nodes[0].node.get_our_node_id(), &msg);
 635                 }
 636                 _ => panic!("Unexpected event"),
 637         }
 638         expect_channel_ready_event(&nodes[0], &nodes[1].node.get_our_node_id());
 639         expect_channel_ready_event(&nodes[1], &nodes[0].node.get_our_node_id());
 640
 641         let bs_channel_update = get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
 642
 643         let as_channel_update = match &as_locked_update[1] {
 644                 MessageSendEvent::SendChannelUpdate { node_id, msg } => {
 645                         assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 646                         msg.clone()
 647                 }
 648                 _ => panic!("Unexpected event"),
 649         };
 650
 651         chanmon_cfgs[0].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
 652         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
 653
 654         nodes[0].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &bs_channel_update);
 655         nodes[1].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &as_channel_update);
 656
 657         assert_eq!(nodes[0].node.list_usable_channels().len(), 1);
 658         assert_eq!(nodes[1].node.list_usable_channels().len(), 2);
 659
 660         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 661
 662         // Now that we have useful channels, try sending a payment where the we hit a temporary monitor
 663         // failure before we've ever confirmed the funding transaction. This previously caused a panic.
 664         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], 1_000_000);
 665
 666         nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
 667         check_added_monitors!(nodes[0], 1);
 668
 669         let as_send = SendEvent::from_node(&nodes[0]);
 670         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_send.msgs[0]);
 671         nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_send.commitment_msg);
 672         check_added_monitors!(nodes[1], 1);
 673
 674         let (bs_raa, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 675         nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
 676         check_added_monitors!(nodes[0], 1);
 677
 678         nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_commitment_signed);
 679         check_added_monitors!(nodes[0], 1);
 680
 681         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
 682         nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id()));
 683         check_added_monitors!(nodes[1], 1);
 684         assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 685
 686         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
 687         let (outpoint, _, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&bs_raa.channel_id).unwrap().clone();
 688         nodes[1].chain_monitor.chain_monitor.channel_monitor_updated(outpoint, latest_update).unwrap();
 689         check_added_monitors!(nodes[1], 0);
 690         expect_pending_htlcs_forwardable!(nodes[1]);
 691         check_added_monitors!(nodes[1], 1);
 692
 693         let bs_send = SendEvent::from_node(&nodes[1]);
 694         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &bs_send.msgs[0]);
 695         commitment_signed_dance!(nodes[2], nodes[1], bs_send.commitment_msg, false);
 696         expect_pending_htlcs_forwardable!(nodes[2]);
 697         expect_payment_claimable!(nodes[2], payment_hash, payment_secret, 1_000_000);
 698         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
 699
 700         confirm_transaction(&nodes[0], &tx);
 701         confirm_transaction(&nodes[1], &tx);
 702
 703         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 704 }
 705
 706 #[test]
 707 fn test_0conf_close_no_early_chan_update() {
 708         // Tests that even with a public channel 0conf channel, we don't generate a channel_update on
 709         // closing.
 710         let chanmon_cfgs = create_chanmon_cfgs(2);
 711         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 712         let mut chan_config = test_default_channel_config();
 713         chan_config.manually_accept_inbound_channels = true;
 714
 715         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 716         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 717
 718         // This is the default but we force it on anyway
 719         chan_config.channel_handshake_config.announced_channel = true;
 720         open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
 721
 722         // We can use the channel immediately, but won't generate a channel_update until we get confs
 723         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 724
 725         nodes[0].node.force_close_all_channels_broadcasting_latest_txn();
 726         check_added_monitors!(nodes[0], 1);
 727         check_closed_event!(&nodes[0], 1, ClosureReason::HolderForceClosed);
 728         let _ = get_err_msg!(nodes[0], nodes[1].node.get_our_node_id());
 729 }
 730
 731 #[test]
 732 fn test_public_0conf_channel() {
 733         // Tests that we will announce a public channel (after confirmation) even if its 0conf.
 734         let chanmon_cfgs = create_chanmon_cfgs(2);
 735         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 736         let mut chan_config = test_default_channel_config();
 737         chan_config.manually_accept_inbound_channels = true;
 738
 739         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 740         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 741
 742         // This is the default but we force it on anyway
 743         chan_config.channel_handshake_config.announced_channel = true;
 744         let (tx, ..) = open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
 745
 746         // We can use the channel immediately, but we can't announce it until we get 6+ confirmations
 747         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 748
 749         let scid = confirm_transaction(&nodes[0], &tx);
 750         let as_announcement_sigs = get_event_msg!(nodes[0], MessageSendEvent::SendAnnouncementSignatures, nodes[1].node.get_our_node_id());
 751         assert_eq!(confirm_transaction(&nodes[1], &tx), scid);
 752         let bs_announcement_sigs = get_event_msg!(nodes[1], MessageSendEvent::SendAnnouncementSignatures, nodes[0].node.get_our_node_id());
 753
 754         nodes[1].node.handle_announcement_signatures(&nodes[0].node.get_our_node_id(), &as_announcement_sigs);
 755         nodes[0].node.handle_announcement_signatures(&nodes[1].node.get_our_node_id(), &bs_announcement_sigs);
 756
 757         let bs_announcement = nodes[1].node.get_and_clear_pending_msg_events();
 758         assert_eq!(bs_announcement.len(), 1);
 759         let announcement;
 760         let bs_update;
 761         match bs_announcement[0] {
 762                 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
 763                         announcement = msg.clone();
 764                         bs_update = update_msg.clone();
 765                 },
 766                 _ => panic!("Unexpected event"),
 767         };
 768
 769         let as_announcement = nodes[0].node.get_and_clear_pending_msg_events();
 770         assert_eq!(as_announcement.len(), 1);
 771         match as_announcement[0] {
 772                 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
 773                         assert!(announcement == *msg);
 774                         assert_eq!(update_msg.contents.short_channel_id, scid);
 775                         assert_eq!(update_msg.contents.short_channel_id, announcement.contents.short_channel_id);
 776                         assert_eq!(update_msg.contents.short_channel_id, bs_update.contents.short_channel_id);
 777                 },
 778                 _ => panic!("Unexpected event"),
 779         };
 780 }
 781
 782 #[test]
 783 fn test_0conf_channel_reorg() {
 784         // If we accept a 0conf channel, which is then confirmed, but then changes SCID in a reorg, we
 785         // have to make sure we handle this correctly (or, currently, just force-close the channel).
 786
 787         let chanmon_cfgs = create_chanmon_cfgs(2);
 788         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 789         let mut chan_config = test_default_channel_config();
 790         chan_config.manually_accept_inbound_channels = true;
 791
 792         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 793         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 794
 795         // This is the default but we force it on anyway
 796         chan_config.channel_handshake_config.announced_channel = true;
 797         let (tx, ..) = open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
 798
 799         // We can use the channel immediately, but we can't announce it until we get 6+ confirmations
 800         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 801
 802         mine_transaction(&nodes[0], &tx);
 803         mine_transaction(&nodes[1], &tx);
 804
 805         // Send a payment using the channel's real SCID, which will be public in a few blocks once we
 806         // can generate a channel_announcement.
 807         let real_scid = nodes[0].node.list_usable_channels()[0].short_channel_id.unwrap();
 808         assert_eq!(nodes[1].node.list_usable_channels()[0].short_channel_id.unwrap(), real_scid);
 809
 810         let (mut route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[1], 10_000);
 811         assert_eq!(route.paths[0][0].short_channel_id, real_scid);
 812         send_along_route_with_secret(&nodes[0], route, &[&[&nodes[1]]], 10_000, payment_hash, payment_secret);
 813         claim_payment(&nodes[0], &[&nodes[1]], payment_preimage);
 814
 815         disconnect_blocks(&nodes[0], 1);
 816         disconnect_blocks(&nodes[1], 1);
 817
 818         // At this point the channel no longer has an SCID again. In the future we should likely
 819         // support simply un-setting the SCID and waiting until the channel gets re-confirmed, but for
 820         // now we force-close the channel here.
 821         check_closed_event!(&nodes[0], 1, ClosureReason::ProcessingError {
 822                 err: "Funding transaction was un-confirmed. Locked at 0 confs, now have 0 confs.".to_owned()
 823         });
 824         check_closed_broadcast!(nodes[0], true);
 825         check_closed_event!(&nodes[1], 1, ClosureReason::ProcessingError {
 826                 err: "Funding transaction was un-confirmed. Locked at 0 confs, now have 0 confs.".to_owned()
 827         });
 828         check_closed_broadcast!(nodes[1], true);
 829 }
 830
 831 #[test]
 832 fn test_zero_conf_accept_reject() {
 833         let mut channel_type_features = ChannelTypeFeatures::only_static_remote_key();
 834         channel_type_features.set_zero_conf_required();
 835
 836         // 1. Check we reject zero conf channels by default
 837         let chanmon_cfgs = create_chanmon_cfgs(2);
 838         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 839         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
 840         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 841
 842         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
 843         let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 844
 845         open_channel_msg.channel_type = Some(channel_type_features.clone());
 846
 847         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
 848
 849         let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 850         match msg_events[0] {
 851                 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg, .. }, .. } => {
 852                         assert_eq!(msg.data, "No zero confirmation channels accepted".to_owned());
 853                 },
 854                 _ => panic!(),
 855         }
 856
 857         // 2. Check we can manually accept zero conf channels via the right method
 858         let mut manually_accept_conf = UserConfig::default();
 859         manually_accept_conf.manually_accept_inbound_channels = true;
 860
 861         let chanmon_cfgs = create_chanmon_cfgs(2);
 862         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 863         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs,
 864                 &[None, Some(manually_accept_conf.clone())]);
 865         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 866
 867         // 2.1 First try the non-0conf method to manually accept
 868         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42,
 869                 Some(manually_accept_conf)).unwrap();
 870         let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel,
 871                 nodes[1].node.get_our_node_id());
 872
 873         open_channel_msg.channel_type = Some(channel_type_features.clone());
 874
 875         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
 876
 877         // Assert that `nodes[1]` has no `MessageSendEvent::SendAcceptChannel` in the `msg_events`.
 878         assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 879
 880         let events = nodes[1].node.get_and_clear_pending_events();
 881
 882         match events[0] {
 883                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 884                         // Assert we fail to accept via the non-0conf method
 885                         assert!(nodes[1].node.accept_inbound_channel(&temporary_channel_id,
 886                                 &nodes[0].node.get_our_node_id(), 0).is_err());
 887                 },
 888                 _ => panic!(),
 889         }
 890
 891         let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 892         match msg_events[0] {
 893                 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg, .. }, .. } => {
 894                         assert_eq!(msg.data, "No zero confirmation channels accepted".to_owned());
 895                 },
 896                 _ => panic!(),
 897         }
 898
 899         // 2.2 Try again with the 0conf method to manually accept
 900         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42,
 901                 Some(manually_accept_conf)).unwrap();
 902         let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel,
 903                 nodes[1].node.get_our_node_id());
 904
 905         open_channel_msg.channel_type = Some(channel_type_features);
 906
 907         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
 908
 909         let events = nodes[1].node.get_and_clear_pending_events();
 910
 911         match events[0] {
 912                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 913                         // Assert we can accept via the 0conf method
 914                         assert!(nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(
 915                                 &temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).is_ok());
 916                 },
 917                 _ => panic!(),
 918         }
 919
 920         // Check we would send accept
 921         let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 922         match msg_events[0] {
 923                 MessageSendEvent::SendAcceptChannel { .. } => {},
 924                 _ => panic!(),
 925         }
 926 }
 927
 928 #[test]
 929 fn test_connect_before_funding() {
 930         // Tests for a particularly dumb explicit panic that existed prior to 0.0.111 for 0conf
 931         // channels. If we received a block while awaiting funding for 0-conf channels we'd hit an
 932         // explicit panic when deciding if we should broadcast our channel_ready message.
 933         let chanmon_cfgs = create_chanmon_cfgs(2);
 934         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 935
 936         let mut manually_accept_conf = test_default_channel_config();
 937         manually_accept_conf.manually_accept_inbound_channels = true;
 938
 939         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(manually_accept_conf)]);
 940         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 941
 942         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100_000, 10_001, 42, None).unwrap();
 943         let open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 944
 945         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
 946         let events = nodes[1].node.get_and_clear_pending_events();
 947         assert_eq!(events.len(), 1);
 948         match events[0] {
 949                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 950                         nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(&temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).unwrap();
 951                 },
 952                 _ => panic!("Unexpected event"),
 953         };
 954
 955         let mut accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
 956         assert_eq!(accept_channel.minimum_depth, 0);
 957         nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &accept_channel);
 958
 959         let events = nodes[0].node.get_and_clear_pending_events();
 960         assert_eq!(events.len(), 1);
 961         match events[0] {
 962                 Event::FundingGenerationReady { .. } => {},
 963                 _ => panic!("Unexpected event"),
 964         }
 965
 966         connect_blocks(&nodes[0], 1);
 967         connect_blocks(&nodes[1], 1);
 968 }