_ Git - rust-lightning/blob - lightning/src/ln/priv_short_conf_tests.rs

   1 // This file is Copyright its original authors, visible in version control
   2 // history.
   3 //
   4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
   5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
   6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
   7 // You may not use this file except in accordance with one or both of these
   8 // licenses.
   9
  10 //! Tests that test ChannelManager behavior with fewer confirmations required than the default and
  11 //! other behavior that exists only on private channels or with a semi-trusted counterparty (eg
  12 //! LSP).
  13
  14 use crate::chain::ChannelMonitorUpdateStatus;
  15 use crate::chain::keysinterface::NodeSigner;
  16 use crate::ln::channelmanager::{ChannelManager, MIN_CLTV_EXPIRY_DELTA, PaymentId};
  17 use crate::routing::gossip::RoutingFees;
  18 use crate::routing::router::{PaymentParameters, RouteHint, RouteHintHop};
  19 use crate::ln::features::ChannelTypeFeatures;
  20 use crate::ln::msgs;
  21 use crate::ln::msgs::{ChannelMessageHandler, RoutingMessageHandler, ChannelUpdate, ErrorAction};
  22 use crate::ln::wire::Encode;
  23 use crate::util::events::{ClosureReason, Event, HTLCDestination, MessageSendEvent, MessageSendEventsProvider};
  24 use crate::util::config::UserConfig;
  25 use crate::util::ser::Writeable;
  26 use crate::util::test_utils;
  27
  28 use crate::prelude::*;
  29 use core::default::Default;
  30
  31 use crate::ln::functional_test_utils::*;
  32
  33 use bitcoin::blockdata::constants::genesis_block;
  34 use bitcoin::network::constants::Network;
  35
  36 #[test]
  37 fn test_priv_forwarding_rejection() {
  38         // If we have a private channel with outbound liquidity, and
  39         // UserConfig::accept_forwards_to_priv_channels is set to false, we should reject any attempts
  40         // to forward through that channel.
  41         let chanmon_cfgs = create_chanmon_cfgs(3);
  42         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
  43         let mut no_announce_cfg = test_default_channel_config();
  44         no_announce_cfg.accept_forwards_to_priv_channels = false;
  45         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(no_announce_cfg), None]);
  46         let persister: test_utils::TestPersister;
  47         let new_chain_monitor: test_utils::TestChainMonitor;
  48         let nodes_1_deserialized: ChannelManager<&test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestRouter, &test_utils::TestLogger>;
  49         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
  50
  51         let chan_id_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000).2;
  52         let chan_id_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 500_000_000).0.channel_id;
  53
  54         // We should always be able to forward through nodes[1] as long as its out through a public
  55         // channel:
  56         send_payment(&nodes[2], &[&nodes[1], &nodes[0]], 10_000);
  57
  58         // ... however, if we send to nodes[2], we will have to pass the private channel from nodes[1]
  59         // to nodes[2], which should be rejected:
  60         let route_hint = RouteHint(vec![RouteHintHop {
  61                 src_node_id: nodes[1].node.get_our_node_id(),
  62                 short_channel_id: nodes[2].node.list_channels()[0].short_channel_id.unwrap(),
  63                 fees: RoutingFees { base_msat: 1000, proportional_millionths: 0 },
  64                 cltv_expiry_delta: MIN_CLTV_EXPIRY_DELTA,
  65                 htlc_minimum_msat: None,
  66                 htlc_maximum_msat: None,
  67         }]);
  68         let last_hops = vec![route_hint];
  69         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), TEST_FINAL_CLTV)
  70                 .with_features(nodes[2].node.invoice_features())
  71                 .with_route_hints(last_hops);
  72         let (route, our_payment_hash, our_payment_preimage, our_payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 10_000, TEST_FINAL_CLTV);
  73
  74         nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret), PaymentId(our_payment_hash.0)).unwrap();
  75         check_added_monitors!(nodes[0], 1);
  76         let payment_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
  77         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
  78         commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false, true);
  79
  80         let htlc_fail_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
  81         assert!(htlc_fail_updates.update_add_htlcs.is_empty());
  82         assert_eq!(htlc_fail_updates.update_fail_htlcs.len(), 1);
  83         assert!(htlc_fail_updates.update_fail_malformed_htlcs.is_empty());
  84         assert!(htlc_fail_updates.update_fee.is_none());
  85
  86         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_fail_updates.update_fail_htlcs[0]);
  87         commitment_signed_dance!(nodes[0], nodes[1], htlc_fail_updates.commitment_signed, true, true);
  88         expect_payment_failed_with_update!(nodes[0], our_payment_hash, false, nodes[2].node.list_channels()[0].short_channel_id.unwrap(), true);
  89
  90         // Now disconnect nodes[1] from its peers and restart with accept_forwards_to_priv_channels set
  91         // to true. Sadly there is currently no way to change it at runtime.
  92
  93         nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id());
  94         nodes[2].node.peer_disconnected(&nodes[1].node.get_our_node_id());
  95
  96         let nodes_1_serialized = nodes[1].node.encode();
  97         let monitor_a_serialized = get_monitor!(nodes[1], chan_id_1).encode();
  98         let monitor_b_serialized = get_monitor!(nodes[1], chan_id_2).encode();
  99
 100         no_announce_cfg.accept_forwards_to_priv_channels = true;
 101         reload_node!(nodes[1], no_announce_cfg, &nodes_1_serialized, &[&monitor_a_serialized, &monitor_b_serialized], persister, new_chain_monitor, nodes_1_deserialized);
 102
 103         nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: nodes[1].node.init_features(), remote_network_address: None }, true).unwrap();
 104         nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: nodes[0].node.init_features(), remote_network_address: None }, false).unwrap();
 105         let as_reestablish = get_chan_reestablish_msgs!(nodes[0], nodes[1]).pop().unwrap();
 106         let bs_reestablish = get_chan_reestablish_msgs!(nodes[1], nodes[0]).pop().unwrap();
 107         nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &as_reestablish);
 108         nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
 109         get_event_msg!(nodes[0], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 110         get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
 111
 112         nodes[1].node.peer_connected(&nodes[2].node.get_our_node_id(), &msgs::Init { features: nodes[2].node.init_features(), remote_network_address: None }, true).unwrap();
 113         nodes[2].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: nodes[1].node.init_features(), remote_network_address: None }, false).unwrap();
 114         let bs_reestablish = get_chan_reestablish_msgs!(nodes[1], nodes[2]).pop().unwrap();
 115         let cs_reestablish = get_chan_reestablish_msgs!(nodes[2], nodes[1]).pop().unwrap();
 116         nodes[2].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
 117         nodes[1].node.handle_channel_reestablish(&nodes[2].node.get_our_node_id(), &cs_reestablish);
 118         get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
 119         get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 120
 121         nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret), PaymentId(our_payment_hash.0)).unwrap();
 122         check_added_monitors!(nodes[0], 1);
 123         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 10_000, our_payment_hash, our_payment_secret);
 124         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], our_payment_preimage);
 125 }
 126
 127 fn do_test_1_conf_open(connect_style: ConnectStyle) {
 128         // Previously, if the minium_depth config was set to 1, we'd never send a channel_ready. This
 129         // tests that we properly send one in that case.
 130         let mut alice_config = UserConfig::default();
 131         alice_config.channel_handshake_config.minimum_depth = 1;
 132         alice_config.channel_handshake_config.announced_channel = true;
 133         alice_config.channel_handshake_limits.force_announced_channel_preference = false;
 134         let mut bob_config = UserConfig::default();
 135         bob_config.channel_handshake_config.minimum_depth = 1;
 136         bob_config.channel_handshake_config.announced_channel = true;
 137         bob_config.channel_handshake_limits.force_announced_channel_preference = false;
 138         let chanmon_cfgs = create_chanmon_cfgs(2);
 139         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 140         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[Some(alice_config), Some(bob_config)]);
 141         let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 142         *nodes[0].connect_style.borrow_mut() = connect_style;
 143
 144         let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001);
 145         mine_transaction(&nodes[1], &tx);
 146         nodes[0].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendChannelReady, nodes[0].node.get_our_node_id()));
 147         assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
 148
 149         mine_transaction(&nodes[0], &tx);
 150         let as_msg_events = nodes[0].node.get_and_clear_pending_msg_events();
 151         assert_eq!(as_msg_events.len(), 2);
 152         let as_channel_ready = if let MessageSendEvent::SendChannelReady { ref node_id, ref msg } = as_msg_events[0] {
 153                 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 154                 msg.clone()
 155         } else { panic!("Unexpected event"); };
 156         if let MessageSendEvent::SendChannelUpdate { ref node_id, msg: _ } = as_msg_events[1] {
 157                 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 158         } else { panic!("Unexpected event"); }
 159
 160         nodes[1].node.handle_channel_ready(&nodes[0].node.get_our_node_id(), &as_channel_ready);
 161         expect_channel_ready_event(&nodes[0], &nodes[1].node.get_our_node_id());
 162         expect_channel_ready_event(&nodes[1], &nodes[0].node.get_our_node_id());
 163         let bs_msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 164         assert_eq!(bs_msg_events.len(), 1);
 165         if let MessageSendEvent::SendChannelUpdate { ref node_id, msg: _ } = bs_msg_events[0] {
 166                 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 167         } else { panic!("Unexpected event"); }
 168
 169         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 170
 171         // After 6 confirmations, as required by the spec, we'll send announcement_signatures and
 172         // broadcast the channel_announcement (but not before exactly 6 confirmations).
 173         connect_blocks(&nodes[0], 4);
 174         assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
 175         connect_blocks(&nodes[0], 1);
 176         nodes[1].node.handle_announcement_signatures(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendAnnouncementSignatures, nodes[1].node.get_our_node_id()));
 177         assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 178
 179         connect_blocks(&nodes[1], 5);
 180         let bs_announce_events = nodes[1].node.get_and_clear_pending_msg_events();
 181         assert_eq!(bs_announce_events.len(), 2);
 182         let bs_announcement_sigs = if let MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } = bs_announce_events[0] {
 183                 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 184                 msg.clone()
 185         } else { panic!("Unexpected event"); };
 186         let (bs_announcement, bs_update) = if let MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } = bs_announce_events[1] {
 187                 (msg.clone(), update_msg.clone().unwrap())
 188         } else { panic!("Unexpected event"); };
 189
 190         nodes[0].node.handle_announcement_signatures(&nodes[1].node.get_our_node_id(), &bs_announcement_sigs);
 191         let as_announce_events = nodes[0].node.get_and_clear_pending_msg_events();
 192         assert_eq!(as_announce_events.len(), 1);
 193         let (announcement, as_update) = if let MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } = as_announce_events[0] {
 194                 (msg.clone(), update_msg.clone().unwrap())
 195         } else { panic!("Unexpected event"); };
 196         assert_eq!(announcement, bs_announcement);
 197
 198         for node in nodes {
 199                 assert!(node.gossip_sync.handle_channel_announcement(&announcement).unwrap());
 200                 node.gossip_sync.handle_channel_update(&as_update).unwrap();
 201                 node.gossip_sync.handle_channel_update(&bs_update).unwrap();
 202         }
 203 }
 204 #[test]
 205 fn test_1_conf_open() {
 206         do_test_1_conf_open(ConnectStyle::BestBlockFirst);
 207         do_test_1_conf_open(ConnectStyle::TransactionsFirst);
 208         do_test_1_conf_open(ConnectStyle::FullBlockViaListen);
 209 }
 210
 211 #[test]
 212 fn test_routed_scid_alias() {
 213         // Trivially test sending a payment which is routed through an SCID alias.
 214         let chanmon_cfgs = create_chanmon_cfgs(3);
 215         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 216         let mut no_announce_cfg = test_default_channel_config();
 217         no_announce_cfg.accept_forwards_to_priv_channels = true;
 218         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(no_announce_cfg), None]);
 219         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 220
 221         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000).2;
 222         let mut as_channel_ready = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 500_000_000).0;
 223
 224         let last_hop = nodes[2].node.list_usable_channels();
 225         let hop_hints = vec![RouteHint(vec![RouteHintHop {
 226                 src_node_id: nodes[1].node.get_our_node_id(),
 227                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 228                 fees: RoutingFees {
 229                         base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 230                         proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 231                 },
 232                 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
 233                 htlc_maximum_msat: None,
 234                 htlc_minimum_msat: None,
 235         }])];
 236         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
 237                 .with_features(nodes[2].node.invoice_features())
 238                 .with_route_hints(hop_hints);
 239         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 100_000, 42);
 240         assert_eq!(route.paths[0][1].short_channel_id, last_hop[0].inbound_scid_alias.unwrap());
 241         nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
 242         check_added_monitors!(nodes[0], 1);
 243
 244         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 100_000, payment_hash, payment_secret);
 245
 246         as_channel_ready.short_channel_id_alias = Some(0xeadbeef);
 247         nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &as_channel_ready);
 248         // Note that we always respond to a channel_ready with a channel_update. Not a lot of reason
 249         // to bother updating that code, so just drop the message here.
 250         get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 251
 252         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
 253
 254         // Now test that if a peer sends us a second channel_ready after the channel is operational we
 255         // will use the new alias.
 256         as_channel_ready.short_channel_id_alias = Some(0xdeadbeef);
 257         nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &as_channel_ready);
 258         // Note that we always respond to a channel_ready with a channel_update. Not a lot of reason
 259         // to bother updating that code, so just drop the message here.
 260         get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 261         let updated_channel_info = nodes[2].node.list_usable_channels();
 262         assert_eq!(updated_channel_info.len(), 1);
 263         assert_eq!(updated_channel_info[0].inbound_scid_alias.unwrap(), 0xdeadbeef);
 264         // Note that because we never send a duplicate channel_ready we can't send a payment through
 265         // the 0xdeadbeef SCID alias.
 266 }
 267
 268 #[test]
 269 fn test_scid_privacy_on_pub_channel() {
 270         // Tests rejecting the scid_privacy feature for public channels and that we don't ever try to
 271         // send them.
 272         let chanmon_cfgs = create_chanmon_cfgs(2);
 273         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 274         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
 275         let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 276
 277         let mut scid_privacy_cfg = test_default_channel_config();
 278         scid_privacy_cfg.channel_handshake_config.announced_channel = true;
 279         scid_privacy_cfg.channel_handshake_config.negotiate_scid_privacy = true;
 280         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(scid_privacy_cfg)).unwrap();
 281         let mut open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 282
 283         assert!(!open_channel.channel_type.as_ref().unwrap().supports_scid_privacy()); // we ignore `negotiate_scid_privacy` on pub channels
 284         open_channel.channel_type.as_mut().unwrap().set_scid_privacy_required();
 285         assert_eq!(open_channel.channel_flags & 1, 1); // The `announce_channel` bit is set.
 286
 287         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
 288         let err = get_err_msg!(nodes[1], nodes[0].node.get_our_node_id());
 289         assert_eq!(err.data, "SCID Alias/Privacy Channel Type cannot be set on a public channel");
 290 }
 291
 292 #[test]
 293 fn test_scid_privacy_negotiation() {
 294         // Tests of the negotiation of SCID alias and falling back to non-SCID-alias if our
 295         // counterparty doesn't support it.
 296         let chanmon_cfgs = create_chanmon_cfgs(2);
 297         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 298         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
 299         let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 300
 301         let mut scid_privacy_cfg = test_default_channel_config();
 302         scid_privacy_cfg.channel_handshake_config.announced_channel = false;
 303         scid_privacy_cfg.channel_handshake_config.negotiate_scid_privacy = true;
 304         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(scid_privacy_cfg)).unwrap();
 305
 306         let init_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 307         assert!(init_open_channel.channel_type.as_ref().unwrap().supports_scid_privacy());
 308         assert!(nodes[0].node.list_channels()[0].channel_type.is_none()); // channel_type is none until counterparty accepts
 309
 310         // now simulate nodes[1] responding with an Error message, indicating it doesn't understand
 311         // SCID alias.
 312         nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage {
 313                 channel_id: init_open_channel.temporary_channel_id,
 314                 data: "Yo, no SCID aliases, no privacy here!".to_string()
 315         });
 316         assert!(nodes[0].node.list_channels()[0].channel_type.is_none()); // channel_type is none until counterparty accepts
 317
 318         let second_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 319         assert!(!second_open_channel.channel_type.as_ref().unwrap().supports_scid_privacy());
 320         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &second_open_channel);
 321         nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id()));
 322
 323         let events = nodes[0].node.get_and_clear_pending_events();
 324         assert_eq!(events.len(), 1);
 325         match events[0] {
 326                 Event::FundingGenerationReady { .. } => {},
 327                 _ => panic!("Unexpected event"),
 328         }
 329
 330         assert!(!nodes[0].node.list_channels()[0].channel_type.as_ref().unwrap().supports_scid_privacy());
 331         assert!(!nodes[1].node.list_channels()[0].channel_type.as_ref().unwrap().supports_scid_privacy());
 332 }
 333
 334 #[test]
 335 fn test_inbound_scid_privacy() {
 336         // Tests accepting channels with the scid_privacy feature and rejecting forwards using the
 337         // channel's real SCID as required by the channel feature.
 338         let chanmon_cfgs = create_chanmon_cfgs(3);
 339         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 340         let mut accept_forward_cfg = test_default_channel_config();
 341         accept_forward_cfg.accept_forwards_to_priv_channels = true;
 342         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(accept_forward_cfg), None]);
 343         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 344
 345         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
 346
 347         let mut no_announce_cfg = test_default_channel_config();
 348         no_announce_cfg.channel_handshake_config.announced_channel = false;
 349         no_announce_cfg.channel_handshake_config.negotiate_scid_privacy = true;
 350         nodes[1].node.create_channel(nodes[2].node.get_our_node_id(), 100_000, 10_000, 42, Some(no_announce_cfg)).unwrap();
 351         let mut open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[2].node.get_our_node_id());
 352
 353         assert!(open_channel.channel_type.as_ref().unwrap().requires_scid_privacy());
 354
 355         nodes[2].node.handle_open_channel(&nodes[1].node.get_our_node_id(), &open_channel);
 356         let accept_channel = get_event_msg!(nodes[2], MessageSendEvent::SendAcceptChannel, nodes[1].node.get_our_node_id());
 357         nodes[1].node.handle_accept_channel(&nodes[2].node.get_our_node_id(), &accept_channel);
 358
 359         let (temporary_channel_id, tx, _) = create_funding_transaction(&nodes[1], &nodes[2].node.get_our_node_id(), 100_000, 42);
 360         nodes[1].node.funding_transaction_generated(&temporary_channel_id, &nodes[2].node.get_our_node_id(), tx.clone()).unwrap();
 361         nodes[2].node.handle_funding_created(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendFundingCreated, nodes[2].node.get_our_node_id()));
 362         check_added_monitors!(nodes[2], 1);
 363
 364         let cs_funding_signed = get_event_msg!(nodes[2], MessageSendEvent::SendFundingSigned, nodes[1].node.get_our_node_id());
 365         nodes[1].node.handle_funding_signed(&nodes[2].node.get_our_node_id(), &cs_funding_signed);
 366         check_added_monitors!(nodes[1], 1);
 367
 368         let conf_height = core::cmp::max(nodes[1].best_block_info().1 + 1, nodes[2].best_block_info().1 + 1);
 369         confirm_transaction_at(&nodes[1], &tx, conf_height);
 370         connect_blocks(&nodes[1], CHAN_CONFIRM_DEPTH - 1);
 371         confirm_transaction_at(&nodes[2], &tx, conf_height);
 372         connect_blocks(&nodes[2], CHAN_CONFIRM_DEPTH - 1);
 373         let bs_channel_ready = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReady, nodes[2].node.get_our_node_id());
 374         nodes[1].node.handle_channel_ready(&nodes[2].node.get_our_node_id(), &get_event_msg!(nodes[2], MessageSendEvent::SendChannelReady, nodes[1].node.get_our_node_id()));
 375         expect_channel_ready_event(&nodes[1], &nodes[2].node.get_our_node_id());
 376         let bs_update = get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
 377         nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &bs_channel_ready);
 378         expect_channel_ready_event(&nodes[2], &nodes[1].node.get_our_node_id());
 379         let cs_update = get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 380
 381         nodes[1].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &cs_update);
 382         nodes[2].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &bs_update);
 383
 384         // Now we can pay just fine using the SCID alias nodes[2] gave to nodes[1]...
 385
 386         let last_hop = nodes[2].node.list_usable_channels();
 387         let mut hop_hints = vec![RouteHint(vec![RouteHintHop {
 388                 src_node_id: nodes[1].node.get_our_node_id(),
 389                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 390                 fees: RoutingFees {
 391                         base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 392                         proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 393                 },
 394                 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
 395                 htlc_maximum_msat: None,
 396                 htlc_minimum_msat: None,
 397         }])];
 398         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
 399                 .with_features(nodes[2].node.invoice_features())
 400                 .with_route_hints(hop_hints.clone());
 401         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 100_000, 42);
 402         assert_eq!(route.paths[0][1].short_channel_id, last_hop[0].inbound_scid_alias.unwrap());
 403         nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
 404         check_added_monitors!(nodes[0], 1);
 405
 406         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 100_000, payment_hash, payment_secret);
 407         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
 408
 409         // ... but if we try to pay using the real SCID, nodes[1] will just tell us they don't know
 410         // what channel we're talking about.
 411         hop_hints[0].0[0].short_channel_id = last_hop[0].short_channel_id.unwrap();
 412
 413         let payment_params_2 = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
 414                 .with_features(nodes[2].node.invoice_features())
 415                 .with_route_hints(hop_hints);
 416         let (route_2, payment_hash_2, _, payment_secret_2) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params_2, 100_000, 42);
 417         assert_eq!(route_2.paths[0][1].short_channel_id, last_hop[0].short_channel_id.unwrap());
 418         nodes[0].node.send_payment(&route_2, payment_hash_2, &Some(payment_secret_2), PaymentId(payment_hash_2.0)).unwrap();
 419         check_added_monitors!(nodes[0], 1);
 420
 421         let payment_event = SendEvent::from_node(&nodes[0]);
 422         assert_eq!(nodes[1].node.get_our_node_id(), payment_event.node_id);
 423         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
 424         commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, true, true);
 425
 426         nodes[1].logger.assert_log_regex("lightning::ln::channelmanager".to_string(), regex::Regex::new(r"Refusing to forward over real channel SCID as our counterparty requested").unwrap(), 1);
 427
 428         let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 429         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
 430         commitment_signed_dance!(nodes[0], nodes[1], updates.commitment_signed, false);
 431
 432         expect_payment_failed_conditions(&nodes[0], payment_hash_2, false,
 433                 PaymentFailedConditions::new().blamed_scid(last_hop[0].short_channel_id.unwrap())
 434                         .blamed_chan_closed(true).expected_htlc_error_data(0x4000|10, &[0; 0]));
 435 }
 436
 437 #[test]
 438 fn test_scid_alias_returned() {
 439         // Tests that when we fail an HTLC (in this case due to attempting to forward more than the
 440         // channel's available balance) we use the correct (in this case the aliased) SCID in the
 441         // channel_update which is returned in the onion to the sender.
 442         let chanmon_cfgs = create_chanmon_cfgs(3);
 443         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 444         let mut accept_forward_cfg = test_default_channel_config();
 445         accept_forward_cfg.accept_forwards_to_priv_channels = true;
 446         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(accept_forward_cfg), None]);
 447         let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 448
 449         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 10_000_000, 0);
 450         let chan = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 10_000, 0);
 451
 452         let last_hop = nodes[2].node.list_usable_channels();
 453         let mut hop_hints = vec![RouteHint(vec![RouteHintHop {
 454                 src_node_id: nodes[1].node.get_our_node_id(),
 455                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 456                 fees: RoutingFees {
 457                         base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 458                         proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 459                 },
 460                 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
 461                 htlc_maximum_msat: None,
 462                 htlc_minimum_msat: None,
 463         }])];
 464         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
 465                 .with_features(nodes[2].node.invoice_features())
 466                 .with_route_hints(hop_hints);
 467         let (mut route, payment_hash, _, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 10_000, 42);
 468         assert_eq!(route.paths[0][1].short_channel_id, nodes[2].node.list_usable_channels()[0].inbound_scid_alias.unwrap());
 469
 470         route.paths[0][1].fee_msat = 10_000_000; // Overshoot the last channel's value
 471
 472         // Route the HTLC through to the destination.
 473         nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
 474         check_added_monitors!(nodes[0], 1);
 475         let as_updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
 476         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_updates.update_add_htlcs[0]);
 477         commitment_signed_dance!(nodes[1], nodes[0], &as_updates.commitment_signed, false, true);
 478
 479         expect_pending_htlcs_forwardable!(nodes[1]);
 480         expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCDestination::NextHopChannel { node_id: Some(nodes[2].node.get_our_node_id()), channel_id: chan.0.channel_id }]);
 481         check_added_monitors!(nodes[1], 1);
 482
 483         let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 484         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
 485         commitment_signed_dance!(nodes[0], nodes[1], bs_updates.commitment_signed, false, true);
 486
 487         // Build the expected channel update
 488         let contents = msgs::UnsignedChannelUpdate {
 489                 chain_hash: genesis_block(Network::Testnet).header.block_hash(),
 490                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 491                 timestamp: 21,
 492                 flags: 1,
 493                 cltv_expiry_delta: accept_forward_cfg.channel_config.cltv_expiry_delta,
 494                 htlc_minimum_msat: 1_000,
 495                 htlc_maximum_msat: 1_000_000, // Defaults to 10% of the channel value
 496                 fee_base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 497                 fee_proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 498                 excess_data: Vec::new(),
 499         };
 500         let signature = nodes[1].keys_manager.sign_gossip_message(msgs::UnsignedGossipMessage::ChannelUpdate(&contents)).unwrap();
 501         let msg = msgs::ChannelUpdate { signature, contents };
 502
 503         let mut err_data = Vec::new();
 504         err_data.extend_from_slice(&(msg.serialized_length() as u16 + 2).to_be_bytes());
 505         err_data.extend_from_slice(&ChannelUpdate::TYPE.to_be_bytes());
 506         err_data.extend_from_slice(&msg.encode());
 507
 508         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
 509                 PaymentFailedConditions::new().blamed_scid(last_hop[0].inbound_scid_alias.unwrap())
 510                         .blamed_chan_closed(false).expected_htlc_error_data(0x1000|7, &err_data));
 511
 512         route.paths[0][1].fee_msat = 10_000; // Reset to the correct payment amount
 513         route.paths[0][0].fee_msat = 0; // But set fee paid to the middle hop to 0
 514
 515         // Route the HTLC through to the destination.
 516         nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
 517         check_added_monitors!(nodes[0], 1);
 518         let as_updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
 519         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_updates.update_add_htlcs[0]);
 520         commitment_signed_dance!(nodes[1], nodes[0], &as_updates.commitment_signed, false, true);
 521
 522         let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 523         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
 524         commitment_signed_dance!(nodes[0], nodes[1], bs_updates.commitment_signed, false, true);
 525
 526         let mut err_data = Vec::new();
 527         err_data.extend_from_slice(&10_000u64.to_be_bytes());
 528         err_data.extend_from_slice(&(msg.serialized_length() as u16 + 2).to_be_bytes());
 529         err_data.extend_from_slice(&ChannelUpdate::TYPE.to_be_bytes());
 530         err_data.extend_from_slice(&msg.encode());
 531         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
 532                 PaymentFailedConditions::new().blamed_scid(last_hop[0].inbound_scid_alias.unwrap())
 533                         .blamed_chan_closed(false).expected_htlc_error_data(0x1000|12, &err_data));
 534 }
 535
 536 #[test]
 537 fn test_simple_0conf_channel() {
 538         // If our peer tells us they will accept our channel with 0 confs, and we funded the channel,
 539         // we should trust the funding won't be double-spent (assuming `trust_own_funding_0conf` is
 540         // set)!
 541         // Further, if we `accept_inbound_channel_from_trusted_peer_0conf`, `channel_ready` messages
 542         // should fly immediately and the channel should be available for use as soon as they are
 543         // received.
 544
 545         let chanmon_cfgs = create_chanmon_cfgs(2);
 546         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 547         let mut chan_config = test_default_channel_config();
 548         chan_config.manually_accept_inbound_channels = true;
 549
 550         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 551         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 552
 553         open_zero_conf_channel(&nodes[0], &nodes[1], None);
 554
 555         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 556 }
 557
 558 #[test]
 559 fn test_0conf_channel_with_async_monitor() {
 560         // Test that we properly send out channel_ready in (both inbound- and outbound-) zero-conf
 561         // channels if ChannelMonitor updates return a `TemporaryFailure` during the initial channel
 562         // negotiation.
 563
 564         let chanmon_cfgs = create_chanmon_cfgs(3);
 565         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 566         let mut chan_config = test_default_channel_config();
 567         chan_config.manually_accept_inbound_channels = true;
 568         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(chan_config), None]);
 569         let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 570
 571         create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0);
 572
 573         chan_config.channel_handshake_config.announced_channel = false;
 574         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(chan_config)).unwrap();
 575         let open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 576
 577         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
 578         let events = nodes[1].node.get_and_clear_pending_events();
 579         assert_eq!(events.len(), 1);
 580         match events[0] {
 581                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 582                         nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(&temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).unwrap();
 583                 },
 584                 _ => panic!("Unexpected event"),
 585         };
 586
 587         let mut accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
 588         assert_eq!(accept_channel.minimum_depth, 0);
 589         nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &accept_channel);
 590
 591         let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&nodes[0], &nodes[1].node.get_our_node_id(), 100000, 42);
 592         nodes[0].node.funding_transaction_generated(&temporary_channel_id, &nodes[1].node.get_our_node_id(), tx.clone()).unwrap();
 593         let funding_created = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
 594
 595         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
 596         nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created);
 597         check_added_monitors!(nodes[1], 1);
 598         assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
 599
 600         let channel_id = funding_output.to_channel_id();
 601         nodes[1].chain_monitor.complete_sole_pending_chan_update(&channel_id);
 602
 603         let bs_signed_locked = nodes[1].node.get_and_clear_pending_msg_events();
 604         assert_eq!(bs_signed_locked.len(), 2);
 605         chanmon_cfgs[0].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
 606
 607         match &bs_signed_locked[0] {
 608                 MessageSendEvent::SendFundingSigned { node_id, msg } => {
 609                         assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 610                         nodes[0].node.handle_funding_signed(&nodes[1].node.get_our_node_id(), &msg);
 611                         check_added_monitors!(nodes[0], 1);
 612                 }
 613                 _ => panic!("Unexpected event"),
 614         }
 615         match &bs_signed_locked[1] {
 616                 MessageSendEvent::SendChannelReady { node_id, msg } => {
 617                         assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 618                         nodes[0].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &msg);
 619                 }
 620                 _ => panic!("Unexpected event"),
 621         }
 622
 623         assert!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().is_empty());
 624
 625         assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
 626         nodes[0].chain_monitor.complete_sole_pending_chan_update(&channel_id);
 627         let as_locked_update = nodes[0].node.get_and_clear_pending_msg_events();
 628
 629         // Note that the funding transaction is actually released when
 630         // get_and_clear_pending_msg_events, above, checks for monitor events.
 631         assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
 632         assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0)[0], tx);
 633
 634         match &as_locked_update[0] {
 635                 MessageSendEvent::SendChannelReady { node_id, msg } => {
 636                         assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 637                         nodes[1].node.handle_channel_ready(&nodes[0].node.get_our_node_id(), &msg);
 638                 }
 639                 _ => panic!("Unexpected event"),
 640         }
 641         expect_channel_ready_event(&nodes[0], &nodes[1].node.get_our_node_id());
 642         expect_channel_ready_event(&nodes[1], &nodes[0].node.get_our_node_id());
 643
 644         let bs_channel_update = get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
 645
 646         let as_channel_update = match &as_locked_update[1] {
 647                 MessageSendEvent::SendChannelUpdate { node_id, msg } => {
 648                         assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 649                         msg.clone()
 650                 }
 651                 _ => panic!("Unexpected event"),
 652         };
 653
 654         chanmon_cfgs[0].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
 655         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
 656
 657         nodes[0].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &bs_channel_update);
 658         nodes[1].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &as_channel_update);
 659
 660         assert_eq!(nodes[0].node.list_usable_channels().len(), 1);
 661         assert_eq!(nodes[1].node.list_usable_channels().len(), 2);
 662
 663         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 664
 665         // Now that we have useful channels, try sending a payment where the we hit a temporary monitor
 666         // failure before we've ever confirmed the funding transaction. This previously caused a panic.
 667         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], 1_000_000);
 668
 669         nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
 670         check_added_monitors!(nodes[0], 1);
 671
 672         let as_send = SendEvent::from_node(&nodes[0]);
 673         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_send.msgs[0]);
 674         nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_send.commitment_msg);
 675         check_added_monitors!(nodes[1], 1);
 676
 677         let (bs_raa, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 678         nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
 679         check_added_monitors!(nodes[0], 1);
 680
 681         nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_commitment_signed);
 682         check_added_monitors!(nodes[0], 1);
 683
 684         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
 685         nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id()));
 686         check_added_monitors!(nodes[1], 1);
 687         assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 688
 689         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
 690         let (outpoint, _, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&bs_raa.channel_id).unwrap().clone();
 691         nodes[1].chain_monitor.chain_monitor.channel_monitor_updated(outpoint, latest_update).unwrap();
 692         check_added_monitors!(nodes[1], 0);
 693         expect_pending_htlcs_forwardable!(nodes[1]);
 694         check_added_monitors!(nodes[1], 1);
 695
 696         let bs_send = SendEvent::from_node(&nodes[1]);
 697         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &bs_send.msgs[0]);
 698         commitment_signed_dance!(nodes[2], nodes[1], bs_send.commitment_msg, false);
 699         expect_pending_htlcs_forwardable!(nodes[2]);
 700         expect_payment_claimable!(nodes[2], payment_hash, payment_secret, 1_000_000);
 701         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
 702
 703         confirm_transaction(&nodes[0], &tx);
 704         confirm_transaction(&nodes[1], &tx);
 705
 706         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 707 }
 708
 709 #[test]
 710 fn test_0conf_close_no_early_chan_update() {
 711         // Tests that even with a public channel 0conf channel, we don't generate a channel_update on
 712         // closing.
 713         let chanmon_cfgs = create_chanmon_cfgs(2);
 714         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 715         let mut chan_config = test_default_channel_config();
 716         chan_config.manually_accept_inbound_channels = true;
 717
 718         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 719         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 720
 721         // This is the default but we force it on anyway
 722         chan_config.channel_handshake_config.announced_channel = true;
 723         open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
 724
 725         // We can use the channel immediately, but won't generate a channel_update until we get confs
 726         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 727
 728         nodes[0].node.force_close_all_channels_broadcasting_latest_txn();
 729         check_added_monitors!(nodes[0], 1);
 730         check_closed_event!(&nodes[0], 1, ClosureReason::HolderForceClosed);
 731         let _ = get_err_msg!(nodes[0], nodes[1].node.get_our_node_id());
 732 }
 733
 734 #[test]
 735 fn test_public_0conf_channel() {
 736         // Tests that we will announce a public channel (after confirmation) even if its 0conf.
 737         let chanmon_cfgs = create_chanmon_cfgs(2);
 738         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 739         let mut chan_config = test_default_channel_config();
 740         chan_config.manually_accept_inbound_channels = true;
 741
 742         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 743         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 744
 745         // This is the default but we force it on anyway
 746         chan_config.channel_handshake_config.announced_channel = true;
 747         let (tx, ..) = open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
 748
 749         // We can use the channel immediately, but we can't announce it until we get 6+ confirmations
 750         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 751
 752         let scid = confirm_transaction(&nodes[0], &tx);
 753         let as_announcement_sigs = get_event_msg!(nodes[0], MessageSendEvent::SendAnnouncementSignatures, nodes[1].node.get_our_node_id());
 754         assert_eq!(confirm_transaction(&nodes[1], &tx), scid);
 755         let bs_announcement_sigs = get_event_msg!(nodes[1], MessageSendEvent::SendAnnouncementSignatures, nodes[0].node.get_our_node_id());
 756
 757         nodes[1].node.handle_announcement_signatures(&nodes[0].node.get_our_node_id(), &as_announcement_sigs);
 758         nodes[0].node.handle_announcement_signatures(&nodes[1].node.get_our_node_id(), &bs_announcement_sigs);
 759
 760         let bs_announcement = nodes[1].node.get_and_clear_pending_msg_events();
 761         assert_eq!(bs_announcement.len(), 1);
 762         let announcement;
 763         let bs_update;
 764         match bs_announcement[0] {
 765                 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
 766                         announcement = msg.clone();
 767                         bs_update = update_msg.clone().unwrap();
 768                 },
 769                 _ => panic!("Unexpected event"),
 770         };
 771
 772         let as_announcement = nodes[0].node.get_and_clear_pending_msg_events();
 773         assert_eq!(as_announcement.len(), 1);
 774         match as_announcement[0] {
 775                 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
 776                         assert!(announcement == *msg);
 777                         let update_msg = update_msg.as_ref().unwrap();
 778                         assert_eq!(update_msg.contents.short_channel_id, scid);
 779                         assert_eq!(update_msg.contents.short_channel_id, announcement.contents.short_channel_id);
 780                         assert_eq!(update_msg.contents.short_channel_id, bs_update.contents.short_channel_id);
 781                 },
 782                 _ => panic!("Unexpected event"),
 783         };
 784 }
 785
 786 #[test]
 787 fn test_0conf_channel_reorg() {
 788         // If we accept a 0conf channel, which is then confirmed, but then changes SCID in a reorg, we
 789         // have to make sure we handle this correctly (or, currently, just force-close the channel).
 790
 791         let chanmon_cfgs = create_chanmon_cfgs(2);
 792         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 793         let mut chan_config = test_default_channel_config();
 794         chan_config.manually_accept_inbound_channels = true;
 795
 796         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 797         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 798
 799         // This is the default but we force it on anyway
 800         chan_config.channel_handshake_config.announced_channel = true;
 801         let (tx, ..) = open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
 802
 803         // We can use the channel immediately, but we can't announce it until we get 6+ confirmations
 804         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 805
 806         mine_transaction(&nodes[0], &tx);
 807         mine_transaction(&nodes[1], &tx);
 808
 809         // Send a payment using the channel's real SCID, which will be public in a few blocks once we
 810         // can generate a channel_announcement.
 811         let real_scid = nodes[0].node.list_usable_channels()[0].short_channel_id.unwrap();
 812         assert_eq!(nodes[1].node.list_usable_channels()[0].short_channel_id.unwrap(), real_scid);
 813
 814         let (mut route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[1], 10_000);
 815         assert_eq!(route.paths[0][0].short_channel_id, real_scid);
 816         send_along_route_with_secret(&nodes[0], route, &[&[&nodes[1]]], 10_000, payment_hash, payment_secret);
 817         claim_payment(&nodes[0], &[&nodes[1]], payment_preimage);
 818
 819         disconnect_blocks(&nodes[0], 1);
 820         disconnect_blocks(&nodes[1], 1);
 821
 822         // At this point the channel no longer has an SCID again. In the future we should likely
 823         // support simply un-setting the SCID and waiting until the channel gets re-confirmed, but for
 824         // now we force-close the channel here.
 825         check_closed_event!(&nodes[0], 1, ClosureReason::ProcessingError {
 826                 err: "Funding transaction was un-confirmed. Locked at 0 confs, now have 0 confs.".to_owned()
 827         });
 828         check_closed_broadcast!(nodes[0], true);
 829         check_closed_event!(&nodes[1], 1, ClosureReason::ProcessingError {
 830                 err: "Funding transaction was un-confirmed. Locked at 0 confs, now have 0 confs.".to_owned()
 831         });
 832         check_closed_broadcast!(nodes[1], true);
 833 }
 834
 835 #[test]
 836 fn test_zero_conf_accept_reject() {
 837         let mut channel_type_features = ChannelTypeFeatures::only_static_remote_key();
 838         channel_type_features.set_zero_conf_required();
 839
 840         // 1. Check we reject zero conf channels by default
 841         let chanmon_cfgs = create_chanmon_cfgs(2);
 842         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 843         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
 844         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 845
 846         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
 847         let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 848
 849         open_channel_msg.channel_type = Some(channel_type_features.clone());
 850
 851         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
 852
 853         let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 854         match msg_events[0] {
 855                 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg, .. }, .. } => {
 856                         assert_eq!(msg.data, "No zero confirmation channels accepted".to_owned());
 857                 },
 858                 _ => panic!(),
 859         }
 860
 861         // 2. Check we can manually accept zero conf channels via the right method
 862         let mut manually_accept_conf = UserConfig::default();
 863         manually_accept_conf.manually_accept_inbound_channels = true;
 864
 865         let chanmon_cfgs = create_chanmon_cfgs(2);
 866         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 867         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs,
 868                 &[None, Some(manually_accept_conf.clone())]);
 869         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 870
 871         // 2.1 First try the non-0conf method to manually accept
 872         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42,
 873                 Some(manually_accept_conf)).unwrap();
 874         let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel,
 875                 nodes[1].node.get_our_node_id());
 876
 877         open_channel_msg.channel_type = Some(channel_type_features.clone());
 878
 879         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
 880
 881         // Assert that `nodes[1]` has no `MessageSendEvent::SendAcceptChannel` in the `msg_events`.
 882         assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 883
 884         let events = nodes[1].node.get_and_clear_pending_events();
 885
 886         match events[0] {
 887                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 888                         // Assert we fail to accept via the non-0conf method
 889                         assert!(nodes[1].node.accept_inbound_channel(&temporary_channel_id,
 890                                 &nodes[0].node.get_our_node_id(), 0).is_err());
 891                 },
 892                 _ => panic!(),
 893         }
 894
 895         let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 896         match msg_events[0] {
 897                 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg, .. }, .. } => {
 898                         assert_eq!(msg.data, "No zero confirmation channels accepted".to_owned());
 899                 },
 900                 _ => panic!(),
 901         }
 902
 903         // 2.2 Try again with the 0conf method to manually accept
 904         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42,
 905                 Some(manually_accept_conf)).unwrap();
 906         let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel,
 907                 nodes[1].node.get_our_node_id());
 908
 909         open_channel_msg.channel_type = Some(channel_type_features);
 910
 911         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
 912
 913         let events = nodes[1].node.get_and_clear_pending_events();
 914
 915         match events[0] {
 916                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 917                         // Assert we can accept via the 0conf method
 918                         assert!(nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(
 919                                 &temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).is_ok());
 920                 },
 921                 _ => panic!(),
 922         }
 923
 924         // Check we would send accept
 925         let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 926         match msg_events[0] {
 927                 MessageSendEvent::SendAcceptChannel { .. } => {},
 928                 _ => panic!(),
 929         }
 930 }
 931
 932 #[test]
 933 fn test_connect_before_funding() {
 934         // Tests for a particularly dumb explicit panic that existed prior to 0.0.111 for 0conf
 935         // channels. If we received a block while awaiting funding for 0-conf channels we'd hit an
 936         // explicit panic when deciding if we should broadcast our channel_ready message.
 937         let chanmon_cfgs = create_chanmon_cfgs(2);
 938         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 939
 940         let mut manually_accept_conf = test_default_channel_config();
 941         manually_accept_conf.manually_accept_inbound_channels = true;
 942
 943         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(manually_accept_conf)]);
 944         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 945
 946         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100_000, 10_001, 42, None).unwrap();
 947         let open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 948
 949         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
 950         let events = nodes[1].node.get_and_clear_pending_events();
 951         assert_eq!(events.len(), 1);
 952         match events[0] {
 953                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 954                         nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(&temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).unwrap();
 955                 },
 956                 _ => panic!("Unexpected event"),
 957         };
 958
 959         let mut accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
 960         assert_eq!(accept_channel.minimum_depth, 0);
 961         nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &accept_channel);
 962
 963         let events = nodes[0].node.get_and_clear_pending_events();
 964         assert_eq!(events.len(), 1);
 965         match events[0] {
 966                 Event::FundingGenerationReady { .. } => {},
 967                 _ => panic!("Unexpected event"),
 968         }
 969
 970         connect_blocks(&nodes[0], 1);
 971         connect_blocks(&nodes[1], 1);
 972 }