1 // This file is Copyright its original authors, visible in version control
4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
7 // You may not use this file except in accordance with one or both of these
10 //! Tests that test ChannelManager behavior with fewer confirmations required than the default and
11 //! other behavior that exists only on private channels or with a semi-trusted counterparty (eg
14 use crate::chain::ChannelMonitorUpdateStatus;
15 use crate::chain::keysinterface::NodeSigner;
16 use crate::events::{ClosureReason, Event, HTLCDestination, MessageSendEvent, MessageSendEventsProvider};
17 use crate::ln::channelmanager::{ChannelManager, MIN_CLTV_EXPIRY_DELTA, PaymentId};
18 use crate::routing::gossip::RoutingFees;
19 use crate::routing::router::{PaymentParameters, RouteHint, RouteHintHop};
20 use crate::ln::features::ChannelTypeFeatures;
22 use crate::ln::msgs::{ChannelMessageHandler, RoutingMessageHandler, ChannelUpdate, ErrorAction};
23 use crate::ln::wire::Encode;
24 use crate::util::config::UserConfig;
25 use crate::util::ser::Writeable;
26 use crate::util::test_utils;
28 use crate::prelude::*;
29 use core::default::Default;
31 use crate::ln::functional_test_utils::*;
33 use bitcoin::blockdata::constants::genesis_block;
34 use bitcoin::network::constants::Network;
37 fn test_priv_forwarding_rejection() {
38 // If we have a private channel with outbound liquidity, and
39 // UserConfig::accept_forwards_to_priv_channels is set to false, we should reject any attempts
40 // to forward through that channel.
41 let chanmon_cfgs = create_chanmon_cfgs(3);
42 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
43 let mut no_announce_cfg = test_default_channel_config();
44 no_announce_cfg.accept_forwards_to_priv_channels = false;
45 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(no_announce_cfg), None]);
46 let persister: test_utils::TestPersister;
47 let new_chain_monitor: test_utils::TestChainMonitor;
48 let nodes_1_deserialized: ChannelManager<&test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestRouter, &test_utils::TestLogger>;
49 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
51 let chan_id_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000).2;
52 let chan_id_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 500_000_000).0.channel_id;
54 // We should always be able to forward through nodes[1] as long as its out through a public
56 send_payment(&nodes[2], &[&nodes[1], &nodes[0]], 10_000);
58 // ... however, if we send to nodes[2], we will have to pass the private channel from nodes[1]
59 // to nodes[2], which should be rejected:
60 let route_hint = RouteHint(vec![RouteHintHop {
61 src_node_id: nodes[1].node.get_our_node_id(),
62 short_channel_id: nodes[2].node.list_channels()[0].short_channel_id.unwrap(),
63 fees: RoutingFees { base_msat: 1000, proportional_millionths: 0 },
64 cltv_expiry_delta: MIN_CLTV_EXPIRY_DELTA,
65 htlc_minimum_msat: None,
66 htlc_maximum_msat: None,
68 let last_hops = vec![route_hint];
69 let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), TEST_FINAL_CLTV)
70 .with_features(nodes[2].node.invoice_features())
71 .with_route_hints(last_hops);
72 let (route, our_payment_hash, our_payment_preimage, our_payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 10_000, TEST_FINAL_CLTV);
74 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret), PaymentId(our_payment_hash.0)).unwrap();
75 check_added_monitors!(nodes[0], 1);
76 let payment_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
77 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
78 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false, true);
80 let htlc_fail_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
81 assert!(htlc_fail_updates.update_add_htlcs.is_empty());
82 assert_eq!(htlc_fail_updates.update_fail_htlcs.len(), 1);
83 assert!(htlc_fail_updates.update_fail_malformed_htlcs.is_empty());
84 assert!(htlc_fail_updates.update_fee.is_none());
86 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_fail_updates.update_fail_htlcs[0]);
87 commitment_signed_dance!(nodes[0], nodes[1], htlc_fail_updates.commitment_signed, true, true);
88 expect_payment_failed_with_update!(nodes[0], our_payment_hash, false, nodes[2].node.list_channels()[0].short_channel_id.unwrap(), true);
90 // Now disconnect nodes[1] from its peers and restart with accept_forwards_to_priv_channels set
91 // to true. Sadly there is currently no way to change it at runtime.
93 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id());
94 nodes[2].node.peer_disconnected(&nodes[1].node.get_our_node_id());
96 let nodes_1_serialized = nodes[1].node.encode();
97 let monitor_a_serialized = get_monitor!(nodes[1], chan_id_1).encode();
98 let monitor_b_serialized = get_monitor!(nodes[1], chan_id_2).encode();
100 no_announce_cfg.accept_forwards_to_priv_channels = true;
101 reload_node!(nodes[1], no_announce_cfg, &nodes_1_serialized, &[&monitor_a_serialized, &monitor_b_serialized], persister, new_chain_monitor, nodes_1_deserialized);
103 nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: nodes[1].node.init_features(), remote_network_address: None }, true).unwrap();
104 nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: nodes[0].node.init_features(), remote_network_address: None }, false).unwrap();
105 let as_reestablish = get_chan_reestablish_msgs!(nodes[0], nodes[1]).pop().unwrap();
106 let bs_reestablish = get_chan_reestablish_msgs!(nodes[1], nodes[0]).pop().unwrap();
107 nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &as_reestablish);
108 nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
109 get_event_msg!(nodes[0], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
110 get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
112 nodes[1].node.peer_connected(&nodes[2].node.get_our_node_id(), &msgs::Init { features: nodes[2].node.init_features(), remote_network_address: None }, true).unwrap();
113 nodes[2].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: nodes[1].node.init_features(), remote_network_address: None }, false).unwrap();
114 let bs_reestablish = get_chan_reestablish_msgs!(nodes[1], nodes[2]).pop().unwrap();
115 let cs_reestablish = get_chan_reestablish_msgs!(nodes[2], nodes[1]).pop().unwrap();
116 nodes[2].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
117 nodes[1].node.handle_channel_reestablish(&nodes[2].node.get_our_node_id(), &cs_reestablish);
118 get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
119 get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
121 nodes[0].node.send_payment(&route, our_payment_hash, &Some(our_payment_secret), PaymentId(our_payment_hash.0)).unwrap();
122 check_added_monitors!(nodes[0], 1);
123 pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 10_000, our_payment_hash, our_payment_secret);
124 claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], our_payment_preimage);
127 fn do_test_1_conf_open(connect_style: ConnectStyle) {
128 // Previously, if the minium_depth config was set to 1, we'd never send a channel_ready. This
129 // tests that we properly send one in that case.
130 let mut alice_config = UserConfig::default();
131 alice_config.channel_handshake_config.minimum_depth = 1;
132 alice_config.channel_handshake_config.announced_channel = true;
133 alice_config.channel_handshake_limits.force_announced_channel_preference = false;
134 let mut bob_config = UserConfig::default();
135 bob_config.channel_handshake_config.minimum_depth = 1;
136 bob_config.channel_handshake_config.announced_channel = true;
137 bob_config.channel_handshake_limits.force_announced_channel_preference = false;
138 let chanmon_cfgs = create_chanmon_cfgs(2);
139 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
140 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[Some(alice_config), Some(bob_config)]);
141 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
142 *nodes[0].connect_style.borrow_mut() = connect_style;
144 let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001);
145 mine_transaction(&nodes[1], &tx);
146 nodes[0].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendChannelReady, nodes[0].node.get_our_node_id()));
147 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
149 mine_transaction(&nodes[0], &tx);
150 let as_msg_events = nodes[0].node.get_and_clear_pending_msg_events();
151 assert_eq!(as_msg_events.len(), 2);
152 let as_channel_ready = if let MessageSendEvent::SendChannelReady { ref node_id, ref msg } = as_msg_events[0] {
153 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
155 } else { panic!("Unexpected event"); };
156 if let MessageSendEvent::SendChannelUpdate { ref node_id, msg: _ } = as_msg_events[1] {
157 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
158 } else { panic!("Unexpected event"); }
160 nodes[1].node.handle_channel_ready(&nodes[0].node.get_our_node_id(), &as_channel_ready);
161 expect_channel_ready_event(&nodes[0], &nodes[1].node.get_our_node_id());
162 expect_channel_ready_event(&nodes[1], &nodes[0].node.get_our_node_id());
163 let bs_msg_events = nodes[1].node.get_and_clear_pending_msg_events();
164 assert_eq!(bs_msg_events.len(), 1);
165 if let MessageSendEvent::SendChannelUpdate { ref node_id, msg: _ } = bs_msg_events[0] {
166 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
167 } else { panic!("Unexpected event"); }
169 send_payment(&nodes[0], &[&nodes[1]], 100_000);
171 // After 6 confirmations, as required by the spec, we'll send announcement_signatures and
172 // broadcast the channel_announcement (but not before exactly 6 confirmations).
173 connect_blocks(&nodes[0], 4);
174 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
175 connect_blocks(&nodes[0], 1);
176 nodes[1].node.handle_announcement_signatures(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendAnnouncementSignatures, nodes[1].node.get_our_node_id()));
177 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
179 connect_blocks(&nodes[1], 5);
180 let bs_announce_events = nodes[1].node.get_and_clear_pending_msg_events();
181 assert_eq!(bs_announce_events.len(), 2);
182 let bs_announcement_sigs = if let MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } = bs_announce_events[0] {
183 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
185 } else { panic!("Unexpected event"); };
186 let (bs_announcement, bs_update) = if let MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } = bs_announce_events[1] {
187 (msg.clone(), update_msg.clone().unwrap())
188 } else { panic!("Unexpected event"); };
190 nodes[0].node.handle_announcement_signatures(&nodes[1].node.get_our_node_id(), &bs_announcement_sigs);
191 let as_announce_events = nodes[0].node.get_and_clear_pending_msg_events();
192 assert_eq!(as_announce_events.len(), 1);
193 let (announcement, as_update) = if let MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } = as_announce_events[0] {
194 (msg.clone(), update_msg.clone().unwrap())
195 } else { panic!("Unexpected event"); };
196 assert_eq!(announcement, bs_announcement);
199 assert!(node.gossip_sync.handle_channel_announcement(&announcement).unwrap());
200 node.gossip_sync.handle_channel_update(&as_update).unwrap();
201 node.gossip_sync.handle_channel_update(&bs_update).unwrap();
205 fn test_1_conf_open() {
206 do_test_1_conf_open(ConnectStyle::BestBlockFirst);
207 do_test_1_conf_open(ConnectStyle::TransactionsFirst);
208 do_test_1_conf_open(ConnectStyle::FullBlockViaListen);
212 fn test_routed_scid_alias() {
213 // Trivially test sending a payment which is routed through an SCID alias.
214 let chanmon_cfgs = create_chanmon_cfgs(3);
215 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
216 let mut no_announce_cfg = test_default_channel_config();
217 no_announce_cfg.accept_forwards_to_priv_channels = true;
218 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(no_announce_cfg), None]);
219 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
221 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000).2;
222 let mut as_channel_ready = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 500_000_000).0;
224 let last_hop = nodes[2].node.list_usable_channels();
225 let hop_hints = vec![RouteHint(vec![RouteHintHop {
226 src_node_id: nodes[1].node.get_our_node_id(),
227 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
229 base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
230 proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
232 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
233 htlc_maximum_msat: None,
234 htlc_minimum_msat: None,
236 let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
237 .with_features(nodes[2].node.invoice_features())
238 .with_route_hints(hop_hints);
239 let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 100_000, 42);
240 assert_eq!(route.paths[0][1].short_channel_id, last_hop[0].inbound_scid_alias.unwrap());
241 nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
242 check_added_monitors!(nodes[0], 1);
244 pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 100_000, payment_hash, payment_secret);
246 as_channel_ready.short_channel_id_alias = Some(0xeadbeef);
247 nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &as_channel_ready);
248 // Note that we always respond to a channel_ready with a channel_update. Not a lot of reason
249 // to bother updating that code, so just drop the message here.
250 get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
252 claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
254 // Now test that if a peer sends us a second channel_ready after the channel is operational we
255 // will use the new alias.
256 as_channel_ready.short_channel_id_alias = Some(0xdeadbeef);
257 nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &as_channel_ready);
258 // Note that we always respond to a channel_ready with a channel_update. Not a lot of reason
259 // to bother updating that code, so just drop the message here.
260 get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
261 let updated_channel_info = nodes[2].node.list_usable_channels();
262 assert_eq!(updated_channel_info.len(), 1);
263 assert_eq!(updated_channel_info[0].inbound_scid_alias.unwrap(), 0xdeadbeef);
264 // Note that because we never send a duplicate channel_ready we can't send a payment through
265 // the 0xdeadbeef SCID alias.
269 fn test_scid_privacy_on_pub_channel() {
270 // Tests rejecting the scid_privacy feature for public channels and that we don't ever try to
272 let chanmon_cfgs = create_chanmon_cfgs(2);
273 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
274 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
275 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
277 let mut scid_privacy_cfg = test_default_channel_config();
278 scid_privacy_cfg.channel_handshake_config.announced_channel = true;
279 scid_privacy_cfg.channel_handshake_config.negotiate_scid_privacy = true;
280 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(scid_privacy_cfg)).unwrap();
281 let mut open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
283 assert!(!open_channel.channel_type.as_ref().unwrap().supports_scid_privacy()); // we ignore `negotiate_scid_privacy` on pub channels
284 open_channel.channel_type.as_mut().unwrap().set_scid_privacy_required();
285 assert_eq!(open_channel.channel_flags & 1, 1); // The `announce_channel` bit is set.
287 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
288 let err = get_err_msg(&nodes[1], &nodes[0].node.get_our_node_id());
289 assert_eq!(err.data, "SCID Alias/Privacy Channel Type cannot be set on a public channel");
293 fn test_scid_privacy_negotiation() {
294 // Tests of the negotiation of SCID alias and falling back to non-SCID-alias if our
295 // counterparty doesn't support it.
296 let chanmon_cfgs = create_chanmon_cfgs(2);
297 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
298 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
299 let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
301 let mut scid_privacy_cfg = test_default_channel_config();
302 scid_privacy_cfg.channel_handshake_config.announced_channel = false;
303 scid_privacy_cfg.channel_handshake_config.negotiate_scid_privacy = true;
304 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(scid_privacy_cfg)).unwrap();
306 let init_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
307 assert!(init_open_channel.channel_type.as_ref().unwrap().supports_scid_privacy());
308 assert!(nodes[0].node.list_channels()[0].channel_type.is_none()); // channel_type is none until counterparty accepts
310 // now simulate nodes[1] responding with an Error message, indicating it doesn't understand
312 nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage {
313 channel_id: init_open_channel.temporary_channel_id,
314 data: "Yo, no SCID aliases, no privacy here!".to_string()
316 assert!(nodes[0].node.list_channels()[0].channel_type.is_none()); // channel_type is none until counterparty accepts
318 let second_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
319 assert!(!second_open_channel.channel_type.as_ref().unwrap().supports_scid_privacy());
320 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &second_open_channel);
321 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id()));
323 let events = nodes[0].node.get_and_clear_pending_events();
324 assert_eq!(events.len(), 1);
326 Event::FundingGenerationReady { .. } => {},
327 _ => panic!("Unexpected event"),
330 assert!(!nodes[0].node.list_channels()[0].channel_type.as_ref().unwrap().supports_scid_privacy());
331 assert!(!nodes[1].node.list_channels()[0].channel_type.as_ref().unwrap().supports_scid_privacy());
335 fn test_inbound_scid_privacy() {
336 // Tests accepting channels with the scid_privacy feature and rejecting forwards using the
337 // channel's real SCID as required by the channel feature.
338 let chanmon_cfgs = create_chanmon_cfgs(3);
339 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
340 let mut accept_forward_cfg = test_default_channel_config();
341 accept_forward_cfg.accept_forwards_to_priv_channels = true;
342 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(accept_forward_cfg), None]);
343 let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
345 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
347 let mut no_announce_cfg = test_default_channel_config();
348 no_announce_cfg.channel_handshake_config.announced_channel = false;
349 no_announce_cfg.channel_handshake_config.negotiate_scid_privacy = true;
350 nodes[1].node.create_channel(nodes[2].node.get_our_node_id(), 100_000, 10_000, 42, Some(no_announce_cfg)).unwrap();
351 let mut open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[2].node.get_our_node_id());
353 assert!(open_channel.channel_type.as_ref().unwrap().requires_scid_privacy());
355 nodes[2].node.handle_open_channel(&nodes[1].node.get_our_node_id(), &open_channel);
356 let accept_channel = get_event_msg!(nodes[2], MessageSendEvent::SendAcceptChannel, nodes[1].node.get_our_node_id());
357 nodes[1].node.handle_accept_channel(&nodes[2].node.get_our_node_id(), &accept_channel);
359 let (temporary_channel_id, tx, _) = create_funding_transaction(&nodes[1], &nodes[2].node.get_our_node_id(), 100_000, 42);
360 nodes[1].node.funding_transaction_generated(&temporary_channel_id, &nodes[2].node.get_our_node_id(), tx.clone()).unwrap();
361 nodes[2].node.handle_funding_created(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendFundingCreated, nodes[2].node.get_our_node_id()));
362 check_added_monitors!(nodes[2], 1);
364 let cs_funding_signed = get_event_msg!(nodes[2], MessageSendEvent::SendFundingSigned, nodes[1].node.get_our_node_id());
365 expect_channel_pending_event(&nodes[2], &nodes[1].node.get_our_node_id());
367 nodes[1].node.handle_funding_signed(&nodes[2].node.get_our_node_id(), &cs_funding_signed);
368 expect_channel_pending_event(&nodes[1], &nodes[2].node.get_our_node_id());
369 check_added_monitors!(nodes[1], 1);
371 let conf_height = core::cmp::max(nodes[1].best_block_info().1 + 1, nodes[2].best_block_info().1 + 1);
372 confirm_transaction_at(&nodes[1], &tx, conf_height);
373 connect_blocks(&nodes[1], CHAN_CONFIRM_DEPTH - 1);
374 confirm_transaction_at(&nodes[2], &tx, conf_height);
375 connect_blocks(&nodes[2], CHAN_CONFIRM_DEPTH - 1);
376 let bs_channel_ready = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReady, nodes[2].node.get_our_node_id());
377 nodes[1].node.handle_channel_ready(&nodes[2].node.get_our_node_id(), &get_event_msg!(nodes[2], MessageSendEvent::SendChannelReady, nodes[1].node.get_our_node_id()));
378 expect_channel_ready_event(&nodes[1], &nodes[2].node.get_our_node_id());
379 let bs_update = get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
380 nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &bs_channel_ready);
381 expect_channel_ready_event(&nodes[2], &nodes[1].node.get_our_node_id());
382 let cs_update = get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
384 nodes[1].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &cs_update);
385 nodes[2].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &bs_update);
387 // Now we can pay just fine using the SCID alias nodes[2] gave to nodes[1]...
389 let last_hop = nodes[2].node.list_usable_channels();
390 let mut hop_hints = vec![RouteHint(vec![RouteHintHop {
391 src_node_id: nodes[1].node.get_our_node_id(),
392 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
394 base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
395 proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
397 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
398 htlc_maximum_msat: None,
399 htlc_minimum_msat: None,
401 let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
402 .with_features(nodes[2].node.invoice_features())
403 .with_route_hints(hop_hints.clone());
404 let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 100_000, 42);
405 assert_eq!(route.paths[0][1].short_channel_id, last_hop[0].inbound_scid_alias.unwrap());
406 nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
407 check_added_monitors!(nodes[0], 1);
409 pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 100_000, payment_hash, payment_secret);
410 claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
412 // ... but if we try to pay using the real SCID, nodes[1] will just tell us they don't know
413 // what channel we're talking about.
414 hop_hints[0].0[0].short_channel_id = last_hop[0].short_channel_id.unwrap();
416 let payment_params_2 = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
417 .with_features(nodes[2].node.invoice_features())
418 .with_route_hints(hop_hints);
419 let (route_2, payment_hash_2, _, payment_secret_2) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params_2, 100_000, 42);
420 assert_eq!(route_2.paths[0][1].short_channel_id, last_hop[0].short_channel_id.unwrap());
421 nodes[0].node.send_payment(&route_2, payment_hash_2, &Some(payment_secret_2), PaymentId(payment_hash_2.0)).unwrap();
422 check_added_monitors!(nodes[0], 1);
424 let payment_event = SendEvent::from_node(&nodes[0]);
425 assert_eq!(nodes[1].node.get_our_node_id(), payment_event.node_id);
426 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
427 commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, true, true);
429 nodes[1].logger.assert_log_regex("lightning::ln::channelmanager", regex::Regex::new(r"Refusing to forward over real channel SCID as our counterparty requested").unwrap(), 1);
431 let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
432 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
433 commitment_signed_dance!(nodes[0], nodes[1], updates.commitment_signed, false);
435 expect_payment_failed_conditions(&nodes[0], payment_hash_2, false,
436 PaymentFailedConditions::new().blamed_scid(last_hop[0].short_channel_id.unwrap())
437 .blamed_chan_closed(true).expected_htlc_error_data(0x4000|10, &[0; 0]));
441 fn test_scid_alias_returned() {
442 // Tests that when we fail an HTLC (in this case due to attempting to forward more than the
443 // channel's available balance) we use the correct (in this case the aliased) SCID in the
444 // channel_update which is returned in the onion to the sender.
445 let chanmon_cfgs = create_chanmon_cfgs(3);
446 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
447 let mut accept_forward_cfg = test_default_channel_config();
448 accept_forward_cfg.accept_forwards_to_priv_channels = true;
449 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(accept_forward_cfg), None]);
450 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
452 create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 10_000_000, 0);
453 let chan = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 10_000, 0);
455 let last_hop = nodes[2].node.list_usable_channels();
456 let mut hop_hints = vec![RouteHint(vec![RouteHintHop {
457 src_node_id: nodes[1].node.get_our_node_id(),
458 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
460 base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
461 proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
463 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
464 htlc_maximum_msat: None,
465 htlc_minimum_msat: None,
467 let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
468 .with_features(nodes[2].node.invoice_features())
469 .with_route_hints(hop_hints);
470 let (mut route, payment_hash, _, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 10_000, 42);
471 assert_eq!(route.paths[0][1].short_channel_id, nodes[2].node.list_usable_channels()[0].inbound_scid_alias.unwrap());
473 route.paths[0][1].fee_msat = 10_000_000; // Overshoot the last channel's value
475 // Route the HTLC through to the destination.
476 nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
477 check_added_monitors!(nodes[0], 1);
478 let as_updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
479 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_updates.update_add_htlcs[0]);
480 commitment_signed_dance!(nodes[1], nodes[0], &as_updates.commitment_signed, false, true);
482 expect_pending_htlcs_forwardable!(nodes[1]);
483 expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCDestination::NextHopChannel { node_id: Some(nodes[2].node.get_our_node_id()), channel_id: chan.0.channel_id }]);
484 check_added_monitors!(nodes[1], 1);
486 let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
487 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
488 commitment_signed_dance!(nodes[0], nodes[1], bs_updates.commitment_signed, false, true);
490 // Build the expected channel update
491 let contents = msgs::UnsignedChannelUpdate {
492 chain_hash: genesis_block(Network::Testnet).header.block_hash(),
493 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
496 cltv_expiry_delta: accept_forward_cfg.channel_config.cltv_expiry_delta,
497 htlc_minimum_msat: 1_000,
498 htlc_maximum_msat: 1_000_000, // Defaults to 10% of the channel value
499 fee_base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
500 fee_proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
501 excess_data: Vec::new(),
503 let signature = nodes[1].keys_manager.sign_gossip_message(msgs::UnsignedGossipMessage::ChannelUpdate(&contents)).unwrap();
504 let msg = msgs::ChannelUpdate { signature, contents };
506 let mut err_data = Vec::new();
507 err_data.extend_from_slice(&(msg.serialized_length() as u16 + 2).to_be_bytes());
508 err_data.extend_from_slice(&ChannelUpdate::TYPE.to_be_bytes());
509 err_data.extend_from_slice(&msg.encode());
511 expect_payment_failed_conditions(&nodes[0], payment_hash, false,
512 PaymentFailedConditions::new().blamed_scid(last_hop[0].inbound_scid_alias.unwrap())
513 .blamed_chan_closed(false).expected_htlc_error_data(0x1000|7, &err_data));
515 route.paths[0][1].fee_msat = 10_000; // Reset to the correct payment amount
516 route.paths[0][0].fee_msat = 0; // But set fee paid to the middle hop to 0
518 // Route the HTLC through to the destination.
519 nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
520 check_added_monitors!(nodes[0], 1);
521 let as_updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
522 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_updates.update_add_htlcs[0]);
523 commitment_signed_dance!(nodes[1], nodes[0], &as_updates.commitment_signed, false, true);
525 let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
526 nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
527 commitment_signed_dance!(nodes[0], nodes[1], bs_updates.commitment_signed, false, true);
529 let mut err_data = Vec::new();
530 err_data.extend_from_slice(&10_000u64.to_be_bytes());
531 err_data.extend_from_slice(&(msg.serialized_length() as u16 + 2).to_be_bytes());
532 err_data.extend_from_slice(&ChannelUpdate::TYPE.to_be_bytes());
533 err_data.extend_from_slice(&msg.encode());
534 expect_payment_failed_conditions(&nodes[0], payment_hash, false,
535 PaymentFailedConditions::new().blamed_scid(last_hop[0].inbound_scid_alias.unwrap())
536 .blamed_chan_closed(false).expected_htlc_error_data(0x1000|12, &err_data));
540 fn test_simple_0conf_channel() {
541 // If our peer tells us they will accept our channel with 0 confs, and we funded the channel,
542 // we should trust the funding won't be double-spent (assuming `trust_own_funding_0conf` is
544 // Further, if we `accept_inbound_channel_from_trusted_peer_0conf`, `channel_ready` messages
545 // should fly immediately and the channel should be available for use as soon as they are
548 let chanmon_cfgs = create_chanmon_cfgs(2);
549 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
550 let mut chan_config = test_default_channel_config();
551 chan_config.manually_accept_inbound_channels = true;
553 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
554 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
556 open_zero_conf_channel(&nodes[0], &nodes[1], None);
558 send_payment(&nodes[0], &[&nodes[1]], 100_000);
562 fn test_0conf_channel_with_async_monitor() {
563 // Test that we properly send out channel_ready in (both inbound- and outbound-) zero-conf
564 // channels if ChannelMonitor updates return a `TemporaryFailure` during the initial channel
567 let chanmon_cfgs = create_chanmon_cfgs(3);
568 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
569 let mut chan_config = test_default_channel_config();
570 chan_config.manually_accept_inbound_channels = true;
571 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(chan_config), None]);
572 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
574 create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0);
576 chan_config.channel_handshake_config.announced_channel = false;
577 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(chan_config)).unwrap();
578 let open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
580 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
581 let events = nodes[1].node.get_and_clear_pending_events();
582 assert_eq!(events.len(), 1);
584 Event::OpenChannelRequest { temporary_channel_id, .. } => {
585 nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(&temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).unwrap();
587 _ => panic!("Unexpected event"),
590 let mut accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
591 assert_eq!(accept_channel.minimum_depth, 0);
592 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &accept_channel);
594 let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&nodes[0], &nodes[1].node.get_our_node_id(), 100000, 42);
595 nodes[0].node.funding_transaction_generated(&temporary_channel_id, &nodes[1].node.get_our_node_id(), tx.clone()).unwrap();
596 let funding_created = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
598 chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
599 nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created);
600 check_added_monitors!(nodes[1], 1);
601 assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
603 let channel_id = funding_output.to_channel_id();
604 nodes[1].chain_monitor.complete_sole_pending_chan_update(&channel_id);
605 expect_channel_pending_event(&nodes[1], &nodes[0].node.get_our_node_id());
607 let bs_signed_locked = nodes[1].node.get_and_clear_pending_msg_events();
608 assert_eq!(bs_signed_locked.len(), 2);
609 chanmon_cfgs[0].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
611 match &bs_signed_locked[0] {
612 MessageSendEvent::SendFundingSigned { node_id, msg } => {
613 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
614 nodes[0].node.handle_funding_signed(&nodes[1].node.get_our_node_id(), &msg);
615 check_added_monitors!(nodes[0], 1);
617 _ => panic!("Unexpected event"),
619 match &bs_signed_locked[1] {
620 MessageSendEvent::SendChannelReady { node_id, msg } => {
621 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
622 nodes[0].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &msg);
624 _ => panic!("Unexpected event"),
627 assert!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().is_empty());
629 assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
630 nodes[0].chain_monitor.complete_sole_pending_chan_update(&channel_id);
632 let events = nodes[0].node.get_and_clear_pending_events();
633 assert_eq!(events.len(), 2);
635 crate::events::Event::ChannelPending { ref counterparty_node_id, .. } => {
636 assert_eq!(nodes[1].node.get_our_node_id(), *counterparty_node_id);
638 _ => panic!("Unexpected event"),
641 crate::events::Event::ChannelReady { ref counterparty_node_id, .. } => {
642 assert_eq!(nodes[1].node.get_our_node_id(), *counterparty_node_id);
644 _ => panic!("Unexpected event"),
647 let as_locked_update = nodes[0].node.get_and_clear_pending_msg_events();
649 // Note that the funding transaction is actually released when
650 // get_and_clear_pending_msg_events, above, checks for monitor events.
651 assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
652 assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0)[0], tx);
654 match &as_locked_update[0] {
655 MessageSendEvent::SendChannelReady { node_id, msg } => {
656 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
657 nodes[1].node.handle_channel_ready(&nodes[0].node.get_our_node_id(), &msg);
659 _ => panic!("Unexpected event"),
661 expect_channel_ready_event(&nodes[1], &nodes[0].node.get_our_node_id());
663 let bs_channel_update = get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
665 let as_channel_update = match &as_locked_update[1] {
666 MessageSendEvent::SendChannelUpdate { node_id, msg } => {
667 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
670 _ => panic!("Unexpected event"),
673 chanmon_cfgs[0].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
674 chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
676 nodes[0].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &bs_channel_update);
677 nodes[1].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &as_channel_update);
679 assert_eq!(nodes[0].node.list_usable_channels().len(), 1);
680 assert_eq!(nodes[1].node.list_usable_channels().len(), 2);
682 send_payment(&nodes[0], &[&nodes[1]], 100_000);
684 // Now that we have useful channels, try sending a payment where the we hit a temporary monitor
685 // failure before we've ever confirmed the funding transaction. This previously caused a panic.
686 let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], 1_000_000);
688 nodes[0].node.send_payment(&route, payment_hash, &Some(payment_secret), PaymentId(payment_hash.0)).unwrap();
689 check_added_monitors!(nodes[0], 1);
691 let as_send = SendEvent::from_node(&nodes[0]);
692 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_send.msgs[0]);
693 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_send.commitment_msg);
694 check_added_monitors!(nodes[1], 1);
696 let (bs_raa, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
697 nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
698 check_added_monitors!(nodes[0], 1);
700 nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_commitment_signed);
701 check_added_monitors!(nodes[0], 1);
703 chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
704 nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id()));
705 check_added_monitors!(nodes[1], 1);
706 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
708 chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
709 let (outpoint, _, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&bs_raa.channel_id).unwrap().clone();
710 nodes[1].chain_monitor.chain_monitor.channel_monitor_updated(outpoint, latest_update).unwrap();
711 check_added_monitors!(nodes[1], 0);
712 expect_pending_htlcs_forwardable!(nodes[1]);
713 check_added_monitors!(nodes[1], 1);
715 let bs_send = SendEvent::from_node(&nodes[1]);
716 nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &bs_send.msgs[0]);
717 commitment_signed_dance!(nodes[2], nodes[1], bs_send.commitment_msg, false);
718 expect_pending_htlcs_forwardable!(nodes[2]);
719 expect_payment_claimable!(nodes[2], payment_hash, payment_secret, 1_000_000);
720 claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
722 confirm_transaction(&nodes[0], &tx);
723 confirm_transaction(&nodes[1], &tx);
725 send_payment(&nodes[0], &[&nodes[1]], 100_000);
729 fn test_0conf_close_no_early_chan_update() {
730 // Tests that even with a public channel 0conf channel, we don't generate a channel_update on
732 let chanmon_cfgs = create_chanmon_cfgs(2);
733 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
734 let mut chan_config = test_default_channel_config();
735 chan_config.manually_accept_inbound_channels = true;
737 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
738 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
740 // This is the default but we force it on anyway
741 chan_config.channel_handshake_config.announced_channel = true;
742 open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
744 // We can use the channel immediately, but won't generate a channel_update until we get confs
745 send_payment(&nodes[0], &[&nodes[1]], 100_000);
747 nodes[0].node.force_close_all_channels_broadcasting_latest_txn();
748 check_added_monitors!(nodes[0], 1);
749 check_closed_event!(&nodes[0], 1, ClosureReason::HolderForceClosed);
750 let _ = get_err_msg(&nodes[0], &nodes[1].node.get_our_node_id());
754 fn test_public_0conf_channel() {
755 // Tests that we will announce a public channel (after confirmation) even if its 0conf.
756 let chanmon_cfgs = create_chanmon_cfgs(2);
757 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
758 let mut chan_config = test_default_channel_config();
759 chan_config.manually_accept_inbound_channels = true;
761 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
762 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
764 // This is the default but we force it on anyway
765 chan_config.channel_handshake_config.announced_channel = true;
766 let (tx, ..) = open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
768 // We can use the channel immediately, but we can't announce it until we get 6+ confirmations
769 send_payment(&nodes[0], &[&nodes[1]], 100_000);
771 let scid = confirm_transaction(&nodes[0], &tx);
772 let as_announcement_sigs = get_event_msg!(nodes[0], MessageSendEvent::SendAnnouncementSignatures, nodes[1].node.get_our_node_id());
773 assert_eq!(confirm_transaction(&nodes[1], &tx), scid);
774 let bs_announcement_sigs = get_event_msg!(nodes[1], MessageSendEvent::SendAnnouncementSignatures, nodes[0].node.get_our_node_id());
776 nodes[1].node.handle_announcement_signatures(&nodes[0].node.get_our_node_id(), &as_announcement_sigs);
777 nodes[0].node.handle_announcement_signatures(&nodes[1].node.get_our_node_id(), &bs_announcement_sigs);
779 let bs_announcement = nodes[1].node.get_and_clear_pending_msg_events();
780 assert_eq!(bs_announcement.len(), 1);
783 match bs_announcement[0] {
784 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
785 announcement = msg.clone();
786 bs_update = update_msg.clone().unwrap();
788 _ => panic!("Unexpected event"),
791 let as_announcement = nodes[0].node.get_and_clear_pending_msg_events();
792 assert_eq!(as_announcement.len(), 1);
793 match as_announcement[0] {
794 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
795 assert!(announcement == *msg);
796 let update_msg = update_msg.as_ref().unwrap();
797 assert_eq!(update_msg.contents.short_channel_id, scid);
798 assert_eq!(update_msg.contents.short_channel_id, announcement.contents.short_channel_id);
799 assert_eq!(update_msg.contents.short_channel_id, bs_update.contents.short_channel_id);
801 _ => panic!("Unexpected event"),
806 fn test_0conf_channel_reorg() {
807 // If we accept a 0conf channel, which is then confirmed, but then changes SCID in a reorg, we
808 // have to make sure we handle this correctly (or, currently, just force-close the channel).
810 let chanmon_cfgs = create_chanmon_cfgs(2);
811 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
812 let mut chan_config = test_default_channel_config();
813 chan_config.manually_accept_inbound_channels = true;
815 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
816 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
818 // This is the default but we force it on anyway
819 chan_config.channel_handshake_config.announced_channel = true;
820 let (tx, ..) = open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
822 // We can use the channel immediately, but we can't announce it until we get 6+ confirmations
823 send_payment(&nodes[0], &[&nodes[1]], 100_000);
825 mine_transaction(&nodes[0], &tx);
826 mine_transaction(&nodes[1], &tx);
828 // Send a payment using the channel's real SCID, which will be public in a few blocks once we
829 // can generate a channel_announcement.
830 let real_scid = nodes[0].node.list_usable_channels()[0].short_channel_id.unwrap();
831 assert_eq!(nodes[1].node.list_usable_channels()[0].short_channel_id.unwrap(), real_scid);
833 let (mut route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[1], 10_000);
834 assert_eq!(route.paths[0][0].short_channel_id, real_scid);
835 send_along_route_with_secret(&nodes[0], route, &[&[&nodes[1]]], 10_000, payment_hash, payment_secret);
836 claim_payment(&nodes[0], &[&nodes[1]], payment_preimage);
838 disconnect_blocks(&nodes[0], 1);
839 disconnect_blocks(&nodes[1], 1);
841 // At this point the channel no longer has an SCID again. In the future we should likely
842 // support simply un-setting the SCID and waiting until the channel gets re-confirmed, but for
843 // now we force-close the channel here.
844 check_closed_event!(&nodes[0], 1, ClosureReason::ProcessingError {
845 err: "Funding transaction was un-confirmed. Locked at 0 confs, now have 0 confs.".to_owned()
847 check_closed_broadcast!(nodes[0], true);
848 check_closed_event!(&nodes[1], 1, ClosureReason::ProcessingError {
849 err: "Funding transaction was un-confirmed. Locked at 0 confs, now have 0 confs.".to_owned()
851 check_closed_broadcast!(nodes[1], true);
855 fn test_zero_conf_accept_reject() {
856 let mut channel_type_features = ChannelTypeFeatures::only_static_remote_key();
857 channel_type_features.set_zero_conf_required();
859 // 1. Check we reject zero conf channels by default
860 let chanmon_cfgs = create_chanmon_cfgs(2);
861 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
862 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
863 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
865 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
866 let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
868 open_channel_msg.channel_type = Some(channel_type_features.clone());
870 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
872 let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
873 match msg_events[0] {
874 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg, .. }, .. } => {
875 assert_eq!(msg.data, "No zero confirmation channels accepted".to_owned());
880 // 2. Check we can manually accept zero conf channels via the right method
881 let mut manually_accept_conf = UserConfig::default();
882 manually_accept_conf.manually_accept_inbound_channels = true;
884 let chanmon_cfgs = create_chanmon_cfgs(2);
885 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
886 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs,
887 &[None, Some(manually_accept_conf.clone())]);
888 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
890 // 2.1 First try the non-0conf method to manually accept
891 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42,
892 Some(manually_accept_conf)).unwrap();
893 let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel,
894 nodes[1].node.get_our_node_id());
896 open_channel_msg.channel_type = Some(channel_type_features.clone());
898 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
900 // Assert that `nodes[1]` has no `MessageSendEvent::SendAcceptChannel` in the `msg_events`.
901 assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
903 let events = nodes[1].node.get_and_clear_pending_events();
906 Event::OpenChannelRequest { temporary_channel_id, .. } => {
907 // Assert we fail to accept via the non-0conf method
908 assert!(nodes[1].node.accept_inbound_channel(&temporary_channel_id,
909 &nodes[0].node.get_our_node_id(), 0).is_err());
914 let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
915 match msg_events[0] {
916 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg, .. }, .. } => {
917 assert_eq!(msg.data, "No zero confirmation channels accepted".to_owned());
922 // 2.2 Try again with the 0conf method to manually accept
923 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42,
924 Some(manually_accept_conf)).unwrap();
925 let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel,
926 nodes[1].node.get_our_node_id());
928 open_channel_msg.channel_type = Some(channel_type_features);
930 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
932 let events = nodes[1].node.get_and_clear_pending_events();
935 Event::OpenChannelRequest { temporary_channel_id, .. } => {
936 // Assert we can accept via the 0conf method
937 assert!(nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(
938 &temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).is_ok());
943 // Check we would send accept
944 let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
945 match msg_events[0] {
946 MessageSendEvent::SendAcceptChannel { .. } => {},
952 fn test_connect_before_funding() {
953 // Tests for a particularly dumb explicit panic that existed prior to 0.0.111 for 0conf
954 // channels. If we received a block while awaiting funding for 0-conf channels we'd hit an
955 // explicit panic when deciding if we should broadcast our channel_ready message.
956 let chanmon_cfgs = create_chanmon_cfgs(2);
957 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
959 let mut manually_accept_conf = test_default_channel_config();
960 manually_accept_conf.manually_accept_inbound_channels = true;
962 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(manually_accept_conf)]);
963 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
965 nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100_000, 10_001, 42, None).unwrap();
966 let open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
968 nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
969 let events = nodes[1].node.get_and_clear_pending_events();
970 assert_eq!(events.len(), 1);
972 Event::OpenChannelRequest { temporary_channel_id, .. } => {
973 nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(&temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).unwrap();
975 _ => panic!("Unexpected event"),
978 let mut accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
979 assert_eq!(accept_channel.minimum_depth, 0);
980 nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &accept_channel);
982 let events = nodes[0].node.get_and_clear_pending_events();
983 assert_eq!(events.len(), 1);
985 Event::FundingGenerationReady { .. } => {},
986 _ => panic!("Unexpected event"),
989 connect_blocks(&nodes[0], 1);
990 connect_blocks(&nodes[1], 1);