_ Git - rust-lightning/blob - lightning/src/ln/priv_short_conf_tests.rs

   1 // This file is Copyright its original authors, visible in version control
   2 // history.
   3 //
   4 // This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
   5 // or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
   6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
   7 // You may not use this file except in accordance with one or both of these
   8 // licenses.
   9
  10 //! Tests that test ChannelManager behavior with fewer confirmations required than the default and
  11 //! other behavior that exists only on private channels or with a semi-trusted counterparty (eg
  12 //! LSP).
  13
  14 use crate::chain::ChannelMonitorUpdateStatus;
  15 use crate::sign::NodeSigner;
  16 use crate::events::{ClosureReason, Event, HTLCDestination, MessageSendEvent, MessageSendEventsProvider};
  17 use crate::ln::channelmanager::{ChannelManager, MIN_CLTV_EXPIRY_DELTA, PaymentId, RecipientOnionFields};
  18 use crate::routing::gossip::RoutingFees;
  19 use crate::routing::router::{PaymentParameters, RouteHint, RouteHintHop};
  20 use crate::ln::features::ChannelTypeFeatures;
  21 use crate::ln::msgs;
  22 use crate::ln::msgs::{ChannelMessageHandler, RoutingMessageHandler, ChannelUpdate, ErrorAction};
  23 use crate::ln::wire::Encode;
  24 use crate::util::config::UserConfig;
  25 use crate::util::ser::Writeable;
  26 use crate::util::test_utils;
  27
  28 use crate::prelude::*;
  29 use core::default::Default;
  30
  31 use crate::ln::functional_test_utils::*;
  32
  33 use bitcoin::blockdata::constants::genesis_block;
  34 use bitcoin::network::constants::Network;
  35
  36 #[test]
  37 fn test_priv_forwarding_rejection() {
  38         // If we have a private channel with outbound liquidity, and
  39         // UserConfig::accept_forwards_to_priv_channels is set to false, we should reject any attempts
  40         // to forward through that channel.
  41         let chanmon_cfgs = create_chanmon_cfgs(3);
  42         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
  43         let mut no_announce_cfg = test_default_channel_config();
  44         no_announce_cfg.accept_forwards_to_priv_channels = false;
  45         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(no_announce_cfg), None]);
  46         let persister: test_utils::TestPersister;
  47         let new_chain_monitor: test_utils::TestChainMonitor;
  48         let nodes_1_deserialized: ChannelManager<&test_utils::TestChainMonitor, &test_utils::TestBroadcaster, &test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestFeeEstimator, &test_utils::TestRouter, &test_utils::TestLogger>;
  49         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
  50
  51         let chan_id_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000).2;
  52         let chan_id_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 500_000_000).0.channel_id;
  53
  54         // We should always be able to forward through nodes[1] as long as its out through a public
  55         // channel:
  56         send_payment(&nodes[2], &[&nodes[1], &nodes[0]], 10_000);
  57
  58         // ... however, if we send to nodes[2], we will have to pass the private channel from nodes[1]
  59         // to nodes[2], which should be rejected:
  60         let route_hint = RouteHint(vec![RouteHintHop {
  61                 src_node_id: nodes[1].node.get_our_node_id(),
  62                 short_channel_id: nodes[2].node.list_channels()[0].short_channel_id.unwrap(),
  63                 fees: RoutingFees { base_msat: 1000, proportional_millionths: 0 },
  64                 cltv_expiry_delta: MIN_CLTV_EXPIRY_DELTA,
  65                 htlc_minimum_msat: None,
  66                 htlc_maximum_msat: None,
  67         }]);
  68         let last_hops = vec![route_hint];
  69         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), TEST_FINAL_CLTV)
  70                 .with_bolt11_features(nodes[2].node.invoice_features()).unwrap()
  71                 .with_route_hints(last_hops).unwrap();
  72         let (route, our_payment_hash, our_payment_preimage, our_payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 10_000);
  73
  74         nodes[0].node.send_payment_with_route(&route, our_payment_hash,
  75                 RecipientOnionFields::secret_only(our_payment_secret), PaymentId(our_payment_hash.0)).unwrap();
  76         check_added_monitors!(nodes[0], 1);
  77         let payment_event = SendEvent::from_event(nodes[0].node.get_and_clear_pending_msg_events().remove(0));
  78         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
  79         commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, false, true);
  80
  81         let htlc_fail_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
  82         assert!(htlc_fail_updates.update_add_htlcs.is_empty());
  83         assert_eq!(htlc_fail_updates.update_fail_htlcs.len(), 1);
  84         assert!(htlc_fail_updates.update_fail_malformed_htlcs.is_empty());
  85         assert!(htlc_fail_updates.update_fee.is_none());
  86
  87         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &htlc_fail_updates.update_fail_htlcs[0]);
  88         commitment_signed_dance!(nodes[0], nodes[1], htlc_fail_updates.commitment_signed, true, true);
  89         expect_payment_failed_with_update!(nodes[0], our_payment_hash, false, nodes[2].node.list_channels()[0].short_channel_id.unwrap(), true);
  90
  91         // Now disconnect nodes[1] from its peers and restart with accept_forwards_to_priv_channels set
  92         // to true. Sadly there is currently no way to change it at runtime.
  93
  94         nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id());
  95         nodes[2].node.peer_disconnected(&nodes[1].node.get_our_node_id());
  96
  97         let nodes_1_serialized = nodes[1].node.encode();
  98         let monitor_a_serialized = get_monitor!(nodes[1], chan_id_1).encode();
  99         let monitor_b_serialized = get_monitor!(nodes[1], chan_id_2).encode();
 100
 101         no_announce_cfg.accept_forwards_to_priv_channels = true;
 102         reload_node!(nodes[1], no_announce_cfg, &nodes_1_serialized, &[&monitor_a_serialized, &monitor_b_serialized], persister, new_chain_monitor, nodes_1_deserialized);
 103
 104         nodes[0].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: nodes[1].node.init_features(), remote_network_address: None }, true).unwrap();
 105         nodes[1].node.peer_connected(&nodes[0].node.get_our_node_id(), &msgs::Init { features: nodes[0].node.init_features(), remote_network_address: None }, false).unwrap();
 106         let as_reestablish = get_chan_reestablish_msgs!(nodes[0], nodes[1]).pop().unwrap();
 107         let bs_reestablish = get_chan_reestablish_msgs!(nodes[1], nodes[0]).pop().unwrap();
 108         nodes[1].node.handle_channel_reestablish(&nodes[0].node.get_our_node_id(), &as_reestablish);
 109         nodes[0].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
 110         get_event_msg!(nodes[0], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 111         get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
 112
 113         nodes[1].node.peer_connected(&nodes[2].node.get_our_node_id(), &msgs::Init { features: nodes[2].node.init_features(), remote_network_address: None }, true).unwrap();
 114         nodes[2].node.peer_connected(&nodes[1].node.get_our_node_id(), &msgs::Init { features: nodes[1].node.init_features(), remote_network_address: None }, false).unwrap();
 115         let bs_reestablish = get_chan_reestablish_msgs!(nodes[1], nodes[2]).pop().unwrap();
 116         let cs_reestablish = get_chan_reestablish_msgs!(nodes[2], nodes[1]).pop().unwrap();
 117         nodes[2].node.handle_channel_reestablish(&nodes[1].node.get_our_node_id(), &bs_reestablish);
 118         nodes[1].node.handle_channel_reestablish(&nodes[2].node.get_our_node_id(), &cs_reestablish);
 119         get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
 120         get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 121
 122         nodes[0].node.send_payment_with_route(&route, our_payment_hash,
 123                 RecipientOnionFields::secret_only(our_payment_secret), PaymentId(our_payment_hash.0)).unwrap();
 124         check_added_monitors!(nodes[0], 1);
 125         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 10_000, our_payment_hash, our_payment_secret);
 126         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], our_payment_preimage);
 127 }
 128
 129 fn do_test_1_conf_open(connect_style: ConnectStyle) {
 130         // Previously, if the minium_depth config was set to 1, we'd never send a channel_ready. This
 131         // tests that we properly send one in that case.
 132         let mut alice_config = UserConfig::default();
 133         alice_config.channel_handshake_config.minimum_depth = 1;
 134         alice_config.channel_handshake_config.announced_channel = true;
 135         alice_config.channel_handshake_limits.force_announced_channel_preference = false;
 136         let mut bob_config = UserConfig::default();
 137         bob_config.channel_handshake_config.minimum_depth = 1;
 138         bob_config.channel_handshake_config.announced_channel = true;
 139         bob_config.channel_handshake_limits.force_announced_channel_preference = false;
 140         let chanmon_cfgs = create_chanmon_cfgs(2);
 141         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 142         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[Some(alice_config), Some(bob_config)]);
 143         let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 144         *nodes[0].connect_style.borrow_mut() = connect_style;
 145
 146         let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001);
 147         mine_transaction(&nodes[1], &tx);
 148         nodes[0].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendChannelReady, nodes[0].node.get_our_node_id()));
 149         assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
 150
 151         mine_transaction(&nodes[0], &tx);
 152         let as_msg_events = nodes[0].node.get_and_clear_pending_msg_events();
 153         assert_eq!(as_msg_events.len(), 2);
 154         let as_channel_ready = if let MessageSendEvent::SendChannelReady { ref node_id, ref msg } = as_msg_events[0] {
 155                 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 156                 msg.clone()
 157         } else { panic!("Unexpected event"); };
 158         if let MessageSendEvent::SendChannelUpdate { ref node_id, msg: _ } = as_msg_events[1] {
 159                 assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 160         } else { panic!("Unexpected event"); }
 161
 162         nodes[1].node.handle_channel_ready(&nodes[0].node.get_our_node_id(), &as_channel_ready);
 163         expect_channel_ready_event(&nodes[0], &nodes[1].node.get_our_node_id());
 164         expect_channel_ready_event(&nodes[1], &nodes[0].node.get_our_node_id());
 165         let bs_msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 166         assert_eq!(bs_msg_events.len(), 1);
 167         if let MessageSendEvent::SendChannelUpdate { ref node_id, msg: _ } = bs_msg_events[0] {
 168                 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 169         } else { panic!("Unexpected event"); }
 170
 171         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 172
 173         // After 6 confirmations, as required by the spec, we'll send announcement_signatures and
 174         // broadcast the channel_announcement (but not before exactly 6 confirmations).
 175         connect_blocks(&nodes[0], 4);
 176         assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
 177         connect_blocks(&nodes[0], 1);
 178         nodes[1].node.handle_announcement_signatures(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendAnnouncementSignatures, nodes[1].node.get_our_node_id()));
 179         assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 180
 181         connect_blocks(&nodes[1], 5);
 182         let bs_announce_events = nodes[1].node.get_and_clear_pending_msg_events();
 183         assert_eq!(bs_announce_events.len(), 2);
 184         let bs_announcement_sigs = if let MessageSendEvent::SendAnnouncementSignatures { ref node_id, ref msg } = bs_announce_events[0] {
 185                 assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 186                 msg.clone()
 187         } else { panic!("Unexpected event"); };
 188         let (bs_announcement, bs_update) = if let MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } = bs_announce_events[1] {
 189                 (msg.clone(), update_msg.clone().unwrap())
 190         } else { panic!("Unexpected event"); };
 191
 192         nodes[0].node.handle_announcement_signatures(&nodes[1].node.get_our_node_id(), &bs_announcement_sigs);
 193         let as_announce_events = nodes[0].node.get_and_clear_pending_msg_events();
 194         assert_eq!(as_announce_events.len(), 1);
 195         let (announcement, as_update) = if let MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } = as_announce_events[0] {
 196                 (msg.clone(), update_msg.clone().unwrap())
 197         } else { panic!("Unexpected event"); };
 198         assert_eq!(announcement, bs_announcement);
 199
 200         for node in nodes {
 201                 assert!(node.gossip_sync.handle_channel_announcement(&announcement).unwrap());
 202                 node.gossip_sync.handle_channel_update(&as_update).unwrap();
 203                 node.gossip_sync.handle_channel_update(&bs_update).unwrap();
 204         }
 205 }
 206 #[test]
 207 fn test_1_conf_open() {
 208         do_test_1_conf_open(ConnectStyle::BestBlockFirst);
 209         do_test_1_conf_open(ConnectStyle::TransactionsFirst);
 210         do_test_1_conf_open(ConnectStyle::FullBlockViaListen);
 211 }
 212
 213 #[test]
 214 fn test_routed_scid_alias() {
 215         // Trivially test sending a payment which is routed through an SCID alias.
 216         let chanmon_cfgs = create_chanmon_cfgs(3);
 217         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 218         let mut no_announce_cfg = test_default_channel_config();
 219         no_announce_cfg.accept_forwards_to_priv_channels = true;
 220         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(no_announce_cfg), None]);
 221         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 222
 223         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 500_000_000).2;
 224         let mut as_channel_ready = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 500_000_000).0;
 225
 226         let last_hop = nodes[2].node.list_usable_channels();
 227         let hop_hints = vec![RouteHint(vec![RouteHintHop {
 228                 src_node_id: nodes[1].node.get_our_node_id(),
 229                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 230                 fees: RoutingFees {
 231                         base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 232                         proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 233                 },
 234                 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
 235                 htlc_maximum_msat: None,
 236                 htlc_minimum_msat: None,
 237         }])];
 238         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
 239                 .with_bolt11_features(nodes[2].node.invoice_features()).unwrap()
 240                 .with_route_hints(hop_hints).unwrap();
 241         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 100_000);
 242         assert_eq!(route.paths[0].hops[1].short_channel_id, last_hop[0].inbound_scid_alias.unwrap());
 243         nodes[0].node.send_payment_with_route(&route, payment_hash,
 244                 RecipientOnionFields::secret_only(payment_secret), PaymentId(payment_hash.0)).unwrap();
 245         check_added_monitors!(nodes[0], 1);
 246
 247         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 100_000, payment_hash, payment_secret);
 248
 249         as_channel_ready.short_channel_id_alias = Some(0xeadbeef);
 250         nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &as_channel_ready);
 251         // Note that we always respond to a channel_ready with a channel_update. Not a lot of reason
 252         // to bother updating that code, so just drop the message here.
 253         get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 254
 255         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
 256
 257         // Now test that if a peer sends us a second channel_ready after the channel is operational we
 258         // will use the new alias.
 259         as_channel_ready.short_channel_id_alias = Some(0xdeadbeef);
 260         nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &as_channel_ready);
 261         // Note that we always respond to a channel_ready with a channel_update. Not a lot of reason
 262         // to bother updating that code, so just drop the message here.
 263         get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 264         let updated_channel_info = nodes[2].node.list_usable_channels();
 265         assert_eq!(updated_channel_info.len(), 1);
 266         assert_eq!(updated_channel_info[0].inbound_scid_alias.unwrap(), 0xdeadbeef);
 267         // Note that because we never send a duplicate channel_ready we can't send a payment through
 268         // the 0xdeadbeef SCID alias.
 269 }
 270
 271 #[test]
 272 fn test_scid_privacy_on_pub_channel() {
 273         // Tests rejecting the scid_privacy feature for public channels and that we don't ever try to
 274         // send them.
 275         let chanmon_cfgs = create_chanmon_cfgs(2);
 276         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 277         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
 278         let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 279
 280         let mut scid_privacy_cfg = test_default_channel_config();
 281         scid_privacy_cfg.channel_handshake_config.announced_channel = true;
 282         scid_privacy_cfg.channel_handshake_config.negotiate_scid_privacy = true;
 283         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(scid_privacy_cfg)).unwrap();
 284         let mut open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 285
 286         assert!(!open_channel.channel_type.as_ref().unwrap().supports_scid_privacy()); // we ignore `negotiate_scid_privacy` on pub channels
 287         open_channel.channel_type.as_mut().unwrap().set_scid_privacy_required();
 288         assert_eq!(open_channel.channel_flags & 1, 1); // The `announce_channel` bit is set.
 289
 290         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
 291         let err = get_err_msg(&nodes[1], &nodes[0].node.get_our_node_id());
 292         assert_eq!(err.data, "SCID Alias/Privacy Channel Type cannot be set on a public channel");
 293 }
 294
 295 #[test]
 296 fn test_scid_privacy_negotiation() {
 297         // Tests of the negotiation of SCID alias and falling back to non-SCID-alias if our
 298         // counterparty doesn't support it.
 299         let chanmon_cfgs = create_chanmon_cfgs(2);
 300         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 301         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
 302         let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 303
 304         let mut scid_privacy_cfg = test_default_channel_config();
 305         scid_privacy_cfg.channel_handshake_config.announced_channel = false;
 306         scid_privacy_cfg.channel_handshake_config.negotiate_scid_privacy = true;
 307         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(scid_privacy_cfg)).unwrap();
 308
 309         let init_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 310         assert!(init_open_channel.channel_type.as_ref().unwrap().supports_scid_privacy());
 311         assert!(nodes[0].node.list_channels()[0].channel_type.is_none()); // channel_type is none until counterparty accepts
 312
 313         // now simulate nodes[1] responding with an Error message, indicating it doesn't understand
 314         // SCID alias.
 315         nodes[0].node.handle_error(&nodes[1].node.get_our_node_id(), &msgs::ErrorMessage {
 316                 channel_id: init_open_channel.temporary_channel_id,
 317                 data: "Yo, no SCID aliases, no privacy here!".to_string()
 318         });
 319         assert!(nodes[0].node.list_channels()[0].channel_type.is_none()); // channel_type is none until counterparty accepts
 320
 321         let second_open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 322         assert!(!second_open_channel.channel_type.as_ref().unwrap().supports_scid_privacy());
 323         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &second_open_channel);
 324         nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id()));
 325
 326         let events = nodes[0].node.get_and_clear_pending_events();
 327         assert_eq!(events.len(), 1);
 328         match events[0] {
 329                 Event::FundingGenerationReady { .. } => {},
 330                 _ => panic!("Unexpected event"),
 331         }
 332
 333         assert!(!nodes[0].node.list_channels()[0].channel_type.as_ref().unwrap().supports_scid_privacy());
 334         assert!(!nodes[1].node.list_channels()[0].channel_type.as_ref().unwrap().supports_scid_privacy());
 335 }
 336
 337 #[test]
 338 fn test_inbound_scid_privacy() {
 339         // Tests accepting channels with the scid_privacy feature and rejecting forwards using the
 340         // channel's real SCID as required by the channel feature.
 341         let chanmon_cfgs = create_chanmon_cfgs(3);
 342         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 343         let mut accept_forward_cfg = test_default_channel_config();
 344         accept_forward_cfg.accept_forwards_to_priv_channels = true;
 345         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(accept_forward_cfg), None]);
 346         let mut nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 347
 348         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
 349
 350         let mut no_announce_cfg = test_default_channel_config();
 351         no_announce_cfg.channel_handshake_config.announced_channel = false;
 352         no_announce_cfg.channel_handshake_config.negotiate_scid_privacy = true;
 353         nodes[1].node.create_channel(nodes[2].node.get_our_node_id(), 100_000, 10_000, 42, Some(no_announce_cfg)).unwrap();
 354         let mut open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[2].node.get_our_node_id());
 355
 356         assert!(open_channel.channel_type.as_ref().unwrap().requires_scid_privacy());
 357
 358         nodes[2].node.handle_open_channel(&nodes[1].node.get_our_node_id(), &open_channel);
 359         let accept_channel = get_event_msg!(nodes[2], MessageSendEvent::SendAcceptChannel, nodes[1].node.get_our_node_id());
 360         nodes[1].node.handle_accept_channel(&nodes[2].node.get_our_node_id(), &accept_channel);
 361
 362         let (temporary_channel_id, tx, _) = create_funding_transaction(&nodes[1], &nodes[2].node.get_our_node_id(), 100_000, 42);
 363         nodes[1].node.funding_transaction_generated(&temporary_channel_id, &nodes[2].node.get_our_node_id(), tx.clone()).unwrap();
 364         nodes[2].node.handle_funding_created(&nodes[1].node.get_our_node_id(), &get_event_msg!(nodes[1], MessageSendEvent::SendFundingCreated, nodes[2].node.get_our_node_id()));
 365         check_added_monitors!(nodes[2], 1);
 366
 367         let cs_funding_signed = get_event_msg!(nodes[2], MessageSendEvent::SendFundingSigned, nodes[1].node.get_our_node_id());
 368         expect_channel_pending_event(&nodes[2], &nodes[1].node.get_our_node_id());
 369
 370         nodes[1].node.handle_funding_signed(&nodes[2].node.get_our_node_id(), &cs_funding_signed);
 371         expect_channel_pending_event(&nodes[1], &nodes[2].node.get_our_node_id());
 372         check_added_monitors!(nodes[1], 1);
 373
 374         let conf_height = core::cmp::max(nodes[1].best_block_info().1 + 1, nodes[2].best_block_info().1 + 1);
 375         confirm_transaction_at(&nodes[1], &tx, conf_height);
 376         connect_blocks(&nodes[1], CHAN_CONFIRM_DEPTH - 1);
 377         confirm_transaction_at(&nodes[2], &tx, conf_height);
 378         connect_blocks(&nodes[2], CHAN_CONFIRM_DEPTH - 1);
 379         let bs_channel_ready = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReady, nodes[2].node.get_our_node_id());
 380         nodes[1].node.handle_channel_ready(&nodes[2].node.get_our_node_id(), &get_event_msg!(nodes[2], MessageSendEvent::SendChannelReady, nodes[1].node.get_our_node_id()));
 381         expect_channel_ready_event(&nodes[1], &nodes[2].node.get_our_node_id());
 382         let bs_update = get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
 383         nodes[2].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &bs_channel_ready);
 384         expect_channel_ready_event(&nodes[2], &nodes[1].node.get_our_node_id());
 385         let cs_update = get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
 386
 387         nodes[1].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &cs_update);
 388         nodes[2].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &bs_update);
 389
 390         // Now we can pay just fine using the SCID alias nodes[2] gave to nodes[1]...
 391
 392         let last_hop = nodes[2].node.list_usable_channels();
 393         let mut hop_hints = vec![RouteHint(vec![RouteHintHop {
 394                 src_node_id: nodes[1].node.get_our_node_id(),
 395                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 396                 fees: RoutingFees {
 397                         base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 398                         proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 399                 },
 400                 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
 401                 htlc_maximum_msat: None,
 402                 htlc_minimum_msat: None,
 403         }])];
 404         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
 405                 .with_bolt11_features(nodes[2].node.invoice_features()).unwrap()
 406                 .with_route_hints(hop_hints.clone()).unwrap();
 407         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 100_000);
 408         assert_eq!(route.paths[0].hops[1].short_channel_id, last_hop[0].inbound_scid_alias.unwrap());
 409         nodes[0].node.send_payment_with_route(&route, payment_hash,
 410                 RecipientOnionFields::secret_only(payment_secret), PaymentId(payment_hash.0)).unwrap();
 411         check_added_monitors!(nodes[0], 1);
 412
 413         pass_along_route(&nodes[0], &[&[&nodes[1], &nodes[2]]], 100_000, payment_hash, payment_secret);
 414         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
 415
 416         // ... but if we try to pay using the real SCID, nodes[1] will just tell us they don't know
 417         // what channel we're talking about.
 418         hop_hints[0].0[0].short_channel_id = last_hop[0].short_channel_id.unwrap();
 419
 420         let payment_params_2 = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
 421                 .with_bolt11_features(nodes[2].node.invoice_features()).unwrap()
 422                 .with_route_hints(hop_hints).unwrap();
 423         let (route_2, payment_hash_2, _, payment_secret_2) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params_2, 100_000);
 424         assert_eq!(route_2.paths[0].hops[1].short_channel_id, last_hop[0].short_channel_id.unwrap());
 425         nodes[0].node.send_payment_with_route(&route_2, payment_hash_2,
 426                 RecipientOnionFields::secret_only(payment_secret_2), PaymentId(payment_hash_2.0)).unwrap();
 427         check_added_monitors!(nodes[0], 1);
 428
 429         let payment_event = SendEvent::from_node(&nodes[0]);
 430         assert_eq!(nodes[1].node.get_our_node_id(), payment_event.node_id);
 431         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
 432         commitment_signed_dance!(nodes[1], nodes[0], payment_event.commitment_msg, true, true);
 433
 434         nodes[1].logger.assert_log_regex("lightning::ln::channelmanager", regex::Regex::new(r"Refusing to forward over real channel SCID as our counterparty requested").unwrap(), 1);
 435
 436         let mut updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 437         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &updates.update_fail_htlcs[0]);
 438         commitment_signed_dance!(nodes[0], nodes[1], updates.commitment_signed, false);
 439
 440         expect_payment_failed_conditions(&nodes[0], payment_hash_2, false,
 441                 PaymentFailedConditions::new().blamed_scid(last_hop[0].short_channel_id.unwrap())
 442                         .blamed_chan_closed(true).expected_htlc_error_data(0x4000|10, &[0; 0]));
 443 }
 444
 445 #[test]
 446 fn test_scid_alias_returned() {
 447         // Tests that when we fail an HTLC (in this case due to attempting to forward more than the
 448         // channel's available balance) we use the correct (in this case the aliased) SCID in the
 449         // channel_update which is returned in the onion to the sender.
 450         let chanmon_cfgs = create_chanmon_cfgs(3);
 451         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 452         let mut accept_forward_cfg = test_default_channel_config();
 453         accept_forward_cfg.accept_forwards_to_priv_channels = true;
 454         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(accept_forward_cfg), None]);
 455         let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 456
 457         create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 10_000_000, 0);
 458         let chan = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 10_000, 0);
 459
 460         let last_hop = nodes[2].node.list_usable_channels();
 461         let mut hop_hints = vec![RouteHint(vec![RouteHintHop {
 462                 src_node_id: nodes[1].node.get_our_node_id(),
 463                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 464                 fees: RoutingFees {
 465                         base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 466                         proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 467                 },
 468                 cltv_expiry_delta: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().cltv_expiry_delta,
 469                 htlc_maximum_msat: None,
 470                 htlc_minimum_msat: None,
 471         }])];
 472         let payment_params = PaymentParameters::from_node_id(nodes[2].node.get_our_node_id(), 42)
 473                 .with_bolt11_features(nodes[2].node.invoice_features()).unwrap()
 474                 .with_route_hints(hop_hints).unwrap();
 475         let (mut route, payment_hash, _, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], payment_params, 10_000);
 476         assert_eq!(route.paths[0].hops[1].short_channel_id, nodes[2].node.list_usable_channels()[0].inbound_scid_alias.unwrap());
 477
 478         route.paths[0].hops[1].fee_msat = 10_000_000; // Overshoot the last channel's value
 479
 480         // Route the HTLC through to the destination.
 481         nodes[0].node.send_payment_with_route(&route, payment_hash,
 482                 RecipientOnionFields::secret_only(payment_secret), PaymentId(payment_hash.0)).unwrap();
 483         check_added_monitors!(nodes[0], 1);
 484         let as_updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
 485         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_updates.update_add_htlcs[0]);
 486         commitment_signed_dance!(nodes[1], nodes[0], &as_updates.commitment_signed, false, true);
 487
 488         expect_pending_htlcs_forwardable!(nodes[1]);
 489         expect_pending_htlcs_forwardable_and_htlc_handling_failed!(nodes[1], vec![HTLCDestination::NextHopChannel { node_id: Some(nodes[2].node.get_our_node_id()), channel_id: chan.0.channel_id }]);
 490         check_added_monitors!(nodes[1], 1);
 491
 492         let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 493         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
 494         commitment_signed_dance!(nodes[0], nodes[1], bs_updates.commitment_signed, false, true);
 495
 496         // Build the expected channel update
 497         let contents = msgs::UnsignedChannelUpdate {
 498                 chain_hash: genesis_block(Network::Testnet).header.block_hash(),
 499                 short_channel_id: last_hop[0].inbound_scid_alias.unwrap(),
 500                 timestamp: 21,
 501                 flags: 1,
 502                 cltv_expiry_delta: accept_forward_cfg.channel_config.cltv_expiry_delta,
 503                 htlc_minimum_msat: 1_000,
 504                 htlc_maximum_msat: 1_000_000, // Defaults to 10% of the channel value
 505                 fee_base_msat: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_base_msat,
 506                 fee_proportional_millionths: last_hop[0].counterparty.forwarding_info.as_ref().unwrap().fee_proportional_millionths,
 507                 excess_data: Vec::new(),
 508         };
 509         let signature = nodes[1].keys_manager.sign_gossip_message(msgs::UnsignedGossipMessage::ChannelUpdate(&contents)).unwrap();
 510         let msg = msgs::ChannelUpdate { signature, contents };
 511
 512         let mut err_data = Vec::new();
 513         err_data.extend_from_slice(&(msg.serialized_length() as u16 + 2).to_be_bytes());
 514         err_data.extend_from_slice(&ChannelUpdate::TYPE.to_be_bytes());
 515         err_data.extend_from_slice(&msg.encode());
 516
 517         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
 518                 PaymentFailedConditions::new().blamed_scid(last_hop[0].inbound_scid_alias.unwrap())
 519                         .blamed_chan_closed(false).expected_htlc_error_data(0x1000|7, &err_data));
 520
 521         route.paths[0].hops[1].fee_msat = 10_000; // Reset to the correct payment amount
 522         route.paths[0].hops[0].fee_msat = 0; // But set fee paid to the middle hop to 0
 523
 524         // Route the HTLC through to the destination.
 525         nodes[0].node.send_payment_with_route(&route, payment_hash,
 526                 RecipientOnionFields::secret_only(payment_secret), PaymentId(payment_hash.0)).unwrap();
 527         check_added_monitors!(nodes[0], 1);
 528         let as_updates = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
 529         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_updates.update_add_htlcs[0]);
 530         commitment_signed_dance!(nodes[1], nodes[0], &as_updates.commitment_signed, false, true);
 531
 532         let bs_updates = get_htlc_update_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 533         nodes[0].node.handle_update_fail_htlc(&nodes[1].node.get_our_node_id(), &bs_updates.update_fail_htlcs[0]);
 534         commitment_signed_dance!(nodes[0], nodes[1], bs_updates.commitment_signed, false, true);
 535
 536         let mut err_data = Vec::new();
 537         err_data.extend_from_slice(&10_000u64.to_be_bytes());
 538         err_data.extend_from_slice(&(msg.serialized_length() as u16 + 2).to_be_bytes());
 539         err_data.extend_from_slice(&ChannelUpdate::TYPE.to_be_bytes());
 540         err_data.extend_from_slice(&msg.encode());
 541         expect_payment_failed_conditions(&nodes[0], payment_hash, false,
 542                 PaymentFailedConditions::new().blamed_scid(last_hop[0].inbound_scid_alias.unwrap())
 543                         .blamed_chan_closed(false).expected_htlc_error_data(0x1000|12, &err_data));
 544 }
 545
 546 #[test]
 547 fn test_simple_0conf_channel() {
 548         // If our peer tells us they will accept our channel with 0 confs, and we funded the channel,
 549         // we should trust the funding won't be double-spent (assuming `trust_own_funding_0conf` is
 550         // set)!
 551         // Further, if we `accept_inbound_channel_from_trusted_peer_0conf`, `channel_ready` messages
 552         // should fly immediately and the channel should be available for use as soon as they are
 553         // received.
 554
 555         let chanmon_cfgs = create_chanmon_cfgs(2);
 556         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 557         let mut chan_config = test_default_channel_config();
 558         chan_config.manually_accept_inbound_channels = true;
 559
 560         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 561         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 562
 563         open_zero_conf_channel(&nodes[0], &nodes[1], None);
 564
 565         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 566 }
 567
 568 #[test]
 569 fn test_0conf_channel_with_async_monitor() {
 570         // Test that we properly send out channel_ready in (both inbound- and outbound-) zero-conf
 571         // channels if ChannelMonitor updates return a `TemporaryFailure` during the initial channel
 572         // negotiation.
 573
 574         let chanmon_cfgs = create_chanmon_cfgs(3);
 575         let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
 576         let mut chan_config = test_default_channel_config();
 577         chan_config.manually_accept_inbound_channels = true;
 578         let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, Some(chan_config), None]);
 579         let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
 580
 581         create_announced_chan_between_nodes_with_value(&nodes, 1, 2, 1_000_000, 0);
 582
 583         chan_config.channel_handshake_config.announced_channel = false;
 584         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, Some(chan_config)).unwrap();
 585         let open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 586
 587         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
 588         let events = nodes[1].node.get_and_clear_pending_events();
 589         assert_eq!(events.len(), 1);
 590         match events[0] {
 591                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 592                         nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(&temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).unwrap();
 593                 },
 594                 _ => panic!("Unexpected event"),
 595         };
 596
 597         let mut accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
 598         assert_eq!(accept_channel.minimum_depth, 0);
 599         nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &accept_channel);
 600
 601         let (temporary_channel_id, tx, funding_output) = create_funding_transaction(&nodes[0], &nodes[1].node.get_our_node_id(), 100000, 42);
 602         nodes[0].node.funding_transaction_generated(&temporary_channel_id, &nodes[1].node.get_our_node_id(), tx.clone()).unwrap();
 603         let funding_created = get_event_msg!(nodes[0], MessageSendEvent::SendFundingCreated, nodes[1].node.get_our_node_id());
 604
 605         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
 606         nodes[1].node.handle_funding_created(&nodes[0].node.get_our_node_id(), &funding_created);
 607         check_added_monitors!(nodes[1], 1);
 608         assert!(nodes[1].node.get_and_clear_pending_events().is_empty());
 609
 610         let channel_id = funding_output.to_channel_id();
 611         nodes[1].chain_monitor.complete_sole_pending_chan_update(&channel_id);
 612         expect_channel_pending_event(&nodes[1], &nodes[0].node.get_our_node_id());
 613
 614         let bs_signed_locked = nodes[1].node.get_and_clear_pending_msg_events();
 615         assert_eq!(bs_signed_locked.len(), 2);
 616         chanmon_cfgs[0].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
 617
 618         match &bs_signed_locked[0] {
 619                 MessageSendEvent::SendFundingSigned { node_id, msg } => {
 620                         assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 621                         nodes[0].node.handle_funding_signed(&nodes[1].node.get_our_node_id(), &msg);
 622                         check_added_monitors!(nodes[0], 1);
 623                 }
 624                 _ => panic!("Unexpected event"),
 625         }
 626         match &bs_signed_locked[1] {
 627                 MessageSendEvent::SendChannelReady { node_id, msg } => {
 628                         assert_eq!(*node_id, nodes[0].node.get_our_node_id());
 629                         nodes[0].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &msg);
 630                 }
 631                 _ => panic!("Unexpected event"),
 632         }
 633
 634         assert!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().is_empty());
 635
 636         assert!(nodes[0].node.get_and_clear_pending_msg_events().is_empty());
 637         nodes[0].chain_monitor.complete_sole_pending_chan_update(&channel_id);
 638
 639         let events = nodes[0].node.get_and_clear_pending_events();
 640         assert_eq!(events.len(), 2);
 641         match events[0] {
 642                 crate::events::Event::ChannelPending { ref counterparty_node_id, .. } => {
 643                         assert_eq!(nodes[1].node.get_our_node_id(), *counterparty_node_id);
 644                 },
 645                 _ => panic!("Unexpected event"),
 646         }
 647         match events[1] {
 648                 crate::events::Event::ChannelReady { ref counterparty_node_id, .. } => {
 649                         assert_eq!(nodes[1].node.get_our_node_id(), *counterparty_node_id);
 650                 },
 651                 _ => panic!("Unexpected event"),
 652         }
 653
 654         let as_locked_update = nodes[0].node.get_and_clear_pending_msg_events();
 655
 656         // Note that the funding transaction is actually released when
 657         // get_and_clear_pending_msg_events, above, checks for monitor events.
 658         assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().len(), 1);
 659         assert_eq!(nodes[0].tx_broadcaster.txn_broadcasted.lock().unwrap().split_off(0)[0], tx);
 660
 661         match &as_locked_update[0] {
 662                 MessageSendEvent::SendChannelReady { node_id, msg } => {
 663                         assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 664                         nodes[1].node.handle_channel_ready(&nodes[0].node.get_our_node_id(), &msg);
 665                 }
 666                 _ => panic!("Unexpected event"),
 667         }
 668         expect_channel_ready_event(&nodes[1], &nodes[0].node.get_our_node_id());
 669
 670         let bs_channel_update = get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
 671
 672         let as_channel_update = match &as_locked_update[1] {
 673                 MessageSendEvent::SendChannelUpdate { node_id, msg } => {
 674                         assert_eq!(*node_id, nodes[1].node.get_our_node_id());
 675                         msg.clone()
 676                 }
 677                 _ => panic!("Unexpected event"),
 678         };
 679
 680         chanmon_cfgs[0].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
 681         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
 682
 683         nodes[0].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &bs_channel_update);
 684         nodes[1].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &as_channel_update);
 685
 686         assert_eq!(nodes[0].node.list_usable_channels().len(), 1);
 687         assert_eq!(nodes[1].node.list_usable_channels().len(), 2);
 688
 689         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 690
 691         // Now that we have useful channels, try sending a payment where the we hit a temporary monitor
 692         // failure before we've ever confirmed the funding transaction. This previously caused a panic.
 693         let (route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[2], 1_000_000);
 694
 695         nodes[0].node.send_payment_with_route(&route, payment_hash,
 696                 RecipientOnionFields::secret_only(payment_secret), PaymentId(payment_hash.0)).unwrap();
 697         check_added_monitors!(nodes[0], 1);
 698
 699         let as_send = SendEvent::from_node(&nodes[0]);
 700         nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &as_send.msgs[0]);
 701         nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &as_send.commitment_msg);
 702         check_added_monitors!(nodes[1], 1);
 703
 704         let (bs_raa, bs_commitment_signed) = get_revoke_commit_msgs!(nodes[1], nodes[0].node.get_our_node_id());
 705         nodes[0].node.handle_revoke_and_ack(&nodes[1].node.get_our_node_id(), &bs_raa);
 706         check_added_monitors!(nodes[0], 1);
 707
 708         nodes[0].node.handle_commitment_signed(&nodes[1].node.get_our_node_id(), &bs_commitment_signed);
 709         check_added_monitors!(nodes[0], 1);
 710
 711         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::InProgress);
 712         nodes[1].node.handle_revoke_and_ack(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendRevokeAndACK, nodes[1].node.get_our_node_id()));
 713         check_added_monitors!(nodes[1], 1);
 714         assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 715
 716         chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
 717         let (outpoint, _, latest_update) = nodes[1].chain_monitor.latest_monitor_update_id.lock().unwrap().get(&bs_raa.channel_id).unwrap().clone();
 718         nodes[1].chain_monitor.chain_monitor.channel_monitor_updated(outpoint, latest_update).unwrap();
 719         check_added_monitors!(nodes[1], 0);
 720         expect_pending_htlcs_forwardable!(nodes[1]);
 721         check_added_monitors!(nodes[1], 1);
 722
 723         let bs_send = SendEvent::from_node(&nodes[1]);
 724         nodes[2].node.handle_update_add_htlc(&nodes[1].node.get_our_node_id(), &bs_send.msgs[0]);
 725         commitment_signed_dance!(nodes[2], nodes[1], bs_send.commitment_msg, false);
 726         expect_pending_htlcs_forwardable!(nodes[2]);
 727         expect_payment_claimable!(nodes[2], payment_hash, payment_secret, 1_000_000);
 728         claim_payment(&nodes[0], &[&nodes[1], &nodes[2]], payment_preimage);
 729
 730         confirm_transaction(&nodes[0], &tx);
 731         confirm_transaction(&nodes[1], &tx);
 732
 733         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 734 }
 735
 736 #[test]
 737 fn test_0conf_close_no_early_chan_update() {
 738         // Tests that even with a public channel 0conf channel, we don't generate a channel_update on
 739         // closing.
 740         let chanmon_cfgs = create_chanmon_cfgs(2);
 741         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 742         let mut chan_config = test_default_channel_config();
 743         chan_config.manually_accept_inbound_channels = true;
 744
 745         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 746         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 747
 748         // This is the default but we force it on anyway
 749         chan_config.channel_handshake_config.announced_channel = true;
 750         open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
 751
 752         // We can use the channel immediately, but won't generate a channel_update until we get confs
 753         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 754
 755         nodes[0].node.force_close_all_channels_broadcasting_latest_txn();
 756         check_added_monitors!(nodes[0], 1);
 757         check_closed_event!(&nodes[0], 1, ClosureReason::HolderForceClosed);
 758         let _ = get_err_msg(&nodes[0], &nodes[1].node.get_our_node_id());
 759 }
 760
 761 #[test]
 762 fn test_public_0conf_channel() {
 763         // Tests that we will announce a public channel (after confirmation) even if its 0conf.
 764         let chanmon_cfgs = create_chanmon_cfgs(2);
 765         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 766         let mut chan_config = test_default_channel_config();
 767         chan_config.manually_accept_inbound_channels = true;
 768
 769         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 770         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 771
 772         // This is the default but we force it on anyway
 773         chan_config.channel_handshake_config.announced_channel = true;
 774         let (tx, ..) = open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
 775
 776         // We can use the channel immediately, but we can't announce it until we get 6+ confirmations
 777         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 778
 779         let scid = confirm_transaction(&nodes[0], &tx);
 780         let as_announcement_sigs = get_event_msg!(nodes[0], MessageSendEvent::SendAnnouncementSignatures, nodes[1].node.get_our_node_id());
 781         assert_eq!(confirm_transaction(&nodes[1], &tx), scid);
 782         let bs_announcement_sigs = get_event_msg!(nodes[1], MessageSendEvent::SendAnnouncementSignatures, nodes[0].node.get_our_node_id());
 783
 784         nodes[1].node.handle_announcement_signatures(&nodes[0].node.get_our_node_id(), &as_announcement_sigs);
 785         nodes[0].node.handle_announcement_signatures(&nodes[1].node.get_our_node_id(), &bs_announcement_sigs);
 786
 787         let bs_announcement = nodes[1].node.get_and_clear_pending_msg_events();
 788         assert_eq!(bs_announcement.len(), 1);
 789         let announcement;
 790         let bs_update;
 791         match bs_announcement[0] {
 792                 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
 793                         announcement = msg.clone();
 794                         bs_update = update_msg.clone().unwrap();
 795                 },
 796                 _ => panic!("Unexpected event"),
 797         };
 798
 799         let as_announcement = nodes[0].node.get_and_clear_pending_msg_events();
 800         assert_eq!(as_announcement.len(), 1);
 801         match as_announcement[0] {
 802                 MessageSendEvent::BroadcastChannelAnnouncement { ref msg, ref update_msg } => {
 803                         assert!(announcement == *msg);
 804                         let update_msg = update_msg.as_ref().unwrap();
 805                         assert_eq!(update_msg.contents.short_channel_id, scid);
 806                         assert_eq!(update_msg.contents.short_channel_id, announcement.contents.short_channel_id);
 807                         assert_eq!(update_msg.contents.short_channel_id, bs_update.contents.short_channel_id);
 808                 },
 809                 _ => panic!("Unexpected event"),
 810         };
 811 }
 812
 813 #[test]
 814 fn test_0conf_channel_reorg() {
 815         // If we accept a 0conf channel, which is then confirmed, but then changes SCID in a reorg, we
 816         // have to make sure we handle this correctly (or, currently, just force-close the channel).
 817
 818         let chanmon_cfgs = create_chanmon_cfgs(2);
 819         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 820         let mut chan_config = test_default_channel_config();
 821         chan_config.manually_accept_inbound_channels = true;
 822
 823         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(chan_config)]);
 824         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 825
 826         // This is the default but we force it on anyway
 827         chan_config.channel_handshake_config.announced_channel = true;
 828         let (tx, ..) = open_zero_conf_channel(&nodes[0], &nodes[1], Some(chan_config));
 829
 830         // We can use the channel immediately, but we can't announce it until we get 6+ confirmations
 831         send_payment(&nodes[0], &[&nodes[1]], 100_000);
 832
 833         mine_transaction(&nodes[0], &tx);
 834         mine_transaction(&nodes[1], &tx);
 835
 836         // Send a payment using the channel's real SCID, which will be public in a few blocks once we
 837         // can generate a channel_announcement.
 838         let real_scid = nodes[0].node.list_usable_channels()[0].short_channel_id.unwrap();
 839         assert_eq!(nodes[1].node.list_usable_channels()[0].short_channel_id.unwrap(), real_scid);
 840
 841         let (mut route, payment_hash, payment_preimage, payment_secret) = get_route_and_payment_hash!(nodes[0], nodes[1], 10_000);
 842         assert_eq!(route.paths[0].hops[0].short_channel_id, real_scid);
 843         send_along_route_with_secret(&nodes[0], route, &[&[&nodes[1]]], 10_000, payment_hash, payment_secret);
 844         claim_payment(&nodes[0], &[&nodes[1]], payment_preimage);
 845
 846         disconnect_blocks(&nodes[0], 1);
 847         disconnect_blocks(&nodes[1], 1);
 848
 849         // At this point the channel no longer has an SCID again. In the future we should likely
 850         // support simply un-setting the SCID and waiting until the channel gets re-confirmed, but for
 851         // now we force-close the channel here.
 852         check_closed_event!(&nodes[0], 1, ClosureReason::ProcessingError {
 853                 err: "Funding transaction was un-confirmed. Locked at 0 confs, now have 0 confs.".to_owned()
 854         });
 855         check_closed_broadcast!(nodes[0], true);
 856         check_closed_event!(&nodes[1], 1, ClosureReason::ProcessingError {
 857                 err: "Funding transaction was un-confirmed. Locked at 0 confs, now have 0 confs.".to_owned()
 858         });
 859         check_closed_broadcast!(nodes[1], true);
 860 }
 861
 862 #[test]
 863 fn test_zero_conf_accept_reject() {
 864         let mut channel_type_features = ChannelTypeFeatures::only_static_remote_key();
 865         channel_type_features.set_zero_conf_required();
 866
 867         // 1. Check we reject zero conf channels by default
 868         let chanmon_cfgs = create_chanmon_cfgs(2);
 869         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 870         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
 871         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 872
 873         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42, None).unwrap();
 874         let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 875
 876         open_channel_msg.channel_type = Some(channel_type_features.clone());
 877
 878         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
 879
 880         let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 881         match msg_events[0] {
 882                 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg, .. }, .. } => {
 883                         assert_eq!(msg.data, "No zero confirmation channels accepted".to_owned());
 884                 },
 885                 _ => panic!(),
 886         }
 887
 888         // 2. Check we can manually accept zero conf channels via the right method
 889         let mut manually_accept_conf = UserConfig::default();
 890         manually_accept_conf.manually_accept_inbound_channels = true;
 891
 892         let chanmon_cfgs = create_chanmon_cfgs(2);
 893         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 894         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs,
 895                 &[None, Some(manually_accept_conf.clone())]);
 896         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 897
 898         // 2.1 First try the non-0conf method to manually accept
 899         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42,
 900                 Some(manually_accept_conf)).unwrap();
 901         let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel,
 902                 nodes[1].node.get_our_node_id());
 903
 904         open_channel_msg.channel_type = Some(channel_type_features.clone());
 905
 906         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
 907
 908         // Assert that `nodes[1]` has no `MessageSendEvent::SendAcceptChannel` in the `msg_events`.
 909         assert!(nodes[1].node.get_and_clear_pending_msg_events().is_empty());
 910
 911         let events = nodes[1].node.get_and_clear_pending_events();
 912
 913         match events[0] {
 914                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 915                         // Assert we fail to accept via the non-0conf method
 916                         assert!(nodes[1].node.accept_inbound_channel(&temporary_channel_id,
 917                                 &nodes[0].node.get_our_node_id(), 0).is_err());
 918                 },
 919                 _ => panic!(),
 920         }
 921
 922         let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 923         match msg_events[0] {
 924                 MessageSendEvent::HandleError { action: ErrorAction::SendErrorMessage { ref msg, .. }, .. } => {
 925                         assert_eq!(msg.data, "No zero confirmation channels accepted".to_owned());
 926                 },
 927                 _ => panic!(),
 928         }
 929
 930         // 2.2 Try again with the 0conf method to manually accept
 931         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100000, 10001, 42,
 932                 Some(manually_accept_conf)).unwrap();
 933         let mut open_channel_msg = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel,
 934                 nodes[1].node.get_our_node_id());
 935
 936         open_channel_msg.channel_type = Some(channel_type_features);
 937
 938         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel_msg);
 939
 940         let events = nodes[1].node.get_and_clear_pending_events();
 941
 942         match events[0] {
 943                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 944                         // Assert we can accept via the 0conf method
 945                         assert!(nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(
 946                                 &temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).is_ok());
 947                 },
 948                 _ => panic!(),
 949         }
 950
 951         // Check we would send accept
 952         let msg_events = nodes[1].node.get_and_clear_pending_msg_events();
 953         match msg_events[0] {
 954                 MessageSendEvent::SendAcceptChannel { .. } => {},
 955                 _ => panic!(),
 956         }
 957 }
 958
 959 #[test]
 960 fn test_connect_before_funding() {
 961         // Tests for a particularly dumb explicit panic that existed prior to 0.0.111 for 0conf
 962         // channels. If we received a block while awaiting funding for 0-conf channels we'd hit an
 963         // explicit panic when deciding if we should broadcast our channel_ready message.
 964         let chanmon_cfgs = create_chanmon_cfgs(2);
 965         let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 966
 967         let mut manually_accept_conf = test_default_channel_config();
 968         manually_accept_conf.manually_accept_inbound_channels = true;
 969
 970         let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(manually_accept_conf)]);
 971         let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
 972
 973         nodes[0].node.create_channel(nodes[1].node.get_our_node_id(), 100_000, 10_001, 42, None).unwrap();
 974         let open_channel = get_event_msg!(nodes[0], MessageSendEvent::SendOpenChannel, nodes[1].node.get_our_node_id());
 975
 976         nodes[1].node.handle_open_channel(&nodes[0].node.get_our_node_id(), &open_channel);
 977         let events = nodes[1].node.get_and_clear_pending_events();
 978         assert_eq!(events.len(), 1);
 979         match events[0] {
 980                 Event::OpenChannelRequest { temporary_channel_id, .. } => {
 981                         nodes[1].node.accept_inbound_channel_from_trusted_peer_0conf(&temporary_channel_id, &nodes[0].node.get_our_node_id(), 0).unwrap();
 982                 },
 983                 _ => panic!("Unexpected event"),
 984         };
 985
 986         let mut accept_channel = get_event_msg!(nodes[1], MessageSendEvent::SendAcceptChannel, nodes[0].node.get_our_node_id());
 987         assert_eq!(accept_channel.minimum_depth, 0);
 988         nodes[0].node.handle_accept_channel(&nodes[1].node.get_our_node_id(), &accept_channel);
 989
 990         let events = nodes[0].node.get_and_clear_pending_events();
 991         assert_eq!(events.len(), 1);
 992         match events[0] {
 993                 Event::FundingGenerationReady { .. } => {},
 994                 _ => panic!("Unexpected event"),
 995         }
 996
 997         connect_blocks(&nodes[0], 1);
 998         connect_blocks(&nodes[1], 1);
 999 }