199aad064694c975d6e97cc132e3b460a84c1b71
[rust-lightning] / lightning-invoice / src / utils.rs
1 //! Convenient utilities to create an invoice.
2
3 use crate::{CreationError, Currency, Invoice, InvoiceBuilder, SignOrCreationError};
4
5 use crate::{prelude::*, Description, InvoiceDescription, Sha256};
6 use bech32::ToBase32;
7 use bitcoin_hashes::Hash;
8 use lightning::chain;
9 use lightning::chain::chaininterface::{BroadcasterInterface, FeeEstimator};
10 use lightning::sign::{Recipient, NodeSigner, SignerProvider, EntropySource};
11 use lightning::ln::{PaymentHash, PaymentSecret};
12 use lightning::ln::channelmanager::{ChannelDetails, ChannelManager, MIN_FINAL_CLTV_EXPIRY_DELTA};
13 use lightning::ln::channelmanager::{PhantomRouteHints, MIN_CLTV_EXPIRY_DELTA};
14 use lightning::ln::inbound_payment::{create, create_from_hash, ExpandedKey};
15 use lightning::routing::gossip::RoutingFees;
16 use lightning::routing::router::{RouteHint, RouteHintHop, Router};
17 use lightning::util::logger::Logger;
18 use secp256k1::PublicKey;
19 use core::ops::Deref;
20 use core::time::Duration;
21 use core::iter::Iterator;
22
23 /// Utility to create an invoice that can be paid to one of multiple nodes, or a "phantom invoice."
24 /// See [`PhantomKeysManager`] for more information on phantom node payments.
25 ///
26 /// `phantom_route_hints` parameter:
27 /// * Contains channel info for all nodes participating in the phantom invoice
28 /// * Entries are retrieved from a call to [`ChannelManager::get_phantom_route_hints`] on each
29 ///   participating node
30 /// * It is fine to cache `phantom_route_hints` and reuse it across invoices, as long as the data is
31 ///   updated when a channel becomes disabled or closes
32 /// * Note that if too many channels are included in [`PhantomRouteHints::channels`], the invoice
33 ///   may be too long for QR code scanning. To fix this, `PhantomRouteHints::channels` may be pared
34 ///   down
35 ///
36 /// `payment_hash` can be specified if you have a specific need for a custom payment hash (see the difference
37 /// between [`ChannelManager::create_inbound_payment`] and [`ChannelManager::create_inbound_payment_for_hash`]).
38 /// If `None` is provided for `payment_hash`, then one will be created.
39 ///
40 /// `invoice_expiry_delta_secs` describes the number of seconds that the invoice is valid for
41 /// in excess of the current time.
42 ///
43 /// `duration_since_epoch` is the current time since epoch in seconds.
44 ///
45 /// You can specify a custom `min_final_cltv_expiry_delta`, or let LDK default it to
46 /// [`MIN_FINAL_CLTV_EXPIRY_DELTA`]. The provided expiry must be at least [`MIN_FINAL_CLTV_EXPIRY_DELTA`] - 3.
47 /// Note that LDK will add a buffer of 3 blocks to the delta to allow for up to a few new block
48 /// confirmations during routing.
49 ///
50 /// Note that the provided `keys_manager`'s `NodeSigner` implementation must support phantom
51 /// invoices in its `sign_invoice` implementation ([`PhantomKeysManager`] satisfies this
52 /// requirement).
53 ///
54 /// [`PhantomKeysManager`]: lightning::sign::PhantomKeysManager
55 /// [`ChannelManager::get_phantom_route_hints`]: lightning::ln::channelmanager::ChannelManager::get_phantom_route_hints
56 /// [`ChannelManager::create_inbound_payment`]: lightning::ln::channelmanager::ChannelManager::create_inbound_payment
57 /// [`ChannelManager::create_inbound_payment_for_hash`]: lightning::ln::channelmanager::ChannelManager::create_inbound_payment_for_hash
58 /// [`PhantomRouteHints::channels`]: lightning::ln::channelmanager::PhantomRouteHints::channels
59 /// [`MIN_FINAL_CLTV_EXPIRY_DETLA`]: lightning::ln::channelmanager::MIN_FINAL_CLTV_EXPIRY_DELTA
60 ///
61 /// This can be used in a `no_std` environment, where [`std::time::SystemTime`] is not
62 /// available and the current time is supplied by the caller.
63 pub fn create_phantom_invoice<ES: Deref, NS: Deref, L: Deref>(
64         amt_msat: Option<u64>, payment_hash: Option<PaymentHash>, description: String,
65         invoice_expiry_delta_secs: u32, phantom_route_hints: Vec<PhantomRouteHints>, entropy_source: ES,
66         node_signer: NS, logger: L, network: Currency, min_final_cltv_expiry_delta: Option<u16>, duration_since_epoch: Duration,
67 ) -> Result<Invoice, SignOrCreationError<()>>
68 where
69         ES::Target: EntropySource,
70         NS::Target: NodeSigner,
71         L::Target: Logger,
72 {
73         let description = Description::new(description).map_err(SignOrCreationError::CreationError)?;
74         let description = InvoiceDescription::Direct(&description,);
75         _create_phantom_invoice::<ES, NS, L>(
76                 amt_msat, payment_hash, description, invoice_expiry_delta_secs, phantom_route_hints,
77                 entropy_source, node_signer, logger, network, min_final_cltv_expiry_delta, duration_since_epoch,
78         )
79 }
80
81 /// Utility to create an invoice that can be paid to one of multiple nodes, or a "phantom invoice."
82 /// See [`PhantomKeysManager`] for more information on phantom node payments.
83 ///
84 /// `phantom_route_hints` parameter:
85 /// * Contains channel info for all nodes participating in the phantom invoice
86 /// * Entries are retrieved from a call to [`ChannelManager::get_phantom_route_hints`] on each
87 ///   participating node
88 /// * It is fine to cache `phantom_route_hints` and reuse it across invoices, as long as the data is
89 ///   updated when a channel becomes disabled or closes
90 /// * Note that the route hints generated from `phantom_route_hints` will be limited to a maximum
91 ///   of 3 hints to ensure that the invoice can be scanned in a QR code. These hints are selected
92 ///   in the order that the nodes in `PhantomRouteHints` are specified, selecting one hint per node
93 ///   until the maximum is hit. Callers may provide as many `PhantomRouteHints::channels` as
94 ///   desired, but note that some nodes will be trimmed if more than 3 nodes are provided.
95 ///
96 /// `description_hash` is a SHA-256 hash of the description text
97 ///
98 /// `payment_hash` can be specified if you have a specific need for a custom payment hash (see the difference
99 /// between [`ChannelManager::create_inbound_payment`] and [`ChannelManager::create_inbound_payment_for_hash`]).
100 /// If `None` is provided for `payment_hash`, then one will be created.
101 ///
102 /// `invoice_expiry_delta_secs` describes the number of seconds that the invoice is valid for
103 /// in excess of the current time.
104 ///
105 /// `duration_since_epoch` is the current time since epoch in seconds.
106 ///
107 /// Note that the provided `keys_manager`'s `NodeSigner` implementation must support phantom
108 /// invoices in its `sign_invoice` implementation ([`PhantomKeysManager`] satisfies this
109 /// requirement).
110 ///
111 /// [`PhantomKeysManager`]: lightning::sign::PhantomKeysManager
112 /// [`ChannelManager::get_phantom_route_hints`]: lightning::ln::channelmanager::ChannelManager::get_phantom_route_hints
113 /// [`ChannelManager::create_inbound_payment`]: lightning::ln::channelmanager::ChannelManager::create_inbound_payment
114 /// [`ChannelManager::create_inbound_payment_for_hash`]: lightning::ln::channelmanager::ChannelManager::create_inbound_payment_for_hash
115 /// [`PhantomRouteHints::channels`]: lightning::ln::channelmanager::PhantomRouteHints::channels
116 ///
117 /// This can be used in a `no_std` environment, where [`std::time::SystemTime`] is not
118 /// available and the current time is supplied by the caller.
119 pub fn create_phantom_invoice_with_description_hash<ES: Deref, NS: Deref, L: Deref>(
120         amt_msat: Option<u64>, payment_hash: Option<PaymentHash>, invoice_expiry_delta_secs: u32,
121         description_hash: Sha256, phantom_route_hints: Vec<PhantomRouteHints>, entropy_source: ES,
122         node_signer: NS, logger: L, network: Currency, min_final_cltv_expiry_delta: Option<u16>, duration_since_epoch: Duration,
123 ) -> Result<Invoice, SignOrCreationError<()>>
124 where
125         ES::Target: EntropySource,
126         NS::Target: NodeSigner,
127         L::Target: Logger,
128 {
129         _create_phantom_invoice::<ES, NS, L>(
130                 amt_msat, payment_hash, InvoiceDescription::Hash(&description_hash),
131                 invoice_expiry_delta_secs, phantom_route_hints, entropy_source, node_signer, logger, network,
132                 min_final_cltv_expiry_delta, duration_since_epoch,
133         )
134 }
135
136 const MAX_CHANNEL_HINTS: usize = 3;
137
138 fn _create_phantom_invoice<ES: Deref, NS: Deref, L: Deref>(
139         amt_msat: Option<u64>, payment_hash: Option<PaymentHash>, description: InvoiceDescription,
140         invoice_expiry_delta_secs: u32, phantom_route_hints: Vec<PhantomRouteHints>, entropy_source: ES,
141         node_signer: NS, logger: L, network: Currency, min_final_cltv_expiry_delta: Option<u16>, duration_since_epoch: Duration,
142 ) -> Result<Invoice, SignOrCreationError<()>>
143 where
144         ES::Target: EntropySource,
145         NS::Target: NodeSigner,
146         L::Target: Logger,
147 {
148
149         if phantom_route_hints.is_empty() {
150                 return Err(SignOrCreationError::CreationError(
151                         CreationError::MissingRouteHints,
152                 ));
153         }
154
155         if min_final_cltv_expiry_delta.is_some() && min_final_cltv_expiry_delta.unwrap().saturating_add(3) < MIN_FINAL_CLTV_EXPIRY_DELTA {
156                 return Err(SignOrCreationError::CreationError(CreationError::MinFinalCltvExpiryDeltaTooShort));
157         }
158
159         let invoice = match description {
160                 InvoiceDescription::Direct(description) => {
161                         InvoiceBuilder::new(network).description(description.0.clone())
162                 }
163                 InvoiceDescription::Hash(hash) => InvoiceBuilder::new(network).description_hash(hash.0),
164         };
165
166         // If we ever see performance here being too slow then we should probably take this ExpandedKey as a parameter instead.
167         let keys = ExpandedKey::new(&node_signer.get_inbound_payment_key_material());
168         let (payment_hash, payment_secret) = if let Some(payment_hash) = payment_hash {
169                 let payment_secret = create_from_hash(
170                         &keys,
171                         amt_msat,
172                         payment_hash,
173                         invoice_expiry_delta_secs,
174                         duration_since_epoch
175                                 .as_secs(),
176                         min_final_cltv_expiry_delta,
177                 )
178                 .map_err(|_| SignOrCreationError::CreationError(CreationError::InvalidAmount))?;
179                 (payment_hash, payment_secret)
180         } else {
181                 create(
182                         &keys,
183                         amt_msat,
184                         invoice_expiry_delta_secs,
185                         &entropy_source,
186                         duration_since_epoch
187                                 .as_secs(),
188                         min_final_cltv_expiry_delta,
189                 )
190                 .map_err(|_| SignOrCreationError::CreationError(CreationError::InvalidAmount))?
191         };
192
193         log_trace!(logger, "Creating phantom invoice from {} participating nodes with payment hash {}",
194                 phantom_route_hints.len(), log_bytes!(payment_hash.0));
195
196         let mut invoice = invoice
197                 .duration_since_epoch(duration_since_epoch)
198                 .payment_hash(Hash::from_slice(&payment_hash.0).unwrap())
199                 .payment_secret(payment_secret)
200                 .min_final_cltv_expiry_delta(
201                         // Add a buffer of 3 to the delta if present, otherwise use LDK's minimum.
202                         min_final_cltv_expiry_delta.map(|x| x.saturating_add(3)).unwrap_or(MIN_FINAL_CLTV_EXPIRY_DELTA).into())
203                 .expiry_time(Duration::from_secs(invoice_expiry_delta_secs.into()));
204         if let Some(amt) = amt_msat {
205                 invoice = invoice.amount_milli_satoshis(amt);
206         }
207
208
209         for route_hint in select_phantom_hints(amt_msat, phantom_route_hints, logger).take(MAX_CHANNEL_HINTS) {
210                 invoice = invoice.private_route(route_hint);
211         }
212
213         let raw_invoice = match invoice.build_raw() {
214                 Ok(inv) => inv,
215                 Err(e) => return Err(SignOrCreationError::CreationError(e))
216         };
217         let hrp_str = raw_invoice.hrp.to_string();
218         let hrp_bytes = hrp_str.as_bytes();
219         let data_without_signature = raw_invoice.data.to_base32();
220         let signed_raw_invoice = raw_invoice.sign(|_| node_signer.sign_invoice(hrp_bytes, &data_without_signature, Recipient::PhantomNode));
221         match signed_raw_invoice {
222                 Ok(inv) => Ok(Invoice::from_signed(inv).unwrap()),
223                 Err(e) => Err(SignOrCreationError::SignError(e))
224         }
225 }
226
227 /// Utility to select route hints for phantom invoices.
228 /// See [`PhantomKeysManager`] for more information on phantom node payments.
229 ///
230 /// To ensure that the phantom invoice is still readable by QR code, we limit to 3 hints per invoice:
231 /// * Select up to three channels per node.
232 /// * Select one hint from each node, up to three hints or until we run out of hints.
233 ///
234 /// [`PhantomKeysManager`]: lightning::sign::PhantomKeysManager
235 fn select_phantom_hints<L: Deref>(amt_msat: Option<u64>, phantom_route_hints: Vec<PhantomRouteHints>,
236         logger: L) -> impl Iterator<Item = RouteHint>
237 where
238         L::Target: Logger,
239 {
240         let mut phantom_hints: Vec<_> = Vec::new();
241
242         for PhantomRouteHints { channels, phantom_scid, real_node_pubkey } in phantom_route_hints {
243                 log_trace!(logger, "Generating phantom route hints for node {}",
244                         log_pubkey!(real_node_pubkey));
245                 let route_hints = sort_and_filter_channels(channels, amt_msat, &logger);
246
247                 // If we have any public channel, the route hints from `sort_and_filter_channels` will be
248                 // empty. In that case we create a RouteHint on which we will push a single hop with the
249                 // phantom route into the invoice, and let the sender find the path to the `real_node_pubkey`
250                 // node by looking at our public channels.
251                 let empty_route_hints = route_hints.len() == 0;
252                 let mut have_pushed_empty = false;
253                 let route_hints = route_hints
254                         .chain(core::iter::from_fn(move || {
255                                 if empty_route_hints && !have_pushed_empty {
256                                         // set flag of having handled the empty route_hints and ensure empty vector
257                                         // returned only once
258                                         have_pushed_empty = true;
259                                         Some(RouteHint(Vec::new()))
260                                 } else {
261                                         None
262                                 }
263                         }))
264                         .map(move |mut hint| {
265                                 hint.0.push(RouteHintHop {
266                                         src_node_id: real_node_pubkey,
267                                         short_channel_id: phantom_scid,
268                                         fees: RoutingFees {
269                                                 base_msat: 0,
270                                                 proportional_millionths: 0,
271                                         },
272                                         cltv_expiry_delta: MIN_CLTV_EXPIRY_DELTA,
273                                         htlc_minimum_msat: None,
274                                         htlc_maximum_msat: None,
275                                 });
276                                 hint
277                         });
278
279                 phantom_hints.push(route_hints);
280         }
281
282         // We have one vector per real node involved in creating the phantom invoice. To distribute
283         // the hints across our real nodes we add one hint from each in turn until no node has any hints
284         // left (if one node has more hints than any other, these will accumulate at the end of the
285         // vector).
286         rotate_through_iterators(phantom_hints)
287 }
288
289 /// Draw items iteratively from multiple iterators.  The items are retrieved by index and
290 /// rotates through the iterators - first the zero index then the first index then second index, etc.
291 fn rotate_through_iterators<T, I: Iterator<Item = T>>(mut vecs: Vec<I>) -> impl Iterator<Item = T> {
292         let mut iterations = 0;
293
294         core::iter::from_fn(move || {
295                 let mut exhausted_iterators = 0;
296                 loop {
297                         if vecs.is_empty() {
298                                 return None;
299                         }
300                         let next_idx = iterations % vecs.len();
301                         iterations += 1;
302                         if let Some(item) = vecs[next_idx].next() {
303                                 return Some(item);
304                         }
305                         // exhausted_vectors increase when the "next_idx" vector is exhausted
306                         exhausted_iterators += 1;
307                         // The check for exhausted iterators gets reset to 0 after each yield of `Some()`
308                         // The loop will return None when all of the nested iterators are exhausted
309                         if exhausted_iterators == vecs.len() {
310                                 return None;
311                         }
312                 }
313         })
314 }
315
316 #[cfg(feature = "std")]
317 /// Utility to construct an invoice. Generally, unless you want to do something like a custom
318 /// cltv_expiry, this is what you should be using to create an invoice. The reason being, this
319 /// method stores the invoice's payment secret and preimage in `ChannelManager`, so (a) the user
320 /// doesn't have to store preimage/payment secret information and (b) `ChannelManager` can verify
321 /// that the payment secret is valid when the invoice is paid.
322 ///
323 /// `invoice_expiry_delta_secs` describes the number of seconds that the invoice is valid for
324 /// in excess of the current time.
325 ///
326 /// You can specify a custom `min_final_cltv_expiry_delta`, or let LDK default it to
327 /// [`MIN_FINAL_CLTV_EXPIRY_DELTA`]. The provided expiry must be at least [`MIN_FINAL_CLTV_EXPIRY_DELTA`].
328 /// Note that LDK will add a buffer of 3 blocks to the delta to allow for up to a few new block
329 /// confirmations during routing.
330 ///
331 /// [`MIN_FINAL_CLTV_EXPIRY_DETLA`]: lightning::ln::channelmanager::MIN_FINAL_CLTV_EXPIRY_DELTA
332 pub fn create_invoice_from_channelmanager<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
333         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
334         network: Currency, amt_msat: Option<u64>, description: String, invoice_expiry_delta_secs: u32,
335         min_final_cltv_expiry_delta: Option<u16>,
336 ) -> Result<Invoice, SignOrCreationError<()>>
337 where
338         M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
339         T::Target: BroadcasterInterface,
340         ES::Target: EntropySource,
341         NS::Target: NodeSigner,
342         SP::Target: SignerProvider,
343         F::Target: FeeEstimator,
344         R::Target: Router,
345         L::Target: Logger,
346 {
347         use std::time::SystemTime;
348         let duration = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH)
349                 .expect("for the foreseeable future this shouldn't happen");
350         create_invoice_from_channelmanager_and_duration_since_epoch(
351                 channelmanager, node_signer, logger, network, amt_msat,
352                 description, duration, invoice_expiry_delta_secs, min_final_cltv_expiry_delta,
353         )
354 }
355
356 #[cfg(feature = "std")]
357 /// Utility to construct an invoice. Generally, unless you want to do something like a custom
358 /// cltv_expiry, this is what you should be using to create an invoice. The reason being, this
359 /// method stores the invoice's payment secret and preimage in `ChannelManager`, so (a) the user
360 /// doesn't have to store preimage/payment secret information and (b) `ChannelManager` can verify
361 /// that the payment secret is valid when the invoice is paid.
362 /// Use this variant if you want to pass the `description_hash` to the invoice.
363 ///
364 /// `invoice_expiry_delta_secs` describes the number of seconds that the invoice is valid for
365 /// in excess of the current time.
366 ///
367 /// You can specify a custom `min_final_cltv_expiry_delta`, or let LDK default it to
368 /// [`MIN_FINAL_CLTV_EXPIRY_DELTA`]. The provided expiry must be at least [`MIN_FINAL_CLTV_EXPIRY_DELTA`].
369 /// Note that LDK will add a buffer of 3 blocks to the delta to allow for up to a few new block
370 /// confirmations during routing.
371 ///
372 /// [`MIN_FINAL_CLTV_EXPIRY_DETLA`]: lightning::ln::channelmanager::MIN_FINAL_CLTV_EXPIRY_DELTA
373 pub fn create_invoice_from_channelmanager_with_description_hash<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
374         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
375         network: Currency, amt_msat: Option<u64>, description_hash: Sha256,
376         invoice_expiry_delta_secs: u32, min_final_cltv_expiry_delta: Option<u16>,
377 ) -> Result<Invoice, SignOrCreationError<()>>
378 where
379         M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
380         T::Target: BroadcasterInterface,
381         ES::Target: EntropySource,
382         NS::Target: NodeSigner,
383         SP::Target: SignerProvider,
384         F::Target: FeeEstimator,
385         R::Target: Router,
386         L::Target: Logger,
387 {
388         use std::time::SystemTime;
389
390         let duration = SystemTime::now()
391                 .duration_since(SystemTime::UNIX_EPOCH)
392                 .expect("for the foreseeable future this shouldn't happen");
393
394         create_invoice_from_channelmanager_with_description_hash_and_duration_since_epoch(
395                 channelmanager, node_signer, logger, network, amt_msat,
396                 description_hash, duration, invoice_expiry_delta_secs, min_final_cltv_expiry_delta,
397         )
398 }
399
400 /// See [`create_invoice_from_channelmanager_with_description_hash`]
401 /// This version can be used in a `no_std` environment, where [`std::time::SystemTime`] is not
402 /// available and the current time is supplied by the caller.
403 pub fn create_invoice_from_channelmanager_with_description_hash_and_duration_since_epoch<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
404         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
405         network: Currency, amt_msat: Option<u64>, description_hash: Sha256,
406         duration_since_epoch: Duration, invoice_expiry_delta_secs: u32, min_final_cltv_expiry_delta: Option<u16>,
407 ) -> Result<Invoice, SignOrCreationError<()>>
408                 where
409                         M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
410                         T::Target: BroadcasterInterface,
411                         ES::Target: EntropySource,
412                         NS::Target: NodeSigner,
413                         SP::Target: SignerProvider,
414                         F::Target: FeeEstimator,
415                         R::Target: Router,
416                         L::Target: Logger,
417 {
418         _create_invoice_from_channelmanager_and_duration_since_epoch(
419                 channelmanager, node_signer, logger, network, amt_msat,
420                 InvoiceDescription::Hash(&description_hash),
421                 duration_since_epoch, invoice_expiry_delta_secs, min_final_cltv_expiry_delta,
422         )
423 }
424
425 /// See [`create_invoice_from_channelmanager`]
426 /// This version can be used in a `no_std` environment, where [`std::time::SystemTime`] is not
427 /// available and the current time is supplied by the caller.
428 pub fn create_invoice_from_channelmanager_and_duration_since_epoch<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
429         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
430         network: Currency, amt_msat: Option<u64>, description: String, duration_since_epoch: Duration,
431         invoice_expiry_delta_secs: u32, min_final_cltv_expiry_delta: Option<u16>,
432 ) -> Result<Invoice, SignOrCreationError<()>>
433                 where
434                         M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
435                         T::Target: BroadcasterInterface,
436                         ES::Target: EntropySource,
437                         NS::Target: NodeSigner,
438                         SP::Target: SignerProvider,
439                         F::Target: FeeEstimator,
440                         R::Target: Router,
441                         L::Target: Logger,
442 {
443         _create_invoice_from_channelmanager_and_duration_since_epoch(
444                 channelmanager, node_signer, logger, network, amt_msat,
445                 InvoiceDescription::Direct(
446                         &Description::new(description).map_err(SignOrCreationError::CreationError)?,
447                 ),
448                 duration_since_epoch, invoice_expiry_delta_secs, min_final_cltv_expiry_delta,
449         )
450 }
451
452 fn _create_invoice_from_channelmanager_and_duration_since_epoch<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
453         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
454         network: Currency, amt_msat: Option<u64>, description: InvoiceDescription,
455         duration_since_epoch: Duration, invoice_expiry_delta_secs: u32, min_final_cltv_expiry_delta: Option<u16>,
456 ) -> Result<Invoice, SignOrCreationError<()>>
457                 where
458                         M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
459                         T::Target: BroadcasterInterface,
460                         ES::Target: EntropySource,
461                         NS::Target: NodeSigner,
462                         SP::Target: SignerProvider,
463                         F::Target: FeeEstimator,
464                         R::Target: Router,
465                         L::Target: Logger,
466 {
467         if min_final_cltv_expiry_delta.is_some() && min_final_cltv_expiry_delta.unwrap().saturating_add(3) < MIN_FINAL_CLTV_EXPIRY_DELTA {
468                 return Err(SignOrCreationError::CreationError(CreationError::MinFinalCltvExpiryDeltaTooShort));
469         }
470
471         // `create_inbound_payment` only returns an error if the amount is greater than the total bitcoin
472         // supply.
473         let (payment_hash, payment_secret) = channelmanager
474                 .create_inbound_payment(amt_msat, invoice_expiry_delta_secs, min_final_cltv_expiry_delta)
475                 .map_err(|()| SignOrCreationError::CreationError(CreationError::InvalidAmount))?;
476         _create_invoice_from_channelmanager_and_duration_since_epoch_with_payment_hash(
477                 channelmanager, node_signer, logger, network, amt_msat, description, duration_since_epoch,
478                 invoice_expiry_delta_secs, payment_hash, payment_secret, min_final_cltv_expiry_delta)
479 }
480
481 /// See [`create_invoice_from_channelmanager_and_duration_since_epoch`]
482 /// This version allows for providing a custom [`PaymentHash`] for the invoice.
483 /// This may be useful if you're building an on-chain swap or involving another protocol where
484 /// the payment hash is also involved outside the scope of lightning.
485 pub fn create_invoice_from_channelmanager_and_duration_since_epoch_with_payment_hash<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
486         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
487         network: Currency, amt_msat: Option<u64>, description: String, duration_since_epoch: Duration,
488         invoice_expiry_delta_secs: u32, payment_hash: PaymentHash, min_final_cltv_expiry_delta: Option<u16>,
489 ) -> Result<Invoice, SignOrCreationError<()>>
490         where
491                 M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
492                 T::Target: BroadcasterInterface,
493                 ES::Target: EntropySource,
494                 NS::Target: NodeSigner,
495                 SP::Target: SignerProvider,
496                 F::Target: FeeEstimator,
497                 R::Target: Router,
498                 L::Target: Logger,
499 {
500         let payment_secret = channelmanager
501                 .create_inbound_payment_for_hash(payment_hash, amt_msat, invoice_expiry_delta_secs,
502                         min_final_cltv_expiry_delta)
503                 .map_err(|()| SignOrCreationError::CreationError(CreationError::InvalidAmount))?;
504         _create_invoice_from_channelmanager_and_duration_since_epoch_with_payment_hash(
505                 channelmanager, node_signer, logger, network, amt_msat,
506                 InvoiceDescription::Direct(
507                         &Description::new(description).map_err(SignOrCreationError::CreationError)?,
508                 ),
509                 duration_since_epoch, invoice_expiry_delta_secs, payment_hash, payment_secret,
510                 min_final_cltv_expiry_delta,
511         )
512 }
513
514 fn _create_invoice_from_channelmanager_and_duration_since_epoch_with_payment_hash<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
515         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
516         network: Currency, amt_msat: Option<u64>, description: InvoiceDescription, duration_since_epoch: Duration,
517         invoice_expiry_delta_secs: u32, payment_hash: PaymentHash, payment_secret: PaymentSecret,
518         min_final_cltv_expiry_delta: Option<u16>,
519 ) -> Result<Invoice, SignOrCreationError<()>>
520         where
521                 M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
522                 T::Target: BroadcasterInterface,
523                 ES::Target: EntropySource,
524                 NS::Target: NodeSigner,
525                 SP::Target: SignerProvider,
526                 F::Target: FeeEstimator,
527                 R::Target: Router,
528                 L::Target: Logger,
529 {
530         let our_node_pubkey = channelmanager.get_our_node_id();
531         let channels = channelmanager.list_channels();
532
533         if min_final_cltv_expiry_delta.is_some() && min_final_cltv_expiry_delta.unwrap().saturating_add(3) < MIN_FINAL_CLTV_EXPIRY_DELTA {
534                 return Err(SignOrCreationError::CreationError(CreationError::MinFinalCltvExpiryDeltaTooShort));
535         }
536
537         log_trace!(logger, "Creating invoice with payment hash {}", log_bytes!(payment_hash.0));
538
539         let invoice = match description {
540                 InvoiceDescription::Direct(description) => {
541                         InvoiceBuilder::new(network).description(description.0.clone())
542                 }
543                 InvoiceDescription::Hash(hash) => InvoiceBuilder::new(network).description_hash(hash.0),
544         };
545
546         let mut invoice = invoice
547                 .duration_since_epoch(duration_since_epoch)
548                 .payee_pub_key(our_node_pubkey)
549                 .payment_hash(Hash::from_slice(&payment_hash.0).unwrap())
550                 .payment_secret(payment_secret)
551                 .basic_mpp()
552                 .min_final_cltv_expiry_delta(
553                         // Add a buffer of 3 to the delta if present, otherwise use LDK's minimum.
554                         min_final_cltv_expiry_delta.map(|x| x.saturating_add(3)).unwrap_or(MIN_FINAL_CLTV_EXPIRY_DELTA).into())
555                 .expiry_time(Duration::from_secs(invoice_expiry_delta_secs.into()));
556         if let Some(amt) = amt_msat {
557                 invoice = invoice.amount_milli_satoshis(amt);
558         }
559
560         let route_hints = sort_and_filter_channels(channels, amt_msat, &logger);
561         for hint in route_hints {
562                 invoice = invoice.private_route(hint);
563         }
564
565         let raw_invoice = match invoice.build_raw() {
566                 Ok(inv) => inv,
567                 Err(e) => return Err(SignOrCreationError::CreationError(e))
568         };
569         let hrp_str = raw_invoice.hrp.to_string();
570         let hrp_bytes = hrp_str.as_bytes();
571         let data_without_signature = raw_invoice.data.to_base32();
572         let signed_raw_invoice = raw_invoice.sign(|_| node_signer.sign_invoice(hrp_bytes, &data_without_signature, Recipient::Node));
573         match signed_raw_invoice {
574                 Ok(inv) => Ok(Invoice::from_signed(inv).unwrap()),
575                 Err(e) => Err(SignOrCreationError::SignError(e))
576         }
577 }
578
579 /// Sorts and filters the `channels` for an invoice, and returns the corresponding `RouteHint`s to include
580 /// in the invoice.
581 ///
582 /// The filtering is based on the following criteria:
583 /// * Only one channel per counterparty node
584 /// * If the counterparty has a channel that is above the `min_inbound_capacity_msat` + 10% scaling
585 ///   factor (to allow some margin for change in inbound), select the channel with the lowest
586 ///   inbound capacity that is above this threshold.
587 /// * If no `min_inbound_capacity_msat` is specified, or the counterparty has no channels above the
588 ///   minimum + 10% scaling factor, select the channel with the highest inbound capacity per counterparty.
589 /// * Prefer channels with capacity at least `min_inbound_capacity_msat` and where the channel
590 ///   `is_usable` (i.e. the peer is connected).
591 /// * If any public channel exists, only public [`RouteHint`]s will be returned.
592 /// * If any public, announced, channel exists (i.e. a channel with 7+ confs, to ensure the
593 ///   announcement has had a chance to propagate), no [`RouteHint`]s will be returned, as the
594 ///   sender is expected to find the path by looking at the public channels instead.
595 /// * Limited to a total of 3 channels.
596 /// * Sorted by lowest inbound capacity if an online channel with the minimum amount requested exists,
597 ///   otherwise sort by highest inbound capacity to give the payment the best chance of succeeding.
598 fn sort_and_filter_channels<L: Deref>(
599         channels: Vec<ChannelDetails>,
600         min_inbound_capacity_msat: Option<u64>,
601         logger: &L,
602 ) -> impl ExactSizeIterator<Item = RouteHint>
603 where
604         L::Target: Logger,
605 {
606         let mut filtered_channels: HashMap<PublicKey, ChannelDetails> = HashMap::new();
607         let min_inbound_capacity = min_inbound_capacity_msat.unwrap_or(0);
608         let mut min_capacity_channel_exists = false;
609         let mut online_channel_exists = false;
610         let mut online_min_capacity_channel_exists = false;
611         let mut has_pub_unconf_chan = false;
612
613         let route_hint_from_channel = |channel: ChannelDetails| {
614                 let forwarding_info = channel.counterparty.forwarding_info.as_ref().unwrap();
615                 RouteHint(vec![RouteHintHop {
616                         src_node_id: channel.counterparty.node_id,
617                         short_channel_id: channel.get_inbound_payment_scid().unwrap(),
618                         fees: RoutingFees {
619                                 base_msat: forwarding_info.fee_base_msat,
620                                 proportional_millionths: forwarding_info.fee_proportional_millionths,
621                         },
622                         cltv_expiry_delta: forwarding_info.cltv_expiry_delta,
623                         htlc_minimum_msat: channel.inbound_htlc_minimum_msat,
624                         htlc_maximum_msat: channel.inbound_htlc_maximum_msat,}])
625         };
626
627         log_trace!(logger, "Considering {} channels for invoice route hints", channels.len());
628         for channel in channels.into_iter().filter(|chan| chan.is_channel_ready) {
629                 if channel.get_inbound_payment_scid().is_none() || channel.counterparty.forwarding_info.is_none() {
630                         log_trace!(logger, "Ignoring channel {} for invoice route hints", log_bytes!(channel.channel_id));
631                         continue;
632                 }
633
634                 if channel.is_public {
635                         if channel.confirmations.is_some() && channel.confirmations < Some(7) {
636                                 // If we have a public channel, but it doesn't have enough confirmations to (yet)
637                                 // be in the public network graph (and have gotten a chance to propagate), include
638                                 // route hints but only for public channels to protect private channel privacy.
639                                 has_pub_unconf_chan = true;
640                         } else {
641                                 // If any public channel exists, return no hints and let the sender
642                                 // look at the public channels instead.
643                                 log_trace!(logger, "Not including channels in invoice route hints on account of public channel {}",
644                                         log_bytes!(channel.channel_id));
645                                 return vec![].into_iter().take(MAX_CHANNEL_HINTS).map(route_hint_from_channel);
646                         }
647                 }
648
649                 if channel.inbound_capacity_msat >= min_inbound_capacity {
650                         if !min_capacity_channel_exists {
651                                 log_trace!(logger, "Channel with enough inbound capacity exists for invoice route hints");
652                                 min_capacity_channel_exists = true;
653                         }
654
655                         if channel.is_usable {
656                                 online_min_capacity_channel_exists = true;
657                         }
658                 }
659
660                 if channel.is_usable && !online_channel_exists {
661                         log_trace!(logger, "Channel with connected peer exists for invoice route hints");
662                         online_channel_exists = true;
663                 }
664
665                 match filtered_channels.entry(channel.counterparty.node_id) {
666                         hash_map::Entry::Occupied(mut entry) => {
667                                 let current_max_capacity = entry.get().inbound_capacity_msat;
668                                 // If this channel is public and the previous channel is not, ensure we replace the
669                                 // previous channel to avoid announcing non-public channels.
670                                 let new_now_public = channel.is_public && !entry.get().is_public;
671                                 // Decide whether we prefer the currently selected channel with the node to the new one,
672                                 // based on their inbound capacity.
673                                 let prefer_current = prefer_current_channel(min_inbound_capacity_msat, current_max_capacity,
674                                         channel.inbound_capacity_msat);
675                                 // If the public-ness of the channel has not changed (in which case simply defer to
676                                 // `new_now_public), and this channel has more desirable inbound than the incumbent,
677                                 // prefer to include this channel.
678                                 let new_channel_preferable = channel.is_public == entry.get().is_public && !prefer_current;
679
680                                 if new_now_public || new_channel_preferable {
681                                         log_trace!(logger,
682                                                 "Preferring counterparty {} channel {} (SCID {:?}, {} msats) over {} (SCID {:?}, {} msats) for invoice route hints",
683                                                 log_pubkey!(channel.counterparty.node_id),
684                                                 log_bytes!(channel.channel_id), channel.short_channel_id,
685                                                 channel.inbound_capacity_msat,
686                                                 log_bytes!(entry.get().channel_id), entry.get().short_channel_id,
687                                                 current_max_capacity);
688                                         entry.insert(channel);
689                                 } else {
690                                         log_trace!(logger,
691                                                 "Preferring counterparty {} channel {} (SCID {:?}, {} msats) over {} (SCID {:?}, {} msats) for invoice route hints",
692                                                 log_pubkey!(channel.counterparty.node_id),
693                                                 log_bytes!(entry.get().channel_id), entry.get().short_channel_id,
694                                                 current_max_capacity,
695                                                 log_bytes!(channel.channel_id), channel.short_channel_id,
696                                                 channel.inbound_capacity_msat);
697                                 }
698                         }
699                         hash_map::Entry::Vacant(entry) => {
700                                 entry.insert(channel);
701                         }
702                 }
703         }
704
705         // If all channels are private, prefer to return route hints which have a higher capacity than
706         // the payment value and where we're currently connected to the channel counterparty.
707         // Even if we cannot satisfy both goals, always ensure we include *some* hints, preferring
708         // those which meet at least one criteria.
709         let mut eligible_channels = filtered_channels
710                 .into_iter()
711                 .map(|(_, channel)| channel)
712                 .filter(|channel| {
713                         let has_enough_capacity = channel.inbound_capacity_msat >= min_inbound_capacity;
714                         let include_channel = if has_pub_unconf_chan {
715                                 // If we have a public channel, but it doesn't have enough confirmations to (yet)
716                                 // be in the public network graph (and have gotten a chance to propagate), include
717                                 // route hints but only for public channels to protect private channel privacy.
718                                 channel.is_public
719                         } else if online_min_capacity_channel_exists {
720                                 has_enough_capacity && channel.is_usable
721                         } else if min_capacity_channel_exists && online_channel_exists {
722                                 // If there are some online channels and some min_capacity channels, but no
723                                 // online-and-min_capacity channels, just include the min capacity ones and ignore
724                                 // online-ness.
725                                 has_enough_capacity
726                         } else if min_capacity_channel_exists {
727                                 has_enough_capacity
728                         } else if online_channel_exists {
729                                 channel.is_usable
730                         } else { true };
731
732                         if include_channel {
733                                 log_trace!(logger, "Including channel {} in invoice route hints",
734                                         log_bytes!(channel.channel_id));
735                         } else if !has_enough_capacity {
736                                 log_trace!(logger, "Ignoring channel {} without enough capacity for invoice route hints",
737                                         log_bytes!(channel.channel_id));
738                         } else {
739                                 debug_assert!(!channel.is_usable || (has_pub_unconf_chan && !channel.is_public));
740                                 log_trace!(logger, "Ignoring channel {} with disconnected peer",
741                                         log_bytes!(channel.channel_id));
742                         }
743
744                         include_channel
745                 })
746                 .collect::<Vec<ChannelDetails>>();
747
748                 eligible_channels.sort_unstable_by(|a, b| {
749                         if online_min_capacity_channel_exists {
750                                 a.inbound_capacity_msat.cmp(&b.inbound_capacity_msat)
751                         } else {
752                                 b.inbound_capacity_msat.cmp(&a.inbound_capacity_msat)
753                         }});
754
755                 eligible_channels.into_iter().take(MAX_CHANNEL_HINTS).map(route_hint_from_channel)
756 }
757
758 /// prefer_current_channel chooses a channel to use for route hints between a currently selected and candidate
759 /// channel based on the inbound capacity of each channel and the minimum inbound capacity requested for the hints,
760 /// returning true if the current channel should be preferred over the candidate channel.
761 /// * If no minimum amount is requested, the channel with the most inbound is chosen to maximize the chances that a
762 ///   payment of any size will succeed.
763 /// * If we have channels with inbound above our minimum requested inbound (plus a 10% scaling factor, expressed as a
764 ///   percentage) then we choose the lowest inbound channel with above this amount. If we have sufficient inbound
765 ///   channels, we don't want to deplete our larger channels with small payments (the off-chain version of "grinding
766 ///   our change").
767 /// * If no channel above our minimum amount exists, then we just prefer the channel with the most inbound to give
768 ///   payments the best chance of succeeding in multiple parts.
769 fn prefer_current_channel(min_inbound_capacity_msat: Option<u64>, current_channel: u64,
770         candidate_channel: u64) -> bool {
771
772         // If no min amount is given for the hints, err of the side of caution and choose the largest channel inbound to
773         // maximize chances of any payment succeeding.
774         if min_inbound_capacity_msat.is_none() {
775                 return current_channel > candidate_channel
776         }
777
778         let scaled_min_inbound = min_inbound_capacity_msat.unwrap() * 110;
779         let current_sufficient = current_channel * 100 >= scaled_min_inbound;
780         let candidate_sufficient = candidate_channel * 100 >= scaled_min_inbound;
781
782         if current_sufficient && candidate_sufficient {
783                 return current_channel < candidate_channel
784         } else if current_sufficient {
785                 return true
786         } else if candidate_sufficient {
787                 return false
788         }
789
790         current_channel > candidate_channel
791 }
792
793 #[cfg(test)]
794 mod test {
795         use core::cell::RefCell;
796         use core::time::Duration;
797         use crate::{Currency, Description, InvoiceDescription, SignOrCreationError, CreationError};
798         use bitcoin_hashes::{Hash, sha256};
799         use bitcoin_hashes::sha256::Hash as Sha256;
800         use lightning::sign::PhantomKeysManager;
801         use lightning::events::{MessageSendEvent, MessageSendEventsProvider, Event, EventsProvider};
802         use lightning::ln::{PaymentPreimage, PaymentHash};
803         use lightning::ln::channelmanager::{PhantomRouteHints, MIN_FINAL_CLTV_EXPIRY_DELTA, PaymentId, RecipientOnionFields, Retry};
804         use lightning::ln::functional_test_utils::*;
805         use lightning::ln::msgs::ChannelMessageHandler;
806         use lightning::routing::router::{PaymentParameters, RouteParameters};
807         use lightning::util::test_utils;
808         use lightning::util::config::UserConfig;
809         use crate::utils::{create_invoice_from_channelmanager_and_duration_since_epoch, rotate_through_iterators};
810         use std::collections::HashSet;
811
812         #[test]
813         fn test_prefer_current_channel() {
814                 // No minimum, prefer larger candidate channel.
815                 assert_eq!(crate::utils::prefer_current_channel(None, 100, 200), false);
816
817                 // No minimum, prefer larger current channel.
818                 assert_eq!(crate::utils::prefer_current_channel(None, 200, 100), true);
819
820                 // Minimum set, prefer current channel over minimum + buffer.
821                 assert_eq!(crate::utils::prefer_current_channel(Some(100), 115, 100), true);
822
823                 // Minimum set, prefer candidate channel over minimum + buffer.
824                 assert_eq!(crate::utils::prefer_current_channel(Some(100), 105, 125), false);
825
826                 // Minimum set, both channels sufficient, prefer smaller current channel.
827                 assert_eq!(crate::utils::prefer_current_channel(Some(100), 115, 125), true);
828
829                 // Minimum set, both channels sufficient, prefer smaller candidate channel.
830                 assert_eq!(crate::utils::prefer_current_channel(Some(100), 200, 160), false);
831
832                 // Minimum set, neither sufficient, prefer larger current channel.
833                 assert_eq!(crate::utils::prefer_current_channel(Some(200), 100, 50), true);
834
835                 // Minimum set, neither sufficient, prefer larger candidate channel.
836                 assert_eq!(crate::utils::prefer_current_channel(Some(200), 100, 150), false);
837         }
838
839
840         #[test]
841         fn test_from_channelmanager() {
842                 let chanmon_cfgs = create_chanmon_cfgs(2);
843                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
844                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
845                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
846                 create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001);
847                 let non_default_invoice_expiry_secs = 4200;
848                 let invoice = create_invoice_from_channelmanager_and_duration_since_epoch(
849                         nodes[1].node, nodes[1].keys_manager, nodes[1].logger, Currency::BitcoinTestnet,
850                         Some(10_000), "test".to_string(), Duration::from_secs(1234567),
851                         non_default_invoice_expiry_secs, None).unwrap();
852                 assert_eq!(invoice.amount_pico_btc(), Some(100_000));
853                 // If no `min_final_cltv_expiry_delta` is specified, then it should be `MIN_FINAL_CLTV_EXPIRY_DELTA`.
854                 assert_eq!(invoice.min_final_cltv_expiry_delta(), MIN_FINAL_CLTV_EXPIRY_DELTA as u64);
855                 assert_eq!(invoice.description(), InvoiceDescription::Direct(&Description("test".to_string())));
856                 assert_eq!(invoice.expiry_time(), Duration::from_secs(non_default_invoice_expiry_secs.into()));
857
858                 // Invoice SCIDs should always use inbound SCID aliases over the real channel ID, if one is
859                 // available.
860                 let chan = &nodes[1].node.list_usable_channels()[0];
861                 assert_eq!(invoice.route_hints().len(), 1);
862                 assert_eq!(invoice.route_hints()[0].0.len(), 1);
863                 assert_eq!(invoice.route_hints()[0].0[0].short_channel_id, chan.inbound_scid_alias.unwrap());
864
865                 assert_eq!(invoice.route_hints()[0].0[0].htlc_minimum_msat, chan.inbound_htlc_minimum_msat);
866                 assert_eq!(invoice.route_hints()[0].0[0].htlc_maximum_msat, chan.inbound_htlc_maximum_msat);
867
868                 let payment_params = PaymentParameters::from_node_id(invoice.recover_payee_pub_key(),
869                                 invoice.min_final_cltv_expiry_delta() as u32)
870                         .with_bolt11_features(invoice.features().unwrap().clone()).unwrap()
871                         .with_route_hints(invoice.route_hints()).unwrap();
872                 let route_params = RouteParameters {
873                         payment_params,
874                         final_value_msat: invoice.amount_milli_satoshis().unwrap(),
875                 };
876                 let payment_event = {
877                         let mut payment_hash = PaymentHash([0; 32]);
878                         payment_hash.0.copy_from_slice(&invoice.payment_hash().as_ref()[0..32]);
879                         nodes[0].node.send_payment(payment_hash,
880                                 RecipientOnionFields::secret_only(*invoice.payment_secret()),
881                                 PaymentId(payment_hash.0), route_params, Retry::Attempts(0)).unwrap();
882                         let mut added_monitors = nodes[0].chain_monitor.added_monitors.lock().unwrap();
883                         assert_eq!(added_monitors.len(), 1);
884                         added_monitors.clear();
885
886                         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
887                         assert_eq!(events.len(), 1);
888                         SendEvent::from_event(events.remove(0))
889
890                 };
891                 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
892                 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event.commitment_msg);
893                 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
894                 assert_eq!(added_monitors.len(), 1);
895                 added_monitors.clear();
896                 let events = nodes[1].node.get_and_clear_pending_msg_events();
897                 assert_eq!(events.len(), 2);
898         }
899
900         fn do_create_invoice_min_final_cltv_delta(with_custom_delta: bool) {
901                 let chanmon_cfgs = create_chanmon_cfgs(2);
902                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
903                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
904                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
905                 let custom_min_final_cltv_expiry_delta = Some(50);
906
907                 let invoice = crate::utils::create_invoice_from_channelmanager_and_duration_since_epoch(
908                         nodes[1].node, nodes[1].keys_manager, nodes[1].logger, Currency::BitcoinTestnet,
909                         Some(10_000), "".into(), Duration::from_secs(1234567), 3600,
910                         if with_custom_delta { custom_min_final_cltv_expiry_delta } else { None },
911                 ).unwrap();
912                 assert_eq!(invoice.min_final_cltv_expiry_delta(), if with_custom_delta {
913                         custom_min_final_cltv_expiry_delta.unwrap() + 3 /* Buffer */} else { MIN_FINAL_CLTV_EXPIRY_DELTA } as u64);
914         }
915
916         #[test]
917         fn test_create_invoice_custom_min_final_cltv_delta() {
918                 do_create_invoice_min_final_cltv_delta(true);
919                 do_create_invoice_min_final_cltv_delta(false);
920         }
921
922         #[test]
923         fn create_invoice_min_final_cltv_delta_equals_htlc_fail_buffer() {
924                 let chanmon_cfgs = create_chanmon_cfgs(2);
925                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
926                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
927                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
928                 let custom_min_final_cltv_expiry_delta = Some(21);
929
930                 let invoice = crate::utils::create_invoice_from_channelmanager_and_duration_since_epoch(
931                         nodes[1].node, nodes[1].keys_manager, nodes[1].logger, Currency::BitcoinTestnet,
932                         Some(10_000), "".into(), Duration::from_secs(1234567), 3600,
933                         custom_min_final_cltv_expiry_delta,
934                 ).unwrap();
935                 assert_eq!(invoice.min_final_cltv_expiry_delta(), MIN_FINAL_CLTV_EXPIRY_DELTA as u64);
936         }
937
938         #[test]
939         fn test_create_invoice_with_description_hash() {
940                 let chanmon_cfgs = create_chanmon_cfgs(2);
941                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
942                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
943                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
944                 let description_hash = crate::Sha256(Hash::hash("Testing description_hash".as_bytes()));
945                 let invoice = crate::utils::create_invoice_from_channelmanager_with_description_hash_and_duration_since_epoch(
946                         nodes[1].node, nodes[1].keys_manager, nodes[1].logger, Currency::BitcoinTestnet,
947                         Some(10_000), description_hash, Duration::from_secs(1234567), 3600, None,
948                 ).unwrap();
949                 assert_eq!(invoice.amount_pico_btc(), Some(100_000));
950                 assert_eq!(invoice.min_final_cltv_expiry_delta(), MIN_FINAL_CLTV_EXPIRY_DELTA as u64);
951                 assert_eq!(invoice.description(), InvoiceDescription::Hash(&crate::Sha256(Sha256::hash("Testing description_hash".as_bytes()))));
952         }
953
954         #[test]
955         fn test_create_invoice_from_channelmanager_and_duration_since_epoch_with_payment_hash() {
956                 let chanmon_cfgs = create_chanmon_cfgs(2);
957                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
958                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
959                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
960                 let payment_hash = PaymentHash([0; 32]);
961                 let invoice = crate::utils::create_invoice_from_channelmanager_and_duration_since_epoch_with_payment_hash(
962                         nodes[1].node, nodes[1].keys_manager, nodes[1].logger, Currency::BitcoinTestnet,
963                         Some(10_000), "test".to_string(), Duration::from_secs(1234567), 3600,
964                         payment_hash, None,
965                 ).unwrap();
966                 assert_eq!(invoice.amount_pico_btc(), Some(100_000));
967                 assert_eq!(invoice.min_final_cltv_expiry_delta(), MIN_FINAL_CLTV_EXPIRY_DELTA as u64);
968                 assert_eq!(invoice.description(), InvoiceDescription::Direct(&Description("test".to_string())));
969                 assert_eq!(invoice.payment_hash(), &sha256::Hash::from_slice(&payment_hash.0[..]).unwrap());
970         }
971
972         #[test]
973         fn test_hints_has_only_public_confd_channels() {
974                 let chanmon_cfgs = create_chanmon_cfgs(2);
975                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
976                 let mut config = test_default_channel_config();
977                 config.channel_handshake_config.minimum_depth = 1;
978                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[Some(config), Some(config)]);
979                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
980
981                 // Create a private channel with lots of capacity and a lower value public channel (without
982                 // confirming the funding tx yet).
983                 let unannounced_scid = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 10_000_000, 0);
984                 let conf_tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 10_000, 0);
985
986                 // Before the channel is available, we should include the unannounced_scid.
987                 let mut scid_aliases = HashSet::new();
988                 scid_aliases.insert(unannounced_scid.0.short_channel_id_alias.unwrap());
989                 match_invoice_routes(Some(5000), &nodes[1], scid_aliases.clone());
990
991                 // However after we mine the funding tx and exchange channel_ready messages for the public
992                 // channel we'll immediately switch to including it as a route hint, even though it isn't
993                 // yet announced.
994                 let pub_channel_scid = mine_transaction(&nodes[0], &conf_tx);
995                 let node_a_pub_channel_ready = get_event_msg!(nodes[0], MessageSendEvent::SendChannelReady, nodes[1].node.get_our_node_id());
996                 nodes[1].node.handle_channel_ready(&nodes[0].node.get_our_node_id(), &node_a_pub_channel_ready);
997
998                 assert_eq!(mine_transaction(&nodes[1], &conf_tx), pub_channel_scid);
999                 let events = nodes[1].node.get_and_clear_pending_msg_events();
1000                 assert_eq!(events.len(), 2);
1001                 if let MessageSendEvent::SendChannelReady { msg, .. } = &events[0] {
1002                         nodes[0].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), msg);
1003                 } else { panic!(); }
1004                 if let MessageSendEvent::SendChannelUpdate { msg, .. } = &events[1] {
1005                         nodes[0].node.handle_channel_update(&nodes[1].node.get_our_node_id(), msg);
1006                 } else { panic!(); }
1007
1008                 nodes[1].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id()));
1009
1010                 expect_channel_ready_event(&nodes[0], &nodes[1].node.get_our_node_id());
1011                 expect_channel_ready_event(&nodes[1], &nodes[0].node.get_our_node_id());
1012
1013                 scid_aliases.clear();
1014                 scid_aliases.insert(node_a_pub_channel_ready.short_channel_id_alias.unwrap());
1015                 match_invoice_routes(Some(5000), &nodes[1], scid_aliases.clone());
1016                 // This also applies even if the amount is more than the payment amount, to ensure users
1017                 // dont screw up their privacy.
1018                 match_invoice_routes(Some(50_000_000), &nodes[1], scid_aliases.clone());
1019
1020                 // The same remains true until the channel has 7 confirmations, at which point we include
1021                 // no hints.
1022                 connect_blocks(&nodes[1], 5);
1023                 match_invoice_routes(Some(5000), &nodes[1], scid_aliases.clone());
1024                 connect_blocks(&nodes[1], 1);
1025                 get_event_msg!(nodes[1], MessageSendEvent::SendAnnouncementSignatures, nodes[0].node.get_our_node_id());
1026                 match_invoice_routes(Some(5000), &nodes[1], HashSet::new());
1027         }
1028
1029         #[test]
1030         fn test_hints_includes_single_channels_to_nodes() {
1031                 let chanmon_cfgs = create_chanmon_cfgs(3);
1032                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1033                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1034                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1035
1036                 let chan_1_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 100000, 10001);
1037                 let chan_2_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 2, 0, 100000, 10001);
1038
1039                 let mut scid_aliases = HashSet::new();
1040                 scid_aliases.insert(chan_1_0.0.short_channel_id_alias.unwrap());
1041                 scid_aliases.insert(chan_2_0.0.short_channel_id_alias.unwrap());
1042
1043                 match_invoice_routes(Some(5000), &nodes[0], scid_aliases);
1044         }
1045
1046         #[test]
1047         fn test_hints_has_only_lowest_inbound_capacity_channel_above_minimum() {
1048                 let chanmon_cfgs = create_chanmon_cfgs(2);
1049                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1050                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1051                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1052
1053                 let _chan_1_0_inbound_below_amt = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 10_000, 0);
1054                 let _chan_1_0_large_inbound_above_amt = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 500_000, 0);
1055                 let chan_1_0_low_inbound_above_amt = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 200_000, 0);
1056
1057                 let mut scid_aliases = HashSet::new();
1058                 scid_aliases.insert(chan_1_0_low_inbound_above_amt.0.short_channel_id_alias.unwrap());
1059                 match_invoice_routes(Some(100_000_000), &nodes[0], scid_aliases);
1060         }
1061
1062         #[test]
1063         fn test_hints_has_only_online_channels() {
1064                 let chanmon_cfgs = create_chanmon_cfgs(4);
1065                 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
1066                 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
1067                 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
1068                 let chan_a = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 10_000_000, 0);
1069                 let chan_b = create_unannounced_chan_between_nodes_with_value(&nodes, 2, 0, 10_000_000, 0);
1070                 let _chan_c = create_unannounced_chan_between_nodes_with_value(&nodes, 3, 0, 1_000_000, 0);
1071
1072                 // With all peers connected we should get all hints that have sufficient value
1073                 let mut scid_aliases = HashSet::new();
1074                 scid_aliases.insert(chan_a.0.short_channel_id_alias.unwrap());
1075                 scid_aliases.insert(chan_b.0.short_channel_id_alias.unwrap());
1076
1077                 match_invoice_routes(Some(1_000_000_000), &nodes[0], scid_aliases.clone());
1078
1079                 // With only one sufficient-value peer connected we should only get its hint
1080                 scid_aliases.remove(&chan_b.0.short_channel_id_alias.unwrap());
1081                 nodes[0].node.peer_disconnected(&nodes[2].node.get_our_node_id());
1082                 match_invoice_routes(Some(1_000_000_000), &nodes[0], scid_aliases.clone());
1083
1084                 // If we don't have any sufficient-value peers connected we should get all hints with
1085                 // sufficient value, even though there is a connected insufficient-value peer.
1086                 scid_aliases.insert(chan_b.0.short_channel_id_alias.unwrap());
1087                 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id());
1088                 match_invoice_routes(Some(1_000_000_000), &nodes[0], scid_aliases);
1089         }
1090
1091         #[test]
1092         fn test_insufficient_inbound_sort_by_highest_capacity() {
1093                 let chanmon_cfgs = create_chanmon_cfgs(5);
1094                 let node_cfgs = create_node_cfgs(5, &chanmon_cfgs);
1095                 let node_chanmgrs = create_node_chanmgrs(5, &node_cfgs, &[None, None, None, None, None]);
1096                 let nodes = create_network(5, &node_cfgs, &node_chanmgrs);
1097                 let _chan_1_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 100_000, 0);
1098                 let chan_2_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 2, 0, 200_000, 0);
1099                 let chan_3_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 3, 0, 300_000, 0);
1100                 let chan_4_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 4, 0, 400_000, 0);
1101
1102                 // When no single channel has enough inbound capacity for the payment, we expect the three
1103                 // highest inbound channels to be chosen.
1104                 let mut scid_aliases = HashSet::new();
1105                 scid_aliases.insert(chan_2_0.0.short_channel_id_alias.unwrap());
1106                 scid_aliases.insert(chan_3_0.0.short_channel_id_alias.unwrap());
1107                 scid_aliases.insert(chan_4_0.0.short_channel_id_alias.unwrap());
1108
1109                 match_invoice_routes(Some(1_000_000_000), &nodes[0], scid_aliases.clone());
1110         }
1111
1112         #[test]
1113         fn test_sufficient_inbound_sort_by_lowest_capacity() {
1114                 let chanmon_cfgs = create_chanmon_cfgs(5);
1115                 let node_cfgs = create_node_cfgs(5, &chanmon_cfgs);
1116                 let node_chanmgrs = create_node_chanmgrs(5, &node_cfgs, &[None, None, None, None, None]);
1117                 let nodes = create_network(5, &node_cfgs, &node_chanmgrs);
1118                 let chan_1_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 100_000, 0);
1119                 let chan_2_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 2, 0, 200_000, 0);
1120                 let chan_3_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 3, 0, 300_000, 0);
1121                 let _chan_4_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 4, 0, 400_000, 0);
1122
1123                 // When we have channels that have sufficient inbound for the payment, test that we sort
1124                 // by lowest inbound capacity.
1125                 let mut scid_aliases = HashSet::new();
1126                 scid_aliases.insert(chan_1_0.0.short_channel_id_alias.unwrap());
1127                 scid_aliases.insert(chan_2_0.0.short_channel_id_alias.unwrap());
1128                 scid_aliases.insert(chan_3_0.0.short_channel_id_alias.unwrap());
1129
1130                 match_invoice_routes(Some(50_000_000), &nodes[0], scid_aliases.clone());
1131         }
1132
1133         #[test]
1134         fn test_forwarding_info_not_assigned_channel_excluded_from_hints() {
1135                 let chanmon_cfgs = create_chanmon_cfgs(3);
1136                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1137                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1138                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1139                 let chan_1_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 100000, 10001);
1140
1141                 // Create an unannonced channel between `nodes[2]` and `nodes[0]`, for which the
1142                 // `msgs::ChannelUpdate` is never handled for the node(s). As the `msgs::ChannelUpdate`
1143                 // is never handled, the `channel.counterparty.forwarding_info` is never assigned.
1144                 let mut private_chan_cfg = UserConfig::default();
1145                 private_chan_cfg.channel_handshake_config.announced_channel = false;
1146                 let temporary_channel_id = nodes[2].node.create_channel(nodes[0].node.get_our_node_id(), 1_000_000, 500_000_000, 42, Some(private_chan_cfg)).unwrap();
1147                 let open_channel = get_event_msg!(nodes[2], MessageSendEvent::SendOpenChannel, nodes[0].node.get_our_node_id());
1148                 nodes[0].node.handle_open_channel(&nodes[2].node.get_our_node_id(), &open_channel);
1149                 let accept_channel = get_event_msg!(nodes[0], MessageSendEvent::SendAcceptChannel, nodes[2].node.get_our_node_id());
1150                 nodes[2].node.handle_accept_channel(&nodes[0].node.get_our_node_id(), &accept_channel);
1151
1152                 let tx = sign_funding_transaction(&nodes[2], &nodes[0], 1_000_000, temporary_channel_id);
1153
1154                 let conf_height = core::cmp::max(nodes[2].best_block_info().1 + 1, nodes[0].best_block_info().1 + 1);
1155                 confirm_transaction_at(&nodes[2], &tx, conf_height);
1156                 connect_blocks(&nodes[2], CHAN_CONFIRM_DEPTH - 1);
1157                 confirm_transaction_at(&nodes[0], &tx, conf_height);
1158                 connect_blocks(&nodes[0], CHAN_CONFIRM_DEPTH - 1);
1159                 let as_channel_ready = get_event_msg!(nodes[2], MessageSendEvent::SendChannelReady, nodes[0].node.get_our_node_id());
1160                 nodes[2].node.handle_channel_ready(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendChannelReady, nodes[2].node.get_our_node_id()));
1161                 get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
1162                 nodes[0].node.handle_channel_ready(&nodes[2].node.get_our_node_id(), &as_channel_ready);
1163                 get_event_msg!(nodes[0], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
1164                 expect_channel_ready_event(&nodes[0], &nodes[2].node.get_our_node_id());
1165                 expect_channel_ready_event(&nodes[2], &nodes[0].node.get_our_node_id());
1166
1167                 // As `msgs::ChannelUpdate` was never handled for the participating node(s) of the second
1168                 // channel, the channel will never be assigned any `counterparty.forwarding_info`.
1169                 // Therefore only `chan_1_0` should be included in the hints.
1170                 let mut scid_aliases = HashSet::new();
1171                 scid_aliases.insert(chan_1_0.0.short_channel_id_alias.unwrap());
1172                 match_invoice_routes(Some(5000), &nodes[0], scid_aliases);
1173         }
1174
1175         #[test]
1176         fn test_no_hints_if_a_mix_between_public_and_private_channel_exists() {
1177                 let chanmon_cfgs = create_chanmon_cfgs(3);
1178                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1179                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1180                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1181                 let _chan_1_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 100000, 10001);
1182
1183                 let chan_2_0 = create_announced_chan_between_nodes_with_value(&nodes, 2, 0, 100000, 10001);
1184                 nodes[2].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_2_0.1);
1185                 nodes[0].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &chan_2_0.0);
1186
1187                 // Ensure that the invoice doesn't include any route hints for any of `nodes[0]` channels,
1188                 // even though all channels between `nodes[1]` and `nodes[0]` are private, as there is a
1189                 // public channel between `nodes[2]` and `nodes[0]`
1190                 match_invoice_routes(Some(5000), &nodes[0], HashSet::new());
1191         }
1192
1193         #[test]
1194         fn test_only_public_channels_includes_no_channels_in_hints() {
1195                 let chanmon_cfgs = create_chanmon_cfgs(3);
1196                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1197                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1198                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1199                 let chan_1_0 = create_announced_chan_between_nodes_with_value(&nodes, 1, 0, 100000, 10001);
1200                 nodes[0].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &chan_1_0.0);
1201                 nodes[1].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_1_0.1);
1202
1203                 let chan_2_0 = create_announced_chan_between_nodes_with_value(&nodes, 2, 0, 100000, 10001);
1204                 nodes[2].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_2_0.1);
1205                 nodes[0].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &chan_2_0.0);
1206
1207                 // As all of `nodes[0]` channels are public, no channels should be included in the hints
1208                 match_invoice_routes(Some(5000), &nodes[0], HashSet::new());
1209         }
1210
1211         #[test]
1212         fn test_channels_with_lower_inbound_capacity_than_invoice_amt_hints_filtering() {
1213                 let chanmon_cfgs = create_chanmon_cfgs(3);
1214                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1215                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1216                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1217                 let chan_1_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 100_000, 0);
1218                 let chan_2_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 2, 0, 1_000_000, 0);
1219
1220                 // As the invoice amt is 1 msat above chan_1_0's inbound capacity, it shouldn't be included
1221                 let mut scid_aliases_99_000_001_msat = HashSet::new();
1222                 scid_aliases_99_000_001_msat.insert(chan_2_0.0.short_channel_id_alias.unwrap());
1223
1224                 match_invoice_routes(Some(99_000_001), &nodes[0], scid_aliases_99_000_001_msat);
1225
1226                 // As the invoice amt is exactly at chan_1_0's inbound capacity, it should be included
1227                 let mut scid_aliases_99_000_000_msat = HashSet::new();
1228                 scid_aliases_99_000_000_msat.insert(chan_1_0.0.short_channel_id_alias.unwrap());
1229                 scid_aliases_99_000_000_msat.insert(chan_2_0.0.short_channel_id_alias.unwrap());
1230
1231                 match_invoice_routes(Some(99_000_000), &nodes[0], scid_aliases_99_000_000_msat);
1232
1233                 // As the invoice amt is above all channels' inbound capacity, they will still be included
1234                 let mut scid_aliases_2_000_000_000_msat = HashSet::new();
1235                 scid_aliases_2_000_000_000_msat.insert(chan_1_0.0.short_channel_id_alias.unwrap());
1236                 scid_aliases_2_000_000_000_msat.insert(chan_2_0.0.short_channel_id_alias.unwrap());
1237
1238                 match_invoice_routes(Some(2_000_000_000), &nodes[0], scid_aliases_2_000_000_000_msat);
1239
1240                 // An invoice with no specified amount should include all channels in the route hints.
1241                 let mut scid_aliases_no_specified_amount = HashSet::new();
1242                 scid_aliases_no_specified_amount.insert(chan_1_0.0.short_channel_id_alias.unwrap());
1243                 scid_aliases_no_specified_amount.insert(chan_2_0.0.short_channel_id_alias.unwrap());
1244
1245                 match_invoice_routes(None, &nodes[0], scid_aliases_no_specified_amount);
1246         }
1247
1248         fn match_invoice_routes<'a, 'b: 'a, 'c: 'b>(
1249                 invoice_amt: Option<u64>,
1250                 invoice_node: &Node<'a, 'b, 'c>,
1251                 mut chan_ids_to_match: HashSet<u64>
1252         ) {
1253                 let invoice = create_invoice_from_channelmanager_and_duration_since_epoch(
1254                         invoice_node.node, invoice_node.keys_manager, invoice_node.logger,
1255                         Currency::BitcoinTestnet, invoice_amt, "test".to_string(), Duration::from_secs(1234567),
1256                         3600, None).unwrap();
1257                 let hints = invoice.private_routes();
1258
1259                 for hint in hints {
1260                         let hint_short_chan_id = (hint.0).0[0].short_channel_id;
1261                         assert!(chan_ids_to_match.remove(&hint_short_chan_id));
1262                 }
1263                 assert!(chan_ids_to_match.is_empty(), "Unmatched short channel ids: {:?}", chan_ids_to_match);
1264         }
1265
1266         #[test]
1267         #[cfg(feature = "std")]
1268         fn test_multi_node_receive() {
1269                 do_test_multi_node_receive(true);
1270                 do_test_multi_node_receive(false);
1271         }
1272
1273         #[cfg(feature = "std")]
1274         fn do_test_multi_node_receive(user_generated_pmt_hash: bool) {
1275                 let mut chanmon_cfgs = create_chanmon_cfgs(3);
1276                 let seed_1 = [42u8; 32];
1277                 let seed_2 = [43u8; 32];
1278                 let cross_node_seed = [44u8; 32];
1279                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1280                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1281                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1282                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1283                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1284                 let chan_0_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001);
1285                 nodes[0].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &chan_0_1.1);
1286                 nodes[1].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_0_1.0);
1287                 let chan_0_2 = create_announced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1288                 nodes[0].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &chan_0_2.1);
1289                 nodes[2].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_0_2.0);
1290
1291                 let payment_amt = 10_000;
1292                 let route_hints = vec![
1293                         nodes[1].node.get_phantom_route_hints(),
1294                         nodes[2].node.get_phantom_route_hints(),
1295                 ];
1296
1297                 let user_payment_preimage = PaymentPreimage([1; 32]);
1298                 let payment_hash = if user_generated_pmt_hash {
1299                         Some(PaymentHash(Sha256::hash(&user_payment_preimage.0[..]).into_inner()))
1300                 } else {
1301                         None
1302                 };
1303                 let genesis_timestamp = bitcoin::blockdata::constants::genesis_block(bitcoin::Network::Testnet).header.time as u64;
1304                 let non_default_invoice_expiry_secs = 4200;
1305
1306                 let invoice =
1307                         crate::utils::create_phantom_invoice::<&test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestLogger>(
1308                                 Some(payment_amt), payment_hash, "test".to_string(), non_default_invoice_expiry_secs,
1309                                 route_hints, nodes[1].keys_manager, nodes[1].keys_manager, nodes[1].logger,
1310                                 Currency::BitcoinTestnet, None, Duration::from_secs(genesis_timestamp)
1311                         ).unwrap();
1312                 let (payment_hash, payment_secret) = (PaymentHash(invoice.payment_hash().into_inner()), *invoice.payment_secret());
1313                 let payment_preimage = if user_generated_pmt_hash {
1314                         user_payment_preimage
1315                 } else {
1316                         nodes[1].node.get_payment_preimage(payment_hash, payment_secret).unwrap()
1317                 };
1318
1319                 assert_eq!(invoice.min_final_cltv_expiry_delta(), MIN_FINAL_CLTV_EXPIRY_DELTA as u64);
1320                 assert_eq!(invoice.description(), InvoiceDescription::Direct(&Description("test".to_string())));
1321                 assert_eq!(invoice.route_hints().len(), 2);
1322                 assert_eq!(invoice.expiry_time(), Duration::from_secs(non_default_invoice_expiry_secs.into()));
1323                 assert!(!invoice.features().unwrap().supports_basic_mpp());
1324
1325                 let payment_params = PaymentParameters::from_node_id(invoice.recover_payee_pub_key(),
1326                                 invoice.min_final_cltv_expiry_delta() as u32)
1327                         .with_bolt11_features(invoice.features().unwrap().clone()).unwrap()
1328                         .with_route_hints(invoice.route_hints()).unwrap();
1329                 let params = RouteParameters {
1330                         payment_params,
1331                         final_value_msat: invoice.amount_milli_satoshis().unwrap(),
1332                 };
1333                 let (payment_event, fwd_idx) = {
1334                         let mut payment_hash = PaymentHash([0; 32]);
1335                         payment_hash.0.copy_from_slice(&invoice.payment_hash().as_ref()[0..32]);
1336                         nodes[0].node.send_payment(payment_hash,
1337                                 RecipientOnionFields::secret_only(*invoice.payment_secret()),
1338                                 PaymentId(payment_hash.0), params, Retry::Attempts(0)).unwrap();
1339                         let mut added_monitors = nodes[0].chain_monitor.added_monitors.lock().unwrap();
1340                         assert_eq!(added_monitors.len(), 1);
1341                         added_monitors.clear();
1342
1343                         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1344                         assert_eq!(events.len(), 1);
1345                         let fwd_idx = match events[0] {
1346                                 MessageSendEvent::UpdateHTLCs { node_id, .. } => {
1347                                         if node_id == nodes[1].node.get_our_node_id() {
1348                                                 1
1349                                         } else { 2 }
1350                                 },
1351                                 _ => panic!("Unexpected event")
1352                         };
1353                         (SendEvent::from_event(events.remove(0)), fwd_idx)
1354                 };
1355                 nodes[fwd_idx].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
1356                 commitment_signed_dance!(nodes[fwd_idx], nodes[0], &payment_event.commitment_msg, false, true);
1357
1358                 // Note that we have to "forward pending HTLCs" twice before we see the PaymentClaimable as
1359                 // this "emulates" the payment taking two hops, providing some privacy to make phantom node
1360                 // payments "look real" by taking more time.
1361                 let other_events = RefCell::new(Vec::new());
1362                 let forward_event_handler = |event: Event| {
1363                         if let Event::PendingHTLCsForwardable { .. } = event {
1364                                 nodes[fwd_idx].node.process_pending_htlc_forwards();
1365                         } else {
1366                                 other_events.borrow_mut().push(event);
1367                         }
1368                 };
1369                 nodes[fwd_idx].node.process_pending_events(&forward_event_handler);
1370                 nodes[fwd_idx].node.process_pending_events(&forward_event_handler);
1371
1372                 let payment_preimage_opt = if user_generated_pmt_hash { None } else { Some(payment_preimage) };
1373                 assert_eq!(other_events.borrow().len(), 1);
1374                 check_payment_claimable(&other_events.borrow()[0], payment_hash, payment_secret, payment_amt, payment_preimage_opt, invoice.recover_payee_pub_key());
1375                 do_claim_payment_along_route(&nodes[0], &[&vec!(&nodes[fwd_idx])[..]], false, payment_preimage);
1376                 let events = nodes[0].node.get_and_clear_pending_events();
1377                 assert_eq!(events.len(), 2);
1378                 match events[0] {
1379                         Event::PaymentSent { payment_preimage: ref ev_preimage, payment_hash: ref ev_hash, ref fee_paid_msat, .. } => {
1380                                 assert_eq!(payment_preimage, *ev_preimage);
1381                                 assert_eq!(payment_hash, *ev_hash);
1382                                 assert_eq!(fee_paid_msat, &Some(0));
1383                         },
1384                         _ => panic!("Unexpected event")
1385                 }
1386                 match events[1] {
1387                         Event::PaymentPathSuccessful { payment_hash: hash, .. } => {
1388                                 assert_eq!(hash, Some(payment_hash));
1389                         },
1390                         _ => panic!("Unexpected event")
1391                 }
1392         }
1393
1394         #[test]
1395         #[cfg(feature = "std")]
1396         fn test_multi_node_hints_has_htlc_min_max_values() {
1397                 let mut chanmon_cfgs = create_chanmon_cfgs(3);
1398                 let seed_1 = [42u8; 32];
1399                 let seed_2 = [43u8; 32];
1400                 let cross_node_seed = [44u8; 32];
1401                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1402                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1403                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1404                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1405                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1406
1407                 create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001);
1408                 create_unannounced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1409
1410                 let payment_amt = 20_000;
1411                 let (payment_hash, _payment_secret) = nodes[1].node.create_inbound_payment(Some(payment_amt), 3600, None).unwrap();
1412                 let route_hints = vec![
1413                         nodes[1].node.get_phantom_route_hints(),
1414                         nodes[2].node.get_phantom_route_hints(),
1415                 ];
1416
1417                 let invoice = crate::utils::create_phantom_invoice::<&test_utils::TestKeysInterface,
1418                         &test_utils::TestKeysInterface, &test_utils::TestLogger>(Some(payment_amt), Some(payment_hash),
1419                                 "test".to_string(), 3600, route_hints, nodes[1].keys_manager, nodes[1].keys_manager,
1420                                 nodes[1].logger, Currency::BitcoinTestnet, None, Duration::from_secs(1234567)).unwrap();
1421
1422                 let chan_0_1 = &nodes[1].node.list_usable_channels()[0];
1423                 assert_eq!(invoice.route_hints()[0].0[0].htlc_minimum_msat, chan_0_1.inbound_htlc_minimum_msat);
1424                 assert_eq!(invoice.route_hints()[0].0[0].htlc_maximum_msat, chan_0_1.inbound_htlc_maximum_msat);
1425
1426                 let chan_0_2 = &nodes[2].node.list_usable_channels()[0];
1427                 assert_eq!(invoice.route_hints()[1].0[0].htlc_minimum_msat, chan_0_2.inbound_htlc_minimum_msat);
1428                 assert_eq!(invoice.route_hints()[1].0[0].htlc_maximum_msat, chan_0_2.inbound_htlc_maximum_msat);
1429         }
1430
1431         #[test]
1432         #[cfg(feature = "std")]
1433         fn create_phantom_invoice_with_description_hash() {
1434                 let chanmon_cfgs = create_chanmon_cfgs(3);
1435                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1436                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1437                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1438
1439                 let payment_amt = 20_000;
1440                 let route_hints = vec![
1441                         nodes[1].node.get_phantom_route_hints(),
1442                         nodes[2].node.get_phantom_route_hints(),
1443                 ];
1444
1445                 let description_hash = crate::Sha256(Hash::hash("Description hash phantom invoice".as_bytes()));
1446                 let non_default_invoice_expiry_secs = 4200;
1447                 let invoice = crate::utils::create_phantom_invoice_with_description_hash::<
1448                         &test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestLogger,
1449                 >(
1450                         Some(payment_amt), None, non_default_invoice_expiry_secs, description_hash,
1451                         route_hints, nodes[1].keys_manager, nodes[1].keys_manager, nodes[1].logger,
1452                         Currency::BitcoinTestnet, None, Duration::from_secs(1234567),
1453                 )
1454                 .unwrap();
1455                 assert_eq!(invoice.amount_pico_btc(), Some(200_000));
1456                 assert_eq!(invoice.min_final_cltv_expiry_delta(), MIN_FINAL_CLTV_EXPIRY_DELTA as u64);
1457                 assert_eq!(invoice.expiry_time(), Duration::from_secs(non_default_invoice_expiry_secs.into()));
1458                 assert_eq!(invoice.description(), InvoiceDescription::Hash(&crate::Sha256(Sha256::hash("Description hash phantom invoice".as_bytes()))));
1459         }
1460
1461         #[test]
1462         #[cfg(feature = "std")]
1463         fn create_phantom_invoice_with_custom_payment_hash_and_custom_min_final_cltv_delta() {
1464                 let chanmon_cfgs = create_chanmon_cfgs(3);
1465                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1466                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1467                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1468
1469                 let payment_amt = 20_000;
1470                 let route_hints = vec![
1471                         nodes[1].node.get_phantom_route_hints(),
1472                         nodes[2].node.get_phantom_route_hints(),
1473                 ];
1474                 let user_payment_preimage = PaymentPreimage([1; 32]);
1475                 let payment_hash = Some(PaymentHash(Sha256::hash(&user_payment_preimage.0[..]).into_inner()));
1476                 let non_default_invoice_expiry_secs = 4200;
1477                 let min_final_cltv_expiry_delta = Some(100);
1478                 let duration_since_epoch = Duration::from_secs(1234567);
1479                 let invoice = crate::utils::create_phantom_invoice::<&test_utils::TestKeysInterface,
1480                         &test_utils::TestKeysInterface, &test_utils::TestLogger>(Some(payment_amt), payment_hash,
1481                                 "".to_string(), non_default_invoice_expiry_secs, route_hints, nodes[1].keys_manager, nodes[1].keys_manager,
1482                                 nodes[1].logger, Currency::BitcoinTestnet, min_final_cltv_expiry_delta, duration_since_epoch).unwrap();
1483                 assert_eq!(invoice.amount_pico_btc(), Some(200_000));
1484                 assert_eq!(invoice.min_final_cltv_expiry_delta(), (min_final_cltv_expiry_delta.unwrap() + 3) as u64);
1485                 assert_eq!(invoice.expiry_time(), Duration::from_secs(non_default_invoice_expiry_secs.into()));
1486         }
1487
1488         #[test]
1489         #[cfg(feature = "std")]
1490         fn test_multi_node_hints_includes_single_channels_to_participating_nodes() {
1491                 let mut chanmon_cfgs = create_chanmon_cfgs(3);
1492                 let seed_1 = [42u8; 32];
1493                 let seed_2 = [43u8; 32];
1494                 let cross_node_seed = [44u8; 32];
1495                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1496                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1497                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1498                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1499                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1500
1501                 let chan_0_1 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001);
1502                 let chan_0_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1503
1504                 let mut scid_aliases = HashSet::new();
1505                 scid_aliases.insert(chan_0_1.0.short_channel_id_alias.unwrap());
1506                 scid_aliases.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1507
1508                 match_multi_node_invoice_routes(
1509                         Some(10_000),
1510                         &nodes[1],
1511                         vec![&nodes[1], &nodes[2],],
1512                         scid_aliases,
1513                         false
1514                 );
1515         }
1516
1517         #[test]
1518         #[cfg(feature = "std")]
1519         fn test_multi_node_hints_includes_one_channel_of_each_counterparty_nodes_per_participating_node() {
1520                 let mut chanmon_cfgs = create_chanmon_cfgs(4);
1521                 let seed_1 = [42u8; 32];
1522                 let seed_2 = [43u8; 32];
1523                 let cross_node_seed = [44u8; 32];
1524                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1525                 chanmon_cfgs[3].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1526                 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
1527                 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
1528                 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
1529
1530                 let chan_0_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1531                 let chan_0_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 3, 1000000, 10001);
1532                 let chan_1_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 3, 3_000_000, 10005);
1533
1534                 let mut scid_aliases = HashSet::new();
1535                 scid_aliases.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1536                 scid_aliases.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1537                 scid_aliases.insert(chan_1_3.0.short_channel_id_alias.unwrap());
1538
1539                 match_multi_node_invoice_routes(
1540                         Some(10_000),
1541                         &nodes[2],
1542                         vec![&nodes[2], &nodes[3],],
1543                         scid_aliases,
1544                         false
1545                 );
1546         }
1547
1548         #[test]
1549         #[cfg(feature = "std")]
1550         fn test_multi_node_forwarding_info_not_assigned_channel_excluded_from_hints() {
1551                 let mut chanmon_cfgs = create_chanmon_cfgs(4);
1552                 let seed_1 = [42u8; 32];
1553                 let seed_2 = [43u8; 32];
1554                 let cross_node_seed = [44u8; 32];
1555                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1556                 chanmon_cfgs[3].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1557                 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
1558                 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
1559                 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
1560
1561                 let chan_0_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1562                 let chan_0_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 3, 1000000, 10001);
1563
1564                 // Create an unannonced channel between `nodes[1]` and `nodes[3]`, for which the
1565                 // `msgs::ChannelUpdate` is never handled for the node(s). As the `msgs::ChannelUpdate`
1566                 // is never handled, the `channel.counterparty.forwarding_info` is never assigned.
1567                 let mut private_chan_cfg = UserConfig::default();
1568                 private_chan_cfg.channel_handshake_config.announced_channel = false;
1569                 let temporary_channel_id = nodes[1].node.create_channel(nodes[3].node.get_our_node_id(), 1_000_000, 500_000_000, 42, Some(private_chan_cfg)).unwrap();
1570                 let open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[3].node.get_our_node_id());
1571                 nodes[3].node.handle_open_channel(&nodes[1].node.get_our_node_id(), &open_channel);
1572                 let accept_channel = get_event_msg!(nodes[3], MessageSendEvent::SendAcceptChannel, nodes[1].node.get_our_node_id());
1573                 nodes[1].node.handle_accept_channel(&nodes[3].node.get_our_node_id(), &accept_channel);
1574
1575                 let tx = sign_funding_transaction(&nodes[1], &nodes[3], 1_000_000, temporary_channel_id);
1576
1577                 let conf_height = core::cmp::max(nodes[1].best_block_info().1 + 1, nodes[3].best_block_info().1 + 1);
1578                 confirm_transaction_at(&nodes[1], &tx, conf_height);
1579                 connect_blocks(&nodes[1], CHAN_CONFIRM_DEPTH - 1);
1580                 confirm_transaction_at(&nodes[3], &tx, conf_height);
1581                 connect_blocks(&nodes[3], CHAN_CONFIRM_DEPTH - 1);
1582                 let as_channel_ready = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReady, nodes[3].node.get_our_node_id());
1583                 nodes[1].node.handle_channel_ready(&nodes[3].node.get_our_node_id(), &get_event_msg!(nodes[3], MessageSendEvent::SendChannelReady, nodes[1].node.get_our_node_id()));
1584                 get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[3].node.get_our_node_id());
1585                 nodes[3].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &as_channel_ready);
1586                 get_event_msg!(nodes[3], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
1587                 expect_channel_ready_event(&nodes[1], &nodes[3].node.get_our_node_id());
1588                 expect_channel_ready_event(&nodes[3], &nodes[1].node.get_our_node_id());
1589
1590                 // As `msgs::ChannelUpdate` was never handled for the participating node(s) of the third
1591                 // channel, the channel will never be assigned any `counterparty.forwarding_info`.
1592                 // Therefore only `chan_0_3` should be included in the hints for `nodes[3]`.
1593                 let mut scid_aliases = HashSet::new();
1594                 scid_aliases.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1595                 scid_aliases.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1596
1597                 match_multi_node_invoice_routes(
1598                         Some(10_000),
1599                         &nodes[2],
1600                         vec![&nodes[2], &nodes[3],],
1601                         scid_aliases,
1602                         false
1603                 );
1604         }
1605
1606         #[test]
1607         #[cfg(feature = "std")]
1608         fn test_multi_node_with_only_public_channels_hints_includes_only_phantom_route() {
1609                 let mut chanmon_cfgs = create_chanmon_cfgs(3);
1610                 let seed_1 = [42u8; 32];
1611                 let seed_2 = [43u8; 32];
1612                 let cross_node_seed = [44u8; 32];
1613                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1614                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1615                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1616                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1617                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1618
1619                 let chan_0_1 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001);
1620
1621                 let chan_2_0 = create_announced_chan_between_nodes_with_value(&nodes, 2, 0, 100000, 10001);
1622                 nodes[2].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_2_0.1);
1623                 nodes[0].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &chan_2_0.0);
1624
1625                 // Hints should include `chan_0_1` from as `nodes[1]` only have private channels, but not
1626                 // `chan_0_2` as `nodes[2]` only has public channels.
1627                 let mut scid_aliases = HashSet::new();
1628                 scid_aliases.insert(chan_0_1.0.short_channel_id_alias.unwrap());
1629
1630                 match_multi_node_invoice_routes(
1631                         Some(10_000),
1632                         &nodes[1],
1633                         vec![&nodes[1], &nodes[2],],
1634                         scid_aliases,
1635                         true
1636                 );
1637         }
1638
1639         #[test]
1640         #[cfg(feature = "std")]
1641         fn test_multi_node_with_mixed_public_and_private_channel_hints_includes_only_phantom_route() {
1642                 let mut chanmon_cfgs = create_chanmon_cfgs(4);
1643                 let seed_1 = [42u8; 32];
1644                 let seed_2 = [43u8; 32];
1645                 let cross_node_seed = [44u8; 32];
1646                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1647                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1648                 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
1649                 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
1650                 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
1651
1652                 let chan_0_2 = create_announced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1653                 nodes[0].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &chan_0_2.1);
1654                 nodes[2].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_0_2.0);
1655                 let _chan_1_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 100000, 10001);
1656
1657                 let chan_0_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 3, 100000, 10001);
1658
1659                 // Hints should include `chan_0_3` from as `nodes[3]` only have private channels, and no
1660                 // channels for `nodes[2]` as it contains a mix of public and private channels.
1661                 let mut scid_aliases = HashSet::new();
1662                 scid_aliases.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1663
1664                 match_multi_node_invoice_routes(
1665                         Some(10_000),
1666                         &nodes[2],
1667                         vec![&nodes[2], &nodes[3],],
1668                         scid_aliases,
1669                         true
1670                 );
1671         }
1672
1673         #[test]
1674         #[cfg(feature = "std")]
1675         fn test_multi_node_hints_has_only_lowest_inbound_channel_above_minimum() {
1676                 let mut chanmon_cfgs = create_chanmon_cfgs(3);
1677                 let seed_1 = [42u8; 32];
1678                 let seed_2 = [43u8; 32];
1679                 let cross_node_seed = [44u8; 32];
1680                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1681                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1682                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1683                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1684                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1685
1686                 let _chan_0_1_below_amt = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 100_000, 0);
1687                 let _chan_0_1_above_amt_high_inbound = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 500_000, 0);
1688                 let chan_0_1_above_amt_low_inbound = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 180_000, 0);
1689                 let chan_0_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1690
1691                 let mut scid_aliases = HashSet::new();
1692                 scid_aliases.insert(chan_0_1_above_amt_low_inbound.0.short_channel_id_alias.unwrap());
1693                 scid_aliases.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1694
1695                 match_multi_node_invoice_routes(
1696                         Some(100_000_000),
1697                         &nodes[1],
1698                         vec![&nodes[1], &nodes[2],],
1699                         scid_aliases,
1700                         false
1701                 );
1702         }
1703
1704         #[test]
1705         #[cfg(feature = "std")]
1706         fn test_multi_node_channels_inbound_capacity_lower_than_invoice_amt_filtering() {
1707                 let mut chanmon_cfgs = create_chanmon_cfgs(4);
1708                 let seed_1 = [42u8; 32];
1709                 let seed_2 = [43u8; 32];
1710                 let cross_node_seed = [44u8; 32];
1711                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1712                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1713                 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
1714                 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
1715                 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
1716
1717                 let chan_0_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 2, 1_000_000, 0);
1718                 let chan_0_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 3, 100_000, 0);
1719                 let chan_1_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 3, 200_000, 0);
1720
1721                 // Since the invoice 1 msat above chan_0_3's inbound capacity, it should be filtered out.
1722                 let mut scid_aliases_99_000_001_msat = HashSet::new();
1723                 scid_aliases_99_000_001_msat.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1724                 scid_aliases_99_000_001_msat.insert(chan_1_3.0.short_channel_id_alias.unwrap());
1725
1726                 match_multi_node_invoice_routes(
1727                         Some(99_000_001),
1728                         &nodes[2],
1729                         vec![&nodes[2], &nodes[3],],
1730                         scid_aliases_99_000_001_msat,
1731                         false
1732                 );
1733
1734                 // Since the invoice is exactly at chan_0_3's inbound capacity, it should be included.
1735                 let mut scid_aliases_99_000_000_msat = HashSet::new();
1736                 scid_aliases_99_000_000_msat.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1737                 scid_aliases_99_000_000_msat.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1738                 scid_aliases_99_000_000_msat.insert(chan_1_3.0.short_channel_id_alias.unwrap());
1739
1740                 match_multi_node_invoice_routes(
1741                         Some(99_000_000),
1742                         &nodes[2],
1743                         vec![&nodes[2], &nodes[3],],
1744                         scid_aliases_99_000_000_msat,
1745                         false
1746                 );
1747
1748                 // Since the invoice is above all of `nodes[2]` channels' inbound capacity, all of
1749                 // `nodes[2]` them should be included.
1750                 let mut scid_aliases_300_000_000_msat = HashSet::new();
1751                 scid_aliases_300_000_000_msat.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1752                 scid_aliases_300_000_000_msat.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1753                 scid_aliases_300_000_000_msat.insert(chan_1_3.0.short_channel_id_alias.unwrap());
1754
1755                 match_multi_node_invoice_routes(
1756                         Some(300_000_000),
1757                         &nodes[2],
1758                         vec![&nodes[2], &nodes[3],],
1759                         scid_aliases_300_000_000_msat,
1760                         false
1761                 );
1762
1763                 // Since the no specified amount, all channels should included.
1764                 let mut scid_aliases_no_specified_amount = HashSet::new();
1765                 scid_aliases_no_specified_amount.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1766                 scid_aliases_no_specified_amount.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1767                 scid_aliases_no_specified_amount.insert(chan_1_3.0.short_channel_id_alias.unwrap());
1768
1769                 match_multi_node_invoice_routes(
1770                         None,
1771                         &nodes[2],
1772                         vec![&nodes[2], &nodes[3],],
1773                         scid_aliases_no_specified_amount,
1774                         false
1775                 );
1776         }
1777
1778         #[test]
1779         fn test_multi_node_hints_limited_to_3() {
1780                 let mut chanmon_cfgs = create_chanmon_cfgs(6);
1781                 let seed_1 = [42 as u8; 32];
1782                 let seed_2 = [43 as u8; 32];
1783                 let seed_3 = [44 as u8; 32];
1784                 let seed_4 = [45 as u8; 32];
1785                 let cross_node_seed = [44 as u8; 32];
1786                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1787                 chanmon_cfgs[3].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1788                 chanmon_cfgs[4].keys_manager.backing = PhantomKeysManager::new(&seed_3, 43, 44, &cross_node_seed);
1789                 chanmon_cfgs[5].keys_manager.backing = PhantomKeysManager::new(&seed_4, 43, 44, &cross_node_seed);
1790                 let node_cfgs = create_node_cfgs(6, &chanmon_cfgs);
1791                 let node_chanmgrs = create_node_chanmgrs(6, &node_cfgs, &[None, None, None, None, None, None]);
1792                 let nodes = create_network(6, &node_cfgs, &node_chanmgrs);
1793
1794                 // Setup each phantom node with two channels from distinct peers.
1795                 let chan_0_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 2, 10_000, 0);
1796                 let chan_1_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 20_000, 0);
1797                 let chan_0_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 3, 20_000, 0);
1798                 let _chan_1_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 3, 10_000, 0);
1799                 let chan_0_4 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 4, 20_000, 0);
1800                 let _chan_1_4 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 4, 10_000, 0);
1801                 let _chan_0_5 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 5, 20_000, 0);
1802                 let _chan_1_5 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 5, 10_000, 0);
1803
1804                 // Set invoice amount > all channels inbound so that every one is eligible for inclusion
1805                 // and hints will be sorted by largest inbound capacity.
1806                 let invoice_amt = Some(100_000_000);
1807
1808                 // With 4 phantom nodes, assert that we include 1 hint per node, up to 3 nodes.
1809                 let mut scid_aliases = HashSet::new();
1810                 scid_aliases.insert(chan_1_2.0.short_channel_id_alias.unwrap());
1811                 scid_aliases.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1812                 scid_aliases.insert(chan_0_4.0.short_channel_id_alias.unwrap());
1813
1814                 match_multi_node_invoice_routes(
1815                         invoice_amt,
1816                         &nodes[3],
1817                         vec![&nodes[2], &nodes[3], &nodes[4], &nodes[5]],
1818                         scid_aliases,
1819                         false,
1820                 );
1821
1822                 // With 2 phantom nodes, assert that we include no more than 3 hints.
1823                 let mut scid_aliases = HashSet::new();
1824                 scid_aliases.insert(chan_1_2.0.short_channel_id_alias.unwrap());
1825                 scid_aliases.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1826                 scid_aliases.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1827
1828                 match_multi_node_invoice_routes(
1829                         invoice_amt,
1830                         &nodes[3],
1831                         vec![&nodes[2], &nodes[3]],
1832                         scid_aliases,
1833                         false,
1834                 );
1835         }
1836
1837         #[test]
1838         fn test_multi_node_hints_at_least_3() {
1839                 let mut chanmon_cfgs = create_chanmon_cfgs(5);
1840                 let seed_1 = [42 as u8; 32];
1841                 let seed_2 = [43 as u8; 32];
1842                 let cross_node_seed = [44 as u8; 32];
1843                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1844                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1845                 let node_cfgs = create_node_cfgs(5, &chanmon_cfgs);
1846                 let node_chanmgrs = create_node_chanmgrs(5, &node_cfgs, &[None, None, None, None, None]);
1847                 let nodes = create_network(5, &node_cfgs, &node_chanmgrs);
1848
1849                 let _chan_0_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 3, 10_000, 0);
1850                 let chan_1_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 3, 20_000, 0);
1851                 let chan_2_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 2, 3, 30_000, 0);
1852                 let chan_0_4 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 4, 10_000, 0);
1853
1854                 // Since the invoice amount is above all channels inbound, all four are eligible. Test that
1855                 // we still include 3 hints from 2 distinct nodes sorted by inbound.
1856                 let mut scid_aliases = HashSet::new();
1857                 scid_aliases.insert(chan_1_3.0.short_channel_id_alias.unwrap());
1858                 scid_aliases.insert(chan_2_3.0.short_channel_id_alias.unwrap());
1859                 scid_aliases.insert(chan_0_4.0.short_channel_id_alias.unwrap());
1860
1861                 match_multi_node_invoice_routes(
1862                         Some(100_000_000),
1863                         &nodes[3],
1864                         vec![&nodes[3], &nodes[4],],
1865                         scid_aliases,
1866                         false,
1867                 );
1868         }
1869
1870         fn match_multi_node_invoice_routes<'a, 'b: 'a, 'c: 'b>(
1871                 invoice_amt: Option<u64>,
1872                 invoice_node: &Node<'a, 'b, 'c>,
1873                 network_multi_nodes: Vec<&Node<'a, 'b, 'c>>,
1874                 mut chan_ids_to_match: HashSet<u64>,
1875                 nodes_contains_public_channels: bool
1876         ){
1877                 let phantom_route_hints = network_multi_nodes.iter()
1878                         .map(|node| node.node.get_phantom_route_hints())
1879                         .collect::<Vec<PhantomRouteHints>>();
1880                 let phantom_scids = phantom_route_hints.iter()
1881                         .map(|route_hint| route_hint.phantom_scid)
1882                         .collect::<HashSet<u64>>();
1883
1884                 let invoice = crate::utils::create_phantom_invoice::<&test_utils::TestKeysInterface,
1885                         &test_utils::TestKeysInterface, &test_utils::TestLogger>(invoice_amt, None, "test".to_string(),
1886                                 3600, phantom_route_hints, invoice_node.keys_manager, invoice_node.keys_manager,
1887                                 invoice_node.logger, Currency::BitcoinTestnet, None, Duration::from_secs(1234567)).unwrap();
1888
1889                 let invoice_hints = invoice.private_routes();
1890
1891                 for hint in invoice_hints {
1892                         let hints = &(hint.0).0;
1893                         match hints.len() {
1894                                 1 => {
1895                                         assert!(nodes_contains_public_channels);
1896                                         let phantom_scid = hints[0].short_channel_id;
1897                                         assert!(phantom_scids.contains(&phantom_scid));
1898                                 },
1899                                 2 => {
1900                                         let hint_short_chan_id = hints[0].short_channel_id;
1901                                         assert!(chan_ids_to_match.remove(&hint_short_chan_id));
1902                                         let phantom_scid = hints[1].short_channel_id;
1903                                         assert!(phantom_scids.contains(&phantom_scid));
1904                                 },
1905                                 _ => panic!("Incorrect hint length generated")
1906                         }
1907                 }
1908                 assert!(chan_ids_to_match.is_empty(), "Unmatched short channel ids: {:?}", chan_ids_to_match);
1909         }
1910
1911         #[test]
1912         fn test_create_invoice_fails_with_invalid_custom_min_final_cltv_expiry_delta() {
1913                 let chanmon_cfgs = create_chanmon_cfgs(2);
1914                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1915                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1916                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1917                 let result = crate::utils::create_invoice_from_channelmanager_and_duration_since_epoch(
1918                         nodes[1].node, nodes[1].keys_manager, nodes[1].logger, Currency::BitcoinTestnet,
1919                         Some(10_000), "Some description".into(), Duration::from_secs(1234567), 3600, Some(MIN_FINAL_CLTV_EXPIRY_DELTA - 4),
1920                 );
1921                 match result {
1922                         Err(SignOrCreationError::CreationError(CreationError::MinFinalCltvExpiryDeltaTooShort)) => {},
1923                         _ => panic!(),
1924                 }
1925         }
1926
1927         #[test]
1928         fn test_rotate_through_iterators() {
1929                 // two nested vectors
1930                 let a = vec![vec!["a0", "b0", "c0"].into_iter(), vec!["a1", "b1"].into_iter()];
1931                 let result = rotate_through_iterators(a).collect::<Vec<_>>();
1932
1933                 let expected = vec!["a0", "a1", "b0", "b1", "c0"];
1934                 assert_eq!(expected, result);
1935
1936                 // test single nested vector
1937                 let a = vec![vec!["a0", "b0", "c0"].into_iter()];
1938                 let result = rotate_through_iterators(a).collect::<Vec<_>>();
1939
1940                 let expected = vec!["a0", "b0", "c0"];
1941                 assert_eq!(expected, result);
1942
1943                 // test second vector with only one element
1944                 let a = vec![vec!["a0", "b0", "c0"].into_iter(), vec!["a1"].into_iter()];
1945                 let result = rotate_through_iterators(a).collect::<Vec<_>>();
1946
1947                 let expected = vec!["a0", "a1", "b0", "c0"];
1948                 assert_eq!(expected, result);
1949
1950                 // test three nestend vectors
1951                 let a = vec![vec!["a0"].into_iter(), vec!["a1", "b1", "c1"].into_iter(), vec!["a2"].into_iter()];
1952                 let result = rotate_through_iterators(a).collect::<Vec<_>>();
1953
1954                 let expected = vec!["a0", "a1", "a2", "b1", "c1"];
1955                 assert_eq!(expected, result);
1956
1957                 // test single nested vector with a single value
1958                 let a = vec![vec!["a0"].into_iter()];
1959                 let result = rotate_through_iterators(a).collect::<Vec<_>>();
1960
1961                 let expected = vec!["a0"];
1962                 assert_eq!(expected, result);
1963
1964                 // test single empty nested vector
1965                 let a:Vec<std::vec::IntoIter<&str>> = vec![vec![].into_iter()];
1966                 let result = rotate_through_iterators(a).collect::<Vec<&str>>();
1967                 let expected:Vec<&str> = vec![];
1968
1969                 assert_eq!(expected, result);
1970
1971                 // test first nested vector is empty
1972                 let a:Vec<std::vec::IntoIter<&str>>= vec![vec![].into_iter(), vec!["a1", "b1", "c1"].into_iter()];
1973                 let result = rotate_through_iterators(a).collect::<Vec<&str>>();
1974
1975                 let expected = vec!["a1", "b1", "c1"];
1976                 assert_eq!(expected, result);
1977
1978                 // test two empty vectors
1979                 let a:Vec<std::vec::IntoIter<&str>> = vec![vec![].into_iter(), vec![].into_iter()];
1980                 let result = rotate_through_iterators(a).collect::<Vec<&str>>();
1981
1982                 let expected:Vec<&str> = vec![];
1983                 assert_eq!(expected, result);
1984
1985                 // test an empty vector amongst other filled vectors
1986                 let a = vec![
1987                         vec!["a0", "b0", "c0"].into_iter(),
1988                         vec![].into_iter(),
1989                         vec!["a1", "b1", "c1"].into_iter(),
1990                         vec!["a2", "b2", "c2"].into_iter(),
1991                 ];
1992                 let result = rotate_through_iterators(a).collect::<Vec<_>>();
1993
1994                 let expected = vec!["a0", "a1", "a2", "b0", "b1", "b2", "c0", "c1", "c2"];
1995                 assert_eq!(expected, result);
1996
1997                 // test a filled vector between two empty vectors
1998                 let a = vec![vec![].into_iter(), vec!["a1", "b1", "c1"].into_iter(), vec![].into_iter()];
1999                 let result = rotate_through_iterators(a).collect::<Vec<_>>();
2000
2001                 let expected = vec!["a1", "b1", "c1"];
2002                 assert_eq!(expected, result);
2003
2004                 // test an empty vector at the end of the vectors
2005                 let a = vec![vec!["a0", "b0", "c0"].into_iter(), vec![].into_iter()];
2006                 let result = rotate_through_iterators(a).collect::<Vec<_>>();
2007
2008                 let expected = vec!["a0", "b0", "c0"];
2009                 assert_eq!(expected, result);
2010
2011                 // test multiple empty vectors amongst multiple filled vectors
2012                 let a = vec![
2013                         vec![].into_iter(),
2014                         vec!["a1", "b1", "c1"].into_iter(),
2015                         vec![].into_iter(),
2016                         vec!["a3", "b3"].into_iter(),
2017                         vec![].into_iter(),
2018                 ];
2019
2020                 let result = rotate_through_iterators(a).collect::<Vec<_>>();
2021
2022                 let expected = vec!["a1", "a3", "b1", "b3", "c1"];
2023                 assert_eq!(expected, result);
2024
2025                 // test one element in the first nested vectore and two elements in the second nested
2026                 // vector
2027                 let a = vec![vec!["a0"].into_iter(), vec!["a1", "b1"].into_iter()];
2028                 let result = rotate_through_iterators(a).collect::<Vec<_>>();
2029
2030                 let expected = vec!["a0", "a1", "b1"];
2031                 assert_eq!(expected, result);
2032         }
2033 }