Merge pull request #2081 from TheBlueMatt/2023-03-future-poll-panic
[rust-lightning] / lightning-invoice / src / utils.rs
1 //! Convenient utilities to create an invoice.
2
3 use crate::{CreationError, Currency, Invoice, InvoiceBuilder, SignOrCreationError};
4
5 use crate::{prelude::*, Description, InvoiceDescription, Sha256};
6 use bech32::ToBase32;
7 use bitcoin_hashes::Hash;
8 use lightning::chain;
9 use lightning::chain::chaininterface::{BroadcasterInterface, FeeEstimator};
10 use lightning::chain::keysinterface::{Recipient, NodeSigner, SignerProvider, EntropySource};
11 use lightning::ln::{PaymentHash, PaymentSecret};
12 use lightning::ln::channelmanager::{ChannelDetails, ChannelManager, MIN_FINAL_CLTV_EXPIRY_DELTA};
13 use lightning::ln::channelmanager::{PhantomRouteHints, MIN_CLTV_EXPIRY_DELTA};
14 use lightning::ln::inbound_payment::{create, create_from_hash, ExpandedKey};
15 use lightning::routing::gossip::RoutingFees;
16 use lightning::routing::router::{RouteHint, RouteHintHop, Router};
17 use lightning::util::logger::Logger;
18 use secp256k1::PublicKey;
19 use core::ops::Deref;
20 use core::time::Duration;
21
22 /// Utility to create an invoice that can be paid to one of multiple nodes, or a "phantom invoice."
23 /// See [`PhantomKeysManager`] for more information on phantom node payments.
24 ///
25 /// `phantom_route_hints` parameter:
26 /// * Contains channel info for all nodes participating in the phantom invoice
27 /// * Entries are retrieved from a call to [`ChannelManager::get_phantom_route_hints`] on each
28 ///   participating node
29 /// * It is fine to cache `phantom_route_hints` and reuse it across invoices, as long as the data is
30 ///   updated when a channel becomes disabled or closes
31 /// * Note that if too many channels are included in [`PhantomRouteHints::channels`], the invoice
32 ///   may be too long for QR code scanning. To fix this, `PhantomRouteHints::channels` may be pared
33 ///   down
34 ///
35 /// `payment_hash` can be specified if you have a specific need for a custom payment hash (see the difference
36 /// between [`ChannelManager::create_inbound_payment`] and [`ChannelManager::create_inbound_payment_for_hash`]).
37 /// If `None` is provided for `payment_hash`, then one will be created.
38 ///
39 /// `invoice_expiry_delta_secs` describes the number of seconds that the invoice is valid for
40 /// in excess of the current time.
41 /// 
42 /// `duration_since_epoch` is the current time since epoch in seconds.
43 ///
44 /// You can specify a custom `min_final_cltv_expiry_delta`, or let LDK default it to
45 /// [`MIN_FINAL_CLTV_EXPIRY_DELTA`]. The provided expiry must be at least [`MIN_FINAL_CLTV_EXPIRY_DELTA`] - 3.
46 /// Note that LDK will add a buffer of 3 blocks to the delta to allow for up to a few new block
47 /// confirmations during routing.
48 ///
49 /// Note that the provided `keys_manager`'s `NodeSigner` implementation must support phantom
50 /// invoices in its `sign_invoice` implementation ([`PhantomKeysManager`] satisfies this
51 /// requirement).
52 ///
53 /// [`PhantomKeysManager`]: lightning::chain::keysinterface::PhantomKeysManager
54 /// [`ChannelManager::get_phantom_route_hints`]: lightning::ln::channelmanager::ChannelManager::get_phantom_route_hints
55 /// [`ChannelManager::create_inbound_payment`]: lightning::ln::channelmanager::ChannelManager::create_inbound_payment
56 /// [`ChannelManager::create_inbound_payment_for_hash`]: lightning::ln::channelmanager::ChannelManager::create_inbound_payment_for_hash
57 /// [`PhantomRouteHints::channels`]: lightning::ln::channelmanager::PhantomRouteHints::channels
58 /// [`MIN_FINAL_CLTV_EXPIRY_DETLA`]: lightning::ln::channelmanager::MIN_FINAL_CLTV_EXPIRY_DELTA
59 /// 
60 /// This can be used in a `no_std` environment, where [`std::time::SystemTime`] is not
61 /// available and the current time is supplied by the caller.
62 pub fn create_phantom_invoice<ES: Deref, NS: Deref, L: Deref>(
63         amt_msat: Option<u64>, payment_hash: Option<PaymentHash>, description: String,
64         invoice_expiry_delta_secs: u32, phantom_route_hints: Vec<PhantomRouteHints>, entropy_source: ES,
65         node_signer: NS, logger: L, network: Currency, min_final_cltv_expiry_delta: Option<u16>, duration_since_epoch: Duration,
66 ) -> Result<Invoice, SignOrCreationError<()>>
67 where
68         ES::Target: EntropySource,
69         NS::Target: NodeSigner,
70         L::Target: Logger,
71 {
72         let description = Description::new(description).map_err(SignOrCreationError::CreationError)?;
73         let description = InvoiceDescription::Direct(&description,);
74         _create_phantom_invoice::<ES, NS, L>(
75                 amt_msat, payment_hash, description, invoice_expiry_delta_secs, phantom_route_hints,
76                 entropy_source, node_signer, logger, network, min_final_cltv_expiry_delta, duration_since_epoch,
77         )
78 }
79
80 /// Utility to create an invoice that can be paid to one of multiple nodes, or a "phantom invoice."
81 /// See [`PhantomKeysManager`] for more information on phantom node payments.
82 ///
83 /// `phantom_route_hints` parameter:
84 /// * Contains channel info for all nodes participating in the phantom invoice
85 /// * Entries are retrieved from a call to [`ChannelManager::get_phantom_route_hints`] on each
86 ///   participating node
87 /// * It is fine to cache `phantom_route_hints` and reuse it across invoices, as long as the data is
88 ///   updated when a channel becomes disabled or closes
89 /// * Note that if too many channels are included in [`PhantomRouteHints::channels`], the invoice
90 ///   may be too long for QR code scanning. To fix this, `PhantomRouteHints::channels` may be pared
91 ///   down
92 ///
93 /// `description_hash` is a SHA-256 hash of the description text
94 ///
95 /// `payment_hash` can be specified if you have a specific need for a custom payment hash (see the difference
96 /// between [`ChannelManager::create_inbound_payment`] and [`ChannelManager::create_inbound_payment_for_hash`]).
97 /// If `None` is provided for `payment_hash`, then one will be created.
98 ///
99 /// `invoice_expiry_delta_secs` describes the number of seconds that the invoice is valid for
100 /// in excess of the current time.
101 /// 
102 /// `duration_since_epoch` is the current time since epoch in seconds.
103 ///
104 /// Note that the provided `keys_manager`'s `NodeSigner` implementation must support phantom
105 /// invoices in its `sign_invoice` implementation ([`PhantomKeysManager`] satisfies this
106 /// requirement).
107 ///
108 /// [`PhantomKeysManager`]: lightning::chain::keysinterface::PhantomKeysManager
109 /// [`ChannelManager::get_phantom_route_hints`]: lightning::ln::channelmanager::ChannelManager::get_phantom_route_hints
110 /// [`ChannelManager::create_inbound_payment`]: lightning::ln::channelmanager::ChannelManager::create_inbound_payment
111 /// [`ChannelManager::create_inbound_payment_for_hash`]: lightning::ln::channelmanager::ChannelManager::create_inbound_payment_for_hash
112 /// [`PhantomRouteHints::channels`]: lightning::ln::channelmanager::PhantomRouteHints::channels
113 /// 
114 /// This can be used in a `no_std` environment, where [`std::time::SystemTime`] is not
115 /// available and the current time is supplied by the caller.
116 pub fn create_phantom_invoice_with_description_hash<ES: Deref, NS: Deref, L: Deref>(
117         amt_msat: Option<u64>, payment_hash: Option<PaymentHash>, invoice_expiry_delta_secs: u32,
118         description_hash: Sha256, phantom_route_hints: Vec<PhantomRouteHints>, entropy_source: ES,
119         node_signer: NS, logger: L, network: Currency, min_final_cltv_expiry_delta: Option<u16>, duration_since_epoch: Duration,
120 ) -> Result<Invoice, SignOrCreationError<()>>
121 where
122         ES::Target: EntropySource,
123         NS::Target: NodeSigner,
124         L::Target: Logger,
125 {
126         _create_phantom_invoice::<ES, NS, L>(
127                 amt_msat, payment_hash, InvoiceDescription::Hash(&description_hash),
128                 invoice_expiry_delta_secs, phantom_route_hints, entropy_source, node_signer, logger, network,
129                 min_final_cltv_expiry_delta, duration_since_epoch,
130         )
131 }
132
133 fn _create_phantom_invoice<ES: Deref, NS: Deref, L: Deref>(
134         amt_msat: Option<u64>, payment_hash: Option<PaymentHash>, description: InvoiceDescription,
135         invoice_expiry_delta_secs: u32, phantom_route_hints: Vec<PhantomRouteHints>, entropy_source: ES,
136         node_signer: NS, logger: L, network: Currency, min_final_cltv_expiry_delta: Option<u16>, duration_since_epoch: Duration,
137 ) -> Result<Invoice, SignOrCreationError<()>>
138 where
139         ES::Target: EntropySource,
140         NS::Target: NodeSigner,
141         L::Target: Logger,
142 {
143
144         if phantom_route_hints.is_empty() {
145                 return Err(SignOrCreationError::CreationError(
146                         CreationError::MissingRouteHints,
147                 ));
148         }
149
150         if min_final_cltv_expiry_delta.is_some() && min_final_cltv_expiry_delta.unwrap().saturating_add(3) < MIN_FINAL_CLTV_EXPIRY_DELTA {
151                 return Err(SignOrCreationError::CreationError(CreationError::MinFinalCltvExpiryDeltaTooShort));
152         }
153
154         let invoice = match description {
155                 InvoiceDescription::Direct(description) => {
156                         InvoiceBuilder::new(network).description(description.0.clone())
157                 }
158                 InvoiceDescription::Hash(hash) => InvoiceBuilder::new(network).description_hash(hash.0),
159         };
160
161         // If we ever see performance here being too slow then we should probably take this ExpandedKey as a parameter instead.
162         let keys = ExpandedKey::new(&node_signer.get_inbound_payment_key_material());
163         let (payment_hash, payment_secret) = if let Some(payment_hash) = payment_hash {
164                 let payment_secret = create_from_hash(
165                         &keys,
166                         amt_msat,
167                         payment_hash,
168                         invoice_expiry_delta_secs,
169                         duration_since_epoch
170                                 .as_secs(),
171                         min_final_cltv_expiry_delta,
172                 )
173                 .map_err(|_| SignOrCreationError::CreationError(CreationError::InvalidAmount))?;
174                 (payment_hash, payment_secret)
175         } else {
176                 create(
177                         &keys,
178                         amt_msat,
179                         invoice_expiry_delta_secs,
180                         &entropy_source,
181                         duration_since_epoch
182                                 .as_secs(),
183                         min_final_cltv_expiry_delta,
184                 )
185                 .map_err(|_| SignOrCreationError::CreationError(CreationError::InvalidAmount))?
186         };
187
188         log_trace!(logger, "Creating phantom invoice from {} participating nodes with payment hash {}",
189                 phantom_route_hints.len(), log_bytes!(payment_hash.0));
190
191         let mut invoice = invoice
192                 .duration_since_epoch(duration_since_epoch)
193                 .payment_hash(Hash::from_slice(&payment_hash.0).unwrap())
194                 .payment_secret(payment_secret)
195                 .min_final_cltv_expiry_delta(
196                         // Add a buffer of 3 to the delta if present, otherwise use LDK's minimum.
197                         min_final_cltv_expiry_delta.map(|x| x.saturating_add(3)).unwrap_or(MIN_FINAL_CLTV_EXPIRY_DELTA).into())
198                 .expiry_time(Duration::from_secs(invoice_expiry_delta_secs.into()));
199         if let Some(amt) = amt_msat {
200                 invoice = invoice.amount_milli_satoshis(amt);
201         }
202
203         for PhantomRouteHints { channels, phantom_scid, real_node_pubkey } in phantom_route_hints {
204                 log_trace!(logger, "Generating phantom route hints for node {}",
205                         log_pubkey!(real_node_pubkey));
206                 let mut route_hints = filter_channels(channels, amt_msat, &logger);
207
208                 // If we have any public channel, the route hints from `filter_channels` will be empty.
209                 // In that case we create a RouteHint on which we will push a single hop with the phantom
210                 // route into the invoice, and let the sender find the path to the `real_node_pubkey`
211                 // node by looking at our public channels.
212                 if route_hints.is_empty() {
213                         route_hints.push(RouteHint(vec![]))
214                 }
215                 for mut route_hint in route_hints {
216                         route_hint.0.push(RouteHintHop {
217                                 src_node_id: real_node_pubkey,
218                                 short_channel_id: phantom_scid,
219                                 fees: RoutingFees {
220                                         base_msat: 0,
221                                         proportional_millionths: 0,
222                                 },
223                                 cltv_expiry_delta: MIN_CLTV_EXPIRY_DELTA,
224                                 htlc_minimum_msat: None,
225                                 htlc_maximum_msat: None,});
226                         invoice = invoice.private_route(route_hint.clone());
227                 }
228         }
229
230         let raw_invoice = match invoice.build_raw() {
231                 Ok(inv) => inv,
232                 Err(e) => return Err(SignOrCreationError::CreationError(e))
233         };
234         let hrp_str = raw_invoice.hrp.to_string();
235         let hrp_bytes = hrp_str.as_bytes();
236         let data_without_signature = raw_invoice.data.to_base32();
237         let signed_raw_invoice = raw_invoice.sign(|_| node_signer.sign_invoice(hrp_bytes, &data_without_signature, Recipient::PhantomNode));
238         match signed_raw_invoice {
239                 Ok(inv) => Ok(Invoice::from_signed(inv).unwrap()),
240                 Err(e) => Err(SignOrCreationError::SignError(e))
241         }
242 }
243
244 #[cfg(feature = "std")]
245 /// Utility to construct an invoice. Generally, unless you want to do something like a custom
246 /// cltv_expiry, this is what you should be using to create an invoice. The reason being, this
247 /// method stores the invoice's payment secret and preimage in `ChannelManager`, so (a) the user
248 /// doesn't have to store preimage/payment secret information and (b) `ChannelManager` can verify
249 /// that the payment secret is valid when the invoice is paid.
250 ///
251 /// `invoice_expiry_delta_secs` describes the number of seconds that the invoice is valid for
252 /// in excess of the current time.
253 ///
254 /// You can specify a custom `min_final_cltv_expiry_delta`, or let LDK default it to
255 /// [`MIN_FINAL_CLTV_EXPIRY_DELTA`]. The provided expiry must be at least [`MIN_FINAL_CLTV_EXPIRY_DELTA`].
256 /// Note that LDK will add a buffer of 3 blocks to the delta to allow for up to a few new block
257 /// confirmations during routing.
258 ///
259 /// [`MIN_FINAL_CLTV_EXPIRY_DETLA`]: lightning::ln::channelmanager::MIN_FINAL_CLTV_EXPIRY_DELTA
260 pub fn create_invoice_from_channelmanager<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
261         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
262         network: Currency, amt_msat: Option<u64>, description: String, invoice_expiry_delta_secs: u32,
263         min_final_cltv_expiry_delta: Option<u16>,
264 ) -> Result<Invoice, SignOrCreationError<()>>
265 where
266         M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
267         T::Target: BroadcasterInterface,
268         ES::Target: EntropySource,
269         NS::Target: NodeSigner,
270         SP::Target: SignerProvider,
271         F::Target: FeeEstimator,
272         R::Target: Router,
273         L::Target: Logger,
274 {
275         use std::time::SystemTime;
276         let duration = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH)
277                 .expect("for the foreseeable future this shouldn't happen");
278         create_invoice_from_channelmanager_and_duration_since_epoch(
279                 channelmanager, node_signer, logger, network, amt_msat,
280                 description, duration, invoice_expiry_delta_secs, min_final_cltv_expiry_delta,
281         )
282 }
283
284 #[cfg(feature = "std")]
285 /// Utility to construct an invoice. Generally, unless you want to do something like a custom
286 /// cltv_expiry, this is what you should be using to create an invoice. The reason being, this
287 /// method stores the invoice's payment secret and preimage in `ChannelManager`, so (a) the user
288 /// doesn't have to store preimage/payment secret information and (b) `ChannelManager` can verify
289 /// that the payment secret is valid when the invoice is paid.
290 /// Use this variant if you want to pass the `description_hash` to the invoice.
291 ///
292 /// `invoice_expiry_delta_secs` describes the number of seconds that the invoice is valid for
293 /// in excess of the current time.
294 ///
295 /// You can specify a custom `min_final_cltv_expiry_delta`, or let LDK default it to
296 /// [`MIN_FINAL_CLTV_EXPIRY_DELTA`]. The provided expiry must be at least [`MIN_FINAL_CLTV_EXPIRY_DELTA`].
297 /// Note that LDK will add a buffer of 3 blocks to the delta to allow for up to a few new block
298 /// confirmations during routing.
299 ///
300 /// [`MIN_FINAL_CLTV_EXPIRY_DETLA`]: lightning::ln::channelmanager::MIN_FINAL_CLTV_EXPIRY_DELTA
301 pub fn create_invoice_from_channelmanager_with_description_hash<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
302         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
303         network: Currency, amt_msat: Option<u64>, description_hash: Sha256,
304         invoice_expiry_delta_secs: u32, min_final_cltv_expiry_delta: Option<u16>,
305 ) -> Result<Invoice, SignOrCreationError<()>>
306 where
307         M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
308         T::Target: BroadcasterInterface,
309         ES::Target: EntropySource,
310         NS::Target: NodeSigner,
311         SP::Target: SignerProvider,
312         F::Target: FeeEstimator,
313         R::Target: Router,
314         L::Target: Logger,
315 {
316         use std::time::SystemTime;
317
318         let duration = SystemTime::now()
319                 .duration_since(SystemTime::UNIX_EPOCH)
320                 .expect("for the foreseeable future this shouldn't happen");
321
322         create_invoice_from_channelmanager_with_description_hash_and_duration_since_epoch(
323                 channelmanager, node_signer, logger, network, amt_msat,
324                 description_hash, duration, invoice_expiry_delta_secs, min_final_cltv_expiry_delta,
325         )
326 }
327
328 /// See [`create_invoice_from_channelmanager_with_description_hash`]
329 /// This version can be used in a `no_std` environment, where [`std::time::SystemTime`] is not
330 /// available and the current time is supplied by the caller.
331 pub fn create_invoice_from_channelmanager_with_description_hash_and_duration_since_epoch<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
332         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
333         network: Currency, amt_msat: Option<u64>, description_hash: Sha256,
334         duration_since_epoch: Duration, invoice_expiry_delta_secs: u32, min_final_cltv_expiry_delta: Option<u16>,
335 ) -> Result<Invoice, SignOrCreationError<()>>
336                 where
337                         M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
338                         T::Target: BroadcasterInterface,
339                         ES::Target: EntropySource,
340                         NS::Target: NodeSigner,
341                         SP::Target: SignerProvider,
342                         F::Target: FeeEstimator,
343                         R::Target: Router,
344                         L::Target: Logger,
345 {
346         _create_invoice_from_channelmanager_and_duration_since_epoch(
347                 channelmanager, node_signer, logger, network, amt_msat,
348                 InvoiceDescription::Hash(&description_hash),
349                 duration_since_epoch, invoice_expiry_delta_secs, min_final_cltv_expiry_delta,
350         )
351 }
352
353 /// See [`create_invoice_from_channelmanager`]
354 /// This version can be used in a `no_std` environment, where [`std::time::SystemTime`] is not
355 /// available and the current time is supplied by the caller.
356 pub fn create_invoice_from_channelmanager_and_duration_since_epoch<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
357         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
358         network: Currency, amt_msat: Option<u64>, description: String, duration_since_epoch: Duration,
359         invoice_expiry_delta_secs: u32, min_final_cltv_expiry_delta: Option<u16>,
360 ) -> Result<Invoice, SignOrCreationError<()>>
361                 where
362                         M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
363                         T::Target: BroadcasterInterface,
364                         ES::Target: EntropySource,
365                         NS::Target: NodeSigner,
366                         SP::Target: SignerProvider,
367                         F::Target: FeeEstimator,
368                         R::Target: Router,
369                         L::Target: Logger,
370 {
371         _create_invoice_from_channelmanager_and_duration_since_epoch(
372                 channelmanager, node_signer, logger, network, amt_msat,
373                 InvoiceDescription::Direct(
374                         &Description::new(description).map_err(SignOrCreationError::CreationError)?,
375                 ),
376                 duration_since_epoch, invoice_expiry_delta_secs, min_final_cltv_expiry_delta,
377         )
378 }
379
380 fn _create_invoice_from_channelmanager_and_duration_since_epoch<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
381         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
382         network: Currency, amt_msat: Option<u64>, description: InvoiceDescription,
383         duration_since_epoch: Duration, invoice_expiry_delta_secs: u32, min_final_cltv_expiry_delta: Option<u16>,
384 ) -> Result<Invoice, SignOrCreationError<()>>
385                 where
386                         M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
387                         T::Target: BroadcasterInterface,
388                         ES::Target: EntropySource,
389                         NS::Target: NodeSigner,
390                         SP::Target: SignerProvider,
391                         F::Target: FeeEstimator,
392                         R::Target: Router,
393                         L::Target: Logger,
394 {
395         if min_final_cltv_expiry_delta.is_some() && min_final_cltv_expiry_delta.unwrap().saturating_add(3) < MIN_FINAL_CLTV_EXPIRY_DELTA {
396                 return Err(SignOrCreationError::CreationError(CreationError::MinFinalCltvExpiryDeltaTooShort));
397         }
398
399         // `create_inbound_payment` only returns an error if the amount is greater than the total bitcoin
400         // supply.
401         let (payment_hash, payment_secret) = channelmanager
402                 .create_inbound_payment(amt_msat, invoice_expiry_delta_secs, min_final_cltv_expiry_delta)
403                 .map_err(|()| SignOrCreationError::CreationError(CreationError::InvalidAmount))?;
404         _create_invoice_from_channelmanager_and_duration_since_epoch_with_payment_hash(
405                 channelmanager, node_signer, logger, network, amt_msat, description, duration_since_epoch,
406                 invoice_expiry_delta_secs, payment_hash, payment_secret, min_final_cltv_expiry_delta)
407 }
408
409 /// See [`create_invoice_from_channelmanager_and_duration_since_epoch`]
410 /// This version allows for providing a custom [`PaymentHash`] for the invoice.
411 /// This may be useful if you're building an on-chain swap or involving another protocol where
412 /// the payment hash is also involved outside the scope of lightning.
413 pub fn create_invoice_from_channelmanager_and_duration_since_epoch_with_payment_hash<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
414         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
415         network: Currency, amt_msat: Option<u64>, description: String, duration_since_epoch: Duration,
416         invoice_expiry_delta_secs: u32, payment_hash: PaymentHash, min_final_cltv_expiry_delta: Option<u16>,
417 ) -> Result<Invoice, SignOrCreationError<()>>
418         where
419                 M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
420                 T::Target: BroadcasterInterface,
421                 ES::Target: EntropySource,
422                 NS::Target: NodeSigner,
423                 SP::Target: SignerProvider,
424                 F::Target: FeeEstimator,
425                 R::Target: Router,
426                 L::Target: Logger,
427 {
428         let payment_secret = channelmanager
429                 .create_inbound_payment_for_hash(payment_hash, amt_msat, invoice_expiry_delta_secs,
430                         min_final_cltv_expiry_delta)
431                 .map_err(|()| SignOrCreationError::CreationError(CreationError::InvalidAmount))?;
432         _create_invoice_from_channelmanager_and_duration_since_epoch_with_payment_hash(
433                 channelmanager, node_signer, logger, network, amt_msat,
434                 InvoiceDescription::Direct(
435                         &Description::new(description).map_err(SignOrCreationError::CreationError)?,
436                 ),
437                 duration_since_epoch, invoice_expiry_delta_secs, payment_hash, payment_secret,
438                 min_final_cltv_expiry_delta,
439         )
440 }
441
442 fn _create_invoice_from_channelmanager_and_duration_since_epoch_with_payment_hash<M: Deref, T: Deref, ES: Deref, NS: Deref, SP: Deref, F: Deref, R: Deref, L: Deref>(
443         channelmanager: &ChannelManager<M, T, ES, NS, SP, F, R, L>, node_signer: NS, logger: L,
444         network: Currency, amt_msat: Option<u64>, description: InvoiceDescription, duration_since_epoch: Duration,
445         invoice_expiry_delta_secs: u32, payment_hash: PaymentHash, payment_secret: PaymentSecret,
446         min_final_cltv_expiry_delta: Option<u16>,
447 ) -> Result<Invoice, SignOrCreationError<()>>
448         where
449                 M::Target: chain::Watch<<SP::Target as SignerProvider>::Signer>,
450                 T::Target: BroadcasterInterface,
451                 ES::Target: EntropySource,
452                 NS::Target: NodeSigner,
453                 SP::Target: SignerProvider,
454                 F::Target: FeeEstimator,
455                 R::Target: Router,
456                 L::Target: Logger,
457 {
458         let our_node_pubkey = channelmanager.get_our_node_id();
459         let channels = channelmanager.list_channels();
460
461         if min_final_cltv_expiry_delta.is_some() && min_final_cltv_expiry_delta.unwrap().saturating_add(3) < MIN_FINAL_CLTV_EXPIRY_DELTA {
462                 return Err(SignOrCreationError::CreationError(CreationError::MinFinalCltvExpiryDeltaTooShort));
463         }
464
465         log_trace!(logger, "Creating invoice with payment hash {}", log_bytes!(payment_hash.0));
466
467         let invoice = match description {
468                 InvoiceDescription::Direct(description) => {
469                         InvoiceBuilder::new(network).description(description.0.clone())
470                 }
471                 InvoiceDescription::Hash(hash) => InvoiceBuilder::new(network).description_hash(hash.0),
472         };
473
474         let mut invoice = invoice
475                 .duration_since_epoch(duration_since_epoch)
476                 .payee_pub_key(our_node_pubkey)
477                 .payment_hash(Hash::from_slice(&payment_hash.0).unwrap())
478                 .payment_secret(payment_secret)
479                 .basic_mpp()
480                 .min_final_cltv_expiry_delta(
481                         // Add a buffer of 3 to the delta if present, otherwise use LDK's minimum.
482                         min_final_cltv_expiry_delta.map(|x| x.saturating_add(3)).unwrap_or(MIN_FINAL_CLTV_EXPIRY_DELTA).into())
483                 .expiry_time(Duration::from_secs(invoice_expiry_delta_secs.into()));
484         if let Some(amt) = amt_msat {
485                 invoice = invoice.amount_milli_satoshis(amt);
486         }
487
488         let route_hints = filter_channels(channels, amt_msat, &logger);
489         for hint in route_hints {
490                 invoice = invoice.private_route(hint);
491         }
492
493         let raw_invoice = match invoice.build_raw() {
494                 Ok(inv) => inv,
495                 Err(e) => return Err(SignOrCreationError::CreationError(e))
496         };
497         let hrp_str = raw_invoice.hrp.to_string();
498         let hrp_bytes = hrp_str.as_bytes();
499         let data_without_signature = raw_invoice.data.to_base32();
500         let signed_raw_invoice = raw_invoice.sign(|_| node_signer.sign_invoice(hrp_bytes, &data_without_signature, Recipient::Node));
501         match signed_raw_invoice {
502                 Ok(inv) => Ok(Invoice::from_signed(inv).unwrap()),
503                 Err(e) => Err(SignOrCreationError::SignError(e))
504         }
505 }
506
507 /// Filters the `channels` for an invoice, and returns the corresponding `RouteHint`s to include
508 /// in the invoice.
509 ///
510 /// The filtering is based on the following criteria:
511 /// * Only one channel per counterparty node
512 /// * Always select the channel with the highest inbound capacity per counterparty node
513 /// * Prefer channels with capacity at least `min_inbound_capacity_msat` and where the channel
514 ///   `is_usable` (i.e. the peer is connected).
515 /// * If any public channel exists, the returned `RouteHint`s will be empty, and the sender will
516 ///   need to find the path by looking at the public channels instead
517 fn filter_channels<L: Deref>(
518         channels: Vec<ChannelDetails>, min_inbound_capacity_msat: Option<u64>, logger: &L
519 ) -> Vec<RouteHint> where L::Target: Logger {
520         let mut filtered_channels: HashMap<PublicKey, ChannelDetails> = HashMap::new();
521         let min_inbound_capacity = min_inbound_capacity_msat.unwrap_or(0);
522         let mut min_capacity_channel_exists = false;
523         let mut online_channel_exists = false;
524         let mut online_min_capacity_channel_exists = false;
525
526         log_trace!(logger, "Considering {} channels for invoice route hints", channels.len());
527         for channel in channels.into_iter().filter(|chan| chan.is_channel_ready) {
528                 if channel.get_inbound_payment_scid().is_none() || channel.counterparty.forwarding_info.is_none() {
529                         log_trace!(logger, "Ignoring channel {} for invoice route hints", log_bytes!(channel.channel_id));
530                         continue;
531                 }
532
533                 if channel.is_public {
534                         // If any public channel exists, return no hints and let the sender
535                         // look at the public channels instead.
536                         log_trace!(logger, "Not including channels in invoice route hints on account of public channel {}",
537                                 log_bytes!(channel.channel_id));
538                         return vec![]
539                 }
540
541                 if channel.inbound_capacity_msat >= min_inbound_capacity {
542                         if !min_capacity_channel_exists {
543                                 log_trace!(logger, "Channel with enough inbound capacity exists for invoice route hints");
544                                 min_capacity_channel_exists = true;
545                         }
546
547                         if channel.is_usable {
548                                 online_min_capacity_channel_exists = true;
549                         }
550                 }
551
552                 if channel.is_usable && !online_channel_exists {
553                         log_trace!(logger, "Channel with connected peer exists for invoice route hints");
554                         online_channel_exists = true;
555                 }
556
557                 match filtered_channels.entry(channel.counterparty.node_id) {
558                         hash_map::Entry::Occupied(mut entry) => {
559                                 let current_max_capacity = entry.get().inbound_capacity_msat;
560                                 if channel.inbound_capacity_msat < current_max_capacity {
561                                         log_trace!(logger,
562                                                 "Preferring counterparty {} channel {} ({} msats) over {} ({} msats) for invoice route hints",
563                                                 log_pubkey!(channel.counterparty.node_id),
564                                                 log_bytes!(entry.get().channel_id), current_max_capacity,
565                                                 log_bytes!(channel.channel_id), channel.inbound_capacity_msat);
566                                         continue;
567                                 }
568                                 log_trace!(logger,
569                                         "Preferring counterparty {} channel {} ({} msats) over {} ({} msats) for invoice route hints",
570                                         log_pubkey!(channel.counterparty.node_id),
571                                         log_bytes!(channel.channel_id), channel.inbound_capacity_msat,
572                                         log_bytes!(entry.get().channel_id), current_max_capacity);
573                                 entry.insert(channel);
574                         }
575                         hash_map::Entry::Vacant(entry) => {
576                                 entry.insert(channel);
577                         }
578                 }
579         }
580
581         let route_hint_from_channel = |channel: ChannelDetails| {
582                 let forwarding_info = channel.counterparty.forwarding_info.as_ref().unwrap();
583                 RouteHint(vec![RouteHintHop {
584                         src_node_id: channel.counterparty.node_id,
585                         short_channel_id: channel.get_inbound_payment_scid().unwrap(),
586                         fees: RoutingFees {
587                                 base_msat: forwarding_info.fee_base_msat,
588                                 proportional_millionths: forwarding_info.fee_proportional_millionths,
589                         },
590                         cltv_expiry_delta: forwarding_info.cltv_expiry_delta,
591                         htlc_minimum_msat: channel.inbound_htlc_minimum_msat,
592                         htlc_maximum_msat: channel.inbound_htlc_maximum_msat,}])
593         };
594         // If all channels are private, prefer to return route hints which have a higher capacity than
595         // the payment value and where we're currently connected to the channel counterparty.
596         // Even if we cannot satisfy both goals, always ensure we include *some* hints, preferring
597         // those which meet at least one criteria.
598         filtered_channels
599                 .into_iter()
600                 .map(|(_, channel)| channel)
601                 .filter(|channel| {
602                         let has_enough_capacity = channel.inbound_capacity_msat >= min_inbound_capacity;
603                         let include_channel = if online_min_capacity_channel_exists {
604                                 has_enough_capacity && channel.is_usable
605                         } else if min_capacity_channel_exists && online_channel_exists {
606                                 // If there are some online channels and some min_capacity channels, but no
607                                 // online-and-min_capacity channels, just include the min capacity ones and ignore
608                                 // online-ness.
609                                 has_enough_capacity
610                         } else if min_capacity_channel_exists {
611                                 has_enough_capacity
612                         } else if online_channel_exists {
613                                 channel.is_usable
614                         } else { true };
615
616                         if include_channel {
617                                 log_trace!(logger, "Including channel {} in invoice route hints",
618                                         log_bytes!(channel.channel_id));
619                         } else if !has_enough_capacity {
620                                 log_trace!(logger, "Ignoring channel {} without enough capacity for invoice route hints",
621                                         log_bytes!(channel.channel_id));
622                         } else {
623                                 debug_assert!(!channel.is_usable);
624                                 log_trace!(logger, "Ignoring channel {} with disconnected peer",
625                                         log_bytes!(channel.channel_id));
626                         }
627
628                         include_channel
629                 })
630                 .map(route_hint_from_channel)
631                 .collect::<Vec<RouteHint>>()
632 }
633
634 #[cfg(test)]
635 mod test {
636         use core::time::Duration;
637         use crate::{Currency, Description, InvoiceDescription, SignOrCreationError, CreationError};
638         use bitcoin_hashes::{Hash, sha256};
639         use bitcoin_hashes::sha256::Hash as Sha256;
640         use lightning::chain::keysinterface::{EntropySource, PhantomKeysManager};
641         use lightning::ln::{PaymentPreimage, PaymentHash};
642         use lightning::ln::channelmanager::{PhantomRouteHints, MIN_FINAL_CLTV_EXPIRY_DELTA, PaymentId};
643         use lightning::ln::functional_test_utils::*;
644         use lightning::ln::msgs::ChannelMessageHandler;
645         use lightning::routing::router::{PaymentParameters, RouteParameters, find_route};
646         use lightning::util::events::{MessageSendEvent, MessageSendEventsProvider, Event};
647         use lightning::util::test_utils;
648         use lightning::util::config::UserConfig;
649         use crate::utils::create_invoice_from_channelmanager_and_duration_since_epoch;
650         use std::collections::HashSet;
651
652         #[test]
653         fn test_from_channelmanager() {
654                 let chanmon_cfgs = create_chanmon_cfgs(2);
655                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
656                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
657                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
658                 create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001);
659                 let non_default_invoice_expiry_secs = 4200;
660                 let invoice = create_invoice_from_channelmanager_and_duration_since_epoch(
661                         nodes[1].node, nodes[1].keys_manager, nodes[1].logger, Currency::BitcoinTestnet,
662                         Some(10_000), "test".to_string(), Duration::from_secs(1234567),
663                         non_default_invoice_expiry_secs, None).unwrap();
664                 assert_eq!(invoice.amount_pico_btc(), Some(100_000));
665                 // If no `min_final_cltv_expiry_delta` is specified, then it should be `MIN_FINAL_CLTV_EXPIRY_DELTA`.
666                 assert_eq!(invoice.min_final_cltv_expiry_delta(), MIN_FINAL_CLTV_EXPIRY_DELTA as u64);
667                 assert_eq!(invoice.description(), InvoiceDescription::Direct(&Description("test".to_string())));
668                 assert_eq!(invoice.expiry_time(), Duration::from_secs(non_default_invoice_expiry_secs.into()));
669
670                 // Invoice SCIDs should always use inbound SCID aliases over the real channel ID, if one is
671                 // available.
672                 let chan = &nodes[1].node.list_usable_channels()[0];
673                 assert_eq!(invoice.route_hints().len(), 1);
674                 assert_eq!(invoice.route_hints()[0].0.len(), 1);
675                 assert_eq!(invoice.route_hints()[0].0[0].short_channel_id, chan.inbound_scid_alias.unwrap());
676
677                 assert_eq!(invoice.route_hints()[0].0[0].htlc_minimum_msat, chan.inbound_htlc_minimum_msat);
678                 assert_eq!(invoice.route_hints()[0].0[0].htlc_maximum_msat, chan.inbound_htlc_maximum_msat);
679
680                 let payment_params = PaymentParameters::from_node_id(invoice.recover_payee_pub_key(),
681                                 invoice.min_final_cltv_expiry_delta() as u32)
682                         .with_features(invoice.features().unwrap().clone())
683                         .with_route_hints(invoice.route_hints());
684                 let route_params = RouteParameters {
685                         payment_params,
686                         final_value_msat: invoice.amount_milli_satoshis().unwrap(),
687                 };
688                 let first_hops = nodes[0].node.list_usable_channels();
689                 let network_graph = &node_cfgs[0].network_graph;
690                 let logger = test_utils::TestLogger::new();
691                 let scorer = test_utils::TestScorer::new();
692                 let random_seed_bytes = chanmon_cfgs[1].keys_manager.get_secure_random_bytes();
693                 let route = find_route(
694                         &nodes[0].node.get_our_node_id(), &route_params, network_graph,
695                         Some(&first_hops.iter().collect::<Vec<_>>()), &logger, &scorer, &random_seed_bytes
696                 ).unwrap();
697
698                 let payment_event = {
699                         let mut payment_hash = PaymentHash([0; 32]);
700                         payment_hash.0.copy_from_slice(&invoice.payment_hash().as_ref()[0..32]);
701                         nodes[0].node.send_payment(&route, payment_hash, &Some(*invoice.payment_secret()), PaymentId(payment_hash.0)).unwrap();
702                         let mut added_monitors = nodes[0].chain_monitor.added_monitors.lock().unwrap();
703                         assert_eq!(added_monitors.len(), 1);
704                         added_monitors.clear();
705
706                         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
707                         assert_eq!(events.len(), 1);
708                         SendEvent::from_event(events.remove(0))
709
710                 };
711                 nodes[1].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
712                 nodes[1].node.handle_commitment_signed(&nodes[0].node.get_our_node_id(), &payment_event.commitment_msg);
713                 let mut added_monitors = nodes[1].chain_monitor.added_monitors.lock().unwrap();
714                 assert_eq!(added_monitors.len(), 1);
715                 added_monitors.clear();
716                 let events = nodes[1].node.get_and_clear_pending_msg_events();
717                 assert_eq!(events.len(), 2);
718         }
719
720         fn do_create_invoice_min_final_cltv_delta(with_custom_delta: bool) {
721                 let chanmon_cfgs = create_chanmon_cfgs(2);
722                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
723                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
724                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
725                 let custom_min_final_cltv_expiry_delta = Some(50);
726
727                 let invoice = crate::utils::create_invoice_from_channelmanager_and_duration_since_epoch(
728                         nodes[1].node, nodes[1].keys_manager, nodes[1].logger, Currency::BitcoinTestnet,
729                         Some(10_000), "".into(), Duration::from_secs(1234567), 3600,
730                         if with_custom_delta { custom_min_final_cltv_expiry_delta } else { None },
731                 ).unwrap();
732                 assert_eq!(invoice.min_final_cltv_expiry_delta(), if with_custom_delta {
733                         custom_min_final_cltv_expiry_delta.unwrap() + 3 /* Buffer */} else { MIN_FINAL_CLTV_EXPIRY_DELTA } as u64);
734         }
735
736         #[test]
737         fn test_create_invoice_custom_min_final_cltv_delta() {
738                 do_create_invoice_min_final_cltv_delta(true);
739                 do_create_invoice_min_final_cltv_delta(false);
740         }
741
742         #[test]
743         fn create_invoice_min_final_cltv_delta_equals_htlc_fail_buffer() {
744                 let chanmon_cfgs = create_chanmon_cfgs(2);
745                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
746                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
747                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
748                 let custom_min_final_cltv_expiry_delta = Some(21);
749
750                 let invoice = crate::utils::create_invoice_from_channelmanager_and_duration_since_epoch(
751                         nodes[1].node, nodes[1].keys_manager, nodes[1].logger, Currency::BitcoinTestnet,
752                         Some(10_000), "".into(), Duration::from_secs(1234567), 3600,
753                         custom_min_final_cltv_expiry_delta,
754                 ).unwrap();
755                 assert_eq!(invoice.min_final_cltv_expiry_delta(), MIN_FINAL_CLTV_EXPIRY_DELTA as u64);
756         }
757
758         #[test]
759         fn test_create_invoice_with_description_hash() {
760                 let chanmon_cfgs = create_chanmon_cfgs(2);
761                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
762                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
763                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
764                 let description_hash = crate::Sha256(Hash::hash("Testing description_hash".as_bytes()));
765                 let invoice = crate::utils::create_invoice_from_channelmanager_with_description_hash_and_duration_since_epoch(
766                         nodes[1].node, nodes[1].keys_manager, nodes[1].logger, Currency::BitcoinTestnet,
767                         Some(10_000), description_hash, Duration::from_secs(1234567), 3600, None,
768                 ).unwrap();
769                 assert_eq!(invoice.amount_pico_btc(), Some(100_000));
770                 assert_eq!(invoice.min_final_cltv_expiry_delta(), MIN_FINAL_CLTV_EXPIRY_DELTA as u64);
771                 assert_eq!(invoice.description(), InvoiceDescription::Hash(&crate::Sha256(Sha256::hash("Testing description_hash".as_bytes()))));
772         }
773
774         #[test]
775         fn test_create_invoice_from_channelmanager_and_duration_since_epoch_with_payment_hash() {
776                 let chanmon_cfgs = create_chanmon_cfgs(2);
777                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
778                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
779                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
780                 let payment_hash = PaymentHash([0; 32]);
781                 let invoice = crate::utils::create_invoice_from_channelmanager_and_duration_since_epoch_with_payment_hash(
782                         nodes[1].node, nodes[1].keys_manager, nodes[1].logger, Currency::BitcoinTestnet,
783                         Some(10_000), "test".to_string(), Duration::from_secs(1234567), 3600,
784                         payment_hash, None,
785                 ).unwrap();
786                 assert_eq!(invoice.amount_pico_btc(), Some(100_000));
787                 assert_eq!(invoice.min_final_cltv_expiry_delta(), MIN_FINAL_CLTV_EXPIRY_DELTA as u64);
788                 assert_eq!(invoice.description(), InvoiceDescription::Direct(&Description("test".to_string())));
789                 assert_eq!(invoice.payment_hash(), &sha256::Hash::from_slice(&payment_hash.0[..]).unwrap());
790         }
791
792         #[test]
793         fn test_hints_includes_single_channels_to_nodes() {
794                 let chanmon_cfgs = create_chanmon_cfgs(3);
795                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
796                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
797                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
798
799                 let chan_1_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 100000, 10001);
800                 let chan_2_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 2, 0, 100000, 10001);
801
802                 let mut scid_aliases = HashSet::new();
803                 scid_aliases.insert(chan_1_0.0.short_channel_id_alias.unwrap());
804                 scid_aliases.insert(chan_2_0.0.short_channel_id_alias.unwrap());
805
806                 match_invoice_routes(Some(5000), &nodes[0], scid_aliases);
807         }
808
809         #[test]
810         fn test_hints_has_only_highest_inbound_capacity_channel() {
811                 let chanmon_cfgs = create_chanmon_cfgs(2);
812                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
813                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
814                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
815                 let _chan_1_0_low_inbound_capacity = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 100_000, 0);
816                 let chan_1_0_high_inbound_capacity = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 10_000_000, 0);
817                 let _chan_1_0_medium_inbound_capacity = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 1_000_000, 0);
818                 let mut scid_aliases = HashSet::new();
819                 scid_aliases.insert(chan_1_0_high_inbound_capacity.0.short_channel_id_alias.unwrap());
820                 match_invoice_routes(Some(5000), &nodes[0], scid_aliases);
821         }
822
823         #[test]
824         fn test_hints_has_only_online_channels() {
825                 let chanmon_cfgs = create_chanmon_cfgs(4);
826                 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
827                 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
828                 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
829                 let chan_a = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 10_000_000, 0);
830                 let chan_b = create_unannounced_chan_between_nodes_with_value(&nodes, 2, 0, 10_000_000, 0);
831                 let _chan_c = create_unannounced_chan_between_nodes_with_value(&nodes, 3, 0, 1_000_000, 0);
832
833                 // With all peers connected we should get all hints that have sufficient value
834                 let mut scid_aliases = HashSet::new();
835                 scid_aliases.insert(chan_a.0.short_channel_id_alias.unwrap());
836                 scid_aliases.insert(chan_b.0.short_channel_id_alias.unwrap());
837
838                 match_invoice_routes(Some(1_000_000_000), &nodes[0], scid_aliases.clone());
839
840                 // With only one sufficient-value peer connected we should only get its hint
841                 scid_aliases.remove(&chan_b.0.short_channel_id_alias.unwrap());
842                 nodes[0].node.peer_disconnected(&nodes[2].node.get_our_node_id());
843                 match_invoice_routes(Some(1_000_000_000), &nodes[0], scid_aliases.clone());
844
845                 // If we don't have any sufficient-value peers connected we should get all hints with
846                 // sufficient value, even though there is a connected insufficient-value peer.
847                 scid_aliases.insert(chan_b.0.short_channel_id_alias.unwrap());
848                 nodes[0].node.peer_disconnected(&nodes[1].node.get_our_node_id());
849                 match_invoice_routes(Some(1_000_000_000), &nodes[0], scid_aliases);
850         }
851
852         #[test]
853         fn test_forwarding_info_not_assigned_channel_excluded_from_hints() {
854                 let chanmon_cfgs = create_chanmon_cfgs(3);
855                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
856                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
857                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
858                 let chan_1_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 100000, 10001);
859
860                 // Create an unannonced channel between `nodes[2]` and `nodes[0]`, for which the
861                 // `msgs::ChannelUpdate` is never handled for the node(s). As the `msgs::ChannelUpdate`
862                 // is never handled, the `channel.counterparty.forwarding_info` is never assigned.
863                 let mut private_chan_cfg = UserConfig::default();
864                 private_chan_cfg.channel_handshake_config.announced_channel = false;
865                 let temporary_channel_id = nodes[2].node.create_channel(nodes[0].node.get_our_node_id(), 1_000_000, 500_000_000, 42, Some(private_chan_cfg)).unwrap();
866                 let open_channel = get_event_msg!(nodes[2], MessageSendEvent::SendOpenChannel, nodes[0].node.get_our_node_id());
867                 nodes[0].node.handle_open_channel(&nodes[2].node.get_our_node_id(), &open_channel);
868                 let accept_channel = get_event_msg!(nodes[0], MessageSendEvent::SendAcceptChannel, nodes[2].node.get_our_node_id());
869                 nodes[2].node.handle_accept_channel(&nodes[0].node.get_our_node_id(), &accept_channel);
870
871                 let tx = sign_funding_transaction(&nodes[2], &nodes[0], 1_000_000, temporary_channel_id);
872
873                 let conf_height = core::cmp::max(nodes[2].best_block_info().1 + 1, nodes[0].best_block_info().1 + 1);
874                 confirm_transaction_at(&nodes[2], &tx, conf_height);
875                 connect_blocks(&nodes[2], CHAN_CONFIRM_DEPTH - 1);
876                 confirm_transaction_at(&nodes[0], &tx, conf_height);
877                 connect_blocks(&nodes[0], CHAN_CONFIRM_DEPTH - 1);
878                 let as_channel_ready = get_event_msg!(nodes[2], MessageSendEvent::SendChannelReady, nodes[0].node.get_our_node_id());
879                 nodes[2].node.handle_channel_ready(&nodes[0].node.get_our_node_id(), &get_event_msg!(nodes[0], MessageSendEvent::SendChannelReady, nodes[2].node.get_our_node_id()));
880                 get_event_msg!(nodes[2], MessageSendEvent::SendChannelUpdate, nodes[0].node.get_our_node_id());
881                 nodes[0].node.handle_channel_ready(&nodes[2].node.get_our_node_id(), &as_channel_ready);
882                 get_event_msg!(nodes[0], MessageSendEvent::SendChannelUpdate, nodes[2].node.get_our_node_id());
883                 expect_channel_ready_event(&nodes[0], &nodes[2].node.get_our_node_id());
884                 expect_channel_ready_event(&nodes[2], &nodes[0].node.get_our_node_id());
885
886                 // As `msgs::ChannelUpdate` was never handled for the participating node(s) of the second
887                 // channel, the channel will never be assigned any `counterparty.forwarding_info`.
888                 // Therefore only `chan_1_0` should be included in the hints.
889                 let mut scid_aliases = HashSet::new();
890                 scid_aliases.insert(chan_1_0.0.short_channel_id_alias.unwrap());
891                 match_invoice_routes(Some(5000), &nodes[0], scid_aliases);
892         }
893
894         #[test]
895         fn test_no_hints_if_a_mix_between_public_and_private_channel_exists() {
896                 let chanmon_cfgs = create_chanmon_cfgs(3);
897                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
898                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
899                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
900                 let _chan_1_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 100000, 10001);
901
902                 let chan_2_0 = create_announced_chan_between_nodes_with_value(&nodes, 2, 0, 100000, 10001);
903                 nodes[2].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_2_0.1);
904                 nodes[0].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &chan_2_0.0);
905
906                 // Ensure that the invoice doesn't include any route hints for any of `nodes[0]` channels,
907                 // even though all channels between `nodes[1]` and `nodes[0]` are private, as there is a
908                 // public channel between `nodes[2]` and `nodes[0]`
909                 match_invoice_routes(Some(5000), &nodes[0], HashSet::new());
910         }
911
912         #[test]
913         fn test_only_public_channels_includes_no_channels_in_hints() {
914                 let chanmon_cfgs = create_chanmon_cfgs(3);
915                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
916                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
917                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
918                 let chan_1_0 = create_announced_chan_between_nodes_with_value(&nodes, 1, 0, 100000, 10001);
919                 nodes[0].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &chan_1_0.0);
920                 nodes[1].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_1_0.1);
921
922                 let chan_2_0 = create_announced_chan_between_nodes_with_value(&nodes, 2, 0, 100000, 10001);
923                 nodes[2].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_2_0.1);
924                 nodes[0].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &chan_2_0.0);
925
926                 // As all of `nodes[0]` channels are public, no channels should be included in the hints
927                 match_invoice_routes(Some(5000), &nodes[0], HashSet::new());
928         }
929
930         #[test]
931         fn test_channels_with_lower_inbound_capacity_than_invoice_amt_hints_filtering() {
932                 let chanmon_cfgs = create_chanmon_cfgs(3);
933                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
934                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
935                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
936                 let chan_1_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 0, 100_000, 0);
937                 let chan_2_0 = create_unannounced_chan_between_nodes_with_value(&nodes, 2, 0, 1_000_000, 0);
938
939                 // As the invoice amt is 1 msat above chan_1_0's inbound capacity, it shouldn't be included
940                 let mut scid_aliases_99_000_001_msat = HashSet::new();
941                 scid_aliases_99_000_001_msat.insert(chan_2_0.0.short_channel_id_alias.unwrap());
942
943                 match_invoice_routes(Some(99_000_001), &nodes[0], scid_aliases_99_000_001_msat);
944
945                 // As the invoice amt is exactly at chan_1_0's inbound capacity, it should be included
946                 let mut scid_aliases_99_000_000_msat = HashSet::new();
947                 scid_aliases_99_000_000_msat.insert(chan_1_0.0.short_channel_id_alias.unwrap());
948                 scid_aliases_99_000_000_msat.insert(chan_2_0.0.short_channel_id_alias.unwrap());
949
950                 match_invoice_routes(Some(99_000_000), &nodes[0], scid_aliases_99_000_000_msat);
951
952                 // As the invoice amt is above all channels' inbound capacity, they will still be included
953                 let mut scid_aliases_2_000_000_000_msat = HashSet::new();
954                 scid_aliases_2_000_000_000_msat.insert(chan_1_0.0.short_channel_id_alias.unwrap());
955                 scid_aliases_2_000_000_000_msat.insert(chan_2_0.0.short_channel_id_alias.unwrap());
956
957                 match_invoice_routes(Some(2_000_000_000), &nodes[0], scid_aliases_2_000_000_000_msat);
958
959                 // An invoice with no specified amount should include all channels in the route hints.
960                 let mut scid_aliases_no_specified_amount = HashSet::new();
961                 scid_aliases_no_specified_amount.insert(chan_1_0.0.short_channel_id_alias.unwrap());
962                 scid_aliases_no_specified_amount.insert(chan_2_0.0.short_channel_id_alias.unwrap());
963
964                 match_invoice_routes(None, &nodes[0], scid_aliases_no_specified_amount);
965         }
966
967         fn match_invoice_routes<'a, 'b: 'a, 'c: 'b>(
968                 invoice_amt: Option<u64>,
969                 invoice_node: &Node<'a, 'b, 'c>,
970                 mut chan_ids_to_match: HashSet<u64>
971         ) {
972                 let invoice = create_invoice_from_channelmanager_and_duration_since_epoch(
973                         invoice_node.node, invoice_node.keys_manager, invoice_node.logger,
974                         Currency::BitcoinTestnet, invoice_amt, "test".to_string(), Duration::from_secs(1234567),
975                         3600, None).unwrap();
976                 let hints = invoice.private_routes();
977
978                 for hint in hints {
979                         let hint_short_chan_id = (hint.0).0[0].short_channel_id;
980                         assert!(chan_ids_to_match.remove(&hint_short_chan_id));
981                 }
982                 assert!(chan_ids_to_match.is_empty(), "Unmatched short channel ids: {:?}", chan_ids_to_match);
983         }
984
985         #[test]
986         #[cfg(feature = "std")]
987         fn test_multi_node_receive() {
988                 do_test_multi_node_receive(true);
989                 do_test_multi_node_receive(false);
990         }
991
992         #[cfg(feature = "std")]
993         fn do_test_multi_node_receive(user_generated_pmt_hash: bool) {
994                 let mut chanmon_cfgs = create_chanmon_cfgs(3);
995                 let seed_1 = [42u8; 32];
996                 let seed_2 = [43u8; 32];
997                 let cross_node_seed = [44u8; 32];
998                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
999                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1000                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1001                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1002                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1003                 let chan_0_1 = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001);
1004                 nodes[0].node.handle_channel_update(&nodes[1].node.get_our_node_id(), &chan_0_1.1);
1005                 nodes[1].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_0_1.0);
1006                 let chan_0_2 = create_announced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1007                 nodes[0].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &chan_0_2.1);
1008                 nodes[2].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_0_2.0);
1009
1010                 let payment_amt = 10_000;
1011                 let route_hints = vec![
1012                         nodes[1].node.get_phantom_route_hints(),
1013                         nodes[2].node.get_phantom_route_hints(),
1014                 ];
1015
1016                 let user_payment_preimage = PaymentPreimage([1; 32]);
1017                 let payment_hash = if user_generated_pmt_hash {
1018                         Some(PaymentHash(Sha256::hash(&user_payment_preimage.0[..]).into_inner()))
1019                 } else {
1020                         None
1021                 };
1022                 let non_default_invoice_expiry_secs = 4200;
1023
1024                 let invoice =
1025                         crate::utils::create_phantom_invoice::<&test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestLogger>(
1026                                 Some(payment_amt), payment_hash, "test".to_string(), non_default_invoice_expiry_secs,
1027                                 route_hints, nodes[1].keys_manager, nodes[1].keys_manager, nodes[1].logger,
1028                                 Currency::BitcoinTestnet, None, Duration::from_secs(1234567)
1029                         ).unwrap();
1030                 let (payment_hash, payment_secret) = (PaymentHash(invoice.payment_hash().into_inner()), *invoice.payment_secret());
1031                 let payment_preimage = if user_generated_pmt_hash {
1032                         user_payment_preimage
1033                 } else {
1034                         nodes[1].node.get_payment_preimage(payment_hash, payment_secret).unwrap()
1035                 };
1036
1037                 assert_eq!(invoice.min_final_cltv_expiry_delta(), MIN_FINAL_CLTV_EXPIRY_DELTA as u64);
1038                 assert_eq!(invoice.description(), InvoiceDescription::Direct(&Description("test".to_string())));
1039                 assert_eq!(invoice.route_hints().len(), 2);
1040                 assert_eq!(invoice.expiry_time(), Duration::from_secs(non_default_invoice_expiry_secs.into()));
1041                 assert!(!invoice.features().unwrap().supports_basic_mpp());
1042
1043                 let payment_params = PaymentParameters::from_node_id(invoice.recover_payee_pub_key(),
1044                                 invoice.min_final_cltv_expiry_delta() as u32)
1045                         .with_features(invoice.features().unwrap().clone())
1046                         .with_route_hints(invoice.route_hints());
1047                 let params = RouteParameters {
1048                         payment_params,
1049                         final_value_msat: invoice.amount_milli_satoshis().unwrap(),
1050                 };
1051                 let first_hops = nodes[0].node.list_usable_channels();
1052                 let network_graph = &node_cfgs[0].network_graph;
1053                 let logger = test_utils::TestLogger::new();
1054                 let scorer = test_utils::TestScorer::new();
1055                 let random_seed_bytes = chanmon_cfgs[1].keys_manager.get_secure_random_bytes();
1056                 let route = find_route(
1057                         &nodes[0].node.get_our_node_id(), &params, network_graph,
1058                         Some(&first_hops.iter().collect::<Vec<_>>()), &logger, &scorer, &random_seed_bytes
1059                 ).unwrap();
1060                 let (payment_event, fwd_idx) = {
1061                         let mut payment_hash = PaymentHash([0; 32]);
1062                         payment_hash.0.copy_from_slice(&invoice.payment_hash().as_ref()[0..32]);
1063                         nodes[0].node.send_payment(&route, payment_hash, &Some(*invoice.payment_secret()), PaymentId(payment_hash.0)).unwrap();
1064                         let mut added_monitors = nodes[0].chain_monitor.added_monitors.lock().unwrap();
1065                         assert_eq!(added_monitors.len(), 1);
1066                         added_monitors.clear();
1067
1068                         let mut events = nodes[0].node.get_and_clear_pending_msg_events();
1069                         assert_eq!(events.len(), 1);
1070                         let fwd_idx = match events[0] {
1071                                 MessageSendEvent::UpdateHTLCs { node_id, .. } => {
1072                                         if node_id == nodes[1].node.get_our_node_id() {
1073                                                 1
1074                                         } else { 2 }
1075                                 },
1076                                 _ => panic!("Unexpected event")
1077                         };
1078                         (SendEvent::from_event(events.remove(0)), fwd_idx)
1079                 };
1080                 nodes[fwd_idx].node.handle_update_add_htlc(&nodes[0].node.get_our_node_id(), &payment_event.msgs[0]);
1081                 commitment_signed_dance!(nodes[fwd_idx], nodes[0], &payment_event.commitment_msg, false, true);
1082
1083                 // Note that we have to "forward pending HTLCs" twice before we see the PaymentClaimable as
1084                 // this "emulates" the payment taking two hops, providing some privacy to make phantom node
1085                 // payments "look real" by taking more time.
1086                 expect_pending_htlcs_forwardable_ignore!(nodes[fwd_idx]);
1087                 nodes[fwd_idx].node.process_pending_htlc_forwards();
1088                 expect_pending_htlcs_forwardable_ignore!(nodes[fwd_idx]);
1089                 nodes[fwd_idx].node.process_pending_htlc_forwards();
1090
1091                 let payment_preimage_opt = if user_generated_pmt_hash { None } else { Some(payment_preimage) };
1092                 expect_payment_claimable!(&nodes[fwd_idx], payment_hash, payment_secret, payment_amt, payment_preimage_opt, route.paths[0].last().unwrap().pubkey);
1093                 do_claim_payment_along_route(&nodes[0], &[&vec!(&nodes[fwd_idx])[..]], false, payment_preimage);
1094                 let events = nodes[0].node.get_and_clear_pending_events();
1095                 assert_eq!(events.len(), 2);
1096                 match events[0] {
1097                         Event::PaymentSent { payment_preimage: ref ev_preimage, payment_hash: ref ev_hash, ref fee_paid_msat, .. } => {
1098                                 assert_eq!(payment_preimage, *ev_preimage);
1099                                 assert_eq!(payment_hash, *ev_hash);
1100                                 assert_eq!(fee_paid_msat, &Some(0));
1101                         },
1102                         _ => panic!("Unexpected event")
1103                 }
1104                 match events[1] {
1105                         Event::PaymentPathSuccessful { payment_hash: hash, .. } => {
1106                                 assert_eq!(hash, Some(payment_hash));
1107                         },
1108                         _ => panic!("Unexpected event")
1109                 }
1110         }
1111
1112         #[test]
1113         #[cfg(feature = "std")]
1114         fn test_multi_node_hints_has_htlc_min_max_values() {
1115                 let mut chanmon_cfgs = create_chanmon_cfgs(3);
1116                 let seed_1 = [42u8; 32];
1117                 let seed_2 = [43u8; 32];
1118                 let cross_node_seed = [44u8; 32];
1119                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1120                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1121                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1122                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1123                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1124
1125                 create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001);
1126                 create_unannounced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1127
1128                 let payment_amt = 20_000;
1129                 let (payment_hash, _payment_secret) = nodes[1].node.create_inbound_payment(Some(payment_amt), 3600, None).unwrap();
1130                 let route_hints = vec![
1131                         nodes[1].node.get_phantom_route_hints(),
1132                         nodes[2].node.get_phantom_route_hints(),
1133                 ];
1134
1135                 let invoice = crate::utils::create_phantom_invoice::<&test_utils::TestKeysInterface,
1136                         &test_utils::TestKeysInterface, &test_utils::TestLogger>(Some(payment_amt), Some(payment_hash),
1137                                 "test".to_string(), 3600, route_hints, nodes[1].keys_manager, nodes[1].keys_manager,
1138                                 nodes[1].logger, Currency::BitcoinTestnet, None, Duration::from_secs(1234567)).unwrap();
1139
1140                 let chan_0_1 = &nodes[1].node.list_usable_channels()[0];
1141                 assert_eq!(invoice.route_hints()[0].0[0].htlc_minimum_msat, chan_0_1.inbound_htlc_minimum_msat);
1142                 assert_eq!(invoice.route_hints()[0].0[0].htlc_maximum_msat, chan_0_1.inbound_htlc_maximum_msat);
1143
1144                 let chan_0_2 = &nodes[2].node.list_usable_channels()[0];
1145                 assert_eq!(invoice.route_hints()[1].0[0].htlc_minimum_msat, chan_0_2.inbound_htlc_minimum_msat);
1146                 assert_eq!(invoice.route_hints()[1].0[0].htlc_maximum_msat, chan_0_2.inbound_htlc_maximum_msat);
1147         }
1148
1149         #[test]
1150         #[cfg(feature = "std")]
1151         fn create_phantom_invoice_with_description_hash() {
1152                 let chanmon_cfgs = create_chanmon_cfgs(3);
1153                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1154                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1155                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1156
1157                 let payment_amt = 20_000;
1158                 let route_hints = vec![
1159                         nodes[1].node.get_phantom_route_hints(),
1160                         nodes[2].node.get_phantom_route_hints(),
1161                 ];
1162
1163                 let description_hash = crate::Sha256(Hash::hash("Description hash phantom invoice".as_bytes()));
1164                 let non_default_invoice_expiry_secs = 4200;
1165                 let invoice = crate::utils::create_phantom_invoice_with_description_hash::<
1166                         &test_utils::TestKeysInterface, &test_utils::TestKeysInterface, &test_utils::TestLogger,
1167                 >(
1168                         Some(payment_amt), None, non_default_invoice_expiry_secs, description_hash,
1169                         route_hints, nodes[1].keys_manager, nodes[1].keys_manager, nodes[1].logger,
1170                         Currency::BitcoinTestnet, None, Duration::from_secs(1234567),
1171                 )
1172                 .unwrap();
1173                 assert_eq!(invoice.amount_pico_btc(), Some(200_000));
1174                 assert_eq!(invoice.min_final_cltv_expiry_delta(), MIN_FINAL_CLTV_EXPIRY_DELTA as u64);
1175                 assert_eq!(invoice.expiry_time(), Duration::from_secs(non_default_invoice_expiry_secs.into()));
1176                 assert_eq!(invoice.description(), InvoiceDescription::Hash(&crate::Sha256(Sha256::hash("Description hash phantom invoice".as_bytes()))));
1177         }
1178
1179         #[test]
1180         #[cfg(feature = "std")]
1181         fn create_phantom_invoice_with_custom_payment_hash_and_custom_min_final_cltv_delta() {
1182                 let chanmon_cfgs = create_chanmon_cfgs(3);
1183                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1184                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1185                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1186
1187                 let payment_amt = 20_000;
1188                 let route_hints = vec![
1189                         nodes[1].node.get_phantom_route_hints(),
1190                         nodes[2].node.get_phantom_route_hints(),
1191                 ];
1192                 let user_payment_preimage = PaymentPreimage([1; 32]);
1193                 let payment_hash = Some(PaymentHash(Sha256::hash(&user_payment_preimage.0[..]).into_inner()));
1194                 let non_default_invoice_expiry_secs = 4200;
1195                 let min_final_cltv_expiry_delta = Some(100);
1196                 let duration_since_epoch = Duration::from_secs(1234567);
1197                 let invoice = crate::utils::create_phantom_invoice::<&test_utils::TestKeysInterface,
1198                         &test_utils::TestKeysInterface, &test_utils::TestLogger>(Some(payment_amt), payment_hash,
1199                                 "".to_string(), non_default_invoice_expiry_secs, route_hints, nodes[1].keys_manager, nodes[1].keys_manager,
1200                                 nodes[1].logger, Currency::BitcoinTestnet, min_final_cltv_expiry_delta, duration_since_epoch).unwrap();
1201                 assert_eq!(invoice.amount_pico_btc(), Some(200_000));
1202                 assert_eq!(invoice.min_final_cltv_expiry_delta(), (min_final_cltv_expiry_delta.unwrap() + 3) as u64);
1203                 assert_eq!(invoice.expiry_time(), Duration::from_secs(non_default_invoice_expiry_secs.into()));
1204         }
1205
1206         #[test]
1207         #[cfg(feature = "std")]
1208         fn test_multi_node_hints_includes_single_channels_to_participating_nodes() {
1209                 let mut chanmon_cfgs = create_chanmon_cfgs(3);
1210                 let seed_1 = [42u8; 32];
1211                 let seed_2 = [43u8; 32];
1212                 let cross_node_seed = [44u8; 32];
1213                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1214                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1215                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1216                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1217                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1218
1219                 let chan_0_1 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001);
1220                 let chan_0_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1221
1222                 let mut scid_aliases = HashSet::new();
1223                 scid_aliases.insert(chan_0_1.0.short_channel_id_alias.unwrap());
1224                 scid_aliases.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1225
1226                 match_multi_node_invoice_routes(
1227                         Some(10_000),
1228                         &nodes[1],
1229                         vec![&nodes[1], &nodes[2],],
1230                         scid_aliases,
1231                         false
1232                 );
1233         }
1234
1235         #[test]
1236         #[cfg(feature = "std")]
1237         fn test_multi_node_hints_includes_one_channel_of_each_counterparty_nodes_per_participating_node() {
1238                 let mut chanmon_cfgs = create_chanmon_cfgs(4);
1239                 let seed_1 = [42u8; 32];
1240                 let seed_2 = [43u8; 32];
1241                 let cross_node_seed = [44u8; 32];
1242                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1243                 chanmon_cfgs[3].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1244                 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
1245                 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
1246                 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
1247
1248                 let chan_0_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1249                 let chan_0_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 3, 1000000, 10001);
1250                 let chan_1_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 3, 3_000_000, 10005);
1251
1252                 let mut scid_aliases = HashSet::new();
1253                 scid_aliases.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1254                 scid_aliases.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1255                 scid_aliases.insert(chan_1_3.0.short_channel_id_alias.unwrap());
1256
1257                 match_multi_node_invoice_routes(
1258                         Some(10_000),
1259                         &nodes[2],
1260                         vec![&nodes[2], &nodes[3],],
1261                         scid_aliases,
1262                         false
1263                 );
1264         }
1265
1266         #[test]
1267         #[cfg(feature = "std")]
1268         fn test_multi_node_forwarding_info_not_assigned_channel_excluded_from_hints() {
1269                 let mut chanmon_cfgs = create_chanmon_cfgs(4);
1270                 let seed_1 = [42u8; 32];
1271                 let seed_2 = [43u8; 32];
1272                 let cross_node_seed = [44u8; 32];
1273                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1274                 chanmon_cfgs[3].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1275                 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
1276                 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
1277                 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
1278
1279                 let chan_0_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1280                 let chan_0_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 3, 1000000, 10001);
1281
1282                 // Create an unannonced channel between `nodes[1]` and `nodes[3]`, for which the
1283                 // `msgs::ChannelUpdate` is never handled for the node(s). As the `msgs::ChannelUpdate`
1284                 // is never handled, the `channel.counterparty.forwarding_info` is never assigned.
1285                 let mut private_chan_cfg = UserConfig::default();
1286                 private_chan_cfg.channel_handshake_config.announced_channel = false;
1287                 let temporary_channel_id = nodes[1].node.create_channel(nodes[3].node.get_our_node_id(), 1_000_000, 500_000_000, 42, Some(private_chan_cfg)).unwrap();
1288                 let open_channel = get_event_msg!(nodes[1], MessageSendEvent::SendOpenChannel, nodes[3].node.get_our_node_id());
1289                 nodes[3].node.handle_open_channel(&nodes[1].node.get_our_node_id(), &open_channel);
1290                 let accept_channel = get_event_msg!(nodes[3], MessageSendEvent::SendAcceptChannel, nodes[1].node.get_our_node_id());
1291                 nodes[1].node.handle_accept_channel(&nodes[3].node.get_our_node_id(), &accept_channel);
1292
1293                 let tx = sign_funding_transaction(&nodes[1], &nodes[3], 1_000_000, temporary_channel_id);
1294
1295                 let conf_height = core::cmp::max(nodes[1].best_block_info().1 + 1, nodes[3].best_block_info().1 + 1);
1296                 confirm_transaction_at(&nodes[1], &tx, conf_height);
1297                 connect_blocks(&nodes[1], CHAN_CONFIRM_DEPTH - 1);
1298                 confirm_transaction_at(&nodes[3], &tx, conf_height);
1299                 connect_blocks(&nodes[3], CHAN_CONFIRM_DEPTH - 1);
1300                 let as_channel_ready = get_event_msg!(nodes[1], MessageSendEvent::SendChannelReady, nodes[3].node.get_our_node_id());
1301                 nodes[1].node.handle_channel_ready(&nodes[3].node.get_our_node_id(), &get_event_msg!(nodes[3], MessageSendEvent::SendChannelReady, nodes[1].node.get_our_node_id()));
1302                 get_event_msg!(nodes[1], MessageSendEvent::SendChannelUpdate, nodes[3].node.get_our_node_id());
1303                 nodes[3].node.handle_channel_ready(&nodes[1].node.get_our_node_id(), &as_channel_ready);
1304                 get_event_msg!(nodes[3], MessageSendEvent::SendChannelUpdate, nodes[1].node.get_our_node_id());
1305                 expect_channel_ready_event(&nodes[1], &nodes[3].node.get_our_node_id());
1306                 expect_channel_ready_event(&nodes[3], &nodes[1].node.get_our_node_id());
1307
1308                 // As `msgs::ChannelUpdate` was never handled for the participating node(s) of the third
1309                 // channel, the channel will never be assigned any `counterparty.forwarding_info`.
1310                 // Therefore only `chan_0_3` should be included in the hints for `nodes[3]`.
1311                 let mut scid_aliases = HashSet::new();
1312                 scid_aliases.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1313                 scid_aliases.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1314
1315                 match_multi_node_invoice_routes(
1316                         Some(10_000),
1317                         &nodes[2],
1318                         vec![&nodes[2], &nodes[3],],
1319                         scid_aliases,
1320                         false
1321                 );
1322         }
1323
1324         #[test]
1325         #[cfg(feature = "std")]
1326         fn test_multi_node_with_only_public_channels_hints_includes_only_phantom_route() {
1327                 let mut chanmon_cfgs = create_chanmon_cfgs(3);
1328                 let seed_1 = [42u8; 32];
1329                 let seed_2 = [43u8; 32];
1330                 let cross_node_seed = [44u8; 32];
1331                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1332                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1333                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1334                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1335                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1336
1337                 let chan_0_1 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 10001);
1338
1339                 let chan_2_0 = create_announced_chan_between_nodes_with_value(&nodes, 2, 0, 100000, 10001);
1340                 nodes[2].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_2_0.1);
1341                 nodes[0].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &chan_2_0.0);
1342
1343                 // Hints should include `chan_0_1` from as `nodes[1]` only have private channels, but not
1344                 // `chan_0_2` as `nodes[2]` only has public channels.
1345                 let mut scid_aliases = HashSet::new();
1346                 scid_aliases.insert(chan_0_1.0.short_channel_id_alias.unwrap());
1347
1348                 match_multi_node_invoice_routes(
1349                         Some(10_000),
1350                         &nodes[1],
1351                         vec![&nodes[1], &nodes[2],],
1352                         scid_aliases,
1353                         true
1354                 );
1355         }
1356
1357         #[test]
1358         #[cfg(feature = "std")]
1359         fn test_multi_node_with_mixed_public_and_private_channel_hints_includes_only_phantom_route() {
1360                 let mut chanmon_cfgs = create_chanmon_cfgs(4);
1361                 let seed_1 = [42u8; 32];
1362                 let seed_2 = [43u8; 32];
1363                 let cross_node_seed = [44u8; 32];
1364                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1365                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1366                 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
1367                 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
1368                 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
1369
1370                 let chan_0_2 = create_announced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1371                 nodes[0].node.handle_channel_update(&nodes[2].node.get_our_node_id(), &chan_0_2.1);
1372                 nodes[2].node.handle_channel_update(&nodes[0].node.get_our_node_id(), &chan_0_2.0);
1373                 let _chan_1_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 2, 100000, 10001);
1374
1375                 let chan_0_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 3, 100000, 10001);
1376
1377                 // Hints should include `chan_0_3` from as `nodes[3]` only have private channels, and no
1378                 // channels for `nodes[2]` as it contains a mix of public and private channels.
1379                 let mut scid_aliases = HashSet::new();
1380                 scid_aliases.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1381
1382                 match_multi_node_invoice_routes(
1383                         Some(10_000),
1384                         &nodes[2],
1385                         vec![&nodes[2], &nodes[3],],
1386                         scid_aliases,
1387                         true
1388                 );
1389         }
1390
1391         #[test]
1392         #[cfg(feature = "std")]
1393         fn test_multi_node_hints_has_only_highest_inbound_capacity_channel() {
1394                 let mut chanmon_cfgs = create_chanmon_cfgs(3);
1395                 let seed_1 = [42u8; 32];
1396                 let seed_2 = [43u8; 32];
1397                 let cross_node_seed = [44u8; 32];
1398                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1399                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1400                 let node_cfgs = create_node_cfgs(3, &chanmon_cfgs);
1401                 let node_chanmgrs = create_node_chanmgrs(3, &node_cfgs, &[None, None, None]);
1402                 let nodes = create_network(3, &node_cfgs, &node_chanmgrs);
1403
1404                 let _chan_0_1_low_inbound_capacity = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 100_000, 0);
1405                 let chan_0_1_high_inbound_capacity = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 10_000_000, 0);
1406                 let _chan_0_1_medium_inbound_capacity = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 1, 1_000_000, 0);
1407                 let chan_0_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 2, 100000, 10001);
1408
1409                 let mut scid_aliases = HashSet::new();
1410                 scid_aliases.insert(chan_0_1_high_inbound_capacity.0.short_channel_id_alias.unwrap());
1411                 scid_aliases.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1412
1413                 match_multi_node_invoice_routes(
1414                         Some(10_000),
1415                         &nodes[1],
1416                         vec![&nodes[1], &nodes[2],],
1417                         scid_aliases,
1418                         false
1419                 );
1420         }
1421
1422         #[test]
1423         #[cfg(feature = "std")]
1424         fn test_multi_node_channels_inbound_capacity_lower_than_invoice_amt_filtering() {
1425                 let mut chanmon_cfgs = create_chanmon_cfgs(4);
1426                 let seed_1 = [42u8; 32];
1427                 let seed_2 = [43u8; 32];
1428                 let cross_node_seed = [44u8; 32];
1429                 chanmon_cfgs[1].keys_manager.backing = PhantomKeysManager::new(&seed_1, 43, 44, &cross_node_seed);
1430                 chanmon_cfgs[2].keys_manager.backing = PhantomKeysManager::new(&seed_2, 43, 44, &cross_node_seed);
1431                 let node_cfgs = create_node_cfgs(4, &chanmon_cfgs);
1432                 let node_chanmgrs = create_node_chanmgrs(4, &node_cfgs, &[None, None, None, None]);
1433                 let nodes = create_network(4, &node_cfgs, &node_chanmgrs);
1434
1435                 let chan_0_2 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 2, 1_000_000, 0);
1436                 let chan_0_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 0, 3, 100_000, 0);
1437                 let chan_1_3 = create_unannounced_chan_between_nodes_with_value(&nodes, 1, 3, 200_000, 0);
1438
1439                 // Since the invoice 1 msat above chan_0_3's inbound capacity, it should be filtered out.
1440                 let mut scid_aliases_99_000_001_msat = HashSet::new();
1441                 scid_aliases_99_000_001_msat.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1442                 scid_aliases_99_000_001_msat.insert(chan_1_3.0.short_channel_id_alias.unwrap());
1443
1444                 match_multi_node_invoice_routes(
1445                         Some(99_000_001),
1446                         &nodes[2],
1447                         vec![&nodes[2], &nodes[3],],
1448                         scid_aliases_99_000_001_msat,
1449                         false
1450                 );
1451
1452                 // Since the invoice is exactly at chan_0_3's inbound capacity, it should be included.
1453                 let mut scid_aliases_99_000_000_msat = HashSet::new();
1454                 scid_aliases_99_000_000_msat.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1455                 scid_aliases_99_000_000_msat.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1456                 scid_aliases_99_000_000_msat.insert(chan_1_3.0.short_channel_id_alias.unwrap());
1457
1458                 match_multi_node_invoice_routes(
1459                         Some(99_000_000),
1460                         &nodes[2],
1461                         vec![&nodes[2], &nodes[3],],
1462                         scid_aliases_99_000_000_msat,
1463                         false
1464                 );
1465
1466                 // Since the invoice is above all of `nodes[2]` channels' inbound capacity, all of
1467                 // `nodes[2]` them should be included.
1468                 let mut scid_aliases_300_000_000_msat = HashSet::new();
1469                 scid_aliases_300_000_000_msat.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1470                 scid_aliases_300_000_000_msat.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1471                 scid_aliases_300_000_000_msat.insert(chan_1_3.0.short_channel_id_alias.unwrap());
1472
1473                 match_multi_node_invoice_routes(
1474                         Some(300_000_000),
1475                         &nodes[2],
1476                         vec![&nodes[2], &nodes[3],],
1477                         scid_aliases_300_000_000_msat,
1478                         false
1479                 );
1480
1481                 // Since the no specified amount, all channels should included.
1482                 let mut scid_aliases_no_specified_amount = HashSet::new();
1483                 scid_aliases_no_specified_amount.insert(chan_0_2.0.short_channel_id_alias.unwrap());
1484                 scid_aliases_no_specified_amount.insert(chan_0_3.0.short_channel_id_alias.unwrap());
1485                 scid_aliases_no_specified_amount.insert(chan_1_3.0.short_channel_id_alias.unwrap());
1486
1487                 match_multi_node_invoice_routes(
1488                         None,
1489                         &nodes[2],
1490                         vec![&nodes[2], &nodes[3],],
1491                         scid_aliases_no_specified_amount,
1492                         false
1493                 );
1494         }
1495
1496         #[cfg(feature = "std")]
1497         fn match_multi_node_invoice_routes<'a, 'b: 'a, 'c: 'b>(
1498                 invoice_amt: Option<u64>,
1499                 invoice_node: &Node<'a, 'b, 'c>,
1500                 network_multi_nodes: Vec<&Node<'a, 'b, 'c>>,
1501                 mut chan_ids_to_match: HashSet<u64>,
1502                 nodes_contains_public_channels: bool
1503         ){
1504                 let phantom_route_hints = network_multi_nodes.iter()
1505                         .map(|node| node.node.get_phantom_route_hints())
1506                         .collect::<Vec<PhantomRouteHints>>();
1507                 let phantom_scids = phantom_route_hints.iter()
1508                         .map(|route_hint| route_hint.phantom_scid)
1509                         .collect::<HashSet<u64>>();
1510
1511                 let invoice = crate::utils::create_phantom_invoice::<&test_utils::TestKeysInterface,
1512                         &test_utils::TestKeysInterface, &test_utils::TestLogger>(invoice_amt, None, "test".to_string(),
1513                                 3600, phantom_route_hints, invoice_node.keys_manager, invoice_node.keys_manager,
1514                                 invoice_node.logger, Currency::BitcoinTestnet, None, Duration::from_secs(1234567)).unwrap();
1515
1516                 let invoice_hints = invoice.private_routes();
1517
1518                 for hint in invoice_hints {
1519                         let hints = &(hint.0).0;
1520                         match hints.len() {
1521                                 1 => {
1522                                         assert!(nodes_contains_public_channels);
1523                                         let phantom_scid = hints[0].short_channel_id;
1524                                         assert!(phantom_scids.contains(&phantom_scid));
1525                                 },
1526                                 2 => {
1527                                         let hint_short_chan_id = hints[0].short_channel_id;
1528                                         assert!(chan_ids_to_match.remove(&hint_short_chan_id));
1529                                         let phantom_scid = hints[1].short_channel_id;
1530                                         assert!(phantom_scids.contains(&phantom_scid));
1531                                 },
1532                                 _ => panic!("Incorrect hint length generated")
1533                         }
1534                 }
1535                 assert!(chan_ids_to_match.is_empty(), "Unmatched short channel ids: {:?}", chan_ids_to_match);
1536         }
1537
1538         #[test]
1539         fn test_create_invoice_fails_with_invalid_custom_min_final_cltv_expiry_delta() {
1540                 let chanmon_cfgs = create_chanmon_cfgs(2);
1541                 let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
1542                 let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
1543                 let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
1544                 let result = crate::utils::create_invoice_from_channelmanager_and_duration_since_epoch(
1545                         nodes[1].node, nodes[1].keys_manager, nodes[1].logger, Currency::BitcoinTestnet,
1546                         Some(10_000), "Some description".into(), Duration::from_secs(1234567), 3600, Some(MIN_FINAL_CLTV_EXPIRY_DELTA - 4),
1547                 );
1548                 match result {
1549                         Err(SignOrCreationError::CreationError(CreationError::MinFinalCltvExpiryDeltaTooShort)) => {},
1550                         _ => panic!(),
1551                 }
1552         }
1553 }