Split HTLC tracking into separate Inbound/Outbound types
[rust-lightning] / src / ln / channel.rs
1 use bitcoin::blockdata::block::BlockHeader;
2 use bitcoin::blockdata::script::{Script,Builder};
3 use bitcoin::blockdata::transaction::{TxIn, TxOut, Transaction, SigHashType};
4 use bitcoin::blockdata::opcodes;
5 use bitcoin::util::hash::{Sha256dHash, Hash160};
6 use bitcoin::util::bip143;
7 use bitcoin::network::serialize::BitcoinHash;
8
9 use secp256k1::key::{PublicKey,SecretKey};
10 use secp256k1::{Secp256k1,Message,Signature};
11 use secp256k1;
12
13 use crypto::digest::Digest;
14 use crypto::hkdf::{hkdf_extract,hkdf_expand};
15
16 use ln::msgs;
17 use ln::msgs::{ErrorAction, HandleError, MsgEncodable};
18 use ln::channelmonitor::ChannelMonitor;
19 use ln::channelmanager::{PendingHTLCStatus, PendingForwardHTLCInfo, HTLCFailReason, HTLCFailureMsg};
20 use ln::chan_utils::{TxCreationKeys,HTLCOutputInCommitment,HTLC_SUCCESS_TX_WEIGHT,HTLC_TIMEOUT_TX_WEIGHT};
21 use ln::chan_utils;
22 use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
23 use chain::transaction::OutPoint;
24 use util::{transaction_utils,rng};
25 use util::sha2::Sha256;
26 use util::logger::Logger;
27 use util::errors::APIError;
28
29 use std;
30 use std::default::Default;
31 use std::{cmp,mem};
32 use std::time::Instant;
33 use std::sync::{Arc};
34
35 pub struct ChannelKeys {
36         pub funding_key: SecretKey,
37         pub revocation_base_key: SecretKey,
38         pub payment_base_key: SecretKey,
39         pub delayed_payment_base_key: SecretKey,
40         pub htlc_base_key: SecretKey,
41         pub channel_close_key: SecretKey,
42         pub channel_monitor_claim_key: SecretKey,
43         pub commitment_seed: [u8; 32],
44 }
45
46 impl ChannelKeys {
47         pub fn new_from_seed(seed: &[u8; 32]) -> Result<ChannelKeys, secp256k1::Error> {
48                 let mut prk = [0; 32];
49                 hkdf_extract(Sha256::new(), b"rust-lightning key gen salt", seed, &mut prk);
50                 let secp_ctx = Secp256k1::without_caps();
51
52                 let mut okm = [0; 32];
53                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning funding key info", &mut okm);
54                 let funding_key = SecretKey::from_slice(&secp_ctx, &okm)?;
55
56                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning revocation base key info", &mut okm);
57                 let revocation_base_key = SecretKey::from_slice(&secp_ctx, &okm)?;
58
59                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning payment base key info", &mut okm);
60                 let payment_base_key = SecretKey::from_slice(&secp_ctx, &okm)?;
61
62                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning delayed payment base key info", &mut okm);
63                 let delayed_payment_base_key = SecretKey::from_slice(&secp_ctx, &okm)?;
64
65                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning htlc base key info", &mut okm);
66                 let htlc_base_key = SecretKey::from_slice(&secp_ctx, &okm)?;
67
68                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning channel close key info", &mut okm);
69                 let channel_close_key = SecretKey::from_slice(&secp_ctx, &okm)?;
70
71                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning channel monitor claim key info", &mut okm);
72                 let channel_monitor_claim_key = SecretKey::from_slice(&secp_ctx, &okm)?;
73
74                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning local commitment seed info", &mut okm);
75
76                 Ok(ChannelKeys {
77                         funding_key: funding_key,
78                         revocation_base_key: revocation_base_key,
79                         payment_base_key: payment_base_key,
80                         delayed_payment_base_key: delayed_payment_base_key,
81                         htlc_base_key: htlc_base_key,
82                         channel_close_key: channel_close_key,
83                         channel_monitor_claim_key: channel_monitor_claim_key,
84                         commitment_seed: okm
85                 })
86         }
87 }
88
89 #[derive(PartialEq)]
90 enum InboundHTLCState {
91         /// Added by remote, to be included in next local commitment tx.
92         RemoteAnnounced,
93         /// Included in a received commitment_signed message (implying we've revoke_and_ack'ed it), but
94         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
95         /// accept this HTLC. Implies AwaitingRemoteRevoke.
96         /// We also have not yet included this HTLC in a commitment_signed message, and are waiting on
97         /// a remote revoke_and_ack on a previous state before we can do so.
98         AwaitingRemoteRevokeToAnnounce,
99         /// Included in a received commitment_signed message (implying we've revoke_and_ack'ed it), but
100         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
101         /// accept this HTLC. Implies AwaitingRemoteRevoke.
102         /// We have included this HTLC in our latest commitment_signed and are now just waiting on a
103         /// revoke_and_ack.
104         AwaitingAnnouncedRemoteRevoke,
105         Committed,
106         /// Removed by us and a new commitment_signed was sent (if we were AwaitingRemoteRevoke when we
107         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
108         /// we'll drop it.
109         /// Note that we have to keep an eye on the HTLC until we've received a broadcastable
110         /// commitment transaction without it as otherwise we'll have to force-close the channel to
111         /// claim it before the timeout (obviously doesn't apply to revoked HTLCs that we can't claim
112         /// anyway). That said, ChannelMonitor does this for us (see
113         /// ChannelMonitor::would_broadcast_at_height) so we actually remove the HTLC from our own
114         /// local state before then, once we're sure that the next commitment_signed and
115         /// ChannelMonitor::provide_latest_local_commitment_tx_info will not include this HTLC.
116         LocalRemoved,
117 }
118
119 struct InboundHTLCOutput {
120         htlc_id: u64,
121         amount_msat: u64,
122         cltv_expiry: u32,
123         payment_hash: [u8; 32],
124         state: InboundHTLCState,
125         /// If we're in LocalRemoved, set to true if we fulfilled the HTLC, and can claim money
126         local_removed_fulfilled: bool,
127         /// state pre-Committed implies pending_forward_state, otherwise it must be None
128         pending_forward_state: Option<PendingHTLCStatus>,
129 }
130
131 #[derive(PartialEq)]
132 enum OutboundHTLCState {
133         /// Added by us and included in a commitment_signed (if we were AwaitingRemoteRevoke when we
134         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
135         /// we will promote to Committed (note that they may not accept it until the next time we
136         /// revoke, but we dont really care about that:
137         ///  * they've revoked, so worst case we can announce an old state and get our (option on)
138         ///    money back (though we wont), and,
139         ///  * we'll send them a revoke when they send a commitment_signed, and since only they're
140         ///    allowed to remove it, the "can only be removed once committed on both sides" requirement
141         ///    doesn't matter to us and its up to them to enforce it, worst-case they jump ahead but
142         ///    we'll never get out of sync).
143         LocalAnnounced,
144         Committed,
145         /// Remote removed this (outbound) HTLC. We're waiting on their commitment_signed to finalize
146         /// the change (though they'll need to revoke before we fail the payment).
147         RemoteRemoved,
148         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
149         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
150         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
151         /// We also have not yet removed this HTLC in a commitment_signed message, and are waiting on a
152         /// remote revoke_and_ack on a previous state before we can do so.
153         AwaitingRemoteRevokeToRemove,
154         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
155         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
156         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
157         /// We have removed this HTLC in our latest commitment_signed and are now just waiting on a
158         /// revoke_and_ack to drop completely.
159         AwaitingRemovedRemoteRevoke,
160 }
161
162 struct OutboundHTLCOutput {
163         htlc_id: u64,
164         amount_msat: u64,
165         cltv_expiry: u32,
166         payment_hash: [u8; 32],
167         state: OutboundHTLCState,
168         /// If we're in a removed state, set if they failed, otherwise None
169         fail_reason: Option<HTLCFailReason>,
170 }
171
172 macro_rules! get_htlc_in_commitment {
173         ($htlc: expr, $offered: expr) => {
174                 HTLCOutputInCommitment {
175                         offered: $offered,
176                         amount_msat: $htlc.amount_msat,
177                         cltv_expiry: $htlc.cltv_expiry,
178                         payment_hash: $htlc.payment_hash,
179                         transaction_output_index: 0
180                 }
181         }
182 }
183
184 /// See AwaitingRemoteRevoke ChannelState for more info
185 enum HTLCUpdateAwaitingACK {
186         AddHTLC {
187                 // always outbound
188                 amount_msat: u64,
189                 cltv_expiry: u32,
190                 payment_hash: [u8; 32],
191                 onion_routing_packet: msgs::OnionPacket,
192                 time_created: Instant, //TODO: Some kind of timeout thing-a-majig
193         },
194         ClaimHTLC {
195                 payment_preimage: [u8; 32],
196                 payment_hash: [u8; 32], // Only here for effecient duplicate detection
197         },
198         FailHTLC {
199                 payment_hash: [u8; 32],
200                 err_packet: msgs::OnionErrorPacket,
201         },
202 }
203
204 enum ChannelState {
205         /// Implies we have (or are prepared to) send our open_channel/accept_channel message
206         OurInitSent = (1 << 0),
207         /// Implies we have received their open_channel/accept_channel message
208         TheirInitSent = (1 << 1),
209         /// We have sent funding_created and are awaiting a funding_signed to advance to FundingSent.
210         /// Note that this is nonsense for an inbound channel as we immediately generate funding_signed
211         /// upon receipt of funding_created, so simply skip this state.
212         FundingCreated = 4,
213         /// Set when we have received/sent funding_created and funding_signed and are thus now waiting
214         /// on the funding transaction to confirm. The FundingLocked flags are set to indicate when we
215         /// and our counterparty consider the funding transaction confirmed.
216         FundingSent = 8,
217         /// Flag which can be set on FundingSent to indicate they sent us a funding_locked message.
218         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
219         TheirFundingLocked = (1 << 4),
220         /// Flag which can be set on FundingSent to indicate we sent them a funding_locked message.
221         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
222         OurFundingLocked = (1 << 5),
223         ChannelFunded = 64,
224         /// Flag which implies that we have sent a commitment_signed but are awaiting the responding
225         /// revoke_and_ack message. During this time period, we can't generate new commitment_signed
226         /// messages as then we will be unable to determine which HTLCs they included in their
227         /// revoke_and_ack implicit ACK, so instead we have to hold them away temporarily to be sent
228         /// later.
229         /// Flag is set on ChannelFunded.
230         AwaitingRemoteRevoke = (1 << 7),
231         /// Flag which is set on ChannelFunded or FundingSent after receiving a shutdown message from
232         /// the remote end. If set, they may not add any new HTLCs to the channel, and we are expected
233         /// to respond with our own shutdown message when possible.
234         RemoteShutdownSent = (1 << 8),
235         /// Flag which is set on ChannelFunded or FundingSent after sending a shutdown message. At this
236         /// point, we may not add any new HTLCs to the channel.
237         /// TODO: Investigate some kind of timeout mechanism by which point the remote end must provide
238         /// us their shutdown.
239         LocalShutdownSent = (1 << 9),
240         /// We've successfully negotiated a closing_signed dance. At this point ChannelManager is about
241         /// to drop us, but we store this anyway.
242         ShutdownComplete = (1 << 10),
243 }
244 const BOTH_SIDES_SHUTDOWN_MASK: u32 = (ChannelState::LocalShutdownSent as u32 | ChannelState::RemoteShutdownSent as u32);
245
246 // TODO: We should refactor this to be an Inbound/OutboundChannel until initial setup handshaking
247 // has been completed, and then turn into a Channel to get compiler-time enforcement of things like
248 // calling channel_id() before we're set up or things like get_outbound_funding_signed on an
249 // inbound channel.
250 pub struct Channel {
251         user_id: u64,
252
253         channel_id: [u8; 32],
254         channel_state: u32,
255         channel_outbound: bool,
256         secp_ctx: Secp256k1<secp256k1::All>,
257         announce_publicly: bool,
258         channel_value_satoshis: u64,
259
260         local_keys: ChannelKeys,
261
262         // Our commitment numbers start at 2^48-1 and count down, whereas the ones used in transaction
263         // generation start at 0 and count up...this simplifies some parts of implementation at the
264         // cost of others, but should really just be changed.
265
266         cur_local_commitment_transaction_number: u64,
267         cur_remote_commitment_transaction_number: u64,
268         value_to_self_msat: u64, // Excluding all pending_htlcs, excluding fees
269         pending_inbound_htlcs: Vec<InboundHTLCOutput>,
270         pending_outbound_htlcs: Vec<OutboundHTLCOutput>,
271         holding_cell_htlc_updates: Vec<HTLCUpdateAwaitingACK>,
272         next_local_htlc_id: u64,
273         next_remote_htlc_id: u64,
274         channel_update_count: u32,
275         feerate_per_kw: u64,
276
277         #[cfg(test)]
278         // Used in ChannelManager's tests to send a revoked transaction
279         pub last_local_commitment_txn: Vec<Transaction>,
280         #[cfg(not(test))]
281         last_local_commitment_txn: Vec<Transaction>,
282
283         last_sent_closing_fee: Option<(u64, u64)>, // (feerate, fee)
284
285         /// The hash of the block in which the funding transaction reached our CONF_TARGET. We use this
286         /// to detect unconfirmation after a serialize-unserialize roudtrip where we may not see a full
287         /// series of block_connected/block_disconnected calls. Obviously this is not a guarantee as we
288         /// could miss the funding_tx_confirmed_in block as well, but it serves as a useful fallback.
289         funding_tx_confirmed_in: Option<Sha256dHash>,
290         short_channel_id: Option<u64>,
291         /// Used to deduplicate block_connected callbacks
292         last_block_connected: Sha256dHash,
293         funding_tx_confirmations: u64,
294
295         their_dust_limit_satoshis: u64,
296         our_dust_limit_satoshis: u64,
297         their_max_htlc_value_in_flight_msat: u64,
298         //get_our_max_htlc_value_in_flight_msat(): u64,
299         their_channel_reserve_satoshis: u64,
300         //get_our_channel_reserve_satoshis(): u64,
301         their_htlc_minimum_msat: u64,
302         our_htlc_minimum_msat: u64,
303         their_to_self_delay: u16,
304         //implied by BREAKDOWN_TIMEOUT: our_to_self_delay: u16,
305         their_max_accepted_htlcs: u16,
306         //implied by OUR_MAX_HTLCS: our_max_accepted_htlcs: u16,
307
308         their_funding_pubkey: Option<PublicKey>,
309         their_revocation_basepoint: Option<PublicKey>,
310         their_payment_basepoint: Option<PublicKey>,
311         their_delayed_payment_basepoint: Option<PublicKey>,
312         their_htlc_basepoint: Option<PublicKey>,
313         their_cur_commitment_point: Option<PublicKey>,
314
315         their_prev_commitment_point: Option<PublicKey>,
316         their_node_id: PublicKey,
317
318         their_shutdown_scriptpubkey: Option<Script>,
319
320         channel_monitor: ChannelMonitor,
321
322         logger: Arc<Logger>,
323 }
324
325 const OUR_MAX_HTLCS: u16 = 5; //TODO
326 /// Confirmation count threshold at which we close a channel. Ideally we'd keep the channel around
327 /// on ice until the funding transaction gets more confirmations, but the LN protocol doesn't
328 /// really allow for this, so instead we're stuck closing it out at that point.
329 const UNCONF_THRESHOLD: u32 = 6;
330 /// The amount of time we require our counterparty wait to claim their money (ie time between when
331 /// we, or our watchtower, must check for them having broadcast a theft transaction).
332 const BREAKDOWN_TIMEOUT: u16 = 6 * 24 * 7; //TODO?
333 /// The amount of time we're willing to wait to claim money back to us
334 const MAX_LOCAL_BREAKDOWN_TIMEOUT: u16 = 6 * 24 * 14;
335 const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
336 const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
337 const SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT: u64 = 79; // prevout: 36, nSequence: 4, script len: 1, witness lengths: (3+1)/4, sig: 73/4, if-selector: 1, redeemScript: (6 ops + 2*33 pubkeys + 1*2 delay)/4
338 const B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT: u64 = 104; // prevout: 40, nSequence: 4, script len: 1, witness lengths: 3/4, sig: 73/4, pubkey: 33/4, output: 31 (TODO: Wrong? Useless?)
339 /// Maximmum `funding_satoshis` value, according to the BOLT #2 specification
340 /// it's 2^24.
341 pub const MAX_FUNDING_SATOSHIS: u64 = (1 << 24);
342
343 macro_rules! secp_call {
344         ( $res: expr, $err: expr, $chan_id: expr ) => {
345                 match $res {
346                         Ok(key) => key,
347                         Err(_) => return Err(HandleError {err: $err, action: Some(msgs::ErrorAction::SendErrorMessage {msg: msgs::ErrorMessage {channel_id: $chan_id, data: $err.to_string()}})})
348                 }
349         };
350 }
351
352 macro_rules! secp_derived_key {
353         ( $res: expr, $chan_id: expr ) => {
354                 secp_call!($res, "Derived invalid key, peer is maliciously selecting parameters", $chan_id)
355         }
356 }
357 impl Channel {
358         // Convert constants + channel value to limits:
359         fn get_our_max_htlc_value_in_flight_msat(channel_value_satoshis: u64) -> u64 {
360                 channel_value_satoshis * 1000 / 10 //TODO
361         }
362
363         /// Guaranteed to return a value no larger than channel_value_satoshis
364         fn get_our_channel_reserve_satoshis(channel_value_satoshis: u64) -> u64 {
365                 let (q, _) = channel_value_satoshis.overflowing_div(100);
366                 cmp::min(channel_value_satoshis, cmp::max(q, 1000)) //TODO
367         }
368
369         fn derive_our_dust_limit_satoshis(at_open_background_feerate: u64) -> u64 {
370                 at_open_background_feerate * B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT / 1000 //TODO
371         }
372
373         fn derive_our_htlc_minimum_msat(_at_open_channel_feerate_per_kw: u64) -> u64 {
374                 1000 // TODO
375         }
376
377         fn derive_minimum_depth(_channel_value_satoshis_msat: u64, _value_to_self_msat: u64) -> u32 {
378                 // Note that in order to comply with BOLT 7 announcement_signatures requirements this must
379                 // be at least 6.
380                 const CONF_TARGET: u32 = 12; //TODO: Should be much higher
381                 CONF_TARGET
382         }
383
384         fn derive_maximum_minimum_depth(_channel_value_satoshis_msat: u64, _value_to_self_msat: u64) -> u32 {
385                 const CONF_TARGET: u32 = 12; //TODO: Should be much higher
386                 CONF_TARGET * 2
387         }
388
389         // Constructors:
390         pub fn new_outbound(fee_estimator: &FeeEstimator, chan_keys: ChannelKeys, their_node_id: PublicKey, channel_value_satoshis: u64, push_msat: u64, announce_publicly: bool, user_id: u64, logger: Arc<Logger>) -> Result<Channel, APIError> {
391                 if channel_value_satoshis >= MAX_FUNDING_SATOSHIS {
392                         return Err(APIError::APIMisuseError{err: "funding value > 2^24"});
393                 }
394
395                 if push_msat > channel_value_satoshis * 1000 {
396                         return Err(APIError::APIMisuseError{err: "push value > channel value"});
397                 }
398
399
400                 let background_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
401                 if Channel::get_our_channel_reserve_satoshis(channel_value_satoshis) < Channel::derive_our_dust_limit_satoshis(background_feerate) {
402                         return Err(APIError::FeeRateTooHigh{err: format!("Not enough reserve above dust limit can be found at current fee rate({})", background_feerate), feerate: background_feerate});
403                 }
404
405                 let feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
406
407                 let secp_ctx = Secp256k1::new();
408                 let our_channel_monitor_claim_key_hash = Hash160::from_data(&PublicKey::from_secret_key(&secp_ctx, &chan_keys.channel_monitor_claim_key).serialize());
409                 let our_channel_monitor_claim_script = Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&our_channel_monitor_claim_key_hash[..]).into_script();
410                 let channel_monitor = ChannelMonitor::new(&chan_keys.revocation_base_key,
411                                                           &PublicKey::from_secret_key(&secp_ctx, &chan_keys.delayed_payment_base_key),
412                                                           &chan_keys.htlc_base_key,
413                                                           BREAKDOWN_TIMEOUT, our_channel_monitor_claim_script);
414
415                 Ok(Channel {
416                         user_id: user_id,
417
418                         channel_id: rng::rand_u832(),
419                         channel_state: ChannelState::OurInitSent as u32,
420                         channel_outbound: true,
421                         secp_ctx: secp_ctx,
422                         announce_publicly: announce_publicly,
423                         channel_value_satoshis: channel_value_satoshis,
424
425                         local_keys: chan_keys,
426                         cur_local_commitment_transaction_number: (1 << 48) - 1,
427                         cur_remote_commitment_transaction_number: (1 << 48) - 1,
428                         value_to_self_msat: channel_value_satoshis * 1000 - push_msat,
429                         pending_inbound_htlcs: Vec::new(),
430                         pending_outbound_htlcs: Vec::new(),
431                         holding_cell_htlc_updates: Vec::new(),
432                         next_local_htlc_id: 0,
433                         next_remote_htlc_id: 0,
434                         channel_update_count: 1,
435
436                         last_local_commitment_txn: Vec::new(),
437
438                         last_sent_closing_fee: None,
439
440                         funding_tx_confirmed_in: None,
441                         short_channel_id: None,
442                         last_block_connected: Default::default(),
443                         funding_tx_confirmations: 0,
444
445                         feerate_per_kw: feerate,
446                         their_dust_limit_satoshis: 0,
447                         our_dust_limit_satoshis: Channel::derive_our_dust_limit_satoshis(background_feerate),
448                         their_max_htlc_value_in_flight_msat: 0,
449                         their_channel_reserve_satoshis: 0,
450                         their_htlc_minimum_msat: 0,
451                         our_htlc_minimum_msat: Channel::derive_our_htlc_minimum_msat(feerate),
452                         their_to_self_delay: 0,
453                         their_max_accepted_htlcs: 0,
454
455                         their_funding_pubkey: None,
456                         their_revocation_basepoint: None,
457                         their_payment_basepoint: None,
458                         their_delayed_payment_basepoint: None,
459                         their_htlc_basepoint: None,
460                         their_cur_commitment_point: None,
461
462                         their_prev_commitment_point: None,
463                         their_node_id: their_node_id,
464
465                         their_shutdown_scriptpubkey: None,
466
467                         channel_monitor: channel_monitor,
468
469                         logger,
470                 })
471         }
472
473         fn check_remote_fee(fee_estimator: &FeeEstimator, feerate_per_kw: u32) -> Result<(), HandleError> {
474                 if (feerate_per_kw as u64) < fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background) {
475                         return Err(HandleError{err: "Peer's feerate much too low", action: Some(msgs::ErrorAction::DisconnectPeer{ msg: None })});
476                 }
477                 if (feerate_per_kw as u64) > fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority) * 2 {
478                         return Err(HandleError{err: "Peer's feerate much too high", action: Some(msgs::ErrorAction::DisconnectPeer{ msg: None })});
479                 }
480                 Ok(())
481         }
482
483         /// Creates a new channel from a remote sides' request for one.
484         /// Assumes chain_hash has already been checked and corresponds with what we expect!
485         /// Generally prefers to take the DisconnectPeer action on failure, as a notice to the sender
486         /// that we're rejecting the new channel.
487         pub fn new_from_req(fee_estimator: &FeeEstimator, chan_keys: ChannelKeys, their_node_id: PublicKey, msg: &msgs::OpenChannel, user_id: u64, require_announce: bool, allow_announce: bool, logger: Arc<Logger>) -> Result<Channel, HandleError> {
488                 macro_rules! return_error_message {
489                         ( $msg: expr ) => {
490                                 return Err(HandleError{err: $msg, action: Some(msgs::ErrorAction::SendErrorMessage{ msg: msgs::ErrorMessage { channel_id: msg.temporary_channel_id, data: $msg.to_string() }})});
491                         }
492                 }
493
494                 // Check sanity of message fields:
495                 if msg.funding_satoshis >= MAX_FUNDING_SATOSHIS {
496                         return_error_message!("funding value > 2^24");
497                 }
498                 if msg.channel_reserve_satoshis > msg.funding_satoshis {
499                         return_error_message!("Bogus channel_reserve_satoshis");
500                 }
501                 if msg.push_msat > (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
502                         return_error_message!("push_msat larger than funding value");
503                 }
504                 if msg.dust_limit_satoshis > msg.funding_satoshis {
505                         return_error_message!("Peer never wants payout outputs?");
506                 }
507                 if msg.dust_limit_satoshis > msg.channel_reserve_satoshis {
508                         return_error_message!("Bogus; channel reserve is less than dust limit");
509                 }
510                 if msg.htlc_minimum_msat >= (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
511                         return_error_message!("Miminum htlc value is full channel value");
512                 }
513                 Channel::check_remote_fee(fee_estimator, msg.feerate_per_kw).map_err(|e|
514                         HandleError{err: e.err, action: Some(msgs::ErrorAction::SendErrorMessage{ msg: msgs::ErrorMessage { channel_id: msg.temporary_channel_id, data: e.err.to_string() }})}
515                 )?;
516
517                 if msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
518                         return_error_message!("They wanted our payments to be delayed by a needlessly long period");
519                 }
520                 if msg.max_accepted_htlcs < 1 {
521                         return_error_message!("0 max_accpted_htlcs makes for a useless channel");
522                 }
523                 if msg.max_accepted_htlcs > 483 {
524                         return_error_message!("max_accpted_htlcs > 483");
525                 }
526
527                 // Convert things into internal flags and prep our state:
528
529                 let their_announce = if (msg.channel_flags & 1) == 1 { true } else { false };
530                 if require_announce && !their_announce {
531                         return_error_message!("Peer tried to open unannounced channel, but we require public ones");
532                 }
533                 if !allow_announce && their_announce {
534                         return_error_message!("Peer tried to open announced channel, but we require private ones");
535                 }
536
537                 let background_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
538
539                 let our_dust_limit_satoshis = Channel::derive_our_dust_limit_satoshis(background_feerate);
540                 let our_channel_reserve_satoshis = Channel::get_our_channel_reserve_satoshis(msg.funding_satoshis);
541                 if our_channel_reserve_satoshis < our_dust_limit_satoshis {
542                         return_error_message!("Suitalbe channel reserve not found. aborting");
543                 }
544                 if msg.channel_reserve_satoshis < our_dust_limit_satoshis {
545                         return_error_message!("channel_reserve_satoshis too small");
546                 }
547                 if our_channel_reserve_satoshis < msg.dust_limit_satoshis {
548                         return_error_message!("Dust limit too high for our channel reserve");
549                 }
550
551                 // check if the funder's amount for the initial commitment tx is sufficient
552                 // for full fee payment
553                 let funders_amount_msat = msg.funding_satoshis * 1000 - msg.push_msat;
554                 if funders_amount_msat < background_feerate * COMMITMENT_TX_BASE_WEIGHT {
555                         return_error_message!("Insufficient funding amount for initial commitment");
556                 }
557
558                 let to_local_msat = msg.push_msat;
559                 let to_remote_msat = funders_amount_msat - background_feerate * COMMITMENT_TX_BASE_WEIGHT;
560                 if to_local_msat <= msg.channel_reserve_satoshis * 1000 && to_remote_msat <= our_channel_reserve_satoshis * 1000 {
561                         return_error_message!("Insufficient funding amount for initial commitment");
562                 }
563
564                 let secp_ctx = Secp256k1::new();
565                 let our_channel_monitor_claim_key_hash = Hash160::from_data(&PublicKey::from_secret_key(&secp_ctx, &chan_keys.channel_monitor_claim_key).serialize());
566                 let our_channel_monitor_claim_script = Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&our_channel_monitor_claim_key_hash[..]).into_script();
567                 let mut channel_monitor = ChannelMonitor::new(&chan_keys.revocation_base_key,
568                                                               &PublicKey::from_secret_key(&secp_ctx, &chan_keys.delayed_payment_base_key),
569                                                               &chan_keys.htlc_base_key,
570                                                               BREAKDOWN_TIMEOUT, our_channel_monitor_claim_script);
571                 channel_monitor.set_their_htlc_base_key(&msg.htlc_basepoint);
572                 channel_monitor.set_their_to_self_delay(msg.to_self_delay);
573
574                 let mut chan = Channel {
575                         user_id: user_id,
576
577                         channel_id: msg.temporary_channel_id,
578                         channel_state: (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32),
579                         channel_outbound: false,
580                         secp_ctx: secp_ctx,
581                         announce_publicly: their_announce,
582
583                         local_keys: chan_keys,
584                         cur_local_commitment_transaction_number: (1 << 48) - 1,
585                         cur_remote_commitment_transaction_number: (1 << 48) - 1,
586                         value_to_self_msat: msg.push_msat,
587                         pending_inbound_htlcs: Vec::new(),
588                         pending_outbound_htlcs: Vec::new(),
589                         holding_cell_htlc_updates: Vec::new(),
590                         next_local_htlc_id: 0,
591                         next_remote_htlc_id: 0,
592                         channel_update_count: 1,
593
594                         last_local_commitment_txn: Vec::new(),
595
596                         last_sent_closing_fee: None,
597
598                         funding_tx_confirmed_in: None,
599                         short_channel_id: None,
600                         last_block_connected: Default::default(),
601                         funding_tx_confirmations: 0,
602
603                         feerate_per_kw: msg.feerate_per_kw as u64,
604                         channel_value_satoshis: msg.funding_satoshis,
605                         their_dust_limit_satoshis: msg.dust_limit_satoshis,
606                         our_dust_limit_satoshis: our_dust_limit_satoshis,
607                         their_max_htlc_value_in_flight_msat: cmp::min(msg.max_htlc_value_in_flight_msat, msg.funding_satoshis * 1000),
608                         their_channel_reserve_satoshis: msg.channel_reserve_satoshis,
609                         their_htlc_minimum_msat: msg.htlc_minimum_msat,
610                         our_htlc_minimum_msat: Channel::derive_our_htlc_minimum_msat(msg.feerate_per_kw as u64),
611                         their_to_self_delay: msg.to_self_delay,
612                         their_max_accepted_htlcs: msg.max_accepted_htlcs,
613
614                         their_funding_pubkey: Some(msg.funding_pubkey),
615                         their_revocation_basepoint: Some(msg.revocation_basepoint),
616                         their_payment_basepoint: Some(msg.payment_basepoint),
617                         their_delayed_payment_basepoint: Some(msg.delayed_payment_basepoint),
618                         their_htlc_basepoint: Some(msg.htlc_basepoint),
619                         their_cur_commitment_point: Some(msg.first_per_commitment_point),
620
621                         their_prev_commitment_point: None,
622                         their_node_id: their_node_id,
623
624                         their_shutdown_scriptpubkey: None,
625
626                         channel_monitor: channel_monitor,
627
628                         logger,
629                 };
630
631                 let obscure_factor = chan.get_commitment_transaction_number_obscure_factor();
632                 chan.channel_monitor.set_commitment_obscure_factor(obscure_factor);
633
634                 Ok(chan)
635         }
636
637         // Utilities to derive keys:
638
639         fn build_local_commitment_secret(&self, idx: u64) -> SecretKey {
640                 let res = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, idx);
641                 SecretKey::from_slice(&self.secp_ctx, &res).unwrap()
642         }
643
644         // Utilities to build transactions:
645
646         fn get_commitment_transaction_number_obscure_factor(&self) -> u64 {
647                 let mut sha = Sha256::new();
648                 let our_payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key);
649
650                 if self.channel_outbound {
651                         sha.input(&our_payment_basepoint.serialize());
652                         sha.input(&self.their_payment_basepoint.unwrap().serialize());
653                 } else {
654                         sha.input(&self.their_payment_basepoint.unwrap().serialize());
655                         sha.input(&our_payment_basepoint.serialize());
656                 }
657                 let mut res = [0; 32];
658                 sha.result(&mut res);
659
660                 ((res[26] as u64) << 5*8) |
661                 ((res[27] as u64) << 4*8) |
662                 ((res[28] as u64) << 3*8) |
663                 ((res[29] as u64) << 2*8) |
664                 ((res[30] as u64) << 1*8) |
665                 ((res[31] as u64) << 0*8)
666         }
667
668         /// Transaction nomenclature is somewhat confusing here as there are many different cases - a
669         /// transaction is referred to as "a's transaction" implying that a will be able to broadcast
670         /// the transaction. Thus, b will generally be sending a signature over such a transaction to
671         /// a, and a can revoke the transaction by providing b the relevant per_commitment_secret. As
672         /// such, a transaction is generally the result of b increasing the amount paid to a (or adding
673         /// an HTLC to a).
674         /// @local is used only to convert relevant internal structures which refer to remote vs local
675         /// to decide value of outputs and direction of HTLCs.
676         /// @generated_by_local is used to determine *which* HTLCs to include - noting that the HTLC
677         /// state may indicate that one peer has informed the other that they'd like to add an HTLC but
678         /// have not yet committed it. Such HTLCs will only be included in transactions which are being
679         /// generated by the peer which proposed adding the HTLCs, and thus we need to understand both
680         /// which peer generated this transaction and "to whom" this transaction flows.
681         #[inline]
682         fn build_commitment_transaction(&self, commitment_number: u64, keys: &TxCreationKeys, local: bool, generated_by_local: bool) -> (Transaction, Vec<HTLCOutputInCommitment>) {
683                 let obscured_commitment_transaction_number = self.get_commitment_transaction_number_obscure_factor() ^ (0xffffffffffff - commitment_number);
684
685                 let txins = {
686                         let mut ins: Vec<TxIn> = Vec::new();
687                         ins.push(TxIn {
688                                 previous_output: self.channel_monitor.get_funding_txo().unwrap().into_bitcoin_outpoint(),
689                                 script_sig: Script::new(),
690                                 sequence: ((0x80 as u32) << 8*3) | ((obscured_commitment_transaction_number >> 3*8) as u32),
691                                 witness: Vec::new(),
692                         });
693                         ins
694                 };
695
696                 let mut txouts: Vec<(TxOut, Option<HTLCOutputInCommitment>)> = Vec::with_capacity(self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len() + 2);
697
698                 let dust_limit_satoshis = if local { self.our_dust_limit_satoshis } else { self.their_dust_limit_satoshis };
699                 let mut remote_htlc_total_msat = 0;
700                 let mut local_htlc_total_msat = 0;
701                 let mut value_to_self_msat_offset = 0;
702
703                 macro_rules! add_htlc_output {
704                         ($htlc: expr, $outbound: expr) => {
705                                 if $outbound == local { // "offered HTLC output"
706                                         if $htlc.amount_msat / 1000 >= dust_limit_satoshis + (self.feerate_per_kw * HTLC_TIMEOUT_TX_WEIGHT / 1000) {
707                                                 let htlc_in_tx = get_htlc_in_commitment!($htlc, true);
708                                                 txouts.push((TxOut {
709                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys).to_v0_p2wsh(),
710                                                         value: $htlc.amount_msat / 1000
711                                                 }, Some(htlc_in_tx)));
712                                         }
713                                 } else {
714                                         if $htlc.amount_msat / 1000 >= dust_limit_satoshis + (self.feerate_per_kw * HTLC_SUCCESS_TX_WEIGHT / 1000) {
715                                                 let htlc_in_tx = get_htlc_in_commitment!($htlc, false);
716                                                 txouts.push((TxOut { // "received HTLC output"
717                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys).to_v0_p2wsh(),
718                                                         value: $htlc.amount_msat / 1000
719                                                 }, Some(htlc_in_tx)));
720                                         }
721                                 }
722                         }
723                 }
724
725                 for ref htlc in self.pending_inbound_htlcs.iter() {
726                         let include = match htlc.state {
727                                 InboundHTLCState::RemoteAnnounced => !generated_by_local,
728                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce => !generated_by_local,
729                                 InboundHTLCState::AwaitingAnnouncedRemoteRevoke => true,
730                                 InboundHTLCState::Committed => true,
731                                 InboundHTLCState::LocalRemoved => !generated_by_local,
732                         };
733
734                         if include {
735                                 add_htlc_output!(htlc, false);
736                                 remote_htlc_total_msat += htlc.amount_msat;
737                         } else {
738                                 match htlc.state {
739                                         InboundHTLCState::LocalRemoved => {
740                                                 if generated_by_local && htlc.local_removed_fulfilled {
741                                                         value_to_self_msat_offset += htlc.amount_msat as i64;
742                                                 }
743                                         },
744                                         _ => {},
745                                 }
746                         }
747                 }
748
749                 for ref htlc in self.pending_outbound_htlcs.iter() {
750                         let include = match htlc.state {
751                                 OutboundHTLCState::LocalAnnounced => generated_by_local,
752                                 OutboundHTLCState::Committed => true,
753                                 OutboundHTLCState::RemoteRemoved => generated_by_local,
754                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove => generated_by_local,
755                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke => false,
756                         };
757
758                         if include {
759                                 add_htlc_output!(htlc, true);
760                                 local_htlc_total_msat += htlc.amount_msat;
761                         } else {
762                                 match htlc.state {
763                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove|OutboundHTLCState::AwaitingRemovedRemoteRevoke => {
764                                                 if htlc.fail_reason.is_none() {
765                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
766                                                 }
767                                         },
768                                         OutboundHTLCState::RemoteRemoved => {
769                                                 if !generated_by_local && htlc.fail_reason.is_none() {
770                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
771                                                 }
772                                         },
773                                         _ => {},
774                                 }
775                         }
776                 }
777
778                 let total_fee: u64 = self.feerate_per_kw * (COMMITMENT_TX_BASE_WEIGHT + (txouts.len() as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
779                 let value_to_self: i64 = ((self.value_to_self_msat - local_htlc_total_msat) as i64 + value_to_self_msat_offset) / 1000 - if self.channel_outbound { total_fee as i64 } else { 0 };
780                 let value_to_remote: i64 = (((self.channel_value_satoshis * 1000 - self.value_to_self_msat - remote_htlc_total_msat) as i64 - value_to_self_msat_offset) / 1000) - if self.channel_outbound { 0 } else { total_fee as i64 };
781
782                 let value_to_a = if local { value_to_self } else { value_to_remote };
783                 let value_to_b = if local { value_to_remote } else { value_to_self };
784
785                 if value_to_a >= (dust_limit_satoshis as i64) {
786                         txouts.push((TxOut {
787                                 script_pubkey: chan_utils::get_revokeable_redeemscript(&keys.revocation_key,
788                                                                                        if local { self.their_to_self_delay } else { BREAKDOWN_TIMEOUT },
789                                                                                        &keys.a_delayed_payment_key).to_v0_p2wsh(),
790                                 value: value_to_a as u64
791                         }, None));
792                 }
793
794                 if value_to_b >= (dust_limit_satoshis as i64) {
795                         txouts.push((TxOut {
796                                 script_pubkey: Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0)
797                                                              .push_slice(&Hash160::from_data(&keys.b_payment_key.serialize())[..])
798                                                              .into_script(),
799                                 value: value_to_b as u64
800                         }, None));
801                 }
802
803                 transaction_utils::sort_outputs(&mut txouts);
804
805                 let mut outputs: Vec<TxOut> = Vec::with_capacity(txouts.len());
806                 let mut htlcs_used: Vec<HTLCOutputInCommitment> = Vec::with_capacity(txouts.len());
807                 for (idx, out) in txouts.drain(..).enumerate() {
808                         outputs.push(out.0);
809                         if let Some(out_htlc) = out.1 {
810                                 htlcs_used.push(out_htlc);
811                                 htlcs_used.last_mut().unwrap().transaction_output_index = idx as u32;
812                         }
813                 }
814
815                 (Transaction {
816                         version: 2,
817                         lock_time: ((0x20 as u32) << 8*3) | ((obscured_commitment_transaction_number & 0xffffffu64) as u32),
818                         input: txins,
819                         output: outputs,
820                 }, htlcs_used)
821         }
822
823         #[inline]
824         fn get_closing_scriptpubkey(&self) -> Script {
825                 let our_channel_close_key_hash = Hash160::from_data(&PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.channel_close_key).serialize());
826                 Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&our_channel_close_key_hash[..]).into_script()
827         }
828
829         #[inline]
830         fn get_closing_transaction_weight(a_scriptpubkey: &Script, b_scriptpubkey: &Script) -> u64 {
831                 (4 + 1 + 36 + 4 + 1 + 1 + 2*(8+1) + 4 + a_scriptpubkey.len() as u64 + b_scriptpubkey.len() as u64)*4 + 2 + 1 + 1 + 2*(1 + 72)
832         }
833
834         #[inline]
835         fn build_closing_transaction(&self, proposed_total_fee_satoshis: u64, skip_remote_output: bool) -> (Transaction, u64) {
836                 let txins = {
837                         let mut ins: Vec<TxIn> = Vec::new();
838                         ins.push(TxIn {
839                                 previous_output: self.channel_monitor.get_funding_txo().unwrap().into_bitcoin_outpoint(),
840                                 script_sig: Script::new(),
841                                 sequence: 0xffffffff,
842                                 witness: Vec::new(),
843                         });
844                         ins
845                 };
846
847                 assert!(self.pending_inbound_htlcs.is_empty());
848                 assert!(self.pending_outbound_htlcs.is_empty());
849                 let mut txouts: Vec<(TxOut, ())> = Vec::new();
850
851                 let mut total_fee_satoshis = proposed_total_fee_satoshis;
852                 let value_to_self: i64 = (self.value_to_self_msat as i64) / 1000 - if self.channel_outbound { total_fee_satoshis as i64 } else { 0 };
853                 let value_to_remote: i64 = ((self.channel_value_satoshis * 1000 - self.value_to_self_msat) as i64 / 1000) - if self.channel_outbound { 0 } else { total_fee_satoshis as i64 };
854
855                 if value_to_self < 0 {
856                         assert!(self.channel_outbound);
857                         total_fee_satoshis += (-value_to_self) as u64;
858                 } else if value_to_remote < 0 {
859                         assert!(!self.channel_outbound);
860                         total_fee_satoshis += (-value_to_remote) as u64;
861                 }
862
863                 if !skip_remote_output && value_to_remote as u64 > self.our_dust_limit_satoshis {
864                         txouts.push((TxOut {
865                                 script_pubkey: self.their_shutdown_scriptpubkey.clone().unwrap(),
866                                 value: value_to_remote as u64
867                         }, ()));
868                 }
869
870                 if value_to_self as u64 > self.our_dust_limit_satoshis {
871                         txouts.push((TxOut {
872                                 script_pubkey: self.get_closing_scriptpubkey(),
873                                 value: value_to_self as u64
874                         }, ()));
875                 }
876
877                 transaction_utils::sort_outputs(&mut txouts);
878
879                 let mut outputs: Vec<TxOut> = Vec::new();
880                 for out in txouts.drain(..) {
881                         outputs.push(out.0);
882                 }
883
884                 (Transaction {
885                         version: 2,
886                         lock_time: 0,
887                         input: txins,
888                         output: outputs,
889                 }, total_fee_satoshis)
890         }
891
892         #[inline]
893         /// Creates a set of keys for build_commitment_transaction to generate a transaction which our
894         /// counterparty will sign (ie DO NOT send signatures over a transaction created by this to
895         /// our counterparty!)
896         /// The result is a transaction which we can revoke ownership of (ie a "local" transaction)
897         /// TODO Some magic rust shit to compile-time check this?
898         fn build_local_transaction_keys(&self, commitment_number: u64) -> Result<TxCreationKeys, HandleError> {
899                 let per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(commitment_number));
900                 let delayed_payment_base = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key);
901                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key);
902
903                 Ok(secp_derived_key!(TxCreationKeys::new(&self.secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &self.their_revocation_basepoint.unwrap(), &self.their_payment_basepoint.unwrap(), &self.their_htlc_basepoint.unwrap()), self.channel_id()))
904         }
905
906         #[inline]
907         /// Creates a set of keys for build_commitment_transaction to generate a transaction which we
908         /// will sign and send to our counterparty.
909         fn build_remote_transaction_keys(&self) -> Result<TxCreationKeys, HandleError> {
910                 //TODO: Ensure that the payment_key derived here ends up in the library users' wallet as we
911                 //may see payments to it!
912                 let payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key);
913                 let revocation_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key);
914                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key);
915
916                 Ok(secp_derived_key!(TxCreationKeys::new(&self.secp_ctx, &self.their_cur_commitment_point.unwrap(), &self.their_delayed_payment_basepoint.unwrap(), &self.their_htlc_basepoint.unwrap(), &revocation_basepoint, &payment_basepoint, &htlc_basepoint), self.channel_id()))
917         }
918
919         /// Gets the redeemscript for the funding transaction output (ie the funding transaction output
920         /// pays to get_funding_redeemscript().to_v0_p2wsh()).
921         /// Panics if called before accept_channel/new_from_req
922         pub fn get_funding_redeemscript(&self) -> Script {
923                 let builder = Builder::new().push_opcode(opcodes::All::OP_PUSHNUM_2);
924                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).serialize();
925                 let their_funding_key = self.their_funding_pubkey.expect("get_funding_redeemscript only allowed after accept_channel").serialize();
926                 if our_funding_key[..] < their_funding_key[..] {
927                         builder.push_slice(&our_funding_key)
928                                 .push_slice(&their_funding_key)
929                 } else {
930                         builder.push_slice(&their_funding_key)
931                                 .push_slice(&our_funding_key)
932                 }.push_opcode(opcodes::All::OP_PUSHNUM_2).push_opcode(opcodes::All::OP_CHECKMULTISIG).into_script()
933         }
934
935         fn sign_commitment_transaction(&self, tx: &mut Transaction, their_sig: &Signature) -> Signature {
936                 if tx.input.len() != 1 {
937                         panic!("Tried to sign commitment transaction that had input count != 1!");
938                 }
939                 if tx.input[0].witness.len() != 0 {
940                         panic!("Tried to re-sign commitment transaction");
941                 }
942
943                 let funding_redeemscript = self.get_funding_redeemscript();
944
945                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&tx).sighash_all(&tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
946                 let our_sig = self.secp_ctx.sign(&sighash, &self.local_keys.funding_key);
947
948                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
949
950                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).serialize();
951                 let their_funding_key = self.their_funding_pubkey.unwrap().serialize();
952                 if our_funding_key[..] < their_funding_key[..] {
953                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
954                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
955                 } else {
956                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
957                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
958                 }
959                 tx.input[0].witness[1].push(SigHashType::All as u8);
960                 tx.input[0].witness[2].push(SigHashType::All as u8);
961
962                 tx.input[0].witness.push(funding_redeemscript.into_bytes());
963
964                 our_sig
965         }
966
967         /// Builds the htlc-success or htlc-timeout transaction which spends a given HTLC output
968         /// @local is used only to convert relevant internal structures which refer to remote vs local
969         /// to decide value of outputs and direction of HTLCs.
970         fn build_htlc_transaction(&self, prev_hash: &Sha256dHash, htlc: &HTLCOutputInCommitment, local: bool, keys: &TxCreationKeys) -> Transaction {
971                 chan_utils::build_htlc_transaction(prev_hash, self.feerate_per_kw, if local { self.their_to_self_delay } else { BREAKDOWN_TIMEOUT }, htlc, &keys.a_delayed_payment_key, &keys.revocation_key)
972         }
973
974         fn create_htlc_tx_signature(&self, tx: &Transaction, htlc: &HTLCOutputInCommitment, keys: &TxCreationKeys) -> Result<(Script, Signature, bool), HandleError> {
975                 if tx.input.len() != 1 {
976                         panic!("Tried to sign HTLC transaction that had input count != 1!");
977                 }
978
979                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys);
980
981                 let our_htlc_key = secp_derived_key!(chan_utils::derive_private_key(&self.secp_ctx, &keys.per_commitment_point, &self.local_keys.htlc_base_key), self.channel_id());
982                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&tx).sighash_all(&tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
983                 let is_local_tx = PublicKey::from_secret_key(&self.secp_ctx, &our_htlc_key) == keys.a_htlc_key;
984                 Ok((htlc_redeemscript, self.secp_ctx.sign(&sighash, &our_htlc_key), is_local_tx))
985         }
986
987         /// Signs a transaction created by build_htlc_transaction. If the transaction is an
988         /// HTLC-Success transaction (ie htlc.offered is false), preimate must be set!
989         fn sign_htlc_transaction(&self, tx: &mut Transaction, their_sig: &Signature, preimage: &Option<[u8; 32]>, htlc: &HTLCOutputInCommitment, keys: &TxCreationKeys) -> Result<Signature, HandleError> {
990                 if tx.input.len() != 1 {
991                         panic!("Tried to sign HTLC transaction that had input count != 1!");
992                 }
993                 if tx.input[0].witness.len() != 0 {
994                         panic!("Tried to re-sign HTLC transaction");
995                 }
996
997                 let (htlc_redeemscript, our_sig, local_tx) = self.create_htlc_tx_signature(tx, htlc, keys)?;
998
999                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
1000
1001                 if local_tx { // b, then a
1002                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
1003                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
1004                 } else {
1005                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
1006                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
1007                 }
1008                 tx.input[0].witness[1].push(SigHashType::All as u8);
1009                 tx.input[0].witness[2].push(SigHashType::All as u8);
1010
1011                 if htlc.offered {
1012                         tx.input[0].witness.push(Vec::new());
1013                 } else {
1014                         tx.input[0].witness.push(preimage.unwrap().to_vec());
1015                 }
1016
1017                 tx.input[0].witness.push(htlc_redeemscript.into_bytes());
1018
1019                 Ok(our_sig)
1020         }
1021
1022         fn get_update_fulfill_htlc(&mut self, payment_preimage_arg: [u8; 32]) -> Result<(Option<msgs::UpdateFulfillHTLC>, Option<ChannelMonitor>), HandleError> {
1023                 // Either ChannelFunded got set (which means it wont bet unset) or there is no way any
1024                 // caller thought we could have something claimed (cause we wouldn't have accepted in an
1025                 // incoming HTLC anyway). If we got to ShutdownComplete, callers aren't allowed to call us,
1026                 // either.
1027                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1028                         panic!("Was asked to fulfill an HTLC when channel was not in an operational state");
1029                 }
1030                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1031
1032                 let mut sha = Sha256::new();
1033                 sha.input(&payment_preimage_arg);
1034                 let mut payment_hash_calc = [0; 32];
1035                 sha.result(&mut payment_hash_calc);
1036
1037                 let mut pending_idx = std::usize::MAX;
1038                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1039                         if htlc.payment_hash == payment_hash_calc &&
1040                                         htlc.state != InboundHTLCState::LocalRemoved {
1041                                 if let Some(PendingHTLCStatus::Fail(_)) = htlc.pending_forward_state {
1042                                 } else {
1043                                         if pending_idx != std::usize::MAX {
1044                                                 panic!("Duplicate HTLC payment_hash, ChannelManager should have prevented this!");
1045                                         }
1046                                         pending_idx = idx;
1047                                 }
1048                         }
1049                 }
1050                 if pending_idx == std::usize::MAX {
1051                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given payment preimage", action: None});
1052                 }
1053
1054                 // Now update local state:
1055                 //
1056                 // We have to put the payment_preimage in the channel_monitor right away here to ensure we
1057                 // can claim it even if the channel hits the chain before we see their next commitment.
1058                 self.channel_monitor.provide_payment_preimage(&payment_hash_calc, &payment_preimage_arg);
1059
1060                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
1061                         for pending_update in self.holding_cell_htlc_updates.iter() {
1062                                 match pending_update {
1063                                         &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, .. } => {
1064                                                 if payment_preimage_arg == *payment_preimage {
1065                                                         return Ok((None, None));
1066                                                 }
1067                                         },
1068                                         &HTLCUpdateAwaitingACK::FailHTLC { ref payment_hash, .. } => {
1069                                                 if payment_hash_calc == *payment_hash {
1070                                                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given payment preimage", action: None});
1071                                                 }
1072                                         },
1073                                         _ => {}
1074                                 }
1075                         }
1076                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::ClaimHTLC {
1077                                 payment_preimage: payment_preimage_arg, payment_hash: payment_hash_calc,
1078                         });
1079                         return Ok((None, Some(self.channel_monitor.clone())));
1080                 }
1081
1082                 let htlc_id = {
1083                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1084                         if htlc.state == InboundHTLCState::Committed {
1085                                 htlc.state = InboundHTLCState::LocalRemoved;
1086                                 htlc.local_removed_fulfilled = true;
1087                         } else if htlc.state == InboundHTLCState::RemoteAnnounced || htlc.state == InboundHTLCState::AwaitingRemoteRevokeToAnnounce || htlc.state == InboundHTLCState::AwaitingAnnouncedRemoteRevoke {
1088                                 // Theoretically we can hit this if we get the preimage on an HTLC prior to us
1089                                 // having forwarded it to anyone. This implies that the sender is busted as someone
1090                                 // else knows the preimage, but handling this case and implementing the logic to
1091                                 // take their money would be a lot of (never-tested) code to handle a case that
1092                                 // hopefully never happens. Instead, we make sure we get the preimage into the
1093                                 // channel_monitor and pretend we didn't just see the preimage.
1094                                 return Ok((None, Some(self.channel_monitor.clone())));
1095                         } else {
1096                                 // LocalRemoved handled in the search loop
1097                                 panic!("Have an inbound HTLC when not awaiting remote revoke that had a garbage state");
1098                         }
1099                         htlc.htlc_id
1100                 };
1101
1102                 Ok((Some(msgs::UpdateFulfillHTLC {
1103                         channel_id: self.channel_id(),
1104                         htlc_id: htlc_id,
1105                         payment_preimage: payment_preimage_arg,
1106                 }), Some(self.channel_monitor.clone())))
1107         }
1108
1109         pub fn get_update_fulfill_htlc_and_commit(&mut self, payment_preimage: [u8; 32]) -> Result<(Option<(msgs::UpdateFulfillHTLC, msgs::CommitmentSigned)>, Option<ChannelMonitor>), HandleError> {
1110                 match self.get_update_fulfill_htlc(payment_preimage)? {
1111                         (Some(update_fulfill_htlc), _) => {
1112                                 let (commitment, monitor_update) = self.send_commitment_no_status_check()?;
1113                                 Ok((Some((update_fulfill_htlc, commitment)), Some(monitor_update)))
1114                         },
1115                         (None, Some(channel_monitor)) => Ok((None, Some(channel_monitor))),
1116                         (None, None) => Ok((None, None))
1117                 }
1118         }
1119
1120         pub fn get_update_fail_htlc(&mut self, payment_hash_arg: &[u8; 32], err_packet: msgs::OnionErrorPacket) -> Result<Option<msgs::UpdateFailHTLC>, HandleError> {
1121                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1122                         panic!("Was asked to fail an HTLC when channel was not in an operational state");
1123                 }
1124                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1125
1126                 // Now update local state:
1127                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
1128                         for pending_update in self.holding_cell_htlc_updates.iter() {
1129                                 match pending_update {
1130                                         &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_hash, .. } => {
1131                                                 if *payment_hash_arg == *payment_hash {
1132                                                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given payment preimage", action: None});
1133                                                 }
1134                                         },
1135                                         &HTLCUpdateAwaitingACK::FailHTLC { ref payment_hash, .. } => {
1136                                                 if *payment_hash_arg == *payment_hash {
1137                                                         return Ok(None);
1138                                                 }
1139                                         },
1140                                         _ => {}
1141                                 }
1142                         }
1143                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::FailHTLC {
1144                                 payment_hash: payment_hash_arg.clone(),
1145                                 err_packet,
1146                         });
1147                         return Ok(None);
1148                 }
1149
1150                 let mut htlc_id = 0;
1151                 let mut htlc_amount_msat = 0;
1152                 for htlc in self.pending_inbound_htlcs.iter_mut() {
1153                         if htlc.payment_hash == *payment_hash_arg {
1154                                 if htlc.state == InboundHTLCState::Committed {
1155                                         htlc.state = InboundHTLCState::LocalRemoved;
1156                                 } else if htlc.state == InboundHTLCState::RemoteAnnounced {
1157                                         if let Some(PendingHTLCStatus::Forward(_)) = htlc.pending_forward_state {
1158                                                 panic!("Somehow forwarded HTLC prior to remote revocation!");
1159                                         } else {
1160                                                 // We have to pretend this isn't here - we're probably a duplicate with the
1161                                                 // same payment_hash as some other HTLC, and the other is getting failed,
1162                                                 // we'll fail this one as soon as remote commits to it.
1163                                                 continue;
1164                                         }
1165                                 } else if htlc.state == InboundHTLCState::LocalRemoved {
1166                                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given payment preimage", action: None});
1167                                 } else {
1168                                         panic!("Have an inbound HTLC when not awaiting remote revoke that had a garbage state");
1169                                 }
1170                                 if htlc_id != 0 {
1171                                         panic!("Duplicate HTLC payment_hash, you probably re-used payment preimages, NEVER DO THIS!");
1172                                 }
1173                                 htlc_id = htlc.htlc_id;
1174                                 htlc_amount_msat += htlc.amount_msat;
1175                         }
1176                 }
1177                 if htlc_amount_msat == 0 {
1178                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given payment preimage", action: None});
1179                 }
1180
1181                 Ok(Some(msgs::UpdateFailHTLC {
1182                         channel_id: self.channel_id(),
1183                         htlc_id,
1184                         reason: err_packet
1185                 }))
1186         }
1187
1188         pub fn get_update_fail_htlc_and_commit(&mut self, payment_hash: &[u8; 32], err_packet: msgs::OnionErrorPacket) -> Result<Option<(msgs::UpdateFailHTLC, msgs::CommitmentSigned, ChannelMonitor)>, HandleError> {
1189                 match self.get_update_fail_htlc(payment_hash, err_packet)? {
1190                         Some(update_fail_htlc) => {
1191                                 let (commitment, monitor_update) = self.send_commitment_no_status_check()?;
1192                                 Ok(Some((update_fail_htlc, commitment, monitor_update)))
1193                         },
1194                         None => Ok(None)
1195                 }
1196         }
1197
1198         // Message handlers:
1199
1200         pub fn accept_channel(&mut self, msg: &msgs::AcceptChannel) -> Result<(), HandleError> {
1201                 macro_rules! return_error_message {
1202                         ( $msg: expr ) => {
1203                                 return Err(HandleError{err: $msg, action: Some(msgs::ErrorAction::SendErrorMessage{ msg: msgs::ErrorMessage { channel_id: msg.temporary_channel_id, data: $msg.to_string() }})});
1204                         }
1205                 }
1206                 // Check sanity of message fields:
1207                 if !self.channel_outbound {
1208                         return_error_message!("Got an accept_channel message from an inbound peer");
1209                 }
1210                 if self.channel_state != ChannelState::OurInitSent as u32 {
1211                         return_error_message!("Got an accept_channel message at a strange time");
1212                 }
1213                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
1214                         return_error_message!("Peer never wants payout outputs?");
1215                 }
1216                 if msg.channel_reserve_satoshis > self.channel_value_satoshis {
1217                         return_error_message!("Bogus channel_reserve_satoshis");
1218                 }
1219                 if msg.dust_limit_satoshis > msg.channel_reserve_satoshis {
1220                         return_error_message!("Bogus channel_reserve and dust_limit");
1221                 }
1222                 if msg.channel_reserve_satoshis < self.our_dust_limit_satoshis {
1223                         return_error_message!("Peer never wants payout outputs?");
1224                 }
1225                 if msg.dust_limit_satoshis > Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis) {
1226                         return_error_message!("Dust limit is bigger than our channel reverse");
1227                 }
1228                 if msg.htlc_minimum_msat >= (self.channel_value_satoshis - msg.channel_reserve_satoshis) * 1000 {
1229                         return_error_message!("Minimum htlc value is full channel value");
1230                 }
1231                 if msg.minimum_depth > Channel::derive_maximum_minimum_depth(self.channel_value_satoshis*1000,  self.value_to_self_msat) {
1232                         return_error_message!("minimum_depth too large");
1233                 }
1234                 if msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
1235                         return_error_message!("They wanted our payments to be delayed by a needlessly long period");
1236                 }
1237                 if msg.max_accepted_htlcs < 1 {
1238                         return_error_message!("0 max_accpted_htlcs makes for a useless channel");
1239                 }
1240                 if msg.max_accepted_htlcs > 483 {
1241                         return_error_message!("max_accpted_htlcs > 483");
1242                 }
1243
1244                 // TODO: Optional additional constraints mentioned in the spec
1245                 // MAY fail the channel if
1246                 // funding_satoshi is too small
1247                 // htlc_minimum_msat too large
1248                 // max_htlc_value_in_flight_msat too small
1249                 // channel_reserve_satoshis too large
1250                 // max_accepted_htlcs too small
1251                 // dust_limit_satoshis too small
1252
1253                 self.channel_monitor.set_their_htlc_base_key(&msg.htlc_basepoint);
1254
1255                 self.their_dust_limit_satoshis = msg.dust_limit_satoshis;
1256                 self.their_max_htlc_value_in_flight_msat = cmp::min(msg.max_htlc_value_in_flight_msat, self.channel_value_satoshis * 1000);
1257                 self.their_channel_reserve_satoshis = msg.channel_reserve_satoshis;
1258                 self.their_htlc_minimum_msat = msg.htlc_minimum_msat;
1259                 self.their_to_self_delay = msg.to_self_delay;
1260                 self.their_max_accepted_htlcs = msg.max_accepted_htlcs;
1261                 self.their_funding_pubkey = Some(msg.funding_pubkey);
1262                 self.their_revocation_basepoint = Some(msg.revocation_basepoint);
1263                 self.their_payment_basepoint = Some(msg.payment_basepoint);
1264                 self.their_delayed_payment_basepoint = Some(msg.delayed_payment_basepoint);
1265                 self.their_htlc_basepoint = Some(msg.htlc_basepoint);
1266                 self.their_cur_commitment_point = Some(msg.first_per_commitment_point);
1267
1268                 let obscure_factor = self.get_commitment_transaction_number_obscure_factor();
1269                 self.channel_monitor.set_commitment_obscure_factor(obscure_factor);
1270                 self.channel_monitor.set_their_to_self_delay(msg.to_self_delay);
1271
1272                 self.channel_state = ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32;
1273
1274                 Ok(())
1275         }
1276
1277         fn funding_created_signature(&mut self, sig: &Signature) -> Result<(Transaction, Signature), HandleError> {
1278                 let funding_script = self.get_funding_redeemscript();
1279
1280                 let remote_keys = self.build_remote_transaction_keys()?;
1281                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false).0;
1282                 let remote_sighash = Message::from_slice(&bip143::SighashComponents::new(&remote_initial_commitment_tx).sighash_all(&remote_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1283
1284                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1285                 let local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false).0;
1286                 let local_sighash = Message::from_slice(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1287
1288                 // They sign the "local" commitment transaction, allowing us to broadcast the tx if we wish.
1289                 secp_call!(self.secp_ctx.verify(&local_sighash, &sig, &self.their_funding_pubkey.unwrap()), "Invalid funding_created signature from peer", self.channel_id());
1290
1291                 // We sign the "remote" commitment transaction, allowing them to broadcast the tx if they wish.
1292                 Ok((remote_initial_commitment_tx, self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key)))
1293         }
1294
1295         pub fn funding_created(&mut self, msg: &msgs::FundingCreated) -> Result<(msgs::FundingSigned, ChannelMonitor), HandleError> {
1296                 if self.channel_outbound {
1297                         return Err(HandleError{err: "Received funding_created for an outbound channel?", action: Some(msgs::ErrorAction::SendErrorMessage {msg: msgs::ErrorMessage {channel_id: self.channel_id, data: "Received funding_created for an outbound channel?".to_string()}})});
1298                 }
1299                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
1300                         // BOLT 2 says that if we disconnect before we send funding_signed we SHOULD NOT
1301                         // remember the channel, so its safe to just send an error_message here and drop the
1302                         // channel.
1303                         return Err(HandleError{err: "Received funding_created after we got the channel!", action: Some(msgs::ErrorAction::SendErrorMessage {msg: msgs::ErrorMessage {channel_id: self.channel_id, data: "Received funding_created after we got the channel!".to_string()}})});
1304                 }
1305                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) || self.cur_remote_commitment_transaction_number != (1 << 48) - 1 || self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
1306                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1307                 }
1308
1309                 let funding_txo = OutPoint::new(msg.funding_txid, msg.funding_output_index);
1310                 let funding_txo_script = self.get_funding_redeemscript().to_v0_p2wsh();
1311                 self.channel_monitor.set_funding_info((funding_txo, funding_txo_script));
1312
1313                 let (remote_initial_commitment_tx, our_signature) = match self.funding_created_signature(&msg.signature) {
1314                         Ok(res) => res,
1315                         Err(e) => {
1316                                 self.channel_monitor.unset_funding_info();
1317                                 return Err(e);
1318                         }
1319                 };
1320
1321                 // Now that we're past error-generating stuff, update our local state:
1322
1323                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&remote_initial_commitment_tx, Vec::new(), self.cur_remote_commitment_transaction_number);
1324                 self.channel_state = ChannelState::FundingSent as u32;
1325                 self.channel_id = funding_txo.to_channel_id();
1326                 self.cur_remote_commitment_transaction_number -= 1;
1327                 self.cur_local_commitment_transaction_number -= 1;
1328
1329                 Ok((msgs::FundingSigned {
1330                         channel_id: self.channel_id,
1331                         signature: our_signature
1332                 }, self.channel_monitor.clone()))
1333         }
1334
1335         /// Handles a funding_signed message from the remote end.
1336         /// If this call is successful, broadcast the funding transaction (and not before!)
1337         pub fn funding_signed(&mut self, msg: &msgs::FundingSigned) -> Result<ChannelMonitor, HandleError> {
1338                 if !self.channel_outbound {
1339                         return Err(HandleError{err: "Received funding_signed for an inbound channel?", action: None});
1340                 }
1341                 if self.channel_state != ChannelState::FundingCreated as u32 {
1342                         return Err(HandleError{err: "Received funding_signed in strange state!", action: None});
1343                 }
1344                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) || self.cur_remote_commitment_transaction_number != (1 << 48) - 2 || self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
1345                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1346                 }
1347
1348                 let funding_script = self.get_funding_redeemscript();
1349
1350                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1351                 let mut local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false).0;
1352                 let local_sighash = Message::from_slice(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1353
1354                 // They sign the "local" commitment transaction, allowing us to broadcast the tx if we wish.
1355                 secp_call!(self.secp_ctx.verify(&local_sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid funding_signed signature from peer", self.channel_id());
1356
1357                 self.sign_commitment_transaction(&mut local_initial_commitment_tx, &msg.signature);
1358                 self.channel_monitor.provide_latest_local_commitment_tx_info(local_initial_commitment_tx.clone(), local_keys, self.feerate_per_kw, Vec::new());
1359                 self.last_local_commitment_txn = vec![local_initial_commitment_tx];
1360                 self.channel_state = ChannelState::FundingSent as u32;
1361                 self.cur_local_commitment_transaction_number -= 1;
1362
1363                 Ok(self.channel_monitor.clone())
1364         }
1365
1366         pub fn funding_locked(&mut self, msg: &msgs::FundingLocked) -> Result<(), HandleError> {
1367                 let non_shutdown_state = self.channel_state & (!BOTH_SIDES_SHUTDOWN_MASK);
1368                 if non_shutdown_state == ChannelState::FundingSent as u32 {
1369                         self.channel_state |= ChannelState::TheirFundingLocked as u32;
1370                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
1371                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & BOTH_SIDES_SHUTDOWN_MASK);
1372                         self.channel_update_count += 1;
1373                 } else {
1374                         return Err(HandleError{err: "Peer sent a funding_locked at a strange time", action: None});
1375                 }
1376
1377                 self.their_prev_commitment_point = self.their_cur_commitment_point;
1378                 self.their_cur_commitment_point = Some(msg.next_per_commitment_point);
1379                 Ok(())
1380         }
1381
1382         /// Returns (inbound_htlc_count, outbound_htlc_count, htlc_outbound_value_msat, htlc_inbound_value_msat)
1383         /// If its for a remote update check, we need to be more lax about checking against messages we
1384         /// sent but they may not have received/processed before they sent this message. Further, for
1385         /// our own sends, we're more conservative and even consider things they've removed against
1386         /// totals, though there is little reason to outside of further avoiding any race condition
1387         /// issues.
1388         fn get_pending_htlc_stats(&self, for_remote_update_check: bool) -> (u32, u32, u64, u64) {
1389                 //TODO: Can probably split this into inbound/outbound
1390                 let mut inbound_htlc_count: u32 = 0;
1391                 let mut outbound_htlc_count: u32 = 0;
1392                 let mut htlc_outbound_value_msat = 0;
1393                 let mut htlc_inbound_value_msat = 0;
1394                 for ref htlc in self.pending_inbound_htlcs.iter() {
1395                         match htlc.state {
1396                                 InboundHTLCState::RemoteAnnounced => {},
1397                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce => {},
1398                                 InboundHTLCState::AwaitingAnnouncedRemoteRevoke => {},
1399                                 InboundHTLCState::Committed => {},
1400                                 InboundHTLCState::LocalRemoved => {},
1401                         }
1402                         inbound_htlc_count += 1;
1403                         htlc_inbound_value_msat += htlc.amount_msat;
1404                 }
1405                 for ref htlc in self.pending_outbound_htlcs.iter() {
1406                         match htlc.state {
1407                                 OutboundHTLCState::LocalAnnounced => { if for_remote_update_check { continue; } },
1408                                 OutboundHTLCState::Committed => {},
1409                                 OutboundHTLCState::RemoteRemoved => { if for_remote_update_check { continue; } },
1410                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove => { if for_remote_update_check { continue; } },
1411                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke => { if for_remote_update_check { continue; } },
1412                         }
1413                         outbound_htlc_count += 1;
1414                         htlc_outbound_value_msat += htlc.amount_msat;
1415                 }
1416
1417                 (inbound_htlc_count, outbound_htlc_count, htlc_outbound_value_msat, htlc_inbound_value_msat)
1418         }
1419
1420         pub fn update_add_htlc(&mut self, msg: &msgs::UpdateAddHTLC, pending_forward_state: PendingHTLCStatus) -> Result<(), HandleError> {
1421                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::RemoteShutdownSent as u32)) != (ChannelState::ChannelFunded as u32) {
1422                         return Err(HandleError{err: "Got add HTLC message when channel was not in an operational state", action: None});
1423                 }
1424                 if msg.amount_msat > self.channel_value_satoshis * 1000 {
1425                         return Err(HandleError{err: "Remote side tried to send more than the total value of the channel", action: None});
1426                 }
1427                 if msg.amount_msat < self.our_htlc_minimum_msat {
1428                         return Err(HandleError{err: "Remote side tried to send less than our minimum HTLC value", action: None});
1429                 }
1430
1431                 let (inbound_htlc_count, _, htlc_outbound_value_msat, htlc_inbound_value_msat) = self.get_pending_htlc_stats(true);
1432                 if inbound_htlc_count + 1 > OUR_MAX_HTLCS as u32 {
1433                         return Err(HandleError{err: "Remote tried to push more than our max accepted HTLCs", action: None});
1434                 }
1435                 //TODO: Spec is unclear if this is per-direction or in total (I assume per direction):
1436                 // Check our_max_htlc_value_in_flight_msat
1437                 if htlc_inbound_value_msat + msg.amount_msat > Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis) {
1438                         return Err(HandleError{err: "Remote HTLC add would put them over their max HTLC value in flight", action: None});
1439                 }
1440                 // Check our_channel_reserve_satoshis (we're getting paid, so they have to at least meet
1441                 // the reserve_satoshis we told them to always have as direct payment so that they lose
1442                 // something if we punish them for broadcasting an old state).
1443                 if htlc_inbound_value_msat + htlc_outbound_value_msat + msg.amount_msat + self.value_to_self_msat > (self.channel_value_satoshis - Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis)) * 1000 {
1444                         return Err(HandleError{err: "Remote HTLC add would put them over their reserve value", action: None});
1445                 }
1446                 if self.next_remote_htlc_id != msg.htlc_id {
1447                         return Err(HandleError{err: "Remote skipped HTLC ID", action: None});
1448                 }
1449                 if msg.cltv_expiry >= 500000000 {
1450                         return Err(HandleError{err: "Remote provided CLTV expiry in seconds instead of block height", action: None});
1451                 }
1452
1453                 //TODO: Check msg.cltv_expiry further? Do this in channel manager?
1454
1455                 // Now update local state:
1456                 self.next_remote_htlc_id += 1;
1457                 self.pending_inbound_htlcs.push(InboundHTLCOutput {
1458                         htlc_id: msg.htlc_id,
1459                         amount_msat: msg.amount_msat,
1460                         payment_hash: msg.payment_hash,
1461                         cltv_expiry: msg.cltv_expiry,
1462                         state: InboundHTLCState::RemoteAnnounced,
1463                         local_removed_fulfilled: false,
1464                         pending_forward_state: Some(pending_forward_state),
1465                 });
1466
1467                 Ok(())
1468         }
1469
1470         /// Removes an outbound HTLC which has been commitment_signed by the remote end
1471         #[inline]
1472         fn mark_outbound_htlc_removed(&mut self, htlc_id: u64, check_preimage: Option<[u8; 32]>, fail_reason: Option<HTLCFailReason>) -> Result<[u8; 32], HandleError> {
1473                 for htlc in self.pending_outbound_htlcs.iter_mut() {
1474                         if htlc.htlc_id == htlc_id {
1475                                 match check_preimage {
1476                                         None => {},
1477                                         Some(payment_hash) =>
1478                                                 if payment_hash != htlc.payment_hash {
1479                                                         return Err(HandleError{err: "Remote tried to fulfill HTLC with an incorrect preimage", action: None});
1480                                                 }
1481                                 };
1482                                 match htlc.state {
1483                                         OutboundHTLCState::LocalAnnounced =>
1484                                                 return Err(HandleError{err: "Remote tried to fulfill HTLC before it had been committed", action: None}),
1485                                         OutboundHTLCState::Committed => {
1486                                                 htlc.state = OutboundHTLCState::RemoteRemoved;
1487                                                 htlc.fail_reason = fail_reason;
1488                                         },
1489                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove | OutboundHTLCState::AwaitingRemovedRemoteRevoke | OutboundHTLCState::RemoteRemoved =>
1490                                                 return Err(HandleError{err: "Remote tried to fulfill HTLC that they'd already fulfilled", action: None}),
1491                                 }
1492                                 return Ok(htlc.payment_hash.clone());
1493                         }
1494                 }
1495                 Err(HandleError{err: "Remote tried to fulfill/fail an HTLC we couldn't find", action: None})
1496         }
1497
1498         pub fn update_fulfill_htlc(&mut self, msg: &msgs::UpdateFulfillHTLC) -> Result<(), HandleError> {
1499                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1500                         return Err(HandleError{err: "Got add HTLC message when channel was not in an operational state", action: None});
1501                 }
1502
1503                 let mut sha = Sha256::new();
1504                 sha.input(&msg.payment_preimage);
1505                 let mut payment_hash = [0; 32];
1506                 sha.result(&mut payment_hash);
1507
1508                 self.mark_outbound_htlc_removed(msg.htlc_id, Some(payment_hash), None)?;
1509                 Ok(())
1510         }
1511
1512         pub fn update_fail_htlc(&mut self, msg: &msgs::UpdateFailHTLC, fail_reason: HTLCFailReason) -> Result<[u8; 32], HandleError> {
1513                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1514                         return Err(HandleError{err: "Got add HTLC message when channel was not in an operational state", action: None});
1515                 }
1516
1517                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))
1518         }
1519
1520         pub fn update_fail_malformed_htlc(&mut self, msg: &msgs::UpdateFailMalformedHTLC, fail_reason: HTLCFailReason) -> Result<(), HandleError> {
1521                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1522                         return Err(HandleError{err: "Got add HTLC message when channel was not in an operational state", action: None});
1523                 }
1524
1525                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
1526                 Ok(())
1527         }
1528
1529         pub fn commitment_signed(&mut self, msg: &msgs::CommitmentSigned) -> Result<(msgs::RevokeAndACK, Option<msgs::CommitmentSigned>, ChannelMonitor), HandleError> {
1530                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1531                         return Err(HandleError{err: "Got commitment signed message when channel was not in an operational state", action: None});
1532                 }
1533
1534                 let funding_script = self.get_funding_redeemscript();
1535
1536                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1537                 let mut local_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false);
1538                 let local_commitment_txid = local_commitment_tx.0.txid();
1539                 let local_sighash = Message::from_slice(&bip143::SighashComponents::new(&local_commitment_tx.0).sighash_all(&local_commitment_tx.0.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1540                 secp_call!(self.secp_ctx.verify(&local_sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid commitment tx signature from peer", self.channel_id());
1541
1542                 if msg.htlc_signatures.len() != local_commitment_tx.1.len() {
1543                         return Err(HandleError{err: "Got wrong number of HTLC signatures from remote", action: None});
1544                 }
1545
1546                 let mut new_local_commitment_txn = Vec::with_capacity(local_commitment_tx.1.len() + 1);
1547                 self.sign_commitment_transaction(&mut local_commitment_tx.0, &msg.signature);
1548                 new_local_commitment_txn.push(local_commitment_tx.0.clone());
1549
1550                 let mut htlcs_and_sigs = Vec::with_capacity(local_commitment_tx.1.len());
1551                 for (idx, ref htlc) in local_commitment_tx.1.iter().enumerate() {
1552                         let mut htlc_tx = self.build_htlc_transaction(&local_commitment_txid, htlc, true, &local_keys);
1553                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &local_keys);
1554                         let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
1555                         secp_call!(self.secp_ctx.verify(&htlc_sighash, &msg.htlc_signatures[idx], &local_keys.b_htlc_key), "Invalid HTLC tx siganture from peer", self.channel_id());
1556                         let htlc_sig = if htlc.offered {
1557                                 let htlc_sig = self.sign_htlc_transaction(&mut htlc_tx, &msg.htlc_signatures[idx], &None, htlc, &local_keys)?;
1558                                 new_local_commitment_txn.push(htlc_tx);
1559                                 htlc_sig
1560                         } else {
1561                                 self.create_htlc_tx_signature(&htlc_tx, htlc, &local_keys)?.1
1562                         };
1563                         htlcs_and_sigs.push(((*htlc).clone(), msg.htlc_signatures[idx], htlc_sig));
1564                 }
1565
1566                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(self.cur_local_commitment_transaction_number - 1));
1567                 let per_commitment_secret = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, self.cur_local_commitment_transaction_number + 1);
1568
1569                 // Update state now that we've passed all the can-fail calls...
1570                 self.channel_monitor.provide_latest_local_commitment_tx_info(local_commitment_tx.0, local_keys, self.feerate_per_kw, htlcs_and_sigs);
1571
1572                 let mut need_our_commitment = false;
1573                 for htlc in self.pending_inbound_htlcs.iter_mut() {
1574                         if htlc.state == InboundHTLCState::RemoteAnnounced {
1575                                 htlc.state = InboundHTLCState::AwaitingRemoteRevokeToAnnounce;
1576                                 need_our_commitment = true;
1577                         }
1578                 }
1579                 for htlc in self.pending_outbound_htlcs.iter_mut() {
1580                         if htlc.state == OutboundHTLCState::RemoteRemoved {
1581                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove;
1582                                 need_our_commitment = true;
1583                         }
1584                 }
1585
1586                 self.cur_local_commitment_transaction_number -= 1;
1587                 self.last_local_commitment_txn = new_local_commitment_txn;
1588
1589                 let (our_commitment_signed, monitor_update) = if need_our_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
1590                         // If we're AwaitingRemoteRevoke we can't send a new commitment here, but that's ok -
1591                         // we'll send one right away when we get the revoke_and_ack when we
1592                         // free_holding_cell_htlcs().
1593                         let (msg, monitor) = self.send_commitment_no_status_check()?;
1594                         (Some(msg), monitor)
1595                 } else { (None, self.channel_monitor.clone()) };
1596
1597                 Ok((msgs::RevokeAndACK {
1598                         channel_id: self.channel_id,
1599                         per_commitment_secret: per_commitment_secret,
1600                         next_per_commitment_point: next_per_commitment_point,
1601                 }, our_commitment_signed, monitor_update))
1602         }
1603
1604         /// Used to fulfill holding_cell_htlcs when we get a remote ack (or implicitly get it by them
1605         /// fulfilling or failing the last pending HTLC)
1606         fn free_holding_cell_htlcs(&mut self) -> Result<Option<(msgs::CommitmentUpdate, ChannelMonitor)>, HandleError> {
1607                 if self.holding_cell_htlc_updates.len() != 0 {
1608                         let mut htlc_updates = Vec::new();
1609                         mem::swap(&mut htlc_updates, &mut self.holding_cell_htlc_updates);
1610                         let mut update_add_htlcs = Vec::with_capacity(htlc_updates.len());
1611                         let mut update_fulfill_htlcs = Vec::with_capacity(htlc_updates.len());
1612                         let mut update_fail_htlcs = Vec::with_capacity(htlc_updates.len());
1613                         let mut err = None;
1614                         for htlc_update in htlc_updates.drain(..) {
1615                                 // Note that this *can* fail, though it should be due to rather-rare conditions on
1616                                 // fee races with adding too many outputs which push our total payments just over
1617                                 // the limit. In case its less rare than I anticipate, we may want to revisit
1618                                 // handling this case better and maybe fufilling some of the HTLCs while attempting
1619                                 // to rebalance channels.
1620                                 if err.is_some() { // We're back to AwaitingRemoteRevoke (or are about to fail the channel)
1621                                         self.holding_cell_htlc_updates.push(htlc_update);
1622                                 } else {
1623                                         match &htlc_update {
1624                                                 &HTLCUpdateAwaitingACK::AddHTLC {amount_msat, cltv_expiry, payment_hash, ref onion_routing_packet, ..} => {
1625                                                         match self.send_htlc(amount_msat, payment_hash, cltv_expiry, onion_routing_packet.clone()) {
1626                                                                 Ok(update_add_msg_option) => update_add_htlcs.push(update_add_msg_option.unwrap()),
1627                                                                 Err(e) => {
1628                                                                         err = Some(e);
1629                                                                 }
1630                                                         }
1631                                                 },
1632                                                 &HTLCUpdateAwaitingACK::ClaimHTLC { payment_preimage, .. } => {
1633                                                         match self.get_update_fulfill_htlc(payment_preimage) {
1634                                                                 Ok(update_fulfill_msg_option) => update_fulfill_htlcs.push(update_fulfill_msg_option.0.unwrap()),
1635                                                                 Err(e) => {
1636                                                                         err = Some(e);
1637                                                                 }
1638                                                         }
1639                                                 },
1640                                                 &HTLCUpdateAwaitingACK::FailHTLC { payment_hash, ref err_packet } => {
1641                                                         match self.get_update_fail_htlc(&payment_hash, err_packet.clone()) {
1642                                                                 Ok(update_fail_msg_option) => update_fail_htlcs.push(update_fail_msg_option.unwrap()),
1643                                                                 Err(e) => {
1644                                                                         err = Some(e);
1645                                                                 }
1646                                                         }
1647                                                 },
1648                                         }
1649                                         if err.is_some() {
1650                                                 self.holding_cell_htlc_updates.push(htlc_update);
1651                                         }
1652                                 }
1653                         }
1654                         //TODO: Need to examine the type of err - if its a fee issue or similar we may want to
1655                         //fail it back the route, if its a temporary issue we can ignore it...
1656                         match err {
1657                                 None => {
1658                                         let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
1659                                         Ok(Some((msgs::CommitmentUpdate {
1660                                                 update_add_htlcs,
1661                                                 update_fulfill_htlcs,
1662                                                 update_fail_htlcs,
1663                                                 update_fail_malformed_htlcs: Vec::new(),
1664                                                 commitment_signed,
1665                                         }, monitor_update)))
1666                                 },
1667                                 Some(e) => Err(e)
1668                         }
1669                 } else {
1670                         Ok(None)
1671                 }
1672         }
1673
1674         /// Handles receiving a remote's revoke_and_ack. Note that we may return a new
1675         /// commitment_signed message here in case we had pending outbound HTLCs to add which were
1676         /// waiting on this revoke_and_ack. The generation of this new commitment_signed may also fail,
1677         /// generating an appropriate error *after* the channel state has been updated based on the
1678         /// revoke_and_ack message.
1679         pub fn revoke_and_ack(&mut self, msg: &msgs::RevokeAndACK) -> Result<(Option<msgs::CommitmentUpdate>, Vec<PendingForwardHTLCInfo>, Vec<([u8; 32], HTLCFailReason)>, ChannelMonitor), HandleError> {
1680                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1681                         return Err(HandleError{err: "Got revoke/ACK message when channel was not in an operational state", action: None});
1682                 }
1683                 if let Some(their_prev_commitment_point) = self.their_prev_commitment_point {
1684                         if PublicKey::from_secret_key(&self.secp_ctx, &secp_call!(SecretKey::from_slice(&self.secp_ctx, &msg.per_commitment_secret), "Peer provided an invalid per_commitment_secret", self.channel_id())) != their_prev_commitment_point {
1685                                 return Err(HandleError{err: "Got a revoke commitment secret which didn't correspond to their current pubkey", action: None});
1686                         }
1687                 }
1688                 self.channel_monitor.provide_secret(self.cur_remote_commitment_transaction_number + 1, msg.per_commitment_secret, Some((self.cur_remote_commitment_transaction_number - 1, msg.next_per_commitment_point)))?;
1689
1690                 // Update state now that we've passed all the can-fail calls...
1691                 // (note that we may still fail to generate the new commitment_signed message, but that's
1692                 // OK, we step the channel here and *then* if the new generation fails we can fail the
1693                 // channel based on that, but stepping stuff here should be safe either way.
1694                 self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
1695                 self.their_prev_commitment_point = self.their_cur_commitment_point;
1696                 self.their_cur_commitment_point = Some(msg.next_per_commitment_point);
1697                 self.cur_remote_commitment_transaction_number -= 1;
1698
1699                 let mut to_forward_infos = Vec::new();
1700                 let mut revoked_htlcs = Vec::new();
1701                 let mut update_fail_htlcs = Vec::new();
1702                 let mut update_fail_malformed_htlcs = Vec::new();
1703                 let mut require_commitment = false;
1704                 let mut value_to_self_msat_diff: i64 = 0;
1705                 // We really shouldnt have two passes here, but retain gives a non-mutable ref (Rust bug)
1706                 self.pending_inbound_htlcs.retain(|htlc| {
1707                         if htlc.state == InboundHTLCState::LocalRemoved {
1708                                 if htlc.local_removed_fulfilled {
1709                                         value_to_self_msat_diff += htlc.amount_msat as i64;
1710                                 }
1711                                 false
1712                         } else { true }
1713                 });
1714                 self.pending_outbound_htlcs.retain(|htlc| {
1715                         if htlc.state == OutboundHTLCState::AwaitingRemovedRemoteRevoke {
1716                                 if let Some(reason) = htlc.fail_reason.clone() { // We really want take() here, but, again, non-mut ref :(
1717                                         revoked_htlcs.push((htlc.payment_hash, reason));
1718                                 } else {
1719                                         // They fulfilled, so we sent them money
1720                                         value_to_self_msat_diff -= htlc.amount_msat as i64;
1721                                 }
1722                                 false
1723                         } else { true }
1724                 });
1725                 for htlc in self.pending_inbound_htlcs.iter_mut() {
1726                         if htlc.state == InboundHTLCState::AwaitingRemoteRevokeToAnnounce {
1727                                 htlc.state = InboundHTLCState::AwaitingAnnouncedRemoteRevoke;
1728                                 require_commitment = true;
1729                         } else if htlc.state == InboundHTLCState::AwaitingAnnouncedRemoteRevoke {
1730                                 match htlc.pending_forward_state.take().unwrap() {
1731                                         PendingHTLCStatus::Fail(fail_msg) => {
1732                                                 htlc.state = InboundHTLCState::LocalRemoved;
1733                                                 require_commitment = true;
1734                                                 match fail_msg {
1735                                                         HTLCFailureMsg::Relay(msg) => update_fail_htlcs.push(msg),
1736                                                         HTLCFailureMsg::Malformed(msg) => update_fail_malformed_htlcs.push(msg),
1737                                                 }
1738                                         },
1739                                         PendingHTLCStatus::Forward(forward_info) => {
1740                                                 to_forward_infos.push(forward_info);
1741                                                 htlc.state = InboundHTLCState::Committed;
1742                                         }
1743                                 }
1744                         }
1745                 }
1746                 for htlc in self.pending_outbound_htlcs.iter_mut() {
1747                         if htlc.state == OutboundHTLCState::LocalAnnounced {
1748                                 htlc.state = OutboundHTLCState::Committed;
1749                         } else if htlc.state == OutboundHTLCState::AwaitingRemoteRevokeToRemove {
1750                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke;
1751                                 require_commitment = true;
1752                         }
1753                 }
1754                 self.value_to_self_msat = (self.value_to_self_msat as i64 + value_to_self_msat_diff) as u64;
1755
1756                 match self.free_holding_cell_htlcs()? {
1757                         Some(mut commitment_update) => {
1758                                 commitment_update.0.update_fail_htlcs.reserve(update_fail_htlcs.len());
1759                                 for fail_msg in update_fail_htlcs.drain(..) {
1760                                         commitment_update.0.update_fail_htlcs.push(fail_msg);
1761                                 }
1762                                 commitment_update.0.update_fail_malformed_htlcs.reserve(update_fail_malformed_htlcs.len());
1763                                 for fail_msg in update_fail_malformed_htlcs.drain(..) {
1764                                         commitment_update.0.update_fail_malformed_htlcs.push(fail_msg);
1765                                 }
1766                                 Ok((Some(commitment_update.0), to_forward_infos, revoked_htlcs, commitment_update.1))
1767                         },
1768                         None => {
1769                                 if require_commitment {
1770                                         let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
1771                                         Ok((Some(msgs::CommitmentUpdate {
1772                                                 update_add_htlcs: Vec::new(),
1773                                                 update_fulfill_htlcs: Vec::new(),
1774                                                 update_fail_htlcs,
1775                                                 update_fail_malformed_htlcs,
1776                                                 commitment_signed
1777                                         }), to_forward_infos, revoked_htlcs, monitor_update))
1778                                 } else {
1779                                         Ok((None, to_forward_infos, revoked_htlcs, self.channel_monitor.clone()))
1780                                 }
1781                         }
1782                 }
1783         }
1784
1785         pub fn update_fee(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::UpdateFee) -> Result<(), HandleError> {
1786                 if self.channel_outbound {
1787                         return Err(HandleError{err: "Non-funding remote tried to update channel fee", action: None});
1788                 }
1789                 Channel::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
1790                 self.channel_update_count += 1;
1791                 self.feerate_per_kw = msg.feerate_per_kw as u64;
1792                 Ok(())
1793         }
1794
1795         pub fn shutdown(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::Shutdown) -> Result<(Option<msgs::Shutdown>, Option<msgs::ClosingSigned>, Vec<[u8; 32]>), HandleError> {
1796                 if self.channel_state < ChannelState::FundingSent as u32 {
1797                         self.channel_state = ChannelState::ShutdownComplete as u32;
1798                         self.channel_update_count += 1;
1799                         return Ok((None, None, Vec::new()));
1800                 }
1801                 for htlc in self.pending_inbound_htlcs.iter() {
1802                         if htlc.state == InboundHTLCState::RemoteAnnounced {
1803                                 return Err(HandleError{err: "Got shutdown with remote pending HTLCs", action: None});
1804                         }
1805                 }
1806                 if (self.channel_state & ChannelState::RemoteShutdownSent as u32) == ChannelState::RemoteShutdownSent as u32 {
1807                         return Err(HandleError{err: "Remote peer sent duplicate shutdown message", action: None});
1808                 }
1809                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1810
1811                 // BOLT 2 says we must only send a scriptpubkey of certain standard forms, which are up to
1812                 // 34 bytes in length, so dont let the remote peer feed us some super fee-heavy script.
1813                 if self.channel_outbound && msg.scriptpubkey.len() > 34 {
1814                         return Err(HandleError{err: "Got shutdown_scriptpubkey of absurd length from remote peer", action: None});
1815                 }
1816                 //TODO: Check shutdown_scriptpubkey form as BOLT says we must? WHYYY
1817
1818                 if self.their_shutdown_scriptpubkey.is_some() {
1819                         if Some(&msg.scriptpubkey) != self.their_shutdown_scriptpubkey.as_ref() {
1820                                 return Err(HandleError{err: "Got shutdown request with a scriptpubkey which did not match their previous scriptpubkey", action: None});
1821                         }
1822                 } else {
1823                         self.their_shutdown_scriptpubkey = Some(msg.scriptpubkey.clone());
1824                 }
1825
1826                 let our_closing_script = self.get_closing_scriptpubkey();
1827
1828                 let (proposed_feerate, proposed_fee, our_sig) = if self.channel_outbound && self.pending_inbound_htlcs.is_empty() && self.pending_outbound_htlcs.is_empty() {
1829                         let mut proposed_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
1830                         if self.feerate_per_kw > proposed_feerate {
1831                                 proposed_feerate = self.feerate_per_kw;
1832                         }
1833                         let tx_weight = Self::get_closing_transaction_weight(&our_closing_script, &msg.scriptpubkey);
1834                         let proposed_total_fee_satoshis = proposed_feerate * tx_weight / 1000;
1835
1836                         let (closing_tx, total_fee_satoshis) = self.build_closing_transaction(proposed_total_fee_satoshis, false);
1837                         let funding_redeemscript = self.get_funding_redeemscript();
1838                         let sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
1839
1840                         (Some(proposed_feerate), Some(total_fee_satoshis), Some(self.secp_ctx.sign(&sighash, &self.local_keys.funding_key)))
1841                 } else { (None, None, None) };
1842
1843                 // From here on out, we may not fail!
1844
1845                 self.channel_state |= ChannelState::RemoteShutdownSent as u32;
1846                 self.channel_update_count += 1;
1847
1848                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
1849                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
1850                 // cell HTLCs and return them to fail the payment.
1851                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
1852                 self.holding_cell_htlc_updates.retain(|htlc_update| {
1853                         match htlc_update {
1854                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, .. } => {
1855                                         dropped_outbound_htlcs.push(payment_hash.clone());
1856                                         false
1857                                 },
1858                                 _ => true
1859                         }
1860                 });
1861                 for htlc in self.pending_outbound_htlcs.iter() {
1862                         if htlc.state == OutboundHTLCState::LocalAnnounced {
1863                                 return Ok((None, None, dropped_outbound_htlcs));
1864                         }
1865                 }
1866
1867                 let our_shutdown = if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
1868                         None
1869                 } else {
1870                         Some(msgs::Shutdown {
1871                                 channel_id: self.channel_id,
1872                                 scriptpubkey: our_closing_script,
1873                         })
1874                 };
1875
1876                 self.channel_state |= ChannelState::LocalShutdownSent as u32;
1877                 self.channel_update_count += 1;
1878                 if self.pending_inbound_htlcs.is_empty() && self.pending_outbound_htlcs.is_empty() && self.channel_outbound {
1879                         // There are no more HTLCs and we're the funder, this means we start the closing_signed
1880                         // dance with an initial fee proposal!
1881                         self.last_sent_closing_fee = Some((proposed_feerate.unwrap(), proposed_fee.unwrap()));
1882                         Ok((our_shutdown, Some(msgs::ClosingSigned {
1883                                 channel_id: self.channel_id,
1884                                 fee_satoshis: proposed_fee.unwrap(),
1885                                 signature: our_sig.unwrap(),
1886                         }), dropped_outbound_htlcs))
1887                 } else {
1888                         Ok((our_shutdown, None, dropped_outbound_htlcs))
1889                 }
1890         }
1891
1892         pub fn closing_signed(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::ClosingSigned) -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), HandleError> {
1893                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != BOTH_SIDES_SHUTDOWN_MASK {
1894                         return Err(HandleError{err: "Remote end sent us a closing_signed before both sides provided a shutdown", action: None});
1895                 }
1896                 if !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() {
1897                         return Err(HandleError{err: "Remote end sent us a closing_signed while there were still pending HTLCs", action: None});
1898                 }
1899                 if msg.fee_satoshis > 21000000 * 10000000 {
1900                         return Err(HandleError{err: "Remote tried to send us a closing tx with > 21 million BTC fee", action: None});
1901                 }
1902
1903                 let funding_redeemscript = self.get_funding_redeemscript();
1904                 let (mut closing_tx, used_total_fee) = self.build_closing_transaction(msg.fee_satoshis, false);
1905                 if used_total_fee != msg.fee_satoshis {
1906                         return Err(HandleError{err: "Remote sent us a closing_signed with a fee greater than the value they can claim", action: None});
1907                 }
1908                 let mut sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
1909
1910                 match self.secp_ctx.verify(&sighash, &msg.signature, &self.their_funding_pubkey.unwrap()) {
1911                         Ok(_) => {},
1912                         Err(_e) => {
1913                                 // The remote end may have decided to revoke their output due to inconsistent dust
1914                                 // limits, so check for that case by re-checking the signature here.
1915                                 closing_tx = self.build_closing_transaction(msg.fee_satoshis, true).0;
1916                                 sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
1917                                 secp_call!(self.secp_ctx.verify(&sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid closing tx signature from peer", self.channel_id());
1918                         },
1919                 };
1920
1921                 if let Some((_, last_fee)) = self.last_sent_closing_fee {
1922                         if last_fee == msg.fee_satoshis {
1923                                 self.sign_commitment_transaction(&mut closing_tx, &msg.signature);
1924                                 self.channel_state = ChannelState::ShutdownComplete as u32;
1925                                 self.channel_update_count += 1;
1926                                 return Ok((None, Some(closing_tx)));
1927                         }
1928                 }
1929
1930                 macro_rules! propose_new_feerate {
1931                         ($new_feerate: expr) => {
1932                                 let closing_tx_max_weight = Self::get_closing_transaction_weight(&self.get_closing_scriptpubkey(), self.their_shutdown_scriptpubkey.as_ref().unwrap());
1933                                 let (closing_tx, used_total_fee) = self.build_closing_transaction($new_feerate * closing_tx_max_weight / 1000, false);
1934                                 sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
1935                                 let our_sig = self.secp_ctx.sign(&sighash, &self.local_keys.funding_key);
1936                                 self.last_sent_closing_fee = Some(($new_feerate, used_total_fee));
1937                                 return Ok((Some(msgs::ClosingSigned {
1938                                         channel_id: self.channel_id,
1939                                         fee_satoshis: used_total_fee,
1940                                         signature: our_sig,
1941                                 }), None))
1942                         }
1943                 }
1944
1945                 let proposed_sat_per_kw = msg.fee_satoshis * 1000 / closing_tx.get_weight();
1946                 if self.channel_outbound {
1947                         let our_max_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
1948                         if proposed_sat_per_kw > our_max_feerate {
1949                                 if let Some((last_feerate, _)) = self.last_sent_closing_fee {
1950                                         if our_max_feerate <= last_feerate {
1951                                                 return Err(HandleError{err: "Unable to come to consensus about closing feerate, remote wanted something higher than our Normal feerate", action: None});
1952                                         }
1953                                 }
1954                                 propose_new_feerate!(our_max_feerate);
1955                         }
1956                 } else {
1957                         let our_min_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
1958                         if proposed_sat_per_kw < our_min_feerate {
1959                                 if let Some((last_feerate, _)) = self.last_sent_closing_fee {
1960                                         if our_min_feerate >= last_feerate {
1961                                                 return Err(HandleError{err: "Unable to come to consensus about closing feerate, remote wanted something lower than our Background feerate", action: None});
1962                                         }
1963                                 }
1964                                 propose_new_feerate!(our_min_feerate);
1965                         }
1966                 }
1967
1968                 let our_sig = self.sign_commitment_transaction(&mut closing_tx, &msg.signature);
1969                 self.channel_state = ChannelState::ShutdownComplete as u32;
1970                 self.channel_update_count += 1;
1971
1972                 Ok((Some(msgs::ClosingSigned {
1973                         channel_id: self.channel_id,
1974                         fee_satoshis: msg.fee_satoshis,
1975                         signature: our_sig,
1976                 }), Some(closing_tx)))
1977         }
1978
1979         // Public utilities:
1980
1981         pub fn channel_id(&self) -> [u8; 32] {
1982                 self.channel_id
1983         }
1984
1985         /// Gets the "user_id" value passed into the construction of this channel. It has no special
1986         /// meaning and exists only to allow users to have a persistent identifier of a channel.
1987         pub fn get_user_id(&self) -> u64 {
1988                 self.user_id
1989         }
1990
1991         /// May only be called after funding has been initiated (ie is_funding_initiated() is true)
1992         pub fn channel_monitor(&self) -> ChannelMonitor {
1993                 if self.channel_state < ChannelState::FundingCreated as u32 {
1994                         panic!("Can't get a channel monitor until funding has been created");
1995                 }
1996                 self.channel_monitor.clone()
1997         }
1998
1999         /// Guaranteed to be Some after both FundingLocked messages have been exchanged (and, thus,
2000         /// is_usable() returns true).
2001         /// Allowed in any state (including after shutdown)
2002         pub fn get_short_channel_id(&self) -> Option<u64> {
2003                 self.short_channel_id
2004         }
2005
2006         /// Returns the funding_txo we either got from our peer, or were given by
2007         /// get_outbound_funding_created.
2008         pub fn get_funding_txo(&self) -> Option<OutPoint> {
2009                 self.channel_monitor.get_funding_txo()
2010         }
2011
2012         /// Allowed in any state (including after shutdown)
2013         pub fn get_their_node_id(&self) -> PublicKey {
2014                 self.their_node_id
2015         }
2016
2017         /// Allowed in any state (including after shutdown)
2018         pub fn get_our_htlc_minimum_msat(&self) -> u64 {
2019                 self.our_htlc_minimum_msat
2020         }
2021
2022         pub fn get_value_satoshis(&self) -> u64 {
2023                 self.channel_value_satoshis
2024         }
2025
2026         //TODO: Testing purpose only, should be changed in another way after #81
2027         #[cfg(test)]
2028         pub fn get_local_keys(&self) -> &ChannelKeys {
2029                 &self.local_keys
2030         }
2031
2032         /// Allowed in any state (including after shutdown)
2033         pub fn get_channel_update_count(&self) -> u32 {
2034                 self.channel_update_count
2035         }
2036
2037         pub fn should_announce(&self) -> bool {
2038                 self.announce_publicly
2039         }
2040
2041         /// Gets the fee we'd want to charge for adding an HTLC output to this Channel
2042         /// Allowed in any state (including after shutdown)
2043         pub fn get_our_fee_base_msat(&self, fee_estimator: &FeeEstimator) -> u32 {
2044                 // For lack of a better metric, we calculate what it would cost to consolidate the new HTLC
2045                 // output value back into a transaction with the regular channel output:
2046
2047                 // the fee cost of the HTLC-Success/HTLC-Timeout transaction:
2048                 let mut res = self.feerate_per_kw * cmp::max(HTLC_TIMEOUT_TX_WEIGHT, HTLC_SUCCESS_TX_WEIGHT) / 1000;
2049
2050                 if self.channel_outbound {
2051                         // + the marginal fee increase cost to us in the commitment transaction:
2052                         res += self.feerate_per_kw * COMMITMENT_TX_WEIGHT_PER_HTLC / 1000;
2053                 }
2054
2055                 // + the marginal cost of an input which spends the HTLC-Success/HTLC-Timeout output:
2056                 res += fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal) * SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT / 1000;
2057
2058                 res as u32
2059         }
2060
2061         /// Returns true if this channel is fully established and not known to be closing.
2062         /// Allowed in any state (including after shutdown)
2063         pub fn is_usable(&self) -> bool {
2064                 let mask = ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK;
2065                 (self.channel_state & mask) == (ChannelState::ChannelFunded as u32)
2066         }
2067
2068         /// Returns true if this channel is currently available for use. This is a superset of
2069         /// is_usable() and considers things like the channel being temporarily disabled.
2070         /// Allowed in any state (including after shutdown)
2071         pub fn is_live(&self) -> bool {
2072                 self.is_usable()
2073         }
2074
2075         /// Returns true if funding_created was sent/received.
2076         pub fn is_funding_initiated(&self) -> bool {
2077                 self.channel_state >= ChannelState::FundingCreated as u32
2078         }
2079
2080         /// Returns true if this channel is fully shut down. True here implies that no further actions
2081         /// may/will be taken on this channel, and thus this object should be freed. Any future changes
2082         /// will be handled appropriately by the chain monitor.
2083         pub fn is_shutdown(&self) -> bool {
2084                 if (self.channel_state & ChannelState::ShutdownComplete as u32) == ChannelState::ShutdownComplete as u32  {
2085                         assert!(self.channel_state == ChannelState::ShutdownComplete as u32);
2086                         true
2087                 } else { false }
2088         }
2089
2090         /// Called by channelmanager based on chain blocks being connected.
2091         /// Note that we only need to use this to detect funding_signed, anything else is handled by
2092         /// the channel_monitor.
2093         /// In case of Err, the channel may have been closed, at which point the standard requirements
2094         /// apply - no calls may be made except those explicitly stated to be allowed post-shutdown.
2095         /// Only returns an ErrorAction of DisconnectPeer, if Err.
2096         pub fn block_connected(&mut self, header: &BlockHeader, height: u32, txn_matched: &[&Transaction], indexes_of_txn_matched: &[u32]) -> Result<Option<msgs::FundingLocked>, HandleError> {
2097                 let non_shutdown_state = self.channel_state & (!BOTH_SIDES_SHUTDOWN_MASK);
2098                 if self.funding_tx_confirmations > 0 {
2099                         if header.bitcoin_hash() != self.last_block_connected {
2100                                 self.last_block_connected = header.bitcoin_hash();
2101                                 self.funding_tx_confirmations += 1;
2102                                 if self.funding_tx_confirmations == Channel::derive_minimum_depth(self.channel_value_satoshis*1000, self.value_to_self_msat) as u64 {
2103                                         let need_commitment_update = if non_shutdown_state == ChannelState::FundingSent as u32 {
2104                                                 self.channel_state |= ChannelState::OurFundingLocked as u32;
2105                                                 true
2106                                         } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) {
2107                                                 self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & BOTH_SIDES_SHUTDOWN_MASK);
2108                                                 self.channel_update_count += 1;
2109                                                 true
2110                                         } else if self.channel_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
2111                                                 // We got a reorg but not enough to trigger a force close, just update
2112                                                 // funding_tx_confirmed_in and return.
2113                                                 false
2114                                         } else if self.channel_state < ChannelState::ChannelFunded as u32 {
2115                                                 panic!("Started confirming a channel in a state pre-FundingSent?: {}", self.channel_state);
2116                                         } else {
2117                                                 // We got a reorg but not enough to trigger a force close, just update
2118                                                 // funding_tx_confirmed_in and return.
2119                                                 false
2120                                         };
2121                                         self.funding_tx_confirmed_in = Some(header.bitcoin_hash());
2122
2123                                         //TODO: Note that this must be a duplicate of the previous commitment point they sent us,
2124                                         //as otherwise we will have a commitment transaction that they can't revoke (well, kinda,
2125                                         //they can by sending two revoke_and_acks back-to-back, but not really). This appears to be
2126                                         //a protocol oversight, but I assume I'm just missing something.
2127                                         if need_commitment_update {
2128                                                 let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2129                                                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2130                                                 return Ok(Some(msgs::FundingLocked {
2131                                                         channel_id: self.channel_id,
2132                                                         next_per_commitment_point: next_per_commitment_point,
2133                                                 }));
2134                                         }
2135                                 }
2136                         }
2137                 }
2138                 if non_shutdown_state & !(ChannelState::TheirFundingLocked as u32) == ChannelState::FundingSent as u32 {
2139                         for (ref tx, index_in_block) in txn_matched.iter().zip(indexes_of_txn_matched) {
2140                                 if tx.txid() == self.channel_monitor.get_funding_txo().unwrap().txid {
2141                                         let txo_idx = self.channel_monitor.get_funding_txo().unwrap().index as usize;
2142                                         if txo_idx >= tx.output.len() || tx.output[txo_idx].script_pubkey != self.get_funding_redeemscript().to_v0_p2wsh() ||
2143                                                         tx.output[txo_idx].value != self.channel_value_satoshis {
2144                                                 if self.channel_outbound {
2145                                                         // If we generated the funding transaction and it doesn't match what it
2146                                                         // should, the client is really broken and we should just panic and
2147                                                         // tell them off. That said, because hash collisions happen with high
2148                                                         // probability in fuzztarget mode, if we're fuzzing we just close the
2149                                                         // channel and move on.
2150                                                         #[cfg(not(feature = "fuzztarget"))]
2151                                                         panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
2152                                                 }
2153                                                 self.channel_state = ChannelState::ShutdownComplete as u32;
2154                                                 self.channel_update_count += 1;
2155                                                 return Err(HandleError{err: "funding tx had wrong script/value", action: Some(ErrorAction::DisconnectPeer{msg: None})});
2156                                         } else {
2157                                                 self.funding_tx_confirmations = 1;
2158                                                 self.short_channel_id = Some(((height as u64)          << (5*8)) |
2159                                                                              ((*index_in_block as u64) << (2*8)) |
2160                                                                              ((txo_idx as u64)         << (0*8)));
2161                                         }
2162                                 }
2163                         }
2164                 }
2165                 Ok(None)
2166         }
2167
2168         /// Called by channelmanager based on chain blocks being disconnected.
2169         /// Returns true if we need to close the channel now due to funding transaction
2170         /// unconfirmation/reorg.
2171         pub fn block_disconnected(&mut self, header: &BlockHeader) -> bool {
2172                 if self.funding_tx_confirmations > 0 {
2173                         self.funding_tx_confirmations -= 1;
2174                         if self.funding_tx_confirmations == UNCONF_THRESHOLD as u64 {
2175                                 return true;
2176                         }
2177                 }
2178                 if Some(header.bitcoin_hash()) == self.funding_tx_confirmed_in {
2179                         self.funding_tx_confirmations = Channel::derive_minimum_depth(self.channel_value_satoshis*1000, self.value_to_self_msat) as u64 - 1;
2180                 }
2181                 false
2182         }
2183
2184         // Methods to get unprompted messages to send to the remote end (or where we already returned
2185         // something in the handler for the message that prompted this message):
2186
2187         pub fn get_open_channel(&self, chain_hash: Sha256dHash, fee_estimator: &FeeEstimator) -> Result<msgs::OpenChannel, APIError> {
2188                 if !self.channel_outbound {
2189                         panic!("Tried to open a channel for an inbound channel?");
2190                 }
2191                 if self.channel_state != ChannelState::OurInitSent as u32 {
2192                         panic!("Cannot generate an open_channel after we've moved forward");
2193                 }
2194
2195                 if self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
2196                         panic!("Tried to send an open_channel for a channel that has already advanced");
2197                 }
2198
2199                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2200
2201                 Ok(msgs::OpenChannel {
2202                         chain_hash: chain_hash,
2203                         temporary_channel_id: self.channel_id,
2204                         funding_satoshis: self.channel_value_satoshis,
2205                         push_msat: self.channel_value_satoshis * 1000 - self.value_to_self_msat,
2206                         dust_limit_satoshis: self.our_dust_limit_satoshis,
2207                         max_htlc_value_in_flight_msat: Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
2208                         channel_reserve_satoshis: Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
2209                         htlc_minimum_msat: self.our_htlc_minimum_msat,
2210                         feerate_per_kw: fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background) as u32,
2211                         to_self_delay: BREAKDOWN_TIMEOUT,
2212                         max_accepted_htlcs: OUR_MAX_HTLCS,
2213                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key),
2214                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key),
2215                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key),
2216                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key),
2217                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key),
2218                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret),
2219                         channel_flags: if self.announce_publicly {1} else {0},
2220                         shutdown_scriptpubkey: None,
2221                 })
2222         }
2223
2224         pub fn get_accept_channel(&self) -> msgs::AcceptChannel {
2225                 if self.channel_outbound {
2226                         panic!("Tried to send accept_channel for an outbound channel?");
2227                 }
2228                 if self.channel_state != (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32) {
2229                         panic!("Tried to send accept_channel after channel had moved forward");
2230                 }
2231                 if self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
2232                         panic!("Tried to send an accept_channel for a channel that has already advanced");
2233                 }
2234
2235                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2236
2237                 msgs::AcceptChannel {
2238                         temporary_channel_id: self.channel_id,
2239                         dust_limit_satoshis: self.our_dust_limit_satoshis,
2240                         max_htlc_value_in_flight_msat: Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
2241                         channel_reserve_satoshis: Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
2242                         htlc_minimum_msat: self.our_htlc_minimum_msat,
2243                         minimum_depth: Channel::derive_minimum_depth(self.channel_value_satoshis*1000, self.value_to_self_msat),
2244                         to_self_delay: BREAKDOWN_TIMEOUT,
2245                         max_accepted_htlcs: OUR_MAX_HTLCS,
2246                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key),
2247                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key),
2248                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key),
2249                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key),
2250                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key),
2251                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret),
2252                         shutdown_scriptpubkey: None,
2253                 }
2254         }
2255
2256         fn get_outbound_funding_created_signature(&mut self) -> Result<(Signature, Transaction), HandleError> {
2257                 let funding_script = self.get_funding_redeemscript();
2258
2259                 let remote_keys = self.build_remote_transaction_keys()?;
2260                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false).0;
2261                 let remote_sighash = Message::from_slice(&bip143::SighashComponents::new(&remote_initial_commitment_tx).sighash_all(&remote_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
2262
2263                 // We sign the "remote" commitment transaction, allowing them to broadcast the tx if they wish.
2264                 Ok((self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key), remote_initial_commitment_tx))
2265         }
2266
2267         /// Updates channel state with knowledge of the funding transaction's txid/index, and generates
2268         /// a funding_created message for the remote peer.
2269         /// Panics if called at some time other than immediately after initial handshake, if called twice,
2270         /// or if called on an inbound channel.
2271         /// Note that channel_id changes during this call!
2272         /// Do NOT broadcast the funding transaction until after a successful funding_signed call!
2273         pub fn get_outbound_funding_created(&mut self, funding_txo: OutPoint) -> Result<(msgs::FundingCreated, ChannelMonitor), HandleError> {
2274                 if !self.channel_outbound {
2275                         panic!("Tried to create outbound funding_created message on an inbound channel!");
2276                 }
2277                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
2278                         panic!("Tried to get a funding_created messsage at a time other than immediately after initial handshake completion (or tried to get funding_created twice)");
2279                 }
2280                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) || self.cur_remote_commitment_transaction_number != (1 << 48) - 1 || self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
2281                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
2282                 }
2283
2284                 let funding_txo_script = self.get_funding_redeemscript().to_v0_p2wsh();
2285                 self.channel_monitor.set_funding_info((funding_txo, funding_txo_script));
2286
2287                 let (our_signature, commitment_tx) = match self.get_outbound_funding_created_signature() {
2288                         Ok(res) => res,
2289                         Err(e) => {
2290                                 log_error!(self, "Got bad signatures: {}!", e.err);
2291                                 self.channel_monitor.unset_funding_info();
2292                                 return Err(e);
2293                         }
2294                 };
2295
2296                 let temporary_channel_id = self.channel_id;
2297
2298                 // Now that we're past error-generating stuff, update our local state:
2299                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&commitment_tx, Vec::new(), self.cur_remote_commitment_transaction_number);
2300                 self.channel_state = ChannelState::FundingCreated as u32;
2301                 self.channel_id = funding_txo.to_channel_id();
2302                 self.cur_remote_commitment_transaction_number -= 1;
2303
2304                 Ok((msgs::FundingCreated {
2305                         temporary_channel_id: temporary_channel_id,
2306                         funding_txid: funding_txo.txid,
2307                         funding_output_index: funding_txo.index,
2308                         signature: our_signature
2309                 }, self.channel_monitor.clone()))
2310         }
2311
2312         /// Gets an UnsignedChannelAnnouncement, as well as a signature covering it using our
2313         /// bitcoin_key, if available, for this channel. The channel must be publicly announceable and
2314         /// available for use (have exchanged FundingLocked messages in both directions). Should be used
2315         /// for both loose and in response to an AnnouncementSignatures message from the remote peer.
2316         /// Will only fail if we're not in a state where channel_announcement may be sent (including
2317         /// closing).
2318         /// Note that the "channel must be funded" requirement is stricter than BOLT 7 requires - see
2319         /// https://github.com/lightningnetwork/lightning-rfc/issues/468
2320         pub fn get_channel_announcement(&self, our_node_id: PublicKey, chain_hash: Sha256dHash) -> Result<(msgs::UnsignedChannelAnnouncement, Signature), HandleError> {
2321                 if !self.announce_publicly {
2322                         return Err(HandleError{err: "Channel is not available for public announcements", action: Some(msgs::ErrorAction::IgnoreError)});
2323                 }
2324                 if self.channel_state & (ChannelState::ChannelFunded as u32) == 0 {
2325                         return Err(HandleError{err: "Cannot get a ChannelAnnouncement until the channel funding has been locked", action: Some(msgs::ErrorAction::IgnoreError)});
2326                 }
2327                 if (self.channel_state & (ChannelState::LocalShutdownSent as u32 | ChannelState::ShutdownComplete as u32)) != 0 {
2328                         return Err(HandleError{err: "Cannot get a ChannelAnnouncement once the channel is closing", action: Some(msgs::ErrorAction::IgnoreError)});
2329                 }
2330
2331                 let were_node_one = our_node_id.serialize()[..] < self.their_node_id.serialize()[..];
2332                 let our_bitcoin_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key);
2333
2334                 let msg = msgs::UnsignedChannelAnnouncement {
2335                         features: msgs::GlobalFeatures::new(),
2336                         chain_hash: chain_hash,
2337                         short_channel_id: self.get_short_channel_id().unwrap(),
2338                         node_id_1: if were_node_one { our_node_id } else { self.get_their_node_id() },
2339                         node_id_2: if were_node_one { self.get_their_node_id() } else { our_node_id },
2340                         bitcoin_key_1: if were_node_one { our_bitcoin_key } else { self.their_funding_pubkey.unwrap() },
2341                         bitcoin_key_2: if were_node_one { self.their_funding_pubkey.unwrap() } else { our_bitcoin_key },
2342                         excess_data: Vec::new(),
2343                 };
2344
2345                 let msghash = Message::from_slice(&Sha256dHash::from_data(&msg.encode()[..])[..]).unwrap();
2346                 let sig = self.secp_ctx.sign(&msghash, &self.local_keys.funding_key);
2347
2348                 Ok((msg, sig))
2349         }
2350
2351
2352         // Send stuff to our remote peers:
2353
2354         /// Adds a pending outbound HTLC to this channel, note that you probably want
2355         /// send_htlc_and_commit instead cause you'll want both messages at once.
2356         /// This returns an option instead of a pure UpdateAddHTLC as we may be in a state where we are
2357         /// waiting on the remote peer to send us a revoke_and_ack during which time we cannot add new
2358         /// HTLCs on the wire or we wouldn't be able to determine what they actually ACK'ed.
2359         /// You MUST call send_commitment prior to any other calls on this Channel
2360         pub fn send_htlc(&mut self, amount_msat: u64, payment_hash: [u8; 32], cltv_expiry: u32, onion_routing_packet: msgs::OnionPacket) -> Result<Option<msgs::UpdateAddHTLC>, HandleError> {
2361                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK)) != (ChannelState::ChannelFunded as u32) {
2362                         return Err(HandleError{err: "Cannot send HTLC until channel is fully established and we haven't started shutting down", action: None});
2363                 }
2364
2365                 if amount_msat > self.channel_value_satoshis * 1000 {
2366                         return Err(HandleError{err: "Cannot send more than the total value of the channel", action: None});
2367                 }
2368                 if amount_msat < self.their_htlc_minimum_msat {
2369                         return Err(HandleError{err: "Cannot send less than their minimum HTLC value", action: None});
2370                 }
2371
2372                 let (_, outbound_htlc_count, htlc_outbound_value_msat, htlc_inbound_value_msat) = self.get_pending_htlc_stats(false);
2373                 if outbound_htlc_count + 1 > self.their_max_accepted_htlcs as u32 {
2374                         return Err(HandleError{err: "Cannot push more than their max accepted HTLCs", action: None});
2375                 }
2376                 //TODO: Spec is unclear if this is per-direction or in total (I assume per direction):
2377                 // Check their_max_htlc_value_in_flight_msat
2378                 if htlc_outbound_value_msat + amount_msat > self.their_max_htlc_value_in_flight_msat {
2379                         return Err(HandleError{err: "Cannot send value that would put us over our max HTLC value in flight", action: None});
2380                 }
2381                 // Check their_channel_reserve_satoshis:
2382                 if htlc_inbound_value_msat + htlc_outbound_value_msat + amount_msat + (self.channel_value_satoshis * 1000 - self.value_to_self_msat) > (self.channel_value_satoshis - self.their_channel_reserve_satoshis) * 1000 {
2383                         return Err(HandleError{err: "Cannot send value that would put us over our reserve value", action: None});
2384                 }
2385
2386                 //TODO: Check cltv_expiry? Do this in channel manager?
2387
2388                 // Now update local state:
2389                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
2390                         //TODO: Check the limits *including* other pending holding cell HTLCs!
2391                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::AddHTLC {
2392                                 amount_msat: amount_msat,
2393                                 payment_hash: payment_hash,
2394                                 cltv_expiry: cltv_expiry,
2395                                 onion_routing_packet: onion_routing_packet,
2396                                 time_created: Instant::now(),
2397                         });
2398                         return Ok(None);
2399                 }
2400
2401                 self.pending_outbound_htlcs.push(OutboundHTLCOutput {
2402                         htlc_id: self.next_local_htlc_id,
2403                         amount_msat: amount_msat,
2404                         payment_hash: payment_hash.clone(),
2405                         cltv_expiry: cltv_expiry,
2406                         state: OutboundHTLCState::LocalAnnounced,
2407                         fail_reason: None,
2408                 });
2409
2410                 let res = msgs::UpdateAddHTLC {
2411                         channel_id: self.channel_id,
2412                         htlc_id: self.next_local_htlc_id,
2413                         amount_msat: amount_msat,
2414                         payment_hash: payment_hash,
2415                         cltv_expiry: cltv_expiry,
2416                         onion_routing_packet: onion_routing_packet,
2417                 };
2418                 self.next_local_htlc_id += 1;
2419
2420                 Ok(Some(res))
2421         }
2422
2423         /// Creates a signed commitment transaction to send to the remote peer.
2424         /// Always returns a Channel-failing HandleError::action if an immediately-preceding (read: the
2425         /// last call to this Channel) send_htlc returned Ok(Some(_)) and there is an Err.
2426         /// May panic if called except immediately after a successful, Ok(Some(_))-returning send_htlc.
2427         pub fn send_commitment(&mut self) -> Result<(msgs::CommitmentSigned, ChannelMonitor), HandleError> {
2428                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2429                         panic!("Cannot create commitment tx until channel is fully established");
2430                 }
2431                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
2432                         panic!("Cannot create commitment tx until remote revokes their previous commitment");
2433                 }
2434                 let mut have_updates = false; // TODO initialize with "have we sent a fee update?"
2435                 for htlc in self.pending_outbound_htlcs.iter() {
2436                         if htlc.state == OutboundHTLCState::LocalAnnounced {
2437                                 have_updates = true;
2438                         }
2439                         if have_updates { break; }
2440                 }
2441                 if !have_updates {
2442                         panic!("Cannot create commitment tx until we have some updates to send");
2443                 }
2444                 self.send_commitment_no_status_check()
2445         }
2446         /// Only fails in case of bad keys
2447         fn send_commitment_no_status_check(&mut self) -> Result<(msgs::CommitmentSigned, ChannelMonitor), HandleError> {
2448                 let funding_script = self.get_funding_redeemscript();
2449
2450                 // We can upgrade the status of some HTLCs that are waiting on a commitment, even if we
2451                 // fail to generate this, we still are at least at a position where upgrading their status
2452                 // is acceptable.
2453                 for htlc in self.pending_inbound_htlcs.iter_mut() {
2454                         if htlc.state == InboundHTLCState::AwaitingRemoteRevokeToAnnounce {
2455                                 htlc.state = InboundHTLCState::AwaitingAnnouncedRemoteRevoke;
2456                         }
2457                 }
2458                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2459                         if htlc.state == OutboundHTLCState::AwaitingRemoteRevokeToRemove {
2460                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke;
2461                         }
2462                 }
2463
2464                 let remote_keys = self.build_remote_transaction_keys()?;
2465                 let remote_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, true);
2466                 let remote_commitment_txid = remote_commitment_tx.0.txid();
2467                 let remote_sighash = Message::from_slice(&bip143::SighashComponents::new(&remote_commitment_tx.0).sighash_all(&remote_commitment_tx.0.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
2468                 let our_sig = self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key);
2469
2470                 let mut htlc_sigs = Vec::new();
2471
2472                 for ref htlc in remote_commitment_tx.1.iter() {
2473                         let htlc_tx = self.build_htlc_transaction(&remote_commitment_txid, htlc, false, &remote_keys);
2474                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &remote_keys);
2475                         let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
2476                         let our_htlc_key = secp_derived_key!(chan_utils::derive_private_key(&self.secp_ctx, &remote_keys.per_commitment_point, &self.local_keys.htlc_base_key), self.channel_id());
2477                         htlc_sigs.push(self.secp_ctx.sign(&htlc_sighash, &our_htlc_key));
2478                 }
2479
2480                 // Update state now that we've passed all the can-fail calls...
2481                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&remote_commitment_tx.0, remote_commitment_tx.1, self.cur_remote_commitment_transaction_number);
2482                 self.channel_state |= ChannelState::AwaitingRemoteRevoke as u32;
2483
2484                 Ok((msgs::CommitmentSigned {
2485                         channel_id: self.channel_id,
2486                         signature: our_sig,
2487                         htlc_signatures: htlc_sigs,
2488                 }, self.channel_monitor.clone()))
2489         }
2490
2491         /// Adds a pending outbound HTLC to this channel, and creates a signed commitment transaction
2492         /// to send to the remote peer in one go.
2493         /// Shorthand for calling send_htlc() followed by send_commitment(), see docs on those for
2494         /// more info.
2495         pub fn send_htlc_and_commit(&mut self, amount_msat: u64, payment_hash: [u8; 32], cltv_expiry: u32, onion_routing_packet: msgs::OnionPacket) -> Result<Option<(msgs::UpdateAddHTLC, msgs::CommitmentSigned, ChannelMonitor)>, HandleError> {
2496                 match self.send_htlc(amount_msat, payment_hash, cltv_expiry, onion_routing_packet)? {
2497                         Some(update_add_htlc) => {
2498                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
2499                                 Ok(Some((update_add_htlc, commitment_signed, monitor_update)))
2500                         },
2501                         None => Ok(None)
2502                 }
2503         }
2504
2505         /// Begins the shutdown process, getting a message for the remote peer and returning all
2506         /// holding cell HTLCs for payment failure.
2507         pub fn get_shutdown(&mut self) -> Result<(msgs::Shutdown, Vec<[u8; 32]>), HandleError> {
2508                 for htlc in self.pending_outbound_htlcs.iter() {
2509                         if htlc.state == OutboundHTLCState::LocalAnnounced {
2510                                 return Err(HandleError{err: "Cannot begin shutdown with pending HTLCs, call send_commitment first", action: None});
2511                         }
2512                 }
2513                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != 0 {
2514                         return Err(HandleError{err: "Shutdown already in progress", action: None});
2515                 }
2516                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
2517
2518                 let our_closing_script = self.get_closing_scriptpubkey();
2519
2520                 // From here on out, we may not fail!
2521                 if self.channel_state < ChannelState::FundingSent as u32 {
2522                         self.channel_state = ChannelState::ShutdownComplete as u32;
2523                 } else {
2524                         self.channel_state |= ChannelState::LocalShutdownSent as u32;
2525                 }
2526                 self.channel_update_count += 1;
2527
2528                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
2529                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
2530                 // cell HTLCs and return them to fail the payment.
2531                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
2532                 self.holding_cell_htlc_updates.retain(|htlc_update| {
2533                         match htlc_update {
2534                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, .. } => {
2535                                         dropped_outbound_htlcs.push(payment_hash.clone());
2536                                         false
2537                                 },
2538                                 _ => true
2539                         }
2540                 });
2541
2542                 Ok((msgs::Shutdown {
2543                         channel_id: self.channel_id,
2544                         scriptpubkey: our_closing_script,
2545                 }, dropped_outbound_htlcs))
2546         }
2547
2548         /// Gets the latest commitment transaction and any dependant transactions for relay (forcing
2549         /// shutdown of this channel - no more calls into this Channel may be made afterwards except
2550         /// those explicitly stated to be allowed after shutdown completes, eg some simple getters).
2551         /// Also returns the list of payment_hashes for channels which we can safely fail backwards
2552         /// immediately (others we will have to allow to time out).
2553         pub fn force_shutdown(&mut self) -> (Vec<Transaction>, Vec<[u8; 32]>) {
2554                 assert!(self.channel_state != ChannelState::ShutdownComplete as u32);
2555
2556                 // We go ahead and "free" any holding cell HTLCs or HTLCs we haven't yet committed to and
2557                 // return them to fail the payment.
2558                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
2559                 for htlc_update in self.holding_cell_htlc_updates.drain(..) {
2560                         match htlc_update {
2561                                 HTLCUpdateAwaitingACK::AddHTLC { payment_hash, .. } => {
2562                                         dropped_outbound_htlcs.push(payment_hash);
2563                                 },
2564                                 _ => {}
2565                         }
2566                 }
2567
2568                 for htlc in self.pending_outbound_htlcs.drain(..) {
2569                         if htlc.state == OutboundHTLCState::LocalAnnounced {
2570                                 dropped_outbound_htlcs.push(htlc.payment_hash);
2571                         }
2572                         //TODO: Do something with the remaining HTLCs
2573                         //(we need to have the ChannelManager monitor them so we can claim the inbound HTLCs
2574                         //which correspond)
2575                 }
2576
2577                 self.channel_state = ChannelState::ShutdownComplete as u32;
2578                 self.channel_update_count += 1;
2579                 let mut res = Vec::new();
2580                 mem::swap(&mut res, &mut self.last_local_commitment_txn);
2581                 (res, dropped_outbound_htlcs)
2582         }
2583 }
2584
2585 #[cfg(test)]
2586 mod tests {
2587         use bitcoin::util::hash::Sha256dHash;
2588         use bitcoin::util::bip143;
2589         use bitcoin::network::serialize::serialize;
2590         use bitcoin::blockdata::script::Script;
2591         use bitcoin::blockdata::transaction::Transaction;
2592         use hex;
2593         use ln::channel::{Channel,ChannelKeys,InboundHTLCOutput,OutboundHTLCOutput,InboundHTLCState,OutboundHTLCState,HTLCOutputInCommitment,TxCreationKeys};
2594         use ln::channel::MAX_FUNDING_SATOSHIS;
2595         use ln::chan_utils;
2596         use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
2597         use chain::transaction::OutPoint;
2598         use util::test_utils;
2599         use util::logger::Logger;
2600         use secp256k1::{Secp256k1,Message,Signature};
2601         use secp256k1::key::{SecretKey,PublicKey};
2602         use crypto::sha2::Sha256;
2603         use crypto::digest::Digest;
2604         use std::sync::Arc;
2605
2606         struct TestFeeEstimator {
2607                 fee_est: u64
2608         }
2609         impl FeeEstimator for TestFeeEstimator {
2610                 fn get_est_sat_per_1000_weight(&self, _: ConfirmationTarget) -> u64 {
2611                         self.fee_est
2612                 }
2613         }
2614
2615         #[test]
2616         fn test_max_funding_satoshis() {
2617                 assert!(MAX_FUNDING_SATOSHIS <= 21_000_000 * 100_000_000,
2618                         "MAX_FUNDING_SATOSHIS is greater than all satoshis on existence");
2619         }
2620
2621         #[test]
2622         fn outbound_commitment_test() {
2623                 // Test vectors from BOLT 3 Appendix C:
2624                 let feeest = TestFeeEstimator{fee_est: 15000};
2625                 let logger : Arc<Logger> = Arc::new(test_utils::TestLogger::new());
2626                 let secp_ctx = Secp256k1::new();
2627
2628                 let chan_keys = ChannelKeys {
2629                         funding_key: SecretKey::from_slice(&secp_ctx, &hex::decode("30ff4956bbdd3222d44cc5e8a1261dab1e07957bdac5ae88fe3261ef321f3749").unwrap()[..]).unwrap(),
2630                         payment_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
2631                         delayed_payment_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("3333333333333333333333333333333333333333333333333333333333333333").unwrap()[..]).unwrap(),
2632                         htlc_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
2633
2634                         // These aren't set in the test vectors:
2635                         revocation_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
2636                         channel_close_key: SecretKey::from_slice(&secp_ctx, &hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
2637                         channel_monitor_claim_key: SecretKey::from_slice(&secp_ctx, &hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
2638                         commitment_seed: [0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff],
2639                 };
2640                 assert_eq!(PublicKey::from_secret_key(&secp_ctx, &chan_keys.funding_key).serialize()[..],
2641                                 hex::decode("023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb").unwrap()[..]);
2642
2643                 let their_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &[42; 32]).unwrap());
2644                 let mut chan = Channel::new_outbound(&feeest, chan_keys, their_node_id, 10000000, 100000, false, 42, Arc::clone(&logger)).unwrap(); // Nothing uses their network key in this test
2645                 chan.their_to_self_delay = 144;
2646                 chan.our_dust_limit_satoshis = 546;
2647
2648                 let funding_info = OutPoint::new(Sha256dHash::from_hex("8984484a580b825b9972d7adb15050b3ab624ccd731946b3eeddb92f4e7ef6be").unwrap(), 0);
2649                 chan.channel_monitor.set_funding_info((funding_info, Script::new()));
2650
2651                 chan.their_payment_basepoint = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex::decode("4444444444444444444444444444444444444444444444444444444444444444").unwrap()[..]).unwrap()));
2652                 assert_eq!(chan.their_payment_basepoint.unwrap().serialize()[..],
2653                                 hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
2654
2655                 chan.their_funding_pubkey = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex::decode("1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13").unwrap()[..]).unwrap()));
2656                 assert_eq!(chan.their_funding_pubkey.unwrap().serialize()[..],
2657                                 hex::decode("030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c1").unwrap()[..]);
2658
2659                 chan.their_htlc_basepoint = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex::decode("4444444444444444444444444444444444444444444444444444444444444444").unwrap()[..]).unwrap()));
2660                 assert_eq!(chan.their_htlc_basepoint.unwrap().serialize()[..],
2661                                 hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
2662
2663                 chan.their_revocation_basepoint = Some(PublicKey::from_slice(&secp_ctx, &hex::decode("02466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27").unwrap()[..]).unwrap());
2664
2665                 // We can't just use build_local_transaction_keys here as the per_commitment_secret is not
2666                 // derived from a commitment_seed, so instead we copy it here and call
2667                 // build_commitment_transaction.
2668                 let delayed_payment_base = PublicKey::from_secret_key(&secp_ctx, &chan.local_keys.delayed_payment_base_key);
2669                 let per_commitment_secret = SecretKey::from_slice(&secp_ctx, &hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
2670                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
2671                 let htlc_basepoint = PublicKey::from_secret_key(&secp_ctx, &chan.local_keys.htlc_base_key);
2672                 let keys = TxCreationKeys::new(&secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &chan.their_revocation_basepoint.unwrap(), &chan.their_payment_basepoint.unwrap(), &chan.their_htlc_basepoint.unwrap()).unwrap();
2673
2674                 let mut unsigned_tx: (Transaction, Vec<HTLCOutputInCommitment>);
2675
2676                 macro_rules! test_commitment {
2677                         ( $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr) => {
2678                                 unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false);
2679                                 let their_signature = Signature::from_der(&secp_ctx, &hex::decode($their_sig_hex).unwrap()[..]).unwrap();
2680                                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&unsigned_tx.0).sighash_all(&unsigned_tx.0.input[0], &chan.get_funding_redeemscript(), chan.channel_value_satoshis)[..]).unwrap();
2681                                 secp_ctx.verify(&sighash, &their_signature, &chan.their_funding_pubkey.unwrap()).unwrap();
2682
2683                                 chan.sign_commitment_transaction(&mut unsigned_tx.0, &their_signature);
2684
2685                                 assert_eq!(serialize(&unsigned_tx.0).unwrap()[..],
2686                                                 hex::decode($tx_hex).unwrap()[..]);
2687                         };
2688                 }
2689
2690                 macro_rules! test_htlc_output {
2691                         ( $htlc_idx: expr, $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr ) => {
2692                                 let remote_signature = Signature::from_der(&secp_ctx, &hex::decode($their_sig_hex).unwrap()[..]).unwrap();
2693
2694                                 let ref htlc = unsigned_tx.1[$htlc_idx];
2695                                 let mut htlc_tx = chan.build_htlc_transaction(&unsigned_tx.0.txid(), &htlc, true, &keys);
2696                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys);
2697                                 let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
2698                                 secp_ctx.verify(&htlc_sighash, &remote_signature, &keys.b_htlc_key).unwrap();
2699
2700                                 let mut preimage: Option<[u8; 32]> = None;
2701                                 if !htlc.offered {
2702                                         for i in 0..5 {
2703                                                 let mut sha = Sha256::new();
2704                                                 sha.input(&[i; 32]);
2705
2706                                                 let mut out = [0; 32];
2707                                                 sha.result(&mut out);
2708
2709                                                 if out == htlc.payment_hash {
2710                                                         preimage = Some([i; 32]);
2711                                                 }
2712                                         }
2713
2714                                         assert!(preimage.is_some());
2715                                 }
2716
2717                                 chan.sign_htlc_transaction(&mut htlc_tx, &remote_signature, &preimage, &htlc, &keys).unwrap();
2718                                 assert_eq!(serialize(&htlc_tx).unwrap()[..],
2719                                                 hex::decode($tx_hex).unwrap()[..]);
2720                         };
2721                 }
2722
2723                 {
2724                         // simple commitment tx with no HTLCs
2725                         chan.value_to_self_msat = 7000000000;
2726
2727                         test_commitment!("3045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c0",
2728                                          "3044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c3836939",
2729                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311054a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c383693901483045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2730                 }
2731
2732                 chan.pending_inbound_htlcs.push({
2733                         let mut out = InboundHTLCOutput{
2734                                 htlc_id: 0,
2735                                 amount_msat: 1000000,
2736                                 cltv_expiry: 500,
2737                                 payment_hash: [0; 32],
2738                                 state: InboundHTLCState::Committed,
2739                                 local_removed_fulfilled: false,
2740                                 pending_forward_state: None,
2741                         };
2742                         let mut sha = Sha256::new();
2743                         sha.input(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
2744                         sha.result(&mut out.payment_hash);
2745                         out
2746                 });
2747                 chan.pending_inbound_htlcs.push({
2748                         let mut out = InboundHTLCOutput{
2749                                 htlc_id: 1,
2750                                 amount_msat: 2000000,
2751                                 cltv_expiry: 501,
2752                                 payment_hash: [0; 32],
2753                                 state: InboundHTLCState::Committed,
2754                                 local_removed_fulfilled: false,
2755                                 pending_forward_state: None,
2756                         };
2757                         let mut sha = Sha256::new();
2758                         sha.input(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
2759                         sha.result(&mut out.payment_hash);
2760                         out
2761                 });
2762                 chan.pending_outbound_htlcs.push({
2763                         let mut out = OutboundHTLCOutput{
2764                                 htlc_id: 2,
2765                                 amount_msat: 2000000,
2766                                 cltv_expiry: 502,
2767                                 payment_hash: [0; 32],
2768                                 state: OutboundHTLCState::Committed,
2769                                 fail_reason: None,
2770                         };
2771                         let mut sha = Sha256::new();
2772                         sha.input(&hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap());
2773                         sha.result(&mut out.payment_hash);
2774                         out
2775                 });
2776                 chan.pending_outbound_htlcs.push({
2777                         let mut out = OutboundHTLCOutput{
2778                                 htlc_id: 3,
2779                                 amount_msat: 3000000,
2780                                 cltv_expiry: 503,
2781                                 payment_hash: [0; 32],
2782                                 state: OutboundHTLCState::Committed,
2783                                 fail_reason: None,
2784                         };
2785                         let mut sha = Sha256::new();
2786                         sha.input(&hex::decode("0303030303030303030303030303030303030303030303030303030303030303").unwrap());
2787                         sha.result(&mut out.payment_hash);
2788                         out
2789                 });
2790                 chan.pending_inbound_htlcs.push({
2791                         let mut out = InboundHTLCOutput{
2792                                 htlc_id: 4,
2793                                 amount_msat: 4000000,
2794                                 cltv_expiry: 504,
2795                                 payment_hash: [0; 32],
2796                                 state: InboundHTLCState::Committed,
2797                                 local_removed_fulfilled: false,
2798                                 pending_forward_state: None,
2799                         };
2800                         let mut sha = Sha256::new();
2801                         sha.input(&hex::decode("0404040404040404040404040404040404040404040404040404040404040404").unwrap());
2802                         sha.result(&mut out.payment_hash);
2803                         out
2804                 });
2805
2806                 {
2807                         // commitment tx with all five HTLCs untrimmed (minimum feerate)
2808                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2809                         chan.feerate_per_kw = 0;
2810
2811                         test_commitment!("304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b70606",
2812                                          "30440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f06",
2813                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f060147304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b7060601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2814
2815                         assert_eq!(unsigned_tx.1.len(), 5);
2816
2817                         test_htlc_output!(0,
2818                                           "304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a6",
2819                                           "304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5",
2820                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219700000000000000000001e8030000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a60147304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
2821
2822                         test_htlc_output!(1,
2823                                           "3045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b",
2824                                           "3045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be5",
2825                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219701000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b01483045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2826
2827                         test_htlc_output!(2,
2828                                           "304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f202",
2829                                           "3045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da",
2830                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219702000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f20201483045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
2831
2832                         test_htlc_output!(3,
2833                                           "3045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554",
2834                                           "30440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac08727",
2835                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219703000000000000000001b80b0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554014730440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac0872701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2836
2837                         test_htlc_output!(4,
2838                                           "304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d",
2839                                           "30440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e",
2840                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219704000000000000000001a00f0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d014730440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2841                 }
2842
2843                 {
2844                         // commitment tx with seven outputs untrimmed (maximum feerate)
2845                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2846                         chan.feerate_per_kw = 647;
2847
2848                         test_commitment!("3045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b",
2849                                          "304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d1163",
2850                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040048304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d116301483045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2851
2852                         assert_eq!(unsigned_tx.1.len(), 5);
2853
2854                         test_htlc_output!(0,
2855                                           "30440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab343740",
2856                                           "304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a",
2857                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab3437400147304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
2858
2859                         test_htlc_output!(1,
2860                                           "304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b0",
2861                                           "304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac",
2862                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60100000000000000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b00147304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2863
2864                         test_htlc_output!(2,
2865                                           "304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d833",
2866                                           "3045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877",
2867                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6020000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d83301483045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
2868
2869                         test_htlc_output!(3,
2870                                           "30450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d",
2871                                           "3045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb",
2872                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6030000000000000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d01483045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2873
2874                         test_htlc_output!(4,
2875                                           "3045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f0",
2876                                           "304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f",
2877                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb604000000000000000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f00147304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2878                 }
2879
2880                 {
2881                         // commitment tx with six outputs untrimmed (minimum feerate)
2882                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2883                         chan.feerate_per_kw = 648;
2884
2885                         test_commitment!("3044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b057",
2886                                          "3045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de",
2887                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431104e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de01473044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b05701475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2888
2889                         assert_eq!(unsigned_tx.1.len(), 4);
2890
2891                         test_htlc_output!(0,
2892                                           "3044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada8",
2893                                           "3045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc098",
2894                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10000000000000000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada801483045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc09801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2895
2896                         test_htlc_output!(1,
2897                                           "3045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d4",
2898                                           "304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0",
2899                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10100000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d40147304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
2900
2901                         test_htlc_output!(2,
2902                                           "3045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c2",
2903                                           "304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda3",
2904                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd1020000000000000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c20147304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda301008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2905
2906                         test_htlc_output!(3,
2907                                           "3044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f",
2908                                           "304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6",
2909                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd103000000000000000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f0147304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2910                 }
2911
2912                 {
2913                         // commitment tx with six outputs untrimmed (maximum feerate)
2914                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2915                         chan.feerate_per_kw = 2069;
2916
2917                         test_commitment!("3044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb4",
2918                                          "304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea",
2919                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311077956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea01473044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2920
2921                         assert_eq!(unsigned_tx.1.len(), 4);
2922
2923                         test_htlc_output!(0,
2924                                           "3045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f992",
2925                                           "3044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae66402",
2926                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0000000000000000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f99201473044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae6640201008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2927
2928                         test_htlc_output!(1,
2929                                           "3045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f4",
2930                                           "3045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f",
2931                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0100000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f401483045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
2932
2933                         test_htlc_output!(2,
2934                                           "3045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef18",
2935                                           "304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f9",
2936                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a020000000000000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef180147304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f901008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2937
2938                         test_htlc_output!(3,
2939                                           "30450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c",
2940                                           "304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5",
2941                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a03000000000000000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c0147304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2942                 }
2943
2944                 {
2945                         // commitment tx with five outputs untrimmed (minimum feerate)
2946                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2947                         chan.feerate_per_kw = 2070;
2948
2949                         test_commitment!("3045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f37526",
2950                                          "30440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd0",
2951                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd001483045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f3752601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2952
2953                         assert_eq!(unsigned_tx.1.len(), 3);
2954
2955                         test_htlc_output!(0,
2956                                           "3045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f891",
2957                                           "3045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb8",
2958                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a2180000000000000000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f89101483045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2959
2960                         test_htlc_output!(1,
2961                                           "3044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf6",
2962                                           "3045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d",
2963                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a218010000000000000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf601483045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2964
2965                         test_htlc_output!(2,
2966                                           "3045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a4",
2967                                           "304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04",
2968                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a21802000000000000000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a40147304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2969                 }
2970
2971                 {
2972                         // commitment tx with five outputs untrimmed (maximum feerate)
2973                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2974                         chan.feerate_per_kw = 2194;
2975
2976                         test_commitment!("3045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec86203953348",
2977                                          "304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f7061",
2978                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311040966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f706101483045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec8620395334801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2979
2980                         assert_eq!(unsigned_tx.1.len(), 3);
2981
2982                         test_htlc_output!(0,
2983                                           "30450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf44",
2984                                           "3044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f",
2985                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf4401473044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2986
2987                         test_htlc_output!(1,
2988                                           "30440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d",
2989                                           "304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c915",
2990                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a010000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d0147304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c91501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2991
2992                         test_htlc_output!(2,
2993                                           "3045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a",
2994                                           "3045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0",
2995                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a020000000000000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a01483045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2996                 }
2997
2998                 {
2999                         // commitment tx with four outputs untrimmed (minimum feerate)
3000                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
3001                         chan.feerate_per_kw = 2195;
3002
3003                         test_commitment!("304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb7924298",
3004                                          "304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a5429",
3005                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a54290147304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb792429801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3006
3007                         assert_eq!(unsigned_tx.1.len(), 2);
3008
3009                         test_htlc_output!(0,
3010                                           "3045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc",
3011                                           "3045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc704390",
3012                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0000000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc01483045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc70439001008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
3013
3014                         test_htlc_output!(1,
3015                                           "3045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92",
3016                                           "30440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8",
3017                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0100000000000000000199090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92014730440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
3018                 }
3019
3020                 {
3021                         // commitment tx with four outputs untrimmed (maximum feerate)
3022                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
3023                         chan.feerate_per_kw = 3702;
3024
3025                         test_commitment!("3045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c1",
3026                                          "304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b0",
3027                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431106f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b001483045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c101475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3028
3029                         assert_eq!(unsigned_tx.1.len(), 2);
3030
3031                         test_htlc_output!(0,
3032                                           "3045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb",
3033                                           "304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a",
3034                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb0147304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
3035
3036                         test_htlc_output!(1,
3037                                           "3045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9",
3038                                           "30440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c",
3039                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30100000000000000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9014730440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
3040                 }
3041
3042                 {
3043                         // commitment tx with three outputs untrimmed (minimum feerate)
3044                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
3045                         chan.feerate_per_kw = 3703;
3046
3047                         test_commitment!("30450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb0",
3048                                          "3044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506",
3049                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506014830450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3050
3051                         assert_eq!(unsigned_tx.1.len(), 1);
3052
3053                         test_htlc_output!(0,
3054                                           "3044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd",
3055                                           "3045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724",
3056                                           "020000000001011c076aa7fb3d7460d10df69432c904227ea84bbf3134d4ceee5fb0f135ef206d0000000000000000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd01483045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
3057                 }
3058
3059                 {
3060                         // commitment tx with three outputs untrimmed (maximum feerate)
3061                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
3062                         chan.feerate_per_kw = 4914;
3063
3064                         test_commitment!("304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e",
3065                                          "304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe26",
3066                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe260147304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3067
3068                         assert_eq!(unsigned_tx.1.len(), 1);
3069
3070                         test_htlc_output!(0,
3071                                           "3045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf",
3072                                           "304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68",
3073                                           "0200000000010110a3fdcbcd5db477cd3ad465e7f501ffa8c437e8301f00a6061138590add757f0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf0148304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
3074                 }
3075
3076                 {
3077                         // commitment tx with two outputs untrimmed (minimum feerate)
3078                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
3079                         chan.feerate_per_kw = 4915;
3080
3081                         test_commitment!("304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f8765552",
3082                                          "3045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b9",
3083                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b90147304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f876555201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3084
3085                         assert_eq!(unsigned_tx.1.len(), 0);
3086                 }
3087
3088                 {
3089                         // commitment tx with two outputs untrimmed (maximum feerate)
3090                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
3091                         chan.feerate_per_kw = 9651180;
3092
3093                         test_commitment!("3044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd",
3094                                          "30440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b9",
3095                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311004004730440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b901473044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3096
3097                         assert_eq!(unsigned_tx.1.len(), 0);
3098                 }
3099
3100                 {
3101                         // commitment tx with one output untrimmed (minimum feerate)
3102                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
3103                         chan.feerate_per_kw = 9651181;
3104
3105                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
3106                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
3107                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3108
3109                         assert_eq!(unsigned_tx.1.len(), 0);
3110                 }
3111
3112                 {
3113                         // commitment tx with fee greater than funder amount
3114                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
3115                         chan.feerate_per_kw = 9651936;
3116
3117                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
3118                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
3119                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3120
3121                         assert_eq!(unsigned_tx.1.len(), 0);
3122                 }
3123         }
3124
3125         #[test]
3126         fn test_per_commitment_secret_gen() {
3127                 // Test vectors from BOLT 3 Appendix D:
3128
3129                 let mut seed = [0; 32];
3130                 seed[0..32].clone_from_slice(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
3131                 assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655),
3132                            hex::decode("02a40c85b6f28da08dfdbe0926c53fab2de6d28c10301f8f7c4073d5e42e3148").unwrap()[..]);
3133
3134                 seed[0..32].clone_from_slice(&hex::decode("FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF").unwrap());
3135                 assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655),
3136                            hex::decode("7cc854b54e3e0dcdb010d7a3fee464a9687be6e8db3be6854c475621e007a5dc").unwrap()[..]);
3137
3138                 assert_eq!(chan_utils::build_commitment_secret(seed, 0xaaaaaaaaaaa),
3139                            hex::decode("56f4008fb007ca9acf0e15b054d5c9fd12ee06cea347914ddbaed70d1c13a528").unwrap()[..]);
3140
3141                 assert_eq!(chan_utils::build_commitment_secret(seed, 0x555555555555),
3142                            hex::decode("9015daaeb06dba4ccc05b91b2f73bd54405f2be9f217fbacd3c5ac2e62327d31").unwrap()[..]);
3143
3144                 seed[0..32].clone_from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
3145                 assert_eq!(chan_utils::build_commitment_secret(seed, 1),
3146                            hex::decode("915c75942a26bb3a433a8ce2cb0427c29ec6c1775cfc78328b57f6ba7bfeaa9c").unwrap()[..]);
3147         }
3148
3149         #[test]
3150         fn test_key_derivation() {
3151                 // Test vectors from BOLT 3 Appendix E:
3152                 let secp_ctx = Secp256k1::new();
3153
3154                 let base_secret = SecretKey::from_slice(&secp_ctx, &hex::decode("000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f").unwrap()[..]).unwrap();
3155                 let per_commitment_secret = SecretKey::from_slice(&secp_ctx, &hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
3156
3157                 let base_point = PublicKey::from_secret_key(&secp_ctx, &base_secret);
3158                 assert_eq!(base_point.serialize()[..], hex::decode("036d6caac248af96f6afa7f904f550253a0f3ef3f5aa2fe6838a95b216691468e2").unwrap()[..]);
3159
3160                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
3161                 assert_eq!(per_commitment_point.serialize()[..], hex::decode("025f7117a78150fe2ef97db7cfc83bd57b2e2c0d0dd25eaf467a4a1c2a45ce1486").unwrap()[..]);
3162
3163                 assert_eq!(chan_utils::derive_public_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
3164                                 hex::decode("0235f2dbfaa89b57ec7b055afe29849ef7ddfeb1cefdb9ebdc43f5494984db29e5").unwrap()[..]);
3165
3166                 assert_eq!(chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &base_secret).unwrap(),
3167                                 SecretKey::from_slice(&secp_ctx, &hex::decode("cbced912d3b21bf196a766651e436aff192362621ce317704ea2f75d87e7be0f").unwrap()[..]).unwrap());
3168
3169                 assert_eq!(chan_utils::derive_public_revocation_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
3170                                 hex::decode("02916e326636d19c33f13e8c0c3a03dd157f332f3e99c317c141dd865eb01f8ff0").unwrap()[..]);
3171
3172                 assert_eq!(chan_utils::derive_private_revocation_key(&secp_ctx, &per_commitment_secret, &base_secret).unwrap(),
3173                                 SecretKey::from_slice(&secp_ctx, &hex::decode("d09ffff62ddb2297ab000cc85bcb4283fdeb6aa052affbc9dddcf33b61078110").unwrap()[..]).unwrap());
3174         }
3175 }