47c05de2ab989ab69c00a8f219efb63adebb527a
[rust-lightning] / src / ln / channel.rs
1 use bitcoin::blockdata::block::BlockHeader;
2 use bitcoin::blockdata::script::{Script,Builder};
3 use bitcoin::blockdata::transaction::{TxIn, TxOut, Transaction, SigHashType};
4 use bitcoin::blockdata::opcodes;
5 use bitcoin::util::hash::{Sha256dHash, Hash160};
6 use bitcoin::util::bip143;
7 use bitcoin::network::serialize::BitcoinHash;
8
9 use secp256k1::key::{PublicKey,SecretKey};
10 use secp256k1::{Secp256k1,Message,Signature};
11 use secp256k1;
12
13 use crypto::digest::Digest;
14 use crypto::hkdf::{hkdf_extract,hkdf_expand};
15
16 use ln::msgs;
17 use ln::msgs::{ErrorAction, HandleError, MsgEncodable};
18 use ln::channelmonitor::ChannelMonitor;
19 use ln::channelmanager::{PendingHTLCStatus, PendingForwardHTLCInfo, HTLCFailReason};
20 use ln::chan_utils::{TxCreationKeys,HTLCOutputInCommitment,HTLC_SUCCESS_TX_WEIGHT,HTLC_TIMEOUT_TX_WEIGHT};
21 use ln::chan_utils;
22 use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
23 use chain::transaction::OutPoint;
24 use util::{transaction_utils,rng};
25 use util::sha2::Sha256;
26 use util::logger::Logger;
27 use util::errors::APIError;
28
29 use std;
30 use std::default::Default;
31 use std::{cmp,mem};
32 use std::time::Instant;
33 use std::sync::{Arc};
34
35 pub struct ChannelKeys {
36         pub funding_key: SecretKey,
37         pub revocation_base_key: SecretKey,
38         pub payment_base_key: SecretKey,
39         pub delayed_payment_base_key: SecretKey,
40         pub htlc_base_key: SecretKey,
41         pub channel_close_key: SecretKey,
42         pub channel_monitor_claim_key: SecretKey,
43         pub commitment_seed: [u8; 32],
44 }
45
46 impl ChannelKeys {
47         pub fn new_from_seed(seed: &[u8; 32]) -> Result<ChannelKeys, secp256k1::Error> {
48                 let mut prk = [0; 32];
49                 hkdf_extract(Sha256::new(), b"rust-lightning key gen salt", seed, &mut prk);
50                 let secp_ctx = Secp256k1::without_caps();
51
52                 let mut okm = [0; 32];
53                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning funding key info", &mut okm);
54                 let funding_key = SecretKey::from_slice(&secp_ctx, &okm)?;
55
56                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning revocation base key info", &mut okm);
57                 let revocation_base_key = SecretKey::from_slice(&secp_ctx, &okm)?;
58
59                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning payment base key info", &mut okm);
60                 let payment_base_key = SecretKey::from_slice(&secp_ctx, &okm)?;
61
62                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning delayed payment base key info", &mut okm);
63                 let delayed_payment_base_key = SecretKey::from_slice(&secp_ctx, &okm)?;
64
65                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning htlc base key info", &mut okm);
66                 let htlc_base_key = SecretKey::from_slice(&secp_ctx, &okm)?;
67
68                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning channel close key info", &mut okm);
69                 let channel_close_key = SecretKey::from_slice(&secp_ctx, &okm)?;
70
71                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning channel monitor claim key info", &mut okm);
72                 let channel_monitor_claim_key = SecretKey::from_slice(&secp_ctx, &okm)?;
73
74                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning local commitment seed info", &mut okm);
75
76                 Ok(ChannelKeys {
77                         funding_key: funding_key,
78                         revocation_base_key: revocation_base_key,
79                         payment_base_key: payment_base_key,
80                         delayed_payment_base_key: delayed_payment_base_key,
81                         htlc_base_key: htlc_base_key,
82                         channel_close_key: channel_close_key,
83                         channel_monitor_claim_key: channel_monitor_claim_key,
84                         commitment_seed: okm
85                 })
86         }
87 }
88
89 #[derive(PartialEq)]
90 enum HTLCState {
91         /// Added by remote, to be included in next local commitment tx.
92         /// Implies HTLCOutput::outbound: false
93         RemoteAnnounced,
94         /// Included in a received commitment_signed message (implying we've revoke_and_ack'ed it), but
95         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
96         /// accept this HTLC. Implies AwaitingRemoteRevoke.
97         /// We also have not yet included this HTLC in a commitment_signed message, and are waiting on
98         /// a remote revoke_and_ack on a previous state before we can do so.
99         /// Implies HTLCOutput::outbound: false
100         AwaitingRemoteRevokeToAnnounce,
101         /// Included in a received commitment_signed message (implying we've revoke_and_ack'ed it), but
102         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
103         /// accept this HTLC. Implies AwaitingRemoteRevoke.
104         /// We have included this HTLC in our latest commitment_signed and are now just waiting on a
105         /// revoke_and_ack.
106         /// Implies HTLCOutput::outbound: true
107         AwaitingAnnouncedRemoteRevoke,
108         /// Added by us and included in a commitment_signed (if we were AwaitingRemoteRevoke when we
109         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
110         /// we will promote to Committed (note that they may not accept it until the next time we
111         /// revoke, but we dont really care about that:
112         ///  * they've revoked, so worst case we can announce an old state and get our (option on)
113         ///    money back (though we wont), and,
114         ///  * we'll send them a revoke when they send a commitment_signed, and since only they're
115         ///    allowed to remove it, the "can only be removed once committed on both sides" requirement
116         ///    doesn't matter to us and its up to them to enforce it, worst-case they jump ahead but
117         ///    we'll never get out of sync).
118         /// Implies HTLCOutput::outbound: true
119         LocalAnnounced,
120         Committed,
121         /// Remote removed this (outbound) HTLC. We're waiting on their commitment_signed to finalize
122         /// the change (though they'll need to revoke before we fail the payment).
123         /// Implies HTLCOutput::outbound: true
124         RemoteRemoved,
125         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
126         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
127         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
128         /// We also have not yet removed this HTLC in a commitment_signed message, and are waiting on a
129         /// remote revoke_and_ack on a previous state before we can do so.
130         /// Implies HTLCOutput::outbound: true
131         AwaitingRemoteRevokeToRemove,
132         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
133         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
134         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
135         /// We have removed this HTLC in our latest commitment_signed and are now just waiting on a
136         /// revoke_and_ack to drop completely.
137         /// Implies HTLCOutput::outbound: true
138         AwaitingRemovedRemoteRevoke,
139         /// Removed by us and a new commitment_signed was sent (if we were AwaitingRemoteRevoke when we
140         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
141         /// we'll promote to LocalRemovedAwaitingCommitment if we fulfilled, otherwise we'll drop at
142         /// that point.
143         /// Note that we have to keep an eye on the HTLC until we've received a broadcastable
144         /// commitment transaction without it as otherwise we'll have to force-close the channel to
145         /// claim it before the timeout (obviously doesn't apply to revoked HTLCs that we can't claim
146         /// anyway).
147         /// Implies HTLCOutput::outbound: false
148         LocalRemoved,
149         /// Removed by us, sent a new commitment_signed and got a revoke_and_ack. Just waiting on an
150         /// updated local commitment transaction. Implies local_removed_fulfilled.
151         /// Implies HTLCOutput::outbound: false
152         LocalRemovedAwaitingCommitment,
153 }
154
155 struct HTLCOutput { //TODO: Refactor into Outbound/InboundHTLCOutput (will save memory and fewer panics)
156         outbound: bool, // ie to an HTLC-Timeout transaction
157         htlc_id: u64,
158         amount_msat: u64,
159         cltv_expiry: u32,
160         payment_hash: [u8; 32],
161         state: HTLCState,
162         /// If we're in a Remote* removed state, set if they failed, otherwise None
163         fail_reason: Option<HTLCFailReason>,
164         /// If we're in LocalRemoved*, set to true if we fulfilled the HTLC, and can claim money
165         local_removed_fulfilled: bool,
166         /// state pre-committed Remote* implies pending_forward_state, otherwise it must be None
167         pending_forward_state: Option<PendingHTLCStatus>,
168 }
169
170 impl HTLCOutput {
171         fn get_in_commitment(&self, offered: bool) -> HTLCOutputInCommitment {
172                 HTLCOutputInCommitment {
173                         offered: offered,
174                         amount_msat: self.amount_msat,
175                         cltv_expiry: self.cltv_expiry,
176                         payment_hash: self.payment_hash,
177                         transaction_output_index: 0
178                 }
179         }
180 }
181
182 /// See AwaitingRemoteRevoke ChannelState for more info
183 enum HTLCUpdateAwaitingACK {
184         AddHTLC {
185                 // always outbound
186                 amount_msat: u64,
187                 cltv_expiry: u32,
188                 payment_hash: [u8; 32],
189                 onion_routing_packet: msgs::OnionPacket,
190                 time_created: Instant, //TODO: Some kind of timeout thing-a-majig
191         },
192         ClaimHTLC {
193                 payment_preimage: [u8; 32],
194                 payment_hash: [u8; 32], // Only here for effecient duplicate detection
195         },
196         FailHTLC {
197                 payment_hash: [u8; 32],
198                 err_packet: msgs::OnionErrorPacket,
199         },
200 }
201
202 enum ChannelState {
203         /// Implies we have (or are prepared to) send our open_channel/accept_channel message
204         OurInitSent = (1 << 0),
205         /// Implies we have received their open_channel/accept_channel message
206         TheirInitSent = (1 << 1),
207         /// We have sent funding_created and are awaiting a funding_signed to advance to FundingSent.
208         /// Note that this is nonsense for an inbound channel as we immediately generate funding_signed
209         /// upon receipt of funding_created, so simply skip this state.
210         FundingCreated = 4,
211         /// Set when we have received/sent funding_created and funding_signed and are thus now waiting
212         /// on the funding transaction to confirm. The FundingLocked flags are set to indicate when we
213         /// and our counterparty consider the funding transaction confirmed.
214         FundingSent = 8,
215         /// Flag which can be set on FundingSent to indicate they sent us a funding_locked message.
216         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
217         TheirFundingLocked = (1 << 4),
218         /// Flag which can be set on FundingSent to indicate we sent them a funding_locked message.
219         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
220         OurFundingLocked = (1 << 5),
221         ChannelFunded = 64,
222         /// Flag which implies that we have sent a commitment_signed but are awaiting the responding
223         /// revoke_and_ack message. During this time period, we can't generate new commitment_signed
224         /// messages as then we will be unable to determine which HTLCs they included in their
225         /// revoke_and_ack implicit ACK, so instead we have to hold them away temporarily to be sent
226         /// later.
227         /// Flag is set on ChannelFunded.
228         AwaitingRemoteRevoke = (1 << 7),
229         /// Flag which is set on ChannelFunded or FundingSent after receiving a shutdown message from
230         /// the remote end. If set, they may not add any new HTLCs to the channel, and we are expected
231         /// to respond with our own shutdown message when possible.
232         RemoteShutdownSent = (1 << 8),
233         /// Flag which is set on ChannelFunded or FundingSent after sending a shutdown message. At this
234         /// point, we may not add any new HTLCs to the channel.
235         /// TODO: Investigate some kind of timeout mechanism by which point the remote end must provide
236         /// us their shutdown.
237         LocalShutdownSent = (1 << 9),
238         /// We've successfully negotiated a closing_signed dance. At this point ChannelManager is about
239         /// to drop us, but we store this anyway.
240         ShutdownComplete = (1 << 10),
241 }
242 const BOTH_SIDES_SHUTDOWN_MASK: u32 = (ChannelState::LocalShutdownSent as u32 | ChannelState::RemoteShutdownSent as u32);
243
244 // TODO: We should refactor this to be an Inbound/OutboundChannel until initial setup handshaking
245 // has been completed, and then turn into a Channel to get compiler-time enforcement of things like
246 // calling channel_id() before we're set up or things like get_outbound_funding_signed on an
247 // inbound channel.
248 pub struct Channel {
249         user_id: u64,
250
251         channel_id: [u8; 32],
252         channel_state: u32,
253         channel_outbound: bool,
254         secp_ctx: Secp256k1<secp256k1::All>,
255         announce_publicly: bool,
256         channel_value_satoshis: u64,
257
258         local_keys: ChannelKeys,
259
260         // Our commitment numbers start at 2^48-1 and count down, whereas the ones used in transaction
261         // generation start at 0 and count up...this simplifies some parts of implementation at the
262         // cost of others, but should really just be changed.
263
264         cur_local_commitment_transaction_number: u64,
265         cur_remote_commitment_transaction_number: u64,
266         value_to_self_msat: u64, // Excluding all pending_htlcs, excluding fees
267         pending_htlcs: Vec<HTLCOutput>,
268         holding_cell_htlc_updates: Vec<HTLCUpdateAwaitingACK>,
269         next_local_htlc_id: u64,
270         next_remote_htlc_id: u64,
271         channel_update_count: u32,
272         feerate_per_kw: u64,
273
274         #[cfg(test)]
275         // Used in ChannelManager's tests to send a revoked transaction
276         pub last_local_commitment_txn: Vec<Transaction>,
277         #[cfg(not(test))]
278         last_local_commitment_txn: Vec<Transaction>,
279
280         last_sent_closing_fee: Option<(u64, u64)>, // (feerate, fee)
281
282         /// The hash of the block in which the funding transaction reached our CONF_TARGET. We use this
283         /// to detect unconfirmation after a serialize-unserialize roudtrip where we may not see a full
284         /// series of block_connected/block_disconnected calls. Obviously this is not a guarantee as we
285         /// could miss the funding_tx_confirmed_in block as well, but it serves as a useful fallback.
286         funding_tx_confirmed_in: Option<Sha256dHash>,
287         short_channel_id: Option<u64>,
288         /// Used to deduplicate block_connected callbacks
289         last_block_connected: Sha256dHash,
290         funding_tx_confirmations: u64,
291
292         their_dust_limit_satoshis: u64,
293         our_dust_limit_satoshis: u64,
294         their_max_htlc_value_in_flight_msat: u64,
295         //get_our_max_htlc_value_in_flight_msat(): u64,
296         their_channel_reserve_satoshis: u64,
297         //get_our_channel_reserve_satoshis(): u64,
298         their_htlc_minimum_msat: u64,
299         our_htlc_minimum_msat: u64,
300         their_to_self_delay: u16,
301         //implied by BREAKDOWN_TIMEOUT: our_to_self_delay: u16,
302         their_max_accepted_htlcs: u16,
303         //implied by OUR_MAX_HTLCS: our_max_accepted_htlcs: u16,
304
305         their_funding_pubkey: Option<PublicKey>,
306         their_revocation_basepoint: Option<PublicKey>,
307         their_payment_basepoint: Option<PublicKey>,
308         their_delayed_payment_basepoint: Option<PublicKey>,
309         their_htlc_basepoint: Option<PublicKey>,
310         their_cur_commitment_point: Option<PublicKey>,
311
312         their_prev_commitment_point: Option<PublicKey>,
313         their_node_id: PublicKey,
314
315         their_shutdown_scriptpubkey: Option<Script>,
316
317         channel_monitor: ChannelMonitor,
318
319         logger: Arc<Logger>,
320 }
321
322 const OUR_MAX_HTLCS: u16 = 5; //TODO
323 /// Confirmation count threshold at which we close a channel. Ideally we'd keep the channel around
324 /// on ice until the funding transaction gets more confirmations, but the LN protocol doesn't
325 /// really allow for this, so instead we're stuck closing it out at that point.
326 const UNCONF_THRESHOLD: u32 = 6;
327 /// The amount of time we require our counterparty wait to claim their money (ie time between when
328 /// we, or our watchtower, must check for them having broadcast a theft transaction).
329 const BREAKDOWN_TIMEOUT: u16 = 6 * 24 * 7; //TODO?
330 /// The amount of time we're willing to wait to claim money back to us
331 const MAX_LOCAL_BREAKDOWN_TIMEOUT: u16 = 6 * 24 * 14;
332 const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
333 const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
334 const SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT: u64 = 79; // prevout: 36, nSequence: 4, script len: 1, witness lengths: (3+1)/4, sig: 73/4, if-selector: 1, redeemScript: (6 ops + 2*33 pubkeys + 1*2 delay)/4
335 const B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT: u64 = 104; // prevout: 40, nSequence: 4, script len: 1, witness lengths: 3/4, sig: 73/4, pubkey: 33/4, output: 31 (TODO: Wrong? Useless?)
336 /// Maximmum `funding_satoshis` value, according to the BOLT #2 specification
337 /// it's 2^24.
338 pub const MAX_FUNDING_SATOSHIS: u64 = (1 << 24);
339
340 macro_rules! secp_call {
341         ( $res: expr, $err: expr ) => {
342                 match $res {
343                         Ok(key) => key,
344                         //TODO: make the error a parameter
345                         Err(_) => return Err(HandleError{err: $err, action: Some(msgs::ErrorAction::DisconnectPeer{ msg: None })})
346                 }
347         };
348 }
349
350 macro_rules! secp_derived_key {
351         ( $res: expr ) => {
352                 secp_call!($res, "Derived invalid key, peer is maliciously selecting parameters")
353         }
354 }
355 impl Channel {
356         // Convert constants + channel value to limits:
357         fn get_our_max_htlc_value_in_flight_msat(channel_value_satoshis: u64) -> u64 {
358                 channel_value_satoshis * 1000 / 10 //TODO
359         }
360
361         /// Guaranteed to return a value no larger than channel_value_satoshis
362         fn get_our_channel_reserve_satoshis(channel_value_satoshis: u64) -> u64 {
363                 let (q, _) = channel_value_satoshis.overflowing_div(100);
364                 cmp::min(channel_value_satoshis, cmp::max(q, 1000)) //TODO
365         }
366
367         fn derive_our_dust_limit_satoshis(at_open_background_feerate: u64) -> u64 {
368                 at_open_background_feerate * B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT / 1000 //TODO
369         }
370
371         fn derive_our_htlc_minimum_msat(_at_open_channel_feerate_per_kw: u64) -> u64 {
372                 1000 // TODO
373         }
374
375         fn derive_minimum_depth(_channel_value_satoshis_msat: u64, _value_to_self_msat: u64) -> u32 {
376                 const CONF_TARGET: u32 = 12; //TODO: Should be much higher
377                 CONF_TARGET
378         }
379
380         fn derive_maximum_minimum_depth(_channel_value_satoshis_msat: u64, _value_to_self_msat: u64) -> u32 {
381                 const CONF_TARGET: u32 = 12; //TODO: Should be much higher
382                 CONF_TARGET * 2
383         }
384
385         // Constructors:
386         pub fn new_outbound(fee_estimator: &FeeEstimator, chan_keys: ChannelKeys, their_node_id: PublicKey, channel_value_satoshis: u64, push_msat: u64, announce_publicly: bool, user_id: u64, logger: Arc<Logger>) -> Result<Channel, APIError> {
387                 if channel_value_satoshis >= MAX_FUNDING_SATOSHIS {
388                         return Err(APIError::APIMisuseError{err: "funding value > 2^24"});
389                 }
390
391                 if push_msat > channel_value_satoshis * 1000 {
392                         return Err(APIError::APIMisuseError{err: "push value > channel value"});
393                 }
394
395
396                 let background_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
397                 if Channel::get_our_channel_reserve_satoshis(channel_value_satoshis) < Channel::derive_our_dust_limit_satoshis(background_feerate) {
398                         return Err(APIError::FeeRateTooHigh{err: format!("Not enough reserve above dust limit can be found at current fee rate({})", background_feerate), feerate: background_feerate});
399                 }
400
401                 let feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
402
403                 let secp_ctx = Secp256k1::new();
404                 let our_channel_monitor_claim_key_hash = Hash160::from_data(&PublicKey::from_secret_key(&secp_ctx, &chan_keys.channel_monitor_claim_key).serialize());
405                 let our_channel_monitor_claim_script = Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&our_channel_monitor_claim_key_hash[..]).into_script();
406                 let channel_monitor = ChannelMonitor::new(&chan_keys.revocation_base_key,
407                                                           &PublicKey::from_secret_key(&secp_ctx, &chan_keys.delayed_payment_base_key),
408                                                           &chan_keys.htlc_base_key,
409                                                           BREAKDOWN_TIMEOUT, our_channel_monitor_claim_script);
410
411                 Ok(Channel {
412                         user_id: user_id,
413
414                         channel_id: rng::rand_u832(),
415                         channel_state: ChannelState::OurInitSent as u32,
416                         channel_outbound: true,
417                         secp_ctx: secp_ctx,
418                         announce_publicly: announce_publicly,
419                         channel_value_satoshis: channel_value_satoshis,
420
421                         local_keys: chan_keys,
422                         cur_local_commitment_transaction_number: (1 << 48) - 1,
423                         cur_remote_commitment_transaction_number: (1 << 48) - 1,
424                         value_to_self_msat: channel_value_satoshis * 1000 - push_msat,
425                         pending_htlcs: Vec::new(),
426                         holding_cell_htlc_updates: Vec::new(),
427                         next_local_htlc_id: 0,
428                         next_remote_htlc_id: 0,
429                         channel_update_count: 1,
430
431                         last_local_commitment_txn: Vec::new(),
432
433                         last_sent_closing_fee: None,
434
435                         funding_tx_confirmed_in: None,
436                         short_channel_id: None,
437                         last_block_connected: Default::default(),
438                         funding_tx_confirmations: 0,
439
440                         feerate_per_kw: feerate,
441                         their_dust_limit_satoshis: 0,
442                         our_dust_limit_satoshis: Channel::derive_our_dust_limit_satoshis(background_feerate),
443                         their_max_htlc_value_in_flight_msat: 0,
444                         their_channel_reserve_satoshis: 0,
445                         their_htlc_minimum_msat: 0,
446                         our_htlc_minimum_msat: Channel::derive_our_htlc_minimum_msat(feerate),
447                         their_to_self_delay: 0,
448                         their_max_accepted_htlcs: 0,
449
450                         their_funding_pubkey: None,
451                         their_revocation_basepoint: None,
452                         their_payment_basepoint: None,
453                         their_delayed_payment_basepoint: None,
454                         their_htlc_basepoint: None,
455                         their_cur_commitment_point: None,
456
457                         their_prev_commitment_point: None,
458                         their_node_id: their_node_id,
459
460                         their_shutdown_scriptpubkey: None,
461
462                         channel_monitor: channel_monitor,
463
464                         logger,
465                 })
466         }
467
468         fn check_remote_fee(fee_estimator: &FeeEstimator, feerate_per_kw: u32) -> Result<(), HandleError> {
469                 if (feerate_per_kw as u64) < fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background) {
470                         return Err(HandleError{err: "Peer's feerate much too low", action: Some(msgs::ErrorAction::DisconnectPeer{ msg: None })});
471                 }
472                 if (feerate_per_kw as u64) > fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority) * 2 {
473                         return Err(HandleError{err: "Peer's feerate much too high", action: Some(msgs::ErrorAction::DisconnectPeer{ msg: None })});
474                 }
475                 Ok(())
476         }
477
478         /// Creates a new channel from a remote sides' request for one.
479         /// Assumes chain_hash has already been checked and corresponds with what we expect!
480         /// Generally prefers to take the DisconnectPeer action on failure, as a notice to the sender
481         /// that we're rejecting the new channel.
482         pub fn new_from_req(fee_estimator: &FeeEstimator, chan_keys: ChannelKeys, their_node_id: PublicKey, msg: &msgs::OpenChannel, user_id: u64, require_announce: bool, allow_announce: bool, logger: Arc<Logger>) -> Result<Channel, HandleError> {
483                 macro_rules! return_error_message {
484                         ( $msg: expr ) => {
485                                 return Err(HandleError{err: $msg, action: Some(msgs::ErrorAction::SendErrorMessage{ msg: msgs::ErrorMessage { channel_id: msg.temporary_channel_id, data: $msg.to_string() }})});
486                         }
487                 }
488
489                 // Check sanity of message fields:
490                 if msg.funding_satoshis >= MAX_FUNDING_SATOSHIS {
491                         return_error_message!("funding value > 2^24");
492                 }
493                 if msg.channel_reserve_satoshis > msg.funding_satoshis {
494                         return_error_message!("Bogus channel_reserve_satoshis");
495                 }
496                 if msg.push_msat > (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
497                         return_error_message!("push_msat larger than funding value");
498                 }
499                 if msg.dust_limit_satoshis > msg.funding_satoshis {
500                         return_error_message!("Peer never wants payout outputs?");
501                 }
502                 if msg.dust_limit_satoshis > msg.channel_reserve_satoshis {
503                         return_error_message!("Bogus; channel reserve is less than dust limit");
504                 }
505                 if msg.htlc_minimum_msat >= (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
506                         return_error_message!("Miminum htlc value is full channel value");
507                 }
508                 Channel::check_remote_fee(fee_estimator, msg.feerate_per_kw).map_err(|e|
509                         HandleError{err: e.err, action: Some(msgs::ErrorAction::SendErrorMessage{ msg: msgs::ErrorMessage { channel_id: msg.temporary_channel_id, data: e.err.to_string() }})}
510                 )?;
511
512                 if msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
513                         return_error_message!("They wanted our payments to be delayed by a needlessly long period");
514                 }
515                 if msg.max_accepted_htlcs < 1 {
516                         return_error_message!("0 max_accpted_htlcs makes for a useless channel");
517                 }
518                 if msg.max_accepted_htlcs > 483 {
519                         return_error_message!("max_accpted_htlcs > 483");
520                 }
521
522                 // Convert things into internal flags and prep our state:
523
524                 let their_announce = if (msg.channel_flags & 1) == 1 { true } else { false };
525                 if require_announce && !their_announce {
526                         return Err(HandleError{err: "Peer tried to open unannounced channel, but we require public ones", action: Some(msgs::ErrorAction::IgnoreError) });
527                 }
528                 if !allow_announce && their_announce {
529                         return Err(HandleError{err: "Peer tried to open announced channel, but we require private ones", action: Some(msgs::ErrorAction::IgnoreError) });
530                 }
531
532                 let background_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
533
534                 let our_dust_limit_satoshis = Channel::derive_our_dust_limit_satoshis(background_feerate);
535                 let our_channel_reserve_satoshis = Channel::get_our_channel_reserve_satoshis(msg.funding_satoshis);
536                 if our_channel_reserve_satoshis < our_dust_limit_satoshis {
537                         return_error_message!("Suitalbe channel reserve not found. aborting");
538                 }
539                 if msg.channel_reserve_satoshis < our_dust_limit_satoshis {
540                         return_error_message!("channel_reserve_satoshis too small");
541                 }
542                 if our_channel_reserve_satoshis < msg.dust_limit_satoshis {
543                         return_error_message!("Dust limit too high for our channel reserve");
544                 }
545
546                 // check if the funder's amount for the initial commitment tx is sufficient
547                 // for full fee payment
548                 let funders_amount_msat = msg.funding_satoshis * 1000 - msg.push_msat;
549                 if funders_amount_msat < background_feerate * COMMITMENT_TX_BASE_WEIGHT {
550                         return_error_message!("Insufficient funding amount for initial commitment");
551                 }
552
553                 let to_local_msat = msg.push_msat;
554                 let to_remote_msat = funders_amount_msat - background_feerate * COMMITMENT_TX_BASE_WEIGHT;
555                 if to_local_msat <= msg.channel_reserve_satoshis * 1000 && to_remote_msat <= our_channel_reserve_satoshis * 1000 {
556                         return_error_message!("Insufficient funding amount for initial commitment");
557                 }
558
559                 let secp_ctx = Secp256k1::new();
560                 let our_channel_monitor_claim_key_hash = Hash160::from_data(&PublicKey::from_secret_key(&secp_ctx, &chan_keys.channel_monitor_claim_key).serialize());
561                 let our_channel_monitor_claim_script = Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&our_channel_monitor_claim_key_hash[..]).into_script();
562                 let mut channel_monitor = ChannelMonitor::new(&chan_keys.revocation_base_key,
563                                                               &PublicKey::from_secret_key(&secp_ctx, &chan_keys.delayed_payment_base_key),
564                                                               &chan_keys.htlc_base_key,
565                                                               BREAKDOWN_TIMEOUT, our_channel_monitor_claim_script);
566                 channel_monitor.set_their_htlc_base_key(&msg.htlc_basepoint);
567                 channel_monitor.set_their_to_self_delay(msg.to_self_delay);
568
569                 let mut chan = Channel {
570                         user_id: user_id,
571
572                         channel_id: msg.temporary_channel_id,
573                         channel_state: (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32),
574                         channel_outbound: false,
575                         secp_ctx: secp_ctx,
576                         announce_publicly: their_announce,
577
578                         local_keys: chan_keys,
579                         cur_local_commitment_transaction_number: (1 << 48) - 1,
580                         cur_remote_commitment_transaction_number: (1 << 48) - 1,
581                         value_to_self_msat: msg.push_msat,
582                         pending_htlcs: Vec::new(),
583                         holding_cell_htlc_updates: Vec::new(),
584                         next_local_htlc_id: 0,
585                         next_remote_htlc_id: 0,
586                         channel_update_count: 1,
587
588                         last_local_commitment_txn: Vec::new(),
589
590                         last_sent_closing_fee: None,
591
592                         funding_tx_confirmed_in: None,
593                         short_channel_id: None,
594                         last_block_connected: Default::default(),
595                         funding_tx_confirmations: 0,
596
597                         feerate_per_kw: msg.feerate_per_kw as u64,
598                         channel_value_satoshis: msg.funding_satoshis,
599                         their_dust_limit_satoshis: msg.dust_limit_satoshis,
600                         our_dust_limit_satoshis: our_dust_limit_satoshis,
601                         their_max_htlc_value_in_flight_msat: cmp::min(msg.max_htlc_value_in_flight_msat, msg.funding_satoshis * 1000),
602                         their_channel_reserve_satoshis: msg.channel_reserve_satoshis,
603                         their_htlc_minimum_msat: msg.htlc_minimum_msat,
604                         our_htlc_minimum_msat: Channel::derive_our_htlc_minimum_msat(msg.feerate_per_kw as u64),
605                         their_to_self_delay: msg.to_self_delay,
606                         their_max_accepted_htlcs: msg.max_accepted_htlcs,
607
608                         their_funding_pubkey: Some(msg.funding_pubkey),
609                         their_revocation_basepoint: Some(msg.revocation_basepoint),
610                         their_payment_basepoint: Some(msg.payment_basepoint),
611                         their_delayed_payment_basepoint: Some(msg.delayed_payment_basepoint),
612                         their_htlc_basepoint: Some(msg.htlc_basepoint),
613                         their_cur_commitment_point: Some(msg.first_per_commitment_point),
614
615                         their_prev_commitment_point: None,
616                         their_node_id: their_node_id,
617
618                         their_shutdown_scriptpubkey: None,
619
620                         channel_monitor: channel_monitor,
621
622                         logger,
623                 };
624
625                 let obscure_factor = chan.get_commitment_transaction_number_obscure_factor();
626                 chan.channel_monitor.set_commitment_obscure_factor(obscure_factor);
627
628                 Ok(chan)
629         }
630
631         // Utilities to derive keys:
632
633         fn build_local_commitment_secret(&self, idx: u64) -> SecretKey {
634                 let res = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, idx);
635                 SecretKey::from_slice(&self.secp_ctx, &res).unwrap()
636         }
637
638         // Utilities to build transactions:
639
640         fn get_commitment_transaction_number_obscure_factor(&self) -> u64 {
641                 let mut sha = Sha256::new();
642                 let our_payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key);
643
644                 if self.channel_outbound {
645                         sha.input(&our_payment_basepoint.serialize());
646                         sha.input(&self.their_payment_basepoint.unwrap().serialize());
647                 } else {
648                         sha.input(&self.their_payment_basepoint.unwrap().serialize());
649                         sha.input(&our_payment_basepoint.serialize());
650                 }
651                 let mut res = [0; 32];
652                 sha.result(&mut res);
653
654                 ((res[26] as u64) << 5*8) |
655                 ((res[27] as u64) << 4*8) |
656                 ((res[28] as u64) << 3*8) |
657                 ((res[29] as u64) << 2*8) |
658                 ((res[30] as u64) << 1*8) |
659                 ((res[31] as u64) << 0*8)
660         }
661
662         /// Transaction nomenclature is somewhat confusing here as there are many different cases - a
663         /// transaction is referred to as "a's transaction" implying that a will be able to broadcast
664         /// the transaction. Thus, b will generally be sending a signature over such a transaction to
665         /// a, and a can revoke the transaction by providing b the relevant per_commitment_secret. As
666         /// such, a transaction is generally the result of b increasing the amount paid to a (or adding
667         /// an HTLC to a).
668         /// @local is used only to convert relevant internal structures which refer to remote vs local
669         /// to decide value of outputs and direction of HTLCs.
670         /// @generated_by_local is used to determine *which* HTLCs to include - noting that the HTLC
671         /// state may indicate that one peer has informed the other that they'd like to add an HTLC but
672         /// have not yet committed it. Such HTLCs will only be included in transactions which are being
673         /// generated by the peer which proposed adding the HTLCs, and thus we need to understand both
674         /// which peer generated this transaction and "to whom" this transaction flows.
675         #[inline]
676         fn build_commitment_transaction(&self, commitment_number: u64, keys: &TxCreationKeys, local: bool, generated_by_local: bool) -> (Transaction, Vec<HTLCOutputInCommitment>) {
677                 let obscured_commitment_transaction_number = self.get_commitment_transaction_number_obscure_factor() ^ (0xffffffffffff - commitment_number);
678
679                 let txins = {
680                         let mut ins: Vec<TxIn> = Vec::new();
681                         ins.push(TxIn {
682                                 previous_output: self.channel_monitor.get_funding_txo().unwrap().into_bitcoin_outpoint(),
683                                 script_sig: Script::new(),
684                                 sequence: ((0x80 as u32) << 8*3) | ((obscured_commitment_transaction_number >> 3*8) as u32),
685                                 witness: Vec::new(),
686                         });
687                         ins
688                 };
689
690                 let mut txouts: Vec<(TxOut, Option<HTLCOutputInCommitment>)> = Vec::with_capacity(self.pending_htlcs.len() + 2);
691
692                 let dust_limit_satoshis = if local { self.our_dust_limit_satoshis } else { self.their_dust_limit_satoshis };
693                 let mut remote_htlc_total_msat = 0;
694                 let mut local_htlc_total_msat = 0;
695                 let mut value_to_self_msat_offset = 0;
696
697                 for ref htlc in self.pending_htlcs.iter() {
698                         let include = match htlc.state {
699                                 HTLCState::RemoteAnnounced => !generated_by_local,
700                                 HTLCState::AwaitingRemoteRevokeToAnnounce => !generated_by_local,
701                                 HTLCState::AwaitingAnnouncedRemoteRevoke => true,
702                                 HTLCState::LocalAnnounced => generated_by_local,
703                                 HTLCState::Committed => true,
704                                 HTLCState::RemoteRemoved => generated_by_local,
705                                 HTLCState::AwaitingRemoteRevokeToRemove => generated_by_local,
706                                 HTLCState::AwaitingRemovedRemoteRevoke => false,
707                                 HTLCState::LocalRemoved => !generated_by_local,
708                                 HTLCState::LocalRemovedAwaitingCommitment => false,
709                         };
710
711                         if include {
712                                 if htlc.outbound == local { // "offered HTLC output"
713                                         if htlc.amount_msat / 1000 >= dust_limit_satoshis + (self.feerate_per_kw * HTLC_TIMEOUT_TX_WEIGHT / 1000) {
714                                                 let htlc_in_tx = htlc.get_in_commitment(true);
715                                                 txouts.push((TxOut {
716                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys).to_v0_p2wsh(),
717                                                         value: htlc.amount_msat / 1000
718                                                 }, Some(htlc_in_tx)));
719                                         }
720                                 } else {
721                                         if htlc.amount_msat / 1000 >= dust_limit_satoshis + (self.feerate_per_kw * HTLC_SUCCESS_TX_WEIGHT / 1000) {
722                                                 let htlc_in_tx = htlc.get_in_commitment(false);
723                                                 txouts.push((TxOut { // "received HTLC output"
724                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys).to_v0_p2wsh(),
725                                                         value: htlc.amount_msat / 1000
726                                                 }, Some(htlc_in_tx)));
727                                         }
728                                 };
729                                 if htlc.outbound {
730                                         local_htlc_total_msat += htlc.amount_msat;
731                                 } else {
732                                         remote_htlc_total_msat += htlc.amount_msat;
733                                 }
734                         } else {
735                                 match htlc.state {
736                                         HTLCState::AwaitingRemoteRevokeToRemove|HTLCState::AwaitingRemovedRemoteRevoke => {
737                                                 if htlc.fail_reason.is_none() {
738                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
739                                                 }
740                                         },
741                                         HTLCState::RemoteRemoved => {
742                                                 if !generated_by_local && htlc.fail_reason.is_none() {
743                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
744                                                 }
745                                         },
746                                         HTLCState::LocalRemoved => {
747                                                 if generated_by_local && htlc.local_removed_fulfilled {
748                                                         value_to_self_msat_offset += htlc.amount_msat as i64;
749                                                 }
750                                         },
751                                         HTLCState::LocalRemovedAwaitingCommitment => {
752                                                 assert!(htlc.local_removed_fulfilled);
753                                                 value_to_self_msat_offset += htlc.amount_msat as i64;
754                                         },
755                                         _ => {},
756                                 }
757                         }
758                 }
759
760                 let total_fee: u64 = self.feerate_per_kw * (COMMITMENT_TX_BASE_WEIGHT + (txouts.len() as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
761                 let value_to_self: i64 = ((self.value_to_self_msat - local_htlc_total_msat) as i64 + value_to_self_msat_offset) / 1000 - if self.channel_outbound { total_fee as i64 } else { 0 };
762                 let value_to_remote: i64 = (((self.channel_value_satoshis * 1000 - self.value_to_self_msat - remote_htlc_total_msat) as i64 - value_to_self_msat_offset) / 1000) - if self.channel_outbound { 0 } else { total_fee as i64 };
763
764                 let value_to_a = if local { value_to_self } else { value_to_remote };
765                 let value_to_b = if local { value_to_remote } else { value_to_self };
766
767                 if value_to_a >= (dust_limit_satoshis as i64) {
768                         txouts.push((TxOut {
769                                 script_pubkey: chan_utils::get_revokeable_redeemscript(&keys.revocation_key,
770                                                                                        if local { self.their_to_self_delay } else { BREAKDOWN_TIMEOUT },
771                                                                                        &keys.a_delayed_payment_key).to_v0_p2wsh(),
772                                 value: value_to_a as u64
773                         }, None));
774                 }
775
776                 if value_to_b >= (dust_limit_satoshis as i64) {
777                         txouts.push((TxOut {
778                                 script_pubkey: Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0)
779                                                              .push_slice(&Hash160::from_data(&keys.b_payment_key.serialize())[..])
780                                                              .into_script(),
781                                 value: value_to_b as u64
782                         }, None));
783                 }
784
785                 transaction_utils::sort_outputs(&mut txouts);
786
787                 let mut outputs: Vec<TxOut> = Vec::with_capacity(txouts.len());
788                 let mut htlcs_used: Vec<HTLCOutputInCommitment> = Vec::with_capacity(txouts.len());
789                 for (idx, out) in txouts.drain(..).enumerate() {
790                         outputs.push(out.0);
791                         if let Some(out_htlc) = out.1 {
792                                 htlcs_used.push(out_htlc);
793                                 htlcs_used.last_mut().unwrap().transaction_output_index = idx as u32;
794                         }
795                 }
796
797                 (Transaction {
798                         version: 2,
799                         lock_time: ((0x20 as u32) << 8*3) | ((obscured_commitment_transaction_number & 0xffffffu64) as u32),
800                         input: txins,
801                         output: outputs,
802                 }, htlcs_used)
803         }
804
805         #[inline]
806         fn get_closing_scriptpubkey(&self) -> Script {
807                 let our_channel_close_key_hash = Hash160::from_data(&PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.channel_close_key).serialize());
808                 Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&our_channel_close_key_hash[..]).into_script()
809         }
810
811         #[inline]
812         fn get_closing_transaction_weight(a_scriptpubkey: &Script, b_scriptpubkey: &Script) -> u64 {
813                 (4 + 1 + 36 + 4 + 1 + 1 + 2*(8+1) + 4 + a_scriptpubkey.len() as u64 + b_scriptpubkey.len() as u64)*4 + 2 + 1 + 1 + 2*(1 + 72)
814         }
815
816         #[inline]
817         fn build_closing_transaction(&self, proposed_total_fee_satoshis: u64, skip_remote_output: bool) -> (Transaction, u64) {
818                 let txins = {
819                         let mut ins: Vec<TxIn> = Vec::new();
820                         ins.push(TxIn {
821                                 previous_output: self.channel_monitor.get_funding_txo().unwrap().into_bitcoin_outpoint(),
822                                 script_sig: Script::new(),
823                                 sequence: 0xffffffff,
824                                 witness: Vec::new(),
825                         });
826                         ins
827                 };
828
829                 assert!(self.pending_htlcs.is_empty());
830                 let mut txouts: Vec<(TxOut, ())> = Vec::new();
831
832                 let mut total_fee_satoshis = proposed_total_fee_satoshis;
833                 let value_to_self: i64 = (self.value_to_self_msat as i64) / 1000 - if self.channel_outbound { total_fee_satoshis as i64 } else { 0 };
834                 let value_to_remote: i64 = ((self.channel_value_satoshis * 1000 - self.value_to_self_msat) as i64 / 1000) - if self.channel_outbound { 0 } else { total_fee_satoshis as i64 };
835
836                 if value_to_self < 0 {
837                         assert!(self.channel_outbound);
838                         total_fee_satoshis += (-value_to_self) as u64;
839                 } else if value_to_remote < 0 {
840                         assert!(!self.channel_outbound);
841                         total_fee_satoshis += (-value_to_remote) as u64;
842                 }
843
844                 if !skip_remote_output && value_to_remote as u64 > self.our_dust_limit_satoshis {
845                         txouts.push((TxOut {
846                                 script_pubkey: self.their_shutdown_scriptpubkey.clone().unwrap(),
847                                 value: value_to_remote as u64
848                         }, ()));
849                 }
850
851                 if value_to_self as u64 > self.our_dust_limit_satoshis {
852                         txouts.push((TxOut {
853                                 script_pubkey: self.get_closing_scriptpubkey(),
854                                 value: value_to_self as u64
855                         }, ()));
856                 }
857
858                 transaction_utils::sort_outputs(&mut txouts);
859
860                 let mut outputs: Vec<TxOut> = Vec::new();
861                 for out in txouts.drain(..) {
862                         outputs.push(out.0);
863                 }
864
865                 (Transaction {
866                         version: 2,
867                         lock_time: 0,
868                         input: txins,
869                         output: outputs,
870                 }, total_fee_satoshis)
871         }
872
873         #[inline]
874         /// Creates a set of keys for build_commitment_transaction to generate a transaction which our
875         /// counterparty will sign (ie DO NOT send signatures over a transaction created by this to
876         /// our counterparty!)
877         /// The result is a transaction which we can revoke ownership of (ie a "local" transaction)
878         /// TODO Some magic rust shit to compile-time check this?
879         fn build_local_transaction_keys(&self, commitment_number: u64) -> Result<TxCreationKeys, HandleError> {
880                 let per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(commitment_number));
881                 let delayed_payment_base = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key);
882                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key);
883
884                 Ok(secp_derived_key!(TxCreationKeys::new(&self.secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &self.their_revocation_basepoint.unwrap(), &self.their_payment_basepoint.unwrap(), &self.their_htlc_basepoint.unwrap())))
885         }
886
887         #[inline]
888         /// Creates a set of keys for build_commitment_transaction to generate a transaction which we
889         /// will sign and send to our counterparty.
890         fn build_remote_transaction_keys(&self) -> Result<TxCreationKeys, HandleError> {
891                 //TODO: Ensure that the payment_key derived here ends up in the library users' wallet as we
892                 //may see payments to it!
893                 let payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key);
894                 let revocation_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key);
895                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key);
896
897                 Ok(secp_derived_key!(TxCreationKeys::new(&self.secp_ctx, &self.their_cur_commitment_point.unwrap(), &self.their_delayed_payment_basepoint.unwrap(), &self.their_htlc_basepoint.unwrap(), &revocation_basepoint, &payment_basepoint, &htlc_basepoint)))
898         }
899
900         /// Gets the redeemscript for the funding transaction output (ie the funding transaction output
901         /// pays to get_funding_redeemscript().to_v0_p2wsh()).
902         pub fn get_funding_redeemscript(&self) -> Script {
903                 let builder = Builder::new().push_opcode(opcodes::All::OP_PUSHNUM_2);
904                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).serialize();
905                 let their_funding_key = self.their_funding_pubkey.unwrap().serialize();
906                 if our_funding_key[..] < their_funding_key[..] {
907                         builder.push_slice(&our_funding_key)
908                                 .push_slice(&their_funding_key)
909                 } else {
910                         builder.push_slice(&their_funding_key)
911                                 .push_slice(&our_funding_key)
912                 }.push_opcode(opcodes::All::OP_PUSHNUM_2).push_opcode(opcodes::All::OP_CHECKMULTISIG).into_script()
913         }
914
915         fn sign_commitment_transaction(&self, tx: &mut Transaction, their_sig: &Signature) -> Signature {
916                 if tx.input.len() != 1 {
917                         panic!("Tried to sign commitment transaction that had input count != 1!");
918                 }
919                 if tx.input[0].witness.len() != 0 {
920                         panic!("Tried to re-sign commitment transaction");
921                 }
922
923                 let funding_redeemscript = self.get_funding_redeemscript();
924
925                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&tx).sighash_all(&tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
926                 let our_sig = self.secp_ctx.sign(&sighash, &self.local_keys.funding_key);
927
928                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
929
930                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).serialize();
931                 let their_funding_key = self.their_funding_pubkey.unwrap().serialize();
932                 if our_funding_key[..] < their_funding_key[..] {
933                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
934                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
935                 } else {
936                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
937                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
938                 }
939                 tx.input[0].witness[1].push(SigHashType::All as u8);
940                 tx.input[0].witness[2].push(SigHashType::All as u8);
941
942                 tx.input[0].witness.push(funding_redeemscript.into_bytes());
943
944                 our_sig
945         }
946
947         /// Builds the htlc-success or htlc-timeout transaction which spends a given HTLC output
948         /// @local is used only to convert relevant internal structures which refer to remote vs local
949         /// to decide value of outputs and direction of HTLCs.
950         fn build_htlc_transaction(&self, prev_hash: &Sha256dHash, htlc: &HTLCOutputInCommitment, local: bool, keys: &TxCreationKeys) -> Transaction {
951                 chan_utils::build_htlc_transaction(prev_hash, self.feerate_per_kw, if local { self.their_to_self_delay } else { BREAKDOWN_TIMEOUT }, htlc, &keys.a_delayed_payment_key, &keys.revocation_key)
952         }
953
954         fn create_htlc_tx_signature(&self, tx: &Transaction, htlc: &HTLCOutputInCommitment, keys: &TxCreationKeys) -> Result<(Script, Signature, bool), HandleError> {
955                 if tx.input.len() != 1 {
956                         panic!("Tried to sign HTLC transaction that had input count != 1!");
957                 }
958
959                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys);
960
961                 let our_htlc_key = secp_derived_key!(chan_utils::derive_private_key(&self.secp_ctx, &keys.per_commitment_point, &self.local_keys.htlc_base_key));
962                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&tx).sighash_all(&tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
963                 let is_local_tx = PublicKey::from_secret_key(&self.secp_ctx, &our_htlc_key) == keys.a_htlc_key;
964                 Ok((htlc_redeemscript, self.secp_ctx.sign(&sighash, &our_htlc_key), is_local_tx))
965         }
966
967         /// Signs a transaction created by build_htlc_transaction. If the transaction is an
968         /// HTLC-Success transaction (ie htlc.offered is false), preimate must be set!
969         fn sign_htlc_transaction(&self, tx: &mut Transaction, their_sig: &Signature, preimage: &Option<[u8; 32]>, htlc: &HTLCOutputInCommitment, keys: &TxCreationKeys) -> Result<Signature, HandleError> {
970                 if tx.input.len() != 1 {
971                         panic!("Tried to sign HTLC transaction that had input count != 1!");
972                 }
973                 if tx.input[0].witness.len() != 0 {
974                         panic!("Tried to re-sign HTLC transaction");
975                 }
976
977                 let (htlc_redeemscript, our_sig, local_tx) = self.create_htlc_tx_signature(tx, htlc, keys)?;
978
979                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
980
981                 if local_tx { // b, then a
982                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
983                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
984                 } else {
985                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
986                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
987                 }
988                 tx.input[0].witness[1].push(SigHashType::All as u8);
989                 tx.input[0].witness[2].push(SigHashType::All as u8);
990
991                 if htlc.offered {
992                         tx.input[0].witness.push(Vec::new());
993                 } else {
994                         tx.input[0].witness.push(preimage.unwrap().to_vec());
995                 }
996
997                 tx.input[0].witness.push(htlc_redeemscript.into_bytes());
998
999                 Ok(our_sig)
1000         }
1001
1002         fn get_update_fulfill_htlc(&mut self, payment_preimage_arg: [u8; 32]) -> Result<(Option<msgs::UpdateFulfillHTLC>, Option<ChannelMonitor>), HandleError> {
1003                 // Either ChannelFunded got set (which means it wont bet unset) or there is no way any
1004                 // caller thought we could have something claimed (cause we wouldn't have accepted in an
1005                 // incoming HTLC anyway). If we got to ShutdownComplete, callers aren't allowed to call us,
1006                 // either.
1007                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1008                         panic!("Was asked to fulfill an HTLC when channel was not in an operational state");
1009                 }
1010                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1011
1012                 let mut sha = Sha256::new();
1013                 sha.input(&payment_preimage_arg);
1014                 let mut payment_hash_calc = [0; 32];
1015                 sha.result(&mut payment_hash_calc);
1016
1017                 let mut pending_idx = std::usize::MAX;
1018                 for (idx, htlc) in self.pending_htlcs.iter().enumerate() {
1019                         if !htlc.outbound && htlc.payment_hash == payment_hash_calc &&
1020                                         htlc.state != HTLCState::LocalRemoved && htlc.state != HTLCState::LocalRemovedAwaitingCommitment {
1021                                 if pending_idx != std::usize::MAX {
1022                                         panic!("Duplicate HTLC payment_hash, ChannelManager should have prevented this!");
1023                                 }
1024                                 pending_idx = idx;
1025                         }
1026                 }
1027                 if pending_idx == std::usize::MAX {
1028                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given payment preimage", action: None});
1029                 }
1030
1031                 // Now update local state:
1032                 //
1033                 // We have to put the payment_preimage in the channel_monitor right away here to ensure we
1034                 // can claim it even if the channel hits the chain before we see their next commitment.
1035                 self.channel_monitor.provide_payment_preimage(&payment_hash_calc, &payment_preimage_arg);
1036
1037                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
1038                         for pending_update in self.holding_cell_htlc_updates.iter() {
1039                                 match pending_update {
1040                                         &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, .. } => {
1041                                                 if payment_preimage_arg == *payment_preimage {
1042                                                         return Ok((None, None));
1043                                                 }
1044                                         },
1045                                         &HTLCUpdateAwaitingACK::FailHTLC { ref payment_hash, .. } => {
1046                                                 if payment_hash_calc == *payment_hash {
1047                                                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given payment preimage", action: None});
1048                                                 }
1049                                         },
1050                                         _ => {}
1051                                 }
1052                         }
1053                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::ClaimHTLC {
1054                                 payment_preimage: payment_preimage_arg, payment_hash: payment_hash_calc,
1055                         });
1056                         return Ok((None, Some(self.channel_monitor.clone())));
1057                 }
1058
1059                 let htlc_id = {
1060                         let htlc = &mut self.pending_htlcs[pending_idx];
1061                         if htlc.state == HTLCState::Committed {
1062                                 htlc.state = HTLCState::LocalRemoved;
1063                                 htlc.local_removed_fulfilled = true;
1064                         } else if htlc.state == HTLCState::RemoteAnnounced || htlc.state == HTLCState::AwaitingRemoteRevokeToAnnounce || htlc.state == HTLCState::AwaitingAnnouncedRemoteRevoke {
1065                                 // Theoretically we can hit this if we get the preimage on an HTLC prior to us
1066                                 // having forwarded it to anyone. This implies that the sender is busted as someone
1067                                 // else knows the preimage, but handling this case and implementing the logic to
1068                                 // take their money would be a lot of (never-tested) code to handle a case that
1069                                 // hopefully never happens. Instead, we make sure we get the preimage into the
1070                                 // channel_monitor and pretend we didn't just see the preimage.
1071                                 return Ok((None, Some(self.channel_monitor.clone())));
1072                         } else {
1073                                 // LocalRemoved/LocalRemovedAwaitingCOmmitment handled in the search loop
1074                                 panic!("Have an inbound HTLC when not awaiting remote revoke that had a garbage state");
1075                         }
1076                         htlc.htlc_id
1077                 };
1078
1079                 Ok((Some(msgs::UpdateFulfillHTLC {
1080                         channel_id: self.channel_id(),
1081                         htlc_id: htlc_id,
1082                         payment_preimage: payment_preimage_arg,
1083                 }), Some(self.channel_monitor.clone())))
1084         }
1085
1086         pub fn get_update_fulfill_htlc_and_commit(&mut self, payment_preimage: [u8; 32]) -> Result<(Option<(msgs::UpdateFulfillHTLC, msgs::CommitmentSigned)>, Option<ChannelMonitor>), HandleError> {
1087                 match self.get_update_fulfill_htlc(payment_preimage)? {
1088                         (Some(update_fulfill_htlc), _) => {
1089                                 let (commitment, monitor_update) = self.send_commitment_no_status_check()?;
1090                                 Ok((Some((update_fulfill_htlc, commitment)), Some(monitor_update)))
1091                         },
1092                         (None, Some(channel_monitor)) => Ok((None, Some(channel_monitor))),
1093                         (None, None) => Ok((None, None))
1094                 }
1095         }
1096
1097         pub fn get_update_fail_htlc(&mut self, payment_hash_arg: &[u8; 32], err_packet: msgs::OnionErrorPacket) -> Result<Option<msgs::UpdateFailHTLC>, HandleError> {
1098                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1099                         return Err(HandleError{err: "Was asked to fail an HTLC when channel was not in an operational state", action: None});
1100                 }
1101                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1102
1103                 // Now update local state:
1104                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
1105                         for pending_update in self.holding_cell_htlc_updates.iter() {
1106                                 match pending_update {
1107                                         &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_hash, .. } => {
1108                                                 if *payment_hash_arg == *payment_hash {
1109                                                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given payment preimage", action: None});
1110                                                 }
1111                                         },
1112                                         &HTLCUpdateAwaitingACK::FailHTLC { ref payment_hash, .. } => {
1113                                                 if *payment_hash_arg == *payment_hash {
1114                                                         return Ok(None);
1115                                                 }
1116                                         },
1117                                         _ => {}
1118                                 }
1119                         }
1120                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::FailHTLC {
1121                                 payment_hash: payment_hash_arg.clone(),
1122                                 err_packet,
1123                         });
1124                         return Ok(None);
1125                 }
1126
1127                 let mut htlc_id = 0;
1128                 let mut htlc_amount_msat = 0;
1129                 for htlc in self.pending_htlcs.iter_mut() {
1130                         if !htlc.outbound && htlc.payment_hash == *payment_hash_arg {
1131                                 if htlc_id != 0 {
1132                                         panic!("Duplicate HTLC payment_hash, you probably re-used payment preimages, NEVER DO THIS!");
1133                                 }
1134                                 if htlc.state == HTLCState::Committed {
1135                                         htlc.state = HTLCState::LocalRemoved;
1136                                 } else if htlc.state == HTLCState::RemoteAnnounced {
1137                                         if let Some(PendingHTLCStatus::Forward(_)) = htlc.pending_forward_state {
1138                                                 panic!("Somehow forwarded HTLC prior to remote revocation!");
1139                                         } else {
1140                                                 // We have to pretend this isn't here - we're probably a duplicate with the
1141                                                 // same payment_hash as some other HTLC, and the other is getting failed,
1142                                                 // we'll fail this one as soon as remote commits to it.
1143                                                 continue;
1144                                         }
1145                                 } else if htlc.state == HTLCState::LocalRemoved || htlc.state == HTLCState::LocalRemovedAwaitingCommitment {
1146                                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given payment preimage", action: None});
1147                                 } else {
1148                                         panic!("Have an inbound HTLC when not awaiting remote revoke that had a garbage state");
1149                                 }
1150                                 htlc_id = htlc.htlc_id;
1151                                 htlc_amount_msat += htlc.amount_msat;
1152                         }
1153                 }
1154                 if htlc_amount_msat == 0 {
1155                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given payment preimage", action: None});
1156                 }
1157
1158                 Ok(Some(msgs::UpdateFailHTLC {
1159                         channel_id: self.channel_id(),
1160                         htlc_id,
1161                         reason: err_packet
1162                 }))
1163         }
1164
1165         pub fn get_update_fail_htlc_and_commit(&mut self, payment_hash: &[u8; 32], err_packet: msgs::OnionErrorPacket) -> Result<Option<(msgs::UpdateFailHTLC, msgs::CommitmentSigned, ChannelMonitor)>, HandleError> {
1166                 match self.get_update_fail_htlc(payment_hash, err_packet)? {
1167                         Some(update_fail_htlc) => {
1168                                 let (commitment, monitor_update) = self.send_commitment_no_status_check()?;
1169                                 Ok(Some((update_fail_htlc, commitment, monitor_update)))
1170                         },
1171                         None => Ok(None)
1172                 }
1173         }
1174
1175         // Message handlers:
1176
1177         pub fn accept_channel(&mut self, msg: &msgs::AcceptChannel) -> Result<(), HandleError> {
1178                 macro_rules! return_error_message {
1179                         ( $msg: expr ) => {
1180                                 return Err(HandleError{err: $msg, action: Some(msgs::ErrorAction::SendErrorMessage{ msg: msgs::ErrorMessage { channel_id: msg.temporary_channel_id, data: $msg.to_string() }})});
1181                         }
1182                 }
1183                 // Check sanity of message fields:
1184                 if !self.channel_outbound {
1185                         return_error_message!("Got an accept_channel message from an inbound peer");
1186                 }
1187                 if self.channel_state != ChannelState::OurInitSent as u32 {
1188                         return_error_message!("Got an accept_channel message at a strange time");
1189                 }
1190                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
1191                         return_error_message!("Peer never wants payout outputs?");
1192                 }
1193                 if msg.channel_reserve_satoshis > self.channel_value_satoshis {
1194                         return_error_message!("Bogus channel_reserve_satoshis");
1195                 }
1196                 if msg.dust_limit_satoshis > msg.channel_reserve_satoshis {
1197                         return_error_message!("Bogus channel_reserve and dust_limit");
1198                 }
1199                 if msg.channel_reserve_satoshis < self.our_dust_limit_satoshis {
1200                         return_error_message!("Peer never wants payout outputs?");
1201                 }
1202                 if msg.dust_limit_satoshis > Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis) {
1203                         return_error_message!("Dust limit is bigger than our channel reverse");
1204                 }
1205                 if msg.htlc_minimum_msat >= (self.channel_value_satoshis - msg.channel_reserve_satoshis) * 1000 {
1206                         return_error_message!("Minimum htlc value is full channel value");
1207                 }
1208                 if msg.minimum_depth > Channel::derive_maximum_minimum_depth(self.channel_value_satoshis*1000,  self.value_to_self_msat) {
1209                         return_error_message!("minimum_depth too large");
1210                 }
1211                 if msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
1212                         return_error_message!("They wanted our payments to be delayed by a needlessly long period");
1213                 }
1214                 if msg.max_accepted_htlcs < 1 {
1215                         return_error_message!("0 max_accpted_htlcs makes for a useless channel");
1216                 }
1217                 if msg.max_accepted_htlcs > 483 {
1218                         return_error_message!("max_accpted_htlcs > 483");
1219                 }
1220
1221                 // TODO: Optional additional constraints mentioned in the spec
1222                 // MAY fail the channel if
1223                 // funding_satoshi is too small
1224                 // htlc_minimum_msat too large
1225                 // max_htlc_value_in_flight_msat too small
1226                 // channel_reserve_satoshis too large
1227                 // max_accepted_htlcs too small
1228                 // dust_limit_satoshis too small
1229
1230                 self.channel_monitor.set_their_htlc_base_key(&msg.htlc_basepoint);
1231
1232                 self.their_dust_limit_satoshis = msg.dust_limit_satoshis;
1233                 self.their_max_htlc_value_in_flight_msat = cmp::min(msg.max_htlc_value_in_flight_msat, self.channel_value_satoshis * 1000);
1234                 self.their_channel_reserve_satoshis = msg.channel_reserve_satoshis;
1235                 self.their_htlc_minimum_msat = msg.htlc_minimum_msat;
1236                 self.their_to_self_delay = msg.to_self_delay;
1237                 self.their_max_accepted_htlcs = msg.max_accepted_htlcs;
1238                 self.their_funding_pubkey = Some(msg.funding_pubkey);
1239                 self.their_revocation_basepoint = Some(msg.revocation_basepoint);
1240                 self.their_payment_basepoint = Some(msg.payment_basepoint);
1241                 self.their_delayed_payment_basepoint = Some(msg.delayed_payment_basepoint);
1242                 self.their_htlc_basepoint = Some(msg.htlc_basepoint);
1243                 self.their_cur_commitment_point = Some(msg.first_per_commitment_point);
1244
1245                 let obscure_factor = self.get_commitment_transaction_number_obscure_factor();
1246                 self.channel_monitor.set_commitment_obscure_factor(obscure_factor);
1247                 self.channel_monitor.set_their_to_self_delay(msg.to_self_delay);
1248
1249                 self.channel_state = ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32;
1250
1251                 Ok(())
1252         }
1253
1254         fn funding_created_signature(&mut self, sig: &Signature) -> Result<(Transaction, Signature), HandleError> {
1255                 let funding_script = self.get_funding_redeemscript();
1256
1257                 let remote_keys = self.build_remote_transaction_keys()?;
1258                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false).0;
1259                 let remote_sighash = Message::from_slice(&bip143::SighashComponents::new(&remote_initial_commitment_tx).sighash_all(&remote_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1260
1261                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1262                 let local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false).0;
1263                 let local_sighash = Message::from_slice(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1264
1265                 // They sign the "local" commitment transaction, allowing us to broadcast the tx if we wish.
1266                 secp_call!(self.secp_ctx.verify(&local_sighash, &sig, &self.their_funding_pubkey.unwrap()), "Invalid funding_created signature from peer");
1267
1268                 // We sign the "remote" commitment transaction, allowing them to broadcast the tx if they wish.
1269                 Ok((remote_initial_commitment_tx, self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key)))
1270         }
1271
1272         pub fn funding_created(&mut self, msg: &msgs::FundingCreated) -> Result<(msgs::FundingSigned, ChannelMonitor), HandleError> {
1273                 if self.channel_outbound {
1274                         return Err(HandleError{err: "Received funding_created for an outbound channel?", action: None});
1275                 }
1276                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
1277                         return Err(HandleError{err: "Received funding_created after we got the channel!", action: None});
1278                 }
1279                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) || self.cur_remote_commitment_transaction_number != (1 << 48) - 1 || self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
1280                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1281                 }
1282
1283                 let funding_txo = OutPoint::new(msg.funding_txid, msg.funding_output_index);
1284                 let funding_txo_script = self.get_funding_redeemscript().to_v0_p2wsh();
1285                 self.channel_monitor.set_funding_info((funding_txo, funding_txo_script));
1286
1287                 let (remote_initial_commitment_tx, our_signature) = match self.funding_created_signature(&msg.signature) {
1288                         Ok(res) => res,
1289                         Err(e) => {
1290                                 self.channel_monitor.unset_funding_info();
1291                                 return Err(e);
1292                         }
1293                 };
1294
1295                 // Now that we're past error-generating stuff, update our local state:
1296
1297                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&remote_initial_commitment_tx, Vec::new(), self.cur_remote_commitment_transaction_number);
1298                 self.channel_state = ChannelState::FundingSent as u32;
1299                 self.channel_id = funding_txo.to_channel_id();
1300                 self.cur_remote_commitment_transaction_number -= 1;
1301                 self.cur_local_commitment_transaction_number -= 1;
1302
1303                 Ok((msgs::FundingSigned {
1304                         channel_id: self.channel_id,
1305                         signature: our_signature
1306                 }, self.channel_monitor.clone()))
1307         }
1308
1309         /// Handles a funding_signed message from the remote end.
1310         /// If this call is successful, broadcast the funding transaction (and not before!)
1311         pub fn funding_signed(&mut self, msg: &msgs::FundingSigned) -> Result<ChannelMonitor, HandleError> {
1312                 if !self.channel_outbound {
1313                         return Err(HandleError{err: "Received funding_signed for an inbound channel?", action: None});
1314                 }
1315                 if self.channel_state != ChannelState::FundingCreated as u32 {
1316                         return Err(HandleError{err: "Received funding_signed in strange state!", action: None});
1317                 }
1318                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) || self.cur_remote_commitment_transaction_number != (1 << 48) - 2 || self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
1319                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1320                 }
1321
1322                 let funding_script = self.get_funding_redeemscript();
1323
1324                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1325                 let mut local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false).0;
1326                 let local_sighash = Message::from_slice(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1327
1328                 // They sign the "local" commitment transaction, allowing us to broadcast the tx if we wish.
1329                 secp_call!(self.secp_ctx.verify(&local_sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid funding_signed signature from peer");
1330
1331                 self.sign_commitment_transaction(&mut local_initial_commitment_tx, &msg.signature);
1332                 self.channel_monitor.provide_latest_local_commitment_tx_info(local_initial_commitment_tx.clone(), local_keys, self.feerate_per_kw, Vec::new());
1333                 self.last_local_commitment_txn = vec![local_initial_commitment_tx];
1334                 self.channel_state = ChannelState::FundingSent as u32;
1335                 self.cur_local_commitment_transaction_number -= 1;
1336
1337                 Ok(self.channel_monitor.clone())
1338         }
1339
1340         pub fn funding_locked(&mut self, msg: &msgs::FundingLocked) -> Result<(), HandleError> {
1341                 let non_shutdown_state = self.channel_state & (!BOTH_SIDES_SHUTDOWN_MASK);
1342                 if non_shutdown_state == ChannelState::FundingSent as u32 {
1343                         self.channel_state |= ChannelState::TheirFundingLocked as u32;
1344                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
1345                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & BOTH_SIDES_SHUTDOWN_MASK);
1346                         self.channel_update_count += 1;
1347                 } else {
1348                         return Err(HandleError{err: "Peer sent a funding_locked at a strange time", action: None});
1349                 }
1350
1351                 self.their_prev_commitment_point = self.their_cur_commitment_point;
1352                 self.their_cur_commitment_point = Some(msg.next_per_commitment_point);
1353                 Ok(())
1354         }
1355
1356         /// Returns (inbound_htlc_count, outbound_htlc_count, htlc_outbound_value_msat, htlc_inbound_value_msat)
1357         /// If its for a remote update check, we need to be more lax about checking against messages we
1358         /// sent but they may not have received/processed before they sent this message. Further, for
1359         /// our own sends, we're more conservative and even consider things they've removed against
1360         /// totals, though there is little reason to outside of further avoiding any race condition
1361         /// issues.
1362         fn get_pending_htlc_stats(&self, for_remote_update_check: bool) -> (u32, u32, u64, u64) {
1363                 let mut inbound_htlc_count: u32 = 0;
1364                 let mut outbound_htlc_count: u32 = 0;
1365                 let mut htlc_outbound_value_msat = 0;
1366                 let mut htlc_inbound_value_msat = 0;
1367                 for ref htlc in self.pending_htlcs.iter() {
1368                         match htlc.state {
1369                                 HTLCState::RemoteAnnounced => {},
1370                                 HTLCState::AwaitingRemoteRevokeToAnnounce => {},
1371                                 HTLCState::AwaitingAnnouncedRemoteRevoke => {},
1372                                 HTLCState::LocalAnnounced => { if for_remote_update_check { continue; } },
1373                                 HTLCState::Committed => {},
1374                                 HTLCState::RemoteRemoved => { if for_remote_update_check { continue; } },
1375                                 HTLCState::AwaitingRemoteRevokeToRemove => { if for_remote_update_check { continue; } },
1376                                 HTLCState::AwaitingRemovedRemoteRevoke => { if for_remote_update_check { continue; } },
1377                                 HTLCState::LocalRemoved => {},
1378                                 HTLCState::LocalRemovedAwaitingCommitment => { if for_remote_update_check { continue; } },
1379                         }
1380                         if !htlc.outbound {
1381                                 inbound_htlc_count += 1;
1382                                 htlc_inbound_value_msat += htlc.amount_msat;
1383                         } else {
1384                                 outbound_htlc_count += 1;
1385                                 htlc_outbound_value_msat += htlc.amount_msat;
1386                         }
1387                 }
1388                 (inbound_htlc_count, outbound_htlc_count, htlc_outbound_value_msat, htlc_inbound_value_msat)
1389         }
1390
1391         pub fn update_add_htlc(&mut self, msg: &msgs::UpdateAddHTLC, pending_forward_state: PendingHTLCStatus) -> Result<(), HandleError> {
1392                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::RemoteShutdownSent as u32)) != (ChannelState::ChannelFunded as u32) {
1393                         return Err(HandleError{err: "Got add HTLC message when channel was not in an operational state", action: None});
1394                 }
1395                 if msg.amount_msat > self.channel_value_satoshis * 1000 {
1396                         return Err(HandleError{err: "Remote side tried to send more than the total value of the channel", action: None});
1397                 }
1398                 if msg.amount_msat < self.our_htlc_minimum_msat {
1399                         return Err(HandleError{err: "Remote side tried to send less than our minimum HTLC value", action: None});
1400                 }
1401
1402                 let (inbound_htlc_count, _, htlc_outbound_value_msat, htlc_inbound_value_msat) = self.get_pending_htlc_stats(true);
1403                 if inbound_htlc_count + 1 > OUR_MAX_HTLCS as u32 {
1404                         return Err(HandleError{err: "Remote tried to push more than our max accepted HTLCs", action: None});
1405                 }
1406                 //TODO: Spec is unclear if this is per-direction or in total (I assume per direction):
1407                 // Check our_max_htlc_value_in_flight_msat
1408                 if htlc_inbound_value_msat + msg.amount_msat > Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis) {
1409                         return Err(HandleError{err: "Remote HTLC add would put them over their max HTLC value in flight", action: None});
1410                 }
1411                 // Check our_channel_reserve_satoshis (we're getting paid, so they have to at least meet
1412                 // the reserve_satoshis we told them to always have as direct payment so that they lose
1413                 // something if we punish them for broadcasting an old state).
1414                 if htlc_inbound_value_msat + htlc_outbound_value_msat + msg.amount_msat + self.value_to_self_msat > (self.channel_value_satoshis - Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis)) * 1000 {
1415                         return Err(HandleError{err: "Remote HTLC add would put them over their reserve value", action: None});
1416                 }
1417                 if self.next_remote_htlc_id != msg.htlc_id {
1418                         return Err(HandleError{err: "Remote skipped HTLC ID", action: None});
1419                 }
1420                 if msg.cltv_expiry >= 500000000 {
1421                         return Err(HandleError{err: "Remote provided CLTV expiry in seconds instead of block height", action: None});
1422                 }
1423
1424                 //TODO: Check msg.cltv_expiry further? Do this in channel manager?
1425
1426                 // Now update local state:
1427                 self.next_remote_htlc_id += 1;
1428                 self.pending_htlcs.push(HTLCOutput {
1429                         outbound: false,
1430                         htlc_id: msg.htlc_id,
1431                         amount_msat: msg.amount_msat,
1432                         payment_hash: msg.payment_hash,
1433                         cltv_expiry: msg.cltv_expiry,
1434                         state: HTLCState::RemoteAnnounced,
1435                         fail_reason: None,
1436                         local_removed_fulfilled: false,
1437                         pending_forward_state: Some(pending_forward_state),
1438                 });
1439
1440                 Ok(())
1441         }
1442
1443         /// Removes an outbound HTLC which has been commitment_signed by the remote end
1444         #[inline]
1445         fn mark_outbound_htlc_removed(&mut self, htlc_id: u64, check_preimage: Option<[u8; 32]>, fail_reason: Option<HTLCFailReason>) -> Result<[u8; 32], HandleError> {
1446                 for htlc in self.pending_htlcs.iter_mut() {
1447                         if htlc.outbound && htlc.htlc_id == htlc_id {
1448                                 match check_preimage {
1449                                         None => {},
1450                                         Some(payment_hash) =>
1451                                                 if payment_hash != htlc.payment_hash {
1452                                                         return Err(HandleError{err: "Remote tried to fulfill HTLC with an incorrect preimage", action: None});
1453                                                 }
1454                                 };
1455                                 if htlc.state == HTLCState::LocalAnnounced {
1456                                         return Err(HandleError{err: "Remote tried to fulfill HTLC before it had been committed", action: None});
1457                                 } else if htlc.state == HTLCState::Committed {
1458                                         htlc.state = HTLCState::RemoteRemoved;
1459                                         htlc.fail_reason = fail_reason;
1460                                 } else if htlc.state == HTLCState::AwaitingRemoteRevokeToRemove || htlc.state == HTLCState::AwaitingRemovedRemoteRevoke || htlc.state == HTLCState::RemoteRemoved {
1461                                         return Err(HandleError{err: "Remote tried to fulfill HTLC that they'd already fulfilled", action: None});
1462                                 } else {
1463                                         panic!("Got a non-outbound state on an outbound HTLC");
1464                                 }
1465                                 return Ok(htlc.payment_hash.clone());
1466                         }
1467                 }
1468                 Err(HandleError{err: "Remote tried to fulfill/fail an HTLC we couldn't find", action: None})
1469         }
1470
1471         pub fn update_fulfill_htlc(&mut self, msg: &msgs::UpdateFulfillHTLC) -> Result<(), HandleError> {
1472                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1473                         return Err(HandleError{err: "Got add HTLC message when channel was not in an operational state", action: None});
1474                 }
1475
1476                 let mut sha = Sha256::new();
1477                 sha.input(&msg.payment_preimage);
1478                 let mut payment_hash = [0; 32];
1479                 sha.result(&mut payment_hash);
1480
1481                 self.mark_outbound_htlc_removed(msg.htlc_id, Some(payment_hash), None)?;
1482                 Ok(())
1483         }
1484
1485         pub fn update_fail_htlc(&mut self, msg: &msgs::UpdateFailHTLC, fail_reason: HTLCFailReason) -> Result<[u8; 32], HandleError> {
1486                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1487                         return Err(HandleError{err: "Got add HTLC message when channel was not in an operational state", action: None});
1488                 }
1489
1490                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))
1491         }
1492
1493         pub fn update_fail_malformed_htlc(&mut self, msg: &msgs::UpdateFailMalformedHTLC, fail_reason: HTLCFailReason) -> Result<(), HandleError> {
1494                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1495                         return Err(HandleError{err: "Got add HTLC message when channel was not in an operational state", action: None});
1496                 }
1497
1498                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
1499                 Ok(())
1500         }
1501
1502         pub fn commitment_signed(&mut self, msg: &msgs::CommitmentSigned) -> Result<(msgs::RevokeAndACK, Option<msgs::CommitmentSigned>, ChannelMonitor), HandleError> {
1503                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1504                         return Err(HandleError{err: "Got commitment signed message when channel was not in an operational state", action: None});
1505                 }
1506
1507                 let funding_script = self.get_funding_redeemscript();
1508
1509                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1510                 let mut local_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false);
1511                 let local_commitment_txid = local_commitment_tx.0.txid();
1512                 let local_sighash = Message::from_slice(&bip143::SighashComponents::new(&local_commitment_tx.0).sighash_all(&local_commitment_tx.0.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1513                 secp_call!(self.secp_ctx.verify(&local_sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid commitment tx signature from peer");
1514
1515                 if msg.htlc_signatures.len() != local_commitment_tx.1.len() {
1516                         return Err(HandleError{err: "Got wrong number of HTLC signatures from remote", action: None});
1517                 }
1518
1519                 let mut new_local_commitment_txn = Vec::with_capacity(local_commitment_tx.1.len() + 1);
1520                 self.sign_commitment_transaction(&mut local_commitment_tx.0, &msg.signature);
1521                 new_local_commitment_txn.push(local_commitment_tx.0.clone());
1522
1523                 let mut htlcs_and_sigs = Vec::with_capacity(local_commitment_tx.1.len());
1524                 for (idx, ref htlc) in local_commitment_tx.1.iter().enumerate() {
1525                         let mut htlc_tx = self.build_htlc_transaction(&local_commitment_txid, htlc, true, &local_keys);
1526                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &local_keys);
1527                         let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
1528                         secp_call!(self.secp_ctx.verify(&htlc_sighash, &msg.htlc_signatures[idx], &local_keys.b_htlc_key), "Invalid HTLC tx siganture from peer");
1529                         let htlc_sig = if htlc.offered {
1530                                 let htlc_sig = self.sign_htlc_transaction(&mut htlc_tx, &msg.htlc_signatures[idx], &None, htlc, &local_keys)?;
1531                                 new_local_commitment_txn.push(htlc_tx);
1532                                 htlc_sig
1533                         } else {
1534                                 self.create_htlc_tx_signature(&htlc_tx, htlc, &local_keys)?.1
1535                         };
1536                         htlcs_and_sigs.push(((*htlc).clone(), msg.htlc_signatures[idx], htlc_sig));
1537                 }
1538
1539                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(self.cur_local_commitment_transaction_number - 1));
1540                 let per_commitment_secret = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, self.cur_local_commitment_transaction_number + 1);
1541
1542                 // Update state now that we've passed all the can-fail calls...
1543                 self.channel_monitor.provide_latest_local_commitment_tx_info(local_commitment_tx.0, local_keys, self.feerate_per_kw, htlcs_and_sigs);
1544
1545                 let mut need_our_commitment = false;
1546                 for htlc in self.pending_htlcs.iter_mut() {
1547                         if htlc.state == HTLCState::RemoteAnnounced {
1548                                 htlc.state = HTLCState::AwaitingRemoteRevokeToAnnounce;
1549                                 need_our_commitment = true;
1550                         } else if htlc.state == HTLCState::RemoteRemoved {
1551                                 htlc.state = HTLCState::AwaitingRemoteRevokeToRemove;
1552                                 need_our_commitment = true;
1553                         }
1554                 }
1555                 // Finally delete all the LocalRemovedAwaitingCommitment HTLCs
1556                 // We really shouldnt have two passes here, but retain gives a non-mutable ref (Rust bug)
1557                 let mut claimed_value_msat = 0;
1558                 self.pending_htlcs.retain(|htlc| {
1559                         if htlc.state == HTLCState::LocalRemovedAwaitingCommitment {
1560                                 claimed_value_msat += htlc.amount_msat;
1561                                 false
1562                         } else { true }
1563                 });
1564                 self.value_to_self_msat += claimed_value_msat;
1565
1566                 self.cur_local_commitment_transaction_number -= 1;
1567                 self.last_local_commitment_txn = new_local_commitment_txn;
1568
1569                 let (our_commitment_signed, monitor_update) = if need_our_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
1570                         // If we're AwaitingRemoteRevoke we can't send a new commitment here, but that's ok -
1571                         // we'll send one right away when we get the revoke_and_ack when we
1572                         // free_holding_cell_htlcs().
1573                         let (msg, monitor) = self.send_commitment_no_status_check()?;
1574                         (Some(msg), monitor)
1575                 } else { (None, self.channel_monitor.clone()) };
1576
1577                 Ok((msgs::RevokeAndACK {
1578                         channel_id: self.channel_id,
1579                         per_commitment_secret: per_commitment_secret,
1580                         next_per_commitment_point: next_per_commitment_point,
1581                 }, our_commitment_signed, monitor_update))
1582         }
1583
1584         /// Used to fulfill holding_cell_htlcs when we get a remote ack (or implicitly get it by them
1585         /// fulfilling or failing the last pending HTLC)
1586         fn free_holding_cell_htlcs(&mut self) -> Result<Option<(msgs::CommitmentUpdate, ChannelMonitor)>, HandleError> {
1587                 if self.holding_cell_htlc_updates.len() != 0 {
1588                         let mut htlc_updates = Vec::new();
1589                         mem::swap(&mut htlc_updates, &mut self.holding_cell_htlc_updates);
1590                         let mut update_add_htlcs = Vec::with_capacity(htlc_updates.len());
1591                         let mut update_fulfill_htlcs = Vec::with_capacity(htlc_updates.len());
1592                         let mut update_fail_htlcs = Vec::with_capacity(htlc_updates.len());
1593                         let mut err = None;
1594                         for htlc_update in htlc_updates.drain(..) {
1595                                 // Note that this *can* fail, though it should be due to rather-rare conditions on
1596                                 // fee races with adding too many outputs which push our total payments just over
1597                                 // the limit. In case its less rare than I anticipate, we may want to revisit
1598                                 // handling this case better and maybe fufilling some of the HTLCs while attempting
1599                                 // to rebalance channels.
1600                                 if err.is_some() { // We're back to AwaitingRemoteRevoke (or are about to fail the channel)
1601                                         self.holding_cell_htlc_updates.push(htlc_update);
1602                                 } else {
1603                                         match &htlc_update {
1604                                                 &HTLCUpdateAwaitingACK::AddHTLC {amount_msat, cltv_expiry, payment_hash, ref onion_routing_packet, ..} => {
1605                                                         match self.send_htlc(amount_msat, payment_hash, cltv_expiry, onion_routing_packet.clone()) {
1606                                                                 Ok(update_add_msg_option) => update_add_htlcs.push(update_add_msg_option.unwrap()),
1607                                                                 Err(e) => {
1608                                                                         err = Some(e);
1609                                                                 }
1610                                                         }
1611                                                 },
1612                                                 &HTLCUpdateAwaitingACK::ClaimHTLC { payment_preimage, .. } => {
1613                                                         match self.get_update_fulfill_htlc(payment_preimage) {
1614                                                                 Ok(update_fulfill_msg_option) => update_fulfill_htlcs.push(update_fulfill_msg_option.0.unwrap()),
1615                                                                 Err(e) => {
1616                                                                         err = Some(e);
1617                                                                 }
1618                                                         }
1619                                                 },
1620                                                 &HTLCUpdateAwaitingACK::FailHTLC { payment_hash, ref err_packet } => {
1621                                                         match self.get_update_fail_htlc(&payment_hash, err_packet.clone()) {
1622                                                                 Ok(update_fail_msg_option) => update_fail_htlcs.push(update_fail_msg_option.unwrap()),
1623                                                                 Err(e) => {
1624                                                                         err = Some(e);
1625                                                                 }
1626                                                         }
1627                                                 },
1628                                         }
1629                                         if err.is_some() {
1630                                                 self.holding_cell_htlc_updates.push(htlc_update);
1631                                         }
1632                                 }
1633                         }
1634                         //TODO: Need to examine the type of err - if its a fee issue or similar we may want to
1635                         //fail it back the route, if its a temporary issue we can ignore it...
1636                         match err {
1637                                 None => {
1638                                         let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
1639                                         Ok(Some((msgs::CommitmentUpdate {
1640                                                 update_add_htlcs,
1641                                                 update_fulfill_htlcs,
1642                                                 update_fail_htlcs,
1643                                                 commitment_signed,
1644                                         }, monitor_update)))
1645                                 },
1646                                 Some(e) => Err(e)
1647                         }
1648                 } else {
1649                         Ok(None)
1650                 }
1651         }
1652
1653         /// Handles receiving a remote's revoke_and_ack. Note that we may return a new
1654         /// commitment_signed message here in case we had pending outbound HTLCs to add which were
1655         /// waiting on this revoke_and_ack. The generation of this new commitment_signed may also fail,
1656         /// generating an appropriate error *after* the channel state has been updated based on the
1657         /// revoke_and_ack message.
1658         pub fn revoke_and_ack(&mut self, msg: &msgs::RevokeAndACK) -> Result<(Option<msgs::CommitmentUpdate>, Vec<PendingForwardHTLCInfo>, Vec<([u8; 32], HTLCFailReason)>, ChannelMonitor), HandleError> {
1659                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1660                         return Err(HandleError{err: "Got revoke/ACK message when channel was not in an operational state", action: None});
1661                 }
1662                 if let Some(their_prev_commitment_point) = self.their_prev_commitment_point {
1663                         if PublicKey::from_secret_key(&self.secp_ctx, &secp_call!(SecretKey::from_slice(&self.secp_ctx, &msg.per_commitment_secret), "Peer provided an invalid per_commitment_secret")) != their_prev_commitment_point {
1664                                 return Err(HandleError{err: "Got a revoke commitment secret which didn't correspond to their current pubkey", action: None});
1665                         }
1666                 }
1667                 self.channel_monitor.provide_secret(self.cur_remote_commitment_transaction_number + 1, msg.per_commitment_secret, Some((self.cur_remote_commitment_transaction_number - 1, msg.next_per_commitment_point)))?;
1668
1669                 // Update state now that we've passed all the can-fail calls...
1670                 // (note that we may still fail to generate the new commitment_signed message, but that's
1671                 // OK, we step the channel here and *then* if the new generation fails we can fail the
1672                 // channel based on that, but stepping stuff here should be safe either way.
1673                 self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
1674                 self.their_prev_commitment_point = self.their_cur_commitment_point;
1675                 self.their_cur_commitment_point = Some(msg.next_per_commitment_point);
1676                 self.cur_remote_commitment_transaction_number -= 1;
1677
1678                 let mut to_forward_infos = Vec::new();
1679                 let mut revoked_htlcs = Vec::new();
1680                 let mut failed_htlcs = Vec::new();
1681                 let mut require_commitment = false;
1682                 let mut value_to_self_msat_diff: i64 = 0;
1683                 // We really shouldnt have two passes here, but retain gives a non-mutable ref (Rust bug)
1684                 self.pending_htlcs.retain(|htlc| {
1685                         if htlc.state == HTLCState::LocalRemoved {
1686                                 if htlc.local_removed_fulfilled { true } else { false }
1687                         } else if htlc.state == HTLCState::AwaitingRemovedRemoteRevoke {
1688                                 if let Some(reason) = htlc.fail_reason.clone() { // We really want take() here, but, again, non-mut ref :(
1689                                         revoked_htlcs.push((htlc.payment_hash, reason));
1690                                 } else {
1691                                         // They fulfilled, so we sent them money
1692                                         value_to_self_msat_diff -= htlc.amount_msat as i64;
1693                                 }
1694                                 false
1695                         } else { true }
1696                 });
1697                 for htlc in self.pending_htlcs.iter_mut() {
1698                         if htlc.state == HTLCState::LocalAnnounced {
1699                                 htlc.state = HTLCState::Committed;
1700                         } else if htlc.state == HTLCState::AwaitingRemoteRevokeToAnnounce {
1701                                 htlc.state = HTLCState::AwaitingAnnouncedRemoteRevoke;
1702                                 require_commitment = true;
1703                         } else if htlc.state == HTLCState::AwaitingAnnouncedRemoteRevoke {
1704                                 match htlc.pending_forward_state.take().unwrap() {
1705                                         PendingHTLCStatus::Fail(fail_msg) => {
1706                                                 htlc.state = HTLCState::LocalRemoved;
1707                                                 require_commitment = true;
1708                                                 failed_htlcs.push(fail_msg);
1709                                         },
1710                                         PendingHTLCStatus::Forward(forward_info) => {
1711                                                 to_forward_infos.push(forward_info);
1712                                                 htlc.state = HTLCState::Committed;
1713                                         }
1714                                 }
1715                         } else if htlc.state == HTLCState::AwaitingRemoteRevokeToRemove {
1716                                 htlc.state = HTLCState::AwaitingRemovedRemoteRevoke;
1717                                 require_commitment = true;
1718                         } else if htlc.state == HTLCState::LocalRemoved {
1719                                 assert!(htlc.local_removed_fulfilled);
1720                                 htlc.state = HTLCState::LocalRemovedAwaitingCommitment;
1721                         }
1722                 }
1723                 self.value_to_self_msat = (self.value_to_self_msat as i64 + value_to_self_msat_diff) as u64;
1724
1725                 match self.free_holding_cell_htlcs()? {
1726                         Some(mut commitment_update) => {
1727                                 commitment_update.0.update_fail_htlcs.reserve(failed_htlcs.len());
1728                                 for fail_msg in failed_htlcs.drain(..) {
1729                                         commitment_update.0.update_fail_htlcs.push(fail_msg);
1730                                 }
1731                                 Ok((Some(commitment_update.0), to_forward_infos, revoked_htlcs, commitment_update.1))
1732                         },
1733                         None => {
1734                                 if require_commitment {
1735                                         let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
1736                                         Ok((Some(msgs::CommitmentUpdate {
1737                                                 update_add_htlcs: Vec::new(),
1738                                                 update_fulfill_htlcs: Vec::new(),
1739                                                 update_fail_htlcs: failed_htlcs,
1740                                                 commitment_signed
1741                                         }), to_forward_infos, revoked_htlcs, monitor_update))
1742                                 } else {
1743                                         Ok((None, to_forward_infos, revoked_htlcs, self.channel_monitor.clone()))
1744                                 }
1745                         }
1746                 }
1747         }
1748
1749         pub fn update_fee(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::UpdateFee) -> Result<(), HandleError> {
1750                 if self.channel_outbound {
1751                         return Err(HandleError{err: "Non-funding remote tried to update channel fee", action: None});
1752                 }
1753                 Channel::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
1754                 self.channel_update_count += 1;
1755                 self.feerate_per_kw = msg.feerate_per_kw as u64;
1756                 Ok(())
1757         }
1758
1759         pub fn shutdown(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::Shutdown) -> Result<(Option<msgs::Shutdown>, Option<msgs::ClosingSigned>, Vec<[u8; 32]>), HandleError> {
1760                 if self.channel_state < ChannelState::FundingSent as u32 {
1761                         self.channel_state = ChannelState::ShutdownComplete as u32;
1762                         self.channel_update_count += 1;
1763                         return Ok((None, None, Vec::new()));
1764                 }
1765                 for htlc in self.pending_htlcs.iter() {
1766                         if htlc.state == HTLCState::RemoteAnnounced {
1767                                 return Err(HandleError{err: "Got shutdown with remote pending HTLCs", action: None});
1768                         }
1769                 }
1770                 if (self.channel_state & ChannelState::RemoteShutdownSent as u32) == ChannelState::RemoteShutdownSent as u32 {
1771                         return Err(HandleError{err: "Remote peer sent duplicate shutdown message", action: None});
1772                 }
1773                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1774
1775                 // BOLT 2 says we must only send a scriptpubkey of certain standard forms, which are up to
1776                 // 34 bytes in length, so dont let the remote peer feed us some super fee-heavy script.
1777                 if self.channel_outbound && msg.scriptpubkey.len() > 34 {
1778                         return Err(HandleError{err: "Got shutdown_scriptpubkey of absurd length from remote peer", action: None});
1779                 }
1780                 //TODO: Check shutdown_scriptpubkey form as BOLT says we must? WHYYY
1781
1782                 if self.their_shutdown_scriptpubkey.is_some() {
1783                         if Some(&msg.scriptpubkey) != self.their_shutdown_scriptpubkey.as_ref() {
1784                                 return Err(HandleError{err: "Got shutdown request with a scriptpubkey which did not match their previous scriptpubkey", action: None});
1785                         }
1786                 } else {
1787                         self.their_shutdown_scriptpubkey = Some(msg.scriptpubkey.clone());
1788                 }
1789
1790                 let our_closing_script = self.get_closing_scriptpubkey();
1791
1792                 let (proposed_feerate, proposed_fee, our_sig) = if self.channel_outbound && self.pending_htlcs.is_empty() {
1793                         let mut proposed_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
1794                         if self.feerate_per_kw > proposed_feerate {
1795                                 proposed_feerate = self.feerate_per_kw;
1796                         }
1797                         let tx_weight = Self::get_closing_transaction_weight(&our_closing_script, &msg.scriptpubkey);
1798                         let proposed_total_fee_satoshis = proposed_feerate * tx_weight / 1000;
1799
1800                         let (closing_tx, total_fee_satoshis) = self.build_closing_transaction(proposed_total_fee_satoshis, false);
1801                         let funding_redeemscript = self.get_funding_redeemscript();
1802                         let sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
1803
1804                         (Some(proposed_feerate), Some(total_fee_satoshis), Some(self.secp_ctx.sign(&sighash, &self.local_keys.funding_key)))
1805                 } else { (None, None, None) };
1806
1807                 // From here on out, we may not fail!
1808
1809                 self.channel_state |= ChannelState::RemoteShutdownSent as u32;
1810                 self.channel_update_count += 1;
1811
1812                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
1813                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
1814                 // cell HTLCs and return them to fail the payment.
1815                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
1816                 self.holding_cell_htlc_updates.retain(|htlc_update| {
1817                         match htlc_update {
1818                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, .. } => {
1819                                         dropped_outbound_htlcs.push(payment_hash.clone());
1820                                         false
1821                                 },
1822                                 _ => true
1823                         }
1824                 });
1825                 for htlc in self.pending_htlcs.iter() {
1826                         if htlc.state == HTLCState::LocalAnnounced {
1827                                 return Ok((None, None, dropped_outbound_htlcs));
1828                         }
1829                 }
1830
1831                 let our_shutdown = if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
1832                         None
1833                 } else {
1834                         Some(msgs::Shutdown {
1835                                 channel_id: self.channel_id,
1836                                 scriptpubkey: our_closing_script,
1837                         })
1838                 };
1839
1840                 self.channel_state |= ChannelState::LocalShutdownSent as u32;
1841                 self.channel_update_count += 1;
1842                 if self.pending_htlcs.is_empty() && self.channel_outbound {
1843                         // There are no more HTLCs and we're the funder, this means we start the closing_signed
1844                         // dance with an initial fee proposal!
1845                         self.last_sent_closing_fee = Some((proposed_feerate.unwrap(), proposed_fee.unwrap()));
1846                         Ok((our_shutdown, Some(msgs::ClosingSigned {
1847                                 channel_id: self.channel_id,
1848                                 fee_satoshis: proposed_fee.unwrap(),
1849                                 signature: our_sig.unwrap(),
1850                         }), dropped_outbound_htlcs))
1851                 } else {
1852                         Ok((our_shutdown, None, dropped_outbound_htlcs))
1853                 }
1854         }
1855
1856         pub fn closing_signed(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::ClosingSigned) -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), HandleError> {
1857                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != BOTH_SIDES_SHUTDOWN_MASK {
1858                         return Err(HandleError{err: "Remote end sent us a closing_signed before both sides provided a shutdown", action: None});
1859                 }
1860                 if !self.pending_htlcs.is_empty() {
1861                         return Err(HandleError{err: "Remote end sent us a closing_signed while there were still pending HTLCs", action: None});
1862                 }
1863                 if msg.fee_satoshis > 21000000 * 10000000 {
1864                         return Err(HandleError{err: "Remote tried to send us a closing tx with > 21 million BTC fee", action: None});
1865                 }
1866
1867                 let funding_redeemscript = self.get_funding_redeemscript();
1868                 let (mut closing_tx, used_total_fee) = self.build_closing_transaction(msg.fee_satoshis, false);
1869                 if used_total_fee != msg.fee_satoshis {
1870                         return Err(HandleError{err: "Remote sent us a closing_signed with a fee greater than the value they can claim", action: None});
1871                 }
1872                 let mut sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
1873
1874                 match self.secp_ctx.verify(&sighash, &msg.signature, &self.their_funding_pubkey.unwrap()) {
1875                         Ok(_) => {},
1876                         Err(_e) => {
1877                                 // The remote end may have decided to revoke their output due to inconsistent dust
1878                                 // limits, so check for that case by re-checking the signature here.
1879                                 closing_tx = self.build_closing_transaction(msg.fee_satoshis, true).0;
1880                                 sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
1881                                 secp_call!(self.secp_ctx.verify(&sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid closing tx signature from peer");
1882                         },
1883                 };
1884
1885                 if let Some((_, last_fee)) = self.last_sent_closing_fee {
1886                         if last_fee == msg.fee_satoshis {
1887                                 self.sign_commitment_transaction(&mut closing_tx, &msg.signature);
1888                                 self.channel_state = ChannelState::ShutdownComplete as u32;
1889                                 self.channel_update_count += 1;
1890                                 return Ok((None, Some(closing_tx)));
1891                         }
1892                 }
1893
1894                 macro_rules! propose_new_feerate {
1895                         ($new_feerate: expr) => {
1896                                 let closing_tx_max_weight = Self::get_closing_transaction_weight(&self.get_closing_scriptpubkey(), self.their_shutdown_scriptpubkey.as_ref().unwrap());
1897                                 let (closing_tx, used_total_fee) = self.build_closing_transaction($new_feerate * closing_tx_max_weight / 1000, false);
1898                                 sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
1899                                 let our_sig = self.secp_ctx.sign(&sighash, &self.local_keys.funding_key);
1900                                 self.last_sent_closing_fee = Some(($new_feerate, used_total_fee));
1901                                 return Ok((Some(msgs::ClosingSigned {
1902                                         channel_id: self.channel_id,
1903                                         fee_satoshis: used_total_fee,
1904                                         signature: our_sig,
1905                                 }), None))
1906                         }
1907                 }
1908
1909                 let proposed_sat_per_kw = msg.fee_satoshis * 1000 / closing_tx.get_weight();
1910                 if self.channel_outbound {
1911                         let our_max_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
1912                         if proposed_sat_per_kw > our_max_feerate {
1913                                 if let Some((last_feerate, _)) = self.last_sent_closing_fee {
1914                                         if our_max_feerate <= last_feerate {
1915                                                 return Err(HandleError{err: "Unable to come to consensus about closing feerate, remote wanted something higher than our Normal feerate", action: None});
1916                                         }
1917                                 }
1918                                 propose_new_feerate!(our_max_feerate);
1919                         }
1920                 } else {
1921                         let our_min_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
1922                         if proposed_sat_per_kw < our_min_feerate {
1923                                 if let Some((last_feerate, _)) = self.last_sent_closing_fee {
1924                                         if our_min_feerate >= last_feerate {
1925                                                 return Err(HandleError{err: "Unable to come to consensus about closing feerate, remote wanted something lower than our Background feerate", action: None});
1926                                         }
1927                                 }
1928                                 propose_new_feerate!(our_min_feerate);
1929                         }
1930                 }
1931
1932                 let our_sig = self.sign_commitment_transaction(&mut closing_tx, &msg.signature);
1933                 self.channel_state = ChannelState::ShutdownComplete as u32;
1934                 self.channel_update_count += 1;
1935
1936                 Ok((Some(msgs::ClosingSigned {
1937                         channel_id: self.channel_id,
1938                         fee_satoshis: msg.fee_satoshis,
1939                         signature: our_sig,
1940                 }), Some(closing_tx)))
1941         }
1942
1943         // Public utilities:
1944
1945         pub fn channel_id(&self) -> [u8; 32] {
1946                 self.channel_id
1947         }
1948
1949         /// Gets the "user_id" value passed into the construction of this channel. It has no special
1950         /// meaning and exists only to allow users to have a persistent identifier of a channel.
1951         pub fn get_user_id(&self) -> u64 {
1952                 self.user_id
1953         }
1954
1955         /// May only be called after funding has been initiated (ie is_funding_initiated() is true)
1956         pub fn channel_monitor(&self) -> ChannelMonitor {
1957                 if self.channel_state < ChannelState::FundingCreated as u32 {
1958                         panic!("Can't get a channel monitor until funding has been created");
1959                 }
1960                 self.channel_monitor.clone()
1961         }
1962
1963         /// Guaranteed to be Some after both FundingLocked messages have been exchanged (and, thus,
1964         /// is_usable() returns true).
1965         /// Allowed in any state (including after shutdown)
1966         pub fn get_short_channel_id(&self) -> Option<u64> {
1967                 self.short_channel_id
1968         }
1969
1970         /// Returns the funding_txo we either got from our peer, or were given by
1971         /// get_outbound_funding_created.
1972         pub fn get_funding_txo(&self) -> Option<OutPoint> {
1973                 self.channel_monitor.get_funding_txo()
1974         }
1975
1976         /// Allowed in any state (including after shutdown)
1977         pub fn get_their_node_id(&self) -> PublicKey {
1978                 self.their_node_id
1979         }
1980
1981         /// Allowed in any state (including after shutdown)
1982         pub fn get_our_htlc_minimum_msat(&self) -> u64 {
1983                 self.our_htlc_minimum_msat
1984         }
1985
1986         pub fn get_value_satoshis(&self) -> u64 {
1987                 self.channel_value_satoshis
1988         }
1989
1990         /// Allowed in any state (including after shutdown)
1991         pub fn get_channel_update_count(&self) -> u32 {
1992                 self.channel_update_count
1993         }
1994
1995         pub fn should_announce(&self) -> bool {
1996                 self.announce_publicly
1997         }
1998
1999         /// Gets the fee we'd want to charge for adding an HTLC output to this Channel
2000         /// Allowed in any state (including after shutdown)
2001         pub fn get_our_fee_base_msat(&self, fee_estimator: &FeeEstimator) -> u32 {
2002                 // For lack of a better metric, we calculate what it would cost to consolidate the new HTLC
2003                 // output value back into a transaction with the regular channel output:
2004
2005                 // the fee cost of the HTLC-Success/HTLC-Timeout transaction:
2006                 let mut res = self.feerate_per_kw * cmp::max(HTLC_TIMEOUT_TX_WEIGHT, HTLC_SUCCESS_TX_WEIGHT) / 1000;
2007
2008                 if self.channel_outbound {
2009                         // + the marginal fee increase cost to us in the commitment transaction:
2010                         res += self.feerate_per_kw * COMMITMENT_TX_WEIGHT_PER_HTLC / 1000;
2011                 }
2012
2013                 // + the marginal cost of an input which spends the HTLC-Success/HTLC-Timeout output:
2014                 res += fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal) * SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT / 1000;
2015
2016                 res as u32
2017         }
2018
2019         /// Returns true if this channel is fully established and not known to be closing.
2020         /// Allowed in any state (including after shutdown)
2021         pub fn is_usable(&self) -> bool {
2022                 let mask = ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK;
2023                 (self.channel_state & mask) == (ChannelState::ChannelFunded as u32)
2024         }
2025
2026         /// Returns true if this channel is currently available for use. This is a superset of
2027         /// is_usable() and considers things like the channel being temporarily disabled.
2028         /// Allowed in any state (including after shutdown)
2029         pub fn is_live(&self) -> bool {
2030                 self.is_usable()
2031         }
2032
2033         /// Returns true if funding_created was sent/received.
2034         pub fn is_funding_initiated(&self) -> bool {
2035                 self.channel_state >= ChannelState::FundingCreated as u32
2036         }
2037
2038         /// Returns true if this channel is fully shut down. True here implies that no further actions
2039         /// may/will be taken on this channel, and thus this object should be freed. Any future changes
2040         /// will be handled appropriately by the chain monitor.
2041         pub fn is_shutdown(&self) -> bool {
2042                 if (self.channel_state & ChannelState::ShutdownComplete as u32) == ChannelState::ShutdownComplete as u32  {
2043                         assert!(self.channel_state == ChannelState::ShutdownComplete as u32);
2044                         true
2045                 } else { false }
2046         }
2047
2048         /// Called by channelmanager based on chain blocks being connected.
2049         /// Note that we only need to use this to detect funding_signed, anything else is handled by
2050         /// the channel_monitor.
2051         /// In case of Err, the channel may have been closed, at which point the standard requirements
2052         /// apply - no calls may be made except those explicitly stated to be allowed post-shutdown.
2053         /// Only returns an ErrorAction of DisconnectPeer, if Err.
2054         pub fn block_connected(&mut self, header: &BlockHeader, height: u32, txn_matched: &[&Transaction], indexes_of_txn_matched: &[u32]) -> Result<Option<msgs::FundingLocked>, HandleError> {
2055                 let non_shutdown_state = self.channel_state & (!BOTH_SIDES_SHUTDOWN_MASK);
2056                 if self.funding_tx_confirmations > 0 {
2057                         if header.bitcoin_hash() != self.last_block_connected {
2058                                 self.last_block_connected = header.bitcoin_hash();
2059                                 self.funding_tx_confirmations += 1;
2060                                 if self.funding_tx_confirmations == Channel::derive_minimum_depth(self.channel_value_satoshis*1000, self.value_to_self_msat) as u64 {
2061                                         let need_commitment_update = if non_shutdown_state == ChannelState::FundingSent as u32 {
2062                                                 self.channel_state |= ChannelState::OurFundingLocked as u32;
2063                                                 true
2064                                         } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) {
2065                                                 self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & BOTH_SIDES_SHUTDOWN_MASK);
2066                                                 self.channel_update_count += 1;
2067                                                 true
2068                                         } else if self.channel_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
2069                                                 // We got a reorg but not enough to trigger a force close, just update
2070                                                 // funding_tx_confirmed_in and return.
2071                                                 false
2072                                         } else if self.channel_state < ChannelState::ChannelFunded as u32 {
2073                                                 panic!("Started confirming a channel in a state pre-FundingSent?: {}", self.channel_state);
2074                                         } else {
2075                                                 // We got a reorg but not enough to trigger a force close, just update
2076                                                 // funding_tx_confirmed_in and return.
2077                                                 false
2078                                         };
2079                                         self.funding_tx_confirmed_in = Some(header.bitcoin_hash());
2080
2081                                         //TODO: Note that this must be a duplicate of the previous commitment point they sent us,
2082                                         //as otherwise we will have a commitment transaction that they can't revoke (well, kinda,
2083                                         //they can by sending two revoke_and_acks back-to-back, but not really). This appears to be
2084                                         //a protocol oversight, but I assume I'm just missing something.
2085                                         if need_commitment_update {
2086                                                 let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2087                                                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2088                                                 return Ok(Some(msgs::FundingLocked {
2089                                                         channel_id: self.channel_id,
2090                                                         next_per_commitment_point: next_per_commitment_point,
2091                                                 }));
2092                                         }
2093                                 }
2094                         }
2095                 }
2096                 if non_shutdown_state & !(ChannelState::TheirFundingLocked as u32) == ChannelState::FundingSent as u32 {
2097                         for (ref tx, index_in_block) in txn_matched.iter().zip(indexes_of_txn_matched) {
2098                                 if tx.txid() == self.channel_monitor.get_funding_txo().unwrap().txid {
2099                                         let txo_idx = self.channel_monitor.get_funding_txo().unwrap().index as usize;
2100                                         if txo_idx >= tx.output.len() || tx.output[txo_idx].script_pubkey != self.get_funding_redeemscript().to_v0_p2wsh() ||
2101                                                 tx.output[txo_idx].value != self.channel_value_satoshis {
2102                                                 self.channel_state = ChannelState::ShutdownComplete as u32;
2103                                                 self.channel_update_count += 1;
2104                                                 return Err(HandleError{err: "funding tx had wrong script/value", action: Some(ErrorAction::DisconnectPeer{msg: None})});
2105                                         } else {
2106                                                 self.funding_tx_confirmations = 1;
2107                                                 self.short_channel_id = Some(((height as u64)          << (5*8)) |
2108                                                                              ((*index_in_block as u64) << (2*8)) |
2109                                                                              ((txo_idx as u64)         << (0*8)));
2110                                         }
2111                                 }
2112                         }
2113                 }
2114                 Ok(None)
2115         }
2116
2117         /// Called by channelmanager based on chain blocks being disconnected.
2118         /// Returns true if we need to close the channel now due to funding transaction
2119         /// unconfirmation/reorg.
2120         pub fn block_disconnected(&mut self, header: &BlockHeader) -> bool {
2121                 if self.funding_tx_confirmations > 0 {
2122                         self.funding_tx_confirmations -= 1;
2123                         if self.funding_tx_confirmations == UNCONF_THRESHOLD as u64 {
2124                                 return true;
2125                         }
2126                 }
2127                 if Some(header.bitcoin_hash()) == self.funding_tx_confirmed_in {
2128                         self.funding_tx_confirmations = Channel::derive_minimum_depth(self.channel_value_satoshis*1000, self.value_to_self_msat) as u64 - 1;
2129                 }
2130                 false
2131         }
2132
2133         // Methods to get unprompted messages to send to the remote end (or where we already returned
2134         // something in the handler for the message that prompted this message):
2135
2136         pub fn get_open_channel(&self, chain_hash: Sha256dHash, fee_estimator: &FeeEstimator) -> Result<msgs::OpenChannel, APIError> {
2137                 if !self.channel_outbound {
2138                         panic!("Tried to open a channel for an inbound channel?");
2139                 }
2140                 if self.channel_state != ChannelState::OurInitSent as u32 {
2141                         panic!("Cannot generate an open_channel after we've moved forward");
2142                 }
2143
2144                 if self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
2145                         panic!("Tried to send an open_channel for a channel that has already advanced");
2146                 }
2147
2148                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2149
2150                 Ok(msgs::OpenChannel {
2151                         chain_hash: chain_hash,
2152                         temporary_channel_id: self.channel_id,
2153                         funding_satoshis: self.channel_value_satoshis,
2154                         push_msat: self.channel_value_satoshis * 1000 - self.value_to_self_msat,
2155                         dust_limit_satoshis: self.our_dust_limit_satoshis,
2156                         max_htlc_value_in_flight_msat: Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
2157                         channel_reserve_satoshis: Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
2158                         htlc_minimum_msat: self.our_htlc_minimum_msat,
2159                         feerate_per_kw: fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background) as u32,
2160                         to_self_delay: BREAKDOWN_TIMEOUT,
2161                         max_accepted_htlcs: OUR_MAX_HTLCS,
2162                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key),
2163                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key),
2164                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key),
2165                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key),
2166                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key),
2167                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret),
2168                         channel_flags: if self.announce_publicly {1} else {0},
2169                         shutdown_scriptpubkey: None,
2170                 })
2171         }
2172
2173         pub fn get_accept_channel(&self) -> Result<msgs::AcceptChannel, HandleError> {
2174                 if self.channel_outbound {
2175                         panic!("Tried to send accept_channel for an outbound channel?");
2176                 }
2177                 if self.channel_state != (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32) {
2178                         panic!("Tried to send accept_channel after channel had moved forward");
2179                 }
2180                 if self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
2181                         panic!("Tried to send an accept_channel for a channel that has already advanced");
2182                 }
2183
2184                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2185
2186                 Ok(msgs::AcceptChannel {
2187                         temporary_channel_id: self.channel_id,
2188                         dust_limit_satoshis: self.our_dust_limit_satoshis,
2189                         max_htlc_value_in_flight_msat: Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
2190                         channel_reserve_satoshis: Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
2191                         htlc_minimum_msat: self.our_htlc_minimum_msat,
2192                         minimum_depth: Channel::derive_minimum_depth(self.channel_value_satoshis*1000, self.value_to_self_msat),
2193                         to_self_delay: BREAKDOWN_TIMEOUT,
2194                         max_accepted_htlcs: OUR_MAX_HTLCS,
2195                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key),
2196                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key),
2197                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key),
2198                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key),
2199                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key),
2200                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret),
2201                         shutdown_scriptpubkey: None,
2202                 })
2203         }
2204
2205         fn get_outbound_funding_created_signature(&mut self) -> Result<(Signature, Transaction), HandleError> {
2206                 let funding_script = self.get_funding_redeemscript();
2207
2208                 let remote_keys = self.build_remote_transaction_keys()?;
2209                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false).0;
2210                 let remote_sighash = Message::from_slice(&bip143::SighashComponents::new(&remote_initial_commitment_tx).sighash_all(&remote_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
2211
2212                 // We sign the "remote" commitment transaction, allowing them to broadcast the tx if they wish.
2213                 Ok((self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key), remote_initial_commitment_tx))
2214         }
2215
2216         /// Updates channel state with knowledge of the funding transaction's txid/index, and generates
2217         /// a funding_created message for the remote peer.
2218         /// Panics if called at some time other than immediately after initial handshake, if called twice,
2219         /// or if called on an inbound channel.
2220         /// Note that channel_id changes during this call!
2221         /// Do NOT broadcast the funding transaction until after a successful funding_signed call!
2222         pub fn get_outbound_funding_created(&mut self, funding_txo: OutPoint) -> Result<(msgs::FundingCreated, ChannelMonitor), HandleError> {
2223                 if !self.channel_outbound {
2224                         panic!("Tried to create outbound funding_created message on an inbound channel!");
2225                 }
2226                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
2227                         panic!("Tried to get a funding_created messsage at a time other than immediately after initial handshake completion (or tried to get funding_created twice)");
2228                 }
2229                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) || self.cur_remote_commitment_transaction_number != (1 << 48) - 1 || self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
2230                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
2231                 }
2232
2233                 let funding_txo_script = self.get_funding_redeemscript().to_v0_p2wsh();
2234                 self.channel_monitor.set_funding_info((funding_txo, funding_txo_script));
2235
2236                 let (our_signature, commitment_tx) = match self.get_outbound_funding_created_signature() {
2237                         Ok(res) => res,
2238                         Err(e) => {
2239                                 log_error!(self, "Got bad signatures: {}!", e.err);
2240                                 self.channel_monitor.unset_funding_info();
2241                                 return Err(e);
2242                         }
2243                 };
2244
2245                 let temporary_channel_id = self.channel_id;
2246
2247                 // Now that we're past error-generating stuff, update our local state:
2248                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&commitment_tx, Vec::new(), self.cur_remote_commitment_transaction_number);
2249                 self.channel_state = ChannelState::FundingCreated as u32;
2250                 self.channel_id = funding_txo.to_channel_id();
2251                 self.cur_remote_commitment_transaction_number -= 1;
2252
2253                 Ok((msgs::FundingCreated {
2254                         temporary_channel_id: temporary_channel_id,
2255                         funding_txid: funding_txo.txid,
2256                         funding_output_index: funding_txo.index,
2257                         signature: our_signature
2258                 }, self.channel_monitor.clone()))
2259         }
2260
2261         /// Gets an UnsignedChannelAnnouncement, as well as a signature covering it using our
2262         /// bitcoin_key, if available, for this channel. The channel must be publicly announceable and
2263         /// available for use (have exchanged FundingLocked messages in both directions. Should be used
2264         /// for both loose and in response to an AnnouncementSignatures message from the remote peer.
2265         /// Note that you can get an announcement for a channel which is closing, though you should
2266         /// likely not announce such a thing. In case its already been announced, a channel_update
2267         /// message can mark the channel disabled.
2268         pub fn get_channel_announcement(&self, our_node_id: PublicKey, chain_hash: Sha256dHash) -> Result<(msgs::UnsignedChannelAnnouncement, Signature), HandleError> {
2269                 if !self.announce_publicly {
2270                         return Err(HandleError{err: "Channel is not available for public announcements", action: None});
2271                 }
2272                 if self.channel_state & (ChannelState::ChannelFunded as u32) != (ChannelState::ChannelFunded as u32) {
2273                         return Err(HandleError{err: "Cannot get a ChannelAnnouncement until the channel funding has been locked", action: None});
2274                 }
2275
2276                 let were_node_one = our_node_id.serialize()[..] < self.their_node_id.serialize()[..];
2277                 let our_bitcoin_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key);
2278
2279                 let msg = msgs::UnsignedChannelAnnouncement {
2280                         features: msgs::GlobalFeatures::new(),
2281                         chain_hash: chain_hash,
2282                         short_channel_id: self.get_short_channel_id().unwrap(),
2283                         node_id_1: if were_node_one { our_node_id } else { self.get_their_node_id() },
2284                         node_id_2: if were_node_one { self.get_their_node_id() } else { our_node_id },
2285                         bitcoin_key_1: if were_node_one { our_bitcoin_key } else { self.their_funding_pubkey.unwrap() },
2286                         bitcoin_key_2: if were_node_one { self.their_funding_pubkey.unwrap() } else { our_bitcoin_key },
2287                 };
2288
2289                 let msghash = Message::from_slice(&Sha256dHash::from_data(&msg.encode()[..])[..]).unwrap();
2290                 let sig = self.secp_ctx.sign(&msghash, &self.local_keys.funding_key);
2291
2292                 Ok((msg, sig))
2293         }
2294
2295
2296         // Send stuff to our remote peers:
2297
2298         /// Adds a pending outbound HTLC to this channel, note that you probably want
2299         /// send_htlc_and_commit instead cause you'll want both messages at once.
2300         /// This returns an option instead of a pure UpdateAddHTLC as we may be in a state where we are
2301         /// waiting on the remote peer to send us a revoke_and_ack during which time we cannot add new
2302         /// HTLCs on the wire or we wouldn't be able to determine what they actually ACK'ed.
2303         pub fn send_htlc(&mut self, amount_msat: u64, payment_hash: [u8; 32], cltv_expiry: u32, onion_routing_packet: msgs::OnionPacket) -> Result<Option<msgs::UpdateAddHTLC>, HandleError> {
2304                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK)) != (ChannelState::ChannelFunded as u32) {
2305                         return Err(HandleError{err: "Cannot send HTLC until channel is fully established and we haven't started shutting down", action: None});
2306                 }
2307
2308                 if amount_msat > self.channel_value_satoshis * 1000 {
2309                         return Err(HandleError{err: "Cannot send more than the total value of the channel", action: None});
2310                 }
2311                 if amount_msat < self.their_htlc_minimum_msat {
2312                         return Err(HandleError{err: "Cannot send less than their minimum HTLC value", action: None});
2313                 }
2314
2315                 let (_, outbound_htlc_count, htlc_outbound_value_msat, htlc_inbound_value_msat) = self.get_pending_htlc_stats(false);
2316                 if outbound_htlc_count + 1 > self.their_max_accepted_htlcs as u32 {
2317                         return Err(HandleError{err: "Cannot push more than their max accepted HTLCs", action: None});
2318                 }
2319                 //TODO: Spec is unclear if this is per-direction or in total (I assume per direction):
2320                 // Check their_max_htlc_value_in_flight_msat
2321                 if htlc_outbound_value_msat + amount_msat > self.their_max_htlc_value_in_flight_msat {
2322                         return Err(HandleError{err: "Cannot send value that would put us over our max HTLC value in flight", action: None});
2323                 }
2324                 // Check their_channel_reserve_satoshis:
2325                 if htlc_inbound_value_msat + htlc_outbound_value_msat + amount_msat + (self.channel_value_satoshis * 1000 - self.value_to_self_msat) > (self.channel_value_satoshis - self.their_channel_reserve_satoshis) * 1000 {
2326                         return Err(HandleError{err: "Cannot send value that would put us over our reserve value", action: None});
2327                 }
2328
2329                 //TODO: Check cltv_expiry? Do this in channel manager?
2330
2331                 // Now update local state:
2332                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
2333                         //TODO: Check the limits *including* other pending holding cell HTLCs!
2334                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::AddHTLC {
2335                                 amount_msat: amount_msat,
2336                                 payment_hash: payment_hash,
2337                                 cltv_expiry: cltv_expiry,
2338                                 onion_routing_packet: onion_routing_packet,
2339                                 time_created: Instant::now(),
2340                         });
2341                         return Ok(None);
2342                 }
2343
2344                 self.pending_htlcs.push(HTLCOutput {
2345                         outbound: true,
2346                         htlc_id: self.next_local_htlc_id,
2347                         amount_msat: amount_msat,
2348                         payment_hash: payment_hash.clone(),
2349                         cltv_expiry: cltv_expiry,
2350                         state: HTLCState::LocalAnnounced,
2351                         fail_reason: None,
2352                         local_removed_fulfilled: false,
2353                         pending_forward_state: None
2354                 });
2355
2356                 let res = msgs::UpdateAddHTLC {
2357                         channel_id: self.channel_id,
2358                         htlc_id: self.next_local_htlc_id,
2359                         amount_msat: amount_msat,
2360                         payment_hash: payment_hash,
2361                         cltv_expiry: cltv_expiry,
2362                         onion_routing_packet: onion_routing_packet,
2363                 };
2364                 self.next_local_htlc_id += 1;
2365
2366                 Ok(Some(res))
2367         }
2368
2369         /// Creates a signed commitment transaction to send to the remote peer.
2370         pub fn send_commitment(&mut self) -> Result<(msgs::CommitmentSigned, ChannelMonitor), HandleError> {
2371                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2372                         return Err(HandleError{err: "Cannot create commitment tx until channel is fully established", action: None});
2373                 }
2374                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
2375                         return Err(HandleError{err: "Cannot create commitment tx until remote revokes their previous commitment", action: None});
2376                 }
2377                 let mut have_updates = false; // TODO initialize with "have we sent a fee update?"
2378                 for htlc in self.pending_htlcs.iter() {
2379                         if htlc.state == HTLCState::LocalAnnounced {
2380                                 have_updates = true;
2381                         }
2382                         if have_updates { break; }
2383                 }
2384                 if !have_updates {
2385                         return Err(HandleError{err: "Cannot create commitment tx until we have some updates to send", action: None});
2386                 }
2387                 self.send_commitment_no_status_check()
2388         }
2389         /// Only fails in case of bad keys
2390         fn send_commitment_no_status_check(&mut self) -> Result<(msgs::CommitmentSigned, ChannelMonitor), HandleError> {
2391                 let funding_script = self.get_funding_redeemscript();
2392
2393                 // We can upgrade the status of some HTLCs that are waiting on a commitment, even if we
2394                 // fail to generate this, we still are at least at a position where upgrading their status
2395                 // is acceptable.
2396                 for htlc in self.pending_htlcs.iter_mut() {
2397                         if htlc.state == HTLCState::AwaitingRemoteRevokeToAnnounce {
2398                                 htlc.state = HTLCState::AwaitingAnnouncedRemoteRevoke;
2399                         } else if htlc.state == HTLCState::AwaitingRemoteRevokeToRemove {
2400                                 htlc.state = HTLCState::AwaitingRemovedRemoteRevoke;
2401                         }
2402                 }
2403
2404                 let remote_keys = self.build_remote_transaction_keys()?;
2405                 let remote_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, true);
2406                 let remote_commitment_txid = remote_commitment_tx.0.txid();
2407                 let remote_sighash = Message::from_slice(&bip143::SighashComponents::new(&remote_commitment_tx.0).sighash_all(&remote_commitment_tx.0.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
2408                 let our_sig = self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key);
2409
2410                 let mut htlc_sigs = Vec::new();
2411
2412                 for ref htlc in remote_commitment_tx.1.iter() {
2413                         let htlc_tx = self.build_htlc_transaction(&remote_commitment_txid, htlc, false, &remote_keys);
2414                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &remote_keys);
2415                         let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
2416                         let our_htlc_key = secp_derived_key!(chan_utils::derive_private_key(&self.secp_ctx, &remote_keys.per_commitment_point, &self.local_keys.htlc_base_key));
2417                         htlc_sigs.push(self.secp_ctx.sign(&htlc_sighash, &our_htlc_key));
2418                 }
2419
2420                 // Update state now that we've passed all the can-fail calls...
2421                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&remote_commitment_tx.0, remote_commitment_tx.1, self.cur_remote_commitment_transaction_number);
2422                 self.channel_state |= ChannelState::AwaitingRemoteRevoke as u32;
2423
2424                 Ok((msgs::CommitmentSigned {
2425                         channel_id: self.channel_id,
2426                         signature: our_sig,
2427                         htlc_signatures: htlc_sigs,
2428                 }, self.channel_monitor.clone()))
2429         }
2430
2431         /// Adds a pending outbound HTLC to this channel, and creates a signed commitment transaction
2432         /// to send to the remote peer in one go.
2433         /// Shorthand for calling send_htlc() followed by send_commitment(), see docs on those for
2434         /// more info.
2435         pub fn send_htlc_and_commit(&mut self, amount_msat: u64, payment_hash: [u8; 32], cltv_expiry: u32, onion_routing_packet: msgs::OnionPacket) -> Result<Option<(msgs::UpdateAddHTLC, msgs::CommitmentSigned, ChannelMonitor)>, HandleError> {
2436                 match self.send_htlc(amount_msat, payment_hash, cltv_expiry, onion_routing_packet)? {
2437                         Some(update_add_htlc) => {
2438                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
2439                                 Ok(Some((update_add_htlc, commitment_signed, monitor_update)))
2440                         },
2441                         None => Ok(None)
2442                 }
2443         }
2444
2445         /// Begins the shutdown process, getting a message for the remote peer and returning all
2446         /// holding cell HTLCs for payment failure.
2447         pub fn get_shutdown(&mut self) -> Result<(msgs::Shutdown, Vec<[u8; 32]>), HandleError> {
2448                 for htlc in self.pending_htlcs.iter() {
2449                         if htlc.state == HTLCState::LocalAnnounced {
2450                                 return Err(HandleError{err: "Cannot begin shutdown with pending HTLCs, call send_commitment first", action: None});
2451                         }
2452                 }
2453                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != 0 {
2454                         return Err(HandleError{err: "Shutdown already in progress", action: None});
2455                 }
2456                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
2457
2458                 let our_closing_script = self.get_closing_scriptpubkey();
2459
2460                 // From here on out, we may not fail!
2461                 if self.channel_state < ChannelState::FundingSent as u32 {
2462                         self.channel_state = ChannelState::ShutdownComplete as u32;
2463                 } else {
2464                         self.channel_state |= ChannelState::LocalShutdownSent as u32;
2465                 }
2466                 self.channel_update_count += 1;
2467
2468                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
2469                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
2470                 // cell HTLCs and return them to fail the payment.
2471                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
2472                 self.holding_cell_htlc_updates.retain(|htlc_update| {
2473                         match htlc_update {
2474                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, .. } => {
2475                                         dropped_outbound_htlcs.push(payment_hash.clone());
2476                                         false
2477                                 },
2478                                 _ => true
2479                         }
2480                 });
2481
2482                 Ok((msgs::Shutdown {
2483                         channel_id: self.channel_id,
2484                         scriptpubkey: our_closing_script,
2485                 }, dropped_outbound_htlcs))
2486         }
2487
2488         /// Gets the latest commitment transaction and any dependant transactions for relay (forcing
2489         /// shutdown of this channel - no more calls into this Channel may be made afterwards except
2490         /// those explicitly stated to be allowed after shutdown completes, eg some simple getters).
2491         /// Also returns the list of payment_hashes for channels which we can safely fail backwards
2492         /// immediately (others we will have to allow to time out).
2493         pub fn force_shutdown(&mut self) -> (Vec<Transaction>, Vec<[u8; 32]>) {
2494                 assert!(self.channel_state != ChannelState::ShutdownComplete as u32);
2495
2496                 // We go ahead and "free" any holding cell HTLCs or HTLCs we haven't yet committed to and
2497                 // return them to fail the payment.
2498                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
2499                 for htlc_update in self.holding_cell_htlc_updates.drain(..) {
2500                         match htlc_update {
2501                                 HTLCUpdateAwaitingACK::AddHTLC { payment_hash, .. } => {
2502                                         dropped_outbound_htlcs.push(payment_hash);
2503                                 },
2504                                 _ => {}
2505                         }
2506                 }
2507
2508                 for htlc in self.pending_htlcs.drain(..) {
2509                         if htlc.state == HTLCState::LocalAnnounced {
2510                                 dropped_outbound_htlcs.push(htlc.payment_hash);
2511                         }
2512                         //TODO: Do something with the remaining HTLCs
2513                         //(we need to have the ChannelManager monitor them so we can claim the inbound HTLCs
2514                         //which correspond)
2515                 }
2516
2517                 self.channel_state = ChannelState::ShutdownComplete as u32;
2518                 self.channel_update_count += 1;
2519                 let mut res = Vec::new();
2520                 mem::swap(&mut res, &mut self.last_local_commitment_txn);
2521                 (res, dropped_outbound_htlcs)
2522         }
2523 }
2524
2525 #[cfg(test)]
2526 mod tests {
2527         use bitcoin::util::hash::Sha256dHash;
2528         use bitcoin::util::bip143;
2529         use bitcoin::network::serialize::serialize;
2530         use bitcoin::blockdata::script::Script;
2531         use bitcoin::blockdata::transaction::Transaction;
2532         use hex;
2533         use ln::channel::{Channel,ChannelKeys,HTLCOutput,HTLCState,HTLCOutputInCommitment,TxCreationKeys};
2534         use ln::channel::MAX_FUNDING_SATOSHIS;
2535         use ln::chan_utils;
2536         use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
2537         use chain::transaction::OutPoint;
2538         use util::test_utils;
2539         use util::logger::Logger;
2540         use secp256k1::{Secp256k1,Message,Signature};
2541         use secp256k1::key::{SecretKey,PublicKey};
2542         use crypto::sha2::Sha256;
2543         use crypto::digest::Digest;
2544         use std::sync::Arc;
2545
2546         struct TestFeeEstimator {
2547                 fee_est: u64
2548         }
2549         impl FeeEstimator for TestFeeEstimator {
2550                 fn get_est_sat_per_1000_weight(&self, _: ConfirmationTarget) -> u64 {
2551                         self.fee_est
2552                 }
2553         }
2554
2555         #[test]
2556         fn test_max_funding_satoshis() {
2557                 assert!(MAX_FUNDING_SATOSHIS <= 21_000_000 * 100_000_000,
2558                         "MAX_FUNDING_SATOSHIS is greater than all satoshis on existence");
2559         }
2560
2561         #[test]
2562         fn outbound_commitment_test() {
2563                 // Test vectors from BOLT 3 Appendix C:
2564                 let feeest = TestFeeEstimator{fee_est: 15000};
2565                 let logger : Arc<Logger> = Arc::new(test_utils::TestLogger::new());
2566                 let secp_ctx = Secp256k1::new();
2567
2568                 let chan_keys = ChannelKeys {
2569                         funding_key: SecretKey::from_slice(&secp_ctx, &hex::decode("30ff4956bbdd3222d44cc5e8a1261dab1e07957bdac5ae88fe3261ef321f3749").unwrap()[..]).unwrap(),
2570                         payment_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
2571                         delayed_payment_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("3333333333333333333333333333333333333333333333333333333333333333").unwrap()[..]).unwrap(),
2572                         htlc_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
2573
2574                         // These aren't set in the test vectors:
2575                         revocation_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
2576                         channel_close_key: SecretKey::from_slice(&secp_ctx, &hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
2577                         channel_monitor_claim_key: SecretKey::from_slice(&secp_ctx, &hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
2578                         commitment_seed: [0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff],
2579                 };
2580                 assert_eq!(PublicKey::from_secret_key(&secp_ctx, &chan_keys.funding_key).serialize()[..],
2581                                 hex::decode("023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb").unwrap()[..]);
2582
2583                 let their_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &[42; 32]).unwrap());
2584                 let mut chan = Channel::new_outbound(&feeest, chan_keys, their_node_id, 10000000, 100000, false, 42, Arc::clone(&logger)).unwrap(); // Nothing uses their network key in this test
2585                 chan.their_to_self_delay = 144;
2586                 chan.our_dust_limit_satoshis = 546;
2587
2588                 let funding_info = OutPoint::new(Sha256dHash::from_hex("8984484a580b825b9972d7adb15050b3ab624ccd731946b3eeddb92f4e7ef6be").unwrap(), 0);
2589                 chan.channel_monitor.set_funding_info((funding_info, Script::new()));
2590
2591                 chan.their_payment_basepoint = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex::decode("4444444444444444444444444444444444444444444444444444444444444444").unwrap()[..]).unwrap()));
2592                 assert_eq!(chan.their_payment_basepoint.unwrap().serialize()[..],
2593                                 hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
2594
2595                 chan.their_funding_pubkey = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex::decode("1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13").unwrap()[..]).unwrap()));
2596                 assert_eq!(chan.their_funding_pubkey.unwrap().serialize()[..],
2597                                 hex::decode("030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c1").unwrap()[..]);
2598
2599                 chan.their_htlc_basepoint = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex::decode("4444444444444444444444444444444444444444444444444444444444444444").unwrap()[..]).unwrap()));
2600                 assert_eq!(chan.their_htlc_basepoint.unwrap().serialize()[..],
2601                                 hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
2602
2603                 chan.their_revocation_basepoint = Some(PublicKey::from_slice(&secp_ctx, &hex::decode("02466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27").unwrap()[..]).unwrap());
2604
2605                 // We can't just use build_local_transaction_keys here as the per_commitment_secret is not
2606                 // derived from a commitment_seed, so instead we copy it here and call
2607                 // build_commitment_transaction.
2608                 let delayed_payment_base = PublicKey::from_secret_key(&secp_ctx, &chan.local_keys.delayed_payment_base_key);
2609                 let per_commitment_secret = SecretKey::from_slice(&secp_ctx, &hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
2610                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
2611                 let htlc_basepoint = PublicKey::from_secret_key(&secp_ctx, &chan.local_keys.htlc_base_key);
2612                 let keys = TxCreationKeys::new(&secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &chan.their_revocation_basepoint.unwrap(), &chan.their_payment_basepoint.unwrap(), &chan.their_htlc_basepoint.unwrap()).unwrap();
2613
2614                 let mut unsigned_tx: (Transaction, Vec<HTLCOutputInCommitment>);
2615
2616                 macro_rules! test_commitment {
2617                         ( $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr) => {
2618                                 unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false);
2619                                 let their_signature = Signature::from_der(&secp_ctx, &hex::decode($their_sig_hex).unwrap()[..]).unwrap();
2620                                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&unsigned_tx.0).sighash_all(&unsigned_tx.0.input[0], &chan.get_funding_redeemscript(), chan.channel_value_satoshis)[..]).unwrap();
2621                                 secp_ctx.verify(&sighash, &their_signature, &chan.their_funding_pubkey.unwrap()).unwrap();
2622
2623                                 chan.sign_commitment_transaction(&mut unsigned_tx.0, &their_signature);
2624
2625                                 assert_eq!(serialize(&unsigned_tx.0).unwrap()[..],
2626                                                 hex::decode($tx_hex).unwrap()[..]);
2627                         };
2628                 }
2629
2630                 macro_rules! test_htlc_output {
2631                         ( $htlc_idx: expr, $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr ) => {
2632                                 let remote_signature = Signature::from_der(&secp_ctx, &hex::decode($their_sig_hex).unwrap()[..]).unwrap();
2633
2634                                 let ref htlc = unsigned_tx.1[$htlc_idx];
2635                                 let mut htlc_tx = chan.build_htlc_transaction(&unsigned_tx.0.txid(), &htlc, true, &keys);
2636                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys);
2637                                 let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
2638                                 secp_ctx.verify(&htlc_sighash, &remote_signature, &keys.b_htlc_key).unwrap();
2639
2640                                 let mut preimage: Option<[u8; 32]> = None;
2641                                 if !htlc.offered {
2642                                         for i in 0..5 {
2643                                                 let mut sha = Sha256::new();
2644                                                 sha.input(&[i; 32]);
2645
2646                                                 let mut out = [0; 32];
2647                                                 sha.result(&mut out);
2648
2649                                                 if out == htlc.payment_hash {
2650                                                         preimage = Some([i; 32]);
2651                                                 }
2652                                         }
2653
2654                                         assert!(preimage.is_some());
2655                                 }
2656
2657                                 chan.sign_htlc_transaction(&mut htlc_tx, &remote_signature, &preimage, &htlc, &keys).unwrap();
2658                                 assert_eq!(serialize(&htlc_tx).unwrap()[..],
2659                                                 hex::decode($tx_hex).unwrap()[..]);
2660                         };
2661                 }
2662
2663                 {
2664                         // simple commitment tx with no HTLCs
2665                         chan.value_to_self_msat = 7000000000;
2666
2667                         test_commitment!("3045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c0",
2668                                          "3044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c3836939",
2669                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311054a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c383693901483045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2670                 }
2671
2672                 chan.pending_htlcs.push({
2673                         let mut out = HTLCOutput{
2674                                 htlc_id: 0,
2675                                 outbound: false,
2676                                 amount_msat: 1000000,
2677                                 cltv_expiry: 500,
2678                                 payment_hash: [0; 32],
2679                                 state: HTLCState::Committed,
2680                                 fail_reason: None,
2681                                 local_removed_fulfilled: false,
2682                                 pending_forward_state: None,
2683                         };
2684                         let mut sha = Sha256::new();
2685                         sha.input(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
2686                         sha.result(&mut out.payment_hash);
2687                         out
2688                 });
2689                 chan.pending_htlcs.push({
2690                         let mut out = HTLCOutput{
2691                                 htlc_id: 1,
2692                                 outbound: false,
2693                                 amount_msat: 2000000,
2694                                 cltv_expiry: 501,
2695                                 payment_hash: [0; 32],
2696                                 state: HTLCState::Committed,
2697                                 fail_reason: None,
2698                                 local_removed_fulfilled: false,
2699                                 pending_forward_state: None,
2700                         };
2701                         let mut sha = Sha256::new();
2702                         sha.input(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
2703                         sha.result(&mut out.payment_hash);
2704                         out
2705                 });
2706                 chan.pending_htlcs.push({
2707                         let mut out = HTLCOutput{
2708                                 htlc_id: 2,
2709                                 outbound: true,
2710                                 amount_msat: 2000000,
2711                                 cltv_expiry: 502,
2712                                 payment_hash: [0; 32],
2713                                 state: HTLCState::Committed,
2714                                 fail_reason: None,
2715                                 local_removed_fulfilled: false,
2716                                 pending_forward_state: None,
2717                         };
2718                         let mut sha = Sha256::new();
2719                         sha.input(&hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap());
2720                         sha.result(&mut out.payment_hash);
2721                         out
2722                 });
2723                 chan.pending_htlcs.push({
2724                         let mut out = HTLCOutput{
2725                                 htlc_id: 3,
2726                                 outbound: true,
2727                                 amount_msat: 3000000,
2728                                 cltv_expiry: 503,
2729                                 payment_hash: [0; 32],
2730                                 state: HTLCState::Committed,
2731                                 fail_reason: None,
2732                                 local_removed_fulfilled: false,
2733                                 pending_forward_state: None,
2734                         };
2735                         let mut sha = Sha256::new();
2736                         sha.input(&hex::decode("0303030303030303030303030303030303030303030303030303030303030303").unwrap());
2737                         sha.result(&mut out.payment_hash);
2738                         out
2739                 });
2740                 chan.pending_htlcs.push({
2741                         let mut out = HTLCOutput{
2742                                 htlc_id: 4,
2743                                 outbound: false,
2744                                 amount_msat: 4000000,
2745                                 cltv_expiry: 504,
2746                                 payment_hash: [0; 32],
2747                                 state: HTLCState::Committed,
2748                                 fail_reason: None,
2749                                 local_removed_fulfilled: false,
2750                                 pending_forward_state: None,
2751                         };
2752                         let mut sha = Sha256::new();
2753                         sha.input(&hex::decode("0404040404040404040404040404040404040404040404040404040404040404").unwrap());
2754                         sha.result(&mut out.payment_hash);
2755                         out
2756                 });
2757
2758                 {
2759                         // commitment tx with all five HTLCs untrimmed (minimum feerate)
2760                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2761                         chan.feerate_per_kw = 0;
2762
2763                         test_commitment!("304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b70606",
2764                                          "30440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f06",
2765                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f060147304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b7060601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2766
2767                         assert_eq!(unsigned_tx.1.len(), 5);
2768
2769                         test_htlc_output!(0,
2770                                           "304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a6",
2771                                           "304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5",
2772                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219700000000000000000001e8030000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a60147304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
2773
2774                         test_htlc_output!(1,
2775                                           "3045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b",
2776                                           "3045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be5",
2777                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219701000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b01483045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2778
2779                         test_htlc_output!(2,
2780                                           "304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f202",
2781                                           "3045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da",
2782                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219702000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f20201483045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
2783
2784                         test_htlc_output!(3,
2785                                           "3045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554",
2786                                           "30440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac08727",
2787                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219703000000000000000001b80b0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554014730440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac0872701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2788
2789                         test_htlc_output!(4,
2790                                           "304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d",
2791                                           "30440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e",
2792                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219704000000000000000001a00f0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d014730440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2793                 }
2794
2795                 {
2796                         // commitment tx with seven outputs untrimmed (maximum feerate)
2797                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2798                         chan.feerate_per_kw = 647;
2799
2800                         test_commitment!("3045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b",
2801                                          "304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d1163",
2802                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040048304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d116301483045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2803
2804                         assert_eq!(unsigned_tx.1.len(), 5);
2805
2806                         test_htlc_output!(0,
2807                                           "30440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab343740",
2808                                           "304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a",
2809                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab3437400147304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
2810
2811                         test_htlc_output!(1,
2812                                           "304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b0",
2813                                           "304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac",
2814                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60100000000000000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b00147304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2815
2816                         test_htlc_output!(2,
2817                                           "304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d833",
2818                                           "3045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877",
2819                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6020000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d83301483045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
2820
2821                         test_htlc_output!(3,
2822                                           "30450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d",
2823                                           "3045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb",
2824                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6030000000000000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d01483045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2825
2826                         test_htlc_output!(4,
2827                                           "3045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f0",
2828                                           "304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f",
2829                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb604000000000000000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f00147304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2830                 }
2831
2832                 {
2833                         // commitment tx with six outputs untrimmed (minimum feerate)
2834                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2835                         chan.feerate_per_kw = 648;
2836
2837                         test_commitment!("3044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b057",
2838                                          "3045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de",
2839                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431104e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de01473044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b05701475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2840
2841                         assert_eq!(unsigned_tx.1.len(), 4);
2842
2843                         test_htlc_output!(0,
2844                                           "3044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada8",
2845                                           "3045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc098",
2846                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10000000000000000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada801483045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc09801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2847
2848                         test_htlc_output!(1,
2849                                           "3045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d4",
2850                                           "304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0",
2851                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10100000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d40147304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
2852
2853                         test_htlc_output!(2,
2854                                           "3045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c2",
2855                                           "304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda3",
2856                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd1020000000000000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c20147304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda301008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2857
2858                         test_htlc_output!(3,
2859                                           "3044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f",
2860                                           "304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6",
2861                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd103000000000000000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f0147304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2862                 }
2863
2864                 {
2865                         // commitment tx with six outputs untrimmed (maximum feerate)
2866                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2867                         chan.feerate_per_kw = 2069;
2868
2869                         test_commitment!("3044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb4",
2870                                          "304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea",
2871                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311077956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea01473044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2872
2873                         assert_eq!(unsigned_tx.1.len(), 4);
2874
2875                         test_htlc_output!(0,
2876                                           "3045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f992",
2877                                           "3044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae66402",
2878                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0000000000000000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f99201473044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae6640201008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2879
2880                         test_htlc_output!(1,
2881                                           "3045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f4",
2882                                           "3045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f",
2883                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0100000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f401483045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
2884
2885                         test_htlc_output!(2,
2886                                           "3045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef18",
2887                                           "304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f9",
2888                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a020000000000000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef180147304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f901008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2889
2890                         test_htlc_output!(3,
2891                                           "30450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c",
2892                                           "304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5",
2893                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a03000000000000000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c0147304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2894                 }
2895
2896                 {
2897                         // commitment tx with five outputs untrimmed (minimum feerate)
2898                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2899                         chan.feerate_per_kw = 2070;
2900
2901                         test_commitment!("3045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f37526",
2902                                          "30440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd0",
2903                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd001483045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f3752601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2904
2905                         assert_eq!(unsigned_tx.1.len(), 3);
2906
2907                         test_htlc_output!(0,
2908                                           "3045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f891",
2909                                           "3045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb8",
2910                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a2180000000000000000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f89101483045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2911
2912                         test_htlc_output!(1,
2913                                           "3044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf6",
2914                                           "3045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d",
2915                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a218010000000000000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf601483045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2916
2917                         test_htlc_output!(2,
2918                                           "3045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a4",
2919                                           "304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04",
2920                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a21802000000000000000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a40147304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2921                 }
2922
2923                 {
2924                         // commitment tx with five outputs untrimmed (maximum feerate)
2925                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2926                         chan.feerate_per_kw = 2194;
2927
2928                         test_commitment!("3045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec86203953348",
2929                                          "304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f7061",
2930                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311040966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f706101483045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec8620395334801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2931
2932                         assert_eq!(unsigned_tx.1.len(), 3);
2933
2934                         test_htlc_output!(0,
2935                                           "30450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf44",
2936                                           "3044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f",
2937                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf4401473044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2938
2939                         test_htlc_output!(1,
2940                                           "30440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d",
2941                                           "304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c915",
2942                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a010000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d0147304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c91501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2943
2944                         test_htlc_output!(2,
2945                                           "3045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a",
2946                                           "3045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0",
2947                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a020000000000000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a01483045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2948                 }
2949
2950                 {
2951                         // commitment tx with four outputs untrimmed (minimum feerate)
2952                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2953                         chan.feerate_per_kw = 2195;
2954
2955                         test_commitment!("304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb7924298",
2956                                          "304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a5429",
2957                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a54290147304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb792429801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2958
2959                         assert_eq!(unsigned_tx.1.len(), 2);
2960
2961                         test_htlc_output!(0,
2962                                           "3045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc",
2963                                           "3045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc704390",
2964                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0000000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc01483045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc70439001008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2965
2966                         test_htlc_output!(1,
2967                                           "3045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92",
2968                                           "30440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8",
2969                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0100000000000000000199090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92014730440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2970                 }
2971
2972                 {
2973                         // commitment tx with four outputs untrimmed (maximum feerate)
2974                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2975                         chan.feerate_per_kw = 3702;
2976
2977                         test_commitment!("3045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c1",
2978                                          "304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b0",
2979                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431106f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b001483045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c101475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2980
2981                         assert_eq!(unsigned_tx.1.len(), 2);
2982
2983                         test_htlc_output!(0,
2984                                           "3045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb",
2985                                           "304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a",
2986                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb0147304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2987
2988                         test_htlc_output!(1,
2989                                           "3045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9",
2990                                           "30440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c",
2991                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30100000000000000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9014730440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2992                 }
2993
2994                 {
2995                         // commitment tx with three outputs untrimmed (minimum feerate)
2996                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2997                         chan.feerate_per_kw = 3703;
2998
2999                         test_commitment!("30450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb0",
3000                                          "3044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506",
3001                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506014830450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3002
3003                         assert_eq!(unsigned_tx.1.len(), 1);
3004
3005                         test_htlc_output!(0,
3006                                           "3044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd",
3007                                           "3045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724",
3008                                           "020000000001011c076aa7fb3d7460d10df69432c904227ea84bbf3134d4ceee5fb0f135ef206d0000000000000000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd01483045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
3009                 }
3010
3011                 {
3012                         // commitment tx with three outputs untrimmed (maximum feerate)
3013                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
3014                         chan.feerate_per_kw = 4914;
3015
3016                         test_commitment!("304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e",
3017                                          "304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe26",
3018                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe260147304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3019
3020                         assert_eq!(unsigned_tx.1.len(), 1);
3021
3022                         test_htlc_output!(0,
3023                                           "3045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf",
3024                                           "304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68",
3025                                           "0200000000010110a3fdcbcd5db477cd3ad465e7f501ffa8c437e8301f00a6061138590add757f0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf0148304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
3026                 }
3027
3028                 {
3029                         // commitment tx with two outputs untrimmed (minimum feerate)
3030                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
3031                         chan.feerate_per_kw = 4915;
3032
3033                         test_commitment!("304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f8765552",
3034                                          "3045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b9",
3035                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b90147304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f876555201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3036
3037                         assert_eq!(unsigned_tx.1.len(), 0);
3038                 }
3039
3040                 {
3041                         // commitment tx with two outputs untrimmed (maximum feerate)
3042                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
3043                         chan.feerate_per_kw = 9651180;
3044
3045                         test_commitment!("3044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd",
3046                                          "30440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b9",
3047                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311004004730440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b901473044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3048
3049                         assert_eq!(unsigned_tx.1.len(), 0);
3050                 }
3051
3052                 {
3053                         // commitment tx with one output untrimmed (minimum feerate)
3054                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
3055                         chan.feerate_per_kw = 9651181;
3056
3057                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
3058                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
3059                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3060
3061                         assert_eq!(unsigned_tx.1.len(), 0);
3062                 }
3063
3064                 {
3065                         // commitment tx with fee greater than funder amount
3066                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
3067                         chan.feerate_per_kw = 9651936;
3068
3069                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
3070                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
3071                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
3072
3073                         assert_eq!(unsigned_tx.1.len(), 0);
3074                 }
3075         }
3076
3077         #[test]
3078         fn test_per_commitment_secret_gen() {
3079                 // Test vectors from BOLT 3 Appendix D:
3080
3081                 let mut seed = [0; 32];
3082                 seed[0..32].clone_from_slice(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
3083                 assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655),
3084                            hex::decode("02a40c85b6f28da08dfdbe0926c53fab2de6d28c10301f8f7c4073d5e42e3148").unwrap()[..]);
3085
3086                 seed[0..32].clone_from_slice(&hex::decode("FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF").unwrap());
3087                 assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655),
3088                            hex::decode("7cc854b54e3e0dcdb010d7a3fee464a9687be6e8db3be6854c475621e007a5dc").unwrap()[..]);
3089
3090                 assert_eq!(chan_utils::build_commitment_secret(seed, 0xaaaaaaaaaaa),
3091                            hex::decode("56f4008fb007ca9acf0e15b054d5c9fd12ee06cea347914ddbaed70d1c13a528").unwrap()[..]);
3092
3093                 assert_eq!(chan_utils::build_commitment_secret(seed, 0x555555555555),
3094                            hex::decode("9015daaeb06dba4ccc05b91b2f73bd54405f2be9f217fbacd3c5ac2e62327d31").unwrap()[..]);
3095
3096                 seed[0..32].clone_from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
3097                 assert_eq!(chan_utils::build_commitment_secret(seed, 1),
3098                            hex::decode("915c75942a26bb3a433a8ce2cb0427c29ec6c1775cfc78328b57f6ba7bfeaa9c").unwrap()[..]);
3099         }
3100
3101         #[test]
3102         fn test_key_derivation() {
3103                 // Test vectors from BOLT 3 Appendix E:
3104                 let secp_ctx = Secp256k1::new();
3105
3106                 let base_secret = SecretKey::from_slice(&secp_ctx, &hex::decode("000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f").unwrap()[..]).unwrap();
3107                 let per_commitment_secret = SecretKey::from_slice(&secp_ctx, &hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
3108
3109                 let base_point = PublicKey::from_secret_key(&secp_ctx, &base_secret);
3110                 assert_eq!(base_point.serialize()[..], hex::decode("036d6caac248af96f6afa7f904f550253a0f3ef3f5aa2fe6838a95b216691468e2").unwrap()[..]);
3111
3112                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
3113                 assert_eq!(per_commitment_point.serialize()[..], hex::decode("025f7117a78150fe2ef97db7cfc83bd57b2e2c0d0dd25eaf467a4a1c2a45ce1486").unwrap()[..]);
3114
3115                 assert_eq!(chan_utils::derive_public_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
3116                                 hex::decode("0235f2dbfaa89b57ec7b055afe29849ef7ddfeb1cefdb9ebdc43f5494984db29e5").unwrap()[..]);
3117
3118                 assert_eq!(chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &base_secret).unwrap(),
3119                                 SecretKey::from_slice(&secp_ctx, &hex::decode("cbced912d3b21bf196a766651e436aff192362621ce317704ea2f75d87e7be0f").unwrap()[..]).unwrap());
3120
3121                 assert_eq!(chan_utils::derive_public_revocation_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
3122                                 hex::decode("02916e326636d19c33f13e8c0c3a03dd157f332f3e99c317c141dd865eb01f8ff0").unwrap()[..]);
3123
3124                 assert_eq!(chan_utils::derive_private_revocation_key(&secp_ctx, &per_commitment_secret, &base_secret).unwrap(),
3125                                 SecretKey::from_slice(&secp_ctx, &hex::decode("d09ffff62ddb2297ab000cc85bcb4283fdeb6aa052affbc9dddcf33b61078110").unwrap()[..]).unwrap());
3126         }
3127 }