Merge pull request #253 from TheBlueMatt/2018-11-misc-tweaks
[rust-lightning] / src / ln / channel.rs
1 use bitcoin::blockdata::block::BlockHeader;
2 use bitcoin::blockdata::script::{Script,Builder};
3 use bitcoin::blockdata::transaction::{TxIn, TxOut, Transaction, SigHashType};
4 use bitcoin::blockdata::opcodes;
5 use bitcoin::util::hash::{BitcoinHash, Sha256dHash, Hash160};
6 use bitcoin::util::bip143;
7 use bitcoin::consensus::encode::{self, Encodable, Decodable};
8
9 use secp256k1::key::{PublicKey,SecretKey};
10 use secp256k1::{Secp256k1,Message,Signature};
11 use secp256k1;
12
13 use crypto::digest::Digest;
14
15 use ln::msgs;
16 use ln::msgs::{DecodeError, ErrorAction, HandleError};
17 use ln::channelmonitor::ChannelMonitor;
18 use ln::channelmanager::{PendingHTLCStatus, HTLCSource, HTLCFailReason, HTLCFailureMsg, PendingForwardHTLCInfo, RAACommitmentOrder};
19 use ln::chan_utils::{TxCreationKeys,HTLCOutputInCommitment,HTLC_SUCCESS_TX_WEIGHT,HTLC_TIMEOUT_TX_WEIGHT};
20 use ln::chan_utils;
21 use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
22 use chain::transaction::OutPoint;
23 use chain::keysinterface::{ChannelKeys, KeysInterface};
24 use util::{transaction_utils,rng};
25 use util::ser::{Readable, ReadableArgs, Writeable, Writer, WriterWriteAdaptor};
26 use util::sha2::Sha256;
27 use util::logger::Logger;
28 use util::errors::APIError;
29 use util::config::{UserConfig,ChannelConfig};
30
31 use std;
32 use std::default::Default;
33 use std::{cmp,mem};
34 use std::time::Instant;
35 use std::sync::{Arc};
36
37 #[cfg(test)]
38 pub struct ChannelValueStat {
39         pub value_to_self_msat: u64,
40         pub channel_value_msat: u64,
41         pub channel_reserve_msat: u64,
42         pub pending_outbound_htlcs_amount_msat: u64,
43         pub pending_inbound_htlcs_amount_msat: u64,
44         pub holding_cell_outbound_amount_msat: u64,
45         pub their_max_htlc_value_in_flight_msat: u64, // outgoing
46 }
47
48 enum InboundHTLCRemovalReason {
49         FailRelay(msgs::OnionErrorPacket),
50         FailMalformed(([u8; 32], u16)),
51         Fulfill([u8; 32]),
52 }
53
54 enum InboundHTLCState {
55         /// Added by remote, to be included in next local commitment tx.
56         RemoteAnnounced(PendingHTLCStatus),
57         /// Included in a received commitment_signed message (implying we've revoke_and_ack'ed it), but
58         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
59         /// accept this HTLC. Implies AwaitingRemoteRevoke.
60         /// We also have not yet included this HTLC in a commitment_signed message, and are waiting on
61         /// a remote revoke_and_ack on a previous state before we can do so.
62         AwaitingRemoteRevokeToAnnounce(PendingHTLCStatus),
63         /// Included in a received commitment_signed message (implying we've revoke_and_ack'ed it), but
64         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
65         /// accept this HTLC. Implies AwaitingRemoteRevoke.
66         /// We have included this HTLC in our latest commitment_signed and are now just waiting on a
67         /// revoke_and_ack.
68         AwaitingAnnouncedRemoteRevoke(PendingHTLCStatus),
69         Committed,
70         /// Removed by us and a new commitment_signed was sent (if we were AwaitingRemoteRevoke when we
71         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
72         /// we'll drop it.
73         /// Note that we have to keep an eye on the HTLC until we've received a broadcastable
74         /// commitment transaction without it as otherwise we'll have to force-close the channel to
75         /// claim it before the timeout (obviously doesn't apply to revoked HTLCs that we can't claim
76         /// anyway). That said, ChannelMonitor does this for us (see
77         /// ChannelMonitor::would_broadcast_at_height) so we actually remove the HTLC from our own
78         /// local state before then, once we're sure that the next commitment_signed and
79         /// ChannelMonitor::provide_latest_local_commitment_tx_info will not include this HTLC.
80         LocalRemoved(InboundHTLCRemovalReason),
81 }
82
83 struct InboundHTLCOutput {
84         htlc_id: u64,
85         amount_msat: u64,
86         cltv_expiry: u32,
87         payment_hash: [u8; 32],
88         state: InboundHTLCState,
89 }
90
91 enum OutboundHTLCState {
92         /// Added by us and included in a commitment_signed (if we were AwaitingRemoteRevoke when we
93         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
94         /// we will promote to Committed (note that they may not accept it until the next time we
95         /// revoke, but we dont really care about that:
96         ///  * they've revoked, so worst case we can announce an old state and get our (option on)
97         ///    money back (though we wont), and,
98         ///  * we'll send them a revoke when they send a commitment_signed, and since only they're
99         ///    allowed to remove it, the "can only be removed once committed on both sides" requirement
100         ///    doesn't matter to us and its up to them to enforce it, worst-case they jump ahead but
101         ///    we'll never get out of sync).
102         /// Note that we Box the OnionPacket as its rather large and we don't want to blow up
103         /// OutboundHTLCOutput's size just for a temporary bit
104         LocalAnnounced(Box<msgs::OnionPacket>),
105         Committed,
106         /// Remote removed this (outbound) HTLC. We're waiting on their commitment_signed to finalize
107         /// the change (though they'll need to revoke before we fail the payment).
108         RemoteRemoved,
109         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
110         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
111         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
112         /// We also have not yet removed this HTLC in a commitment_signed message, and are waiting on a
113         /// remote revoke_and_ack on a previous state before we can do so.
114         AwaitingRemoteRevokeToRemove,
115         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
116         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
117         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
118         /// We have removed this HTLC in our latest commitment_signed and are now just waiting on a
119         /// revoke_and_ack to drop completely.
120         AwaitingRemovedRemoteRevoke,
121 }
122
123 struct OutboundHTLCOutput {
124         htlc_id: u64,
125         amount_msat: u64,
126         cltv_expiry: u32,
127         payment_hash: [u8; 32],
128         state: OutboundHTLCState,
129         source: HTLCSource,
130         /// If we're in a removed state, set if they failed, otherwise None
131         fail_reason: Option<HTLCFailReason>,
132 }
133
134 macro_rules! get_htlc_in_commitment {
135         ($htlc: expr, $offered: expr) => {
136                 HTLCOutputInCommitment {
137                         offered: $offered,
138                         amount_msat: $htlc.amount_msat,
139                         cltv_expiry: $htlc.cltv_expiry,
140                         payment_hash: $htlc.payment_hash,
141                         transaction_output_index: 0
142                 }
143         }
144 }
145
146 /// See AwaitingRemoteRevoke ChannelState for more info
147 enum HTLCUpdateAwaitingACK {
148         AddHTLC {
149                 // always outbound
150                 amount_msat: u64,
151                 cltv_expiry: u32,
152                 payment_hash: [u8; 32],
153                 source: HTLCSource,
154                 onion_routing_packet: msgs::OnionPacket,
155                 time_created: Instant, //TODO: Some kind of timeout thing-a-majig
156         },
157         ClaimHTLC {
158                 payment_preimage: [u8; 32],
159                 htlc_id: u64,
160         },
161         FailHTLC {
162                 htlc_id: u64,
163                 err_packet: msgs::OnionErrorPacket,
164         },
165 }
166
167 /// There are a few "states" and then a number of flags which can be applied:
168 /// We first move through init with OurInitSent -> TheirInitSent -> FundingCreated -> FundingSent.
169 /// TheirFundingLocked and OurFundingLocked then get set on FundingSent, and when both are set we
170 /// move on to ChannelFunded.
171 /// Note that PeerDisconnected can be set on both ChannelFunded and FundingSent.
172 /// ChannelFunded can then get all remaining flags set on it, until we finish shutdown, then we
173 /// move on to ShutdownComplete, at which point most calls into this channel are disallowed.
174 enum ChannelState {
175         /// Implies we have (or are prepared to) send our open_channel/accept_channel message
176         OurInitSent = (1 << 0),
177         /// Implies we have received their open_channel/accept_channel message
178         TheirInitSent = (1 << 1),
179         /// We have sent funding_created and are awaiting a funding_signed to advance to FundingSent.
180         /// Note that this is nonsense for an inbound channel as we immediately generate funding_signed
181         /// upon receipt of funding_created, so simply skip this state.
182         FundingCreated = 4,
183         /// Set when we have received/sent funding_created and funding_signed and are thus now waiting
184         /// on the funding transaction to confirm. The FundingLocked flags are set to indicate when we
185         /// and our counterparty consider the funding transaction confirmed.
186         FundingSent = 8,
187         /// Flag which can be set on FundingSent to indicate they sent us a funding_locked message.
188         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
189         TheirFundingLocked = (1 << 4),
190         /// Flag which can be set on FundingSent to indicate we sent them a funding_locked message.
191         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
192         OurFundingLocked = (1 << 5),
193         ChannelFunded = 64,
194         /// Flag which is set on ChannelFunded and FundingSent indicating remote side is considered
195         /// "disconnected" and no updates are allowed until after we've done a channel_reestablish
196         /// dance.
197         PeerDisconnected = (1 << 7),
198         /// Flag which is set on ChannelFunded and FundingSent indicating the user has told us they
199         /// failed to update our ChannelMonitor somewhere and we should pause sending any outbound
200         /// messages until they've managed to do so.
201         MonitorUpdateFailed = (1 << 8),
202         /// Flag which implies that we have sent a commitment_signed but are awaiting the responding
203         /// revoke_and_ack message. During this time period, we can't generate new commitment_signed
204         /// messages as then we will be unable to determine which HTLCs they included in their
205         /// revoke_and_ack implicit ACK, so instead we have to hold them away temporarily to be sent
206         /// later.
207         /// Flag is set on ChannelFunded.
208         AwaitingRemoteRevoke = (1 << 9),
209         /// Flag which is set on ChannelFunded or FundingSent after receiving a shutdown message from
210         /// the remote end. If set, they may not add any new HTLCs to the channel, and we are expected
211         /// to respond with our own shutdown message when possible.
212         RemoteShutdownSent = (1 << 10),
213         /// Flag which is set on ChannelFunded or FundingSent after sending a shutdown message. At this
214         /// point, we may not add any new HTLCs to the channel.
215         /// TODO: Investigate some kind of timeout mechanism by which point the remote end must provide
216         /// us their shutdown.
217         LocalShutdownSent = (1 << 11),
218         /// We've successfully negotiated a closing_signed dance. At this point ChannelManager is about
219         /// to drop us, but we store this anyway.
220         ShutdownComplete = 4096,
221 }
222 const BOTH_SIDES_SHUTDOWN_MASK: u32 = (ChannelState::LocalShutdownSent as u32 | ChannelState::RemoteShutdownSent as u32);
223 const MULTI_STATE_FLAGS: u32 = (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32);
224
225 const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
226
227 // TODO: We should refactor this to be an Inbound/OutboundChannel until initial setup handshaking
228 // has been completed, and then turn into a Channel to get compiler-time enforcement of things like
229 // calling channel_id() before we're set up or things like get_outbound_funding_signed on an
230 // inbound channel.
231 pub(super) struct Channel {
232         config: ChannelConfig,
233
234         user_id: u64,
235
236         channel_id: [u8; 32],
237         channel_state: u32,
238         channel_outbound: bool,
239         secp_ctx: Secp256k1<secp256k1::All>,
240         channel_value_satoshis: u64,
241
242         local_keys: ChannelKeys,
243         shutdown_pubkey: PublicKey,
244
245         // Our commitment numbers start at 2^48-1 and count down, whereas the ones used in transaction
246         // generation start at 0 and count up...this simplifies some parts of implementation at the
247         // cost of others, but should really just be changed.
248
249         cur_local_commitment_transaction_number: u64,
250         cur_remote_commitment_transaction_number: u64,
251         value_to_self_msat: u64, // Excluding all pending_htlcs, excluding fees
252         /// Upon receipt of a channel_reestablish we have to figure out whether to send a
253         /// revoke_and_ack first or a commitment update first. Generally, we prefer to send
254         /// revoke_and_ack first, but if we had a pending commitment update of our own waiting on a
255         /// remote revoke when we received the latest commitment update from the remote we have to make
256         /// sure that commitment update gets resent first.
257         received_commitment_while_awaiting_raa: bool,
258         pending_inbound_htlcs: Vec<InboundHTLCOutput>,
259         pending_outbound_htlcs: Vec<OutboundHTLCOutput>,
260         holding_cell_htlc_updates: Vec<HTLCUpdateAwaitingACK>,
261
262         monitor_pending_revoke_and_ack: bool,
263         monitor_pending_commitment_signed: bool,
264         monitor_pending_order: Option<RAACommitmentOrder>,
265         monitor_pending_forwards: Vec<(PendingForwardHTLCInfo, u64)>,
266         monitor_pending_failures: Vec<(HTLCSource, [u8; 32], HTLCFailReason)>,
267
268         // pending_update_fee is filled when sending and receiving update_fee
269         // For outbound channel, feerate_per_kw is updated with the value from
270         // pending_update_fee when revoke_and_ack is received
271         //
272         // For inbound channel, feerate_per_kw is updated when it receives
273         // commitment_signed and revoke_and_ack is generated
274         // The pending value is kept when another pair of update_fee and commitment_signed
275         // is received during AwaitingRemoteRevoke and relieved when the expected
276         // revoke_and_ack is received and new commitment_signed is generated to be
277         // sent to the funder. Otherwise, the pending value is removed when receiving
278         // commitment_signed.
279         pending_update_fee: Option<u64>,
280         // update_fee() during ChannelState::AwaitingRemoteRevoke is hold in
281         // holdina_cell_update_fee then moved to pending_udpate_fee when revoke_and_ack
282         // is received. holding_cell_update_fee is updated when there are additional
283         // update_fee() during ChannelState::AwaitingRemoteRevoke.
284         holding_cell_update_fee: Option<u64>,
285         next_local_htlc_id: u64,
286         next_remote_htlc_id: u64,
287         channel_update_count: u32,
288         feerate_per_kw: u64,
289
290         #[cfg(debug_assertions)]
291         /// Max to_local and to_remote outputs in a locally-generated commitment transaction
292         max_commitment_tx_output_local: ::std::sync::Mutex<(u64, u64)>,
293         #[cfg(debug_assertions)]
294         /// Max to_local and to_remote outputs in a remote-generated commitment transaction
295         max_commitment_tx_output_remote: ::std::sync::Mutex<(u64, u64)>,
296
297         #[cfg(test)]
298         // Used in ChannelManager's tests to send a revoked transaction
299         pub last_local_commitment_txn: Vec<Transaction>,
300         #[cfg(not(test))]
301         last_local_commitment_txn: Vec<Transaction>,
302
303         last_sent_closing_fee: Option<(u64, u64)>, // (feerate, fee)
304
305         /// The hash of the block in which the funding transaction reached our CONF_TARGET. We use this
306         /// to detect unconfirmation after a serialize-unserialize roudtrip where we may not see a full
307         /// series of block_connected/block_disconnected calls. Obviously this is not a guarantee as we
308         /// could miss the funding_tx_confirmed_in block as well, but it serves as a useful fallback.
309         funding_tx_confirmed_in: Option<Sha256dHash>,
310         short_channel_id: Option<u64>,
311         /// Used to deduplicate block_connected callbacks, also used to verify consistency during
312         /// ChannelManager deserialization (hence pub(super))
313         pub(super) last_block_connected: Sha256dHash,
314         funding_tx_confirmations: u64,
315
316         their_dust_limit_satoshis: u64,
317         our_dust_limit_satoshis: u64,
318         their_max_htlc_value_in_flight_msat: u64,
319         //get_our_max_htlc_value_in_flight_msat(): u64,
320         /// minimum channel reserve for **self** to maintain - set by them.
321         their_channel_reserve_satoshis: u64,
322         //get_our_channel_reserve_satoshis(): u64,
323         their_htlc_minimum_msat: u64,
324         our_htlc_minimum_msat: u64,
325         their_to_self_delay: u16,
326         //implied by BREAKDOWN_TIMEOUT: our_to_self_delay: u16,
327         their_max_accepted_htlcs: u16,
328         //implied by OUR_MAX_HTLCS: our_max_accepted_htlcs: u16,
329         minimum_depth: u32,
330
331         their_funding_pubkey: Option<PublicKey>,
332         their_revocation_basepoint: Option<PublicKey>,
333         their_payment_basepoint: Option<PublicKey>,
334         their_delayed_payment_basepoint: Option<PublicKey>,
335         their_htlc_basepoint: Option<PublicKey>,
336         their_cur_commitment_point: Option<PublicKey>,
337
338         their_prev_commitment_point: Option<PublicKey>,
339         their_node_id: PublicKey,
340
341         their_shutdown_scriptpubkey: Option<Script>,
342
343         channel_monitor: ChannelMonitor,
344
345         logger: Arc<Logger>,
346 }
347
348 const OUR_MAX_HTLCS: u16 = 5; //TODO
349 /// Confirmation count threshold at which we close a channel. Ideally we'd keep the channel around
350 /// on ice until the funding transaction gets more confirmations, but the LN protocol doesn't
351 /// really allow for this, so instead we're stuck closing it out at that point.
352 const UNCONF_THRESHOLD: u32 = 6;
353 /// The amount of time we require our counterparty wait to claim their money (ie time between when
354 /// we, or our watchtower, must check for them having broadcast a theft transaction).
355 const BREAKDOWN_TIMEOUT: u16 = 6 * 24 * 7; //TODO?
356 /// The amount of time we're willing to wait to claim money back to us
357 const MAX_LOCAL_BREAKDOWN_TIMEOUT: u16 = 6 * 24 * 14;
358 const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
359 const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
360 const SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT: u64 = 79; // prevout: 36, nSequence: 4, script len: 1, witness lengths: (3+1)/4, sig: 73/4, if-selector: 1, redeemScript: (6 ops + 2*33 pubkeys + 1*2 delay)/4
361 const B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT: u64 = 104; // prevout: 40, nSequence: 4, script len: 1, witness lengths: 3/4, sig: 73/4, pubkey: 33/4, output: 31 (TODO: Wrong? Useless?)
362 /// Maximmum `funding_satoshis` value, according to the BOLT #2 specification
363 /// it's 2^24.
364 pub const MAX_FUNDING_SATOSHIS: u64 = (1 << 24);
365
366 /// Used to return a simple Error back to ChannelManager. Will get converted to a
367 /// msgs::ErrorAction::SendErrorMessage or msgs::ErrorAction::IgnoreError as appropriate with our
368 /// channel_id in ChannelManager.
369 pub(super) enum ChannelError {
370         Ignore(&'static str),
371         Close(&'static str),
372 }
373
374 macro_rules! secp_call {
375         ( $res: expr, $err: expr, $chan_id: expr ) => {
376                 match $res {
377                         Ok(key) => key,
378                         Err(_) => return Err(HandleError {err: $err, action: Some(msgs::ErrorAction::SendErrorMessage {msg: msgs::ErrorMessage {channel_id: $chan_id, data: $err.to_string()}})})
379                 }
380         };
381 }
382
383 macro_rules! secp_derived_key {
384         ( $res: expr, $chan_id: expr ) => {
385                 secp_call!($res, "Derived invalid key, peer is maliciously selecting parameters", $chan_id)
386         }
387 }
388 impl Channel {
389         // Convert constants + channel value to limits:
390         fn get_our_max_htlc_value_in_flight_msat(channel_value_satoshis: u64) -> u64 {
391                 channel_value_satoshis * 1000 / 10 //TODO
392         }
393
394         /// Returns a minimum channel reserve value **they** need to maintain
395         ///
396         /// Guaranteed to return a value no larger than channel_value_satoshis
397         fn get_our_channel_reserve_satoshis(channel_value_satoshis: u64) -> u64 {
398                 let (q, _) = channel_value_satoshis.overflowing_div(100);
399                 cmp::min(channel_value_satoshis, cmp::max(q, 1000)) //TODO
400         }
401
402         fn derive_our_dust_limit_satoshis(at_open_background_feerate: u64) -> u64 {
403                 cmp::max(at_open_background_feerate * B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT / 1000, 546) //TODO
404         }
405
406         fn derive_our_htlc_minimum_msat(_at_open_channel_feerate_per_kw: u64) -> u64 {
407                 1000 // TODO
408         }
409
410         fn derive_minimum_depth(_channel_value_satoshis_msat: u64, _value_to_self_msat: u64) -> u32 {
411                 // Note that in order to comply with BOLT 7 announcement_signatures requirements this must
412                 // be at least 6.
413                 const CONF_TARGET: u32 = 12; //TODO: Should be much higher
414                 CONF_TARGET
415         }
416
417         // Constructors:
418         pub fn new_outbound(fee_estimator: &FeeEstimator, keys_provider: &Arc<KeysInterface>, their_node_id: PublicKey, channel_value_satoshis: u64, push_msat: u64, user_id: u64, logger: Arc<Logger>, config: &UserConfig) -> Result<Channel, APIError> {
419                 let chan_keys = keys_provider.get_channel_keys(false);
420
421                 if channel_value_satoshis >= MAX_FUNDING_SATOSHIS {
422                         return Err(APIError::APIMisuseError{err: "funding value > 2^24"});
423                 }
424
425                 if push_msat > channel_value_satoshis * 1000 {
426                         return Err(APIError::APIMisuseError{err: "push value > channel value"});
427                 }
428
429
430                 let background_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
431                 if Channel::get_our_channel_reserve_satoshis(channel_value_satoshis) < Channel::derive_our_dust_limit_satoshis(background_feerate) {
432                         return Err(APIError::FeeRateTooHigh{err: format!("Not enough reserve above dust limit can be found at current fee rate({})", background_feerate), feerate: background_feerate});
433                 }
434
435                 let feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
436
437                 let secp_ctx = Secp256k1::new();
438                 let channel_monitor = ChannelMonitor::new(&chan_keys.revocation_base_key, &chan_keys.delayed_payment_base_key,
439                                                           &chan_keys.htlc_base_key, BREAKDOWN_TIMEOUT,
440                                                           keys_provider.get_destination_script(), logger.clone());
441
442                 Ok(Channel {
443                         user_id: user_id,
444                         config: config.channel_options.clone(),
445
446                         channel_id: rng::rand_u832(),
447                         channel_state: ChannelState::OurInitSent as u32,
448                         channel_outbound: true,
449                         secp_ctx: secp_ctx,
450                         channel_value_satoshis: channel_value_satoshis,
451
452                         local_keys: chan_keys,
453                         shutdown_pubkey: keys_provider.get_shutdown_pubkey(),
454                         cur_local_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
455                         cur_remote_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
456                         value_to_self_msat: channel_value_satoshis * 1000 - push_msat,
457                         received_commitment_while_awaiting_raa: false,
458
459                         pending_inbound_htlcs: Vec::new(),
460                         pending_outbound_htlcs: Vec::new(),
461                         holding_cell_htlc_updates: Vec::new(),
462                         pending_update_fee: None,
463                         holding_cell_update_fee: None,
464                         next_local_htlc_id: 0,
465                         next_remote_htlc_id: 0,
466                         channel_update_count: 1,
467
468                         monitor_pending_revoke_and_ack: false,
469                         monitor_pending_commitment_signed: false,
470                         monitor_pending_order: None,
471                         monitor_pending_forwards: Vec::new(),
472                         monitor_pending_failures: Vec::new(),
473
474                         #[cfg(debug_assertions)]
475                         max_commitment_tx_output_local: ::std::sync::Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
476                         #[cfg(debug_assertions)]
477                         max_commitment_tx_output_remote: ::std::sync::Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
478
479                         last_local_commitment_txn: Vec::new(),
480
481                         last_sent_closing_fee: None,
482
483                         funding_tx_confirmed_in: None,
484                         short_channel_id: None,
485                         last_block_connected: Default::default(),
486                         funding_tx_confirmations: 0,
487
488                         feerate_per_kw: feerate,
489                         their_dust_limit_satoshis: 0,
490                         our_dust_limit_satoshis: Channel::derive_our_dust_limit_satoshis(background_feerate),
491                         their_max_htlc_value_in_flight_msat: 0,
492                         their_channel_reserve_satoshis: 0,
493                         their_htlc_minimum_msat: 0,
494                         our_htlc_minimum_msat: Channel::derive_our_htlc_minimum_msat(feerate),
495                         their_to_self_delay: 0,
496                         their_max_accepted_htlcs: 0,
497                         minimum_depth: 0, // Filled in in accept_channel
498
499                         their_funding_pubkey: None,
500                         their_revocation_basepoint: None,
501                         their_payment_basepoint: None,
502                         their_delayed_payment_basepoint: None,
503                         their_htlc_basepoint: None,
504                         their_cur_commitment_point: None,
505
506                         their_prev_commitment_point: None,
507                         their_node_id: their_node_id,
508
509                         their_shutdown_scriptpubkey: None,
510
511                         channel_monitor: channel_monitor,
512
513                         logger,
514                 })
515         }
516
517         fn check_remote_fee(fee_estimator: &FeeEstimator, feerate_per_kw: u32) -> Result<(), ChannelError> {
518                 if (feerate_per_kw as u64) < fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background) {
519                         return Err(ChannelError::Close("Peer's feerate much too low"));
520                 }
521                 if (feerate_per_kw as u64) > fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority) * 2 {
522                         return Err(ChannelError::Close("Peer's feerate much too high"));
523                 }
524                 Ok(())
525         }
526
527         /// Creates a new channel from a remote sides' request for one.
528         /// Assumes chain_hash has already been checked and corresponds with what we expect!
529         pub fn new_from_req(fee_estimator: &FeeEstimator, keys_provider: &Arc<KeysInterface>, their_node_id: PublicKey, msg: &msgs::OpenChannel, user_id: u64, logger: Arc<Logger>, config: &UserConfig) -> Result<Channel, ChannelError> {
530                 let chan_keys = keys_provider.get_channel_keys(true);
531                 let mut local_config = (*config).channel_options.clone();
532
533                 // Check sanity of message fields:
534                 if msg.funding_satoshis >= MAX_FUNDING_SATOSHIS {
535                         return Err(ChannelError::Close("funding value > 2^24"));
536                 }
537                 if msg.channel_reserve_satoshis > msg.funding_satoshis {
538                         return Err(ChannelError::Close("Bogus channel_reserve_satoshis"));
539                 }
540                 if msg.push_msat > (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
541                         return Err(ChannelError::Close("push_msat larger than funding value"));
542                 }
543                 if msg.dust_limit_satoshis > msg.funding_satoshis {
544                         return Err(ChannelError::Close("Peer never wants payout outputs?"));
545                 }
546                 if msg.dust_limit_satoshis > msg.channel_reserve_satoshis {
547                         return Err(ChannelError::Close("Bogus; channel reserve is less than dust limit"));
548                 }
549                 if msg.htlc_minimum_msat >= (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
550                         return Err(ChannelError::Close("Miminum htlc value is full channel value"));
551                 }
552                 Channel::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
553
554                 if msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
555                         return Err(ChannelError::Close("They wanted our payments to be delayed by a needlessly long period"));
556                 }
557                 if msg.max_accepted_htlcs < 1 {
558                         return Err(ChannelError::Close("0 max_accpted_htlcs makes for a useless channel"));
559                 }
560                 if msg.max_accepted_htlcs > 483 {
561                         return Err(ChannelError::Close("max_accpted_htlcs > 483"));
562                 }
563
564                 // Now check against optional parameters as set by config...
565                 if msg.funding_satoshis < config.channel_limits.min_funding_satoshis {
566                         return Err(ChannelError::Close("funding satoshis is less than the user specified limit"));
567                 }
568                 if msg.htlc_minimum_msat > config.channel_limits.max_htlc_minimum_msat {
569                         return Err(ChannelError::Close("htlc minimum msat is higher than the user specified limit"));
570                 }
571                 if msg.max_htlc_value_in_flight_msat < config.channel_limits.min_max_htlc_value_in_flight_msat {
572                         return Err(ChannelError::Close("max htlc value in flight msat is less than the user specified limit"));
573                 }
574                 if msg.channel_reserve_satoshis > config.channel_limits.max_channel_reserve_satoshis {
575                         return Err(ChannelError::Close("channel reserve satoshis is higher than the user specified limit"));
576                 }
577                 if msg.max_accepted_htlcs < config.channel_limits.min_max_accepted_htlcs {
578                         return Err(ChannelError::Close("max accepted htlcs is less than the user specified limit"));
579                 }
580                 if msg.dust_limit_satoshis < config.channel_limits.min_dust_limit_satoshis {
581                         return Err(ChannelError::Close("dust limit satoshis is less than the user specified limit"));
582                 }
583                 if msg.dust_limit_satoshis > config.channel_limits.max_dust_limit_satoshis {
584                         return Err(ChannelError::Close("dust limit satoshis is greater than the user specified limit"));
585                 }
586
587                 // Convert things into internal flags and prep our state:
588
589                 let their_announce = if (msg.channel_flags & 1) == 1 { true } else { false };
590                 if config.channel_limits.force_announced_channel_preference {
591                         if local_config.announced_channel != their_announce {
592                                 return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours"));
593                         }
594                 }
595                 // we either accept their preference or the preferences match
596                 local_config.announced_channel = their_announce;
597
598                 let background_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
599
600                 let our_dust_limit_satoshis = Channel::derive_our_dust_limit_satoshis(background_feerate);
601                 let our_channel_reserve_satoshis = Channel::get_our_channel_reserve_satoshis(msg.funding_satoshis);
602                 if our_channel_reserve_satoshis < our_dust_limit_satoshis {
603                         return Err(ChannelError::Close("Suitable channel reserve not found. aborting"));
604                 }
605                 if msg.channel_reserve_satoshis < our_dust_limit_satoshis {
606                         return Err(ChannelError::Close("channel_reserve_satoshis too small"));
607                 }
608                 if our_channel_reserve_satoshis < msg.dust_limit_satoshis {
609                         return Err(ChannelError::Close("Dust limit too high for our channel reserve"));
610                 }
611
612                 // check if the funder's amount for the initial commitment tx is sufficient
613                 // for full fee payment
614                 let funders_amount_msat = msg.funding_satoshis * 1000 - msg.push_msat;
615                 if funders_amount_msat < background_feerate * COMMITMENT_TX_BASE_WEIGHT {
616                         return Err(ChannelError::Close("Insufficient funding amount for initial commitment"));
617                 }
618
619                 let to_local_msat = msg.push_msat;
620                 let to_remote_msat = funders_amount_msat - background_feerate * COMMITMENT_TX_BASE_WEIGHT;
621                 if to_local_msat <= msg.channel_reserve_satoshis * 1000 && to_remote_msat <= our_channel_reserve_satoshis * 1000 {
622                         return Err(ChannelError::Close("Insufficient funding amount for initial commitment"));
623                 }
624
625                 let secp_ctx = Secp256k1::new();
626                 let mut channel_monitor = ChannelMonitor::new(&chan_keys.revocation_base_key, &chan_keys.delayed_payment_base_key,
627                                                               &chan_keys.htlc_base_key, BREAKDOWN_TIMEOUT,
628                                                               keys_provider.get_destination_script(), logger.clone());
629                 channel_monitor.set_their_base_keys(&msg.htlc_basepoint, &msg.delayed_payment_basepoint);
630                 channel_monitor.set_their_to_self_delay(msg.to_self_delay);
631
632                 let mut chan = Channel {
633                         user_id: user_id,
634                         config: local_config,
635
636                         channel_id: msg.temporary_channel_id,
637                         channel_state: (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32),
638                         channel_outbound: false,
639                         secp_ctx: secp_ctx,
640
641                         local_keys: chan_keys,
642                         shutdown_pubkey: keys_provider.get_shutdown_pubkey(),
643                         cur_local_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
644                         cur_remote_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
645                         value_to_self_msat: msg.push_msat,
646                         received_commitment_while_awaiting_raa: false,
647
648                         pending_inbound_htlcs: Vec::new(),
649                         pending_outbound_htlcs: Vec::new(),
650                         holding_cell_htlc_updates: Vec::new(),
651                         pending_update_fee: None,
652                         holding_cell_update_fee: None,
653                         next_local_htlc_id: 0,
654                         next_remote_htlc_id: 0,
655                         channel_update_count: 1,
656
657                         monitor_pending_revoke_and_ack: false,
658                         monitor_pending_commitment_signed: false,
659                         monitor_pending_order: None,
660                         monitor_pending_forwards: Vec::new(),
661                         monitor_pending_failures: Vec::new(),
662
663                         #[cfg(debug_assertions)]
664                         max_commitment_tx_output_local: ::std::sync::Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
665                         #[cfg(debug_assertions)]
666                         max_commitment_tx_output_remote: ::std::sync::Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
667
668                         last_local_commitment_txn: Vec::new(),
669
670                         last_sent_closing_fee: None,
671
672                         funding_tx_confirmed_in: None,
673                         short_channel_id: None,
674                         last_block_connected: Default::default(),
675                         funding_tx_confirmations: 0,
676
677                         feerate_per_kw: msg.feerate_per_kw as u64,
678                         channel_value_satoshis: msg.funding_satoshis,
679                         their_dust_limit_satoshis: msg.dust_limit_satoshis,
680                         our_dust_limit_satoshis: our_dust_limit_satoshis,
681                         their_max_htlc_value_in_flight_msat: cmp::min(msg.max_htlc_value_in_flight_msat, msg.funding_satoshis * 1000),
682                         their_channel_reserve_satoshis: msg.channel_reserve_satoshis,
683                         their_htlc_minimum_msat: msg.htlc_minimum_msat,
684                         our_htlc_minimum_msat: Channel::derive_our_htlc_minimum_msat(msg.feerate_per_kw as u64),
685                         their_to_self_delay: msg.to_self_delay,
686                         their_max_accepted_htlcs: msg.max_accepted_htlcs,
687                         minimum_depth: Channel::derive_minimum_depth(msg.funding_satoshis*1000, msg.push_msat),
688
689                         their_funding_pubkey: Some(msg.funding_pubkey),
690                         their_revocation_basepoint: Some(msg.revocation_basepoint),
691                         their_payment_basepoint: Some(msg.payment_basepoint),
692                         their_delayed_payment_basepoint: Some(msg.delayed_payment_basepoint),
693                         their_htlc_basepoint: Some(msg.htlc_basepoint),
694                         their_cur_commitment_point: Some(msg.first_per_commitment_point),
695
696                         their_prev_commitment_point: None,
697                         their_node_id: their_node_id,
698
699                         their_shutdown_scriptpubkey: None,
700
701                         channel_monitor: channel_monitor,
702
703                         logger,
704                 };
705
706                 let obscure_factor = chan.get_commitment_transaction_number_obscure_factor();
707                 chan.channel_monitor.set_commitment_obscure_factor(obscure_factor);
708
709                 Ok(chan)
710         }
711
712         // Utilities to derive keys:
713
714         fn build_local_commitment_secret(&self, idx: u64) -> SecretKey {
715                 let res = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, idx);
716                 SecretKey::from_slice(&self.secp_ctx, &res).unwrap()
717         }
718
719         // Utilities to build transactions:
720
721         fn get_commitment_transaction_number_obscure_factor(&self) -> u64 {
722                 let mut sha = Sha256::new();
723                 let our_payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key);
724
725                 if self.channel_outbound {
726                         sha.input(&our_payment_basepoint.serialize());
727                         sha.input(&self.their_payment_basepoint.unwrap().serialize());
728                 } else {
729                         sha.input(&self.their_payment_basepoint.unwrap().serialize());
730                         sha.input(&our_payment_basepoint.serialize());
731                 }
732                 let mut res = [0; 32];
733                 sha.result(&mut res);
734
735                 ((res[26] as u64) << 5*8) |
736                 ((res[27] as u64) << 4*8) |
737                 ((res[28] as u64) << 3*8) |
738                 ((res[29] as u64) << 2*8) |
739                 ((res[30] as u64) << 1*8) |
740                 ((res[31] as u64) << 0*8)
741         }
742
743         /// Transaction nomenclature is somewhat confusing here as there are many different cases - a
744         /// transaction is referred to as "a's transaction" implying that a will be able to broadcast
745         /// the transaction. Thus, b will generally be sending a signature over such a transaction to
746         /// a, and a can revoke the transaction by providing b the relevant per_commitment_secret. As
747         /// such, a transaction is generally the result of b increasing the amount paid to a (or adding
748         /// an HTLC to a).
749         /// @local is used only to convert relevant internal structures which refer to remote vs local
750         /// to decide value of outputs and direction of HTLCs.
751         /// @generated_by_local is used to determine *which* HTLCs to include - noting that the HTLC
752         /// state may indicate that one peer has informed the other that they'd like to add an HTLC but
753         /// have not yet committed it. Such HTLCs will only be included in transactions which are being
754         /// generated by the peer which proposed adding the HTLCs, and thus we need to understand both
755         /// which peer generated this transaction and "to whom" this transaction flows.
756         #[inline]
757         fn build_commitment_transaction(&self, commitment_number: u64, keys: &TxCreationKeys, local: bool, generated_by_local: bool, feerate_per_kw: u64) -> (Transaction, Vec<HTLCOutputInCommitment>) {
758                 let obscured_commitment_transaction_number = self.get_commitment_transaction_number_obscure_factor() ^ (INITIAL_COMMITMENT_NUMBER - commitment_number);
759
760                 let txins = {
761                         let mut ins: Vec<TxIn> = Vec::new();
762                         ins.push(TxIn {
763                                 previous_output: self.channel_monitor.get_funding_txo().unwrap().into_bitcoin_outpoint(),
764                                 script_sig: Script::new(),
765                                 sequence: ((0x80 as u32) << 8*3) | ((obscured_commitment_transaction_number >> 3*8) as u32),
766                                 witness: Vec::new(),
767                         });
768                         ins
769                 };
770
771                 let mut txouts: Vec<(TxOut, Option<HTLCOutputInCommitment>)> = Vec::with_capacity(self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len() + 2);
772
773                 let dust_limit_satoshis = if local { self.our_dust_limit_satoshis } else { self.their_dust_limit_satoshis };
774                 let mut remote_htlc_total_msat = 0;
775                 let mut local_htlc_total_msat = 0;
776                 let mut value_to_self_msat_offset = 0;
777
778                 macro_rules! add_htlc_output {
779                         ($htlc: expr, $outbound: expr) => {
780                                 if $outbound == local { // "offered HTLC output"
781                                         if $htlc.amount_msat / 1000 >= dust_limit_satoshis + (feerate_per_kw * HTLC_TIMEOUT_TX_WEIGHT / 1000) {
782                                                 let htlc_in_tx = get_htlc_in_commitment!($htlc, true);
783                                                 txouts.push((TxOut {
784                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys).to_v0_p2wsh(),
785                                                         value: $htlc.amount_msat / 1000
786                                                 }, Some(htlc_in_tx)));
787                                         }
788                                 } else {
789                                         if $htlc.amount_msat / 1000 >= dust_limit_satoshis + (feerate_per_kw * HTLC_SUCCESS_TX_WEIGHT / 1000) {
790                                                 let htlc_in_tx = get_htlc_in_commitment!($htlc, false);
791                                                 txouts.push((TxOut { // "received HTLC output"
792                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys).to_v0_p2wsh(),
793                                                         value: $htlc.amount_msat / 1000
794                                                 }, Some(htlc_in_tx)));
795                                         }
796                                 }
797                         }
798                 }
799
800                 for ref htlc in self.pending_inbound_htlcs.iter() {
801                         let include = match htlc.state {
802                                 InboundHTLCState::RemoteAnnounced(_) => !generated_by_local,
803                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) => !generated_by_local,
804                                 InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => true,
805                                 InboundHTLCState::Committed => true,
806                                 InboundHTLCState::LocalRemoved(_) => !generated_by_local,
807                         };
808
809                         if include {
810                                 add_htlc_output!(htlc, false);
811                                 remote_htlc_total_msat += htlc.amount_msat;
812                         } else {
813                                 match &htlc.state {
814                                         &InboundHTLCState::LocalRemoved(ref reason) => {
815                                                 if generated_by_local {
816                                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
817                                                                 value_to_self_msat_offset += htlc.amount_msat as i64;
818                                                         }
819                                                 }
820                                         },
821                                         _ => {},
822                                 }
823                         }
824                 }
825
826                 for ref htlc in self.pending_outbound_htlcs.iter() {
827                         let include = match htlc.state {
828                                 OutboundHTLCState::LocalAnnounced(_) => generated_by_local,
829                                 OutboundHTLCState::Committed => true,
830                                 OutboundHTLCState::RemoteRemoved => generated_by_local,
831                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove => generated_by_local,
832                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke => false,
833                         };
834
835                         if include {
836                                 add_htlc_output!(htlc, true);
837                                 local_htlc_total_msat += htlc.amount_msat;
838                         } else {
839                                 match htlc.state {
840                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove|OutboundHTLCState::AwaitingRemovedRemoteRevoke => {
841                                                 if htlc.fail_reason.is_none() {
842                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
843                                                 }
844                                         },
845                                         OutboundHTLCState::RemoteRemoved => {
846                                                 if !generated_by_local && htlc.fail_reason.is_none() {
847                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
848                                                 }
849                                         },
850                                         _ => {},
851                                 }
852                         }
853                 }
854
855
856                 let value_to_self_msat: i64 = (self.value_to_self_msat - local_htlc_total_msat) as i64 + value_to_self_msat_offset;
857                 let value_to_remote_msat: i64 = (self.channel_value_satoshis * 1000 - self.value_to_self_msat - remote_htlc_total_msat) as i64 - value_to_self_msat_offset;
858
859                 #[cfg(debug_assertions)]
860                 {
861                         // Make sure that the to_self/to_remote is always either past the appropriate
862                         // channel_reserve *or* it is making progress towards it.
863                         // TODO: This should happen after fee calculation, but we don't handle that correctly
864                         // yet!
865                         let mut max_commitment_tx_output = if generated_by_local {
866                                 self.max_commitment_tx_output_local.lock().unwrap()
867                         } else {
868                                 self.max_commitment_tx_output_remote.lock().unwrap()
869                         };
870                         debug_assert!(max_commitment_tx_output.0 <= value_to_self_msat as u64 || value_to_self_msat / 1000 >= self.their_channel_reserve_satoshis as i64);
871                         max_commitment_tx_output.0 = cmp::max(max_commitment_tx_output.0, value_to_self_msat as u64);
872                         debug_assert!(max_commitment_tx_output.1 <= value_to_remote_msat as u64 || value_to_remote_msat / 1000 >= Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis) as i64);
873                         max_commitment_tx_output.1 = cmp::max(max_commitment_tx_output.1, value_to_remote_msat as u64);
874                 }
875
876                 let total_fee: u64 = feerate_per_kw * (COMMITMENT_TX_BASE_WEIGHT + (txouts.len() as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
877                 let (value_to_self, value_to_remote) = if self.channel_outbound {
878                         (value_to_self_msat / 1000 - total_fee as i64, value_to_remote_msat / 1000)
879                 } else {
880                         (value_to_self_msat / 1000, value_to_remote_msat / 1000 - total_fee as i64)
881                 };
882
883                 let value_to_a = if local { value_to_self } else { value_to_remote };
884                 let value_to_b = if local { value_to_remote } else { value_to_self };
885
886                 if value_to_a >= (dust_limit_satoshis as i64) {
887                         txouts.push((TxOut {
888                                 script_pubkey: chan_utils::get_revokeable_redeemscript(&keys.revocation_key,
889                                                                                        if local { self.their_to_self_delay } else { BREAKDOWN_TIMEOUT },
890                                                                                        &keys.a_delayed_payment_key).to_v0_p2wsh(),
891                                 value: value_to_a as u64
892                         }, None));
893                 }
894
895                 if value_to_b >= (dust_limit_satoshis as i64) {
896                         txouts.push((TxOut {
897                                 script_pubkey: Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0)
898                                                              .push_slice(&Hash160::from_data(&keys.b_payment_key.serialize())[..])
899                                                              .into_script(),
900                                 value: value_to_b as u64
901                         }, None));
902                 }
903
904                 transaction_utils::sort_outputs(&mut txouts);
905
906                 let mut outputs: Vec<TxOut> = Vec::with_capacity(txouts.len());
907                 let mut htlcs_used: Vec<HTLCOutputInCommitment> = Vec::with_capacity(txouts.len());
908                 for (idx, out) in txouts.drain(..).enumerate() {
909                         outputs.push(out.0);
910                         if let Some(out_htlc) = out.1 {
911                                 htlcs_used.push(out_htlc);
912                                 htlcs_used.last_mut().unwrap().transaction_output_index = idx as u32;
913                         }
914                 }
915
916                 (Transaction {
917                         version: 2,
918                         lock_time: ((0x20 as u32) << 8*3) | ((obscured_commitment_transaction_number & 0xffffffu64) as u32),
919                         input: txins,
920                         output: outputs,
921                 }, htlcs_used)
922         }
923
924         #[inline]
925         fn get_closing_scriptpubkey(&self) -> Script {
926                 let our_channel_close_key_hash = Hash160::from_data(&self.shutdown_pubkey.serialize());
927                 Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&our_channel_close_key_hash[..]).into_script()
928         }
929
930         #[inline]
931         fn get_closing_transaction_weight(a_scriptpubkey: &Script, b_scriptpubkey: &Script) -> u64 {
932                 (4 + 1 + 36 + 4 + 1 + 1 + 2*(8+1) + 4 + a_scriptpubkey.len() as u64 + b_scriptpubkey.len() as u64)*4 + 2 + 1 + 1 + 2*(1 + 72)
933         }
934
935         #[inline]
936         fn build_closing_transaction(&self, proposed_total_fee_satoshis: u64, skip_remote_output: bool) -> (Transaction, u64) {
937                 let txins = {
938                         let mut ins: Vec<TxIn> = Vec::new();
939                         ins.push(TxIn {
940                                 previous_output: self.channel_monitor.get_funding_txo().unwrap().into_bitcoin_outpoint(),
941                                 script_sig: Script::new(),
942                                 sequence: 0xffffffff,
943                                 witness: Vec::new(),
944                         });
945                         ins
946                 };
947
948                 assert!(self.pending_inbound_htlcs.is_empty());
949                 assert!(self.pending_outbound_htlcs.is_empty());
950                 let mut txouts: Vec<(TxOut, ())> = Vec::new();
951
952                 let mut total_fee_satoshis = proposed_total_fee_satoshis;
953                 let value_to_self: i64 = (self.value_to_self_msat as i64) / 1000 - if self.channel_outbound { total_fee_satoshis as i64 } else { 0 };
954                 let value_to_remote: i64 = ((self.channel_value_satoshis * 1000 - self.value_to_self_msat) as i64 / 1000) - if self.channel_outbound { 0 } else { total_fee_satoshis as i64 };
955
956                 if value_to_self < 0 {
957                         assert!(self.channel_outbound);
958                         total_fee_satoshis += (-value_to_self) as u64;
959                 } else if value_to_remote < 0 {
960                         assert!(!self.channel_outbound);
961                         total_fee_satoshis += (-value_to_remote) as u64;
962                 }
963
964                 if !skip_remote_output && value_to_remote as u64 > self.our_dust_limit_satoshis {
965                         txouts.push((TxOut {
966                                 script_pubkey: self.their_shutdown_scriptpubkey.clone().unwrap(),
967                                 value: value_to_remote as u64
968                         }, ()));
969                 }
970
971                 if value_to_self as u64 > self.our_dust_limit_satoshis {
972                         txouts.push((TxOut {
973                                 script_pubkey: self.get_closing_scriptpubkey(),
974                                 value: value_to_self as u64
975                         }, ()));
976                 }
977
978                 transaction_utils::sort_outputs(&mut txouts);
979
980                 let mut outputs: Vec<TxOut> = Vec::new();
981                 for out in txouts.drain(..) {
982                         outputs.push(out.0);
983                 }
984
985                 (Transaction {
986                         version: 2,
987                         lock_time: 0,
988                         input: txins,
989                         output: outputs,
990                 }, total_fee_satoshis)
991         }
992
993         #[inline]
994         /// Creates a set of keys for build_commitment_transaction to generate a transaction which our
995         /// counterparty will sign (ie DO NOT send signatures over a transaction created by this to
996         /// our counterparty!)
997         /// The result is a transaction which we can revoke ownership of (ie a "local" transaction)
998         /// TODO Some magic rust shit to compile-time check this?
999         fn build_local_transaction_keys(&self, commitment_number: u64) -> Result<TxCreationKeys, HandleError> {
1000                 let per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(commitment_number));
1001                 let delayed_payment_base = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key);
1002                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key);
1003
1004                 Ok(secp_derived_key!(TxCreationKeys::new(&self.secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &self.their_revocation_basepoint.unwrap(), &self.their_payment_basepoint.unwrap(), &self.their_htlc_basepoint.unwrap()), self.channel_id()))
1005         }
1006
1007         #[inline]
1008         /// Creates a set of keys for build_commitment_transaction to generate a transaction which we
1009         /// will sign and send to our counterparty.
1010         fn build_remote_transaction_keys(&self) -> Result<TxCreationKeys, HandleError> {
1011                 //TODO: Ensure that the payment_key derived here ends up in the library users' wallet as we
1012                 //may see payments to it!
1013                 let payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key);
1014                 let revocation_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key);
1015                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key);
1016
1017                 Ok(secp_derived_key!(TxCreationKeys::new(&self.secp_ctx, &self.their_cur_commitment_point.unwrap(), &self.their_delayed_payment_basepoint.unwrap(), &self.their_htlc_basepoint.unwrap(), &revocation_basepoint, &payment_basepoint, &htlc_basepoint), self.channel_id()))
1018         }
1019
1020         /// Gets the redeemscript for the funding transaction output (ie the funding transaction output
1021         /// pays to get_funding_redeemscript().to_v0_p2wsh()).
1022         /// Panics if called before accept_channel/new_from_req
1023         pub fn get_funding_redeemscript(&self) -> Script {
1024                 let builder = Builder::new().push_opcode(opcodes::All::OP_PUSHNUM_2);
1025                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).serialize();
1026                 let their_funding_key = self.their_funding_pubkey.expect("get_funding_redeemscript only allowed after accept_channel").serialize();
1027                 if our_funding_key[..] < their_funding_key[..] {
1028                         builder.push_slice(&our_funding_key)
1029                                 .push_slice(&their_funding_key)
1030                 } else {
1031                         builder.push_slice(&their_funding_key)
1032                                 .push_slice(&our_funding_key)
1033                 }.push_opcode(opcodes::All::OP_PUSHNUM_2).push_opcode(opcodes::All::OP_CHECKMULTISIG).into_script()
1034         }
1035
1036         fn sign_commitment_transaction(&self, tx: &mut Transaction, their_sig: &Signature) -> Signature {
1037                 if tx.input.len() != 1 {
1038                         panic!("Tried to sign commitment transaction that had input count != 1!");
1039                 }
1040                 if tx.input[0].witness.len() != 0 {
1041                         panic!("Tried to re-sign commitment transaction");
1042                 }
1043
1044                 let funding_redeemscript = self.get_funding_redeemscript();
1045
1046                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&tx).sighash_all(&tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
1047                 let our_sig = self.secp_ctx.sign(&sighash, &self.local_keys.funding_key);
1048
1049                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
1050
1051                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).serialize();
1052                 let their_funding_key = self.their_funding_pubkey.unwrap().serialize();
1053                 if our_funding_key[..] < their_funding_key[..] {
1054                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
1055                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
1056                 } else {
1057                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
1058                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
1059                 }
1060                 tx.input[0].witness[1].push(SigHashType::All as u8);
1061                 tx.input[0].witness[2].push(SigHashType::All as u8);
1062
1063                 tx.input[0].witness.push(funding_redeemscript.into_bytes());
1064
1065                 our_sig
1066         }
1067
1068         /// Builds the htlc-success or htlc-timeout transaction which spends a given HTLC output
1069         /// @local is used only to convert relevant internal structures which refer to remote vs local
1070         /// to decide value of outputs and direction of HTLCs.
1071         fn build_htlc_transaction(&self, prev_hash: &Sha256dHash, htlc: &HTLCOutputInCommitment, local: bool, keys: &TxCreationKeys, feerate_per_kw: u64) -> Transaction {
1072                 chan_utils::build_htlc_transaction(prev_hash, feerate_per_kw, if local { self.their_to_self_delay } else { BREAKDOWN_TIMEOUT }, htlc, &keys.a_delayed_payment_key, &keys.revocation_key)
1073         }
1074
1075         fn create_htlc_tx_signature(&self, tx: &Transaction, htlc: &HTLCOutputInCommitment, keys: &TxCreationKeys) -> Result<(Script, Signature, bool), HandleError> {
1076                 if tx.input.len() != 1 {
1077                         panic!("Tried to sign HTLC transaction that had input count != 1!");
1078                 }
1079
1080                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys);
1081
1082                 let our_htlc_key = secp_derived_key!(chan_utils::derive_private_key(&self.secp_ctx, &keys.per_commitment_point, &self.local_keys.htlc_base_key), self.channel_id());
1083                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&tx).sighash_all(&tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
1084                 let is_local_tx = PublicKey::from_secret_key(&self.secp_ctx, &our_htlc_key) == keys.a_htlc_key;
1085                 Ok((htlc_redeemscript, self.secp_ctx.sign(&sighash, &our_htlc_key), is_local_tx))
1086         }
1087
1088         /// Signs a transaction created by build_htlc_transaction. If the transaction is an
1089         /// HTLC-Success transaction (ie htlc.offered is false), preimate must be set!
1090         fn sign_htlc_transaction(&self, tx: &mut Transaction, their_sig: &Signature, preimage: &Option<[u8; 32]>, htlc: &HTLCOutputInCommitment, keys: &TxCreationKeys) -> Result<Signature, HandleError> {
1091                 if tx.input.len() != 1 {
1092                         panic!("Tried to sign HTLC transaction that had input count != 1!");
1093                 }
1094                 if tx.input[0].witness.len() != 0 {
1095                         panic!("Tried to re-sign HTLC transaction");
1096                 }
1097
1098                 let (htlc_redeemscript, our_sig, local_tx) = self.create_htlc_tx_signature(tx, htlc, keys)?;
1099
1100                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
1101
1102                 if local_tx { // b, then a
1103                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
1104                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
1105                 } else {
1106                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
1107                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
1108                 }
1109                 tx.input[0].witness[1].push(SigHashType::All as u8);
1110                 tx.input[0].witness[2].push(SigHashType::All as u8);
1111
1112                 if htlc.offered {
1113                         tx.input[0].witness.push(Vec::new());
1114                 } else {
1115                         tx.input[0].witness.push(preimage.unwrap().to_vec());
1116                 }
1117
1118                 tx.input[0].witness.push(htlc_redeemscript.into_bytes());
1119
1120                 Ok(our_sig)
1121         }
1122
1123         /// Per HTLC, only one get_update_fail_htlc or get_update_fulfill_htlc call may be made.
1124         /// In such cases we debug_assert!(false) and return an IgnoreError. Thus, will always return
1125         /// Ok(_) if debug assertions are turned on and preconditions are met.
1126         fn get_update_fulfill_htlc(&mut self, htlc_id_arg: u64, payment_preimage_arg: [u8; 32]) -> Result<(Option<msgs::UpdateFulfillHTLC>, Option<ChannelMonitor>), HandleError> {
1127                 // Either ChannelFunded got set (which means it wont bet unset) or there is no way any
1128                 // caller thought we could have something claimed (cause we wouldn't have accepted in an
1129                 // incoming HTLC anyway). If we got to ShutdownComplete, callers aren't allowed to call us,
1130                 // either.
1131                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1132                         panic!("Was asked to fulfill an HTLC when channel was not in an operational state");
1133                 }
1134                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1135
1136                 let mut sha = Sha256::new();
1137                 sha.input(&payment_preimage_arg);
1138                 let mut payment_hash_calc = [0; 32];
1139                 sha.result(&mut payment_hash_calc);
1140
1141                 let mut pending_idx = std::usize::MAX;
1142                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1143                         if htlc.htlc_id == htlc_id_arg {
1144                                 assert_eq!(htlc.payment_hash, payment_hash_calc);
1145                                 if let InboundHTLCState::Committed = htlc.state {
1146                                 } else {
1147                                         debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1148                                         // Don't return in release mode here so that we can update channel_monitor
1149                                 }
1150                                 pending_idx = idx;
1151                                 break;
1152                         }
1153                 }
1154                 if pending_idx == std::usize::MAX {
1155                         debug_assert!(false, "Unable to find a pending HTLC which matched the given HTLC ID");
1156                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given HTLC ID", action: Some(msgs::ErrorAction::IgnoreError)});
1157                 }
1158
1159                 // Now update local state:
1160                 //
1161                 // We have to put the payment_preimage in the channel_monitor right away here to ensure we
1162                 // can claim it even if the channel hits the chain before we see their next commitment.
1163                 self.channel_monitor.provide_payment_preimage(&payment_hash_calc, &payment_preimage_arg);
1164
1165                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1166                         for pending_update in self.holding_cell_htlc_updates.iter() {
1167                                 match pending_update {
1168                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1169                                                 if htlc_id_arg == htlc_id {
1170                                                         debug_assert!(false, "Tried to fulfill an HTLC we already had a pending fulfill for");
1171                                                         return Ok((None, None));
1172                                                 }
1173                                         },
1174                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1175                                                 if htlc_id_arg == htlc_id {
1176                                                         debug_assert!(false, "Tried to fulfill an HTLC we already had a holding-cell failure on");
1177                                                         // Return the new channel monitor in a last-ditch effort to hit the
1178                                                         // chain and claim the funds
1179                                                         return Ok((None, Some(self.channel_monitor.clone())));
1180                                                 }
1181                                         },
1182                                         _ => {}
1183                                 }
1184                         }
1185                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::ClaimHTLC {
1186                                 payment_preimage: payment_preimage_arg, htlc_id: htlc_id_arg,
1187                         });
1188                         return Ok((None, Some(self.channel_monitor.clone())));
1189                 }
1190
1191                 {
1192                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1193                         if let InboundHTLCState::Committed = htlc.state {
1194                         } else {
1195                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1196                                 return Ok((None, Some(self.channel_monitor.clone())));
1197                         }
1198                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::Fulfill(payment_preimage_arg.clone()));
1199                 }
1200
1201                 Ok((Some(msgs::UpdateFulfillHTLC {
1202                         channel_id: self.channel_id(),
1203                         htlc_id: htlc_id_arg,
1204                         payment_preimage: payment_preimage_arg,
1205                 }), Some(self.channel_monitor.clone())))
1206         }
1207
1208         pub fn get_update_fulfill_htlc_and_commit(&mut self, htlc_id: u64, payment_preimage: [u8; 32]) -> Result<(Option<(msgs::UpdateFulfillHTLC, msgs::CommitmentSigned)>, Option<ChannelMonitor>), HandleError> {
1209                 match self.get_update_fulfill_htlc(htlc_id, payment_preimage)? {
1210                         (Some(update_fulfill_htlc), _) => {
1211                                 let (commitment, monitor_update) = self.send_commitment_no_status_check()?;
1212                                 Ok((Some((update_fulfill_htlc, commitment)), Some(monitor_update)))
1213                         },
1214                         (None, Some(channel_monitor)) => Ok((None, Some(channel_monitor))),
1215                         (None, None) => Ok((None, None))
1216                 }
1217         }
1218
1219         /// Per HTLC, only one get_update_fail_htlc or get_update_fulfill_htlc call may be made.
1220         /// In such cases we debug_assert!(false) and return an IgnoreError. Thus, will always return
1221         /// Ok(_) if debug assertions are turned on and preconditions are met.
1222         pub fn get_update_fail_htlc(&mut self, htlc_id_arg: u64, err_packet: msgs::OnionErrorPacket) -> Result<Option<msgs::UpdateFailHTLC>, HandleError> {
1223                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1224                         panic!("Was asked to fail an HTLC when channel was not in an operational state");
1225                 }
1226                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1227
1228                 let mut pending_idx = std::usize::MAX;
1229                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1230                         if htlc.htlc_id == htlc_id_arg {
1231                                 if let InboundHTLCState::Committed = htlc.state {
1232                                 } else {
1233                                         debug_assert!(false, "Have an inbound HTLC we tried to fail before it was fully committed to");
1234                                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given HTLC ID", action: Some(msgs::ErrorAction::IgnoreError)});
1235                                 }
1236                                 pending_idx = idx;
1237                         }
1238                 }
1239                 if pending_idx == std::usize::MAX {
1240                         debug_assert!(false, "Unable to find a pending HTLC which matched the given HTLC ID");
1241                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given HTLC ID", action: Some(msgs::ErrorAction::IgnoreError)});
1242                 }
1243
1244                 // Now update local state:
1245                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1246                         for pending_update in self.holding_cell_htlc_updates.iter() {
1247                                 match pending_update {
1248                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1249                                                 if htlc_id_arg == htlc_id {
1250                                                         debug_assert!(false, "Unable to find a pending HTLC which matched the given HTLC ID");
1251                                                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given HTLC ID", action: Some(msgs::ErrorAction::IgnoreError)});
1252                                                 }
1253                                         },
1254                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1255                                                 if htlc_id_arg == htlc_id {
1256                                                         debug_assert!(false, "Tried to fail an HTLC that we already had a pending failure for");
1257                                                         return Ok(None);
1258                                                 }
1259                                         },
1260                                         _ => {}
1261                                 }
1262                         }
1263                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::FailHTLC {
1264                                 htlc_id: htlc_id_arg,
1265                                 err_packet,
1266                         });
1267                         return Ok(None);
1268                 }
1269
1270                 {
1271                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1272                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(err_packet.clone()));
1273                 }
1274
1275                 Ok(Some(msgs::UpdateFailHTLC {
1276                         channel_id: self.channel_id(),
1277                         htlc_id: htlc_id_arg,
1278                         reason: err_packet
1279                 }))
1280         }
1281
1282         pub fn get_update_fail_htlc_and_commit(&mut self, htlc_id: u64, err_packet: msgs::OnionErrorPacket) -> Result<Option<(msgs::UpdateFailHTLC, msgs::CommitmentSigned, ChannelMonitor)>, HandleError> {
1283                 match self.get_update_fail_htlc(htlc_id, err_packet)? {
1284                         Some(update_fail_htlc) => {
1285                                 let (commitment, monitor_update) = self.send_commitment_no_status_check()?;
1286                                 Ok(Some((update_fail_htlc, commitment, monitor_update)))
1287                         },
1288                         None => Ok(None)
1289                 }
1290         }
1291
1292         // Message handlers:
1293
1294         pub fn accept_channel(&mut self, msg: &msgs::AcceptChannel, config: &UserConfig) -> Result<(), ChannelError> {
1295                 // Check sanity of message fields:
1296                 if !self.channel_outbound {
1297                         return Err(ChannelError::Close("Got an accept_channel message from an inbound peer"));
1298                 }
1299                 if self.channel_state != ChannelState::OurInitSent as u32 {
1300                         return Err(ChannelError::Close("Got an accept_channel message at a strange time"));
1301                 }
1302                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
1303                         return Err(ChannelError::Close("Peer never wants payout outputs?"));
1304                 }
1305                 if msg.channel_reserve_satoshis > self.channel_value_satoshis {
1306                         return Err(ChannelError::Close("Bogus channel_reserve_satoshis"));
1307                 }
1308                 if msg.dust_limit_satoshis > msg.channel_reserve_satoshis {
1309                         return Err(ChannelError::Close("Bogus channel_reserve and dust_limit"));
1310                 }
1311                 if msg.channel_reserve_satoshis < self.our_dust_limit_satoshis {
1312                         return Err(ChannelError::Close("Peer never wants payout outputs?"));
1313                 }
1314                 if msg.dust_limit_satoshis > Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis) {
1315                         return Err(ChannelError::Close("Dust limit is bigger than our channel reverse"));
1316                 }
1317                 if msg.htlc_minimum_msat >= (self.channel_value_satoshis - msg.channel_reserve_satoshis) * 1000 {
1318                         return Err(ChannelError::Close("Minimum htlc value is full channel value"));
1319                 }
1320                 if msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
1321                         return Err(ChannelError::Close("They wanted our payments to be delayed by a needlessly long period"));
1322                 }
1323                 if msg.max_accepted_htlcs < 1 {
1324                         return Err(ChannelError::Close("0 max_accpted_htlcs makes for a useless channel"));
1325                 }
1326                 if msg.max_accepted_htlcs > 483 {
1327                         return Err(ChannelError::Close("max_accpted_htlcs > 483"));
1328                 }
1329
1330                 // Now check against optional parameters as set by config...
1331                 if msg.htlc_minimum_msat > config.channel_limits.max_htlc_minimum_msat {
1332                         return Err(ChannelError::Close("htlc minimum msat is higher than the user specified limit"));
1333                 }
1334                 if msg.max_htlc_value_in_flight_msat < config.channel_limits.min_max_htlc_value_in_flight_msat {
1335                         return Err(ChannelError::Close("max htlc value in flight msat is less than the user specified limit"));
1336                 }
1337                 if msg.channel_reserve_satoshis > config.channel_limits.max_channel_reserve_satoshis {
1338                         return Err(ChannelError::Close("channel reserve satoshis is higher than the user specified limit"));
1339                 }
1340                 if msg.max_accepted_htlcs < config.channel_limits.min_max_accepted_htlcs {
1341                         return Err(ChannelError::Close("max accepted htlcs is less than the user specified limit"));
1342                 }
1343                 if msg.dust_limit_satoshis < config.channel_limits.min_dust_limit_satoshis {
1344                         return Err(ChannelError::Close("dust limit satoshis is less than the user specified limit"));
1345                 }
1346                 if msg.dust_limit_satoshis > config.channel_limits.max_dust_limit_satoshis {
1347                         return Err(ChannelError::Close("dust limit satoshis is greater than the user specified limit"));
1348                 }
1349                 if msg.minimum_depth > config.channel_limits.max_minimum_depth {
1350                         return Err(ChannelError::Close("We consider the minimum depth to be unreasonably large"));
1351                 }
1352
1353                 self.channel_monitor.set_their_base_keys(&msg.htlc_basepoint, &msg.delayed_payment_basepoint);
1354
1355                 self.their_dust_limit_satoshis = msg.dust_limit_satoshis;
1356                 self.their_max_htlc_value_in_flight_msat = cmp::min(msg.max_htlc_value_in_flight_msat, self.channel_value_satoshis * 1000);
1357                 self.their_channel_reserve_satoshis = msg.channel_reserve_satoshis;
1358                 self.their_htlc_minimum_msat = msg.htlc_minimum_msat;
1359                 self.their_to_self_delay = msg.to_self_delay;
1360                 self.their_max_accepted_htlcs = msg.max_accepted_htlcs;
1361                 self.minimum_depth = msg.minimum_depth;
1362                 self.their_funding_pubkey = Some(msg.funding_pubkey);
1363                 self.their_revocation_basepoint = Some(msg.revocation_basepoint);
1364                 self.their_payment_basepoint = Some(msg.payment_basepoint);
1365                 self.their_delayed_payment_basepoint = Some(msg.delayed_payment_basepoint);
1366                 self.their_htlc_basepoint = Some(msg.htlc_basepoint);
1367                 self.their_cur_commitment_point = Some(msg.first_per_commitment_point);
1368
1369                 let obscure_factor = self.get_commitment_transaction_number_obscure_factor();
1370                 self.channel_monitor.set_commitment_obscure_factor(obscure_factor);
1371                 self.channel_monitor.set_their_to_self_delay(msg.to_self_delay);
1372
1373                 self.channel_state = ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32;
1374
1375                 Ok(())
1376         }
1377
1378         fn funding_created_signature(&mut self, sig: &Signature) -> Result<(Transaction, Signature), HandleError> {
1379                 let funding_script = self.get_funding_redeemscript();
1380
1381                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1382                 let local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false, self.feerate_per_kw).0;
1383                 let local_sighash = Message::from_slice(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1384
1385                 // They sign the "local" commitment transaction, allowing us to broadcast the tx if we wish.
1386                 secp_call!(self.secp_ctx.verify(&local_sighash, &sig, &self.their_funding_pubkey.unwrap()), "Invalid funding_created signature from peer", self.channel_id());
1387
1388                 let remote_keys = self.build_remote_transaction_keys()?;
1389                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false, self.feerate_per_kw).0;
1390                 let remote_sighash = Message::from_slice(&bip143::SighashComponents::new(&remote_initial_commitment_tx).sighash_all(&remote_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1391
1392                 // We sign the "remote" commitment transaction, allowing them to broadcast the tx if they wish.
1393                 Ok((remote_initial_commitment_tx, self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key)))
1394         }
1395
1396         pub fn funding_created(&mut self, msg: &msgs::FundingCreated) -> Result<(msgs::FundingSigned, ChannelMonitor), HandleError> {
1397                 if self.channel_outbound {
1398                         return Err(HandleError{err: "Received funding_created for an outbound channel?", action: Some(msgs::ErrorAction::SendErrorMessage {msg: msgs::ErrorMessage {channel_id: self.channel_id, data: "Received funding_created for an outbound channel?".to_string()}})});
1399                 }
1400                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
1401                         // BOLT 2 says that if we disconnect before we send funding_signed we SHOULD NOT
1402                         // remember the channel, so its safe to just send an error_message here and drop the
1403                         // channel.
1404                         return Err(HandleError{err: "Received funding_created after we got the channel!", action: Some(msgs::ErrorAction::SendErrorMessage {msg: msgs::ErrorMessage {channel_id: self.channel_id, data: "Received funding_created after we got the channel!".to_string()}})});
1405                 }
1406                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) ||
1407                                 self.cur_remote_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
1408                                 self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1409                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1410                 }
1411
1412                 let funding_txo = OutPoint::new(msg.funding_txid, msg.funding_output_index);
1413                 let funding_txo_script = self.get_funding_redeemscript().to_v0_p2wsh();
1414                 self.channel_monitor.set_funding_info((funding_txo, funding_txo_script));
1415
1416                 let (remote_initial_commitment_tx, our_signature) = match self.funding_created_signature(&msg.signature) {
1417                         Ok(res) => res,
1418                         Err(e) => {
1419                                 self.channel_monitor.unset_funding_info();
1420                                 return Err(e);
1421                         }
1422                 };
1423
1424                 // Now that we're past error-generating stuff, update our local state:
1425
1426                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&remote_initial_commitment_tx, Vec::new(), self.cur_remote_commitment_transaction_number);
1427                 self.channel_state = ChannelState::FundingSent as u32;
1428                 self.channel_id = funding_txo.to_channel_id();
1429                 self.cur_remote_commitment_transaction_number -= 1;
1430                 self.cur_local_commitment_transaction_number -= 1;
1431
1432                 Ok((msgs::FundingSigned {
1433                         channel_id: self.channel_id,
1434                         signature: our_signature
1435                 }, self.channel_monitor.clone()))
1436         }
1437
1438         /// Handles a funding_signed message from the remote end.
1439         /// If this call is successful, broadcast the funding transaction (and not before!)
1440         pub fn funding_signed(&mut self, msg: &msgs::FundingSigned) -> Result<ChannelMonitor, HandleError> {
1441                 if !self.channel_outbound {
1442                         return Err(HandleError{err: "Received funding_signed for an inbound channel?", action: None});
1443                 }
1444                 if self.channel_state != ChannelState::FundingCreated as u32 {
1445                         return Err(HandleError{err: "Received funding_signed in strange state!", action: None});
1446                 }
1447                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) ||
1448                                 self.cur_remote_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER - 1 ||
1449                                 self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1450                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1451                 }
1452
1453                 let funding_script = self.get_funding_redeemscript();
1454
1455                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1456                 let mut local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false, self.feerate_per_kw).0;
1457                 let local_sighash = Message::from_slice(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1458
1459                 // They sign the "local" commitment transaction, allowing us to broadcast the tx if we wish.
1460                 secp_call!(self.secp_ctx.verify(&local_sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid funding_signed signature from peer", self.channel_id());
1461
1462                 self.sign_commitment_transaction(&mut local_initial_commitment_tx, &msg.signature);
1463                 self.channel_monitor.provide_latest_local_commitment_tx_info(local_initial_commitment_tx.clone(), local_keys, self.feerate_per_kw, Vec::new());
1464                 self.last_local_commitment_txn = vec![local_initial_commitment_tx];
1465                 self.channel_state = ChannelState::FundingSent as u32;
1466                 self.cur_local_commitment_transaction_number -= 1;
1467
1468                 Ok(self.channel_monitor.clone())
1469         }
1470
1471         pub fn funding_locked(&mut self, msg: &msgs::FundingLocked) -> Result<(), ChannelError> {
1472                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1473                         return Err(ChannelError::Close("Peer sent funding_locked when we needed a channel_reestablish"));
1474                 }
1475
1476                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
1477
1478                 if non_shutdown_state == ChannelState::FundingSent as u32 {
1479                         self.channel_state |= ChannelState::TheirFundingLocked as u32;
1480                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
1481                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
1482                         self.channel_update_count += 1;
1483                 } else if self.channel_state & (ChannelState::ChannelFunded as u32) != 0 &&
1484                                 // Note that funding_signed/funding_created will have decremented both by 1!
1485                                 self.cur_local_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1 &&
1486                                 self.cur_remote_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1 {
1487                         if self.their_cur_commitment_point != Some(msg.next_per_commitment_point) {
1488                                 return Err(ChannelError::Close("Peer sent a reconnect funding_locked with a different point"));
1489                         }
1490                         // They probably disconnected/reconnected and re-sent the funding_locked, which is required
1491                         return Ok(());
1492                 } else {
1493                         return Err(ChannelError::Close("Peer sent a funding_locked at a strange time"));
1494                 }
1495
1496                 self.their_prev_commitment_point = self.their_cur_commitment_point;
1497                 self.their_cur_commitment_point = Some(msg.next_per_commitment_point);
1498                 Ok(())
1499         }
1500
1501         /// Returns (inbound_htlc_count, htlc_inbound_value_msat)
1502         fn get_inbound_pending_htlc_stats(&self) -> (u32, u64) {
1503                 let mut htlc_inbound_value_msat = 0;
1504                 for ref htlc in self.pending_inbound_htlcs.iter() {
1505                         htlc_inbound_value_msat += htlc.amount_msat;
1506                 }
1507                 (self.pending_inbound_htlcs.len() as u32, htlc_inbound_value_msat)
1508         }
1509
1510         /// Returns (outbound_htlc_count, htlc_outbound_value_msat)
1511         fn get_outbound_pending_htlc_stats(&self) -> (u32, u64) {
1512                 let mut htlc_outbound_value_msat = 0;
1513                 for ref htlc in self.pending_outbound_htlcs.iter() {
1514                         htlc_outbound_value_msat += htlc.amount_msat;
1515                 }
1516
1517                 (self.pending_outbound_htlcs.len() as u32, htlc_outbound_value_msat)
1518         }
1519
1520         pub fn update_add_htlc(&mut self, msg: &msgs::UpdateAddHTLC, pending_forward_state: PendingHTLCStatus) -> Result<(), HandleError> {
1521                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::RemoteShutdownSent as u32)) != (ChannelState::ChannelFunded as u32) {
1522                         return Err(HandleError{err: "Got add HTLC message when channel was not in an operational state", action: None});
1523                 }
1524                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1525                         return Err(HandleError{err: "Peer sent update_add_htlc when we needed a channel_reestablish", action: Some(msgs::ErrorAction::SendErrorMessage{msg: msgs::ErrorMessage{data: "Peer sent update_add_htlc when we needed a channel_reestablish".to_string(), channel_id: msg.channel_id}})});
1526                 }
1527                 if msg.amount_msat > self.channel_value_satoshis * 1000 {
1528                         return Err(HandleError{err: "Remote side tried to send more than the total value of the channel", action: None});
1529                 }
1530                 if msg.amount_msat < self.our_htlc_minimum_msat {
1531                         return Err(HandleError{err: "Remote side tried to send less than our minimum HTLC value", action: None});
1532                 }
1533
1534                 let (inbound_htlc_count, htlc_inbound_value_msat) = self.get_inbound_pending_htlc_stats();
1535                 if inbound_htlc_count + 1 > OUR_MAX_HTLCS as u32 {
1536                         return Err(HandleError{err: "Remote tried to push more than our max accepted HTLCs", action: None});
1537                 }
1538                 //TODO: Spec is unclear if this is per-direction or in total (I assume per direction):
1539                 // Check our_max_htlc_value_in_flight_msat
1540                 if htlc_inbound_value_msat + msg.amount_msat > Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis) {
1541                         return Err(HandleError{err: "Remote HTLC add would put them over their max HTLC value in flight", action: None});
1542                 }
1543                 // Check our_channel_reserve_satoshis (we're getting paid, so they have to at least meet
1544                 // the reserve_satoshis we told them to always have as direct payment so that they lose
1545                 // something if we punish them for broadcasting an old state).
1546                 if htlc_inbound_value_msat + msg.amount_msat + self.value_to_self_msat > (self.channel_value_satoshis - Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis)) * 1000 {
1547                         return Err(HandleError{err: "Remote HTLC add would put them over their reserve value", action: None});
1548                 }
1549                 if self.next_remote_htlc_id != msg.htlc_id {
1550                         return Err(HandleError{err: "Remote skipped HTLC ID", action: None});
1551                 }
1552                 if msg.cltv_expiry >= 500000000 {
1553                         return Err(HandleError{err: "Remote provided CLTV expiry in seconds instead of block height", action: None});
1554                 }
1555
1556                 //TODO: Check msg.cltv_expiry further? Do this in channel manager?
1557
1558                 if self.channel_state & ChannelState::LocalShutdownSent as u32 != 0 {
1559                         if let PendingHTLCStatus::Forward(_) = pending_forward_state {
1560                                 panic!("ChannelManager shouldn't be trying to add a forwardable HTLC after we've started closing");
1561                         }
1562                 }
1563
1564                 // Now update local state:
1565                 self.next_remote_htlc_id += 1;
1566                 self.pending_inbound_htlcs.push(InboundHTLCOutput {
1567                         htlc_id: msg.htlc_id,
1568                         amount_msat: msg.amount_msat,
1569                         payment_hash: msg.payment_hash,
1570                         cltv_expiry: msg.cltv_expiry,
1571                         state: InboundHTLCState::RemoteAnnounced(pending_forward_state),
1572                 });
1573
1574                 Ok(())
1575         }
1576
1577         /// Marks an outbound HTLC which we have received update_fail/fulfill/malformed
1578         #[inline]
1579         fn mark_outbound_htlc_removed(&mut self, htlc_id: u64, check_preimage: Option<[u8; 32]>, fail_reason: Option<HTLCFailReason>) -> Result<&HTLCSource, ChannelError> {
1580                 for htlc in self.pending_outbound_htlcs.iter_mut() {
1581                         if htlc.htlc_id == htlc_id {
1582                                 match check_preimage {
1583                                         None => {},
1584                                         Some(payment_hash) =>
1585                                                 if payment_hash != htlc.payment_hash {
1586                                                         return Err(ChannelError::Close("Remote tried to fulfill HTLC with an incorrect preimage"));
1587                                                 }
1588                                 };
1589                                 match htlc.state {
1590                                         OutboundHTLCState::LocalAnnounced(_) =>
1591                                                 return Err(ChannelError::Close("Remote tried to fulfill/fail HTLC before it had been committed")),
1592                                         OutboundHTLCState::Committed => {
1593                                                 htlc.state = OutboundHTLCState::RemoteRemoved;
1594                                                 htlc.fail_reason = fail_reason;
1595                                         },
1596                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove | OutboundHTLCState::AwaitingRemovedRemoteRevoke | OutboundHTLCState::RemoteRemoved =>
1597                                                 return Err(ChannelError::Close("Remote tried to fulfill/fail HTLC that they'd already fulfilled/failed")),
1598                                 }
1599                                 return Ok(&htlc.source);
1600                         }
1601                 }
1602                 Err(ChannelError::Close("Remote tried to fulfill/fail an HTLC we couldn't find"))
1603         }
1604
1605         pub fn update_fulfill_htlc(&mut self, msg: &msgs::UpdateFulfillHTLC) -> Result<&HTLCSource, ChannelError> {
1606                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1607                         return Err(ChannelError::Close("Got fulfill HTLC message when channel was not in an operational state"));
1608                 }
1609                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1610                         return Err(ChannelError::Close("Peer sent update_fulfill_htlc when we needed a channel_reestablish"));
1611                 }
1612
1613                 let mut sha = Sha256::new();
1614                 sha.input(&msg.payment_preimage);
1615                 let mut payment_hash = [0; 32];
1616                 sha.result(&mut payment_hash);
1617
1618                 self.mark_outbound_htlc_removed(msg.htlc_id, Some(payment_hash), None)
1619         }
1620
1621         pub fn update_fail_htlc(&mut self, msg: &msgs::UpdateFailHTLC, fail_reason: HTLCFailReason) -> Result<&HTLCSource, ChannelError> {
1622                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1623                         return Err(ChannelError::Close("Got fail HTLC message when channel was not in an operational state"));
1624                 }
1625                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1626                         return Err(ChannelError::Close("Peer sent update_fail_htlc when we needed a channel_reestablish"));
1627                 }
1628
1629                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))
1630         }
1631
1632         pub fn update_fail_malformed_htlc<'a>(&mut self, msg: &msgs::UpdateFailMalformedHTLC, fail_reason: HTLCFailReason) -> Result<&HTLCSource, ChannelError> {
1633                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1634                         return Err(ChannelError::Close("Got fail malformed HTLC message when channel was not in an operational state"));
1635                 }
1636                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1637                         return Err(ChannelError::Close("Peer sent update_fail_malformed_htlc when we needed a channel_reestablish"));
1638                 }
1639
1640                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))
1641         }
1642
1643         pub fn commitment_signed(&mut self, msg: &msgs::CommitmentSigned, fee_estimator: &FeeEstimator) -> Result<(msgs::RevokeAndACK, Option<msgs::CommitmentSigned>, Option<msgs::ClosingSigned>, ChannelMonitor), HandleError> {
1644                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1645                         return Err(HandleError{err: "Got commitment signed message when channel was not in an operational state", action: None});
1646                 }
1647                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1648                         return Err(HandleError{err: "Peer sent commitment_signed when we needed a channel_reestablish", action: Some(msgs::ErrorAction::SendErrorMessage{msg: msgs::ErrorMessage{data: "Peer sent commitment_signed when we needed a channel_reestablish".to_string(), channel_id: msg.channel_id}})});
1649                 }
1650                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
1651                         return Err(HandleError{err: "Peer sent commitment_signed after we'd started exchanging closing_signeds", action: Some(msgs::ErrorAction::SendErrorMessage{msg: msgs::ErrorMessage{data: "Peer sent commitment_signed after we'd started exchanging closing_signeds".to_string(), channel_id: msg.channel_id}})});
1652                 }
1653
1654                 let funding_script = self.get_funding_redeemscript();
1655
1656                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1657
1658                 let feerate_per_kw = if !self.channel_outbound && self.pending_update_fee.is_some() {
1659                         self.pending_update_fee.unwrap()
1660                 } else {
1661                         self.feerate_per_kw
1662                 };
1663
1664                 let mut local_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false, feerate_per_kw);
1665                 let local_commitment_txid = local_commitment_tx.0.txid();
1666                 let local_sighash = Message::from_slice(&bip143::SighashComponents::new(&local_commitment_tx.0).sighash_all(&local_commitment_tx.0.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1667                 secp_call!(self.secp_ctx.verify(&local_sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid commitment tx signature from peer", self.channel_id());
1668
1669                 if msg.htlc_signatures.len() != local_commitment_tx.1.len() {
1670                         return Err(HandleError{err: "Got wrong number of HTLC signatures from remote", action: None});
1671                 }
1672
1673                 let mut new_local_commitment_txn = Vec::with_capacity(local_commitment_tx.1.len() + 1);
1674                 self.sign_commitment_transaction(&mut local_commitment_tx.0, &msg.signature);
1675                 new_local_commitment_txn.push(local_commitment_tx.0.clone());
1676
1677                 let mut htlcs_and_sigs = Vec::with_capacity(local_commitment_tx.1.len());
1678                 for (idx, ref htlc) in local_commitment_tx.1.iter().enumerate() {
1679                         let mut htlc_tx = self.build_htlc_transaction(&local_commitment_txid, htlc, true, &local_keys, feerate_per_kw);
1680                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &local_keys);
1681                         let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
1682                         secp_call!(self.secp_ctx.verify(&htlc_sighash, &msg.htlc_signatures[idx], &local_keys.b_htlc_key), "Invalid HTLC tx siganture from peer", self.channel_id());
1683                         let htlc_sig = if htlc.offered {
1684                                 let htlc_sig = self.sign_htlc_transaction(&mut htlc_tx, &msg.htlc_signatures[idx], &None, htlc, &local_keys)?;
1685                                 new_local_commitment_txn.push(htlc_tx);
1686                                 htlc_sig
1687                         } else {
1688                                 self.create_htlc_tx_signature(&htlc_tx, htlc, &local_keys)?.1
1689                         };
1690                         htlcs_and_sigs.push(((*htlc).clone(), msg.htlc_signatures[idx], htlc_sig));
1691                 }
1692
1693                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(self.cur_local_commitment_transaction_number - 1));
1694                 let per_commitment_secret = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, self.cur_local_commitment_transaction_number + 1);
1695
1696                 // Update state now that we've passed all the can-fail calls...
1697                 let mut need_our_commitment = false;
1698                 if !self.channel_outbound {
1699                         if let Some(fee_update) = self.pending_update_fee {
1700                                 self.feerate_per_kw = fee_update;
1701                                 // We later use the presence of pending_update_fee to indicate we should generate a
1702                                 // commitment_signed upon receipt of revoke_and_ack, so we can only set it to None
1703                                 // if we're not awaiting a revoke (ie will send a commitment_signed now).
1704                                 if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) == 0 {
1705                                         need_our_commitment = true;
1706                                         self.pending_update_fee = None;
1707                                 }
1708                         }
1709                 }
1710                 if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
1711                         // This is a response to our post-monitor-failed unfreeze messages, so we can clear the
1712                         // monitor_pending_order requirement as we won't re-send the monitor_pending messages.
1713                         self.monitor_pending_order = None;
1714                 }
1715
1716                 self.channel_monitor.provide_latest_local_commitment_tx_info(local_commitment_tx.0, local_keys, self.feerate_per_kw, htlcs_and_sigs);
1717
1718                 for htlc in self.pending_inbound_htlcs.iter_mut() {
1719                         let new_forward = if let &InboundHTLCState::RemoteAnnounced(ref forward_info) = &htlc.state {
1720                                 Some(forward_info.clone())
1721                         } else { None };
1722                         if let Some(forward_info) = new_forward {
1723                                 htlc.state = InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info);
1724                                 need_our_commitment = true;
1725                         }
1726                 }
1727                 for htlc in self.pending_outbound_htlcs.iter_mut() {
1728                         if let OutboundHTLCState::RemoteRemoved = htlc.state {
1729                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove;
1730                                 need_our_commitment = true;
1731                         }
1732                 }
1733
1734                 self.cur_local_commitment_transaction_number -= 1;
1735                 self.last_local_commitment_txn = new_local_commitment_txn;
1736                 self.received_commitment_while_awaiting_raa = (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) != 0;
1737
1738                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0 {
1739                         self.monitor_pending_revoke_and_ack = true;
1740                         self.monitor_pending_commitment_signed |= need_our_commitment;
1741                         return Err(HandleError{err: "Previous monitor update failure prevented generation of RAA", action: Some(ErrorAction::IgnoreError)});
1742                 }
1743
1744                 let (our_commitment_signed, monitor_update, closing_signed) = if need_our_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
1745                         // If we're AwaitingRemoteRevoke we can't send a new commitment here, but that's ok -
1746                         // we'll send one right away when we get the revoke_and_ack when we
1747                         // free_holding_cell_htlcs().
1748                         let (msg, monitor) = self.send_commitment_no_status_check()?;
1749                         (Some(msg), monitor, None)
1750                 } else if !need_our_commitment {
1751                         (None, self.channel_monitor.clone(), self.maybe_propose_first_closing_signed(fee_estimator))
1752                 } else { (None, self.channel_monitor.clone(), None) };
1753
1754                 Ok((msgs::RevokeAndACK {
1755                         channel_id: self.channel_id,
1756                         per_commitment_secret: per_commitment_secret,
1757                         next_per_commitment_point: next_per_commitment_point,
1758                 }, our_commitment_signed, closing_signed, monitor_update))
1759         }
1760
1761         /// Used to fulfill holding_cell_htlcs when we get a remote ack (or implicitly get it by them
1762         /// fulfilling or failing the last pending HTLC)
1763         fn free_holding_cell_htlcs(&mut self) -> Result<Option<(msgs::CommitmentUpdate, ChannelMonitor)>, HandleError> {
1764                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
1765                 if self.holding_cell_htlc_updates.len() != 0 || self.holding_cell_update_fee.is_some() {
1766                         let mut htlc_updates = Vec::new();
1767                         mem::swap(&mut htlc_updates, &mut self.holding_cell_htlc_updates);
1768                         let mut update_add_htlcs = Vec::with_capacity(htlc_updates.len());
1769                         let mut update_fulfill_htlcs = Vec::with_capacity(htlc_updates.len());
1770                         let mut update_fail_htlcs = Vec::with_capacity(htlc_updates.len());
1771                         let mut err = None;
1772                         for htlc_update in htlc_updates.drain(..) {
1773                                 // Note that this *can* fail, though it should be due to rather-rare conditions on
1774                                 // fee races with adding too many outputs which push our total payments just over
1775                                 // the limit. In case its less rare than I anticipate, we may want to revisit
1776                                 // handling this case better and maybe fufilling some of the HTLCs while attempting
1777                                 // to rebalance channels.
1778                                 if err.is_some() { // We're back to AwaitingRemoteRevoke (or are about to fail the channel)
1779                                         self.holding_cell_htlc_updates.push(htlc_update);
1780                                 } else {
1781                                         match &htlc_update {
1782                                                 &HTLCUpdateAwaitingACK::AddHTLC {amount_msat, cltv_expiry, payment_hash, ref source, ref onion_routing_packet, ..} => {
1783                                                         match self.send_htlc(amount_msat, payment_hash, cltv_expiry, source.clone(), onion_routing_packet.clone()) {
1784                                                                 Ok(update_add_msg_option) => update_add_htlcs.push(update_add_msg_option.unwrap()),
1785                                                                 Err(e) => {
1786                                                                         err = Some(e);
1787                                                                 }
1788                                                         }
1789                                                 },
1790                                                 &HTLCUpdateAwaitingACK::ClaimHTLC { payment_preimage, htlc_id, .. } => {
1791                                                         match self.get_update_fulfill_htlc(htlc_id, payment_preimage) {
1792                                                                 Ok(update_fulfill_msg_option) => update_fulfill_htlcs.push(update_fulfill_msg_option.0.unwrap()),
1793                                                                 Err(e) => {
1794                                                                         if let Some(msgs::ErrorAction::IgnoreError) = e.action {}
1795                                                                         else {
1796                                                                                 panic!("Got a non-IgnoreError action trying to fulfill holding cell HTLC");
1797                                                                         }
1798                                                                 }
1799                                                         }
1800                                                 },
1801                                                 &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, ref err_packet } => {
1802                                                         match self.get_update_fail_htlc(htlc_id, err_packet.clone()) {
1803                                                                 Ok(update_fail_msg_option) => update_fail_htlcs.push(update_fail_msg_option.unwrap()),
1804                                                                 Err(e) => {
1805                                                                         if let Some(msgs::ErrorAction::IgnoreError) = e.action {}
1806                                                                         else {
1807                                                                                 panic!("Got a non-IgnoreError action trying to fail holding cell HTLC");
1808                                                                         }
1809                                                                 }
1810                                                         }
1811                                                 },
1812                                         }
1813                                         if err.is_some() {
1814                                                 self.holding_cell_htlc_updates.push(htlc_update);
1815                                         }
1816                                 }
1817                         }
1818                         //TODO: Need to examine the type of err - if its a fee issue or similar we may want to
1819                         //fail it back the route, if its a temporary issue we can ignore it...
1820                         match err {
1821                                 None => {
1822                                         if update_add_htlcs.is_empty() && update_fulfill_htlcs.is_empty() && update_fail_htlcs.is_empty() && self.holding_cell_update_fee.is_none() {
1823                                                 // This should never actually happen and indicates we got some Errs back
1824                                                 // from update_fulfill_htlc/update_fail_htlc, but we handle it anyway in
1825                                                 // case there is some strange way to hit duplicate HTLC removes.
1826                                                 return Ok(None);
1827                                         }
1828                                         let update_fee = if let Some(feerate) = self.holding_cell_update_fee {
1829                                                         self.pending_update_fee = self.holding_cell_update_fee.take();
1830                                                         Some(msgs::UpdateFee {
1831                                                                 channel_id: self.channel_id,
1832                                                                 feerate_per_kw: feerate as u32,
1833                                                         })
1834                                                 } else {
1835                                                         None
1836                                                 };
1837                                         let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
1838                                         Ok(Some((msgs::CommitmentUpdate {
1839                                                 update_add_htlcs,
1840                                                 update_fulfill_htlcs,
1841                                                 update_fail_htlcs,
1842                                                 update_fail_malformed_htlcs: Vec::new(),
1843                                                 update_fee: update_fee,
1844                                                 commitment_signed,
1845                                         }, monitor_update)))
1846                                 },
1847                                 Some(e) => Err(e)
1848                         }
1849                 } else {
1850                         Ok(None)
1851                 }
1852         }
1853
1854         /// Handles receiving a remote's revoke_and_ack. Note that we may return a new
1855         /// commitment_signed message here in case we had pending outbound HTLCs to add which were
1856         /// waiting on this revoke_and_ack. The generation of this new commitment_signed may also fail,
1857         /// generating an appropriate error *after* the channel state has been updated based on the
1858         /// revoke_and_ack message.
1859         pub fn revoke_and_ack(&mut self, msg: &msgs::RevokeAndACK, fee_estimator: &FeeEstimator) -> Result<(Option<msgs::CommitmentUpdate>, Vec<(PendingForwardHTLCInfo, u64)>, Vec<(HTLCSource, [u8; 32], HTLCFailReason)>, Option<msgs::ClosingSigned>, ChannelMonitor), HandleError> {
1860                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1861                         return Err(HandleError{err: "Got revoke/ACK message when channel was not in an operational state", action: None});
1862                 }
1863                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1864                         return Err(HandleError{err: "Peer sent revoke_and_ack when we needed a channel_reestablish", action: Some(msgs::ErrorAction::SendErrorMessage{msg: msgs::ErrorMessage{data: "Peer sent revoke_and_ack when we needed a channel_reestablish".to_string(), channel_id: msg.channel_id}})});
1865                 }
1866                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
1867                         return Err(HandleError{err: "Peer sent revoke_and_ack after we'd started exchanging closing_signeds", action: Some(msgs::ErrorAction::SendErrorMessage{msg: msgs::ErrorMessage{data: "Peer sent revoke_and_ack after we'd started exchanging closing_signeds".to_string(), channel_id: msg.channel_id}})});
1868                 }
1869
1870                 if let Some(their_prev_commitment_point) = self.their_prev_commitment_point {
1871                         if PublicKey::from_secret_key(&self.secp_ctx, &secp_call!(SecretKey::from_slice(&self.secp_ctx, &msg.per_commitment_secret), "Peer provided an invalid per_commitment_secret", self.channel_id())) != their_prev_commitment_point {
1872                                 return Err(HandleError{err: "Got a revoke commitment secret which didn't correspond to their current pubkey", action: None});
1873                         }
1874                 }
1875                 self.channel_monitor.provide_secret(self.cur_remote_commitment_transaction_number + 1, msg.per_commitment_secret, Some((self.cur_remote_commitment_transaction_number - 1, msg.next_per_commitment_point)))?;
1876
1877                 // Update state now that we've passed all the can-fail calls...
1878                 // (note that we may still fail to generate the new commitment_signed message, but that's
1879                 // OK, we step the channel here and *then* if the new generation fails we can fail the
1880                 // channel based on that, but stepping stuff here should be safe either way.
1881                 self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
1882                 self.their_prev_commitment_point = self.their_cur_commitment_point;
1883                 self.their_cur_commitment_point = Some(msg.next_per_commitment_point);
1884                 self.cur_remote_commitment_transaction_number -= 1;
1885                 self.received_commitment_while_awaiting_raa = false;
1886                 if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
1887                         // This is a response to our post-monitor-failed unfreeze messages, so we can clear the
1888                         // monitor_pending_order requirement as we won't re-send the monitor_pending messages.
1889                         self.monitor_pending_order = None;
1890                 }
1891
1892                 let mut to_forward_infos = Vec::new();
1893                 let mut revoked_htlcs = Vec::new();
1894                 let mut update_fail_htlcs = Vec::new();
1895                 let mut update_fail_malformed_htlcs = Vec::new();
1896                 let mut require_commitment = false;
1897                 let mut value_to_self_msat_diff: i64 = 0;
1898                 // We really shouldnt have two passes here, but retain gives a non-mutable ref (Rust bug)
1899                 self.pending_inbound_htlcs.retain(|htlc| {
1900                         if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
1901                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1902                                         value_to_self_msat_diff += htlc.amount_msat as i64;
1903                                 }
1904                                 false
1905                         } else { true }
1906                 });
1907                 self.pending_outbound_htlcs.retain(|htlc| {
1908                         if let OutboundHTLCState::AwaitingRemovedRemoteRevoke = htlc.state {
1909                                 if let Some(reason) = htlc.fail_reason.clone() { // We really want take() here, but, again, non-mut ref :(
1910                                         revoked_htlcs.push((htlc.source.clone(), htlc.payment_hash, reason));
1911                                 } else {
1912                                         // They fulfilled, so we sent them money
1913                                         value_to_self_msat_diff -= htlc.amount_msat as i64;
1914                                 }
1915                                 false
1916                         } else { true }
1917                 });
1918                 for htlc in self.pending_inbound_htlcs.iter_mut() {
1919                         let swap = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) = &htlc.state {
1920                                 true
1921                         } else if let &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) = &htlc.state {
1922                                 true
1923                         } else { false };
1924                         if swap {
1925                                 let mut state = InboundHTLCState::Committed;
1926                                 mem::swap(&mut state, &mut htlc.state);
1927
1928                                 if let InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info) = state {
1929                                         htlc.state = InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info);
1930                                         require_commitment = true;
1931                                 } else if let InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info) = state {
1932                                         match forward_info {
1933                                                 PendingHTLCStatus::Fail(fail_msg) => {
1934                                                         require_commitment = true;
1935                                                         match fail_msg {
1936                                                                 HTLCFailureMsg::Relay(msg) => {
1937                                                                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(msg.reason.clone()));
1938                                                                         update_fail_htlcs.push(msg)
1939                                                                 },
1940                                                                 HTLCFailureMsg::Malformed(msg) => {
1941                                                                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailMalformed((msg.sha256_of_onion, msg.failure_code)));
1942                                                                         update_fail_malformed_htlcs.push(msg)
1943                                                                 },
1944                                                         }
1945                                                 },
1946                                                 PendingHTLCStatus::Forward(forward_info) => {
1947                                                         to_forward_infos.push((forward_info, htlc.htlc_id));
1948                                                         htlc.state = InboundHTLCState::Committed;
1949                                                 }
1950                                         }
1951                                 }
1952                         }
1953                 }
1954                 for htlc in self.pending_outbound_htlcs.iter_mut() {
1955                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
1956                                 htlc.state = OutboundHTLCState::Committed;
1957                         } else if let OutboundHTLCState::AwaitingRemoteRevokeToRemove = htlc.state {
1958                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke;
1959                                 require_commitment = true;
1960                         }
1961                 }
1962                 self.value_to_self_msat = (self.value_to_self_msat as i64 + value_to_self_msat_diff) as u64;
1963
1964                 if self.channel_outbound {
1965                         if let Some(feerate) = self.pending_update_fee.take() {
1966                                 self.feerate_per_kw = feerate;
1967                         }
1968                 } else {
1969                         if let Some(feerate) = self.pending_update_fee {
1970                                 // Because a node cannot send two commitment_signed's in a row without getting a
1971                                 // revoke_and_ack from us (as it would otherwise not know the per_commitment_point
1972                                 // it should use to create keys with) and because a node can't send a
1973                                 // commitment_signed without changes, checking if the feerate is equal to the
1974                                 // pending feerate update is sufficient to detect require_commitment.
1975                                 if feerate == self.feerate_per_kw {
1976                                         require_commitment = true;
1977                                         self.pending_update_fee = None;
1978                                 }
1979                         }
1980                 }
1981
1982                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) == ChannelState::MonitorUpdateFailed as u32 {
1983                         // We can't actually generate a new commitment transaction (incl by freeing holding
1984                         // cells) while we can't update the monitor, so we just return what we have.
1985                         if require_commitment {
1986                                 self.monitor_pending_commitment_signed = true;
1987                         }
1988                         self.monitor_pending_forwards.append(&mut to_forward_infos);
1989                         self.monitor_pending_failures.append(&mut revoked_htlcs);
1990                         return Ok((None, Vec::new(), Vec::new(), None, self.channel_monitor.clone()));
1991                 }
1992
1993                 match self.free_holding_cell_htlcs()? {
1994                         Some(mut commitment_update) => {
1995                                 commitment_update.0.update_fail_htlcs.reserve(update_fail_htlcs.len());
1996                                 for fail_msg in update_fail_htlcs.drain(..) {
1997                                         commitment_update.0.update_fail_htlcs.push(fail_msg);
1998                                 }
1999                                 commitment_update.0.update_fail_malformed_htlcs.reserve(update_fail_malformed_htlcs.len());
2000                                 for fail_msg in update_fail_malformed_htlcs.drain(..) {
2001                                         commitment_update.0.update_fail_malformed_htlcs.push(fail_msg);
2002                                 }
2003                                 Ok((Some(commitment_update.0), to_forward_infos, revoked_htlcs, None, commitment_update.1))
2004                         },
2005                         None => {
2006                                 if require_commitment {
2007                                         let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
2008                                         Ok((Some(msgs::CommitmentUpdate {
2009                                                 update_add_htlcs: Vec::new(),
2010                                                 update_fulfill_htlcs: Vec::new(),
2011                                                 update_fail_htlcs,
2012                                                 update_fail_malformed_htlcs,
2013                                                 update_fee: None,
2014                                                 commitment_signed
2015                                         }), to_forward_infos, revoked_htlcs, None, monitor_update))
2016                                 } else {
2017                                         Ok((None, to_forward_infos, revoked_htlcs, self.maybe_propose_first_closing_signed(fee_estimator), self.channel_monitor.clone()))
2018                                 }
2019                         }
2020                 }
2021
2022         }
2023
2024         /// Adds a pending update to this channel. See the doc for send_htlc for
2025         /// further details on the optionness of the return value.
2026         /// You MUST call send_commitment prior to any other calls on this Channel
2027         fn send_update_fee(&mut self, feerate_per_kw: u64) -> Option<msgs::UpdateFee> {
2028                 if !self.channel_outbound {
2029                         panic!("Cannot send fee from inbound channel");
2030                 }
2031                 if !self.is_usable() {
2032                         panic!("Cannot update fee until channel is fully established and we haven't started shutting down");
2033                 }
2034                 if !self.is_live() {
2035                         panic!("Cannot update fee while peer is disconnected/we're awaiting a monitor update (ChannelManager should have caught this)");
2036                 }
2037
2038                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
2039                         self.holding_cell_update_fee = Some(feerate_per_kw);
2040                         return None;
2041                 }
2042
2043                 debug_assert!(self.pending_update_fee.is_none());
2044                 self.pending_update_fee = Some(feerate_per_kw);
2045
2046                 Some(msgs::UpdateFee {
2047                         channel_id: self.channel_id,
2048                         feerate_per_kw: feerate_per_kw as u32,
2049                 })
2050         }
2051
2052         pub fn send_update_fee_and_commit(&mut self, feerate_per_kw: u64) -> Result<Option<(msgs::UpdateFee, msgs::CommitmentSigned, ChannelMonitor)>, HandleError> {
2053                 match self.send_update_fee(feerate_per_kw) {
2054                         Some(update_fee) => {
2055                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
2056                                 Ok(Some((update_fee, commitment_signed, monitor_update)))
2057                         },
2058                         None => Ok(None)
2059                 }
2060         }
2061
2062         /// Removes any uncommitted HTLCs, to be used on peer disconnection, including any pending
2063         /// HTLCs that we intended to add but haven't as we were waiting on a remote revoke.
2064         /// Returns the set of PendingHTLCStatuses from remote uncommitted HTLCs (which we're
2065         /// implicitly dropping) and the payment_hashes of HTLCs we tried to add but are dropping.
2066         /// No further message handling calls may be made until a channel_reestablish dance has
2067         /// completed.
2068         pub fn remove_uncommitted_htlcs_and_mark_paused(&mut self) -> Vec<(HTLCSource, [u8; 32])> {
2069                 let mut outbound_drops = Vec::new();
2070
2071                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
2072                 if self.channel_state < ChannelState::FundingSent as u32 {
2073                         self.channel_state = ChannelState::ShutdownComplete as u32;
2074                         return outbound_drops;
2075                 }
2076                 // Upon reconnect we have to start the closing_signed dance over, but shutdown messages
2077                 // will be retransmitted.
2078                 self.last_sent_closing_fee = None;
2079
2080                 let mut inbound_drop_count = 0;
2081                 self.pending_inbound_htlcs.retain(|htlc| {
2082                         match htlc.state {
2083                                 InboundHTLCState::RemoteAnnounced(_) => {
2084                                         // They sent us an update_add_htlc but we never got the commitment_signed.
2085                                         // We'll tell them what commitment_signed we're expecting next and they'll drop
2086                                         // this HTLC accordingly
2087                                         inbound_drop_count += 1;
2088                                         false
2089                                 },
2090                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_)|InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => {
2091                                         // We received a commitment_signed updating this HTLC and (at least hopefully)
2092                                         // sent a revoke_and_ack (which we can re-transmit) and have heard nothing
2093                                         // in response to it yet, so don't touch it.
2094                                         true
2095                                 },
2096                                 InboundHTLCState::Committed => true,
2097                                 InboundHTLCState::LocalRemoved(_) => {
2098                                         // We (hopefully) sent a commitment_signed updating this HTLC (which we can
2099                                         // re-transmit if needed) and they may have even sent a revoke_and_ack back
2100                                         // (that we missed). Keep this around for now and if they tell us they missed
2101                                         // the commitment_signed we can re-transmit the update then.
2102                                         true
2103                                 },
2104                         }
2105                 });
2106                 self.next_remote_htlc_id -= inbound_drop_count;
2107
2108                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2109                         if let OutboundHTLCState::RemoteRemoved = htlc.state {
2110                                 // They sent us an update to remove this but haven't yet sent the corresponding
2111                                 // commitment_signed, we need to move it back to Committed and they can re-send
2112                                 // the update upon reconnection.
2113                                 htlc.state = OutboundHTLCState::Committed;
2114                         }
2115                 }
2116
2117                 self.holding_cell_htlc_updates.retain(|htlc_update| {
2118                         match htlc_update {
2119                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
2120                                         outbound_drops.push((source.clone(), payment_hash.clone()));
2121                                         false
2122                                 },
2123                                 &HTLCUpdateAwaitingACK::ClaimHTLC {..} | &HTLCUpdateAwaitingACK::FailHTLC {..} => true,
2124                         }
2125                 });
2126                 self.channel_state |= ChannelState::PeerDisconnected as u32;
2127                 log_debug!(self, "Peer disconnection resulted in {} remote-announced HTLC drops and {} waiting-to-locally-announced HTLC drops on channel {}", outbound_drops.len(), inbound_drop_count, log_bytes!(self.channel_id()));
2128                 outbound_drops
2129         }
2130
2131         /// Indicates that a ChannelMonitor update failed to be stored by the client and further
2132         /// updates are partially paused.
2133         /// This must be called immediately after the call which generated the ChannelMonitor update
2134         /// which failed, with the order argument set to the type of call it represented (ie a
2135         /// commitment update or a revoke_and_ack generation). The messages which were generated from
2136         /// that original call must *not* have been sent to the remote end, and must instead have been
2137         /// dropped. They will be regenerated when monitor_updating_restored is called.
2138         pub fn monitor_update_failed(&mut self, order: RAACommitmentOrder) {
2139                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
2140                 match order {
2141                         RAACommitmentOrder::CommitmentFirst => {
2142                                 self.monitor_pending_revoke_and_ack = false;
2143                                 self.monitor_pending_commitment_signed = true;
2144                         },
2145                         RAACommitmentOrder::RevokeAndACKFirst => {
2146                                 self.monitor_pending_revoke_and_ack = true;
2147                                 self.monitor_pending_commitment_signed = false;
2148                         },
2149                 }
2150                 self.monitor_pending_order = Some(order);
2151                 self.channel_state |= ChannelState::MonitorUpdateFailed as u32;
2152         }
2153
2154         /// Indicates that the latest ChannelMonitor update has been committed by the client
2155         /// successfully and we should restore normal operation. Returns messages which should be sent
2156         /// to the remote side.
2157         pub fn monitor_updating_restored(&mut self) -> (Option<msgs::RevokeAndACK>, Option<msgs::CommitmentUpdate>, RAACommitmentOrder, Vec<(PendingForwardHTLCInfo, u64)>, Vec<(HTLCSource, [u8; 32], HTLCFailReason)>) {
2158                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, ChannelState::MonitorUpdateFailed as u32);
2159                 self.channel_state &= !(ChannelState::MonitorUpdateFailed as u32);
2160
2161                 let mut forwards = Vec::new();
2162                 mem::swap(&mut forwards, &mut self.monitor_pending_forwards);
2163                 let mut failures = Vec::new();
2164                 mem::swap(&mut failures, &mut self.monitor_pending_failures);
2165
2166                 if self.channel_state & (ChannelState::PeerDisconnected as u32) != 0 {
2167                         // Leave monitor_pending_order so we can order our channel_reestablish responses
2168                         self.monitor_pending_revoke_and_ack = false;
2169                         self.monitor_pending_commitment_signed = false;
2170                         return (None, None, RAACommitmentOrder::RevokeAndACKFirst, forwards, failures);
2171                 }
2172
2173                 let raa = if self.monitor_pending_revoke_and_ack {
2174                         Some(self.get_last_revoke_and_ack())
2175                 } else { None };
2176                 let commitment_update = if self.monitor_pending_commitment_signed {
2177                         Some(self.get_last_commitment_update())
2178                 } else { None };
2179
2180                 self.monitor_pending_revoke_and_ack = false;
2181                 self.monitor_pending_commitment_signed = false;
2182                 (raa, commitment_update, self.monitor_pending_order.clone().unwrap(), forwards, failures)
2183         }
2184
2185         pub fn update_fee(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::UpdateFee) -> Result<(), ChannelError> {
2186                 if self.channel_outbound {
2187                         return Err(ChannelError::Close("Non-funding remote tried to update channel fee"));
2188                 }
2189                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2190                         return Err(ChannelError::Close("Peer sent update_fee when we needed a channel_reestablish"));
2191                 }
2192                 Channel::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
2193
2194                 self.pending_update_fee = Some(msg.feerate_per_kw as u64);
2195                 self.channel_update_count += 1;
2196                 Ok(())
2197         }
2198
2199         fn get_last_revoke_and_ack(&self) -> msgs::RevokeAndACK {
2200                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(self.cur_local_commitment_transaction_number));
2201                 let per_commitment_secret = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, self.cur_local_commitment_transaction_number + 2);
2202                 msgs::RevokeAndACK {
2203                         channel_id: self.channel_id,
2204                         per_commitment_secret,
2205                         next_per_commitment_point,
2206                 }
2207         }
2208
2209         fn get_last_commitment_update(&self) -> msgs::CommitmentUpdate {
2210                 let mut update_add_htlcs = Vec::new();
2211                 let mut update_fulfill_htlcs = Vec::new();
2212                 let mut update_fail_htlcs = Vec::new();
2213                 let mut update_fail_malformed_htlcs = Vec::new();
2214
2215                 for htlc in self.pending_outbound_htlcs.iter() {
2216                         if let &OutboundHTLCState::LocalAnnounced(ref onion_packet) = &htlc.state {
2217                                 update_add_htlcs.push(msgs::UpdateAddHTLC {
2218                                         channel_id: self.channel_id(),
2219                                         htlc_id: htlc.htlc_id,
2220                                         amount_msat: htlc.amount_msat,
2221                                         payment_hash: htlc.payment_hash,
2222                                         cltv_expiry: htlc.cltv_expiry,
2223                                         onion_routing_packet: (**onion_packet).clone(),
2224                                 });
2225                         }
2226                 }
2227
2228                 for htlc in self.pending_inbound_htlcs.iter() {
2229                         if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
2230                                 match reason {
2231                                         &InboundHTLCRemovalReason::FailRelay(ref err_packet) => {
2232                                                 update_fail_htlcs.push(msgs::UpdateFailHTLC {
2233                                                         channel_id: self.channel_id(),
2234                                                         htlc_id: htlc.htlc_id,
2235                                                         reason: err_packet.clone()
2236                                                 });
2237                                         },
2238                                         &InboundHTLCRemovalReason::FailMalformed((ref sha256_of_onion, ref failure_code)) => {
2239                                                 update_fail_malformed_htlcs.push(msgs::UpdateFailMalformedHTLC {
2240                                                         channel_id: self.channel_id(),
2241                                                         htlc_id: htlc.htlc_id,
2242                                                         sha256_of_onion: sha256_of_onion.clone(),
2243                                                         failure_code: failure_code.clone(),
2244                                                 });
2245                                         },
2246                                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
2247                                                 update_fulfill_htlcs.push(msgs::UpdateFulfillHTLC {
2248                                                         channel_id: self.channel_id(),
2249                                                         htlc_id: htlc.htlc_id,
2250                                                         payment_preimage: payment_preimage.clone(),
2251                                                 });
2252                                         },
2253                                 }
2254                         }
2255                 }
2256
2257                 msgs::CommitmentUpdate {
2258                         update_add_htlcs, update_fulfill_htlcs, update_fail_htlcs, update_fail_malformed_htlcs,
2259                         update_fee: None, //TODO: We need to support re-generating any update_fees in the last commitment_signed!
2260                         commitment_signed: self.send_commitment_no_state_update().expect("It looks like we failed to re-generate a commitment_signed we had previously sent?").0,
2261                 }
2262         }
2263
2264         /// May panic if some calls other than message-handling calls (which will all Err immediately)
2265         /// have been called between remove_uncommitted_htlcs_and_mark_paused and this call.
2266         pub fn channel_reestablish(&mut self, msg: &msgs::ChannelReestablish) -> Result<(Option<msgs::FundingLocked>, Option<msgs::RevokeAndACK>, Option<msgs::CommitmentUpdate>, Option<ChannelMonitor>, RAACommitmentOrder, Option<msgs::Shutdown>), ChannelError> {
2267                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
2268                         // While BOLT 2 doesn't indicate explicitly we should error this channel here, it
2269                         // almost certainly indicates we are going to end up out-of-sync in some way, so we
2270                         // just close here instead of trying to recover.
2271                         return Err(ChannelError::Close("Peer sent a loose channel_reestablish not after reconnect"));
2272                 }
2273
2274                 if msg.next_local_commitment_number >= INITIAL_COMMITMENT_NUMBER || msg.next_remote_commitment_number >= INITIAL_COMMITMENT_NUMBER {
2275                         return Err(ChannelError::Close("Peer sent a garbage channel_reestablish"));
2276                 }
2277
2278                 // Go ahead and unmark PeerDisconnected as various calls we may make check for it (and all
2279                 // remaining cases either succeed or ErrorMessage-fail).
2280                 self.channel_state &= !(ChannelState::PeerDisconnected as u32);
2281
2282                 let shutdown_msg = if self.channel_state & (ChannelState::LocalShutdownSent as u32) != 0 {
2283                         Some(msgs::Shutdown {
2284                                 channel_id: self.channel_id,
2285                                 scriptpubkey: self.get_closing_scriptpubkey(),
2286                         })
2287                 } else { None };
2288
2289                 if self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) == ChannelState::FundingSent as u32 {
2290                         // Short circuit the whole handler as there is nothing we can resend them
2291                         return Ok((None, None, None, None, RAACommitmentOrder::CommitmentFirst, shutdown_msg));
2292                 }
2293
2294                 if msg.next_local_commitment_number == 0 || msg.next_remote_commitment_number == 0 {
2295                         if self.channel_state & (ChannelState::FundingSent as u32) != ChannelState::FundingSent as u32 {
2296                                 return Err(ChannelError::Close("Peer sent a pre-funding channel_reestablish after we exchanged funding_locked"));
2297                         }
2298                         // We have OurFundingLocked set!
2299                         let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2300                         let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2301                         return Ok((Some(msgs::FundingLocked {
2302                                 channel_id: self.channel_id(),
2303                                 next_per_commitment_point: next_per_commitment_point,
2304                         }), None, None, None, RAACommitmentOrder::CommitmentFirst, shutdown_msg));
2305                 }
2306
2307                 let required_revoke = if msg.next_remote_commitment_number == INITIAL_COMMITMENT_NUMBER - self.cur_local_commitment_transaction_number {
2308                         // Remote isn't waiting on any RevokeAndACK from us!
2309                         // Note that if we need to repeat our FundingLocked we'll do that in the next if block.
2310                         None
2311                 } else if msg.next_remote_commitment_number == (INITIAL_COMMITMENT_NUMBER - 1) - self.cur_local_commitment_transaction_number {
2312                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
2313                                 self.monitor_pending_revoke_and_ack = true;
2314                                 None
2315                         } else {
2316                                 Some(self.get_last_revoke_and_ack())
2317                         }
2318                 } else {
2319                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old local commitment transaction"));
2320                 };
2321
2322                 // We increment cur_remote_commitment_transaction_number only upon receipt of
2323                 // revoke_and_ack, not on sending commitment_signed, so we add one if have
2324                 // AwaitingRemoteRevoke set, which indicates we sent a commitment_signed but haven't gotten
2325                 // the corresponding revoke_and_ack back yet.
2326                 let our_next_remote_commitment_number = INITIAL_COMMITMENT_NUMBER - self.cur_remote_commitment_transaction_number + if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 };
2327
2328                 let resend_funding_locked = if msg.next_local_commitment_number == 1 && INITIAL_COMMITMENT_NUMBER - self.cur_local_commitment_transaction_number == 1 {
2329                         // We should never have to worry about MonitorUpdateFailed resending FundingLocked
2330                         let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2331                         let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2332                         Some(msgs::FundingLocked {
2333                                 channel_id: self.channel_id(),
2334                                 next_per_commitment_point: next_per_commitment_point,
2335                         })
2336                 } else { None };
2337
2338                 let order = self.monitor_pending_order.clone().unwrap_or(if self.received_commitment_while_awaiting_raa {
2339                                 RAACommitmentOrder::CommitmentFirst
2340                         } else {
2341                                 RAACommitmentOrder::RevokeAndACKFirst
2342                         });
2343
2344                 if msg.next_local_commitment_number == our_next_remote_commitment_number {
2345                         if required_revoke.is_some() {
2346                                 log_debug!(self, "Reconnected channel {} with only lost outbound RAA", log_bytes!(self.channel_id()));
2347                         } else {
2348                                 log_debug!(self, "Reconnected channel {} with no loss", log_bytes!(self.channel_id()));
2349                         }
2350
2351                         if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 &&
2352                                         self.monitor_pending_order.is_none() { // monitor_pending_order indicates we're waiting on a response to a unfreeze
2353                                 // We're up-to-date and not waiting on a remote revoke (if we are our
2354                                 // channel_reestablish should result in them sending a revoke_and_ack), but we may
2355                                 // have received some updates while we were disconnected. Free the holding cell
2356                                 // now!
2357                                 match self.free_holding_cell_htlcs() {
2358                                         Err(e) => {
2359                                                 if let &Some(msgs::ErrorAction::DisconnectPeer{msg: Some(_)}) = &e.action {
2360                                                         return Err(ChannelError::Close(e.err));
2361                                                 } else if let &Some(msgs::ErrorAction::SendErrorMessage{msg: _}) = &e.action {
2362                                                         return Err(ChannelError::Close(e.err));
2363                                                 } else {
2364                                                         panic!("Got non-channel-failing result from free_holding_cell_htlcs");
2365                                                 }
2366                                         },
2367                                         Ok(Some((commitment_update, channel_monitor))) => return Ok((resend_funding_locked, required_revoke, Some(commitment_update), Some(channel_monitor), order, shutdown_msg)),
2368                                         Ok(None) => return Ok((resend_funding_locked, required_revoke, None, None, order, shutdown_msg)),
2369                                 }
2370                         } else {
2371                                 return Ok((resend_funding_locked, required_revoke, None, None, order, shutdown_msg));
2372                         }
2373                 } else if msg.next_local_commitment_number == our_next_remote_commitment_number - 1 {
2374                         if required_revoke.is_some() {
2375                                 log_debug!(self, "Reconnected channel {} with lost outbound RAA and lost remote commitment tx", log_bytes!(self.channel_id()));
2376                         } else {
2377                                 log_debug!(self, "Reconnected channel {} with only lost remote commitment tx", log_bytes!(self.channel_id()));
2378                         }
2379
2380                         // If monitor_pending_order is set, it must be CommitmentSigned if we have no RAA
2381                         debug_assert!(self.monitor_pending_order != Some(RAACommitmentOrder::RevokeAndACKFirst) || required_revoke.is_some());
2382
2383                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
2384                                 self.monitor_pending_commitment_signed = true;
2385                                 return Ok((resend_funding_locked, None, None, None, order, shutdown_msg));
2386                         }
2387
2388                         return Ok((resend_funding_locked, required_revoke, Some(self.get_last_commitment_update()), None, order, shutdown_msg));
2389                 } else {
2390                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction"));
2391                 }
2392         }
2393
2394         fn maybe_propose_first_closing_signed(&mut self, fee_estimator: &FeeEstimator) -> Option<msgs::ClosingSigned> {
2395                 if !self.channel_outbound || !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() ||
2396                                 self.channel_state & (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::AwaitingRemoteRevoke as u32) != BOTH_SIDES_SHUTDOWN_MASK ||
2397                                 self.last_sent_closing_fee.is_some() ||
2398                                 self.cur_remote_commitment_transaction_number != self.cur_local_commitment_transaction_number{
2399                         return None;
2400                 }
2401
2402                 let mut proposed_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
2403                 if self.feerate_per_kw > proposed_feerate {
2404                         proposed_feerate = self.feerate_per_kw;
2405                 }
2406                 let tx_weight = Self::get_closing_transaction_weight(&self.get_closing_scriptpubkey(), self.their_shutdown_scriptpubkey.as_ref().unwrap());
2407                 let proposed_total_fee_satoshis = proposed_feerate * tx_weight / 1000;
2408
2409                 let (closing_tx, total_fee_satoshis) = self.build_closing_transaction(proposed_total_fee_satoshis, false);
2410                 let funding_redeemscript = self.get_funding_redeemscript();
2411                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
2412
2413                 self.last_sent_closing_fee = Some((proposed_feerate, total_fee_satoshis));
2414                 Some(msgs::ClosingSigned {
2415                         channel_id: self.channel_id,
2416                         fee_satoshis: total_fee_satoshis,
2417                         signature: self.secp_ctx.sign(&sighash, &self.local_keys.funding_key),
2418                 })
2419         }
2420
2421         pub fn shutdown(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::Shutdown) -> Result<(Option<msgs::Shutdown>, Option<msgs::ClosingSigned>, Vec<(HTLCSource, [u8; 32])>), ChannelError> {
2422                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2423                         return Err(ChannelError::Close("Peer sent shutdown when we needed a channel_reestablish"));
2424                 }
2425                 if self.channel_state < ChannelState::FundingSent as u32 {
2426                         // Spec says we should fail the connection, not the channel, but that's nonsense, there
2427                         // are plenty of reasons you may want to fail a channel pre-funding, and spec says you
2428                         // can do that via error message without getting a connection fail anyway...
2429                         return Err(ChannelError::Close("Peer sent shutdown pre-funding generation"));
2430                 }
2431                 for htlc in self.pending_inbound_htlcs.iter() {
2432                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
2433                                 return Err(ChannelError::Close("Got shutdown with remote pending HTLCs"));
2434                         }
2435                 }
2436                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
2437
2438                 // BOLT 2 says we must only send a scriptpubkey of certain standard forms, which are up to
2439                 // 34 bytes in length, so dont let the remote peer feed us some super fee-heavy script.
2440                 if self.channel_outbound && msg.scriptpubkey.len() > 34 {
2441                         return Err(ChannelError::Close("Got shutdown_scriptpubkey of absurd length from remote peer"));
2442                 }
2443
2444                 //Check shutdown_scriptpubkey form as BOLT says we must
2445                 if !msg.scriptpubkey.is_p2pkh() && !msg.scriptpubkey.is_p2sh() && !msg.scriptpubkey.is_v0_p2wpkh() && !msg.scriptpubkey.is_v0_p2wsh() {
2446                         return Err(ChannelError::Close("Got a nonstandard scriptpubkey from remote peer"));
2447                 }
2448
2449                 if self.their_shutdown_scriptpubkey.is_some() {
2450                         if Some(&msg.scriptpubkey) != self.their_shutdown_scriptpubkey.as_ref() {
2451                                 return Err(ChannelError::Close("Got shutdown request with a scriptpubkey which did not match their previous scriptpubkey"));
2452                         }
2453                 } else {
2454                         self.their_shutdown_scriptpubkey = Some(msg.scriptpubkey.clone());
2455                 }
2456
2457                 // From here on out, we may not fail!
2458
2459                 self.channel_state |= ChannelState::RemoteShutdownSent as u32;
2460                 self.channel_update_count += 1;
2461
2462                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
2463                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
2464                 // cell HTLCs and return them to fail the payment.
2465                 self.holding_cell_update_fee = None;
2466                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
2467                 self.holding_cell_htlc_updates.retain(|htlc_update| {
2468                         match htlc_update {
2469                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
2470                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
2471                                         false
2472                                 },
2473                                 _ => true
2474                         }
2475                 });
2476                 // If we have any LocalAnnounced updates we'll probably just get back a update_fail_htlc
2477                 // immediately after the commitment dance, but we can send a Shutdown cause we won't send
2478                 // any further commitment updates after we set LocalShutdownSent.
2479
2480                 let our_shutdown = if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
2481                         None
2482                 } else {
2483                         Some(msgs::Shutdown {
2484                                 channel_id: self.channel_id,
2485                                 scriptpubkey: self.get_closing_scriptpubkey(),
2486                         })
2487                 };
2488
2489                 self.channel_state |= ChannelState::LocalShutdownSent as u32;
2490                 self.channel_update_count += 1;
2491                 Ok((our_shutdown, self.maybe_propose_first_closing_signed(fee_estimator), dropped_outbound_htlcs))
2492         }
2493
2494         pub fn closing_signed(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::ClosingSigned) -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), HandleError> {
2495                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != BOTH_SIDES_SHUTDOWN_MASK {
2496                         return Err(HandleError{err: "Remote end sent us a closing_signed before both sides provided a shutdown", action: None});
2497                 }
2498                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2499                         return Err(HandleError{err: "Peer sent closing_signed when we needed a channel_reestablish", action: Some(msgs::ErrorAction::SendErrorMessage{msg: msgs::ErrorMessage{data: "Peer sent closing_signed when we needed a channel_reestablish".to_string(), channel_id: msg.channel_id}})});
2500                 }
2501                 if !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() {
2502                         return Err(HandleError{err: "Remote end sent us a closing_signed while there were still pending HTLCs", action: None});
2503                 }
2504                 if msg.fee_satoshis > 21000000 * 10000000 { //this is required to stop potential overflow in build_closing_transaction
2505                         return Err(HandleError{err: "Remote tried to send us a closing tx with > 21 million BTC fee", action: None});
2506                 }
2507
2508                 let funding_redeemscript = self.get_funding_redeemscript();
2509                 let (mut closing_tx, used_total_fee) = self.build_closing_transaction(msg.fee_satoshis, false);
2510                 if used_total_fee != msg.fee_satoshis {
2511                         return Err(HandleError{err: "Remote sent us a closing_signed with a fee greater than the value they can claim", action: None});
2512                 }
2513                 let mut sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
2514
2515                 match self.secp_ctx.verify(&sighash, &msg.signature, &self.their_funding_pubkey.unwrap()) {
2516                         Ok(_) => {},
2517                         Err(_e) => {
2518                                 // The remote end may have decided to revoke their output due to inconsistent dust
2519                                 // limits, so check for that case by re-checking the signature here.
2520                                 closing_tx = self.build_closing_transaction(msg.fee_satoshis, true).0;
2521                                 sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
2522                                 secp_call!(self.secp_ctx.verify(&sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid closing tx signature from peer", self.channel_id());
2523                         },
2524                 };
2525
2526                 if let Some((_, last_fee)) = self.last_sent_closing_fee {
2527                         if last_fee == msg.fee_satoshis {
2528                                 self.sign_commitment_transaction(&mut closing_tx, &msg.signature);
2529                                 self.channel_state = ChannelState::ShutdownComplete as u32;
2530                                 self.channel_update_count += 1;
2531                                 return Ok((None, Some(closing_tx)));
2532                         }
2533                 }
2534
2535                 macro_rules! propose_new_feerate {
2536                         ($new_feerate: expr) => {
2537                                 let closing_tx_max_weight = Self::get_closing_transaction_weight(&self.get_closing_scriptpubkey(), self.their_shutdown_scriptpubkey.as_ref().unwrap());
2538                                 let (closing_tx, used_total_fee) = self.build_closing_transaction($new_feerate * closing_tx_max_weight / 1000, false);
2539                                 sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
2540                                 let our_sig = self.secp_ctx.sign(&sighash, &self.local_keys.funding_key);
2541                                 self.last_sent_closing_fee = Some(($new_feerate, used_total_fee));
2542                                 return Ok((Some(msgs::ClosingSigned {
2543                                         channel_id: self.channel_id,
2544                                         fee_satoshis: used_total_fee,
2545                                         signature: our_sig,
2546                                 }), None))
2547                         }
2548                 }
2549
2550                 let proposed_sat_per_kw = msg.fee_satoshis * 1000 / closing_tx.get_weight();
2551                 if self.channel_outbound {
2552                         let our_max_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
2553                         if proposed_sat_per_kw > our_max_feerate {
2554                                 if let Some((last_feerate, _)) = self.last_sent_closing_fee {
2555                                         if our_max_feerate <= last_feerate {
2556                                                 return Err(HandleError{err: "Unable to come to consensus about closing feerate, remote wanted something higher than our Normal feerate", action: None});
2557                                         }
2558                                 }
2559                                 propose_new_feerate!(our_max_feerate);
2560                         }
2561                 } else {
2562                         let our_min_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
2563                         if proposed_sat_per_kw < our_min_feerate {
2564                                 if let Some((last_feerate, _)) = self.last_sent_closing_fee {
2565                                         if our_min_feerate >= last_feerate {
2566                                                 return Err(HandleError{err: "Unable to come to consensus about closing feerate, remote wanted something lower than our Background feerate", action: None});
2567                                         }
2568                                 }
2569                                 propose_new_feerate!(our_min_feerate);
2570                         }
2571                 }
2572
2573                 let our_sig = self.sign_commitment_transaction(&mut closing_tx, &msg.signature);
2574                 self.channel_state = ChannelState::ShutdownComplete as u32;
2575                 self.channel_update_count += 1;
2576
2577                 Ok((Some(msgs::ClosingSigned {
2578                         channel_id: self.channel_id,
2579                         fee_satoshis: msg.fee_satoshis,
2580                         signature: our_sig,
2581                 }), Some(closing_tx)))
2582         }
2583
2584         // Public utilities:
2585
2586         pub fn channel_id(&self) -> [u8; 32] {
2587                 self.channel_id
2588         }
2589
2590         /// Gets the "user_id" value passed into the construction of this channel. It has no special
2591         /// meaning and exists only to allow users to have a persistent identifier of a channel.
2592         pub fn get_user_id(&self) -> u64 {
2593                 self.user_id
2594         }
2595
2596         /// May only be called after funding has been initiated (ie is_funding_initiated() is true)
2597         pub fn channel_monitor(&self) -> ChannelMonitor {
2598                 if self.channel_state < ChannelState::FundingCreated as u32 {
2599                         panic!("Can't get a channel monitor until funding has been created");
2600                 }
2601                 self.channel_monitor.clone()
2602         }
2603
2604         /// Guaranteed to be Some after both FundingLocked messages have been exchanged (and, thus,
2605         /// is_usable() returns true).
2606         /// Allowed in any state (including after shutdown)
2607         pub fn get_short_channel_id(&self) -> Option<u64> {
2608                 self.short_channel_id
2609         }
2610
2611         /// Returns the funding_txo we either got from our peer, or were given by
2612         /// get_outbound_funding_created.
2613         pub fn get_funding_txo(&self) -> Option<OutPoint> {
2614                 self.channel_monitor.get_funding_txo()
2615         }
2616
2617         /// Allowed in any state (including after shutdown)
2618         pub fn get_their_node_id(&self) -> PublicKey {
2619                 self.their_node_id
2620         }
2621
2622         /// Allowed in any state (including after shutdown)
2623         pub fn get_our_htlc_minimum_msat(&self) -> u64 {
2624                 self.our_htlc_minimum_msat
2625         }
2626
2627         /// Allowed in any state (including after shutdown)
2628         pub fn get_their_htlc_minimum_msat(&self) -> u64 {
2629                 self.our_htlc_minimum_msat
2630         }
2631
2632         pub fn get_value_satoshis(&self) -> u64 {
2633                 self.channel_value_satoshis
2634         }
2635
2636         pub fn get_fee_proportional_millionths(&self) -> u32 {
2637                 self.config.fee_proportional_millionths
2638         }
2639
2640         #[cfg(test)]
2641         pub fn get_feerate(&self) -> u64 {
2642                 self.feerate_per_kw
2643         }
2644
2645         pub fn get_cur_local_commitment_transaction_number(&self) -> u64 {
2646                 self.cur_local_commitment_transaction_number + 1
2647         }
2648
2649         pub fn get_cur_remote_commitment_transaction_number(&self) -> u64 {
2650                 self.cur_remote_commitment_transaction_number + 1 - if self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 }
2651         }
2652
2653         pub fn get_revoked_remote_commitment_transaction_number(&self) -> u64 {
2654                 self.cur_remote_commitment_transaction_number + 2
2655         }
2656
2657         //TODO: Testing purpose only, should be changed in another way after #81
2658         #[cfg(test)]
2659         pub fn get_local_keys(&self) -> &ChannelKeys {
2660                 &self.local_keys
2661         }
2662
2663         #[cfg(test)]
2664         pub fn get_value_stat(&self) -> ChannelValueStat {
2665                 ChannelValueStat {
2666                         value_to_self_msat: self.value_to_self_msat,
2667                         channel_value_msat: self.channel_value_satoshis * 1000,
2668                         channel_reserve_msat: self.their_channel_reserve_satoshis * 1000,
2669                         pending_outbound_htlcs_amount_msat: self.pending_outbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
2670                         pending_inbound_htlcs_amount_msat: self.pending_inbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
2671                         holding_cell_outbound_amount_msat: {
2672                                 let mut res = 0;
2673                                 for h in self.holding_cell_htlc_updates.iter() {
2674                                         match h {
2675                                                 &HTLCUpdateAwaitingACK::AddHTLC{amount_msat, .. } => {
2676                                                         res += amount_msat;
2677                                                 }
2678                                                 _ => {}
2679                                         }
2680                                 }
2681                                 res
2682                         },
2683                         their_max_htlc_value_in_flight_msat: self.their_max_htlc_value_in_flight_msat,
2684                 }
2685         }
2686
2687         /// Allowed in any state (including after shutdown)
2688         pub fn get_channel_update_count(&self) -> u32 {
2689                 self.channel_update_count
2690         }
2691
2692         pub fn should_announce(&self) -> bool {
2693                 self.config.announced_channel
2694         }
2695
2696         pub fn is_outbound(&self) -> bool {
2697                 self.channel_outbound
2698         }
2699
2700         /// Gets the fee we'd want to charge for adding an HTLC output to this Channel
2701         /// Allowed in any state (including after shutdown)
2702         pub fn get_our_fee_base_msat(&self, fee_estimator: &FeeEstimator) -> u32 {
2703                 // For lack of a better metric, we calculate what it would cost to consolidate the new HTLC
2704                 // output value back into a transaction with the regular channel output:
2705
2706                 // the fee cost of the HTLC-Success/HTLC-Timeout transaction:
2707                 let mut res = self.feerate_per_kw * cmp::max(HTLC_TIMEOUT_TX_WEIGHT, HTLC_SUCCESS_TX_WEIGHT) / 1000;
2708
2709                 if self.channel_outbound {
2710                         // + the marginal fee increase cost to us in the commitment transaction:
2711                         res += self.feerate_per_kw * COMMITMENT_TX_WEIGHT_PER_HTLC / 1000;
2712                 }
2713
2714                 // + the marginal cost of an input which spends the HTLC-Success/HTLC-Timeout output:
2715                 res += fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal) * SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT / 1000;
2716
2717                 res as u32
2718         }
2719
2720         /// Returns true if we've ever received a message from the remote end for this Channel
2721         pub fn have_received_message(&self) -> bool {
2722                 self.channel_state > (ChannelState::OurInitSent as u32)
2723         }
2724
2725         /// Returns true if this channel is fully established and not known to be closing.
2726         /// Allowed in any state (including after shutdown)
2727         pub fn is_usable(&self) -> bool {
2728                 let mask = ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK;
2729                 (self.channel_state & mask) == (ChannelState::ChannelFunded as u32)
2730         }
2731
2732         /// Returns true if this channel is currently available for use. This is a superset of
2733         /// is_usable() and considers things like the channel being temporarily disabled.
2734         /// Allowed in any state (including after shutdown)
2735         pub fn is_live(&self) -> bool {
2736                 self.is_usable() && (self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) == 0)
2737         }
2738
2739         /// Returns true if this channel has been marked as awaiting a monitor update to move forward.
2740         /// Allowed in any state (including after shutdown)
2741         pub fn is_awaiting_monitor_update(&self) -> bool {
2742                 (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0
2743         }
2744
2745         /// Returns true if funding_created was sent/received.
2746         pub fn is_funding_initiated(&self) -> bool {
2747                 self.channel_state >= ChannelState::FundingCreated as u32
2748         }
2749
2750         /// Returns true if this channel is fully shut down. True here implies that no further actions
2751         /// may/will be taken on this channel, and thus this object should be freed. Any future changes
2752         /// will be handled appropriately by the chain monitor.
2753         pub fn is_shutdown(&self) -> bool {
2754                 if (self.channel_state & ChannelState::ShutdownComplete as u32) == ChannelState::ShutdownComplete as u32  {
2755                         assert!(self.channel_state == ChannelState::ShutdownComplete as u32);
2756                         true
2757                 } else { false }
2758         }
2759
2760         /// Called by channelmanager based on chain blocks being connected.
2761         /// Note that we only need to use this to detect funding_signed, anything else is handled by
2762         /// the channel_monitor.
2763         /// In case of Err, the channel may have been closed, at which point the standard requirements
2764         /// apply - no calls may be made except those explicitly stated to be allowed post-shutdown.
2765         /// Only returns an ErrorAction of DisconnectPeer, if Err.
2766         pub fn block_connected(&mut self, header: &BlockHeader, height: u32, txn_matched: &[&Transaction], indexes_of_txn_matched: &[u32]) -> Result<Option<msgs::FundingLocked>, HandleError> {
2767                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
2768                 if header.bitcoin_hash() != self.last_block_connected {
2769                         self.last_block_connected = header.bitcoin_hash();
2770                         self.channel_monitor.last_block_hash = self.last_block_connected;
2771                         if self.funding_tx_confirmations > 0 {
2772                                 self.funding_tx_confirmations += 1;
2773                                 if self.funding_tx_confirmations == self.minimum_depth as u64 {
2774                                         let need_commitment_update = if non_shutdown_state == ChannelState::FundingSent as u32 {
2775                                                 self.channel_state |= ChannelState::OurFundingLocked as u32;
2776                                                 true
2777                                         } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) {
2778                                                 self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
2779                                                 self.channel_update_count += 1;
2780                                                 true
2781                                         } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
2782                                                 // We got a reorg but not enough to trigger a force close, just update
2783                                                 // funding_tx_confirmed_in and return.
2784                                                 false
2785                                         } else if self.channel_state < ChannelState::ChannelFunded as u32 {
2786                                                 panic!("Started confirming a channel in a state pre-FundingSent?: {}", self.channel_state);
2787                                         } else {
2788                                                 // We got a reorg but not enough to trigger a force close, just update
2789                                                 // funding_tx_confirmed_in and return.
2790                                                 false
2791                                         };
2792                                         self.funding_tx_confirmed_in = Some(header.bitcoin_hash());
2793
2794                                         //TODO: Note that this must be a duplicate of the previous commitment point they sent us,
2795                                         //as otherwise we will have a commitment transaction that they can't revoke (well, kinda,
2796                                         //they can by sending two revoke_and_acks back-to-back, but not really). This appears to be
2797                                         //a protocol oversight, but I assume I'm just missing something.
2798                                         if need_commitment_update {
2799                                                 let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2800                                                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2801                                                 return Ok(Some(msgs::FundingLocked {
2802                                                         channel_id: self.channel_id,
2803                                                         next_per_commitment_point: next_per_commitment_point,
2804                                                 }));
2805                                         }
2806                                 }
2807                         }
2808                 }
2809                 if non_shutdown_state & !(ChannelState::TheirFundingLocked as u32) == ChannelState::FundingSent as u32 {
2810                         for (ref tx, index_in_block) in txn_matched.iter().zip(indexes_of_txn_matched) {
2811                                 if tx.txid() == self.channel_monitor.get_funding_txo().unwrap().txid {
2812                                         let txo_idx = self.channel_monitor.get_funding_txo().unwrap().index as usize;
2813                                         if txo_idx >= tx.output.len() || tx.output[txo_idx].script_pubkey != self.get_funding_redeemscript().to_v0_p2wsh() ||
2814                                                         tx.output[txo_idx].value != self.channel_value_satoshis {
2815                                                 if self.channel_outbound {
2816                                                         // If we generated the funding transaction and it doesn't match what it
2817                                                         // should, the client is really broken and we should just panic and
2818                                                         // tell them off. That said, because hash collisions happen with high
2819                                                         // probability in fuzztarget mode, if we're fuzzing we just close the
2820                                                         // channel and move on.
2821                                                         #[cfg(not(feature = "fuzztarget"))]
2822                                                         panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
2823                                                 }
2824                                                 self.channel_state = ChannelState::ShutdownComplete as u32;
2825                                                 self.channel_update_count += 1;
2826                                                 return Err(HandleError{err: "funding tx had wrong script/value", action: Some(ErrorAction::DisconnectPeer{msg: None})});
2827                                         } else {
2828                                                 if self.channel_outbound {
2829                                                         for input in tx.input.iter() {
2830                                                                 if input.witness.is_empty() {
2831                                                                         // We generated a malleable funding transaction, implying we've
2832                                                                         // just exposed ourselves to funds loss to our counterparty.
2833                                                                         #[cfg(not(feature = "fuzztarget"))]
2834                                                                         panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
2835                                                                 }
2836                                                         }
2837                                                 }
2838                                                 self.funding_tx_confirmations = 1;
2839                                                 self.short_channel_id = Some(((height as u64)          << (5*8)) |
2840                                                                              ((*index_in_block as u64) << (2*8)) |
2841                                                                              ((txo_idx as u64)         << (0*8)));
2842                                         }
2843                                 }
2844                         }
2845                 }
2846                 Ok(None)
2847         }
2848
2849         /// Called by channelmanager based on chain blocks being disconnected.
2850         /// Returns true if we need to close the channel now due to funding transaction
2851         /// unconfirmation/reorg.
2852         pub fn block_disconnected(&mut self, header: &BlockHeader) -> bool {
2853                 if self.funding_tx_confirmations > 0 {
2854                         self.funding_tx_confirmations -= 1;
2855                         if self.funding_tx_confirmations == UNCONF_THRESHOLD as u64 {
2856                                 return true;
2857                         }
2858                 }
2859                 if Some(header.bitcoin_hash()) == self.funding_tx_confirmed_in {
2860                         self.funding_tx_confirmations = self.minimum_depth as u64 - 1;
2861                 }
2862                 self.last_block_connected = header.bitcoin_hash();
2863                 self.channel_monitor.last_block_hash = self.last_block_connected;
2864                 false
2865         }
2866
2867         // Methods to get unprompted messages to send to the remote end (or where we already returned
2868         // something in the handler for the message that prompted this message):
2869
2870         pub fn get_open_channel(&self, chain_hash: Sha256dHash, fee_estimator: &FeeEstimator) -> msgs::OpenChannel {
2871                 if !self.channel_outbound {
2872                         panic!("Tried to open a channel for an inbound channel?");
2873                 }
2874                 if self.channel_state != ChannelState::OurInitSent as u32 {
2875                         panic!("Cannot generate an open_channel after we've moved forward");
2876                 }
2877
2878                 if self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
2879                         panic!("Tried to send an open_channel for a channel that has already advanced");
2880                 }
2881
2882                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2883
2884                 msgs::OpenChannel {
2885                         chain_hash: chain_hash,
2886                         temporary_channel_id: self.channel_id,
2887                         funding_satoshis: self.channel_value_satoshis,
2888                         push_msat: self.channel_value_satoshis * 1000 - self.value_to_self_msat,
2889                         dust_limit_satoshis: self.our_dust_limit_satoshis,
2890                         max_htlc_value_in_flight_msat: Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
2891                         channel_reserve_satoshis: Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
2892                         htlc_minimum_msat: self.our_htlc_minimum_msat,
2893                         feerate_per_kw: fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background) as u32,
2894                         to_self_delay: BREAKDOWN_TIMEOUT,
2895                         max_accepted_htlcs: OUR_MAX_HTLCS,
2896                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key),
2897                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key),
2898                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key),
2899                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key),
2900                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key),
2901                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret),
2902                         channel_flags: if self.config.announced_channel {1} else {0},
2903                         shutdown_scriptpubkey: None,
2904                 }
2905         }
2906
2907         pub fn get_accept_channel(&self) -> msgs::AcceptChannel {
2908                 if self.channel_outbound {
2909                         panic!("Tried to send accept_channel for an outbound channel?");
2910                 }
2911                 if self.channel_state != (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32) {
2912                         panic!("Tried to send accept_channel after channel had moved forward");
2913                 }
2914                 if self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
2915                         panic!("Tried to send an accept_channel for a channel that has already advanced");
2916                 }
2917
2918                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2919
2920                 msgs::AcceptChannel {
2921                         temporary_channel_id: self.channel_id,
2922                         dust_limit_satoshis: self.our_dust_limit_satoshis,
2923                         max_htlc_value_in_flight_msat: Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
2924                         channel_reserve_satoshis: Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
2925                         htlc_minimum_msat: self.our_htlc_minimum_msat,
2926                         minimum_depth: self.minimum_depth,
2927                         to_self_delay: BREAKDOWN_TIMEOUT,
2928                         max_accepted_htlcs: OUR_MAX_HTLCS,
2929                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key),
2930                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key),
2931                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key),
2932                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key),
2933                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key),
2934                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret),
2935                         shutdown_scriptpubkey: None,
2936                 }
2937         }
2938
2939         fn get_outbound_funding_created_signature(&mut self) -> Result<(Signature, Transaction), HandleError> {
2940                 let funding_script = self.get_funding_redeemscript();
2941
2942                 let remote_keys = self.build_remote_transaction_keys()?;
2943                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false, self.feerate_per_kw).0;
2944                 let remote_sighash = Message::from_slice(&bip143::SighashComponents::new(&remote_initial_commitment_tx).sighash_all(&remote_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
2945
2946                 // We sign the "remote" commitment transaction, allowing them to broadcast the tx if they wish.
2947                 Ok((self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key), remote_initial_commitment_tx))
2948         }
2949
2950         /// Updates channel state with knowledge of the funding transaction's txid/index, and generates
2951         /// a funding_created message for the remote peer.
2952         /// Panics if called at some time other than immediately after initial handshake, if called twice,
2953         /// or if called on an inbound channel.
2954         /// Note that channel_id changes during this call!
2955         /// Do NOT broadcast the funding transaction until after a successful funding_signed call!
2956         pub fn get_outbound_funding_created(&mut self, funding_txo: OutPoint) -> Result<(msgs::FundingCreated, ChannelMonitor), HandleError> {
2957                 if !self.channel_outbound {
2958                         panic!("Tried to create outbound funding_created message on an inbound channel!");
2959                 }
2960                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
2961                         panic!("Tried to get a funding_created messsage at a time other than immediately after initial handshake completion (or tried to get funding_created twice)");
2962                 }
2963                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) ||
2964                                 self.cur_remote_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
2965                                 self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
2966                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
2967                 }
2968
2969                 let funding_txo_script = self.get_funding_redeemscript().to_v0_p2wsh();
2970                 self.channel_monitor.set_funding_info((funding_txo, funding_txo_script));
2971
2972                 let (our_signature, commitment_tx) = match self.get_outbound_funding_created_signature() {
2973                         Ok(res) => res,
2974                         Err(e) => {
2975                                 log_error!(self, "Got bad signatures: {}!", e.err);
2976                                 self.channel_monitor.unset_funding_info();
2977                                 return Err(e);
2978                         }
2979                 };
2980
2981                 let temporary_channel_id = self.channel_id;
2982
2983                 // Now that we're past error-generating stuff, update our local state:
2984                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&commitment_tx, Vec::new(), self.cur_remote_commitment_transaction_number);
2985                 self.channel_state = ChannelState::FundingCreated as u32;
2986                 self.channel_id = funding_txo.to_channel_id();
2987                 self.cur_remote_commitment_transaction_number -= 1;
2988
2989                 Ok((msgs::FundingCreated {
2990                         temporary_channel_id: temporary_channel_id,
2991                         funding_txid: funding_txo.txid,
2992                         funding_output_index: funding_txo.index,
2993                         signature: our_signature
2994                 }, self.channel_monitor.clone()))
2995         }
2996
2997         /// Gets an UnsignedChannelAnnouncement, as well as a signature covering it using our
2998         /// bitcoin_key, if available, for this channel. The channel must be publicly announceable and
2999         /// available for use (have exchanged FundingLocked messages in both directions). Should be used
3000         /// for both loose and in response to an AnnouncementSignatures message from the remote peer.
3001         /// Will only fail if we're not in a state where channel_announcement may be sent (including
3002         /// closing).
3003         /// Note that the "channel must be funded" requirement is stricter than BOLT 7 requires - see
3004         /// https://github.com/lightningnetwork/lightning-rfc/issues/468
3005         pub fn get_channel_announcement(&self, our_node_id: PublicKey, chain_hash: Sha256dHash) -> Result<(msgs::UnsignedChannelAnnouncement, Signature), ChannelError> {
3006                 if !self.config.announced_channel {
3007                         return Err(ChannelError::Ignore("Channel is not available for public announcements"));
3008                 }
3009                 if self.channel_state & (ChannelState::ChannelFunded as u32) == 0 {
3010                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement until the channel funding has been locked"));
3011                 }
3012                 if (self.channel_state & (ChannelState::LocalShutdownSent as u32 | ChannelState::ShutdownComplete as u32)) != 0 {
3013                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement once the channel is closing"));
3014                 }
3015
3016                 let were_node_one = our_node_id.serialize()[..] < self.their_node_id.serialize()[..];
3017                 let our_bitcoin_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key);
3018
3019                 let msg = msgs::UnsignedChannelAnnouncement {
3020                         features: msgs::GlobalFeatures::new(),
3021                         chain_hash: chain_hash,
3022                         short_channel_id: self.get_short_channel_id().unwrap(),
3023                         node_id_1: if were_node_one { our_node_id } else { self.get_their_node_id() },
3024                         node_id_2: if were_node_one { self.get_their_node_id() } else { our_node_id },
3025                         bitcoin_key_1: if were_node_one { our_bitcoin_key } else { self.their_funding_pubkey.unwrap() },
3026                         bitcoin_key_2: if were_node_one { self.their_funding_pubkey.unwrap() } else { our_bitcoin_key },
3027                         excess_data: Vec::new(),
3028                 };
3029
3030                 let msghash = Message::from_slice(&Sha256dHash::from_data(&msg.encode()[..])[..]).unwrap();
3031                 let sig = self.secp_ctx.sign(&msghash, &self.local_keys.funding_key);
3032
3033                 Ok((msg, sig))
3034         }
3035
3036         /// May panic if called on a channel that wasn't immediately-previously
3037         /// self.remove_uncommitted_htlcs_and_mark_paused()'d
3038         pub fn get_channel_reestablish(&self) -> msgs::ChannelReestablish {
3039                 assert_eq!(self.channel_state & ChannelState::PeerDisconnected as u32, ChannelState::PeerDisconnected as u32);
3040                 msgs::ChannelReestablish {
3041                         channel_id: self.channel_id(),
3042                         next_local_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_local_commitment_transaction_number,
3043                         next_remote_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_remote_commitment_transaction_number -
3044                                 if self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) == (ChannelState::FundingSent as u32) { 1 } else { 0 },
3045                         data_loss_protect: None,
3046                 }
3047         }
3048
3049
3050         // Send stuff to our remote peers:
3051
3052         /// Adds a pending outbound HTLC to this channel, note that you probably want
3053         /// send_htlc_and_commit instead cause you'll want both messages at once.
3054         /// This returns an option instead of a pure UpdateAddHTLC as we may be in a state where we are
3055         /// waiting on the remote peer to send us a revoke_and_ack during which time we cannot add new
3056         /// HTLCs on the wire or we wouldn't be able to determine what they actually ACK'ed.
3057         /// You MUST call send_commitment prior to any other calls on this Channel
3058         pub fn send_htlc(&mut self, amount_msat: u64, payment_hash: [u8; 32], cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket) -> Result<Option<msgs::UpdateAddHTLC>, HandleError> {
3059                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK)) != (ChannelState::ChannelFunded as u32) {
3060                         return Err(HandleError{err: "Cannot send HTLC until channel is fully established and we haven't started shutting down", action: None});
3061                 }
3062
3063                 if amount_msat > self.channel_value_satoshis * 1000 {
3064                         return Err(HandleError{err: "Cannot send more than the total value of the channel", action: None});
3065                 }
3066                 if amount_msat < self.their_htlc_minimum_msat {
3067                         return Err(HandleError{err: "Cannot send less than their minimum HTLC value", action: None});
3068                 }
3069
3070                 if (self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
3071                         // Note that this should never really happen, if we're !is_live() on receipt of an
3072                         // incoming HTLC for relay will result in us rejecting the HTLC and we won't allow
3073                         // the user to send directly into a !is_live() channel. However, if we
3074                         // disconnected during the time the previous hop was doing the commitment dance we may
3075                         // end up getting here after the forwarding delay. In any case, returning an
3076                         // IgnoreError will get ChannelManager to do the right thing and fail backwards now.
3077                         return Err(HandleError{err: "Cannot send an HTLC while disconnected/frozen for channel monitor update", action: Some(ErrorAction::IgnoreError)});
3078                 }
3079
3080                 let (outbound_htlc_count, htlc_outbound_value_msat) = self.get_outbound_pending_htlc_stats();
3081                 if outbound_htlc_count + 1 > self.their_max_accepted_htlcs as u32 {
3082                         return Err(HandleError{err: "Cannot push more than their max accepted HTLCs", action: None});
3083                 }
3084                 //TODO: Spec is unclear if this is per-direction or in total (I assume per direction):
3085                 // Check their_max_htlc_value_in_flight_msat
3086                 if htlc_outbound_value_msat + amount_msat > self.their_max_htlc_value_in_flight_msat {
3087                         return Err(HandleError{err: "Cannot send value that would put us over our max HTLC value in flight", action: None});
3088                 }
3089
3090                 let mut holding_cell_outbound_amount_msat = 0;
3091                 for holding_htlc in self.holding_cell_htlc_updates.iter() {
3092                         match holding_htlc {
3093                                 &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, .. } => {
3094                                         holding_cell_outbound_amount_msat += *amount_msat;
3095                                 }
3096                                 _ => {}
3097                         }
3098                 }
3099
3100                 // Check self.their_channel_reserve_satoshis (the amount we must keep as
3101                 // reserve for them to have something to claim if we misbehave)
3102                 if self.value_to_self_msat < self.their_channel_reserve_satoshis * 1000 + amount_msat + holding_cell_outbound_amount_msat + htlc_outbound_value_msat {
3103                         return Err(HandleError{err: "Cannot send value that would put us over our reserve value", action: None});
3104                 }
3105
3106                 //TODO: Check cltv_expiry? Do this in channel manager?
3107
3108                 // Now update local state:
3109                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
3110                         //TODO: Check the limits *including* other pending holding cell HTLCs!
3111                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::AddHTLC {
3112                                 amount_msat: amount_msat,
3113                                 payment_hash: payment_hash,
3114                                 cltv_expiry: cltv_expiry,
3115                                 source,
3116                                 onion_routing_packet: onion_routing_packet,
3117                                 time_created: Instant::now(),
3118                         });
3119                         return Ok(None);
3120                 }
3121
3122                 self.pending_outbound_htlcs.push(OutboundHTLCOutput {
3123                         htlc_id: self.next_local_htlc_id,
3124                         amount_msat: amount_msat,
3125                         payment_hash: payment_hash.clone(),
3126                         cltv_expiry: cltv_expiry,
3127                         state: OutboundHTLCState::LocalAnnounced(Box::new(onion_routing_packet.clone())),
3128                         source,
3129                         fail_reason: None,
3130                 });
3131
3132                 let res = msgs::UpdateAddHTLC {
3133                         channel_id: self.channel_id,
3134                         htlc_id: self.next_local_htlc_id,
3135                         amount_msat: amount_msat,
3136                         payment_hash: payment_hash,
3137                         cltv_expiry: cltv_expiry,
3138                         onion_routing_packet: onion_routing_packet,
3139                 };
3140                 self.next_local_htlc_id += 1;
3141
3142                 Ok(Some(res))
3143         }
3144
3145         /// Creates a signed commitment transaction to send to the remote peer.
3146         /// Always returns a Channel-failing HandleError::action if an immediately-preceding (read: the
3147         /// last call to this Channel) send_htlc returned Ok(Some(_)) and there is an Err.
3148         /// May panic if called except immediately after a successful, Ok(Some(_))-returning send_htlc.
3149         pub fn send_commitment(&mut self) -> Result<(msgs::CommitmentSigned, ChannelMonitor), HandleError> {
3150                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
3151                         panic!("Cannot create commitment tx until channel is fully established");
3152                 }
3153                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
3154                         panic!("Cannot create commitment tx until remote revokes their previous commitment");
3155                 }
3156                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) == (ChannelState::PeerDisconnected as u32) {
3157                         panic!("Cannot create commitment tx while disconnected, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
3158                 }
3159                 if (self.channel_state & (ChannelState::MonitorUpdateFailed as u32)) == (ChannelState::MonitorUpdateFailed as u32) {
3160                         panic!("Cannot create commitment tx while awaiting monitor update unfreeze, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
3161                 }
3162                 let mut have_updates = self.pending_update_fee.is_some();
3163                 for htlc in self.pending_outbound_htlcs.iter() {
3164                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
3165                                 have_updates = true;
3166                         }
3167                         if have_updates { break; }
3168                 }
3169                 if !have_updates {
3170                         panic!("Cannot create commitment tx until we have some updates to send");
3171                 }
3172                 self.send_commitment_no_status_check()
3173         }
3174         /// Only fails in case of bad keys
3175         fn send_commitment_no_status_check(&mut self) -> Result<(msgs::CommitmentSigned, ChannelMonitor), HandleError> {
3176                 // We can upgrade the status of some HTLCs that are waiting on a commitment, even if we
3177                 // fail to generate this, we still are at least at a position where upgrading their status
3178                 // is acceptable.
3179                 for htlc in self.pending_inbound_htlcs.iter_mut() {
3180                         let new_state = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref forward_info) = &htlc.state {
3181                                 Some(InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info.clone()))
3182                         } else { None };
3183                         if let Some(state) = new_state {
3184                                 htlc.state = state;
3185                         }
3186                 }
3187                 for htlc in self.pending_outbound_htlcs.iter_mut() {
3188                         if let OutboundHTLCState::AwaitingRemoteRevokeToRemove = htlc.state {
3189                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke;
3190                         }
3191                 }
3192
3193                 match self.send_commitment_no_state_update() {
3194                         Ok((res, remote_commitment_tx)) => {
3195                                 // Update state now that we've passed all the can-fail calls...
3196                                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&remote_commitment_tx.0, remote_commitment_tx.1, self.cur_remote_commitment_transaction_number);
3197                                 self.channel_state |= ChannelState::AwaitingRemoteRevoke as u32;
3198                                 Ok((res, self.channel_monitor.clone()))
3199                         },
3200                         Err(e) => Err(e),
3201                 }
3202         }
3203
3204         /// Only fails in case of bad keys. Used for channel_reestablish commitment_signed generation
3205         /// when we shouldn't change HTLC/channel state.
3206         fn send_commitment_no_state_update(&self) -> Result<(msgs::CommitmentSigned, (Transaction, Vec<HTLCOutputInCommitment>)), HandleError> {
3207                 let funding_script = self.get_funding_redeemscript();
3208
3209                 let mut feerate_per_kw = self.feerate_per_kw;
3210                 if let Some(feerate) = self.pending_update_fee {
3211                         if self.channel_outbound {
3212                                 feerate_per_kw = feerate;
3213                         }
3214                 }
3215
3216                 let remote_keys = self.build_remote_transaction_keys()?;
3217                 let remote_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, true, feerate_per_kw);
3218                 let remote_commitment_txid = remote_commitment_tx.0.txid();
3219                 let remote_sighash = Message::from_slice(&bip143::SighashComponents::new(&remote_commitment_tx.0).sighash_all(&remote_commitment_tx.0.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
3220                 let our_sig = self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key);
3221
3222                 let mut htlc_sigs = Vec::new();
3223
3224                 for ref htlc in remote_commitment_tx.1.iter() {
3225                         let htlc_tx = self.build_htlc_transaction(&remote_commitment_txid, htlc, false, &remote_keys, feerate_per_kw);
3226                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &remote_keys);
3227                         let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
3228                         let our_htlc_key = secp_derived_key!(chan_utils::derive_private_key(&self.secp_ctx, &remote_keys.per_commitment_point, &self.local_keys.htlc_base_key), self.channel_id());
3229                         htlc_sigs.push(self.secp_ctx.sign(&htlc_sighash, &our_htlc_key));
3230                 }
3231
3232                 Ok((msgs::CommitmentSigned {
3233                         channel_id: self.channel_id,
3234                         signature: our_sig,
3235                         htlc_signatures: htlc_sigs,
3236                 }, remote_commitment_tx))
3237         }
3238
3239         /// Adds a pending outbound HTLC to this channel, and creates a signed commitment transaction
3240         /// to send to the remote peer in one go.
3241         /// Shorthand for calling send_htlc() followed by send_commitment(), see docs on those for
3242         /// more info.
3243         pub fn send_htlc_and_commit(&mut self, amount_msat: u64, payment_hash: [u8; 32], cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket) -> Result<Option<(msgs::UpdateAddHTLC, msgs::CommitmentSigned, ChannelMonitor)>, HandleError> {
3244                 match self.send_htlc(amount_msat, payment_hash, cltv_expiry, source, onion_routing_packet)? {
3245                         Some(update_add_htlc) => {
3246                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
3247                                 Ok(Some((update_add_htlc, commitment_signed, monitor_update)))
3248                         },
3249                         None => Ok(None)
3250                 }
3251         }
3252
3253         /// Begins the shutdown process, getting a message for the remote peer and returning all
3254         /// holding cell HTLCs for payment failure.
3255         pub fn get_shutdown(&mut self) -> Result<(msgs::Shutdown, Vec<(HTLCSource, [u8; 32])>), APIError> {
3256                 for htlc in self.pending_outbound_htlcs.iter() {
3257                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
3258                                 return Err(APIError::APIMisuseError{err: "Cannot begin shutdown with pending HTLCs. Process pending events first"});
3259                         }
3260                 }
3261                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != 0 {
3262                         if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
3263                                 return Err(APIError::APIMisuseError{err: "Shutdown already in progress"});
3264                         }
3265                         else if (self.channel_state & ChannelState::RemoteShutdownSent as u32) == ChannelState::RemoteShutdownSent as u32 {
3266                                 return Err(APIError::ChannelUnavailable{err: "Shutdown already in progress by remote"});
3267                         }
3268                 }
3269                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3270                 if self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) != 0 {
3271                         return Err(APIError::ChannelUnavailable{err: "Cannot begin shutdown while peer is disconnected or we're waiting on a monitor update, maybe force-close instead?"});
3272                 }
3273
3274                 let our_closing_script = self.get_closing_scriptpubkey();
3275
3276                 // From here on out, we may not fail!
3277                 if self.channel_state < ChannelState::FundingSent as u32 {
3278                         self.channel_state = ChannelState::ShutdownComplete as u32;
3279                 } else {
3280                         self.channel_state |= ChannelState::LocalShutdownSent as u32;
3281                 }
3282                 self.channel_update_count += 1;
3283
3284                 // Go ahead and drop holding cell updates as we'd rather fail payments than wait to send
3285                 // our shutdown until we've committed all of the pending changes.
3286                 self.holding_cell_update_fee = None;
3287                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
3288                 self.holding_cell_htlc_updates.retain(|htlc_update| {
3289                         match htlc_update {
3290                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
3291                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
3292                                         false
3293                                 },
3294                                 _ => true
3295                         }
3296                 });
3297
3298                 Ok((msgs::Shutdown {
3299                         channel_id: self.channel_id,
3300                         scriptpubkey: our_closing_script,
3301                 }, dropped_outbound_htlcs))
3302         }
3303
3304         /// Gets the latest commitment transaction and any dependant transactions for relay (forcing
3305         /// shutdown of this channel - no more calls into this Channel may be made afterwards except
3306         /// those explicitly stated to be allowed after shutdown completes, eg some simple getters).
3307         /// Also returns the list of payment_hashes for channels which we can safely fail backwards
3308         /// immediately (others we will have to allow to time out).
3309         pub fn force_shutdown(&mut self) -> (Vec<Transaction>, Vec<(HTLCSource, [u8; 32])>) {
3310                 assert!(self.channel_state != ChannelState::ShutdownComplete as u32);
3311
3312                 // We go ahead and "free" any holding cell HTLCs or HTLCs we haven't yet committed to and
3313                 // return them to fail the payment.
3314                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
3315                 for htlc_update in self.holding_cell_htlc_updates.drain(..) {
3316                         match htlc_update {
3317                                 HTLCUpdateAwaitingACK::AddHTLC { source, payment_hash, .. } => {
3318                                         dropped_outbound_htlcs.push((source, payment_hash));
3319                                 },
3320                                 _ => {}
3321                         }
3322                 }
3323
3324                 for _htlc in self.pending_outbound_htlcs.drain(..) {
3325                         //TODO: Do something with the remaining HTLCs
3326                         //(we need to have the ChannelManager monitor them so we can claim the inbound HTLCs
3327                         //which correspond)
3328                 }
3329
3330                 self.channel_state = ChannelState::ShutdownComplete as u32;
3331                 self.channel_update_count += 1;
3332                 let mut res = Vec::new();
3333                 mem::swap(&mut res, &mut self.last_local_commitment_txn);
3334                 (res, dropped_outbound_htlcs)
3335         }
3336 }
3337
3338 const SERIALIZATION_VERSION: u8 = 1;
3339 const MIN_SERIALIZATION_VERSION: u8 = 1;
3340
3341 impl Writeable for InboundHTLCRemovalReason {
3342         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
3343                 match self {
3344                         &InboundHTLCRemovalReason::FailRelay(ref error_packet) => {
3345                                 0u8.write(writer)?;
3346                                 error_packet.write(writer)?;
3347                         },
3348                         &InboundHTLCRemovalReason::FailMalformed((ref onion_hash, ref err_code)) => {
3349                                 1u8.write(writer)?;
3350                                 onion_hash.write(writer)?;
3351                                 err_code.write(writer)?;
3352                         },
3353                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
3354                                 2u8.write(writer)?;
3355                                 payment_preimage.write(writer)?;
3356                         },
3357                 }
3358                 Ok(())
3359         }
3360 }
3361
3362 impl<R: ::std::io::Read> Readable<R> for InboundHTLCRemovalReason {
3363         fn read(reader: &mut R) -> Result<Self, DecodeError> {
3364                 Ok(match <u8 as Readable<R>>::read(reader)? {
3365                         0 => InboundHTLCRemovalReason::FailRelay(Readable::read(reader)?),
3366                         1 => InboundHTLCRemovalReason::FailMalformed((Readable::read(reader)?, Readable::read(reader)?)),
3367                         2 => InboundHTLCRemovalReason::Fulfill(Readable::read(reader)?),
3368                         _ => return Err(DecodeError::InvalidValue),
3369                 })
3370         }
3371 }
3372
3373 impl Writeable for Channel {
3374         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
3375                 // Note that we write out as if remove_uncommitted_htlcs_and_mark_paused had just been
3376                 // called but include holding cell updates (and obviously we don't modify self).
3377
3378                 writer.write_all(&[SERIALIZATION_VERSION; 1])?;
3379                 writer.write_all(&[MIN_SERIALIZATION_VERSION; 1])?;
3380
3381                 self.user_id.write(writer)?;
3382                 self.config.write(writer)?;
3383
3384                 self.channel_id.write(writer)?;
3385                 (self.channel_state | ChannelState::PeerDisconnected as u32).write(writer)?;
3386                 self.channel_outbound.write(writer)?;
3387                 self.channel_value_satoshis.write(writer)?;
3388
3389                 self.local_keys.write(writer)?;
3390                 self.shutdown_pubkey.write(writer)?;
3391
3392                 self.cur_local_commitment_transaction_number.write(writer)?;
3393                 self.cur_remote_commitment_transaction_number.write(writer)?;
3394                 self.value_to_self_msat.write(writer)?;
3395
3396                 self.received_commitment_while_awaiting_raa.write(writer)?;
3397
3398                 let mut dropped_inbound_htlcs = 0;
3399                 for htlc in self.pending_inbound_htlcs.iter() {
3400                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
3401                                 dropped_inbound_htlcs += 1;
3402                         }
3403                 }
3404                 (self.pending_inbound_htlcs.len() as u64 - dropped_inbound_htlcs).write(writer)?;
3405                 for htlc in self.pending_inbound_htlcs.iter() {
3406                         htlc.htlc_id.write(writer)?;
3407                         htlc.amount_msat.write(writer)?;
3408                         htlc.cltv_expiry.write(writer)?;
3409                         htlc.payment_hash.write(writer)?;
3410                         match &htlc.state {
3411                                 &InboundHTLCState::RemoteAnnounced(_) => {}, // Drop
3412                                 &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref htlc_state) => {
3413                                         1u8.write(writer)?;
3414                                         htlc_state.write(writer)?;
3415                                 },
3416                                 &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(ref htlc_state) => {
3417                                         2u8.write(writer)?;
3418                                         htlc_state.write(writer)?;
3419                                 },
3420                                 &InboundHTLCState::Committed => {
3421                                         3u8.write(writer)?;
3422                                 },
3423                                 &InboundHTLCState::LocalRemoved(ref removal_reason) => {
3424                                         4u8.write(writer)?;
3425                                         removal_reason.write(writer)?;
3426                                 },
3427                         }
3428                 }
3429
3430                 macro_rules! write_option {
3431                         ($thing: expr) => {
3432                                 match &$thing {
3433                                         &None => 0u8.write(writer)?,
3434                                         &Some(ref v) => {
3435                                                 1u8.write(writer)?;
3436                                                 v.write(writer)?;
3437                                         },
3438                                 }
3439                         }
3440                 }
3441
3442                 (self.pending_outbound_htlcs.len() as u64).write(writer)?;
3443                 for htlc in self.pending_outbound_htlcs.iter() {
3444                         htlc.htlc_id.write(writer)?;
3445                         htlc.amount_msat.write(writer)?;
3446                         htlc.cltv_expiry.write(writer)?;
3447                         htlc.payment_hash.write(writer)?;
3448                         htlc.source.write(writer)?;
3449                         write_option!(htlc.fail_reason);
3450                         match &htlc.state {
3451                                 &OutboundHTLCState::LocalAnnounced(ref onion_packet) => {
3452                                         0u8.write(writer)?;
3453                                         onion_packet.write(writer)?;
3454                                 },
3455                                 &OutboundHTLCState::Committed => {
3456                                         1u8.write(writer)?;
3457                                 },
3458                                 &OutboundHTLCState::RemoteRemoved => {
3459                                         2u8.write(writer)?;
3460                                 },
3461                                 &OutboundHTLCState::AwaitingRemoteRevokeToRemove => {
3462                                         3u8.write(writer)?;
3463                                 },
3464                                 &OutboundHTLCState::AwaitingRemovedRemoteRevoke => {
3465                                         4u8.write(writer)?;
3466                                 },
3467                         }
3468                 }
3469
3470                 (self.holding_cell_htlc_updates.len() as u64).write(writer)?;
3471                 for update in self.holding_cell_htlc_updates.iter() {
3472                         match update {
3473                                 &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, time_created: _ } => {
3474                                         0u8.write(writer)?;
3475                                         amount_msat.write(writer)?;
3476                                         cltv_expiry.write(writer)?;
3477                                         payment_hash.write(writer)?;
3478                                         source.write(writer)?;
3479                                         onion_routing_packet.write(writer)?;
3480                                         // time_created is not serialized - we re-init the timeout upon deserialization
3481                                 },
3482                                 &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, ref htlc_id } => {
3483                                         1u8.write(writer)?;
3484                                         payment_preimage.write(writer)?;
3485                                         htlc_id.write(writer)?;
3486                                 },
3487                                 &HTLCUpdateAwaitingACK::FailHTLC { ref htlc_id, ref err_packet } => {
3488                                         2u8.write(writer)?;
3489                                         htlc_id.write(writer)?;
3490                                         err_packet.write(writer)?;
3491                                 }
3492                         }
3493                 }
3494
3495                 self.monitor_pending_revoke_and_ack.write(writer)?;
3496                 self.monitor_pending_commitment_signed.write(writer)?;
3497                 match self.monitor_pending_order {
3498                         None => 0u8.write(writer)?,
3499                         Some(RAACommitmentOrder::CommitmentFirst) => 1u8.write(writer)?,
3500                         Some(RAACommitmentOrder::RevokeAndACKFirst) => 2u8.write(writer)?,
3501                 }
3502
3503                 (self.monitor_pending_forwards.len() as u64).write(writer)?;
3504                 for &(ref pending_forward, ref htlc_id) in self.monitor_pending_forwards.iter() {
3505                         pending_forward.write(writer)?;
3506                         htlc_id.write(writer)?;
3507                 }
3508
3509                 (self.monitor_pending_failures.len() as u64).write(writer)?;
3510                 for &(ref htlc_source, ref payment_hash, ref fail_reason) in self.monitor_pending_failures.iter() {
3511                         htlc_source.write(writer)?;
3512                         payment_hash.write(writer)?;
3513                         fail_reason.write(writer)?;
3514                 }
3515
3516                 write_option!(self.pending_update_fee);
3517                 write_option!(self.holding_cell_update_fee);
3518
3519                 self.next_local_htlc_id.write(writer)?;
3520                 (self.next_remote_htlc_id - dropped_inbound_htlcs).write(writer)?;
3521                 self.channel_update_count.write(writer)?;
3522                 self.feerate_per_kw.write(writer)?;
3523
3524                 (self.last_local_commitment_txn.len() as u64).write(writer)?;
3525                 for tx in self.last_local_commitment_txn.iter() {
3526                         if let Err(e) = tx.consensus_encode(&mut WriterWriteAdaptor(writer)) {
3527                                 match e {
3528                                         encode::Error::Io(e) => return Err(e),
3529                                         _ => panic!("last_local_commitment_txn must have been well-formed!"),
3530                                 }
3531                         }
3532                 }
3533
3534                 match self.last_sent_closing_fee {
3535                         Some((feerate, fee)) => {
3536                                 1u8.write(writer)?;
3537                                 feerate.write(writer)?;
3538                                 fee.write(writer)?;
3539                         },
3540                         None => 0u8.write(writer)?,
3541                 }
3542
3543                 write_option!(self.funding_tx_confirmed_in);
3544                 write_option!(self.short_channel_id);
3545
3546                 self.last_block_connected.write(writer)?;
3547                 self.funding_tx_confirmations.write(writer)?;
3548
3549                 self.their_dust_limit_satoshis.write(writer)?;
3550                 self.our_dust_limit_satoshis.write(writer)?;
3551                 self.their_max_htlc_value_in_flight_msat.write(writer)?;
3552                 self.their_channel_reserve_satoshis.write(writer)?;
3553                 self.their_htlc_minimum_msat.write(writer)?;
3554                 self.our_htlc_minimum_msat.write(writer)?;
3555                 self.their_to_self_delay.write(writer)?;
3556                 self.their_max_accepted_htlcs.write(writer)?;
3557                 self.minimum_depth.write(writer)?;
3558
3559                 write_option!(self.their_funding_pubkey);
3560                 write_option!(self.their_revocation_basepoint);
3561                 write_option!(self.their_payment_basepoint);
3562                 write_option!(self.their_delayed_payment_basepoint);
3563                 write_option!(self.their_htlc_basepoint);
3564                 write_option!(self.their_cur_commitment_point);
3565
3566                 write_option!(self.their_prev_commitment_point);
3567                 self.their_node_id.write(writer)?;
3568
3569                 write_option!(self.their_shutdown_scriptpubkey);
3570
3571                 self.channel_monitor.write_for_disk(writer)?;
3572                 Ok(())
3573         }
3574 }
3575
3576 impl<R : ::std::io::Read> ReadableArgs<R, Arc<Logger>> for Channel {
3577         fn read(reader: &mut R, logger: Arc<Logger>) -> Result<Self, DecodeError> {
3578                 let _ver: u8 = Readable::read(reader)?;
3579                 let min_ver: u8 = Readable::read(reader)?;
3580                 if min_ver > SERIALIZATION_VERSION {
3581                         return Err(DecodeError::UnknownVersion);
3582                 }
3583
3584                 let user_id = Readable::read(reader)?;
3585                 let config: ChannelConfig = Readable::read(reader)?;
3586
3587                 let channel_id = Readable::read(reader)?;
3588                 let channel_state = Readable::read(reader)?;
3589                 let channel_outbound = Readable::read(reader)?;
3590                 let channel_value_satoshis = Readable::read(reader)?;
3591
3592                 let local_keys = Readable::read(reader)?;
3593                 let shutdown_pubkey = Readable::read(reader)?;
3594
3595                 let cur_local_commitment_transaction_number = Readable::read(reader)?;
3596                 let cur_remote_commitment_transaction_number = Readable::read(reader)?;
3597                 let value_to_self_msat = Readable::read(reader)?;
3598
3599                 let received_commitment_while_awaiting_raa = Readable::read(reader)?;
3600
3601                 let pending_inbound_htlc_count: u64 = Readable::read(reader)?;
3602                 let mut pending_inbound_htlcs = Vec::with_capacity(cmp::min(pending_inbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
3603                 for _ in 0..pending_inbound_htlc_count {
3604                         pending_inbound_htlcs.push(InboundHTLCOutput {
3605                                 htlc_id: Readable::read(reader)?,
3606                                 amount_msat: Readable::read(reader)?,
3607                                 cltv_expiry: Readable::read(reader)?,
3608                                 payment_hash: Readable::read(reader)?,
3609                                 state: match <u8 as Readable<R>>::read(reader)? {
3610                                         1 => InboundHTLCState::AwaitingRemoteRevokeToAnnounce(Readable::read(reader)?),
3611                                         2 => InboundHTLCState::AwaitingAnnouncedRemoteRevoke(Readable::read(reader)?),
3612                                         3 => InboundHTLCState::Committed,
3613                                         4 => InboundHTLCState::LocalRemoved(Readable::read(reader)?),
3614                                         _ => return Err(DecodeError::InvalidValue),
3615                                 },
3616                         });
3617                 }
3618
3619                 macro_rules! read_option { () => {
3620                         match <u8 as Readable<R>>::read(reader)? {
3621                                 0 => None,
3622                                 1 => Some(Readable::read(reader)?),
3623                                 _ => return Err(DecodeError::InvalidValue),
3624                         }
3625                 } }
3626
3627                 let pending_outbound_htlc_count: u64 = Readable::read(reader)?;
3628                 let mut pending_outbound_htlcs = Vec::with_capacity(cmp::min(pending_outbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
3629                 for _ in 0..pending_outbound_htlc_count {
3630                         pending_outbound_htlcs.push(OutboundHTLCOutput {
3631                                 htlc_id: Readable::read(reader)?,
3632                                 amount_msat: Readable::read(reader)?,
3633                                 cltv_expiry: Readable::read(reader)?,
3634                                 payment_hash: Readable::read(reader)?,
3635                                 source: Readable::read(reader)?,
3636                                 fail_reason: read_option!(),
3637                                 state: match <u8 as Readable<R>>::read(reader)? {
3638                                         0 => OutboundHTLCState::LocalAnnounced(Box::new(Readable::read(reader)?)),
3639                                         1 => OutboundHTLCState::Committed,
3640                                         2 => OutboundHTLCState::RemoteRemoved,
3641                                         3 => OutboundHTLCState::AwaitingRemoteRevokeToRemove,
3642                                         4 => OutboundHTLCState::AwaitingRemovedRemoteRevoke,
3643                                         _ => return Err(DecodeError::InvalidValue),
3644                                 },
3645                         });
3646                 }
3647
3648                 let holding_cell_htlc_update_count: u64 = Readable::read(reader)?;
3649                 let mut holding_cell_htlc_updates = Vec::with_capacity(cmp::min(holding_cell_htlc_update_count as usize, OUR_MAX_HTLCS as usize*2));
3650                 for _ in 0..holding_cell_htlc_update_count {
3651                         holding_cell_htlc_updates.push(match <u8 as Readable<R>>::read(reader)? {
3652                                 0 => HTLCUpdateAwaitingACK::AddHTLC {
3653                                         amount_msat: Readable::read(reader)?,
3654                                         cltv_expiry: Readable::read(reader)?,
3655                                         payment_hash: Readable::read(reader)?,
3656                                         source: Readable::read(reader)?,
3657                                         onion_routing_packet: Readable::read(reader)?,
3658                                         time_created: Instant::now(),
3659                                 },
3660                                 1 => HTLCUpdateAwaitingACK::ClaimHTLC {
3661                                         payment_preimage: Readable::read(reader)?,
3662                                         htlc_id: Readable::read(reader)?,
3663                                 },
3664                                 2 => HTLCUpdateAwaitingACK::FailHTLC {
3665                                         htlc_id: Readable::read(reader)?,
3666                                         err_packet: Readable::read(reader)?,
3667                                 },
3668                                 _ => return Err(DecodeError::InvalidValue),
3669                         });
3670                 }
3671
3672                 let monitor_pending_revoke_and_ack = Readable::read(reader)?;
3673                 let monitor_pending_commitment_signed = Readable::read(reader)?;
3674
3675                 let monitor_pending_order = match <u8 as Readable<R>>::read(reader)? {
3676                         0 => None,
3677                         1 => Some(RAACommitmentOrder::CommitmentFirst),
3678                         2 => Some(RAACommitmentOrder::RevokeAndACKFirst),
3679                         _ => return Err(DecodeError::InvalidValue),
3680                 };
3681
3682                 let monitor_pending_forwards_count: u64 = Readable::read(reader)?;
3683                 let mut monitor_pending_forwards = Vec::with_capacity(cmp::min(monitor_pending_forwards_count as usize, OUR_MAX_HTLCS as usize));
3684                 for _ in 0..monitor_pending_forwards_count {
3685                         monitor_pending_forwards.push((Readable::read(reader)?, Readable::read(reader)?));
3686                 }
3687
3688                 let monitor_pending_failures_count: u64 = Readable::read(reader)?;
3689                 let mut monitor_pending_failures = Vec::with_capacity(cmp::min(monitor_pending_failures_count as usize, OUR_MAX_HTLCS as usize));
3690                 for _ in 0..monitor_pending_failures_count {
3691                         monitor_pending_failures.push((Readable::read(reader)?, Readable::read(reader)?, Readable::read(reader)?));
3692                 }
3693
3694                 let pending_update_fee = read_option!();
3695                 let holding_cell_update_fee = read_option!();
3696
3697                 let next_local_htlc_id = Readable::read(reader)?;
3698                 let next_remote_htlc_id = Readable::read(reader)?;
3699                 let channel_update_count = Readable::read(reader)?;
3700                 let feerate_per_kw = Readable::read(reader)?;
3701
3702                 let last_local_commitment_txn_count: u64 = Readable::read(reader)?;
3703                 let mut last_local_commitment_txn = Vec::with_capacity(cmp::min(last_local_commitment_txn_count as usize, OUR_MAX_HTLCS as usize*2 + 1));
3704                 for _ in 0..last_local_commitment_txn_count {
3705                         last_local_commitment_txn.push(match Transaction::consensus_decode(reader.by_ref()) {
3706                                 Ok(tx) => tx,
3707                                 Err(_) => return Err(DecodeError::InvalidValue),
3708                         });
3709                 }
3710
3711                 let last_sent_closing_fee = match <u8 as Readable<R>>::read(reader)? {
3712                         0 => None,
3713                         1 => Some((Readable::read(reader)?, Readable::read(reader)?)),
3714                         _ => return Err(DecodeError::InvalidValue),
3715                 };
3716
3717                 let funding_tx_confirmed_in = read_option!();
3718                 let short_channel_id = read_option!();
3719
3720                 let last_block_connected = Readable::read(reader)?;
3721                 let funding_tx_confirmations = Readable::read(reader)?;
3722
3723                 let their_dust_limit_satoshis = Readable::read(reader)?;
3724                 let our_dust_limit_satoshis = Readable::read(reader)?;
3725                 let their_max_htlc_value_in_flight_msat = Readable::read(reader)?;
3726                 let their_channel_reserve_satoshis = Readable::read(reader)?;
3727                 let their_htlc_minimum_msat = Readable::read(reader)?;
3728                 let our_htlc_minimum_msat = Readable::read(reader)?;
3729                 let their_to_self_delay = Readable::read(reader)?;
3730                 let their_max_accepted_htlcs = Readable::read(reader)?;
3731                 let minimum_depth = Readable::read(reader)?;
3732
3733                 let their_funding_pubkey = read_option!();
3734                 let their_revocation_basepoint = read_option!();
3735                 let their_payment_basepoint = read_option!();
3736                 let their_delayed_payment_basepoint = read_option!();
3737                 let their_htlc_basepoint = read_option!();
3738                 let their_cur_commitment_point = read_option!();
3739
3740                 let their_prev_commitment_point = read_option!();
3741                 let their_node_id = Readable::read(reader)?;
3742
3743                 let their_shutdown_scriptpubkey = read_option!();
3744                 let (monitor_last_block, channel_monitor) = ReadableArgs::read(reader, logger.clone())?;
3745                 // We drop the ChannelMonitor's last block connected hash cause we don't actually bother
3746                 // doing full block connection operations on the internal CHannelMonitor copies
3747                 if monitor_last_block != last_block_connected {
3748                         return Err(DecodeError::InvalidValue);
3749                 }
3750
3751                 Ok(Channel {
3752                         user_id,
3753
3754                         config,
3755                         channel_id,
3756                         channel_state,
3757                         channel_outbound,
3758                         secp_ctx: Secp256k1::new(),
3759                         channel_value_satoshis,
3760
3761                         local_keys,
3762                         shutdown_pubkey,
3763
3764                         cur_local_commitment_transaction_number,
3765                         cur_remote_commitment_transaction_number,
3766                         value_to_self_msat,
3767
3768                         received_commitment_while_awaiting_raa,
3769                         pending_inbound_htlcs,
3770                         pending_outbound_htlcs,
3771                         holding_cell_htlc_updates,
3772
3773                         monitor_pending_revoke_and_ack,
3774                         monitor_pending_commitment_signed,
3775                         monitor_pending_order,
3776                         monitor_pending_forwards,
3777                         monitor_pending_failures,
3778
3779                         pending_update_fee,
3780                         holding_cell_update_fee,
3781                         next_local_htlc_id,
3782                         next_remote_htlc_id,
3783                         channel_update_count,
3784                         feerate_per_kw,
3785
3786                         #[cfg(debug_assertions)]
3787                         max_commitment_tx_output_local: ::std::sync::Mutex::new((0, 0)),
3788                         #[cfg(debug_assertions)]
3789                         max_commitment_tx_output_remote: ::std::sync::Mutex::new((0, 0)),
3790
3791                         last_local_commitment_txn,
3792
3793                         last_sent_closing_fee,
3794
3795                         funding_tx_confirmed_in,
3796                         short_channel_id,
3797                         last_block_connected,
3798                         funding_tx_confirmations,
3799
3800                         their_dust_limit_satoshis,
3801                         our_dust_limit_satoshis,
3802                         their_max_htlc_value_in_flight_msat,
3803                         their_channel_reserve_satoshis,
3804                         their_htlc_minimum_msat,
3805                         our_htlc_minimum_msat,
3806                         their_to_self_delay,
3807                         their_max_accepted_htlcs,
3808                         minimum_depth,
3809
3810                         their_funding_pubkey,
3811                         their_revocation_basepoint,
3812                         their_payment_basepoint,
3813                         their_delayed_payment_basepoint,
3814                         their_htlc_basepoint,
3815                         their_cur_commitment_point,
3816
3817                         their_prev_commitment_point,
3818                         their_node_id,
3819
3820                         their_shutdown_scriptpubkey,
3821
3822                         channel_monitor,
3823
3824                         logger,
3825                 })
3826         }
3827 }
3828
3829 #[cfg(test)]
3830 mod tests {
3831         use bitcoin::util::hash::{Sha256dHash, Hash160};
3832         use bitcoin::util::bip143;
3833         use bitcoin::consensus::encode::serialize;
3834         use bitcoin::blockdata::script::{Script, Builder};
3835         use bitcoin::blockdata::transaction::Transaction;
3836         use bitcoin::blockdata::opcodes;
3837         use hex;
3838         use ln::channelmanager::HTLCSource;
3839         use ln::channel::{Channel,ChannelKeys,InboundHTLCOutput,OutboundHTLCOutput,InboundHTLCState,OutboundHTLCState,HTLCOutputInCommitment,TxCreationKeys};
3840         use ln::channel::MAX_FUNDING_SATOSHIS;
3841         use ln::chan_utils;
3842         use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
3843         use chain::keysinterface::KeysInterface;
3844         use chain::transaction::OutPoint;
3845         use util::config::UserConfig;
3846         use util::test_utils;
3847         use util::logger::Logger;
3848         use secp256k1::{Secp256k1,Message,Signature};
3849         use secp256k1::key::{SecretKey,PublicKey};
3850         use crypto::sha2::Sha256;
3851         use crypto::digest::Digest;
3852         use std::sync::Arc;
3853
3854         struct TestFeeEstimator {
3855                 fee_est: u64
3856         }
3857         impl FeeEstimator for TestFeeEstimator {
3858                 fn get_est_sat_per_1000_weight(&self, _: ConfirmationTarget) -> u64 {
3859                         self.fee_est
3860                 }
3861         }
3862
3863         #[test]
3864         fn test_max_funding_satoshis() {
3865                 assert!(MAX_FUNDING_SATOSHIS <= 21_000_000 * 100_000_000,
3866                         "MAX_FUNDING_SATOSHIS is greater than all satoshis on existence");
3867         }
3868
3869         struct Keys {
3870                 chan_keys: ChannelKeys,
3871         }
3872         impl KeysInterface for Keys {
3873                 fn get_node_secret(&self) -> SecretKey { panic!(); }
3874                 fn get_destination_script(&self) -> Script {
3875                         let secp_ctx = Secp256k1::signing_only();
3876                         let channel_monitor_claim_key = SecretKey::from_slice(&secp_ctx, &hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
3877                         let our_channel_monitor_claim_key_hash = Hash160::from_data(&PublicKey::from_secret_key(&secp_ctx, &channel_monitor_claim_key).serialize());
3878                         Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&our_channel_monitor_claim_key_hash[..]).into_script()
3879                 }
3880
3881                 fn get_shutdown_pubkey(&self) -> PublicKey {
3882                         let secp_ctx = Secp256k1::signing_only();
3883                         let channel_close_key = SecretKey::from_slice(&secp_ctx, &hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
3884                         PublicKey::from_secret_key(&secp_ctx, &channel_close_key)
3885                 }
3886
3887                 fn get_channel_keys(&self, _inbound: bool) -> ChannelKeys { self.chan_keys.clone() }
3888         }
3889
3890         #[test]
3891         fn outbound_commitment_test() {
3892                 // Test vectors from BOLT 3 Appendix C:
3893                 let feeest = TestFeeEstimator{fee_est: 15000};
3894                 let logger : Arc<Logger> = Arc::new(test_utils::TestLogger::new());
3895                 let secp_ctx = Secp256k1::new();
3896
3897                 let chan_keys = ChannelKeys {
3898                         funding_key: SecretKey::from_slice(&secp_ctx, &hex::decode("30ff4956bbdd3222d44cc5e8a1261dab1e07957bdac5ae88fe3261ef321f3749").unwrap()[..]).unwrap(),
3899                         payment_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
3900                         delayed_payment_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("3333333333333333333333333333333333333333333333333333333333333333").unwrap()[..]).unwrap(),
3901                         htlc_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
3902
3903                         // These aren't set in the test vectors:
3904                         revocation_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
3905                         commitment_seed: [0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff],
3906                 };
3907                 assert_eq!(PublicKey::from_secret_key(&secp_ctx, &chan_keys.funding_key).serialize()[..],
3908                                 hex::decode("023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb").unwrap()[..]);
3909                 let keys_provider: Arc<KeysInterface> = Arc::new(Keys { chan_keys });
3910
3911                 let their_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &[42; 32]).unwrap());
3912                 let mut config = UserConfig::new();
3913                 config.channel_options.announced_channel = false;
3914                 let mut chan = Channel::new_outbound(&feeest, &keys_provider, their_node_id, 10000000, 100000, 42, Arc::clone(&logger), &config).unwrap(); // Nothing uses their network key in this test
3915                 chan.their_to_self_delay = 144;
3916                 chan.our_dust_limit_satoshis = 546;
3917
3918                 let funding_info = OutPoint::new(Sha256dHash::from_hex("8984484a580b825b9972d7adb15050b3ab624ccd731946b3eeddb92f4e7ef6be").unwrap(), 0);
3919                 chan.channel_monitor.set_funding_info((funding_info, Script::new()));
3920
3921                 chan.their_payment_basepoint = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex::decode("4444444444444444444444444444444444444444444444444444444444444444").unwrap()[..]).unwrap()));
3922                 assert_eq!(chan.their_payment_basepoint.unwrap().serialize()[..],
3923                                 hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
3924
3925                 chan.their_funding_pubkey = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex::decode("1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13").unwrap()[..]).unwrap()));
3926                 assert_eq!(chan.their_funding_pubkey.unwrap().serialize()[..],
3927                                 hex::decode("030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c1").unwrap()[..]);
3928
3929                 chan.their_htlc_basepoint = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex::decode("4444444444444444444444444444444444444444444444444444444444444444").unwrap()[..]).unwrap()));
3930                 assert_eq!(chan.their_htlc_basepoint.unwrap().serialize()[..],
3931                                 hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
3932
3933                 chan.their_revocation_basepoint = Some(PublicKey::from_slice(&secp_ctx, &hex::decode("02466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27").unwrap()[..]).unwrap());
3934
3935                 // We can't just use build_local_transaction_keys here as the per_commitment_secret is not
3936                 // derived from a commitment_seed, so instead we copy it here and call
3937                 // build_commitment_transaction.
3938                 let delayed_payment_base = PublicKey::from_secret_key(&secp_ctx, &chan.local_keys.delayed_payment_base_key);
3939                 let per_commitment_secret = SecretKey::from_slice(&secp_ctx, &hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
3940                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
3941                 let htlc_basepoint = PublicKey::from_secret_key(&secp_ctx, &chan.local_keys.htlc_base_key);
3942                 let keys = TxCreationKeys::new(&secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &chan.their_revocation_basepoint.unwrap(), &chan.their_payment_basepoint.unwrap(), &chan.their_htlc_basepoint.unwrap()).unwrap();
3943
3944                 let mut unsigned_tx: (Transaction, Vec<HTLCOutputInCommitment>);
3945
3946                 macro_rules! test_commitment {
3947                         ( $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr) => {
3948                                 unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw);
3949                                 let their_signature = Signature::from_der(&secp_ctx, &hex::decode($their_sig_hex).unwrap()[..]).unwrap();
3950                                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&unsigned_tx.0).sighash_all(&unsigned_tx.0.input[0], &chan.get_funding_redeemscript(), chan.channel_value_satoshis)[..]).unwrap();
3951                                 secp_ctx.verify(&sighash, &their_signature, &chan.their_funding_pubkey.unwrap()).unwrap();
3952
3953                                 chan.sign_commitment_transaction(&mut unsigned_tx.0, &their_signature);
3954
3955                                 assert_eq!(serialize(&unsigned_tx.0)[..],
3956                                                 hex::decode($tx_hex).unwrap()[..]);
3957                         };
3958                 }
3959
3960                 macro_rules! test_htlc_output {
3961                         ( $htlc_idx: expr, $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr ) => {
3962                                 let remote_signature = Signature::from_der(&secp_ctx, &hex::decode($their_sig_hex).unwrap()[..]).unwrap();
3963
3964                                 let ref htlc = unsigned_tx.1[$htlc_idx];
3965                                 let mut htlc_tx = chan.build_htlc_transaction(&unsigned_tx.0.txid(), &htlc, true, &keys, chan.feerate_per_kw);
3966                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys);
3967                                 let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
3968                                 secp_ctx.verify(&htlc_sighash, &remote_signature, &keys.b_htlc_key).unwrap();
3969
3970                                 let mut preimage: Option<[u8; 32]> = None;
3971                                 if !htlc.offered {
3972                                         for i in 0..5 {
3973                                                 let mut sha = Sha256::new();
3974                                                 sha.input(&[i; 32]);
3975
3976                                                 let mut out = [0; 32];
3977                                                 sha.result(&mut out);
3978
3979                                                 if out == htlc.payment_hash {
3980                                                         preimage = Some([i; 32]);
3981                                                 }
3982                                         }
3983
3984                                         assert!(preimage.is_some());
3985                                 }
3986
3987                                 chan.sign_htlc_transaction(&mut htlc_tx, &remote_signature, &preimage, &htlc, &keys).unwrap();
3988                                 assert_eq!(serialize(&htlc_tx)[..],
3989                                                 hex::decode($tx_hex).unwrap()[..]);
3990                         };
3991                 }
3992
3993                 {
3994                         // simple commitment tx with no HTLCs
3995                         chan.value_to_self_msat = 7000000000;
3996
3997                         test_commitment!("3045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c0",
3998                                          "3044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c3836939",
3999                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311054a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c383693901483045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4000                 }
4001
4002                 chan.pending_inbound_htlcs.push({
4003                         let mut out = InboundHTLCOutput{
4004                                 htlc_id: 0,
4005                                 amount_msat: 1000000,
4006                                 cltv_expiry: 500,
4007                                 payment_hash: [0; 32],
4008                                 state: InboundHTLCState::Committed,
4009                         };
4010                         let mut sha = Sha256::new();
4011                         sha.input(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
4012                         sha.result(&mut out.payment_hash);
4013                         out
4014                 });
4015                 chan.pending_inbound_htlcs.push({
4016                         let mut out = InboundHTLCOutput{
4017                                 htlc_id: 1,
4018                                 amount_msat: 2000000,
4019                                 cltv_expiry: 501,
4020                                 payment_hash: [0; 32],
4021                                 state: InboundHTLCState::Committed,
4022                         };
4023                         let mut sha = Sha256::new();
4024                         sha.input(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
4025                         sha.result(&mut out.payment_hash);
4026                         out
4027                 });
4028                 chan.pending_outbound_htlcs.push({
4029                         let mut out = OutboundHTLCOutput{
4030                                 htlc_id: 2,
4031                                 amount_msat: 2000000,
4032                                 cltv_expiry: 502,
4033                                 payment_hash: [0; 32],
4034                                 state: OutboundHTLCState::Committed,
4035                                 source: HTLCSource::dummy(),
4036                                 fail_reason: None,
4037                         };
4038                         let mut sha = Sha256::new();
4039                         sha.input(&hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap());
4040                         sha.result(&mut out.payment_hash);
4041                         out
4042                 });
4043                 chan.pending_outbound_htlcs.push({
4044                         let mut out = OutboundHTLCOutput{
4045                                 htlc_id: 3,
4046                                 amount_msat: 3000000,
4047                                 cltv_expiry: 503,
4048                                 payment_hash: [0; 32],
4049                                 state: OutboundHTLCState::Committed,
4050                                 source: HTLCSource::dummy(),
4051                                 fail_reason: None,
4052                         };
4053                         let mut sha = Sha256::new();
4054                         sha.input(&hex::decode("0303030303030303030303030303030303030303030303030303030303030303").unwrap());
4055                         sha.result(&mut out.payment_hash);
4056                         out
4057                 });
4058                 chan.pending_inbound_htlcs.push({
4059                         let mut out = InboundHTLCOutput{
4060                                 htlc_id: 4,
4061                                 amount_msat: 4000000,
4062                                 cltv_expiry: 504,
4063                                 payment_hash: [0; 32],
4064                                 state: InboundHTLCState::Committed,
4065                         };
4066                         let mut sha = Sha256::new();
4067                         sha.input(&hex::decode("0404040404040404040404040404040404040404040404040404040404040404").unwrap());
4068                         sha.result(&mut out.payment_hash);
4069                         out
4070                 });
4071
4072                 {
4073                         // commitment tx with all five HTLCs untrimmed (minimum feerate)
4074                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4075                         chan.feerate_per_kw = 0;
4076
4077                         test_commitment!("304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b70606",
4078                                          "30440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f06",
4079                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f060147304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b7060601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4080
4081                         assert_eq!(unsigned_tx.1.len(), 5);
4082
4083                         test_htlc_output!(0,
4084                                           "304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a6",
4085                                           "304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5",
4086                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219700000000000000000001e8030000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a60147304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
4087
4088                         test_htlc_output!(1,
4089                                           "3045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b",
4090                                           "3045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be5",
4091                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219701000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b01483045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4092
4093                         test_htlc_output!(2,
4094                                           "304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f202",
4095                                           "3045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da",
4096                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219702000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f20201483045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4097
4098                         test_htlc_output!(3,
4099                                           "3045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554",
4100                                           "30440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac08727",
4101                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219703000000000000000001b80b0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554014730440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac0872701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4102
4103                         test_htlc_output!(4,
4104                                           "304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d",
4105                                           "30440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e",
4106                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219704000000000000000001a00f0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d014730440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4107                 }
4108
4109                 {
4110                         // commitment tx with seven outputs untrimmed (maximum feerate)
4111                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4112                         chan.feerate_per_kw = 647;
4113
4114                         test_commitment!("3045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b",
4115                                          "304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d1163",
4116                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040048304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d116301483045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4117
4118                         assert_eq!(unsigned_tx.1.len(), 5);
4119
4120                         test_htlc_output!(0,
4121                                           "30440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab343740",
4122                                           "304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a",
4123                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab3437400147304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
4124
4125                         test_htlc_output!(1,
4126                                           "304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b0",
4127                                           "304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac",
4128                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60100000000000000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b00147304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4129
4130                         test_htlc_output!(2,
4131                                           "304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d833",
4132                                           "3045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877",
4133                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6020000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d83301483045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4134
4135                         test_htlc_output!(3,
4136                                           "30450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d",
4137                                           "3045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb",
4138                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6030000000000000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d01483045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4139
4140                         test_htlc_output!(4,
4141                                           "3045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f0",
4142                                           "304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f",
4143                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb604000000000000000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f00147304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4144                 }
4145
4146                 {
4147                         // commitment tx with six outputs untrimmed (minimum feerate)
4148                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4149                         chan.feerate_per_kw = 648;
4150
4151                         test_commitment!("3044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b057",
4152                                          "3045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de",
4153                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431104e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de01473044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b05701475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4154
4155                         assert_eq!(unsigned_tx.1.len(), 4);
4156
4157                         test_htlc_output!(0,
4158                                           "3044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada8",
4159                                           "3045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc098",
4160                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10000000000000000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada801483045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc09801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4161
4162                         test_htlc_output!(1,
4163                                           "3045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d4",
4164                                           "304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0",
4165                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10100000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d40147304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4166
4167                         test_htlc_output!(2,
4168                                           "3045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c2",
4169                                           "304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda3",
4170                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd1020000000000000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c20147304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda301008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4171
4172                         test_htlc_output!(3,
4173                                           "3044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f",
4174                                           "304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6",
4175                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd103000000000000000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f0147304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4176                 }
4177
4178                 {
4179                         // commitment tx with six outputs untrimmed (maximum feerate)
4180                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4181                         chan.feerate_per_kw = 2069;
4182
4183                         test_commitment!("3044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb4",
4184                                          "304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea",
4185                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311077956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea01473044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4186
4187                         assert_eq!(unsigned_tx.1.len(), 4);
4188
4189                         test_htlc_output!(0,
4190                                           "3045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f992",
4191                                           "3044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae66402",
4192                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0000000000000000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f99201473044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae6640201008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4193
4194                         test_htlc_output!(1,
4195                                           "3045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f4",
4196                                           "3045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f",
4197                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0100000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f401483045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4198
4199                         test_htlc_output!(2,
4200                                           "3045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef18",
4201                                           "304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f9",
4202                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a020000000000000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef180147304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f901008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4203
4204                         test_htlc_output!(3,
4205                                           "30450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c",
4206                                           "304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5",
4207                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a03000000000000000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c0147304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4208                 }
4209
4210                 {
4211                         // commitment tx with five outputs untrimmed (minimum feerate)
4212                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4213                         chan.feerate_per_kw = 2070;
4214
4215                         test_commitment!("3045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f37526",
4216                                          "30440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd0",
4217                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd001483045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f3752601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4218
4219                         assert_eq!(unsigned_tx.1.len(), 3);
4220
4221                         test_htlc_output!(0,
4222                                           "3045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f891",
4223                                           "3045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb8",
4224                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a2180000000000000000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f89101483045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4225
4226                         test_htlc_output!(1,
4227                                           "3044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf6",
4228                                           "3045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d",
4229                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a218010000000000000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf601483045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4230
4231                         test_htlc_output!(2,
4232                                           "3045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a4",
4233                                           "304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04",
4234                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a21802000000000000000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a40147304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4235                 }
4236
4237                 {
4238                         // commitment tx with five outputs untrimmed (maximum feerate)
4239                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4240                         chan.feerate_per_kw = 2194;
4241
4242                         test_commitment!("3045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec86203953348",
4243                                          "304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f7061",
4244                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311040966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f706101483045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec8620395334801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4245
4246                         assert_eq!(unsigned_tx.1.len(), 3);
4247
4248                         test_htlc_output!(0,
4249                                           "30450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf44",
4250                                           "3044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f",
4251                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf4401473044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4252
4253                         test_htlc_output!(1,
4254                                           "30440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d",
4255                                           "304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c915",
4256                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a010000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d0147304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c91501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4257
4258                         test_htlc_output!(2,
4259                                           "3045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a",
4260                                           "3045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0",
4261                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a020000000000000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a01483045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4262                 }
4263
4264                 {
4265                         // commitment tx with four outputs untrimmed (minimum feerate)
4266                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4267                         chan.feerate_per_kw = 2195;
4268
4269                         test_commitment!("304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb7924298",
4270                                          "304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a5429",
4271                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a54290147304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb792429801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4272
4273                         assert_eq!(unsigned_tx.1.len(), 2);
4274
4275                         test_htlc_output!(0,
4276                                           "3045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc",
4277                                           "3045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc704390",
4278                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0000000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc01483045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc70439001008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4279
4280                         test_htlc_output!(1,
4281                                           "3045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92",
4282                                           "30440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8",
4283                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0100000000000000000199090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92014730440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4284                 }
4285
4286                 {
4287                         // commitment tx with four outputs untrimmed (maximum feerate)
4288                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4289                         chan.feerate_per_kw = 3702;
4290
4291                         test_commitment!("3045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c1",
4292                                          "304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b0",
4293                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431106f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b001483045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c101475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4294
4295                         assert_eq!(unsigned_tx.1.len(), 2);
4296
4297                         test_htlc_output!(0,
4298                                           "3045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb",
4299                                           "304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a",
4300                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb0147304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4301
4302                         test_htlc_output!(1,
4303                                           "3045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9",
4304                                           "30440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c",
4305                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30100000000000000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9014730440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4306                 }
4307
4308                 {
4309                         // commitment tx with three outputs untrimmed (minimum feerate)
4310                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4311                         chan.feerate_per_kw = 3703;
4312
4313                         test_commitment!("30450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb0",
4314                                          "3044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506",
4315                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506014830450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4316
4317                         assert_eq!(unsigned_tx.1.len(), 1);
4318
4319                         test_htlc_output!(0,
4320                                           "3044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd",
4321                                           "3045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724",
4322                                           "020000000001011c076aa7fb3d7460d10df69432c904227ea84bbf3134d4ceee5fb0f135ef206d0000000000000000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd01483045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4323                 }
4324
4325                 {
4326                         // commitment tx with three outputs untrimmed (maximum feerate)
4327                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4328                         chan.feerate_per_kw = 4914;
4329
4330                         test_commitment!("304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e",
4331                                          "304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe26",
4332                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe260147304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4333
4334                         assert_eq!(unsigned_tx.1.len(), 1);
4335
4336                         test_htlc_output!(0,
4337                                           "3045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf",
4338                                           "304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68",
4339                                           "0200000000010110a3fdcbcd5db477cd3ad465e7f501ffa8c437e8301f00a6061138590add757f0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf0148304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4340                 }
4341
4342                 {
4343                         // commitment tx with two outputs untrimmed (minimum feerate)
4344                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4345                         chan.feerate_per_kw = 4915;
4346
4347                         test_commitment!("304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f8765552",
4348                                          "3045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b9",
4349                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b90147304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f876555201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4350
4351                         assert_eq!(unsigned_tx.1.len(), 0);
4352                 }
4353
4354                 {
4355                         // commitment tx with two outputs untrimmed (maximum feerate)
4356                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4357                         chan.feerate_per_kw = 9651180;
4358
4359                         test_commitment!("3044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd",
4360                                          "30440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b9",
4361                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311004004730440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b901473044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4362
4363                         assert_eq!(unsigned_tx.1.len(), 0);
4364                 }
4365
4366                 {
4367                         // commitment tx with one output untrimmed (minimum feerate)
4368                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4369                         chan.feerate_per_kw = 9651181;
4370
4371                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
4372                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
4373                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4374
4375                         assert_eq!(unsigned_tx.1.len(), 0);
4376                 }
4377
4378                 {
4379                         // commitment tx with fee greater than funder amount
4380                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4381                         chan.feerate_per_kw = 9651936;
4382
4383                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
4384                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
4385                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4386
4387                         assert_eq!(unsigned_tx.1.len(), 0);
4388                 }
4389         }
4390
4391         #[test]
4392         fn test_per_commitment_secret_gen() {
4393                 // Test vectors from BOLT 3 Appendix D:
4394
4395                 let mut seed = [0; 32];
4396                 seed[0..32].clone_from_slice(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
4397                 assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655),
4398                            hex::decode("02a40c85b6f28da08dfdbe0926c53fab2de6d28c10301f8f7c4073d5e42e3148").unwrap()[..]);
4399
4400                 seed[0..32].clone_from_slice(&hex::decode("FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF").unwrap());
4401                 assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655),
4402                            hex::decode("7cc854b54e3e0dcdb010d7a3fee464a9687be6e8db3be6854c475621e007a5dc").unwrap()[..]);
4403
4404                 assert_eq!(chan_utils::build_commitment_secret(seed, 0xaaaaaaaaaaa),
4405                            hex::decode("56f4008fb007ca9acf0e15b054d5c9fd12ee06cea347914ddbaed70d1c13a528").unwrap()[..]);
4406
4407                 assert_eq!(chan_utils::build_commitment_secret(seed, 0x555555555555),
4408                            hex::decode("9015daaeb06dba4ccc05b91b2f73bd54405f2be9f217fbacd3c5ac2e62327d31").unwrap()[..]);
4409
4410                 seed[0..32].clone_from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
4411                 assert_eq!(chan_utils::build_commitment_secret(seed, 1),
4412                            hex::decode("915c75942a26bb3a433a8ce2cb0427c29ec6c1775cfc78328b57f6ba7bfeaa9c").unwrap()[..]);
4413         }
4414
4415         #[test]
4416         fn test_key_derivation() {
4417                 // Test vectors from BOLT 3 Appendix E:
4418                 let secp_ctx = Secp256k1::new();
4419
4420                 let base_secret = SecretKey::from_slice(&secp_ctx, &hex::decode("000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f").unwrap()[..]).unwrap();
4421                 let per_commitment_secret = SecretKey::from_slice(&secp_ctx, &hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
4422
4423                 let base_point = PublicKey::from_secret_key(&secp_ctx, &base_secret);
4424                 assert_eq!(base_point.serialize()[..], hex::decode("036d6caac248af96f6afa7f904f550253a0f3ef3f5aa2fe6838a95b216691468e2").unwrap()[..]);
4425
4426                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
4427                 assert_eq!(per_commitment_point.serialize()[..], hex::decode("025f7117a78150fe2ef97db7cfc83bd57b2e2c0d0dd25eaf467a4a1c2a45ce1486").unwrap()[..]);
4428
4429                 assert_eq!(chan_utils::derive_public_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
4430                                 hex::decode("0235f2dbfaa89b57ec7b055afe29849ef7ddfeb1cefdb9ebdc43f5494984db29e5").unwrap()[..]);
4431
4432                 assert_eq!(chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &base_secret).unwrap(),
4433                                 SecretKey::from_slice(&secp_ctx, &hex::decode("cbced912d3b21bf196a766651e436aff192362621ce317704ea2f75d87e7be0f").unwrap()[..]).unwrap());
4434
4435                 assert_eq!(chan_utils::derive_public_revocation_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
4436                                 hex::decode("02916e326636d19c33f13e8c0c3a03dd157f332f3e99c317c141dd865eb01f8ff0").unwrap()[..]);
4437
4438                 assert_eq!(chan_utils::derive_private_revocation_key(&secp_ctx, &per_commitment_secret, &base_secret).unwrap(),
4439                                 SecretKey::from_slice(&secp_ctx, &hex::decode("d09ffff62ddb2297ab000cc85bcb4283fdeb6aa052affbc9dddcf33b61078110").unwrap()[..]).unwrap());
4440         }
4441 }