Return refs from build_commitment_transaction, removing clone()s
[rust-lightning] / src / ln / channel.rs
1 use bitcoin::blockdata::block::BlockHeader;
2 use bitcoin::blockdata::script::{Script,Builder};
3 use bitcoin::blockdata::transaction::{TxIn, TxOut, Transaction, SigHashType};
4 use bitcoin::blockdata::opcodes;
5 use bitcoin::util::hash::{BitcoinHash, Sha256dHash, Hash160};
6 use bitcoin::util::bip143;
7 use bitcoin::consensus::encode::{self, Encodable, Decodable};
8
9 use secp256k1::key::{PublicKey,SecretKey};
10 use secp256k1::{Secp256k1,Message,Signature};
11 use secp256k1;
12
13 use crypto::digest::Digest;
14
15 use ln::msgs;
16 use ln::msgs::DecodeError;
17 use ln::channelmonitor::ChannelMonitor;
18 use ln::channelmanager::{PendingHTLCStatus, HTLCSource, HTLCFailReason, HTLCFailureMsg, PendingForwardHTLCInfo, RAACommitmentOrder};
19 use ln::chan_utils::{TxCreationKeys,HTLCOutputInCommitment,HTLC_SUCCESS_TX_WEIGHT,HTLC_TIMEOUT_TX_WEIGHT};
20 use ln::chan_utils;
21 use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
22 use chain::transaction::OutPoint;
23 use chain::keysinterface::{ChannelKeys, KeysInterface};
24 use util::{transaction_utils,rng};
25 use util::ser::{Readable, ReadableArgs, Writeable, Writer, WriterWriteAdaptor};
26 use util::sha2::Sha256;
27 use util::logger::Logger;
28 use util::errors::APIError;
29 use util::config::{UserConfig,ChannelConfig};
30
31 use std;
32 use std::default::Default;
33 use std::{cmp,mem};
34 use std::time::Instant;
35 use std::sync::{Arc};
36
37 #[cfg(test)]
38 pub struct ChannelValueStat {
39         pub value_to_self_msat: u64,
40         pub channel_value_msat: u64,
41         pub channel_reserve_msat: u64,
42         pub pending_outbound_htlcs_amount_msat: u64,
43         pub pending_inbound_htlcs_amount_msat: u64,
44         pub holding_cell_outbound_amount_msat: u64,
45         pub their_max_htlc_value_in_flight_msat: u64, // outgoing
46 }
47
48 enum InboundHTLCRemovalReason {
49         FailRelay(msgs::OnionErrorPacket),
50         FailMalformed(([u8; 32], u16)),
51         Fulfill([u8; 32]),
52 }
53
54 enum InboundHTLCState {
55         /// Added by remote, to be included in next local commitment tx.
56         RemoteAnnounced(PendingHTLCStatus),
57         /// Included in a received commitment_signed message (implying we've revoke_and_ack'ed it), but
58         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
59         /// accept this HTLC. Implies AwaitingRemoteRevoke.
60         /// We also have not yet included this HTLC in a commitment_signed message, and are waiting on
61         /// a remote revoke_and_ack on a previous state before we can do so.
62         AwaitingRemoteRevokeToAnnounce(PendingHTLCStatus),
63         /// Included in a received commitment_signed message (implying we've revoke_and_ack'ed it), but
64         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
65         /// accept this HTLC. Implies AwaitingRemoteRevoke.
66         /// We have included this HTLC in our latest commitment_signed and are now just waiting on a
67         /// revoke_and_ack.
68         AwaitingAnnouncedRemoteRevoke(PendingHTLCStatus),
69         Committed,
70         /// Removed by us and a new commitment_signed was sent (if we were AwaitingRemoteRevoke when we
71         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
72         /// we'll drop it.
73         /// Note that we have to keep an eye on the HTLC until we've received a broadcastable
74         /// commitment transaction without it as otherwise we'll have to force-close the channel to
75         /// claim it before the timeout (obviously doesn't apply to revoked HTLCs that we can't claim
76         /// anyway). That said, ChannelMonitor does this for us (see
77         /// ChannelMonitor::would_broadcast_at_height) so we actually remove the HTLC from our own
78         /// local state before then, once we're sure that the next commitment_signed and
79         /// ChannelMonitor::provide_latest_local_commitment_tx_info will not include this HTLC.
80         LocalRemoved(InboundHTLCRemovalReason),
81 }
82
83 struct InboundHTLCOutput {
84         htlc_id: u64,
85         amount_msat: u64,
86         cltv_expiry: u32,
87         payment_hash: [u8; 32],
88         state: InboundHTLCState,
89 }
90
91 enum OutboundHTLCState {
92         /// Added by us and included in a commitment_signed (if we were AwaitingRemoteRevoke when we
93         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
94         /// we will promote to Committed (note that they may not accept it until the next time we
95         /// revoke, but we dont really care about that:
96         ///  * they've revoked, so worst case we can announce an old state and get our (option on)
97         ///    money back (though we wont), and,
98         ///  * we'll send them a revoke when they send a commitment_signed, and since only they're
99         ///    allowed to remove it, the "can only be removed once committed on both sides" requirement
100         ///    doesn't matter to us and its up to them to enforce it, worst-case they jump ahead but
101         ///    we'll never get out of sync).
102         /// Note that we Box the OnionPacket as its rather large and we don't want to blow up
103         /// OutboundHTLCOutput's size just for a temporary bit
104         LocalAnnounced(Box<msgs::OnionPacket>),
105         Committed,
106         /// Remote removed this (outbound) HTLC. We're waiting on their commitment_signed to finalize
107         /// the change (though they'll need to revoke before we fail the payment).
108         RemoteRemoved,
109         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
110         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
111         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
112         /// We also have not yet removed this HTLC in a commitment_signed message, and are waiting on a
113         /// remote revoke_and_ack on a previous state before we can do so.
114         AwaitingRemoteRevokeToRemove,
115         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
116         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
117         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
118         /// We have removed this HTLC in our latest commitment_signed and are now just waiting on a
119         /// revoke_and_ack to drop completely.
120         AwaitingRemovedRemoteRevoke,
121 }
122
123 struct OutboundHTLCOutput {
124         htlc_id: u64,
125         amount_msat: u64,
126         cltv_expiry: u32,
127         payment_hash: [u8; 32],
128         state: OutboundHTLCState,
129         source: HTLCSource,
130         /// If we're in a removed state, set if they failed, otherwise None
131         fail_reason: Option<HTLCFailReason>,
132 }
133
134 macro_rules! get_htlc_in_commitment {
135         ($htlc: expr, $offered: expr) => {
136                 HTLCOutputInCommitment {
137                         offered: $offered,
138                         amount_msat: $htlc.amount_msat,
139                         cltv_expiry: $htlc.cltv_expiry,
140                         payment_hash: $htlc.payment_hash,
141                         transaction_output_index: 0
142                 }
143         }
144 }
145
146 /// See AwaitingRemoteRevoke ChannelState for more info
147 enum HTLCUpdateAwaitingACK {
148         AddHTLC {
149                 // always outbound
150                 amount_msat: u64,
151                 cltv_expiry: u32,
152                 payment_hash: [u8; 32],
153                 source: HTLCSource,
154                 onion_routing_packet: msgs::OnionPacket,
155                 time_created: Instant, //TODO: Some kind of timeout thing-a-majig
156         },
157         ClaimHTLC {
158                 payment_preimage: [u8; 32],
159                 htlc_id: u64,
160         },
161         FailHTLC {
162                 htlc_id: u64,
163                 err_packet: msgs::OnionErrorPacket,
164         },
165 }
166
167 /// There are a few "states" and then a number of flags which can be applied:
168 /// We first move through init with OurInitSent -> TheirInitSent -> FundingCreated -> FundingSent.
169 /// TheirFundingLocked and OurFundingLocked then get set on FundingSent, and when both are set we
170 /// move on to ChannelFunded.
171 /// Note that PeerDisconnected can be set on both ChannelFunded and FundingSent.
172 /// ChannelFunded can then get all remaining flags set on it, until we finish shutdown, then we
173 /// move on to ShutdownComplete, at which point most calls into this channel are disallowed.
174 enum ChannelState {
175         /// Implies we have (or are prepared to) send our open_channel/accept_channel message
176         OurInitSent = (1 << 0),
177         /// Implies we have received their open_channel/accept_channel message
178         TheirInitSent = (1 << 1),
179         /// We have sent funding_created and are awaiting a funding_signed to advance to FundingSent.
180         /// Note that this is nonsense for an inbound channel as we immediately generate funding_signed
181         /// upon receipt of funding_created, so simply skip this state.
182         FundingCreated = 4,
183         /// Set when we have received/sent funding_created and funding_signed and are thus now waiting
184         /// on the funding transaction to confirm. The FundingLocked flags are set to indicate when we
185         /// and our counterparty consider the funding transaction confirmed.
186         FundingSent = 8,
187         /// Flag which can be set on FundingSent to indicate they sent us a funding_locked message.
188         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
189         TheirFundingLocked = (1 << 4),
190         /// Flag which can be set on FundingSent to indicate we sent them a funding_locked message.
191         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
192         OurFundingLocked = (1 << 5),
193         ChannelFunded = 64,
194         /// Flag which is set on ChannelFunded and FundingSent indicating remote side is considered
195         /// "disconnected" and no updates are allowed until after we've done a channel_reestablish
196         /// dance.
197         PeerDisconnected = (1 << 7),
198         /// Flag which is set on ChannelFunded and FundingSent indicating the user has told us they
199         /// failed to update our ChannelMonitor somewhere and we should pause sending any outbound
200         /// messages until they've managed to do so.
201         MonitorUpdateFailed = (1 << 8),
202         /// Flag which implies that we have sent a commitment_signed but are awaiting the responding
203         /// revoke_and_ack message. During this time period, we can't generate new commitment_signed
204         /// messages as then we will be unable to determine which HTLCs they included in their
205         /// revoke_and_ack implicit ACK, so instead we have to hold them away temporarily to be sent
206         /// later.
207         /// Flag is set on ChannelFunded.
208         AwaitingRemoteRevoke = (1 << 9),
209         /// Flag which is set on ChannelFunded or FundingSent after receiving a shutdown message from
210         /// the remote end. If set, they may not add any new HTLCs to the channel, and we are expected
211         /// to respond with our own shutdown message when possible.
212         RemoteShutdownSent = (1 << 10),
213         /// Flag which is set on ChannelFunded or FundingSent after sending a shutdown message. At this
214         /// point, we may not add any new HTLCs to the channel.
215         /// TODO: Investigate some kind of timeout mechanism by which point the remote end must provide
216         /// us their shutdown.
217         LocalShutdownSent = (1 << 11),
218         /// We've successfully negotiated a closing_signed dance. At this point ChannelManager is about
219         /// to drop us, but we store this anyway.
220         ShutdownComplete = 4096,
221 }
222 const BOTH_SIDES_SHUTDOWN_MASK: u32 = (ChannelState::LocalShutdownSent as u32 | ChannelState::RemoteShutdownSent as u32);
223 const MULTI_STATE_FLAGS: u32 = (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32);
224
225 const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
226
227 // TODO: We should refactor this to be an Inbound/OutboundChannel until initial setup handshaking
228 // has been completed, and then turn into a Channel to get compiler-time enforcement of things like
229 // calling channel_id() before we're set up or things like get_outbound_funding_signed on an
230 // inbound channel.
231 pub(super) struct Channel {
232         config: ChannelConfig,
233
234         user_id: u64,
235
236         channel_id: [u8; 32],
237         channel_state: u32,
238         channel_outbound: bool,
239         secp_ctx: Secp256k1<secp256k1::All>,
240         channel_value_satoshis: u64,
241
242         local_keys: ChannelKeys,
243         shutdown_pubkey: PublicKey,
244
245         // Our commitment numbers start at 2^48-1 and count down, whereas the ones used in transaction
246         // generation start at 0 and count up...this simplifies some parts of implementation at the
247         // cost of others, but should really just be changed.
248
249         cur_local_commitment_transaction_number: u64,
250         cur_remote_commitment_transaction_number: u64,
251         value_to_self_msat: u64, // Excluding all pending_htlcs, excluding fees
252         /// Upon receipt of a channel_reestablish we have to figure out whether to send a
253         /// revoke_and_ack first or a commitment update first. Generally, we prefer to send
254         /// revoke_and_ack first, but if we had a pending commitment update of our own waiting on a
255         /// remote revoke when we received the latest commitment update from the remote we have to make
256         /// sure that commitment update gets resent first.
257         received_commitment_while_awaiting_raa: bool,
258         pending_inbound_htlcs: Vec<InboundHTLCOutput>,
259         pending_outbound_htlcs: Vec<OutboundHTLCOutput>,
260         holding_cell_htlc_updates: Vec<HTLCUpdateAwaitingACK>,
261
262         monitor_pending_revoke_and_ack: bool,
263         monitor_pending_commitment_signed: bool,
264         monitor_pending_order: Option<RAACommitmentOrder>,
265         monitor_pending_forwards: Vec<(PendingForwardHTLCInfo, u64)>,
266         monitor_pending_failures: Vec<(HTLCSource, [u8; 32], HTLCFailReason)>,
267
268         // pending_update_fee is filled when sending and receiving update_fee
269         // For outbound channel, feerate_per_kw is updated with the value from
270         // pending_update_fee when revoke_and_ack is received
271         //
272         // For inbound channel, feerate_per_kw is updated when it receives
273         // commitment_signed and revoke_and_ack is generated
274         // The pending value is kept when another pair of update_fee and commitment_signed
275         // is received during AwaitingRemoteRevoke and relieved when the expected
276         // revoke_and_ack is received and new commitment_signed is generated to be
277         // sent to the funder. Otherwise, the pending value is removed when receiving
278         // commitment_signed.
279         pending_update_fee: Option<u64>,
280         // update_fee() during ChannelState::AwaitingRemoteRevoke is hold in
281         // holdina_cell_update_fee then moved to pending_udpate_fee when revoke_and_ack
282         // is received. holding_cell_update_fee is updated when there are additional
283         // update_fee() during ChannelState::AwaitingRemoteRevoke.
284         holding_cell_update_fee: Option<u64>,
285         next_local_htlc_id: u64,
286         next_remote_htlc_id: u64,
287         channel_update_count: u32,
288         feerate_per_kw: u64,
289
290         #[cfg(debug_assertions)]
291         /// Max to_local and to_remote outputs in a locally-generated commitment transaction
292         max_commitment_tx_output_local: ::std::sync::Mutex<(u64, u64)>,
293         #[cfg(debug_assertions)]
294         /// Max to_local and to_remote outputs in a remote-generated commitment transaction
295         max_commitment_tx_output_remote: ::std::sync::Mutex<(u64, u64)>,
296
297         #[cfg(test)]
298         // Used in ChannelManager's tests to send a revoked transaction
299         pub last_local_commitment_txn: Vec<Transaction>,
300         #[cfg(not(test))]
301         last_local_commitment_txn: Vec<Transaction>,
302
303         last_sent_closing_fee: Option<(u64, u64)>, // (feerate, fee)
304
305         /// The hash of the block in which the funding transaction reached our CONF_TARGET. We use this
306         /// to detect unconfirmation after a serialize-unserialize roudtrip where we may not see a full
307         /// series of block_connected/block_disconnected calls. Obviously this is not a guarantee as we
308         /// could miss the funding_tx_confirmed_in block as well, but it serves as a useful fallback.
309         funding_tx_confirmed_in: Option<Sha256dHash>,
310         short_channel_id: Option<u64>,
311         /// Used to deduplicate block_connected callbacks, also used to verify consistency during
312         /// ChannelManager deserialization (hence pub(super))
313         pub(super) last_block_connected: Sha256dHash,
314         funding_tx_confirmations: u64,
315
316         their_dust_limit_satoshis: u64,
317         our_dust_limit_satoshis: u64,
318         their_max_htlc_value_in_flight_msat: u64,
319         //get_our_max_htlc_value_in_flight_msat(): u64,
320         /// minimum channel reserve for **self** to maintain - set by them.
321         their_channel_reserve_satoshis: u64,
322         //get_our_channel_reserve_satoshis(): u64,
323         their_htlc_minimum_msat: u64,
324         our_htlc_minimum_msat: u64,
325         their_to_self_delay: u16,
326         //implied by BREAKDOWN_TIMEOUT: our_to_self_delay: u16,
327         their_max_accepted_htlcs: u16,
328         //implied by OUR_MAX_HTLCS: our_max_accepted_htlcs: u16,
329         minimum_depth: u32,
330
331         their_funding_pubkey: Option<PublicKey>,
332         their_revocation_basepoint: Option<PublicKey>,
333         their_payment_basepoint: Option<PublicKey>,
334         their_delayed_payment_basepoint: Option<PublicKey>,
335         their_htlc_basepoint: Option<PublicKey>,
336         their_cur_commitment_point: Option<PublicKey>,
337
338         their_prev_commitment_point: Option<PublicKey>,
339         their_node_id: PublicKey,
340
341         their_shutdown_scriptpubkey: Option<Script>,
342
343         channel_monitor: ChannelMonitor,
344
345         logger: Arc<Logger>,
346 }
347
348 const OUR_MAX_HTLCS: u16 = 5; //TODO
349 /// Confirmation count threshold at which we close a channel. Ideally we'd keep the channel around
350 /// on ice until the funding transaction gets more confirmations, but the LN protocol doesn't
351 /// really allow for this, so instead we're stuck closing it out at that point.
352 const UNCONF_THRESHOLD: u32 = 6;
353 /// The amount of time we require our counterparty wait to claim their money (ie time between when
354 /// we, or our watchtower, must check for them having broadcast a theft transaction).
355 const BREAKDOWN_TIMEOUT: u16 = 6 * 24 * 7; //TODO?
356 /// The amount of time we're willing to wait to claim money back to us
357 const MAX_LOCAL_BREAKDOWN_TIMEOUT: u16 = 6 * 24 * 14;
358 /// Exposing these two constants for use in test in ChannelMonitor
359 pub const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
360 pub const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
361 const SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT: u64 = 79; // prevout: 36, nSequence: 4, script len: 1, witness lengths: (3+1)/4, sig: 73/4, if-selector: 1, redeemScript: (6 ops + 2*33 pubkeys + 1*2 delay)/4
362 const B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT: u64 = 104; // prevout: 40, nSequence: 4, script len: 1, witness lengths: 3/4, sig: 73/4, pubkey: 33/4, output: 31 (TODO: Wrong? Useless?)
363 /// Maximmum `funding_satoshis` value, according to the BOLT #2 specification
364 /// it's 2^24.
365 pub const MAX_FUNDING_SATOSHIS: u64 = (1 << 24);
366
367 /// Used to return a simple Error back to ChannelManager. Will get converted to a
368 /// msgs::ErrorAction::SendErrorMessage or msgs::ErrorAction::IgnoreError as appropriate with our
369 /// channel_id in ChannelManager.
370 #[derive(Debug)]
371 pub(super) enum ChannelError {
372         Ignore(&'static str),
373         Close(&'static str),
374 }
375
376 macro_rules! secp_check {
377         ($res: expr, $err: expr) => {
378                 match $res {
379                         Ok(thing) => thing,
380                         Err(_) => return Err(ChannelError::Close($err)),
381                 }
382         };
383 }
384
385 impl Channel {
386         // Convert constants + channel value to limits:
387         fn get_our_max_htlc_value_in_flight_msat(channel_value_satoshis: u64) -> u64 {
388                 channel_value_satoshis * 1000 / 10 //TODO
389         }
390
391         /// Returns a minimum channel reserve value **they** need to maintain
392         ///
393         /// Guaranteed to return a value no larger than channel_value_satoshis
394         fn get_our_channel_reserve_satoshis(channel_value_satoshis: u64) -> u64 {
395                 let (q, _) = channel_value_satoshis.overflowing_div(100);
396                 cmp::min(channel_value_satoshis, cmp::max(q, 1000)) //TODO
397         }
398
399         fn derive_our_dust_limit_satoshis(at_open_background_feerate: u64) -> u64 {
400                 cmp::max(at_open_background_feerate * B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT / 1000, 546) //TODO
401         }
402
403         fn derive_our_htlc_minimum_msat(_at_open_channel_feerate_per_kw: u64) -> u64 {
404                 1000 // TODO
405         }
406
407         fn derive_minimum_depth(_channel_value_satoshis_msat: u64, _value_to_self_msat: u64) -> u32 {
408                 // Note that in order to comply with BOLT 7 announcement_signatures requirements this must
409                 // be at least 6.
410                 const CONF_TARGET: u32 = 12; //TODO: Should be much higher
411                 CONF_TARGET
412         }
413
414         // Constructors:
415         pub fn new_outbound(fee_estimator: &FeeEstimator, keys_provider: &Arc<KeysInterface>, their_node_id: PublicKey, channel_value_satoshis: u64, push_msat: u64, user_id: u64, logger: Arc<Logger>, config: &UserConfig) -> Result<Channel, APIError> {
416                 let chan_keys = keys_provider.get_channel_keys(false);
417
418                 if channel_value_satoshis >= MAX_FUNDING_SATOSHIS {
419                         return Err(APIError::APIMisuseError{err: "funding value > 2^24"});
420                 }
421
422                 if push_msat > channel_value_satoshis * 1000 {
423                         return Err(APIError::APIMisuseError{err: "push value > channel value"});
424                 }
425
426
427                 let background_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
428                 if Channel::get_our_channel_reserve_satoshis(channel_value_satoshis) < Channel::derive_our_dust_limit_satoshis(background_feerate) {
429                         return Err(APIError::FeeRateTooHigh{err: format!("Not enough reserve above dust limit can be found at current fee rate({})", background_feerate), feerate: background_feerate});
430                 }
431
432                 let feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
433
434                 let secp_ctx = Secp256k1::new();
435                 let channel_monitor = ChannelMonitor::new(&chan_keys.revocation_base_key, &chan_keys.delayed_payment_base_key,
436                                                           &chan_keys.htlc_base_key, &chan_keys.payment_base_key, &keys_provider.get_shutdown_pubkey(), BREAKDOWN_TIMEOUT,
437                                                           keys_provider.get_destination_script(), logger.clone());
438
439                 Ok(Channel {
440                         user_id: user_id,
441                         config: config.channel_options.clone(),
442
443                         channel_id: rng::rand_u832(),
444                         channel_state: ChannelState::OurInitSent as u32,
445                         channel_outbound: true,
446                         secp_ctx: secp_ctx,
447                         channel_value_satoshis: channel_value_satoshis,
448
449                         local_keys: chan_keys,
450                         shutdown_pubkey: keys_provider.get_shutdown_pubkey(),
451                         cur_local_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
452                         cur_remote_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
453                         value_to_self_msat: channel_value_satoshis * 1000 - push_msat,
454                         received_commitment_while_awaiting_raa: false,
455
456                         pending_inbound_htlcs: Vec::new(),
457                         pending_outbound_htlcs: Vec::new(),
458                         holding_cell_htlc_updates: Vec::new(),
459                         pending_update_fee: None,
460                         holding_cell_update_fee: None,
461                         next_local_htlc_id: 0,
462                         next_remote_htlc_id: 0,
463                         channel_update_count: 1,
464
465                         monitor_pending_revoke_and_ack: false,
466                         monitor_pending_commitment_signed: false,
467                         monitor_pending_order: None,
468                         monitor_pending_forwards: Vec::new(),
469                         monitor_pending_failures: Vec::new(),
470
471                         #[cfg(debug_assertions)]
472                         max_commitment_tx_output_local: ::std::sync::Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
473                         #[cfg(debug_assertions)]
474                         max_commitment_tx_output_remote: ::std::sync::Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
475
476                         last_local_commitment_txn: Vec::new(),
477
478                         last_sent_closing_fee: None,
479
480                         funding_tx_confirmed_in: None,
481                         short_channel_id: None,
482                         last_block_connected: Default::default(),
483                         funding_tx_confirmations: 0,
484
485                         feerate_per_kw: feerate,
486                         their_dust_limit_satoshis: 0,
487                         our_dust_limit_satoshis: Channel::derive_our_dust_limit_satoshis(background_feerate),
488                         their_max_htlc_value_in_flight_msat: 0,
489                         their_channel_reserve_satoshis: 0,
490                         their_htlc_minimum_msat: 0,
491                         our_htlc_minimum_msat: Channel::derive_our_htlc_minimum_msat(feerate),
492                         their_to_self_delay: 0,
493                         their_max_accepted_htlcs: 0,
494                         minimum_depth: 0, // Filled in in accept_channel
495
496                         their_funding_pubkey: None,
497                         their_revocation_basepoint: None,
498                         their_payment_basepoint: None,
499                         their_delayed_payment_basepoint: None,
500                         their_htlc_basepoint: None,
501                         their_cur_commitment_point: None,
502
503                         their_prev_commitment_point: None,
504                         their_node_id: their_node_id,
505
506                         their_shutdown_scriptpubkey: None,
507
508                         channel_monitor: channel_monitor,
509
510                         logger,
511                 })
512         }
513
514         fn check_remote_fee(fee_estimator: &FeeEstimator, feerate_per_kw: u32) -> Result<(), ChannelError> {
515                 if (feerate_per_kw as u64) < fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background) {
516                         return Err(ChannelError::Close("Peer's feerate much too low"));
517                 }
518                 if (feerate_per_kw as u64) > fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority) * 2 {
519                         return Err(ChannelError::Close("Peer's feerate much too high"));
520                 }
521                 Ok(())
522         }
523
524         /// Creates a new channel from a remote sides' request for one.
525         /// Assumes chain_hash has already been checked and corresponds with what we expect!
526         pub fn new_from_req(fee_estimator: &FeeEstimator, keys_provider: &Arc<KeysInterface>, their_node_id: PublicKey, msg: &msgs::OpenChannel, user_id: u64, logger: Arc<Logger>, config: &UserConfig) -> Result<Channel, ChannelError> {
527                 let chan_keys = keys_provider.get_channel_keys(true);
528                 let mut local_config = (*config).channel_options.clone();
529
530                 // Check sanity of message fields:
531                 if msg.funding_satoshis >= MAX_FUNDING_SATOSHIS {
532                         return Err(ChannelError::Close("funding value > 2^24"));
533                 }
534                 if msg.channel_reserve_satoshis > msg.funding_satoshis {
535                         return Err(ChannelError::Close("Bogus channel_reserve_satoshis"));
536                 }
537                 if msg.push_msat > (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
538                         return Err(ChannelError::Close("push_msat larger than funding value"));
539                 }
540                 if msg.dust_limit_satoshis > msg.funding_satoshis {
541                         return Err(ChannelError::Close("Peer never wants payout outputs?"));
542                 }
543                 if msg.dust_limit_satoshis > msg.channel_reserve_satoshis {
544                         return Err(ChannelError::Close("Bogus; channel reserve is less than dust limit"));
545                 }
546                 if msg.htlc_minimum_msat >= (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
547                         return Err(ChannelError::Close("Miminum htlc value is full channel value"));
548                 }
549                 Channel::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
550
551                 if msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
552                         return Err(ChannelError::Close("They wanted our payments to be delayed by a needlessly long period"));
553                 }
554                 if msg.max_accepted_htlcs < 1 {
555                         return Err(ChannelError::Close("0 max_accpted_htlcs makes for a useless channel"));
556                 }
557                 if msg.max_accepted_htlcs > 483 {
558                         return Err(ChannelError::Close("max_accpted_htlcs > 483"));
559                 }
560
561                 // Now check against optional parameters as set by config...
562                 if msg.funding_satoshis < config.channel_limits.min_funding_satoshis {
563                         return Err(ChannelError::Close("funding satoshis is less than the user specified limit"));
564                 }
565                 if msg.htlc_minimum_msat > config.channel_limits.max_htlc_minimum_msat {
566                         return Err(ChannelError::Close("htlc minimum msat is higher than the user specified limit"));
567                 }
568                 if msg.max_htlc_value_in_flight_msat < config.channel_limits.min_max_htlc_value_in_flight_msat {
569                         return Err(ChannelError::Close("max htlc value in flight msat is less than the user specified limit"));
570                 }
571                 if msg.channel_reserve_satoshis > config.channel_limits.max_channel_reserve_satoshis {
572                         return Err(ChannelError::Close("channel reserve satoshis is higher than the user specified limit"));
573                 }
574                 if msg.max_accepted_htlcs < config.channel_limits.min_max_accepted_htlcs {
575                         return Err(ChannelError::Close("max accepted htlcs is less than the user specified limit"));
576                 }
577                 if msg.dust_limit_satoshis < config.channel_limits.min_dust_limit_satoshis {
578                         return Err(ChannelError::Close("dust limit satoshis is less than the user specified limit"));
579                 }
580                 if msg.dust_limit_satoshis > config.channel_limits.max_dust_limit_satoshis {
581                         return Err(ChannelError::Close("dust limit satoshis is greater than the user specified limit"));
582                 }
583
584                 // Convert things into internal flags and prep our state:
585
586                 let their_announce = if (msg.channel_flags & 1) == 1 { true } else { false };
587                 if config.channel_limits.force_announced_channel_preference {
588                         if local_config.announced_channel != their_announce {
589                                 return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours"));
590                         }
591                 }
592                 // we either accept their preference or the preferences match
593                 local_config.announced_channel = their_announce;
594
595                 let background_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
596
597                 let our_dust_limit_satoshis = Channel::derive_our_dust_limit_satoshis(background_feerate);
598                 let our_channel_reserve_satoshis = Channel::get_our_channel_reserve_satoshis(msg.funding_satoshis);
599                 if our_channel_reserve_satoshis < our_dust_limit_satoshis {
600                         return Err(ChannelError::Close("Suitable channel reserve not found. aborting"));
601                 }
602                 if msg.channel_reserve_satoshis < our_dust_limit_satoshis {
603                         return Err(ChannelError::Close("channel_reserve_satoshis too small"));
604                 }
605                 if our_channel_reserve_satoshis < msg.dust_limit_satoshis {
606                         return Err(ChannelError::Close("Dust limit too high for our channel reserve"));
607                 }
608
609                 // check if the funder's amount for the initial commitment tx is sufficient
610                 // for full fee payment
611                 let funders_amount_msat = msg.funding_satoshis * 1000 - msg.push_msat;
612                 if funders_amount_msat < background_feerate * COMMITMENT_TX_BASE_WEIGHT {
613                         return Err(ChannelError::Close("Insufficient funding amount for initial commitment"));
614                 }
615
616                 let to_local_msat = msg.push_msat;
617                 let to_remote_msat = funders_amount_msat - background_feerate * COMMITMENT_TX_BASE_WEIGHT;
618                 if to_local_msat <= msg.channel_reserve_satoshis * 1000 && to_remote_msat <= our_channel_reserve_satoshis * 1000 {
619                         return Err(ChannelError::Close("Insufficient funding amount for initial commitment"));
620                 }
621
622                 let secp_ctx = Secp256k1::new();
623                 let mut channel_monitor = ChannelMonitor::new(&chan_keys.revocation_base_key, &chan_keys.delayed_payment_base_key,
624                                                               &chan_keys.htlc_base_key, &chan_keys.payment_base_key, &keys_provider.get_shutdown_pubkey(), BREAKDOWN_TIMEOUT,
625                                                               keys_provider.get_destination_script(), logger.clone());
626                 channel_monitor.set_their_base_keys(&msg.htlc_basepoint, &msg.delayed_payment_basepoint);
627                 channel_monitor.set_their_to_self_delay(msg.to_self_delay);
628
629                 let mut chan = Channel {
630                         user_id: user_id,
631                         config: local_config,
632
633                         channel_id: msg.temporary_channel_id,
634                         channel_state: (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32),
635                         channel_outbound: false,
636                         secp_ctx: secp_ctx,
637
638                         local_keys: chan_keys,
639                         shutdown_pubkey: keys_provider.get_shutdown_pubkey(),
640                         cur_local_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
641                         cur_remote_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
642                         value_to_self_msat: msg.push_msat,
643                         received_commitment_while_awaiting_raa: false,
644
645                         pending_inbound_htlcs: Vec::new(),
646                         pending_outbound_htlcs: Vec::new(),
647                         holding_cell_htlc_updates: Vec::new(),
648                         pending_update_fee: None,
649                         holding_cell_update_fee: None,
650                         next_local_htlc_id: 0,
651                         next_remote_htlc_id: 0,
652                         channel_update_count: 1,
653
654                         monitor_pending_revoke_and_ack: false,
655                         monitor_pending_commitment_signed: false,
656                         monitor_pending_order: None,
657                         monitor_pending_forwards: Vec::new(),
658                         monitor_pending_failures: Vec::new(),
659
660                         #[cfg(debug_assertions)]
661                         max_commitment_tx_output_local: ::std::sync::Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
662                         #[cfg(debug_assertions)]
663                         max_commitment_tx_output_remote: ::std::sync::Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
664
665                         last_local_commitment_txn: Vec::new(),
666
667                         last_sent_closing_fee: None,
668
669                         funding_tx_confirmed_in: None,
670                         short_channel_id: None,
671                         last_block_connected: Default::default(),
672                         funding_tx_confirmations: 0,
673
674                         feerate_per_kw: msg.feerate_per_kw as u64,
675                         channel_value_satoshis: msg.funding_satoshis,
676                         their_dust_limit_satoshis: msg.dust_limit_satoshis,
677                         our_dust_limit_satoshis: our_dust_limit_satoshis,
678                         their_max_htlc_value_in_flight_msat: cmp::min(msg.max_htlc_value_in_flight_msat, msg.funding_satoshis * 1000),
679                         their_channel_reserve_satoshis: msg.channel_reserve_satoshis,
680                         their_htlc_minimum_msat: msg.htlc_minimum_msat,
681                         our_htlc_minimum_msat: Channel::derive_our_htlc_minimum_msat(msg.feerate_per_kw as u64),
682                         their_to_self_delay: msg.to_self_delay,
683                         their_max_accepted_htlcs: msg.max_accepted_htlcs,
684                         minimum_depth: Channel::derive_minimum_depth(msg.funding_satoshis*1000, msg.push_msat),
685
686                         their_funding_pubkey: Some(msg.funding_pubkey),
687                         their_revocation_basepoint: Some(msg.revocation_basepoint),
688                         their_payment_basepoint: Some(msg.payment_basepoint),
689                         their_delayed_payment_basepoint: Some(msg.delayed_payment_basepoint),
690                         their_htlc_basepoint: Some(msg.htlc_basepoint),
691                         their_cur_commitment_point: Some(msg.first_per_commitment_point),
692
693                         their_prev_commitment_point: None,
694                         their_node_id: their_node_id,
695
696                         their_shutdown_scriptpubkey: None,
697
698                         channel_monitor: channel_monitor,
699
700                         logger,
701                 };
702
703                 let obscure_factor = chan.get_commitment_transaction_number_obscure_factor();
704                 chan.channel_monitor.set_commitment_obscure_factor(obscure_factor);
705
706                 Ok(chan)
707         }
708
709         // Utilities to derive keys:
710
711         fn build_local_commitment_secret(&self, idx: u64) -> SecretKey {
712                 let res = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, idx);
713                 SecretKey::from_slice(&self.secp_ctx, &res).unwrap()
714         }
715
716         // Utilities to build transactions:
717
718         fn get_commitment_transaction_number_obscure_factor(&self) -> u64 {
719                 let mut sha = Sha256::new();
720                 let our_payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key);
721
722                 if self.channel_outbound {
723                         sha.input(&our_payment_basepoint.serialize());
724                         sha.input(&self.their_payment_basepoint.unwrap().serialize());
725                 } else {
726                         sha.input(&self.their_payment_basepoint.unwrap().serialize());
727                         sha.input(&our_payment_basepoint.serialize());
728                 }
729                 let mut res = [0; 32];
730                 sha.result(&mut res);
731
732                 ((res[26] as u64) << 5*8) |
733                 ((res[27] as u64) << 4*8) |
734                 ((res[28] as u64) << 3*8) |
735                 ((res[29] as u64) << 2*8) |
736                 ((res[30] as u64) << 1*8) |
737                 ((res[31] as u64) << 0*8)
738         }
739
740         /// Transaction nomenclature is somewhat confusing here as there are many different cases - a
741         /// transaction is referred to as "a's transaction" implying that a will be able to broadcast
742         /// the transaction. Thus, b will generally be sending a signature over such a transaction to
743         /// a, and a can revoke the transaction by providing b the relevant per_commitment_secret. As
744         /// such, a transaction is generally the result of b increasing the amount paid to a (or adding
745         /// an HTLC to a).
746         /// @local is used only to convert relevant internal structures which refer to remote vs local
747         /// to decide value of outputs and direction of HTLCs.
748         /// @generated_by_local is used to determine *which* HTLCs to include - noting that the HTLC
749         /// state may indicate that one peer has informed the other that they'd like to add an HTLC but
750         /// have not yet committed it. Such HTLCs will only be included in transactions which are being
751         /// generated by the peer which proposed adding the HTLCs, and thus we need to understand both
752         /// which peer generated this transaction and "to whom" this transaction flows.
753         #[inline]
754         fn build_commitment_transaction(&self, commitment_number: u64, keys: &TxCreationKeys, local: bool, generated_by_local: bool, feerate_per_kw: u64) -> (Transaction, Vec<HTLCOutputInCommitment>, Vec<([u8; 32], &HTLCSource, Option<u32>)>) {
755                 let obscured_commitment_transaction_number = self.get_commitment_transaction_number_obscure_factor() ^ (INITIAL_COMMITMENT_NUMBER - commitment_number);
756
757                 let txins = {
758                         let mut ins: Vec<TxIn> = Vec::new();
759                         ins.push(TxIn {
760                                 previous_output: self.channel_monitor.get_funding_txo().unwrap().into_bitcoin_outpoint(),
761                                 script_sig: Script::new(),
762                                 sequence: ((0x80 as u32) << 8*3) | ((obscured_commitment_transaction_number >> 3*8) as u32),
763                                 witness: Vec::new(),
764                         });
765                         ins
766                 };
767
768                 let mut txouts: Vec<(TxOut, Option<(HTLCOutputInCommitment, Option<&HTLCSource>)>)> = Vec::with_capacity(self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len() + 2);
769                 let mut unincluded_htlc_sources: Vec<([u8; 32], &HTLCSource, Option<u32>)> = Vec::new();
770
771                 let dust_limit_satoshis = if local { self.our_dust_limit_satoshis } else { self.their_dust_limit_satoshis };
772                 let mut remote_htlc_total_msat = 0;
773                 let mut local_htlc_total_msat = 0;
774                 let mut value_to_self_msat_offset = 0;
775
776                 macro_rules! add_htlc_output {
777                         ($htlc: expr, $outbound: expr, $source: expr) => {
778                                 if $outbound == local { // "offered HTLC output"
779                                         if $htlc.amount_msat / 1000 >= dust_limit_satoshis + (feerate_per_kw * HTLC_TIMEOUT_TX_WEIGHT / 1000) {
780                                                 let htlc_in_tx = get_htlc_in_commitment!($htlc, true);
781                                                 txouts.push((TxOut {
782                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys).to_v0_p2wsh(),
783                                                         value: $htlc.amount_msat / 1000
784                                                 }, Some((htlc_in_tx, $source))));
785                                         } else {
786                                                 if let Some(source) = $source {
787                                                         unincluded_htlc_sources.push(($htlc.payment_hash, source, None));
788                                                 }
789                                         }
790                                 } else {
791                                         if $htlc.amount_msat / 1000 >= dust_limit_satoshis + (feerate_per_kw * HTLC_SUCCESS_TX_WEIGHT / 1000) {
792                                                 let htlc_in_tx = get_htlc_in_commitment!($htlc, false);
793                                                 txouts.push((TxOut { // "received HTLC output"
794                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys).to_v0_p2wsh(),
795                                                         value: $htlc.amount_msat / 1000
796                                                 }, Some((htlc_in_tx, $source))));
797                                         } else {
798                                                 if let Some(source) = $source {
799                                                         unincluded_htlc_sources.push(($htlc.payment_hash, source, None));
800                                                 }
801                                         }
802                                 }
803                         }
804                 }
805
806                 for ref htlc in self.pending_inbound_htlcs.iter() {
807                         let include = match htlc.state {
808                                 InboundHTLCState::RemoteAnnounced(_) => !generated_by_local,
809                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) => !generated_by_local,
810                                 InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => true,
811                                 InboundHTLCState::Committed => true,
812                                 InboundHTLCState::LocalRemoved(_) => !generated_by_local,
813                         };
814
815                         if include {
816                                 add_htlc_output!(htlc, false, None);
817                                 remote_htlc_total_msat += htlc.amount_msat;
818                         } else {
819                                 match &htlc.state {
820                                         &InboundHTLCState::LocalRemoved(ref reason) => {
821                                                 if generated_by_local {
822                                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
823                                                                 value_to_self_msat_offset += htlc.amount_msat as i64;
824                                                         }
825                                                 }
826                                         },
827                                         _ => {},
828                                 }
829                         }
830                 }
831
832                 for ref htlc in self.pending_outbound_htlcs.iter() {
833                         let include = match htlc.state {
834                                 OutboundHTLCState::LocalAnnounced(_) => generated_by_local,
835                                 OutboundHTLCState::Committed => true,
836                                 OutboundHTLCState::RemoteRemoved => generated_by_local,
837                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove => generated_by_local,
838                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke => false,
839                         };
840
841                         if include {
842                                 add_htlc_output!(htlc, true, Some(&htlc.source));
843                                 local_htlc_total_msat += htlc.amount_msat;
844                         } else {
845                                 match htlc.state {
846                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove|OutboundHTLCState::AwaitingRemovedRemoteRevoke => {
847                                                 if htlc.fail_reason.is_none() {
848                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
849                                                 }
850                                         },
851                                         OutboundHTLCState::RemoteRemoved => {
852                                                 if !generated_by_local && htlc.fail_reason.is_none() {
853                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
854                                                 }
855                                         },
856                                         _ => {},
857                                 }
858                         }
859                 }
860
861
862                 let value_to_self_msat: i64 = (self.value_to_self_msat - local_htlc_total_msat) as i64 + value_to_self_msat_offset;
863                 let value_to_remote_msat: i64 = (self.channel_value_satoshis * 1000 - self.value_to_self_msat - remote_htlc_total_msat) as i64 - value_to_self_msat_offset;
864
865                 #[cfg(debug_assertions)]
866                 {
867                         // Make sure that the to_self/to_remote is always either past the appropriate
868                         // channel_reserve *or* it is making progress towards it.
869                         // TODO: This should happen after fee calculation, but we don't handle that correctly
870                         // yet!
871                         let mut max_commitment_tx_output = if generated_by_local {
872                                 self.max_commitment_tx_output_local.lock().unwrap()
873                         } else {
874                                 self.max_commitment_tx_output_remote.lock().unwrap()
875                         };
876                         debug_assert!(max_commitment_tx_output.0 <= value_to_self_msat as u64 || value_to_self_msat / 1000 >= self.their_channel_reserve_satoshis as i64);
877                         max_commitment_tx_output.0 = cmp::max(max_commitment_tx_output.0, value_to_self_msat as u64);
878                         debug_assert!(max_commitment_tx_output.1 <= value_to_remote_msat as u64 || value_to_remote_msat / 1000 >= Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis) as i64);
879                         max_commitment_tx_output.1 = cmp::max(max_commitment_tx_output.1, value_to_remote_msat as u64);
880                 }
881
882                 let total_fee: u64 = feerate_per_kw * (COMMITMENT_TX_BASE_WEIGHT + (txouts.len() as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
883                 let (value_to_self, value_to_remote) = if self.channel_outbound {
884                         (value_to_self_msat / 1000 - total_fee as i64, value_to_remote_msat / 1000)
885                 } else {
886                         (value_to_self_msat / 1000, value_to_remote_msat / 1000 - total_fee as i64)
887                 };
888
889                 let value_to_a = if local { value_to_self } else { value_to_remote };
890                 let value_to_b = if local { value_to_remote } else { value_to_self };
891
892                 if value_to_a >= (dust_limit_satoshis as i64) {
893                         txouts.push((TxOut {
894                                 script_pubkey: chan_utils::get_revokeable_redeemscript(&keys.revocation_key,
895                                                                                        if local { self.their_to_self_delay } else { BREAKDOWN_TIMEOUT },
896                                                                                        &keys.a_delayed_payment_key).to_v0_p2wsh(),
897                                 value: value_to_a as u64
898                         }, None));
899                 }
900
901                 if value_to_b >= (dust_limit_satoshis as i64) {
902                         txouts.push((TxOut {
903                                 script_pubkey: Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0)
904                                                              .push_slice(&Hash160::from_data(&keys.b_payment_key.serialize())[..])
905                                                              .into_script(),
906                                 value: value_to_b as u64
907                         }, None));
908                 }
909
910                 transaction_utils::sort_outputs(&mut txouts);
911
912                 let mut outputs: Vec<TxOut> = Vec::with_capacity(txouts.len());
913                 let mut htlcs_included: Vec<HTLCOutputInCommitment> = Vec::with_capacity(txouts.len());
914                 let mut htlc_sources: Vec<([u8; 32], &HTLCSource, Option<u32>)> = Vec::with_capacity(txouts.len() + unincluded_htlc_sources.len());
915                 for (idx, out) in txouts.drain(..).enumerate() {
916                         outputs.push(out.0);
917                         if let Some((mut htlc, source_option)) = out.1 {
918                                 htlc.transaction_output_index = idx as u32;
919                                 if let Some(source) = source_option {
920                                         htlc_sources.push((htlc.payment_hash, source, Some(idx as u32)));
921                                 }
922                                 htlcs_included.push(htlc);
923                         }
924                 }
925                 htlc_sources.append(&mut unincluded_htlc_sources);
926
927                 (Transaction {
928                         version: 2,
929                         lock_time: ((0x20 as u32) << 8*3) | ((obscured_commitment_transaction_number & 0xffffffu64) as u32),
930                         input: txins,
931                         output: outputs,
932                 }, htlcs_included, htlc_sources)
933         }
934
935         #[inline]
936         fn get_closing_scriptpubkey(&self) -> Script {
937                 let our_channel_close_key_hash = Hash160::from_data(&self.shutdown_pubkey.serialize());
938                 Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&our_channel_close_key_hash[..]).into_script()
939         }
940
941         #[inline]
942         fn get_closing_transaction_weight(a_scriptpubkey: &Script, b_scriptpubkey: &Script) -> u64 {
943                 (4 + 1 + 36 + 4 + 1 + 1 + 2*(8+1) + 4 + a_scriptpubkey.len() as u64 + b_scriptpubkey.len() as u64)*4 + 2 + 1 + 1 + 2*(1 + 72)
944         }
945
946         #[inline]
947         fn build_closing_transaction(&self, proposed_total_fee_satoshis: u64, skip_remote_output: bool) -> (Transaction, u64) {
948                 let txins = {
949                         let mut ins: Vec<TxIn> = Vec::new();
950                         ins.push(TxIn {
951                                 previous_output: self.channel_monitor.get_funding_txo().unwrap().into_bitcoin_outpoint(),
952                                 script_sig: Script::new(),
953                                 sequence: 0xffffffff,
954                                 witness: Vec::new(),
955                         });
956                         ins
957                 };
958
959                 assert!(self.pending_inbound_htlcs.is_empty());
960                 assert!(self.pending_outbound_htlcs.is_empty());
961                 let mut txouts: Vec<(TxOut, ())> = Vec::new();
962
963                 let mut total_fee_satoshis = proposed_total_fee_satoshis;
964                 let value_to_self: i64 = (self.value_to_self_msat as i64) / 1000 - if self.channel_outbound { total_fee_satoshis as i64 } else { 0 };
965                 let value_to_remote: i64 = ((self.channel_value_satoshis * 1000 - self.value_to_self_msat) as i64 / 1000) - if self.channel_outbound { 0 } else { total_fee_satoshis as i64 };
966
967                 if value_to_self < 0 {
968                         assert!(self.channel_outbound);
969                         total_fee_satoshis += (-value_to_self) as u64;
970                 } else if value_to_remote < 0 {
971                         assert!(!self.channel_outbound);
972                         total_fee_satoshis += (-value_to_remote) as u64;
973                 }
974
975                 if !skip_remote_output && value_to_remote as u64 > self.our_dust_limit_satoshis {
976                         txouts.push((TxOut {
977                                 script_pubkey: self.their_shutdown_scriptpubkey.clone().unwrap(),
978                                 value: value_to_remote as u64
979                         }, ()));
980                 }
981
982                 if value_to_self as u64 > self.our_dust_limit_satoshis {
983                         txouts.push((TxOut {
984                                 script_pubkey: self.get_closing_scriptpubkey(),
985                                 value: value_to_self as u64
986                         }, ()));
987                 }
988
989                 transaction_utils::sort_outputs(&mut txouts);
990
991                 let mut outputs: Vec<TxOut> = Vec::new();
992                 for out in txouts.drain(..) {
993                         outputs.push(out.0);
994                 }
995
996                 (Transaction {
997                         version: 2,
998                         lock_time: 0,
999                         input: txins,
1000                         output: outputs,
1001                 }, total_fee_satoshis)
1002         }
1003
1004         #[inline]
1005         /// Creates a set of keys for build_commitment_transaction to generate a transaction which our
1006         /// counterparty will sign (ie DO NOT send signatures over a transaction created by this to
1007         /// our counterparty!)
1008         /// The result is a transaction which we can revoke ownership of (ie a "local" transaction)
1009         /// TODO Some magic rust shit to compile-time check this?
1010         fn build_local_transaction_keys(&self, commitment_number: u64) -> Result<TxCreationKeys, ChannelError> {
1011                 let per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(commitment_number));
1012                 let delayed_payment_base = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key);
1013                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key);
1014
1015                 Ok(secp_check!(TxCreationKeys::new(&self.secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &self.their_revocation_basepoint.unwrap(), &self.their_payment_basepoint.unwrap(), &self.their_htlc_basepoint.unwrap()), "Local tx keys generation got bogus keys"))
1016         }
1017
1018         #[inline]
1019         /// Creates a set of keys for build_commitment_transaction to generate a transaction which we
1020         /// will sign and send to our counterparty.
1021         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
1022         fn build_remote_transaction_keys(&self) -> Result<TxCreationKeys, ChannelError> {
1023                 //TODO: Ensure that the payment_key derived here ends up in the library users' wallet as we
1024                 //may see payments to it!
1025                 let payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key);
1026                 let revocation_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key);
1027                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key);
1028
1029                 Ok(secp_check!(TxCreationKeys::new(&self.secp_ctx, &self.their_cur_commitment_point.unwrap(), &self.their_delayed_payment_basepoint.unwrap(), &self.their_htlc_basepoint.unwrap(), &revocation_basepoint, &payment_basepoint, &htlc_basepoint), "Remote tx keys generation got bogus keys"))
1030         }
1031
1032         /// Gets the redeemscript for the funding transaction output (ie the funding transaction output
1033         /// pays to get_funding_redeemscript().to_v0_p2wsh()).
1034         /// Panics if called before accept_channel/new_from_req
1035         pub fn get_funding_redeemscript(&self) -> Script {
1036                 let builder = Builder::new().push_opcode(opcodes::All::OP_PUSHNUM_2);
1037                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).serialize();
1038                 let their_funding_key = self.their_funding_pubkey.expect("get_funding_redeemscript only allowed after accept_channel").serialize();
1039                 if our_funding_key[..] < their_funding_key[..] {
1040                         builder.push_slice(&our_funding_key)
1041                                 .push_slice(&their_funding_key)
1042                 } else {
1043                         builder.push_slice(&their_funding_key)
1044                                 .push_slice(&our_funding_key)
1045                 }.push_opcode(opcodes::All::OP_PUSHNUM_2).push_opcode(opcodes::All::OP_CHECKMULTISIG).into_script()
1046         }
1047
1048         fn sign_commitment_transaction(&self, tx: &mut Transaction, their_sig: &Signature) -> Signature {
1049                 if tx.input.len() != 1 {
1050                         panic!("Tried to sign commitment transaction that had input count != 1!");
1051                 }
1052                 if tx.input[0].witness.len() != 0 {
1053                         panic!("Tried to re-sign commitment transaction");
1054                 }
1055
1056                 let funding_redeemscript = self.get_funding_redeemscript();
1057
1058                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&tx).sighash_all(&tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
1059                 let our_sig = self.secp_ctx.sign(&sighash, &self.local_keys.funding_key);
1060
1061                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
1062
1063                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).serialize();
1064                 let their_funding_key = self.their_funding_pubkey.unwrap().serialize();
1065                 if our_funding_key[..] < their_funding_key[..] {
1066                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
1067                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
1068                 } else {
1069                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
1070                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
1071                 }
1072                 tx.input[0].witness[1].push(SigHashType::All as u8);
1073                 tx.input[0].witness[2].push(SigHashType::All as u8);
1074
1075                 tx.input[0].witness.push(funding_redeemscript.into_bytes());
1076
1077                 our_sig
1078         }
1079
1080         /// Builds the htlc-success or htlc-timeout transaction which spends a given HTLC output
1081         /// @local is used only to convert relevant internal structures which refer to remote vs local
1082         /// to decide value of outputs and direction of HTLCs.
1083         fn build_htlc_transaction(&self, prev_hash: &Sha256dHash, htlc: &HTLCOutputInCommitment, local: bool, keys: &TxCreationKeys, feerate_per_kw: u64) -> Transaction {
1084                 chan_utils::build_htlc_transaction(prev_hash, feerate_per_kw, if local { self.their_to_self_delay } else { BREAKDOWN_TIMEOUT }, htlc, &keys.a_delayed_payment_key, &keys.revocation_key)
1085         }
1086
1087         fn create_htlc_tx_signature(&self, tx: &Transaction, htlc: &HTLCOutputInCommitment, keys: &TxCreationKeys) -> Result<(Script, Signature, bool), ChannelError> {
1088                 if tx.input.len() != 1 {
1089                         panic!("Tried to sign HTLC transaction that had input count != 1!");
1090                 }
1091
1092                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys);
1093
1094                 let our_htlc_key = secp_check!(chan_utils::derive_private_key(&self.secp_ctx, &keys.per_commitment_point, &self.local_keys.htlc_base_key), "Derived invalid key, peer is maliciously selecting parameters");
1095                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&tx).sighash_all(&tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
1096                 let is_local_tx = PublicKey::from_secret_key(&self.secp_ctx, &our_htlc_key) == keys.a_htlc_key;
1097                 Ok((htlc_redeemscript, self.secp_ctx.sign(&sighash, &our_htlc_key), is_local_tx))
1098         }
1099
1100         /// Signs a transaction created by build_htlc_transaction. If the transaction is an
1101         /// HTLC-Success transaction (ie htlc.offered is false), preimate must be set!
1102         fn sign_htlc_transaction(&self, tx: &mut Transaction, their_sig: &Signature, preimage: &Option<[u8; 32]>, htlc: &HTLCOutputInCommitment, keys: &TxCreationKeys) -> Result<Signature, ChannelError> {
1103                 if tx.input.len() != 1 {
1104                         panic!("Tried to sign HTLC transaction that had input count != 1!");
1105                 }
1106                 if tx.input[0].witness.len() != 0 {
1107                         panic!("Tried to re-sign HTLC transaction");
1108                 }
1109
1110                 let (htlc_redeemscript, our_sig, local_tx) = self.create_htlc_tx_signature(tx, htlc, keys)?;
1111
1112                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
1113
1114                 if local_tx { // b, then a
1115                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
1116                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
1117                 } else {
1118                         tx.input[0].witness.push(our_sig.serialize_der(&self.secp_ctx).to_vec());
1119                         tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec());
1120                 }
1121                 tx.input[0].witness[1].push(SigHashType::All as u8);
1122                 tx.input[0].witness[2].push(SigHashType::All as u8);
1123
1124                 if htlc.offered {
1125                         tx.input[0].witness.push(Vec::new());
1126                 } else {
1127                         tx.input[0].witness.push(preimage.unwrap().to_vec());
1128                 }
1129
1130                 tx.input[0].witness.push(htlc_redeemscript.into_bytes());
1131
1132                 Ok(our_sig)
1133         }
1134
1135         /// Per HTLC, only one get_update_fail_htlc or get_update_fulfill_htlc call may be made.
1136         /// In such cases we debug_assert!(false) and return an IgnoreError. Thus, will always return
1137         /// Ok(_) if debug assertions are turned on and preconditions are met.
1138         fn get_update_fulfill_htlc(&mut self, htlc_id_arg: u64, payment_preimage_arg: [u8; 32]) -> Result<(Option<msgs::UpdateFulfillHTLC>, Option<ChannelMonitor>), ChannelError> {
1139                 // Either ChannelFunded got set (which means it wont bet unset) or there is no way any
1140                 // caller thought we could have something claimed (cause we wouldn't have accepted in an
1141                 // incoming HTLC anyway). If we got to ShutdownComplete, callers aren't allowed to call us,
1142                 // either.
1143                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1144                         panic!("Was asked to fulfill an HTLC when channel was not in an operational state");
1145                 }
1146                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1147
1148                 let mut sha = Sha256::new();
1149                 sha.input(&payment_preimage_arg);
1150                 let mut payment_hash_calc = [0; 32];
1151                 sha.result(&mut payment_hash_calc);
1152
1153                 let mut pending_idx = std::usize::MAX;
1154                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1155                         if htlc.htlc_id == htlc_id_arg {
1156                                 assert_eq!(htlc.payment_hash, payment_hash_calc);
1157                                 if let InboundHTLCState::Committed = htlc.state {
1158                                 } else {
1159                                         debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1160                                         // Don't return in release mode here so that we can update channel_monitor
1161                                 }
1162                                 pending_idx = idx;
1163                                 break;
1164                         }
1165                 }
1166                 if pending_idx == std::usize::MAX {
1167                         debug_assert!(false, "Unable to find a pending HTLC which matched the given HTLC ID");
1168                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1169                 }
1170
1171                 // Now update local state:
1172                 //
1173                 // We have to put the payment_preimage in the channel_monitor right away here to ensure we
1174                 // can claim it even if the channel hits the chain before we see their next commitment.
1175                 self.channel_monitor.provide_payment_preimage(&payment_hash_calc, &payment_preimage_arg);
1176
1177                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1178                         for pending_update in self.holding_cell_htlc_updates.iter() {
1179                                 match pending_update {
1180                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1181                                                 if htlc_id_arg == htlc_id {
1182                                                         debug_assert!(false, "Tried to fulfill an HTLC we already had a pending fulfill for");
1183                                                         return Ok((None, None));
1184                                                 }
1185                                         },
1186                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1187                                                 if htlc_id_arg == htlc_id {
1188                                                         debug_assert!(false, "Tried to fulfill an HTLC we already had a holding-cell failure on");
1189                                                         // Return the new channel monitor in a last-ditch effort to hit the
1190                                                         // chain and claim the funds
1191                                                         return Ok((None, Some(self.channel_monitor.clone())));
1192                                                 }
1193                                         },
1194                                         _ => {}
1195                                 }
1196                         }
1197                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::ClaimHTLC {
1198                                 payment_preimage: payment_preimage_arg, htlc_id: htlc_id_arg,
1199                         });
1200                         return Ok((None, Some(self.channel_monitor.clone())));
1201                 }
1202
1203                 {
1204                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1205                         if let InboundHTLCState::Committed = htlc.state {
1206                         } else {
1207                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1208                                 return Ok((None, Some(self.channel_monitor.clone())));
1209                         }
1210                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::Fulfill(payment_preimage_arg.clone()));
1211                 }
1212
1213                 Ok((Some(msgs::UpdateFulfillHTLC {
1214                         channel_id: self.channel_id(),
1215                         htlc_id: htlc_id_arg,
1216                         payment_preimage: payment_preimage_arg,
1217                 }), Some(self.channel_monitor.clone())))
1218         }
1219
1220         pub fn get_update_fulfill_htlc_and_commit(&mut self, htlc_id: u64, payment_preimage: [u8; 32]) -> Result<(Option<(msgs::UpdateFulfillHTLC, msgs::CommitmentSigned)>, Option<ChannelMonitor>), ChannelError> {
1221                 match self.get_update_fulfill_htlc(htlc_id, payment_preimage)? {
1222                         (Some(update_fulfill_htlc), _) => {
1223                                 let (commitment, monitor_update) = self.send_commitment_no_status_check()?;
1224                                 Ok((Some((update_fulfill_htlc, commitment)), Some(monitor_update)))
1225                         },
1226                         (None, Some(channel_monitor)) => Ok((None, Some(channel_monitor))),
1227                         (None, None) => Ok((None, None))
1228                 }
1229         }
1230
1231         /// Per HTLC, only one get_update_fail_htlc or get_update_fulfill_htlc call may be made.
1232         /// In such cases we debug_assert!(false) and return an IgnoreError. Thus, will always return
1233         /// Ok(_) if debug assertions are turned on and preconditions are met.
1234         pub fn get_update_fail_htlc(&mut self, htlc_id_arg: u64, err_packet: msgs::OnionErrorPacket) -> Result<Option<msgs::UpdateFailHTLC>, ChannelError> {
1235                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1236                         panic!("Was asked to fail an HTLC when channel was not in an operational state");
1237                 }
1238                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1239
1240                 let mut pending_idx = std::usize::MAX;
1241                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1242                         if htlc.htlc_id == htlc_id_arg {
1243                                 if let InboundHTLCState::Committed = htlc.state {
1244                                 } else {
1245                                         debug_assert!(false, "Have an inbound HTLC we tried to fail before it was fully committed to");
1246                                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1247                                 }
1248                                 pending_idx = idx;
1249                         }
1250                 }
1251                 if pending_idx == std::usize::MAX {
1252                         debug_assert!(false, "Unable to find a pending HTLC which matched the given HTLC ID");
1253                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1254                 }
1255
1256                 // Now update local state:
1257                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1258                         for pending_update in self.holding_cell_htlc_updates.iter() {
1259                                 match pending_update {
1260                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1261                                                 if htlc_id_arg == htlc_id {
1262                                                         debug_assert!(false, "Unable to find a pending HTLC which matched the given HTLC ID");
1263                                                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1264                                                 }
1265                                         },
1266                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1267                                                 if htlc_id_arg == htlc_id {
1268                                                         debug_assert!(false, "Tried to fail an HTLC that we already had a pending failure for");
1269                                                         return Ok(None);
1270                                                 }
1271                                         },
1272                                         _ => {}
1273                                 }
1274                         }
1275                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::FailHTLC {
1276                                 htlc_id: htlc_id_arg,
1277                                 err_packet,
1278                         });
1279                         return Ok(None);
1280                 }
1281
1282                 {
1283                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1284                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(err_packet.clone()));
1285                 }
1286
1287                 Ok(Some(msgs::UpdateFailHTLC {
1288                         channel_id: self.channel_id(),
1289                         htlc_id: htlc_id_arg,
1290                         reason: err_packet
1291                 }))
1292         }
1293
1294         pub fn get_update_fail_htlc_and_commit(&mut self, htlc_id: u64, err_packet: msgs::OnionErrorPacket) -> Result<Option<(msgs::UpdateFailHTLC, msgs::CommitmentSigned, ChannelMonitor)>, ChannelError> {
1295                 match self.get_update_fail_htlc(htlc_id, err_packet)? {
1296                         Some(update_fail_htlc) => {
1297                                 let (commitment, monitor_update) = self.send_commitment_no_status_check()?;
1298                                 Ok(Some((update_fail_htlc, commitment, monitor_update)))
1299                         },
1300                         None => Ok(None)
1301                 }
1302         }
1303
1304         // Message handlers:
1305
1306         pub fn accept_channel(&mut self, msg: &msgs::AcceptChannel, config: &UserConfig) -> Result<(), ChannelError> {
1307                 // Check sanity of message fields:
1308                 if !self.channel_outbound {
1309                         return Err(ChannelError::Close("Got an accept_channel message from an inbound peer"));
1310                 }
1311                 if self.channel_state != ChannelState::OurInitSent as u32 {
1312                         return Err(ChannelError::Close("Got an accept_channel message at a strange time"));
1313                 }
1314                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
1315                         return Err(ChannelError::Close("Peer never wants payout outputs?"));
1316                 }
1317                 if msg.channel_reserve_satoshis > self.channel_value_satoshis {
1318                         return Err(ChannelError::Close("Bogus channel_reserve_satoshis"));
1319                 }
1320                 if msg.dust_limit_satoshis > msg.channel_reserve_satoshis {
1321                         return Err(ChannelError::Close("Bogus channel_reserve and dust_limit"));
1322                 }
1323                 if msg.channel_reserve_satoshis < self.our_dust_limit_satoshis {
1324                         return Err(ChannelError::Close("Peer never wants payout outputs?"));
1325                 }
1326                 if msg.dust_limit_satoshis > Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis) {
1327                         return Err(ChannelError::Close("Dust limit is bigger than our channel reverse"));
1328                 }
1329                 if msg.htlc_minimum_msat >= (self.channel_value_satoshis - msg.channel_reserve_satoshis) * 1000 {
1330                         return Err(ChannelError::Close("Minimum htlc value is full channel value"));
1331                 }
1332                 if msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
1333                         return Err(ChannelError::Close("They wanted our payments to be delayed by a needlessly long period"));
1334                 }
1335                 if msg.max_accepted_htlcs < 1 {
1336                         return Err(ChannelError::Close("0 max_accpted_htlcs makes for a useless channel"));
1337                 }
1338                 if msg.max_accepted_htlcs > 483 {
1339                         return Err(ChannelError::Close("max_accpted_htlcs > 483"));
1340                 }
1341
1342                 // Now check against optional parameters as set by config...
1343                 if msg.htlc_minimum_msat > config.channel_limits.max_htlc_minimum_msat {
1344                         return Err(ChannelError::Close("htlc minimum msat is higher than the user specified limit"));
1345                 }
1346                 if msg.max_htlc_value_in_flight_msat < config.channel_limits.min_max_htlc_value_in_flight_msat {
1347                         return Err(ChannelError::Close("max htlc value in flight msat is less than the user specified limit"));
1348                 }
1349                 if msg.channel_reserve_satoshis > config.channel_limits.max_channel_reserve_satoshis {
1350                         return Err(ChannelError::Close("channel reserve satoshis is higher than the user specified limit"));
1351                 }
1352                 if msg.max_accepted_htlcs < config.channel_limits.min_max_accepted_htlcs {
1353                         return Err(ChannelError::Close("max accepted htlcs is less than the user specified limit"));
1354                 }
1355                 if msg.dust_limit_satoshis < config.channel_limits.min_dust_limit_satoshis {
1356                         return Err(ChannelError::Close("dust limit satoshis is less than the user specified limit"));
1357                 }
1358                 if msg.dust_limit_satoshis > config.channel_limits.max_dust_limit_satoshis {
1359                         return Err(ChannelError::Close("dust limit satoshis is greater than the user specified limit"));
1360                 }
1361                 if msg.minimum_depth > config.channel_limits.max_minimum_depth {
1362                         return Err(ChannelError::Close("We consider the minimum depth to be unreasonably large"));
1363                 }
1364
1365                 self.channel_monitor.set_their_base_keys(&msg.htlc_basepoint, &msg.delayed_payment_basepoint);
1366
1367                 self.their_dust_limit_satoshis = msg.dust_limit_satoshis;
1368                 self.their_max_htlc_value_in_flight_msat = cmp::min(msg.max_htlc_value_in_flight_msat, self.channel_value_satoshis * 1000);
1369                 self.their_channel_reserve_satoshis = msg.channel_reserve_satoshis;
1370                 self.their_htlc_minimum_msat = msg.htlc_minimum_msat;
1371                 self.their_to_self_delay = msg.to_self_delay;
1372                 self.their_max_accepted_htlcs = msg.max_accepted_htlcs;
1373                 self.minimum_depth = msg.minimum_depth;
1374                 self.their_funding_pubkey = Some(msg.funding_pubkey);
1375                 self.their_revocation_basepoint = Some(msg.revocation_basepoint);
1376                 self.their_payment_basepoint = Some(msg.payment_basepoint);
1377                 self.their_delayed_payment_basepoint = Some(msg.delayed_payment_basepoint);
1378                 self.their_htlc_basepoint = Some(msg.htlc_basepoint);
1379                 self.their_cur_commitment_point = Some(msg.first_per_commitment_point);
1380
1381                 let obscure_factor = self.get_commitment_transaction_number_obscure_factor();
1382                 self.channel_monitor.set_commitment_obscure_factor(obscure_factor);
1383                 self.channel_monitor.set_their_to_self_delay(msg.to_self_delay);
1384
1385                 self.channel_state = ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32;
1386
1387                 Ok(())
1388         }
1389
1390         fn funding_created_signature(&mut self, sig: &Signature) -> Result<(Transaction, Transaction, Signature, TxCreationKeys), ChannelError> {
1391                 let funding_script = self.get_funding_redeemscript();
1392
1393                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1394                 let mut local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false, self.feerate_per_kw).0;
1395                 let local_sighash = Message::from_slice(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1396
1397                 // They sign the "local" commitment transaction...
1398                 secp_check!(self.secp_ctx.verify(&local_sighash, &sig, &self.their_funding_pubkey.unwrap()), "Invalid funding_created signature from peer");
1399
1400                 // ...and we sign it, allowing us to broadcast the tx if we wish
1401                 self.sign_commitment_transaction(&mut local_initial_commitment_tx, sig);
1402
1403                 let remote_keys = self.build_remote_transaction_keys()?;
1404                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false, self.feerate_per_kw).0;
1405                 let remote_sighash = Message::from_slice(&bip143::SighashComponents::new(&remote_initial_commitment_tx).sighash_all(&remote_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1406
1407                 // We sign the "remote" commitment transaction, allowing them to broadcast the tx if they wish.
1408                 Ok((remote_initial_commitment_tx, local_initial_commitment_tx, self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key), local_keys))
1409         }
1410
1411         pub fn funding_created(&mut self, msg: &msgs::FundingCreated) -> Result<(msgs::FundingSigned, ChannelMonitor), ChannelError> {
1412                 if self.channel_outbound {
1413                         return Err(ChannelError::Close("Received funding_created for an outbound channel?"));
1414                 }
1415                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
1416                         // BOLT 2 says that if we disconnect before we send funding_signed we SHOULD NOT
1417                         // remember the channel, so its safe to just send an error_message here and drop the
1418                         // channel.
1419                         return Err(ChannelError::Close("Received funding_created after we got the channel!"));
1420                 }
1421                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) ||
1422                                 self.cur_remote_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
1423                                 self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1424                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1425                 }
1426
1427                 let funding_txo = OutPoint::new(msg.funding_txid, msg.funding_output_index);
1428                 let funding_txo_script = self.get_funding_redeemscript().to_v0_p2wsh();
1429                 self.channel_monitor.set_funding_info((funding_txo, funding_txo_script));
1430
1431                 let (remote_initial_commitment_tx, local_initial_commitment_tx, our_signature, local_keys) = match self.funding_created_signature(&msg.signature) {
1432                         Ok(res) => res,
1433                         Err(e) => {
1434                                 self.channel_monitor.unset_funding_info();
1435                                 return Err(e);
1436                         }
1437                 };
1438
1439                 // Now that we're past error-generating stuff, update our local state:
1440
1441                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&remote_initial_commitment_tx, Vec::new(), Vec::new(), self.cur_remote_commitment_transaction_number, self.their_cur_commitment_point.unwrap());
1442                 self.last_local_commitment_txn = vec![local_initial_commitment_tx.clone()];
1443                 self.channel_monitor.provide_latest_local_commitment_tx_info(local_initial_commitment_tx, local_keys, self.feerate_per_kw, Vec::new(), Vec::new());
1444                 self.channel_state = ChannelState::FundingSent as u32;
1445                 self.channel_id = funding_txo.to_channel_id();
1446                 self.cur_remote_commitment_transaction_number -= 1;
1447                 self.cur_local_commitment_transaction_number -= 1;
1448
1449                 Ok((msgs::FundingSigned {
1450                         channel_id: self.channel_id,
1451                         signature: our_signature
1452                 }, self.channel_monitor.clone()))
1453         }
1454
1455         /// Handles a funding_signed message from the remote end.
1456         /// If this call is successful, broadcast the funding transaction (and not before!)
1457         pub fn funding_signed(&mut self, msg: &msgs::FundingSigned) -> Result<ChannelMonitor, ChannelError> {
1458                 if !self.channel_outbound {
1459                         return Err(ChannelError::Close("Received funding_signed for an inbound channel?"));
1460                 }
1461                 if self.channel_state != ChannelState::FundingCreated as u32 {
1462                         return Err(ChannelError::Close("Received funding_signed in strange state!"));
1463                 }
1464                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) ||
1465                                 self.cur_remote_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER - 1 ||
1466                                 self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1467                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1468                 }
1469
1470                 let funding_script = self.get_funding_redeemscript();
1471
1472                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1473                 let mut local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false, self.feerate_per_kw).0;
1474                 let local_sighash = Message::from_slice(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1475
1476                 // They sign the "local" commitment transaction, allowing us to broadcast the tx if we wish.
1477                 secp_check!(self.secp_ctx.verify(&local_sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid funding_signed signature from peer");
1478
1479                 self.sign_commitment_transaction(&mut local_initial_commitment_tx, &msg.signature);
1480                 self.channel_monitor.provide_latest_local_commitment_tx_info(local_initial_commitment_tx.clone(), local_keys, self.feerate_per_kw, Vec::new(), Vec::new());
1481                 self.last_local_commitment_txn = vec![local_initial_commitment_tx];
1482                 self.channel_state = ChannelState::FundingSent as u32;
1483                 self.cur_local_commitment_transaction_number -= 1;
1484
1485                 Ok(self.channel_monitor.clone())
1486         }
1487
1488         pub fn funding_locked(&mut self, msg: &msgs::FundingLocked) -> Result<(), ChannelError> {
1489                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1490                         return Err(ChannelError::Close("Peer sent funding_locked when we needed a channel_reestablish"));
1491                 }
1492
1493                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
1494
1495                 if non_shutdown_state == ChannelState::FundingSent as u32 {
1496                         self.channel_state |= ChannelState::TheirFundingLocked as u32;
1497                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
1498                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
1499                         self.channel_update_count += 1;
1500                 } else if self.channel_state & (ChannelState::ChannelFunded as u32) != 0 &&
1501                                 // Note that funding_signed/funding_created will have decremented both by 1!
1502                                 self.cur_local_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1 &&
1503                                 self.cur_remote_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1 {
1504                         if self.their_cur_commitment_point != Some(msg.next_per_commitment_point) {
1505                                 return Err(ChannelError::Close("Peer sent a reconnect funding_locked with a different point"));
1506                         }
1507                         // They probably disconnected/reconnected and re-sent the funding_locked, which is required
1508                         return Ok(());
1509                 } else {
1510                         return Err(ChannelError::Close("Peer sent a funding_locked at a strange time"));
1511                 }
1512
1513                 self.their_prev_commitment_point = self.their_cur_commitment_point;
1514                 self.their_cur_commitment_point = Some(msg.next_per_commitment_point);
1515                 Ok(())
1516         }
1517
1518         /// Returns (inbound_htlc_count, htlc_inbound_value_msat)
1519         fn get_inbound_pending_htlc_stats(&self) -> (u32, u64) {
1520                 let mut htlc_inbound_value_msat = 0;
1521                 for ref htlc in self.pending_inbound_htlcs.iter() {
1522                         htlc_inbound_value_msat += htlc.amount_msat;
1523                 }
1524                 (self.pending_inbound_htlcs.len() as u32, htlc_inbound_value_msat)
1525         }
1526
1527         /// Returns (outbound_htlc_count, htlc_outbound_value_msat)
1528         fn get_outbound_pending_htlc_stats(&self) -> (u32, u64) {
1529                 let mut htlc_outbound_value_msat = 0;
1530                 for ref htlc in self.pending_outbound_htlcs.iter() {
1531                         htlc_outbound_value_msat += htlc.amount_msat;
1532                 }
1533
1534                 (self.pending_outbound_htlcs.len() as u32, htlc_outbound_value_msat)
1535         }
1536
1537         pub fn update_add_htlc(&mut self, msg: &msgs::UpdateAddHTLC, pending_forward_state: PendingHTLCStatus) -> Result<(), ChannelError> {
1538                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::RemoteShutdownSent as u32)) != (ChannelState::ChannelFunded as u32) {
1539                         return Err(ChannelError::Close("Got add HTLC message when channel was not in an operational state"));
1540                 }
1541                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1542                         return Err(ChannelError::Close("Peer sent update_add_htlc when we needed a channel_reestablish"));
1543                 }
1544                 if msg.amount_msat > self.channel_value_satoshis * 1000 {
1545                         return Err(ChannelError::Close("Remote side tried to send more than the total value of the channel"));
1546                 }
1547                 if msg.amount_msat < self.our_htlc_minimum_msat {
1548                         return Err(ChannelError::Close("Remote side tried to send less than our minimum HTLC value"));
1549                 }
1550
1551                 let (inbound_htlc_count, htlc_inbound_value_msat) = self.get_inbound_pending_htlc_stats();
1552                 if inbound_htlc_count + 1 > OUR_MAX_HTLCS as u32 {
1553                         return Err(ChannelError::Close("Remote tried to push more than our max accepted HTLCs"));
1554                 }
1555                 //TODO: Spec is unclear if this is per-direction or in total (I assume per direction):
1556                 // Check our_max_htlc_value_in_flight_msat
1557                 if htlc_inbound_value_msat + msg.amount_msat > Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis) {
1558                         return Err(ChannelError::Close("Remote HTLC add would put them over their max HTLC value in flight"));
1559                 }
1560                 // Check our_channel_reserve_satoshis (we're getting paid, so they have to at least meet
1561                 // the reserve_satoshis we told them to always have as direct payment so that they lose
1562                 // something if we punish them for broadcasting an old state).
1563                 if htlc_inbound_value_msat + msg.amount_msat + self.value_to_self_msat > (self.channel_value_satoshis - Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis)) * 1000 {
1564                         return Err(ChannelError::Close("Remote HTLC add would put them over their reserve value"));
1565                 }
1566                 if self.next_remote_htlc_id != msg.htlc_id {
1567                         return Err(ChannelError::Close("Remote skipped HTLC ID"));
1568                 }
1569                 if msg.cltv_expiry >= 500000000 {
1570                         return Err(ChannelError::Close("Remote provided CLTV expiry in seconds instead of block height"));
1571                 }
1572
1573                 //TODO: Check msg.cltv_expiry further? Do this in channel manager?
1574
1575                 if self.channel_state & ChannelState::LocalShutdownSent as u32 != 0 {
1576                         if let PendingHTLCStatus::Forward(_) = pending_forward_state {
1577                                 panic!("ChannelManager shouldn't be trying to add a forwardable HTLC after we've started closing");
1578                         }
1579                 }
1580
1581                 // Now update local state:
1582                 self.next_remote_htlc_id += 1;
1583                 self.pending_inbound_htlcs.push(InboundHTLCOutput {
1584                         htlc_id: msg.htlc_id,
1585                         amount_msat: msg.amount_msat,
1586                         payment_hash: msg.payment_hash,
1587                         cltv_expiry: msg.cltv_expiry,
1588                         state: InboundHTLCState::RemoteAnnounced(pending_forward_state),
1589                 });
1590
1591                 Ok(())
1592         }
1593
1594         /// Marks an outbound HTLC which we have received update_fail/fulfill/malformed
1595         #[inline]
1596         fn mark_outbound_htlc_removed(&mut self, htlc_id: u64, check_preimage: Option<[u8; 32]>, fail_reason: Option<HTLCFailReason>) -> Result<&HTLCSource, ChannelError> {
1597                 for htlc in self.pending_outbound_htlcs.iter_mut() {
1598                         if htlc.htlc_id == htlc_id {
1599                                 match check_preimage {
1600                                         None => {},
1601                                         Some(payment_hash) =>
1602                                                 if payment_hash != htlc.payment_hash {
1603                                                         return Err(ChannelError::Close("Remote tried to fulfill HTLC with an incorrect preimage"));
1604                                                 }
1605                                 };
1606                                 match htlc.state {
1607                                         OutboundHTLCState::LocalAnnounced(_) =>
1608                                                 return Err(ChannelError::Close("Remote tried to fulfill/fail HTLC before it had been committed")),
1609                                         OutboundHTLCState::Committed => {
1610                                                 htlc.state = OutboundHTLCState::RemoteRemoved;
1611                                                 htlc.fail_reason = fail_reason;
1612                                         },
1613                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove | OutboundHTLCState::AwaitingRemovedRemoteRevoke | OutboundHTLCState::RemoteRemoved =>
1614                                                 return Err(ChannelError::Close("Remote tried to fulfill/fail HTLC that they'd already fulfilled/failed")),
1615                                 }
1616                                 return Ok(&htlc.source);
1617                         }
1618                 }
1619                 Err(ChannelError::Close("Remote tried to fulfill/fail an HTLC we couldn't find"))
1620         }
1621
1622         pub fn update_fulfill_htlc(&mut self, msg: &msgs::UpdateFulfillHTLC) -> Result<HTLCSource, ChannelError> {
1623                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1624                         return Err(ChannelError::Close("Got fulfill HTLC message when channel was not in an operational state"));
1625                 }
1626                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1627                         return Err(ChannelError::Close("Peer sent update_fulfill_htlc when we needed a channel_reestablish"));
1628                 }
1629
1630                 let mut sha = Sha256::new();
1631                 sha.input(&msg.payment_preimage);
1632                 let mut payment_hash = [0; 32];
1633                 sha.result(&mut payment_hash);
1634
1635                 self.mark_outbound_htlc_removed(msg.htlc_id, Some(payment_hash), None).map(|source| source.clone())
1636         }
1637
1638         pub fn update_fail_htlc(&mut self, msg: &msgs::UpdateFailHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
1639                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1640                         return Err(ChannelError::Close("Got fail HTLC message when channel was not in an operational state"));
1641                 }
1642                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1643                         return Err(ChannelError::Close("Peer sent update_fail_htlc when we needed a channel_reestablish"));
1644                 }
1645
1646                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
1647                 Ok(())
1648         }
1649
1650         pub fn update_fail_malformed_htlc<'a>(&mut self, msg: &msgs::UpdateFailMalformedHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
1651                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1652                         return Err(ChannelError::Close("Got fail malformed HTLC message when channel was not in an operational state"));
1653                 }
1654                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1655                         return Err(ChannelError::Close("Peer sent update_fail_malformed_htlc when we needed a channel_reestablish"));
1656                 }
1657
1658                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
1659                 Ok(())
1660         }
1661
1662         pub fn commitment_signed(&mut self, msg: &msgs::CommitmentSigned, fee_estimator: &FeeEstimator) -> Result<(msgs::RevokeAndACK, Option<msgs::CommitmentSigned>, Option<msgs::ClosingSigned>, ChannelMonitor), ChannelError> {
1663                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1664                         return Err(ChannelError::Close("Got commitment signed message when channel was not in an operational state"));
1665                 }
1666                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1667                         return Err(ChannelError::Close("Peer sent commitment_signed when we needed a channel_reestablish"));
1668                 }
1669                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
1670                         return Err(ChannelError::Close("Peer sent commitment_signed after we'd started exchanging closing_signeds"));
1671                 }
1672
1673                 let funding_script = self.get_funding_redeemscript();
1674
1675                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1676
1677                 let mut update_fee = false;
1678                 let feerate_per_kw = if !self.channel_outbound && self.pending_update_fee.is_some() {
1679                         update_fee = true;
1680                         self.pending_update_fee.unwrap()
1681                 } else {
1682                         self.feerate_per_kw
1683                 };
1684
1685                 let mut local_commitment_tx = {
1686                         let mut commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false, feerate_per_kw);
1687                         let htlcs_cloned: Vec<_> = commitment_tx.2.drain(..).map(|htlc_source| (htlc_source.0, htlc_source.1.clone(), htlc_source.2)).collect();
1688                         (commitment_tx.0, commitment_tx.1, htlcs_cloned)
1689                 };
1690                 let local_commitment_txid = local_commitment_tx.0.txid();
1691                 let local_sighash = Message::from_slice(&bip143::SighashComponents::new(&local_commitment_tx.0).sighash_all(&local_commitment_tx.0.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
1692                 secp_check!(self.secp_ctx.verify(&local_sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid commitment tx signature from peer");
1693
1694                 //If channel fee was updated by funder confirm funder can afford the new fee rate when applied to the current local commitment transaction
1695                 if update_fee {
1696                         let num_htlcs = local_commitment_tx.1.len();
1697                         let total_fee: u64 = feerate_per_kw as u64 * (COMMITMENT_TX_BASE_WEIGHT + (num_htlcs as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
1698
1699                         if self.channel_value_satoshis - self.value_to_self_msat / 1000 < total_fee + self.their_channel_reserve_satoshis {
1700                                 return Err(ChannelError::Close("Funding remote cannot afford proposed new fee"));
1701                         }
1702                 }
1703
1704                 if msg.htlc_signatures.len() != local_commitment_tx.1.len() {
1705                         return Err(ChannelError::Close("Got wrong number of HTLC signatures from remote"));
1706                 }
1707
1708                 let mut new_local_commitment_txn = Vec::with_capacity(local_commitment_tx.1.len() + 1);
1709                 self.sign_commitment_transaction(&mut local_commitment_tx.0, &msg.signature);
1710                 new_local_commitment_txn.push(local_commitment_tx.0.clone());
1711
1712                 let mut htlcs_and_sigs = Vec::with_capacity(local_commitment_tx.1.len());
1713                 for (idx, htlc) in local_commitment_tx.1.drain(..).enumerate() {
1714                         let mut htlc_tx = self.build_htlc_transaction(&local_commitment_txid, &htlc, true, &local_keys, feerate_per_kw);
1715                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &local_keys);
1716                         let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
1717                         secp_check!(self.secp_ctx.verify(&htlc_sighash, &msg.htlc_signatures[idx], &local_keys.b_htlc_key), "Invalid HTLC tx signature from peer");
1718                         let htlc_sig = if htlc.offered {
1719                                 let htlc_sig = self.sign_htlc_transaction(&mut htlc_tx, &msg.htlc_signatures[idx], &None, &htlc, &local_keys)?;
1720                                 new_local_commitment_txn.push(htlc_tx);
1721                                 htlc_sig
1722                         } else {
1723                                 self.create_htlc_tx_signature(&htlc_tx, &htlc, &local_keys)?.1
1724                         };
1725                         htlcs_and_sigs.push((htlc, msg.htlc_signatures[idx], htlc_sig));
1726                 }
1727
1728                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(self.cur_local_commitment_transaction_number - 1));
1729                 let per_commitment_secret = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, self.cur_local_commitment_transaction_number + 1);
1730
1731                 // Update state now that we've passed all the can-fail calls...
1732                 let mut need_our_commitment = false;
1733                 if !self.channel_outbound {
1734                         if let Some(fee_update) = self.pending_update_fee {
1735                                 self.feerate_per_kw = fee_update;
1736                                 // We later use the presence of pending_update_fee to indicate we should generate a
1737                                 // commitment_signed upon receipt of revoke_and_ack, so we can only set it to None
1738                                 // if we're not awaiting a revoke (ie will send a commitment_signed now).
1739                                 if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) == 0 {
1740                                         need_our_commitment = true;
1741                                         self.pending_update_fee = None;
1742                                 }
1743                         }
1744                 }
1745
1746                 if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
1747                         // This is a response to our post-monitor-failed unfreeze messages, so we can clear the
1748                         // monitor_pending_order requirement as we won't re-send the monitor_pending messages.
1749                         self.monitor_pending_order = None;
1750                 }
1751
1752                 self.channel_monitor.provide_latest_local_commitment_tx_info(local_commitment_tx.0, local_keys, self.feerate_per_kw, htlcs_and_sigs, local_commitment_tx.2);
1753
1754                 for htlc in self.pending_inbound_htlcs.iter_mut() {
1755                         let new_forward = if let &InboundHTLCState::RemoteAnnounced(ref forward_info) = &htlc.state {
1756                                 Some(forward_info.clone())
1757                         } else { None };
1758                         if let Some(forward_info) = new_forward {
1759                                 htlc.state = InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info);
1760                                 need_our_commitment = true;
1761                         }
1762                 }
1763                 for htlc in self.pending_outbound_htlcs.iter_mut() {
1764                         if let OutboundHTLCState::RemoteRemoved = htlc.state {
1765                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove;
1766                                 need_our_commitment = true;
1767                         }
1768                 }
1769
1770                 self.cur_local_commitment_transaction_number -= 1;
1771                 self.last_local_commitment_txn = new_local_commitment_txn;
1772                 self.received_commitment_while_awaiting_raa = (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) != 0;
1773
1774                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0 {
1775                         self.monitor_pending_revoke_and_ack = true;
1776                         self.monitor_pending_commitment_signed |= need_our_commitment;
1777                         return Err(ChannelError::Ignore("Previous monitor update failure prevented generation of RAA"));
1778                 }
1779
1780                 let (our_commitment_signed, monitor_update, closing_signed) = if need_our_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
1781                         // If we're AwaitingRemoteRevoke we can't send a new commitment here, but that's ok -
1782                         // we'll send one right away when we get the revoke_and_ack when we
1783                         // free_holding_cell_htlcs().
1784                         let (msg, monitor) = self.send_commitment_no_status_check()?;
1785                         (Some(msg), monitor, None)
1786                 } else if !need_our_commitment {
1787                         (None, self.channel_monitor.clone(), self.maybe_propose_first_closing_signed(fee_estimator))
1788                 } else { (None, self.channel_monitor.clone(), None) };
1789
1790                 Ok((msgs::RevokeAndACK {
1791                         channel_id: self.channel_id,
1792                         per_commitment_secret: per_commitment_secret,
1793                         next_per_commitment_point: next_per_commitment_point,
1794                 }, our_commitment_signed, closing_signed, monitor_update))
1795         }
1796
1797         /// Used to fulfill holding_cell_htlcs when we get a remote ack (or implicitly get it by them
1798         /// fulfilling or failing the last pending HTLC)
1799         fn free_holding_cell_htlcs(&mut self) -> Result<Option<(msgs::CommitmentUpdate, ChannelMonitor)>, ChannelError> {
1800                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
1801                 if self.holding_cell_htlc_updates.len() != 0 || self.holding_cell_update_fee.is_some() {
1802                         let mut htlc_updates = Vec::new();
1803                         mem::swap(&mut htlc_updates, &mut self.holding_cell_htlc_updates);
1804                         let mut update_add_htlcs = Vec::with_capacity(htlc_updates.len());
1805                         let mut update_fulfill_htlcs = Vec::with_capacity(htlc_updates.len());
1806                         let mut update_fail_htlcs = Vec::with_capacity(htlc_updates.len());
1807                         let mut err = None;
1808                         for htlc_update in htlc_updates.drain(..) {
1809                                 // Note that this *can* fail, though it should be due to rather-rare conditions on
1810                                 // fee races with adding too many outputs which push our total payments just over
1811                                 // the limit. In case its less rare than I anticipate, we may want to revisit
1812                                 // handling this case better and maybe fufilling some of the HTLCs while attempting
1813                                 // to rebalance channels.
1814                                 if err.is_some() { // We're back to AwaitingRemoteRevoke (or are about to fail the channel)
1815                                         self.holding_cell_htlc_updates.push(htlc_update);
1816                                 } else {
1817                                         match &htlc_update {
1818                                                 &HTLCUpdateAwaitingACK::AddHTLC {amount_msat, cltv_expiry, payment_hash, ref source, ref onion_routing_packet, ..} => {
1819                                                         match self.send_htlc(amount_msat, payment_hash, cltv_expiry, source.clone(), onion_routing_packet.clone()) {
1820                                                                 Ok(update_add_msg_option) => update_add_htlcs.push(update_add_msg_option.unwrap()),
1821                                                                 Err(e) => {
1822                                                                         err = Some(e);
1823                                                                 }
1824                                                         }
1825                                                 },
1826                                                 &HTLCUpdateAwaitingACK::ClaimHTLC { payment_preimage, htlc_id, .. } => {
1827                                                         match self.get_update_fulfill_htlc(htlc_id, payment_preimage) {
1828                                                                 Ok(update_fulfill_msg_option) => update_fulfill_htlcs.push(update_fulfill_msg_option.0.unwrap()),
1829                                                                 Err(e) => {
1830                                                                         if let ChannelError::Ignore(_) = e {}
1831                                                                         else {
1832                                                                                 panic!("Got a non-IgnoreError action trying to fulfill holding cell HTLC");
1833                                                                         }
1834                                                                 }
1835                                                         }
1836                                                 },
1837                                                 &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, ref err_packet } => {
1838                                                         match self.get_update_fail_htlc(htlc_id, err_packet.clone()) {
1839                                                                 Ok(update_fail_msg_option) => update_fail_htlcs.push(update_fail_msg_option.unwrap()),
1840                                                                 Err(e) => {
1841                                                                         if let ChannelError::Ignore(_) = e {}
1842                                                                         else {
1843                                                                                 panic!("Got a non-IgnoreError action trying to fail holding cell HTLC");
1844                                                                         }
1845                                                                 }
1846                                                         }
1847                                                 },
1848                                         }
1849                                         if err.is_some() {
1850                                                 self.holding_cell_htlc_updates.push(htlc_update);
1851                                         }
1852                                 }
1853                         }
1854                         //TODO: Need to examine the type of err - if its a fee issue or similar we may want to
1855                         //fail it back the route, if its a temporary issue we can ignore it...
1856                         match err {
1857                                 None => {
1858                                         if update_add_htlcs.is_empty() && update_fulfill_htlcs.is_empty() && update_fail_htlcs.is_empty() && self.holding_cell_update_fee.is_none() {
1859                                                 // This should never actually happen and indicates we got some Errs back
1860                                                 // from update_fulfill_htlc/update_fail_htlc, but we handle it anyway in
1861                                                 // case there is some strange way to hit duplicate HTLC removes.
1862                                                 return Ok(None);
1863                                         }
1864                                         let update_fee = if let Some(feerate) = self.holding_cell_update_fee {
1865                                                         self.pending_update_fee = self.holding_cell_update_fee.take();
1866                                                         Some(msgs::UpdateFee {
1867                                                                 channel_id: self.channel_id,
1868                                                                 feerate_per_kw: feerate as u32,
1869                                                         })
1870                                                 } else {
1871                                                         None
1872                                                 };
1873                                         let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
1874                                         Ok(Some((msgs::CommitmentUpdate {
1875                                                 update_add_htlcs,
1876                                                 update_fulfill_htlcs,
1877                                                 update_fail_htlcs,
1878                                                 update_fail_malformed_htlcs: Vec::new(),
1879                                                 update_fee: update_fee,
1880                                                 commitment_signed,
1881                                         }, monitor_update)))
1882                                 },
1883                                 Some(e) => Err(e)
1884                         }
1885                 } else {
1886                         Ok(None)
1887                 }
1888         }
1889
1890         /// Handles receiving a remote's revoke_and_ack. Note that we may return a new
1891         /// commitment_signed message here in case we had pending outbound HTLCs to add which were
1892         /// waiting on this revoke_and_ack. The generation of this new commitment_signed may also fail,
1893         /// generating an appropriate error *after* the channel state has been updated based on the
1894         /// revoke_and_ack message.
1895         pub fn revoke_and_ack(&mut self, msg: &msgs::RevokeAndACK, fee_estimator: &FeeEstimator) -> Result<(Option<msgs::CommitmentUpdate>, Vec<(PendingForwardHTLCInfo, u64)>, Vec<(HTLCSource, [u8; 32], HTLCFailReason)>, Option<msgs::ClosingSigned>, ChannelMonitor), ChannelError> {
1896                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1897                         return Err(ChannelError::Close("Got revoke/ACK message when channel was not in an operational state"));
1898                 }
1899                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1900                         return Err(ChannelError::Close("Peer sent revoke_and_ack when we needed a channel_reestablish"));
1901                 }
1902                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
1903                         return Err(ChannelError::Close("Peer sent revoke_and_ack after we'd started exchanging closing_signeds"));
1904                 }
1905
1906                 if let Some(their_prev_commitment_point) = self.their_prev_commitment_point {
1907                         if PublicKey::from_secret_key(&self.secp_ctx, &secp_check!(SecretKey::from_slice(&self.secp_ctx, &msg.per_commitment_secret), "Peer provided an invalid per_commitment_secret")) != their_prev_commitment_point {
1908                                 return Err(ChannelError::Close("Got a revoke commitment secret which didn't correspond to their current pubkey"));
1909                         }
1910                 }
1911                 self.channel_monitor.provide_secret(self.cur_remote_commitment_transaction_number + 1, msg.per_commitment_secret)
1912                         .map_err(|e| ChannelError::Close(e.0))?;
1913
1914                 // Update state now that we've passed all the can-fail calls...
1915                 // (note that we may still fail to generate the new commitment_signed message, but that's
1916                 // OK, we step the channel here and *then* if the new generation fails we can fail the
1917                 // channel based on that, but stepping stuff here should be safe either way.
1918                 self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
1919                 self.their_prev_commitment_point = self.their_cur_commitment_point;
1920                 self.their_cur_commitment_point = Some(msg.next_per_commitment_point);
1921                 self.cur_remote_commitment_transaction_number -= 1;
1922                 self.received_commitment_while_awaiting_raa = false;
1923                 if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
1924                         // This is a response to our post-monitor-failed unfreeze messages, so we can clear the
1925                         // monitor_pending_order requirement as we won't re-send the monitor_pending messages.
1926                         self.monitor_pending_order = None;
1927                 }
1928
1929                 let mut to_forward_infos = Vec::new();
1930                 let mut revoked_htlcs = Vec::new();
1931                 let mut update_fail_htlcs = Vec::new();
1932                 let mut update_fail_malformed_htlcs = Vec::new();
1933                 let mut require_commitment = false;
1934                 let mut value_to_self_msat_diff: i64 = 0;
1935                 // We really shouldnt have two passes here, but retain gives a non-mutable ref (Rust bug)
1936                 self.pending_inbound_htlcs.retain(|htlc| {
1937                         if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
1938                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1939                                         value_to_self_msat_diff += htlc.amount_msat as i64;
1940                                 }
1941                                 false
1942                         } else { true }
1943                 });
1944                 self.pending_outbound_htlcs.retain(|htlc| {
1945                         if let OutboundHTLCState::AwaitingRemovedRemoteRevoke = htlc.state {
1946                                 if let Some(reason) = htlc.fail_reason.clone() { // We really want take() here, but, again, non-mut ref :(
1947                                         revoked_htlcs.push((htlc.source.clone(), htlc.payment_hash, reason));
1948                                 } else {
1949                                         // They fulfilled, so we sent them money
1950                                         value_to_self_msat_diff -= htlc.amount_msat as i64;
1951                                 }
1952                                 false
1953                         } else { true }
1954                 });
1955                 for htlc in self.pending_inbound_htlcs.iter_mut() {
1956                         let swap = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) = &htlc.state {
1957                                 true
1958                         } else if let &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) = &htlc.state {
1959                                 true
1960                         } else { false };
1961                         if swap {
1962                                 let mut state = InboundHTLCState::Committed;
1963                                 mem::swap(&mut state, &mut htlc.state);
1964
1965                                 if let InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info) = state {
1966                                         htlc.state = InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info);
1967                                         require_commitment = true;
1968                                 } else if let InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info) = state {
1969                                         match forward_info {
1970                                                 PendingHTLCStatus::Fail(fail_msg) => {
1971                                                         require_commitment = true;
1972                                                         match fail_msg {
1973                                                                 HTLCFailureMsg::Relay(msg) => {
1974                                                                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(msg.reason.clone()));
1975                                                                         update_fail_htlcs.push(msg)
1976                                                                 },
1977                                                                 HTLCFailureMsg::Malformed(msg) => {
1978                                                                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailMalformed((msg.sha256_of_onion, msg.failure_code)));
1979                                                                         update_fail_malformed_htlcs.push(msg)
1980                                                                 },
1981                                                         }
1982                                                 },
1983                                                 PendingHTLCStatus::Forward(forward_info) => {
1984                                                         to_forward_infos.push((forward_info, htlc.htlc_id));
1985                                                         htlc.state = InboundHTLCState::Committed;
1986                                                 }
1987                                         }
1988                                 }
1989                         }
1990                 }
1991                 for htlc in self.pending_outbound_htlcs.iter_mut() {
1992                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
1993                                 htlc.state = OutboundHTLCState::Committed;
1994                         } else if let OutboundHTLCState::AwaitingRemoteRevokeToRemove = htlc.state {
1995                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke;
1996                                 require_commitment = true;
1997                         }
1998                 }
1999                 self.value_to_self_msat = (self.value_to_self_msat as i64 + value_to_self_msat_diff) as u64;
2000
2001                 if self.channel_outbound {
2002                         if let Some(feerate) = self.pending_update_fee.take() {
2003                                 self.feerate_per_kw = feerate;
2004                         }
2005                 } else {
2006                         if let Some(feerate) = self.pending_update_fee {
2007                                 // Because a node cannot send two commitment_signed's in a row without getting a
2008                                 // revoke_and_ack from us (as it would otherwise not know the per_commitment_point
2009                                 // it should use to create keys with) and because a node can't send a
2010                                 // commitment_signed without changes, checking if the feerate is equal to the
2011                                 // pending feerate update is sufficient to detect require_commitment.
2012                                 if feerate == self.feerate_per_kw {
2013                                         require_commitment = true;
2014                                         self.pending_update_fee = None;
2015                                 }
2016                         }
2017                 }
2018
2019                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) == ChannelState::MonitorUpdateFailed as u32 {
2020                         // We can't actually generate a new commitment transaction (incl by freeing holding
2021                         // cells) while we can't update the monitor, so we just return what we have.
2022                         if require_commitment {
2023                                 self.monitor_pending_commitment_signed = true;
2024                         }
2025                         self.monitor_pending_forwards.append(&mut to_forward_infos);
2026                         self.monitor_pending_failures.append(&mut revoked_htlcs);
2027                         return Ok((None, Vec::new(), Vec::new(), None, self.channel_monitor.clone()));
2028                 }
2029
2030                 match self.free_holding_cell_htlcs()? {
2031                         Some(mut commitment_update) => {
2032                                 commitment_update.0.update_fail_htlcs.reserve(update_fail_htlcs.len());
2033                                 for fail_msg in update_fail_htlcs.drain(..) {
2034                                         commitment_update.0.update_fail_htlcs.push(fail_msg);
2035                                 }
2036                                 commitment_update.0.update_fail_malformed_htlcs.reserve(update_fail_malformed_htlcs.len());
2037                                 for fail_msg in update_fail_malformed_htlcs.drain(..) {
2038                                         commitment_update.0.update_fail_malformed_htlcs.push(fail_msg);
2039                                 }
2040                                 Ok((Some(commitment_update.0), to_forward_infos, revoked_htlcs, None, commitment_update.1))
2041                         },
2042                         None => {
2043                                 if require_commitment {
2044                                         let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
2045                                         Ok((Some(msgs::CommitmentUpdate {
2046                                                 update_add_htlcs: Vec::new(),
2047                                                 update_fulfill_htlcs: Vec::new(),
2048                                                 update_fail_htlcs,
2049                                                 update_fail_malformed_htlcs,
2050                                                 update_fee: None,
2051                                                 commitment_signed
2052                                         }), to_forward_infos, revoked_htlcs, None, monitor_update))
2053                                 } else {
2054                                         Ok((None, to_forward_infos, revoked_htlcs, self.maybe_propose_first_closing_signed(fee_estimator), self.channel_monitor.clone()))
2055                                 }
2056                         }
2057                 }
2058
2059         }
2060
2061         /// Adds a pending update to this channel. See the doc for send_htlc for
2062         /// further details on the optionness of the return value.
2063         /// You MUST call send_commitment prior to any other calls on this Channel
2064         fn send_update_fee(&mut self, feerate_per_kw: u64) -> Option<msgs::UpdateFee> {
2065                 if !self.channel_outbound {
2066                         panic!("Cannot send fee from inbound channel");
2067                 }
2068                 if !self.is_usable() {
2069                         panic!("Cannot update fee until channel is fully established and we haven't started shutting down");
2070                 }
2071                 if !self.is_live() {
2072                         panic!("Cannot update fee while peer is disconnected/we're awaiting a monitor update (ChannelManager should have caught this)");
2073                 }
2074
2075                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
2076                         self.holding_cell_update_fee = Some(feerate_per_kw);
2077                         return None;
2078                 }
2079
2080                 debug_assert!(self.pending_update_fee.is_none());
2081                 self.pending_update_fee = Some(feerate_per_kw);
2082
2083                 Some(msgs::UpdateFee {
2084                         channel_id: self.channel_id,
2085                         feerate_per_kw: feerate_per_kw as u32,
2086                 })
2087         }
2088
2089         pub fn send_update_fee_and_commit(&mut self, feerate_per_kw: u64) -> Result<Option<(msgs::UpdateFee, msgs::CommitmentSigned, ChannelMonitor)>, ChannelError> {
2090                 match self.send_update_fee(feerate_per_kw) {
2091                         Some(update_fee) => {
2092                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
2093                                 Ok(Some((update_fee, commitment_signed, monitor_update)))
2094                         },
2095                         None => Ok(None)
2096                 }
2097         }
2098
2099         /// Removes any uncommitted HTLCs, to be used on peer disconnection, including any pending
2100         /// HTLCs that we intended to add but haven't as we were waiting on a remote revoke.
2101         /// Returns the set of PendingHTLCStatuses from remote uncommitted HTLCs (which we're
2102         /// implicitly dropping) and the payment_hashes of HTLCs we tried to add but are dropping.
2103         /// No further message handling calls may be made until a channel_reestablish dance has
2104         /// completed.
2105         pub fn remove_uncommitted_htlcs_and_mark_paused(&mut self) -> Vec<(HTLCSource, [u8; 32])> {
2106                 let mut outbound_drops = Vec::new();
2107
2108                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
2109                 if self.channel_state < ChannelState::FundingSent as u32 {
2110                         self.channel_state = ChannelState::ShutdownComplete as u32;
2111                         return outbound_drops;
2112                 }
2113                 // Upon reconnect we have to start the closing_signed dance over, but shutdown messages
2114                 // will be retransmitted.
2115                 self.last_sent_closing_fee = None;
2116
2117                 let mut inbound_drop_count = 0;
2118                 self.pending_inbound_htlcs.retain(|htlc| {
2119                         match htlc.state {
2120                                 InboundHTLCState::RemoteAnnounced(_) => {
2121                                         // They sent us an update_add_htlc but we never got the commitment_signed.
2122                                         // We'll tell them what commitment_signed we're expecting next and they'll drop
2123                                         // this HTLC accordingly
2124                                         inbound_drop_count += 1;
2125                                         false
2126                                 },
2127                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_)|InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => {
2128                                         // We received a commitment_signed updating this HTLC and (at least hopefully)
2129                                         // sent a revoke_and_ack (which we can re-transmit) and have heard nothing
2130                                         // in response to it yet, so don't touch it.
2131                                         true
2132                                 },
2133                                 InboundHTLCState::Committed => true,
2134                                 InboundHTLCState::LocalRemoved(_) => {
2135                                         // We (hopefully) sent a commitment_signed updating this HTLC (which we can
2136                                         // re-transmit if needed) and they may have even sent a revoke_and_ack back
2137                                         // (that we missed). Keep this around for now and if they tell us they missed
2138                                         // the commitment_signed we can re-transmit the update then.
2139                                         true
2140                                 },
2141                         }
2142                 });
2143                 self.next_remote_htlc_id -= inbound_drop_count;
2144
2145                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2146                         if let OutboundHTLCState::RemoteRemoved = htlc.state {
2147                                 // They sent us an update to remove this but haven't yet sent the corresponding
2148                                 // commitment_signed, we need to move it back to Committed and they can re-send
2149                                 // the update upon reconnection.
2150                                 htlc.state = OutboundHTLCState::Committed;
2151                         }
2152                 }
2153
2154                 self.holding_cell_htlc_updates.retain(|htlc_update| {
2155                         match htlc_update {
2156                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
2157                                         outbound_drops.push((source.clone(), payment_hash.clone()));
2158                                         false
2159                                 },
2160                                 &HTLCUpdateAwaitingACK::ClaimHTLC {..} | &HTLCUpdateAwaitingACK::FailHTLC {..} => true,
2161                         }
2162                 });
2163                 self.channel_state |= ChannelState::PeerDisconnected as u32;
2164                 log_debug!(self, "Peer disconnection resulted in {} remote-announced HTLC drops and {} waiting-to-locally-announced HTLC drops on channel {}", outbound_drops.len(), inbound_drop_count, log_bytes!(self.channel_id()));
2165                 outbound_drops
2166         }
2167
2168         /// Indicates that a ChannelMonitor update failed to be stored by the client and further
2169         /// updates are partially paused.
2170         /// This must be called immediately after the call which generated the ChannelMonitor update
2171         /// which failed, with the order argument set to the type of call it represented (ie a
2172         /// commitment update or a revoke_and_ack generation). The messages which were generated from
2173         /// that original call must *not* have been sent to the remote end, and must instead have been
2174         /// dropped. They will be regenerated when monitor_updating_restored is called.
2175         pub fn monitor_update_failed(&mut self, order: RAACommitmentOrder, mut pending_forwards: Vec<(PendingForwardHTLCInfo, u64)>, mut pending_fails: Vec<(HTLCSource, [u8; 32], HTLCFailReason)>, raa_first_dropped_cs: bool) {
2176                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
2177                 match order {
2178                         RAACommitmentOrder::CommitmentFirst => {
2179                                 self.monitor_pending_revoke_and_ack = false;
2180                                 self.monitor_pending_commitment_signed = true;
2181                         },
2182                         RAACommitmentOrder::RevokeAndACKFirst => {
2183                                 self.monitor_pending_revoke_and_ack = true;
2184                                 self.monitor_pending_commitment_signed = raa_first_dropped_cs;
2185                         },
2186                 }
2187                 assert!(self.monitor_pending_forwards.is_empty());
2188                 mem::swap(&mut pending_forwards, &mut self.monitor_pending_forwards);
2189                 assert!(self.monitor_pending_failures.is_empty());
2190                 mem::swap(&mut pending_fails, &mut self.monitor_pending_failures);
2191                 self.monitor_pending_order = Some(order);
2192                 self.channel_state |= ChannelState::MonitorUpdateFailed as u32;
2193         }
2194
2195         /// Indicates that the latest ChannelMonitor update has been committed by the client
2196         /// successfully and we should restore normal operation. Returns messages which should be sent
2197         /// to the remote side.
2198         pub fn monitor_updating_restored(&mut self) -> (Option<msgs::RevokeAndACK>, Option<msgs::CommitmentUpdate>, RAACommitmentOrder, Vec<(PendingForwardHTLCInfo, u64)>, Vec<(HTLCSource, [u8; 32], HTLCFailReason)>) {
2199                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, ChannelState::MonitorUpdateFailed as u32);
2200                 self.channel_state &= !(ChannelState::MonitorUpdateFailed as u32);
2201
2202                 let mut forwards = Vec::new();
2203                 mem::swap(&mut forwards, &mut self.monitor_pending_forwards);
2204                 let mut failures = Vec::new();
2205                 mem::swap(&mut failures, &mut self.monitor_pending_failures);
2206
2207                 if self.channel_state & (ChannelState::PeerDisconnected as u32) != 0 {
2208                         // Leave monitor_pending_order so we can order our channel_reestablish responses
2209                         self.monitor_pending_revoke_and_ack = false;
2210                         self.monitor_pending_commitment_signed = false;
2211                         return (None, None, RAACommitmentOrder::RevokeAndACKFirst, forwards, failures);
2212                 }
2213
2214                 let raa = if self.monitor_pending_revoke_and_ack {
2215                         Some(self.get_last_revoke_and_ack())
2216                 } else { None };
2217                 let commitment_update = if self.monitor_pending_commitment_signed {
2218                         Some(self.get_last_commitment_update())
2219                 } else { None };
2220
2221                 self.monitor_pending_revoke_and_ack = false;
2222                 self.monitor_pending_commitment_signed = false;
2223                 (raa, commitment_update, self.monitor_pending_order.clone().unwrap(), forwards, failures)
2224         }
2225
2226         pub fn update_fee(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::UpdateFee) -> Result<(), ChannelError> {
2227                 if self.channel_outbound {
2228                         return Err(ChannelError::Close("Non-funding remote tried to update channel fee"));
2229                 }
2230                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2231                         return Err(ChannelError::Close("Peer sent update_fee when we needed a channel_reestablish"));
2232                 }
2233                 Channel::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
2234                 self.pending_update_fee = Some(msg.feerate_per_kw as u64);
2235                 self.channel_update_count += 1;
2236                 Ok(())
2237         }
2238
2239         fn get_last_revoke_and_ack(&self) -> msgs::RevokeAndACK {
2240                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(self.cur_local_commitment_transaction_number));
2241                 let per_commitment_secret = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, self.cur_local_commitment_transaction_number + 2);
2242                 msgs::RevokeAndACK {
2243                         channel_id: self.channel_id,
2244                         per_commitment_secret,
2245                         next_per_commitment_point,
2246                 }
2247         }
2248
2249         fn get_last_commitment_update(&self) -> msgs::CommitmentUpdate {
2250                 let mut update_add_htlcs = Vec::new();
2251                 let mut update_fulfill_htlcs = Vec::new();
2252                 let mut update_fail_htlcs = Vec::new();
2253                 let mut update_fail_malformed_htlcs = Vec::new();
2254
2255                 for htlc in self.pending_outbound_htlcs.iter() {
2256                         if let &OutboundHTLCState::LocalAnnounced(ref onion_packet) = &htlc.state {
2257                                 update_add_htlcs.push(msgs::UpdateAddHTLC {
2258                                         channel_id: self.channel_id(),
2259                                         htlc_id: htlc.htlc_id,
2260                                         amount_msat: htlc.amount_msat,
2261                                         payment_hash: htlc.payment_hash,
2262                                         cltv_expiry: htlc.cltv_expiry,
2263                                         onion_routing_packet: (**onion_packet).clone(),
2264                                 });
2265                         }
2266                 }
2267
2268                 for htlc in self.pending_inbound_htlcs.iter() {
2269                         if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
2270                                 match reason {
2271                                         &InboundHTLCRemovalReason::FailRelay(ref err_packet) => {
2272                                                 update_fail_htlcs.push(msgs::UpdateFailHTLC {
2273                                                         channel_id: self.channel_id(),
2274                                                         htlc_id: htlc.htlc_id,
2275                                                         reason: err_packet.clone()
2276                                                 });
2277                                         },
2278                                         &InboundHTLCRemovalReason::FailMalformed((ref sha256_of_onion, ref failure_code)) => {
2279                                                 update_fail_malformed_htlcs.push(msgs::UpdateFailMalformedHTLC {
2280                                                         channel_id: self.channel_id(),
2281                                                         htlc_id: htlc.htlc_id,
2282                                                         sha256_of_onion: sha256_of_onion.clone(),
2283                                                         failure_code: failure_code.clone(),
2284                                                 });
2285                                         },
2286                                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
2287                                                 update_fulfill_htlcs.push(msgs::UpdateFulfillHTLC {
2288                                                         channel_id: self.channel_id(),
2289                                                         htlc_id: htlc.htlc_id,
2290                                                         payment_preimage: payment_preimage.clone(),
2291                                                 });
2292                                         },
2293                                 }
2294                         }
2295                 }
2296
2297                 msgs::CommitmentUpdate {
2298                         update_add_htlcs, update_fulfill_htlcs, update_fail_htlcs, update_fail_malformed_htlcs,
2299                         update_fee: None, //TODO: We need to support re-generating any update_fees in the last commitment_signed!
2300                         commitment_signed: self.send_commitment_no_state_update().expect("It looks like we failed to re-generate a commitment_signed we had previously sent?").0,
2301                 }
2302         }
2303
2304         /// May panic if some calls other than message-handling calls (which will all Err immediately)
2305         /// have been called between remove_uncommitted_htlcs_and_mark_paused and this call.
2306         pub fn channel_reestablish(&mut self, msg: &msgs::ChannelReestablish) -> Result<(Option<msgs::FundingLocked>, Option<msgs::RevokeAndACK>, Option<msgs::CommitmentUpdate>, Option<ChannelMonitor>, RAACommitmentOrder, Option<msgs::Shutdown>), ChannelError> {
2307                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
2308                         // While BOLT 2 doesn't indicate explicitly we should error this channel here, it
2309                         // almost certainly indicates we are going to end up out-of-sync in some way, so we
2310                         // just close here instead of trying to recover.
2311                         return Err(ChannelError::Close("Peer sent a loose channel_reestablish not after reconnect"));
2312                 }
2313
2314                 if msg.next_local_commitment_number >= INITIAL_COMMITMENT_NUMBER || msg.next_remote_commitment_number >= INITIAL_COMMITMENT_NUMBER ||
2315                         msg.next_local_commitment_number == 0 {
2316                         return Err(ChannelError::Close("Peer sent a garbage channel_reestablish"));
2317                 }
2318
2319                 // Go ahead and unmark PeerDisconnected as various calls we may make check for it (and all
2320                 // remaining cases either succeed or ErrorMessage-fail).
2321                 self.channel_state &= !(ChannelState::PeerDisconnected as u32);
2322
2323                 let shutdown_msg = if self.channel_state & (ChannelState::LocalShutdownSent as u32) != 0 {
2324                         Some(msgs::Shutdown {
2325                                 channel_id: self.channel_id,
2326                                 scriptpubkey: self.get_closing_scriptpubkey(),
2327                         })
2328                 } else { None };
2329
2330                 if self.channel_state & (ChannelState::FundingSent as u32) == ChannelState::FundingSent as u32 {
2331                         if self.channel_state & ChannelState::OurFundingLocked as u32 == 0 {
2332                                 if msg.next_remote_commitment_number != 0 {
2333                                         return Err(ChannelError::Close("Peer claimed they saw a revoke_and_ack but we haven't sent funding_locked yet"));
2334                                 }
2335                                 // Short circuit the whole handler as there is nothing we can resend them
2336                                 return Ok((None, None, None, None, RAACommitmentOrder::CommitmentFirst, shutdown_msg));
2337                         }
2338
2339                         // We have OurFundingLocked set!
2340                         let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2341                         let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2342                         return Ok((Some(msgs::FundingLocked {
2343                                 channel_id: self.channel_id(),
2344                                 next_per_commitment_point: next_per_commitment_point,
2345                         }), None, None, None, RAACommitmentOrder::CommitmentFirst, shutdown_msg));
2346                 }
2347
2348                 let required_revoke = if msg.next_remote_commitment_number + 1 == INITIAL_COMMITMENT_NUMBER - self.cur_local_commitment_transaction_number {
2349                         // Remote isn't waiting on any RevokeAndACK from us!
2350                         // Note that if we need to repeat our FundingLocked we'll do that in the next if block.
2351                         None
2352                 } else if msg.next_remote_commitment_number + 1 == (INITIAL_COMMITMENT_NUMBER - 1) - self.cur_local_commitment_transaction_number {
2353                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
2354                                 self.monitor_pending_revoke_and_ack = true;
2355                                 None
2356                         } else {
2357                                 Some(self.get_last_revoke_and_ack())
2358                         }
2359                 } else {
2360                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old local commitment transaction"));
2361                 };
2362
2363                 // We increment cur_remote_commitment_transaction_number only upon receipt of
2364                 // revoke_and_ack, not on sending commitment_signed, so we add one if have
2365                 // AwaitingRemoteRevoke set, which indicates we sent a commitment_signed but haven't gotten
2366                 // the corresponding revoke_and_ack back yet.
2367                 let our_next_remote_commitment_number = INITIAL_COMMITMENT_NUMBER - self.cur_remote_commitment_transaction_number + if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 };
2368
2369                 let resend_funding_locked = if msg.next_local_commitment_number == 1 && INITIAL_COMMITMENT_NUMBER - self.cur_local_commitment_transaction_number == 1 {
2370                         // We should never have to worry about MonitorUpdateFailed resending FundingLocked
2371                         let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2372                         let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2373                         Some(msgs::FundingLocked {
2374                                 channel_id: self.channel_id(),
2375                                 next_per_commitment_point: next_per_commitment_point,
2376                         })
2377                 } else { None };
2378
2379                 let order = self.monitor_pending_order.clone().unwrap_or(if self.received_commitment_while_awaiting_raa {
2380                                 RAACommitmentOrder::CommitmentFirst
2381                         } else {
2382                                 RAACommitmentOrder::RevokeAndACKFirst
2383                         });
2384
2385                 if msg.next_local_commitment_number == our_next_remote_commitment_number {
2386                         if required_revoke.is_some() {
2387                                 log_debug!(self, "Reconnected channel {} with only lost outbound RAA", log_bytes!(self.channel_id()));
2388                         } else {
2389                                 log_debug!(self, "Reconnected channel {} with no loss", log_bytes!(self.channel_id()));
2390                         }
2391
2392                         if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 &&
2393                                         self.monitor_pending_order.is_none() { // monitor_pending_order indicates we're waiting on a response to a unfreeze
2394                                 // We're up-to-date and not waiting on a remote revoke (if we are our
2395                                 // channel_reestablish should result in them sending a revoke_and_ack), but we may
2396                                 // have received some updates while we were disconnected. Free the holding cell
2397                                 // now!
2398                                 match self.free_holding_cell_htlcs() {
2399                                         Err(ChannelError::Close(msg)) => return Err(ChannelError::Close(msg)),
2400                                         Err(ChannelError::Ignore(_)) => panic!("Got non-channel-failing result from free_holding_cell_htlcs"),
2401                                         Ok(Some((commitment_update, channel_monitor))) => return Ok((resend_funding_locked, required_revoke, Some(commitment_update), Some(channel_monitor), order, shutdown_msg)),
2402                                         Ok(None) => return Ok((resend_funding_locked, required_revoke, None, None, order, shutdown_msg)),
2403                                 }
2404                         } else {
2405                                 return Ok((resend_funding_locked, required_revoke, None, None, order, shutdown_msg));
2406                         }
2407                 } else if msg.next_local_commitment_number == our_next_remote_commitment_number - 1 {
2408                         if required_revoke.is_some() {
2409                                 log_debug!(self, "Reconnected channel {} with lost outbound RAA and lost remote commitment tx", log_bytes!(self.channel_id()));
2410                         } else {
2411                                 log_debug!(self, "Reconnected channel {} with only lost remote commitment tx", log_bytes!(self.channel_id()));
2412                         }
2413
2414                         // If monitor_pending_order is set, it must be CommitmentSigned if we have no RAA
2415                         debug_assert!(self.monitor_pending_order != Some(RAACommitmentOrder::RevokeAndACKFirst) || required_revoke.is_some());
2416
2417                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
2418                                 self.monitor_pending_commitment_signed = true;
2419                                 return Ok((resend_funding_locked, None, None, None, order, shutdown_msg));
2420                         }
2421
2422                         return Ok((resend_funding_locked, required_revoke, Some(self.get_last_commitment_update()), None, order, shutdown_msg));
2423                 } else {
2424                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction"));
2425                 }
2426         }
2427
2428         fn maybe_propose_first_closing_signed(&mut self, fee_estimator: &FeeEstimator) -> Option<msgs::ClosingSigned> {
2429                 if !self.channel_outbound || !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() ||
2430                                 self.channel_state & (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::AwaitingRemoteRevoke as u32) != BOTH_SIDES_SHUTDOWN_MASK ||
2431                                 self.last_sent_closing_fee.is_some() || self.pending_update_fee.is_some() {
2432                         return None;
2433                 }
2434
2435                 let mut proposed_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
2436                 if self.feerate_per_kw > proposed_feerate {
2437                         proposed_feerate = self.feerate_per_kw;
2438                 }
2439                 let tx_weight = Self::get_closing_transaction_weight(&self.get_closing_scriptpubkey(), self.their_shutdown_scriptpubkey.as_ref().unwrap());
2440                 let proposed_total_fee_satoshis = proposed_feerate * tx_weight / 1000;
2441
2442                 let (closing_tx, total_fee_satoshis) = self.build_closing_transaction(proposed_total_fee_satoshis, false);
2443                 let funding_redeemscript = self.get_funding_redeemscript();
2444                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
2445
2446                 self.last_sent_closing_fee = Some((proposed_feerate, total_fee_satoshis));
2447                 Some(msgs::ClosingSigned {
2448                         channel_id: self.channel_id,
2449                         fee_satoshis: total_fee_satoshis,
2450                         signature: self.secp_ctx.sign(&sighash, &self.local_keys.funding_key),
2451                 })
2452         }
2453
2454         pub fn shutdown(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::Shutdown) -> Result<(Option<msgs::Shutdown>, Option<msgs::ClosingSigned>, Vec<(HTLCSource, [u8; 32])>), ChannelError> {
2455                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2456                         return Err(ChannelError::Close("Peer sent shutdown when we needed a channel_reestablish"));
2457                 }
2458                 if self.channel_state < ChannelState::FundingSent as u32 {
2459                         // Spec says we should fail the connection, not the channel, but that's nonsense, there
2460                         // are plenty of reasons you may want to fail a channel pre-funding, and spec says you
2461                         // can do that via error message without getting a connection fail anyway...
2462                         return Err(ChannelError::Close("Peer sent shutdown pre-funding generation"));
2463                 }
2464                 for htlc in self.pending_inbound_htlcs.iter() {
2465                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
2466                                 return Err(ChannelError::Close("Got shutdown with remote pending HTLCs"));
2467                         }
2468                 }
2469                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
2470
2471                 // BOLT 2 says we must only send a scriptpubkey of certain standard forms, which are up to
2472                 // 34 bytes in length, so dont let the remote peer feed us some super fee-heavy script.
2473                 if self.channel_outbound && msg.scriptpubkey.len() > 34 {
2474                         return Err(ChannelError::Close("Got shutdown_scriptpubkey of absurd length from remote peer"));
2475                 }
2476
2477                 //Check shutdown_scriptpubkey form as BOLT says we must
2478                 if !msg.scriptpubkey.is_p2pkh() && !msg.scriptpubkey.is_p2sh() && !msg.scriptpubkey.is_v0_p2wpkh() && !msg.scriptpubkey.is_v0_p2wsh() {
2479                         return Err(ChannelError::Close("Got a nonstandard scriptpubkey from remote peer"));
2480                 }
2481
2482                 if self.their_shutdown_scriptpubkey.is_some() {
2483                         if Some(&msg.scriptpubkey) != self.their_shutdown_scriptpubkey.as_ref() {
2484                                 return Err(ChannelError::Close("Got shutdown request with a scriptpubkey which did not match their previous scriptpubkey"));
2485                         }
2486                 } else {
2487                         self.their_shutdown_scriptpubkey = Some(msg.scriptpubkey.clone());
2488                 }
2489
2490                 // From here on out, we may not fail!
2491
2492                 self.channel_state |= ChannelState::RemoteShutdownSent as u32;
2493                 self.channel_update_count += 1;
2494
2495                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
2496                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
2497                 // cell HTLCs and return them to fail the payment.
2498                 self.holding_cell_update_fee = None;
2499                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
2500                 self.holding_cell_htlc_updates.retain(|htlc_update| {
2501                         match htlc_update {
2502                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
2503                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
2504                                         false
2505                                 },
2506                                 _ => true
2507                         }
2508                 });
2509                 // If we have any LocalAnnounced updates we'll probably just get back a update_fail_htlc
2510                 // immediately after the commitment dance, but we can send a Shutdown cause we won't send
2511                 // any further commitment updates after we set LocalShutdownSent.
2512
2513                 let our_shutdown = if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
2514                         None
2515                 } else {
2516                         Some(msgs::Shutdown {
2517                                 channel_id: self.channel_id,
2518                                 scriptpubkey: self.get_closing_scriptpubkey(),
2519                         })
2520                 };
2521
2522                 self.channel_state |= ChannelState::LocalShutdownSent as u32;
2523                 self.channel_update_count += 1;
2524                 Ok((our_shutdown, self.maybe_propose_first_closing_signed(fee_estimator), dropped_outbound_htlcs))
2525         }
2526
2527         pub fn closing_signed(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::ClosingSigned) -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError> {
2528                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != BOTH_SIDES_SHUTDOWN_MASK {
2529                         return Err(ChannelError::Close("Remote end sent us a closing_signed before both sides provided a shutdown"));
2530                 }
2531                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2532                         return Err(ChannelError::Close("Peer sent closing_signed when we needed a channel_reestablish"));
2533                 }
2534                 if !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() {
2535                         return Err(ChannelError::Close("Remote end sent us a closing_signed while there were still pending HTLCs"));
2536                 }
2537                 if msg.fee_satoshis > 21000000 * 10000000 { //this is required to stop potential overflow in build_closing_transaction
2538                         return Err(ChannelError::Close("Remote tried to send us a closing tx with > 21 million BTC fee"));
2539                 }
2540
2541                 let funding_redeemscript = self.get_funding_redeemscript();
2542                 let (mut closing_tx, used_total_fee) = self.build_closing_transaction(msg.fee_satoshis, false);
2543                 if used_total_fee != msg.fee_satoshis {
2544                         return Err(ChannelError::Close("Remote sent us a closing_signed with a fee greater than the value they can claim"));
2545                 }
2546                 let mut sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
2547
2548                 match self.secp_ctx.verify(&sighash, &msg.signature, &self.their_funding_pubkey.unwrap()) {
2549                         Ok(_) => {},
2550                         Err(_e) => {
2551                                 // The remote end may have decided to revoke their output due to inconsistent dust
2552                                 // limits, so check for that case by re-checking the signature here.
2553                                 closing_tx = self.build_closing_transaction(msg.fee_satoshis, true).0;
2554                                 sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
2555                                 secp_check!(self.secp_ctx.verify(&sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid closing tx signature from peer");
2556                         },
2557                 };
2558
2559                 if let Some((_, last_fee)) = self.last_sent_closing_fee {
2560                         if last_fee == msg.fee_satoshis {
2561                                 self.sign_commitment_transaction(&mut closing_tx, &msg.signature);
2562                                 self.channel_state = ChannelState::ShutdownComplete as u32;
2563                                 self.channel_update_count += 1;
2564                                 return Ok((None, Some(closing_tx)));
2565                         }
2566                 }
2567
2568                 macro_rules! propose_new_feerate {
2569                         ($new_feerate: expr) => {
2570                                 let closing_tx_max_weight = Self::get_closing_transaction_weight(&self.get_closing_scriptpubkey(), self.their_shutdown_scriptpubkey.as_ref().unwrap());
2571                                 let (closing_tx, used_total_fee) = self.build_closing_transaction($new_feerate * closing_tx_max_weight / 1000, false);
2572                                 sighash = Message::from_slice(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]).unwrap();
2573                                 let our_sig = self.secp_ctx.sign(&sighash, &self.local_keys.funding_key);
2574                                 self.last_sent_closing_fee = Some(($new_feerate, used_total_fee));
2575                                 return Ok((Some(msgs::ClosingSigned {
2576                                         channel_id: self.channel_id,
2577                                         fee_satoshis: used_total_fee,
2578                                         signature: our_sig,
2579                                 }), None))
2580                         }
2581                 }
2582
2583                 let proposed_sat_per_kw = msg.fee_satoshis * 1000 / closing_tx.get_weight();
2584                 if self.channel_outbound {
2585                         let our_max_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
2586                         if proposed_sat_per_kw > our_max_feerate {
2587                                 if let Some((last_feerate, _)) = self.last_sent_closing_fee {
2588                                         if our_max_feerate <= last_feerate {
2589                                                 return Err(ChannelError::Close("Unable to come to consensus about closing feerate, remote wanted something higher than our Normal feerate"));
2590                                         }
2591                                 }
2592                                 propose_new_feerate!(our_max_feerate);
2593                         }
2594                 } else {
2595                         let our_min_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
2596                         if proposed_sat_per_kw < our_min_feerate {
2597                                 if let Some((last_feerate, _)) = self.last_sent_closing_fee {
2598                                         if our_min_feerate >= last_feerate {
2599                                                 return Err(ChannelError::Close("Unable to come to consensus about closing feerate, remote wanted something lower than our Background feerate"));
2600                                         }
2601                                 }
2602                                 propose_new_feerate!(our_min_feerate);
2603                         }
2604                 }
2605
2606                 let our_sig = self.sign_commitment_transaction(&mut closing_tx, &msg.signature);
2607                 self.channel_state = ChannelState::ShutdownComplete as u32;
2608                 self.channel_update_count += 1;
2609
2610                 Ok((Some(msgs::ClosingSigned {
2611                         channel_id: self.channel_id,
2612                         fee_satoshis: msg.fee_satoshis,
2613                         signature: our_sig,
2614                 }), Some(closing_tx)))
2615         }
2616
2617         // Public utilities:
2618
2619         pub fn channel_id(&self) -> [u8; 32] {
2620                 self.channel_id
2621         }
2622
2623         /// Gets the "user_id" value passed into the construction of this channel. It has no special
2624         /// meaning and exists only to allow users to have a persistent identifier of a channel.
2625         pub fn get_user_id(&self) -> u64 {
2626                 self.user_id
2627         }
2628
2629         /// May only be called after funding has been initiated (ie is_funding_initiated() is true)
2630         pub fn channel_monitor(&self) -> ChannelMonitor {
2631                 if self.channel_state < ChannelState::FundingCreated as u32 {
2632                         panic!("Can't get a channel monitor until funding has been created");
2633                 }
2634                 self.channel_monitor.clone()
2635         }
2636
2637         /// Guaranteed to be Some after both FundingLocked messages have been exchanged (and, thus,
2638         /// is_usable() returns true).
2639         /// Allowed in any state (including after shutdown)
2640         pub fn get_short_channel_id(&self) -> Option<u64> {
2641                 self.short_channel_id
2642         }
2643
2644         /// Returns the funding_txo we either got from our peer, or were given by
2645         /// get_outbound_funding_created.
2646         pub fn get_funding_txo(&self) -> Option<OutPoint> {
2647                 self.channel_monitor.get_funding_txo()
2648         }
2649
2650         /// Allowed in any state (including after shutdown)
2651         pub fn get_their_node_id(&self) -> PublicKey {
2652                 self.their_node_id
2653         }
2654
2655         /// Allowed in any state (including after shutdown)
2656         pub fn get_our_htlc_minimum_msat(&self) -> u64 {
2657                 self.our_htlc_minimum_msat
2658         }
2659
2660         /// Allowed in any state (including after shutdown)
2661         pub fn get_their_htlc_minimum_msat(&self) -> u64 {
2662                 self.our_htlc_minimum_msat
2663         }
2664
2665         pub fn get_value_satoshis(&self) -> u64 {
2666                 self.channel_value_satoshis
2667         }
2668
2669         pub fn get_fee_proportional_millionths(&self) -> u32 {
2670                 self.config.fee_proportional_millionths
2671         }
2672
2673         #[cfg(test)]
2674         pub fn get_feerate(&self) -> u64 {
2675                 self.feerate_per_kw
2676         }
2677
2678         pub fn get_cur_local_commitment_transaction_number(&self) -> u64 {
2679                 self.cur_local_commitment_transaction_number + 1
2680         }
2681
2682         pub fn get_cur_remote_commitment_transaction_number(&self) -> u64 {
2683                 self.cur_remote_commitment_transaction_number + 1 - if self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 }
2684         }
2685
2686         pub fn get_revoked_remote_commitment_transaction_number(&self) -> u64 {
2687                 self.cur_remote_commitment_transaction_number + 2
2688         }
2689
2690         //TODO: Testing purpose only, should be changed in another way after #81
2691         #[cfg(test)]
2692         pub fn get_local_keys(&self) -> &ChannelKeys {
2693                 &self.local_keys
2694         }
2695
2696         #[cfg(test)]
2697         pub fn get_value_stat(&self) -> ChannelValueStat {
2698                 ChannelValueStat {
2699                         value_to_self_msat: self.value_to_self_msat,
2700                         channel_value_msat: self.channel_value_satoshis * 1000,
2701                         channel_reserve_msat: self.their_channel_reserve_satoshis * 1000,
2702                         pending_outbound_htlcs_amount_msat: self.pending_outbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
2703                         pending_inbound_htlcs_amount_msat: self.pending_inbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
2704                         holding_cell_outbound_amount_msat: {
2705                                 let mut res = 0;
2706                                 for h in self.holding_cell_htlc_updates.iter() {
2707                                         match h {
2708                                                 &HTLCUpdateAwaitingACK::AddHTLC{amount_msat, .. } => {
2709                                                         res += amount_msat;
2710                                                 }
2711                                                 _ => {}
2712                                         }
2713                                 }
2714                                 res
2715                         },
2716                         their_max_htlc_value_in_flight_msat: self.their_max_htlc_value_in_flight_msat,
2717                 }
2718         }
2719
2720         /// Allowed in any state (including after shutdown)
2721         pub fn get_channel_update_count(&self) -> u32 {
2722                 self.channel_update_count
2723         }
2724
2725         pub fn should_announce(&self) -> bool {
2726                 self.config.announced_channel
2727         }
2728
2729         pub fn is_outbound(&self) -> bool {
2730                 self.channel_outbound
2731         }
2732
2733         /// Gets the fee we'd want to charge for adding an HTLC output to this Channel
2734         /// Allowed in any state (including after shutdown)
2735         pub fn get_our_fee_base_msat(&self, fee_estimator: &FeeEstimator) -> u32 {
2736                 // For lack of a better metric, we calculate what it would cost to consolidate the new HTLC
2737                 // output value back into a transaction with the regular channel output:
2738
2739                 // the fee cost of the HTLC-Success/HTLC-Timeout transaction:
2740                 let mut res = self.feerate_per_kw * cmp::max(HTLC_TIMEOUT_TX_WEIGHT, HTLC_SUCCESS_TX_WEIGHT) / 1000;
2741
2742                 if self.channel_outbound {
2743                         // + the marginal fee increase cost to us in the commitment transaction:
2744                         res += self.feerate_per_kw * COMMITMENT_TX_WEIGHT_PER_HTLC / 1000;
2745                 }
2746
2747                 // + the marginal cost of an input which spends the HTLC-Success/HTLC-Timeout output:
2748                 res += fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal) * SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT / 1000;
2749
2750                 res as u32
2751         }
2752
2753         /// Returns true if we've ever received a message from the remote end for this Channel
2754         pub fn have_received_message(&self) -> bool {
2755                 self.channel_state > (ChannelState::OurInitSent as u32)
2756         }
2757
2758         /// Returns true if this channel is fully established and not known to be closing.
2759         /// Allowed in any state (including after shutdown)
2760         pub fn is_usable(&self) -> bool {
2761                 let mask = ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK;
2762                 (self.channel_state & mask) == (ChannelState::ChannelFunded as u32)
2763         }
2764
2765         /// Returns true if this channel is currently available for use. This is a superset of
2766         /// is_usable() and considers things like the channel being temporarily disabled.
2767         /// Allowed in any state (including after shutdown)
2768         pub fn is_live(&self) -> bool {
2769                 self.is_usable() && (self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) == 0)
2770         }
2771
2772         /// Returns true if this channel has been marked as awaiting a monitor update to move forward.
2773         /// Allowed in any state (including after shutdown)
2774         pub fn is_awaiting_monitor_update(&self) -> bool {
2775                 (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0
2776         }
2777
2778         /// Returns true if funding_created was sent/received.
2779         pub fn is_funding_initiated(&self) -> bool {
2780                 self.channel_state >= ChannelState::FundingCreated as u32
2781         }
2782
2783         /// Returns true if this channel is fully shut down. True here implies that no further actions
2784         /// may/will be taken on this channel, and thus this object should be freed. Any future changes
2785         /// will be handled appropriately by the chain monitor.
2786         pub fn is_shutdown(&self) -> bool {
2787                 if (self.channel_state & ChannelState::ShutdownComplete as u32) == ChannelState::ShutdownComplete as u32  {
2788                         assert!(self.channel_state == ChannelState::ShutdownComplete as u32);
2789                         true
2790                 } else { false }
2791         }
2792
2793         /// Called by channelmanager based on chain blocks being connected.
2794         /// Note that we only need to use this to detect funding_signed, anything else is handled by
2795         /// the channel_monitor.
2796         /// In case of Err, the channel may have been closed, at which point the standard requirements
2797         /// apply - no calls may be made except those explicitly stated to be allowed post-shutdown.
2798         /// Only returns an ErrorAction of DisconnectPeer, if Err.
2799         pub fn block_connected(&mut self, header: &BlockHeader, height: u32, txn_matched: &[&Transaction], indexes_of_txn_matched: &[u32]) -> Result<Option<msgs::FundingLocked>, msgs::ErrorMessage> {
2800                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
2801                 if header.bitcoin_hash() != self.last_block_connected {
2802                         self.last_block_connected = header.bitcoin_hash();
2803                         self.channel_monitor.last_block_hash = self.last_block_connected;
2804                         if self.funding_tx_confirmations > 0 {
2805                                 self.funding_tx_confirmations += 1;
2806                                 if self.funding_tx_confirmations == self.minimum_depth as u64 {
2807                                         let need_commitment_update = if non_shutdown_state == ChannelState::FundingSent as u32 {
2808                                                 self.channel_state |= ChannelState::OurFundingLocked as u32;
2809                                                 true
2810                                         } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) {
2811                                                 self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
2812                                                 self.channel_update_count += 1;
2813                                                 true
2814                                         } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
2815                                                 // We got a reorg but not enough to trigger a force close, just update
2816                                                 // funding_tx_confirmed_in and return.
2817                                                 false
2818                                         } else if self.channel_state < ChannelState::ChannelFunded as u32 {
2819                                                 panic!("Started confirming a channel in a state pre-FundingSent?: {}", self.channel_state);
2820                                         } else {
2821                                                 // We got a reorg but not enough to trigger a force close, just update
2822                                                 // funding_tx_confirmed_in and return.
2823                                                 false
2824                                         };
2825                                         self.funding_tx_confirmed_in = Some(header.bitcoin_hash());
2826
2827                                         //TODO: Note that this must be a duplicate of the previous commitment point they sent us,
2828                                         //as otherwise we will have a commitment transaction that they can't revoke (well, kinda,
2829                                         //they can by sending two revoke_and_acks back-to-back, but not really). This appears to be
2830                                         //a protocol oversight, but I assume I'm just missing something.
2831                                         if need_commitment_update {
2832                                                 let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2833                                                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2834                                                 return Ok(Some(msgs::FundingLocked {
2835                                                         channel_id: self.channel_id,
2836                                                         next_per_commitment_point: next_per_commitment_point,
2837                                                 }));
2838                                         }
2839                                 }
2840                         }
2841                 }
2842                 if non_shutdown_state & !(ChannelState::TheirFundingLocked as u32) == ChannelState::FundingSent as u32 {
2843                         for (ref tx, index_in_block) in txn_matched.iter().zip(indexes_of_txn_matched) {
2844                                 if tx.txid() == self.channel_monitor.get_funding_txo().unwrap().txid {
2845                                         let txo_idx = self.channel_monitor.get_funding_txo().unwrap().index as usize;
2846                                         if txo_idx >= tx.output.len() || tx.output[txo_idx].script_pubkey != self.get_funding_redeemscript().to_v0_p2wsh() ||
2847                                                         tx.output[txo_idx].value != self.channel_value_satoshis {
2848                                                 if self.channel_outbound {
2849                                                         // If we generated the funding transaction and it doesn't match what it
2850                                                         // should, the client is really broken and we should just panic and
2851                                                         // tell them off. That said, because hash collisions happen with high
2852                                                         // probability in fuzztarget mode, if we're fuzzing we just close the
2853                                                         // channel and move on.
2854                                                         #[cfg(not(feature = "fuzztarget"))]
2855                                                         panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
2856                                                 }
2857                                                 self.channel_state = ChannelState::ShutdownComplete as u32;
2858                                                 self.channel_update_count += 1;
2859                                                 return Err(msgs::ErrorMessage {
2860                                                         channel_id: self.channel_id(),
2861                                                         data: "funding tx had wrong script/value".to_owned()
2862                                                 });
2863                                         } else {
2864                                                 if self.channel_outbound {
2865                                                         for input in tx.input.iter() {
2866                                                                 if input.witness.is_empty() {
2867                                                                         // We generated a malleable funding transaction, implying we've
2868                                                                         // just exposed ourselves to funds loss to our counterparty.
2869                                                                         #[cfg(not(feature = "fuzztarget"))]
2870                                                                         panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
2871                                                                 }
2872                                                         }
2873                                                 }
2874                                                 self.funding_tx_confirmations = 1;
2875                                                 self.short_channel_id = Some(((height as u64)          << (5*8)) |
2876                                                                              ((*index_in_block as u64) << (2*8)) |
2877                                                                              ((txo_idx as u64)         << (0*8)));
2878                                         }
2879                                 }
2880                         }
2881                 }
2882                 Ok(None)
2883         }
2884
2885         /// Called by channelmanager based on chain blocks being disconnected.
2886         /// Returns true if we need to close the channel now due to funding transaction
2887         /// unconfirmation/reorg.
2888         pub fn block_disconnected(&mut self, header: &BlockHeader) -> bool {
2889                 if self.funding_tx_confirmations > 0 {
2890                         self.funding_tx_confirmations -= 1;
2891                         if self.funding_tx_confirmations == UNCONF_THRESHOLD as u64 {
2892                                 return true;
2893                         }
2894                 }
2895                 if Some(header.bitcoin_hash()) == self.funding_tx_confirmed_in {
2896                         self.funding_tx_confirmations = self.minimum_depth as u64 - 1;
2897                 }
2898                 self.last_block_connected = header.bitcoin_hash();
2899                 self.channel_monitor.last_block_hash = self.last_block_connected;
2900                 false
2901         }
2902
2903         // Methods to get unprompted messages to send to the remote end (or where we already returned
2904         // something in the handler for the message that prompted this message):
2905
2906         pub fn get_open_channel(&self, chain_hash: Sha256dHash, fee_estimator: &FeeEstimator) -> msgs::OpenChannel {
2907                 if !self.channel_outbound {
2908                         panic!("Tried to open a channel for an inbound channel?");
2909                 }
2910                 if self.channel_state != ChannelState::OurInitSent as u32 {
2911                         panic!("Cannot generate an open_channel after we've moved forward");
2912                 }
2913
2914                 if self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
2915                         panic!("Tried to send an open_channel for a channel that has already advanced");
2916                 }
2917
2918                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2919
2920                 msgs::OpenChannel {
2921                         chain_hash: chain_hash,
2922                         temporary_channel_id: self.channel_id,
2923                         funding_satoshis: self.channel_value_satoshis,
2924                         push_msat: self.channel_value_satoshis * 1000 - self.value_to_self_msat,
2925                         dust_limit_satoshis: self.our_dust_limit_satoshis,
2926                         max_htlc_value_in_flight_msat: Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
2927                         channel_reserve_satoshis: Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
2928                         htlc_minimum_msat: self.our_htlc_minimum_msat,
2929                         feerate_per_kw: fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background) as u32,
2930                         to_self_delay: BREAKDOWN_TIMEOUT,
2931                         max_accepted_htlcs: OUR_MAX_HTLCS,
2932                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key),
2933                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key),
2934                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key),
2935                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key),
2936                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key),
2937                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret),
2938                         channel_flags: if self.config.announced_channel {1} else {0},
2939                         shutdown_scriptpubkey: None,
2940                 }
2941         }
2942
2943         pub fn get_accept_channel(&self) -> msgs::AcceptChannel {
2944                 if self.channel_outbound {
2945                         panic!("Tried to send accept_channel for an outbound channel?");
2946                 }
2947                 if self.channel_state != (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32) {
2948                         panic!("Tried to send accept_channel after channel had moved forward");
2949                 }
2950                 if self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
2951                         panic!("Tried to send an accept_channel for a channel that has already advanced");
2952                 }
2953
2954                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2955
2956                 msgs::AcceptChannel {
2957                         temporary_channel_id: self.channel_id,
2958                         dust_limit_satoshis: self.our_dust_limit_satoshis,
2959                         max_htlc_value_in_flight_msat: Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
2960                         channel_reserve_satoshis: Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
2961                         htlc_minimum_msat: self.our_htlc_minimum_msat,
2962                         minimum_depth: self.minimum_depth,
2963                         to_self_delay: BREAKDOWN_TIMEOUT,
2964                         max_accepted_htlcs: OUR_MAX_HTLCS,
2965                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key),
2966                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key),
2967                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key),
2968                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key),
2969                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key),
2970                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret),
2971                         shutdown_scriptpubkey: None,
2972                 }
2973         }
2974
2975         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
2976         fn get_outbound_funding_created_signature(&mut self) -> Result<(Signature, Transaction), ChannelError> {
2977                 let funding_script = self.get_funding_redeemscript();
2978
2979                 let remote_keys = self.build_remote_transaction_keys()?;
2980                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false, self.feerate_per_kw).0;
2981                 let remote_sighash = Message::from_slice(&bip143::SighashComponents::new(&remote_initial_commitment_tx).sighash_all(&remote_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
2982
2983                 // We sign the "remote" commitment transaction, allowing them to broadcast the tx if they wish.
2984                 Ok((self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key), remote_initial_commitment_tx))
2985         }
2986
2987         /// Updates channel state with knowledge of the funding transaction's txid/index, and generates
2988         /// a funding_created message for the remote peer.
2989         /// Panics if called at some time other than immediately after initial handshake, if called twice,
2990         /// or if called on an inbound channel.
2991         /// Note that channel_id changes during this call!
2992         /// Do NOT broadcast the funding transaction until after a successful funding_signed call!
2993         /// If an Err is returned, it is a ChannelError::Close.
2994         pub fn get_outbound_funding_created(&mut self, funding_txo: OutPoint) -> Result<(msgs::FundingCreated, ChannelMonitor), ChannelError> {
2995                 if !self.channel_outbound {
2996                         panic!("Tried to create outbound funding_created message on an inbound channel!");
2997                 }
2998                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
2999                         panic!("Tried to get a funding_created messsage at a time other than immediately after initial handshake completion (or tried to get funding_created twice)");
3000                 }
3001                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) ||
3002                                 self.cur_remote_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
3003                                 self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
3004                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
3005                 }
3006
3007                 let funding_txo_script = self.get_funding_redeemscript().to_v0_p2wsh();
3008                 self.channel_monitor.set_funding_info((funding_txo, funding_txo_script));
3009
3010                 let (our_signature, commitment_tx) = match self.get_outbound_funding_created_signature() {
3011                         Ok(res) => res,
3012                         Err(e) => {
3013                                 log_error!(self, "Got bad signatures: {:?}!", e);
3014                                 self.channel_monitor.unset_funding_info();
3015                                 return Err(e);
3016                         }
3017                 };
3018
3019                 let temporary_channel_id = self.channel_id;
3020
3021                 // Now that we're past error-generating stuff, update our local state:
3022                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&commitment_tx, Vec::new(), Vec::new(), self.cur_remote_commitment_transaction_number, self.their_cur_commitment_point.unwrap());
3023                 self.channel_state = ChannelState::FundingCreated as u32;
3024                 self.channel_id = funding_txo.to_channel_id();
3025                 self.cur_remote_commitment_transaction_number -= 1;
3026
3027                 Ok((msgs::FundingCreated {
3028                         temporary_channel_id: temporary_channel_id,
3029                         funding_txid: funding_txo.txid,
3030                         funding_output_index: funding_txo.index,
3031                         signature: our_signature
3032                 }, self.channel_monitor.clone()))
3033         }
3034
3035         /// Gets an UnsignedChannelAnnouncement, as well as a signature covering it using our
3036         /// bitcoin_key, if available, for this channel. The channel must be publicly announceable and
3037         /// available for use (have exchanged FundingLocked messages in both directions). Should be used
3038         /// for both loose and in response to an AnnouncementSignatures message from the remote peer.
3039         /// Will only fail if we're not in a state where channel_announcement may be sent (including
3040         /// closing).
3041         /// Note that the "channel must be funded" requirement is stricter than BOLT 7 requires - see
3042         /// https://github.com/lightningnetwork/lightning-rfc/issues/468
3043         pub fn get_channel_announcement(&self, our_node_id: PublicKey, chain_hash: Sha256dHash) -> Result<(msgs::UnsignedChannelAnnouncement, Signature), ChannelError> {
3044                 if !self.config.announced_channel {
3045                         return Err(ChannelError::Ignore("Channel is not available for public announcements"));
3046                 }
3047                 if self.channel_state & (ChannelState::ChannelFunded as u32) == 0 {
3048                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement until the channel funding has been locked"));
3049                 }
3050                 if (self.channel_state & (ChannelState::LocalShutdownSent as u32 | ChannelState::ShutdownComplete as u32)) != 0 {
3051                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement once the channel is closing"));
3052                 }
3053
3054                 let were_node_one = our_node_id.serialize()[..] < self.their_node_id.serialize()[..];
3055                 let our_bitcoin_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key);
3056
3057                 let msg = msgs::UnsignedChannelAnnouncement {
3058                         features: msgs::GlobalFeatures::new(),
3059                         chain_hash: chain_hash,
3060                         short_channel_id: self.get_short_channel_id().unwrap(),
3061                         node_id_1: if were_node_one { our_node_id } else { self.get_their_node_id() },
3062                         node_id_2: if were_node_one { self.get_their_node_id() } else { our_node_id },
3063                         bitcoin_key_1: if were_node_one { our_bitcoin_key } else { self.their_funding_pubkey.unwrap() },
3064                         bitcoin_key_2: if were_node_one { self.their_funding_pubkey.unwrap() } else { our_bitcoin_key },
3065                         excess_data: Vec::new(),
3066                 };
3067
3068                 let msghash = Message::from_slice(&Sha256dHash::from_data(&msg.encode()[..])[..]).unwrap();
3069                 let sig = self.secp_ctx.sign(&msghash, &self.local_keys.funding_key);
3070
3071                 Ok((msg, sig))
3072         }
3073
3074         /// May panic if called on a channel that wasn't immediately-previously
3075         /// self.remove_uncommitted_htlcs_and_mark_paused()'d
3076         pub fn get_channel_reestablish(&self) -> msgs::ChannelReestablish {
3077                 assert_eq!(self.channel_state & ChannelState::PeerDisconnected as u32, ChannelState::PeerDisconnected as u32);
3078                 assert_ne!(self.cur_remote_commitment_transaction_number, INITIAL_COMMITMENT_NUMBER);
3079                 msgs::ChannelReestablish {
3080                         channel_id: self.channel_id(),
3081                         // The protocol has two different commitment number concepts - the "commitment
3082                         // transaction number", which starts from 0 and counts up, and the "revocation key
3083                         // index" which starts at INITIAL_COMMITMENT_NUMBER and counts down. We track
3084                         // commitment transaction numbers by the index which will be used to reveal the
3085                         // revocation key for that commitment transaction, which means we have to convert them
3086                         // to protocol-level commitment numbers here...
3087
3088                         // next_local_commitment_number is the next commitment_signed number we expect to
3089                         // receive (indicating if they need to resend one that we missed).
3090                         next_local_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_local_commitment_transaction_number,
3091                         // We have to set next_remote_commitment_number to the next revoke_and_ack we expect to
3092                         // receive, however we track it by the next commitment number for a remote transaction
3093                         // (which is one further, as they always revoke previous commitment transaction, not
3094                         // the one we send) so we have to decrement by 1. Note that if
3095                         // cur_remote_commitment_transaction_number is INITIAL_COMMITMENT_NUMBER we will have
3096                         // dropped this channel on disconnect as it hasn't yet reached FundingSent so we can't
3097                         // overflow here.
3098                         next_remote_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_remote_commitment_transaction_number - 1,
3099                         data_loss_protect: None,
3100                 }
3101         }
3102
3103
3104         // Send stuff to our remote peers:
3105
3106         /// Adds a pending outbound HTLC to this channel, note that you probably want
3107         /// send_htlc_and_commit instead cause you'll want both messages at once.
3108         /// This returns an option instead of a pure UpdateAddHTLC as we may be in a state where we are
3109         /// waiting on the remote peer to send us a revoke_and_ack during which time we cannot add new
3110         /// HTLCs on the wire or we wouldn't be able to determine what they actually ACK'ed.
3111         /// You MUST call send_commitment prior to any other calls on this Channel
3112         pub fn send_htlc(&mut self, amount_msat: u64, payment_hash: [u8; 32], cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket) -> Result<Option<msgs::UpdateAddHTLC>, ChannelError> {
3113                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK)) != (ChannelState::ChannelFunded as u32) {
3114                         return Err(ChannelError::Ignore("Cannot send HTLC until channel is fully established and we haven't started shutting down"));
3115                 }
3116
3117                 if amount_msat > self.channel_value_satoshis * 1000 {
3118                         return Err(ChannelError::Ignore("Cannot send more than the total value of the channel"));
3119                 }
3120                 if amount_msat < self.their_htlc_minimum_msat {
3121                         return Err(ChannelError::Ignore("Cannot send less than their minimum HTLC value"));
3122                 }
3123
3124                 if (self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
3125                         // Note that this should never really happen, if we're !is_live() on receipt of an
3126                         // incoming HTLC for relay will result in us rejecting the HTLC and we won't allow
3127                         // the user to send directly into a !is_live() channel. However, if we
3128                         // disconnected during the time the previous hop was doing the commitment dance we may
3129                         // end up getting here after the forwarding delay. In any case, returning an
3130                         // IgnoreError will get ChannelManager to do the right thing and fail backwards now.
3131                         return Err(ChannelError::Ignore("Cannot send an HTLC while disconnected/frozen for channel monitor update"));
3132                 }
3133
3134                 let (outbound_htlc_count, htlc_outbound_value_msat) = self.get_outbound_pending_htlc_stats();
3135                 if outbound_htlc_count + 1 > self.their_max_accepted_htlcs as u32 {
3136                         return Err(ChannelError::Ignore("Cannot push more than their max accepted HTLCs"));
3137                 }
3138                 //TODO: Spec is unclear if this is per-direction or in total (I assume per direction):
3139                 // Check their_max_htlc_value_in_flight_msat
3140                 if htlc_outbound_value_msat + amount_msat > self.their_max_htlc_value_in_flight_msat {
3141                         return Err(ChannelError::Ignore("Cannot send value that would put us over our max HTLC value in flight"));
3142                 }
3143
3144                 let mut holding_cell_outbound_amount_msat = 0;
3145                 for holding_htlc in self.holding_cell_htlc_updates.iter() {
3146                         match holding_htlc {
3147                                 &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, .. } => {
3148                                         holding_cell_outbound_amount_msat += *amount_msat;
3149                                 }
3150                                 _ => {}
3151                         }
3152                 }
3153
3154                 // Check self.their_channel_reserve_satoshis (the amount we must keep as
3155                 // reserve for them to have something to claim if we misbehave)
3156                 if self.value_to_self_msat < self.their_channel_reserve_satoshis * 1000 + amount_msat + holding_cell_outbound_amount_msat + htlc_outbound_value_msat {
3157                         return Err(ChannelError::Ignore("Cannot send value that would put us over our reserve value"));
3158                 }
3159
3160                 //TODO: Check cltv_expiry? Do this in channel manager?
3161
3162                 // Now update local state:
3163                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
3164                         //TODO: Check the limits *including* other pending holding cell HTLCs!
3165                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::AddHTLC {
3166                                 amount_msat: amount_msat,
3167                                 payment_hash: payment_hash,
3168                                 cltv_expiry: cltv_expiry,
3169                                 source,
3170                                 onion_routing_packet: onion_routing_packet,
3171                                 time_created: Instant::now(),
3172                         });
3173                         return Ok(None);
3174                 }
3175
3176                 self.pending_outbound_htlcs.push(OutboundHTLCOutput {
3177                         htlc_id: self.next_local_htlc_id,
3178                         amount_msat: amount_msat,
3179                         payment_hash: payment_hash.clone(),
3180                         cltv_expiry: cltv_expiry,
3181                         state: OutboundHTLCState::LocalAnnounced(Box::new(onion_routing_packet.clone())),
3182                         source,
3183                         fail_reason: None,
3184                 });
3185
3186                 let res = msgs::UpdateAddHTLC {
3187                         channel_id: self.channel_id,
3188                         htlc_id: self.next_local_htlc_id,
3189                         amount_msat: amount_msat,
3190                         payment_hash: payment_hash,
3191                         cltv_expiry: cltv_expiry,
3192                         onion_routing_packet: onion_routing_packet,
3193                 };
3194                 self.next_local_htlc_id += 1;
3195
3196                 Ok(Some(res))
3197         }
3198
3199         /// Creates a signed commitment transaction to send to the remote peer.
3200         /// Always returns a ChannelError::Close if an immediately-preceding (read: the
3201         /// last call to this Channel) send_htlc returned Ok(Some(_)) and there is an Err.
3202         /// May panic if called except immediately after a successful, Ok(Some(_))-returning send_htlc.
3203         pub fn send_commitment(&mut self) -> Result<(msgs::CommitmentSigned, ChannelMonitor), ChannelError> {
3204                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
3205                         panic!("Cannot create commitment tx until channel is fully established");
3206                 }
3207                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
3208                         panic!("Cannot create commitment tx until remote revokes their previous commitment");
3209                 }
3210                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) == (ChannelState::PeerDisconnected as u32) {
3211                         panic!("Cannot create commitment tx while disconnected, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
3212                 }
3213                 if (self.channel_state & (ChannelState::MonitorUpdateFailed as u32)) == (ChannelState::MonitorUpdateFailed as u32) {
3214                         panic!("Cannot create commitment tx while awaiting monitor update unfreeze, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
3215                 }
3216                 let mut have_updates = self.pending_update_fee.is_some();
3217                 for htlc in self.pending_outbound_htlcs.iter() {
3218                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
3219                                 have_updates = true;
3220                         }
3221                         if have_updates { break; }
3222                 }
3223                 if !have_updates {
3224                         panic!("Cannot create commitment tx until we have some updates to send");
3225                 }
3226                 self.send_commitment_no_status_check()
3227         }
3228         /// Only fails in case of bad keys
3229         fn send_commitment_no_status_check(&mut self) -> Result<(msgs::CommitmentSigned, ChannelMonitor), ChannelError> {
3230                 // We can upgrade the status of some HTLCs that are waiting on a commitment, even if we
3231                 // fail to generate this, we still are at least at a position where upgrading their status
3232                 // is acceptable.
3233                 for htlc in self.pending_inbound_htlcs.iter_mut() {
3234                         let new_state = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref forward_info) = &htlc.state {
3235                                 Some(InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info.clone()))
3236                         } else { None };
3237                         if let Some(state) = new_state {
3238                                 htlc.state = state;
3239                         }
3240                 }
3241                 for htlc in self.pending_outbound_htlcs.iter_mut() {
3242                         if let OutboundHTLCState::AwaitingRemoteRevokeToRemove = htlc.state {
3243                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke;
3244                         }
3245                 }
3246
3247                 let (res, remote_commitment_tx, htlcs, htlc_sources) = match self.send_commitment_no_state_update() {
3248                         Ok((res, (remote_commitment_tx, htlcs, mut htlc_sources))) => {
3249                                 // Update state now that we've passed all the can-fail calls...
3250                                 let htlc_sources_no_ref = htlc_sources.drain(..).map(|htlc_source| (htlc_source.0, htlc_source.1.clone(), htlc_source.2)).collect();
3251                                 (res, remote_commitment_tx, htlcs, htlc_sources_no_ref)
3252                         },
3253                         Err(e) => return Err(e),
3254                 };
3255
3256                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&remote_commitment_tx, htlcs, htlc_sources, self.cur_remote_commitment_transaction_number, self.their_cur_commitment_point.unwrap());
3257                 self.channel_state |= ChannelState::AwaitingRemoteRevoke as u32;
3258                 Ok((res, self.channel_monitor.clone()))
3259         }
3260
3261         /// Only fails in case of bad keys. Used for channel_reestablish commitment_signed generation
3262         /// when we shouldn't change HTLC/channel state.
3263         fn send_commitment_no_state_update(&self) -> Result<(msgs::CommitmentSigned, (Transaction, Vec<HTLCOutputInCommitment>, Vec<([u8; 32], &HTLCSource, Option<u32>)>)), ChannelError> {
3264                 let funding_script = self.get_funding_redeemscript();
3265
3266                 let mut feerate_per_kw = self.feerate_per_kw;
3267                 if let Some(feerate) = self.pending_update_fee {
3268                         if self.channel_outbound {
3269                                 feerate_per_kw = feerate;
3270                         }
3271                 }
3272
3273                 let remote_keys = self.build_remote_transaction_keys()?;
3274                 let remote_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, true, feerate_per_kw);
3275                 let remote_commitment_txid = remote_commitment_tx.0.txid();
3276                 let remote_sighash = Message::from_slice(&bip143::SighashComponents::new(&remote_commitment_tx.0).sighash_all(&remote_commitment_tx.0.input[0], &funding_script, self.channel_value_satoshis)[..]).unwrap();
3277                 let our_sig = self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key);
3278
3279                 let mut htlc_sigs = Vec::new();
3280
3281                 for ref htlc in remote_commitment_tx.1.iter() {
3282                         let htlc_tx = self.build_htlc_transaction(&remote_commitment_txid, htlc, false, &remote_keys, feerate_per_kw);
3283                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &remote_keys);
3284                         let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
3285                         let our_htlc_key = secp_check!(chan_utils::derive_private_key(&self.secp_ctx, &remote_keys.per_commitment_point, &self.local_keys.htlc_base_key), "Derived invalid key, peer is maliciously selecting parameters");
3286                         htlc_sigs.push(self.secp_ctx.sign(&htlc_sighash, &our_htlc_key));
3287                 }
3288
3289                 Ok((msgs::CommitmentSigned {
3290                         channel_id: self.channel_id,
3291                         signature: our_sig,
3292                         htlc_signatures: htlc_sigs,
3293                 }, remote_commitment_tx))
3294         }
3295
3296         /// Adds a pending outbound HTLC to this channel, and creates a signed commitment transaction
3297         /// to send to the remote peer in one go.
3298         /// Shorthand for calling send_htlc() followed by send_commitment(), see docs on those for
3299         /// more info.
3300         pub fn send_htlc_and_commit(&mut self, amount_msat: u64, payment_hash: [u8; 32], cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket) -> Result<Option<(msgs::UpdateAddHTLC, msgs::CommitmentSigned, ChannelMonitor)>, ChannelError> {
3301                 match self.send_htlc(amount_msat, payment_hash, cltv_expiry, source, onion_routing_packet)? {
3302                         Some(update_add_htlc) => {
3303                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
3304                                 Ok(Some((update_add_htlc, commitment_signed, monitor_update)))
3305                         },
3306                         None => Ok(None)
3307                 }
3308         }
3309
3310         /// Begins the shutdown process, getting a message for the remote peer and returning all
3311         /// holding cell HTLCs for payment failure.
3312         pub fn get_shutdown(&mut self) -> Result<(msgs::Shutdown, Vec<(HTLCSource, [u8; 32])>), APIError> {
3313                 for htlc in self.pending_outbound_htlcs.iter() {
3314                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
3315                                 return Err(APIError::APIMisuseError{err: "Cannot begin shutdown with pending HTLCs. Process pending events first"});
3316                         }
3317                 }
3318                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != 0 {
3319                         if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
3320                                 return Err(APIError::APIMisuseError{err: "Shutdown already in progress"});
3321                         }
3322                         else if (self.channel_state & ChannelState::RemoteShutdownSent as u32) == ChannelState::RemoteShutdownSent as u32 {
3323                                 return Err(APIError::ChannelUnavailable{err: "Shutdown already in progress by remote"});
3324                         }
3325                 }
3326                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3327                 if self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) != 0 {
3328                         return Err(APIError::ChannelUnavailable{err: "Cannot begin shutdown while peer is disconnected or we're waiting on a monitor update, maybe force-close instead?"});
3329                 }
3330
3331                 let our_closing_script = self.get_closing_scriptpubkey();
3332
3333                 // From here on out, we may not fail!
3334                 if self.channel_state < ChannelState::FundingSent as u32 {
3335                         self.channel_state = ChannelState::ShutdownComplete as u32;
3336                 } else {
3337                         self.channel_state |= ChannelState::LocalShutdownSent as u32;
3338                 }
3339                 self.channel_update_count += 1;
3340
3341                 // Go ahead and drop holding cell updates as we'd rather fail payments than wait to send
3342                 // our shutdown until we've committed all of the pending changes.
3343                 self.holding_cell_update_fee = None;
3344                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
3345                 self.holding_cell_htlc_updates.retain(|htlc_update| {
3346                         match htlc_update {
3347                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
3348                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
3349                                         false
3350                                 },
3351                                 _ => true
3352                         }
3353                 });
3354
3355                 Ok((msgs::Shutdown {
3356                         channel_id: self.channel_id,
3357                         scriptpubkey: our_closing_script,
3358                 }, dropped_outbound_htlcs))
3359         }
3360
3361         /// Gets the latest commitment transaction and any dependant transactions for relay (forcing
3362         /// shutdown of this channel - no more calls into this Channel may be made afterwards except
3363         /// those explicitly stated to be allowed after shutdown completes, eg some simple getters).
3364         /// Also returns the list of payment_hashes for channels which we can safely fail backwards
3365         /// immediately (others we will have to allow to time out).
3366         pub fn force_shutdown(&mut self) -> (Vec<Transaction>, Vec<(HTLCSource, [u8; 32])>) {
3367                 assert!(self.channel_state != ChannelState::ShutdownComplete as u32);
3368
3369                 // We go ahead and "free" any holding cell HTLCs or HTLCs we haven't yet committed to and
3370                 // return them to fail the payment.
3371                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
3372                 for htlc_update in self.holding_cell_htlc_updates.drain(..) {
3373                         match htlc_update {
3374                                 HTLCUpdateAwaitingACK::AddHTLC { source, payment_hash, .. } => {
3375                                         dropped_outbound_htlcs.push((source, payment_hash));
3376                                 },
3377                                 _ => {}
3378                         }
3379                 }
3380
3381                 for _htlc in self.pending_outbound_htlcs.drain(..) {
3382                         //TODO: Do something with the remaining HTLCs
3383                         //(we need to have the ChannelManager monitor them so we can claim the inbound HTLCs
3384                         //which correspond)
3385                 }
3386
3387                 self.channel_state = ChannelState::ShutdownComplete as u32;
3388                 self.channel_update_count += 1;
3389                 let mut res = Vec::new();
3390                 mem::swap(&mut res, &mut self.last_local_commitment_txn);
3391                 (res, dropped_outbound_htlcs)
3392         }
3393 }
3394
3395 const SERIALIZATION_VERSION: u8 = 1;
3396 const MIN_SERIALIZATION_VERSION: u8 = 1;
3397
3398 impl Writeable for InboundHTLCRemovalReason {
3399         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
3400                 match self {
3401                         &InboundHTLCRemovalReason::FailRelay(ref error_packet) => {
3402                                 0u8.write(writer)?;
3403                                 error_packet.write(writer)?;
3404                         },
3405                         &InboundHTLCRemovalReason::FailMalformed((ref onion_hash, ref err_code)) => {
3406                                 1u8.write(writer)?;
3407                                 onion_hash.write(writer)?;
3408                                 err_code.write(writer)?;
3409                         },
3410                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
3411                                 2u8.write(writer)?;
3412                                 payment_preimage.write(writer)?;
3413                         },
3414                 }
3415                 Ok(())
3416         }
3417 }
3418
3419 impl<R: ::std::io::Read> Readable<R> for InboundHTLCRemovalReason {
3420         fn read(reader: &mut R) -> Result<Self, DecodeError> {
3421                 Ok(match <u8 as Readable<R>>::read(reader)? {
3422                         0 => InboundHTLCRemovalReason::FailRelay(Readable::read(reader)?),
3423                         1 => InboundHTLCRemovalReason::FailMalformed((Readable::read(reader)?, Readable::read(reader)?)),
3424                         2 => InboundHTLCRemovalReason::Fulfill(Readable::read(reader)?),
3425                         _ => return Err(DecodeError::InvalidValue),
3426                 })
3427         }
3428 }
3429
3430 impl Writeable for Channel {
3431         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
3432                 // Note that we write out as if remove_uncommitted_htlcs_and_mark_paused had just been
3433                 // called but include holding cell updates (and obviously we don't modify self).
3434
3435                 writer.write_all(&[SERIALIZATION_VERSION; 1])?;
3436                 writer.write_all(&[MIN_SERIALIZATION_VERSION; 1])?;
3437
3438                 self.user_id.write(writer)?;
3439                 self.config.write(writer)?;
3440
3441                 self.channel_id.write(writer)?;
3442                 (self.channel_state | ChannelState::PeerDisconnected as u32).write(writer)?;
3443                 self.channel_outbound.write(writer)?;
3444                 self.channel_value_satoshis.write(writer)?;
3445
3446                 self.local_keys.write(writer)?;
3447                 self.shutdown_pubkey.write(writer)?;
3448
3449                 self.cur_local_commitment_transaction_number.write(writer)?;
3450                 self.cur_remote_commitment_transaction_number.write(writer)?;
3451                 self.value_to_self_msat.write(writer)?;
3452
3453                 self.received_commitment_while_awaiting_raa.write(writer)?;
3454
3455                 let mut dropped_inbound_htlcs = 0;
3456                 for htlc in self.pending_inbound_htlcs.iter() {
3457                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
3458                                 dropped_inbound_htlcs += 1;
3459                         }
3460                 }
3461                 (self.pending_inbound_htlcs.len() as u64 - dropped_inbound_htlcs).write(writer)?;
3462                 for htlc in self.pending_inbound_htlcs.iter() {
3463                         htlc.htlc_id.write(writer)?;
3464                         htlc.amount_msat.write(writer)?;
3465                         htlc.cltv_expiry.write(writer)?;
3466                         htlc.payment_hash.write(writer)?;
3467                         match &htlc.state {
3468                                 &InboundHTLCState::RemoteAnnounced(_) => {}, // Drop
3469                                 &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref htlc_state) => {
3470                                         1u8.write(writer)?;
3471                                         htlc_state.write(writer)?;
3472                                 },
3473                                 &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(ref htlc_state) => {
3474                                         2u8.write(writer)?;
3475                                         htlc_state.write(writer)?;
3476                                 },
3477                                 &InboundHTLCState::Committed => {
3478                                         3u8.write(writer)?;
3479                                 },
3480                                 &InboundHTLCState::LocalRemoved(ref removal_reason) => {
3481                                         4u8.write(writer)?;
3482                                         removal_reason.write(writer)?;
3483                                 },
3484                         }
3485                 }
3486
3487                 macro_rules! write_option {
3488                         ($thing: expr) => {
3489                                 match &$thing {
3490                                         &None => 0u8.write(writer)?,
3491                                         &Some(ref v) => {
3492                                                 1u8.write(writer)?;
3493                                                 v.write(writer)?;
3494                                         },
3495                                 }
3496                         }
3497                 }
3498
3499                 (self.pending_outbound_htlcs.len() as u64).write(writer)?;
3500                 for htlc in self.pending_outbound_htlcs.iter() {
3501                         htlc.htlc_id.write(writer)?;
3502                         htlc.amount_msat.write(writer)?;
3503                         htlc.cltv_expiry.write(writer)?;
3504                         htlc.payment_hash.write(writer)?;
3505                         htlc.source.write(writer)?;
3506                         write_option!(htlc.fail_reason);
3507                         match &htlc.state {
3508                                 &OutboundHTLCState::LocalAnnounced(ref onion_packet) => {
3509                                         0u8.write(writer)?;
3510                                         onion_packet.write(writer)?;
3511                                 },
3512                                 &OutboundHTLCState::Committed => {
3513                                         1u8.write(writer)?;
3514                                 },
3515                                 &OutboundHTLCState::RemoteRemoved => {
3516                                         2u8.write(writer)?;
3517                                 },
3518                                 &OutboundHTLCState::AwaitingRemoteRevokeToRemove => {
3519                                         3u8.write(writer)?;
3520                                 },
3521                                 &OutboundHTLCState::AwaitingRemovedRemoteRevoke => {
3522                                         4u8.write(writer)?;
3523                                 },
3524                         }
3525                 }
3526
3527                 (self.holding_cell_htlc_updates.len() as u64).write(writer)?;
3528                 for update in self.holding_cell_htlc_updates.iter() {
3529                         match update {
3530                                 &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, time_created: _ } => {
3531                                         0u8.write(writer)?;
3532                                         amount_msat.write(writer)?;
3533                                         cltv_expiry.write(writer)?;
3534                                         payment_hash.write(writer)?;
3535                                         source.write(writer)?;
3536                                         onion_routing_packet.write(writer)?;
3537                                         // time_created is not serialized - we re-init the timeout upon deserialization
3538                                 },
3539                                 &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, ref htlc_id } => {
3540                                         1u8.write(writer)?;
3541                                         payment_preimage.write(writer)?;
3542                                         htlc_id.write(writer)?;
3543                                 },
3544                                 &HTLCUpdateAwaitingACK::FailHTLC { ref htlc_id, ref err_packet } => {
3545                                         2u8.write(writer)?;
3546                                         htlc_id.write(writer)?;
3547                                         err_packet.write(writer)?;
3548                                 }
3549                         }
3550                 }
3551
3552                 self.monitor_pending_revoke_and_ack.write(writer)?;
3553                 self.monitor_pending_commitment_signed.write(writer)?;
3554                 match self.monitor_pending_order {
3555                         None => 0u8.write(writer)?,
3556                         Some(RAACommitmentOrder::CommitmentFirst) => 1u8.write(writer)?,
3557                         Some(RAACommitmentOrder::RevokeAndACKFirst) => 2u8.write(writer)?,
3558                 }
3559
3560                 (self.monitor_pending_forwards.len() as u64).write(writer)?;
3561                 for &(ref pending_forward, ref htlc_id) in self.monitor_pending_forwards.iter() {
3562                         pending_forward.write(writer)?;
3563                         htlc_id.write(writer)?;
3564                 }
3565
3566                 (self.monitor_pending_failures.len() as u64).write(writer)?;
3567                 for &(ref htlc_source, ref payment_hash, ref fail_reason) in self.monitor_pending_failures.iter() {
3568                         htlc_source.write(writer)?;
3569                         payment_hash.write(writer)?;
3570                         fail_reason.write(writer)?;
3571                 }
3572
3573                 write_option!(self.pending_update_fee);
3574                 write_option!(self.holding_cell_update_fee);
3575
3576                 self.next_local_htlc_id.write(writer)?;
3577                 (self.next_remote_htlc_id - dropped_inbound_htlcs).write(writer)?;
3578                 self.channel_update_count.write(writer)?;
3579                 self.feerate_per_kw.write(writer)?;
3580
3581                 (self.last_local_commitment_txn.len() as u64).write(writer)?;
3582                 for tx in self.last_local_commitment_txn.iter() {
3583                         if let Err(e) = tx.consensus_encode(&mut WriterWriteAdaptor(writer)) {
3584                                 match e {
3585                                         encode::Error::Io(e) => return Err(e),
3586                                         _ => panic!("last_local_commitment_txn must have been well-formed!"),
3587                                 }
3588                         }
3589                 }
3590
3591                 match self.last_sent_closing_fee {
3592                         Some((feerate, fee)) => {
3593                                 1u8.write(writer)?;
3594                                 feerate.write(writer)?;
3595                                 fee.write(writer)?;
3596                         },
3597                         None => 0u8.write(writer)?,
3598                 }
3599
3600                 write_option!(self.funding_tx_confirmed_in);
3601                 write_option!(self.short_channel_id);
3602
3603                 self.last_block_connected.write(writer)?;
3604                 self.funding_tx_confirmations.write(writer)?;
3605
3606                 self.their_dust_limit_satoshis.write(writer)?;
3607                 self.our_dust_limit_satoshis.write(writer)?;
3608                 self.their_max_htlc_value_in_flight_msat.write(writer)?;
3609                 self.their_channel_reserve_satoshis.write(writer)?;
3610                 self.their_htlc_minimum_msat.write(writer)?;
3611                 self.our_htlc_minimum_msat.write(writer)?;
3612                 self.their_to_self_delay.write(writer)?;
3613                 self.their_max_accepted_htlcs.write(writer)?;
3614                 self.minimum_depth.write(writer)?;
3615
3616                 write_option!(self.their_funding_pubkey);
3617                 write_option!(self.their_revocation_basepoint);
3618                 write_option!(self.their_payment_basepoint);
3619                 write_option!(self.their_delayed_payment_basepoint);
3620                 write_option!(self.their_htlc_basepoint);
3621                 write_option!(self.their_cur_commitment_point);
3622
3623                 write_option!(self.their_prev_commitment_point);
3624                 self.their_node_id.write(writer)?;
3625
3626                 write_option!(self.their_shutdown_scriptpubkey);
3627
3628                 self.channel_monitor.write_for_disk(writer)?;
3629                 Ok(())
3630         }
3631 }
3632
3633 impl<R : ::std::io::Read> ReadableArgs<R, Arc<Logger>> for Channel {
3634         fn read(reader: &mut R, logger: Arc<Logger>) -> Result<Self, DecodeError> {
3635                 let _ver: u8 = Readable::read(reader)?;
3636                 let min_ver: u8 = Readable::read(reader)?;
3637                 if min_ver > SERIALIZATION_VERSION {
3638                         return Err(DecodeError::UnknownVersion);
3639                 }
3640
3641                 let user_id = Readable::read(reader)?;
3642                 let config: ChannelConfig = Readable::read(reader)?;
3643
3644                 let channel_id = Readable::read(reader)?;
3645                 let channel_state = Readable::read(reader)?;
3646                 let channel_outbound = Readable::read(reader)?;
3647                 let channel_value_satoshis = Readable::read(reader)?;
3648
3649                 let local_keys = Readable::read(reader)?;
3650                 let shutdown_pubkey = Readable::read(reader)?;
3651
3652                 let cur_local_commitment_transaction_number = Readable::read(reader)?;
3653                 let cur_remote_commitment_transaction_number = Readable::read(reader)?;
3654                 let value_to_self_msat = Readable::read(reader)?;
3655
3656                 let received_commitment_while_awaiting_raa = Readable::read(reader)?;
3657
3658                 let pending_inbound_htlc_count: u64 = Readable::read(reader)?;
3659                 let mut pending_inbound_htlcs = Vec::with_capacity(cmp::min(pending_inbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
3660                 for _ in 0..pending_inbound_htlc_count {
3661                         pending_inbound_htlcs.push(InboundHTLCOutput {
3662                                 htlc_id: Readable::read(reader)?,
3663                                 amount_msat: Readable::read(reader)?,
3664                                 cltv_expiry: Readable::read(reader)?,
3665                                 payment_hash: Readable::read(reader)?,
3666                                 state: match <u8 as Readable<R>>::read(reader)? {
3667                                         1 => InboundHTLCState::AwaitingRemoteRevokeToAnnounce(Readable::read(reader)?),
3668                                         2 => InboundHTLCState::AwaitingAnnouncedRemoteRevoke(Readable::read(reader)?),
3669                                         3 => InboundHTLCState::Committed,
3670                                         4 => InboundHTLCState::LocalRemoved(Readable::read(reader)?),
3671                                         _ => return Err(DecodeError::InvalidValue),
3672                                 },
3673                         });
3674                 }
3675
3676                 macro_rules! read_option { () => {
3677                         match <u8 as Readable<R>>::read(reader)? {
3678                                 0 => None,
3679                                 1 => Some(Readable::read(reader)?),
3680                                 _ => return Err(DecodeError::InvalidValue),
3681                         }
3682                 } }
3683
3684                 let pending_outbound_htlc_count: u64 = Readable::read(reader)?;
3685                 let mut pending_outbound_htlcs = Vec::with_capacity(cmp::min(pending_outbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
3686                 for _ in 0..pending_outbound_htlc_count {
3687                         pending_outbound_htlcs.push(OutboundHTLCOutput {
3688                                 htlc_id: Readable::read(reader)?,
3689                                 amount_msat: Readable::read(reader)?,
3690                                 cltv_expiry: Readable::read(reader)?,
3691                                 payment_hash: Readable::read(reader)?,
3692                                 source: Readable::read(reader)?,
3693                                 fail_reason: read_option!(),
3694                                 state: match <u8 as Readable<R>>::read(reader)? {
3695                                         0 => OutboundHTLCState::LocalAnnounced(Box::new(Readable::read(reader)?)),
3696                                         1 => OutboundHTLCState::Committed,
3697                                         2 => OutboundHTLCState::RemoteRemoved,
3698                                         3 => OutboundHTLCState::AwaitingRemoteRevokeToRemove,
3699                                         4 => OutboundHTLCState::AwaitingRemovedRemoteRevoke,
3700                                         _ => return Err(DecodeError::InvalidValue),
3701                                 },
3702                         });
3703                 }
3704
3705                 let holding_cell_htlc_update_count: u64 = Readable::read(reader)?;
3706                 let mut holding_cell_htlc_updates = Vec::with_capacity(cmp::min(holding_cell_htlc_update_count as usize, OUR_MAX_HTLCS as usize*2));
3707                 for _ in 0..holding_cell_htlc_update_count {
3708                         holding_cell_htlc_updates.push(match <u8 as Readable<R>>::read(reader)? {
3709                                 0 => HTLCUpdateAwaitingACK::AddHTLC {
3710                                         amount_msat: Readable::read(reader)?,
3711                                         cltv_expiry: Readable::read(reader)?,
3712                                         payment_hash: Readable::read(reader)?,
3713                                         source: Readable::read(reader)?,
3714                                         onion_routing_packet: Readable::read(reader)?,
3715                                         time_created: Instant::now(),
3716                                 },
3717                                 1 => HTLCUpdateAwaitingACK::ClaimHTLC {
3718                                         payment_preimage: Readable::read(reader)?,
3719                                         htlc_id: Readable::read(reader)?,
3720                                 },
3721                                 2 => HTLCUpdateAwaitingACK::FailHTLC {
3722                                         htlc_id: Readable::read(reader)?,
3723                                         err_packet: Readable::read(reader)?,
3724                                 },
3725                                 _ => return Err(DecodeError::InvalidValue),
3726                         });
3727                 }
3728
3729                 let monitor_pending_revoke_and_ack = Readable::read(reader)?;
3730                 let monitor_pending_commitment_signed = Readable::read(reader)?;
3731
3732                 let monitor_pending_order = match <u8 as Readable<R>>::read(reader)? {
3733                         0 => None,
3734                         1 => Some(RAACommitmentOrder::CommitmentFirst),
3735                         2 => Some(RAACommitmentOrder::RevokeAndACKFirst),
3736                         _ => return Err(DecodeError::InvalidValue),
3737                 };
3738
3739                 let monitor_pending_forwards_count: u64 = Readable::read(reader)?;
3740                 let mut monitor_pending_forwards = Vec::with_capacity(cmp::min(monitor_pending_forwards_count as usize, OUR_MAX_HTLCS as usize));
3741                 for _ in 0..monitor_pending_forwards_count {
3742                         monitor_pending_forwards.push((Readable::read(reader)?, Readable::read(reader)?));
3743                 }
3744
3745                 let monitor_pending_failures_count: u64 = Readable::read(reader)?;
3746                 let mut monitor_pending_failures = Vec::with_capacity(cmp::min(monitor_pending_failures_count as usize, OUR_MAX_HTLCS as usize));
3747                 for _ in 0..monitor_pending_failures_count {
3748                         monitor_pending_failures.push((Readable::read(reader)?, Readable::read(reader)?, Readable::read(reader)?));
3749                 }
3750
3751                 let pending_update_fee = read_option!();
3752                 let holding_cell_update_fee = read_option!();
3753
3754                 let next_local_htlc_id = Readable::read(reader)?;
3755                 let next_remote_htlc_id = Readable::read(reader)?;
3756                 let channel_update_count = Readable::read(reader)?;
3757                 let feerate_per_kw = Readable::read(reader)?;
3758
3759                 let last_local_commitment_txn_count: u64 = Readable::read(reader)?;
3760                 let mut last_local_commitment_txn = Vec::with_capacity(cmp::min(last_local_commitment_txn_count as usize, OUR_MAX_HTLCS as usize*2 + 1));
3761                 for _ in 0..last_local_commitment_txn_count {
3762                         last_local_commitment_txn.push(match Transaction::consensus_decode(reader.by_ref()) {
3763                                 Ok(tx) => tx,
3764                                 Err(_) => return Err(DecodeError::InvalidValue),
3765                         });
3766                 }
3767
3768                 let last_sent_closing_fee = match <u8 as Readable<R>>::read(reader)? {
3769                         0 => None,
3770                         1 => Some((Readable::read(reader)?, Readable::read(reader)?)),
3771                         _ => return Err(DecodeError::InvalidValue),
3772                 };
3773
3774                 let funding_tx_confirmed_in = read_option!();
3775                 let short_channel_id = read_option!();
3776
3777                 let last_block_connected = Readable::read(reader)?;
3778                 let funding_tx_confirmations = Readable::read(reader)?;
3779
3780                 let their_dust_limit_satoshis = Readable::read(reader)?;
3781                 let our_dust_limit_satoshis = Readable::read(reader)?;
3782                 let their_max_htlc_value_in_flight_msat = Readable::read(reader)?;
3783                 let their_channel_reserve_satoshis = Readable::read(reader)?;
3784                 let their_htlc_minimum_msat = Readable::read(reader)?;
3785                 let our_htlc_minimum_msat = Readable::read(reader)?;
3786                 let their_to_self_delay = Readable::read(reader)?;
3787                 let their_max_accepted_htlcs = Readable::read(reader)?;
3788                 let minimum_depth = Readable::read(reader)?;
3789
3790                 let their_funding_pubkey = read_option!();
3791                 let their_revocation_basepoint = read_option!();
3792                 let their_payment_basepoint = read_option!();
3793                 let their_delayed_payment_basepoint = read_option!();
3794                 let their_htlc_basepoint = read_option!();
3795                 let their_cur_commitment_point = read_option!();
3796
3797                 let their_prev_commitment_point = read_option!();
3798                 let their_node_id = Readable::read(reader)?;
3799
3800                 let their_shutdown_scriptpubkey = read_option!();
3801                 let (monitor_last_block, channel_monitor) = ReadableArgs::read(reader, logger.clone())?;
3802                 // We drop the ChannelMonitor's last block connected hash cause we don't actually bother
3803                 // doing full block connection operations on the internal CHannelMonitor copies
3804                 if monitor_last_block != last_block_connected {
3805                         return Err(DecodeError::InvalidValue);
3806                 }
3807
3808                 Ok(Channel {
3809                         user_id,
3810
3811                         config,
3812                         channel_id,
3813                         channel_state,
3814                         channel_outbound,
3815                         secp_ctx: Secp256k1::new(),
3816                         channel_value_satoshis,
3817
3818                         local_keys,
3819                         shutdown_pubkey,
3820
3821                         cur_local_commitment_transaction_number,
3822                         cur_remote_commitment_transaction_number,
3823                         value_to_self_msat,
3824
3825                         received_commitment_while_awaiting_raa,
3826                         pending_inbound_htlcs,
3827                         pending_outbound_htlcs,
3828                         holding_cell_htlc_updates,
3829
3830                         monitor_pending_revoke_and_ack,
3831                         monitor_pending_commitment_signed,
3832                         monitor_pending_order,
3833                         monitor_pending_forwards,
3834                         monitor_pending_failures,
3835
3836                         pending_update_fee,
3837                         holding_cell_update_fee,
3838                         next_local_htlc_id,
3839                         next_remote_htlc_id,
3840                         channel_update_count,
3841                         feerate_per_kw,
3842
3843                         #[cfg(debug_assertions)]
3844                         max_commitment_tx_output_local: ::std::sync::Mutex::new((0, 0)),
3845                         #[cfg(debug_assertions)]
3846                         max_commitment_tx_output_remote: ::std::sync::Mutex::new((0, 0)),
3847
3848                         last_local_commitment_txn,
3849
3850                         last_sent_closing_fee,
3851
3852                         funding_tx_confirmed_in,
3853                         short_channel_id,
3854                         last_block_connected,
3855                         funding_tx_confirmations,
3856
3857                         their_dust_limit_satoshis,
3858                         our_dust_limit_satoshis,
3859                         their_max_htlc_value_in_flight_msat,
3860                         their_channel_reserve_satoshis,
3861                         their_htlc_minimum_msat,
3862                         our_htlc_minimum_msat,
3863                         their_to_self_delay,
3864                         their_max_accepted_htlcs,
3865                         minimum_depth,
3866
3867                         their_funding_pubkey,
3868                         their_revocation_basepoint,
3869                         their_payment_basepoint,
3870                         their_delayed_payment_basepoint,
3871                         their_htlc_basepoint,
3872                         their_cur_commitment_point,
3873
3874                         their_prev_commitment_point,
3875                         their_node_id,
3876
3877                         their_shutdown_scriptpubkey,
3878
3879                         channel_monitor,
3880
3881                         logger,
3882                 })
3883         }
3884 }
3885
3886 #[cfg(test)]
3887 mod tests {
3888         use bitcoin::util::hash::{Sha256dHash, Hash160};
3889         use bitcoin::util::bip143;
3890         use bitcoin::consensus::encode::serialize;
3891         use bitcoin::blockdata::script::{Script, Builder};
3892         use bitcoin::blockdata::transaction::Transaction;
3893         use bitcoin::blockdata::opcodes;
3894         use hex;
3895         use ln::channelmanager::HTLCSource;
3896         use ln::channel::{Channel,ChannelKeys,InboundHTLCOutput,OutboundHTLCOutput,InboundHTLCState,OutboundHTLCState,HTLCOutputInCommitment,TxCreationKeys};
3897         use ln::channel::MAX_FUNDING_SATOSHIS;
3898         use ln::chan_utils;
3899         use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
3900         use chain::keysinterface::KeysInterface;
3901         use chain::transaction::OutPoint;
3902         use util::config::UserConfig;
3903         use util::test_utils;
3904         use util::logger::Logger;
3905         use secp256k1::{Secp256k1,Message,Signature};
3906         use secp256k1::key::{SecretKey,PublicKey};
3907         use crypto::sha2::Sha256;
3908         use crypto::digest::Digest;
3909         use std::sync::Arc;
3910
3911         struct TestFeeEstimator {
3912                 fee_est: u64
3913         }
3914         impl FeeEstimator for TestFeeEstimator {
3915                 fn get_est_sat_per_1000_weight(&self, _: ConfirmationTarget) -> u64 {
3916                         self.fee_est
3917                 }
3918         }
3919
3920         #[test]
3921         fn test_max_funding_satoshis() {
3922                 assert!(MAX_FUNDING_SATOSHIS <= 21_000_000 * 100_000_000,
3923                         "MAX_FUNDING_SATOSHIS is greater than all satoshis on existence");
3924         }
3925
3926         struct Keys {
3927                 chan_keys: ChannelKeys,
3928         }
3929         impl KeysInterface for Keys {
3930                 fn get_node_secret(&self) -> SecretKey { panic!(); }
3931                 fn get_destination_script(&self) -> Script {
3932                         let secp_ctx = Secp256k1::signing_only();
3933                         let channel_monitor_claim_key = SecretKey::from_slice(&secp_ctx, &hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
3934                         let our_channel_monitor_claim_key_hash = Hash160::from_data(&PublicKey::from_secret_key(&secp_ctx, &channel_monitor_claim_key).serialize());
3935                         Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&our_channel_monitor_claim_key_hash[..]).into_script()
3936                 }
3937
3938                 fn get_shutdown_pubkey(&self) -> PublicKey {
3939                         let secp_ctx = Secp256k1::signing_only();
3940                         let channel_close_key = SecretKey::from_slice(&secp_ctx, &hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
3941                         PublicKey::from_secret_key(&secp_ctx, &channel_close_key)
3942                 }
3943
3944                 fn get_channel_keys(&self, _inbound: bool) -> ChannelKeys { self.chan_keys.clone() }
3945                 fn get_session_key(&self) -> SecretKey { panic!(); }
3946         }
3947
3948         #[test]
3949         fn outbound_commitment_test() {
3950                 // Test vectors from BOLT 3 Appendix C:
3951                 let feeest = TestFeeEstimator{fee_est: 15000};
3952                 let logger : Arc<Logger> = Arc::new(test_utils::TestLogger::new());
3953                 let secp_ctx = Secp256k1::new();
3954
3955                 let chan_keys = ChannelKeys {
3956                         funding_key: SecretKey::from_slice(&secp_ctx, &hex::decode("30ff4956bbdd3222d44cc5e8a1261dab1e07957bdac5ae88fe3261ef321f3749").unwrap()[..]).unwrap(),
3957                         payment_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
3958                         delayed_payment_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("3333333333333333333333333333333333333333333333333333333333333333").unwrap()[..]).unwrap(),
3959                         htlc_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
3960
3961                         // These aren't set in the test vectors:
3962                         revocation_base_key: SecretKey::from_slice(&secp_ctx, &hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
3963                         commitment_seed: [0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff],
3964                 };
3965                 assert_eq!(PublicKey::from_secret_key(&secp_ctx, &chan_keys.funding_key).serialize()[..],
3966                                 hex::decode("023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb").unwrap()[..]);
3967                 let keys_provider: Arc<KeysInterface> = Arc::new(Keys { chan_keys });
3968
3969                 let their_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &[42; 32]).unwrap());
3970                 let mut config = UserConfig::new();
3971                 config.channel_options.announced_channel = false;
3972                 let mut chan = Channel::new_outbound(&feeest, &keys_provider, their_node_id, 10000000, 100000, 42, Arc::clone(&logger), &config).unwrap(); // Nothing uses their network key in this test
3973                 chan.their_to_self_delay = 144;
3974                 chan.our_dust_limit_satoshis = 546;
3975
3976                 let funding_info = OutPoint::new(Sha256dHash::from_hex("8984484a580b825b9972d7adb15050b3ab624ccd731946b3eeddb92f4e7ef6be").unwrap(), 0);
3977                 chan.channel_monitor.set_funding_info((funding_info, Script::new()));
3978
3979                 chan.their_payment_basepoint = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex::decode("4444444444444444444444444444444444444444444444444444444444444444").unwrap()[..]).unwrap()));
3980                 assert_eq!(chan.their_payment_basepoint.unwrap().serialize()[..],
3981                                 hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
3982
3983                 chan.their_funding_pubkey = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex::decode("1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13").unwrap()[..]).unwrap()));
3984                 assert_eq!(chan.their_funding_pubkey.unwrap().serialize()[..],
3985                                 hex::decode("030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c1").unwrap()[..]);
3986
3987                 chan.their_htlc_basepoint = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex::decode("4444444444444444444444444444444444444444444444444444444444444444").unwrap()[..]).unwrap()));
3988                 assert_eq!(chan.their_htlc_basepoint.unwrap().serialize()[..],
3989                                 hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
3990
3991                 chan.their_revocation_basepoint = Some(PublicKey::from_slice(&secp_ctx, &hex::decode("02466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27").unwrap()[..]).unwrap());
3992
3993                 // We can't just use build_local_transaction_keys here as the per_commitment_secret is not
3994                 // derived from a commitment_seed, so instead we copy it here and call
3995                 // build_commitment_transaction.
3996                 let delayed_payment_base = PublicKey::from_secret_key(&secp_ctx, &chan.local_keys.delayed_payment_base_key);
3997                 let per_commitment_secret = SecretKey::from_slice(&secp_ctx, &hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
3998                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
3999                 let htlc_basepoint = PublicKey::from_secret_key(&secp_ctx, &chan.local_keys.htlc_base_key);
4000                 let keys = TxCreationKeys::new(&secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &chan.their_revocation_basepoint.unwrap(), &chan.their_payment_basepoint.unwrap(), &chan.their_htlc_basepoint.unwrap()).unwrap();
4001
4002                 let mut unsigned_tx: (Transaction, Vec<HTLCOutputInCommitment>);
4003
4004                 macro_rules! test_commitment {
4005                         ( $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr) => {
4006                                 unsigned_tx = {
4007                                         let res = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw);
4008                                         (res.0, res.1)
4009                                 };
4010                                 let their_signature = Signature::from_der(&secp_ctx, &hex::decode($their_sig_hex).unwrap()[..]).unwrap();
4011                                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&unsigned_tx.0).sighash_all(&unsigned_tx.0.input[0], &chan.get_funding_redeemscript(), chan.channel_value_satoshis)[..]).unwrap();
4012                                 secp_ctx.verify(&sighash, &their_signature, &chan.their_funding_pubkey.unwrap()).unwrap();
4013
4014                                 chan.sign_commitment_transaction(&mut unsigned_tx.0, &their_signature);
4015
4016                                 assert_eq!(serialize(&unsigned_tx.0)[..],
4017                                                 hex::decode($tx_hex).unwrap()[..]);
4018                         };
4019                 }
4020
4021                 macro_rules! test_htlc_output {
4022                         ( $htlc_idx: expr, $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr ) => {
4023                                 let remote_signature = Signature::from_der(&secp_ctx, &hex::decode($their_sig_hex).unwrap()[..]).unwrap();
4024
4025                                 let ref htlc = unsigned_tx.1[$htlc_idx];
4026                                 let mut htlc_tx = chan.build_htlc_transaction(&unsigned_tx.0.txid(), &htlc, true, &keys, chan.feerate_per_kw);
4027                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys);
4028                                 let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
4029                                 secp_ctx.verify(&htlc_sighash, &remote_signature, &keys.b_htlc_key).unwrap();
4030
4031                                 let mut preimage: Option<[u8; 32]> = None;
4032                                 if !htlc.offered {
4033                                         for i in 0..5 {
4034                                                 let mut sha = Sha256::new();
4035                                                 sha.input(&[i; 32]);
4036
4037                                                 let mut out = [0; 32];
4038                                                 sha.result(&mut out);
4039
4040                                                 if out == htlc.payment_hash {
4041                                                         preimage = Some([i; 32]);
4042                                                 }
4043                                         }
4044
4045                                         assert!(preimage.is_some());
4046                                 }
4047
4048                                 chan.sign_htlc_transaction(&mut htlc_tx, &remote_signature, &preimage, &htlc, &keys).unwrap();
4049                                 assert_eq!(serialize(&htlc_tx)[..],
4050                                                 hex::decode($tx_hex).unwrap()[..]);
4051                         };
4052                 }
4053
4054                 {
4055                         // simple commitment tx with no HTLCs
4056                         chan.value_to_self_msat = 7000000000;
4057
4058                         test_commitment!("3045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c0",
4059                                          "3044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c3836939",
4060                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311054a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c383693901483045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4061                 }
4062
4063                 chan.pending_inbound_htlcs.push({
4064                         let mut out = InboundHTLCOutput{
4065                                 htlc_id: 0,
4066                                 amount_msat: 1000000,
4067                                 cltv_expiry: 500,
4068                                 payment_hash: [0; 32],
4069                                 state: InboundHTLCState::Committed,
4070                         };
4071                         let mut sha = Sha256::new();
4072                         sha.input(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
4073                         sha.result(&mut out.payment_hash);
4074                         out
4075                 });
4076                 chan.pending_inbound_htlcs.push({
4077                         let mut out = InboundHTLCOutput{
4078                                 htlc_id: 1,
4079                                 amount_msat: 2000000,
4080                                 cltv_expiry: 501,
4081                                 payment_hash: [0; 32],
4082                                 state: InboundHTLCState::Committed,
4083                         };
4084                         let mut sha = Sha256::new();
4085                         sha.input(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
4086                         sha.result(&mut out.payment_hash);
4087                         out
4088                 });
4089                 chan.pending_outbound_htlcs.push({
4090                         let mut out = OutboundHTLCOutput{
4091                                 htlc_id: 2,
4092                                 amount_msat: 2000000,
4093                                 cltv_expiry: 502,
4094                                 payment_hash: [0; 32],
4095                                 state: OutboundHTLCState::Committed,
4096                                 source: HTLCSource::dummy(),
4097                                 fail_reason: None,
4098                         };
4099                         let mut sha = Sha256::new();
4100                         sha.input(&hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap());
4101                         sha.result(&mut out.payment_hash);
4102                         out
4103                 });
4104                 chan.pending_outbound_htlcs.push({
4105                         let mut out = OutboundHTLCOutput{
4106                                 htlc_id: 3,
4107                                 amount_msat: 3000000,
4108                                 cltv_expiry: 503,
4109                                 payment_hash: [0; 32],
4110                                 state: OutboundHTLCState::Committed,
4111                                 source: HTLCSource::dummy(),
4112                                 fail_reason: None,
4113                         };
4114                         let mut sha = Sha256::new();
4115                         sha.input(&hex::decode("0303030303030303030303030303030303030303030303030303030303030303").unwrap());
4116                         sha.result(&mut out.payment_hash);
4117                         out
4118                 });
4119                 chan.pending_inbound_htlcs.push({
4120                         let mut out = InboundHTLCOutput{
4121                                 htlc_id: 4,
4122                                 amount_msat: 4000000,
4123                                 cltv_expiry: 504,
4124                                 payment_hash: [0; 32],
4125                                 state: InboundHTLCState::Committed,
4126                         };
4127                         let mut sha = Sha256::new();
4128                         sha.input(&hex::decode("0404040404040404040404040404040404040404040404040404040404040404").unwrap());
4129                         sha.result(&mut out.payment_hash);
4130                         out
4131                 });
4132
4133                 {
4134                         // commitment tx with all five HTLCs untrimmed (minimum feerate)
4135                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4136                         chan.feerate_per_kw = 0;
4137
4138                         test_commitment!("304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b70606",
4139                                          "30440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f06",
4140                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f060147304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b7060601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4141
4142                         assert_eq!(unsigned_tx.1.len(), 5);
4143
4144                         test_htlc_output!(0,
4145                                           "304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a6",
4146                                           "304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5",
4147                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219700000000000000000001e8030000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a60147304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
4148
4149                         test_htlc_output!(1,
4150                                           "3045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b",
4151                                           "3045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be5",
4152                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219701000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b01483045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4153
4154                         test_htlc_output!(2,
4155                                           "304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f202",
4156                                           "3045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da",
4157                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219702000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f20201483045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4158
4159                         test_htlc_output!(3,
4160                                           "3045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554",
4161                                           "30440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac08727",
4162                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219703000000000000000001b80b0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554014730440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac0872701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4163
4164                         test_htlc_output!(4,
4165                                           "304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d",
4166                                           "30440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e",
4167                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219704000000000000000001a00f0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d014730440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4168                 }
4169
4170                 {
4171                         // commitment tx with seven outputs untrimmed (maximum feerate)
4172                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4173                         chan.feerate_per_kw = 647;
4174
4175                         test_commitment!("3045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b",
4176                                          "304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d1163",
4177                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040048304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d116301483045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4178
4179                         assert_eq!(unsigned_tx.1.len(), 5);
4180
4181                         test_htlc_output!(0,
4182                                           "30440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab343740",
4183                                           "304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a",
4184                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab3437400147304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
4185
4186                         test_htlc_output!(1,
4187                                           "304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b0",
4188                                           "304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac",
4189                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60100000000000000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b00147304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4190
4191                         test_htlc_output!(2,
4192                                           "304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d833",
4193                                           "3045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877",
4194                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6020000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d83301483045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4195
4196                         test_htlc_output!(3,
4197                                           "30450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d",
4198                                           "3045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb",
4199                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6030000000000000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d01483045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4200
4201                         test_htlc_output!(4,
4202                                           "3045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f0",
4203                                           "304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f",
4204                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb604000000000000000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f00147304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4205                 }
4206
4207                 {
4208                         // commitment tx with six outputs untrimmed (minimum feerate)
4209                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4210                         chan.feerate_per_kw = 648;
4211
4212                         test_commitment!("3044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b057",
4213                                          "3045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de",
4214                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431104e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de01473044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b05701475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4215
4216                         assert_eq!(unsigned_tx.1.len(), 4);
4217
4218                         test_htlc_output!(0,
4219                                           "3044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada8",
4220                                           "3045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc098",
4221                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10000000000000000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada801483045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc09801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4222
4223                         test_htlc_output!(1,
4224                                           "3045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d4",
4225                                           "304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0",
4226                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10100000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d40147304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4227
4228                         test_htlc_output!(2,
4229                                           "3045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c2",
4230                                           "304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda3",
4231                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd1020000000000000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c20147304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda301008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4232
4233                         test_htlc_output!(3,
4234                                           "3044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f",
4235                                           "304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6",
4236                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd103000000000000000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f0147304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4237                 }
4238
4239                 {
4240                         // commitment tx with six outputs untrimmed (maximum feerate)
4241                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4242                         chan.feerate_per_kw = 2069;
4243
4244                         test_commitment!("3044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb4",
4245                                          "304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea",
4246                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311077956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea01473044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4247
4248                         assert_eq!(unsigned_tx.1.len(), 4);
4249
4250                         test_htlc_output!(0,
4251                                           "3045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f992",
4252                                           "3044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae66402",
4253                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0000000000000000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f99201473044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae6640201008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4254
4255                         test_htlc_output!(1,
4256                                           "3045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f4",
4257                                           "3045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f",
4258                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0100000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f401483045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4259
4260                         test_htlc_output!(2,
4261                                           "3045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef18",
4262                                           "304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f9",
4263                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a020000000000000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef180147304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f901008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4264
4265                         test_htlc_output!(3,
4266                                           "30450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c",
4267                                           "304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5",
4268                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a03000000000000000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c0147304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4269                 }
4270
4271                 {
4272                         // commitment tx with five outputs untrimmed (minimum feerate)
4273                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4274                         chan.feerate_per_kw = 2070;
4275
4276                         test_commitment!("3045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f37526",
4277                                          "30440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd0",
4278                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd001483045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f3752601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4279
4280                         assert_eq!(unsigned_tx.1.len(), 3);
4281
4282                         test_htlc_output!(0,
4283                                           "3045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f891",
4284                                           "3045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb8",
4285                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a2180000000000000000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f89101483045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4286
4287                         test_htlc_output!(1,
4288                                           "3044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf6",
4289                                           "3045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d",
4290                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a218010000000000000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf601483045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4291
4292                         test_htlc_output!(2,
4293                                           "3045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a4",
4294                                           "304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04",
4295                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a21802000000000000000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a40147304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4296                 }
4297
4298                 {
4299                         // commitment tx with five outputs untrimmed (maximum feerate)
4300                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4301                         chan.feerate_per_kw = 2194;
4302
4303                         test_commitment!("3045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec86203953348",
4304                                          "304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f7061",
4305                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311040966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f706101483045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec8620395334801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4306
4307                         assert_eq!(unsigned_tx.1.len(), 3);
4308
4309                         test_htlc_output!(0,
4310                                           "30450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf44",
4311                                           "3044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f",
4312                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf4401473044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4313
4314                         test_htlc_output!(1,
4315                                           "30440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d",
4316                                           "304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c915",
4317                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a010000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d0147304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c91501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4318
4319                         test_htlc_output!(2,
4320                                           "3045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a",
4321                                           "3045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0",
4322                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a020000000000000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a01483045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4323                 }
4324
4325                 {
4326                         // commitment tx with four outputs untrimmed (minimum feerate)
4327                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4328                         chan.feerate_per_kw = 2195;
4329
4330                         test_commitment!("304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb7924298",
4331                                          "304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a5429",
4332                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a54290147304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb792429801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4333
4334                         assert_eq!(unsigned_tx.1.len(), 2);
4335
4336                         test_htlc_output!(0,
4337                                           "3045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc",
4338                                           "3045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc704390",
4339                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0000000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc01483045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc70439001008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4340
4341                         test_htlc_output!(1,
4342                                           "3045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92",
4343                                           "30440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8",
4344                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0100000000000000000199090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92014730440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4345                 }
4346
4347                 {
4348                         // commitment tx with four outputs untrimmed (maximum feerate)
4349                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4350                         chan.feerate_per_kw = 3702;
4351
4352                         test_commitment!("3045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c1",
4353                                          "304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b0",
4354                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431106f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b001483045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c101475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4355
4356                         assert_eq!(unsigned_tx.1.len(), 2);
4357
4358                         test_htlc_output!(0,
4359                                           "3045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb",
4360                                           "304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a",
4361                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb0147304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4362
4363                         test_htlc_output!(1,
4364                                           "3045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9",
4365                                           "30440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c",
4366                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30100000000000000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9014730440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4367                 }
4368
4369                 {
4370                         // commitment tx with three outputs untrimmed (minimum feerate)
4371                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4372                         chan.feerate_per_kw = 3703;
4373
4374                         test_commitment!("30450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb0",
4375                                          "3044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506",
4376                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506014830450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4377
4378                         assert_eq!(unsigned_tx.1.len(), 1);
4379
4380                         test_htlc_output!(0,
4381                                           "3044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd",
4382                                           "3045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724",
4383                                           "020000000001011c076aa7fb3d7460d10df69432c904227ea84bbf3134d4ceee5fb0f135ef206d0000000000000000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd01483045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4384                 }
4385
4386                 {
4387                         // commitment tx with three outputs untrimmed (maximum feerate)
4388                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4389                         chan.feerate_per_kw = 4914;
4390
4391                         test_commitment!("304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e",
4392                                          "304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe26",
4393                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe260147304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4394
4395                         assert_eq!(unsigned_tx.1.len(), 1);
4396
4397                         test_htlc_output!(0,
4398                                           "3045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf",
4399                                           "304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68",
4400                                           "0200000000010110a3fdcbcd5db477cd3ad465e7f501ffa8c437e8301f00a6061138590add757f0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf0148304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4401                 }
4402
4403                 {
4404                         // commitment tx with two outputs untrimmed (minimum feerate)
4405                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4406                         chan.feerate_per_kw = 4915;
4407
4408                         test_commitment!("304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f8765552",
4409                                          "3045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b9",
4410                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b90147304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f876555201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4411
4412                         assert_eq!(unsigned_tx.1.len(), 0);
4413                 }
4414
4415                 {
4416                         // commitment tx with two outputs untrimmed (maximum feerate)
4417                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4418                         chan.feerate_per_kw = 9651180;
4419
4420                         test_commitment!("3044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd",
4421                                          "30440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b9",
4422                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311004004730440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b901473044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4423
4424                         assert_eq!(unsigned_tx.1.len(), 0);
4425                 }
4426
4427                 {
4428                         // commitment tx with one output untrimmed (minimum feerate)
4429                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4430                         chan.feerate_per_kw = 9651181;
4431
4432                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
4433                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
4434                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4435
4436                         assert_eq!(unsigned_tx.1.len(), 0);
4437                 }
4438
4439                 {
4440                         // commitment tx with fee greater than funder amount
4441                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4442                         chan.feerate_per_kw = 9651936;
4443
4444                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
4445                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
4446                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4447
4448                         assert_eq!(unsigned_tx.1.len(), 0);
4449                 }
4450         }
4451
4452         #[test]
4453         fn test_per_commitment_secret_gen() {
4454                 // Test vectors from BOLT 3 Appendix D:
4455
4456                 let mut seed = [0; 32];
4457                 seed[0..32].clone_from_slice(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
4458                 assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655),
4459                            hex::decode("02a40c85b6f28da08dfdbe0926c53fab2de6d28c10301f8f7c4073d5e42e3148").unwrap()[..]);
4460
4461                 seed[0..32].clone_from_slice(&hex::decode("FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF").unwrap());
4462                 assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655),
4463                            hex::decode("7cc854b54e3e0dcdb010d7a3fee464a9687be6e8db3be6854c475621e007a5dc").unwrap()[..]);
4464
4465                 assert_eq!(chan_utils::build_commitment_secret(seed, 0xaaaaaaaaaaa),
4466                            hex::decode("56f4008fb007ca9acf0e15b054d5c9fd12ee06cea347914ddbaed70d1c13a528").unwrap()[..]);
4467
4468                 assert_eq!(chan_utils::build_commitment_secret(seed, 0x555555555555),
4469                            hex::decode("9015daaeb06dba4ccc05b91b2f73bd54405f2be9f217fbacd3c5ac2e62327d31").unwrap()[..]);
4470
4471                 seed[0..32].clone_from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
4472                 assert_eq!(chan_utils::build_commitment_secret(seed, 1),
4473                            hex::decode("915c75942a26bb3a433a8ce2cb0427c29ec6c1775cfc78328b57f6ba7bfeaa9c").unwrap()[..]);
4474         }
4475
4476         #[test]
4477         fn test_key_derivation() {
4478                 // Test vectors from BOLT 3 Appendix E:
4479                 let secp_ctx = Secp256k1::new();
4480
4481                 let base_secret = SecretKey::from_slice(&secp_ctx, &hex::decode("000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f").unwrap()[..]).unwrap();
4482                 let per_commitment_secret = SecretKey::from_slice(&secp_ctx, &hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
4483
4484                 let base_point = PublicKey::from_secret_key(&secp_ctx, &base_secret);
4485                 assert_eq!(base_point.serialize()[..], hex::decode("036d6caac248af96f6afa7f904f550253a0f3ef3f5aa2fe6838a95b216691468e2").unwrap()[..]);
4486
4487                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
4488                 assert_eq!(per_commitment_point.serialize()[..], hex::decode("025f7117a78150fe2ef97db7cfc83bd57b2e2c0d0dd25eaf467a4a1c2a45ce1486").unwrap()[..]);
4489
4490                 assert_eq!(chan_utils::derive_public_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
4491                                 hex::decode("0235f2dbfaa89b57ec7b055afe29849ef7ddfeb1cefdb9ebdc43f5494984db29e5").unwrap()[..]);
4492
4493                 assert_eq!(chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &base_secret).unwrap(),
4494                                 SecretKey::from_slice(&secp_ctx, &hex::decode("cbced912d3b21bf196a766651e436aff192362621ce317704ea2f75d87e7be0f").unwrap()[..]).unwrap());
4495
4496                 assert_eq!(chan_utils::derive_public_revocation_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
4497                                 hex::decode("02916e326636d19c33f13e8c0c3a03dd157f332f3e99c317c141dd865eb01f8ff0").unwrap()[..]);
4498
4499                 assert_eq!(chan_utils::derive_private_revocation_key(&secp_ctx, &per_commitment_secret, &base_secret).unwrap(),
4500                                 SecretKey::from_slice(&secp_ctx, &hex::decode("d09ffff62ddb2297ab000cc85bcb4283fdeb6aa052affbc9dddcf33b61078110").unwrap()[..]).unwrap());
4501         }
4502 }