_ Git - rust-lightning/blob - src/ln/channel.rs

   1 use bitcoin::blockdata::block::BlockHeader;
   2 use bitcoin::blockdata::script::{Script,Builder};
   3 use bitcoin::blockdata::transaction::{TxIn, TxOut, Transaction, SigHashType};
   4 use bitcoin::blockdata::opcodes;
   5 use bitcoin::util::hash::BitcoinHash;
   6 use bitcoin::util::bip143;
   7 use bitcoin::consensus::encode::{self, Encodable, Decodable};
   8
   9 use bitcoin_hashes::{Hash, HashEngine};
  10 use bitcoin_hashes::sha256::Hash as Sha256;
  11 use bitcoin_hashes::hash160::Hash as Hash160;
  12 use bitcoin_hashes::sha256d::Hash as Sha256dHash;
  13
  14 use secp256k1::key::{PublicKey,SecretKey};
  15 use secp256k1::{Secp256k1,Signature};
  16 use secp256k1;
  17
  18 use ln::msgs;
  19 use ln::msgs::{DecodeError, OptionalField, LocalFeatures};
  20 use ln::channelmonitor::ChannelMonitor;
  21 use ln::channelmanager::{PendingHTLCStatus, HTLCSource, HTLCFailReason, HTLCFailureMsg, PendingForwardHTLCInfo, RAACommitmentOrder, PaymentPreimage, PaymentHash, BREAKDOWN_TIMEOUT, MAX_LOCAL_BREAKDOWN_TIMEOUT};
  22 use ln::chan_utils::{TxCreationKeys,HTLCOutputInCommitment,HTLC_SUCCESS_TX_WEIGHT,HTLC_TIMEOUT_TX_WEIGHT};
  23 use ln::chan_utils;
  24 use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
  25 use chain::transaction::OutPoint;
  26 use chain::keysinterface::{ChannelKeys, KeysInterface};
  27 use util::transaction_utils;
  28 use util::ser::{Readable, ReadableArgs, Writeable, Writer, WriterWriteAdaptor};
  29 use util::logger::{Logger, LogHolder};
  30 use util::errors::APIError;
  31 use util::config::{UserConfig,ChannelConfig};
  32
  33 use std;
  34 use std::default::Default;
  35 use std::{cmp,mem};
  36 use std::sync::{Arc};
  37
  38 #[cfg(test)]
  39 pub struct ChannelValueStat {
  40         pub value_to_self_msat: u64,
  41         pub channel_value_msat: u64,
  42         pub channel_reserve_msat: u64,
  43         pub pending_outbound_htlcs_amount_msat: u64,
  44         pub pending_inbound_htlcs_amount_msat: u64,
  45         pub holding_cell_outbound_amount_msat: u64,
  46         pub their_max_htlc_value_in_flight_msat: u64, // outgoing
  47 }
  48
  49 enum InboundHTLCRemovalReason {
  50         FailRelay(msgs::OnionErrorPacket),
  51         FailMalformed(([u8; 32], u16)),
  52         Fulfill(PaymentPreimage),
  53 }
  54
  55 enum InboundHTLCState {
  56         /// Added by remote, to be included in next local commitment tx.
  57         RemoteAnnounced(PendingHTLCStatus),
  58         /// Included in a received commitment_signed message (implying we've revoke_and_ack'ed it), but
  59         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
  60         /// accept this HTLC. Implies AwaitingRemoteRevoke.
  61         /// We also have not yet included this HTLC in a commitment_signed message, and are waiting on
  62         /// a remote revoke_and_ack on a previous state before we can do so.
  63         AwaitingRemoteRevokeToAnnounce(PendingHTLCStatus),
  64         /// Included in a received commitment_signed message (implying we've revoke_and_ack'ed it), but
  65         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
  66         /// accept this HTLC. Implies AwaitingRemoteRevoke.
  67         /// We have included this HTLC in our latest commitment_signed and are now just waiting on a
  68         /// revoke_and_ack.
  69         AwaitingAnnouncedRemoteRevoke(PendingHTLCStatus),
  70         Committed,
  71         /// Removed by us and a new commitment_signed was sent (if we were AwaitingRemoteRevoke when we
  72         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
  73         /// we'll drop it.
  74         /// Note that we have to keep an eye on the HTLC until we've received a broadcastable
  75         /// commitment transaction without it as otherwise we'll have to force-close the channel to
  76         /// claim it before the timeout (obviously doesn't apply to revoked HTLCs that we can't claim
  77         /// anyway). That said, ChannelMonitor does this for us (see
  78         /// ChannelMonitor::would_broadcast_at_height) so we actually remove the HTLC from our own
  79         /// local state before then, once we're sure that the next commitment_signed and
  80         /// ChannelMonitor::provide_latest_local_commitment_tx_info will not include this HTLC.
  81         LocalRemoved(InboundHTLCRemovalReason),
  82 }
  83
  84 struct InboundHTLCOutput {
  85         htlc_id: u64,
  86         amount_msat: u64,
  87         cltv_expiry: u32,
  88         payment_hash: PaymentHash,
  89         state: InboundHTLCState,
  90 }
  91
  92 enum OutboundHTLCState {
  93         /// Added by us and included in a commitment_signed (if we were AwaitingRemoteRevoke when we
  94         /// created it we would have put it in the holding cell instead). When they next revoke_and_ack
  95         /// we will promote to Committed (note that they may not accept it until the next time we
  96         /// revoke, but we don't really care about that:
  97         ///  * they've revoked, so worst case we can announce an old state and get our (option on)
  98         ///    money back (though we won't), and,
  99         ///  * we'll send them a revoke when they send a commitment_signed, and since only they're
 100         ///    allowed to remove it, the "can only be removed once committed on both sides" requirement
 101         ///    doesn't matter to us and it's up to them to enforce it, worst-case they jump ahead but
 102         ///    we'll never get out of sync).
 103         /// Note that we Box the OnionPacket as it's rather large and we don't want to blow up
 104         /// OutboundHTLCOutput's size just for a temporary bit
 105         LocalAnnounced(Box<msgs::OnionPacket>),
 106         Committed,
 107         /// Remote removed this (outbound) HTLC. We're waiting on their commitment_signed to finalize
 108         /// the change (though they'll need to revoke before we fail the payment).
 109         RemoteRemoved(Option<HTLCFailReason>),
 110         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
 111         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
 112         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
 113         /// We also have not yet removed this HTLC in a commitment_signed message, and are waiting on a
 114         /// remote revoke_and_ack on a previous state before we can do so.
 115         AwaitingRemoteRevokeToRemove(Option<HTLCFailReason>),
 116         /// Remote removed this and sent a commitment_signed (implying we've revoke_and_ack'ed it), but
 117         /// the remote side hasn't yet revoked their previous state, which we need them to do before we
 118         /// can do any backwards failing. Implies AwaitingRemoteRevoke.
 119         /// We have removed this HTLC in our latest commitment_signed and are now just waiting on a
 120         /// revoke_and_ack to drop completely.
 121         AwaitingRemovedRemoteRevoke(Option<HTLCFailReason>),
 122 }
 123
 124 struct OutboundHTLCOutput {
 125         htlc_id: u64,
 126         amount_msat: u64,
 127         cltv_expiry: u32,
 128         payment_hash: PaymentHash,
 129         state: OutboundHTLCState,
 130         source: HTLCSource,
 131 }
 132
 133 /// See AwaitingRemoteRevoke ChannelState for more info
 134 enum HTLCUpdateAwaitingACK {
 135         AddHTLC { // TODO: Time out if we're getting close to cltv_expiry
 136                 // always outbound
 137                 amount_msat: u64,
 138                 cltv_expiry: u32,
 139                 payment_hash: PaymentHash,
 140                 source: HTLCSource,
 141                 onion_routing_packet: msgs::OnionPacket,
 142         },
 143         ClaimHTLC {
 144                 payment_preimage: PaymentPreimage,
 145                 htlc_id: u64,
 146         },
 147         FailHTLC {
 148                 htlc_id: u64,
 149                 err_packet: msgs::OnionErrorPacket,
 150         },
 151 }
 152
 153 /// There are a few "states" and then a number of flags which can be applied:
 154 /// We first move through init with OurInitSent -> TheirInitSent -> FundingCreated -> FundingSent.
 155 /// TheirFundingLocked and OurFundingLocked then get set on FundingSent, and when both are set we
 156 /// move on to ChannelFunded.
 157 /// Note that PeerDisconnected can be set on both ChannelFunded and FundingSent.
 158 /// ChannelFunded can then get all remaining flags set on it, until we finish shutdown, then we
 159 /// move on to ShutdownComplete, at which point most calls into this channel are disallowed.
 160 enum ChannelState {
 161         /// Implies we have (or are prepared to) send our open_channel/accept_channel message
 162         OurInitSent = (1 << 0),
 163         /// Implies we have received their open_channel/accept_channel message
 164         TheirInitSent = (1 << 1),
 165         /// We have sent funding_created and are awaiting a funding_signed to advance to FundingSent.
 166         /// Note that this is nonsense for an inbound channel as we immediately generate funding_signed
 167         /// upon receipt of funding_created, so simply skip this state.
 168         FundingCreated = 4,
 169         /// Set when we have received/sent funding_created and funding_signed and are thus now waiting
 170         /// on the funding transaction to confirm. The FundingLocked flags are set to indicate when we
 171         /// and our counterparty consider the funding transaction confirmed.
 172         FundingSent = 8,
 173         /// Flag which can be set on FundingSent to indicate they sent us a funding_locked message.
 174         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
 175         TheirFundingLocked = (1 << 4),
 176         /// Flag which can be set on FundingSent to indicate we sent them a funding_locked message.
 177         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
 178         OurFundingLocked = (1 << 5),
 179         ChannelFunded = 64,
 180         /// Flag which is set on ChannelFunded and FundingSent indicating remote side is considered
 181         /// "disconnected" and no updates are allowed until after we've done a channel_reestablish
 182         /// dance.
 183         PeerDisconnected = (1 << 7),
 184         /// Flag which is set on ChannelFunded, FundingCreated, and FundingSent indicating the user has
 185         /// told us they failed to update our ChannelMonitor somewhere and we should pause sending any
 186         /// outbound messages until they've managed to do so.
 187         MonitorUpdateFailed = (1 << 8),
 188         /// Flag which implies that we have sent a commitment_signed but are awaiting the responding
 189         /// revoke_and_ack message. During this time period, we can't generate new commitment_signed
 190         /// messages as then we will be unable to determine which HTLCs they included in their
 191         /// revoke_and_ack implicit ACK, so instead we have to hold them away temporarily to be sent
 192         /// later.
 193         /// Flag is set on ChannelFunded.
 194         AwaitingRemoteRevoke = (1 << 9),
 195         /// Flag which is set on ChannelFunded or FundingSent after receiving a shutdown message from
 196         /// the remote end. If set, they may not add any new HTLCs to the channel, and we are expected
 197         /// to respond with our own shutdown message when possible.
 198         RemoteShutdownSent = (1 << 10),
 199         /// Flag which is set on ChannelFunded or FundingSent after sending a shutdown message. At this
 200         /// point, we may not add any new HTLCs to the channel.
 201         /// TODO: Investigate some kind of timeout mechanism by which point the remote end must provide
 202         /// us their shutdown.
 203         LocalShutdownSent = (1 << 11),
 204         /// We've successfully negotiated a closing_signed dance. At this point ChannelManager is about
 205         /// to drop us, but we store this anyway.
 206         ShutdownComplete = 4096,
 207 }
 208 const BOTH_SIDES_SHUTDOWN_MASK: u32 = (ChannelState::LocalShutdownSent as u32 | ChannelState::RemoteShutdownSent as u32);
 209 const MULTI_STATE_FLAGS: u32 = (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32);
 210
 211 const INITIAL_COMMITMENT_NUMBER: u64 = (1 << 48) - 1;
 212
 213 // TODO: We should refactor this to be an Inbound/OutboundChannel until initial setup handshaking
 214 // has been completed, and then turn into a Channel to get compiler-time enforcement of things like
 215 // calling channel_id() before we're set up or things like get_outbound_funding_signed on an
 216 // inbound channel.
 217 pub(super) struct Channel {
 218         config: ChannelConfig,
 219
 220         user_id: u64,
 221
 222         channel_id: [u8; 32],
 223         channel_state: u32,
 224         channel_outbound: bool,
 225         secp_ctx: Secp256k1<secp256k1::All>,
 226         channel_value_satoshis: u64,
 227
 228         local_keys: ChannelKeys,
 229         shutdown_pubkey: PublicKey,
 230
 231         // Our commitment numbers start at 2^48-1 and count down, whereas the ones used in transaction
 232         // generation start at 0 and count up...this simplifies some parts of implementation at the
 233         // cost of others, but should really just be changed.
 234
 235         cur_local_commitment_transaction_number: u64,
 236         cur_remote_commitment_transaction_number: u64,
 237         value_to_self_msat: u64, // Excluding all pending_htlcs, excluding fees
 238         pending_inbound_htlcs: Vec<InboundHTLCOutput>,
 239         pending_outbound_htlcs: Vec<OutboundHTLCOutput>,
 240         holding_cell_htlc_updates: Vec<HTLCUpdateAwaitingACK>,
 241
 242         /// When resending CS/RAA messages on channel monitor restoration or on reconnect, we always
 243         /// need to ensure we resend them in the order we originally generated them. Note that because
 244         /// there can only ever be one in-flight CS and/or one in-flight RAA at any time, it is
 245         /// sufficient to simply set this to the opposite of any message we are generating as we
 246         /// generate it. ie when we generate a CS, we set this to RAAFirst as, if there is a pending
 247         /// in-flight RAA to resend, it will have been the first thing we generated, and thus we should
 248         /// send it first.
 249         resend_order: RAACommitmentOrder,
 250
 251         monitor_pending_funding_locked: bool,
 252         monitor_pending_revoke_and_ack: bool,
 253         monitor_pending_commitment_signed: bool,
 254         monitor_pending_forwards: Vec<(PendingForwardHTLCInfo, u64)>,
 255         monitor_pending_failures: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>,
 256
 257         // pending_update_fee is filled when sending and receiving update_fee
 258         // For outbound channel, feerate_per_kw is updated with the value from
 259         // pending_update_fee when revoke_and_ack is received
 260         //
 261         // For inbound channel, feerate_per_kw is updated when it receives
 262         // commitment_signed and revoke_and_ack is generated
 263         // The pending value is kept when another pair of update_fee and commitment_signed
 264         // is received during AwaitingRemoteRevoke and relieved when the expected
 265         // revoke_and_ack is received and new commitment_signed is generated to be
 266         // sent to the funder. Otherwise, the pending value is removed when receiving
 267         // commitment_signed.
 268         pending_update_fee: Option<u64>,
 269         // update_fee() during ChannelState::AwaitingRemoteRevoke is hold in
 270         // holdina_cell_update_fee then moved to pending_udpate_fee when revoke_and_ack
 271         // is received. holding_cell_update_fee is updated when there are additional
 272         // update_fee() during ChannelState::AwaitingRemoteRevoke.
 273         holding_cell_update_fee: Option<u64>,
 274         next_local_htlc_id: u64,
 275         next_remote_htlc_id: u64,
 276         channel_update_count: u32,
 277         feerate_per_kw: u64,
 278
 279         #[cfg(debug_assertions)]
 280         /// Max to_local and to_remote outputs in a locally-generated commitment transaction
 281         max_commitment_tx_output_local: ::std::sync::Mutex<(u64, u64)>,
 282         #[cfg(debug_assertions)]
 283         /// Max to_local and to_remote outputs in a remote-generated commitment transaction
 284         max_commitment_tx_output_remote: ::std::sync::Mutex<(u64, u64)>,
 285
 286         #[cfg(test)]
 287         // Used in ChannelManager's tests to send a revoked transaction
 288         pub last_local_commitment_txn: Vec<Transaction>,
 289         #[cfg(not(test))]
 290         last_local_commitment_txn: Vec<Transaction>,
 291
 292         last_sent_closing_fee: Option<(u64, u64)>, // (feerate, fee)
 293
 294         /// The hash of the block in which the funding transaction reached our CONF_TARGET. We use this
 295         /// to detect unconfirmation after a serialize-unserialize roundtrip where we may not see a full
 296         /// series of block_connected/block_disconnected calls. Obviously this is not a guarantee as we
 297         /// could miss the funding_tx_confirmed_in block as well, but it serves as a useful fallback.
 298         funding_tx_confirmed_in: Option<Sha256dHash>,
 299         short_channel_id: Option<u64>,
 300         /// Used to deduplicate block_connected callbacks, also used to verify consistency during
 301         /// ChannelManager deserialization (hence pub(super))
 302         pub(super) last_block_connected: Sha256dHash,
 303         funding_tx_confirmations: u64,
 304
 305         their_dust_limit_satoshis: u64,
 306         #[cfg(test)]
 307         pub(super) our_dust_limit_satoshis: u64,
 308         #[cfg(not(test))]
 309         our_dust_limit_satoshis: u64,
 310         #[cfg(test)]
 311         pub(super) their_max_htlc_value_in_flight_msat: u64,
 312         #[cfg(not(test))]
 313         their_max_htlc_value_in_flight_msat: u64,
 314         //get_our_max_htlc_value_in_flight_msat(): u64,
 315         /// minimum channel reserve for **self** to maintain - set by them.
 316         their_channel_reserve_satoshis: u64,
 317         //get_our_channel_reserve_satoshis(): u64,
 318         their_htlc_minimum_msat: u64,
 319         our_htlc_minimum_msat: u64,
 320         their_to_self_delay: u16,
 321         our_to_self_delay: u16,
 322         #[cfg(test)]
 323         pub their_max_accepted_htlcs: u16,
 324         #[cfg(not(test))]
 325         their_max_accepted_htlcs: u16,
 326         //implied by OUR_MAX_HTLCS: our_max_accepted_htlcs: u16,
 327         minimum_depth: u32,
 328
 329         their_funding_pubkey: Option<PublicKey>,
 330         their_revocation_basepoint: Option<PublicKey>,
 331         their_payment_basepoint: Option<PublicKey>,
 332         their_delayed_payment_basepoint: Option<PublicKey>,
 333         their_htlc_basepoint: Option<PublicKey>,
 334         their_cur_commitment_point: Option<PublicKey>,
 335
 336         their_prev_commitment_point: Option<PublicKey>,
 337         their_node_id: PublicKey,
 338
 339         their_shutdown_scriptpubkey: Option<Script>,
 340
 341         channel_monitor: ChannelMonitor,
 342
 343         logger: Arc<Logger>,
 344 }
 345
 346 pub const OUR_MAX_HTLCS: u16 = 50; //TODO
 347 /// Confirmation count threshold at which we close a channel. Ideally we'd keep the channel around
 348 /// on ice until the funding transaction gets more confirmations, but the LN protocol doesn't
 349 /// really allow for this, so instead we're stuck closing it out at that point.
 350 const UNCONF_THRESHOLD: u32 = 6;
 351 /// Exposing these two constants for use in test in ChannelMonitor
 352 pub const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
 353 pub const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
 354 const SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT: u64 = 79; // prevout: 36, nSequence: 4, script len: 1, witness lengths: (3+1)/4, sig: 73/4, if-selector: 1, redeemScript: (6 ops + 2*33 pubkeys + 1*2 delay)/4
 355 const B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT: u64 = 104; // prevout: 40, nSequence: 4, script len: 1, witness lengths: 3/4, sig: 73/4, pubkey: 33/4, output: 31 (TODO: Wrong? Useless?)
 356 /// Maximmum `funding_satoshis` value, according to the BOLT #2 specification
 357 /// it's 2^24.
 358 pub const MAX_FUNDING_SATOSHIS: u64 = (1 << 24);
 359
 360 #[cfg(test)]
 361 pub const ACCEPTED_HTLC_SCRIPT_WEIGHT: usize = 138; //Here we have a diff due to HTLC CLTV expiry being < 2^15 in test
 362 #[cfg(not(test))]
 363 pub const ACCEPTED_HTLC_SCRIPT_WEIGHT: usize = 139;
 364 pub const OFFERED_HTLC_SCRIPT_WEIGHT: usize = 133;
 365
 366 /// Used to return a simple Error back to ChannelManager. Will get converted to a
 367 /// msgs::ErrorAction::SendErrorMessage or msgs::ErrorAction::IgnoreError as appropriate with our
 368 /// channel_id in ChannelManager.
 369 #[derive(Debug)]
 370 pub(super) enum ChannelError {
 371         Ignore(&'static str),
 372         Close(&'static str),
 373 }
 374
 375 macro_rules! secp_check {
 376         ($res: expr, $err: expr) => {
 377                 match $res {
 378                         Ok(thing) => thing,
 379                         Err(_) => return Err(ChannelError::Close($err)),
 380                 }
 381         };
 382 }
 383
 384 impl Channel {
 385         // Convert constants + channel value to limits:
 386         fn get_our_max_htlc_value_in_flight_msat(channel_value_satoshis: u64) -> u64 {
 387                 channel_value_satoshis * 1000 / 10 //TODO
 388         }
 389
 390         /// Returns a minimum channel reserve value **they** need to maintain
 391         ///
 392         /// Guaranteed to return a value no larger than channel_value_satoshis
 393         fn get_our_channel_reserve_satoshis(channel_value_satoshis: u64) -> u64 {
 394                 let (q, _) = channel_value_satoshis.overflowing_div(100);
 395                 cmp::min(channel_value_satoshis, cmp::max(q, 1000)) //TODO
 396         }
 397
 398         fn derive_our_dust_limit_satoshis(at_open_background_feerate: u64) -> u64 {
 399                 cmp::max(at_open_background_feerate * B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT / 1000, 546) //TODO
 400         }
 401
 402         fn derive_our_htlc_minimum_msat(_at_open_channel_feerate_per_kw: u64) -> u64 {
 403                 1000 // TODO
 404         }
 405
 406         // Constructors:
 407         pub fn new_outbound(fee_estimator: &FeeEstimator, keys_provider: &Arc<KeysInterface>, their_node_id: PublicKey, channel_value_satoshis: u64, push_msat: u64, user_id: u64, logger: Arc<Logger>, config: &UserConfig) -> Result<Channel, APIError> {
 408                 let chan_keys = keys_provider.get_channel_keys(false);
 409
 410                 if channel_value_satoshis >= MAX_FUNDING_SATOSHIS {
 411                         return Err(APIError::APIMisuseError{err: "funding value > 2^24"});
 412                 }
 413
 414                 if push_msat > channel_value_satoshis * 1000 {
 415                         return Err(APIError::APIMisuseError{err: "push value > channel value"});
 416                 }
 417                 if config.own_channel_config.our_to_self_delay < BREAKDOWN_TIMEOUT {
 418                         return Err(APIError::APIMisuseError{err: "Configured with an unreasonable our_to_self_delay putting user funds at risks"});
 419                 }
 420
 421
 422                 let background_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
 423                 if Channel::get_our_channel_reserve_satoshis(channel_value_satoshis) < Channel::derive_our_dust_limit_satoshis(background_feerate) {
 424                         return Err(APIError::FeeRateTooHigh{err: format!("Not enough reserve above dust limit can be found at current fee rate({})", background_feerate), feerate: background_feerate});
 425                 }
 426
 427                 let feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
 428
 429                 let secp_ctx = Secp256k1::new();
 430                 let channel_monitor = ChannelMonitor::new(&chan_keys.revocation_base_key, &chan_keys.delayed_payment_base_key,
 431                                                           &chan_keys.htlc_base_key, &chan_keys.payment_base_key, &keys_provider.get_shutdown_pubkey(), config.own_channel_config.our_to_self_delay,
 432                                                           keys_provider.get_destination_script(), logger.clone());
 433
 434                 Ok(Channel {
 435                         user_id: user_id,
 436                         config: config.channel_options.clone(),
 437
 438                         channel_id: keys_provider.get_channel_id(),
 439                         channel_state: ChannelState::OurInitSent as u32,
 440                         channel_outbound: true,
 441                         secp_ctx: secp_ctx,
 442                         channel_value_satoshis: channel_value_satoshis,
 443
 444                         local_keys: chan_keys,
 445                         shutdown_pubkey: keys_provider.get_shutdown_pubkey(),
 446                         cur_local_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
 447                         cur_remote_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
 448                         value_to_self_msat: channel_value_satoshis * 1000 - push_msat,
 449
 450                         pending_inbound_htlcs: Vec::new(),
 451                         pending_outbound_htlcs: Vec::new(),
 452                         holding_cell_htlc_updates: Vec::new(),
 453                         pending_update_fee: None,
 454                         holding_cell_update_fee: None,
 455                         next_local_htlc_id: 0,
 456                         next_remote_htlc_id: 0,
 457                         channel_update_count: 1,
 458
 459                         resend_order: RAACommitmentOrder::CommitmentFirst,
 460
 461                         monitor_pending_funding_locked: false,
 462                         monitor_pending_revoke_and_ack: false,
 463                         monitor_pending_commitment_signed: false,
 464                         monitor_pending_forwards: Vec::new(),
 465                         monitor_pending_failures: Vec::new(),
 466
 467                         #[cfg(debug_assertions)]
 468                         max_commitment_tx_output_local: ::std::sync::Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
 469                         #[cfg(debug_assertions)]
 470                         max_commitment_tx_output_remote: ::std::sync::Mutex::new((channel_value_satoshis * 1000 - push_msat, push_msat)),
 471
 472                         last_local_commitment_txn: Vec::new(),
 473
 474                         last_sent_closing_fee: None,
 475
 476                         funding_tx_confirmed_in: None,
 477                         short_channel_id: None,
 478                         last_block_connected: Default::default(),
 479                         funding_tx_confirmations: 0,
 480
 481                         feerate_per_kw: feerate,
 482                         their_dust_limit_satoshis: 0,
 483                         our_dust_limit_satoshis: Channel::derive_our_dust_limit_satoshis(background_feerate),
 484                         their_max_htlc_value_in_flight_msat: 0,
 485                         their_channel_reserve_satoshis: 0,
 486                         their_htlc_minimum_msat: 0,
 487                         our_htlc_minimum_msat: Channel::derive_our_htlc_minimum_msat(feerate),
 488                         their_to_self_delay: 0,
 489                         our_to_self_delay: config.own_channel_config.our_to_self_delay,
 490                         their_max_accepted_htlcs: 0,
 491                         minimum_depth: 0, // Filled in in accept_channel
 492
 493                         their_funding_pubkey: None,
 494                         their_revocation_basepoint: None,
 495                         their_payment_basepoint: None,
 496                         their_delayed_payment_basepoint: None,
 497                         their_htlc_basepoint: None,
 498                         their_cur_commitment_point: None,
 499
 500                         their_prev_commitment_point: None,
 501                         their_node_id: their_node_id,
 502
 503                         their_shutdown_scriptpubkey: None,
 504
 505                         channel_monitor: channel_monitor,
 506
 507                         logger,
 508                 })
 509         }
 510
 511         fn check_remote_fee(fee_estimator: &FeeEstimator, feerate_per_kw: u32) -> Result<(), ChannelError> {
 512                 if (feerate_per_kw as u64) < fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background) {
 513                         return Err(ChannelError::Close("Peer's feerate much too low"));
 514                 }
 515                 if (feerate_per_kw as u64) > fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::HighPriority) * 2 {
 516                         return Err(ChannelError::Close("Peer's feerate much too high"));
 517                 }
 518                 Ok(())
 519         }
 520
 521         /// Creates a new channel from a remote sides' request for one.
 522         /// Assumes chain_hash has already been checked and corresponds with what we expect!
 523         pub fn new_from_req(fee_estimator: &FeeEstimator, keys_provider: &Arc<KeysInterface>, their_node_id: PublicKey, their_local_features: LocalFeatures, msg: &msgs::OpenChannel, user_id: u64, logger: Arc<Logger>, config: &UserConfig) -> Result<Channel, ChannelError> {
 524                 let chan_keys = keys_provider.get_channel_keys(true);
 525                 let mut local_config = (*config).channel_options.clone();
 526
 527                 if config.own_channel_config.our_to_self_delay < BREAKDOWN_TIMEOUT {
 528                         return Err(ChannelError::Close("Configured with an unreasonable our_to_self_delay putting user funds at risks"));
 529                 }
 530
 531                 // Check sanity of message fields:
 532                 if msg.funding_satoshis >= MAX_FUNDING_SATOSHIS {
 533                         return Err(ChannelError::Close("funding value > 2^24"));
 534                 }
 535                 if msg.channel_reserve_satoshis > msg.funding_satoshis {
 536                         return Err(ChannelError::Close("Bogus channel_reserve_satoshis"));
 537                 }
 538                 if msg.push_msat > (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
 539                         return Err(ChannelError::Close("push_msat larger than funding value"));
 540                 }
 541                 if msg.dust_limit_satoshis > msg.funding_satoshis {
 542                         return Err(ChannelError::Close("Peer never wants payout outputs?"));
 543                 }
 544                 if msg.dust_limit_satoshis > msg.channel_reserve_satoshis {
 545                         return Err(ChannelError::Close("Bogus; channel reserve is less than dust limit"));
 546                 }
 547                 if msg.htlc_minimum_msat >= (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
 548                         return Err(ChannelError::Close("Minimum htlc value is full channel value"));
 549                 }
 550                 Channel::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
 551
 552                 if msg.to_self_delay > config.peer_channel_config_limits.their_to_self_delay || msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
 553                         return Err(ChannelError::Close("They wanted our payments to be delayed by a needlessly long period"));
 554                 }
 555                 if msg.max_accepted_htlcs < 1 {
 556                         return Err(ChannelError::Close("0 max_accpted_htlcs makes for a useless channel"));
 557                 }
 558                 if msg.max_accepted_htlcs > 483 {
 559                         return Err(ChannelError::Close("max_accpted_htlcs > 483"));
 560                 }
 561
 562                 // Now check against optional parameters as set by config...
 563                 if msg.funding_satoshis < config.peer_channel_config_limits.min_funding_satoshis {
 564                         return Err(ChannelError::Close("funding satoshis is less than the user specified limit"));
 565                 }
 566                 if msg.htlc_minimum_msat > config.peer_channel_config_limits.max_htlc_minimum_msat {
 567                         return Err(ChannelError::Close("htlc minimum msat is higher than the user specified limit"));
 568                 }
 569                 if msg.max_htlc_value_in_flight_msat < config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat {
 570                         return Err(ChannelError::Close("max htlc value in flight msat is less than the user specified limit"));
 571                 }
 572                 if msg.channel_reserve_satoshis > config.peer_channel_config_limits.max_channel_reserve_satoshis {
 573                         return Err(ChannelError::Close("channel reserve satoshis is higher than the user specified limit"));
 574                 }
 575                 if msg.max_accepted_htlcs < config.peer_channel_config_limits.min_max_accepted_htlcs {
 576                         return Err(ChannelError::Close("max accepted htlcs is less than the user specified limit"));
 577                 }
 578                 if msg.dust_limit_satoshis < config.peer_channel_config_limits.min_dust_limit_satoshis {
 579                         return Err(ChannelError::Close("dust limit satoshis is less than the user specified limit"));
 580                 }
 581                 if msg.dust_limit_satoshis > config.peer_channel_config_limits.max_dust_limit_satoshis {
 582                         return Err(ChannelError::Close("dust limit satoshis is greater than the user specified limit"));
 583                 }
 584
 585                 // Convert things into internal flags and prep our state:
 586
 587                 let their_announce = if (msg.channel_flags & 1) == 1 { true } else { false };
 588                 if config.peer_channel_config_limits.force_announced_channel_preference {
 589                         if local_config.announced_channel != their_announce {
 590                                 return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours"));
 591                         }
 592                 }
 593                 // we either accept their preference or the preferences match
 594                 local_config.announced_channel = their_announce;
 595
 596                 let background_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
 597
 598                 let our_dust_limit_satoshis = Channel::derive_our_dust_limit_satoshis(background_feerate);
 599                 let our_channel_reserve_satoshis = Channel::get_our_channel_reserve_satoshis(msg.funding_satoshis);
 600                 if our_channel_reserve_satoshis < our_dust_limit_satoshis {
 601                         return Err(ChannelError::Close("Suitable channel reserve not found. aborting"));
 602                 }
 603                 if msg.channel_reserve_satoshis < our_dust_limit_satoshis {
 604                         return Err(ChannelError::Close("channel_reserve_satoshis too small"));
 605                 }
 606                 if our_channel_reserve_satoshis < msg.dust_limit_satoshis {
 607                         return Err(ChannelError::Close("Dust limit too high for our channel reserve"));
 608                 }
 609
 610                 // check if the funder's amount for the initial commitment tx is sufficient
 611                 // for full fee payment
 612                 let funders_amount_msat = msg.funding_satoshis * 1000 - msg.push_msat;
 613                 if funders_amount_msat < background_feerate * COMMITMENT_TX_BASE_WEIGHT {
 614                         return Err(ChannelError::Close("Insufficient funding amount for initial commitment"));
 615                 }
 616
 617                 let to_local_msat = msg.push_msat;
 618                 let to_remote_msat = funders_amount_msat - background_feerate * COMMITMENT_TX_BASE_WEIGHT;
 619                 if to_local_msat <= msg.channel_reserve_satoshis * 1000 && to_remote_msat <= our_channel_reserve_satoshis * 1000 {
 620                         return Err(ChannelError::Close("Insufficient funding amount for initial commitment"));
 621                 }
 622
 623                 let secp_ctx = Secp256k1::new();
 624                 let mut channel_monitor = ChannelMonitor::new(&chan_keys.revocation_base_key, &chan_keys.delayed_payment_base_key,
 625                                                               &chan_keys.htlc_base_key, &chan_keys.payment_base_key, &keys_provider.get_shutdown_pubkey(), config.own_channel_config.our_to_self_delay,
 626                                                               keys_provider.get_destination_script(), logger.clone());
 627                 channel_monitor.set_their_base_keys(&msg.htlc_basepoint, &msg.delayed_payment_basepoint);
 628                 channel_monitor.set_their_to_self_delay(msg.to_self_delay);
 629
 630                 let their_shutdown_scriptpubkey = if their_local_features.supports_upfront_shutdown_script() {
 631                         match &msg.shutdown_scriptpubkey {
 632                                 &OptionalField::Present(ref script) => {
 633                                         // Peer is signaling upfront_shutdown and has provided a non-accepted scriptpubkey format. We enforce it while receiving shutdown msg
 634                                         if script.is_p2pkh() || script.is_p2sh() || script.is_v0_p2wsh() || script.is_v0_p2wpkh() {
 635                                                 Some(script.clone())
 636                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
 637                                         } else if script.len() == 0 {
 638                                                 None
 639                                         // Peer is signaling upfront_shutdown and has provided a non-accepted scriptpubkey format. Fail the channel
 640                                         } else {
 641                                                 return Err(ChannelError::Close("Peer is signaling upfront_shutdown but has provided a non-accepted scriptpubkey format"));
 642                                         }
 643                                 },
 644                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
 645                                 &OptionalField::Absent => {
 646                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out"));
 647                                 }
 648                         }
 649                 } else { None };
 650
 651                 let mut chan = Channel {
 652                         user_id: user_id,
 653                         config: local_config,
 654
 655                         channel_id: msg.temporary_channel_id,
 656                         channel_state: (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32),
 657                         channel_outbound: false,
 658                         secp_ctx: secp_ctx,
 659
 660                         local_keys: chan_keys,
 661                         shutdown_pubkey: keys_provider.get_shutdown_pubkey(),
 662                         cur_local_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
 663                         cur_remote_commitment_transaction_number: INITIAL_COMMITMENT_NUMBER,
 664                         value_to_self_msat: msg.push_msat,
 665
 666                         pending_inbound_htlcs: Vec::new(),
 667                         pending_outbound_htlcs: Vec::new(),
 668                         holding_cell_htlc_updates: Vec::new(),
 669                         pending_update_fee: None,
 670                         holding_cell_update_fee: None,
 671                         next_local_htlc_id: 0,
 672                         next_remote_htlc_id: 0,
 673                         channel_update_count: 1,
 674
 675                         resend_order: RAACommitmentOrder::CommitmentFirst,
 676
 677                         monitor_pending_funding_locked: false,
 678                         monitor_pending_revoke_and_ack: false,
 679                         monitor_pending_commitment_signed: false,
 680                         monitor_pending_forwards: Vec::new(),
 681                         monitor_pending_failures: Vec::new(),
 682
 683                         #[cfg(debug_assertions)]
 684                         max_commitment_tx_output_local: ::std::sync::Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
 685                         #[cfg(debug_assertions)]
 686                         max_commitment_tx_output_remote: ::std::sync::Mutex::new((msg.push_msat, msg.funding_satoshis * 1000 - msg.push_msat)),
 687
 688                         last_local_commitment_txn: Vec::new(),
 689
 690                         last_sent_closing_fee: None,
 691
 692                         funding_tx_confirmed_in: None,
 693                         short_channel_id: None,
 694                         last_block_connected: Default::default(),
 695                         funding_tx_confirmations: 0,
 696
 697                         feerate_per_kw: msg.feerate_per_kw as u64,
 698                         channel_value_satoshis: msg.funding_satoshis,
 699                         their_dust_limit_satoshis: msg.dust_limit_satoshis,
 700                         our_dust_limit_satoshis: our_dust_limit_satoshis,
 701                         their_max_htlc_value_in_flight_msat: cmp::min(msg.max_htlc_value_in_flight_msat, msg.funding_satoshis * 1000),
 702                         their_channel_reserve_satoshis: msg.channel_reserve_satoshis,
 703                         their_htlc_minimum_msat: msg.htlc_minimum_msat,
 704                         our_htlc_minimum_msat: Channel::derive_our_htlc_minimum_msat(msg.feerate_per_kw as u64),
 705                         their_to_self_delay: msg.to_self_delay,
 706                         our_to_self_delay: config.own_channel_config.our_to_self_delay,
 707                         their_max_accepted_htlcs: msg.max_accepted_htlcs,
 708                         minimum_depth: config.own_channel_config.minimum_depth,
 709
 710                         their_funding_pubkey: Some(msg.funding_pubkey),
 711                         their_revocation_basepoint: Some(msg.revocation_basepoint),
 712                         their_payment_basepoint: Some(msg.payment_basepoint),
 713                         their_delayed_payment_basepoint: Some(msg.delayed_payment_basepoint),
 714                         their_htlc_basepoint: Some(msg.htlc_basepoint),
 715                         their_cur_commitment_point: Some(msg.first_per_commitment_point),
 716
 717                         their_prev_commitment_point: None,
 718                         their_node_id: their_node_id,
 719
 720                         their_shutdown_scriptpubkey,
 721
 722                         channel_monitor: channel_monitor,
 723
 724                         logger,
 725                 };
 726
 727                 let obscure_factor = chan.get_commitment_transaction_number_obscure_factor();
 728                 chan.channel_monitor.set_commitment_obscure_factor(obscure_factor);
 729
 730                 Ok(chan)
 731         }
 732
 733         // Utilities to derive keys:
 734
 735         fn build_local_commitment_secret(&self, idx: u64) -> SecretKey {
 736                 let res = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, idx);
 737                 SecretKey::from_slice(&res).unwrap()
 738         }
 739
 740         // Utilities to build transactions:
 741
 742         fn get_commitment_transaction_number_obscure_factor(&self) -> u64 {
 743                 let mut sha = Sha256::engine();
 744                 let our_payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key);
 745
 746                 if self.channel_outbound {
 747                         sha.input(&our_payment_basepoint.serialize());
 748                         sha.input(&self.their_payment_basepoint.unwrap().serialize());
 749                 } else {
 750                         sha.input(&self.their_payment_basepoint.unwrap().serialize());
 751                         sha.input(&our_payment_basepoint.serialize());
 752                 }
 753                 let res = Sha256::from_engine(sha).into_inner();
 754
 755                 ((res[26] as u64) << 5*8) |
 756                 ((res[27] as u64) << 4*8) |
 757                 ((res[28] as u64) << 3*8) |
 758                 ((res[29] as u64) << 2*8) |
 759                 ((res[30] as u64) << 1*8) |
 760                 ((res[31] as u64) << 0*8)
 761         }
 762
 763         /// Transaction nomenclature is somewhat confusing here as there are many different cases - a
 764         /// transaction is referred to as "a's transaction" implying that a will be able to broadcast
 765         /// the transaction. Thus, b will generally be sending a signature over such a transaction to
 766         /// a, and a can revoke the transaction by providing b the relevant per_commitment_secret. As
 767         /// such, a transaction is generally the result of b increasing the amount paid to a (or adding
 768         /// an HTLC to a).
 769         /// @local is used only to convert relevant internal structures which refer to remote vs local
 770         /// to decide value of outputs and direction of HTLCs.
 771         /// @generated_by_local is used to determine *which* HTLCs to include - noting that the HTLC
 772         /// state may indicate that one peer has informed the other that they'd like to add an HTLC but
 773         /// have not yet committed it. Such HTLCs will only be included in transactions which are being
 774         /// generated by the peer which proposed adding the HTLCs, and thus we need to understand both
 775         /// which peer generated this transaction and "to whom" this transaction flows.
 776         /// Returns (the transaction built, the number of HTLC outputs which were present in the
 777         /// transaction, the list of HTLCs which were not ignored when building the transaction).
 778         /// Note that below-dust HTLCs are included in the third return value, but not the second, and
 779         /// sources are provided only for outbound HTLCs in the third return value.
 780         #[inline]
 781         fn build_commitment_transaction(&self, commitment_number: u64, keys: &TxCreationKeys, local: bool, generated_by_local: bool, feerate_per_kw: u64) -> (Transaction, usize, Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)>) {
 782                 let obscured_commitment_transaction_number = self.get_commitment_transaction_number_obscure_factor() ^ (INITIAL_COMMITMENT_NUMBER - commitment_number);
 783
 784                 let txins = {
 785                         let mut ins: Vec<TxIn> = Vec::new();
 786                         ins.push(TxIn {
 787                                 previous_output: self.channel_monitor.get_funding_txo().unwrap().into_bitcoin_outpoint(),
 788                                 script_sig: Script::new(),
 789                                 sequence: ((0x80 as u32) << 8*3) | ((obscured_commitment_transaction_number >> 3*8) as u32),
 790                                 witness: Vec::new(),
 791                         });
 792                         ins
 793                 };
 794
 795                 let mut txouts: Vec<(TxOut, Option<(HTLCOutputInCommitment, Option<&HTLCSource>)>)> = Vec::with_capacity(self.pending_inbound_htlcs.len() + self.pending_outbound_htlcs.len() + 2);
 796                 let mut included_dust_htlcs: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::new();
 797
 798                 let dust_limit_satoshis = if local { self.our_dust_limit_satoshis } else { self.their_dust_limit_satoshis };
 799                 let mut remote_htlc_total_msat = 0;
 800                 let mut local_htlc_total_msat = 0;
 801                 let mut value_to_self_msat_offset = 0;
 802
 803                 log_trace!(self, "Building commitment transaction number {} for {}, generated by {} with fee {}...", commitment_number, if local { "us" } else { "remote" }, if generated_by_local { "us" } else { "remote" }, feerate_per_kw);
 804
 805                 macro_rules! get_htlc_in_commitment {
 806                         ($htlc: expr, $offered: expr) => {
 807                                 HTLCOutputInCommitment {
 808                                         offered: $offered,
 809                                         amount_msat: $htlc.amount_msat,
 810                                         cltv_expiry: $htlc.cltv_expiry,
 811                                         payment_hash: $htlc.payment_hash,
 812                                         transaction_output_index: None
 813                                 }
 814                         }
 815                 }
 816
 817                 macro_rules! add_htlc_output {
 818                         ($htlc: expr, $outbound: expr, $source: expr, $state_name: expr) => {
 819                                 if $outbound == local { // "offered HTLC output"
 820                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, true);
 821                                         if $htlc.amount_msat / 1000 >= dust_limit_satoshis + (feerate_per_kw * HTLC_TIMEOUT_TX_WEIGHT / 1000) {
 822                                                 log_trace!(self, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
 823                                                 txouts.push((TxOut {
 824                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys).to_v0_p2wsh(),
 825                                                         value: $htlc.amount_msat / 1000
 826                                                 }, Some((htlc_in_tx, $source))));
 827                                         } else {
 828                                                 log_trace!(self, "   ...including {} {} dust HTLC {} (hash {}) with value {} due to dust limit", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
 829                                                 included_dust_htlcs.push((htlc_in_tx, $source));
 830                                         }
 831                                 } else {
 832                                         let htlc_in_tx = get_htlc_in_commitment!($htlc, false);
 833                                         if $htlc.amount_msat / 1000 >= dust_limit_satoshis + (feerate_per_kw * HTLC_SUCCESS_TX_WEIGHT / 1000) {
 834                                                 log_trace!(self, "   ...including {} {} HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
 835                                                 txouts.push((TxOut { // "received HTLC output"
 836                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys).to_v0_p2wsh(),
 837                                                         value: $htlc.amount_msat / 1000
 838                                                 }, Some((htlc_in_tx, $source))));
 839                                         } else {
 840                                                 log_trace!(self, "   ...including {} {} dust HTLC {} (hash {}) with value {}", if $outbound { "outbound" } else { "inbound" }, $state_name, $htlc.htlc_id, log_bytes!($htlc.payment_hash.0), $htlc.amount_msat);
 841                                                 included_dust_htlcs.push((htlc_in_tx, $source));
 842                                         }
 843                                 }
 844                         }
 845                 }
 846
 847                 for ref htlc in self.pending_inbound_htlcs.iter() {
 848                         let (include, state_name) = match htlc.state {
 849                                 InboundHTLCState::RemoteAnnounced(_) => (!generated_by_local, "RemoteAnnounced"),
 850                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) => (!generated_by_local, "AwaitingRemoteRevokeToAnnounce"),
 851                                 InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => (true, "AwaitingAnnouncedRemoteRevoke"),
 852                                 InboundHTLCState::Committed => (true, "Committed"),
 853                                 InboundHTLCState::LocalRemoved(_) => (!generated_by_local, "LocalRemoved"),
 854                         };
 855
 856                         if include {
 857                                 add_htlc_output!(htlc, false, None, state_name);
 858                                 remote_htlc_total_msat += htlc.amount_msat;
 859                         } else {
 860                                 log_trace!(self, "   ...not including inbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
 861                                 match &htlc.state {
 862                                         &InboundHTLCState::LocalRemoved(ref reason) => {
 863                                                 if generated_by_local {
 864                                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
 865                                                                 value_to_self_msat_offset += htlc.amount_msat as i64;
 866                                                         }
 867                                                 }
 868                                         },
 869                                         _ => {},
 870                                 }
 871                         }
 872                 }
 873
 874                 for ref htlc in self.pending_outbound_htlcs.iter() {
 875                         let (include, state_name) = match htlc.state {
 876                                 OutboundHTLCState::LocalAnnounced(_) => (generated_by_local, "LocalAnnounced"),
 877                                 OutboundHTLCState::Committed => (true, "Committed"),
 878                                 OutboundHTLCState::RemoteRemoved(_) => (generated_by_local, "RemoteRemoved"),
 879                                 OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) => (generated_by_local, "AwaitingRemoteRevokeToRemove"),
 880                                 OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) => (false, "AwaitingRemovedRemoteRevoke"),
 881                         };
 882
 883                         if include {
 884                                 add_htlc_output!(htlc, true, Some(&htlc.source), state_name);
 885                                 local_htlc_total_msat += htlc.amount_msat;
 886                         } else {
 887                                 log_trace!(self, "   ...not including outbound HTLC {} (hash {}) with value {} due to state ({})", htlc.htlc_id, log_bytes!(htlc.payment_hash.0), htlc.amount_msat, state_name);
 888                                 match htlc.state {
 889                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(None)|OutboundHTLCState::AwaitingRemovedRemoteRevoke(None) => {
 890                                                 value_to_self_msat_offset -= htlc.amount_msat as i64;
 891                                         },
 892                                         OutboundHTLCState::RemoteRemoved(None) => {
 893                                                 if !generated_by_local {
 894                                                         value_to_self_msat_offset -= htlc.amount_msat as i64;
 895                                                 }
 896                                         },
 897                                         _ => {},
 898                                 }
 899                         }
 900                 }
 901
 902                 let value_to_self_msat: i64 = (self.value_to_self_msat - local_htlc_total_msat) as i64 + value_to_self_msat_offset;
 903                 assert!(value_to_self_msat >= 0);
 904                 // Note that in case they have several just-awaiting-last-RAA fulfills in-progress (ie
 905                 // AwaitingRemoteRevokeToRemove or AwaitingRemovedRemoteRevoke) we may have allowed them to
 906                 // "violate" their reserve value by couting those against it. Thus, we have to convert
 907                 // everything to i64 before subtracting as otherwise we can overflow.
 908                 let value_to_remote_msat: i64 = (self.channel_value_satoshis * 1000) as i64 - (self.value_to_self_msat as i64) - (remote_htlc_total_msat as i64) - value_to_self_msat_offset;
 909                 assert!(value_to_remote_msat >= 0);
 910
 911                 #[cfg(debug_assertions)]
 912                 {
 913                         // Make sure that the to_self/to_remote is always either past the appropriate
 914                         // channel_reserve *or* it is making progress towards it.
 915                         // TODO: This should happen after fee calculation, but we don't handle that correctly
 916                         // yet!
 917                         let mut max_commitment_tx_output = if generated_by_local {
 918                                 self.max_commitment_tx_output_local.lock().unwrap()
 919                         } else {
 920                                 self.max_commitment_tx_output_remote.lock().unwrap()
 921                         };
 922                         debug_assert!(max_commitment_tx_output.0 <= value_to_self_msat as u64 || value_to_self_msat / 1000 >= self.their_channel_reserve_satoshis as i64);
 923                         max_commitment_tx_output.0 = cmp::max(max_commitment_tx_output.0, value_to_self_msat as u64);
 924                         debug_assert!(max_commitment_tx_output.1 <= value_to_remote_msat as u64 || value_to_remote_msat / 1000 >= Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis) as i64);
 925                         max_commitment_tx_output.1 = cmp::max(max_commitment_tx_output.1, value_to_remote_msat as u64);
 926                 }
 927
 928                 let total_fee: u64 = feerate_per_kw * (COMMITMENT_TX_BASE_WEIGHT + (txouts.len() as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
 929                 let (value_to_self, value_to_remote) = if self.channel_outbound {
 930                         (value_to_self_msat / 1000 - total_fee as i64, value_to_remote_msat / 1000)
 931                 } else {
 932                         (value_to_self_msat / 1000, value_to_remote_msat / 1000 - total_fee as i64)
 933                 };
 934
 935                 let value_to_a = if local { value_to_self } else { value_to_remote };
 936                 let value_to_b = if local { value_to_remote } else { value_to_self };
 937
 938                 if value_to_a >= (dust_limit_satoshis as i64) {
 939                         log_trace!(self, "   ...including {} output with value {}", if local { "to_local" } else { "to_remote" }, value_to_a);
 940                         txouts.push((TxOut {
 941                                 script_pubkey: chan_utils::get_revokeable_redeemscript(&keys.revocation_key,
 942                                                                                        if local { self.their_to_self_delay } else { self.our_to_self_delay },
 943                                                                                        &keys.a_delayed_payment_key).to_v0_p2wsh(),
 944                                 value: value_to_a as u64
 945                         }, None));
 946                 }
 947
 948                 if value_to_b >= (dust_limit_satoshis as i64) {
 949                         log_trace!(self, "   ...including {} output with value {}", if local { "to_remote" } else { "to_local" }, value_to_b);
 950                         txouts.push((TxOut {
 951                                 script_pubkey: Builder::new().push_opcode(opcodes::all::OP_PUSHBYTES_0)
 952                                                              .push_slice(&Hash160::hash(&keys.b_payment_key.serialize())[..])
 953                                                              .into_script(),
 954                                 value: value_to_b as u64
 955                         }, None));
 956                 }
 957
 958                 transaction_utils::sort_outputs(&mut txouts, |a, b| {
 959                         if let &Some(ref a_htlc) = a {
 960                                 if let &Some(ref b_htlc) = b {
 961                                         a_htlc.0.cltv_expiry.cmp(&b_htlc.0.cltv_expiry)
 962                                                 // Note that due to hash collisions, we have to have a fallback comparison
 963                                                 // here for fuzztarget mode (otherwise at least chanmon_fail_consistency
 964                                                 // may fail)!
 965                                                 .then(a_htlc.0.payment_hash.0.cmp(&b_htlc.0.payment_hash.0))
 966                                 // For non-HTLC outputs, if they're copying our SPK we don't really care if we
 967                                 // close the channel due to mismatches - they're doing something dumb:
 968                                 } else { cmp::Ordering::Equal }
 969                         } else { cmp::Ordering::Equal }
 970                 });
 971
 972                 let mut outputs: Vec<TxOut> = Vec::with_capacity(txouts.len());
 973                 let mut htlcs_included: Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)> = Vec::with_capacity(txouts.len() + included_dust_htlcs.len());
 974                 for (idx, mut out) in txouts.drain(..).enumerate() {
 975                         outputs.push(out.0);
 976                         if let Some((mut htlc, source_option)) = out.1.take() {
 977                                 htlc.transaction_output_index = Some(idx as u32);
 978                                 htlcs_included.push((htlc, source_option));
 979                         }
 980                 }
 981                 let non_dust_htlc_count = htlcs_included.len();
 982                 htlcs_included.append(&mut included_dust_htlcs);
 983
 984                 (Transaction {
 985                         version: 2,
 986                         lock_time: ((0x20 as u32) << 8*3) | ((obscured_commitment_transaction_number & 0xffffffu64) as u32),
 987                         input: txins,
 988                         output: outputs,
 989                 }, non_dust_htlc_count, htlcs_included)
 990         }
 991
 992         #[inline]
 993         fn get_closing_scriptpubkey(&self) -> Script {
 994                 let our_channel_close_key_hash = Hash160::hash(&self.shutdown_pubkey.serialize());
 995                 Builder::new().push_opcode(opcodes::all::OP_PUSHBYTES_0).push_slice(&our_channel_close_key_hash[..]).into_script()
 996         }
 997
 998         #[inline]
 999         fn get_closing_transaction_weight(a_scriptpubkey: &Script, b_scriptpubkey: &Script) -> u64 {
1000                 (4 + 1 + 36 + 4 + 1 + 1 + 2*(8+1) + 4 + a_scriptpubkey.len() as u64 + b_scriptpubkey.len() as u64)*4 + 2 + 1 + 1 + 2*(1 + 72)
1001         }
1002
1003         #[inline]
1004         fn build_closing_transaction(&self, proposed_total_fee_satoshis: u64, skip_remote_output: bool) -> (Transaction, u64) {
1005                 let txins = {
1006                         let mut ins: Vec<TxIn> = Vec::new();
1007                         ins.push(TxIn {
1008                                 previous_output: self.channel_monitor.get_funding_txo().unwrap().into_bitcoin_outpoint(),
1009                                 script_sig: Script::new(),
1010                                 sequence: 0xffffffff,
1011                                 witness: Vec::new(),
1012                         });
1013                         ins
1014                 };
1015
1016                 assert!(self.pending_inbound_htlcs.is_empty());
1017                 assert!(self.pending_outbound_htlcs.is_empty());
1018                 let mut txouts: Vec<(TxOut, ())> = Vec::new();
1019
1020                 let mut total_fee_satoshis = proposed_total_fee_satoshis;
1021                 let value_to_self: i64 = (self.value_to_self_msat as i64) / 1000 - if self.channel_outbound { total_fee_satoshis as i64 } else { 0 };
1022                 let value_to_remote: i64 = ((self.channel_value_satoshis * 1000 - self.value_to_self_msat) as i64 / 1000) - if self.channel_outbound { 0 } else { total_fee_satoshis as i64 };
1023
1024                 if value_to_self < 0 {
1025                         assert!(self.channel_outbound);
1026                         total_fee_satoshis += (-value_to_self) as u64;
1027                 } else if value_to_remote < 0 {
1028                         assert!(!self.channel_outbound);
1029                         total_fee_satoshis += (-value_to_remote) as u64;
1030                 }
1031
1032                 if !skip_remote_output && value_to_remote as u64 > self.our_dust_limit_satoshis {
1033                         txouts.push((TxOut {
1034                                 script_pubkey: self.their_shutdown_scriptpubkey.clone().unwrap(),
1035                                 value: value_to_remote as u64
1036                         }, ()));
1037                 }
1038
1039                 if value_to_self as u64 > self.our_dust_limit_satoshis {
1040                         txouts.push((TxOut {
1041                                 script_pubkey: self.get_closing_scriptpubkey(),
1042                                 value: value_to_self as u64
1043                         }, ()));
1044                 }
1045
1046                 transaction_utils::sort_outputs(&mut txouts, |_, _| { cmp::Ordering::Equal }); // Ordering doesnt matter if they used our pubkey...
1047
1048                 let mut outputs: Vec<TxOut> = Vec::new();
1049                 for out in txouts.drain(..) {
1050                         outputs.push(out.0);
1051                 }
1052
1053                 (Transaction {
1054                         version: 2,
1055                         lock_time: 0,
1056                         input: txins,
1057                         output: outputs,
1058                 }, total_fee_satoshis)
1059         }
1060
1061         #[inline]
1062         /// Creates a set of keys for build_commitment_transaction to generate a transaction which our
1063         /// counterparty will sign (ie DO NOT send signatures over a transaction created by this to
1064         /// our counterparty!)
1065         /// The result is a transaction which we can revoke ownership of (ie a "local" transaction)
1066         /// TODO Some magic rust shit to compile-time check this?
1067         fn build_local_transaction_keys(&self, commitment_number: u64) -> Result<TxCreationKeys, ChannelError> {
1068                 let per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(commitment_number));
1069                 let delayed_payment_base = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key);
1070                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key);
1071
1072                 Ok(secp_check!(TxCreationKeys::new(&self.secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &self.their_revocation_basepoint.unwrap(), &self.their_payment_basepoint.unwrap(), &self.their_htlc_basepoint.unwrap()), "Local tx keys generation got bogus keys"))
1073         }
1074
1075         #[inline]
1076         /// Creates a set of keys for build_commitment_transaction to generate a transaction which we
1077         /// will sign and send to our counterparty.
1078         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
1079         fn build_remote_transaction_keys(&self) -> Result<TxCreationKeys, ChannelError> {
1080                 //TODO: Ensure that the payment_key derived here ends up in the library users' wallet as we
1081                 //may see payments to it!
1082                 let payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key);
1083                 let revocation_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key);
1084                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key);
1085
1086                 Ok(secp_check!(TxCreationKeys::new(&self.secp_ctx, &self.their_cur_commitment_point.unwrap(), &self.their_delayed_payment_basepoint.unwrap(), &self.their_htlc_basepoint.unwrap(), &revocation_basepoint, &payment_basepoint, &htlc_basepoint), "Remote tx keys generation got bogus keys"))
1087         }
1088
1089         /// Gets the redeemscript for the funding transaction output (ie the funding transaction output
1090         /// pays to get_funding_redeemscript().to_v0_p2wsh()).
1091         /// Panics if called before accept_channel/new_from_req
1092         pub fn get_funding_redeemscript(&self) -> Script {
1093                 let builder = Builder::new().push_opcode(opcodes::all::OP_PUSHNUM_2);
1094                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).serialize();
1095                 let their_funding_key = self.their_funding_pubkey.expect("get_funding_redeemscript only allowed after accept_channel").serialize();
1096                 if our_funding_key[..] < their_funding_key[..] {
1097                         builder.push_slice(&our_funding_key)
1098                                 .push_slice(&their_funding_key)
1099                 } else {
1100                         builder.push_slice(&their_funding_key)
1101                                 .push_slice(&our_funding_key)
1102                 }.push_opcode(opcodes::all::OP_PUSHNUM_2).push_opcode(opcodes::all::OP_CHECKMULTISIG).into_script()
1103         }
1104
1105         fn sign_commitment_transaction(&self, tx: &mut Transaction, their_sig: &Signature) -> Signature {
1106                 if tx.input.len() != 1 {
1107                         panic!("Tried to sign commitment transaction that had input count != 1!");
1108                 }
1109                 if tx.input[0].witness.len() != 0 {
1110                         panic!("Tried to re-sign commitment transaction");
1111                 }
1112
1113                 let funding_redeemscript = self.get_funding_redeemscript();
1114
1115                 let sighash = hash_to_message!(&bip143::SighashComponents::new(&tx).sighash_all(&tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]);
1116                 let our_sig = self.secp_ctx.sign(&sighash, &self.local_keys.funding_key);
1117
1118                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
1119
1120                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).serialize();
1121                 let their_funding_key = self.their_funding_pubkey.unwrap().serialize();
1122                 if our_funding_key[..] < their_funding_key[..] {
1123                         tx.input[0].witness.push(our_sig.serialize_der().to_vec());
1124                         tx.input[0].witness.push(their_sig.serialize_der().to_vec());
1125                 } else {
1126                         tx.input[0].witness.push(their_sig.serialize_der().to_vec());
1127                         tx.input[0].witness.push(our_sig.serialize_der().to_vec());
1128                 }
1129                 tx.input[0].witness[1].push(SigHashType::All as u8);
1130                 tx.input[0].witness[2].push(SigHashType::All as u8);
1131
1132                 tx.input[0].witness.push(funding_redeemscript.into_bytes());
1133
1134                 our_sig
1135         }
1136
1137         /// Builds the htlc-success or htlc-timeout transaction which spends a given HTLC output
1138         /// @local is used only to convert relevant internal structures which refer to remote vs local
1139         /// to decide value of outputs and direction of HTLCs.
1140         fn build_htlc_transaction(&self, prev_hash: &Sha256dHash, htlc: &HTLCOutputInCommitment, local: bool, keys: &TxCreationKeys, feerate_per_kw: u64) -> Transaction {
1141                 chan_utils::build_htlc_transaction(prev_hash, feerate_per_kw, if local { self.their_to_self_delay } else { self.our_to_self_delay }, htlc, &keys.a_delayed_payment_key, &keys.revocation_key)
1142         }
1143
1144         fn create_htlc_tx_signature(&self, tx: &Transaction, htlc: &HTLCOutputInCommitment, keys: &TxCreationKeys) -> Result<(Script, Signature, bool), ChannelError> {
1145                 if tx.input.len() != 1 {
1146                         panic!("Tried to sign HTLC transaction that had input count != 1!");
1147                 }
1148
1149                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys);
1150
1151                 let our_htlc_key = secp_check!(chan_utils::derive_private_key(&self.secp_ctx, &keys.per_commitment_point, &self.local_keys.htlc_base_key), "Derived invalid key, peer is maliciously selecting parameters");
1152                 let sighash = hash_to_message!(&bip143::SighashComponents::new(&tx).sighash_all(&tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]);
1153                 let is_local_tx = PublicKey::from_secret_key(&self.secp_ctx, &our_htlc_key) == keys.a_htlc_key;
1154                 Ok((htlc_redeemscript, self.secp_ctx.sign(&sighash, &our_htlc_key), is_local_tx))
1155         }
1156
1157         /// Signs a transaction created by build_htlc_transaction. If the transaction is an
1158         /// HTLC-Success transaction (ie htlc.offered is false), preimage must be set!
1159         fn sign_htlc_transaction(&self, tx: &mut Transaction, their_sig: &Signature, preimage: &Option<PaymentPreimage>, htlc: &HTLCOutputInCommitment, keys: &TxCreationKeys) -> Result<Signature, ChannelError> {
1160                 if tx.input.len() != 1 {
1161                         panic!("Tried to sign HTLC transaction that had input count != 1!");
1162                 }
1163                 if tx.input[0].witness.len() != 0 {
1164                         panic!("Tried to re-sign HTLC transaction");
1165                 }
1166
1167                 let (htlc_redeemscript, our_sig, local_tx) = self.create_htlc_tx_signature(tx, htlc, keys)?;
1168
1169                 tx.input[0].witness.push(Vec::new()); // First is the multisig dummy
1170
1171                 if local_tx { // b, then a
1172                         tx.input[0].witness.push(their_sig.serialize_der().to_vec());
1173                         tx.input[0].witness.push(our_sig.serialize_der().to_vec());
1174                 } else {
1175                         tx.input[0].witness.push(our_sig.serialize_der().to_vec());
1176                         tx.input[0].witness.push(their_sig.serialize_der().to_vec());
1177                 }
1178                 tx.input[0].witness[1].push(SigHashType::All as u8);
1179                 tx.input[0].witness[2].push(SigHashType::All as u8);
1180
1181                 if htlc.offered {
1182                         tx.input[0].witness.push(Vec::new());
1183                 } else {
1184                         tx.input[0].witness.push(preimage.unwrap().0.to_vec());
1185                 }
1186
1187                 tx.input[0].witness.push(htlc_redeemscript.into_bytes());
1188
1189                 Ok(our_sig)
1190         }
1191
1192         /// Per HTLC, only one get_update_fail_htlc or get_update_fulfill_htlc call may be made.
1193         /// In such cases we debug_assert!(false) and return an IgnoreError. Thus, will always return
1194         /// Ok(_) if debug assertions are turned on and preconditions are met.
1195         fn get_update_fulfill_htlc(&mut self, htlc_id_arg: u64, payment_preimage_arg: PaymentPreimage) -> Result<(Option<msgs::UpdateFulfillHTLC>, Option<ChannelMonitor>), ChannelError> {
1196                 // Either ChannelFunded got set (which means it won't be unset) or there is no way any
1197                 // caller thought we could have something claimed (cause we wouldn't have accepted in an
1198                 // incoming HTLC anyway). If we got to ShutdownComplete, callers aren't allowed to call us,
1199                 // either.
1200                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1201                         panic!("Was asked to fulfill an HTLC when channel was not in an operational state");
1202                 }
1203                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1204
1205                 let payment_hash_calc = PaymentHash(Sha256::hash(&payment_preimage_arg.0[..]).into_inner());
1206
1207                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1208                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1209                 // these, but for now we just have to treat them as normal.
1210
1211                 let mut pending_idx = std::usize::MAX;
1212                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1213                         if htlc.htlc_id == htlc_id_arg {
1214                                 assert_eq!(htlc.payment_hash, payment_hash_calc);
1215                                 match htlc.state {
1216                                         InboundHTLCState::Committed => {},
1217                                         InboundHTLCState::LocalRemoved(ref reason) => {
1218                                                 if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
1219                                                 } else {
1220                                                         log_warn!(self, "Have preimage and want to fulfill HTLC with payment hash {} we already failed against channel {}", log_bytes!(htlc.payment_hash.0), log_bytes!(self.channel_id()));
1221                                                 }
1222                                                 return Ok((None, None));
1223                                         },
1224                                         _ => {
1225                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1226                                                 // Don't return in release mode here so that we can update channel_monitor
1227                                         }
1228                                 }
1229                                 pending_idx = idx;
1230                                 break;
1231                         }
1232                 }
1233                 if pending_idx == std::usize::MAX {
1234                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1235                 }
1236
1237                 // Now update local state:
1238                 //
1239                 // We have to put the payment_preimage in the channel_monitor right away here to ensure we
1240                 // can claim it even if the channel hits the chain before we see their next commitment.
1241                 self.channel_monitor.provide_payment_preimage(&payment_hash_calc, &payment_preimage_arg);
1242
1243                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1244                         for pending_update in self.holding_cell_htlc_updates.iter() {
1245                                 match pending_update {
1246                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1247                                                 if htlc_id_arg == htlc_id {
1248                                                         return Ok((None, None));
1249                                                 }
1250                                         },
1251                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1252                                                 if htlc_id_arg == htlc_id {
1253                                                         log_warn!(self, "Have preimage and want to fulfill HTLC with pending failure against channel {}", log_bytes!(self.channel_id()));
1254                                                         // TODO: We may actually be able to switch to a fulfill here, though its
1255                                                         // rare enough it may not be worth the complexity burden.
1256                                                         return Ok((None, Some(self.channel_monitor.clone())));
1257                                                 }
1258                                         },
1259                                         _ => {}
1260                                 }
1261                         }
1262                         log_trace!(self, "Adding HTLC claim to holding_cell! Current state: {}", self.channel_state);
1263                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::ClaimHTLC {
1264                                 payment_preimage: payment_preimage_arg, htlc_id: htlc_id_arg,
1265                         });
1266                         return Ok((None, Some(self.channel_monitor.clone())));
1267                 }
1268
1269                 {
1270                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1271                         if let InboundHTLCState::Committed = htlc.state {
1272                         } else {
1273                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1274                                 return Ok((None, Some(self.channel_monitor.clone())));
1275                         }
1276                         log_trace!(self, "Upgrading HTLC {} to LocalRemoved with a Fulfill!", log_bytes!(htlc.payment_hash.0));
1277                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::Fulfill(payment_preimage_arg.clone()));
1278                 }
1279
1280                 Ok((Some(msgs::UpdateFulfillHTLC {
1281                         channel_id: self.channel_id(),
1282                         htlc_id: htlc_id_arg,
1283                         payment_preimage: payment_preimage_arg,
1284                 }), Some(self.channel_monitor.clone())))
1285         }
1286
1287         pub fn get_update_fulfill_htlc_and_commit(&mut self, htlc_id: u64, payment_preimage: PaymentPreimage) -> Result<(Option<(msgs::UpdateFulfillHTLC, msgs::CommitmentSigned)>, Option<ChannelMonitor>), ChannelError> {
1288                 match self.get_update_fulfill_htlc(htlc_id, payment_preimage)? {
1289                         (Some(update_fulfill_htlc), _) => {
1290                                 let (commitment, monitor_update) = self.send_commitment_no_status_check()?;
1291                                 Ok((Some((update_fulfill_htlc, commitment)), Some(monitor_update)))
1292                         },
1293                         (None, Some(channel_monitor)) => Ok((None, Some(channel_monitor))),
1294                         (None, None) => Ok((None, None))
1295                 }
1296         }
1297
1298         /// Per HTLC, only one get_update_fail_htlc or get_update_fulfill_htlc call may be made.
1299         /// In such cases we debug_assert!(false) and return an IgnoreError. Thus, will always return
1300         /// Ok(_) if debug assertions are turned on and preconditions are met.
1301         pub fn get_update_fail_htlc(&mut self, htlc_id_arg: u64, err_packet: msgs::OnionErrorPacket) -> Result<Option<msgs::UpdateFailHTLC>, ChannelError> {
1302                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1303                         panic!("Was asked to fail an HTLC when channel was not in an operational state");
1304                 }
1305                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
1306
1307                 // ChannelManager may generate duplicate claims/fails due to HTLC update events from
1308                 // on-chain ChannelsMonitors during block rescan. Ideally we'd figure out a way to drop
1309                 // these, but for now we just have to treat them as normal.
1310
1311                 let mut pending_idx = std::usize::MAX;
1312                 for (idx, htlc) in self.pending_inbound_htlcs.iter().enumerate() {
1313                         if htlc.htlc_id == htlc_id_arg {
1314                                 match htlc.state {
1315                                         InboundHTLCState::Committed => {},
1316                                         InboundHTLCState::LocalRemoved(_) => {
1317                                                 return Ok(None);
1318                                         },
1319                                         _ => {
1320                                                 debug_assert!(false, "Have an inbound HTLC we tried to claim before it was fully committed to");
1321                                                 return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1322                                         }
1323                                 }
1324                                 pending_idx = idx;
1325                         }
1326                 }
1327                 if pending_idx == std::usize::MAX {
1328                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1329                 }
1330
1331                 // Now update local state:
1332                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
1333                         for pending_update in self.holding_cell_htlc_updates.iter() {
1334                                 match pending_update {
1335                                         &HTLCUpdateAwaitingACK::ClaimHTLC { htlc_id, .. } => {
1336                                                 if htlc_id_arg == htlc_id {
1337                                                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1338                                                 }
1339                                         },
1340                                         &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, .. } => {
1341                                                 if htlc_id_arg == htlc_id {
1342                                                         return Err(ChannelError::Ignore("Unable to find a pending HTLC which matched the given HTLC ID"));
1343                                                 }
1344                                         },
1345                                         _ => {}
1346                                 }
1347                         }
1348                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::FailHTLC {
1349                                 htlc_id: htlc_id_arg,
1350                                 err_packet,
1351                         });
1352                         return Ok(None);
1353                 }
1354
1355                 {
1356                         let htlc = &mut self.pending_inbound_htlcs[pending_idx];
1357                         htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(err_packet.clone()));
1358                 }
1359
1360                 Ok(Some(msgs::UpdateFailHTLC {
1361                         channel_id: self.channel_id(),
1362                         htlc_id: htlc_id_arg,
1363                         reason: err_packet
1364                 }))
1365         }
1366
1367         // Message handlers:
1368
1369         pub fn accept_channel(&mut self, msg: &msgs::AcceptChannel, config: &UserConfig, their_local_features: LocalFeatures) -> Result<(), ChannelError> {
1370                 // Check sanity of message fields:
1371                 if !self.channel_outbound {
1372                         return Err(ChannelError::Close("Got an accept_channel message from an inbound peer"));
1373                 }
1374                 if self.channel_state != ChannelState::OurInitSent as u32 {
1375                         return Err(ChannelError::Close("Got an accept_channel message at a strange time"));
1376                 }
1377                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
1378                         return Err(ChannelError::Close("Peer never wants payout outputs?"));
1379                 }
1380                 if msg.channel_reserve_satoshis > self.channel_value_satoshis {
1381                         return Err(ChannelError::Close("Bogus channel_reserve_satoshis"));
1382                 }
1383                 if msg.dust_limit_satoshis > msg.channel_reserve_satoshis {
1384                         return Err(ChannelError::Close("Bogus channel_reserve and dust_limit"));
1385                 }
1386                 if msg.channel_reserve_satoshis < self.our_dust_limit_satoshis {
1387                         return Err(ChannelError::Close("Peer never wants payout outputs?"));
1388                 }
1389                 if msg.dust_limit_satoshis > Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis) {
1390                         return Err(ChannelError::Close("Dust limit is bigger than our channel reverse"));
1391                 }
1392                 if msg.htlc_minimum_msat >= (self.channel_value_satoshis - msg.channel_reserve_satoshis) * 1000 {
1393                         return Err(ChannelError::Close("Minimum htlc value is full channel value"));
1394                 }
1395                 if msg.to_self_delay > config.peer_channel_config_limits.their_to_self_delay || msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
1396                         return Err(ChannelError::Close("They wanted our payments to be delayed by a needlessly long period"));
1397                 }
1398                 if msg.max_accepted_htlcs < 1 {
1399                         return Err(ChannelError::Close("0 max_accepted_htlcs makes for a useless channel"));
1400                 }
1401                 if msg.max_accepted_htlcs > 483 {
1402                         return Err(ChannelError::Close("max_accepted_htlcs > 483"));
1403                 }
1404
1405                 // Now check against optional parameters as set by config...
1406                 if msg.htlc_minimum_msat > config.peer_channel_config_limits.max_htlc_minimum_msat {
1407                         return Err(ChannelError::Close("htlc minimum msat is higher than the user specified limit"));
1408                 }
1409                 if msg.max_htlc_value_in_flight_msat < config.peer_channel_config_limits.min_max_htlc_value_in_flight_msat {
1410                         return Err(ChannelError::Close("max htlc value in flight msat is less than the user specified limit"));
1411                 }
1412                 if msg.channel_reserve_satoshis > config.peer_channel_config_limits.max_channel_reserve_satoshis {
1413                         return Err(ChannelError::Close("channel reserve satoshis is higher than the user specified limit"));
1414                 }
1415                 if msg.max_accepted_htlcs < config.peer_channel_config_limits.min_max_accepted_htlcs {
1416                         return Err(ChannelError::Close("max accepted htlcs is less than the user specified limit"));
1417                 }
1418                 if msg.dust_limit_satoshis < config.peer_channel_config_limits.min_dust_limit_satoshis {
1419                         return Err(ChannelError::Close("dust limit satoshis is less than the user specified limit"));
1420                 }
1421                 if msg.dust_limit_satoshis > config.peer_channel_config_limits.max_dust_limit_satoshis {
1422                         return Err(ChannelError::Close("dust limit satoshis is greater than the user specified limit"));
1423                 }
1424                 if msg.minimum_depth > config.peer_channel_config_limits.max_minimum_depth {
1425                         return Err(ChannelError::Close("We consider the minimum depth to be unreasonably large"));
1426                 }
1427
1428                 let their_shutdown_scriptpubkey = if their_local_features.supports_upfront_shutdown_script() {
1429                         match &msg.shutdown_scriptpubkey {
1430                                 &OptionalField::Present(ref script) => {
1431                                         // Peer is signaling upfront_shutdown and has provided a non-accepted scriptpubkey format. We enforce it while receiving shutdown msg
1432                                         if script.is_p2pkh() || script.is_p2sh() || script.is_v0_p2wsh() || script.is_v0_p2wpkh() {
1433                                                 Some(script.clone())
1434                                         // Peer is signaling upfront_shutdown and has opt-out with a 0-length script. We don't enforce anything
1435                                         } else if script.len() == 0 {
1436                                                 None
1437                                         // Peer is signaling upfront_shutdown and has provided a non-accepted scriptpubkey format. Fail the channel
1438                                         } else {
1439                                                 return Err(ChannelError::Close("Peer is signaling upfront_shutdown but has provided a non-accepted scriptpubkey format"));
1440                                         }
1441                                 },
1442                                 // Peer is signaling upfront shutdown but don't opt-out with correct mechanism (a.k.a 0-length script). Peer looks buggy, we fail the channel
1443                                 &OptionalField::Absent => {
1444                                         return Err(ChannelError::Close("Peer is signaling upfront_shutdown but we don't get any script. Use 0-length script to opt-out"));
1445                                 }
1446                         }
1447                 } else { None };
1448
1449                 self.channel_monitor.set_their_base_keys(&msg.htlc_basepoint, &msg.delayed_payment_basepoint);
1450
1451                 self.their_dust_limit_satoshis = msg.dust_limit_satoshis;
1452                 self.their_max_htlc_value_in_flight_msat = cmp::min(msg.max_htlc_value_in_flight_msat, self.channel_value_satoshis * 1000);
1453                 self.their_channel_reserve_satoshis = msg.channel_reserve_satoshis;
1454                 self.their_htlc_minimum_msat = msg.htlc_minimum_msat;
1455                 self.their_to_self_delay = msg.to_self_delay;
1456                 self.their_max_accepted_htlcs = msg.max_accepted_htlcs;
1457                 self.minimum_depth = msg.minimum_depth;
1458                 self.their_funding_pubkey = Some(msg.funding_pubkey);
1459                 self.their_revocation_basepoint = Some(msg.revocation_basepoint);
1460                 self.their_payment_basepoint = Some(msg.payment_basepoint);
1461                 self.their_delayed_payment_basepoint = Some(msg.delayed_payment_basepoint);
1462                 self.their_htlc_basepoint = Some(msg.htlc_basepoint);
1463                 self.their_cur_commitment_point = Some(msg.first_per_commitment_point);
1464                 self.their_shutdown_scriptpubkey = their_shutdown_scriptpubkey;
1465
1466                 let obscure_factor = self.get_commitment_transaction_number_obscure_factor();
1467                 self.channel_monitor.set_commitment_obscure_factor(obscure_factor);
1468                 self.channel_monitor.set_their_to_self_delay(msg.to_self_delay);
1469
1470                 self.channel_state = ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32;
1471
1472                 Ok(())
1473         }
1474
1475         fn funding_created_signature(&mut self, sig: &Signature) -> Result<(Transaction, Transaction, Signature, TxCreationKeys), ChannelError> {
1476                 let funding_script = self.get_funding_redeemscript();
1477
1478                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1479                 let mut local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false, self.feerate_per_kw).0;
1480                 let local_sighash = hash_to_message!(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]);
1481
1482                 // They sign the "local" commitment transaction...
1483                 secp_check!(self.secp_ctx.verify(&local_sighash, &sig, &self.their_funding_pubkey.unwrap()), "Invalid funding_created signature from peer");
1484
1485                 // ...and we sign it, allowing us to broadcast the tx if we wish
1486                 self.sign_commitment_transaction(&mut local_initial_commitment_tx, sig);
1487
1488                 let remote_keys = self.build_remote_transaction_keys()?;
1489                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false, self.feerate_per_kw).0;
1490                 let remote_sighash = hash_to_message!(&bip143::SighashComponents::new(&remote_initial_commitment_tx).sighash_all(&remote_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]);
1491
1492                 // We sign the "remote" commitment transaction, allowing them to broadcast the tx if they wish.
1493                 Ok((remote_initial_commitment_tx, local_initial_commitment_tx, self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key), local_keys))
1494         }
1495
1496         pub fn funding_created(&mut self, msg: &msgs::FundingCreated) -> Result<(msgs::FundingSigned, ChannelMonitor), ChannelError> {
1497                 if self.channel_outbound {
1498                         return Err(ChannelError::Close("Received funding_created for an outbound channel?"));
1499                 }
1500                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
1501                         // BOLT 2 says that if we disconnect before we send funding_signed we SHOULD NOT
1502                         // remember the channel, so it's safe to just send an error_message here and drop the
1503                         // channel.
1504                         return Err(ChannelError::Close("Received funding_created after we got the channel!"));
1505                 }
1506                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) ||
1507                                 self.cur_remote_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
1508                                 self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1509                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1510                 }
1511
1512                 let funding_txo = OutPoint::new(msg.funding_txid, msg.funding_output_index);
1513                 let funding_txo_script = self.get_funding_redeemscript().to_v0_p2wsh();
1514                 self.channel_monitor.set_funding_info((funding_txo, funding_txo_script));
1515
1516                 let (remote_initial_commitment_tx, local_initial_commitment_tx, our_signature, local_keys) = match self.funding_created_signature(&msg.signature) {
1517                         Ok(res) => res,
1518                         Err(e) => {
1519                                 self.channel_monitor.unset_funding_info();
1520                                 return Err(e);
1521                         }
1522                 };
1523
1524                 // Now that we're past error-generating stuff, update our local state:
1525
1526                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&remote_initial_commitment_tx, Vec::new(), self.cur_remote_commitment_transaction_number, self.their_cur_commitment_point.unwrap());
1527                 self.last_local_commitment_txn = vec![local_initial_commitment_tx.clone()];
1528                 self.channel_monitor.provide_latest_local_commitment_tx_info(local_initial_commitment_tx, local_keys, self.feerate_per_kw, Vec::new());
1529                 self.channel_state = ChannelState::FundingSent as u32;
1530                 self.channel_id = funding_txo.to_channel_id();
1531                 self.cur_remote_commitment_transaction_number -= 1;
1532                 self.cur_local_commitment_transaction_number -= 1;
1533
1534                 Ok((msgs::FundingSigned {
1535                         channel_id: self.channel_id,
1536                         signature: our_signature
1537                 }, self.channel_monitor.clone()))
1538         }
1539
1540         /// Handles a funding_signed message from the remote end.
1541         /// If this call is successful, broadcast the funding transaction (and not before!)
1542         pub fn funding_signed(&mut self, msg: &msgs::FundingSigned) -> Result<ChannelMonitor, ChannelError> {
1543                 if !self.channel_outbound {
1544                         return Err(ChannelError::Close("Received funding_signed for an inbound channel?"));
1545                 }
1546                 if self.channel_state & !(ChannelState::MonitorUpdateFailed as u32) != ChannelState::FundingCreated as u32 {
1547                         return Err(ChannelError::Close("Received funding_signed in strange state!"));
1548                 }
1549                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) ||
1550                                 self.cur_remote_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER - 1 ||
1551                                 self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
1552                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1553                 }
1554
1555                 let funding_script = self.get_funding_redeemscript();
1556
1557                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1558                 let mut local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false, self.feerate_per_kw).0;
1559                 let local_sighash = hash_to_message!(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]);
1560
1561                 // They sign the "local" commitment transaction, allowing us to broadcast the tx if we wish.
1562                 secp_check!(self.secp_ctx.verify(&local_sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid funding_signed signature from peer");
1563
1564                 self.sign_commitment_transaction(&mut local_initial_commitment_tx, &msg.signature);
1565                 self.channel_monitor.provide_latest_local_commitment_tx_info(local_initial_commitment_tx.clone(), local_keys, self.feerate_per_kw, Vec::new());
1566                 self.last_local_commitment_txn = vec![local_initial_commitment_tx];
1567                 self.channel_state = ChannelState::FundingSent as u32 | (self.channel_state & (ChannelState::MonitorUpdateFailed as u32));
1568                 self.cur_local_commitment_transaction_number -= 1;
1569
1570                 if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
1571                         Ok(self.channel_monitor.clone())
1572                 } else {
1573                         Err(ChannelError::Ignore("Previous monitor update failure prevented funding_signed from allowing funding broadcast"))
1574                 }
1575         }
1576
1577         pub fn funding_locked(&mut self, msg: &msgs::FundingLocked) -> Result<(), ChannelError> {
1578                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1579                         return Err(ChannelError::Close("Peer sent funding_locked when we needed a channel_reestablish"));
1580                 }
1581
1582                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
1583
1584                 if non_shutdown_state == ChannelState::FundingSent as u32 {
1585                         self.channel_state |= ChannelState::TheirFundingLocked as u32;
1586                 } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
1587                         self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
1588                         self.channel_update_count += 1;
1589                 } else if (self.channel_state & (ChannelState::ChannelFunded as u32) != 0 &&
1590                                  // Note that funding_signed/funding_created will have decremented both by 1!
1591                                  self.cur_local_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1 &&
1592                                  self.cur_remote_commitment_transaction_number == INITIAL_COMMITMENT_NUMBER - 1) ||
1593                                 // If we reconnected before sending our funding locked they may still resend theirs:
1594                                 (self.channel_state & (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) ==
1595                                                       (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32)) {
1596                         if self.their_cur_commitment_point != Some(msg.next_per_commitment_point) {
1597                                 return Err(ChannelError::Close("Peer sent a reconnect funding_locked with a different point"));
1598                         }
1599                         // They probably disconnected/reconnected and re-sent the funding_locked, which is required
1600                         return Ok(());
1601                 } else {
1602                         return Err(ChannelError::Close("Peer sent a funding_locked at a strange time"));
1603                 }
1604
1605                 self.their_prev_commitment_point = self.their_cur_commitment_point;
1606                 self.their_cur_commitment_point = Some(msg.next_per_commitment_point);
1607                 Ok(())
1608         }
1609
1610         /// Returns (inbound_htlc_count, htlc_inbound_value_msat)
1611         fn get_inbound_pending_htlc_stats(&self) -> (u32, u64) {
1612                 let mut htlc_inbound_value_msat = 0;
1613                 for ref htlc in self.pending_inbound_htlcs.iter() {
1614                         htlc_inbound_value_msat += htlc.amount_msat;
1615                 }
1616                 (self.pending_inbound_htlcs.len() as u32, htlc_inbound_value_msat)
1617         }
1618
1619         /// Returns (outbound_htlc_count, htlc_outbound_value_msat) *including* pending adds in our
1620         /// holding cell.
1621         fn get_outbound_pending_htlc_stats(&self) -> (u32, u64) {
1622                 let mut htlc_outbound_value_msat = 0;
1623                 for ref htlc in self.pending_outbound_htlcs.iter() {
1624                         htlc_outbound_value_msat += htlc.amount_msat;
1625                 }
1626
1627                 let mut htlc_outbound_count = self.pending_outbound_htlcs.len();
1628                 for update in self.holding_cell_htlc_updates.iter() {
1629                         if let &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, .. } = update {
1630                                 htlc_outbound_count += 1;
1631                                 htlc_outbound_value_msat += amount_msat;
1632                         }
1633                 }
1634
1635                 (htlc_outbound_count as u32, htlc_outbound_value_msat)
1636         }
1637
1638         /// Get the available (ie not including pending HTLCs) inbound and outbound balance in msat.
1639         /// Doesn't bother handling the
1640         /// if-we-removed-it-already-but-haven't-fully-resolved-they-can-still-send-an-inbound-HTLC
1641         /// corner case properly.
1642         pub fn get_inbound_outbound_available_balance_msat(&self) -> (u64, u64) {
1643                 // Note that we have to handle overflow due to the above case.
1644                 (cmp::min(self.channel_value_satoshis as i64 * 1000 - self.value_to_self_msat as i64 - self.get_inbound_pending_htlc_stats().1 as i64, 0) as u64,
1645                 cmp::min(self.value_to_self_msat as i64 - self.get_outbound_pending_htlc_stats().1 as i64, 0) as u64)
1646         }
1647
1648         pub fn update_add_htlc(&mut self, msg: &msgs::UpdateAddHTLC, pending_forward_state: PendingHTLCStatus) -> Result<(), ChannelError> {
1649                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | ChannelState::RemoteShutdownSent as u32)) != (ChannelState::ChannelFunded as u32) {
1650                         return Err(ChannelError::Close("Got add HTLC message when channel was not in an operational state"));
1651                 }
1652                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1653                         return Err(ChannelError::Close("Peer sent update_add_htlc when we needed a channel_reestablish"));
1654                 }
1655                 if msg.amount_msat > self.channel_value_satoshis * 1000 {
1656                         return Err(ChannelError::Close("Remote side tried to send more than the total value of the channel"));
1657                 }
1658                 if msg.amount_msat < self.our_htlc_minimum_msat {
1659                         return Err(ChannelError::Close("Remote side tried to send less than our minimum HTLC value"));
1660                 }
1661
1662                 let (inbound_htlc_count, htlc_inbound_value_msat) = self.get_inbound_pending_htlc_stats();
1663                 if inbound_htlc_count + 1 > OUR_MAX_HTLCS as u32 {
1664                         return Err(ChannelError::Close("Remote tried to push more than our max accepted HTLCs"));
1665                 }
1666                 //TODO: Spec is unclear if this is per-direction or in total (I assume per direction):
1667                 // Check our_max_htlc_value_in_flight_msat
1668                 if htlc_inbound_value_msat + msg.amount_msat > Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis) {
1669                         return Err(ChannelError::Close("Remote HTLC add would put them over their max HTLC value in flight"));
1670                 }
1671                 // Check our_channel_reserve_satoshis (we're getting paid, so they have to at least meet
1672                 // the reserve_satoshis we told them to always have as direct payment so that they lose
1673                 // something if we punish them for broadcasting an old state).
1674                 // Note that we don't really care about having a small/no to_remote output in our local
1675                 // commitment transactions, as the purpose of the channel reserve is to ensure we can
1676                 // punish *them* if they misbehave, so we discount any outbound HTLCs which will not be
1677                 // present in the next commitment transaction we send them (at least for fulfilled ones,
1678                 // failed ones won't modify value_to_self).
1679                 // Note that we will send HTLCs which another instance of rust-lightning would think
1680                 // violate the reserve value if we do not do this (as we forget inbound HTLCs from the
1681                 // Channel state once they will not be present in the next received commitment
1682                 // transaction).
1683                 let mut removed_outbound_total_msat = 0;
1684                 for ref htlc in self.pending_outbound_htlcs.iter() {
1685                         if let OutboundHTLCState::AwaitingRemoteRevokeToRemove(None) = htlc.state {
1686                                 removed_outbound_total_msat += htlc.amount_msat;
1687                         } else if let OutboundHTLCState::AwaitingRemovedRemoteRevoke(None) = htlc.state {
1688                                 removed_outbound_total_msat += htlc.amount_msat;
1689                         }
1690                 }
1691                 if htlc_inbound_value_msat + msg.amount_msat + self.value_to_self_msat > (self.channel_value_satoshis - Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis)) * 1000 + removed_outbound_total_msat {
1692                         return Err(ChannelError::Close("Remote HTLC add would put them over their reserve value"));
1693                 }
1694                 if self.next_remote_htlc_id != msg.htlc_id {
1695                         return Err(ChannelError::Close("Remote skipped HTLC ID"));
1696                 }
1697                 if msg.cltv_expiry >= 500000000 {
1698                         return Err(ChannelError::Close("Remote provided CLTV expiry in seconds instead of block height"));
1699                 }
1700
1701                 //TODO: Check msg.cltv_expiry further? Do this in channel manager?
1702
1703                 if self.channel_state & ChannelState::LocalShutdownSent as u32 != 0 {
1704                         if let PendingHTLCStatus::Forward(_) = pending_forward_state {
1705                                 panic!("ChannelManager shouldn't be trying to add a forwardable HTLC after we've started closing");
1706                         }
1707                 }
1708
1709                 // Now update local state:
1710                 self.next_remote_htlc_id += 1;
1711                 self.pending_inbound_htlcs.push(InboundHTLCOutput {
1712                         htlc_id: msg.htlc_id,
1713                         amount_msat: msg.amount_msat,
1714                         payment_hash: msg.payment_hash,
1715                         cltv_expiry: msg.cltv_expiry,
1716                         state: InboundHTLCState::RemoteAnnounced(pending_forward_state),
1717                 });
1718                 Ok(())
1719         }
1720
1721         /// Marks an outbound HTLC which we have received update_fail/fulfill/malformed
1722         #[inline]
1723         fn mark_outbound_htlc_removed(&mut self, htlc_id: u64, check_preimage: Option<PaymentHash>, fail_reason: Option<HTLCFailReason>) -> Result<&HTLCSource, ChannelError> {
1724                 for htlc in self.pending_outbound_htlcs.iter_mut() {
1725                         if htlc.htlc_id == htlc_id {
1726                                 match check_preimage {
1727                                         None => {},
1728                                         Some(payment_hash) =>
1729                                                 if payment_hash != htlc.payment_hash {
1730                                                         return Err(ChannelError::Close("Remote tried to fulfill HTLC with an incorrect preimage"));
1731                                                 }
1732                                 };
1733                                 match htlc.state {
1734                                         OutboundHTLCState::LocalAnnounced(_) =>
1735                                                 return Err(ChannelError::Close("Remote tried to fulfill/fail HTLC before it had been committed")),
1736                                         OutboundHTLCState::Committed => {
1737                                                 htlc.state = OutboundHTLCState::RemoteRemoved(fail_reason);
1738                                         },
1739                                         OutboundHTLCState::AwaitingRemoteRevokeToRemove(_) | OutboundHTLCState::AwaitingRemovedRemoteRevoke(_) | OutboundHTLCState::RemoteRemoved(_) =>
1740                                                 return Err(ChannelError::Close("Remote tried to fulfill/fail HTLC that they'd already fulfilled/failed")),
1741                                 }
1742                                 return Ok(&htlc.source);
1743                         }
1744                 }
1745                 Err(ChannelError::Close("Remote tried to fulfill/fail an HTLC we couldn't find"))
1746         }
1747
1748         pub fn update_fulfill_htlc(&mut self, msg: &msgs::UpdateFulfillHTLC) -> Result<HTLCSource, ChannelError> {
1749                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1750                         return Err(ChannelError::Close("Got fulfill HTLC message when channel was not in an operational state"));
1751                 }
1752                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1753                         return Err(ChannelError::Close("Peer sent update_fulfill_htlc when we needed a channel_reestablish"));
1754                 }
1755
1756                 let payment_hash = PaymentHash(Sha256::hash(&msg.payment_preimage.0[..]).into_inner());
1757                 self.mark_outbound_htlc_removed(msg.htlc_id, Some(payment_hash), None).map(|source| source.clone())
1758         }
1759
1760         pub fn update_fail_htlc(&mut self, msg: &msgs::UpdateFailHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
1761                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1762                         return Err(ChannelError::Close("Got fail HTLC message when channel was not in an operational state"));
1763                 }
1764                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1765                         return Err(ChannelError::Close("Peer sent update_fail_htlc when we needed a channel_reestablish"));
1766                 }
1767
1768                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
1769                 Ok(())
1770         }
1771
1772         pub fn update_fail_malformed_htlc<'a>(&mut self, msg: &msgs::UpdateFailMalformedHTLC, fail_reason: HTLCFailReason) -> Result<(), ChannelError> {
1773                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1774                         return Err(ChannelError::Close("Got fail malformed HTLC message when channel was not in an operational state"));
1775                 }
1776                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1777                         return Err(ChannelError::Close("Peer sent update_fail_malformed_htlc when we needed a channel_reestablish"));
1778                 }
1779
1780                 self.mark_outbound_htlc_removed(msg.htlc_id, None, Some(fail_reason))?;
1781                 Ok(())
1782         }
1783
1784         pub fn commitment_signed(&mut self, msg: &msgs::CommitmentSigned, fee_estimator: &FeeEstimator) -> Result<(msgs::RevokeAndACK, Option<msgs::CommitmentSigned>, Option<msgs::ClosingSigned>, ChannelMonitor), ChannelError> {
1785                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1786                         return Err(ChannelError::Close("Got commitment signed message when channel was not in an operational state"));
1787                 }
1788                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
1789                         return Err(ChannelError::Close("Peer sent commitment_signed when we needed a channel_reestablish"));
1790                 }
1791                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
1792                         return Err(ChannelError::Close("Peer sent commitment_signed after we'd started exchanging closing_signeds"));
1793                 }
1794
1795                 let funding_script = self.get_funding_redeemscript();
1796
1797                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1798
1799                 let mut update_fee = false;
1800                 let feerate_per_kw = if !self.channel_outbound && self.pending_update_fee.is_some() {
1801                         update_fee = true;
1802                         self.pending_update_fee.unwrap()
1803                 } else {
1804                         self.feerate_per_kw
1805                 };
1806
1807                 let mut local_commitment_tx = {
1808                         let mut commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false, feerate_per_kw);
1809                         let htlcs_cloned: Vec<_> = commitment_tx.2.drain(..).map(|htlc| (htlc.0, htlc.1.map(|h| h.clone()))).collect();
1810                         (commitment_tx.0, commitment_tx.1, htlcs_cloned)
1811                 };
1812                 let local_commitment_txid = local_commitment_tx.0.txid();
1813                 let local_sighash = hash_to_message!(&bip143::SighashComponents::new(&local_commitment_tx.0).sighash_all(&local_commitment_tx.0.input[0], &funding_script, self.channel_value_satoshis)[..]);
1814                 log_trace!(self, "Checking commitment tx signature {} by key {} against tx {} with redeemscript {}", log_bytes!(msg.signature.serialize_compact()[..]), log_bytes!(self.their_funding_pubkey.unwrap().serialize()), encode::serialize_hex(&local_commitment_tx.0), encode::serialize_hex(&funding_script));
1815                 secp_check!(self.secp_ctx.verify(&local_sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid commitment tx signature from peer");
1816
1817                 //If channel fee was updated by funder confirm funder can afford the new fee rate when applied to the current local commitment transaction
1818                 if update_fee {
1819                         let num_htlcs = local_commitment_tx.1;
1820                         let total_fee: u64 = feerate_per_kw as u64 * (COMMITMENT_TX_BASE_WEIGHT + (num_htlcs as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
1821
1822                         if self.channel_value_satoshis - self.value_to_self_msat / 1000 < total_fee + self.their_channel_reserve_satoshis {
1823                                 return Err(ChannelError::Close("Funding remote cannot afford proposed new fee"));
1824                         }
1825                 }
1826
1827                 if msg.htlc_signatures.len() != local_commitment_tx.1 {
1828                         return Err(ChannelError::Close("Got wrong number of HTLC signatures from remote"));
1829                 }
1830
1831                 let mut new_local_commitment_txn = Vec::with_capacity(local_commitment_tx.1 + 1);
1832                 self.sign_commitment_transaction(&mut local_commitment_tx.0, &msg.signature);
1833                 new_local_commitment_txn.push(local_commitment_tx.0.clone());
1834
1835                 let mut htlcs_and_sigs = Vec::with_capacity(local_commitment_tx.2.len());
1836                 for (idx, (htlc, source)) in local_commitment_tx.2.drain(..).enumerate() {
1837                         if let Some(_) = htlc.transaction_output_index {
1838                                 let mut htlc_tx = self.build_htlc_transaction(&local_commitment_txid, &htlc, true, &local_keys, feerate_per_kw);
1839                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &local_keys);
1840                                 log_trace!(self, "Checking HTLC tx signature {} by key {} against tx {} with redeemscript {}", log_bytes!(msg.htlc_signatures[idx].serialize_compact()[..]), log_bytes!(local_keys.b_htlc_key.serialize()), encode::serialize_hex(&htlc_tx), encode::serialize_hex(&htlc_redeemscript));
1841                                 let htlc_sighash = hash_to_message!(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]);
1842                                 secp_check!(self.secp_ctx.verify(&htlc_sighash, &msg.htlc_signatures[idx], &local_keys.b_htlc_key), "Invalid HTLC tx signature from peer");
1843                                 let htlc_sig = if htlc.offered {
1844                                         let htlc_sig = self.sign_htlc_transaction(&mut htlc_tx, &msg.htlc_signatures[idx], &None, &htlc, &local_keys)?;
1845                                         new_local_commitment_txn.push(htlc_tx);
1846                                         htlc_sig
1847                                 } else {
1848                                         self.create_htlc_tx_signature(&htlc_tx, &htlc, &local_keys)?.1
1849                                 };
1850                                 htlcs_and_sigs.push((htlc, Some((msg.htlc_signatures[idx], htlc_sig)), source));
1851                         } else {
1852                                 htlcs_and_sigs.push((htlc, None, source));
1853                         }
1854                 }
1855
1856                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(self.cur_local_commitment_transaction_number - 1));
1857                 let per_commitment_secret = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, self.cur_local_commitment_transaction_number + 1);
1858
1859                 // Update state now that we've passed all the can-fail calls...
1860                 let mut need_our_commitment = false;
1861                 if !self.channel_outbound {
1862                         if let Some(fee_update) = self.pending_update_fee {
1863                                 self.feerate_per_kw = fee_update;
1864                                 // We later use the presence of pending_update_fee to indicate we should generate a
1865                                 // commitment_signed upon receipt of revoke_and_ack, so we can only set it to None
1866                                 // if we're not awaiting a revoke (ie will send a commitment_signed now).
1867                                 if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) == 0 {
1868                                         need_our_commitment = true;
1869                                         self.pending_update_fee = None;
1870                                 }
1871                         }
1872                 }
1873
1874                 self.channel_monitor.provide_latest_local_commitment_tx_info(local_commitment_tx.0, local_keys, self.feerate_per_kw, htlcs_and_sigs);
1875
1876                 for htlc in self.pending_inbound_htlcs.iter_mut() {
1877                         let new_forward = if let &InboundHTLCState::RemoteAnnounced(ref forward_info) = &htlc.state {
1878                                 Some(forward_info.clone())
1879                         } else { None };
1880                         if let Some(forward_info) = new_forward {
1881                                 htlc.state = InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info);
1882                                 need_our_commitment = true;
1883                         }
1884                 }
1885                 for htlc in self.pending_outbound_htlcs.iter_mut() {
1886                         if let Some(fail_reason) = if let &mut OutboundHTLCState::RemoteRemoved(ref mut fail_reason) = &mut htlc.state {
1887                                 Some(fail_reason.take())
1888                         } else { None } {
1889                                 htlc.state = OutboundHTLCState::AwaitingRemoteRevokeToRemove(fail_reason);
1890                                 need_our_commitment = true;
1891                         }
1892                 }
1893
1894                 self.cur_local_commitment_transaction_number -= 1;
1895                 self.last_local_commitment_txn = new_local_commitment_txn;
1896                 // Note that if we need_our_commitment & !AwaitingRemoteRevoke we'll call
1897                 // send_commitment_no_status_check() next which will reset this to RAAFirst.
1898                 self.resend_order = RAACommitmentOrder::CommitmentFirst;
1899
1900                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0 {
1901                         // In case we initially failed monitor updating without requiring a response, we need
1902                         // to make sure the RAA gets sent first.
1903                         self.monitor_pending_revoke_and_ack = true;
1904                         if need_our_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
1905                                 // If we were going to send a commitment_signed after the RAA, go ahead and do all
1906                                 // the corresponding HTLC status updates so that get_last_commitment_update
1907                                 // includes the right HTLCs.
1908                                 // Note that this generates a monitor update that we ignore! This is OK since we
1909                                 // won't actually send the commitment_signed that generated the update to the other
1910                                 // side until the latest monitor has been pulled from us and stored.
1911                                 self.monitor_pending_commitment_signed = true;
1912                                 self.send_commitment_no_status_check()?;
1913                         }
1914                         // TODO: Call maybe_propose_first_closing_signed on restoration (or call it here and
1915                         // re-send the message on restoration)
1916                         return Err(ChannelError::Ignore("Previous monitor update failure prevented generation of RAA"));
1917                 }
1918
1919                 let (our_commitment_signed, monitor_update, closing_signed) = if need_our_commitment && (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == 0 {
1920                         // If we're AwaitingRemoteRevoke we can't send a new commitment here, but that's ok -
1921                         // we'll send one right away when we get the revoke_and_ack when we
1922                         // free_holding_cell_htlcs().
1923                         let (msg, monitor) = self.send_commitment_no_status_check()?;
1924                         (Some(msg), monitor, None)
1925                 } else if !need_our_commitment {
1926                         (None, self.channel_monitor.clone(), self.maybe_propose_first_closing_signed(fee_estimator))
1927                 } else { (None, self.channel_monitor.clone(), None) };
1928
1929                 Ok((msgs::RevokeAndACK {
1930                         channel_id: self.channel_id,
1931                         per_commitment_secret: per_commitment_secret,
1932                         next_per_commitment_point: next_per_commitment_point,
1933                 }, our_commitment_signed, closing_signed, monitor_update))
1934         }
1935
1936         /// Used to fulfill holding_cell_htlcs when we get a remote ack (or implicitly get it by them
1937         /// fulfilling or failing the last pending HTLC)
1938         fn free_holding_cell_htlcs(&mut self) -> Result<Option<(msgs::CommitmentUpdate, ChannelMonitor)>, ChannelError> {
1939                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
1940                 if self.holding_cell_htlc_updates.len() != 0 || self.holding_cell_update_fee.is_some() {
1941                         log_trace!(self, "Freeing holding cell with {} HTLC updates{}", self.holding_cell_htlc_updates.len(), if self.holding_cell_update_fee.is_some() { " and a fee update" } else { "" });
1942
1943                         let mut htlc_updates = Vec::new();
1944                         mem::swap(&mut htlc_updates, &mut self.holding_cell_htlc_updates);
1945                         let mut update_add_htlcs = Vec::with_capacity(htlc_updates.len());
1946                         let mut update_fulfill_htlcs = Vec::with_capacity(htlc_updates.len());
1947                         let mut update_fail_htlcs = Vec::with_capacity(htlc_updates.len());
1948                         let mut err = None;
1949                         for htlc_update in htlc_updates.drain(..) {
1950                                 // Note that this *can* fail, though it should be due to rather-rare conditions on
1951                                 // fee races with adding too many outputs which push our total payments just over
1952                                 // the limit. In case it's less rare than I anticipate, we may want to revisit
1953                                 // handling this case better and maybe fulfilling some of the HTLCs while attempting
1954                                 // to rebalance channels.
1955                                 if err.is_some() { // We're back to AwaitingRemoteRevoke (or are about to fail the channel)
1956                                         self.holding_cell_htlc_updates.push(htlc_update);
1957                                 } else {
1958                                         match &htlc_update {
1959                                                 &HTLCUpdateAwaitingACK::AddHTLC {amount_msat, cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, ..} => {
1960                                                         match self.send_htlc(amount_msat, *payment_hash, cltv_expiry, source.clone(), onion_routing_packet.clone()) {
1961                                                                 Ok(update_add_msg_option) => update_add_htlcs.push(update_add_msg_option.unwrap()),
1962                                                                 Err(e) => {
1963                                                                         match e {
1964                                                                                 ChannelError::Ignore(ref msg) => {
1965                                                                                         log_info!(self, "Failed to send HTLC with payment_hash {} due to {}", log_bytes!(payment_hash.0), msg);
1966                                                                                 },
1967                                                                                 _ => {
1968                                                                                         log_info!(self, "Failed to send HTLC with payment_hash {} resulting in a channel closure during holding_cell freeing", log_bytes!(payment_hash.0));
1969                                                                                 },
1970                                                                         }
1971                                                                         err = Some(e);
1972                                                                 }
1973                                                         }
1974                                                 },
1975                                                 &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, htlc_id, .. } => {
1976                                                         match self.get_update_fulfill_htlc(htlc_id, *payment_preimage) {
1977                                                                 Ok(update_fulfill_msg_option) => update_fulfill_htlcs.push(update_fulfill_msg_option.0.unwrap()),
1978                                                                 Err(e) => {
1979                                                                         if let ChannelError::Ignore(_) = e {}
1980                                                                         else {
1981                                                                                 panic!("Got a non-IgnoreError action trying to fulfill holding cell HTLC");
1982                                                                         }
1983                                                                 }
1984                                                         }
1985                                                 },
1986                                                 &HTLCUpdateAwaitingACK::FailHTLC { htlc_id, ref err_packet } => {
1987                                                         match self.get_update_fail_htlc(htlc_id, err_packet.clone()) {
1988                                                                 Ok(update_fail_msg_option) => update_fail_htlcs.push(update_fail_msg_option.unwrap()),
1989                                                                 Err(e) => {
1990                                                                         if let ChannelError::Ignore(_) = e {}
1991                                                                         else {
1992                                                                                 panic!("Got a non-IgnoreError action trying to fail holding cell HTLC");
1993                                                                         }
1994                                                                 }
1995                                                         }
1996                                                 },
1997                                         }
1998                                         if err.is_some() {
1999                                                 self.holding_cell_htlc_updates.push(htlc_update);
2000                                                 if let Some(ChannelError::Ignore(_)) = err {
2001                                                         // If we failed to add the HTLC, but got an Ignore error, we should
2002                                                         // still send the new commitment_signed, so reset the err to None.
2003                                                         err = None;
2004                                                 }
2005                                         }
2006                                 }
2007                         }
2008                         //TODO: Need to examine the type of err - if it's a fee issue or similar we may want to
2009                         //fail it back the route, if it's a temporary issue we can ignore it...
2010                         match err {
2011                                 None => {
2012                                         if update_add_htlcs.is_empty() && update_fulfill_htlcs.is_empty() && update_fail_htlcs.is_empty() && self.holding_cell_update_fee.is_none() {
2013                                                 // This should never actually happen and indicates we got some Errs back
2014                                                 // from update_fulfill_htlc/update_fail_htlc, but we handle it anyway in
2015                                                 // case there is some strange way to hit duplicate HTLC removes.
2016                                                 return Ok(None);
2017                                         }
2018                                         let update_fee = if let Some(feerate) = self.holding_cell_update_fee {
2019                                                         self.pending_update_fee = self.holding_cell_update_fee.take();
2020                                                         Some(msgs::UpdateFee {
2021                                                                 channel_id: self.channel_id,
2022                                                                 feerate_per_kw: feerate as u32,
2023                                                         })
2024                                                 } else {
2025                                                         None
2026                                                 };
2027                                         let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
2028                                         Ok(Some((msgs::CommitmentUpdate {
2029                                                 update_add_htlcs,
2030                                                 update_fulfill_htlcs,
2031                                                 update_fail_htlcs,
2032                                                 update_fail_malformed_htlcs: Vec::new(),
2033                                                 update_fee: update_fee,
2034                                                 commitment_signed,
2035                                         }, monitor_update)))
2036                                 },
2037                                 Some(e) => Err(e)
2038                         }
2039                 } else {
2040                         Ok(None)
2041                 }
2042         }
2043
2044         /// Handles receiving a remote's revoke_and_ack. Note that we may return a new
2045         /// commitment_signed message here in case we had pending outbound HTLCs to add which were
2046         /// waiting on this revoke_and_ack. The generation of this new commitment_signed may also fail,
2047         /// generating an appropriate error *after* the channel state has been updated based on the
2048         /// revoke_and_ack message.
2049         pub fn revoke_and_ack(&mut self, msg: &msgs::RevokeAndACK, fee_estimator: &FeeEstimator) -> Result<(Option<msgs::CommitmentUpdate>, Vec<(PendingForwardHTLCInfo, u64)>, Vec<(HTLCSource, PaymentHash, HTLCFailReason)>, Option<msgs::ClosingSigned>, ChannelMonitor), ChannelError> {
2050                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
2051                         return Err(ChannelError::Close("Got revoke/ACK message when channel was not in an operational state"));
2052                 }
2053                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2054                         return Err(ChannelError::Close("Peer sent revoke_and_ack when we needed a channel_reestablish"));
2055                 }
2056                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK == BOTH_SIDES_SHUTDOWN_MASK && self.last_sent_closing_fee.is_some() {
2057                         return Err(ChannelError::Close("Peer sent revoke_and_ack after we'd started exchanging closing_signeds"));
2058                 }
2059
2060                 if let Some(their_prev_commitment_point) = self.their_prev_commitment_point {
2061                         if PublicKey::from_secret_key(&self.secp_ctx, &secp_check!(SecretKey::from_slice(&msg.per_commitment_secret), "Peer provided an invalid per_commitment_secret")) != their_prev_commitment_point {
2062                                 return Err(ChannelError::Close("Got a revoke commitment secret which didn't correspond to their current pubkey"));
2063                         }
2064                 }
2065                 self.channel_monitor.provide_secret(self.cur_remote_commitment_transaction_number + 1, msg.per_commitment_secret)
2066                         .map_err(|e| ChannelError::Close(e.0))?;
2067
2068                 // Update state now that we've passed all the can-fail calls...
2069                 // (note that we may still fail to generate the new commitment_signed message, but that's
2070                 // OK, we step the channel here and *then* if the new generation fails we can fail the
2071                 // channel based on that, but stepping stuff here should be safe either way.
2072                 self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
2073                 self.their_prev_commitment_point = self.their_cur_commitment_point;
2074                 self.their_cur_commitment_point = Some(msg.next_per_commitment_point);
2075                 self.cur_remote_commitment_transaction_number -= 1;
2076
2077                 log_trace!(self, "Updating HTLCs on receipt of RAA...");
2078                 let mut to_forward_infos = Vec::new();
2079                 let mut revoked_htlcs = Vec::new();
2080                 let mut update_fail_htlcs = Vec::new();
2081                 let mut update_fail_malformed_htlcs = Vec::new();
2082                 let mut require_commitment = false;
2083                 let mut value_to_self_msat_diff: i64 = 0;
2084
2085                 {
2086                         // Take references explicitly so that we can hold multiple references to self.
2087                         let pending_inbound_htlcs: &mut Vec<_> = &mut self.pending_inbound_htlcs;
2088                         let pending_outbound_htlcs: &mut Vec<_> = &mut self.pending_outbound_htlcs;
2089                         let logger = LogHolder { logger: &self.logger };
2090
2091                         // We really shouldnt have two passes here, but retain gives a non-mutable ref (Rust bug)
2092                         pending_inbound_htlcs.retain(|htlc| {
2093                                 if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
2094                                         log_trace!(logger, " ...removing inbound LocalRemoved {}", log_bytes!(htlc.payment_hash.0));
2095                                         if let &InboundHTLCRemovalReason::Fulfill(_) = reason {
2096                                                 value_to_self_msat_diff += htlc.amount_msat as i64;
2097                                         }
2098                                         false
2099                                 } else { true }
2100                         });
2101                         pending_outbound_htlcs.retain(|htlc| {
2102                                 if let &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref fail_reason) = &htlc.state {
2103                                         log_trace!(logger, " ...removing outbound AwaitingRemovedRemoteRevoke {}", log_bytes!(htlc.payment_hash.0));
2104                                         if let Some(reason) = fail_reason.clone() { // We really want take() here, but, again, non-mut ref :(
2105                                                 revoked_htlcs.push((htlc.source.clone(), htlc.payment_hash, reason));
2106                                         } else {
2107                                                 // They fulfilled, so we sent them money
2108                                                 value_to_self_msat_diff -= htlc.amount_msat as i64;
2109                                         }
2110                                         false
2111                                 } else { true }
2112                         });
2113                         for htlc in pending_inbound_htlcs.iter_mut() {
2114                                 let swap = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_) = &htlc.state {
2115                                         log_trace!(logger, " ...promoting inbound AwaitingRemoteRevokeToAnnounce {} to Committed", log_bytes!(htlc.payment_hash.0));
2116                                         true
2117                                 } else if let &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) = &htlc.state {
2118                                         log_trace!(logger, " ...promoting inbound AwaitingAnnouncedRemoteRevoke {} to Committed", log_bytes!(htlc.payment_hash.0));
2119                                         true
2120                                 } else { false };
2121                                 if swap {
2122                                         let mut state = InboundHTLCState::Committed;
2123                                         mem::swap(&mut state, &mut htlc.state);
2124
2125                                         if let InboundHTLCState::AwaitingRemoteRevokeToAnnounce(forward_info) = state {
2126                                                 htlc.state = InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info);
2127                                                 require_commitment = true;
2128                                         } else if let InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info) = state {
2129                                                 match forward_info {
2130                                                         PendingHTLCStatus::Fail(fail_msg) => {
2131                                                                 require_commitment = true;
2132                                                                 match fail_msg {
2133                                                                         HTLCFailureMsg::Relay(msg) => {
2134                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(msg.reason.clone()));
2135                                                                                 update_fail_htlcs.push(msg)
2136                                                                         },
2137                                                                         HTLCFailureMsg::Malformed(msg) => {
2138                                                                                 htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailMalformed((msg.sha256_of_onion, msg.failure_code)));
2139                                                                                 update_fail_malformed_htlcs.push(msg)
2140                                                                         },
2141                                                                 }
2142                                                         },
2143                                                         PendingHTLCStatus::Forward(forward_info) => {
2144                                                                 to_forward_infos.push((forward_info, htlc.htlc_id));
2145                                                                 htlc.state = InboundHTLCState::Committed;
2146                                                         }
2147                                                 }
2148                                         }
2149                                 }
2150                         }
2151                         for htlc in pending_outbound_htlcs.iter_mut() {
2152                                 if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
2153                                         log_trace!(logger, " ...promoting outbound LocalAnnounced {} to Committed", log_bytes!(htlc.payment_hash.0));
2154                                         htlc.state = OutboundHTLCState::Committed;
2155                                 }
2156                                 if let Some(fail_reason) = if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut fail_reason) = &mut htlc.state {
2157                                         Some(fail_reason.take())
2158                                 } else { None } {
2159                                         log_trace!(logger, " ...promoting outbound AwaitingRemoteRevokeToRemove {} to AwaitingRemovedRemoteRevoke", log_bytes!(htlc.payment_hash.0));
2160                                         htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(fail_reason);
2161                                         require_commitment = true;
2162                                 }
2163                         }
2164                 }
2165                 self.value_to_self_msat = (self.value_to_self_msat as i64 + value_to_self_msat_diff) as u64;
2166
2167                 if self.channel_outbound {
2168                         if let Some(feerate) = self.pending_update_fee.take() {
2169                                 self.feerate_per_kw = feerate;
2170                         }
2171                 } else {
2172                         if let Some(feerate) = self.pending_update_fee {
2173                                 // Because a node cannot send two commitment_signeds in a row without getting a
2174                                 // revoke_and_ack from us (as it would otherwise not know the per_commitment_point
2175                                 // it should use to create keys with) and because a node can't send a
2176                                 // commitment_signed without changes, checking if the feerate is equal to the
2177                                 // pending feerate update is sufficient to detect require_commitment.
2178                                 if feerate == self.feerate_per_kw {
2179                                         require_commitment = true;
2180                                         self.pending_update_fee = None;
2181                                 }
2182                         }
2183                 }
2184
2185                 if (self.channel_state & ChannelState::MonitorUpdateFailed as u32) == ChannelState::MonitorUpdateFailed as u32 {
2186                         // We can't actually generate a new commitment transaction (incl by freeing holding
2187                         // cells) while we can't update the monitor, so we just return what we have.
2188                         if require_commitment {
2189                                 self.monitor_pending_commitment_signed = true;
2190                                 // When the monitor updating is restored we'll call get_last_commitment_update(),
2191                                 // which does not update state, but we're definitely now awaiting a remote revoke
2192                                 // before we can step forward any more, so set it here.
2193                                 self.send_commitment_no_status_check()?;
2194                         }
2195                         self.monitor_pending_forwards.append(&mut to_forward_infos);
2196                         self.monitor_pending_failures.append(&mut revoked_htlcs);
2197                         return Ok((None, Vec::new(), Vec::new(), None, self.channel_monitor.clone()));
2198                 }
2199
2200                 match self.free_holding_cell_htlcs()? {
2201                         Some(mut commitment_update) => {
2202                                 commitment_update.0.update_fail_htlcs.reserve(update_fail_htlcs.len());
2203                                 for fail_msg in update_fail_htlcs.drain(..) {
2204                                         commitment_update.0.update_fail_htlcs.push(fail_msg);
2205                                 }
2206                                 commitment_update.0.update_fail_malformed_htlcs.reserve(update_fail_malformed_htlcs.len());
2207                                 for fail_msg in update_fail_malformed_htlcs.drain(..) {
2208                                         commitment_update.0.update_fail_malformed_htlcs.push(fail_msg);
2209                                 }
2210                                 Ok((Some(commitment_update.0), to_forward_infos, revoked_htlcs, None, commitment_update.1))
2211                         },
2212                         None => {
2213                                 if require_commitment {
2214                                         let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
2215                                         Ok((Some(msgs::CommitmentUpdate {
2216                                                 update_add_htlcs: Vec::new(),
2217                                                 update_fulfill_htlcs: Vec::new(),
2218                                                 update_fail_htlcs,
2219                                                 update_fail_malformed_htlcs,
2220                                                 update_fee: None,
2221                                                 commitment_signed
2222                                         }), to_forward_infos, revoked_htlcs, None, monitor_update))
2223                                 } else {
2224                                         Ok((None, to_forward_infos, revoked_htlcs, self.maybe_propose_first_closing_signed(fee_estimator), self.channel_monitor.clone()))
2225                                 }
2226                         }
2227                 }
2228
2229         }
2230
2231         /// Adds a pending update to this channel. See the doc for send_htlc for
2232         /// further details on the optionness of the return value.
2233         /// You MUST call send_commitment prior to any other calls on this Channel
2234         fn send_update_fee(&mut self, feerate_per_kw: u64) -> Option<msgs::UpdateFee> {
2235                 if !self.channel_outbound {
2236                         panic!("Cannot send fee from inbound channel");
2237                 }
2238                 if !self.is_usable() {
2239                         panic!("Cannot update fee until channel is fully established and we haven't started shutting down");
2240                 }
2241                 if !self.is_live() {
2242                         panic!("Cannot update fee while peer is disconnected/we're awaiting a monitor update (ChannelManager should have caught this)");
2243                 }
2244
2245                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
2246                         self.holding_cell_update_fee = Some(feerate_per_kw);
2247                         return None;
2248                 }
2249
2250                 debug_assert!(self.pending_update_fee.is_none());
2251                 self.pending_update_fee = Some(feerate_per_kw);
2252
2253                 Some(msgs::UpdateFee {
2254                         channel_id: self.channel_id,
2255                         feerate_per_kw: feerate_per_kw as u32,
2256                 })
2257         }
2258
2259         pub fn send_update_fee_and_commit(&mut self, feerate_per_kw: u64) -> Result<Option<(msgs::UpdateFee, msgs::CommitmentSigned, ChannelMonitor)>, ChannelError> {
2260                 match self.send_update_fee(feerate_per_kw) {
2261                         Some(update_fee) => {
2262                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
2263                                 Ok(Some((update_fee, commitment_signed, monitor_update)))
2264                         },
2265                         None => Ok(None)
2266                 }
2267         }
2268
2269         /// Removes any uncommitted HTLCs, to be used on peer disconnection, including any pending
2270         /// HTLCs that we intended to add but haven't as we were waiting on a remote revoke.
2271         /// Returns the set of PendingHTLCStatuses from remote uncommitted HTLCs (which we're
2272         /// implicitly dropping) and the payment_hashes of HTLCs we tried to add but are dropping.
2273         /// No further message handling calls may be made until a channel_reestablish dance has
2274         /// completed.
2275         pub fn remove_uncommitted_htlcs_and_mark_paused(&mut self) -> Vec<(HTLCSource, PaymentHash)> {
2276                 let mut outbound_drops = Vec::new();
2277
2278                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
2279                 if self.channel_state < ChannelState::FundingSent as u32 {
2280                         self.channel_state = ChannelState::ShutdownComplete as u32;
2281                         return outbound_drops;
2282                 }
2283                 // Upon reconnect we have to start the closing_signed dance over, but shutdown messages
2284                 // will be retransmitted.
2285                 self.last_sent_closing_fee = None;
2286
2287                 let mut inbound_drop_count = 0;
2288                 self.pending_inbound_htlcs.retain(|htlc| {
2289                         match htlc.state {
2290                                 InboundHTLCState::RemoteAnnounced(_) => {
2291                                         // They sent us an update_add_htlc but we never got the commitment_signed.
2292                                         // We'll tell them what commitment_signed we're expecting next and they'll drop
2293                                         // this HTLC accordingly
2294                                         inbound_drop_count += 1;
2295                                         false
2296                                 },
2297                                 InboundHTLCState::AwaitingRemoteRevokeToAnnounce(_)|InboundHTLCState::AwaitingAnnouncedRemoteRevoke(_) => {
2298                                         // We received a commitment_signed updating this HTLC and (at least hopefully)
2299                                         // sent a revoke_and_ack (which we can re-transmit) and have heard nothing
2300                                         // in response to it yet, so don't touch it.
2301                                         true
2302                                 },
2303                                 InboundHTLCState::Committed => true,
2304                                 InboundHTLCState::LocalRemoved(_) => {
2305                                         // We (hopefully) sent a commitment_signed updating this HTLC (which we can
2306                                         // re-transmit if needed) and they may have even sent a revoke_and_ack back
2307                                         // (that we missed). Keep this around for now and if they tell us they missed
2308                                         // the commitment_signed we can re-transmit the update then.
2309                                         true
2310                                 },
2311                         }
2312                 });
2313                 self.next_remote_htlc_id -= inbound_drop_count;
2314
2315                 for htlc in self.pending_outbound_htlcs.iter_mut() {
2316                         if let OutboundHTLCState::RemoteRemoved(_) = htlc.state {
2317                                 // They sent us an update to remove this but haven't yet sent the corresponding
2318                                 // commitment_signed, we need to move it back to Committed and they can re-send
2319                                 // the update upon reconnection.
2320                                 htlc.state = OutboundHTLCState::Committed;
2321                         }
2322                 }
2323
2324                 self.holding_cell_htlc_updates.retain(|htlc_update| {
2325                         match htlc_update {
2326                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
2327                                         outbound_drops.push((source.clone(), payment_hash.clone()));
2328                                         false
2329                                 },
2330                                 &HTLCUpdateAwaitingACK::ClaimHTLC {..} | &HTLCUpdateAwaitingACK::FailHTLC {..} => true,
2331                         }
2332                 });
2333                 self.channel_state |= ChannelState::PeerDisconnected as u32;
2334                 log_debug!(self, "Peer disconnection resulted in {} remote-announced HTLC drops and {} waiting-to-locally-announced HTLC drops on channel {}", outbound_drops.len(), inbound_drop_count, log_bytes!(self.channel_id()));
2335                 outbound_drops
2336         }
2337
2338         /// Indicates that a ChannelMonitor update failed to be stored by the client and further
2339         /// updates are partially paused.
2340         /// This must be called immediately after the call which generated the ChannelMonitor update
2341         /// which failed. The messages which were generated from that call which generated the
2342         /// monitor update failure must *not* have been sent to the remote end, and must instead
2343         /// have been dropped. They will be regenerated when monitor_updating_restored is called.
2344         pub fn monitor_update_failed(&mut self, resend_raa: bool, resend_commitment: bool, mut pending_forwards: Vec<(PendingForwardHTLCInfo, u64)>, mut pending_fails: Vec<(HTLCSource, PaymentHash, HTLCFailReason)>) {
2345                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, 0);
2346                 self.monitor_pending_revoke_and_ack = resend_raa;
2347                 self.monitor_pending_commitment_signed = resend_commitment;
2348                 assert!(self.monitor_pending_forwards.is_empty());
2349                 mem::swap(&mut pending_forwards, &mut self.monitor_pending_forwards);
2350                 assert!(self.monitor_pending_failures.is_empty());
2351                 mem::swap(&mut pending_fails, &mut self.monitor_pending_failures);
2352                 self.channel_state |= ChannelState::MonitorUpdateFailed as u32;
2353         }
2354
2355         /// Indicates that the latest ChannelMonitor update has been committed by the client
2356         /// successfully and we should restore normal operation. Returns messages which should be sent
2357         /// to the remote side.
2358         pub fn monitor_updating_restored(&mut self) -> (Option<msgs::RevokeAndACK>, Option<msgs::CommitmentUpdate>, RAACommitmentOrder, Vec<(PendingForwardHTLCInfo, u64)>, Vec<(HTLCSource, PaymentHash, HTLCFailReason)>, bool, Option<msgs::FundingLocked>) {
2359                 assert_eq!(self.channel_state & ChannelState::MonitorUpdateFailed as u32, ChannelState::MonitorUpdateFailed as u32);
2360                 self.channel_state &= !(ChannelState::MonitorUpdateFailed as u32);
2361
2362                 let needs_broadcast_safe = self.channel_state & (ChannelState::FundingSent as u32) != 0 && self.channel_outbound;
2363
2364                 // Because we will never generate a FundingBroadcastSafe event when we're in
2365                 // MonitorUpdateFailed, if we assume the user only broadcast the funding transaction when
2366                 // they received the FundingBroadcastSafe event, we can only ever hit
2367                 // monitor_pending_funding_locked when we're an inbound channel which failed to persist the
2368                 // monitor on funding_created, and we even got the funding transaction confirmed before the
2369                 // monitor was persisted.
2370                 let funding_locked = if self.monitor_pending_funding_locked {
2371                         assert!(!self.channel_outbound, "Funding transaction broadcast without FundingBroadcastSafe!");
2372                         self.monitor_pending_funding_locked = false;
2373                         let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2374                         let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2375                         Some(msgs::FundingLocked {
2376                                 channel_id: self.channel_id(),
2377                                 next_per_commitment_point: next_per_commitment_point,
2378                         })
2379                 } else { None };
2380
2381                 let mut forwards = Vec::new();
2382                 mem::swap(&mut forwards, &mut self.monitor_pending_forwards);
2383                 let mut failures = Vec::new();
2384                 mem::swap(&mut failures, &mut self.monitor_pending_failures);
2385
2386                 if self.channel_state & (ChannelState::PeerDisconnected as u32) != 0 {
2387                         self.monitor_pending_revoke_and_ack = false;
2388                         self.monitor_pending_commitment_signed = false;
2389                         return (None, None, RAACommitmentOrder::RevokeAndACKFirst, forwards, failures, needs_broadcast_safe, funding_locked);
2390                 }
2391
2392                 let raa = if self.monitor_pending_revoke_and_ack {
2393                         Some(self.get_last_revoke_and_ack())
2394                 } else { None };
2395                 let commitment_update = if self.monitor_pending_commitment_signed {
2396                         Some(self.get_last_commitment_update())
2397                 } else { None };
2398
2399                 self.monitor_pending_revoke_and_ack = false;
2400                 self.monitor_pending_commitment_signed = false;
2401                 let order = self.resend_order.clone();
2402                 log_trace!(self, "Restored monitor updating resulting in {}{} commitment update and {} RAA, with {} first",
2403                         if needs_broadcast_safe { "a funding broadcast safe, " } else { "" },
2404                         if commitment_update.is_some() { "a" } else { "no" },
2405                         if raa.is_some() { "an" } else { "no" },
2406                         match order { RAACommitmentOrder::CommitmentFirst => "commitment", RAACommitmentOrder::RevokeAndACKFirst => "RAA"});
2407                 (raa, commitment_update, order, forwards, failures, needs_broadcast_safe, funding_locked)
2408         }
2409
2410         pub fn update_fee(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::UpdateFee) -> Result<(), ChannelError> {
2411                 if self.channel_outbound {
2412                         return Err(ChannelError::Close("Non-funding remote tried to update channel fee"));
2413                 }
2414                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2415                         return Err(ChannelError::Close("Peer sent update_fee when we needed a channel_reestablish"));
2416                 }
2417                 Channel::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
2418                 self.pending_update_fee = Some(msg.feerate_per_kw as u64);
2419                 self.channel_update_count += 1;
2420                 Ok(())
2421         }
2422
2423         fn get_last_revoke_and_ack(&self) -> msgs::RevokeAndACK {
2424                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(self.cur_local_commitment_transaction_number));
2425                 let per_commitment_secret = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, self.cur_local_commitment_transaction_number + 2);
2426                 msgs::RevokeAndACK {
2427                         channel_id: self.channel_id,
2428                         per_commitment_secret,
2429                         next_per_commitment_point,
2430                 }
2431         }
2432
2433         fn get_last_commitment_update(&self) -> msgs::CommitmentUpdate {
2434                 let mut update_add_htlcs = Vec::new();
2435                 let mut update_fulfill_htlcs = Vec::new();
2436                 let mut update_fail_htlcs = Vec::new();
2437                 let mut update_fail_malformed_htlcs = Vec::new();
2438
2439                 for htlc in self.pending_outbound_htlcs.iter() {
2440                         if let &OutboundHTLCState::LocalAnnounced(ref onion_packet) = &htlc.state {
2441                                 update_add_htlcs.push(msgs::UpdateAddHTLC {
2442                                         channel_id: self.channel_id(),
2443                                         htlc_id: htlc.htlc_id,
2444                                         amount_msat: htlc.amount_msat,
2445                                         payment_hash: htlc.payment_hash,
2446                                         cltv_expiry: htlc.cltv_expiry,
2447                                         onion_routing_packet: (**onion_packet).clone(),
2448                                 });
2449                         }
2450                 }
2451
2452                 for htlc in self.pending_inbound_htlcs.iter() {
2453                         if let &InboundHTLCState::LocalRemoved(ref reason) = &htlc.state {
2454                                 match reason {
2455                                         &InboundHTLCRemovalReason::FailRelay(ref err_packet) => {
2456                                                 update_fail_htlcs.push(msgs::UpdateFailHTLC {
2457                                                         channel_id: self.channel_id(),
2458                                                         htlc_id: htlc.htlc_id,
2459                                                         reason: err_packet.clone()
2460                                                 });
2461                                         },
2462                                         &InboundHTLCRemovalReason::FailMalformed((ref sha256_of_onion, ref failure_code)) => {
2463                                                 update_fail_malformed_htlcs.push(msgs::UpdateFailMalformedHTLC {
2464                                                         channel_id: self.channel_id(),
2465                                                         htlc_id: htlc.htlc_id,
2466                                                         sha256_of_onion: sha256_of_onion.clone(),
2467                                                         failure_code: failure_code.clone(),
2468                                                 });
2469                                         },
2470                                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
2471                                                 update_fulfill_htlcs.push(msgs::UpdateFulfillHTLC {
2472                                                         channel_id: self.channel_id(),
2473                                                         htlc_id: htlc.htlc_id,
2474                                                         payment_preimage: payment_preimage.clone(),
2475                                                 });
2476                                         },
2477                                 }
2478                         }
2479                 }
2480
2481                 log_trace!(self, "Regenerated latest commitment update with {} update_adds, {} update_fulfills, {} update_fails, and {} update_fail_malformeds",
2482                                 update_add_htlcs.len(), update_fulfill_htlcs.len(), update_fail_htlcs.len(), update_fail_malformed_htlcs.len());
2483                 msgs::CommitmentUpdate {
2484                         update_add_htlcs, update_fulfill_htlcs, update_fail_htlcs, update_fail_malformed_htlcs,
2485                         update_fee: None, //TODO: We need to support re-generating any update_fees in the last commitment_signed!
2486                         commitment_signed: self.send_commitment_no_state_update().expect("It looks like we failed to re-generate a commitment_signed we had previously sent?").0,
2487                 }
2488         }
2489
2490         /// May panic if some calls other than message-handling calls (which will all Err immediately)
2491         /// have been called between remove_uncommitted_htlcs_and_mark_paused and this call.
2492         pub fn channel_reestablish(&mut self, msg: &msgs::ChannelReestablish) -> Result<(Option<msgs::FundingLocked>, Option<msgs::RevokeAndACK>, Option<msgs::CommitmentUpdate>, Option<ChannelMonitor>, RAACommitmentOrder, Option<msgs::Shutdown>), ChannelError> {
2493                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == 0 {
2494                         // While BOLT 2 doesn't indicate explicitly we should error this channel here, it
2495                         // almost certainly indicates we are going to end up out-of-sync in some way, so we
2496                         // just close here instead of trying to recover.
2497                         return Err(ChannelError::Close("Peer sent a loose channel_reestablish not after reconnect"));
2498                 }
2499
2500                 if msg.next_local_commitment_number >= INITIAL_COMMITMENT_NUMBER || msg.next_remote_commitment_number >= INITIAL_COMMITMENT_NUMBER ||
2501                         msg.next_local_commitment_number == 0 {
2502                         return Err(ChannelError::Close("Peer sent a garbage channel_reestablish"));
2503                 }
2504
2505                 // Go ahead and unmark PeerDisconnected as various calls we may make check for it (and all
2506                 // remaining cases either succeed or ErrorMessage-fail).
2507                 self.channel_state &= !(ChannelState::PeerDisconnected as u32);
2508
2509                 let shutdown_msg = if self.channel_state & (ChannelState::LocalShutdownSent as u32) != 0 {
2510                         Some(msgs::Shutdown {
2511                                 channel_id: self.channel_id,
2512                                 scriptpubkey: self.get_closing_scriptpubkey(),
2513                         })
2514                 } else { None };
2515
2516                 if self.channel_state & (ChannelState::FundingSent as u32) == ChannelState::FundingSent as u32 {
2517                         // If we're waiting on a monitor update, we shouldn't re-send any funding_locked's.
2518                         if self.channel_state & (ChannelState::OurFundingLocked as u32) == 0 ||
2519                                         self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
2520                                 if msg.next_remote_commitment_number != 0 {
2521                                         return Err(ChannelError::Close("Peer claimed they saw a revoke_and_ack but we haven't sent funding_locked yet"));
2522                                 }
2523                                 // Short circuit the whole handler as there is nothing we can resend them
2524                                 return Ok((None, None, None, None, RAACommitmentOrder::CommitmentFirst, shutdown_msg));
2525                         }
2526
2527                         // We have OurFundingLocked set!
2528                         let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2529                         let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2530                         return Ok((Some(msgs::FundingLocked {
2531                                 channel_id: self.channel_id(),
2532                                 next_per_commitment_point: next_per_commitment_point,
2533                         }), None, None, None, RAACommitmentOrder::CommitmentFirst, shutdown_msg));
2534                 }
2535
2536                 let required_revoke = if msg.next_remote_commitment_number + 1 == INITIAL_COMMITMENT_NUMBER - self.cur_local_commitment_transaction_number {
2537                         // Remote isn't waiting on any RevokeAndACK from us!
2538                         // Note that if we need to repeat our FundingLocked we'll do that in the next if block.
2539                         None
2540                 } else if msg.next_remote_commitment_number + 1 == (INITIAL_COMMITMENT_NUMBER - 1) - self.cur_local_commitment_transaction_number {
2541                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
2542                                 self.monitor_pending_revoke_and_ack = true;
2543                                 None
2544                         } else {
2545                                 Some(self.get_last_revoke_and_ack())
2546                         }
2547                 } else {
2548                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old local commitment transaction"));
2549                 };
2550
2551                 // We increment cur_remote_commitment_transaction_number only upon receipt of
2552                 // revoke_and_ack, not on sending commitment_signed, so we add one if have
2553                 // AwaitingRemoteRevoke set, which indicates we sent a commitment_signed but haven't gotten
2554                 // the corresponding revoke_and_ack back yet.
2555                 let our_next_remote_commitment_number = INITIAL_COMMITMENT_NUMBER - self.cur_remote_commitment_transaction_number + if (self.channel_state & ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 };
2556
2557                 let resend_funding_locked = if msg.next_local_commitment_number == 1 && INITIAL_COMMITMENT_NUMBER - self.cur_local_commitment_transaction_number == 1 {
2558                         // We should never have to worry about MonitorUpdateFailed resending FundingLocked
2559                         let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
2560                         let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
2561                         Some(msgs::FundingLocked {
2562                                 channel_id: self.channel_id(),
2563                                 next_per_commitment_point: next_per_commitment_point,
2564                         })
2565                 } else { None };
2566
2567                 if msg.next_local_commitment_number == our_next_remote_commitment_number {
2568                         if required_revoke.is_some() {
2569                                 log_debug!(self, "Reconnected channel {} with only lost outbound RAA", log_bytes!(self.channel_id()));
2570                         } else {
2571                                 log_debug!(self, "Reconnected channel {} with no loss", log_bytes!(self.channel_id()));
2572                         }
2573
2574                         if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32 | ChannelState::MonitorUpdateFailed as u32)) == 0 {
2575                                 // We're up-to-date and not waiting on a remote revoke (if we are our
2576                                 // channel_reestablish should result in them sending a revoke_and_ack), but we may
2577                                 // have received some updates while we were disconnected. Free the holding cell
2578                                 // now!
2579                                 match self.free_holding_cell_htlcs() {
2580                                         Err(ChannelError::Close(msg)) => return Err(ChannelError::Close(msg)),
2581                                         Err(ChannelError::Ignore(_)) => panic!("Got non-channel-failing result from free_holding_cell_htlcs"),
2582                                         Ok(Some((commitment_update, channel_monitor))) => return Ok((resend_funding_locked, required_revoke, Some(commitment_update), Some(channel_monitor), self.resend_order.clone(), shutdown_msg)),
2583                                         Ok(None) => return Ok((resend_funding_locked, required_revoke, None, None, self.resend_order.clone(), shutdown_msg)),
2584                                 }
2585                         } else {
2586                                 return Ok((resend_funding_locked, required_revoke, None, None, self.resend_order.clone(), shutdown_msg));
2587                         }
2588                 } else if msg.next_local_commitment_number == our_next_remote_commitment_number - 1 {
2589                         if required_revoke.is_some() {
2590                                 log_debug!(self, "Reconnected channel {} with lost outbound RAA and lost remote commitment tx", log_bytes!(self.channel_id()));
2591                         } else {
2592                                 log_debug!(self, "Reconnected channel {} with only lost remote commitment tx", log_bytes!(self.channel_id()));
2593                         }
2594
2595                         if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) != 0 {
2596                                 self.monitor_pending_commitment_signed = true;
2597                                 return Ok((resend_funding_locked, None, None, None, self.resend_order.clone(), shutdown_msg));
2598                         }
2599
2600                         return Ok((resend_funding_locked, required_revoke, Some(self.get_last_commitment_update()), None, self.resend_order.clone(), shutdown_msg));
2601                 } else {
2602                         return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction"));
2603                 }
2604         }
2605
2606         fn maybe_propose_first_closing_signed(&mut self, fee_estimator: &FeeEstimator) -> Option<msgs::ClosingSigned> {
2607                 if !self.channel_outbound || !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() ||
2608                                 self.channel_state & (BOTH_SIDES_SHUTDOWN_MASK | ChannelState::AwaitingRemoteRevoke as u32) != BOTH_SIDES_SHUTDOWN_MASK ||
2609                                 self.last_sent_closing_fee.is_some() || self.pending_update_fee.is_some() {
2610                         return None;
2611                 }
2612
2613                 let mut proposed_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
2614                 if self.feerate_per_kw > proposed_feerate {
2615                         proposed_feerate = self.feerate_per_kw;
2616                 }
2617                 let tx_weight = Self::get_closing_transaction_weight(&self.get_closing_scriptpubkey(), self.their_shutdown_scriptpubkey.as_ref().unwrap());
2618                 let proposed_total_fee_satoshis = proposed_feerate * tx_weight / 1000;
2619
2620                 let (closing_tx, total_fee_satoshis) = self.build_closing_transaction(proposed_total_fee_satoshis, false);
2621                 let funding_redeemscript = self.get_funding_redeemscript();
2622                 let sighash = hash_to_message!(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]);
2623
2624                 self.last_sent_closing_fee = Some((proposed_feerate, total_fee_satoshis));
2625                 Some(msgs::ClosingSigned {
2626                         channel_id: self.channel_id,
2627                         fee_satoshis: total_fee_satoshis,
2628                         signature: self.secp_ctx.sign(&sighash, &self.local_keys.funding_key),
2629                 })
2630         }
2631
2632         pub fn shutdown(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::Shutdown) -> Result<(Option<msgs::Shutdown>, Option<msgs::ClosingSigned>, Vec<(HTLCSource, PaymentHash)>), ChannelError> {
2633                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2634                         return Err(ChannelError::Close("Peer sent shutdown when we needed a channel_reestablish"));
2635                 }
2636                 if self.channel_state < ChannelState::FundingSent as u32 {
2637                         // Spec says we should fail the connection, not the channel, but that's nonsense, there
2638                         // are plenty of reasons you may want to fail a channel pre-funding, and spec says you
2639                         // can do that via error message without getting a connection fail anyway...
2640                         return Err(ChannelError::Close("Peer sent shutdown pre-funding generation"));
2641                 }
2642                 for htlc in self.pending_inbound_htlcs.iter() {
2643                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
2644                                 return Err(ChannelError::Close("Got shutdown with remote pending HTLCs"));
2645                         }
2646                 }
2647                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
2648
2649                 // BOLT 2 says we must only send a scriptpubkey of certain standard forms, which are up to
2650                 // 34 bytes in length, so don't let the remote peer feed us some super fee-heavy script.
2651                 if self.channel_outbound && msg.scriptpubkey.len() > 34 {
2652                         return Err(ChannelError::Close("Got shutdown_scriptpubkey of absurd length from remote peer"));
2653                 }
2654
2655                 //Check shutdown_scriptpubkey form as BOLT says we must
2656                 if !msg.scriptpubkey.is_p2pkh() && !msg.scriptpubkey.is_p2sh() && !msg.scriptpubkey.is_v0_p2wpkh() && !msg.scriptpubkey.is_v0_p2wsh() {
2657                         return Err(ChannelError::Close("Got a nonstandard scriptpubkey from remote peer"));
2658                 }
2659
2660                 if self.their_shutdown_scriptpubkey.is_some() {
2661                         if Some(&msg.scriptpubkey) != self.their_shutdown_scriptpubkey.as_ref() {
2662                                 return Err(ChannelError::Close("Got shutdown request with a scriptpubkey which did not match their previous scriptpubkey"));
2663                         }
2664                 } else {
2665                         self.their_shutdown_scriptpubkey = Some(msg.scriptpubkey.clone());
2666                 }
2667
2668                 // From here on out, we may not fail!
2669
2670                 self.channel_state |= ChannelState::RemoteShutdownSent as u32;
2671                 self.channel_update_count += 1;
2672
2673                 // We can't send our shutdown until we've committed all of our pending HTLCs, but the
2674                 // remote side is unlikely to accept any new HTLCs, so we go ahead and "free" any holding
2675                 // cell HTLCs and return them to fail the payment.
2676                 self.holding_cell_update_fee = None;
2677                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
2678                 self.holding_cell_htlc_updates.retain(|htlc_update| {
2679                         match htlc_update {
2680                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
2681                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
2682                                         false
2683                                 },
2684                                 _ => true
2685                         }
2686                 });
2687                 // If we have any LocalAnnounced updates we'll probably just get back a update_fail_htlc
2688                 // immediately after the commitment dance, but we can send a Shutdown cause we won't send
2689                 // any further commitment updates after we set LocalShutdownSent.
2690
2691                 let our_shutdown = if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
2692                         None
2693                 } else {
2694                         Some(msgs::Shutdown {
2695                                 channel_id: self.channel_id,
2696                                 scriptpubkey: self.get_closing_scriptpubkey(),
2697                         })
2698                 };
2699
2700                 self.channel_state |= ChannelState::LocalShutdownSent as u32;
2701                 self.channel_update_count += 1;
2702                 Ok((our_shutdown, self.maybe_propose_first_closing_signed(fee_estimator), dropped_outbound_htlcs))
2703         }
2704
2705         pub fn closing_signed(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::ClosingSigned) -> Result<(Option<msgs::ClosingSigned>, Option<Transaction>), ChannelError> {
2706                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != BOTH_SIDES_SHUTDOWN_MASK {
2707                         return Err(ChannelError::Close("Remote end sent us a closing_signed before both sides provided a shutdown"));
2708                 }
2709                 if self.channel_state & (ChannelState::PeerDisconnected as u32) == ChannelState::PeerDisconnected as u32 {
2710                         return Err(ChannelError::Close("Peer sent closing_signed when we needed a channel_reestablish"));
2711                 }
2712                 if !self.pending_inbound_htlcs.is_empty() || !self.pending_outbound_htlcs.is_empty() {
2713                         return Err(ChannelError::Close("Remote end sent us a closing_signed while there were still pending HTLCs"));
2714                 }
2715                 if msg.fee_satoshis > 21000000 * 10000000 { //this is required to stop potential overflow in build_closing_transaction
2716                         return Err(ChannelError::Close("Remote tried to send us a closing tx with > 21 million BTC fee"));
2717                 }
2718
2719                 let funding_redeemscript = self.get_funding_redeemscript();
2720                 let (mut closing_tx, used_total_fee) = self.build_closing_transaction(msg.fee_satoshis, false);
2721                 if used_total_fee != msg.fee_satoshis {
2722                         return Err(ChannelError::Close("Remote sent us a closing_signed with a fee greater than the value they can claim"));
2723                 }
2724                 let mut sighash = hash_to_message!(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]);
2725
2726                 match self.secp_ctx.verify(&sighash, &msg.signature, &self.their_funding_pubkey.unwrap()) {
2727                         Ok(_) => {},
2728                         Err(_e) => {
2729                                 // The remote end may have decided to revoke their output due to inconsistent dust
2730                                 // limits, so check for that case by re-checking the signature here.
2731                                 closing_tx = self.build_closing_transaction(msg.fee_satoshis, true).0;
2732                                 sighash = hash_to_message!(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]);
2733                                 secp_check!(self.secp_ctx.verify(&sighash, &msg.signature, &self.their_funding_pubkey.unwrap()), "Invalid closing tx signature from peer");
2734                         },
2735                 };
2736
2737                 if let Some((_, last_fee)) = self.last_sent_closing_fee {
2738                         if last_fee == msg.fee_satoshis {
2739                                 self.sign_commitment_transaction(&mut closing_tx, &msg.signature);
2740                                 self.channel_state = ChannelState::ShutdownComplete as u32;
2741                                 self.channel_update_count += 1;
2742                                 return Ok((None, Some(closing_tx)));
2743                         }
2744                 }
2745
2746                 macro_rules! propose_new_feerate {
2747                         ($new_feerate: expr) => {
2748                                 let closing_tx_max_weight = Self::get_closing_transaction_weight(&self.get_closing_scriptpubkey(), self.their_shutdown_scriptpubkey.as_ref().unwrap());
2749                                 let (closing_tx, used_total_fee) = self.build_closing_transaction($new_feerate * closing_tx_max_weight / 1000, false);
2750                                 sighash = hash_to_message!(&bip143::SighashComponents::new(&closing_tx).sighash_all(&closing_tx.input[0], &funding_redeemscript, self.channel_value_satoshis)[..]);
2751                                 let our_sig = self.secp_ctx.sign(&sighash, &self.local_keys.funding_key);
2752                                 self.last_sent_closing_fee = Some(($new_feerate, used_total_fee));
2753                                 return Ok((Some(msgs::ClosingSigned {
2754                                         channel_id: self.channel_id,
2755                                         fee_satoshis: used_total_fee,
2756                                         signature: our_sig,
2757                                 }), None))
2758                         }
2759                 }
2760
2761                 let proposed_sat_per_kw = msg.fee_satoshis * 1000 / closing_tx.get_weight();
2762                 if self.channel_outbound {
2763                         let our_max_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal);
2764                         if proposed_sat_per_kw > our_max_feerate {
2765                                 if let Some((last_feerate, _)) = self.last_sent_closing_fee {
2766                                         if our_max_feerate <= last_feerate {
2767                                                 return Err(ChannelError::Close("Unable to come to consensus about closing feerate, remote wanted something higher than our Normal feerate"));
2768                                         }
2769                                 }
2770                                 propose_new_feerate!(our_max_feerate);
2771                         }
2772                 } else {
2773                         let our_min_feerate = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
2774                         if proposed_sat_per_kw < our_min_feerate {
2775                                 if let Some((last_feerate, _)) = self.last_sent_closing_fee {
2776                                         if our_min_feerate >= last_feerate {
2777                                                 return Err(ChannelError::Close("Unable to come to consensus about closing feerate, remote wanted something lower than our Background feerate"));
2778                                         }
2779                                 }
2780                                 propose_new_feerate!(our_min_feerate);
2781                         }
2782                 }
2783
2784                 let our_sig = self.sign_commitment_transaction(&mut closing_tx, &msg.signature);
2785                 self.channel_state = ChannelState::ShutdownComplete as u32;
2786                 self.channel_update_count += 1;
2787
2788                 Ok((Some(msgs::ClosingSigned {
2789                         channel_id: self.channel_id,
2790                         fee_satoshis: msg.fee_satoshis,
2791                         signature: our_sig,
2792                 }), Some(closing_tx)))
2793         }
2794
2795         // Public utilities:
2796
2797         pub fn channel_id(&self) -> [u8; 32] {
2798                 self.channel_id
2799         }
2800
2801         /// Gets the "user_id" value passed into the construction of this channel. It has no special
2802         /// meaning and exists only to allow users to have a persistent identifier of a channel.
2803         pub fn get_user_id(&self) -> u64 {
2804                 self.user_id
2805         }
2806
2807         /// May only be called after funding has been initiated (ie is_funding_initiated() is true)
2808         pub fn channel_monitor(&self) -> ChannelMonitor {
2809                 if self.channel_state < ChannelState::FundingCreated as u32 {
2810                         panic!("Can't get a channel monitor until funding has been created");
2811                 }
2812                 self.channel_monitor.clone()
2813         }
2814
2815         /// Guaranteed to be Some after both FundingLocked messages have been exchanged (and, thus,
2816         /// is_usable() returns true).
2817         /// Allowed in any state (including after shutdown)
2818         pub fn get_short_channel_id(&self) -> Option<u64> {
2819                 self.short_channel_id
2820         }
2821
2822         /// Returns the funding_txo we either got from our peer, or were given by
2823         /// get_outbound_funding_created.
2824         pub fn get_funding_txo(&self) -> Option<OutPoint> {
2825                 self.channel_monitor.get_funding_txo()
2826         }
2827
2828         /// Allowed in any state (including after shutdown)
2829         pub fn get_their_node_id(&self) -> PublicKey {
2830                 self.their_node_id
2831         }
2832
2833         /// Allowed in any state (including after shutdown)
2834         pub fn get_our_htlc_minimum_msat(&self) -> u64 {
2835                 self.our_htlc_minimum_msat
2836         }
2837
2838         /// Allowed in any state (including after shutdown)
2839         pub fn get_their_htlc_minimum_msat(&self) -> u64 {
2840                 self.our_htlc_minimum_msat
2841         }
2842
2843         pub fn get_value_satoshis(&self) -> u64 {
2844                 self.channel_value_satoshis
2845         }
2846
2847         pub fn get_fee_proportional_millionths(&self) -> u32 {
2848                 self.config.fee_proportional_millionths
2849         }
2850
2851         #[cfg(test)]
2852         pub fn get_feerate(&self) -> u64 {
2853                 self.feerate_per_kw
2854         }
2855
2856         pub fn get_cur_local_commitment_transaction_number(&self) -> u64 {
2857                 self.cur_local_commitment_transaction_number + 1
2858         }
2859
2860         pub fn get_cur_remote_commitment_transaction_number(&self) -> u64 {
2861                 self.cur_remote_commitment_transaction_number + 1 - if self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32) != 0 { 1 } else { 0 }
2862         }
2863
2864         pub fn get_revoked_remote_commitment_transaction_number(&self) -> u64 {
2865                 self.cur_remote_commitment_transaction_number + 2
2866         }
2867
2868         //TODO: Testing purpose only, should be changed in another way after #81
2869         #[cfg(test)]
2870         pub fn get_local_keys(&self) -> &ChannelKeys {
2871                 &self.local_keys
2872         }
2873
2874         #[cfg(test)]
2875         pub fn get_value_stat(&self) -> ChannelValueStat {
2876                 ChannelValueStat {
2877                         value_to_self_msat: self.value_to_self_msat,
2878                         channel_value_msat: self.channel_value_satoshis * 1000,
2879                         channel_reserve_msat: self.their_channel_reserve_satoshis * 1000,
2880                         pending_outbound_htlcs_amount_msat: self.pending_outbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
2881                         pending_inbound_htlcs_amount_msat: self.pending_inbound_htlcs.iter().map(|ref h| h.amount_msat).sum::<u64>(),
2882                         holding_cell_outbound_amount_msat: {
2883                                 let mut res = 0;
2884                                 for h in self.holding_cell_htlc_updates.iter() {
2885                                         match h {
2886                                                 &HTLCUpdateAwaitingACK::AddHTLC{amount_msat, .. } => {
2887                                                         res += amount_msat;
2888                                                 }
2889                                                 _ => {}
2890                                         }
2891                                 }
2892                                 res
2893                         },
2894                         their_max_htlc_value_in_flight_msat: self.their_max_htlc_value_in_flight_msat,
2895                 }
2896         }
2897
2898         /// Allowed in any state (including after shutdown)
2899         pub fn get_channel_update_count(&self) -> u32 {
2900                 self.channel_update_count
2901         }
2902
2903         pub fn should_announce(&self) -> bool {
2904                 self.config.announced_channel
2905         }
2906
2907         pub fn is_outbound(&self) -> bool {
2908                 self.channel_outbound
2909         }
2910
2911         /// Gets the fee we'd want to charge for adding an HTLC output to this Channel
2912         /// Allowed in any state (including after shutdown)
2913         pub fn get_our_fee_base_msat(&self, fee_estimator: &FeeEstimator) -> u32 {
2914                 // For lack of a better metric, we calculate what it would cost to consolidate the new HTLC
2915                 // output value back into a transaction with the regular channel output:
2916
2917                 // the fee cost of the HTLC-Success/HTLC-Timeout transaction:
2918                 let mut res = self.feerate_per_kw * cmp::max(HTLC_TIMEOUT_TX_WEIGHT, HTLC_SUCCESS_TX_WEIGHT) / 1000;
2919
2920                 if self.channel_outbound {
2921                         // + the marginal fee increase cost to us in the commitment transaction:
2922                         res += self.feerate_per_kw * COMMITMENT_TX_WEIGHT_PER_HTLC / 1000;
2923                 }
2924
2925                 // + the marginal cost of an input which spends the HTLC-Success/HTLC-Timeout output:
2926                 res += fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Normal) * SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT / 1000;
2927
2928                 res as u32
2929         }
2930
2931         /// Returns true if we've ever received a message from the remote end for this Channel
2932         pub fn have_received_message(&self) -> bool {
2933                 self.channel_state > (ChannelState::OurInitSent as u32)
2934         }
2935
2936         /// Returns true if this channel is fully established and not known to be closing.
2937         /// Allowed in any state (including after shutdown)
2938         pub fn is_usable(&self) -> bool {
2939                 let mask = ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK;
2940                 (self.channel_state & mask) == (ChannelState::ChannelFunded as u32)
2941         }
2942
2943         /// Returns true if this channel is currently available for use. This is a superset of
2944         /// is_usable() and considers things like the channel being temporarily disabled.
2945         /// Allowed in any state (including after shutdown)
2946         pub fn is_live(&self) -> bool {
2947                 self.is_usable() && (self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) == 0)
2948         }
2949
2950         /// Returns true if this channel has been marked as awaiting a monitor update to move forward.
2951         /// Allowed in any state (including after shutdown)
2952         pub fn is_awaiting_monitor_update(&self) -> bool {
2953                 (self.channel_state & ChannelState::MonitorUpdateFailed as u32) != 0
2954         }
2955
2956         /// Returns true if funding_created was sent/received.
2957         pub fn is_funding_initiated(&self) -> bool {
2958                 self.channel_state >= ChannelState::FundingCreated as u32
2959         }
2960
2961         /// Returns true if this channel is fully shut down. True here implies that no further actions
2962         /// may/will be taken on this channel, and thus this object should be freed. Any future changes
2963         /// will be handled appropriately by the chain monitor.
2964         pub fn is_shutdown(&self) -> bool {
2965                 if (self.channel_state & ChannelState::ShutdownComplete as u32) == ChannelState::ShutdownComplete as u32  {
2966                         assert!(self.channel_state == ChannelState::ShutdownComplete as u32);
2967                         true
2968                 } else { false }
2969         }
2970
2971         /// Called by channelmanager based on chain blocks being connected.
2972         /// Note that we only need to use this to detect funding_signed, anything else is handled by
2973         /// the channel_monitor.
2974         /// In case of Err, the channel may have been closed, at which point the standard requirements
2975         /// apply - no calls may be made except those explicitly stated to be allowed post-shutdown.
2976         /// Only returns an ErrorAction of DisconnectPeer, if Err.
2977         pub fn block_connected(&mut self, header: &BlockHeader, height: u32, txn_matched: &[&Transaction], indexes_of_txn_matched: &[u32]) -> Result<Option<msgs::FundingLocked>, msgs::ErrorMessage> {
2978                 let non_shutdown_state = self.channel_state & (!MULTI_STATE_FLAGS);
2979                 if header.bitcoin_hash() != self.last_block_connected {
2980                         self.last_block_connected = header.bitcoin_hash();
2981                         self.channel_monitor.last_block_hash = self.last_block_connected;
2982                         if self.funding_tx_confirmations > 0 {
2983                                 self.funding_tx_confirmations += 1;
2984                                 if self.funding_tx_confirmations == self.minimum_depth as u64 {
2985                                         let need_commitment_update = if non_shutdown_state == ChannelState::FundingSent as u32 {
2986                                                 self.channel_state |= ChannelState::OurFundingLocked as u32;
2987                                                 true
2988                                         } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) {
2989                                                 self.channel_state = ChannelState::ChannelFunded as u32 | (self.channel_state & MULTI_STATE_FLAGS);
2990                                                 self.channel_update_count += 1;
2991                                                 true
2992                                         } else if non_shutdown_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
2993                                                 // We got a reorg but not enough to trigger a force close, just update
2994                                                 // funding_tx_confirmed_in and return.
2995                                                 false
2996                                         } else if self.channel_state < ChannelState::ChannelFunded as u32 {
2997                                                 panic!("Started confirming a channel in a state pre-FundingSent?: {}", self.channel_state);
2998                                         } else {
2999                                                 // We got a reorg but not enough to trigger a force close, just update
3000                                                 // funding_tx_confirmed_in and return.
3001                                                 false
3002                                         };
3003                                         self.funding_tx_confirmed_in = Some(header.bitcoin_hash());
3004
3005                                         //TODO: Note that this must be a duplicate of the previous commitment point they sent us,
3006                                         //as otherwise we will have a commitment transaction that they can't revoke (well, kinda,
3007                                         //they can by sending two revoke_and_acks back-to-back, but not really). This appears to be
3008                                         //a protocol oversight, but I assume I'm just missing something.
3009                                         if need_commitment_update {
3010                                                 if self.channel_state & (ChannelState::MonitorUpdateFailed as u32) == 0 {
3011                                                         let next_per_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
3012                                                         let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret);
3013                                                         return Ok(Some(msgs::FundingLocked {
3014                                                                 channel_id: self.channel_id,
3015                                                                 next_per_commitment_point: next_per_commitment_point,
3016                                                         }));
3017                                                 } else {
3018                                                         self.monitor_pending_funding_locked = true;
3019                                                         return Ok(None);
3020                                                 }
3021                                         }
3022                                 }
3023                         }
3024                 }
3025                 if non_shutdown_state & !(ChannelState::TheirFundingLocked as u32) == ChannelState::FundingSent as u32 {
3026                         for (ref tx, index_in_block) in txn_matched.iter().zip(indexes_of_txn_matched) {
3027                                 if tx.txid() == self.channel_monitor.get_funding_txo().unwrap().txid {
3028                                         let txo_idx = self.channel_monitor.get_funding_txo().unwrap().index as usize;
3029                                         if txo_idx >= tx.output.len() || tx.output[txo_idx].script_pubkey != self.get_funding_redeemscript().to_v0_p2wsh() ||
3030                                                         tx.output[txo_idx].value != self.channel_value_satoshis {
3031                                                 if self.channel_outbound {
3032                                                         // If we generated the funding transaction and it doesn't match what it
3033                                                         // should, the client is really broken and we should just panic and
3034                                                         // tell them off. That said, because hash collisions happen with high
3035                                                         // probability in fuzztarget mode, if we're fuzzing we just close the
3036                                                         // channel and move on.
3037                                                         #[cfg(not(feature = "fuzztarget"))]
3038                                                         panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
3039                                                 }
3040                                                 self.channel_state = ChannelState::ShutdownComplete as u32;
3041                                                 self.channel_update_count += 1;
3042                                                 return Err(msgs::ErrorMessage {
3043                                                         channel_id: self.channel_id(),
3044                                                         data: "funding tx had wrong script/value".to_owned()
3045                                                 });
3046                                         } else {
3047                                                 if self.channel_outbound {
3048                                                         for input in tx.input.iter() {
3049                                                                 if input.witness.is_empty() {
3050                                                                         // We generated a malleable funding transaction, implying we've
3051                                                                         // just exposed ourselves to funds loss to our counterparty.
3052                                                                         #[cfg(not(feature = "fuzztarget"))]
3053                                                                         panic!("Client called ChannelManager::funding_transaction_generated with bogus transaction!");
3054                                                                 }
3055                                                         }
3056                                                 }
3057                                                 self.funding_tx_confirmations = 1;
3058                                                 self.short_channel_id = Some(((height as u64)          << (5*8)) |
3059                                                                              ((*index_in_block as u64) << (2*8)) |
3060                                                                              ((txo_idx as u64)         << (0*8)));
3061                                         }
3062                                 }
3063                         }
3064                 }
3065                 Ok(None)
3066         }
3067
3068         /// Called by channelmanager based on chain blocks being disconnected.
3069         /// Returns true if we need to close the channel now due to funding transaction
3070         /// unconfirmation/reorg.
3071         pub fn block_disconnected(&mut self, header: &BlockHeader) -> bool {
3072                 if self.funding_tx_confirmations > 0 {
3073                         self.funding_tx_confirmations -= 1;
3074                         if self.funding_tx_confirmations == UNCONF_THRESHOLD as u64 {
3075                                 return true;
3076                         }
3077                 }
3078                 if Some(header.bitcoin_hash()) == self.funding_tx_confirmed_in {
3079                         self.funding_tx_confirmations = self.minimum_depth as u64 - 1;
3080                 }
3081                 self.last_block_connected = header.bitcoin_hash();
3082                 self.channel_monitor.last_block_hash = self.last_block_connected;
3083                 false
3084         }
3085
3086         // Methods to get unprompted messages to send to the remote end (or where we already returned
3087         // something in the handler for the message that prompted this message):
3088
3089         pub fn get_open_channel(&self, chain_hash: Sha256dHash, fee_estimator: &FeeEstimator) -> msgs::OpenChannel {
3090                 if !self.channel_outbound {
3091                         panic!("Tried to open a channel for an inbound channel?");
3092                 }
3093                 if self.channel_state != ChannelState::OurInitSent as u32 {
3094                         panic!("Cannot generate an open_channel after we've moved forward");
3095                 }
3096
3097                 if self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
3098                         panic!("Tried to send an open_channel for a channel that has already advanced");
3099                 }
3100
3101                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
3102
3103                 msgs::OpenChannel {
3104                         chain_hash: chain_hash,
3105                         temporary_channel_id: self.channel_id,
3106                         funding_satoshis: self.channel_value_satoshis,
3107                         push_msat: self.channel_value_satoshis * 1000 - self.value_to_self_msat,
3108                         dust_limit_satoshis: self.our_dust_limit_satoshis,
3109                         max_htlc_value_in_flight_msat: Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
3110                         channel_reserve_satoshis: Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
3111                         htlc_minimum_msat: self.our_htlc_minimum_msat,
3112                         feerate_per_kw: fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background) as u32,
3113                         to_self_delay: self.our_to_self_delay,
3114                         max_accepted_htlcs: OUR_MAX_HTLCS,
3115                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key),
3116                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key),
3117                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key),
3118                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key),
3119                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key),
3120                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret),
3121                         channel_flags: if self.config.announced_channel {1} else {0},
3122                         shutdown_scriptpubkey: OptionalField::Present(if self.config.commit_upfront_shutdown_pubkey { self.get_closing_scriptpubkey() } else { Builder::new().into_script() })
3123                 }
3124         }
3125
3126         pub fn get_accept_channel(&self) -> msgs::AcceptChannel {
3127                 if self.channel_outbound {
3128                         panic!("Tried to send accept_channel for an outbound channel?");
3129                 }
3130                 if self.channel_state != (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32) {
3131                         panic!("Tried to send accept_channel after channel had moved forward");
3132                 }
3133                 if self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
3134                         panic!("Tried to send an accept_channel for a channel that has already advanced");
3135                 }
3136
3137                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number);
3138
3139                 msgs::AcceptChannel {
3140                         temporary_channel_id: self.channel_id,
3141                         dust_limit_satoshis: self.our_dust_limit_satoshis,
3142                         max_htlc_value_in_flight_msat: Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
3143                         channel_reserve_satoshis: Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
3144                         htlc_minimum_msat: self.our_htlc_minimum_msat,
3145                         minimum_depth: self.minimum_depth,
3146                         to_self_delay: self.our_to_self_delay,
3147                         max_accepted_htlcs: OUR_MAX_HTLCS,
3148                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key),
3149                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key),
3150                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key),
3151                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key),
3152                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key),
3153                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret),
3154                         shutdown_scriptpubkey: OptionalField::Present(if self.config.commit_upfront_shutdown_pubkey { self.get_closing_scriptpubkey() } else { Builder::new().into_script() })
3155                 }
3156         }
3157
3158         /// If an Err is returned, it is a ChannelError::Close (for get_outbound_funding_created)
3159         fn get_outbound_funding_created_signature(&mut self) -> Result<(Signature, Transaction), ChannelError> {
3160                 let funding_script = self.get_funding_redeemscript();
3161
3162                 let remote_keys = self.build_remote_transaction_keys()?;
3163                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false, self.feerate_per_kw).0;
3164                 let remote_sighash = hash_to_message!(&bip143::SighashComponents::new(&remote_initial_commitment_tx).sighash_all(&remote_initial_commitment_tx.input[0], &funding_script, self.channel_value_satoshis)[..]);
3165
3166                 // We sign the "remote" commitment transaction, allowing them to broadcast the tx if they wish.
3167                 Ok((self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key), remote_initial_commitment_tx))
3168         }
3169
3170         /// Updates channel state with knowledge of the funding transaction's txid/index, and generates
3171         /// a funding_created message for the remote peer.
3172         /// Panics if called at some time other than immediately after initial handshake, if called twice,
3173         /// or if called on an inbound channel.
3174         /// Note that channel_id changes during this call!
3175         /// Do NOT broadcast the funding transaction until after a successful funding_signed call!
3176         /// If an Err is returned, it is a ChannelError::Close.
3177         pub fn get_outbound_funding_created(&mut self, funding_txo: OutPoint) -> Result<(msgs::FundingCreated, ChannelMonitor), ChannelError> {
3178                 if !self.channel_outbound {
3179                         panic!("Tried to create outbound funding_created message on an inbound channel!");
3180                 }
3181                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
3182                         panic!("Tried to get a funding_created messsage at a time other than immediately after initial handshake completion (or tried to get funding_created twice)");
3183                 }
3184                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) ||
3185                                 self.cur_remote_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER ||
3186                                 self.cur_local_commitment_transaction_number != INITIAL_COMMITMENT_NUMBER {
3187                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
3188                 }
3189
3190                 let funding_txo_script = self.get_funding_redeemscript().to_v0_p2wsh();
3191                 self.channel_monitor.set_funding_info((funding_txo, funding_txo_script));
3192
3193                 let (our_signature, commitment_tx) = match self.get_outbound_funding_created_signature() {
3194                         Ok(res) => res,
3195                         Err(e) => {
3196                                 log_error!(self, "Got bad signatures: {:?}!", e);
3197                                 self.channel_monitor.unset_funding_info();
3198                                 return Err(e);
3199                         }
3200                 };
3201
3202                 let temporary_channel_id = self.channel_id;
3203
3204                 // Now that we're past error-generating stuff, update our local state:
3205                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&commitment_tx, Vec::new(), self.cur_remote_commitment_transaction_number, self.their_cur_commitment_point.unwrap());
3206                 self.channel_state = ChannelState::FundingCreated as u32;
3207                 self.channel_id = funding_txo.to_channel_id();
3208                 self.cur_remote_commitment_transaction_number -= 1;
3209
3210                 Ok((msgs::FundingCreated {
3211                         temporary_channel_id: temporary_channel_id,
3212                         funding_txid: funding_txo.txid,
3213                         funding_output_index: funding_txo.index,
3214                         signature: our_signature
3215                 }, self.channel_monitor.clone()))
3216         }
3217
3218         /// Gets an UnsignedChannelAnnouncement, as well as a signature covering it using our
3219         /// bitcoin_key, if available, for this channel. The channel must be publicly announceable and
3220         /// available for use (have exchanged FundingLocked messages in both directions). Should be used
3221         /// for both loose and in response to an AnnouncementSignatures message from the remote peer.
3222         /// Will only fail if we're not in a state where channel_announcement may be sent (including
3223         /// closing).
3224         /// Note that the "channel must be funded" requirement is stricter than BOLT 7 requires - see
3225         /// https://github.com/lightningnetwork/lightning-rfc/issues/468
3226         pub fn get_channel_announcement(&self, our_node_id: PublicKey, chain_hash: Sha256dHash) -> Result<(msgs::UnsignedChannelAnnouncement, Signature), ChannelError> {
3227                 if !self.config.announced_channel {
3228                         return Err(ChannelError::Ignore("Channel is not available for public announcements"));
3229                 }
3230                 if self.channel_state & (ChannelState::ChannelFunded as u32) == 0 {
3231                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement until the channel funding has been locked"));
3232                 }
3233                 if (self.channel_state & (ChannelState::LocalShutdownSent as u32 | ChannelState::ShutdownComplete as u32)) != 0 {
3234                         return Err(ChannelError::Ignore("Cannot get a ChannelAnnouncement once the channel is closing"));
3235                 }
3236
3237                 let were_node_one = our_node_id.serialize()[..] < self.their_node_id.serialize()[..];
3238                 let our_bitcoin_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key);
3239
3240                 let msg = msgs::UnsignedChannelAnnouncement {
3241                         features: msgs::GlobalFeatures::new(),
3242                         chain_hash: chain_hash,
3243                         short_channel_id: self.get_short_channel_id().unwrap(),
3244                         node_id_1: if were_node_one { our_node_id } else { self.get_their_node_id() },
3245                         node_id_2: if were_node_one { self.get_their_node_id() } else { our_node_id },
3246                         bitcoin_key_1: if were_node_one { our_bitcoin_key } else { self.their_funding_pubkey.unwrap() },
3247                         bitcoin_key_2: if were_node_one { self.their_funding_pubkey.unwrap() } else { our_bitcoin_key },
3248                         excess_data: Vec::new(),
3249                 };
3250
3251                 let msghash = hash_to_message!(&Sha256dHash::hash(&msg.encode()[..])[..]);
3252                 let sig = self.secp_ctx.sign(&msghash, &self.local_keys.funding_key);
3253
3254                 Ok((msg, sig))
3255         }
3256
3257         /// May panic if called on a channel that wasn't immediately-previously
3258         /// self.remove_uncommitted_htlcs_and_mark_paused()'d
3259         pub fn get_channel_reestablish(&self) -> msgs::ChannelReestablish {
3260                 assert_eq!(self.channel_state & ChannelState::PeerDisconnected as u32, ChannelState::PeerDisconnected as u32);
3261                 assert_ne!(self.cur_remote_commitment_transaction_number, INITIAL_COMMITMENT_NUMBER);
3262                 msgs::ChannelReestablish {
3263                         channel_id: self.channel_id(),
3264                         // The protocol has two different commitment number concepts - the "commitment
3265                         // transaction number", which starts from 0 and counts up, and the "revocation key
3266                         // index" which starts at INITIAL_COMMITMENT_NUMBER and counts down. We track
3267                         // commitment transaction numbers by the index which will be used to reveal the
3268                         // revocation key for that commitment transaction, which means we have to convert them
3269                         // to protocol-level commitment numbers here...
3270
3271                         // next_local_commitment_number is the next commitment_signed number we expect to
3272                         // receive (indicating if they need to resend one that we missed).
3273                         next_local_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_local_commitment_transaction_number,
3274                         // We have to set next_remote_commitment_number to the next revoke_and_ack we expect to
3275                         // receive, however we track it by the next commitment number for a remote transaction
3276                         // (which is one further, as they always revoke previous commitment transaction, not
3277                         // the one we send) so we have to decrement by 1. Note that if
3278                         // cur_remote_commitment_transaction_number is INITIAL_COMMITMENT_NUMBER we will have
3279                         // dropped this channel on disconnect as it hasn't yet reached FundingSent so we can't
3280                         // overflow here.
3281                         next_remote_commitment_number: INITIAL_COMMITMENT_NUMBER - self.cur_remote_commitment_transaction_number - 1,
3282                         data_loss_protect: OptionalField::Absent,
3283                 }
3284         }
3285
3286
3287         // Send stuff to our remote peers:
3288
3289         /// Adds a pending outbound HTLC to this channel, note that you probably want
3290         /// send_htlc_and_commit instead cause you'll want both messages at once.
3291         /// This returns an option instead of a pure UpdateAddHTLC as we may be in a state where we are
3292         /// waiting on the remote peer to send us a revoke_and_ack during which time we cannot add new
3293         /// HTLCs on the wire or we wouldn't be able to determine what they actually ACK'ed.
3294         /// You MUST call send_commitment prior to any other calls on this Channel
3295         /// If an Err is returned, it's a ChannelError::Ignore!
3296         pub fn send_htlc(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket) -> Result<Option<msgs::UpdateAddHTLC>, ChannelError> {
3297                 if (self.channel_state & (ChannelState::ChannelFunded as u32 | BOTH_SIDES_SHUTDOWN_MASK)) != (ChannelState::ChannelFunded as u32) {
3298                         return Err(ChannelError::Ignore("Cannot send HTLC until channel is fully established and we haven't started shutting down"));
3299                 }
3300
3301                 if amount_msat > self.channel_value_satoshis * 1000 {
3302                         return Err(ChannelError::Ignore("Cannot send more than the total value of the channel"));
3303                 }
3304                 if amount_msat < self.their_htlc_minimum_msat {
3305                         return Err(ChannelError::Ignore("Cannot send less than their minimum HTLC value"));
3306                 }
3307
3308                 if (self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32)) != 0 {
3309                         // Note that this should never really happen, if we're !is_live() on receipt of an
3310                         // incoming HTLC for relay will result in us rejecting the HTLC and we won't allow
3311                         // the user to send directly into a !is_live() channel. However, if we
3312                         // disconnected during the time the previous hop was doing the commitment dance we may
3313                         // end up getting here after the forwarding delay. In any case, returning an
3314                         // IgnoreError will get ChannelManager to do the right thing and fail backwards now.
3315                         return Err(ChannelError::Ignore("Cannot send an HTLC while disconnected/frozen for channel monitor update"));
3316                 }
3317
3318                 let (outbound_htlc_count, htlc_outbound_value_msat) = self.get_outbound_pending_htlc_stats();
3319                 if outbound_htlc_count + 1 > self.their_max_accepted_htlcs as u32 {
3320                         return Err(ChannelError::Ignore("Cannot push more than their max accepted HTLCs"));
3321                 }
3322                 //TODO: Spec is unclear if this is per-direction or in total (I assume per direction):
3323                 // Check their_max_htlc_value_in_flight_msat
3324                 if htlc_outbound_value_msat + amount_msat > self.their_max_htlc_value_in_flight_msat {
3325                         return Err(ChannelError::Ignore("Cannot send value that would put us over the max HTLC value in flight"));
3326                 }
3327
3328                 // Check self.their_channel_reserve_satoshis (the amount we must keep as
3329                 // reserve for them to have something to claim if we misbehave)
3330                 if self.value_to_self_msat < self.their_channel_reserve_satoshis * 1000 + amount_msat + htlc_outbound_value_msat {
3331                         return Err(ChannelError::Ignore("Cannot send value that would put us over the reserve value"));
3332                 }
3333
3334                 //TODO: Check cltv_expiry? Do this in channel manager?
3335
3336                 // Now update local state:
3337                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
3338                         self.holding_cell_htlc_updates.push(HTLCUpdateAwaitingACK::AddHTLC {
3339                                 amount_msat: amount_msat,
3340                                 payment_hash: payment_hash,
3341                                 cltv_expiry: cltv_expiry,
3342                                 source,
3343                                 onion_routing_packet: onion_routing_packet,
3344                         });
3345                         return Ok(None);
3346                 }
3347
3348                 self.pending_outbound_htlcs.push(OutboundHTLCOutput {
3349                         htlc_id: self.next_local_htlc_id,
3350                         amount_msat: amount_msat,
3351                         payment_hash: payment_hash.clone(),
3352                         cltv_expiry: cltv_expiry,
3353                         state: OutboundHTLCState::LocalAnnounced(Box::new(onion_routing_packet.clone())),
3354                         source,
3355                 });
3356
3357                 let res = msgs::UpdateAddHTLC {
3358                         channel_id: self.channel_id,
3359                         htlc_id: self.next_local_htlc_id,
3360                         amount_msat: amount_msat,
3361                         payment_hash: payment_hash,
3362                         cltv_expiry: cltv_expiry,
3363                         onion_routing_packet: onion_routing_packet,
3364                 };
3365                 self.next_local_htlc_id += 1;
3366
3367                 Ok(Some(res))
3368         }
3369
3370         /// Creates a signed commitment transaction to send to the remote peer.
3371         /// Always returns a ChannelError::Close if an immediately-preceding (read: the
3372         /// last call to this Channel) send_htlc returned Ok(Some(_)) and there is an Err.
3373         /// May panic if called except immediately after a successful, Ok(Some(_))-returning send_htlc.
3374         pub fn send_commitment(&mut self) -> Result<(msgs::CommitmentSigned, ChannelMonitor), ChannelError> {
3375                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
3376                         panic!("Cannot create commitment tx until channel is fully established");
3377                 }
3378                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
3379                         panic!("Cannot create commitment tx until remote revokes their previous commitment");
3380                 }
3381                 if (self.channel_state & (ChannelState::PeerDisconnected as u32)) == (ChannelState::PeerDisconnected as u32) {
3382                         panic!("Cannot create commitment tx while disconnected, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
3383                 }
3384                 if (self.channel_state & (ChannelState::MonitorUpdateFailed as u32)) == (ChannelState::MonitorUpdateFailed as u32) {
3385                         panic!("Cannot create commitment tx while awaiting monitor update unfreeze, as send_htlc will have returned an Err so a send_commitment precondition has been violated");
3386                 }
3387                 let mut have_updates = self.pending_update_fee.is_some();
3388                 for htlc in self.pending_outbound_htlcs.iter() {
3389                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
3390                                 have_updates = true;
3391                         }
3392                         if have_updates { break; }
3393                 }
3394                 for htlc in self.pending_inbound_htlcs.iter() {
3395                         if let InboundHTLCState::LocalRemoved(_) = htlc.state {
3396                                 have_updates = true;
3397                         }
3398                         if have_updates { break; }
3399                 }
3400                 if !have_updates {
3401                         panic!("Cannot create commitment tx until we have some updates to send");
3402                 }
3403                 self.send_commitment_no_status_check()
3404         }
3405         /// Only fails in case of bad keys
3406         fn send_commitment_no_status_check(&mut self) -> Result<(msgs::CommitmentSigned, ChannelMonitor), ChannelError> {
3407                 // We can upgrade the status of some HTLCs that are waiting on a commitment, even if we
3408                 // fail to generate this, we still are at least at a position where upgrading their status
3409                 // is acceptable.
3410                 for htlc in self.pending_inbound_htlcs.iter_mut() {
3411                         let new_state = if let &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref forward_info) = &htlc.state {
3412                                 Some(InboundHTLCState::AwaitingAnnouncedRemoteRevoke(forward_info.clone()))
3413                         } else { None };
3414                         if let Some(state) = new_state {
3415                                 htlc.state = state;
3416                         }
3417                 }
3418                 for htlc in self.pending_outbound_htlcs.iter_mut() {
3419                         if let Some(fail_reason) = if let &mut OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref mut fail_reason) = &mut htlc.state {
3420                                 Some(fail_reason.take())
3421                         } else { None } {
3422                                 htlc.state = OutboundHTLCState::AwaitingRemovedRemoteRevoke(fail_reason);
3423                         }
3424                 }
3425                 self.resend_order = RAACommitmentOrder::RevokeAndACKFirst;
3426
3427                 let (res, remote_commitment_tx, htlcs) = match self.send_commitment_no_state_update() {
3428                         Ok((res, (remote_commitment_tx, mut htlcs))) => {
3429                                 // Update state now that we've passed all the can-fail calls...
3430                                 let htlcs_no_ref = htlcs.drain(..).map(|(htlc, htlc_source)| (htlc, htlc_source.map(|source_ref| Box::new(source_ref.clone())))).collect();
3431                                 (res, remote_commitment_tx, htlcs_no_ref)
3432                         },
3433                         Err(e) => return Err(e),
3434                 };
3435
3436                 self.channel_monitor.provide_latest_remote_commitment_tx_info(&remote_commitment_tx, htlcs, self.cur_remote_commitment_transaction_number, self.their_cur_commitment_point.unwrap());
3437                 self.channel_state |= ChannelState::AwaitingRemoteRevoke as u32;
3438                 Ok((res, self.channel_monitor.clone()))
3439         }
3440
3441         /// Only fails in case of bad keys. Used for channel_reestablish commitment_signed generation
3442         /// when we shouldn't change HTLC/channel state.
3443         fn send_commitment_no_state_update(&self) -> Result<(msgs::CommitmentSigned, (Transaction, Vec<(HTLCOutputInCommitment, Option<&HTLCSource>)>)), ChannelError> {
3444                 let funding_script = self.get_funding_redeemscript();
3445
3446                 let mut feerate_per_kw = self.feerate_per_kw;
3447                 if let Some(feerate) = self.pending_update_fee {
3448                         if self.channel_outbound {
3449                                 feerate_per_kw = feerate;
3450                         }
3451                 }
3452
3453                 let remote_keys = self.build_remote_transaction_keys()?;
3454                 let remote_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, true, feerate_per_kw);
3455                 let remote_commitment_txid = remote_commitment_tx.0.txid();
3456                 let remote_sighash = hash_to_message!(&bip143::SighashComponents::new(&remote_commitment_tx.0).sighash_all(&remote_commitment_tx.0.input[0], &funding_script, self.channel_value_satoshis)[..]);
3457                 let our_sig = self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key);
3458                 log_trace!(self, "Signing remote commitment tx {} with redeemscript {} with pubkey {} -> {}", encode::serialize_hex(&remote_commitment_tx.0), encode::serialize_hex(&funding_script), log_bytes!(PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).serialize()), log_bytes!(our_sig.serialize_compact()[..]));
3459
3460                 let mut htlc_sigs = Vec::with_capacity(remote_commitment_tx.1);
3461                 for &(ref htlc, _) in remote_commitment_tx.2.iter() {
3462                         if let Some(_) = htlc.transaction_output_index {
3463                                 let htlc_tx = self.build_htlc_transaction(&remote_commitment_txid, htlc, false, &remote_keys, feerate_per_kw);
3464                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &remote_keys);
3465                                 let htlc_sighash = hash_to_message!(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]);
3466                                 let our_htlc_key = secp_check!(chan_utils::derive_private_key(&self.secp_ctx, &remote_keys.per_commitment_point, &self.local_keys.htlc_base_key), "Derived invalid key, peer is maliciously selecting parameters");
3467                                 htlc_sigs.push(self.secp_ctx.sign(&htlc_sighash, &our_htlc_key));
3468                                 log_trace!(self, "Signing remote HTLC tx {} with redeemscript {} with pubkey {} -> {}", encode::serialize_hex(&htlc_tx), encode::serialize_hex(&htlc_redeemscript), log_bytes!(PublicKey::from_secret_key(&self.secp_ctx, &our_htlc_key).serialize()), log_bytes!(htlc_sigs.last().unwrap().serialize_compact()[..]));
3469                         }
3470                 }
3471
3472                 Ok((msgs::CommitmentSigned {
3473                         channel_id: self.channel_id,
3474                         signature: our_sig,
3475                         htlc_signatures: htlc_sigs,
3476                 }, (remote_commitment_tx.0, remote_commitment_tx.2)))
3477         }
3478
3479         /// Adds a pending outbound HTLC to this channel, and creates a signed commitment transaction
3480         /// to send to the remote peer in one go.
3481         /// Shorthand for calling send_htlc() followed by send_commitment(), see docs on those for
3482         /// more info.
3483         pub fn send_htlc_and_commit(&mut self, amount_msat: u64, payment_hash: PaymentHash, cltv_expiry: u32, source: HTLCSource, onion_routing_packet: msgs::OnionPacket) -> Result<Option<(msgs::UpdateAddHTLC, msgs::CommitmentSigned, ChannelMonitor)>, ChannelError> {
3484                 match self.send_htlc(amount_msat, payment_hash, cltv_expiry, source, onion_routing_packet)? {
3485                         Some(update_add_htlc) => {
3486                                 let (commitment_signed, monitor_update) = self.send_commitment_no_status_check()?;
3487                                 Ok(Some((update_add_htlc, commitment_signed, monitor_update)))
3488                         },
3489                         None => Ok(None)
3490                 }
3491         }
3492
3493         /// Begins the shutdown process, getting a message for the remote peer and returning all
3494         /// holding cell HTLCs for payment failure.
3495         pub fn get_shutdown(&mut self) -> Result<(msgs::Shutdown, Vec<(HTLCSource, PaymentHash)>), APIError> {
3496                 for htlc in self.pending_outbound_htlcs.iter() {
3497                         if let OutboundHTLCState::LocalAnnounced(_) = htlc.state {
3498                                 return Err(APIError::APIMisuseError{err: "Cannot begin shutdown with pending HTLCs. Process pending events first"});
3499                         }
3500                 }
3501                 if self.channel_state & BOTH_SIDES_SHUTDOWN_MASK != 0 {
3502                         if (self.channel_state & ChannelState::LocalShutdownSent as u32) == ChannelState::LocalShutdownSent as u32 {
3503                                 return Err(APIError::APIMisuseError{err: "Shutdown already in progress"});
3504                         }
3505                         else if (self.channel_state & ChannelState::RemoteShutdownSent as u32) == ChannelState::RemoteShutdownSent as u32 {
3506                                 return Err(APIError::ChannelUnavailable{err: "Shutdown already in progress by remote"});
3507                         }
3508                 }
3509                 assert_eq!(self.channel_state & ChannelState::ShutdownComplete as u32, 0);
3510                 if self.channel_state & (ChannelState::PeerDisconnected as u32 | ChannelState::MonitorUpdateFailed as u32) != 0 {
3511                         return Err(APIError::ChannelUnavailable{err: "Cannot begin shutdown while peer is disconnected or we're waiting on a monitor update, maybe force-close instead?"});
3512                 }
3513
3514                 let our_closing_script = self.get_closing_scriptpubkey();
3515
3516                 // From here on out, we may not fail!
3517                 if self.channel_state < ChannelState::FundingSent as u32 {
3518                         self.channel_state = ChannelState::ShutdownComplete as u32;
3519                 } else {
3520                         self.channel_state |= ChannelState::LocalShutdownSent as u32;
3521                 }
3522                 self.channel_update_count += 1;
3523
3524                 // Go ahead and drop holding cell updates as we'd rather fail payments than wait to send
3525                 // our shutdown until we've committed all of the pending changes.
3526                 self.holding_cell_update_fee = None;
3527                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
3528                 self.holding_cell_htlc_updates.retain(|htlc_update| {
3529                         match htlc_update {
3530                                 &HTLCUpdateAwaitingACK::AddHTLC { ref payment_hash, ref source, .. } => {
3531                                         dropped_outbound_htlcs.push((source.clone(), payment_hash.clone()));
3532                                         false
3533                                 },
3534                                 _ => true
3535                         }
3536                 });
3537
3538                 Ok((msgs::Shutdown {
3539                         channel_id: self.channel_id,
3540                         scriptpubkey: our_closing_script,
3541                 }, dropped_outbound_htlcs))
3542         }
3543
3544         /// Gets the latest commitment transaction and any dependent transactions for relay (forcing
3545         /// shutdown of this channel - no more calls into this Channel may be made afterwards except
3546         /// those explicitly stated to be allowed after shutdown completes, eg some simple getters).
3547         /// Also returns the list of payment_hashes for channels which we can safely fail backwards
3548         /// immediately (others we will have to allow to time out).
3549         pub fn force_shutdown(&mut self) -> (Vec<Transaction>, Vec<(HTLCSource, PaymentHash)>) {
3550                 assert!(self.channel_state != ChannelState::ShutdownComplete as u32);
3551
3552                 // We go ahead and "free" any holding cell HTLCs or HTLCs we haven't yet committed to and
3553                 // return them to fail the payment.
3554                 let mut dropped_outbound_htlcs = Vec::with_capacity(self.holding_cell_htlc_updates.len());
3555                 for htlc_update in self.holding_cell_htlc_updates.drain(..) {
3556                         match htlc_update {
3557                                 HTLCUpdateAwaitingACK::AddHTLC { source, payment_hash, .. } => {
3558                                         dropped_outbound_htlcs.push((source, payment_hash));
3559                                 },
3560                                 _ => {}
3561                         }
3562                 }
3563
3564                 for _htlc in self.pending_outbound_htlcs.drain(..) {
3565                         //TODO: Do something with the remaining HTLCs
3566                         //(we need to have the ChannelManager monitor them so we can claim the inbound HTLCs
3567                         //which correspond)
3568                 }
3569
3570                 self.channel_state = ChannelState::ShutdownComplete as u32;
3571                 self.channel_update_count += 1;
3572                 let mut res = Vec::new();
3573                 mem::swap(&mut res, &mut self.last_local_commitment_txn);
3574                 (res, dropped_outbound_htlcs)
3575         }
3576 }
3577
3578 const SERIALIZATION_VERSION: u8 = 1;
3579 const MIN_SERIALIZATION_VERSION: u8 = 1;
3580
3581 impl Writeable for InboundHTLCRemovalReason {
3582         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
3583                 match self {
3584                         &InboundHTLCRemovalReason::FailRelay(ref error_packet) => {
3585                                 0u8.write(writer)?;
3586                                 error_packet.write(writer)?;
3587                         },
3588                         &InboundHTLCRemovalReason::FailMalformed((ref onion_hash, ref err_code)) => {
3589                                 1u8.write(writer)?;
3590                                 onion_hash.write(writer)?;
3591                                 err_code.write(writer)?;
3592                         },
3593                         &InboundHTLCRemovalReason::Fulfill(ref payment_preimage) => {
3594                                 2u8.write(writer)?;
3595                                 payment_preimage.write(writer)?;
3596                         },
3597                 }
3598                 Ok(())
3599         }
3600 }
3601
3602 impl<R: ::std::io::Read> Readable<R> for InboundHTLCRemovalReason {
3603         fn read(reader: &mut R) -> Result<Self, DecodeError> {
3604                 Ok(match <u8 as Readable<R>>::read(reader)? {
3605                         0 => InboundHTLCRemovalReason::FailRelay(Readable::read(reader)?),
3606                         1 => InboundHTLCRemovalReason::FailMalformed((Readable::read(reader)?, Readable::read(reader)?)),
3607                         2 => InboundHTLCRemovalReason::Fulfill(Readable::read(reader)?),
3608                         _ => return Err(DecodeError::InvalidValue),
3609                 })
3610         }
3611 }
3612
3613 impl Writeable for Channel {
3614         fn write<W: Writer>(&self, writer: &mut W) -> Result<(), ::std::io::Error> {
3615                 // Note that we write out as if remove_uncommitted_htlcs_and_mark_paused had just been
3616                 // called but include holding cell updates (and obviously we don't modify self).
3617
3618                 writer.write_all(&[SERIALIZATION_VERSION; 1])?;
3619                 writer.write_all(&[MIN_SERIALIZATION_VERSION; 1])?;
3620
3621                 self.user_id.write(writer)?;
3622                 self.config.write(writer)?;
3623
3624                 self.channel_id.write(writer)?;
3625                 (self.channel_state | ChannelState::PeerDisconnected as u32).write(writer)?;
3626                 self.channel_outbound.write(writer)?;
3627                 self.channel_value_satoshis.write(writer)?;
3628
3629                 self.local_keys.write(writer)?;
3630                 self.shutdown_pubkey.write(writer)?;
3631
3632                 self.cur_local_commitment_transaction_number.write(writer)?;
3633                 self.cur_remote_commitment_transaction_number.write(writer)?;
3634                 self.value_to_self_msat.write(writer)?;
3635
3636                 let mut dropped_inbound_htlcs = 0;
3637                 for htlc in self.pending_inbound_htlcs.iter() {
3638                         if let InboundHTLCState::RemoteAnnounced(_) = htlc.state {
3639                                 dropped_inbound_htlcs += 1;
3640                         }
3641                 }
3642                 (self.pending_inbound_htlcs.len() as u64 - dropped_inbound_htlcs).write(writer)?;
3643                 for htlc in self.pending_inbound_htlcs.iter() {
3644                         htlc.htlc_id.write(writer)?;
3645                         htlc.amount_msat.write(writer)?;
3646                         htlc.cltv_expiry.write(writer)?;
3647                         htlc.payment_hash.write(writer)?;
3648                         match &htlc.state {
3649                                 &InboundHTLCState::RemoteAnnounced(_) => {}, // Drop
3650                                 &InboundHTLCState::AwaitingRemoteRevokeToAnnounce(ref htlc_state) => {
3651                                         1u8.write(writer)?;
3652                                         htlc_state.write(writer)?;
3653                                 },
3654                                 &InboundHTLCState::AwaitingAnnouncedRemoteRevoke(ref htlc_state) => {
3655                                         2u8.write(writer)?;
3656                                         htlc_state.write(writer)?;
3657                                 },
3658                                 &InboundHTLCState::Committed => {
3659                                         3u8.write(writer)?;
3660                                 },
3661                                 &InboundHTLCState::LocalRemoved(ref removal_reason) => {
3662                                         4u8.write(writer)?;
3663                                         removal_reason.write(writer)?;
3664                                 },
3665                         }
3666                 }
3667
3668                 macro_rules! write_option {
3669                         ($thing: expr) => {
3670                                 match &$thing {
3671                                         &None => 0u8.write(writer)?,
3672                                         &Some(ref v) => {
3673                                                 1u8.write(writer)?;
3674                                                 v.write(writer)?;
3675                                         },
3676                                 }
3677                         }
3678                 }
3679
3680                 (self.pending_outbound_htlcs.len() as u64).write(writer)?;
3681                 for htlc in self.pending_outbound_htlcs.iter() {
3682                         htlc.htlc_id.write(writer)?;
3683                         htlc.amount_msat.write(writer)?;
3684                         htlc.cltv_expiry.write(writer)?;
3685                         htlc.payment_hash.write(writer)?;
3686                         htlc.source.write(writer)?;
3687                         match &htlc.state {
3688                                 &OutboundHTLCState::LocalAnnounced(ref onion_packet) => {
3689                                         0u8.write(writer)?;
3690                                         onion_packet.write(writer)?;
3691                                 },
3692                                 &OutboundHTLCState::Committed => {
3693                                         1u8.write(writer)?;
3694                                 },
3695                                 &OutboundHTLCState::RemoteRemoved(ref fail_reason) => {
3696                                         2u8.write(writer)?;
3697                                         write_option!(*fail_reason);
3698                                 },
3699                                 &OutboundHTLCState::AwaitingRemoteRevokeToRemove(ref fail_reason) => {
3700                                         3u8.write(writer)?;
3701                                         write_option!(*fail_reason);
3702                                 },
3703                                 &OutboundHTLCState::AwaitingRemovedRemoteRevoke(ref fail_reason) => {
3704                                         4u8.write(writer)?;
3705                                         write_option!(*fail_reason);
3706                                 },
3707                         }
3708                 }
3709
3710                 (self.holding_cell_htlc_updates.len() as u64).write(writer)?;
3711                 for update in self.holding_cell_htlc_updates.iter() {
3712                         match update {
3713                                 &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet } => {
3714                                         0u8.write(writer)?;
3715                                         amount_msat.write(writer)?;
3716                                         cltv_expiry.write(writer)?;
3717                                         payment_hash.write(writer)?;
3718                                         source.write(writer)?;
3719                                         onion_routing_packet.write(writer)?;
3720                                 },
3721                                 &HTLCUpdateAwaitingACK::ClaimHTLC { ref payment_preimage, ref htlc_id } => {
3722                                         1u8.write(writer)?;
3723                                         payment_preimage.write(writer)?;
3724                                         htlc_id.write(writer)?;
3725                                 },
3726                                 &HTLCUpdateAwaitingACK::FailHTLC { ref htlc_id, ref err_packet } => {
3727                                         2u8.write(writer)?;
3728                                         htlc_id.write(writer)?;
3729                                         err_packet.write(writer)?;
3730                                 }
3731                         }
3732                 }
3733
3734                 match self.resend_order {
3735                         RAACommitmentOrder::CommitmentFirst => 0u8.write(writer)?,
3736                         RAACommitmentOrder::RevokeAndACKFirst => 1u8.write(writer)?,
3737                 }
3738
3739                 self.monitor_pending_funding_locked.write(writer)?;
3740                 self.monitor_pending_revoke_and_ack.write(writer)?;
3741                 self.monitor_pending_commitment_signed.write(writer)?;
3742
3743                 (self.monitor_pending_forwards.len() as u64).write(writer)?;
3744                 for &(ref pending_forward, ref htlc_id) in self.monitor_pending_forwards.iter() {
3745                         pending_forward.write(writer)?;
3746                         htlc_id.write(writer)?;
3747                 }
3748
3749                 (self.monitor_pending_failures.len() as u64).write(writer)?;
3750                 for &(ref htlc_source, ref payment_hash, ref fail_reason) in self.monitor_pending_failures.iter() {
3751                         htlc_source.write(writer)?;
3752                         payment_hash.write(writer)?;
3753                         fail_reason.write(writer)?;
3754                 }
3755
3756                 write_option!(self.pending_update_fee);
3757                 write_option!(self.holding_cell_update_fee);
3758
3759                 self.next_local_htlc_id.write(writer)?;
3760                 (self.next_remote_htlc_id - dropped_inbound_htlcs).write(writer)?;
3761                 self.channel_update_count.write(writer)?;
3762                 self.feerate_per_kw.write(writer)?;
3763
3764                 (self.last_local_commitment_txn.len() as u64).write(writer)?;
3765                 for tx in self.last_local_commitment_txn.iter() {
3766                         if let Err(e) = tx.consensus_encode(&mut WriterWriteAdaptor(writer)) {
3767                                 match e {
3768                                         encode::Error::Io(e) => return Err(e),
3769                                         _ => panic!("last_local_commitment_txn must have been well-formed!"),
3770                                 }
3771                         }
3772                 }
3773
3774                 match self.last_sent_closing_fee {
3775                         Some((feerate, fee)) => {
3776                                 1u8.write(writer)?;
3777                                 feerate.write(writer)?;
3778                                 fee.write(writer)?;
3779                         },
3780                         None => 0u8.write(writer)?,
3781                 }
3782
3783                 write_option!(self.funding_tx_confirmed_in);
3784                 write_option!(self.short_channel_id);
3785
3786                 self.last_block_connected.write(writer)?;
3787                 self.funding_tx_confirmations.write(writer)?;
3788
3789                 self.their_dust_limit_satoshis.write(writer)?;
3790                 self.our_dust_limit_satoshis.write(writer)?;
3791                 self.their_max_htlc_value_in_flight_msat.write(writer)?;
3792                 self.their_channel_reserve_satoshis.write(writer)?;
3793                 self.their_htlc_minimum_msat.write(writer)?;
3794                 self.our_htlc_minimum_msat.write(writer)?;
3795                 self.their_to_self_delay.write(writer)?;
3796                 self.our_to_self_delay.write(writer)?;
3797                 self.their_max_accepted_htlcs.write(writer)?;
3798                 self.minimum_depth.write(writer)?;
3799
3800                 write_option!(self.their_funding_pubkey);
3801                 write_option!(self.their_revocation_basepoint);
3802                 write_option!(self.their_payment_basepoint);
3803                 write_option!(self.their_delayed_payment_basepoint);
3804                 write_option!(self.their_htlc_basepoint);
3805                 write_option!(self.their_cur_commitment_point);
3806
3807                 write_option!(self.their_prev_commitment_point);
3808                 self.their_node_id.write(writer)?;
3809
3810                 write_option!(self.their_shutdown_scriptpubkey);
3811
3812                 self.channel_monitor.write_for_disk(writer)?;
3813                 Ok(())
3814         }
3815 }
3816
3817 impl<R : ::std::io::Read> ReadableArgs<R, Arc<Logger>> for Channel {
3818         fn read(reader: &mut R, logger: Arc<Logger>) -> Result<Self, DecodeError> {
3819                 let _ver: u8 = Readable::read(reader)?;
3820                 let min_ver: u8 = Readable::read(reader)?;
3821                 if min_ver > SERIALIZATION_VERSION {
3822                         return Err(DecodeError::UnknownVersion);
3823                 }
3824
3825                 let user_id = Readable::read(reader)?;
3826                 let config: ChannelConfig = Readable::read(reader)?;
3827
3828                 let channel_id = Readable::read(reader)?;
3829                 let channel_state = Readable::read(reader)?;
3830                 let channel_outbound = Readable::read(reader)?;
3831                 let channel_value_satoshis = Readable::read(reader)?;
3832
3833                 let local_keys = Readable::read(reader)?;
3834                 let shutdown_pubkey = Readable::read(reader)?;
3835
3836                 let cur_local_commitment_transaction_number = Readable::read(reader)?;
3837                 let cur_remote_commitment_transaction_number = Readable::read(reader)?;
3838                 let value_to_self_msat = Readable::read(reader)?;
3839
3840                 let pending_inbound_htlc_count: u64 = Readable::read(reader)?;
3841                 let mut pending_inbound_htlcs = Vec::with_capacity(cmp::min(pending_inbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
3842                 for _ in 0..pending_inbound_htlc_count {
3843                         pending_inbound_htlcs.push(InboundHTLCOutput {
3844                                 htlc_id: Readable::read(reader)?,
3845                                 amount_msat: Readable::read(reader)?,
3846                                 cltv_expiry: Readable::read(reader)?,
3847                                 payment_hash: Readable::read(reader)?,
3848                                 state: match <u8 as Readable<R>>::read(reader)? {
3849                                         1 => InboundHTLCState::AwaitingRemoteRevokeToAnnounce(Readable::read(reader)?),
3850                                         2 => InboundHTLCState::AwaitingAnnouncedRemoteRevoke(Readable::read(reader)?),
3851                                         3 => InboundHTLCState::Committed,
3852                                         4 => InboundHTLCState::LocalRemoved(Readable::read(reader)?),
3853                                         _ => return Err(DecodeError::InvalidValue),
3854                                 },
3855                         });
3856                 }
3857
3858                 let pending_outbound_htlc_count: u64 = Readable::read(reader)?;
3859                 let mut pending_outbound_htlcs = Vec::with_capacity(cmp::min(pending_outbound_htlc_count as usize, OUR_MAX_HTLCS as usize));
3860                 for _ in 0..pending_outbound_htlc_count {
3861                         pending_outbound_htlcs.push(OutboundHTLCOutput {
3862                                 htlc_id: Readable::read(reader)?,
3863                                 amount_msat: Readable::read(reader)?,
3864                                 cltv_expiry: Readable::read(reader)?,
3865                                 payment_hash: Readable::read(reader)?,
3866                                 source: Readable::read(reader)?,
3867                                 state: match <u8 as Readable<R>>::read(reader)? {
3868                                         0 => OutboundHTLCState::LocalAnnounced(Box::new(Readable::read(reader)?)),
3869                                         1 => OutboundHTLCState::Committed,
3870                                         2 => OutboundHTLCState::RemoteRemoved(Readable::read(reader)?),
3871                                         3 => OutboundHTLCState::AwaitingRemoteRevokeToRemove(Readable::read(reader)?),
3872                                         4 => OutboundHTLCState::AwaitingRemovedRemoteRevoke(Readable::read(reader)?),
3873                                         _ => return Err(DecodeError::InvalidValue),
3874                                 },
3875                         });
3876                 }
3877
3878                 let holding_cell_htlc_update_count: u64 = Readable::read(reader)?;
3879                 let mut holding_cell_htlc_updates = Vec::with_capacity(cmp::min(holding_cell_htlc_update_count as usize, OUR_MAX_HTLCS as usize*2));
3880                 for _ in 0..holding_cell_htlc_update_count {
3881                         holding_cell_htlc_updates.push(match <u8 as Readable<R>>::read(reader)? {
3882                                 0 => HTLCUpdateAwaitingACK::AddHTLC {
3883                                         amount_msat: Readable::read(reader)?,
3884                                         cltv_expiry: Readable::read(reader)?,
3885                                         payment_hash: Readable::read(reader)?,
3886                                         source: Readable::read(reader)?,
3887                                         onion_routing_packet: Readable::read(reader)?,
3888                                 },
3889                                 1 => HTLCUpdateAwaitingACK::ClaimHTLC {
3890                                         payment_preimage: Readable::read(reader)?,
3891                                         htlc_id: Readable::read(reader)?,
3892                                 },
3893                                 2 => HTLCUpdateAwaitingACK::FailHTLC {
3894                                         htlc_id: Readable::read(reader)?,
3895                                         err_packet: Readable::read(reader)?,
3896                                 },
3897                                 _ => return Err(DecodeError::InvalidValue),
3898                         });
3899                 }
3900
3901                 let resend_order = match <u8 as Readable<R>>::read(reader)? {
3902                         0 => RAACommitmentOrder::CommitmentFirst,
3903                         1 => RAACommitmentOrder::RevokeAndACKFirst,
3904                         _ => return Err(DecodeError::InvalidValue),
3905                 };
3906
3907                 let monitor_pending_funding_locked = Readable::read(reader)?;
3908                 let monitor_pending_revoke_and_ack = Readable::read(reader)?;
3909                 let monitor_pending_commitment_signed = Readable::read(reader)?;
3910
3911                 let monitor_pending_forwards_count: u64 = Readable::read(reader)?;
3912                 let mut monitor_pending_forwards = Vec::with_capacity(cmp::min(monitor_pending_forwards_count as usize, OUR_MAX_HTLCS as usize));
3913                 for _ in 0..monitor_pending_forwards_count {
3914                         monitor_pending_forwards.push((Readable::read(reader)?, Readable::read(reader)?));
3915                 }
3916
3917                 let monitor_pending_failures_count: u64 = Readable::read(reader)?;
3918                 let mut monitor_pending_failures = Vec::with_capacity(cmp::min(monitor_pending_failures_count as usize, OUR_MAX_HTLCS as usize));
3919                 for _ in 0..monitor_pending_failures_count {
3920                         monitor_pending_failures.push((Readable::read(reader)?, Readable::read(reader)?, Readable::read(reader)?));
3921                 }
3922
3923                 let pending_update_fee = Readable::read(reader)?;
3924                 let holding_cell_update_fee = Readable::read(reader)?;
3925
3926                 let next_local_htlc_id = Readable::read(reader)?;
3927                 let next_remote_htlc_id = Readable::read(reader)?;
3928                 let channel_update_count = Readable::read(reader)?;
3929                 let feerate_per_kw = Readable::read(reader)?;
3930
3931                 let last_local_commitment_txn_count: u64 = Readable::read(reader)?;
3932                 let mut last_local_commitment_txn = Vec::with_capacity(cmp::min(last_local_commitment_txn_count as usize, OUR_MAX_HTLCS as usize*2 + 1));
3933                 for _ in 0..last_local_commitment_txn_count {
3934                         last_local_commitment_txn.push(match Transaction::consensus_decode(reader.by_ref()) {
3935                                 Ok(tx) => tx,
3936                                 Err(_) => return Err(DecodeError::InvalidValue),
3937                         });
3938                 }
3939
3940                 let last_sent_closing_fee = match <u8 as Readable<R>>::read(reader)? {
3941                         0 => None,
3942                         1 => Some((Readable::read(reader)?, Readable::read(reader)?)),
3943                         _ => return Err(DecodeError::InvalidValue),
3944                 };
3945
3946                 let funding_tx_confirmed_in = Readable::read(reader)?;
3947                 let short_channel_id = Readable::read(reader)?;
3948
3949                 let last_block_connected = Readable::read(reader)?;
3950                 let funding_tx_confirmations = Readable::read(reader)?;
3951
3952                 let their_dust_limit_satoshis = Readable::read(reader)?;
3953                 let our_dust_limit_satoshis = Readable::read(reader)?;
3954                 let their_max_htlc_value_in_flight_msat = Readable::read(reader)?;
3955                 let their_channel_reserve_satoshis = Readable::read(reader)?;
3956                 let their_htlc_minimum_msat = Readable::read(reader)?;
3957                 let our_htlc_minimum_msat = Readable::read(reader)?;
3958                 let their_to_self_delay = Readable::read(reader)?;
3959                 let our_to_self_delay = Readable::read(reader)?;
3960                 let their_max_accepted_htlcs = Readable::read(reader)?;
3961                 let minimum_depth = Readable::read(reader)?;
3962
3963                 let their_funding_pubkey = Readable::read(reader)?;
3964                 let their_revocation_basepoint = Readable::read(reader)?;
3965                 let their_payment_basepoint = Readable::read(reader)?;
3966                 let their_delayed_payment_basepoint = Readable::read(reader)?;
3967                 let their_htlc_basepoint = Readable::read(reader)?;
3968                 let their_cur_commitment_point = Readable::read(reader)?;
3969
3970                 let their_prev_commitment_point = Readable::read(reader)?;
3971                 let their_node_id = Readable::read(reader)?;
3972
3973                 let their_shutdown_scriptpubkey = Readable::read(reader)?;
3974                 let (monitor_last_block, channel_monitor) = ReadableArgs::read(reader, logger.clone())?;
3975                 // We drop the ChannelMonitor's last block connected hash cause we don't actually bother
3976                 // doing full block connection operations on the internal CHannelMonitor copies
3977                 if monitor_last_block != last_block_connected {
3978                         return Err(DecodeError::InvalidValue);
3979                 }
3980
3981                 Ok(Channel {
3982                         user_id,
3983
3984                         config,
3985                         channel_id,
3986                         channel_state,
3987                         channel_outbound,
3988                         secp_ctx: Secp256k1::new(),
3989                         channel_value_satoshis,
3990
3991                         local_keys,
3992                         shutdown_pubkey,
3993
3994                         cur_local_commitment_transaction_number,
3995                         cur_remote_commitment_transaction_number,
3996                         value_to_self_msat,
3997
3998                         pending_inbound_htlcs,
3999                         pending_outbound_htlcs,
4000                         holding_cell_htlc_updates,
4001
4002                         resend_order,
4003
4004                         monitor_pending_funding_locked,
4005                         monitor_pending_revoke_and_ack,
4006                         monitor_pending_commitment_signed,
4007                         monitor_pending_forwards,
4008                         monitor_pending_failures,
4009
4010                         pending_update_fee,
4011                         holding_cell_update_fee,
4012                         next_local_htlc_id,
4013                         next_remote_htlc_id,
4014                         channel_update_count,
4015                         feerate_per_kw,
4016
4017                         #[cfg(debug_assertions)]
4018                         max_commitment_tx_output_local: ::std::sync::Mutex::new((0, 0)),
4019                         #[cfg(debug_assertions)]
4020                         max_commitment_tx_output_remote: ::std::sync::Mutex::new((0, 0)),
4021
4022                         last_local_commitment_txn,
4023
4024                         last_sent_closing_fee,
4025
4026                         funding_tx_confirmed_in,
4027                         short_channel_id,
4028                         last_block_connected,
4029                         funding_tx_confirmations,
4030
4031                         their_dust_limit_satoshis,
4032                         our_dust_limit_satoshis,
4033                         their_max_htlc_value_in_flight_msat,
4034                         their_channel_reserve_satoshis,
4035                         their_htlc_minimum_msat,
4036                         our_htlc_minimum_msat,
4037                         their_to_self_delay,
4038                         our_to_self_delay,
4039                         their_max_accepted_htlcs,
4040                         minimum_depth,
4041
4042                         their_funding_pubkey,
4043                         their_revocation_basepoint,
4044                         their_payment_basepoint,
4045                         their_delayed_payment_basepoint,
4046                         their_htlc_basepoint,
4047                         their_cur_commitment_point,
4048
4049                         their_prev_commitment_point,
4050                         their_node_id,
4051
4052                         their_shutdown_scriptpubkey,
4053
4054                         channel_monitor,
4055
4056                         logger,
4057                 })
4058         }
4059 }
4060
4061 #[cfg(test)]
4062 mod tests {
4063         use bitcoin::util::bip143;
4064         use bitcoin::consensus::encode::serialize;
4065         use bitcoin::blockdata::script::{Script, Builder};
4066         use bitcoin::blockdata::transaction::Transaction;
4067         use bitcoin::blockdata::opcodes;
4068         use bitcoin_hashes::hex::FromHex;
4069         use hex;
4070         use ln::channelmanager::{HTLCSource, PaymentPreimage, PaymentHash};
4071         use ln::channel::{Channel,ChannelKeys,InboundHTLCOutput,OutboundHTLCOutput,InboundHTLCState,OutboundHTLCState,HTLCOutputInCommitment,TxCreationKeys};
4072         use ln::channel::MAX_FUNDING_SATOSHIS;
4073         use ln::chan_utils;
4074         use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
4075         use chain::keysinterface::KeysInterface;
4076         use chain::transaction::OutPoint;
4077         use util::config::UserConfig;
4078         use util::test_utils;
4079         use util::logger::Logger;
4080         use secp256k1::{Secp256k1,Message,Signature};
4081         use secp256k1::key::{SecretKey,PublicKey};
4082         use bitcoin_hashes::sha256::Hash as Sha256;
4083         use bitcoin_hashes::sha256d::Hash as Sha256dHash;
4084         use bitcoin_hashes::hash160::Hash as Hash160;
4085         use bitcoin_hashes::Hash;
4086         use std::sync::Arc;
4087
4088         struct TestFeeEstimator {
4089                 fee_est: u64
4090         }
4091         impl FeeEstimator for TestFeeEstimator {
4092                 fn get_est_sat_per_1000_weight(&self, _: ConfirmationTarget) -> u64 {
4093                         self.fee_est
4094                 }
4095         }
4096
4097         #[test]
4098         fn test_max_funding_satoshis() {
4099                 assert!(MAX_FUNDING_SATOSHIS <= 21_000_000 * 100_000_000,
4100                         "MAX_FUNDING_SATOSHIS is greater than all satoshis in existence");
4101         }
4102
4103         struct Keys {
4104                 chan_keys: ChannelKeys,
4105         }
4106         impl KeysInterface for Keys {
4107                 fn get_node_secret(&self) -> SecretKey { panic!(); }
4108                 fn get_destination_script(&self) -> Script {
4109                         let secp_ctx = Secp256k1::signing_only();
4110                         let channel_monitor_claim_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
4111                         let our_channel_monitor_claim_key_hash = Hash160::hash(&PublicKey::from_secret_key(&secp_ctx, &channel_monitor_claim_key).serialize());
4112                         Builder::new().push_opcode(opcodes::all::OP_PUSHBYTES_0).push_slice(&our_channel_monitor_claim_key_hash[..]).into_script()
4113                 }
4114
4115                 fn get_shutdown_pubkey(&self) -> PublicKey {
4116                         let secp_ctx = Secp256k1::signing_only();
4117                         let channel_close_key = SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap();
4118                         PublicKey::from_secret_key(&secp_ctx, &channel_close_key)
4119                 }
4120
4121                 fn get_channel_keys(&self, _inbound: bool) -> ChannelKeys { self.chan_keys.clone() }
4122                 fn get_session_key(&self) -> SecretKey { panic!(); }
4123                 fn get_channel_id(&self) -> [u8; 32] { [0; 32] }
4124         }
4125
4126         #[test]
4127         fn outbound_commitment_test() {
4128                 // Test vectors from BOLT 3 Appendix C:
4129                 let feeest = TestFeeEstimator{fee_est: 15000};
4130                 let logger : Arc<Logger> = Arc::new(test_utils::TestLogger::new());
4131                 let secp_ctx = Secp256k1::new();
4132
4133                 let chan_keys = ChannelKeys {
4134                         funding_key: SecretKey::from_slice(&hex::decode("30ff4956bbdd3222d44cc5e8a1261dab1e07957bdac5ae88fe3261ef321f3749").unwrap()[..]).unwrap(),
4135                         payment_base_key: SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
4136                         delayed_payment_base_key: SecretKey::from_slice(&hex::decode("3333333333333333333333333333333333333333333333333333333333333333").unwrap()[..]).unwrap(),
4137                         htlc_base_key: SecretKey::from_slice(&hex::decode("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap(),
4138
4139                         // These aren't set in the test vectors:
4140                         revocation_base_key: SecretKey::from_slice(&hex::decode("0fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff").unwrap()[..]).unwrap(),
4141                         commitment_seed: [0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff],
4142                 };
4143                 assert_eq!(PublicKey::from_secret_key(&secp_ctx, &chan_keys.funding_key).serialize()[..],
4144                                 hex::decode("023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb").unwrap()[..]);
4145                 let keys_provider: Arc<KeysInterface> = Arc::new(Keys { chan_keys });
4146
4147                 let their_node_id = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap());
4148                 let mut config = UserConfig::new();
4149                 config.channel_options.announced_channel = false;
4150                 let mut chan = Channel::new_outbound(&feeest, &keys_provider, their_node_id, 10000000, 100000, 42, Arc::clone(&logger), &config).unwrap(); // Nothing uses their network key in this test
4151                 chan.their_to_self_delay = 144;
4152                 chan.our_dust_limit_satoshis = 546;
4153
4154                 let funding_info = OutPoint::new(Sha256dHash::from_hex("8984484a580b825b9972d7adb15050b3ab624ccd731946b3eeddb92f4e7ef6be").unwrap(), 0);
4155                 chan.channel_monitor.set_funding_info((funding_info, Script::new()));
4156
4157                 chan.their_payment_basepoint = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode("4444444444444444444444444444444444444444444444444444444444444444").unwrap()[..]).unwrap()));
4158                 assert_eq!(chan.their_payment_basepoint.unwrap().serialize()[..],
4159                                 hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
4160
4161                 chan.their_funding_pubkey = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode("1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13").unwrap()[..]).unwrap()));
4162                 assert_eq!(chan.their_funding_pubkey.unwrap().serialize()[..],
4163                                 hex::decode("030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c1").unwrap()[..]);
4164
4165                 chan.their_htlc_basepoint = Some(PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&hex::decode("4444444444444444444444444444444444444444444444444444444444444444").unwrap()[..]).unwrap()));
4166                 assert_eq!(chan.their_htlc_basepoint.unwrap().serialize()[..],
4167                                 hex::decode("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
4168
4169                 chan.their_revocation_basepoint = Some(PublicKey::from_slice(&hex::decode("02466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27").unwrap()[..]).unwrap());
4170
4171                 // We can't just use build_local_transaction_keys here as the per_commitment_secret is not
4172                 // derived from a commitment_seed, so instead we copy it here and call
4173                 // build_commitment_transaction.
4174                 let delayed_payment_base = PublicKey::from_secret_key(&secp_ctx, &chan.local_keys.delayed_payment_base_key);
4175                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
4176                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
4177                 let htlc_basepoint = PublicKey::from_secret_key(&secp_ctx, &chan.local_keys.htlc_base_key);
4178                 let keys = TxCreationKeys::new(&secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &chan.their_revocation_basepoint.unwrap(), &chan.their_payment_basepoint.unwrap(), &chan.their_htlc_basepoint.unwrap()).unwrap();
4179
4180                 let mut unsigned_tx: (Transaction, Vec<HTLCOutputInCommitment>);
4181
4182                 macro_rules! test_commitment {
4183                         ( $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr) => {
4184                                 unsigned_tx = {
4185                                         let mut res = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw);
4186                                         let htlcs = res.2.drain(..)
4187                                                 .filter_map(|(htlc, _)| if htlc.transaction_output_index.is_some() { Some(htlc) } else { None })
4188                                                 .collect();
4189                                         (res.0, htlcs)
4190                                 };
4191                                 let their_signature = Signature::from_der(&hex::decode($their_sig_hex).unwrap()[..]).unwrap();
4192                                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&unsigned_tx.0).sighash_all(&unsigned_tx.0.input[0], &chan.get_funding_redeemscript(), chan.channel_value_satoshis)[..]).unwrap();
4193                                 secp_ctx.verify(&sighash, &their_signature, &chan.their_funding_pubkey.unwrap()).unwrap();
4194
4195                                 chan.sign_commitment_transaction(&mut unsigned_tx.0, &their_signature);
4196
4197                                 assert_eq!(serialize(&unsigned_tx.0)[..],
4198                                                 hex::decode($tx_hex).unwrap()[..]);
4199                         };
4200                 }
4201
4202                 macro_rules! test_htlc_output {
4203                         ( $htlc_idx: expr, $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr ) => {
4204                                 let remote_signature = Signature::from_der(&hex::decode($their_sig_hex).unwrap()[..]).unwrap();
4205
4206                                 let ref htlc = unsigned_tx.1[$htlc_idx];
4207                                 let mut htlc_tx = chan.build_htlc_transaction(&unsigned_tx.0.txid(), &htlc, true, &keys, chan.feerate_per_kw);
4208                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys);
4209                                 let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx.input[0], &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
4210                                 secp_ctx.verify(&htlc_sighash, &remote_signature, &keys.b_htlc_key).unwrap();
4211
4212                                 let mut preimage: Option<PaymentPreimage> = None;
4213                                 if !htlc.offered {
4214                                         for i in 0..5 {
4215                                                 let out = PaymentHash(Sha256::hash(&[i; 32]).into_inner());
4216                                                 if out == htlc.payment_hash {
4217                                                         preimage = Some(PaymentPreimage([i; 32]));
4218                                                 }
4219                                         }
4220
4221                                         assert!(preimage.is_some());
4222                                 }
4223
4224                                 chan.sign_htlc_transaction(&mut htlc_tx, &remote_signature, &preimage, &htlc, &keys).unwrap();
4225                                 assert_eq!(serialize(&htlc_tx)[..],
4226                                                 hex::decode($tx_hex).unwrap()[..]);
4227                         };
4228                 }
4229
4230                 {
4231                         // simple commitment tx with no HTLCs
4232                         chan.value_to_self_msat = 7000000000;
4233
4234                         test_commitment!("3045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c0",
4235                                          "3044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c3836939",
4236                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311054a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c383693901483045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4237                 }
4238
4239                 chan.pending_inbound_htlcs.push({
4240                         let mut out = InboundHTLCOutput{
4241                                 htlc_id: 0,
4242                                 amount_msat: 1000000,
4243                                 cltv_expiry: 500,
4244                                 payment_hash: PaymentHash([0; 32]),
4245                                 state: InboundHTLCState::Committed,
4246                         };
4247                         out.payment_hash.0 = Sha256::hash(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap()).into_inner();
4248                         out
4249                 });
4250                 chan.pending_inbound_htlcs.push({
4251                         let mut out = InboundHTLCOutput{
4252                                 htlc_id: 1,
4253                                 amount_msat: 2000000,
4254                                 cltv_expiry: 501,
4255                                 payment_hash: PaymentHash([0; 32]),
4256                                 state: InboundHTLCState::Committed,
4257                         };
4258                         out.payment_hash.0 = Sha256::hash(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap()).into_inner();
4259                         out
4260                 });
4261                 chan.pending_outbound_htlcs.push({
4262                         let mut out = OutboundHTLCOutput{
4263                                 htlc_id: 2,
4264                                 amount_msat: 2000000,
4265                                 cltv_expiry: 502,
4266                                 payment_hash: PaymentHash([0; 32]),
4267                                 state: OutboundHTLCState::Committed,
4268                                 source: HTLCSource::dummy(),
4269                         };
4270                         out.payment_hash.0 = Sha256::hash(&hex::decode("0202020202020202020202020202020202020202020202020202020202020202").unwrap()).into_inner();
4271                         out
4272                 });
4273                 chan.pending_outbound_htlcs.push({
4274                         let mut out = OutboundHTLCOutput{
4275                                 htlc_id: 3,
4276                                 amount_msat: 3000000,
4277                                 cltv_expiry: 503,
4278                                 payment_hash: PaymentHash([0; 32]),
4279                                 state: OutboundHTLCState::Committed,
4280                                 source: HTLCSource::dummy(),
4281                         };
4282                         out.payment_hash.0 = Sha256::hash(&hex::decode("0303030303030303030303030303030303030303030303030303030303030303").unwrap()).into_inner();
4283                         out
4284                 });
4285                 chan.pending_inbound_htlcs.push({
4286                         let mut out = InboundHTLCOutput{
4287                                 htlc_id: 4,
4288                                 amount_msat: 4000000,
4289                                 cltv_expiry: 504,
4290                                 payment_hash: PaymentHash([0; 32]),
4291                                 state: InboundHTLCState::Committed,
4292                         };
4293                         out.payment_hash.0 = Sha256::hash(&hex::decode("0404040404040404040404040404040404040404040404040404040404040404").unwrap()).into_inner();
4294                         out
4295                 });
4296
4297                 {
4298                         // commitment tx with all five HTLCs untrimmed (minimum feerate)
4299                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4300                         chan.feerate_per_kw = 0;
4301
4302                         test_commitment!("304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b70606",
4303                                          "30440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f06",
4304                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f060147304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b7060601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4305
4306                         assert_eq!(unsigned_tx.1.len(), 5);
4307
4308                         test_htlc_output!(0,
4309                                           "304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a6",
4310                                           "304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5",
4311                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219700000000000000000001e8030000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a60147304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
4312
4313                         test_htlc_output!(1,
4314                                           "3045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b",
4315                                           "3045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be5",
4316                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219701000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b01483045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4317
4318                         test_htlc_output!(2,
4319                                           "304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f202",
4320                                           "3045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da",
4321                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219702000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f20201483045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4322
4323                         test_htlc_output!(3,
4324                                           "3045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554",
4325                                           "30440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac08727",
4326                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219703000000000000000001b80b0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554014730440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac0872701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4327
4328                         test_htlc_output!(4,
4329                                           "304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d",
4330                                           "30440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e",
4331                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219704000000000000000001a00f0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d014730440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4332                 }
4333
4334                 {
4335                         // commitment tx with seven outputs untrimmed (maximum feerate)
4336                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4337                         chan.feerate_per_kw = 647;
4338
4339                         test_commitment!("3045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b",
4340                                          "304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d1163",
4341                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040048304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d116301483045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4342
4343                         assert_eq!(unsigned_tx.1.len(), 5);
4344
4345                         test_htlc_output!(0,
4346                                           "30440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab343740",
4347                                           "304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a",
4348                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab3437400147304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
4349
4350                         test_htlc_output!(1,
4351                                           "304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b0",
4352                                           "304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac",
4353                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60100000000000000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b00147304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4354
4355                         test_htlc_output!(2,
4356                                           "304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d833",
4357                                           "3045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877",
4358                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6020000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d83301483045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4359
4360                         test_htlc_output!(3,
4361                                           "30450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d",
4362                                           "3045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb",
4363                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6030000000000000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d01483045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4364
4365                         test_htlc_output!(4,
4366                                           "3045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f0",
4367                                           "304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f",
4368                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb604000000000000000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f00147304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4369                 }
4370
4371                 {
4372                         // commitment tx with six outputs untrimmed (minimum feerate)
4373                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4374                         chan.feerate_per_kw = 648;
4375
4376                         test_commitment!("3044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b057",
4377                                          "3045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de",
4378                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431104e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de01473044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b05701475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4379
4380                         assert_eq!(unsigned_tx.1.len(), 4);
4381
4382                         test_htlc_output!(0,
4383                                           "3044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada8",
4384                                           "3045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc098",
4385                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10000000000000000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada801483045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc09801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4386
4387                         test_htlc_output!(1,
4388                                           "3045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d4",
4389                                           "304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0",
4390                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10100000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d40147304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4391
4392                         test_htlc_output!(2,
4393                                           "3045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c2",
4394                                           "304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda3",
4395                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd1020000000000000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c20147304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda301008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4396
4397                         test_htlc_output!(3,
4398                                           "3044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f",
4399                                           "304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6",
4400                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd103000000000000000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f0147304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4401                 }
4402
4403                 {
4404                         // commitment tx with six outputs untrimmed (maximum feerate)
4405                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4406                         chan.feerate_per_kw = 2069;
4407
4408                         test_commitment!("3044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb4",
4409                                          "304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea",
4410                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311077956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea01473044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4411
4412                         assert_eq!(unsigned_tx.1.len(), 4);
4413
4414                         test_htlc_output!(0,
4415                                           "3045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f992",
4416                                           "3044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae66402",
4417                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0000000000000000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f99201473044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae6640201008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4418
4419                         test_htlc_output!(1,
4420                                           "3045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f4",
4421                                           "3045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f",
4422                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0100000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f401483045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
4423
4424                         test_htlc_output!(2,
4425                                           "3045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef18",
4426                                           "304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f9",
4427                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a020000000000000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef180147304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f901008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4428
4429                         test_htlc_output!(3,
4430                                           "30450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c",
4431                                           "304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5",
4432                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a03000000000000000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c0147304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4433                 }
4434
4435                 {
4436                         // commitment tx with five outputs untrimmed (minimum feerate)
4437                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4438                         chan.feerate_per_kw = 2070;
4439
4440                         test_commitment!("3045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f37526",
4441                                          "30440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd0",
4442                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd001483045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f3752601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4443
4444                         assert_eq!(unsigned_tx.1.len(), 3);
4445
4446                         test_htlc_output!(0,
4447                                           "3045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f891",
4448                                           "3045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb8",
4449                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a2180000000000000000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f89101483045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4450
4451                         test_htlc_output!(1,
4452                                           "3044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf6",
4453                                           "3045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d",
4454                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a218010000000000000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf601483045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4455
4456                         test_htlc_output!(2,
4457                                           "3045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a4",
4458                                           "304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04",
4459                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a21802000000000000000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a40147304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4460                 }
4461
4462                 {
4463                         // commitment tx with five outputs untrimmed (maximum feerate)
4464                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4465                         chan.feerate_per_kw = 2194;
4466
4467                         test_commitment!("3045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec86203953348",
4468                                          "304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f7061",
4469                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311040966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f706101483045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec8620395334801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4470
4471                         assert_eq!(unsigned_tx.1.len(), 3);
4472
4473                         test_htlc_output!(0,
4474                                           "30450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf44",
4475                                           "3044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f",
4476                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf4401473044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
4477
4478                         test_htlc_output!(1,
4479                                           "30440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d",
4480                                           "304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c915",
4481                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a010000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d0147304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c91501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4482
4483                         test_htlc_output!(2,
4484                                           "3045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a",
4485                                           "3045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0",
4486                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a020000000000000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a01483045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4487                 }
4488
4489                 {
4490                         // commitment tx with four outputs untrimmed (minimum feerate)
4491                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4492                         chan.feerate_per_kw = 2195;
4493
4494                         test_commitment!("304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb7924298",
4495                                          "304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a5429",
4496                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a54290147304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb792429801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4497
4498                         assert_eq!(unsigned_tx.1.len(), 2);
4499
4500                         test_htlc_output!(0,
4501                                           "3045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc",
4502                                           "3045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc704390",
4503                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0000000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc01483045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc70439001008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4504
4505                         test_htlc_output!(1,
4506                                           "3045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92",
4507                                           "30440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8",
4508                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0100000000000000000199090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92014730440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4509                 }
4510
4511                 {
4512                         // commitment tx with four outputs untrimmed (maximum feerate)
4513                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4514                         chan.feerate_per_kw = 3702;
4515
4516                         test_commitment!("3045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c1",
4517                                          "304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b0",
4518                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431106f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b001483045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c101475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4519
4520                         assert_eq!(unsigned_tx.1.len(), 2);
4521
4522                         test_htlc_output!(0,
4523                                           "3045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb",
4524                                           "304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a",
4525                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb0147304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
4526
4527                         test_htlc_output!(1,
4528                                           "3045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9",
4529                                           "30440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c",
4530                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30100000000000000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9014730440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4531                 }
4532
4533                 {
4534                         // commitment tx with three outputs untrimmed (minimum feerate)
4535                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4536                         chan.feerate_per_kw = 3703;
4537
4538                         test_commitment!("30450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb0",
4539                                          "3044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506",
4540                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506014830450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4541
4542                         assert_eq!(unsigned_tx.1.len(), 1);
4543
4544                         test_htlc_output!(0,
4545                                           "3044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd",
4546                                           "3045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724",
4547                                           "020000000001011c076aa7fb3d7460d10df69432c904227ea84bbf3134d4ceee5fb0f135ef206d0000000000000000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd01483045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4548                 }
4549
4550                 {
4551                         // commitment tx with three outputs untrimmed (maximum feerate)
4552                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4553                         chan.feerate_per_kw = 4914;
4554
4555                         test_commitment!("304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e",
4556                                          "304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe26",
4557                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe260147304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4558
4559                         assert_eq!(unsigned_tx.1.len(), 1);
4560
4561                         test_htlc_output!(0,
4562                                           "3045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf",
4563                                           "304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68",
4564                                           "0200000000010110a3fdcbcd5db477cd3ad465e7f501ffa8c437e8301f00a6061138590add757f0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf0148304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
4565                 }
4566
4567                 {
4568                         // commitment tx with two outputs untrimmed (minimum feerate)
4569                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4570                         chan.feerate_per_kw = 4915;
4571
4572                         test_commitment!("304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f8765552",
4573                                          "3045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b9",
4574                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b90147304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f876555201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4575
4576                         assert_eq!(unsigned_tx.1.len(), 0);
4577                 }
4578
4579                 {
4580                         // commitment tx with two outputs untrimmed (maximum feerate)
4581                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4582                         chan.feerate_per_kw = 9651180;
4583
4584                         test_commitment!("3044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd",
4585                                          "30440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b9",
4586                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311004004730440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b901473044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4587
4588                         assert_eq!(unsigned_tx.1.len(), 0);
4589                 }
4590
4591                 {
4592                         // commitment tx with one output untrimmed (minimum feerate)
4593                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4594                         chan.feerate_per_kw = 9651181;
4595
4596                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
4597                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
4598                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4599
4600                         assert_eq!(unsigned_tx.1.len(), 0);
4601                 }
4602
4603                 {
4604                         // commitment tx with fee greater than funder amount
4605                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
4606                         chan.feerate_per_kw = 9651936;
4607
4608                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
4609                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
4610                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
4611
4612                         assert_eq!(unsigned_tx.1.len(), 0);
4613                 }
4614         }
4615
4616         #[test]
4617         fn test_per_commitment_secret_gen() {
4618                 // Test vectors from BOLT 3 Appendix D:
4619
4620                 let mut seed = [0; 32];
4621                 seed[0..32].clone_from_slice(&hex::decode("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
4622                 assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655),
4623                            hex::decode("02a40c85b6f28da08dfdbe0926c53fab2de6d28c10301f8f7c4073d5e42e3148").unwrap()[..]);
4624
4625                 seed[0..32].clone_from_slice(&hex::decode("FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF").unwrap());
4626                 assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655),
4627                            hex::decode("7cc854b54e3e0dcdb010d7a3fee464a9687be6e8db3be6854c475621e007a5dc").unwrap()[..]);
4628
4629                 assert_eq!(chan_utils::build_commitment_secret(seed, 0xaaaaaaaaaaa),
4630                            hex::decode("56f4008fb007ca9acf0e15b054d5c9fd12ee06cea347914ddbaed70d1c13a528").unwrap()[..]);
4631
4632                 assert_eq!(chan_utils::build_commitment_secret(seed, 0x555555555555),
4633                            hex::decode("9015daaeb06dba4ccc05b91b2f73bd54405f2be9f217fbacd3c5ac2e62327d31").unwrap()[..]);
4634
4635                 seed[0..32].clone_from_slice(&hex::decode("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
4636                 assert_eq!(chan_utils::build_commitment_secret(seed, 1),
4637                            hex::decode("915c75942a26bb3a433a8ce2cb0427c29ec6c1775cfc78328b57f6ba7bfeaa9c").unwrap()[..]);
4638         }
4639
4640         #[test]
4641         fn test_key_derivation() {
4642                 // Test vectors from BOLT 3 Appendix E:
4643                 let secp_ctx = Secp256k1::new();
4644
4645                 let base_secret = SecretKey::from_slice(&hex::decode("000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f").unwrap()[..]).unwrap();
4646                 let per_commitment_secret = SecretKey::from_slice(&hex::decode("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
4647
4648                 let base_point = PublicKey::from_secret_key(&secp_ctx, &base_secret);
4649                 assert_eq!(base_point.serialize()[..], hex::decode("036d6caac248af96f6afa7f904f550253a0f3ef3f5aa2fe6838a95b216691468e2").unwrap()[..]);
4650
4651                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret);
4652                 assert_eq!(per_commitment_point.serialize()[..], hex::decode("025f7117a78150fe2ef97db7cfc83bd57b2e2c0d0dd25eaf467a4a1c2a45ce1486").unwrap()[..]);
4653
4654                 assert_eq!(chan_utils::derive_public_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
4655                                 hex::decode("0235f2dbfaa89b57ec7b055afe29849ef7ddfeb1cefdb9ebdc43f5494984db29e5").unwrap()[..]);
4656
4657                 assert_eq!(chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &base_secret).unwrap(),
4658                                 SecretKey::from_slice(&hex::decode("cbced912d3b21bf196a766651e436aff192362621ce317704ea2f75d87e7be0f").unwrap()[..]).unwrap());
4659
4660                 assert_eq!(chan_utils::derive_public_revocation_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
4661                                 hex::decode("02916e326636d19c33f13e8c0c3a03dd157f332f3e99c317c141dd865eb01f8ff0").unwrap()[..]);
4662
4663                 assert_eq!(chan_utils::derive_private_revocation_key(&secp_ctx, &per_commitment_secret, &base_secret).unwrap(),
4664                                 SecretKey::from_slice(&hex::decode("d09ffff62ddb2297ab000cc85bcb4283fdeb6aa052affbc9dddcf33b61078110").unwrap()[..]).unwrap());
4665         }
4666 }