Check validity of dust_limit_satoshis in remote messages
[rust-lightning] / src / ln / channel.rs
1 use bitcoin::blockdata::block::BlockHeader;
2 use bitcoin::blockdata::script::{Script,Builder};
3 use bitcoin::blockdata::transaction::{TxIn, TxOut, Transaction, SigHashType};
4 use bitcoin::blockdata::opcodes;
5 use bitcoin::util::uint::Uint256;
6 use bitcoin::util::hash::{Sha256dHash, Hash160};
7 use bitcoin::util::bip143;
8 use bitcoin::network::serialize::BitcoinHash;
9
10 use secp256k1::key::{PublicKey,SecretKey};
11 use secp256k1::{Secp256k1,Message,Signature};
12 use secp256k1;
13
14 use crypto::digest::Digest;
15 use crypto::hkdf::{hkdf_extract,hkdf_expand};
16 use crypto::sha2::Sha256;
17
18 use ln::msgs;
19 use ln::msgs::{HandleError, MsgEncodable};
20 use ln::channelmonitor::ChannelMonitor;
21 use ln::channelmanager::PendingForwardHTLCInfo;
22 use ln::chan_utils::{TxCreationKeys,HTLCOutputInCommitment};
23 use ln::chan_utils;
24 use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
25 use util::transaction_utils;
26
27 use rand::{thread_rng,Rng};
28
29 use std::default::Default;
30 use std::cmp;
31 use std::time::Instant;
32
33 pub struct ChannelKeys {
34         pub funding_key: SecretKey,
35         pub revocation_base_key: SecretKey,
36         pub payment_base_key: SecretKey,
37         pub delayed_payment_base_key: SecretKey,
38         pub htlc_base_key: SecretKey,
39         pub channel_close_key: SecretKey,
40         pub channel_monitor_claim_key: SecretKey,
41         pub commitment_seed: [u8; 32],
42 }
43
44 impl ChannelKeys {
45         pub fn new_from_seed(seed: &[u8; 32]) -> Result<ChannelKeys, secp256k1::Error> {
46                 let mut prk = [0; 32];
47                 hkdf_extract(Sha256::new(), b"rust-lightning key gen salt", seed, &mut prk);
48                 let secp_ctx = Secp256k1::new();
49
50                 let mut okm = [0; 32];
51                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning funding key info", &mut okm);
52                 let funding_key = SecretKey::from_slice(&secp_ctx, &okm)?;
53
54                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning revocation base key info", &mut okm);
55                 let revocation_base_key = SecretKey::from_slice(&secp_ctx, &okm)?;
56
57                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning payment base key info", &mut okm);
58                 let payment_base_key = SecretKey::from_slice(&secp_ctx, &okm)?;
59
60                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning delayed payment base key info", &mut okm);
61                 let delayed_payment_base_key = SecretKey::from_slice(&secp_ctx, &okm)?;
62
63                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning htlc base key info", &mut okm);
64                 let htlc_base_key = SecretKey::from_slice(&secp_ctx, &okm)?;
65
66                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning channel close key info", &mut okm);
67                 let channel_close_key = SecretKey::from_slice(&secp_ctx, &okm)?;
68
69                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning channel monitor claim key info", &mut okm);
70                 let channel_monitor_claim_key = SecretKey::from_slice(&secp_ctx, &okm)?;
71
72                 hkdf_expand(Sha256::new(), &prk, b"rust-lightning local commitment seed info", &mut okm);
73
74                 Ok(ChannelKeys {
75                         funding_key: funding_key,
76                         revocation_base_key: revocation_base_key,
77                         payment_base_key: payment_base_key,
78                         delayed_payment_base_key: delayed_payment_base_key,
79                         htlc_base_key: htlc_base_key,
80                         channel_close_key: channel_close_key,
81                         channel_monitor_claim_key: channel_monitor_claim_key,
82                         commitment_seed: okm
83                 })
84         }
85 }
86
87 #[derive(PartialEq)]
88 enum HTLCState {
89         RemoteAnnounced,
90         LocalAnnounced,
91         Committed,
92 }
93
94 struct HTLCOutput {
95         outbound: bool, // ie to an HTLC-Timeout transaction
96         htlc_id: u64,
97         amount_msat: u64,
98         cltv_expiry: u32,
99         payment_hash: [u8; 32],
100         state: HTLCState,
101         // state == RemoteAnnounced implies pending_forward_state, otherwise it must be None
102         pending_forward_state: Option<PendingForwardHTLCInfo>,
103 }
104
105 impl HTLCOutput {
106         fn get_in_commitment(&self, offered: bool) -> HTLCOutputInCommitment {
107                 HTLCOutputInCommitment {
108                         offered: offered,
109                         amount_msat: self.amount_msat,
110                         cltv_expiry: self.cltv_expiry,
111                         payment_hash: self.payment_hash,
112                         transaction_output_index: 0
113                 }
114         }
115 }
116
117 /// See AwaitingRemoteRevoke ChannelState for more info
118 struct HTLCOutputAwaitingACK {
119         // always outbound
120         amount_msat: u64,
121         cltv_expiry: u32,
122         payment_hash: [u8; 32],
123         onion_routing_packet: msgs::OnionPacket,
124         time_created: Instant, //TODO: Some kind of timeout thing-a-majig
125 }
126
127 enum ChannelState {
128         /// Implies we have (or are prepared to) send our open_channel/accept_channel message
129         OurInitSent = (1 << 0),
130         /// Implies we have received their open_channel/accept_channel message
131         TheirInitSent = (1 << 1),
132         /// We have sent funding_created and are awaiting a funding_signed to advance to FundingSent.
133         /// Note that this is nonsense for an inbound channel as we immediately generate funding_signed
134         /// upon receipt of funding_created, so simply skip this state.
135         FundingCreated = 4,
136         /// Set when we have received/sent funding_created and funding_signed and are thus now waiting
137         /// on the funding transaction to confirm. The FundingLocked flags are set to indicate when we
138         /// and our counterparty consider the funding transaction confirmed.
139         FundingSent = 8,
140         /// Flag which can be set on FundingSent to indicate they sent us a funding_locked message.
141         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
142         TheirFundingLocked = (1 << 4),
143         /// Flag which can be set on FundingSent to indicate we sent them a funding_locked message.
144         /// Once both TheirFundingLocked and OurFundingLocked are set, state moves on to ChannelFunded.
145         OurFundingLocked = (1 << 5),
146         ChannelFunded = 64,
147         /// Flag which implies that we have sent a commitment_signed but are awaiting the responding
148         /// revoke_and_ack message. During this time period, we can't generate new commitment_signed
149         /// messages as then we will be unable to determine which HTLCs they included in their
150         /// revoke_and_ack implicit ACK, so instead we have to hold them away temporarily to be sent
151         /// later.
152         /// Flag is set on ChannelFunded.
153         AwaitingRemoteRevoke = (1 << 7),
154 }
155
156 // TODO: We should refactor this to be an Inbound/OutboundChannel until initial setup handshaking
157 // has been completed, and then turn into a Channel to get compiler-time enforcement of things like
158 // calling get_channel_id() before we're set up or things like get_outbound_funding_signed on an
159 // inbound channel.
160 pub struct Channel {
161         user_id: u64,
162
163         channel_id: Uint256,
164         channel_state: u32,
165         channel_outbound: bool,
166         secp_ctx: Secp256k1,
167         announce_publicly: bool,
168         channel_value_satoshis: u64,
169
170         local_keys: ChannelKeys,
171
172         cur_local_commitment_transaction_number: u64,
173         cur_remote_commitment_transaction_number: u64,
174         value_to_self_msat: u64, // Excluding all pending_htlcs, excluding fees
175         pending_htlcs: Vec<HTLCOutput>,
176         holding_cell_htlcs: Vec<HTLCOutputAwaitingACK>,
177         next_local_htlc_id: u64,
178         next_remote_htlc_id: u64,
179         channel_update_count: u32,
180         feerate_per_kw: u64,
181
182         /// The hash of the block in which the funding transaction reached our CONF_TARGET. We use this
183         /// to detect unconfirmation after a serialize-unserialize roudtrip where we may not see a full
184         /// series of block_connected/block_disconnected calls. Obviously this is not a guarantee as we
185         /// could miss the funding_tx_confirmed_in block as well, but it serves as a useful fallback.
186         funding_tx_confirmed_in: Sha256dHash,
187         short_channel_id: Option<u64>,
188         /// Used to deduplicate block_connected callbacks
189         last_block_connected: Sha256dHash,
190         funding_tx_confirmations: u64,
191
192         their_dust_limit_satoshis: u64,
193         our_dust_limit_satoshis: u64,
194         their_max_htlc_value_in_flight_msat: u64,
195         //get_our_max_htlc_value_in_flight_msat(): u64,
196         their_channel_reserve_satoshis: u64,
197         //get_our_channel_reserve_satoshis(): u64,
198         their_htlc_minimum_msat: u64,
199         our_htlc_minimum_msat: u64,
200         their_to_self_delay: u16,
201         //implied by BREAKDOWN_TIMEOUT: our_to_self_delay: u16,
202         their_max_accepted_htlcs: u16,
203         //implied by OUR_MAX_HTLCS: our_max_accepted_htlcs: u16,
204
205         their_funding_pubkey: PublicKey,
206         their_revocation_basepoint: PublicKey,
207         their_payment_basepoint: PublicKey,
208         their_delayed_payment_basepoint: PublicKey,
209         their_htlc_basepoint: PublicKey,
210         their_cur_commitment_point: PublicKey,
211         their_node_id: PublicKey,
212
213         channel_monitor: ChannelMonitor,
214 }
215
216 const OUR_MAX_HTLCS: u16 = 1; //TODO
217 const CONF_TARGET: u32 = 12; //TODO: Should be much higher
218 /// Confirmation count threshold at which we close a channel. Ideally we'd keep the channel around
219 /// on ice until the funding transaction gets more confirmations, but the LN protocol doesn't
220 /// really allow for this, so instead we're stuck closing it out at that point.
221 const UNCONF_THRESHOLD: u32 = 6;
222 /// The amount of time we require our counterparty wait to claim their money (ie time between when
223 /// we, or our watchtower, must check for them having broadcast a theft transaction).
224 const BREAKDOWN_TIMEOUT: u16 = 6 * 24 * 7; //TODO?
225 /// The amount of time we're willing to wait to claim money back to us
226 const MAX_LOCAL_BREAKDOWN_TIMEOUT: u16 = 6 * 24 * 14;
227 const COMMITMENT_TX_BASE_WEIGHT: u64 = 724;
228 const COMMITMENT_TX_WEIGHT_PER_HTLC: u64 = 172;
229 const HTLC_SUCCESS_TX_WEIGHT: u64 = 703;
230 const HTLC_TIMEOUT_TX_WEIGHT: u64 = 663;
231 const SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT: u64 = 79; // prevout: 36, nSequence: 4, script len: 1, witness lengths: (3+1)/4, sig: 73/4, if-selector: 1, redeemScript: (6 ops + 2*33 pubkeys + 1*2 delay)/4
232 const B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT: u64 = 104; // prevout: 40, nSequence: 4, script len: 1, witness lengths: 3/4, sig: 73/4, pubkey: 33/4, output: 31 (TODO: Wrong? Useless?)
233
234 macro_rules! secp_call {
235         ( $res : expr ) => {
236                 match $res {
237                         Ok(key) => key,
238                         //TODO: make the error a parameter
239                         Err(_) => return Err(HandleError{err: "Secp call failed - probably bad signature or evil data generated a bad pubkey/privkey", msg: None})
240                 }
241         };
242 }
243
244 macro_rules! get_key {
245         ( $ctx : expr, $slice : expr ) => {
246                 secp_call! (SecretKey::from_slice($ctx, $slice))
247         };
248 }
249
250 impl Channel {
251         // Convert constants + channel value to limits:
252         fn get_our_max_htlc_value_in_flight_msat(channel_value_satoshis: u64) -> u64 {
253                 channel_value_satoshis * 1000 / 10 //TODO
254         }
255
256         /// Guaranteed to return a value no larger than channel_value_satoshis
257         fn get_our_channel_reserve_satoshis(channel_value_satoshis: u64) -> u64 {
258                 cmp::min(channel_value_satoshis, 10) //TODO
259         }
260
261         fn derive_our_dust_limit_satoshis(at_open_background_feerate: u64) -> u64 {
262                 at_open_background_feerate * B_OUTPUT_PLUS_SPENDING_INPUT_WEIGHT //TODO
263         }
264
265         fn derive_our_htlc_minimum_msat(_at_open_channel_feerate_per_kw: u64) -> u64 {
266                 1000 // TODO
267         }
268
269         // Constructors:
270
271         /// panics if channel_value_satoshis is >= (1 << 24)
272         pub fn new_outbound(fee_estimator: &FeeEstimator, their_node_id: PublicKey, channel_value_satoshis: u64, announce_publicly: bool, user_id: u64) -> Channel {
273                 if channel_value_satoshis >= (1 << 24) {
274                         panic!("funding value > 2^24");
275                 }
276
277                 let mut rng = thread_rng();
278                 let feerate = fee_estimator.get_est_sat_per_vbyte(ConfirmationTarget::Normal);
279                 let background_feerate = fee_estimator.get_est_sat_per_vbyte(ConfirmationTarget::Background);
280
281                 let mut key_seed = [0u8; 32];
282                 rng.fill_bytes(&mut key_seed);
283                 let chan_keys = match ChannelKeys::new_from_seed(&key_seed) {
284                         Ok(key) => key,
285                         Err(_) => panic!("RNG is busted!")
286                 };
287
288                 let secp_ctx = Secp256k1::new();
289                 let our_channel_monitor_claim_key_hash = Hash160::from_data(&PublicKey::from_secret_key(&secp_ctx, &chan_keys.channel_monitor_claim_key).unwrap().serialize());
290                 let our_channel_monitor_claim_script = Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&our_channel_monitor_claim_key_hash[..]).into_script();
291                 let channel_monitor = ChannelMonitor::new(&chan_keys.revocation_base_key,
292                                                           &PublicKey::from_secret_key(&secp_ctx, &chan_keys.delayed_payment_base_key).unwrap(),
293                                                           &PublicKey::from_secret_key(&secp_ctx, &chan_keys.htlc_base_key).unwrap(),
294                                                           BREAKDOWN_TIMEOUT, our_channel_monitor_claim_script);
295
296                 Channel {
297                         user_id: user_id,
298
299                         channel_id: Uint256([rng.gen(), rng.gen(), rng.gen(), rng.gen()]),
300                         channel_state: ChannelState::OurInitSent as u32,
301                         channel_outbound: true,
302                         secp_ctx: secp_ctx,
303                         announce_publicly: announce_publicly,
304                         channel_value_satoshis: channel_value_satoshis,
305
306                         local_keys: chan_keys,
307                         cur_local_commitment_transaction_number: (1 << 48) - 1,
308                         cur_remote_commitment_transaction_number: (1 << 48) - 1,
309                         value_to_self_msat: channel_value_satoshis * 1000, //TODO: give them something on open? Parameterize it?
310                         pending_htlcs: Vec::new(),
311                         holding_cell_htlcs: Vec::new(),
312                         next_local_htlc_id: 0,
313                         next_remote_htlc_id: 0,
314                         channel_update_count: 0,
315
316                         funding_tx_confirmed_in: Default::default(),
317                         short_channel_id: None,
318                         last_block_connected: Default::default(),
319                         funding_tx_confirmations: 0,
320
321                         feerate_per_kw: feerate * 250,
322                         their_dust_limit_satoshis: 0,
323                         our_dust_limit_satoshis: Channel::derive_our_dust_limit_satoshis(background_feerate),
324                         their_max_htlc_value_in_flight_msat: 0,
325                         their_channel_reserve_satoshis: 0,
326                         their_htlc_minimum_msat: 0,
327                         our_htlc_minimum_msat: Channel::derive_our_htlc_minimum_msat(feerate * 250),
328                         their_to_self_delay: 0,
329                         their_max_accepted_htlcs: 0,
330
331                         their_funding_pubkey: PublicKey::new(),
332                         their_revocation_basepoint: PublicKey::new(),
333                         their_payment_basepoint: PublicKey::new(),
334                         their_delayed_payment_basepoint: PublicKey::new(),
335                         their_htlc_basepoint: PublicKey::new(),
336                         their_cur_commitment_point: PublicKey::new(),
337                         their_node_id: their_node_id,
338
339                         channel_monitor: channel_monitor,
340                 }
341         }
342
343         fn check_remote_fee(fee_estimator: &FeeEstimator, feerate_per_kw: u32) -> Result<(), HandleError> {
344                 if (feerate_per_kw as u64) < fee_estimator.get_est_sat_per_vbyte(ConfirmationTarget::Background) * 250 {
345                         return Err(HandleError{err: "Peer's feerate much too low", msg: None});
346                 }
347                 if (feerate_per_kw as u64) > fee_estimator.get_est_sat_per_vbyte(ConfirmationTarget::HighPriority) * 375 { // 375 = 250 * 1.5x
348                         return Err(HandleError{err: "Peer's feerate much too high", msg: None});
349                 }
350                 Ok(())
351         }
352
353         /// Creates a new channel from a remote sides' request for one.
354         /// Assumes chain_hash has already been checked and corresponds with what we expect!
355         pub fn new_from_req(fee_estimator: &FeeEstimator, their_node_id: PublicKey, msg: &msgs::OpenChannel, user_id: u64, announce_publicly: bool) -> Result<Channel, HandleError> {
356                 // Check sanity of message fields:
357                 if msg.funding_satoshis >= (1 << 24) {
358                         return Err(HandleError{err: "funding value > 2^24", msg: None});
359                 }
360                 if msg.funding_satoshis > 21000000 * 100000000 {
361                         return Err(HandleError{err: "More funding_satoshis than there are satoshis!", msg: None});
362                 }
363                 if msg.channel_reserve_satoshis > msg.funding_satoshis {
364                         return Err(HandleError{err: "Bogus channel_reserve_satoshis", msg: None});
365                 }
366                 if msg.push_msat > (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
367                         return Err(HandleError{err: "push_msat more than highest possible value", msg: None});
368                 }
369                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
370                         return Err(HandleError{err: "Peer never wants payout outputs?", msg: None});
371                 }
372                 if msg.max_htlc_value_in_flight_msat > msg.funding_satoshis * 1000 {
373                         return Err(HandleError{err: "Bogus max_htlc_value_in_flight_satoshis", msg: None});
374                 }
375                 if msg.htlc_minimum_msat >= (msg.funding_satoshis - msg.channel_reserve_satoshis) * 1000 {
376                         return Err(HandleError{err: "Minimum htlc value is full channel value", msg: None});
377                 }
378                 Channel::check_remote_fee(fee_estimator, msg.feerate_per_kw)?;
379                 if msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
380                         return Err(HandleError{err: "They wanted our payments to be delayed by a needlessly long period", msg: None});
381                 }
382                 if msg.max_accepted_htlcs < 1 {
383                         return Err(HandleError{err: "0 max_accpted_htlcs makes for a useless channel", msg: None});
384                 }
385                 if (msg.channel_flags & 254) != 0 {
386                         return Err(HandleError{err: "unknown channel_flags", msg: None});
387                 }
388
389                 // Convert things into internal flags and prep our state:
390
391                 let their_announce = if (msg.channel_flags & 1) == 1 { true } else { false };
392
393                 let background_feerate = fee_estimator.get_est_sat_per_vbyte(ConfirmationTarget::Background);
394
395                 let mut rng = thread_rng();
396                 let mut key_seed = [0u8; 32];
397                 rng.fill_bytes(&mut key_seed);
398                 let chan_keys = match ChannelKeys::new_from_seed(&key_seed) {
399                         Ok(key) => key,
400                         Err(_) => panic!("RNG is busted!")
401                 };
402
403                 let secp_ctx = Secp256k1::new();
404                 let our_channel_monitor_claim_key_hash = Hash160::from_data(&PublicKey::from_secret_key(&secp_ctx, &chan_keys.channel_monitor_claim_key).unwrap().serialize());
405                 let our_channel_monitor_claim_script = Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&our_channel_monitor_claim_key_hash[..]).into_script();
406                 let mut channel_monitor = ChannelMonitor::new(&chan_keys.revocation_base_key,
407                                                           &PublicKey::from_secret_key(&secp_ctx, &chan_keys.delayed_payment_base_key).unwrap(),
408                                                           &PublicKey::from_secret_key(&secp_ctx, &chan_keys.htlc_base_key).unwrap(),
409                                                           BREAKDOWN_TIMEOUT, our_channel_monitor_claim_script);
410                 channel_monitor.set_their_htlc_base_key(&msg.htlc_basepoint);
411
412                 let mut chan = Channel {
413                         user_id: user_id,
414
415                         channel_id: msg.temporary_channel_id,
416                         channel_state: (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32),
417                         channel_outbound: false,
418                         secp_ctx: secp_ctx,
419                         announce_publicly: their_announce && announce_publicly,
420
421                         local_keys: chan_keys,
422                         cur_local_commitment_transaction_number: (1 << 48) - 1,
423                         cur_remote_commitment_transaction_number: (1 << 48) - 1,
424                         value_to_self_msat: msg.push_msat,
425                         pending_htlcs: Vec::new(),
426                         holding_cell_htlcs: Vec::new(),
427                         next_local_htlc_id: 0,
428                         next_remote_htlc_id: 0,
429                         channel_update_count: 0,
430
431                         funding_tx_confirmed_in: Default::default(),
432                         short_channel_id: None,
433                         last_block_connected: Default::default(),
434                         funding_tx_confirmations: 0,
435
436                         feerate_per_kw: msg.feerate_per_kw as u64,
437                         channel_value_satoshis: msg.funding_satoshis,
438                         their_dust_limit_satoshis: msg.dust_limit_satoshis,
439                         our_dust_limit_satoshis: Channel::derive_our_dust_limit_satoshis(background_feerate),
440                         their_max_htlc_value_in_flight_msat: msg.max_htlc_value_in_flight_msat,
441                         their_channel_reserve_satoshis: msg.channel_reserve_satoshis,
442                         their_htlc_minimum_msat: msg.htlc_minimum_msat,
443                         our_htlc_minimum_msat: Channel::derive_our_htlc_minimum_msat(msg.feerate_per_kw as u64),
444                         their_to_self_delay: msg.to_self_delay,
445                         their_max_accepted_htlcs: msg.max_accepted_htlcs,
446
447                         their_funding_pubkey: msg.funding_pubkey,
448                         their_revocation_basepoint: msg.revocation_basepoint,
449                         their_payment_basepoint: msg.payment_basepoint,
450                         their_delayed_payment_basepoint: msg.delayed_payment_basepoint,
451                         their_htlc_basepoint: msg.htlc_basepoint,
452                         their_cur_commitment_point: msg.first_per_commitment_point,
453                         their_node_id: their_node_id,
454
455                         channel_monitor: channel_monitor,
456                 };
457
458                 let obscure_factor = chan.get_commitment_transaction_number_obscure_factor();
459                 chan.channel_monitor.set_commitment_obscure_factor(obscure_factor);
460
461                 Ok(chan)
462         }
463
464         // Utilities to derive keys:
465
466         fn build_local_commitment_secret(&self, idx: u64) -> Result<SecretKey, HandleError> {
467                 let res = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, idx);
468                 Ok(get_key!(&self.secp_ctx, &res))
469         }
470
471         // Utilities to build transactions:
472
473         fn get_commitment_transaction_number_obscure_factor(&self) -> u64 {
474                 let mut sha = Sha256::new();
475                 let our_payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key).unwrap();
476
477                 if self.channel_outbound {
478                         sha.input(&our_payment_basepoint.serialize());
479                         sha.input(&self.their_payment_basepoint.serialize());
480                 } else {
481                         sha.input(&self.their_payment_basepoint.serialize());
482                         sha.input(&our_payment_basepoint.serialize());
483                 }
484                 let mut res = [0; 32];
485                 sha.result(&mut res);
486
487                 ((res[26] as u64) << 5*8) |
488                 ((res[27] as u64) << 4*8) |
489                 ((res[28] as u64) << 3*8) |
490                 ((res[29] as u64) << 2*8) |
491                 ((res[30] as u64) << 1*8) |
492                 ((res[31] as u64) << 0*8)
493         }
494
495         /// Transaction nomenclature is somewhat confusing here as there are many different cases - a
496         /// transaction is referred to as "a's transaction" implying that a will be able to broadcast
497         /// the transaction. Thus, b will generally be sending a signature over such a transaction to
498         /// a, and a can revoke the transaction by providing b the relevant per_commitment_secret. As
499         /// such, a transaction is generally the result of b increasing the amount paid to a (or adding
500         /// an HTLC to a).
501         /// @local is used only to convert relevant internal structures which refer to remote vs local
502         /// to decide value of outputs and direction of HTLCs.
503         /// @generated_by_local is used to determine *which* HTLCs to include - noting that the HTLC
504         /// state may indicate that one peer has informed the other that they'd like to add an HTLC but
505         /// have not yet committed it. Such HTLCs will only be included in transactions which are being
506         /// generated by the peer which proposed adding the HTLCs, and thus we need to understand both
507         /// which peer generated this transaction and "to whom" this transaction flows.
508         #[inline]
509         fn build_commitment_transaction(&self, commitment_number: u64, keys: &TxCreationKeys, local: bool, generated_by_local: bool) -> Result<(Transaction, Vec<HTLCOutputInCommitment>), HandleError> {
510                 let obscured_commitment_transaction_number = self.get_commitment_transaction_number_obscure_factor() ^ commitment_number;
511
512                 let txins = {
513                         let mut ins: Vec<TxIn> = Vec::new();
514                         ins.push(TxIn {
515                                 prev_hash: self.channel_monitor.get_funding_txo().unwrap().0,
516                                 prev_index: self.channel_monitor.get_funding_txo().unwrap().1 as u32,
517                                 script_sig: Script::new(),
518                                 sequence: ((0x80 as u32) << 8*3) | ((obscured_commitment_transaction_number >> 3*8) as u32)
519                         });
520                         ins
521                 };
522                 let mut witness: Vec<Vec<Vec<u8>>> = Vec::new();
523                 witness.push(Vec::new());
524
525                 let mut txouts: Vec<(TxOut, Option<HTLCOutputInCommitment>)> = Vec::new();
526
527                 let dust_limit_satoshis = if local { self.our_dust_limit_satoshis } else { self.their_dust_limit_satoshis };
528                 let mut remote_htlc_total_msat = 0;
529                 let mut local_htlc_total_msat = 0;
530
531                 for ref htlc in self.pending_htlcs.iter() {
532                         if htlc.state == HTLCState::Committed || htlc.state == (if generated_by_local { HTLCState::LocalAnnounced } else { HTLCState::RemoteAnnounced }) {
533                                 if htlc.outbound == local { // "offered HTLC output"
534                                         if htlc.amount_msat / 1000 >= dust_limit_satoshis + (self.feerate_per_kw * HTLC_TIMEOUT_TX_WEIGHT / 1000) {
535                                                 let htlc_in_tx = htlc.get_in_commitment(true);
536                                                 txouts.push((TxOut {
537                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys, true).to_v0_p2wsh(),
538                                                         value: htlc.amount_msat / 1000
539                                                 }, Some(htlc_in_tx)));
540                                         }
541                                 } else {
542                                         if htlc.amount_msat / 1000 >= dust_limit_satoshis + (self.feerate_per_kw * HTLC_SUCCESS_TX_WEIGHT / 1000) {
543                                                 let htlc_in_tx = htlc.get_in_commitment(false);
544                                                 txouts.push((TxOut { // "received HTLC output"
545                                                         script_pubkey: chan_utils::get_htlc_redeemscript(&htlc_in_tx, &keys, false).to_v0_p2wsh(),
546                                                         value: htlc.amount_msat / 1000
547                                                 }, Some(htlc_in_tx)));
548                                         }
549                                 };
550                                 if htlc.outbound {
551                                         local_htlc_total_msat += htlc.amount_msat;
552                                 } else {
553                                         remote_htlc_total_msat += htlc.amount_msat;
554                                 }
555                         }
556                 }
557
558                 let total_fee: u64 = self.feerate_per_kw * (COMMITMENT_TX_BASE_WEIGHT + (txouts.len() as u64) * COMMITMENT_TX_WEIGHT_PER_HTLC) / 1000;
559                 let value_to_self: i64 = ((self.value_to_self_msat - local_htlc_total_msat) as i64) / 1000 - if self.channel_outbound { total_fee as i64 } else { 0 };
560                 let value_to_remote: i64 = (((self.channel_value_satoshis * 1000 - self.value_to_self_msat - remote_htlc_total_msat) / 1000) as i64) - if self.channel_outbound { 0 } else { total_fee as i64 };
561
562                 let value_to_a = if local { value_to_self } else { value_to_remote };
563                 let value_to_b = if local { value_to_remote } else { value_to_self };
564
565                 if value_to_a >= (dust_limit_satoshis as i64) {
566                         txouts.push((TxOut {
567                                 script_pubkey: chan_utils::get_revokeable_redeemscript(&keys.revocation_key,
568                                                                                        if local { self.their_to_self_delay } else { BREAKDOWN_TIMEOUT },
569                                                                                        &keys.a_delayed_payment_key).to_v0_p2wsh(),
570                                 value: value_to_a as u64
571                         }, None));
572                 }
573
574                 if value_to_b >= (dust_limit_satoshis as i64) {
575                         txouts.push((TxOut {
576                                 script_pubkey: Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0)
577                                                              .push_slice(&Hash160::from_data(&keys.b_payment_key.serialize())[..])
578                                                              .into_script(),
579                                 value: value_to_b as u64
580                         }, None));
581                 }
582
583                 transaction_utils::sort_outputs(&mut txouts);
584
585                 let mut outputs: Vec<TxOut> = Vec::new();
586                 let mut htlcs_used: Vec<HTLCOutputInCommitment> = Vec::new();
587                 for (idx, out) in txouts.drain(..).enumerate() {
588                         outputs.push(out.0);
589                         match out.1 {
590                                 Some(out_htlc) => {
591                                         htlcs_used.push(out_htlc);
592                                         htlcs_used.last_mut().unwrap().transaction_output_index = idx as u32;
593                                 },
594                                 None => {}
595                         }
596                 }
597
598                 Ok((Transaction {
599                         version: 2,
600                         lock_time: ((0x20 as u32) << 8*3) | ((obscured_commitment_transaction_number & 0xffffffu64) as u32),
601                         input: txins,
602                         output: outputs,
603                         witness: witness
604                 }, htlcs_used))
605         }
606
607         #[inline]
608         /// Creates a set of keys for build_commitment_transaction to generate a transaction which our
609         /// counterparty will sign (ie DO NOT send signatures over a transaction created by this to
610         /// our counterparty!)
611         /// The result is a transaction which we can revoke ownership of (ie a "local" transaction)
612         /// TODO Some magic rust shit to compile-time check this?
613         fn build_local_transaction_keys(&self, commitment_number: u64) -> Result<TxCreationKeys, HandleError> {
614                 let per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(commitment_number)?).unwrap();
615                 let delayed_payment_base = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key).unwrap();
616                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key).unwrap();
617
618                 Ok(secp_call!(TxCreationKeys::new(&self.secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &self.their_revocation_basepoint, &self.their_payment_basepoint, &self.their_htlc_basepoint)))
619         }
620
621         #[inline]
622         /// Creates a set of keys for build_commitment_transaction to generate a transaction which we
623         /// will sign and send to our counterparty.
624         fn build_remote_transaction_keys(&self) -> Result<TxCreationKeys, HandleError> {
625                 //TODO: Ensure that the payment_key derived here ends up in the library users' wallet as we
626                 //may see payments to it!
627                 let payment_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key).unwrap();
628                 let revocation_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key).unwrap();
629                 let htlc_basepoint = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key).unwrap();
630
631                 Ok(secp_call!(TxCreationKeys::new(&self.secp_ctx, &self.their_cur_commitment_point, &self.their_delayed_payment_basepoint, &self.their_htlc_basepoint, &revocation_basepoint, &payment_basepoint, &htlc_basepoint)))
632         }
633
634         /// Gets the redeemscript for the funding transaction output (ie the funding transaction output
635         /// pays to get_funding_redeemscript().to_v0_p2wsh()).
636         pub fn get_funding_redeemscript(&self) -> Script {
637                 let builder = Builder::new().push_opcode(opcodes::All::OP_PUSHNUM_2);
638                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).unwrap().serialize();
639                 let their_funding_key = self.their_funding_pubkey.serialize();
640                 if our_funding_key[..] < their_funding_key[..] {
641                         builder.push_slice(&our_funding_key)
642                                 .push_slice(&their_funding_key)
643                 } else {
644                         builder.push_slice(&their_funding_key)
645                                 .push_slice(&our_funding_key)
646                 }.push_opcode(opcodes::All::OP_PUSHNUM_2).push_opcode(opcodes::All::OP_CHECKMULTISIG).into_script()
647         }
648
649         fn sign_commitment_transaction(&self, tx: &mut Transaction, their_sig: &Signature) -> Result<(), HandleError> {
650                 if tx.input.len() != 1 {
651                         panic!("Tried to sign commitment transaction that had input count != 1!");
652                 }
653                 if tx.witness.len() != 1 || tx.witness[0].len() != 0 {
654                         panic!("Tried to re-sign commitment transaction");
655                 }
656
657                 let funding_redeemscript = self.get_funding_redeemscript();
658
659                 let sighash = secp_call!(Message::from_slice(&bip143::SighashComponents::new(&tx).sighash_all(&tx, 0, &funding_redeemscript, self.channel_value_satoshis)[..]));
660                 let our_sig = secp_call!(self.secp_ctx.sign(&sighash, &self.local_keys.funding_key));
661
662                 tx.witness[0].push(Vec::new()); // First is the multisig dummy
663
664                 let our_funding_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).unwrap().serialize();
665                 let their_funding_key = self.their_funding_pubkey.serialize();
666                 if our_funding_key[..] < their_funding_key[..] {
667                         tx.witness[0].push(our_sig.serialize_der(&self.secp_ctx).to_vec());
668                         tx.witness[0].push(their_sig.serialize_der(&self.secp_ctx).to_vec());
669                 } else {
670                         tx.witness[0].push(their_sig.serialize_der(&self.secp_ctx).to_vec());
671                         tx.witness[0].push(our_sig.serialize_der(&self.secp_ctx).to_vec());
672                 }
673                 tx.witness[0][1].push(SigHashType::All as u8);
674                 tx.witness[0][2].push(SigHashType::All as u8);
675
676                 tx.witness[0].push(funding_redeemscript.into_vec());
677
678                 Ok(())
679         }
680
681         /// Builds the htlc-success or htlc-timeout transaction which spends a given HTLC output
682         /// @local is used only to convert relevant internal structures which refer to remote vs local
683         /// to decide value of outputs and direction of HTLCs.
684         fn build_htlc_transaction(&self, prev_hash: &Sha256dHash, htlc: &HTLCOutputInCommitment, local: bool, keys: &TxCreationKeys) -> Result<Transaction, HandleError> {
685                 let mut txins: Vec<TxIn> = Vec::new();
686                 txins.push(TxIn {
687                         prev_hash: prev_hash.clone(),
688                         prev_index: htlc.transaction_output_index,
689                         script_sig: Script::new(),
690                         sequence: 0
691                 });
692
693                 let mut witnesses: Vec<Vec<Vec<u8>>> = Vec::new();
694                 witnesses.push(Vec::new());
695
696                 let total_fee = if htlc.offered {
697                                 self.feerate_per_kw * HTLC_TIMEOUT_TX_WEIGHT / 1000
698                         } else {
699                                 self.feerate_per_kw * HTLC_SUCCESS_TX_WEIGHT / 1000
700                         };
701
702                 let mut txouts: Vec<TxOut> = Vec::new();
703                 txouts.push(TxOut {
704                         script_pubkey: chan_utils::get_revokeable_redeemscript(&keys.revocation_key,
705                                                                                if local { self.their_to_self_delay } else { BREAKDOWN_TIMEOUT },
706                                                                                &keys.a_delayed_payment_key).to_v0_p2wsh(),
707                         value: htlc.amount_msat / 1000 - total_fee //TODO: BOLT 3 does not specify if we should add amount_msat before dividing or if we should divide by 1000 before subtracting (as we do here)
708                 });
709
710                 Ok(Transaction {
711                         version: 2,
712                         lock_time: if htlc.offered { htlc.cltv_expiry } else { 0 },
713                         input: txins,
714                         output: txouts,
715                         witness: witnesses
716                 })
717         }
718
719         /// Signs a transaction created by build_htlc_transaction. If the transaction is an
720         /// HTLC-Success transaction (ie htlc.offered is false), preimate must be set!
721         fn sign_htlc_transaction(&self, tx: &mut Transaction, their_sig: &Signature, preimage: &Option<[u8; 32]>, htlc: &HTLCOutputInCommitment, keys: &TxCreationKeys) -> Result<(), HandleError> {
722                 if tx.input.len() != 1 {
723                         panic!("Tried to sign HTLC transaction that had input count != 1!");
724                 }
725                 if tx.witness.len() != 1 || tx.witness[0].len() != 0 {
726                         panic!("Tried to re-sign HTLC transaction");
727                 }
728
729                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys, htlc.offered);
730
731                 let our_htlc_key = secp_call!(chan_utils::derive_private_key(&self.secp_ctx, &keys.per_commitment_point, &self.local_keys.htlc_base_key));
732                 let sighash = secp_call!(Message::from_slice(&bip143::SighashComponents::new(&tx).sighash_all(&tx, 0, &htlc_redeemscript, htlc.amount_msat / 1000)[..]));
733                 let our_sig = secp_call!(self.secp_ctx.sign(&sighash, &our_htlc_key));
734
735                 let local_tx = PublicKey::from_secret_key(&self.secp_ctx, &our_htlc_key).unwrap() == keys.a_htlc_key;
736
737                 tx.witness[0].push(Vec::new()); // First is the multisig dummy
738
739                 if local_tx { // b, then a
740                         tx.witness[0].push(their_sig.serialize_der(&self.secp_ctx).to_vec());
741                         tx.witness[0].push(our_sig.serialize_der(&self.secp_ctx).to_vec());
742                 } else {
743                         tx.witness[0].push(our_sig.serialize_der(&self.secp_ctx).to_vec());
744                         tx.witness[0].push(their_sig.serialize_der(&self.secp_ctx).to_vec());
745                 }
746                 tx.witness[0][1].push(SigHashType::All as u8);
747                 tx.witness[0][2].push(SigHashType::All as u8);
748
749                 if htlc.offered {
750                         tx.witness[0].push(Vec::new());
751                 } else {
752                         tx.witness[0].push(preimage.unwrap().to_vec());
753                 }
754
755                 tx.witness[0].push(htlc_redeemscript.into_vec());
756
757                 Ok(())
758         }
759
760         pub fn get_update_fulfill_htlc(&mut self, payment_preimage: [u8; 32]) -> Result<msgs::UpdateFulfillHTLC, HandleError> {
761                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
762                         return Err(HandleError{err: "Was asked to fulfill an HTLC when channel was not in an operational state", msg: None});
763                 }
764
765                 let mut sha = Sha256::new();
766                 sha.input(&payment_preimage);
767                 let mut payment_hash = [0; 32];
768                 sha.result(&mut payment_hash);
769
770                 let mut htlc_id = 0;
771                 let mut htlc_amount_msat = 0;
772                 self.pending_htlcs.retain(|ref htlc| {
773                         if !htlc.outbound && htlc.payment_hash == payment_hash {
774                                 if htlc_id != 0 {
775                                         panic!("Duplicate HTLC payment_hash, you probably re-used payment preimages, NEVER DO THIS!");
776                                 }
777                                 htlc_id = htlc.htlc_id;
778                                 htlc_amount_msat += htlc.amount_msat;
779                                 false
780                         } else { true }
781                 });
782                 if htlc_amount_msat == 0 {
783                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given payment preimage", msg: None});
784                 }
785
786                 //TODO: This is racy af, they may have pending messages in flight to us that will not have
787                 //received this yet!
788                 self.value_to_self_msat += htlc_amount_msat;
789                 Ok(msgs::UpdateFulfillHTLC {
790                         channel_id: self.channel_id(),
791                         htlc_id: htlc_id,
792                         payment_preimage: payment_preimage,
793                 })
794         }
795
796         pub fn get_update_fail_htlc(&mut self, payment_hash: &[u8; 32], err_packet: msgs::OnionErrorPacket) -> Result<msgs::UpdateFailHTLC, HandleError> {
797                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
798                         return Err(HandleError{err: "Was asked to fail an HTLC when channel was not in an operational state", msg: None});
799                 }
800
801                 let mut htlc_id = 0;
802                 let mut htlc_amount_msat = 0;
803                 self.pending_htlcs.retain(|ref htlc| {
804                         if !htlc.outbound && htlc.payment_hash == *payment_hash {
805                                 if htlc_id != 0 {
806                                         panic!("Duplicate HTLC payment_hash, you probably re-used payment preimages, NEVER DO THIS!");
807                                 }
808                                 htlc_id = htlc.htlc_id;
809                                 htlc_amount_msat += htlc.amount_msat;
810                                 false
811                         } else { true }
812                 });
813                 if htlc_amount_msat == 0 {
814                         return Err(HandleError{err: "Unable to find a pending HTLC which matched the given payment preimage", msg: None});
815                 }
816
817                 //TODO: This is racy af, they may have pending messages in flight to us that will not have
818                 //received this yet!
819
820                 Ok(msgs::UpdateFailHTLC {
821                         channel_id: self.channel_id(),
822                         htlc_id,
823                         reason: err_packet
824                 })
825         }
826
827         // Message handlers:
828
829         pub fn accept_channel(&mut self, msg: &msgs::AcceptChannel) -> Result<(), HandleError> {
830                 // Check sanity of message fields:
831                 if !self.channel_outbound {
832                         return Err(HandleError{err: "Got an accept_channel message from an inbound peer", msg: None});
833                 }
834                 if self.channel_state != ChannelState::OurInitSent as u32 {
835                         return Err(HandleError{err: "Got an accept_channel message at a strange time", msg: None});
836                 }
837                 if msg.dust_limit_satoshis > 21000000 * 100000000 {
838                         return Err(HandleError{err: "Peer never wants payout outputs?", msg: None});
839                 }
840                 if msg.max_htlc_value_in_flight_msat > self.channel_value_satoshis * 1000 {
841                         return Err(HandleError{err: "Bogus max_htlc_value_in_flight_satoshis", msg: None});
842                 }
843                 if msg.channel_reserve_satoshis > self.channel_value_satoshis {
844                         return Err(HandleError{err: "Bogus channel_reserve_satoshis", msg: None});
845                 }
846                 if msg.htlc_minimum_msat >= (self.channel_value_satoshis - msg.channel_reserve_satoshis) * 1000 {
847                         return Err(HandleError{err: "Minimum htlc value is full channel value", msg: None});
848                 }
849                 //TODO do something with minimum_depth
850                 if msg.to_self_delay > MAX_LOCAL_BREAKDOWN_TIMEOUT {
851                         return Err(HandleError{err: "They wanted our payments to be delayed by a needlessly long period", msg: None});
852                 }
853                 if msg.max_accepted_htlcs < 1 {
854                         return Err(HandleError{err: "0 max_accpted_htlcs makes for a useless channel", msg: None});
855                 }
856
857                 self.channel_monitor.set_their_htlc_base_key(&msg.htlc_basepoint);
858
859                 self.their_dust_limit_satoshis = msg.dust_limit_satoshis;
860                 self.their_max_htlc_value_in_flight_msat = msg.max_htlc_value_in_flight_msat;
861                 self.their_channel_reserve_satoshis = msg.channel_reserve_satoshis;
862                 self.their_htlc_minimum_msat = msg.htlc_minimum_msat;
863                 self.their_to_self_delay = msg.to_self_delay;
864                 self.their_max_accepted_htlcs = msg.max_accepted_htlcs;
865                 self.their_funding_pubkey = msg.funding_pubkey;
866                 self.their_revocation_basepoint = msg.revocation_basepoint;
867                 self.their_payment_basepoint = msg.payment_basepoint;
868                 self.their_delayed_payment_basepoint = msg.delayed_payment_basepoint;
869                 self.their_htlc_basepoint = msg.htlc_basepoint;
870                 self.their_cur_commitment_point = msg.first_per_commitment_point;
871
872                 let obscure_factor = self.get_commitment_transaction_number_obscure_factor();
873                 self.channel_monitor.set_commitment_obscure_factor(obscure_factor);
874
875                 self.channel_state = ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32;
876
877                 Ok(())
878         }
879
880         fn funding_created_signature(&mut self, sig: &Signature) -> Result<(Transaction, Signature), HandleError> {
881                 let funding_script = self.get_funding_redeemscript();
882
883                 let remote_keys = self.build_remote_transaction_keys()?;
884                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false)?.0;
885                 let remote_sighash = secp_call!(Message::from_slice(&bip143::SighashComponents::new(&remote_initial_commitment_tx).sighash_all(&remote_initial_commitment_tx, 0, &funding_script, self.channel_value_satoshis)[..]));
886
887                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
888                 let local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false)?.0;
889                 let local_sighash = secp_call!(Message::from_slice(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx, 0, &funding_script, self.channel_value_satoshis)[..]));
890
891                 // They sign the "local" commitment transaction, allowing us to broadcast the tx if we wish.
892                 secp_call!(self.secp_ctx.verify(&local_sighash, &sig, &self.their_funding_pubkey));
893
894                 // We sign the "remote" commitment transaction, allowing them to broadcast the tx if they wish.
895                 Ok((remote_initial_commitment_tx, secp_call!(self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key))))
896         }
897
898         pub fn funding_created(&mut self, msg: &msgs::FundingCreated) -> Result<msgs::FundingSigned, HandleError> {
899                 if self.channel_outbound {
900                         return Err(HandleError{err: "Received funding_created for an outbound channel?", msg: None});
901                 }
902                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
903                         return Err(HandleError{err: "Received funding_created after we got the channel!", msg: None});
904                 }
905                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) || self.cur_remote_commitment_transaction_number != (1 << 48) - 1 || self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
906                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
907                 }
908
909                 self.channel_monitor.set_funding_info(msg.funding_txid, msg.funding_output_index);
910
911                 let (remote_initial_commitment_tx, our_signature) = match self.funding_created_signature(&msg.signature) {
912                         Ok((remote_initial_commitment_tx, sig)) => (remote_initial_commitment_tx, sig),
913                         Err(e) => {
914                                 self.channel_monitor.unset_funding_info();
915                                 return Err(e);
916                         }
917                 };
918
919                 // Now that we're past error-generating stuff, update our local state:
920
921                 //TODO: Determine which tx index in remote_initial_commitment_transaction's outputs
922                 //represent a revokeable script!
923                 self.channel_monitor.provide_tx_info(&remote_initial_commitment_tx, 0, Vec::new());
924                 self.channel_state = ChannelState::FundingSent as u32;
925                 let funding_txo = self.channel_monitor.get_funding_txo().unwrap();
926                 self.channel_id = funding_txo.0.into_be() ^ Uint256::from_u64(funding_txo.1 as u64).unwrap(); //TODO: or le?
927
928                 Ok(msgs::FundingSigned {
929                         channel_id: self.channel_id,
930                         signature: our_signature
931                 })
932         }
933
934         /// Handles a funding_signed message from the remote end.
935         /// If this call is successful, broadcast the funding transaction (and not before!)
936         pub fn funding_signed(&mut self, msg: &msgs::FundingSigned) -> Result<(), HandleError> {
937                 if !self.channel_outbound {
938                         return Err(HandleError{err: "Received funding_signed for an inbound channel?", msg: None});
939                 }
940                 if self.channel_state != ChannelState::FundingCreated as u32 {
941                         return Err(HandleError{err: "Received funding_signed in strange state!", msg: None});
942                 }
943                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) || self.cur_remote_commitment_transaction_number != (1 << 48) - 1 || self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
944                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
945                 }
946
947                 let funding_script = self.get_funding_redeemscript();
948
949                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
950                 let local_initial_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false)?.0;
951                 let local_sighash = secp_call!(Message::from_slice(&bip143::SighashComponents::new(&local_initial_commitment_tx).sighash_all(&local_initial_commitment_tx, 0, &funding_script, self.channel_value_satoshis)[..]));
952
953                 // They sign the "local" commitment transaction, allowing us to broadcast the tx if we wish.
954                 secp_call!(self.secp_ctx.verify(&local_sighash, &msg.signature, &self.their_funding_pubkey));
955
956                 self.channel_state = ChannelState::FundingSent as u32;
957
958                 Ok(())
959         }
960
961         pub fn funding_locked(&mut self, msg: &msgs::FundingLocked) -> Result<(), HandleError> {
962                 if self.channel_state == ChannelState::FundingSent as u32 {
963                         self.channel_state |= ChannelState::TheirFundingLocked as u32;
964                 } else if self.channel_state == (ChannelState::FundingSent as u32 | ChannelState::OurFundingLocked as u32) {
965                         self.channel_state = ChannelState::ChannelFunded as u32;
966                 } else if self.channel_state < ChannelState::FundingSent as u32 {
967                         return Err(HandleError{err: "Peer sent a funding_locked before we'd even been told the funding txid", msg: None});
968                 }
969
970                 //TODO: Note that this must be a duplicate of the previous commitment point they sent us,
971                 //as otherwise we will have a commitment transaction that they can't revoke (well, kinda,
972                 //they can by sending two revoke_and_acks back-to-back, but not really). This appears to be
973                 //a protocol oversight, but I assume I'm just missing something.
974                 if self.their_cur_commitment_point != msg.next_per_commitment_point {
975                         return Err(HandleError{err: "Non-duplicate next_per_commitment_point in funding_locked", msg: None});
976                 }
977                 self.their_cur_commitment_point = msg.next_per_commitment_point;
978                 Ok(())
979         }
980
981         /// Returns (inbound_htlc_count, outbound_htlc_count, htlc_outbound_value_msat, htlc_inbound_value_msat)
982         fn get_pending_htlc_stats(&self) -> (u32, u32, u64, u64) {
983                 let mut inbound_htlc_count: u32 = 0;
984                 let mut outbound_htlc_count: u32 = 0;
985                 let mut htlc_outbound_value_msat = 0;
986                 let mut htlc_inbound_value_msat = 0;
987                 for ref htlc in self.pending_htlcs.iter() {
988                         if !htlc.outbound {
989                                 inbound_htlc_count += 1;
990                                 htlc_inbound_value_msat += htlc.amount_msat;
991                         } else {
992                                 outbound_htlc_count += 1;
993                                 htlc_outbound_value_msat += htlc.amount_msat;
994                         }
995                 }
996                 (inbound_htlc_count, outbound_htlc_count, htlc_outbound_value_msat, htlc_inbound_value_msat)
997         }
998
999         pub fn update_add_htlc(&mut self, msg: &msgs::UpdateAddHTLC, pending_forward_state: PendingForwardHTLCInfo) -> Result<(), HandleError> {
1000                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1001                         return Err(HandleError{err: "Got add HTLC message when channel was not in an operational state", msg: None});
1002                 }
1003                 if msg.amount_msat > self.channel_value_satoshis * 1000 {
1004                         return Err(HandleError{err: "Remote side tried to send more than the total value of the channel", msg: None});
1005                 }
1006                 if msg.amount_msat < self.our_htlc_minimum_msat {
1007                         return Err(HandleError{err: "Remote side tried to send less than our minimum HTLC value", msg: None});
1008                 }
1009
1010                 let (inbound_htlc_count, _, htlc_outbound_value_msat, htlc_inbound_value_msat) = self.get_pending_htlc_stats();
1011                 if inbound_htlc_count + 1 > OUR_MAX_HTLCS as u32 {
1012                         return Err(HandleError{err: "Remote tried to push more than our max accepted HTLCs", msg: None});
1013                 }
1014                 //TODO: Spec is unclear if this is per-direction or in total (I assume per direction):
1015                 // Check our_max_htlc_value_in_flight_msat
1016                 if htlc_inbound_value_msat + msg.amount_msat > Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis) {
1017                         return Err(HandleError{err: "Remote HTLC add would put them over their max HTLC value in flight", msg: None});
1018                 }
1019                 // Check our_channel_reserve_satoshis (we're getting paid, so they have to at least meet
1020                 // the reserve_satoshis we told them to always have as direct payment so that they lose
1021                 // something if we punish them for broadcasting an old state).
1022                 if htlc_inbound_value_msat + htlc_outbound_value_msat + msg.amount_msat + self.value_to_self_msat > (self.channel_value_satoshis - Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis)) * 1000 {
1023                         return Err(HandleError{err: "Remote HTLC add would put them over their reserve value", msg: None});
1024                 }
1025                 if self.next_remote_htlc_id != msg.htlc_id {
1026                         return Err(HandleError{err: "Remote skipped HTLC ID", msg: None});
1027                 }
1028                 if msg.cltv_expiry >= 500000000 {
1029                         return Err(HandleError{err: "Remote provided CLTV expiry in seconds instead of block height", msg: None});
1030                 }
1031
1032                 //TODO: Check msg.cltv_expiry further? Do this in channel manager?
1033
1034                 // Now update local state:
1035                 self.next_remote_htlc_id += 1;
1036                 self.pending_htlcs.push(HTLCOutput {
1037                         outbound: false,
1038                         htlc_id: msg.htlc_id,
1039                         amount_msat: msg.amount_msat,
1040                         payment_hash: msg.payment_hash,
1041                         cltv_expiry: msg.cltv_expiry,
1042                         state: HTLCState::RemoteAnnounced,
1043                         pending_forward_state: Some(pending_forward_state),
1044                 });
1045
1046                 Ok(())
1047         }
1048
1049         /// Removes an outbound HTLC which has been commitment_signed by the remote end
1050         fn remove_outbound_htlc(&mut self, htlc_id: u64, check_preimage: Option<[u8; 32]>) -> Result<HTLCOutput, HandleError> {
1051                 let mut found_idx = None;
1052                 for (idx, ref htlc) in self.pending_htlcs.iter().enumerate() {
1053                         if htlc.outbound && htlc.htlc_id == htlc_id {
1054                                 match check_preimage {
1055                                         None => {},
1056                                         Some(payment_hash) =>
1057                                                 if payment_hash != htlc.payment_hash {
1058                                                         return Err(HandleError{err: "Remote tried to fulfill HTLC with an incorrect preimage", msg: None});
1059                                                 }
1060                                 };
1061                                 found_idx = Some(idx);
1062                                 break;
1063                         }
1064                 }
1065                 match found_idx {
1066                         None => Err(HandleError{err: "Remote tried to fulfill/fail an HTLC we couldn't find", msg: None}),
1067                         Some(idx) => {
1068                                 Ok(self.pending_htlcs.swap_remove(idx))
1069                         }
1070                 }
1071         }
1072
1073         /// Used to fulfill holding_cell_htlcs when we get a remote ack (or implicitly get it by them
1074         /// fulfilling or failing the last pending HTLC)
1075         fn free_holding_cell_htlcs(&mut self) -> Result<Option<(Vec<msgs::UpdateAddHTLC>, msgs::CommitmentSigned)>, HandleError> {
1076                 if self.holding_cell_htlcs.len() != 0 {
1077                         let mut new_htlcs = self.holding_cell_htlcs.split_off(0);
1078                         let mut update_add_msgs = Vec::with_capacity(new_htlcs.len());
1079                         let mut err = None;
1080                         for new_htlc in new_htlcs.drain(..) {
1081                                 // Note that this *can* fail, though it should be due to rather-rare conditions on
1082                                 // fee races with adding too many outputs which push our total payments just over
1083                                 // the limit. In case its less rare than I anticipate, we may want to revisit
1084                                 // handling this case better and maybe fufilling some of the HTLCs while attempting
1085                                 // to rebalance channels.
1086                                 if self.holding_cell_htlcs.len() != 0 {
1087                                         self.holding_cell_htlcs.push(new_htlc);
1088                                 } else {
1089                                         match self.send_htlc(new_htlc.amount_msat, new_htlc.payment_hash, new_htlc.cltv_expiry, new_htlc.onion_routing_packet.clone()) {
1090                                                 Ok(update_add_msg_option) => update_add_msgs.push(update_add_msg_option.unwrap()),
1091                                                 Err(e) => {
1092                                                         self.holding_cell_htlcs.push(new_htlc);
1093                                                         err = Some(e);
1094                                                 }
1095                                         }
1096                                 }
1097                         }
1098                         //TODO: Need to examine the type of err - if its a fee issue or similar we may want to
1099                         //fail it back the route, if its a temporary issue we can ignore it...
1100                         if update_add_msgs.len() > 0 {
1101                                 Ok(Some((update_add_msgs, self.send_commitment()?)))
1102                         } else {
1103                                 Err(err.unwrap())
1104                         }
1105                 } else {
1106                         Ok(None)
1107                 }
1108         }
1109
1110         /// Checks if there are any LocalAnnounced HTLCs remaining and sets
1111         /// ChannelState::AwaitingRemoteRevoke accordingly, possibly calling free_holding_cell_htlcs.
1112         fn check_and_free_holding_cell_htlcs(&mut self) -> Result<Option<(Vec<msgs::UpdateAddHTLC>, msgs::CommitmentSigned)>, HandleError> {
1113                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
1114                         for htlc in self.pending_htlcs.iter() {
1115                                 if htlc.state == HTLCState::LocalAnnounced {
1116                                         return Ok(None);
1117                                 }
1118                         }
1119                         self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
1120                         self.free_holding_cell_htlcs()
1121                 } else {
1122                         Ok(None)
1123                 }
1124         }
1125
1126         pub fn update_fulfill_htlc(&mut self, msg: &msgs::UpdateFulfillHTLC) -> Result<Option<(Vec<msgs::UpdateAddHTLC>, msgs::CommitmentSigned)>, HandleError> {
1127                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1128                         return Err(HandleError{err: "Got add HTLC message when channel was not in an operational state", msg: None});
1129                 }
1130
1131                 let mut sha = Sha256::new();
1132                 sha.input(&msg.payment_preimage);
1133                 let mut payment_hash = [0; 32];
1134                 sha.result(&mut payment_hash);
1135
1136                 match self.remove_outbound_htlc(msg.htlc_id, Some(payment_hash)) {
1137                         Err(e) => return Err(e),
1138                         Ok(htlc) => {
1139                                 //TODO: Double-check that we didn't exceed some limits (or value_to_self went
1140                                 //negative here?)
1141                                 self.value_to_self_msat -= htlc.amount_msat;
1142                         }
1143                 }
1144
1145                 self.check_and_free_holding_cell_htlcs()
1146         }
1147
1148         pub fn update_fail_htlc(&mut self, msg: &msgs::UpdateFailHTLC) -> Result<([u8; 32], Option<(Vec<msgs::UpdateAddHTLC>, msgs::CommitmentSigned)>), HandleError> {
1149                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1150                         return Err(HandleError{err: "Got add HTLC message when channel was not in an operational state", msg: None});
1151                 }
1152
1153                 let payment_hash = match self.remove_outbound_htlc(msg.htlc_id, None) {
1154                         Err(e) => return Err(e),
1155                         Ok(htlc) => {
1156                                 //TODO: Double-check that we didn't exceed some limits (or value_to_self went
1157                                 //negative here?)
1158                                 htlc.payment_hash
1159                         }
1160                 };
1161
1162                 let holding_cell_freedom = self.check_and_free_holding_cell_htlcs()?;
1163                 Ok((payment_hash, holding_cell_freedom))
1164         }
1165
1166         pub fn update_fail_malformed_htlc(&mut self, msg: &msgs::UpdateFailMalformedHTLC) -> Result<([u8; 32], Option<(Vec<msgs::UpdateAddHTLC>, msgs::CommitmentSigned)>), HandleError> {
1167                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1168                         return Err(HandleError{err: "Got add HTLC message when channel was not in an operational state", msg: None});
1169                 }
1170
1171                 let payment_hash = match self.remove_outbound_htlc(msg.htlc_id, None) {
1172                         Err(e) => return Err(e),
1173                         Ok(htlc) => {
1174                                 //TODO: Double-check that we didn't exceed some limits (or value_to_self went
1175                                 //negative here?)
1176                                 htlc.payment_hash
1177                         }
1178                 };
1179
1180                 let holding_cell_freedom = self.check_and_free_holding_cell_htlcs()?;
1181                 Ok((payment_hash, holding_cell_freedom))
1182         }
1183
1184         pub fn commitment_signed(&mut self, msg: &msgs::CommitmentSigned) -> Result<(msgs::RevokeAndACK, Vec<PendingForwardHTLCInfo>), HandleError> {
1185                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1186                         return Err(HandleError{err: "Got commitment signed message when channel was not in an operational state", msg: None});
1187                 }
1188
1189                 let funding_script = self.get_funding_redeemscript();
1190
1191                 let local_keys = self.build_local_transaction_keys(self.cur_local_commitment_transaction_number)?;
1192                 let local_commitment_tx = self.build_commitment_transaction(self.cur_local_commitment_transaction_number, &local_keys, true, false)?;
1193                 let local_sighash = secp_call!(Message::from_slice(&bip143::SighashComponents::new(&local_commitment_tx.0).sighash_all(&local_commitment_tx.0, 0, &funding_script, self.channel_value_satoshis)[..]));
1194                 secp_call!(self.secp_ctx.verify(&local_sighash, &msg.signature, &self.their_funding_pubkey));
1195
1196                 if msg.htlc_signatures.len() != local_commitment_tx.1.len() {
1197                         return Err(HandleError{err: "Got wrong number of HTLC signatures from remote", msg: None});
1198                 }
1199
1200                 for (idx, ref htlc) in local_commitment_tx.1.iter().enumerate() {
1201                         let htlc_tx = self.build_htlc_transaction(&local_commitment_tx.0.txid(), htlc, true, &local_keys)?;
1202                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &local_keys, htlc.offered);
1203                         let htlc_sighash = secp_call!(Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx, 0, &htlc_redeemscript, htlc.amount_msat / 1000)[..]));
1204                         secp_call!(self.secp_ctx.verify(&htlc_sighash, &msg.htlc_signatures[idx], &local_keys.b_htlc_key));
1205                 }
1206
1207                 let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &self.build_local_commitment_secret(self.cur_local_commitment_transaction_number - 1)?).unwrap();
1208                 let per_commitment_secret = chan_utils::build_commitment_secret(self.local_keys.commitment_seed, self.cur_local_commitment_transaction_number);
1209
1210                 //TODO: Store htlc keys in our channel_watcher
1211
1212                 // Update state now that we've passed all the can-fail calls...
1213
1214                 let mut to_forward_infos = Vec::new();
1215                 for ref mut htlc in self.pending_htlcs.iter_mut() {
1216                         if htlc.state == HTLCState::RemoteAnnounced {
1217                                 htlc.state = HTLCState::Committed;
1218                                 to_forward_infos.push(htlc.pending_forward_state.take().unwrap());
1219                         }
1220                 }
1221
1222                 self.cur_local_commitment_transaction_number -= 1;
1223
1224                 Ok((msgs::RevokeAndACK {
1225                         channel_id: self.channel_id,
1226                         per_commitment_secret: per_commitment_secret,
1227                         next_per_commitment_point: next_per_commitment_point,
1228                 }, to_forward_infos))
1229         }
1230
1231         /// Handles receiving a remote's revoke_and_ack. Note that we may return a new
1232         /// commitment_signed message here in case we had pending outbound HTLCs to add which were
1233         /// waiting on this revoke_and_ack. The generation of this new commitment_signed may also fail,
1234         /// generating an appropriate error *after* the channel state has been updated based on the
1235         /// revoke_and_ack message.
1236         pub fn revoke_and_ack(&mut self, msg: &msgs::RevokeAndACK) -> Result<Option<(Vec<msgs::UpdateAddHTLC>, msgs::CommitmentSigned)>, HandleError> {
1237                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1238                         return Err(HandleError{err: "Got revoke/ACK message when channel was not in an operational state", msg: None});
1239                 }
1240                 if PublicKey::from_secret_key(&self.secp_ctx, &get_key!(&self.secp_ctx, &msg.per_commitment_secret)).unwrap() != self.their_cur_commitment_point {
1241                         return Err(HandleError{err: "Got a revoke commitment secret which didn't correspond to their current pubkey", msg: None});
1242                 }
1243                 self.channel_monitor.provide_secret(self.cur_remote_commitment_transaction_number, msg.per_commitment_secret)?;
1244
1245                 // Update state now that we've passed all the can-fail calls...
1246                 // (note that we may still fail to generate the new commitment_signed message, but that's
1247                 // OK, we step the channel here and *then* if the new generation fails we can fail the
1248                 // channel based on that, but stepping stuff here should be safe either way.
1249                 self.channel_state &= !(ChannelState::AwaitingRemoteRevoke as u32);
1250                 self.their_cur_commitment_point = msg.next_per_commitment_point;
1251                 self.cur_remote_commitment_transaction_number -= 1;
1252                 for htlc in self.pending_htlcs.iter_mut() {
1253                         if htlc.state == HTLCState::LocalAnnounced {
1254                                 htlc.state = HTLCState::Committed;
1255                         }
1256                 }
1257
1258                 self.free_holding_cell_htlcs()
1259         }
1260
1261         pub fn update_fee(&mut self, fee_estimator: &FeeEstimator, msg: &msgs::UpdateFee) -> Result<(), HandleError> {
1262         if self.channel_outbound {
1263                         return Err(HandleError{err: "Non-funding remote tried to update channel fee", msg: None});
1264         }
1265                 Channel::check_remote_fee(fee_estimator, msg.feerate_per_kw).unwrap();
1266                 self.feerate_per_kw = msg.feerate_per_kw as u64;
1267                 Ok(())
1268         }
1269
1270         // Public utilities:
1271
1272         pub fn channel_id(&self) -> Uint256 {
1273                 self.channel_id
1274         }
1275
1276         /// Gets the "user_id" value passed into the construction of this channel. It has no special
1277         /// meaning and exists only to allow users to have a persistent identifier of a channel.
1278         pub fn get_user_id(&self) -> u64 {
1279                 self.user_id
1280         }
1281
1282         /// Guaranteed to be Some after both FundingLocked messages have been exchanged (and, thus,
1283         /// is_usable() returns true).
1284         pub fn get_short_channel_id(&self) -> Option<u64> {
1285                 self.short_channel_id
1286         }
1287
1288         /// Returns the funding_txo we either got from our peer, or were given by
1289         /// get_outbound_funding_created.
1290         pub fn get_funding_txo(&self) -> Option<(Sha256dHash, u16)> {
1291                 self.channel_monitor.get_funding_txo()
1292         }
1293
1294         pub fn get_their_node_id(&self) -> PublicKey {
1295                 self.their_node_id
1296         }
1297
1298         pub fn get_our_htlc_minimum_msat(&self) -> u64 {
1299                 self.our_htlc_minimum_msat
1300         }
1301
1302         pub fn get_value_satoshis(&self) -> u64 {
1303                 self.channel_value_satoshis
1304         }
1305
1306         pub fn get_channel_update_count(&mut self) -> u32 {
1307                 self.channel_update_count += 1; //TODO: This should be base on updates, not updates *sent*
1308                 self.channel_update_count
1309         }
1310
1311         /// Gets the fee we'd want to charge for adding an HTLC output to this Channel
1312         pub fn get_our_fee_base_msat(&self, fee_estimator: &FeeEstimator) -> u32 {
1313                 // For lack of a better metric, we calculate what it would cost to consolidate the new HTLC
1314                 // output value back into a transaction with the regular channel output:
1315
1316                 // the fee cost of the HTLC-Success/HTLC-Timeout transaction:
1317                 let mut res = self.feerate_per_kw * cmp::max(HTLC_TIMEOUT_TX_WEIGHT, HTLC_SUCCESS_TX_WEIGHT);
1318
1319                 if self.channel_outbound {
1320                         // + the marginal fee increase cost to us in the commitment transaction:
1321                         res += self.feerate_per_kw * COMMITMENT_TX_WEIGHT_PER_HTLC;
1322                 }
1323
1324                 // + the marginal cost of an input which spends the HTLC-Success/HTLC-Timeout output:
1325                 res += fee_estimator.get_est_sat_per_vbyte(ConfirmationTarget::Normal) * SPENDING_INPUT_FOR_A_OUTPUT_WEIGHT * 250;
1326
1327                 res as u32
1328         }
1329
1330         pub fn channel_monitor(&self) -> ChannelMonitor {
1331                 if self.channel_state < ChannelState::FundingCreated as u32 {
1332                         panic!("Can't get a channel monitor until funding has been created");
1333                 }
1334                 self.channel_monitor.clone()
1335         }
1336
1337         /// Returns true if this channel is fully established and not known to be closing.
1338         pub fn is_usable(&self) -> bool {
1339                 (self.channel_state & (ChannelState::ChannelFunded as u32)) == (ChannelState::ChannelFunded as u32)
1340         }
1341
1342         /// Returns true if this channel is currently available for use. This is a superset of
1343         /// is_usable() and considers things like the channel being temporarily disabled.
1344         pub fn is_live(&self) -> bool {
1345                 self.is_usable()
1346         }
1347
1348         /// Called by channelmanager based on chain blocks being connected.
1349         /// Note that we only need to use this to detect funding_signed, anything else is handled by
1350         /// the channel_monitor.
1351         pub fn block_connected(&mut self, header: &BlockHeader, height: u32, txn_matched: &[&Transaction], indexes_of_txn_matched: &[u32]) -> Option<msgs::FundingLocked> {
1352                 if self.funding_tx_confirmations > 0 {
1353                         if header.bitcoin_hash() != self.last_block_connected {
1354                                 self.last_block_connected = header.bitcoin_hash();
1355                                 self.funding_tx_confirmations += 1;
1356                                 if self.funding_tx_confirmations == CONF_TARGET as u64 {
1357                                         if self.channel_state == ChannelState::FundingSent as u32 {
1358                                                 self.channel_state |= ChannelState::OurFundingLocked as u32;
1359                                         } else if self.channel_state == (ChannelState::FundingSent as u32 | ChannelState::TheirFundingLocked as u32) {
1360                                                 self.channel_state = ChannelState::ChannelFunded as u32;
1361                                                 //TODO: Something about a state where we "lost confirmation"
1362                                         } else if self.channel_state < ChannelState::ChannelFunded as u32 {
1363                                                 panic!("Started confirming a channel in a state pre-FundingSent?");
1364                                         }
1365                                         self.funding_tx_confirmed_in = header.bitcoin_hash();
1366
1367                                         //TODO: Note that this must be a duplicate of the previous commitment point they sent us,
1368                                         //as otherwise we will have a commitment transaction that they can't revoke (well, kinda,
1369                                         //they can by sending two revoke_and_acks back-to-back, but not really). This appears to be
1370                                         //a protocol oversight, but I assume I'm just missing something.
1371                                         let next_per_commitment_secret = match self.build_local_commitment_secret(self.cur_local_commitment_transaction_number) {
1372                                                 Ok(secret) => secret,
1373                                                 Err(_) => return None
1374                                         };
1375
1376                                         let next_per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &next_per_commitment_secret).unwrap();
1377                                         return Some(msgs::FundingLocked {
1378                                                 channel_id: self.channel_id,
1379                                                 next_per_commitment_point: next_per_commitment_point,
1380                                         });
1381                                 }
1382                         }
1383                 }
1384                 if self.channel_state & !(ChannelState::TheirFundingLocked as u32) == ChannelState::FundingSent as u32 {
1385                         for (ref tx, index_in_block) in txn_matched.iter().zip(indexes_of_txn_matched) {
1386                                 if tx.txid() == self.channel_monitor.get_funding_txo().unwrap().0 {
1387                                         self.funding_tx_confirmations = 1;
1388                                         self.short_channel_id = Some(((height as u64)          << (5*8)) |
1389                                                                      ((*index_in_block as u64) << (2*8)) |
1390                                                                      ((self.channel_monitor.get_funding_txo().unwrap().1 as u64) << (2*8)));
1391                                 }
1392                         }
1393                 }
1394                 None
1395         }
1396
1397         /// Called by channelmanager based on chain blocks being disconnected.
1398         /// Returns true if we need to close the channel now due to funding transaction
1399         /// unconfirmation/reorg.
1400         pub fn block_disconnected(&mut self, header: &BlockHeader) -> bool {
1401                 if self.funding_tx_confirmations > 0 {
1402                         self.funding_tx_confirmations -= 1;
1403                         if self.funding_tx_confirmations == UNCONF_THRESHOLD as u64 {
1404                                 return true;
1405                         }
1406                 }
1407                 if header.bitcoin_hash() == self.funding_tx_confirmed_in {
1408                         self.funding_tx_confirmations = CONF_TARGET as u64 - 1;
1409                 }
1410                 false
1411         }
1412
1413         // Methods to get unprompted messages to send to the remote end (or where we already returned
1414         // something in the handler for the message that prompted this message):
1415
1416         pub fn get_open_channel(&self, chain_hash: Sha256dHash, fee_estimator: &FeeEstimator) -> Result<msgs::OpenChannel, HandleError> {
1417                 if !self.channel_outbound {
1418                         panic!("Tried to open a channel for an inbound channel?");
1419                 }
1420                 if self.channel_state != ChannelState::OurInitSent as u32 {
1421                         return Err(HandleError{err: "Cannot generate an open_channel after we've moved forward", msg: None});
1422                 }
1423
1424                 if self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
1425                         panic!("Tried to send an open_channel for a channel that has already advanced");
1426                 }
1427
1428                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number)?;
1429
1430                 Ok(msgs::OpenChannel {
1431                         chain_hash: chain_hash,
1432                         temporary_channel_id: self.channel_id,
1433                         funding_satoshis: self.channel_value_satoshis,
1434                         push_msat: 0, //TODO: Something about feerate?
1435                         dust_limit_satoshis: self.our_dust_limit_satoshis,
1436                         max_htlc_value_in_flight_msat: Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
1437                         channel_reserve_satoshis: Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
1438                         htlc_minimum_msat: self.our_htlc_minimum_msat,
1439                         feerate_per_kw: fee_estimator.get_est_sat_per_vbyte(ConfirmationTarget::Background) as u32 * 250,
1440                         to_self_delay: BREAKDOWN_TIMEOUT,
1441                         max_accepted_htlcs: OUR_MAX_HTLCS,
1442                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).unwrap(),
1443                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key).unwrap(),
1444                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key).unwrap(),
1445                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key).unwrap(),
1446                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key).unwrap(),
1447                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret).unwrap(),
1448                         channel_flags: if self.announce_publicly {1} else {0},
1449                         shutdown_scriptpubkey: None,
1450                 })
1451         }
1452
1453         pub fn get_accept_channel(&self) -> Result<msgs::AcceptChannel, HandleError> {
1454                 if self.channel_outbound {
1455                         panic!("Tried to send accept_channel for an outbound channel?");
1456                 }
1457                 if self.channel_state != (ChannelState::OurInitSent as u32) | (ChannelState::TheirInitSent as u32) {
1458                         panic!("Tried to send accept_channel after channel had moved forward");
1459                 }
1460                 if self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
1461                         panic!("Tried to send an accept_channel for a channel that has already advanced");
1462                 }
1463
1464                 let local_commitment_secret = self.build_local_commitment_secret(self.cur_local_commitment_transaction_number)?;
1465
1466                 Ok(msgs::AcceptChannel {
1467                         temporary_channel_id: self.channel_id,
1468                         dust_limit_satoshis: self.our_dust_limit_satoshis,
1469                         max_htlc_value_in_flight_msat: Channel::get_our_max_htlc_value_in_flight_msat(self.channel_value_satoshis),
1470                         channel_reserve_satoshis: Channel::get_our_channel_reserve_satoshis(self.channel_value_satoshis),
1471                         htlc_minimum_msat: self.our_htlc_minimum_msat,
1472                         minimum_depth: CONF_TARGET,
1473                         to_self_delay: BREAKDOWN_TIMEOUT,
1474                         max_accepted_htlcs: OUR_MAX_HTLCS,
1475                         funding_pubkey: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).unwrap(),
1476                         revocation_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.revocation_base_key).unwrap(),
1477                         payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.payment_base_key).unwrap(),
1478                         delayed_payment_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.delayed_payment_base_key).unwrap(),
1479                         htlc_basepoint: PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.htlc_base_key).unwrap(),
1480                         first_per_commitment_point: PublicKey::from_secret_key(&self.secp_ctx, &local_commitment_secret).unwrap(),
1481                         shutdown_scriptpubkey: None,
1482                 })
1483         }
1484
1485         fn get_outbound_funding_created_signature(&mut self) -> Result<Signature, HandleError> {
1486                 let funding_script = self.get_funding_redeemscript();
1487
1488                 let remote_keys = self.build_remote_transaction_keys()?;
1489                 let remote_initial_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, false)?.0;
1490                 let remote_sighash = secp_call!(Message::from_slice(&bip143::SighashComponents::new(&remote_initial_commitment_tx).sighash_all(&remote_initial_commitment_tx, 0, &funding_script, self.channel_value_satoshis)[..]));
1491
1492                 // We sign the "remote" commitment transaction, allowing them to broadcast the tx if they wish.
1493                 Ok(secp_call!(self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key)))
1494         }
1495
1496         /// Updates channel state with knowledge of the funding transaction's txid/index, and generates
1497         /// a funding_created message for the remote peer.
1498         /// Panics if called at some time other than immediately after initial handshake, if called twice,
1499         /// or if called on an inbound channel.
1500         /// Note that channel_id changes during this call!
1501         /// Do NOT broadcast the funding transaction until after a successful funding_signed call!
1502         pub fn get_outbound_funding_created(&mut self, funding_txid: Sha256dHash, funding_output_index: u16) -> Result<msgs::FundingCreated, HandleError> {
1503                 if !self.channel_outbound {
1504                         panic!("Tried to create outbound funding_created message on an inbound channel!");
1505                 }
1506                 if self.channel_state != (ChannelState::OurInitSent as u32 | ChannelState::TheirInitSent as u32) {
1507                         panic!("Tried to get a funding_created messsage at a time other than immediately after initial handshake completion (or tried to get funding_created twice)");
1508                 }
1509                 if self.channel_monitor.get_min_seen_secret() != (1 << 48) || self.cur_remote_commitment_transaction_number != (1 << 48) - 1 || self.cur_local_commitment_transaction_number != (1 << 48) - 1 {
1510                         panic!("Should not have advanced channel commitment tx numbers prior to funding_created");
1511                 }
1512
1513                 self.channel_monitor.set_funding_info(funding_txid, funding_output_index);
1514
1515                 let our_signature = match self.get_outbound_funding_created_signature() {
1516                         Ok(sig) => sig,
1517                         Err(e) => {
1518                                 self.channel_monitor.unset_funding_info();
1519                                 return Err(e);
1520                         }
1521                 };
1522
1523                 let temporary_channel_id = self.channel_id;
1524
1525                 // Now that we're past error-generating stuff, update our local state:
1526
1527                 self.channel_state = ChannelState::FundingCreated as u32;
1528                 let funding_txo = self.channel_monitor.get_funding_txo().unwrap();
1529                 self.channel_id = funding_txo.0.into_be() ^ Uint256::from_u64(funding_txo.1 as u64).unwrap(); //TODO: or le?
1530
1531                 Ok(msgs::FundingCreated {
1532                         temporary_channel_id: temporary_channel_id,
1533                         funding_txid: funding_txid,
1534                         funding_output_index: funding_output_index,
1535                         signature: our_signature
1536                 })
1537         }
1538
1539         /// Gets an UnsignedChannelAnnouncement, as well as a signature covering it using our
1540         /// bitcoin_key, if available, for this channel. The channel must be publicly announceable and
1541         /// available for use (have exchanged FundingLocked messages in both directions. Should be used
1542         /// for both loose and in response to an AnnouncementSignatures message from the remote peer.
1543         pub fn get_channel_announcement(&self, our_node_id: PublicKey, chain_hash: Sha256dHash) -> Result<(msgs::UnsignedChannelAnnouncement, Signature), HandleError> {
1544                 if !self.announce_publicly {
1545                         return Err(HandleError{err: "Channel is not available for public announcements", msg: None});
1546                 }
1547                 if self.channel_state < ChannelState::ChannelFunded as u32 {
1548                         return Err(HandleError{err: "Cannot get a ChannelAnnouncement until the channel funding has been locked", msg: None});
1549                 }
1550
1551                 let were_node_one = our_node_id.serialize()[..] < self.their_node_id.serialize()[..];
1552                 let our_bitcoin_key = PublicKey::from_secret_key(&self.secp_ctx, &self.local_keys.funding_key).unwrap();
1553
1554                 let msg = msgs::UnsignedChannelAnnouncement {
1555                         features: msgs::GlobalFeatures::new(),
1556                         chain_hash: chain_hash,
1557                         short_channel_id: self.get_short_channel_id().unwrap(),
1558                         node_id_1: if were_node_one { our_node_id } else { self.get_their_node_id() },
1559                         node_id_2: if were_node_one { self.get_their_node_id() } else { our_node_id },
1560                         bitcoin_key_1: if were_node_one { our_bitcoin_key } else { self.their_funding_pubkey },
1561                         bitcoin_key_2: if were_node_one { self.their_funding_pubkey } else { our_bitcoin_key },
1562                 };
1563
1564                 let msghash = Message::from_slice(&Sha256dHash::from_data(&msg.encode()[..])[..]).unwrap();
1565                 let sig = secp_call!(self.secp_ctx.sign(&msghash, &self.local_keys.funding_key));
1566
1567                 Ok((msg, sig))
1568         }
1569
1570
1571         // Send stuff to our remote peers:
1572
1573         /// Adds a pending outbound HTLC to this channel, note that you probably want
1574         /// send_htlc_and_commit instead cause you'll want both messages at once.
1575         /// This returns an option instead of a pure UpdateAddHTLC as we may be in a state where we are
1576         /// waiting on the remote peer to send us a revoke_and_ack during which time we cannot add new
1577         /// HTLCs on the wire or we wouldn't be able to determine what they actually ACK'ed.
1578         pub fn send_htlc(&mut self, amount_msat: u64, payment_hash: [u8; 32], cltv_expiry: u32, onion_routing_packet: msgs::OnionPacket) -> Result<Option<msgs::UpdateAddHTLC>, HandleError> {
1579                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1580                         return Err(HandleError{err: "Cannot send HTLC until channel is fully established", msg: None});
1581                 }
1582
1583                 if amount_msat > self.channel_value_satoshis * 1000 {
1584                         return Err(HandleError{err: "Cannot send more than the total value of the channel", msg: None});
1585                 }
1586                 if amount_msat < self.their_htlc_minimum_msat {
1587                         return Err(HandleError{err: "Cannot send less than their minimum HTLC value", msg: None});
1588                 }
1589
1590                 let (_, outbound_htlc_count, htlc_outbound_value_msat, htlc_inbound_value_msat) = self.get_pending_htlc_stats();
1591                 if outbound_htlc_count + 1 > self.their_max_accepted_htlcs as u32 {
1592                         return Err(HandleError{err: "Cannot push more than their max accepted HTLCs", msg: None});
1593                 }
1594                 //TODO: Spec is unclear if this is per-direction or in total (I assume per direction):
1595                 // Check their_max_htlc_value_in_flight_msat
1596                 if htlc_outbound_value_msat + amount_msat > self.their_max_htlc_value_in_flight_msat {
1597                         return Err(HandleError{err: "Cannot send value that would put us over our max HTLC value in flight", msg: None});
1598                 }
1599                 // Check their_channel_reserve_satoshis:
1600                 if htlc_inbound_value_msat + htlc_outbound_value_msat + amount_msat + (self.channel_value_satoshis * 1000 - self.value_to_self_msat) > (self.channel_value_satoshis - self.their_channel_reserve_satoshis) * 1000 {
1601                         return Err(HandleError{err: "Cannot send value that would put us over our reserve value", msg: None});
1602                 }
1603
1604                 //TODO: Check cltv_expiry? Do this in channel manager?
1605
1606                 // Now update local state:
1607                 if (self.channel_state & (ChannelState::AwaitingRemoteRevoke as u32)) == (ChannelState::AwaitingRemoteRevoke as u32) {
1608                         //TODO: Check the limits *including* other pending holding cell HTLCs!
1609                         self.holding_cell_htlcs.push(HTLCOutputAwaitingACK {
1610                                 amount_msat: amount_msat,
1611                                 payment_hash: payment_hash,
1612                                 cltv_expiry: cltv_expiry,
1613                                 onion_routing_packet: onion_routing_packet,
1614                                 time_created: Instant::now(),
1615                         });
1616                         return Ok(None);
1617                 }
1618
1619                 self.pending_htlcs.push(HTLCOutput {
1620                         outbound: true,
1621                         htlc_id: self.next_local_htlc_id,
1622                         amount_msat: amount_msat,
1623                         payment_hash: payment_hash.clone(),
1624                         cltv_expiry: cltv_expiry,
1625                         state: HTLCState::LocalAnnounced,
1626                         pending_forward_state: None
1627                 });
1628
1629                 let res = msgs::UpdateAddHTLC {
1630                         channel_id: self.channel_id,
1631                         htlc_id: self.next_local_htlc_id,
1632                         amount_msat: amount_msat,
1633                         payment_hash: payment_hash,
1634                         cltv_expiry: cltv_expiry,
1635                         onion_routing_packet: onion_routing_packet,
1636                 };
1637                 self.next_local_htlc_id += 1;
1638
1639                 Ok(Some(res))
1640         }
1641
1642         /// Creates a signed commitment transaction to send to the remote peer.
1643         pub fn send_commitment(&mut self) -> Result<msgs::CommitmentSigned, HandleError> {
1644                 if (self.channel_state & (ChannelState::ChannelFunded as u32)) != (ChannelState::ChannelFunded as u32) {
1645                         return Err(HandleError{err: "Cannot create commitment tx until channel is fully established", msg: None});
1646                 }
1647
1648                 let funding_script = self.get_funding_redeemscript();
1649
1650                 let remote_keys = self.build_remote_transaction_keys()?;
1651                 let remote_commitment_tx = self.build_commitment_transaction(self.cur_remote_commitment_transaction_number, &remote_keys, false, true)?;
1652                 let remote_sighash = secp_call!(Message::from_slice(&bip143::SighashComponents::new(&remote_commitment_tx.0).sighash_all(&remote_commitment_tx.0, 0, &funding_script, self.channel_value_satoshis)[..]));
1653                 let our_sig = secp_call!(self.secp_ctx.sign(&remote_sighash, &self.local_keys.funding_key));
1654
1655                 let mut htlc_sigs = Vec::new();
1656
1657                 for ref htlc in remote_commitment_tx.1.iter() {
1658                         let htlc_tx = self.build_htlc_transaction(&remote_commitment_tx.0.txid(), htlc, false, &remote_keys)?;
1659                         let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &remote_keys, htlc.offered);
1660                         let htlc_sighash = secp_call!(Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx, 0, &htlc_redeemscript, htlc.amount_msat / 1000)[..]));
1661                         let our_htlc_key = secp_call!(chan_utils::derive_private_key(&self.secp_ctx, &remote_keys.per_commitment_point, &self.local_keys.htlc_base_key));
1662                         htlc_sigs.push(secp_call!(self.secp_ctx.sign(&htlc_sighash, &our_htlc_key)));
1663                 }
1664
1665                 // Update state now that we've passed all the can-fail calls...
1666                 self.channel_state |= ChannelState::AwaitingRemoteRevoke as u32;
1667
1668                 Ok(msgs::CommitmentSigned {
1669                         channel_id: self.channel_id,
1670                         signature: our_sig,
1671                         htlc_signatures: htlc_sigs,
1672                 })
1673         }
1674
1675         /// Adds a pending outbound HTLC to this channel, and creates a signed commitment transaction
1676         /// to send to the remote peer in one go.
1677         /// Shorthand for calling send_htlc() followed by send_commitment(), see docs on those for
1678         /// more info.
1679         pub fn send_htlc_and_commit(&mut self, amount_msat: u64, payment_hash: [u8; 32], cltv_expiry: u32, onion_routing_packet: msgs::OnionPacket) -> Result<Option<(msgs::UpdateAddHTLC, msgs::CommitmentSigned)>, HandleError> {
1680                 match self.send_htlc(amount_msat, payment_hash, cltv_expiry, onion_routing_packet)? {
1681                         Some(update_add_htlc) =>
1682                                 Ok(Some((update_add_htlc, self.send_commitment()?))),
1683                         None => Ok(None)
1684                 }
1685         }
1686 }
1687
1688 #[cfg(test)]
1689 mod tests {
1690         use bitcoin::util::misc::hex_bytes;
1691         use bitcoin::util::hash::Sha256dHash;
1692         use bitcoin::util::bip143;
1693         use bitcoin::network::serialize::serialize;
1694         use bitcoin::blockdata::transaction::Transaction;
1695         use ln::channel::{Channel,HTLCOutput,HTLCState,HTLCOutputInCommitment,TxCreationKeys};
1696         use ln::chan_utils;
1697         use chain::chaininterface::{FeeEstimator,ConfirmationTarget};
1698         use secp256k1::{Secp256k1,Message,Signature};
1699         use secp256k1::key::{SecretKey,PublicKey};
1700         use crypto::sha2::Sha256;
1701         use crypto::digest::Digest;
1702
1703         struct TestFeeEstimator {
1704                 fee_est: u64
1705         }
1706         impl FeeEstimator for TestFeeEstimator {
1707                 fn get_est_sat_per_vbyte(&self, _: ConfirmationTarget) -> u64 {
1708                         self.fee_est
1709                 }
1710         }
1711
1712         #[test]
1713         fn outbound_commitment_test() {
1714                 // Test vectors from BOLT 3 Appendix C:
1715                 let feeest = TestFeeEstimator{fee_est: 15000/250};
1716                 let mut chan = Channel::new_outbound(&feeest, PublicKey::new(), 10000000, false, 42); // Nothing uses their network key in this test
1717                 chan.their_to_self_delay = 144;
1718                 chan.our_dust_limit_satoshis = 546;
1719
1720                 let secp_ctx = Secp256k1::new();
1721
1722                 chan.local_keys.funding_key = SecretKey::from_slice(&secp_ctx, &hex_bytes("30ff4956bbdd3222d44cc5e8a1261dab1e07957bdac5ae88fe3261ef321f3749").unwrap()[..]).unwrap();
1723                 assert_eq!(PublicKey::from_secret_key(&secp_ctx, &chan.local_keys.funding_key).unwrap().serialize()[..],
1724                                 hex_bytes("023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb").unwrap()[..]);
1725
1726                 chan.local_keys.payment_base_key = SecretKey::from_slice(&secp_ctx, &hex_bytes("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap();
1727                 chan.local_keys.delayed_payment_base_key = SecretKey::from_slice(&secp_ctx, &hex_bytes("3333333333333333333333333333333333333333333333333333333333333333").unwrap()[..]).unwrap();
1728                 chan.local_keys.htlc_base_key = SecretKey::from_slice(&secp_ctx, &hex_bytes("1111111111111111111111111111111111111111111111111111111111111111").unwrap()[..]).unwrap();
1729                 // chan.local_keys.commitment_seed isn't derived in the test vectors :(
1730
1731                 chan.channel_monitor.set_funding_info(Sha256dHash::from_hex("8984484a580b825b9972d7adb15050b3ab624ccd731946b3eeddb92f4e7ef6be").unwrap(), 0);
1732
1733                 chan.their_payment_basepoint = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex_bytes("4444444444444444444444444444444444444444444444444444444444444444").unwrap()[..]).unwrap()).unwrap();
1734                 assert_eq!(chan.their_payment_basepoint.serialize()[..],
1735                                 hex_bytes("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
1736
1737                 chan.their_funding_pubkey = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex_bytes("1552dfba4f6cf29a62a0af13c8d6981d36d0ef8d61ba10fb0fe90da7634d7e13").unwrap()[..]).unwrap()).unwrap();
1738                 assert_eq!(chan.their_funding_pubkey.serialize()[..],
1739                                 hex_bytes("030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c1").unwrap()[..]);
1740
1741                 chan.their_htlc_basepoint = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &hex_bytes("4444444444444444444444444444444444444444444444444444444444444444").unwrap()[..]).unwrap()).unwrap();
1742                 assert_eq!(chan.their_htlc_basepoint.serialize()[..],
1743                                 hex_bytes("032c0b7cf95324a07d05398b240174dc0c2be444d96b159aa6c7f7b1e668680991").unwrap()[..]);
1744
1745                 chan.their_revocation_basepoint = PublicKey::from_slice(&secp_ctx, &hex_bytes("02466d7fcae563e5cb09a0d1870bb580344804617879a14949cf22285f1bae3f27").unwrap()[..]).unwrap();
1746
1747                 // We can't just use build_local_transaction_keys here as the per_commitment_secret is not
1748                 // derived from a commitment_seed, so instead we copy it here and call
1749                 // build_commitment_transaction.
1750                 let delayed_payment_base = PublicKey::from_secret_key(&secp_ctx, &chan.local_keys.delayed_payment_base_key).unwrap();
1751                 let per_commitment_secret = SecretKey::from_slice(&secp_ctx, &hex_bytes("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
1752                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret).unwrap();
1753                 let htlc_basepoint = PublicKey::from_secret_key(&secp_ctx, &chan.local_keys.htlc_base_key).unwrap();
1754                 let keys = TxCreationKeys::new(&secp_ctx, &per_commitment_point, &delayed_payment_base, &htlc_basepoint, &chan.their_revocation_basepoint, &chan.their_payment_basepoint, &chan.their_htlc_basepoint).unwrap();
1755
1756                 let mut unsigned_tx: (Transaction, Vec<HTLCOutputInCommitment>);
1757
1758                 macro_rules! test_commitment {
1759                         ( $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr) => {
1760                                 unsigned_tx = chan.build_commitment_transaction(42, &keys, true, false).unwrap();
1761                                 let their_signature = Signature::from_der(&secp_ctx, &hex_bytes($their_sig_hex).unwrap()[..]).unwrap();
1762                                 let sighash = Message::from_slice(&bip143::SighashComponents::new(&unsigned_tx.0).sighash_all(&unsigned_tx.0, 0, &chan.get_funding_redeemscript(), chan.channel_value_satoshis)[..]).unwrap();
1763                                 secp_ctx.verify(&sighash, &their_signature, &chan.their_funding_pubkey).unwrap();
1764
1765                                 chan.sign_commitment_transaction(&mut unsigned_tx.0, &their_signature).unwrap();
1766
1767                                 assert_eq!(serialize(&unsigned_tx.0).unwrap()[..],
1768                                                 hex_bytes($tx_hex).unwrap()[..]);
1769                         };
1770                 }
1771
1772                 macro_rules! test_htlc_output {
1773                         ( $htlc_idx: expr, $their_sig_hex: expr, $our_sig_hex: expr, $tx_hex: expr ) => {
1774                                 let remote_signature = Signature::from_der(&secp_ctx, &hex_bytes($their_sig_hex).unwrap()[..]).unwrap();
1775
1776                                 let ref htlc = unsigned_tx.1[$htlc_idx];
1777                                 let mut htlc_tx = chan.build_htlc_transaction(&unsigned_tx.0.txid(), &htlc, true, &keys).unwrap();
1778                                 let htlc_redeemscript = chan_utils::get_htlc_redeemscript(&htlc, &keys, htlc.offered);
1779                                 let htlc_sighash = Message::from_slice(&bip143::SighashComponents::new(&htlc_tx).sighash_all(&htlc_tx, 0, &htlc_redeemscript, htlc.amount_msat / 1000)[..]).unwrap();
1780                                 secp_ctx.verify(&htlc_sighash, &remote_signature, &keys.b_htlc_key).unwrap();
1781
1782                                 let mut preimage: Option<[u8; 32]> = None;
1783                                 if !htlc.offered {
1784                                         for i in 0..5 {
1785                                                 let mut sha = Sha256::new();
1786                                                 sha.input(&[i; 32]);
1787
1788                                                 let mut out = [0; 32];
1789                                                 sha.result(&mut out);
1790
1791                                                 if out == htlc.payment_hash {
1792                                                         preimage = Some([i; 32]);
1793                                                 }
1794                                         }
1795
1796                                         assert!(preimage.is_some());
1797                                 }
1798
1799                                 chan.sign_htlc_transaction(&mut htlc_tx, &remote_signature, &preimage, &htlc, &keys).unwrap();
1800                                 assert_eq!(serialize(&htlc_tx).unwrap()[..],
1801                                                 hex_bytes($tx_hex).unwrap()[..]);
1802                         };
1803                 }
1804
1805                 {
1806                         // simple commitment tx with no HTLCs
1807                         chan.value_to_self_msat = 7000000000;
1808
1809                         test_commitment!("3045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c0",
1810                                          "3044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c3836939",
1811                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311054a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c383693901483045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
1812                 }
1813
1814                 chan.pending_htlcs.push({
1815                         let mut out = HTLCOutput{
1816                                 htlc_id: 0,
1817                                 outbound: false,
1818                                 amount_msat: 1000000,
1819                                 cltv_expiry: 500,
1820                                 payment_hash: [0; 32],
1821                                 state: HTLCState::Committed,
1822                                 pending_forward_state: None,
1823                         };
1824                         let mut sha = Sha256::new();
1825                         sha.input(&hex_bytes("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
1826                         sha.result(&mut out.payment_hash);
1827                         out
1828                 });
1829                 chan.pending_htlcs.push({
1830                         let mut out = HTLCOutput{
1831                                 htlc_id: 1,
1832                                 outbound: false,
1833                                 amount_msat: 2000000,
1834                                 cltv_expiry: 501,
1835                                 payment_hash: [0; 32],
1836                                 state: HTLCState::Committed,
1837                                 pending_forward_state: None,
1838                         };
1839                         let mut sha = Sha256::new();
1840                         sha.input(&hex_bytes("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
1841                         sha.result(&mut out.payment_hash);
1842                         out
1843                 });
1844                 chan.pending_htlcs.push({
1845                         let mut out = HTLCOutput{
1846                                 htlc_id: 2,
1847                                 outbound: true,
1848                                 amount_msat: 2000000,
1849                                 cltv_expiry: 502,
1850                                 payment_hash: [0; 32],
1851                                 state: HTLCState::Committed,
1852                                 pending_forward_state: None,
1853                         };
1854                         let mut sha = Sha256::new();
1855                         sha.input(&hex_bytes("0202020202020202020202020202020202020202020202020202020202020202").unwrap());
1856                         sha.result(&mut out.payment_hash);
1857                         out
1858                 });
1859                 chan.pending_htlcs.push({
1860                         let mut out = HTLCOutput{
1861                                 htlc_id: 3,
1862                                 outbound: true,
1863                                 amount_msat: 3000000,
1864                                 cltv_expiry: 503,
1865                                 payment_hash: [0; 32],
1866                                 state: HTLCState::Committed,
1867                                 pending_forward_state: None,
1868                         };
1869                         let mut sha = Sha256::new();
1870                         sha.input(&hex_bytes("0303030303030303030303030303030303030303030303030303030303030303").unwrap());
1871                         sha.result(&mut out.payment_hash);
1872                         out
1873                 });
1874                 chan.pending_htlcs.push({
1875                         let mut out = HTLCOutput{
1876                                 htlc_id: 4,
1877                                 outbound: false,
1878                                 amount_msat: 4000000,
1879                                 cltv_expiry: 504,
1880                                 payment_hash: [0; 32],
1881                                 state: HTLCState::Committed,
1882                                 pending_forward_state: None,
1883                         };
1884                         let mut sha = Sha256::new();
1885                         sha.input(&hex_bytes("0404040404040404040404040404040404040404040404040404040404040404").unwrap());
1886                         sha.result(&mut out.payment_hash);
1887                         out
1888                 });
1889
1890                 {
1891                         // commitment tx with all five HTLCs untrimmed (minimum feerate)
1892                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
1893                         chan.feerate_per_kw = 0;
1894
1895                         test_commitment!("304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b70606",
1896                                          "30440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f06",
1897                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f060147304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b7060601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
1898
1899                         assert_eq!(unsigned_tx.1.len(), 5);
1900
1901                         test_htlc_output!(0,
1902                                           "304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a6",
1903                                           "304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5",
1904                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219700000000000000000001e8030000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a6e59f18764a5bf8d4fa45eebc591566689441229c918b480fb2af8cc6a4aeb02205248f273be447684b33e3c8d1d85a8e0ca9fa0bae9ae33f0527ada9c162919a60147304402207cb324fa0de88f452ffa9389678127ebcf4cabe1dd848b8e076c1a1962bf34720220116ed922b12311bd602d67e60d2529917f21c5b82f25ff6506c0f87886b4dfd5012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
1905
1906                         test_htlc_output!(1,
1907                                           "3045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b",
1908                                           "3045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be5",
1909                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219701000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d5275b3619953cb0c3b5aa577f04bc512380e60fa551762ce3d7a1bb7401cff9022037237ab0dac3fe100cde094e82e2bed9ba0ed1bb40154b48e56aa70f259e608b01483045022100c89172099507ff50f4c925e6c5150e871fb6e83dd73ff9fbb72f6ce829a9633f02203a63821d9162e99f9be712a68f9e589483994feae2661e4546cd5b6cec007be501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
1910
1911                         test_htlc_output!(2,
1912                                           "304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f202",
1913                                           "3045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da",
1914                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219702000000000000000001d0070000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402201b63ec807771baf4fdff523c644080de17f1da478989308ad13a58b51db91d360220568939d38c9ce295adba15665fa68f51d967e8ed14a007b751540a80b325f20201483045022100def389deab09cee69eaa1ec14d9428770e45bcbe9feb46468ecf481371165c2f022015d2e3c46600b2ebba8dcc899768874cc6851fd1ecb3fffd15db1cc3de7e10da012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
1915
1916                         test_htlc_output!(3,
1917                                           "3045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554",
1918                                           "30440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac08727",
1919                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219703000000000000000001b80b0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100daee1808f9861b6c3ecd14f7b707eca02dd6bdfc714ba2f33bc8cdba507bb182022026654bf8863af77d74f51f4e0b62d461a019561bb12acb120d3f7195d148a554014730440220643aacb19bbb72bd2b635bc3f7375481f5981bace78cdd8319b2988ffcc6704202203d27784ec8ad51ed3bd517a05525a5139bb0b755dd719e0054332d186ac0872701008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
1920
1921                         test_htlc_output!(4,
1922                                           "304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d",
1923                                           "30440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e",
1924                                           "020000000001018154ecccf11a5fb56c39654c4deb4d2296f83c69268280b94d021370c94e219704000000000000000001a00f0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207e0410e45454b0978a623f36a10626ef17b27d9ad44e2760f98cfa3efb37924f0220220bd8acd43ecaa916a80bd4f919c495a2c58982ce7c8625153f8596692a801d014730440220549e80b4496803cbc4a1d09d46df50109f546d43fbbf86cd90b174b1484acd5402205f12a4f995cb9bded597eabfee195a285986aa6d93ae5bb72507ebc6a4e2349e012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
1925                 }
1926
1927                 {
1928                         // commitment tx with seven outputs untrimmed (maximum feerate)
1929                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
1930                         chan.feerate_per_kw = 647;
1931
1932                         test_commitment!("3045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b",
1933                                          "304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d1163",
1934                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040048304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d116301483045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
1935
1936                         assert_eq!(unsigned_tx.1.len(), 5);
1937
1938                         test_htlc_output!(0,
1939                                           "30440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab343740",
1940                                           "304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a",
1941                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220385a5afe75632f50128cbb029ee95c80156b5b4744beddc729ad339c9ca432c802202ba5f48550cad3379ac75b9b4fedb86a35baa6947f16ba5037fb8b11ab3437400147304402205999590b8a79fa346e003a68fd40366397119b2b0cdf37b149968d6bc6fbcc4702202b1e1fb5ab7864931caed4e732c359e0fe3d86a548b557be2246efb1708d579a012000000000000000000000000000000000000000000000000000000000000000008a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a914b8bcb07f6344b42ab04250c86a6e8b75d3fdbbc688527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f401b175ac686800000000");
1942
1943                         test_htlc_output!(1,
1944                                           "304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b0",
1945                                           "304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac",
1946                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb60100000000000000000124060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402207ceb6678d4db33d2401fdc409959e57c16a6cb97a30261d9c61f29b8c58d34b90220084b4a17b4ca0e86f2d798b3698ca52de5621f2ce86f80bed79afa66874511b00147304402207ff03eb0127fc7c6cae49cc29e2a586b98d1e8969cf4a17dfa50b9c2647720b902205e2ecfda2252956c0ca32f175080e75e4e390e433feb1f8ce9f2ba55648a1dac01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
1947
1948                         test_htlc_output!(2,
1949                                           "304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d833",
1950                                           "3045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877",
1951                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6020000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e050047304402206a401b29a0dff0d18ec903502c13d83e7ec019450113f4a7655a4ce40d1f65ba0220217723a084e727b6ca0cc8b6c69c014a7e4a01fcdcba3e3993f462a3c574d83301483045022100d50d067ca625d54e62df533a8f9291736678d0b86c28a61bb2a80cf42e702d6e02202373dde7e00218eacdafb9415fe0e1071beec1857d1af3c6a201a44cbc47c877012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
1952
1953                         test_htlc_output!(3,
1954                                           "30450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d",
1955                                           "3045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb",
1956                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb6030000000000000000010c0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009b1c987ba599ee3bde1dbca776b85481d70a78b681a8d84206723e2795c7cac002207aac84ad910f8598c4d1c0ea2e3399cf6627a4e3e90131315bc9f038451ce39d01483045022100db9dc65291077a52728c622987e9895b7241d4394d6dcb916d7600a3e8728c22022036ee3ee717ba0bb5c45ee84bc7bbf85c0f90f26ae4e4a25a6b4241afa8a3f1cb01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
1957
1958                         test_htlc_output!(4,
1959                                           "3045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f0",
1960                                           "304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f",
1961                                           "020000000001018323148ce2419f21ca3d6780053747715832e18ac780931a514b187768882bb604000000000000000001da0d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100cc28030b59f0914f45b84caa983b6f8effa900c952310708c2b5b00781117022022027ba2ccdf94d03c6d48b327f183f6e28c8a214d089b9227f94ac4f85315274f00147304402202d1a3c0d31200265d2a2def2753ead4959ae20b4083e19553acfffa5dfab60bf022020ede134149504e15b88ab261a066de49848411e15e70f9e6a5462aec2949f8f012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
1962                 }
1963
1964                 {
1965                         // commitment tx with six outputs untrimmed (minimum feerate)
1966                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
1967                         chan.feerate_per_kw = 648;
1968
1969                         test_commitment!("3044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b057",
1970                                          "3045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de",
1971                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431104e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de01473044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b05701475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
1972
1973                         assert_eq!(unsigned_tx.1.len(), 4);
1974
1975                         test_htlc_output!(0,
1976                                           "3044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada8",
1977                                           "3045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc098",
1978                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10000000000000000000123060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022062ef2e77591409d60d7817d9bb1e71d3c4a2931d1a6c7c8307422c84f001a251022022dad9726b0ae3fe92bda745a06f2c00f92342a186d84518588cf65f4dfaada801483045022100a4c574f00411dd2f978ca5cdc1b848c311cd7849c087ad2f21a5bce5e8cc5ae90220090ae39a9bce2fb8bc879d7e9f9022df249f41e25e51f1a9bf6447a9eeffc09801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
1979
1980                         test_htlc_output!(1,
1981                                           "3045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d4",
1982                                           "304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0",
1983                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd10100000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e968cbbb5f402ed389fdc7f6cd2a80ed650bb42c79aeb2a5678444af94f6c78502204b47a1cb24ab5b0b6fe69fe9cfc7dba07b9dd0d8b95f372c1d9435146a88f8d40147304402207679cf19790bea76a733d2fa0672bd43ab455687a068f815a3d237581f57139a0220683a1a799e102071c206b207735ca80f627ab83d6616b4bcd017c5d79ef3e7d0012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
1984
1985                         test_htlc_output!(2,
1986                                           "3045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c2",
1987                                           "304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda3",
1988                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd1020000000000000000010b0a0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100aa91932e305292cf9969cc23502bbf6cef83a5df39c95ad04a707c4f4fed5c7702207099fc0f3a9bfe1e7683c0e9aa5e76c5432eb20693bf4cb182f04d383dc9c8c20147304402200df76fea718745f3c529bac7fd37923e7309ce38b25c0781e4cf514dd9ef8dc802204172295739dbae9fe0474dcee3608e3433b4b2af3a2e6787108b02f894dcdda301008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
1989
1990                         test_htlc_output!(3,
1991                                           "3044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f",
1992                                           "304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6",
1993                                           "02000000000101579c183eca9e8236a5d7f5dcd79cfec32c497fdc0ec61533cde99ecd436cadd103000000000000000001d90d0000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022035cac88040a5bba420b1c4257235d5015309113460bc33f2853cd81ca36e632402202fc94fd3e81e9d34a9d01782a0284f3044370d03d60f3fc041e2da088d2de58f0147304402200daf2eb7afd355b4caf6fb08387b5f031940ea29d1a9f35071288a839c9039e4022067201b562456e7948616c13acb876b386b511599b58ac1d94d127f91c50463a6012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
1994                 }
1995
1996                 {
1997                         // commitment tx with six outputs untrimmed (maximum feerate)
1998                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
1999                         chan.feerate_per_kw = 2069;
2000
2001                         test_commitment!("3044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb4",
2002                                          "304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea",
2003                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311077956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea01473044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2004
2005                         assert_eq!(unsigned_tx.1.len(), 4);
2006
2007                         test_htlc_output!(0,
2008                                           "3045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f992",
2009                                           "3044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae66402",
2010                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0000000000000000000175020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d1cf354de41c1369336cf85b225ed033f1f8982a01be503668df756a7e668b66022001254144fb4d0eecc61908fccc3388891ba17c5d7a1a8c62bdd307e5a513f99201473044022056eb1af429660e45a1b0b66568cb8c4a3aa7e4c9c292d5d6c47f86ebf2c8838f022065c3ac4ebe980ca7a41148569be4ad8751b0a724a41405697ec55035dae6640201008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2011
2012                         test_htlc_output!(1,
2013                                           "3045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f4",
2014                                           "3045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f",
2015                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a0100000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d065569dcb94f090345402736385efeb8ea265131804beac06dd84d15dd2d6880220664feb0b4b2eb985fadb6ec7dc58c9334ea88ce599a9be760554a2d4b3b5d9f401483045022100914bb232cd4b2690ee3d6cb8c3713c4ac9c4fb925323068d8b07f67c8541f8d9022057152f5f1615b793d2d45aac7518989ae4fe970f28b9b5c77504799d25433f7f012001010101010101010101010101010101010101010101010101010101010101018a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a9144b6b2e5444c2639cc0fb7bcea5afba3f3cdce23988527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f501b175ac686800000000");
2016
2017                         test_htlc_output!(2,
2018                                           "3045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef18",
2019                                           "304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f9",
2020                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a020000000000000000015d060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100d4e69d363de993684eae7b37853c40722a4c1b4a7b588ad7b5d8a9b5006137a102207a069c628170ee34be5612747051bdcc087466dbaa68d5756ea81c10155aef180147304402200e362443f7af830b419771e8e1614fc391db3a4eb799989abfc5ab26d6fcd032022039ab0cad1c14dfbe9446bf847965e56fe016e0cbcf719fd18c1bfbf53ecbd9f901008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2021
2022                         test_htlc_output!(3,
2023                                           "30450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c",
2024                                           "304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5",
2025                                           "02000000000101ca94a9ad516ebc0c4bdd7b6254871babfa978d5accafb554214137d398bfcf6a03000000000000000001f2090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221008ec888e36e4a4b3dc2ed6b823319855b2ae03006ca6ae0d9aa7e24bfc1d6f07102203b0f78885472a67ff4fe5916c0bb669487d659527509516fc3a08e87a2cc0a7c0147304402202c3e14282b84b02705dfd00a6da396c9fe8a8bcb1d3fdb4b20a4feba09440e8b02202b058b39aa9b0c865b22095edcd9ff1f71bbfe20aa4993755e54d042755ed0d5012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2026                 }
2027
2028                 {
2029                         // commitment tx with five outputs untrimmed (minimum feerate)
2030                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2031                         chan.feerate_per_kw = 2070;
2032
2033                         test_commitment!("3045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f37526",
2034                                          "30440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd0",
2035                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd001483045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f3752601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2036
2037                         assert_eq!(unsigned_tx.1.len(), 3);
2038
2039                         test_htlc_output!(0,
2040                                           "3045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f891",
2041                                           "3045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb8",
2042                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a2180000000000000000000174020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100eed143b1ee4bed5dc3cde40afa5db3e7354cbf9c44054b5f713f729356f08cf7022077161d171c2bbd9badf3c9934de65a4918de03bbac1450f715275f75b103f89101483045022100a0d043ed533e7fb1911e0553d31a8e2f3e6de19dbc035257f29d747c5e02f1f5022030cd38d8e84282175d49c1ebe0470db3ebd59768cf40780a784e248a43904fb801008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2043
2044                         test_htlc_output!(1,
2045                                           "3044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf6",
2046                                           "3045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d",
2047                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a218010000000000000000015c060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022071e9357619fd8d29a411dc053b326a5224c5d11268070e88ecb981b174747c7a02202b763ae29a9d0732fa8836dd8597439460b50472183f420021b768981b4f7cf601483045022100adb1d679f65f96178b59f23ed37d3b70443118f345224a07ecb043eee2acc157022034d24524fe857144a3bcfff3065a9994d0a6ec5f11c681e49431d573e242612d01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2048
2049                         test_htlc_output!(2,
2050                                           "3045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a4",
2051                                           "304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04",
2052                                           "0200000000010140a83ce364747ff277f4d7595d8d15f708418798922c40bc2b056aca5485a21802000000000000000001f1090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100c9458a4d2cbb741705577deb0a890e5cb90ee141be0400d3162e533727c9cb2102206edcf765c5dc5e5f9b976ea8149bf8607b5a0efb30691138e1231302b640d2a40147304402200831422aa4e1ee6d55e0b894201770a8f8817a189356f2d70be76633ffa6a6f602200dd1b84a4855dc6727dd46c98daae43dfc70889d1ba7ef0087529a57c06e5e04012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2053                 }
2054
2055                 {
2056                         // commitment tx with five outputs untrimmed (maximum feerate)
2057                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2058                         chan.feerate_per_kw = 2194;
2059
2060                         test_commitment!("3045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec86203953348",
2061                                          "304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f7061",
2062                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311040966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f706101483045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec8620395334801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2063
2064                         assert_eq!(unsigned_tx.1.len(), 3);
2065
2066                         test_htlc_output!(0,
2067                                           "30450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf44",
2068                                           "3044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f",
2069                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004830450221009ed2f0a67f99e29c3c8cf45c08207b765980697781bb727fe0b1416de0e7622902206052684229bc171419ed290f4b615c943f819c0262414e43c5b91dcf72ddcf4401473044022004ad5f04ae69c71b3b141d4db9d0d4c38d84009fb3cfeeae6efdad414487a9a0022042d3fe1388c1ff517d1da7fb4025663d372c14728ed52dc88608363450ff6a2f01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a914b43e1b38138a41b37f7cd9a1d274bc63e3a9b5d188ac6868f6010000");
2070
2071                         test_htlc_output!(1,
2072                                           "30440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d",
2073                                           "304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c915",
2074                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a010000000000000000010a060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e05004730440220155d3b90c67c33a8321996a9be5b82431b0c126613be751d400669da9d5c696702204318448bcd48824439d2c6a70be6e5747446be47ff45977cf41672bdc9b6b12d0147304402201707050c870c1f77cc3ed58d6d71bf281de239e9eabd8ef0955bad0d7fe38dcc02204d36d80d0019b3a71e646a08fa4a5607761d341ae8be371946ebe437c289c91501008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2075
2076                         test_htlc_output!(2,
2077                                           "3045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a",
2078                                           "3045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0",
2079                                           "02000000000101fb824d4e4dafc0f567789dee3a6bce8d411fe80f5563d8cdfdcc7d7e4447d43a020000000000000000019a090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a12a9a473ece548584aabdd051779025a5ed4077c4b7aa376ec7a0b1645e5a48022039490b333f53b5b3e2ddde1d809e492cba2b3e5fc3a436cd3ffb4cd3d500fa5a01483045022100ff200bc934ab26ce9a559e998ceb0aee53bc40368e114ab9d3054d9960546e2802202496856ca163ac12c143110b6b3ac9d598df7254f2e17b3b94c3ab5301f4c3b0012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2080                 }
2081
2082                 {
2083                         // commitment tx with four outputs untrimmed (minimum feerate)
2084                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2085                         chan.feerate_per_kw = 2195;
2086
2087                         test_commitment!("304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb7924298",
2088                                          "304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a5429",
2089                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a54290147304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb792429801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2090
2091                         assert_eq!(unsigned_tx.1.len(), 2);
2092
2093                         test_htlc_output!(0,
2094                                           "3045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc",
2095                                           "3045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc704390",
2096                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0000000000000000000109060000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100a8a78fa1016a5c5c3704f2e8908715a3cef66723fb95f3132ec4d2d05cd84fb4022025ac49287b0861ec21932405f5600cbce94313dbde0e6c5d5af1b3366d8afbfc01483045022100be6ae1977fd7b630a53623f3f25c542317ccfc2b971782802a4f1ef538eb22b402207edc4d0408f8f38fd3c7365d1cfc26511b7cd2d4fecd8b005fba3cd5bc70439001008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2097
2098                         test_htlc_output!(1,
2099                                           "3045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92",
2100                                           "30440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8",
2101                                           "020000000001014e16c488fa158431c1a82e8f661240ec0a71ba0ce92f2721a6538c510226ad5c0100000000000000000199090000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100e769cb156aa2f7515d126cef7a69968629620ce82afcaa9e210969de6850df4602200b16b3f3486a229a48aadde520dbee31ae340dbadaffae74fbb56681fef27b92014730440220665b9cb4a978c09d1ca8977a534999bc8a49da624d0c5439451dd69cde1a003d022070eae0620f01f3c1bd029cc1488da13fb40fdab76f396ccd335479a11c5276d8012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2102                 }
2103
2104                 {
2105                         // commitment tx with four outputs untrimmed (maximum feerate)
2106                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2107                         chan.feerate_per_kw = 3702;
2108
2109                         test_commitment!("3045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c1",
2110                                          "304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b0",
2111                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431106f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b001483045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c101475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2112
2113                         assert_eq!(unsigned_tx.1.len(), 2);
2114
2115                         test_htlc_output!(0,
2116                                           "3045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb",
2117                                           "304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a",
2118                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100dfb73b4fe961b31a859b2bb1f4f15cabab9265016dd0272323dc6a9e85885c54022059a7b87c02861ee70662907f25ce11597d7b68d3399443a831ae40e777b76bdb0147304402202765b9c9ece4f127fa5407faf66da4c5ce2719cdbe47cd3175fc7d48b482e43d02205605125925e07bad1e41c618a4b434d72c88a164981c4b8af5eaf4ee9142ec3a01008576a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c820120876475527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae67a9148a486ff2e31d6158bf39e2608864d63fefd09d5b88ac6868f7010000");
2119
2120                         test_htlc_output!(1,
2121                                           "3045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9",
2122                                           "30440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c",
2123                                           "02000000000101b8de11eb51c22498fe39722c7227b6e55ff1a94146cf638458cb9bc6a060d3a30100000000000000000176050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100ea9dc2a7c3c3640334dab733bb4e036e32a3106dc707b24227874fa4f7da746802204d672f7ac0fe765931a8df10b81e53a3242dd32bd9dc9331eb4a596da87954e9014730440220048a41c660c4841693de037d00a407810389f4574b3286afb7bc392a438fa3f802200401d71fa87c64fe621b49ac07e3bf85157ac680acb977124da28652cc7f1a5c012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2124                 }
2125
2126                 {
2127                         // commitment tx with three outputs untrimmed (minimum feerate)
2128                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2129                         chan.feerate_per_kw = 3703;
2130
2131                         test_commitment!("30450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb0",
2132                                          "3044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506",
2133                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506014830450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2134
2135                         assert_eq!(unsigned_tx.1.len(), 1);
2136
2137                         test_htlc_output!(0,
2138                                           "3044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd",
2139                                           "3045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724",
2140                                           "020000000001011c076aa7fb3d7460d10df69432c904227ea84bbf3134d4ceee5fb0f135ef206d0000000000000000000175050000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500473044022044f65cf833afdcb9d18795ca93f7230005777662539815b8a601eeb3e57129a902206a4bf3e53392affbba52640627defa8dc8af61c958c9e827b2798ab45828abdd01483045022100b94d931a811b32eeb885c28ddcf999ae1981893b21dd1329929543fe87ce793002206370107fdd151c5f2384f9ceb71b3107c69c74c8ed5a28a94a4ab2d27d3b0724012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2141                 }
2142
2143                 {
2144                         // commitment tx with three outputs untrimmed (maximum feerate)
2145                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2146                         chan.feerate_per_kw = 4914;
2147
2148                         test_commitment!("304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e",
2149                                          "304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe26",
2150                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe260147304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2151
2152                         assert_eq!(unsigned_tx.1.len(), 1);
2153
2154                         test_htlc_output!(0,
2155                                           "3045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf",
2156                                           "304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68",
2157                                           "0200000000010110a3fdcbcd5db477cd3ad465e7f501ffa8c437e8301f00a6061138590add757f0000000000000000000122020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0500483045022100fcb38506bfa11c02874092a843d0cc0a8613c23b639832564a5f69020cb0f6ba02206508b9e91eaa001425c190c68ee5f887e1ad5b1b314002e74db9dbd9e42dbecf0148304502210086e76b460ddd3cea10525fba298405d3fe11383e56966a5091811368362f689a02200f72ee75657915e0ede89c28709acd113ede9e1b7be520e3bc5cda425ecd6e68012004040404040404040404040404040404040404040404040404040404040404048a76a91414011f7254d96b819c76986c277d115efce6f7b58763ac67210394854aa6eab5b2a8122cc726e9dded053a2184d88256816826d6231c068d4a5b7c8201208763a91418bc1a114ccf9c052d3d23e28d3b0a9d1227434288527c21030d417a46946384f88d5f3337267c5e579765875dc4daca813e21734b140639e752ae677502f801b175ac686800000000");
2158                 }
2159
2160                 {
2161                         // commitment tx with two outputs untrimmed (minimum feerate)
2162                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2163                         chan.feerate_per_kw = 4915;
2164
2165                         test_commitment!("304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f8765552",
2166                                          "3045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b9",
2167                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b90147304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f876555201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2168
2169                         assert_eq!(unsigned_tx.1.len(), 0);
2170                 }
2171
2172                 {
2173                         // commitment tx with two outputs untrimmed (maximum feerate)
2174                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2175                         chan.feerate_per_kw = 9651180;
2176
2177                         test_commitment!("3044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd",
2178                                          "30440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b9",
2179                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311004004730440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b901473044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2180
2181                         assert_eq!(unsigned_tx.1.len(), 0);
2182                 }
2183
2184                 {
2185                         // commitment tx with one output untrimmed (minimum feerate)
2186                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2187                         chan.feerate_per_kw = 9651181;
2188
2189                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
2190                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
2191                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2192
2193                         assert_eq!(unsigned_tx.1.len(), 0);
2194                 }
2195
2196                 {
2197                         // commitment tx with fee greater than funder amount
2198                         chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000
2199                         chan.feerate_per_kw = 9651936;
2200
2201                         test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e",
2202                                          "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1",
2203                                          "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220");
2204
2205                         assert_eq!(unsigned_tx.1.len(), 0);
2206                 }
2207         }
2208
2209         #[test]
2210         fn test_per_commitment_secret_gen() {
2211                 // Test vectors from BOLT 3 Appendix D:
2212
2213                 let mut seed = [0; 32];
2214                 seed[0..32].clone_from_slice(&hex_bytes("0000000000000000000000000000000000000000000000000000000000000000").unwrap());
2215                 assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655),
2216                                 hex_bytes("02a40c85b6f28da08dfdbe0926c53fab2de6d28c10301f8f7c4073d5e42e3148").unwrap()[..]);
2217
2218                 seed[0..32].clone_from_slice(&hex_bytes("FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF").unwrap());
2219                 assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655),
2220                                 hex_bytes("7cc854b54e3e0dcdb010d7a3fee464a9687be6e8db3be6854c475621e007a5dc").unwrap()[..]);
2221
2222                 assert_eq!(chan_utils::build_commitment_secret(seed, 0xaaaaaaaaaaa),
2223                                 hex_bytes("56f4008fb007ca9acf0e15b054d5c9fd12ee06cea347914ddbaed70d1c13a528").unwrap()[..]);
2224
2225                 assert_eq!(chan_utils::build_commitment_secret(seed, 0x555555555555),
2226                                 hex_bytes("9015daaeb06dba4ccc05b91b2f73bd54405f2be9f217fbacd3c5ac2e62327d31").unwrap()[..]);
2227
2228                 seed[0..32].clone_from_slice(&hex_bytes("0101010101010101010101010101010101010101010101010101010101010101").unwrap());
2229                 assert_eq!(chan_utils::build_commitment_secret(seed, 1),
2230                                 hex_bytes("915c75942a26bb3a433a8ce2cb0427c29ec6c1775cfc78328b57f6ba7bfeaa9c").unwrap()[..]);
2231         }
2232
2233         #[test]
2234         fn test_key_derivation() {
2235                 // Test vectors from BOLT 3 Appendix E:
2236                 let secp_ctx = Secp256k1::new();
2237
2238                 let base_secret = SecretKey::from_slice(&secp_ctx, &hex_bytes("000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f").unwrap()[..]).unwrap();
2239                 let per_commitment_secret = SecretKey::from_slice(&secp_ctx, &hex_bytes("1f1e1d1c1b1a191817161514131211100f0e0d0c0b0a09080706050403020100").unwrap()[..]).unwrap();
2240
2241                 let base_point = PublicKey::from_secret_key(&secp_ctx, &base_secret).unwrap();
2242                 assert_eq!(base_point.serialize()[..], hex_bytes("036d6caac248af96f6afa7f904f550253a0f3ef3f5aa2fe6838a95b216691468e2").unwrap()[..]);
2243
2244                 let per_commitment_point = PublicKey::from_secret_key(&secp_ctx, &per_commitment_secret).unwrap();
2245                 assert_eq!(per_commitment_point.serialize()[..], hex_bytes("025f7117a78150fe2ef97db7cfc83bd57b2e2c0d0dd25eaf467a4a1c2a45ce1486").unwrap()[..]);
2246
2247                 assert_eq!(chan_utils::derive_public_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
2248                                 hex_bytes("0235f2dbfaa89b57ec7b055afe29849ef7ddfeb1cefdb9ebdc43f5494984db29e5").unwrap()[..]);
2249
2250                 assert_eq!(chan_utils::derive_private_key(&secp_ctx, &per_commitment_point, &base_secret).unwrap(),
2251                                 SecretKey::from_slice(&secp_ctx, &hex_bytes("cbced912d3b21bf196a766651e436aff192362621ce317704ea2f75d87e7be0f").unwrap()[..]).unwrap());
2252
2253                 assert_eq!(chan_utils::derive_public_revocation_key(&secp_ctx, &per_commitment_point, &base_point).unwrap().serialize()[..],
2254                                 hex_bytes("02916e326636d19c33f13e8c0c3a03dd157f332f3e99c317c141dd865eb01f8ff0").unwrap()[..]);
2255
2256                 assert_eq!(chan_utils::derive_private_revocation_key(&secp_ctx, &per_commitment_secret, &base_secret).unwrap(),
2257                                 SecretKey::from_slice(&secp_ctx, &hex_bytes("d09ffff62ddb2297ab000cc85bcb4283fdeb6aa052affbc9dddcf33b61078110").unwrap()[..]).unwrap());
2258         }
2259 }