Merge pull request #671 from valentinewallace/bump-msrv

[rust-lightning] / .github / workflows / build.yml

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 43ed94dd9ebaa6a3b26b5ee287deb4a6ca4230bc..9a24b15cc514512b16309b04e4c284bddea2142a 100644 (file)
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -1,7 +1,6 @@
 name: Continuous Integration Checks
 
-on:
-  push:
+on: [push, pull_request]
 
 jobs:
   build:
@@ -9,8 +8,8 @@ jobs:
       matrix:
         toolchain: [ stable,
                      beta,
-                     # 1.22.0 is MSRV for rust-lightning in general:
-                     1.22.0,
+                     # 1.30.0 is MSRV for Rust-Lightning
+                     1.30.0,
                      # 1.34.2 is Debian stable
                      1.34.2,
                      # 1.39.0 is MSRV for lightning-net-tokio and generates coverage
@@ -35,16 +34,16 @@ jobs:
           profile: minimal
       - name: Build on Rust ${{ matrix.toolchain }} with net-tokio
         if: matrix.build-net-tokio
-        run: RUSTFLAGS="-C link-dead-code" cargo build --verbose
+        run: RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always
       - name: Build on Rust ${{ matrix.toolchain }}
         if: "! matrix.build-net-tokio"
-        run: RUSTFLAGS="-C link-dead-code" cargo build --verbose -p lightning
+        run: RUSTFLAGS="-C link-dead-code" cargo build --verbose  --color always -p lightning
       - name: Test on Rust ${{ matrix.toolchain }} with net-tokio
         if: matrix.build-net-tokio
-        run: RUSTFLAGS="-C link-dead-code" cargo test --verbose
+        run: RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always
       - name: Test on Rust ${{ matrix.toolchain }}
         if: "! matrix.build-net-tokio"
-        run: RUSTFLAGS="-C link-dead-code" cargo test --verbose -p lightning
+        run: RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always  -p lightning
       - name: Install deps for kcov
         if: matrix.coverage
         run: |
@@ -72,6 +71,10 @@ jobs:
         if: matrix.coverage
         uses: codecov/codecov-action@v1
         with:
+          # Could you use this to fake the coverage report for your PR? Sure.
+          # Will anyone be impressed by your amazing coverage? No
+          # Maybe if codecov wasn't broken we wouldn't need to do this...
+          token: f421b687-4dc2-4387-ac3d-dc3b2528af57
           fail_ci_if_error: true
 
   fuzz:
@@ -91,7 +94,7 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get -y install build-essential binutils-dev libunwind-dev
-      - name: Fuzz test on Rust ${{ matrix.TOOLCHAIN }}
-        run: cd fuzz && cargo test --verbose
-      - name: Generate fuzz report
+      - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
+        run: cd fuzz && cargo test --verbose --color always
+      - name: Run fuzzers
         run: cd fuzz && ./ci-fuzz.sh