Merge pull request #2693 from Evanfeenstra/next-hop-pubkey-secp-mode

[rust-lightning] / lightning / src / chain / chaininterface.rs

diff --git a/lightning/src/chain/chaininterface.rs b/lightning/src/chain/chaininterface.rs
index dfb90135c88de84b2d9fe962c9e05d354cbab86b..73707f05236f8ae487308022d49414ba63db5ed0 100644 (file)
--- a/lightning/src/chain/chaininterface.rs
+++ b/lightning/src/chain/chaininterface.rs
@@ -71,14 +71,12 @@ pub enum ConfirmationTarget {
        /// [`ChannelConfig::max_dust_htlc_exposure`]: crate::util::config::ChannelConfig::max_dust_htlc_exposure
        MaxAllowedNonAnchorChannelRemoteFee,
        /// This is the lowest feerate we will allow our channel counterparty to have in an anchor
-       /// channel in order to close the channel if a channel party goes away. Because our counterparty
-       /// must ensure they can always broadcast the latest state, this value being too high will cause
-       /// immediate force-closures.
+       /// channel in order to close the channel if a channel party goes away.
        ///
        /// This needs to be sufficient to get into the mempool when the channel needs to
-       /// be force-closed. Setting too low may result in force-closures. Because this is for anchor
-       /// channels, we can always bump the feerate later, the feerate here only needs to suffice to
-       /// enter the mempool.
+       /// be force-closed. Setting too high may result in force-closures if our counterparty attempts
+       /// to use a lower feerate. Because this is for anchor channels, we can always bump the feerate
+       /// later; the feerate here only needs to be sufficient to enter the mempool.
        ///
        /// A good estimate is the expected mempool minimum at the time of force-closure. Obviously this
        /// is not an estimate which is very easy to calculate because we do not know the future. Using
@@ -87,13 +85,10 @@ pub enum ConfirmationTarget {
        /// (package relay) may obviate the need for this entirely.
        MinAllowedAnchorChannelRemoteFee,
        /// The lowest feerate we will allow our channel counterparty to have in a non-anchor channel.
-       /// This needs to be sufficient to get confirmed when the channel needs to be force-closed.
-       /// Setting too low may result in force-closures.
        ///
        /// This is the feerate on the transaction which we (or our counterparty) will broadcast in
-       /// order to close the channel if a channel party goes away. Because our counterparty must
-       /// ensure they can always broadcast the latest state, this value being too high will cause
-       /// immediate force-closures.
+       /// order to close the channel if a channel party goes away. Setting this value too high will
+       /// cause immediate force-closures in order to avoid having an unbroadcastable state.
        ///
        /// This feerate represents the fee we pick now, which must be sufficient to enter a block at an
        /// arbitrary time in the future. Obviously this is not an estimate which is very easy to