Merge pull request #1748 from valentinewallace/2022-10-custom-oms
[rust-lightning] / lightning / src / onion_message / packet.rs
index 20b1fb0b82fdf5cf0c0b16096f524110d20ba6da..41b8a1634f6bcf68147e15e301c72515a543004f 100644 (file)
@@ -16,7 +16,7 @@ use ln::msgs::DecodeError;
 use ln::onion_utils;
 use super::blinded_route::{BlindedRoute, ForwardTlvs, ReceiveTlvs};
 use util::chacha20poly1305rfc::{ChaChaPolyReadAdapter, ChaChaPolyWriteAdapter};
-use util::ser::{BigSize, FixedLengthReader, LengthRead, LengthReadable, LengthReadableArgs, Readable, ReadableArgs, Writeable, Writer};
+use util::ser::{BigSize, FixedLengthReader, LengthRead, LengthReadable, LengthReadableArgs, MaybeReadableArgs, Readable, ReadableArgs, Writeable, Writer};
 
 use core::cmp;
 use io::{self, Read};
@@ -92,25 +92,52 @@ impl LengthReadable for Packet {
 /// Onion message payloads contain "control" TLVs and "data" TLVs. Control TLVs are used to route
 /// the onion message from hop to hop and for path verification, whereas data TLVs contain the onion
 /// message content itself, such as an invoice request.
-pub(super) enum Payload {
+pub(super) enum Payload<T: CustomOnionMessageContents> {
        /// This payload is for an intermediate hop.
        Forward(ForwardControlTlvs),
        /// This payload is for the final hop.
        Receive {
                control_tlvs: ReceiveControlTlvs,
                reply_path: Option<BlindedRoute>,
-               // Coming soon:
-               // message: Message,
+               message: OnionMessageContents<T>,
        }
 }
 
-// Coming soon:
-// enum Message {
-//     InvoiceRequest(InvoiceRequest),
-//     Invoice(Invoice),
-//     InvoiceError(InvoiceError),
-//     CustomMessage<T>,
-// }
+#[derive(Debug)]
+/// The contents of an onion message. In the context of offers, this would be the invoice, invoice
+/// request, or invoice error.
+pub enum OnionMessageContents<T> where T: CustomOnionMessageContents {
+       // Coming soon:
+       // Invoice,
+       // InvoiceRequest,
+       // InvoiceError,
+       /// A custom onion message specified by the user.
+       Custom(T),
+}
+
+impl<T> OnionMessageContents<T> where T: CustomOnionMessageContents {
+       /// Returns the type that was used to decode the message payload.
+       pub fn tlv_type(&self) -> u64 {
+               match self {
+                       &OnionMessageContents::Custom(ref msg) => msg.tlv_type(),
+               }
+       }
+}
+
+impl<T: CustomOnionMessageContents> Writeable for OnionMessageContents<T> {
+       fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
+               match self {
+                       OnionMessageContents::Custom(msg) => Ok(msg.write(w)?),
+               }
+       }
+}
+
+/// The contents of a custom onion message. Must implement `MaybeReadableArgs<u64>` where the `u64`
+/// is the custom TLV type attempting to be read, and return `Ok(None)` if the TLV type is unknown.
+pub trait CustomOnionMessageContents: Writeable + MaybeReadableArgs<u64> {
+       /// Returns the TLV type identifying the message contents. MUST be >= 64.
+       fn tlv_type(&self) -> u64;
+}
 
 /// Forward control TLVs in their blinded and unblinded form.
 pub(super) enum ForwardControlTlvs {
@@ -132,7 +159,7 @@ pub(super) enum ReceiveControlTlvs {
 }
 
 // Uses the provided secret to simultaneously encode and encrypt the unblinded control TLVs.
-impl Writeable for (Payload, [u8; 32]) {
+impl<T: CustomOnionMessageContents> Writeable for (Payload<T>, [u8; 32]) {
        fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {
                match &self.0 {
                        Payload::Forward(ForwardControlTlvs::Blinded(encrypted_bytes)) => {
@@ -141,11 +168,12 @@ impl Writeable for (Payload, [u8; 32]) {
                                })
                        },
                        Payload::Receive {
-                               control_tlvs: ReceiveControlTlvs::Blinded(encrypted_bytes), reply_path
+                               control_tlvs: ReceiveControlTlvs::Blinded(encrypted_bytes), reply_path, message,
                        } => {
                                encode_varint_length_prefixed_tlv!(w, {
                                        (2, reply_path, option),
-                                       (4, encrypted_bytes, vec_type)
+                                       (4, encrypted_bytes, vec_type),
+                                       (message.tlv_type(), message, required)
                                })
                        },
                        Payload::Forward(ForwardControlTlvs::Unblinded(control_tlvs)) => {
@@ -155,12 +183,13 @@ impl Writeable for (Payload, [u8; 32]) {
                                })
                        },
                        Payload::Receive {
-                               control_tlvs: ReceiveControlTlvs::Unblinded(control_tlvs), reply_path,
+                               control_tlvs: ReceiveControlTlvs::Unblinded(control_tlvs), reply_path, message,
                        } => {
                                let write_adapter = ChaChaPolyWriteAdapter::new(self.1, &control_tlvs);
                                encode_varint_length_prefixed_tlv!(w, {
                                        (2, reply_path, option),
-                                       (4, write_adapter, required)
+                                       (4, write_adapter, required),
+                                       (message.tlv_type(), message, required)
                                })
                        },
                }
@@ -168,28 +197,52 @@ impl Writeable for (Payload, [u8; 32]) {
        }
 }
 
-// Uses the provided secret to simultaneously decode and decrypt the control TLVs.
-impl ReadableArgs<SharedSecret> for Payload {
+// Uses the provided secret to simultaneously decode and decrypt the control TLVs and data TLV.
+impl<T: CustomOnionMessageContents> ReadableArgs<SharedSecret> for Payload<T> {
        fn read<R: Read>(r: &mut R, encrypted_tlvs_ss: SharedSecret) -> Result<Self, DecodeError> {
                let v: BigSize = Readable::read(r)?;
                let mut rd = FixedLengthReader::new(r, v.0);
                let mut reply_path: Option<BlindedRoute> = None;
                let mut read_adapter: Option<ChaChaPolyReadAdapter<ControlTlvs>> = None;
                let rho = onion_utils::gen_rho_from_shared_secret(&encrypted_tlvs_ss.secret_bytes());
+               let mut message_type: Option<u64> = None;
+               let mut message = None;
                decode_tlv_stream!(&mut rd, {
                        (2, reply_path, option),
-                       (4, read_adapter, (option: LengthReadableArgs, rho))
+                       (4, read_adapter, (option: LengthReadableArgs, rho)),
+               }, |msg_type, msg_reader| {
+                       if msg_type < 64 { return Ok(false) }
+                       // Don't allow reading more than one data TLV from an onion message.
+                       if message_type.is_some() { return Err(DecodeError::InvalidValue) }
+
+                       message_type = Some(msg_type);
+                       match T::read(msg_reader, msg_type) {
+                               Ok(Some(msg)) => {
+                                       message = Some(msg);
+                                       Ok(true)
+                               },
+                               Ok(None) => Ok(false),
+                               Err(e) => Err(e),
+                       }
                });
                rd.eat_remaining().map_err(|_| DecodeError::ShortRead)?;
 
                match read_adapter {
                        None => return Err(DecodeError::InvalidValue),
                        Some(ChaChaPolyReadAdapter { readable: ControlTlvs::Forward(tlvs)}) => {
+                               if message_type.is_some() {
+                                       return Err(DecodeError::InvalidValue)
+                               }
                                Ok(Payload::Forward(ForwardControlTlvs::Unblinded(tlvs)))
                        },
                        Some(ChaChaPolyReadAdapter { readable: ControlTlvs::Receive(tlvs)}) => {
-                               Ok(Payload::Receive { control_tlvs: ReceiveControlTlvs::Unblinded(tlvs), reply_path })
-                       },
+                               if message.is_none() { return Err(DecodeError::InvalidValue) }
+                               Ok(Payload::Receive {
+                                       control_tlvs: ReceiveControlTlvs::Unblinded(tlvs),
+                                       reply_path,
+                                       message: OnionMessageContents::Custom(message.unwrap()),
+                               })
+                       }
                }
        }
 }