Penalize failed channels in Scorer
[rust-lightning] / lightning / src / routing / scorer.rs
index 01481f16c297f9218aa05082b3fbdc7f22e886ba..d2a7cebd3b1c9ea306eabe69ff8b08ff93de237a 100644 (file)
@@ -19,7 +19,7 @@
 //! #
 //! # use lightning::routing::network_graph::NetworkGraph;
 //! # use lightning::routing::router::{RouteParameters, find_route};
-//! # use lightning::routing::scorer::Scorer;
+//! # use lightning::routing::scorer::{Scorer, ScoringParameters};
 //! # use lightning::util::logger::{Logger, Record};
 //! # use secp256k1::key::PublicKey;
 //! #
 //! # fn find_scored_route(payer: PublicKey, params: RouteParameters, network_graph: NetworkGraph) {
 //! # let logger = FakeLogger {};
 //! #
-//! // Use the default channel penalty.
+//! // Use the default channel penalties.
 //! let scorer = Scorer::default();
 //!
-//! // Or use a custom channel penalty.
-//! let scorer = Scorer::new(1_000);
+//! // Or use custom channel penalties.
+//! let scorer = Scorer::new(ScoringParameters {
+//!     base_penalty_msat: 1000, ..ScoringParameters::default()
+//! });
 //!
 //! let route = find_route(&payer, &params, &network_graph, None, &logger, &scorer);
 //! # }
@@ -48,39 +50,128 @@ use routing::network_graph::NodeId;
 use routing::router::RouteHop;
 
 use prelude::*;
+#[cfg(not(feature = "no-std"))]
+use core::time::Duration;
+#[cfg(not(feature = "no-std"))]
+use std::time::SystemTime;
 
 /// [`routing::Score`] implementation that provides reasonable default behavior.
 ///
 /// Used to apply a fixed penalty to each channel, thus avoiding long paths when shorter paths with
-/// slightly higher fees are available.
+/// slightly higher fees are available. May also further penalize failed channels.
 ///
 /// See [module-level documentation] for usage.
 ///
 /// [module-level documentation]: crate::routing::scorer
 pub struct Scorer {
-       base_penalty_msat: u64,
+       params: ScoringParameters,
+       #[cfg(not(feature = "no-std"))]
+       channel_failures: HashMap<u64, (u64, SystemTime)>,
+       #[cfg(feature = "no-std")]
+       channel_failures: HashMap<u64, u64>,
+}
+
+/// Parameters for configuring [`Scorer`].
+pub struct ScoringParameters {
+       /// A fixed penalty in msats to apply to each channel.
+       pub base_penalty_msat: u64,
+
+       /// A penalty in msats to apply to a channel upon failure.
+       ///
+       /// This may be reduced over time based on [`failure_penalty_decay_interval`].
+       ///
+       /// [`failure_penalty_decay_interval`]: Self::failure_penalty_decay_interval
+       pub failure_penalty_msat: u64,
+
+       /// The time needed before any accumulated channel failure penalties are cut in half.
+       #[cfg(not(feature = "no-std"))]
+       pub failure_penalty_decay_interval: Duration,
 }
 
 impl Scorer {
-       /// Creates a new scorer using `base_penalty_msat` as the channel penalty.
-       pub fn new(base_penalty_msat: u64) -> Self {
-               Self { base_penalty_msat }
+       /// Creates a new scorer using the given scoring parameters.
+       pub fn new(params: ScoringParameters) -> Self {
+               Self {
+                       params,
+                       channel_failures: HashMap::new(),
+               }
+       }
+
+       /// Creates a new scorer using `penalty_msat` as a fixed channel penalty.
+       pub fn with_fixed_penalty(penalty_msat: u64) -> Self {
+               Self::new(ScoringParameters {
+                       base_penalty_msat: penalty_msat,
+                       failure_penalty_msat: 0,
+                       #[cfg(not(feature = "no-std"))]
+                       failure_penalty_decay_interval: Duration::from_secs(0),
+               })
+       }
+
+       #[cfg(not(feature = "no-std"))]
+       fn decay_from(&self, penalty_msat: u64, last_failure: &SystemTime) -> u64 {
+               decay_from(penalty_msat, last_failure, self.params.failure_penalty_decay_interval)
        }
 }
 
 impl Default for Scorer {
-       /// Creates a new scorer using 500 msat as the channel penalty.
        fn default() -> Self {
-               Scorer::new(500)
+               Scorer::new(ScoringParameters::default())
+       }
+}
+
+impl Default for ScoringParameters {
+       fn default() -> Self {
+               Self {
+                       base_penalty_msat: 500,
+                       failure_penalty_msat: 1024,
+                       #[cfg(not(feature = "no-std"))]
+                       failure_penalty_decay_interval: Duration::from_secs(3600),
+               }
        }
 }
 
 impl routing::Score for Scorer {
        fn channel_penalty_msat(
-               &self, _short_channel_id: u64, _source: &NodeId, _target: &NodeId
+               &self, short_channel_id: u64, _source: &NodeId, _target: &NodeId
        ) -> u64 {
-               self.base_penalty_msat
+               #[cfg(not(feature = "no-std"))]
+               let failure_penalty_msat = match self.channel_failures.get(&short_channel_id) {
+                       Some((penalty_msat, last_failure)) => self.decay_from(*penalty_msat, last_failure),
+                       None => 0,
+               };
+               #[cfg(feature = "no-std")]
+               let failure_penalty_msat =
+                       self.channel_failures.get(&short_channel_id).copied().unwrap_or(0);
+
+               self.params.base_penalty_msat + failure_penalty_msat
+       }
+
+       fn payment_path_failed(&mut self, _path: &Vec<RouteHop>, short_channel_id: u64) {
+               let failure_penalty_msat = self.params.failure_penalty_msat;
+               #[cfg(not(feature = "no-std"))]
+               {
+                       let decay_interval = self.params.failure_penalty_decay_interval;
+                       self.channel_failures
+                               .entry(short_channel_id)
+                               .and_modify(|(penalty_msat, last_failure)| {
+                                       let decayed_penalty = decay_from(*penalty_msat, last_failure, decay_interval);
+                                       *penalty_msat = decayed_penalty + failure_penalty_msat;
+                                       *last_failure = SystemTime::now();
+                               })
+                               .or_insert_with(|| (failure_penalty_msat, SystemTime::now()));
+               }
+               #[cfg(feature = "no-std")]
+               self.channel_failures
+                       .entry(short_channel_id)
+                       .and_modify(|penalty_msat| *penalty_msat += failure_penalty_msat)
+                       .or_insert(failure_penalty_msat);
        }
+}
 
-       fn payment_path_failed(&mut self, _path: &Vec<RouteHop>, _short_channel_id: u64) {}
+#[cfg(not(feature = "no-std"))]
+fn decay_from(penalty_msat: u64, last_failure: &SystemTime, decay_interval: Duration) -> u64 {
+       let decays = last_failure.elapsed().map_or(0, |elapsed| {
+               elapsed.as_secs() / decay_interval.as_secs()
+       });
+       penalty_msat >> decays
 }