ChannelKeys - separate commitment revocation from getting the per-commitment point

[rust-lightning] / lightning / src / util / enforcing_trait_impls.rs

diff --git a/lightning/src/util/enforcing_trait_impls.rs b/lightning/src/util/enforcing_trait_impls.rs
index 425b2124f9cc146bca00363489f4118fbfee4638..c1d3d490262b84d41e08bda7509f6cff8e1b8b69 100644 (file)
--- a/lightning/src/util/enforcing_trait_impls.rs
+++ b/lightning/src/util/enforcing_trait_impls.rs
@@ -35,8 +35,6 @@ impl EnforcingChannelKeys {
 impl EnforcingChannelKeys {
        fn check_keys<T: secp256k1::Signing + secp256k1::Verification>(&self, secp_ctx: &Secp256k1<T>,
                                                                       keys: &TxCreationKeys) {
-               let htlc_base = PublicKey::from_secret_key(secp_ctx, &self.inner.htlc_base_key());
-
                let remote_points = self.inner.remote_channel_pubkeys.as_ref().unwrap();
 
                let keys_expected = TxCreationKeys::new(secp_ctx,
@@ -44,19 +42,25 @@ impl EnforcingChannelKeys {
                                                        &remote_points.delayed_payment_basepoint,
                                                        &remote_points.htlc_basepoint,
                                                        &self.inner.pubkeys().revocation_basepoint,
-                                                       &htlc_base).unwrap();
+                                                       &self.inner.pubkeys().htlc_basepoint).unwrap();
                if keys != &keys_expected { panic!("derived different per-tx keys") }
        }
 }
 
 impl ChannelKeys for EnforcingChannelKeys {
-       fn delayed_payment_base_key(&self) -> &SecretKey { self.inner.delayed_payment_base_key() }
-       fn htlc_base_key(&self) -> &SecretKey { self.inner.htlc_base_key() }
-       fn commitment_seed(&self) -> &[u8; 32] { self.inner.commitment_seed() }
-       fn pubkeys<'a>(&'a self) -> &'a ChannelPublicKeys { self.inner.pubkeys() }
+       fn get_per_commitment_point<T: secp256k1::Signing + secp256k1::Verification>(&self, idx: u64, secp_ctx: &Secp256k1<T>) -> PublicKey {
+               self.inner.get_per_commitment_point(idx, secp_ctx)
+       }
+
+       fn release_commitment_secret(&self, idx: u64) -> [u8; 32] {
+               // TODO: enforce the ChannelKeys contract - error here if we already signed this commitment
+               self.inner.release_commitment_secret(idx)
+       }
+
+       fn pubkeys(&self) -> &ChannelPublicKeys { self.inner.pubkeys() }
        fn key_derivation_params(&self) -> (u64, u64) { self.inner.key_derivation_params() }
 
-       fn sign_remote_commitment<T: secp256k1::Signing + secp256k1::Verification>(&self, feerate_per_kw: u64, commitment_tx: &Transaction, keys: &TxCreationKeys, htlcs: &[&HTLCOutputInCommitment], to_self_delay: u16, secp_ctx: &Secp256k1<T>) -> Result<(Signature, Vec<Signature>), ()> {
+       fn sign_remote_commitment<T: secp256k1::Signing + secp256k1::Verification>(&self, feerate_per_kw: u32, commitment_tx: &Transaction, keys: &TxCreationKeys, htlcs: &[&HTLCOutputInCommitment], to_self_delay: u16, secp_ctx: &Secp256k1<T>) -> Result<(Signature, Vec<Signature>), ()> {
                if commitment_tx.input.len() != 1 { panic!("lightning commitment transactions have a single input"); }
                self.check_keys(secp_ctx, keys);
                let obscured_commitment_transaction_number = (commitment_tx.lock_time & 0xffffff) as u64 | ((commitment_tx.input[0].sequence as u64 & 0xffffff) << 3*8);
@@ -75,6 +79,8 @@ impl ChannelKeys for EnforcingChannelKeys {
        }
 
        fn sign_local_commitment<T: secp256k1::Signing + secp256k1::Verification>(&self, local_commitment_tx: &LocalCommitmentTransaction, secp_ctx: &Secp256k1<T>) -> Result<Signature, ()> {
+               // TODO: enforce the ChannelKeys contract - error if this commitment was already revoked
+               // TODO: need the commitment number
                Ok(self.inner.sign_local_commitment(local_commitment_tx, secp_ctx).unwrap())
        }