Use libbitcoinconsensus to check tx validity in some tests
[rust-lightning] / src / ln / channelmanager.rs
index 6d631435a5e2572b730f3a4b456f3f46a41c8b73..50aac54c3a0010a27e5e2be465fe99f35a6677ed 100644 (file)
@@ -838,7 +838,7 @@ impl ChannelManager {
                                false
                        },
                        PendingOutboundHTLC::IntermediaryHopData { source_short_channel_id, .. } => {
-                               let (node_id, fulfill_msg) = {
+                               let (node_id, fulfill_msg, monitor) = {
                                        let chan_id = match channel_state.short_to_id.get(&source_short_channel_id) {
                                                Some(chan_id) => chan_id.clone(),
                                                None => return false
@@ -846,7 +846,7 @@ impl ChannelManager {
 
                                        let chan = channel_state.by_id.get_mut(&chan_id).unwrap();
                                        match chan.get_update_fulfill_htlc(payment_preimage) {
-                                               Ok(msg) => (chan.get_their_node_id(), msg),
+                                               Ok(msg) => (chan.get_their_node_id(), msg, if from_user { Some(chan.channel_monitor()) } else { None }),
                                                Err(_e) => {
                                                        //TODO: Do something with e?
                                                        return false;
@@ -854,14 +854,23 @@ impl ChannelManager {
                                        }
                                };
 
-                               mem::drop(channel_state);
-                               let mut pending_events = self.pending_events.lock().unwrap();
-                               pending_events.push(events::Event::SendFulfillHTLC {
-                                       node_id: node_id,
-                                       msg: fulfill_msg
-                               });
+                               {
+                                       mem::drop(channel_state);
+                                       let mut pending_events = self.pending_events.lock().unwrap();
+                                       pending_events.push(events::Event::SendFulfillHTLC {
+                                               node_id: node_id,
+                                               msg: fulfill_msg
+                                       });
+                               }
 
-                               true
+                               //TODO: It may not be possible to handle add_update_monitor fails gracefully, maybe
+                               //it should return no Err? Sadly, panic!()s instead doesn't help much :(
+                               if from_user {
+                                       match self.monitor.add_update_monitor(monitor.as_ref().unwrap().get_funding_txo().unwrap(), monitor.unwrap()) {
+                                               Ok(()) => true,
+                                               Err(_) => true,
+                                       }
+                               } else { true }
                        },
                }
        }
@@ -1319,7 +1328,7 @@ impl ChannelMessageHandler for ChannelManager {
        }
 
        fn handle_update_fulfill_htlc(&self, their_node_id: &PublicKey, msg: &msgs::UpdateFulfillHTLC) -> Result<(), HandleError> {
-               {
+               let monitor = {
                        let mut channel_state = self.channel_state.lock().unwrap();
                        match channel_state.by_id.get_mut(&msg.channel_id) {
                                Some(chan) => {
@@ -1327,12 +1336,14 @@ impl ChannelMessageHandler for ChannelManager {
                                                return Err(HandleError{err: "Got a message for a channel from the wrong node!", msg: None})
                                        }
                                        chan.update_fulfill_htlc(&msg)?;
+                                       chan.channel_monitor()
                                },
                                None => return Err(HandleError{err: "Failed to find corresponding channel", msg: None})
                        }
-               }
+               };
                //TODO: Delay the claimed_funds relaying just like we do outbound relay!
                self.claim_funds_internal(msg.payment_preimage.clone(), false);
+               self.monitor.add_update_monitor(monitor.get_funding_txo().unwrap(), monitor)?;
                Ok(())
        }
 
@@ -1481,6 +1492,37 @@ impl ChannelMessageHandler for ChannelManager {
                pending_events.push(events::Event::BroadcastChannelAnnouncement { msg: chan_announcement, update_msg: chan_update });
                Ok(())
        }
+
+       fn peer_disconnected(&self, their_node_id: &PublicKey, no_connection_possible: bool) {
+               let mut channel_state_lock = self.channel_state.lock().unwrap();
+               let channel_state = channel_state_lock.borrow_parts();
+               let short_to_id = channel_state.short_to_id;
+               if no_connection_possible {
+                       channel_state.by_id.retain(move |_, chan| {
+                               if chan.get_their_node_id() == *their_node_id {
+                                       match chan.get_short_channel_id() {
+                                               Some(short_id) => {
+                                                       short_to_id.remove(&short_id);
+                                               },
+                                               None => {},
+                                       }
+                                       //TODO: get the latest commitment tx, any HTLC txn built on top of it, etc out
+                                       //of the channel and throw those into the announcement blackhole.
+                                       false
+                               } else {
+                                       true
+                               }
+                       });
+               } else {
+                       for chan in channel_state.by_id {
+                               if chan.1.get_their_node_id() == *their_node_id {
+                                       //TODO: mark channel disabled (and maybe announce such after a timeout). Also
+                                       //fail and wipe any uncommitted outbound HTLCs as those are considered after
+                                       //reconnect.
+                               }
+                       }
+               }
+       }
 }
 
 #[cfg(test)]
@@ -1664,18 +1706,17 @@ mod tests {
                assert_eq!(onion_packet_5.data, hex_bytes("9c5add3963fc7f6ed7f148623c84134b5647e1306419dbe2174e523fa9e2fbed3a06a19f899145610741c83ad40b7712aefaddec8c6baf7325d92ea4ca4d1df8bce517f7e54554608bf2bd8071a4f52a7a2f7ffbb1413edad81eeea5785aa9d990f2865dc23b4bc3c301a94eec4eabebca66be5cf638f693ec256aec514620cc28ee4a94bd9565bc4d4962b9d3641d4278fb319ed2b84de5b665f307a2db0f7fbb757366067d88c50f7e829138fde4f78d39b5b5802f1b92a8a820865af5cc79f9f30bc3f461c66af95d13e5e1f0381c184572a91dee1c849048a647a1158cf884064deddbf1b0b88dfe2f791428d0ba0f6fb2f04e14081f69165ae66d9297c118f0907705c9c4954a199bae0bb96fad763d690e7daa6cfda59ba7f2c8d11448b604d12d").unwrap());
        }
 
-       static mut CHAN_COUNT: u16 = 0;
-       fn confirm_transaction(chain: &chaininterface::ChainWatchInterfaceUtil, tx: &Transaction) {
+       fn confirm_transaction(chain: &chaininterface::ChainWatchInterfaceUtil, tx: &Transaction, chan_id: u32) {
                let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
-               let chan_id = unsafe { CHAN_COUNT };
-               chain.block_connected_checked(&header, 1, &[tx; 1], &[chan_id as u32; 1]);
+               chain.block_connected_checked(&header, 1, &[tx; 1], &[chan_id; 1]);
                for i in 2..100 {
                        header = BlockHeader { version: 0x20000000, prev_blockhash: header.bitcoin_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
                        chain.block_connected_checked(&header, i, &[tx; 0], &[0; 0]);
                }
        }
 
-       fn create_chan_between_nodes(node_a: &ChannelManager, chain_a: &chaininterface::ChainWatchInterfaceUtil, node_b: &ChannelManager, chain_b: &chaininterface::ChainWatchInterfaceUtil) -> (msgs::ChannelAnnouncement, msgs::ChannelUpdate, msgs::ChannelUpdate, Uint256) {
+       static mut CHAN_COUNT: u32 = 0;
+       fn create_chan_between_nodes(node_a: &ChannelManager, chain_a: &chaininterface::ChainWatchInterfaceUtil, monitor_a: &test_utils::TestChannelMonitor, node_b: &ChannelManager, chain_b: &chaininterface::ChainWatchInterfaceUtil, monitor_b: &test_utils::TestChannelMonitor) -> (msgs::ChannelAnnouncement, msgs::ChannelUpdate, msgs::ChannelUpdate, Uint256, Transaction) {
                let open_chan = node_a.create_channel(node_b.get_our_node_id(), 100000, 42).unwrap();
                let accept_chan = node_b.handle_open_channel(&node_a.get_our_node_id(), &open_chan).unwrap();
                node_a.handle_accept_channel(&node_b.get_our_node_id(), &accept_chan).unwrap();
@@ -1697,7 +1738,10 @@ mod tests {
                                funding_output = (Sha256dHash::from_data(&serialize(&tx).unwrap()[..]), 0);
 
                                node_a.funding_transaction_generated(&temporary_channel_id, funding_output.clone());
-                               //TODO: Check that we got added to chan_monitor_a!
+                               let mut added_monitors = monitor_a.added_monitors.lock().unwrap();
+                               assert_eq!(added_monitors.len(), 1);
+                               assert_eq!(added_monitors[0].0, funding_output);
+                               added_monitors.clear();
                        },
                        _ => panic!("Unexpected event"),
                }
@@ -1707,8 +1751,12 @@ mod tests {
                let funding_signed = match events_2[0] {
                        Event::SendFundingCreated { ref node_id, ref msg } => {
                                assert_eq!(*node_id, node_b.get_our_node_id());
-                               node_b.handle_funding_created(&node_a.get_our_node_id(), msg).unwrap()
-                               //TODO: Check that we got added to chan_monitor_b!
+                               let res = node_b.handle_funding_created(&node_a.get_our_node_id(), msg).unwrap();
+                               let mut added_monitors = monitor_b.added_monitors.lock().unwrap();
+                               assert_eq!(added_monitors.len(), 1);
+                               assert_eq!(added_monitors[0].0, funding_output);
+                               added_monitors.clear();
+                               res
                        },
                        _ => panic!("Unexpected event"),
                };
@@ -1725,7 +1773,7 @@ mod tests {
                        _ => panic!("Unexpected event"),
                };
 
-               confirm_transaction(&chain_a, &tx);
+               confirm_transaction(&chain_a, &tx, chan_id);
                let events_4 = node_a.get_and_clear_pending_events();
                assert_eq!(events_4.len(), 1);
                match events_4[0] {
@@ -1739,7 +1787,7 @@ mod tests {
 
                let channel_id;
 
-               confirm_transaction(&chain_b, &tx);
+               confirm_transaction(&chain_b, &tx, chan_id);
                let events_5 = node_b.get_and_clear_pending_events();
                assert_eq!(events_5.len(), 1);
                let as_announcement_sigs = match events_5[0] {
@@ -1777,10 +1825,10 @@ mod tests {
                        CHAN_COUNT += 1;
                }
 
-               ((*announcement).clone(), (*as_update).clone(), (*bs_update).clone(), channel_id)
+               ((*announcement).clone(), (*as_update).clone(), (*bs_update).clone(), channel_id, tx)
        }
 
-       fn close_channel(outbound_node: &ChannelManager, outbound_broadcaster: &test_utils::TestBroadcaster, inbound_node: &ChannelManager, inbound_broadcaster: &test_utils::TestBroadcaster, channel_id: &Uint256, close_inbound_first: bool) {
+       fn close_channel(outbound_node: &ChannelManager, outbound_broadcaster: &test_utils::TestBroadcaster, inbound_node: &ChannelManager, inbound_broadcaster: &test_utils::TestBroadcaster, channel_id: &Uint256, funding_tx: Transaction, close_inbound_first: bool) {
                let (node_a, broadcaster_a) = if close_inbound_first { (inbound_node, inbound_broadcaster) } else { (outbound_node, outbound_broadcaster) };
                let (node_b, broadcaster_b) = if close_inbound_first { (outbound_node, outbound_broadcaster) } else { (inbound_node, inbound_broadcaster) };
                let (tx_a, tx_b);
@@ -1813,6 +1861,9 @@ mod tests {
                        tx_a = broadcaster_a.txn_broadcasted.lock().unwrap().remove(0);
                }
                assert_eq!(tx_a, tx_b);
+               let mut funding_tx_map = HashMap::new();
+               funding_tx_map.insert(funding_tx.txid(), funding_tx);
+               tx_a.verify(&funding_tx_map).unwrap();
        }
 
        struct SendEvent {
@@ -1832,7 +1883,7 @@ mod tests {
        }
 
        static mut PAYMENT_COUNT: u8 = 0;
-       fn send_along_route(origin_node: &ChannelManager, route: Route, expected_route: &[&ChannelManager], recv_value: u64) -> ([u8; 32], [u8; 32]) {
+       fn send_along_route(origin_node: &ChannelManager, origin_monitor: &test_utils::TestChannelMonitor, route: Route, expected_route: &[(&ChannelManager, &test_utils::TestChannelMonitor)], recv_value: u64) -> ([u8; 32], [u8; 32]) {
                let our_payment_preimage = unsafe { [PAYMENT_COUNT; 32] };
                unsafe { PAYMENT_COUNT += 1 };
                let our_payment_hash = {
@@ -1846,19 +1897,34 @@ mod tests {
                let mut payment_event = {
                        let msgs = origin_node.send_payment(route, our_payment_hash).unwrap().unwrap();
                        SendEvent {
-                               node_id: expected_route[0].get_our_node_id(),
+                               node_id: expected_route[0].0.get_our_node_id(),
                                msgs: vec!(msgs.0),
                                commitment_msg: msgs.1,
                        }
                };
-               let mut prev_node = origin_node;
+               let mut prev_node = (origin_node, origin_monitor);
 
-               for (idx, node) in expected_route.iter().enumerate() {
+               for (idx, &(node, monitor)) in expected_route.iter().enumerate() {
                        assert_eq!(node.get_our_node_id(), payment_event.node_id);
 
-                       node.handle_update_add_htlc(&prev_node.get_our_node_id(), &payment_event.msgs[0]).unwrap();
-                       let revoke_and_ack = node.handle_commitment_signed(&prev_node.get_our_node_id(), &payment_event.commitment_msg).unwrap();
-                       assert!(prev_node.handle_revoke_and_ack(&node.get_our_node_id(), &revoke_and_ack).unwrap().is_none());
+                       node.handle_update_add_htlc(&prev_node.0.get_our_node_id(), &payment_event.msgs[0]).unwrap();
+                       {
+                               let added_monitors = monitor.added_monitors.lock().unwrap();
+                               assert_eq!(added_monitors.len(), 0);
+                       }
+
+                       let revoke_and_ack = node.handle_commitment_signed(&prev_node.0.get_our_node_id(), &payment_event.commitment_msg).unwrap();
+                       {
+                               let mut added_monitors = monitor.added_monitors.lock().unwrap();
+                               assert_eq!(added_monitors.len(), 1);
+                               added_monitors.clear();
+                       }
+                       assert!(prev_node.0.handle_revoke_and_ack(&node.get_our_node_id(), &revoke_and_ack).unwrap().is_none());
+                       {
+                               let mut added_monitors = prev_node.1.added_monitors.lock().unwrap();
+                               assert_eq!(added_monitors.len(), 1);
+                               added_monitors.clear();
+                       }
 
                        let events_1 = node.get_and_clear_pending_events();
                        assert_eq!(events_1.len(), 1);
@@ -1887,23 +1953,33 @@ mod tests {
                                assert_eq!(payment_event.msgs.len(), 1);
                        }
 
-                       prev_node = node;
+                       prev_node = (node, monitor);
                }
 
                (our_payment_preimage, our_payment_hash)
        }
 
-       fn claim_payment(origin_node: &ChannelManager, expected_route: &[&ChannelManager], our_payment_preimage: [u8; 32]) {
-               assert!(expected_route.last().unwrap().claim_funds(our_payment_preimage));
+       fn claim_payment(origin_node: &ChannelManager, origin_monitor: &test_utils::TestChannelMonitor, expected_route: &[(&ChannelManager, &test_utils::TestChannelMonitor)], our_payment_preimage: [u8; 32]) {
+               assert!(expected_route.last().unwrap().0.claim_funds(our_payment_preimage));
+               {
+                       let mut added_monitors = expected_route.last().unwrap().1.added_monitors.lock().unwrap();
+                       assert_eq!(added_monitors.len(), 1);
+                       added_monitors.clear();
+               }
 
-               let mut expected_next_node = expected_route.last().unwrap().get_our_node_id();
-               let mut prev_node = expected_route.last().unwrap();
+               let mut expected_next_node = expected_route.last().unwrap().0.get_our_node_id();
+               let mut prev_node = expected_route.last().unwrap().0;
                let mut next_msg = None;
-               for node in expected_route.iter().rev() {
+               for &(node, monitor) in expected_route.iter().rev() {
                        assert_eq!(expected_next_node, node.get_our_node_id());
                        match next_msg {
                                Some(msg) => {
                                        node.handle_update_fulfill_htlc(&prev_node.get_our_node_id(), &msg).unwrap();
+                                       {
+                                               let mut added_monitors = monitor.added_monitors.lock().unwrap();
+                                               assert_eq!(added_monitors.len(), 1);
+                                               added_monitors.clear();
+                                       }
                                }, None => {}
                        }
 
@@ -1921,7 +1997,12 @@ mod tests {
                }
 
                assert_eq!(expected_next_node, origin_node.get_our_node_id());
-               origin_node.handle_update_fulfill_htlc(&expected_route.first().unwrap().get_our_node_id(), &next_msg.unwrap()).unwrap();
+               origin_node.handle_update_fulfill_htlc(&expected_route.first().unwrap().0.get_our_node_id(), &next_msg.unwrap()).unwrap();
+               {
+                       let mut added_monitors = origin_monitor.added_monitors.lock().unwrap();
+                       assert_eq!(added_monitors.len(), 1);
+                       added_monitors.clear();
+               }
 
                let events = origin_node.get_and_clear_pending_events();
                assert_eq!(events.len(), 1);
@@ -1933,14 +2014,14 @@ mod tests {
                }
        }
 
-       fn route_payment(origin_node: &ChannelManager, origin_router: &Router, expected_route: &[&ChannelManager], recv_value: u64) -> ([u8; 32], [u8; 32]) {
-               let route = origin_router.get_route(&expected_route.last().unwrap().get_our_node_id(), &Vec::new(), recv_value, 142).unwrap();
+       fn route_payment(origin_node: &ChannelManager, origin_monitor: &test_utils::TestChannelMonitor, origin_router: &Router, expected_route: &[(&ChannelManager, &test_utils::TestChannelMonitor)], recv_value: u64) -> ([u8; 32], [u8; 32]) {
+               let route = origin_router.get_route(&expected_route.last().unwrap().0.get_our_node_id(), &Vec::new(), recv_value, 142).unwrap();
                assert_eq!(route.hops.len(), expected_route.len());
-               for (node, hop) in expected_route.iter().zip(route.hops.iter()) {
+               for (&(node, _), hop) in expected_route.iter().zip(route.hops.iter()) {
                        assert_eq!(hop.pubkey, node.get_our_node_id());
                }
 
-               send_along_route(origin_node, route, expected_route, recv_value)
+               send_along_route(origin_node, origin_monitor, route, expected_route, recv_value)
        }
 
        fn route_over_limit(origin_node: &ChannelManager, origin_router: &Router, expected_route: &[&ChannelManager], recv_value: u64) {
@@ -1964,25 +2045,25 @@ mod tests {
                assert_eq!(err.err, "Cannot send value that would put us over our max HTLC value in flight");
        }
 
-       fn send_payment(origin_node: &ChannelManager, origin_router: &Router, expected_route: &[&ChannelManager], recv_value: u64) {
-               let our_payment_preimage = route_payment(origin_node, origin_router, expected_route, recv_value).0;
-               claim_payment(origin_node, expected_route, our_payment_preimage);
+       fn send_payment(origin_node: &ChannelManager, origin_monitor: &test_utils::TestChannelMonitor, origin_router: &Router, expected_route: &[(&ChannelManager, &test_utils::TestChannelMonitor)], recv_value: u64) {
+               let our_payment_preimage = route_payment(origin_node, origin_monitor, origin_router, expected_route, recv_value).0;
+               claim_payment(origin_node, origin_monitor, expected_route, our_payment_preimage);
        }
 
-       fn send_failed_payment(origin_node: &ChannelManager, origin_router: &Router, expected_route: &[&ChannelManager]) {
-               let route = origin_router.get_route(&expected_route.last().unwrap().get_our_node_id(), &Vec::new(), 1000000, 142).unwrap();
+       fn send_failed_payment(origin_node: &ChannelManager, origin_monitor: &test_utils::TestChannelMonitor, origin_router: &Router, expected_route: &[(&ChannelManager, &test_utils::TestChannelMonitor)]) {
+               let route = origin_router.get_route(&expected_route.last().unwrap().0.get_our_node_id(), &Vec::new(), 1000000, 142).unwrap();
                assert_eq!(route.hops.len(), expected_route.len());
-               for (node, hop) in expected_route.iter().zip(route.hops.iter()) {
+               for (&(node, _), hop) in expected_route.iter().zip(route.hops.iter()) {
                        assert_eq!(hop.pubkey, node.get_our_node_id());
                }
-               let our_payment_hash = send_along_route(origin_node, route, expected_route, 1000000).1;
+               let our_payment_hash = send_along_route(origin_node, origin_monitor, route, expected_route, 1000000).1;
 
-               assert!(expected_route.last().unwrap().fail_htlc_backwards(&our_payment_hash));
+               assert!(expected_route.last().unwrap().0.fail_htlc_backwards(&our_payment_hash));
 
-               let mut expected_next_node = expected_route.last().unwrap().get_our_node_id();
-               let mut prev_node = expected_route.last().unwrap();
+               let mut expected_next_node = expected_route.last().unwrap().0.get_our_node_id();
+               let mut prev_node = expected_route.last().unwrap().0;
                let mut next_msg = None;
-               for node in expected_route.iter().rev() {
+               for &(node, _) in expected_route.iter().rev() {
                        assert_eq!(expected_next_node, node.get_our_node_id());
                        match next_msg {
                                Some(msg) => {
@@ -2004,7 +2085,7 @@ mod tests {
                }
 
                assert_eq!(expected_next_node, origin_node.get_our_node_id());
-               origin_node.handle_update_fail_htlc(&expected_route.first().unwrap().get_our_node_id(), &next_msg.unwrap()).unwrap();
+               origin_node.handle_update_fail_htlc(&expected_route.first().unwrap().0.get_our_node_id(), &next_msg.unwrap()).unwrap();
 
                let events = origin_node.get_and_clear_pending_events();
                assert_eq!(events.len(), 1);
@@ -2025,8 +2106,8 @@ mod tests {
 
                let feeest_1 = Arc::new(test_utils::TestFeeEstimator { sat_per_vbyte: 1 });
                let chain_monitor_1 = Arc::new(chaininterface::ChainWatchInterfaceUtil::new());
-               let chan_monitor_1 = Arc::new(test_utils::TestChannelMonitor{});
                let tx_broadcaster_1 = Arc::new(test_utils::TestBroadcaster{txn_broadcasted: Mutex::new(Vec::new())});
+               let chan_monitor_1 = Arc::new(test_utils::TestChannelMonitor::new(chain_monitor_1.clone(), tx_broadcaster_1.clone()));
                let node_id_1 = {
                        let mut key_slice = [0; 32];
                        rng.fill_bytes(&mut key_slice);
@@ -2037,8 +2118,8 @@ mod tests {
 
                let feeest_2 = Arc::new(test_utils::TestFeeEstimator { sat_per_vbyte: 1 });
                let chain_monitor_2 = Arc::new(chaininterface::ChainWatchInterfaceUtil::new());
-               let chan_monitor_2 = Arc::new(test_utils::TestChannelMonitor{});
                let tx_broadcaster_2 = Arc::new(test_utils::TestBroadcaster{txn_broadcasted: Mutex::new(Vec::new())});
+               let chan_monitor_2 = Arc::new(test_utils::TestChannelMonitor::new(chain_monitor_2.clone(), tx_broadcaster_2.clone()));
                let node_id_2 = {
                        let mut key_slice = [0; 32];
                        rng.fill_bytes(&mut key_slice);
@@ -2049,8 +2130,8 @@ mod tests {
 
                let feeest_3 = Arc::new(test_utils::TestFeeEstimator { sat_per_vbyte: 1 });
                let chain_monitor_3 = Arc::new(chaininterface::ChainWatchInterfaceUtil::new());
-               let chan_monitor_3 = Arc::new(test_utils::TestChannelMonitor{});
                let tx_broadcaster_3 = Arc::new(test_utils::TestBroadcaster{txn_broadcasted: Mutex::new(Vec::new())});
+               let chan_monitor_3 = Arc::new(test_utils::TestChannelMonitor::new(chain_monitor_3.clone(), tx_broadcaster_3.clone()));
                let node_id_3 = {
                        let mut key_slice = [0; 32];
                        rng.fill_bytes(&mut key_slice);
@@ -2061,8 +2142,8 @@ mod tests {
 
                let feeest_4 = Arc::new(test_utils::TestFeeEstimator { sat_per_vbyte: 1 });
                let chain_monitor_4 = Arc::new(chaininterface::ChainWatchInterfaceUtil::new());
-               let chan_monitor_4 = Arc::new(test_utils::TestChannelMonitor{});
                let tx_broadcaster_4 = Arc::new(test_utils::TestBroadcaster{txn_broadcasted: Mutex::new(Vec::new())});
+               let chan_monitor_4 = Arc::new(test_utils::TestChannelMonitor::new(chain_monitor_4.clone(), tx_broadcaster_4.clone()));
                let node_id_4 = {
                        let mut key_slice = [0; 32];
                        rng.fill_bytes(&mut key_slice);
@@ -2072,19 +2153,19 @@ mod tests {
                let router_4 = Router::new(PublicKey::from_secret_key(&secp_ctx, &node_id_4).unwrap());
 
                // Create some initial channels
-               let chan_announcement_1 = create_chan_between_nodes(&node_1, &chain_monitor_1, &node_2, &chain_monitor_2);
+               let chan_announcement_1 = create_chan_between_nodes(&node_1, &chain_monitor_1, &chan_monitor_1, &node_2, &chain_monitor_2, &chan_monitor_2);
                for router in vec!(&router_1, &router_2, &router_3, &router_4) {
                        assert!(router.handle_channel_announcement(&chan_announcement_1.0).unwrap());
                        router.handle_channel_update(&chan_announcement_1.1).unwrap();
                        router.handle_channel_update(&chan_announcement_1.2).unwrap();
                }
-               let chan_announcement_2 = create_chan_between_nodes(&node_2, &chain_monitor_2, &node_3, &chain_monitor_3);
+               let chan_announcement_2 = create_chan_between_nodes(&node_2, &chain_monitor_2, &chan_monitor_2, &node_3, &chain_monitor_3, &chan_monitor_3);
                for router in vec!(&router_1, &router_2, &router_3, &router_4) {
                        assert!(router.handle_channel_announcement(&chan_announcement_2.0).unwrap());
                        router.handle_channel_update(&chan_announcement_2.1).unwrap();
                        router.handle_channel_update(&chan_announcement_2.2).unwrap();
                }
-               let chan_announcement_3 = create_chan_between_nodes(&node_3, &chain_monitor_3, &node_4, &chain_monitor_4);
+               let chan_announcement_3 = create_chan_between_nodes(&node_3, &chain_monitor_3, &chan_monitor_3, &node_4, &chain_monitor_4, &chan_monitor_4);
                for router in vec!(&router_1, &router_2, &router_3, &router_4) {
                        assert!(router.handle_channel_announcement(&chan_announcement_3.0).unwrap());
                        router.handle_channel_update(&chan_announcement_3.1).unwrap();
@@ -2092,35 +2173,35 @@ mod tests {
                }
 
                // Rebalance the network a bit by relaying one payment through all the channels...
-               send_payment(&node_1, &router_1, &vec!(&*node_2, &*node_3, &*node_4)[..], 8000000);
-               send_payment(&node_1, &router_1, &vec!(&*node_2, &*node_3, &*node_4)[..], 8000000);
-               send_payment(&node_1, &router_1, &vec!(&*node_2, &*node_3, &*node_4)[..], 8000000);
-               send_payment(&node_1, &router_1, &vec!(&*node_2, &*node_3, &*node_4)[..], 8000000);
-               send_payment(&node_1, &router_1, &vec!(&*node_2, &*node_3, &*node_4)[..], 8000000);
+               send_payment(&node_1, &chan_monitor_1, &router_1, &vec!((&*node_2, &*chan_monitor_2), (&*node_3, &*chan_monitor_3), (&*node_4, &*chan_monitor_4))[..], 8000000);
+               send_payment(&node_1, &chan_monitor_1, &router_1, &vec!((&*node_2, &*chan_monitor_2), (&*node_3, &*chan_monitor_3), (&*node_4, &*chan_monitor_4))[..], 8000000);
+               send_payment(&node_1, &chan_monitor_1, &router_1, &vec!((&*node_2, &*chan_monitor_2), (&*node_3, &*chan_monitor_3), (&*node_4, &*chan_monitor_4))[..], 8000000);
+               send_payment(&node_1, &chan_monitor_1, &router_1, &vec!((&*node_2, &*chan_monitor_2), (&*node_3, &*chan_monitor_3), (&*node_4, &*chan_monitor_4))[..], 8000000);
+               send_payment(&node_1, &chan_monitor_1, &router_1, &vec!((&*node_2, &*chan_monitor_2), (&*node_3, &*chan_monitor_3), (&*node_4, &*chan_monitor_4))[..], 8000000);
 
                // Send some more payments
-               send_payment(&node_2, &router_2, &vec!(&*node_3, &*node_4)[..], 1000000);
-               send_payment(&node_4, &router_4, &vec!(&*node_3, &*node_2, &*node_1)[..], 1000000);
-               send_payment(&node_4, &router_4, &vec!(&*node_3, &*node_2)[..], 1000000);
+               send_payment(&node_2, &chan_monitor_2, &router_2, &vec!((&*node_3, &*chan_monitor_3), (&*node_4, &*chan_monitor_4))[..], 1000000);
+               send_payment(&node_4, &chan_monitor_4, &router_4, &vec!((&*node_3, &*chan_monitor_3), (&*node_2, &*chan_monitor_2), (&*node_1, &*chan_monitor_1))[..], 1000000);
+               send_payment(&node_4, &chan_monitor_4, &router_4, &vec!((&*node_3, &*chan_monitor_3), (&*node_2, &*chan_monitor_2))[..], 1000000);
 
                // Test failure packets
-               send_failed_payment(&node_1, &router_1, &vec!(&*node_2, &*node_3, &*node_4)[..]);
+               send_failed_payment(&node_1, &chan_monitor_1, &router_1, &vec!((&*node_2, &*chan_monitor_2), (&*node_3, &*chan_monitor_3), (&*node_4, &*chan_monitor_4))[..]);
 
                // Add a new channel that skips 3
-               let chan_announcement_4 = create_chan_between_nodes(&node_2, &chain_monitor_2, &node_4, &chain_monitor_4);
+               let chan_announcement_4 = create_chan_between_nodes(&node_2, &chain_monitor_2, &chan_monitor_2, &node_4, &chain_monitor_4, &chan_monitor_4);
                for router in vec!(&router_1, &router_2, &router_3, &router_4) {
                        assert!(router.handle_channel_announcement(&chan_announcement_4.0).unwrap());
                        router.handle_channel_update(&chan_announcement_4.1).unwrap();
                        router.handle_channel_update(&chan_announcement_4.2).unwrap();
                }
 
-               send_payment(&node_1, &router_1, &vec!(&*node_2, &*node_4)[..], 1000000);
-               send_payment(&node_3, &router_3, &vec!(&*node_4)[..], 1000000);
-               send_payment(&node_2, &router_2, &vec!(&*node_4)[..], 8000000);
-               send_payment(&node_2, &router_2, &vec!(&*node_4)[..], 8000000);
-               send_payment(&node_2, &router_2, &vec!(&*node_4)[..], 8000000);
-               send_payment(&node_2, &router_2, &vec!(&*node_4)[..], 8000000);
-               send_payment(&node_2, &router_2, &vec!(&*node_4)[..], 8000000);
+               send_payment(&node_1, &chan_monitor_1, &router_1, &vec!((&*node_2, &*chan_monitor_2), (&*node_4, &*chan_monitor_4))[..], 1000000);
+               send_payment(&node_3, &chan_monitor_3, &router_3, &vec!((&*node_4, &*chan_monitor_4))[..], 1000000);
+               send_payment(&node_2, &chan_monitor_2, &router_2, &vec!((&*node_4, &*chan_monitor_4))[..], 8000000);
+               send_payment(&node_2, &chan_monitor_2, &router_2, &vec!((&*node_4, &*chan_monitor_4))[..], 8000000);
+               send_payment(&node_2, &chan_monitor_2, &router_2, &vec!((&*node_4, &*chan_monitor_4))[..], 8000000);
+               send_payment(&node_2, &chan_monitor_2, &router_2, &vec!((&*node_4, &*chan_monitor_4))[..], 8000000);
+               send_payment(&node_2, &chan_monitor_2, &router_2, &vec!((&*node_4, &*chan_monitor_4))[..], 8000000);
 
                // Do some rebalance loop payments, simultaneously
                let mut hops = Vec::with_capacity(3);
@@ -2144,7 +2225,7 @@ mod tests {
                });
                hops[1].fee_msat = chan_announcement_4.2.contents.fee_base_msat as u64 + chan_announcement_4.2.contents.fee_proportional_millionths as u64 * hops[2].fee_msat as u64 / 1000000;
                hops[0].fee_msat = chan_announcement_3.1.contents.fee_base_msat as u64 + chan_announcement_3.1.contents.fee_proportional_millionths as u64 * hops[1].fee_msat as u64 / 1000000;
-               let payment_preimage_1 = send_along_route(&node_2, Route { hops }, &vec!(&*node_3, &*node_4, &*node_2)[..], 1000000).0;
+               let payment_preimage_1 = send_along_route(&node_2, &chan_monitor_2, Route { hops }, &vec!((&*node_3, &*chan_monitor_3), (&*node_4, &*chan_monitor_4), (&*node_2, &*chan_monitor_2))[..], 1000000).0;
 
                let mut hops = Vec::with_capacity(3);
                hops.push(RouteHop {
@@ -2167,14 +2248,14 @@ mod tests {
                });
                hops[1].fee_msat = chan_announcement_2.2.contents.fee_base_msat as u64 + chan_announcement_2.2.contents.fee_proportional_millionths as u64 * hops[2].fee_msat as u64 / 1000000;
                hops[0].fee_msat = chan_announcement_3.2.contents.fee_base_msat as u64 + chan_announcement_3.2.contents.fee_proportional_millionths as u64 * hops[1].fee_msat as u64 / 1000000;
-               let payment_preimage_2 = send_along_route(&node_2, Route { hops }, &vec!(&*node_4, &*node_3, &*node_2)[..], 1000000).0;
+               let payment_preimage_2 = send_along_route(&node_2, &chan_monitor_2, Route { hops }, &vec!((&*node_4, &*chan_monitor_4), (&*node_3, &*chan_monitor_3), (&*node_2, &*chan_monitor_2))[..], 1000000).0;
 
                // Claim the rebalances...
-               claim_payment(&node_2, &vec!(&*node_4, &*node_3, &*node_2)[..], payment_preimage_2);
-               claim_payment(&node_2, &vec!(&*node_3, &*node_4, &*node_2)[..], payment_preimage_1);
+               claim_payment(&node_2, &chan_monitor_2, &vec!((&*node_4, &*chan_monitor_4), (&*node_3, &*chan_monitor_3), (&*node_2, &*chan_monitor_2))[..], payment_preimage_2);
+               claim_payment(&node_2, &chan_monitor_2, &vec!((&*node_3, &*chan_monitor_3), (&*node_4, &*chan_monitor_4), (&*node_2, &*chan_monitor_2))[..], payment_preimage_1);
 
                // Add a duplicate new channel from 2 to 4
-               let chan_announcement_5 = create_chan_between_nodes(&node_2, &chain_monitor_2, &node_4, &chain_monitor_4);
+               let chan_announcement_5 = create_chan_between_nodes(&node_2, &chain_monitor_2, &chan_monitor_2, &node_4, &chain_monitor_4, &chan_monitor_4);
                for router in vec!(&router_1, &router_2, &router_3, &router_4) {
                        assert!(router.handle_channel_announcement(&chan_announcement_5.0).unwrap());
                        router.handle_channel_update(&chan_announcement_5.1).unwrap();
@@ -2182,27 +2263,30 @@ mod tests {
                }
 
                // Send some payments across both channels
-               let payment_preimage_3 = route_payment(&node_1, &router_1, &vec!(&*node_2, &*node_4)[..], 3000000).0;
-               let payment_preimage_4 = route_payment(&node_1, &router_1, &vec!(&*node_2, &*node_4)[..], 3000000).0;
-               let payment_preimage_5 = route_payment(&node_1, &router_1, &vec!(&*node_2, &*node_4)[..], 3000000).0;
+               let payment_preimage_3 = route_payment(&node_1, &chan_monitor_1, &router_1, &vec!((&*node_2, &*chan_monitor_2), (&*node_4, &*chan_monitor_4))[..], 3000000).0;
+               let payment_preimage_4 = route_payment(&node_1, &chan_monitor_1, &router_1, &vec!((&*node_2, &*chan_monitor_2), (&*node_4, &*chan_monitor_4))[..], 3000000).0;
+               let payment_preimage_5 = route_payment(&node_1, &chan_monitor_1, &router_1, &vec!((&*node_2, &*chan_monitor_2), (&*node_4, &*chan_monitor_4))[..], 3000000).0;
 
                route_over_limit(&node_1, &router_1, &vec!(&*node_2, &*node_4)[..], 3000000);
 
                //TODO: Test that routes work again here as we've been notified that the channel is full
 
-               claim_payment(&node_1, &vec!(&*node_2, &*node_4)[..], payment_preimage_3);
-               claim_payment(&node_1, &vec!(&*node_2, &*node_4)[..], payment_preimage_4);
-               claim_payment(&node_1, &vec!(&*node_2, &*node_4)[..], payment_preimage_5);
+               claim_payment(&node_1, &chan_monitor_1, &vec!((&*node_2, &*chan_monitor_2), (&*node_4, &*chan_monitor_4))[..], payment_preimage_3);
+               claim_payment(&node_1, &chan_monitor_1, &vec!((&*node_2, &*chan_monitor_2), (&*node_4, &*chan_monitor_4))[..], payment_preimage_4);
+               claim_payment(&node_1, &chan_monitor_1, &vec!((&*node_2, &*chan_monitor_2), (&*node_4, &*chan_monitor_4))[..], payment_preimage_5);
 
                // Close down the channels...
-               close_channel(&node_1, &tx_broadcaster_1, &node_2, &tx_broadcaster_2, &chan_announcement_1.3, true);
-               close_channel(&node_2, &tx_broadcaster_2, &node_3, &tx_broadcaster_3, &chan_announcement_2.3, false);
-               close_channel(&node_3, &tx_broadcaster_3, &node_4, &tx_broadcaster_4, &chan_announcement_3.3, true);
-               close_channel(&node_2, &tx_broadcaster_2, &node_4, &tx_broadcaster_4, &chan_announcement_4.3, false);
+               close_channel(&node_1, &tx_broadcaster_1, &node_2, &tx_broadcaster_2, &chan_announcement_1.3, chan_announcement_1.4, true);
+               close_channel(&node_2, &tx_broadcaster_2, &node_3, &tx_broadcaster_3, &chan_announcement_2.3, chan_announcement_2.4, false);
+               close_channel(&node_3, &tx_broadcaster_3, &node_4, &tx_broadcaster_4, &chan_announcement_3.3, chan_announcement_3.4, true);
+               close_channel(&node_2, &tx_broadcaster_2, &node_4, &tx_broadcaster_4, &chan_announcement_4.3, chan_announcement_4.4, false);
 
                // Check that we processed all pending events
                for node in vec!(&node_1, &node_2, &node_3, &node_4) {
                        assert_eq!(node.get_and_clear_pending_events().len(), 0);
                }
+               for chan_monitor in vec!(&chan_monitor_1, &chan_monitor_2, &chan_monitor_3, &chan_monitor_4) {
+                       assert_eq!(chan_monitor.added_monitors.lock().unwrap().len(), 0);
+               }
        }
 }