Merge pull request #259 from TheBlueMatt/2018-11-256-redux
[rust-lightning] / src / ln / channelmanager.rs
index 20a3779899a620b185723bdf78d7513017321ee4..6933198c608e0e56f59ffe510d2b2b6583fb3dde 100644 (file)
@@ -404,6 +404,38 @@ pub struct ChannelDetails {
        pub user_id: u64,
 }
 
+macro_rules! handle_error {
+       ($self: ident, $internal: expr, $their_node_id: expr) => {
+               match $internal {
+                       Ok(msg) => Ok(msg),
+                       Err(MsgHandleErrInternal { err, needs_channel_force_close }) => {
+                               if needs_channel_force_close {
+                                       match &err.action {
+                                               &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => {
+                                                       if msg.channel_id == [0; 32] {
+                                                               $self.peer_disconnected(&$their_node_id, true);
+                                                       } else {
+                                                               $self.force_close_channel(&msg.channel_id);
+                                                       }
+                                               },
+                                               &Some(msgs::ErrorAction::DisconnectPeer { msg: None }) => {},
+                                               &Some(msgs::ErrorAction::IgnoreError) => {},
+                                               &Some(msgs::ErrorAction::SendErrorMessage { ref msg }) => {
+                                                       if msg.channel_id == [0; 32] {
+                                                               $self.peer_disconnected(&$their_node_id, true);
+                                                       } else {
+                                                               $self.force_close_channel(&msg.channel_id);
+                                                       }
+                                               },
+                                               &None => {},
+                                       }
+                               }
+                               Err(err)
+                       },
+               }
+       }
+}
+
 impl ChannelManager {
        /// Constructs a new ChannelManager to hold several channels and route between them.
        ///
@@ -1203,7 +1235,17 @@ impl ChannelManager {
                                route: route.clone(),
                                session_priv: session_priv.clone(),
                                first_hop_htlc_msat: htlc_msat,
-                       }, onion_packet).map_err(|he| APIError::ChannelUnavailable{err: he.err})?
+                       }, onion_packet).map_err(|he|
+                               match he {
+                                       ChannelError::Close(err) => {
+                                               // TODO: We need to close the channel here, but for that to be safe we have
+                                               // to do all channel closure inside the channel_state lock which is a
+                                               // somewhat-larger refactor, so we leave that for later.
+                                               APIError::ChannelUnavailable { err }
+                                       },
+                                       ChannelError::Ignore(err) => APIError::ChannelUnavailable { err },
+                               }
+                       )?
                };
                match res {
                        Some((update_add, commitment_signed, chan_monitor)) => {
@@ -1243,24 +1285,30 @@ impl ChannelManager {
                let _ = self.total_consistency_lock.read().unwrap();
 
                let (chan, msg, chan_monitor) = {
-                       let mut channel_state = self.channel_state.lock().unwrap();
-                       match channel_state.by_id.remove(temporary_channel_id) {
-                               Some(mut chan) => {
-                                       match chan.get_outbound_funding_created(funding_txo) {
-                                               Ok(funding_msg) => {
-                                                       (chan, funding_msg.0, funding_msg.1)
-                                               },
-                                               Err(e) => {
-                                                       log_error!(self, "Got bad signatures: {}!", e.err);
-                                                       channel_state.pending_msg_events.push(events::MessageSendEvent::HandleError {
-                                                               node_id: chan.get_their_node_id(),
-                                                               action: e.action,
-                                                       });
-                                                       return;
-                                               },
-                                       }
+                       let (res, chan) = {
+                               let mut channel_state = self.channel_state.lock().unwrap();
+                               match channel_state.by_id.remove(temporary_channel_id) {
+                                       Some(mut chan) => {
+                                               (chan.get_outbound_funding_created(funding_txo)
+                                                       .map_err(|e| MsgHandleErrInternal::from_chan_maybe_close(e, chan.channel_id()))
+                                               , chan)
+                                       },
+                                       None => return
+                               }
+                       };
+                       match handle_error!(self, res, chan.get_their_node_id()) {
+                               Ok(funding_msg) => {
+                                       (chan, funding_msg.0, funding_msg.1)
+                               },
+                               Err(e) => {
+                                       log_error!(self, "Got bad signatures: {}!", e.err);
+                                       let mut channel_state = self.channel_state.lock().unwrap();
+                                       channel_state.pending_msg_events.push(events::MessageSendEvent::HandleError {
+                                               node_id: chan.get_their_node_id(),
+                                               action: e.action,
+                                       });
+                                       return;
                                },
-                               None => return
                        }
                };
                // Because we have exclusive ownership of the channel here we can release the channel_state
@@ -1372,9 +1420,7 @@ impl ChannelManager {
                                                let (commitment_msg, monitor) = match forward_chan.send_commitment() {
                                                        Ok(res) => res,
                                                        Err(e) => {
-                                                               if let &Some(msgs::ErrorAction::DisconnectPeer{msg: Some(ref _err_msg)}) = &e.action {
-                                                               } else if let &Some(msgs::ErrorAction::SendErrorMessage{msg: ref _err_msg}) = &e.action {
-                                                               } else {
+                                                               if let ChannelError::Ignore(_) = e {
                                                                        panic!("Stated return value requirements in send_commitment() were not met");
                                                                }
                                                                //TODO: Handle...this is bad!
@@ -1745,7 +1791,7 @@ impl ChannelManager {
                                                        (chan.remove(), funding_msg, monitor_update)
                                                },
                                                Err(e) => {
-                                                       return Err(e).map_err(|e| MsgHandleErrInternal::from_maybe_close(e))
+                                                       return Err(e).map_err(|e| MsgHandleErrInternal::from_chan_maybe_close(e, msg.temporary_channel_id))
                                                }
                                        }
                                },
@@ -1783,7 +1829,7 @@ impl ChannelManager {
                                                //TODO: here and below MsgHandleErrInternal, #153 case
                                                return Err(MsgHandleErrInternal::send_err_msg_no_close("Got a message for a channel from the wrong node!", msg.channel_id));
                                        }
-                                       let chan_monitor = chan.funding_signed(&msg).map_err(|e| MsgHandleErrInternal::from_maybe_close(e))?;
+                                       let chan_monitor = chan.funding_signed(&msg).map_err(|e| MsgHandleErrInternal::from_chan_maybe_close(e, msg.channel_id))?;
                                        if let Err(_e) = self.monitor.add_update_monitor(chan_monitor.get_funding_txo().unwrap(), chan_monitor) {
                                                unimplemented!();
                                        }
@@ -1942,10 +1988,20 @@ impl ChannelManager {
                                        // but if we've sent a shutdown and they haven't acknowledged it yet, we just
                                        // want to reject the new HTLC and fail it backwards instead of forwarding.
                                        if let PendingHTLCStatus::Forward(PendingForwardHTLCInfo { incoming_shared_secret, .. }) = pending_forward_info {
+                                               let chan_update = self.get_channel_update(chan);
                                                pending_forward_info = PendingHTLCStatus::Fail(HTLCFailureMsg::Relay(msgs::UpdateFailHTLC {
                                                        channel_id: msg.channel_id,
                                                        htlc_id: msg.htlc_id,
-                                                       reason: ChannelManager::build_first_hop_failure_packet(&incoming_shared_secret, 0x1000|20, &self.get_channel_update(chan).unwrap().encode_with_len()[..]),
+                                                       reason: if let Ok(update) = chan_update {
+                                                               ChannelManager::build_first_hop_failure_packet(&incoming_shared_secret, 0x1000|20, &update.encode_with_len()[..])
+                                                       } else {
+                                                               // This can only happen if the channel isn't in the fully-funded
+                                                               // state yet, implying our counterparty is trying to route payments
+                                                               // over the channel back to themselves (cause no one else should
+                                                               // know the short_id is a lightning channel yet). We should have no
+                                                               // problem just calling this unknown_next_peer
+                                                               ChannelManager::build_first_hop_failure_packet(&incoming_shared_secret, 0x4000|10, &[])
+                                                       },
                                                }));
                                        }
                                }
@@ -2213,7 +2269,8 @@ impl ChannelManager {
                                        //TODO: here and below MsgHandleErrInternal, #153 case
                                        return Err(MsgHandleErrInternal::send_err_msg_no_close("Got a message for a channel from the wrong node!", msg.channel_id));
                                }
-                               let (revoke_and_ack, commitment_signed, closing_signed, chan_monitor) = chan.commitment_signed(&msg, &*self.fee_estimator).map_err(|e| MsgHandleErrInternal::from_maybe_close(e))?;
+                               let (revoke_and_ack, commitment_signed, closing_signed, chan_monitor) = chan.commitment_signed(&msg, &*self.fee_estimator)
+                                       .map_err(|e| MsgHandleErrInternal::from_chan_maybe_close(e, msg.channel_id))?;
                                if let Err(_e) = self.monitor.add_update_monitor(chan_monitor.get_funding_txo().unwrap(), chan_monitor) {
                                        unimplemented!();
                                }
@@ -2289,7 +2346,8 @@ impl ChannelManager {
                                                //TODO: here and below MsgHandleErrInternal, #153 case
                                                return Err(MsgHandleErrInternal::send_err_msg_no_close("Got a message for a channel from the wrong node!", msg.channel_id));
                                        }
-                                       let (commitment_update, pending_forwards, pending_failures, closing_signed, chan_monitor) = chan.revoke_and_ack(&msg, &*self.fee_estimator).map_err(|e| MsgHandleErrInternal::from_maybe_close(e))?;
+                                       let (commitment_update, pending_forwards, pending_failures, closing_signed, chan_monitor) = chan.revoke_and_ack(&msg, &*self.fee_estimator)
+                                                       .map_err(|e| MsgHandleErrInternal::from_chan_maybe_close(e, msg.channel_id))?;
                                        if let Err(_e) = self.monitor.add_update_monitor(chan_monitor.get_funding_txo().unwrap(), chan_monitor) {
                                                unimplemented!();
                                        }
@@ -2455,7 +2513,16 @@ impl ChannelManager {
                                if !chan.is_live() {
                                        return Err(APIError::ChannelUnavailable{err: "Channel is either not yet fully established or peer is currently disconnected"});
                                }
-                               if let Some((update_fee, commitment_signed, chan_monitor)) = chan.send_update_fee_and_commit(feerate_per_kw).map_err(|e| APIError::APIMisuseError{err: e.err})? {
+                               if let Some((update_fee, commitment_signed, chan_monitor)) = chan.send_update_fee_and_commit(feerate_per_kw)
+                                               .map_err(|e| match e {
+                                                       ChannelError::Ignore(err) => APIError::APIMisuseError{err},
+                                                       ChannelError::Close(err) => {
+                                                               // TODO: We need to close the channel here, but for that to be safe we have
+                                                               // to do all channel closure inside the channel_state lock which is a
+                                                               // somewhat-larger refactor, so we leave that for later.
+                                                               APIError::APIMisuseError{err}
+                                                       },
+                                               })? {
                                        if let Err(_e) = self.monitor.add_update_monitor(chan_monitor.get_funding_txo().unwrap(), chan_monitor) {
                                                unimplemented!();
                                        }
@@ -2608,38 +2675,6 @@ impl ChainListener for ChannelManager {
        }
 }
 
-macro_rules! handle_error {
-       ($self: ident, $internal: expr, $their_node_id: expr) => {
-               match $internal {
-                       Ok(msg) => Ok(msg),
-                       Err(MsgHandleErrInternal { err, needs_channel_force_close }) => {
-                               if needs_channel_force_close {
-                                       match &err.action {
-                                               &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => {
-                                                       if msg.channel_id == [0; 32] {
-                                                               $self.peer_disconnected(&$their_node_id, true);
-                                                       } else {
-                                                               $self.force_close_channel(&msg.channel_id);
-                                                       }
-                                               },
-                                               &Some(msgs::ErrorAction::DisconnectPeer { msg: None }) => {},
-                                               &Some(msgs::ErrorAction::IgnoreError) => {},
-                                               &Some(msgs::ErrorAction::SendErrorMessage { ref msg }) => {
-                                                       if msg.channel_id == [0; 32] {
-                                                               $self.peer_disconnected(&$their_node_id, true);
-                                                       } else {
-                                                               $self.force_close_channel(&msg.channel_id);
-                                                       }
-                                               },
-                                               &None => {},
-                                       }
-                               }
-                               Err(err)
-                       },
-               }
-       }
-}
-
 impl ChannelMessageHandler for ChannelManager {
        //TODO: Handle errors and close channel (or so)
        fn handle_open_channel(&self, their_node_id: &PublicKey, msg: &msgs::OpenChannel) -> Result<(), HandleError> {
@@ -4446,7 +4481,7 @@ mod tests {
 
        #[test]
        fn test_update_fee_that_funder_cannot_afford() {
-               let mut nodes = create_network(2);
+               let nodes = create_network(2);
                let channel_value = 1888;
                let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, channel_value, 700000);
                let channel_id = chan.2;
@@ -4481,7 +4516,7 @@ mod tests {
 
                let update2_msg = get_htlc_update_msgs!(nodes[0], nodes[1].node.get_our_node_id());
 
-               nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update2_msg.update_fee.unwrap());
+               nodes[1].node.handle_update_fee(&nodes[0].node.get_our_node_id(), &update2_msg.update_fee.unwrap()).unwrap();
 
                //While producing the commitment_signed response after handling a received update_fee request the
                //check to see if the funder, who sent the update_fee request, can afford the new fee (funder_balance >= fee+channel_reserve)
@@ -7563,8 +7598,8 @@ mod tests {
                } else { panic!("Unexpected result"); }
        }
 
-       macro_rules! check_dynamic_output_p2wsh {
-               ($node: expr) => {
+       macro_rules! check_spendable_outputs {
+               ($node: expr, $der_idx: expr) => {
                        {
                                let events = $node.chan_monitor.simple_monitor.get_and_clear_pending_events();
                                let mut txn = Vec::new();
@@ -7573,6 +7608,33 @@ mod tests {
                                                Event::SpendableOutputs { ref outputs } => {
                                                        for outp in outputs {
                                                                match *outp {
+                                                                       SpendableOutputDescriptor::DynamicOutputP2WPKH { ref outpoint, ref key, ref output } => {
+                                                                               let input = TxIn {
+                                                                                       previous_output: outpoint.clone(),
+                                                                                       script_sig: Script::new(),
+                                                                                       sequence: 0,
+                                                                                       witness: Vec::new(),
+                                                                               };
+                                                                               let outp = TxOut {
+                                                                                       script_pubkey: Builder::new().push_opcode(opcodes::All::OP_RETURN).into_script(),
+                                                                                       value: output.value,
+                                                                               };
+                                                                               let mut spend_tx = Transaction {
+                                                                                       version: 2,
+                                                                                       lock_time: 0,
+                                                                                       input: vec![input],
+                                                                                       output: vec![outp],
+                                                                               };
+                                                                               let secp_ctx = Secp256k1::new();
+                                                                               let remotepubkey = PublicKey::from_secret_key(&secp_ctx, &key);
+                                                                               let witness_script = Address::p2pkh(&remotepubkey, Network::Testnet).script_pubkey();
+                                                                               let sighash = Message::from_slice(&bip143::SighashComponents::new(&spend_tx).sighash_all(&spend_tx.input[0], &witness_script, output.value)[..]).unwrap();
+                                                                               let remotesig = secp_ctx.sign(&sighash, key);
+                                                                               spend_tx.input[0].witness.push(remotesig.serialize_der(&secp_ctx).to_vec());
+                                                                               spend_tx.input[0].witness[0].push(SigHashType::All as u8);
+                                                                               spend_tx.input[0].witness.push(remotepubkey.serialize().to_vec());
+                                                                               txn.push(spend_tx);
+                                                                       },
                                                                        SpendableOutputDescriptor::DynamicOutputP2WSH { ref outpoint, ref key, ref witness_script, ref to_self_delay, ref output } => {
                                                                                let input = TxIn {
                                                                                        previous_output: outpoint.clone(),
@@ -7599,29 +7661,8 @@ mod tests {
                                                                                spend_tx.input[0].witness.push(witness_script.clone().into_bytes());
                                                                                txn.push(spend_tx);
                                                                        },
-                                                                       _ => panic!("Unexpected event"),
-                                                               }
-                                                       }
-                                               },
-                                               _ => panic!("Unexpected event"),
-                                       };
-                               }
-                               txn
-                       }
-               }
-       }
-
-       macro_rules! check_dynamic_output_p2wpkh {
-               ($node: expr) => {
-                       {
-                               let events = $node.chan_monitor.simple_monitor.get_and_clear_pending_events();
-                               let mut txn = Vec::new();
-                               for event in events {
-                                       match event {
-                                               Event::SpendableOutputs { ref outputs } => {
-                                                       for outp in outputs {
-                                                               match *outp {
-                                                                       SpendableOutputDescriptor::DynamicOutputP2WPKH { ref outpoint, ref key, ref output } => {
+                                                                       SpendableOutputDescriptor::StaticOutput { ref outpoint, ref output } => {
+                                                                               let secp_ctx = Secp256k1::new();
                                                                                let input = TxIn {
                                                                                        previous_output: outpoint.clone(),
                                                                                        script_sig: Script::new(),
@@ -7636,19 +7677,28 @@ mod tests {
                                                                                        version: 2,
                                                                                        lock_time: 0,
                                                                                        input: vec![input],
-                                                                                       output: vec![outp],
+                                                                                       output: vec![outp.clone()],
                                                                                };
-                                                                               let secp_ctx = Secp256k1::new();
-                                                                               let remotepubkey = PublicKey::from_secret_key(&secp_ctx, &key);
-                                                                               let witness_script = Address::p2pkh(&remotepubkey, Network::Testnet).script_pubkey();
+                                                                               let secret = {
+                                                                                       match ExtendedPrivKey::new_master(&secp_ctx, Network::Testnet, &$node.node_seed) {
+                                                                                               Ok(master_key) => {
+                                                                                                       match master_key.ckd_priv(&secp_ctx, ChildNumber::from_hardened_idx($der_idx)) {
+                                                                                                               Ok(key) => key,
+                                                                                                               Err(_) => panic!("Your RNG is busted"),
+                                                                                                       }
+                                                                                               }
+                                                                                               Err(_) => panic!("Your rng is busted"),
+                                                                                       }
+                                                                               };
+                                                                               let pubkey = ExtendedPubKey::from_private(&secp_ctx, &secret).public_key;
+                                                                               let witness_script = Address::p2pkh(&pubkey, Network::Testnet).script_pubkey();
                                                                                let sighash = Message::from_slice(&bip143::SighashComponents::new(&spend_tx).sighash_all(&spend_tx.input[0], &witness_script, output.value)[..]).unwrap();
-                                                                               let remotesig = secp_ctx.sign(&sighash, key);
-                                                                               spend_tx.input[0].witness.push(remotesig.serialize_der(&secp_ctx).to_vec());
+                                                                               let sig = secp_ctx.sign(&sighash, &secret.secret_key);
+                                                                               spend_tx.input[0].witness.push(sig.serialize_der(&secp_ctx).to_vec());
                                                                                spend_tx.input[0].witness[0].push(SigHashType::All as u8);
-                                                                               spend_tx.input[0].witness.push(remotepubkey.serialize().to_vec());
+                                                                               spend_tx.input[0].witness.push(pubkey.serialize().to_vec());
                                                                                txn.push(spend_tx);
                                                                        },
-                                                                       _ => panic!("Unexpected event"),
                                                                }
                                                        }
                                                },
@@ -7660,57 +7710,6 @@ mod tests {
                }
        }
 
-       macro_rules! check_static_output {
-               ($event: expr, $node: expr, $event_idx: expr, $output_idx: expr, $der_idx: expr, $idx_node: expr) => {
-                       match $event[$event_idx] {
-                               Event::SpendableOutputs { ref outputs } => {
-                                       match outputs[$output_idx] {
-                                               SpendableOutputDescriptor::StaticOutput { ref outpoint, ref output } => {
-                                                       let secp_ctx = Secp256k1::new();
-                                                       let input = TxIn {
-                                                               previous_output: outpoint.clone(),
-                                                               script_sig: Script::new(),
-                                                               sequence: 0,
-                                                               witness: Vec::new(),
-                                                       };
-                                                       let outp = TxOut {
-                                                               script_pubkey: Builder::new().push_opcode(opcodes::All::OP_RETURN).into_script(),
-                                                               value: output.value,
-                                                       };
-                                                       let mut spend_tx = Transaction {
-                                                               version: 2,
-                                                               lock_time: 0,
-                                                               input: vec![input],
-                                                               output: vec![outp.clone()],
-                                                       };
-                                                       let secret = {
-                                                               match ExtendedPrivKey::new_master(&secp_ctx, Network::Testnet, &$node[$idx_node].node_seed) {
-                                                                       Ok(master_key) => {
-                                                                               match master_key.ckd_priv(&secp_ctx, ChildNumber::from_hardened_idx($der_idx)) {
-                                                                                       Ok(key) => key,
-                                                                                       Err(_) => panic!("Your RNG is busted"),
-                                                                               }
-                                                                       }
-                                                                       Err(_) => panic!("Your rng is busted"),
-                                                               }
-                                                       };
-                                                       let pubkey = ExtendedPubKey::from_private(&secp_ctx, &secret).public_key;
-                                                       let witness_script = Address::p2pkh(&pubkey, Network::Testnet).script_pubkey();
-                                                       let sighash = Message::from_slice(&bip143::SighashComponents::new(&spend_tx).sighash_all(&spend_tx.input[0], &witness_script, output.value)[..]).unwrap();
-                                                       let sig = secp_ctx.sign(&sighash, &secret.secret_key);
-                                                       spend_tx.input[0].witness.push(sig.serialize_der(&secp_ctx).to_vec());
-                                                       spend_tx.input[0].witness[0].push(SigHashType::All as u8);
-                                                       spend_tx.input[0].witness.push(pubkey.serialize().to_vec());
-                                                       spend_tx
-                                               },
-                                               _ => panic!("Unexpected event !"),
-                                       }
-                               },
-                               _ => panic!("Unexpected event !"),
-                       };
-               }
-       }
-
        #[test]
        fn test_claim_sizeable_push_msat() {
                // Incidentally test SpendableOutput event generation due to detection of to_local output on commitment tx
@@ -7730,14 +7729,14 @@ mod tests {
 
                let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
                nodes[1].chain_monitor.block_connected_with_filtering(&Block { header, txdata: vec![node_txn[0].clone()] }, 0);
-               let spend_txn = check_dynamic_output_p2wsh!(nodes[1]);
+               let spend_txn = check_spendable_outputs!(nodes[1], 1);
                assert_eq!(spend_txn.len(), 1);
                check_spends!(spend_txn[0], node_txn[0].clone());
        }
 
        #[test]
        fn test_claim_on_remote_sizeable_push_msat() {
-               // Same test as precedent, just test on remote commitment tx, as per_commitment_point registration changes following you're funder/fundee and
+               // Same test as previous, just test on remote commitment tx, as per_commitment_point registration changes following you're funder/fundee and
                // to_remote output is encumbered by a P2WPKH
 
                let nodes = create_network(2);
@@ -7761,12 +7760,42 @@ mod tests {
                        MessageSendEvent::BroadcastChannelUpdate { .. } => {},
                        _ => panic!("Unexpected event"),
                }
-               let spend_txn = check_dynamic_output_p2wpkh!(nodes[1]);
+               let spend_txn = check_spendable_outputs!(nodes[1], 1);
                assert_eq!(spend_txn.len(), 2);
                assert_eq!(spend_txn[0], spend_txn[1]);
                check_spends!(spend_txn[0], node_txn[0].clone());
        }
 
+       #[test]
+       fn test_claim_on_remote_revoked_sizeable_push_msat() {
+               // Same test as previous, just test on remote revoked commitment tx, as per_commitment_point registration changes following you're funder/fundee and
+               // to_remote output is encumbered by a P2WPKH
+
+               let nodes = create_network(2);
+
+               let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 59000000);
+               let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0;
+               let revoked_local_txn = nodes[0].node.channel_state.lock().unwrap().by_id.get(&chan.2).unwrap().last_local_commitment_txn.clone();
+               assert_eq!(revoked_local_txn[0].input.len(), 1);
+               assert_eq!(revoked_local_txn[0].input[0].previous_output.txid, chan.3.txid());
+
+               claim_payment(&nodes[0], &vec!(&nodes[1])[..], payment_preimage);
+               let  header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
+               nodes[1].chain_monitor.block_connected_with_filtering(&Block { header, txdata: vec![revoked_local_txn[0].clone()] }, 1);
+               let events = nodes[1].node.get_and_clear_pending_msg_events();
+               match events[0] {
+                       MessageSendEvent::BroadcastChannelUpdate { .. } => {},
+                       _ => panic!("Unexpected event"),
+               }
+               let node_txn = nodes[1].tx_broadcaster.txn_broadcasted.lock().unwrap();
+               let spend_txn = check_spendable_outputs!(nodes[1], 1);
+               assert_eq!(spend_txn.len(), 4);
+               assert_eq!(spend_txn[0], spend_txn[2]); // to_remote output on revoked remote commitment_tx
+               check_spends!(spend_txn[0], revoked_local_txn[0].clone());
+               assert_eq!(spend_txn[1], spend_txn[3]); // to_local output on local commitment tx
+               check_spends!(spend_txn[1], node_txn[0].clone());
+       }
+
        #[test]
        fn test_static_spendable_outputs_preimage_tx() {
                let nodes = create_network(2);
@@ -7802,9 +7831,10 @@ mod tests {
                assert_eq!(node_txn[0].input[0].witness.last().unwrap().len(), 133);
                check_spends!(node_txn[1], chan_1.3.clone());
 
-               let events = nodes[1].chan_monitor.simple_monitor.get_and_clear_pending_events();
-               let spend_tx = check_static_output!(events, nodes, 0, 0, 1, 1);
-               check_spends!(spend_tx, node_txn[0].clone());
+               let spend_txn = check_spendable_outputs!(nodes[1], 1); // , 0, 0, 1, 1);
+               assert_eq!(spend_txn.len(), 2);
+               assert_eq!(spend_txn[0], spend_txn[1]);
+               check_spends!(spend_txn[0], node_txn[0].clone());
        }
 
        #[test]
@@ -7834,9 +7864,10 @@ mod tests {
                assert_eq!(node_txn[0].input.len(), 2);
                check_spends!(node_txn[0], revoked_local_txn[0].clone());
 
-               let events = nodes[1].chan_monitor.simple_monitor.get_and_clear_pending_events();
-               let spend_tx = check_static_output!(events, nodes, 0, 0, 1, 1);
-               check_spends!(spend_tx, node_txn[0].clone());
+               let spend_txn = check_spendable_outputs!(nodes[1], 1);
+               assert_eq!(spend_txn.len(), 2);
+               assert_eq!(spend_txn[0], spend_txn[1]);
+               check_spends!(spend_txn[0], node_txn[0].clone());
        }
 
        #[test]
@@ -7880,10 +7911,12 @@ mod tests {
                assert_eq!(node_txn[3].input.len(), 1);
                check_spends!(node_txn[3], revoked_htlc_txn[0].clone());
 
-               let events = nodes[1].chan_monitor.simple_monitor.get_and_clear_pending_events();
                // Check B's ChannelMonitor was able to generate the right spendable output descriptor
-               let spend_tx = check_static_output!(events, nodes, 1, 1, 1, 1);
-               check_spends!(spend_tx, node_txn[3].clone());
+               let spend_txn = check_spendable_outputs!(nodes[1], 1);
+               assert_eq!(spend_txn.len(), 3);
+               assert_eq!(spend_txn[0], spend_txn[1]);
+               check_spends!(spend_txn[0], node_txn[0].clone());
+               check_spends!(spend_txn[2], node_txn[3].clone());
        }
 
        #[test]
@@ -7928,10 +7961,14 @@ mod tests {
                assert_eq!(node_txn[3].input.len(), 1);
                check_spends!(node_txn[3], revoked_htlc_txn[0].clone());
 
-               let events = nodes[0].chan_monitor.simple_monitor.get_and_clear_pending_events();
                // Check A's ChannelMonitor was able to generate the right spendable output descriptor
-               let spend_tx = check_static_output!(events, nodes, 1, 2, 1, 0);
-               check_spends!(spend_tx, node_txn[3].clone());
+               let spend_txn = check_spendable_outputs!(nodes[0], 1);
+               assert_eq!(spend_txn.len(), 5);
+               assert_eq!(spend_txn[0], spend_txn[2]);
+               assert_eq!(spend_txn[1], spend_txn[3]);
+               check_spends!(spend_txn[0], revoked_local_txn[0].clone()); // spending to_remote output from revoked local tx
+               check_spends!(spend_txn[1], node_txn[2].clone()); // spending justice tx output from revoked local tx htlc received output
+               check_spends!(spend_txn[4], node_txn[3].clone()); // spending justice tx output on htlc success tx
        }
 
        #[test]
@@ -7966,7 +8003,7 @@ mod tests {
                check_spends!(node_txn[0], local_txn[0].clone());
 
                // Verify that B is able to spend its own HTLC-Success tx thanks to spendable output event given back by its ChannelMonitor
-               let spend_txn = check_dynamic_output_p2wsh!(nodes[1]);
+               let spend_txn = check_spendable_outputs!(nodes[1], 1);
                assert_eq!(spend_txn.len(), 1);
                check_spends!(spend_txn[0], node_txn[0].clone());
        }
@@ -7997,7 +8034,7 @@ mod tests {
                check_spends!(node_txn[0], local_txn[0].clone());
 
                // Verify that A is able to spend its own HTLC-Timeout tx thanks to spendable output event given back by its ChannelMonitor
-               let spend_txn = check_dynamic_output_p2wsh!(nodes[0]);
+               let spend_txn = check_spendable_outputs!(nodes[0], 1);
                assert_eq!(spend_txn.len(), 4);
                assert_eq!(spend_txn[0], spend_txn[2]);
                assert_eq!(spend_txn[1], spend_txn[3]);
@@ -8016,13 +8053,13 @@ mod tests {
 
                let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 };
                nodes[0].chain_monitor.block_connected_with_filtering(&Block { header, txdata: vec![closing_tx.clone()] }, 1);
-               let events = nodes[0].chan_monitor.simple_monitor.get_and_clear_pending_events();
-               let spend_tx = check_static_output!(events, nodes, 0, 0, 2, 0);
-               check_spends!(spend_tx, closing_tx.clone());
+               let spend_txn = check_spendable_outputs!(nodes[0], 2);
+               assert_eq!(spend_txn.len(), 1);
+               check_spends!(spend_txn[0], closing_tx.clone());
 
                nodes[1].chain_monitor.block_connected_with_filtering(&Block { header, txdata: vec![closing_tx.clone()] }, 1);
-               let events = nodes[1].chan_monitor.simple_monitor.get_and_clear_pending_events();
-               let spend_tx = check_static_output!(events, nodes, 0, 0, 2, 1);
-               check_spends!(spend_tx, closing_tx);
+               let spend_txn = check_spendable_outputs!(nodes[1], 2);
+               assert_eq!(spend_txn.len(), 1);
+               check_spends!(spend_txn[0], closing_tx);
        }
 }