Simplify ChannelMonitor Storage updates a bit
[rust-lightning] / src / ln / channelmonitor.rs
index d50c73f6dcd5de61da0b82093188e722c1f39460..65b592a879927182bfe970915d62217b94816e18 100644 (file)
@@ -170,21 +170,27 @@ impl<Key : Send + cmp::Eq + hash::Hash + 'static> SimpleManyChannelMonitor<Key>
                let mut monitors = self.monitors.lock().unwrap();
                match monitors.get_mut(&key) {
                        Some(orig_monitor) => {
-                               log_trace!(self, "Updating Channel Monitor for channel {}", log_funding_option!(monitor.funding_txo));
+                               log_trace!(self, "Updating Channel Monitor for channel {}", log_funding_info!(monitor.key_storage));
                                return orig_monitor.insert_combine(monitor);
                        },
                        None => {}
                };
-               match &monitor.funding_txo {
-                       &None => {
-                               log_trace!(self, "Got new Channel Monitor for no-funding-set channel (monitoring all txn!)");
-                               self.chain_monitor.watch_all_txn()
-                       },
-                       &Some((ref outpoint, ref script)) => {
-                               log_trace!(self, "Got new Channel Monitor for channel {}", log_bytes!(outpoint.to_channel_id()[..]));
-                               self.chain_monitor.install_watch_tx(&outpoint.txid, script);
-                               self.chain_monitor.install_watch_outpoint((outpoint.txid, outpoint.index as u32), script);
+               match monitor.key_storage {
+                       Storage::Local { ref funding_info, .. } => {
+                               match funding_info {
+                                       &None => {
+                                               return Err(MonitorUpdateError("Try to update a useless monitor without funding_txo !"));
+                                       },
+                                       &Some((ref outpoint, ref script)) => {
+                                               log_trace!(self, "Got new Channel Monitor for channel {}", log_bytes!(outpoint.to_channel_id()[..]));
+                                               self.chain_monitor.install_watch_tx(&outpoint.txid, script);
+                                               self.chain_monitor.install_watch_outpoint((outpoint.txid, outpoint.index as u32), script);
+                                       },
+                               }
                        },
+                       Storage::Watchtower { .. } => {
+                               self.chain_monitor.watch_all_txn();
+                       }
                }
                monitors.insert(key, monitor);
                Ok(())
@@ -223,8 +229,8 @@ pub(crate) const CLTV_CLAIM_BUFFER: u32 = 6;
 pub(crate) const HTLC_FAIL_TIMEOUT_BLOCKS: u32 = 3;
 
 #[derive(Clone, PartialEq)]
-enum KeyStorage {
-       PrivMode {
+enum Storage {
+       Local {
                revocation_base_key: SecretKey,
                htlc_base_key: SecretKey,
                delayed_payment_base_key: SecretKey,
@@ -232,11 +238,11 @@ enum KeyStorage {
                shutdown_pubkey: PublicKey,
                prev_latest_per_commitment_point: Option<PublicKey>,
                latest_per_commitment_point: Option<PublicKey>,
+               funding_info: Option<(OutPoint, Script)>,
        },
-       SigsMode {
+       Watchtower {
                revocation_base_key: PublicKey,
                htlc_base_key: PublicKey,
-               sigs: HashMap<Sha256dHash, Signature>,
        }
 }
 
@@ -263,10 +269,9 @@ const MIN_SERIALIZATION_VERSION: u8 = 1;
 /// information and are actively monitoring the chain.
 #[derive(Clone)]
 pub struct ChannelMonitor {
-       funding_txo: Option<(OutPoint, Script)>,
        commitment_transaction_number_obscure_factor: u64,
 
-       key_storage: KeyStorage,
+       key_storage: Storage,
        their_htlc_base_key: Option<PublicKey>,
        their_delayed_payment_base_key: Option<PublicKey>,
        // first is the idx of the first of the two revocation points
@@ -319,8 +324,7 @@ pub struct ChannelMonitor {
 /// underlying object
 impl PartialEq for ChannelMonitor {
        fn eq(&self, other: &Self) -> bool {
-               if self.funding_txo != other.funding_txo ||
-                       self.commitment_transaction_number_obscure_factor != other.commitment_transaction_number_obscure_factor ||
+               if self.commitment_transaction_number_obscure_factor != other.commitment_transaction_number_obscure_factor ||
                        self.key_storage != other.key_storage ||
                        self.their_htlc_base_key != other.their_htlc_base_key ||
                        self.their_delayed_payment_base_key != other.their_delayed_payment_base_key ||
@@ -351,10 +355,9 @@ impl PartialEq for ChannelMonitor {
 impl ChannelMonitor {
        pub(super) fn new(revocation_base_key: &SecretKey, delayed_payment_base_key: &SecretKey, htlc_base_key: &SecretKey, payment_base_key: &SecretKey, shutdown_pubkey: &PublicKey, our_to_self_delay: u16, destination_script: Script, logger: Arc<Logger>) -> ChannelMonitor {
                ChannelMonitor {
-                       funding_txo: None,
                        commitment_transaction_number_obscure_factor: 0,
 
-                       key_storage: KeyStorage::PrivMode {
+                       key_storage: Storage::Local {
                                revocation_base_key: revocation_base_key.clone(),
                                htlc_base_key: htlc_base_key.clone(),
                                delayed_payment_base_key: delayed_payment_base_key.clone(),
@@ -362,6 +365,7 @@ impl ChannelMonitor {
                                shutdown_pubkey: shutdown_pubkey.clone(),
                                prev_latest_per_commitment_point: None,
                                latest_per_commitment_point: None,
+                               funding_info: None,
                        },
                        their_htlc_base_key: None,
                        their_delayed_payment_base_key: None,
@@ -461,37 +465,11 @@ impl ChannelMonitor {
                Ok(())
        }
 
-       /// Tracks the next revocation point which may be required to claim HTLC outputs which we know
-       /// the preimage of in case the remote end force-closes using their latest state. When called at
-       /// channel opening revocation point is the CURRENT one used for first commitment tx. Needed in case of sizeable push_msat.
-       pub(super) fn provide_their_next_revocation_point(&mut self, their_next_revocation_point: Option<(u64, PublicKey)>) {
-               if let Some(new_revocation_point) = their_next_revocation_point {
-                       match self.their_cur_revocation_points {
-                               Some(old_points) => {
-                                       if old_points.0 == new_revocation_point.0 + 1 {
-                                               self.their_cur_revocation_points = Some((old_points.0, old_points.1, Some(new_revocation_point.1)));
-                                       } else if old_points.0 == new_revocation_point.0 + 2 {
-                                               if let Some(old_second_point) = old_points.2 {
-                                                       self.their_cur_revocation_points = Some((old_points.0 - 1, old_second_point, Some(new_revocation_point.1)));
-                                               } else {
-                                                       self.their_cur_revocation_points = Some((new_revocation_point.0, new_revocation_point.1, None));
-                                               }
-                                       } else {
-                                               self.their_cur_revocation_points = Some((new_revocation_point.0, new_revocation_point.1, None));
-                                       }
-                               },
-                               None => {
-                                       self.their_cur_revocation_points = Some((new_revocation_point.0, new_revocation_point.1, None));
-                               }
-                       }
-               }
-       }
-
        /// Informs this monitor of the latest remote (ie non-broadcastable) commitment transaction.
        /// The monitor watches for it to be broadcasted and then uses the HTLC information (and
        /// possibly future revocation/preimage information) to claim outputs where possible.
        /// We cache also the mapping hash:commitment number to lighten pruning of old preimages by watchtowers.
-       pub(super) fn provide_latest_remote_commitment_tx_info(&mut self, unsigned_commitment_tx: &Transaction, htlc_outputs: Vec<HTLCOutputInCommitment>, commitment_number: u64) {
+       pub(super) fn provide_latest_remote_commitment_tx_info(&mut self, unsigned_commitment_tx: &Transaction, htlc_outputs: Vec<HTLCOutputInCommitment>, commitment_number: u64, their_revocation_point: PublicKey) {
                // TODO: Encrypt the htlc_outputs data with the single-hash of the commitment transaction
                // so that a remote monitor doesn't learn anything unless there is a malicious close.
                // (only maybe, sadly we cant do the same for local info, as we need to be aware of
@@ -501,6 +479,25 @@ impl ChannelMonitor {
                }
                self.remote_claimable_outpoints.insert(unsigned_commitment_tx.txid(), htlc_outputs);
                self.current_remote_commitment_number = commitment_number;
+               //TODO: Merge this into the other per-remote-transaction output storage stuff
+               match self.their_cur_revocation_points {
+                       Some(old_points) => {
+                               if old_points.0 == commitment_number + 1 {
+                                       self.their_cur_revocation_points = Some((old_points.0, old_points.1, Some(their_revocation_point)));
+                               } else if old_points.0 == commitment_number + 2 {
+                                       if let Some(old_second_point) = old_points.2 {
+                                               self.their_cur_revocation_points = Some((old_points.0 - 1, old_second_point, Some(their_revocation_point)));
+                                       } else {
+                                               self.their_cur_revocation_points = Some((commitment_number, their_revocation_point, None));
+                                       }
+                               } else {
+                                       self.their_cur_revocation_points = Some((commitment_number, their_revocation_point, None));
+                               }
+                       },
+                       None => {
+                               self.their_cur_revocation_points = Some((commitment_number, their_revocation_point, None));
+                       }
+               }
        }
 
        /// Informs this monitor of the latest local (ie broadcastable) commitment transaction. The
@@ -508,7 +505,7 @@ impl ChannelMonitor {
        /// is important that any clones of this channel monitor (including remote clones) by kept
        /// up-to-date as our local commitment transaction is updated.
        /// Panics if set_their_to_self_delay has never been called.
-       /// Also update KeyStorage with latest local per_commitment_point to derive local_delayedkey in
+       /// Also update Storage with latest local per_commitment_point to derive local_delayedkey in
        /// case of onchain HTLC tx
        pub(super) fn provide_latest_local_commitment_tx_info(&mut self, signed_commitment_tx: Transaction, local_keys: chan_utils::TxCreationKeys, feerate_per_kw: u64, htlc_outputs: Vec<(HTLCOutputInCommitment, Signature, Signature)>) {
                assert!(self.their_to_self_delay.is_some());
@@ -523,8 +520,8 @@ impl ChannelMonitor {
                        feerate_per_kw,
                        htlc_outputs,
                });
-               self.key_storage = if let KeyStorage::PrivMode { ref revocation_base_key, ref htlc_base_key, ref delayed_payment_base_key, ref payment_base_key, ref shutdown_pubkey, ref latest_per_commitment_point, .. } = self.key_storage {
-                       KeyStorage::PrivMode {
+               self.key_storage = if let Storage::Local { ref revocation_base_key, ref htlc_base_key, ref delayed_payment_base_key, ref payment_base_key, ref shutdown_pubkey, ref latest_per_commitment_point, ref mut funding_info, .. } = self.key_storage {
+                       Storage::Local {
                                revocation_base_key: *revocation_base_key,
                                htlc_base_key: *htlc_base_key,
                                delayed_payment_base_key: *delayed_payment_base_key,
@@ -532,6 +529,7 @@ impl ChannelMonitor {
                                shutdown_pubkey: *shutdown_pubkey,
                                prev_latest_per_commitment_point: *latest_per_commitment_point,
                                latest_per_commitment_point: Some(local_keys.per_commitment_point),
+                               funding_info: funding_info.take(),
                        }
                } else { unimplemented!(); };
        }
@@ -546,14 +544,28 @@ impl ChannelMonitor {
        /// After a successful call this ChannelMonitor is up-to-date and is safe to use to monitor the
        /// chain for new blocks/transactions.
        pub fn insert_combine(&mut self, mut other: ChannelMonitor) -> Result<(), MonitorUpdateError> {
-               if self.funding_txo.is_some() {
-                       // We should be able to compare the entire funding_txo, but in fuzztarget its trivially
-                       // easy to collide the funding_txo hash and have a different scriptPubKey.
-                       if other.funding_txo.is_some() && other.funding_txo.as_ref().unwrap().0 != self.funding_txo.as_ref().unwrap().0 {
-                               return Err(MonitorUpdateError("Funding transaction outputs are not identical!"));
-                       }
-               } else {
-                       self.funding_txo = other.funding_txo.take();
+               match self.key_storage {
+                       Storage::Local { ref funding_info, .. } => {
+                               if funding_info.is_none() { return Err(MonitorUpdateError("Try to combine a Local monitor without funding_info")); }
+                               let our_funding_info = funding_info;
+                               if let Storage::Local { ref funding_info, .. } = other.key_storage {
+                                       if funding_info.is_none() { return Err(MonitorUpdateError("Try to combine a Local monitor without funding_info")); }
+                                       // We should be able to compare the entire funding_txo, but in fuzztarget its trivially
+                                       // easy to collide the funding_txo hash and have a different scriptPubKey.
+                                       if funding_info.as_ref().unwrap().0 != our_funding_info.as_ref().unwrap().0 {
+                                               return Err(MonitorUpdateError("Funding transaction outputs are not identical!"));
+                                       }
+                               } else {
+                                       return Err(MonitorUpdateError("Try to combine a Local monitor with a Watchtower one !"));
+                               }
+                       },
+                       Storage::Watchtower { .. } => {
+                               if let Storage::Watchtower { .. } = other.key_storage {
+                                       unimplemented!();
+                               } else {
+                                       return Err(MonitorUpdateError("Try to combine a Watchtower monitor with a Local one !"));
+                               }
+                       },
                }
                let other_min_secret = other.get_min_seen_secret();
                let our_min_secret = self.get_min_seen_secret();
@@ -601,8 +613,15 @@ impl ChannelMonitor {
        /// provides slightly better privacy.
        /// It's the responsibility of the caller to register outpoint and script with passing the former
        /// value as key to add_update_monitor.
-       pub(super) fn set_funding_info(&mut self, funding_info: (OutPoint, Script)) {
-               self.funding_txo = Some(funding_info);
+       pub(super) fn set_funding_info(&mut self, new_funding_info: (OutPoint, Script)) {
+               match self.key_storage {
+                       Storage::Local { ref mut funding_info, .. } => {
+                               *funding_info = Some(new_funding_info);
+                       },
+                       Storage::Watchtower { .. } => {
+                               panic!("Channel somehow ended up with its internal ChannelMonitor being in Watchtower mode?");
+                       }
+               }
        }
 
        /// We log these base keys at channel opening to being able to rebuild redeemscript in case of leaked revoked commit tx
@@ -616,14 +635,28 @@ impl ChannelMonitor {
        }
 
        pub(super) fn unset_funding_info(&mut self) {
-               self.funding_txo = None;
+               match self.key_storage {
+                       Storage::Local { ref mut funding_info, .. } => {
+                               *funding_info = None;
+                       },
+                       Storage::Watchtower { .. } => {
+                               panic!("Channel somehow ended up with its internal ChannelMonitor being in Watchtower mode?");
+                       },
+               }
        }
 
        /// Gets the funding transaction outpoint of the channel this ChannelMonitor is monitoring for.
        pub fn get_funding_txo(&self) -> Option<OutPoint> {
-               match self.funding_txo {
-                       Some((outpoint, _)) => Some(outpoint),
-                       None => None
+               match self.key_storage {
+                       Storage::Local { ref funding_info, .. } => {
+                               match funding_info {
+                                       &Some((outpoint, _)) => Some(outpoint),
+                                       &None => None
+                               }
+                       },
+                       Storage::Watchtower { .. } => {
+                               return None;
+                       }
                }
        }
 
@@ -648,24 +681,11 @@ impl ChannelMonitor {
                writer.write_all(&[SERIALIZATION_VERSION; 1])?;
                writer.write_all(&[MIN_SERIALIZATION_VERSION; 1])?;
 
-               match &self.funding_txo {
-                       &Some((ref outpoint, ref script)) => {
-                               writer.write_all(&outpoint.txid[..])?;
-                               writer.write_all(&byte_utils::be16_to_array(outpoint.index))?;
-                               script.write(writer)?;
-                       },
-                       &None => {
-                               // We haven't even been initialized...not sure why anyone is serializing us, but
-                               // not much to give them.
-                               return Ok(());
-                       },
-               }
-
                // Set in initial Channel-object creation, so should always be set by now:
                U48(self.commitment_transaction_number_obscure_factor).write(writer)?;
 
                match self.key_storage {
-                       KeyStorage::PrivMode { ref revocation_base_key, ref htlc_base_key, ref delayed_payment_base_key, ref payment_base_key, ref shutdown_pubkey, ref prev_latest_per_commitment_point, ref latest_per_commitment_point } => {
+                       Storage::Local { ref revocation_base_key, ref htlc_base_key, ref delayed_payment_base_key, ref payment_base_key, ref shutdown_pubkey, ref prev_latest_per_commitment_point, ref latest_per_commitment_point, ref funding_info } => {
                                writer.write_all(&[0; 1])?;
                                writer.write_all(&revocation_base_key[..])?;
                                writer.write_all(&htlc_base_key[..])?;
@@ -684,9 +704,18 @@ impl ChannelMonitor {
                                } else {
                                        writer.write_all(&[0; 1])?;
                                }
-
+                               match funding_info  {
+                                       &Some((ref outpoint, ref script)) => {
+                                               writer.write_all(&outpoint.txid[..])?;
+                                               writer.write_all(&byte_utils::be16_to_array(outpoint.index))?;
+                                               script.write(writer)?;
+                                       },
+                                       &None => {
+                                               debug_assert!(false, "Try to serialize a useless Local monitor !");
+                                       },
+                               }
                        },
-                       KeyStorage::SigsMode { .. } => unimplemented!(),
+                       Storage::Watchtower { .. } => unimplemented!(),
                }
 
                writer.write_all(&self.their_htlc_base_key.as_ref().unwrap().serialize())?;
@@ -896,16 +925,18 @@ impl ChannelMonitor {
                if commitment_number >= self.get_min_seen_secret() {
                        let secret = self.get_secret(commitment_number).unwrap();
                        let per_commitment_key = ignore_error!(SecretKey::from_slice(&self.secp_ctx, &secret));
-                       let (revocation_pubkey, b_htlc_key) = match self.key_storage {
-                               KeyStorage::PrivMode { ref revocation_base_key, ref htlc_base_key, .. } => {
+                       let (revocation_pubkey, b_htlc_key, local_payment_key) = match self.key_storage {
+                               Storage::Local { ref revocation_base_key, ref htlc_base_key, ref payment_base_key, .. } => {
                                        let per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &per_commitment_key);
                                        (ignore_error!(chan_utils::derive_public_revocation_key(&self.secp_ctx, &per_commitment_point, &PublicKey::from_secret_key(&self.secp_ctx, &revocation_base_key))),
-                                       ignore_error!(chan_utils::derive_public_key(&self.secp_ctx, &per_commitment_point, &PublicKey::from_secret_key(&self.secp_ctx, &htlc_base_key))))
+                                       ignore_error!(chan_utils::derive_public_key(&self.secp_ctx, &per_commitment_point, &PublicKey::from_secret_key(&self.secp_ctx, &htlc_base_key))),
+                                       Some(ignore_error!(chan_utils::derive_private_key(&self.secp_ctx, &per_commitment_point, &payment_base_key))))
                                },
-                               KeyStorage::SigsMode { ref revocation_base_key, ref htlc_base_key, .. } => {
+                               Storage::Watchtower { ref revocation_base_key, ref htlc_base_key, .. } => {
                                        let per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &per_commitment_key);
                                        (ignore_error!(chan_utils::derive_public_revocation_key(&self.secp_ctx, &per_commitment_point, &revocation_base_key)),
-                                       ignore_error!(chan_utils::derive_public_key(&self.secp_ctx, &per_commitment_point, &htlc_base_key)))
+                                       ignore_error!(chan_utils::derive_public_key(&self.secp_ctx, &per_commitment_point, &htlc_base_key)),
+                                       None)
                                },
                        };
                        let delayed_key = ignore_error!(chan_utils::derive_public_key(&self.secp_ctx, &PublicKey::from_secret_key(&self.secp_ctx, &per_commitment_key), &self.their_delayed_payment_base_key.unwrap()));
@@ -917,6 +948,13 @@ impl ChannelMonitor {
                        let revokeable_redeemscript = chan_utils::get_revokeable_redeemscript(&revocation_pubkey, self.our_to_self_delay, &delayed_key);
                        let revokeable_p2wsh = revokeable_redeemscript.to_v0_p2wsh();
 
+                       let local_payment_p2wpkh = if let Some(payment_key) = local_payment_key {
+                               // Note that the Network here is ignored as we immediately drop the address for the
+                               // script_pubkey version.
+                               let payment_hash160 = Hash160::from_data(&PublicKey::from_secret_key(&self.secp_ctx, &payment_key).serialize());
+                               Some(Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&payment_hash160[..]).into_script())
+                       } else { None };
+
                        let mut total_value = 0;
                        let mut values = Vec::new();
                        let mut inputs = Vec::new();
@@ -936,23 +974,12 @@ impl ChannelMonitor {
                                        htlc_idxs.push(None);
                                        values.push(outp.value);
                                        total_value += outp.value;
-                               } else if outp.script_pubkey.is_v0_p2wpkh() {
-                                       match self.key_storage {
-                                               KeyStorage::PrivMode { ref payment_base_key, .. } => {
-                                                       let per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &per_commitment_key);
-                                                       if let Ok(local_key) = chan_utils::derive_private_key(&self.secp_ctx, &per_commitment_point, &payment_base_key) {
-                                                               spendable_outputs.push(SpendableOutputDescriptor::DynamicOutputP2WPKH {
-                                                                       outpoint: BitcoinOutPoint { txid: commitment_txid, vout: idx as u32 },
-                                                                       key: local_key,
-                                                                       output: outp.clone(),
-                                                               });
-                                                       }
-                                               }
-                                               KeyStorage::SigsMode { .. } => {
-                                                       //TODO: we need to ensure an offline client will generate the event when it
-                                                       // cames back online after only the watchtower saw the transaction
-                                               }
-                                       }
+                               } else if Some(&outp.script_pubkey) == local_payment_p2wpkh.as_ref() {
+                                       spendable_outputs.push(SpendableOutputDescriptor::DynamicOutputP2WPKH {
+                                               outpoint: BitcoinOutPoint { txid: commitment_txid, vout: idx as u32 },
+                                               key: local_payment_key.unwrap(),
+                                               output: outp.clone(),
+                                       });
                                }
                        }
 
@@ -960,7 +987,7 @@ impl ChannelMonitor {
                                ($sighash_parts: expr, $input: expr, $htlc_idx: expr, $amount: expr) => {
                                        {
                                                let (sig, redeemscript) = match self.key_storage {
-                                                       KeyStorage::PrivMode { ref revocation_base_key, .. } => {
+                                                       Storage::Local { ref revocation_base_key, .. } => {
                                                                let redeemscript = if $htlc_idx.is_none() { revokeable_redeemscript.clone() } else {
                                                                        let htlc = &per_commitment_option.unwrap()[$htlc_idx.unwrap()];
                                                                        chan_utils::get_htlc_redeemscript_with_explicit_keys(htlc, &a_htlc_key, &b_htlc_key, &revocation_pubkey)
@@ -969,7 +996,7 @@ impl ChannelMonitor {
                                                                let revocation_key = ignore_error!(chan_utils::derive_private_revocation_key(&self.secp_ctx, &per_commitment_key, &revocation_base_key));
                                                                (self.secp_ctx.sign(&sighash, &revocation_key), redeemscript)
                                                        },
-                                                       KeyStorage::SigsMode { .. } => {
+                                                       Storage::Watchtower { .. } => {
                                                                unimplemented!();
                                                        }
                                                };
@@ -1076,11 +1103,11 @@ impl ChannelMonitor {
                                        } else { None };
                                if let Some(revocation_point) = revocation_point_option {
                                        let (revocation_pubkey, b_htlc_key) = match self.key_storage {
-                                               KeyStorage::PrivMode { ref revocation_base_key, ref htlc_base_key, .. } => {
+                                               Storage::Local { ref revocation_base_key, ref htlc_base_key, .. } => {
                                                        (ignore_error!(chan_utils::derive_public_revocation_key(&self.secp_ctx, revocation_point, &PublicKey::from_secret_key(&self.secp_ctx, &revocation_base_key))),
                                                        ignore_error!(chan_utils::derive_public_key(&self.secp_ctx, revocation_point, &PublicKey::from_secret_key(&self.secp_ctx, &htlc_base_key))))
                                                },
-                                               KeyStorage::SigsMode { ref revocation_base_key, ref htlc_base_key, .. } => {
+                                               Storage::Watchtower { ref revocation_base_key, ref htlc_base_key, .. } => {
                                                        (ignore_error!(chan_utils::derive_public_revocation_key(&self.secp_ctx, revocation_point, &revocation_base_key)),
                                                        ignore_error!(chan_utils::derive_public_key(&self.secp_ctx, revocation_point, &htlc_base_key)))
                                                },
@@ -1090,11 +1117,10 @@ impl ChannelMonitor {
                                                Some(their_htlc_base_key) => ignore_error!(chan_utils::derive_public_key(&self.secp_ctx, revocation_point, &their_htlc_base_key)),
                                        };
 
-
                                        for (idx, outp) in tx.output.iter().enumerate() {
                                                if outp.script_pubkey.is_v0_p2wpkh() {
                                                        match self.key_storage {
-                                                               KeyStorage::PrivMode { ref payment_base_key, .. } => {
+                                                               Storage::Local { ref payment_base_key, .. } => {
                                                                        if let Ok(local_key) = chan_utils::derive_private_key(&self.secp_ctx, &revocation_point, &payment_base_key) {
                                                                                spendable_outputs.push(SpendableOutputDescriptor::DynamicOutputP2WPKH {
                                                                                        outpoint: BitcoinOutPoint { txid: commitment_txid, vout: idx as u32 },
@@ -1102,11 +1128,8 @@ impl ChannelMonitor {
                                                                                        output: outp.clone(),
                                                                                });
                                                                        }
-                                                               }
-                                                               KeyStorage::SigsMode { .. } => {
-                                                                       //TODO: we need to ensure an offline client will generate the event when it
-                                                                       // cames back online after only the watchtower saw the transaction
-                                                               }
+                                                               },
+                                                               Storage::Watchtower { .. } => {}
                                                        }
                                                        break; // Only to_remote ouput is claimable
                                                }
@@ -1120,14 +1143,14 @@ impl ChannelMonitor {
                                                ($sighash_parts: expr, $input: expr, $amount: expr, $preimage: expr) => {
                                                        {
                                                                let (sig, redeemscript) = match self.key_storage {
-                                                                       KeyStorage::PrivMode { ref htlc_base_key, .. } => {
+                                                                       Storage::Local { ref htlc_base_key, .. } => {
                                                                                let htlc = &per_commitment_option.unwrap()[$input.sequence as usize];
                                                                                let redeemscript = chan_utils::get_htlc_redeemscript_with_explicit_keys(htlc, &a_htlc_key, &b_htlc_key, &revocation_pubkey);
                                                                                let sighash = ignore_error!(Message::from_slice(&$sighash_parts.sighash_all(&$input, &redeemscript, $amount)[..]));
                                                                                let htlc_key = ignore_error!(chan_utils::derive_private_key(&self.secp_ctx, revocation_point, &htlc_base_key));
                                                                                (self.secp_ctx.sign(&sighash, &htlc_key), redeemscript)
                                                                        },
-                                                                       KeyStorage::SigsMode { .. } => {
+                                                                       Storage::Watchtower { .. } => {
                                                                                unimplemented!();
                                                                        }
                                                                };
@@ -1227,10 +1250,10 @@ impl ChannelMonitor {
                let per_commitment_key = ignore_error!(SecretKey::from_slice(&self.secp_ctx, &secret));
                let per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &per_commitment_key);
                let revocation_pubkey = match self.key_storage {
-                       KeyStorage::PrivMode { ref revocation_base_key, .. } => {
+                       Storage::Local { ref revocation_base_key, .. } => {
                                ignore_error!(chan_utils::derive_public_revocation_key(&self.secp_ctx, &per_commitment_point, &PublicKey::from_secret_key(&self.secp_ctx, &revocation_base_key)))
                        },
-                       KeyStorage::SigsMode { ref revocation_base_key, .. } => {
+                       Storage::Watchtower { ref revocation_base_key, .. } => {
                                ignore_error!(chan_utils::derive_public_revocation_key(&self.secp_ctx, &per_commitment_point, &revocation_base_key))
                        },
                };
@@ -1274,12 +1297,12 @@ impl ChannelMonitor {
                        let sighash_parts = bip143::SighashComponents::new(&spend_tx);
 
                        let sig = match self.key_storage {
-                               KeyStorage::PrivMode { ref revocation_base_key, .. } => {
+                               Storage::Local { ref revocation_base_key, .. } => {
                                        let sighash = ignore_error!(Message::from_slice(&sighash_parts.sighash_all(&spend_tx.input[0], &redeemscript, amount)[..]));
                                        let revocation_key = ignore_error!(chan_utils::derive_private_revocation_key(&self.secp_ctx, &per_commitment_key, &revocation_base_key));
                                        self.secp_ctx.sign(&sighash, &revocation_key)
                                }
-                               KeyStorage::SigsMode { .. } => {
+                               Storage::Watchtower { .. } => {
                                        unimplemented!();
                                }
                        };
@@ -1373,10 +1396,10 @@ impl ChannelMonitor {
                if let &Some(ref local_tx) = &self.current_local_signed_commitment_tx {
                        if local_tx.txid == commitment_txid {
                                match self.key_storage {
-                                       KeyStorage::PrivMode { ref delayed_payment_base_key, ref latest_per_commitment_point, .. } => {
+                                       Storage::Local { ref delayed_payment_base_key, ref latest_per_commitment_point, .. } => {
                                                return self.broadcast_by_local_state(local_tx, latest_per_commitment_point, &Some(*delayed_payment_base_key));
                                        },
-                                       KeyStorage::SigsMode { .. } => {
+                                       Storage::Watchtower { .. } => {
                                                return self.broadcast_by_local_state(local_tx, &None, &None);
                                        }
                                }
@@ -1385,10 +1408,10 @@ impl ChannelMonitor {
                if let &Some(ref local_tx) = &self.prev_local_signed_commitment_tx {
                        if local_tx.txid == commitment_txid {
                                match self.key_storage {
-                                       KeyStorage::PrivMode { ref delayed_payment_base_key, ref prev_latest_per_commitment_point, .. } => {
+                                       Storage::Local { ref delayed_payment_base_key, ref prev_latest_per_commitment_point, .. } => {
                                                return self.broadcast_by_local_state(local_tx, prev_latest_per_commitment_point, &Some(*delayed_payment_base_key));
                                        },
-                                       KeyStorage::SigsMode { .. } => {
+                                       Storage::Watchtower { .. } => {
                                                return self.broadcast_by_local_state(local_tx, &None, &None);
                                        }
                                }
@@ -1399,9 +1422,9 @@ impl ChannelMonitor {
 
        /// Generate a spendable output event when closing_transaction get registered onchain.
        fn check_spend_closing_transaction(&self, tx: &Transaction) -> Option<SpendableOutputDescriptor> {
-               if tx.input[0].sequence == 0xFFFFFFFF && tx.input[0].witness.last().unwrap().len() == 71 {
+               if tx.input[0].sequence == 0xFFFFFFFF && !tx.input[0].witness.is_empty() && tx.input[0].witness.last().unwrap().len() == 71 {
                        match self.key_storage {
-                               KeyStorage::PrivMode { ref shutdown_pubkey, .. } =>  {
+                               Storage::Local { ref shutdown_pubkey, .. } =>  {
                                        let our_channel_close_key_hash = Hash160::from_data(&shutdown_pubkey.serialize());
                                        let shutdown_script = Builder::new().push_opcode(opcodes::All::OP_PUSHBYTES_0).push_slice(&our_channel_close_key_hash[..]).into_script();
                                        for (idx, output) in tx.output.iter().enumerate() {
@@ -1413,7 +1436,7 @@ impl ChannelMonitor {
                                                }
                                        }
                                }
-                               KeyStorage::SigsMode { .. } => {
+                               Storage::Watchtower { .. } => {
                                        //TODO: we need to ensure an offline client will generate the event when it
                                        // cames back online after only the watchtower saw the transaction
                                }
@@ -1428,7 +1451,7 @@ impl ChannelMonitor {
                if let &Some(ref local_tx) = &self.current_local_signed_commitment_tx {
                        let mut res = vec![local_tx.tx.clone()];
                        match self.key_storage {
-                               KeyStorage::PrivMode { ref delayed_payment_base_key, ref prev_latest_per_commitment_point, .. } => {
+                               Storage::Local { ref delayed_payment_base_key, ref prev_latest_per_commitment_point, .. } => {
                                        res.append(&mut self.broadcast_by_local_state(local_tx, prev_latest_per_commitment_point, &Some(*delayed_payment_base_key)).0);
                                },
                                _ => panic!("Can only broadcast by local channelmonitor"),
@@ -1450,7 +1473,15 @@ impl ChannelMonitor {
                                // filters.
                                let prevout = &tx.input[0].previous_output;
                                let mut txn: Vec<Transaction> = Vec::new();
-                               if self.funding_txo.is_none() || (prevout.txid == self.funding_txo.as_ref().unwrap().0.txid && prevout.vout == self.funding_txo.as_ref().unwrap().0.index as u32) {
+                               let funding_txo = match self.key_storage {
+                                       Storage::Local { ref funding_info, .. } => {
+                                               funding_info.clone()
+                                       }
+                                       Storage::Watchtower { .. } => {
+                                               unimplemented!();
+                                       }
+                               };
+                               if funding_txo.is_none() || (prevout.txid == funding_txo.as_ref().unwrap().0.txid && prevout.vout == funding_txo.as_ref().unwrap().0.index as u32) {
                                        let (remote_txn, new_outputs, mut spendable_output) = self.check_spend_remote_transaction(tx, height);
                                        txn = remote_txn;
                                        spendable_outputs.append(&mut spendable_output);
@@ -1462,7 +1493,7 @@ impl ChannelMonitor {
                                                spendable_outputs.append(&mut outputs);
                                                txn = remote_txn;
                                        }
-                                       if !self.funding_txo.is_none() && txn.is_empty() {
+                                       if !funding_txo.is_none() && txn.is_empty() {
                                                if let Some(spendable_output) = self.check_spend_closing_transaction(tx) {
                                                        spendable_outputs.push(spendable_output);
                                                }
@@ -1487,14 +1518,14 @@ impl ChannelMonitor {
                        if self.would_broadcast_at_height(height) {
                                broadcaster.broadcast_transaction(&cur_local_tx.tx);
                                match self.key_storage {
-                                       KeyStorage::PrivMode { ref delayed_payment_base_key, ref latest_per_commitment_point, .. } => {
+                                       Storage::Local { ref delayed_payment_base_key, ref latest_per_commitment_point, .. } => {
                                                let (txs, mut outputs) = self.broadcast_by_local_state(&cur_local_tx, latest_per_commitment_point, &Some(*delayed_payment_base_key));
                                                spendable_outputs.append(&mut outputs);
                                                for tx in txs {
                                                        broadcaster.broadcast_transaction(&tx);
                                                }
                                        },
-                                       KeyStorage::SigsMode { .. } => {
+                                       Storage::Watchtower { .. } => {
                                                let (txs, mut outputs) = self.broadcast_by_local_state(&cur_local_tx, &None, &None);
                                                spendable_outputs.append(&mut outputs);
                                                for tx in txs {
@@ -1561,13 +1592,6 @@ impl<R: ::std::io::Read> ReadableArgs<R, Arc<Logger>> for (Sha256dHash, ChannelM
                        return Err(DecodeError::UnknownVersion);
                }
 
-               // Technically this can fail and serialize fail a round-trip, but only for serialization of
-               // barely-init'd ChannelMonitors that we can't do anything with.
-               let outpoint = OutPoint {
-                       txid: Readable::read(reader)?,
-                       index: Readable::read(reader)?,
-               };
-               let funding_txo = Some((outpoint, Readable::read(reader)?));
                let commitment_transaction_number_obscure_factor = <U48 as Readable<R>>::read(reader)?.0;
 
                let key_storage = match <u8 as Readable<R>>::read(reader)? {
@@ -1587,7 +1611,14 @@ impl<R: ::std::io::Read> ReadableArgs<R, Arc<Logger>> for (Sha256dHash, ChannelM
                                        1 => Some(Readable::read(reader)?),
                                        _ => return Err(DecodeError::InvalidValue),
                                };
-                               KeyStorage::PrivMode {
+                               // Technically this can fail and serialize fail a round-trip, but only for serialization of
+                               // barely-init'd ChannelMonitors that we can't do anything with.
+                               let outpoint = OutPoint {
+                                       txid: Readable::read(reader)?,
+                                       index: Readable::read(reader)?,
+                               };
+                               let funding_info = Some((outpoint, Readable::read(reader)?));
+                               Storage::Local {
                                        revocation_base_key,
                                        htlc_base_key,
                                        delayed_payment_base_key,
@@ -1595,6 +1626,7 @@ impl<R: ::std::io::Read> ReadableArgs<R, Arc<Logger>> for (Sha256dHash, ChannelM
                                        shutdown_pubkey,
                                        prev_latest_per_commitment_point,
                                        latest_per_commitment_point,
+                                       funding_info,
                                }
                        },
                        _ => return Err(DecodeError::InvalidValue),
@@ -1754,7 +1786,6 @@ impl<R: ::std::io::Read> ReadableArgs<R, Arc<Logger>> for (Sha256dHash, ChannelM
                let destination_script = Readable::read(reader)?;
 
                Ok((last_block_hash.clone(), ChannelMonitor {
-                       funding_txo,
                        commitment_transaction_number_obscure_factor,
 
                        key_storage,
@@ -2161,10 +2192,10 @@ mod tests {
                let logger = Arc::new(TestLogger::new());
                let dummy_sig = Signature::from_der(&secp_ctx, &hex::decode("3045022100fa86fa9a36a8cd6a7bb8f06a541787d51371d067951a9461d5404de6b928782e02201c8b7c334c10aed8976a3a465be9a28abff4cb23acbf00022295b378ce1fa3cd").unwrap()[..]).unwrap();
 
+               let dummy_key = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &[42; 32]).unwrap());
                macro_rules! dummy_keys {
                        () => {
                                {
-                                       let dummy_key = PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&secp_ctx, &[42; 32]).unwrap());
                                        TxCreationKeys {
                                                per_commitment_point: dummy_key.clone(),
                                                revocation_key: dummy_key.clone(),
@@ -2233,10 +2264,10 @@ mod tests {
                monitor.set_their_to_self_delay(10);
 
                monitor.provide_latest_local_commitment_tx_info(dummy_tx.clone(), dummy_keys!(), 0, preimages_to_local_htlcs!(preimages[0..10]));
-               monitor.provide_latest_remote_commitment_tx_info(&dummy_tx, preimages_slice_to_htlc_outputs!(preimages[5..15]), 281474976710655);
-               monitor.provide_latest_remote_commitment_tx_info(&dummy_tx, preimages_slice_to_htlc_outputs!(preimages[15..20]), 281474976710654);
-               monitor.provide_latest_remote_commitment_tx_info(&dummy_tx, preimages_slice_to_htlc_outputs!(preimages[17..20]), 281474976710653);
-               monitor.provide_latest_remote_commitment_tx_info(&dummy_tx, preimages_slice_to_htlc_outputs!(preimages[18..20]), 281474976710652);
+               monitor.provide_latest_remote_commitment_tx_info(&dummy_tx, preimages_slice_to_htlc_outputs!(preimages[5..15]), 281474976710655, dummy_key);
+               monitor.provide_latest_remote_commitment_tx_info(&dummy_tx, preimages_slice_to_htlc_outputs!(preimages[15..20]), 281474976710654, dummy_key);
+               monitor.provide_latest_remote_commitment_tx_info(&dummy_tx, preimages_slice_to_htlc_outputs!(preimages[17..20]), 281474976710653, dummy_key);
+               monitor.provide_latest_remote_commitment_tx_info(&dummy_tx, preimages_slice_to_htlc_outputs!(preimages[18..20]), 281474976710652, dummy_key);
                for &(ref preimage, ref hash) in preimages.iter() {
                        monitor.provide_payment_preimage(hash, preimage);
                }