]> git.bitcoin.ninja Git - rust-lightning/commit
Return a malformed HTLC message when ephemeral pubkey is garbage
authorMatt Corallo <git@bluematt.me>
Sun, 26 Aug 2018 20:35:26 +0000 (16:35 -0400)
committerMatt Corallo <git@bluematt.me>
Mon, 27 Aug 2018 15:47:11 +0000 (11:47 -0400)
commit42e908883f3a655270e0b442295a361d56e14b3b
tree3206e6762c35a91d483aea7c4c327604649ede72
parent4ca5bcf8cfc5cb3868974028b23ab7829c21426b
Return a malformed HTLC message when ephemeral pubkey is garbage

This resolves a spec-compliance bug with BOLT 4 where we simply
failed to deserialize the message and thus could never return an
HTLC failure message. However, note that BOLT 4 incorrectly hints
that a non-malformed message should be used ("...MUST report a
route failure to the origin node") which we cannot do as we cannot
derive a SharedSecret to encrypt a regular update_fail_htlc message
fuzz/Cargo.toml
fuzz/fuzz_targets/channel_target.rs
fuzz/fuzz_targets/msg_targets/gen_target.sh
fuzz/fuzz_targets/msg_targets/msg_update_add_htlc_target.rs [deleted file]
fuzz/fuzz_targets/msg_update_add_htlc_target.rs [new file with mode: 0644]
src/ln/channelmanager.rs
src/ln/msgs.rs