]> git.bitcoin.ninja Git - rust-lightning/commit
Use our actual feerate in open_channel messages, not a new one
authorValentine Wallace <vwallace@protonmail.com>
Sat, 13 Jun 2020 20:46:25 +0000 (16:46 -0400)
committerValentine Wallace <vwallace@protonmail.com>
Mon, 15 Jun 2020 22:22:33 +0000 (18:22 -0400)
commit4c655b2281383069e6ca27ba0faf640250d251c3
treeaaa3ce3c1e94e6dd120fe04318123ec973a1f81a
parentc1c9b1175bf6726c3a20d7da76fe6950ce55df66
Use our actual feerate in open_channel messages, not a new one

When we were sending an open_channel messages we were asking the
feerate estimator for a new value instead of using the one we had.
If the feerate estimator gave a different value than the one it did
when we created the Channel struct, we'd start out-of-sync with our
counterparty and blow up on funding_signed. Even worse, the
ConfirmationTarget used was different, so its highly likely they
would disagree.

Also remove newly unused fee estimator parameter from get_open-channel
API.

Co-authored-by: Matt Corallo <git@bluematt.me>
Co-authored-by: Valentine Wallace <vwallace@protonmail.com>
fuzz/src/full_stack.rs
lightning/src/ln/channel.rs
lightning/src/ln/channelmanager.rs