]> git.bitcoin.ninja Git - rust-lightning/commit
Rename `OpenChannelRequest::is_public` to `is_announced`
authorElias Rohrer <dev@tnull.de>
Tue, 20 Aug 2024 11:43:40 +0000 (13:43 +0200)
committerElias Rohrer <dev@tnull.de>
Wed, 21 Aug 2024 10:38:27 +0000 (12:38 +0200)
commitb9c73b176754f92acbadbaf35d10c02682eefd83
treeeed887c66bbfd86f8b507ddb4704938735095e63
parentbbfa15eb18faf4ca67986d7935d179c0526b1881
Rename `OpenChannelRequest::is_public` to `is_announced`

Referring to announced/unannounced channels as 'public'/'private'
regularly leads to confusion on what they are and when which should be
used. To avoid perpetuating this confusion, we should avoid referring to
announced channels as 'public' in our API.

Here we rename the recently introduced field in `OpenChannelRequest`
(which doesn't break released API), and will align the pre-existing
instances of `is_public` in the following commit (which will break API).
lightning/src/events/mod.rs
lightning/src/ln/channelmanager.rs