]> git.bitcoin.ninja Git - rust-lightning/commit
projects / rust-lightning / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: e48f8e3) | patch
Actually hold the total_consistency_lock instead of take-and-drop 2020-10-fix-big-lock
authorMatt Corallo <git@bluematt.me>
Fri, 2 Oct 2020 16:51:25 +0000 (12:51 -0400)
committerMatt Corallo <git@bluematt.me>
Fri, 2 Oct 2020 16:51:25 +0000 (12:51 -0400)
commitddebf36eaeef90684eb48ddab8db924b46ee74ac
treeb61ba397a23d2d9139e549f08c35b6d802dde93dtree | snapshot
parente48f8e3f33c7b7feadebb05f9241300f4e3b792bcommit | diff
Actually hold the total_consistency_lock instead of take-and-drop

It was noticed (via clippy) by @casey that we were taking and then
immediately dropping the total_consistency_lock because `let _ =`
doesn't actually bind the response to anything. This appears to be
a consequence of wanting `if let Some(_) =` to not hold a ref to
the contained value at all, but is relatively surprising to me.
lightning/src/ln/channelmanager.rs diff | blob | history
Personal fork of Rust-Lightning. Upstream is https://github.com/rust-bitcoin/rust-lightning