]> git.bitcoin.ninja Git - rust-lightning/commit
Remove check which makes us sometimes never send closing_signed 2018-12-closing_signed-3-leg-commitment
authorMatt Corallo <git@bluematt.me>
Tue, 27 Nov 2018 03:21:28 +0000 (22:21 -0500)
committerMatt Corallo <git@bluematt.me>
Mon, 3 Dec 2018 22:04:19 +0000 (17:04 -0500)
commita2df43d525322812a6081e5ae0a666ce79efc20b
tree4053ab7b095b3bcffccae595a227bb4fbf502230
parentdfbc6c60a73ee0f57fb899d414d2f385b5ab1308
Remove check which makes us sometimes never send closing_signed

This is the case pointed out by nayuta-gondo at
https://github.com/lightningnetwork/lightning-rfc/issues/499#issuecomment-438623208
though this doesn't actually solve the issue of ensuring we have a
consistent fee view when we start shutdown processing. There isn't
a clear solution to that however without adding additional state
tracking in Channel.

This also removes an associated test that tests for the correct
behavior (but didn't consider the bug) as we no longer behave
correctly. This should be fine as we'll be removing all the
update_fee garbage with option_simplified_commitment anyway.
src/ln/channel.rs
src/ln/channelmanager.rs