Fix `Route` serialization round-trip 2024-02-fix-route-ser-117-bindings
authorMatt Corallo <git@bluematt.me>
Fri, 16 Feb 2024 19:26:22 +0000 (19:26 +0000)
committerMatt Corallo <git@bluematt.me>
Fri, 16 Feb 2024 19:53:28 +0000 (19:53 +0000)
commit795000ce546107cfa67638ed3100ff79120ddb3c
tree7fbaccf3d1855f038b8c94c9334586e6fd9e2bd3
parentde72542a6b8c2ab56d598b1ae96a98733574ffb3
Fix `Route` serialization round-trip

When the `max_total_routing_fee_msat` parameter was added to
`RouteParameters`, the serialization used `map` to get the max fee,
accidentally writing an `Option<Option<u64>>`, but then read it as
an `Option<u64>`. Thus, any `Route`s with a `route_params` written
will fail to be read back.

Luckily, this is an incredibly rarely-used bit of code, so only one
user managed to hit it.
lightning/src/routing/router.rs