projects / rust-lightning / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 98398fe) | patch
Drop `amount_msats` from `InvoiceRequestFields` 2024-04-2970-followups
authorMatt Corallo <git@bluematt.me>
Thu, 25 Apr 2024 20:41:03 +0000 (20:41 +0000)
committerMatt Corallo <git@bluematt.me>
Thu, 25 Apr 2024 20:47:43 +0000 (20:47 +0000)
commit90c919c4a7da629174f92aab1f495d27512de2a3
tree62f916463a7cf408865eec7d6c45ad6e13089417tree | snapshot
parent98398fe4e481b1b57e5d62741d5c5882a12ca7becommit | diff
Drop `amount_msats` from `InvoiceRequestFields`

An `InvoiceRequest` can overpay for an `Offer` which would be
reflected back to the recipient via the `amount_msats` field, but
its somewhat deceptive as the sender can *also* then further
overpay in the HTLC(s) themselves. The total overpayment is already
communicated in the `Event::ClaimablePayment` so we simply drop the
`InvoiceRequestFields` field here.

Fixes #3002
lightning/src/ln/offers_tests.rs diff | blob | history
lightning/src/offers/invoice_request.rs diff | blob | history
Personal fork of Rust-Lightning. Upstream is https://github.com/rust-bitcoin/rust-lightning