Remove superfluous commitment_number parameter.
authorArik Sosman <git@arik.io>
Wed, 29 Nov 2023 00:11:15 +0000 (16:11 -0800)
committerArik Sosman <git@arik.io>
Wed, 29 Nov 2023 00:11:15 +0000 (16:11 -0800)
lightning/src/sign/mod.rs
lightning/src/sign/taproot.rs
lightning/src/util/test_channel_signer.rs

index d8f71f590534555988d5f06d4a9757b70baa4f8c..65457d27dbc1e42c6f293c027ce25f6595d1e87e 100644 (file)
@@ -1258,7 +1258,7 @@ impl TaprootChannelSigner for InMemorySigner {
                todo!()
        }
 
-       fn finalize_holder_commitment(&self, commitment_number: u64, commitment_tx: &HolderCommitmentTransaction, counterparty_partial_signature: PartialSignatureWithNonce, secp_ctx: &Secp256k1<All>) -> Result<PartialSignature, ()> {
+       fn finalize_holder_commitment(&self, commitment_tx: &HolderCommitmentTransaction, counterparty_partial_signature: PartialSignatureWithNonce, secp_ctx: &Secp256k1<All>) -> Result<PartialSignature, ()> {
                todo!()
        }
 
index 0028a0cd12bb4e111aa04da29aa6d36788b3a404..f2d3f62831374a5091d55a9825f46e494f66e459 100644 (file)
@@ -51,8 +51,7 @@ pub trait TaprootChannelSigner: ChannelSigner {
        /// An external signer implementation should check that the commitment has not been revoked.
        ///
        // TODO: Document the things someone using this interface should enforce before signing.
-       fn finalize_holder_commitment(&self, commitment_number: u64,
-               commitment_tx: &HolderCommitmentTransaction,
+       fn finalize_holder_commitment(&self, commitment_tx: &HolderCommitmentTransaction,
                counterparty_partial_signature: PartialSignatureWithNonce,
                secp_ctx: &Secp256k1<secp256k1::All>
        ) -> Result<PartialSignature, ()>;
index ccdcfdd09346123cab89ecc56857c7f82a7337fc..0e3890f54de518340f9dabb5c695b9c558e17c30 100644 (file)
@@ -292,7 +292,7 @@ impl TaprootChannelSigner for TestChannelSigner {
                todo!()
        }
 
-       fn finalize_holder_commitment(&self, commitment_number: u64, commitment_tx: &HolderCommitmentTransaction, counterparty_partial_signature: PartialSignatureWithNonce, secp_ctx: &Secp256k1<All>) -> Result<PartialSignature, ()> {
+       fn finalize_holder_commitment(&self, commitment_tx: &HolderCommitmentTransaction, counterparty_partial_signature: PartialSignatureWithNonce, secp_ctx: &Secp256k1<All>) -> Result<PartialSignature, ()> {
                todo!()
        }