Bump MSRV to 1.30.0

We wanted to bump to 1.29 to continue to support mrustc bootstrapping, but on 1.29
there's a bug preventing us from compiling the lightning package only, thus parts
of lightning-net-tokio cause a compilation error.

The advantage of bumping the MSRV is an improved borrow checker which should
enable improved code quality, and not having jump through weird hoops sometimes
to get 1.22 working.

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index eb397230f370bace586e9810f632cd273d2f46b2..9a24b15cc514512b16309b04e4c284bddea2142a 100644 (file)
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -8,8 +8,8 @@ jobs:
       matrix:
         toolchain: [ stable,
                      beta,
-                     # 1.22.0 is MSRV for rust-lightning in general:
-                     1.22.0,
+                     # 1.30.0 is MSRV for Rust-Lightning
+                     1.30.0,
                      # 1.34.2 is Debian stable
                      1.34.2,
                      # 1.39.0 is MSRV for lightning-net-tokio and generates coverage

diff --git a/.travis.yml b/.travis.yml
index 0c36806c63c059869d44f3e56082340cbf03eca6..1e136798133cc40e172fe9aa57ec1738b90ee851 100644 (file)
--- a/.travis.yml
+++ b/.travis.yml
@@ -2,8 +2,8 @@ language: rust
 rust:
   - stable
   - beta
-  # 1.22.0 is MSRV for rust-lightning in general:
-  - 1.22.0
+  # 1.30.0 is MSRV for rust-lightning in general:
+  - 1.30.0
   # 1.34.2 is Debian stable
   - 1.34.2
   # 1.39.0 is MSRV for lightning-net-tokio and generates coverage

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 7a0c71f407a912aa31ef8a8fdbcae8fef911dc81..0b6e07acfd734a648bef59fb56fec669d9df9986 100644 (file)
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -50,7 +50,8 @@ be covered by functional tests.
 When refactoring, structure your PR to make it easy to review and don't
 hestitate to split it into multiple small, focused PRs.
 
-The Minimal Supported Rust Version is 1.22.0 (enforced by our Travis).
+The Minimal Supported Rust Version is 1.30.0 (enforced by our Travis and
+GitHub Actions).
 
 Commits should cover both the issue fixed and the solution's rationale.
 These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind.