]> git.bitcoin.ninja Git - rust-lightning/commitdiff
Fix fuzztarget insert_combine hash-collision panic
authorMatt Corallo <git@bluematt.me>
Thu, 2 Aug 2018 10:32:11 +0000 (06:32 -0400)
committerMatt Corallo <git@bluematt.me>
Fri, 3 Aug 2018 02:26:44 +0000 (22:26 -0400)
src/ln/channelmonitor.rs

index ae8f4f4a668f2ca007b2e03394a26725fe827d78..ffc9ed26fdaa60a0f81375ce88588f2f4aa8f18d 100644 (file)
@@ -423,7 +423,9 @@ impl ChannelMonitor {
 
        pub fn insert_combine(&mut self, mut other: ChannelMonitor) -> Result<(), HandleError> {
                if self.funding_txo.is_some() {
-                       if other.funding_txo.is_some() && other.funding_txo.as_ref().unwrap() != self.funding_txo.as_ref().unwrap() {
+                       // We should be able to compare the entire funding_txo, but in fuzztarget its trivially
+                       // easy to collide the funding_txo hash and have a different scriptPubKey.
+                       if other.funding_txo.is_some() && other.funding_txo.as_ref().unwrap().0 != self.funding_txo.as_ref().unwrap().0 {
                                return Err(HandleError{err: "Funding transaction outputs are not identical!", action: None});
                        }
                } else {