Merge pull request #3264 from jkczyz/2024-08-remove-user-provided-payer-id

Disallow user-provided `payer_signing_pubkey`

diff --cc lightning/src/ln/blinded_payment_tests.rs
Simple merge

diff --cc lightning/src/ln/channelmanager.rs
Simple merge

diff --cc lightning/src/ln/outbound_payment.rs
Simple merge

diff --cc lightning/src/offers/invoice.rs
index e7e4596901ba0f618939f30cb9e171b635a1f1fa,59100f4cf49318775d94f4f681d4d4426242277c..3539d0f81d1ded777924237a08bfea01309ae609
--- 1/lightning/src/offers/invoice.rs
--- 2/lightning/src/offers/invoice.rs
+++ b/lightning/src/offers/invoice.rs
@@@ -1763,10 -1772,9 +1772,10 @@@ mod tests 
                                        amount: None,
                                        features: None,
                                        quantity: None,
-                                       payer_id: Some(&payer_pubkey()),
+                                       payer_id: Some(&invoice.payer_signing_pubkey()),
                                        payer_note: None,
                                        paths: None,
 +                                      offer_from_hrn: None,
                                },
                                InvoiceTlvStreamRef {
                                        paths: Some(Iterable(payment_paths.iter().map(|path| path.inner_blinded_path()))),

diff --cc lightning/src/offers/invoice_request.rs
index f7f1c228779fa80b96c3dfb10a9cd6560e03d258,0e6ebb8cc01abfe02ab41464905f87f812c15b66..2594c056f05b7b0c75e55cc02f5aff746ad69e80
--- 1/lightning/src/offers/invoice_request.rs
--- 2/lightning/src/offers/invoice_request.rs
+++ b/lightning/src/offers/invoice_request.rs
@@@ -1511,10 -1387,9 +1417,10 @@@ mod tests 
                                        amount: None,
                                        features: None,
                                        quantity: None,
-                                       payer_id: Some(&payer_pubkey()),
+                                       payer_id: Some(&invoice_request.payer_signing_pubkey()),
                                        payer_note: None,
                                        paths: None,
 +                                      offer_from_hrn: None,
                                },
                                SignatureTlvStreamRef { signature: Some(&invoice_request.signature()) },
                                ExperimentalOfferTlvStreamRef {
@@@ -2737,10 -2565,9 +2596,10 @@@
                                assert_eq!(
                                        fields,
                                        InvoiceRequestFields {
-                                               payer_signing_pubkey: payer_pubkey(),
+                                               payer_signing_pubkey: invoice_request.payer_signing_pubkey(),
                                                quantity: Some(1),
                                                payer_note_truncated: Some(UntrustedString("0".repeat(PAYER_NOTE_LIMIT))),
 +                                              human_readable_name: None,
                                        }
                                );