[test] Demonstrate that the next commit is trivially safe

See comment in the code. This commit exists only to aid reviewers.

diff --git a/lightning/src/ln/functional_test_utils.rs b/lightning/src/ln/functional_test_utils.rs
index 90ca0052eec271aa92d9045f62fc6f219a09bf53..564e63996c4380a34dfbc79ea50ebe7b96b1032f 100644 (file)
--- a/lightning/src/ln/functional_test_utils.rs
+++ b/lightning/src/ln/functional_test_utils.rs
@@ -83,6 +83,12 @@ pub fn confirm_transaction_at<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, tx: &T
 }
 
 pub fn connect_blocks<'a, 'b, 'c, 'd>(node: &'a Node<'b, 'c, 'd>, depth: u32, height: u32, parent: bool, prev_blockhash: BlockHash) -> BlockHash {
+       // The next commit drops the height, parent, and prev_blockhash parameters. In order to
+       // demonstrate that they are currently unused, we assert that they always match the new default
+       // parameters here.
+       if parent { assert_eq!(prev_blockhash, node.best_block_hash()); }
+       assert_eq!(node.best_block_info().1, height);
+
        let mut block = Block {
                header: BlockHeader { version: 0x2000000, prev_blockhash: if parent { prev_blockhash } else { node.best_block_hash() }, merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 },
                txdata: vec![],