]> git.bitcoin.ninja Git - rust-lightning/commitdiff
Fail linter on #[warn(clippy::try_err)]
authorJeffrey Czyz <jkczyz@gmail.com>
Mon, 2 Aug 2021 15:30:01 +0000 (10:30 -0500)
committerJeffrey Czyz <jkczyz@gmail.com>
Mon, 2 Aug 2021 15:32:02 +0000 (10:32 -0500)
Some heavily used macros are using ? directly on an Err. Using a return
is easier to read and removes hundreds of linter warnings.

https://rust-lang.github.io/rust-clippy/master/index.html#try_err

.github/workflows/build.yml

index 5b886e19bff5d440cdabb8441b4e4a9d17077fdb..100fbdfcff6c66814b8c847d737c4a87a8c4ceb8 100644 (file)
@@ -262,4 +262,4 @@ jobs:
           rustup component add clippy
       - name: Run default clippy linting
         run: |
-          cargo clippy -- -Aclippy::erasing_op -Aclippy::never_loop -Aclippy::if_same_then_else
+          cargo clippy -- -Aclippy::erasing_op -Aclippy::never_loop -Aclippy::if_same_then_else -Dclippy::try_err