]> git.bitcoin.ninja Git - rust-lightning/commitdiff
Check that we aren't reading a second message in BOLT 12 retry test
authorMatt Corallo <git@bluematt.me>
Thu, 12 Sep 2024 15:13:11 +0000 (15:13 +0000)
committerMatt Corallo <git@bluematt.me>
Mon, 30 Sep 2024 18:57:52 +0000 (18:57 +0000)
`creates_and_pays_for_offer_with_retry` intends to check that we
re-send a BOLT 12 `invoice_request` in response to a
`message_received` call, but doesn't actually test that there were
no messages in the outbound buffer after the initial send, which we
do here.

lightning/src/ln/offers_tests.rs

index 3b9317e4674a85b09b3a23a17e745bf7eff1f33f..dd7ce4afb290f9fdfdf8da154192824f791d14ed 100644 (file)
@@ -1100,6 +1100,7 @@ fn creates_and_pays_for_offer_with_retry() {
        expect_recent_payment!(bob, RecentPaymentDetails::AwaitingInvoice, payment_id);
 
        let _lost_onion_message = bob.onion_messenger.next_onion_message_for_peer(alice_id).unwrap();
+       assert!(bob.onion_messenger.next_onion_message_for_peer(alice_id).is_none());
 
        // Simulate a scenario where the original onion_message is lost before reaching Alice.
        // Use handle_message_received to regenerate the message.