Merge pull request #738 from TheBlueMatt/2020-10-opt-test

Fix passing -O1 to build from `cargo test`

diff --git a/Cargo.toml b/Cargo.toml
index 03d58b202cf39ea5526d683711cff464e04b1c10..56f4ac32f3f629c3553adb07114e21370ee1c80b 100644 (file)
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -5,11 +5,13 @@ members = [
     "lightning-net-tokio",
 ]
 
-# Our tests do actual crypo and lots of work, the tradeoff for -O1 is well worth it
-[profile.test]
-opt-level = 1
-
+# Our tests do actual crypo and lots of work, the tradeoff for -O1 is well worth it.
+# Ideally we would only do this in profile.test, but profile.test only applies to
+# the test binary, not dependencies, which means most of the critical code still
+# gets compiled as -O0. See
+# https://doc.rust-lang.org/cargo/reference/profiles.html#profile-selection
 [profile.dev]
+opt-level = 1
 panic = "abort"
 
 [profile.release]