]> git.bitcoin.ninja Git - rust-lightning/commitdiff
Correct `get_claimable_balance` version info 2022-09-bad-doc-versions
authorMatt Corallo <git@bluematt.me>
Fri, 9 Sep 2022 19:30:30 +0000 (19:30 +0000)
committerMatt Corallo <git@bluematt.me>
Fri, 9 Sep 2022 19:30:30 +0000 (19:30 +0000)
5a8ede09fb3c8bbcd8694d94c12dac9ea7485537 updated the documentation
on `get_claimable_balance` to note that if a channel went on-chain
with an LDK version older than 0.0.108 some
counterparty-revoked-output claimable balances my be missing.
However, this failed to account for the fact that we rely on the
entirely-new-in-0.0.111
`confirmed_commitment_tx_counterparty_output` field for some
balances as well.

Thus, the comment should have been in terms of 0.0.111, not
0.0.108.

lightning/src/chain/channelmonitor.rs

index ed84750590a1c95ac220ce9408c40135b5aca0ec..e79e50172f9f3f1c5c8a2e98d378f118e6841001 100644 (file)
@@ -1630,7 +1630,7 @@ impl<Signer: Sign> ChannelMonitor<Signer> {
        /// confirmations on the claim transaction.
        ///
        /// Note that for `ChannelMonitors` which track a channel which went on-chain with versions of
-       /// LDK prior to 0.0.108, balances may not be fully captured if our counterparty broadcasted
+       /// LDK prior to 0.0.111, balances may not be fully captured if our counterparty broadcasted
        /// a revoked state.
        ///
        /// See [`Balance`] for additional details on the types of claimable balances which