]> git.bitcoin.ninja Git - rust-lightning/commitdiff
Correct async `lightning-background-processor` exit check docs 2022-11-fix-bp-exit-docs
authorMatt Corallo <git@bluematt.me>
Wed, 9 Nov 2022 17:35:26 +0000 (17:35 +0000)
committerMatt Corallo <git@bluematt.me>
Wed, 9 Nov 2022 18:39:51 +0000 (18:39 +0000)
The check to stop the background processor is true -> break, not
false -> break. This simply updates the docs and leaves the code
as-is.

lightning-background-processor/src/lib.rs

index 27cd0663e3291f27e385787d99769553c012de80..10bcc9bd6e28dc0cb80c12f25853b160d6be89d6 100644 (file)
@@ -358,8 +358,8 @@ macro_rules! define_run_body {
 /// Processes background events in a future.
 ///
 /// `sleeper` should return a future which completes in the given amount of time and returns a
-/// boolean indicating whether the background processing should continue. Once `sleeper` returns a
-/// future which outputs false, the loop will exit and this function's future will complete.
+/// boolean indicating whether the background processing should exit. Once `sleeper` returns a
+/// future which outputs true, the loop will exit and this function's future will complete.
 ///
 /// See [`BackgroundProcessor::start`] for information on which actions this handles.
 #[cfg(feature = "futures")]
@@ -411,13 +411,13 @@ where
        UMH::Target: 'static + CustomMessageHandler,
        PS::Target: 'static + Persister<'a, Signer, CW, T, K, F, L, SC>,
 {
-       let mut should_continue = true;
+       let mut should_break = true;
        define_run_body!(persister, event_handler, chain_monitor, channel_manager,
-               gossip_sync, peer_manager, logger, scorer, should_continue, {
+               gossip_sync, peer_manager, logger, scorer, should_break, {
                        select_biased! {
                                _ = channel_manager.get_persistable_update_future().fuse() => true,
-                               cont = sleeper(Duration::from_millis(100)).fuse() => {
-                                       should_continue = cont;
+                               exit = sleeper(Duration::from_millis(100)).fuse() => {
+                                       should_break = exit;
                                        false
                                }
                        }