Matt Corallo [Fri, 29 Sep 2023 21:06:55 +0000 (21:06 +0000)]
Merge pull request #2622 from wpaulino/funding-and-commitment-tx-confirm-same-block
Avoid early return upon confirmation of channel funding
Matt Corallo [Fri, 29 Sep 2023 21:06:41 +0000 (21:06 +0000)]
Merge pull request #2626 from TheBlueMatt/2023-09-revert-2476
Revert "Remove AvailableBalances::balance_msat"
Wilmer Paulino [Thu, 28 Sep 2023 16:07:10 +0000 (09:07 -0700)]
Fix off-by-one max witness estimate for P2WPKH StaticPaymentDescriptor
We were not accounting for the extra byte denoting the number of items
in the witness stack.
Wilmer Paulino [Mon, 25 Sep 2023 23:55:22 +0000 (16:55 -0700)]
Support signing to_remote anchors variant for StaticPaymentOutput
`to_remote` outputs on commitment transactions with anchor outputs have
an additional `1 CSV` constraint on its spending condition,
transitioning away from the previous P2WPKH script to a P2WSH.
Since our `ChannelMonitor` was never updated to track the proper
`to_remote` script on anchor outputs channels, we also missed updating
our signer to handle the new script changes.
Wilmer Paulino [Mon, 25 Sep 2023 23:53:42 +0000 (16:53 -0700)]
Use correct to_remote script in counterparty commitments
While our commitment transactions did use the correct `to_remote`
script, the `ChannelMonitor`'s was not as it is tracked separately. This
would lead to users never receiving an `Event::SpendableOutputs` with a
`StaticPaymentOutput` descriptor to claim the funds.
Luckily, any users affected which had channel closures confirmed by a
counterparty commitment just need to replay the closing transaction to
receive the event.
Matt Corallo [Fri, 29 Sep 2023 20:07:16 +0000 (20:07 +0000)]
Merge pull request #2624 from wpaulino/2609-follow-up
Address 2609 follow-up comments
Willem Van Lint [Fri, 29 Sep 2023 19:06:36 +0000 (12:06 -0700)]
Fix handling multiple ShutdownResults
Matt Corallo [Fri, 29 Sep 2023 18:53:44 +0000 (18:53 +0000)]
Merge pull request #2623 from wpaulino/htlc-claim-receive-preimage-after-close
Claim HTLCs with preimage from currently confirmed commitment
Wilmer Paulino [Fri, 22 Sep 2023 17:39:10 +0000 (10:39 -0700)]
Avoid early return upon confirmation of channel funding
This early return is only possible if the channel requires a single
confirmation, allowing a `channel_ready` message to go out. This can be
problematic though if a commitment transaction (specifically from the
counterparty, as the channel would be immediately closed if a local
commitment is broadcast) also confirms within the same block. The
`ChannelMonitor` will detect both, but it won't inform the
`ChannelManager` at all. Luckily, while the channel still is considered
open to the `ChannelManager`, the `ChannelMonitor` will reject any
further updates to the channel state.
Matt Corallo [Fri, 29 Sep 2023 18:32:25 +0000 (18:32 +0000)]
Revert "Remove AvailableBalances::balance_msat"
While removing the `balance_msat` field absolutely makes sense -
it is, at best, confusing - we really need a solid replacement for
it before we can do so. While one such replacement is in progress,
it is not complete and we'd like to not block our current release
on its completion.
This reverts commit
ef5be580f51d6756612fea710516c0297203f4dc.
Elias Rohrer [Fri, 29 Sep 2023 14:44:20 +0000 (16:44 +0200)]
Test we consider route hints if we are the src of the first hop
Previously, we would only consider route hints if the entry point was
in our first hops or in the network graph. We fixed this by also
considering hints if our own node ID was the first src.
Here, we add test coverage for this behavior.
Elias Rohrer [Fri, 29 Sep 2023 14:09:44 +0000 (16:09 +0200)]
Test we prefer first hops over route hints
We previously added logic that would avoid adding superflous candidates
for route hints if we detect that we have a first hop for this channel.
Here we add test coverage that we actually prefer the first hop over the
route hint, but still consider the remaining hints.
Wilmer Paulino [Fri, 29 Sep 2023 16:40:34 +0000 (09:40 -0700)]
Only yield DelayedPaymentOutput descriptors once their delay expires
Otherwise, we could give users a descriptor ahead of time that will
result in an invalid transaction spend/broadcast.
Matt Corallo [Fri, 29 Sep 2023 17:39:49 +0000 (17:39 +0000)]
Merge pull request #2617 from wpaulino/no-persist-same-channel-update
Avoid persisting on same counterparty's ChannelUpdate
Elias Rohrer [Fri, 29 Sep 2023 17:08:36 +0000 (19:08 +0200)]
Merge pull request #2591 from TheBlueMatt/2023-09-2562-followups
Doc and comment followups to #2562
Wilmer Paulino [Fri, 29 Sep 2023 16:16:48 +0000 (09:16 -0700)]
Note required levels of descendant transactions in get_spendable_outputs
Three levels of descendant transactions starting from the channel's
funding transaction should cover all potential spendable outputs.
The first level covers the commitment transaction.
The second level covers the to_self claims, to_remote claims,
second-stage HTLC claims and justice transactions.
The third levels covers the justice transactions on second-stage HTLCs,
and to_self claims on second-stage HTLCs.
Wilmer Paulino [Mon, 14 Aug 2023 19:12:54 +0000 (12:12 -0700)]
Test preimage claim after reorg of counterparty commitment
This test adds coverage for receiving a preimage after seeing a
counterparty commitment confirm, followed by a reorg and the
confirmation of a different commitment instead.
The first test covers the case where a holder commitment confirms after
the counterparty commitment reorg.
The second test covers the case where a previous counterparty commitment
confirms after the latest counterparty commitment reorg.
Wilmer Paulino [Fri, 28 Jul 2023 22:32:29 +0000 (15:32 -0700)]
Claim HTLCs with preimage from currently confirmed commitment
We should always claim HTLCs from the currently confirmed commitment,
rather than always claiming from the latest or previous counterparty
commitment if we've seen either confirm onchain at a prior point.
Wilmer Paulino [Thu, 28 Sep 2023 23:02:25 +0000 (16:02 -0700)]
Avoid persisting on same counterparty's ChannelUpdate
Some nodes may rebroadcast their `ChannelUpdate` to their counterparty
on every connection establishment, which leads to us doing an additional
persist most of the time when nothing has changed. Now, we'll only
persist if we receive an update that changes anything.
Elias Rohrer [Fri, 29 Sep 2023 06:53:19 +0000 (08:53 +0200)]
Assert equality of route params in tests
Previously we only asserted the `final_value_msat` matches. Looking at
it again we can _of course_ assert the full equality of looked-for and
included route params after all (duh, not sure what I was thinking...).
This cleans up the prior misunderstanding and fixes a bunch of tests
that would now fail otherwise.
Matt Corallo [Fri, 29 Sep 2023 01:29:47 +0000 (01:29 +0000)]
Merge pull request #2609 from wpaulino/monitor-get-spendable-output
Allow retrieval of SpendableOutputDescriptors from relevant transactions
Matt Corallo [Fri, 29 Sep 2023 00:19:04 +0000 (00:19 +0000)]
Merge pull request #2604 from TheBlueMatt/2023-09-route-overpay-limit
Try to overpay the recipient if we fail to find a path at all and limit overpay
Wilmer Paulino [Thu, 28 Sep 2023 18:42:13 +0000 (11:42 -0700)]
Retrieve all possible spendable outputs from transactions
Assuming our keys haven't been compromised, and that random transactions
aren't learning of these scripts somehow and sending funds to them, it
was only possible for one spendable output to exist within a
transaction.
- `shutdown_script` can only exist in co-op close transactions.
- `counterparty_payment_script` can only exist in counterparty
commitment transactions.
- `broadcasted_holder_revokable_script` can only exist in holder
commitment/HTLC transactions.
- `destination_script` can exist in any other type of claim we support.
Now that we're exposing this API to users such that they can rescan any
relevant transactions, there's no harm in allowing them to claim more
funds from spendable outputs than we expected.
Wilmer Paulino [Wed, 27 Sep 2023 17:27:44 +0000 (10:27 -0700)]
Allow retrieval of SpendableOutputDescriptors from relevant transactions
Currently, our API will only expose `SpendableOutputDescriptor`s once
after they are no longer under reorg risk (see `ANTI_REORG_DELAY`).
Users have often requested they'd like the ability to retrieve these in
some other way, either for historical purposes, or to handle replaying
any in the event of a failure.
Matt Corallo [Thu, 28 Sep 2023 20:45:27 +0000 (20:45 +0000)]
Add more details about async persistence completion/backgrounding
This clarifies somewhat that async persistence should run
indefinitely or keep trying via polling, and that either is
acceptable.
Matt Corallo [Thu, 28 Sep 2023 17:51:05 +0000 (17:51 +0000)]
Log max routing fee before we start pathfinding
This may be useful in debugging routing failures in the future.
Matt Corallo [Thu, 28 Sep 2023 18:19:36 +0000 (18:19 +0000)]
Include any recipient overpayment amounts in the route fee limit
If the user told us to limit their total fee exposure, we should
do so including any potential overpayment to the recipient, which
is ultimately a part of the "fee" as far as the user is concerned.
Matt Corallo [Tue, 26 Sep 2023 21:58:53 +0000 (21:58 +0000)]
Try to overpay the recipient if we fail to find a path at all
Previously we'd only try to overpay if we managed to find a path
to the recipient which was sufficient. However, if we fail to find
any path to the recipient at all we should still retry overpaying
the recipient. Ultimately we should be silling to pay whatever
reasonable performance penalty if the alternative is not finding a
path at all, which we do here.
Matt Corallo [Thu, 28 Sep 2023 18:19:50 +0000 (18:19 +0000)]
Allow routefinding again due to HTLC limit based on >= not >
While this doesn't matter much in practice, if we go around again
when route-finding to try to meet an htlc_minimum_msat, we use the
`recommended_value_msat` which can work if we meet the
`htlc_minimum_msat` on a channel exactly, so using >= rather than >
can capture cases with 1msat more.
Matt Corallo [Thu, 28 Sep 2023 20:37:54 +0000 (20:37 +0000)]
Merge pull request #2612 from TheBlueMatt/2023-09-namespace-split
Refer to top-level persistence namespaces as primary_namespace
Matt Corallo [Thu, 28 Sep 2023 20:30:29 +0000 (20:30 +0000)]
Merge pull request #2575 from tnull/2023-09-fix-debug-panic
Various router fixes and #2417 follow-ups
Matt Corallo [Thu, 28 Sep 2023 19:06:24 +0000 (19:06 +0000)]
Merge pull request #2611 from TheBlueMatt/2023-09-no-close-on-bad-update
Don't FC when a `channel_update` has a bogus `htlc_minimum_msat`
Matt Corallo [Thu, 28 Sep 2023 17:28:04 +0000 (17:28 +0000)]
Update remaining references to primary/secondary namespaces
Update various variables, error strings, and the pending changelog
entry to refer to new namespace terminology.
Matt Corallo [Thu, 28 Sep 2023 17:06:20 +0000 (17:06 +0000)]
Update storage constants to new PRIMARY/SECONDARY namespace terms
Matt Corallo [Thu, 28 Sep 2023 16:36:52 +0000 (16:36 +0000)]
Rename the persistence `sub_namespace` to `secondary_namespace`
With the top-level namespace now called "primary", "secondary"
makes more sense than "sub".
Elias Rohrer [Wed, 27 Sep 2023 10:43:31 +0000 (12:43 +0200)]
Don't retry overpaid values for `PartialFailure`s
Previously, if an overpaid path would fail immediately, we'd retry a
`PartialFailure` with the full path amount, _including_ any overpayment.
Here, we now subtract the succeeded paths' values from the
net. value to exclude the overpaid amounts on retry.
Elias Rohrer [Thu, 28 Sep 2023 08:04:35 +0000 (10:04 +0200)]
Assert query's and route's `final_value_msat` are equal
Elias Rohrer [Wed, 27 Sep 2023 07:57:20 +0000 (09:57 +0200)]
Refactor `mpp_retry[_overpay]` tests to use `SendEvent::from_event`
.. as a follow-up from #2417.
Elias Rohrer [Wed, 27 Sep 2023 07:28:43 +0000 (09:28 +0200)]
Make ignored candidate counts `u32`
.. as a follow-up from #2417.
Elias Rohrer [Fri, 22 Sep 2023 14:38:30 +0000 (16:38 +0200)]
Avoid adding duplicate hint candidates if they are first hops
If we have a direct channel to a node generating an invoice with route
hints, we'd previously happily add multiple candidates that all refer to
the same channel. To keep our candidate set small and unify our tracking
where possible, we now check if its `short_channel_id` is an
`outbound_scid_alias` of any of our first hops and refrain from adding
another candidate if it's the case.
Elias Rohrer [Fri, 22 Sep 2023 13:56:07 +0000 (15:56 +0200)]
Also add route hints if we are the source
Previously, we would only consider route hints if we had a direct
channel to the first node in the hint or if the first node in the hint
was part of the public network graph.
However, this left out the possiblity of us being part of the first hop,
especially if our own node is not announced and part of the graph.
Matt Corallo [Thu, 28 Sep 2023 16:54:44 +0000 (16:54 +0000)]
Merge pull request #2607 from DhananjayPurohit/civkit-branch
Issue in adding rust lightning as dependency on windows
Matt Corallo [Thu, 28 Sep 2023 16:32:18 +0000 (16:32 +0000)]
Merge pull request #2606 from wpaulino/anchors-counterparty-htlc-claim-sequence
Use correct input sequence for HTLC claims from counterparty commitments
Matt Corallo [Thu, 28 Sep 2023 16:30:02 +0000 (16:30 +0000)]
Log full channel_update messages received for our channels
Elias Rohrer [Fri, 22 Sep 2023 13:00:43 +0000 (15:00 +0200)]
Extend logging of ignored candidates
Elias Rohrer [Thu, 14 Sep 2023 12:14:03 +0000 (14:14 +0200)]
Use `saturating_add` when adding inflight HTLCs values
Previously this calculation could overflow, leading to panicking in `debug`.
DhananjayPurohit [Tue, 26 Sep 2023 09:24:00 +0000 (14:54 +0530)]
chore: remove time_utils.rs
No longer needed time_utils in lightning-invoice
Matt Corallo [Thu, 28 Sep 2023 02:40:07 +0000 (02:40 +0000)]
Refer to top-level persistence namespaces as `primary_namespace`
This fixes a bindings build error as `namespace` is a C++ keyword
which cannot be used as an argument, and while this could be fixed
in the bindings rather than here, separating the term `namespace`
between the concept (which refers to the primary and sub
namespaces) and the primary namespace makes the documentation more
readable.
Matt Corallo [Wed, 27 Sep 2023 22:26:57 +0000 (22:26 +0000)]
Use `Result<_, io::Error>` over `io::Result<_>`
Personally I've always found the overload of a prelude enum to be
confusing, and never bothered to handle it properly in bindings as
a result. To avoid needing to do so now, we simply move the
newly-introduced `io::Result` usages over to
`Result<_, io::Error>`.
Matt Corallo [Thu, 28 Sep 2023 00:46:31 +0000 (00:46 +0000)]
Don't FC when a `channel_update` has a bogus `htlc_minimum_msat`
If a peer sends us a `channel_update` for our own channel with an
`htlc_minimum_msat` which is more than the channel's amount, that's
dumb, but there's no reason to force-close the channel. We don't
even use the field.
Here we simply drop the unnecessary check.
Matt Corallo [Wed, 27 Sep 2023 20:40:32 +0000 (20:40 +0000)]
Merge pull request #2570 from valentinewallace/2023-08-router-fuzz-fail
Fix router fuzz failure
Wilmer Paulino [Mon, 25 Sep 2023 23:57:04 +0000 (16:57 -0700)]
Use correct input sequence for HTLC claims from counterparty commitments
HTLC outputs, like the `to_remote` output, in commitment transactions
with anchor outputs also have an additional `1 CSV` constraint on the
counterparty. When spending such outputs, their corresponding input
needs to have their sequence set to 1. This was done for HTLC claims
from holder commitments, but unfortunately not for counterparty
commitments as we were lacking test coverage.
Valentine Wallace [Wed, 27 Sep 2023 03:44:27 +0000 (23:44 -0400)]
get_route: fix path value contribution to include min htlc overpay
Previously, the fuzzer hit a debug panic because we wouldn't include the amount
overpaid to meet a last hop's min_htlc in the total collected paths value. We
now include this value and also penalize hops along the overpaying path to
ensure that it gets deprioritized in path selection.
Valentine Wallace [Wed, 27 Sep 2023 02:21:15 +0000 (22:21 -0400)]
get_route: fix path_min for first_hop<>network_node candidates
Previously, we would add a first_hop<>network_node channel that did not have
enough contribution amount to cover the next channel's min htlc plus fees,
because we were storing the next hop as having a path_min that did not include
fees, and would add a connecting first_hop node that did not have enough
contribution amount, leading to a debug panic upon invalid path construction.
Valentine Wallace [Tue, 26 Sep 2023 22:57:02 +0000 (18:57 -0400)]
get_route: fix path_min for first_hop<>blinded_hint candidates
See previous commit, but the bug where we would underestimate how much a first
hop candidate needed to be able to relay was also present in blinded paths.
Valentine Wallace [Wed, 27 Sep 2023 01:19:33 +0000 (21:19 -0400)]
get_route: fix path_min when adding first_hop<>route_hint candidates
Previously, we would add a candidate hop to the list of potential hops even
though its available contribution wasn't sufficient to meet the next hop's
min_htlc. We'd subsequently build an invalid path using this hop and hit a
debug assertion.
Valentine Wallace [Fri, 22 Sep 2023 20:13:36 +0000 (16:13 -0400)]
get_route: fix outdated var name
Previously this variable was a bool, but has since been updated to be an
Option, so rename accordingly.
Valentine Wallace [Tue, 12 Sep 2023 18:57:59 +0000 (14:57 -0400)]
Pathfinding: ignore blinded route hints where we are the intro node
See tests, but the fuzzer found several panics from not fully ignoring these
hints.
We should support these route hints eventually, but it will involve some
reworking of the Path/BlindedTail structs.
Valentine Wallace [Tue, 12 Sep 2023 19:01:53 +0000 (15:01 -0400)]
Remove trailing whitespace in get_route
Because my text editor loves to do that.
Valentine Wallace [Tue, 12 Sep 2023 18:56:54 +0000 (14:56 -0400)]
Refuse to pathfind when provided our_node_id matches internal dummy pk
The fuzzer managed to hit this and it causes some invalid paths to be generated
internally.
Valentine Wallace [Tue, 12 Sep 2023 18:55:36 +0000 (14:55 -0400)]
Pathfinding: log when we ignore one hop blinded route hints
Matt Corallo [Wed, 27 Sep 2023 03:51:12 +0000 (03:51 +0000)]
Merge pull request #2601 from TheBlueMatt/2023-09-117-alpha2
Bump versions to 0.0.117-alpha2/invoice 0.25.0-alpha2
Matt Corallo [Wed, 27 Sep 2023 03:47:16 +0000 (03:47 +0000)]
Merge pull request #2603 from TheBlueMatt/2023-09-default-route-limit
Set a default max_total_routing_fee_msat of 1% + 50sats
Matt Corallo [Wed, 27 Sep 2023 03:47:09 +0000 (03:47 +0000)]
Merge pull request #2602 from TheBlueMatt/2023-09-descriptor-hash
Derive `Hash` for `SpendableOutputDescriptor`
Matt Corallo [Wed, 27 Sep 2023 03:46:39 +0000 (03:46 +0000)]
Merge pull request #2359 from domZippilli/2023-06-monitor-updating-persister
Monitor updating persister
Dom Zippilli [Wed, 30 Aug 2023 00:42:07 +0000 (17:42 -0700)]
Add MonitorUpdatingPersister
MonitorUpdatingPersister is an implementation of Persister that stores
ChannelMonitorUpdates separately from ChannelMonitors. Its RFC is
in #2545, at https://github.com/orgs/lightningdevkit/discussions/2545.
Co-Authored-By: Elias Rohrer <dev@tnull.de>
Matt Corallo [Tue, 26 Sep 2023 22:54:12 +0000 (22:54 +0000)]
Merge pull request #2486 from wvanlint/batch_channel_opens
Batch funding for v1 channel establishments
Matt Corallo [Tue, 26 Sep 2023 21:28:29 +0000 (21:28 +0000)]
Set a default `max_total_routing_fee_msat` of 1% + 50sats
When using the normal default constructors, we should have some
fee maximum to ensure our default behavior is safe. Here we pick
1% + 50 sats to ensure we're always willing to pay
reasonabl(y high) fees, but not anything too wild.
Matt Corallo [Tue, 26 Sep 2023 21:12:46 +0000 (21:12 +0000)]
Derive `Debug` and `Display` for `Route`
Matt Corallo [Tue, 26 Sep 2023 20:41:49 +0000 (20:41 +0000)]
Derive `Hash` for `SpendableOutputDescriptor`
This allows for easy descriptor de-duplication before building a
claiming transaction.
Willem Van Lint [Sat, 29 Jul 2023 00:21:47 +0000 (17:21 -0700)]
Batch funding for v1 channel establishments
Willem Van Lint [Tue, 26 Sep 2023 05:39:26 +0000 (22:39 -0700)]
Rename finish_force_close_channel to finish_close_channel
Willem Van Lint [Tue, 26 Sep 2023 05:36:26 +0000 (22:36 -0700)]
Always call finish_force_close_channel on closure
This is a step towards more unified closing of channels, and provides a
place where the per_peer_state lock is not held.
Matt Corallo [Tue, 26 Sep 2023 20:21:08 +0000 (20:21 +0000)]
Bump versions to 0.0.117-alpha2/invoice 0.25.0-alpha2
Matt Corallo [Tue, 26 Sep 2023 20:07:52 +0000 (20:07 +0000)]
Merge pull request #2417 from tnull/2023-07-max-total-fee
Add config option to set maximum total routing fee
Elias Rohrer [Tue, 26 Sep 2023 13:30:39 +0000 (15:30 +0200)]
Test `max_total_routing_fee_msat` handling when retrying overpaid paths
We setup an MPP scenario with two paths in which we need to overpay to
reach `htlc_minimum_msat`. We then fail the overpaid path and check that
on retry our `max_total_routing_fee_msat` only accounts for the path
fees, but not for the fees overpaid in the first attempt.
Elias Rohrer [Tue, 26 Sep 2023 08:48:33 +0000 (10:48 +0200)]
Check `max_total_routing_fee` is accounted for in `test_threaded_payment_retries`
Elias Rohrer [Wed, 20 Sep 2023 13:32:37 +0000 (15:32 +0200)]
Check `max_total_routing_fee` is reduced in `mpp_retry` test
We check that the `RouteParameters::max_total_routing_fee` field is reduced accordingly
to our previously used fees.
Elias Rohrer [Mon, 4 Sep 2023 12:51:42 +0000 (14:51 +0200)]
Account for leftover fee budget when retrying via `check_retry_payment`
Matt Corallo [Tue, 26 Sep 2023 16:37:40 +0000 (16:37 +0000)]
Correct comment in `shutdown_on_unfunded_channel`
which described the script type incorrectly.
Matt Corallo [Thu, 21 Sep 2023 20:21:13 +0000 (20:21 +0000)]
Refer to an "outage" over a "timeout", for when failure happens
Timeouts may be worth retrying, but an outage is a more general
term which obviously cannot be retried.
Matt Corallo [Thu, 21 Sep 2023 20:19:08 +0000 (20:19 +0000)]
Correct ChannelUnavailable error docs on `send_payment_with_route`
Monitor update failure can no longer lead to a `ChannelUnavailable`
error, but more common cases such as the peer being disconnected
always could, so those should be documented clearer.
Matt Corallo [Thu, 21 Sep 2023 20:03:13 +0000 (20:03 +0000)]
Matt Corallo [Tue, 26 Sep 2023 16:36:16 +0000 (16:36 +0000)]
Merge pull request #2597 from TheBlueMatt/2023-09-finish-force-close-deadlocks
Fix potential peer_state deadlocks in `finish_force_close_channel`
Elias Rohrer [Tue, 18 Jul 2023 13:46:06 +0000 (15:46 +0200)]
Account for leftover fee budget when retrying `PartialFailure`s
Elias Rohrer [Fri, 14 Jul 2023 14:46:52 +0000 (16:46 +0200)]
Test we adhere to `max_total_routing_fee_msat`
Elias Rohrer [Fri, 14 Jul 2023 11:25:33 +0000 (13:25 +0200)]
Consider `RouteParameters::max_total_routing_fee_msat` in `get_route`
We exclude any candidate hops if we find that using them would let the
aggregated path routing fees exceed `max_total_routing_fee_msat`.
Moreover, we return an error if the aggregated fees over all paths of
the selected route would surpass `max_total_routing_fee_msat`.
Elias Rohrer [Fri, 14 Jul 2023 09:47:22 +0000 (11:47 +0200)]
Introduce `RouteParameters::max_total_routing_fee_msat`
Currently, users have no means to upper-bound the total fees accruing
when finding a route. Here, we add a corresponding field to
`RouteParameters` which will be used to limit the candidate set during
path finding in the following commits.
Matt Corallo [Mon, 25 Sep 2023 19:49:15 +0000 (19:49 +0000)]
Provide some test coverage of `shutdown` msgs for unfunded chans
We have code to handle receiving `shutdown` messages on unfudned
channels. However, it had no test coverage, which we add here.
Matt Corallo [Mon, 25 Sep 2023 18:05:53 +0000 (18:05 +0000)]
Fix potential peer_state deadlocks in `finish_force_close_channel`
`ChannelManager::finish_force_close_channel` exists to do cleanups
which must happen without the `per_peer_state` mutex held. However,
because it lacked lock assertions, several changes snuck in
recently which resulted in it running with peer-state locks held,
risking a deadlock if some HTLCs need to be failed.
Matt Corallo [Mon, 25 Sep 2023 17:08:41 +0000 (17:08 +0000)]
Merge pull request #2583 from Evanfeenstra/pub-make-onion
Pub make onion
Matt Corallo [Mon, 25 Sep 2023 16:56:03 +0000 (16:56 +0000)]
Merge pull request #2576 from valentinewallace/2023-09-fix-outbound-bp-fail-ev
Fix `PaymentPathFailed::payment_failed_permanently` on blinded path fail
Matt Corallo [Mon, 25 Sep 2023 16:00:04 +0000 (16:00 +0000)]
Merge pull request #2594 from benthecarman/debug-monitor-update-id
Implement Debug for MonitorUpdateId
benthecarman [Sun, 24 Sep 2023 05:34:27 +0000 (00:34 -0500)]
Implement Debug for MonitorUpdateId
Valentine Wallace [Fri, 15 Sep 2023 20:55:12 +0000 (16:55 -0400)]
Blame outbound channel on UPDATE onion failure with 0-len update
We've run into this several times in the wild, likely due to
https://github.com/ElementsProject/lightning/issues/6200 wherein a node on the
path will error with 0x1000 but not provide a channel update (a spec
violation).
Previously, we would blame the inbound edge even though the buggy peer wanted
us to blame the outbound edge. Since this issue seems to be recurring and our
blaming the inbound edge is causing us to punish innocent channels, trust the
peer that the outbound edge is the one to blame.
Valentine Wallace [Thu, 14 Sep 2023 15:46:02 +0000 (11:46 -0400)]
Fix PaymentPathFailed::payment_failed_permanently on blinded path fail
Previously this value would be incorrectly set to true because we wouldn't
account for blinded hops when determining if we were processing the last hop's
failure packet.
Valentine Wallace [Thu, 14 Sep 2023 15:41:35 +0000 (11:41 -0400)]
Correct DecodedOnionFailure when processing we-are-intro-node path
We don't support sending to paths where we are the intro node yet, but may as
well set the failure correctly now.
Valentine Wallace [Thu, 14 Sep 2023 15:33:01 +0000 (11:33 -0400)]
DecodedOnionFailure::payment_retryable -> ::payment_failed_permanently
Our ultimate goal with this field is to set
PaymentPathFailed::payment_failed_permanently, so use this name rather than
flipping a bool back and forth across methods.
Valentine Wallace [Wed, 20 Sep 2023 18:49:58 +0000 (14:49 -0400)]
Struct-ify onion util internal result type
Improves readability.
Valentine Wallace [Thu, 14 Sep 2023 03:52:11 +0000 (23:52 -0400)]
Rename onion util internal var
This variable is ultimately for setting
PaymentPathFailed::payment_failed_permanently, so use this name rather than
flipping a bool back and forth.