]> git.bitcoin.ninja Git - rust-lightning/log
rust-lightning
4 years agoLog fee spike buffer violations.
Valentine Wallace [Mon, 22 Jun 2020 19:29:29 +0000 (15:29 -0400)]
Log fee spike buffer violations.

4 years agoMerge pull request #641 from jkczyz/2020-06-deterministic-test-logging
Matt Corallo [Sun, 21 Jun 2020 19:44:56 +0000 (19:44 +0000)]
Merge pull request #641 from jkczyz/2020-06-deterministic-test-logging

Make test output deterministic

4 years agoMake test output deterministic
Jeffrey Czyz [Wed, 17 Jun 2020 15:29:30 +0000 (08:29 -0700)]
Make test output deterministic

Tests use sources of randomness to produce seeds, preimages, secrets,
and ephemeral data. However, this makes comparing logs between different
test runs difficult. Remove uses of random number generators and the
current time in favor of fixed values in order to make the test output
deterministic.

4 years agoMerge pull request #639 from valentinewallace/fix-feerate-new-channel
Matt Corallo [Tue, 16 Jun 2020 19:51:24 +0000 (19:51 +0000)]
Merge pull request #639 from valentinewallace/fix-feerate-new-channel

Use our actual feerate in open_channel messages, not a new one

4 years agoSwitch all feerate u64's to u32's.
Valentine Wallace [Mon, 15 Jun 2020 21:28:01 +0000 (17:28 -0400)]
Switch all feerate u64's to u32's.

The protocol only allows a u32, so if we received or sent something
larger it would be an issue (though it's unlikely).

4 years agoUse our actual feerate in open_channel messages, not a new one
Valentine Wallace [Sat, 13 Jun 2020 20:46:25 +0000 (16:46 -0400)]
Use our actual feerate in open_channel messages, not a new one

When we were sending an open_channel messages we were asking the
feerate estimator for a new value instead of using the one we had.
If the feerate estimator gave a different value than the one it did
when we created the Channel struct, we'd start out-of-sync with our
counterparty and blow up on funding_signed. Even worse, the
ConfirmationTarget used was different, so its highly likely they
would disagree.

Also remove newly unused fee estimator parameter from get_open-channel
API.

Co-authored-by: Matt Corallo <git@bluematt.me>
Co-authored-by: Valentine Wallace <vwallace@protonmail.com>
4 years agoMerge pull request #577 from valentinewallace/fix-onchain-fee-check-htlcs
Matt Corallo [Mon, 15 Jun 2020 20:17:03 +0000 (20:17 +0000)]
Merge pull request #577 from valentinewallace/fix-onchain-fee-check-htlcs

Incl tx fee when calcing inbound+outbound HTLC limits on channels

4 years agoUpdate chanmon fuzzer to include small payment actions.
Valentine Wallace [Wed, 6 May 2020 23:18:51 +0000 (19:18 -0400)]
Update chanmon fuzzer to include small payment actions.

This change should allow the fuzzer to catch more edge cases, such as
channel reserve checks that cut it close when sending payments.

4 years agoAdd fee spike buffer + incl commit tx fee in chan reserve calculation
Valentine Wallace [Wed, 6 May 2020 23:18:23 +0000 (19:18 -0400)]
Add fee spike buffer + incl commit tx fee in chan reserve calculation

When we receive an inbound HTLC from a peer on an inbound channel,
make sure the funder can still cover the additional on-chain cost
of the HTLC while maintaining their channel reserve.

When we're sending an outbound HTLC, make sure the funder can still
cover the additional on-chain cost of the HTLC while maintaining
their channel reserve.

+ implement fee spike buffer for channel initiators sending payments.
Also add an additional spec-deviating fee spike buffer on the
receiving side (but don't close the channel if this reserve is
violated, just fail the HTLC).
From lightning-rfc PR #740.

Co-authored-by: Matt Corallo <git@bluematt.me>
Co-authored-by: Valentine Wallace <vwallace@protonmail.com>
4 years agoMerge pull request #634 from valentinewallace/improve-inbound-htlc-docs
Matt Corallo [Thu, 11 Jun 2020 18:59:07 +0000 (18:59 +0000)]
Merge pull request #634 from valentinewallace/improve-inbound-htlc-docs

Improve documentation for InboundHTLCState enum states.

4 years agoImprove documentation for InboundHTLCState enum states.
Valentine Wallace [Sun, 31 May 2020 19:59:49 +0000 (15:59 -0400)]
Improve documentation for InboundHTLCState enum states.

4 years agoRefactor: move channel checks for HTLC adds into Channel
Valentine Wallace [Fri, 5 Jun 2020 19:27:30 +0000 (15:27 -0400)]
Refactor: move channel checks for HTLC adds into Channel

This also includes adding a closure that creates a new pending HTLC status
as a parameter for Channel's update_add_htlc. This will later be useful
when we add the check for fee spike buffer violations, which will also result
in changing an HTLC's pending status to failing.

Co-authored-by: Jeffrey Czyz <jkczyz@gmail.com>
Co-authored-by: Valentine Wallace <vwallace@protonmail.com>
4 years agoMerge pull request #629 from arik-so/message_handling_extraction
Matt Corallo [Thu, 11 Jun 2020 03:58:07 +0000 (03:58 +0000)]
Merge pull request #629 from arik-so/message_handling_extraction

Extract wire message handling into a method.

4 years agoExtract wire message handling into a method.
Arik Sosman [Fri, 22 May 2020 20:03:49 +0000 (13:03 -0700)]
Extract wire message handling into a method.

This is a response to splitting #585 into smaller components. This extraction should allow the subsequent creation of a trait for all message handling, thereby enabling more flexibility in the state machine, particularly for bindings.

4 years agoMerge pull request #632 from TheBlueMatt/2020-05-drop-chankeys-privs
Matt Corallo [Sat, 6 Jun 2020 23:22:59 +0000 (23:22 +0000)]
Merge pull request #632 from TheBlueMatt/2020-05-drop-chankeys-privs

Drop ChannelKeys Private Key Methods

4 years agoDrop requirement that all ChannelKeys expose htlc_basepoint 2020-05-drop-chankeys-privs
Matt Corallo [Thu, 28 May 2020 20:13:38 +0000 (16:13 -0400)]
Drop requirement that all ChannelKeys expose htlc_basepoint

4 years agoDrop requirement that ChannelKeys expose delayed_payment_basepoint
Matt Corallo [Thu, 28 May 2020 20:09:47 +0000 (16:09 -0400)]
Drop requirement that ChannelKeys expose delayed_payment_basepoint

4 years agoDrop requirement that all ChannelKeys expose revocaion_basepoint
Matt Corallo [Thu, 28 May 2020 20:06:28 +0000 (16:06 -0400)]
Drop requirement that all ChannelKeys expose revocaion_basepoint

4 years agoDrop requirement that all ChannelKeys expose the payment_point
Matt Corallo [Thu, 28 May 2020 20:03:03 +0000 (16:03 -0400)]
Drop requirement that all ChannelKeys expose the payment_point

4 years agoDrop requirement that all ChannelKeys expose the funding privkey
Matt Corallo [Thu, 28 May 2020 20:02:33 +0000 (16:02 -0400)]
Drop requirement that all ChannelKeys expose the funding privkey

4 years agoExpose private keys from InMemoryChannelKeys publicly
Matt Corallo [Thu, 28 May 2020 20:00:46 +0000 (16:00 -0400)]
Expose private keys from InMemoryChannelKeys publicly

As we drop the requirement that all ChannelKeys expose the private
keys used, we should have a way to access the private keys in use
when using InMemoryChannelKeys.

4 years agoMerge pull request #620 from TheBlueMatt/2020-05-pre-bindings-cleanups
Matt Corallo [Thu, 28 May 2020 19:34:42 +0000 (19:34 +0000)]
Merge pull request #620 from TheBlueMatt/2020-05-pre-bindings-cleanups

Pre-C Bindings Cleanup

4 years agoMerge pull request #610 from ariard/2020-04-cache-in-monitor
Matt Corallo [Thu, 28 May 2020 19:25:06 +0000 (19:25 +0000)]
Merge pull request #610 from ariard/2020-04-cache-in-monitor

Move back to ChannelMonitor RemoteTxCache

4 years agoAdd test_key_derivation_params
Antoine Riard [Mon, 18 May 2020 08:19:32 +0000 (04:19 -0400)]
Add test_key_derivation_params

`to_local` output or remote output on remote commitment transaction
needs a channel keys to be spent. As per-channel keys are derived from
KeysManager seed and per-channel secrets those must be backed up by
any descriptor bookmarking for latter spend. We test that generating
a new KeysManager loaded with such backed-up seed/per-channel secrets
return the correct keys for spending a `to_local` output.

4 years agoSignificantly clarify key derivation and expose methods referenced
Matt Corallo [Fri, 15 May 2020 22:57:44 +0000 (18:57 -0400)]
Significantly clarify key derivation and expose methods referenced

4 years agoDocument better DynamicOutputP2WSH
Antoine Riard [Fri, 8 May 2020 21:19:19 +0000 (17:19 -0400)]
Document better DynamicOutputP2WSH

4 years agoRemove useless build warnings
Antoine Riard [Wed, 6 May 2020 01:42:51 +0000 (21:42 -0400)]
Remove useless build warnings

4 years agoMake get_revokable_redeemscript
Antoine Riard [Tue, 5 May 2020 22:48:32 +0000 (18:48 -0400)]
Make get_revokable_redeemscript

4 years agoMake derive_private_key public
Antoine Riard [Tue, 5 May 2020 22:36:06 +0000 (18:36 -0400)]
Make derive_private_key public

4 years agoDry-up witnessScript in sign_remote_htlc_transaction
Antoine Riard [Mon, 4 May 2020 06:35:54 +0000 (02:35 -0400)]
Dry-up witnessScript in sign_remote_htlc_transaction

Instead of blindly signing provided witnessScript, signer must derive
channel keys corresponding to the provided per-commitment-point and
regenerate templated witnessScript to ensure its syntax correctness.

4 years agoDry-up witnessScript in sign_justice_transaction
Antoine Riard [Mon, 4 May 2020 06:20:56 +0000 (02:20 -0400)]
Dry-up witnessScript in sign_justice_transaction

Instead of blindly signing provided witnessScript, signer must derive
channel keys corresponding to the provided per-commitment-point and
regenerate templated witnessScript to ensure its syntax correctness.

4 years agoImp Writer/Reader for RemoteCommitmentTransaction
Antoine Riard [Wed, 29 Apr 2020 23:43:31 +0000 (19:43 -0400)]
Imp Writer/Reader for RemoteCommitmentTransaction

4 years agoRename RemoteTxCache as RemoteCommitmentTransaction and document better
Antoine Riard [Wed, 29 Apr 2020 23:21:37 +0000 (19:21 -0400)]
Rename RemoteTxCache as RemoteCommitmentTransaction and document better

We also remove an unecessary build warning.

4 years agoRename their_to_self_delay as on_local_tx_csv
Antoine Riard [Thu, 30 Apr 2020 01:22:28 +0000 (21:22 -0400)]
Rename their_to_self_delay as on_local_tx_csv

on_remote_tx_csv is the CSV delay encumbering remote transactions
revokable outputs as required by local.

on_local_tx_csv is the CSV delay encumbering local transactions
revokable outputs as required by remote.

Local/remote is here defined from a code processing viewpoint,
process running this code is "local".

4 years agoDrop remote_csv from OnchainTxHandler, cache it in Monitor's cache
Antoine Riard [Tue, 28 Apr 2020 00:20:43 +0000 (20:20 -0400)]
Drop remote_csv from OnchainTxHandler, cache it in Monitor's cache

4 years agoDedup RemoteTxCache by removing OnchainTxHandler copy
Antoine Riard [Tue, 28 Apr 2020 00:07:17 +0000 (20:07 -0400)]
Dedup RemoteTxCache by removing OnchainTxHandler copy

RemoteTxCache was providing all data needed at transaction
signature for any remote HTLC transaction or justice transaction.
This move was making the API between OnchainTxHandle akward and
scope of responsibilites with ChannelMonitor unclear.

Instead scope OnchainTxHandler to transaction-finalization, fee-bumping
and broadcast only.

4 years agoDuplicate RemoteTxCache in ChannelMonitor
Antoine Riard [Mon, 18 May 2020 22:37:06 +0000 (18:37 -0400)]
Duplicate RemoteTxCache in ChannelMonitor

Dry-up remote pubkeys tracking in one struct.

This introduce a duplicate of RemoteTxCache, which is going
to be removed in next commit when OnchainTxHandler version is
removed.

4 years agoRemove SecretKey from DynamicOuputP2WPKH descriptor
Antoine Riard [Tue, 24 Mar 2020 21:03:26 +0000 (17:03 -0400)]
Remove SecretKey from DynamicOuputP2WPKH descriptor

Add sign_payment_transaction in ChanSigner to be able to spend
SpendableOutputDescriptor in test framework

Extend ChannelKeys with remote_pubkeys to access remote revocation
basepoint for witnessScript construction.

4 years agoRemove SecretKey from DynamicOutputP2WSH descriptor
Antoine Riard [Tue, 24 Mar 2020 20:26:46 +0000 (16:26 -0400)]
Remove SecretKey from DynamicOutputP2WSH descriptor

Add sign_delayed_transaction in ChanSigner to be able to spend
SpendableOutputDescriptor in test framework.

4 years agoExtend KeysInterface with derive_channel_keys
Antoine Riard [Wed, 6 May 2020 00:00:01 +0000 (20:00 -0400)]
Extend KeysInterface with derive_channel_keys

A dynamic-p2wsh-output like `to_local` on local commitment/HTLC txn
require a signature from delayed_payment_key to be spend. Instead of
sending private key in descriptor, we ask for spender to derive again
the corresponding ChannelKeys based on key state, uniquely identifying
a channel and encompassing its unique start data.

Descriptor modification is done in next commit.

4 years agoMerge pull request #624 from arik-so/encode_and_send_msg_method_refactor
Matt Corallo [Fri, 22 May 2020 18:45:55 +0000 (18:45 +0000)]
Merge pull request #624 from arik-so/encode_and_send_msg_method_refactor

Extract encode_and_send_msg into a method.

4 years agoExpose PeerHandleError::no_connection_possible 2020-05-pre-bindings-cleanups
Matt Corallo [Thu, 14 May 2020 01:25:51 +0000 (21:25 -0400)]
Expose PeerHandleError::no_connection_possible

Its just a trivial bool and already has docs on it, so seems like
an oversight

4 years agoThree small fixes to work around our bindings generator limitations
Matt Corallo [Tue, 12 May 2020 17:47:54 +0000 (13:47 -0400)]
Three small fixes to work around our bindings generator limitations

 * Return Self instead of the fully-written types for constructors,
 * Place definitions before use (in this case for KeysInterface),
 * Don't import foo::bar::self, but import foo::bar

 + a spelling fix in the KeysInterface docs for get_onion_rand.

4 years agoReturn a ChannelManager instead of result from ChannelManager::new()
Matt Corallo [Tue, 12 May 2020 17:34:00 +0000 (13:34 -0400)]
Return a ChannelManager instead of result from ChannelManager::new()

We never actually fail, so we can just drop the Result type.

4 years agoMake RoutingMessageHandler a generic Deref instead of an Arc
Matt Corallo [Tue, 12 May 2020 17:31:20 +0000 (13:31 -0400)]
Make RoutingMessageHandler a generic Deref instead of an Arc

We also update to use single idents when referencing the Deref=*
types since the automated code generator is pretty braindead.

This also moves some test utils out of peer_handler.rs and into
util::test_utils to standardize things a little bit, which we need
to concretize the PeerHandler types used in testing.

4 years agoMake ManyChannelMonitor Keys an associated type
Matt Corallo [Tue, 12 May 2020 17:20:31 +0000 (13:20 -0400)]
Make ManyChannelMonitor Keys an associated type

Instead of using a raw generic type, an associted type allows us
to have explicit docs on the type, which is nice. More importantly,
however, our automated bindings generator knows how to read
associated types but not raw generics.

Also, our bindings generator expects things which are referenced to
have already been defined, so we move ManyChannelMonitor below the
ChannelMonitor definition.

4 years agoExtract encode_and_send_msg into a method.
Arik Sosman [Mon, 18 May 2020 17:55:28 +0000 (10:55 -0700)]
Extract encode_and_send_msg into a method.

This is a response to splitting #585 into smaller components. This extraction will permit a future extraction of all message handling into a separate method, and then later even into a separate trait that will be accessible through language bindings.

4 years agoAdd KeysManager::derive_unique_start
Antoine Riard [Tue, 12 May 2020 00:29:39 +0000 (20:29 -0400)]
Add KeysManager::derive_unique_start

In next commit, we add derive_channel_keys, a helper to rederive
keys from a SpendableOuptutDescriptor. We still need to ensure
that user rederive same set of keys even if KeyManager is started
at a later time. For doing so we need to pass starting time as
part of the re-derived sha_state, therefore we need to make it
accessible and part of channel state key material.

Seed is already required to be conserved between KeysManager
serializations.

4 years agoMove remote htlc transaction signature behind ChanSigner
Antoine Riard [Tue, 24 Mar 2020 19:04:36 +0000 (15:04 -0400)]
Move remote htlc transaction signature behind ChanSigner

4 years agoBuild witness_script for remote htlc transactions inside
Antoine Riard [Tue, 24 Mar 2020 18:47:37 +0000 (14:47 -0400)]
Build witness_script for remote htlc transactions inside
OnchainTxHandler

By moving script generation inside OnchainTxHandler, we may dry-up
further ChannelMonitor in next commits

Comment MINIMALIF rule

4 years agoMove justice transaction signature behind ChanSigner
Antoine Riard [Tue, 24 Mar 2020 18:22:16 +0000 (14:22 -0400)]
Move justice transaction signature behind ChanSigner

4 years agoBuild witness_script for justice tx inside OnchainTxHandler
Antoine Riard [Tue, 24 Mar 2020 01:50:23 +0000 (21:50 -0400)]
Build witness_script for justice tx inside OnchainTxHandler

By moving script generation inside OnchainTxHandler, we may dry-up
further ChannelMonitor in next commits.

4 years agoReplace is_htlc in InputMaterial by InputDescriptor
Antoine Riard [Tue, 24 Mar 2020 03:28:00 +0000 (23:28 -0400)]
Replace is_htlc in InputMaterial by InputDescriptor

As we cache more and more transaction elements in OnchainTxHandler
we should dry up completly InputMaterial until them being replaced
directly by InputDescriptor

4 years agoCache remote HTLC inside OnchainTxHandler::RemoteTxCache
Antoine Riard [Tue, 24 Mar 2020 02:17:46 +0000 (22:17 -0400)]
Cache remote HTLC inside OnchainTxHandler::RemoteTxCache

As we can't predict if any and which revoked commitment tx is
going to appear onchain we have by design to cache all htlc information
to regenerate htlc script if needed.

4 years agoCache remote basepoint and remote_csv in new OnchainTxHandler::RemoteTxCache
Antoine Riard [Tue, 24 Mar 2020 01:22:14 +0000 (21:22 -0400)]
Cache remote basepoint and remote_csv in new OnchainTxHandler::RemoteTxCache

Used in next commits to avoid passing script between ChannelMonitor
and OnchainTxHandler. ChannelMonitor duplicata will be removed
in future commits.

4 years agoDrop OutPoint::new since the struct is all pub
Matt Corallo [Tue, 12 May 2020 17:17:49 +0000 (13:17 -0400)]
Drop OutPoint::new since the struct is all pub

This makes it easier for our automated bindings generator to
function as it tries to automatically create a ::new if the struct
contains only pub elements who's type is convertible.

4 years agoMerge pull request #622 from valentinewallace/chanmgr-logger-arc-to-deref
Matt Corallo [Mon, 18 May 2020 03:21:12 +0000 (03:21 +0000)]
Merge pull request #622 from valentinewallace/chanmgr-logger-arc-to-deref

ChannelManager+Router++ Logger Arc --> Deref

4 years agoPeerManager Logger Arc --> Deref
Valentine Wallace [Sun, 17 May 2020 16:13:29 +0000 (12:13 -0400)]
PeerManager Logger Arc --> Deref

4 years agoChannelManager+Router++ Logger Arc --> Deref
Valentine Wallace [Mon, 2 Mar 2020 17:55:53 +0000 (12:55 -0500)]
ChannelManager+Router++ Logger Arc --> Deref

This caused a bunch of cascading changes, including
passing loggers down to Channels in function calls
rather than having each Channel have a pointer to the
ChannelManager's Logger (which was a circular reference).
Other structs that the Channel had passed its Logger to also
had their loggers removed. Other newly unused Loggers were
also removed, especially when keeping them would've caused
a bunch of extra test changes to be necessary, e.g. with
the ChainWatchInterfaceUtil's Logger.

4 years agoMerge pull request #617 from sourabhmarathe/serialize-channelmanager-events
Matt Corallo [Thu, 14 May 2020 21:24:45 +0000 (21:24 +0000)]
Merge pull request #617 from sourabhmarathe/serialize-channelmanager-events

Serialize ChannelManager events

4 years agoSerialize ChannelManager events
Sourabh Marathe [Thu, 7 May 2020 01:02:44 +0000 (21:02 -0400)]
Serialize ChannelManager events

Also adds a test for de/serializing events

4 years agoMerge pull request #621 from TheBlueMatt/2020-05-592-nits
Matt Corallo [Tue, 12 May 2020 18:41:04 +0000 (18:41 +0000)]
Merge pull request #621 from TheBlueMatt/2020-05-592-nits

592+a few fixes

4 years agoFix some new indentation nits 2020-05-592-nits
Matt Corallo [Tue, 12 May 2020 01:12:23 +0000 (21:12 -0400)]
Fix some new indentation nits

4 years agoFix a few new (and one old) issues in the new channel_update
Matt Corallo [Tue, 12 May 2020 01:09:44 +0000 (21:09 -0400)]
Fix a few new (and one old) issues in the new channel_update

We need to always set lowest_inbound_channel_fees to None if there
are no channels (and we should ignore the channels which are
disabled for the purpose of lowest-fee calculations). Further, we
cannot unwrap the channel lookups as they may be for channels which
are not related to the channel we are processing an update for.
Finally, we can satisfy borrowck much easier since things are on
self instead of on a MutexGuard.

4 years agoAdd assertion since we now have a pub field that is PartialEq
Matt Corallo [Tue, 12 May 2020 01:08:35 +0000 (21:08 -0400)]
Add assertion since we now have a pub field that is PartialEq

We previously were only able to assert that the route graph
serialization roundtrips were good by comparing the network
messages returned from them, but we can now do better as the graph
is exposed publicly via a simple datastructure that implements
PartialEq.

4 years agoAdd missing comment on why last_update_message is None
Matt Corallo [Tue, 12 May 2020 01:08:11 +0000 (21:08 -0400)]
Add missing comment on why last_update_message is None

4 years agoMove get_addresses to network_graph and drop now-useless log_trace
Matt Corallo [Tue, 12 May 2020 01:07:02 +0000 (21:07 -0400)]
Move get_addresses to network_graph and drop now-useless log_trace

Because we expose the internals we don't need a method to log
their contents anymore, and get_addresses can now avoid copying as
we expose the RwLock directly

4 years agoDrop new test Node field introduced in 8ce2223b6952567b28adfcc11c2
Matt Corallo [Mon, 11 May 2020 22:36:58 +0000 (18:36 -0400)]
Drop new test Node field introduced in 8ce2223b6952567b28adfcc11c2

8ce2223b6952567b28adfcc11c23c9f19c4c0324 introduced a new field in
the "Node" objects used in our functional tests - the node_id. Its
not a bad idea to cache it, but unless we want to commit and use it
everywhere, we should avoid duplicating data, especially in tests
where we'd rather exercise the underlying code than bypass it.

4 years agoImprove routing-related documentation
Gleb Naumenko [Wed, 6 May 2020 23:04:44 +0000 (19:04 -0400)]
Improve routing-related documentation

4 years agoRemove NetGraphMsgHandler serialization
Gleb Naumenko [Wed, 6 May 2020 22:34:37 +0000 (18:34 -0400)]
Remove NetGraphMsgHandler serialization

4 years agoMake DirectionalChannelInfo optional
Gleb Naumenko [Sun, 3 May 2020 20:06:59 +0000 (16:06 -0400)]
Make DirectionalChannelInfo optional

4 years agoMove node announcement fields into a separate struct
Gleb Naumenko [Mon, 4 May 2020 17:53:44 +0000 (13:53 -0400)]
Move node announcement fields into a separate struct

4 years agoExpose some network graph methods
Gleb Naumenko [Sun, 3 May 2020 15:01:55 +0000 (11:01 -0400)]
Expose some network graph methods

4 years agoSplit routing from getting network messages
Gleb Naumenko [Sat, 2 May 2020 19:05:04 +0000 (15:05 -0400)]
Split routing from getting network messages

4 years agoRemove non-bitcoin chain helpers
Gleb Naumenko [Sat, 2 May 2020 18:58:06 +0000 (14:58 -0400)]
Remove non-bitcoin chain helpers

4 years agoMove router to a separate module
Gleb Naumenko [Sat, 2 May 2020 13:37:38 +0000 (09:37 -0400)]
Move router to a separate module

4 years agoMerge pull request #539 from TheBlueMatt/2020-03-static-remotekey
Matt Corallo [Wed, 6 May 2020 02:07:02 +0000 (02:07 +0000)]
Merge pull request #539 from TheBlueMatt/2020-03-static-remotekey

Require static_remotekey

4 years agoMerge pull request #613 from valentinewallace/less-confusing-chan-reserve-names
Matt Corallo [Wed, 6 May 2020 02:06:41 +0000 (02:06 +0000)]
Merge pull request #613 from valentinewallace/less-confusing-chan-reserve-names

Make channel reserve variable names less confusing.

4 years agoRename payment_basepoint/key to simply payment_point/key. 2020-03-static-remotekey
Matt Corallo [Mon, 9 Mar 2020 00:38:16 +0000 (20:38 -0400)]
Rename payment_basepoint/key to simply payment_point/key.

We no longer derive any keys from the payment point, so they aren't
a "base" but simply a point/key.

4 years agoRequire option_static_remotekey in channel/channelmonitor.
Matt Corallo [Sun, 3 May 2020 02:00:08 +0000 (22:00 -0400)]
Require option_static_remotekey in channel/channelmonitor.

This simplifies channelmonitor quite nicely (as expected) as we
never have to be concerned with learning data in a DataLossProtect
which is require for us to claim our funds from the latest remote
commitment transaction.

4 years agoAdd detection of feature_static_remotekey support and print
Matt Corallo [Tue, 3 Mar 2020 20:27:45 +0000 (15:27 -0500)]
Add detection of feature_static_remotekey support and print

This adds the ability to check for static_remotekey in appropriate
feature contexts and prints it at connect time. It is still
considered unknown for the purposes of requires_unknown_bits() as
we don't yet implement it.

4 years agoMake channel reserve variable names less confusing.
Valentine Wallace [Fri, 1 May 2020 22:39:18 +0000 (18:39 -0400)]
Make channel reserve variable names less confusing.

Previous to this commit, variables such as their_channel_reserve
referred to the channel reserve that _we_ are required to keep,
(the value is initially set by the remote). Similarly,
variables such as our_channel_reserve referred to the channel
reserve that we require the remote to keep.

Change this to use local_channel_reserve / remote_channel_reserve
to refer to the the channel reserve that the local is required to keep
and the channel reserve that the remote is required to keep, respectively.

4 years agoCheck local signtures explicitly in channel tx-generation tests
Matt Corallo [Mon, 9 Mar 2020 17:45:15 +0000 (13:45 -0400)]
Check local signtures explicitly in channel tx-generation tests

It appears the local signatures which are specified in the channel
transaction-generation tests were never checked directly (though
they were checked as a part of the overall fully-signed-transaction
tests).

Check them explicitly so that they can be updated for static remote
key.

4 years agoAdd additional trace logging in channel signature validation
Matt Corallo [Tue, 28 Apr 2020 23:46:45 +0000 (19:46 -0400)]
Add additional trace logging in channel signature validation

This makes it easier to amend the full_stack_target
test_no_existing_test_breakage test by always providing the
neccessary data in the log.

4 years agoMerge pull request #590 from jkczyz/2020-04-feature-flags
Matt Corallo [Wed, 29 Apr 2020 18:49:39 +0000 (18:49 +0000)]
Merge pull request #590 from jkczyz/2020-04-feature-flags

Features module improvements

4 years agoSanity check that known features are not required
Jeffrey Czyz [Tue, 28 Apr 2020 06:24:46 +0000 (23:24 -0700)]
Sanity check that known features are not required

4 years agoExpand testing of unknown feature bits
Jeffrey Czyz [Tue, 28 Apr 2020 05:12:53 +0000 (22:12 -0700)]
Expand testing of unknown feature bits

Include tests for requires_unknown_bits and supports_unknown_bits when
an unknown even bit, odd bit, or neither is set. Refactor bit clearing
such that tests and production code share the same code path. Fix a
potential spec incompatibility (currently only exposed in testing code)
where trailing zero bytes are not removed after a bit is cleared.

4 years agoGeneralize with_known_relevant_init_flags
Jeffrey Czyz [Wed, 22 Apr 2020 23:52:11 +0000 (16:52 -0700)]
Generalize with_known_relevant_init_flags

Converting from InitFeatures to other Features is accomplished using
Features::with_known_relevant_init_flags. Define a more general
to_context method which converts from Features of one Context to
another.

Additionally, ensure the source context only has known flags before
selecting flags for the target context.

4 years agoGeneralize feature methods to work in any context
Jeffrey Czyz [Thu, 16 Apr 2020 05:44:43 +0000 (22:44 -0700)]
Generalize feature methods to work in any context

Refactoring the features module allowed for making code specific to
certain contexts generalizable. Specifically, KNOWN_FEATURE_MASK
is defined on Context instead of hardcoded in each method
specialization. Thus, such methods are no longer required.

4 years agoRemove duplicate specification of features
Jeffrey Czyz [Thu, 16 Apr 2020 00:16:45 +0000 (17:16 -0700)]
Remove duplicate specification of features

Features for a given context are duplicated throughout the features
module. Use a macro for defining a Context and the applicable features
such that features only need to be defined for a Context in one place.
The Context provides bitmasks for selecting known and unknown feature
flags.

BOLT 1 and BOLT 9 refer to features as "known" if a peer understands
them. They also use the term "supported" to mean either optional or
required.

Update the features module to use similar terminology.
- Define contexts in terms of required and optional features rather than
  just supported features
- Define known features as those that are optional or required
- Rename supported() constructor to known()

For completeness, clear_optional_bit for each feature is now called
clear_bits and clears both optional and required bits.

4 years agoImprove features module documentation
Jeffrey Czyz [Tue, 14 Apr 2020 01:39:29 +0000 (18:39 -0700)]
Improve features module documentation

4 years agoEncapsulate feature flag checking and manipulation
Jeffrey Czyz [Fri, 10 Apr 2020 00:08:48 +0000 (17:08 -0700)]
Encapsulate feature flag checking and manipulation

Each feature is represented by two bits within Features' flags field.
Working with these flags requires bitwise operations, which can be error
prone. Rather than directly checking and manipulating bits, encapsulate
the bits within each feature trait and provide mechanisms for doing so.

This removes the need to comment on which features correspond to bitwise
expressions since the expressions use feature trait identifiers instead.

With this approach, byte literals and expressions can be evaluated at
compile time still. However, for these cases, knowing which byte within
the flags that a feature corresponds to still must be determined by the
implementor.

Remove the special case where initial_routing_sync has no even bit. Now,
it (bit 2) is considered known by the implementation.

4 years agoSet initial_routing_sync in InitFeatures
Jeffrey Czyz [Thu, 23 Apr 2020 16:47:15 +0000 (09:47 -0700)]
Set initial_routing_sync in InitFeatures

The initial_routing_sync feature is set by peer_handler whenever a full
sync of the network graph is desired. It is not explicitly set when
creating features with InitFeatures::supported().

An upcoming refactor will change supported() to known(), which will
return all features known by the implementation. Thus, the
initial_routing_sync flag will need to be set by default. This commit
makes the behavior change ahead of the refactor.

4 years agoMerge pull request #609 from LNP-BP/refactor-deps
Matt Corallo [Wed, 29 Apr 2020 17:15:38 +0000 (17:15 +0000)]
Merge pull request #609 from LNP-BP/refactor-deps

Refactor dependencies

4 years agoAdopting (W)PubkeyHash types
Dr. Maxim Orlovsky [Mon, 27 Apr 2020 16:13:27 +0000 (18:13 +0200)]
Adopting (W)PubkeyHash types

4 years agoAdopting new bitcoin hash types and crate version
Dr. Maxim Orlovsky [Mon, 27 Apr 2020 15:53:13 +0000 (17:53 +0200)]
Adopting new bitcoin hash types and crate version

4 years agoBDR: Linearizing secp256k1 deps
Dr. Maxim Orlovsky [Mon, 27 Apr 2020 14:51:59 +0000 (16:51 +0200)]
BDR: Linearizing secp256k1 deps

4 years agoBitcoin deps refactoring (BDR): Linearizing bitcoin_hash deps
Dr. Maxim Orlovsky [Mon, 27 Apr 2020 14:41:54 +0000 (16:41 +0200)]
Bitcoin deps refactoring (BDR): Linearizing bitcoin_hash deps

4 years agoUnset upfront_shutdown_script using bit clearing
Jeffrey Czyz [Fri, 10 Apr 2020 18:36:47 +0000 (11:36 -0700)]
Unset upfront_shutdown_script using bit clearing

The test_upfront_shutdown_script functional test clears this feature
flag. However, the method used to clear the flag is implemented by bit
toggling. Thus, if the flag is not set the method would actually set it.
Implement the method using bit clearing instead.

4 years agoMerge pull request #608 from TheBlueMatt/2020-04-0.0.11
Matt Corallo [Sat, 25 Apr 2020 16:42:15 +0000 (16:42 +0000)]
Merge pull request #608 from TheBlueMatt/2020-04-0.0.11

0.0.11