]> git.bitcoin.ninja Git - rust-lightning/log
rust-lightning
19 months agoExpose HTLC transaction locktime in BumpTransactionEvent::HTLCResolution
Wilmer Paulino [Tue, 7 Mar 2023 01:01:21 +0000 (17:01 -0800)]
Expose HTLC transaction locktime in BumpTransactionEvent::HTLCResolution

While users could easily figure it out based on the set of HTLC
descriptors included within, we already track it within the
`OnchainTxHandler`, so we might as well expose it to users as a
nice-to-have. It's also yet another thing they must get right to ensure
their HTLC transaction broadcasts are valid.

19 months agoSet transaction locktime on malleable packages to discourage fee sniping
Wilmer Paulino [Tue, 28 Mar 2023 19:09:13 +0000 (12:09 -0700)]
Set transaction locktime on malleable packages to discourage fee sniping

This only applies to all malleable packages on channels pre-dating
anchors and malleables packages for counterparty commitments
post-anchors. Malleables packages for holder commitments post-anchors
should have their transaction locktime applied manually by the consumer
of `BumpTransactionEvent::HTLCResolution` events.

19 months agoRe-work PackageSolvingData::absolute_tx_timelock
Wilmer Paulino [Tue, 28 Mar 2023 19:03:19 +0000 (12:03 -0700)]
Re-work PackageSolvingData::absolute_tx_timelock

Previously, this would return the earliest height the output could be
confirmed, which seems to no longer be useful. The only use of the
method was to determine whether we should delay a package to a future
block. Instead, we choose to return the absolute locktime the
transaction spending the output should have, which better corresponds to
the method name and still supports the delay functionality mentioned.

Doing so also allows us to expose the locktime required for HTLC
transactions we need to broadcast based on our own commitments for
anchor channels.

19 months agoMerge pull request #2133 from tnull/2023-03-pin-syn
Wilmer Paulino [Tue, 28 Mar 2023 17:16:39 +0000 (10:16 -0700)]
Merge pull request #2133 from tnull/2023-03-pin-syn

Pin`tokio` to fix CI

19 months agoMerge pull request #2132 from tnull/2023-03-tx-sync-even-more-robustness
Matt Corallo [Tue, 28 Mar 2023 16:42:44 +0000 (16:42 +0000)]
Merge pull request #2132 from tnull/2023-03-tx-sync-even-more-robustness

Drop `OnceCell` in `lightning-transaction-sync` tests

19 months agoMerge pull request #2083 from wpaulino/events-module
Matt Corallo [Tue, 28 Mar 2023 16:37:55 +0000 (16:37 +0000)]
Merge pull request #2083 from wpaulino/events-module

Move events.rs into its own top-level module

19 months agoPin `tokio` to fix CI
Elias Rohrer [Tue, 28 Mar 2023 10:56:38 +0000 (12:56 +0200)]
Pin `tokio` to fix CI

Recently `tokio` got updated to 1.27.0, which bumped MSRV from 1.49 to
1.56.

Here we pin `tokio` accordingly to unbreak CI.

19 months agoRemove unnecessary restriction on `esplora-client` version
Elias Rohrer [Mon, 27 Mar 2023 11:33:01 +0000 (13:33 +0200)]
Remove unnecessary restriction on `esplora-client` version

19 months agoMove test `bitcoind`/`electrsd` out of `OnceCell`
Elias Rohrer [Mon, 27 Mar 2023 11:19:15 +0000 (13:19 +0200)]
Move test `bitcoind`/`electrsd` out of `OnceCell`

`OnceCell` doesn't call `drop`, which makes the spawned
`bitcoind`/`electrsd` instances linger around after our tests have
finished. To fix this, we move them out of `OnceCell` and let every test
that needs them spawn their own instances. This additional let us drop
the `OnceCell` dev dependency.

19 months agoMerge pull request #2125 from benthecarman/invoice-expire-time
Matt Corallo [Mon, 27 Mar 2023 22:54:05 +0000 (22:54 +0000)]
Merge pull request #2125 from benthecarman/invoice-expire-time

Add helper functions for invoice expiry

19 months agoAdd helper functions for invoice expiry
benthecarman [Thu, 23 Mar 2023 20:41:55 +0000 (15:41 -0500)]
Add helper functions for invoice expiry

19 months agoMerge pull request #2110 from munjesi/docs_fixes
Matt Corallo [Mon, 27 Mar 2023 18:12:00 +0000 (18:12 +0000)]
Merge pull request #2110 from munjesi/docs_fixes

Replacing (C-not exported) in the docs

19 months agoMerge pull request #2123 from benthecarman/create-inv-desc
Jeffrey Czyz [Fri, 24 Mar 2023 20:00:10 +0000 (15:00 -0500)]
Merge pull request #2123 from benthecarman/create-inv-desc

Add generic InvoiceDescription to invoice in InvoiceBuilder

19 months agoAdd generic InvoiceDescription to invoice in InvoiceBuilder
benthecarman [Thu, 23 Mar 2023 05:06:32 +0000 (00:06 -0500)]
Add generic InvoiceDescription to invoice in InvoiceBuilder

19 months agoAdd new sub-module for BumpTransactionEvent
Wilmer Paulino [Tue, 7 Mar 2023 22:20:31 +0000 (14:20 -0800)]
Add new sub-module for BumpTransactionEvent

Its accompanying event handler will also live here.

19 months agoMove events.rs into its own top-level module
Wilmer Paulino [Tue, 7 Mar 2023 21:57:01 +0000 (13:57 -0800)]
Move events.rs into its own top-level module

This is largely motivated by some follow-up work for anchors that will
introduce an event handler for `BumpTransaction` events, which we can
now include in this new top-level `events` module.

19 months agoMerge pull request #2114 from Evanfeenstra/force_close_msg_display
Jeffrey Czyz [Wed, 22 Mar 2023 17:32:22 +0000 (12:32 -0500)]
Merge pull request #2114 from Evanfeenstra/force_close_msg_display

use PrintableString to Display CounterpartyForceClosed peer_msg

19 months agoReplacing (C-not exported) in the docs
munjesi [Thu, 16 Mar 2023 17:35:52 +0000 (20:35 +0300)]
Replacing (C-not exported) in the docs

19 months agoSanitizedString struct to safely Display CounterpartyForceClosed peer_msg
Evan Feenstra [Sat, 18 Mar 2023 05:24:23 +0000 (22:24 -0700)]
SanitizedString struct to safely Display CounterpartyForceClosed peer_msg

19 months agoMerge pull request #2102 from douglaz/node_info_addresses
Matt Corallo [Tue, 21 Mar 2023 22:42:16 +0000 (22:42 +0000)]
Merge pull request #2102 from douglaz/node_info_addresses

Remove NodeAnnouncementInfo addresses

19 months agoMerge pull request #2034 from wpaulino/anchor-revoked-aggregate-claim
Matt Corallo [Tue, 21 Mar 2023 22:32:18 +0000 (22:32 +0000)]
Merge pull request #2034 from wpaulino/anchor-revoked-aggregate-claim

Add test for aggregated revoked HTLC claim on anchors channel

19 months agoMerge pull request #2100 from douglaz/docs_fixes
Matt Corallo [Tue, 21 Mar 2023 18:44:23 +0000 (18:44 +0000)]
Merge pull request #2100 from douglaz/docs_fixes

Docs improvements

19 months agoRemove redundant `addresses` field from `NodeAnnouncementInfo`
Allan Douglas R. de Oliveira [Mon, 13 Mar 2023 20:13:28 +0000 (20:13 +0000)]
Remove redundant `addresses` field from `NodeAnnouncementInfo`

...replacing it with an acessor `addresses()`.

Besides removing a redundant data structure already present on inner
`NodeAnnouncement`, this change makes it possible to discover new address types
upon deserialization thanks to `UnsignedNodeAnnouncement`'s implementation.

19 months agoDocs improvements
Allan Douglas R. de Oliveira [Tue, 14 Mar 2023 19:54:44 +0000 (19:54 +0000)]
Docs improvements

19 months agoTest anchors build in CI
Wilmer Paulino [Wed, 15 Feb 2023 00:32:45 +0000 (16:32 -0800)]
Test anchors build in CI

19 months agoMerge pull request #2118 from TheBlueMatt/2023-03-no-useless-strings
Matt Corallo [Mon, 20 Mar 2023 22:22:56 +0000 (22:22 +0000)]
Merge pull request #2118 from TheBlueMatt/2023-03-no-useless-strings

Remove unnecessary heap allocations in log-entry-matching tests

19 months agoRemove unnecessary use in `channelmonitor` tests module 2023-03-no-useless-strings
Matt Corallo [Mon, 20 Mar 2023 20:08:29 +0000 (20:08 +0000)]
Remove unnecessary use in `channelmonitor` tests module

19 months agoRemove unnecessary heap allocations in log-entry-matching tests
Matt Corallo [Mon, 20 Mar 2023 20:07:18 +0000 (20:07 +0000)]
Remove unnecessary heap allocations in log-entry-matching tests

19 months agoAdd test for aggregated revoked HTLC claim on anchors channel
Wilmer Paulino [Wed, 15 Feb 2023 00:10:52 +0000 (16:10 -0800)]
Add test for aggregated revoked HTLC claim on anchors channel

19 months agoMaintain order of yielded claim events
Wilmer Paulino [Tue, 14 Feb 2023 23:49:37 +0000 (15:49 -0800)]
Maintain order of yielded claim events

Since the claim events are stored internally within a HashMap, they will
be yielded in a random order once dispatched. Claim events may be
invalidated if a conflicting claim has confirmed on-chain and we need to
generate a new claim event; the randomized order could result in the
new claim event being handled prior to the previous. To maintain the
order in which the claim events are generated, we track them in a Vec
instead and ensure only one instance of a PackageId only ever exists
within it.

This would have certain performance implications, but since we're
bounded by the total number of HTLCs in a commitment anyway, we're
comfortable with taking the cost.

19 months agoRename keys for OnchainTxHandler::claimable_outpoints map
Wilmer Paulino [Tue, 14 Feb 2023 23:48:44 +0000 (15:48 -0800)]
Rename keys for OnchainTxHandler::claimable_outpoints map

19 months agoClarify OnchainEvent::Claim behavior
Wilmer Paulino [Wed, 15 Feb 2023 00:24:30 +0000 (16:24 -0800)]
Clarify OnchainEvent::Claim behavior

The previous documentation was slightly incorrect, a `Claim` can also be
from the counterparty if they happened to claim the same exact set of
outputs as a claiming transaction we generated.

19 months agoAdd missing docs for BumpHTLCResolution
Wilmer Paulino [Wed, 15 Feb 2023 00:14:03 +0000 (16:14 -0800)]
Add missing docs for BumpHTLCResolution

19 months agoFix stale import behind anchors build tag
Wilmer Paulino [Tue, 14 Feb 2023 23:38:20 +0000 (15:38 -0800)]
Fix stale import behind anchors build tag

19 months agoDerive Eq on structs behind anchors build flag
Wilmer Paulino [Tue, 14 Feb 2023 23:36:37 +0000 (15:36 -0800)]
Derive Eq on structs behind anchors build flag

19 months agoImplement PartialEq manually
Wilmer Paulino [Tue, 14 Feb 2023 23:35:40 +0000 (15:35 -0800)]
Implement PartialEq manually

Since we don't store `pending_claim_events` within `OnchainTxHandler` as
they'll be regenerated on restarts, we opt to implement `PartialEq`
manually such that the field is not longer considered.

19 months agoMerge pull request #2116 from TheBlueMatt/2023-03-serde-sucks
Matt Corallo [Mon, 20 Mar 2023 18:31:12 +0000 (18:31 +0000)]
Merge pull request #2116 from TheBlueMatt/2023-03-serde-sucks

Drop `serde` dependency from `lightning-block-sync`

19 months agoDrop `serde` dependency from `lightning-block-sync` 2023-03-serde-sucks
Matt Corallo [Sun, 19 Mar 2023 23:39:56 +0000 (23:39 +0000)]
Drop `serde` dependency from `lightning-block-sync`

`serde` doesn't bother with MSRVs, so its expected to break
frequently. Yesterday, the `derive` feature had its MSRV broken in
a patch version without care.

Luckily its trivial for us to remove the `serde` dependency in
`lightning-block-sync`, using only `serde_json` for the JSON
deserialization part. It even ends up net-negative on LoC.

19 months agoMerge pull request #2024 from TheBlueMatt/2023-02-6conf-pub-hints
Matt Corallo [Sun, 19 Mar 2023 23:42:15 +0000 (23:42 +0000)]
Merge pull request #2024 from TheBlueMatt/2023-02-6conf-pub-hints

Include a route hint for public, not-yet-announced channels

19 months agoInclude a route hint for public, not-yet-announced channels 2023-02-6conf-pub-hints
Matt Corallo [Thu, 9 Feb 2023 19:02:04 +0000 (19:02 +0000)]
Include a route hint for public, not-yet-announced channels

If we have a public channel which doesn't yet have six
confirmations the network can't possibly know about it as we cannot
have announced it yet. However, because we refuse to include
route-hints if we have any public channels, we will generate
invoices that no one can pay.

Thus, if we have any public, not-yet-announced channels, include
them as a route-hint.

19 months agoMerge pull request #2107 from TheBlueMatt/2023-04-msrv-cleanup
Matt Corallo [Fri, 17 Mar 2023 19:21:49 +0000 (19:21 +0000)]
Merge pull request #2107 from TheBlueMatt/2023-04-msrv-cleanup

Bump MSRV to 1.48 and replace most of CI with a bash script

19 months agoReplace the bulk of CI with a (much simpler) bash script 2023-04-msrv-cleanup
Matt Corallo [Wed, 15 Mar 2023 19:20:08 +0000 (19:20 +0000)]
Replace the bulk of CI with a (much simpler) bash script

19 months agoMerge pull request #2094 from johncantrell97/expose-fee
Matt Corallo [Wed, 15 Mar 2023 21:16:23 +0000 (21:16 +0000)]
Merge pull request #2094 from johncantrell97/expose-fee

expose `feerate_per_kw` in `ChannelDetails`

19 months agoFix onion_message functional_tests `no-std` build
Matt Corallo [Wed, 15 Mar 2023 19:19:49 +0000 (19:19 +0000)]
Fix onion_message functional_tests `no-std` build

19 months agoRemove `build-features` CI flag now that its always true
Matt Corallo [Wed, 15 Mar 2023 18:18:01 +0000 (18:18 +0000)]
Remove `build-features` CI flag now that its always true

19 months agoRemove `build-no-std` CI flag now that its always true
Matt Corallo [Wed, 15 Mar 2023 18:17:02 +0000 (18:17 +0000)]
Remove `build-no-std` CI flag now that its always true

19 months agoRemove `build-net-tokio` flag in CI since its now always true
Matt Corallo [Wed, 15 Mar 2023 18:16:01 +0000 (18:16 +0000)]
Remove `build-net-tokio` flag in CI since its now always true

19 months agoBump MSRV to 1.48
Matt Corallo [Wed, 15 Mar 2023 18:08:35 +0000 (18:08 +0000)]
Bump MSRV to 1.48

1.48.0 was released at the end of 2020, nearly 2.5 years ago. It
has been the rustc available on Debian stable since bullseye,
released in 2021. supporting Debian oldstable for more than a year
seems more than sufficient time to give Debian folks to upgrade,
and bullseye is set to become `oldstable` later this year with the
release of `bookworm`, likely this summer.

This also allows us to clean up our MSRV substantially, having a
single MSRV across our crates rather than a number of separate
ones. Sadly, windows already requires 1.49.

19 months agoexpose `feerate_sat_per_1000_weight` in `ChannelDetails`
John Cantrell [Thu, 9 Mar 2023 22:00:49 +0000 (17:00 -0500)]
expose `feerate_sat_per_1000_weight` in `ChannelDetails`

renames Channel::get_feerate to get_feerate_sat_per_1000_weight

19 months agoMerge pull request #2045 from wpaulino/fix-broken-commitment-test-vectors
Matt Corallo [Tue, 14 Mar 2023 19:01:59 +0000 (19:01 +0000)]
Merge pull request #2045 from wpaulino/fix-broken-commitment-test-vectors

Update commitment test vectors

19 months agoMerge pull request #2063 from valentinewallace/2023-03-remove-paymentpathfailed-retry
Matt Corallo [Mon, 13 Mar 2023 23:01:38 +0000 (23:01 +0000)]
Merge pull request #2063 from valentinewallace/2023-03-remove-paymentpathfailed-retry

Remove `PaymentPathFailed::retry`

19 months agoMerge pull request #2099 from tnull/2023-03-pin-ntapi-on-windows
Matt Corallo [Mon, 13 Mar 2023 17:44:08 +0000 (17:44 +0000)]
Merge pull request #2099 from tnull/2023-03-pin-ntapi-on-windows

Pin tokio to 1.26 on windows to fix CI

19 months agoMerge pull request #2091 from tnull/2023-03-expose-impl-writeable-tlv-based-enum...
Matt Corallo [Mon, 13 Mar 2023 16:32:19 +0000 (16:32 +0000)]
Merge pull request #2091 from tnull/2023-03-expose-impl-writeable-tlv-based-enum-common

19 months agoEnsure payment_params present when checking is_retryable_now
Valentine Wallace [Tue, 7 Mar 2023 22:13:57 +0000 (17:13 -0500)]
Ensure payment_params present when checking is_retryable_now

19 months agoRemove payment_params from send_payent_along_path
Valentine Wallace [Wed, 1 Mar 2023 17:11:35 +0000 (12:11 -0500)]
Remove payment_params from send_payent_along_path

It's unused since it no longer inserts it into HTLCSource

19 months agoRemove HTLCSource::OutboundRoute::payment_params
Valentine Wallace [Wed, 1 Mar 2023 17:02:52 +0000 (12:02 -0500)]
Remove HTLCSource::OutboundRoute::payment_params

No longer used since it is no longer used to construct PaymentPathFailed events

19 months agoRemove PaymentPathFailed::retry
Valentine Wallace [Wed, 1 Mar 2023 16:46:15 +0000 (11:46 -0500)]
Remove PaymentPathFailed::retry

We now support automatic retries in ChannelManager and no longer support manual
retries, so the field is useless.

19 months agoPin tokio to 1.26 on windows to fix CI
Elias Rohrer [Fri, 10 Mar 2023 21:24:39 +0000 (22:24 +0100)]
Pin tokio to 1.26 on windows to fix CI

19 months agoMerge pull request #2092 from TheBlueMatt/2023-03-find-route-id
Matt Corallo [Thu, 9 Mar 2023 21:49:09 +0000 (21:49 +0000)]
Merge pull request #2092 from TheBlueMatt/2023-03-find-route-id

Correct `outbound_payment` route-fetch calls to pass the hash + ID

19 months agoFurther simplify the `outbound_payments` failure macro 2023-03-find-route-id
Matt Corallo [Thu, 9 Mar 2023 20:06:23 +0000 (20:06 +0000)]
Further simplify the `outbound_payments` failure macro

19 months agoCorrect `outbound_payment` route-fetch calls to pass the hash + ID
Matt Corallo [Thu, 9 Mar 2023 19:23:58 +0000 (19:23 +0000)]
Correct `outbound_payment` route-fetch calls to pass the hash + ID

`Route::get_route_with_id` exists to provide users payment-specific
data when fetching a route, however we were failing to call it when
we have such info, opting for the simple `get_route` instead. This
defeats the purpose of the additional-metadata method, which we
swap to using here.

19 months agoExpose `_impl_writeable_tlv_based_enum_common` macro
Elias Rohrer [Thu, 9 Mar 2023 14:47:19 +0000 (15:47 +0100)]
Expose `_impl_writeable_tlv_based_enum_common` macro

As it isn't currently, and it's used by the exposed
`impl_writeable_tlv_based_enum`.

19 months agoMerge pull request #2079 from tnull/2023-03-add-list-channel-by-counterparty
Matt Corallo [Wed, 8 Mar 2023 21:55:32 +0000 (21:55 +0000)]
Merge pull request #2079 from tnull/2023-03-add-list-channel-by-counterparty

19 months agoMerge pull request #2078 from AdvaitPote/bigsize_tests
Matt Corallo [Wed, 8 Mar 2023 20:03:58 +0000 (20:03 +0000)]
Merge pull request #2078 from AdvaitPote/bigsize_tests

Added encoding and decoding tests for BigSize

19 months agoMerge pull request #2085 from tnull/2023-03-introduce-async-https-feature
Matt Corallo [Wed, 8 Mar 2023 19:41:10 +0000 (19:41 +0000)]
Merge pull request #2085 from tnull/2023-03-introduce-async-https-feature

Support HTTPS Esplora endpoints in `lightning-transaction-sync` via new feature

19 months agoencoding/decoding tests added for BigSize
Advait [Tue, 7 Mar 2023 07:10:46 +0000 (12:40 +0530)]
encoding/decoding tests added for BigSize

removed unnecessary debugging line

using io::Cursor in place of the std one

encoding/decoding tests added for BigSize

made the code concise

encoding/decoding tests added for BigSize

19 months agoRemove unnecessary logging imports
Elias Rohrer [Wed, 8 Mar 2023 11:11:51 +0000 (12:11 +0100)]
Remove unnecessary logging imports

19 months agoSupport HTTPS Esplora endpoints via new feature
Elias Rohrer [Wed, 8 Mar 2023 11:05:57 +0000 (12:05 +0100)]
Support HTTPS Esplora endpoints via new feature

To support HTTPS endpoints, the async HTTP library `reqwest` needs one of
the `-tls` features enabled. While the users could specify this in their
own cargo dependencies, we here provide a new `esplora-async-https`
feature for conveinience.

19 months agoMerge pull request #2084 from zpv/fix-changelog-all-paths-failed-typo
valentinewallace [Wed, 8 Mar 2023 16:59:36 +0000 (11:59 -0500)]
Merge pull request #2084 from zpv/fix-changelog-all-paths-failed-typo

Fix `all_paths_failed` typo in changelog

19 months agoMerge pull request #2081 from TheBlueMatt/2023-03-future-poll-panic
Matt Corallo [Wed, 8 Mar 2023 15:49:43 +0000 (15:49 +0000)]
Merge pull request #2081 from TheBlueMatt/2023-03-future-poll-panic

20 months agoFix `Event::PaymentPathFailed` typo in changelog
Steven Zhao [Wed, 8 Mar 2023 08:23:09 +0000 (00:23 -0800)]
Fix `Event::PaymentPathFailed` typo in changelog

20 months agoFix `all_paths_failed` typo in changelog
Steven [Wed, 8 Mar 2023 00:51:35 +0000 (16:51 -0800)]
Fix `all_paths_failed` typo in changelog

20 months agoAdd `list_channels_by_counterparty` method
Elias Rohrer [Tue, 7 Mar 2023 10:19:41 +0000 (11:19 +0100)]
Add `list_channels_by_counterparty` method

While we already provide a `list_channels` method, it could result in
quite a large `Vec<ChannelDetails>`. Here, we provide the means to query
our channels by `counterparty_node_id` and DRY up the code.

20 months agoAvoid `poll`ing completed futures in the `background-processor` 2023-03-future-poll-panic
Matt Corallo [Tue, 7 Mar 2023 18:06:12 +0000 (18:06 +0000)]
Avoid `poll`ing completed futures in the `background-processor`

`poll`ing completed futures invokes undefined behavior in Rust
(panics, etc, obviously not memory corruption as its not unsafe).
Sadly, in our futures-based version of
`lightning-background-processor` we have one case where we can
`poll` a completed future - if the timer for the network graph
prune + persist completes without a network graph to prune +
persist we'll happily poll the same future over and over again,
likely panicing in user code.

20 months agoMerge pull request #2049 from douglaz/run-clippy-fix
Matt Corallo [Mon, 6 Mar 2023 21:28:38 +0000 (21:28 +0000)]
Merge pull request #2049 from douglaz/run-clippy-fix

Run clippy fix

20 months agoRun clippy --fix and cleanup code
Allan Douglas R. de Oliveira [Mon, 27 Feb 2023 18:24:57 +0000 (18:24 +0000)]
Run clippy --fix and cleanup code

20 months agoUpdate same amount and preimage test vector
Wilmer Paulino [Wed, 22 Feb 2023 19:46:21 +0000 (11:46 -0800)]
Update same amount and preimage test vector

The amount for HTLC #6 was updated in the spec's test vectors, but the
"same amount and preimage" test vector itself was not updated, even
though the new HTLC amount resulted in a different commitment
transaction, and thus, different signatures.

20 months agoAdd missing test vector for anchors_zero_fee_htlc_tx
Wilmer Paulino [Wed, 22 Feb 2023 19:45:43 +0000 (11:45 -0800)]
Add missing test vector for anchors_zero_fee_htlc_tx

Tests the case where only one anchor output exists for the funder in the
commitment transaction due to the remote having a dust balance (in this
case, 0).

20 months agoMerge pull request #2074 from TheBlueMatt/2023-03-fix-threaded-test
Matt Corallo [Mon, 6 Mar 2023 17:26:59 +0000 (17:26 +0000)]
Merge pull request #2074 from TheBlueMatt/2023-03-fix-threaded-test

Make `fuzz_threaded_connections` more robust

20 months agoMerge pull request #2028 from TheBlueMatt/2023-02-macros-for-wilmer
Matt Corallo [Mon, 6 Mar 2023 16:56:08 +0000 (16:56 +0000)]
Merge pull request #2028 from TheBlueMatt/2023-02-macros-for-wilmer

Reduce macro usage in tests

20 months agoMerge pull request #1497 from TheBlueMatt/2022-05-no-default-opt
Matt Corallo [Sat, 4 Mar 2023 02:01:49 +0000 (02:01 +0000)]
Merge pull request #1497 from TheBlueMatt/2022-05-no-default-opt

Disable LTO builds in tests (and bump deps to -O2)

20 months agoMake `fuzz_threaded_connections` more robust 2023-03-fix-threaded-test
Matt Corallo [Sat, 4 Mar 2023 01:16:57 +0000 (01:16 +0000)]
Make `fuzz_threaded_connections` more robust

In `fuzz_threaded_connections`, if one thread is being run while
another is starved, and the running thread manages to call
`timer_tick_ocurred` twice after the starved thread constructs the
inbound connection but before it delivers the first bytes, we'll
receive an immediate error and `unwrap` it, causing failure.

The fix is trivial, simply remove the unwrap and return if we're
already disconnected when we do the initial read.

While we're here, we also reduce the frequency of the
`timer_tick_ocurred` calls to give us a chance to occasionally
deliver some additional messages.

Fixes #2073

20 months agoMerge pull request #2065 from TheBlueMatt/2023-02-0.0.114 0.0.114-bindings v0.0.114
Matt Corallo [Sat, 4 Mar 2023 01:00:06 +0000 (01:00 +0000)]
Merge pull request #2065 from TheBlueMatt/2023-02-0.0.114

Cut 0.0.114

20 months agoUpdate crate versions to 0.0.114/invoice 0.22 2023-02-0.0.114
Matt Corallo [Wed, 1 Mar 2023 05:06:03 +0000 (05:06 +0000)]
Update crate versions to 0.0.114/invoice 0.22

20 months agoAdd release notes for 0.0.114
Matt Corallo [Wed, 1 Mar 2023 05:03:21 +0000 (05:03 +0000)]
Add release notes for 0.0.114

20 months agoMerge pull request #2072 from jkczyz/2023-01-fix-scoring-div-by-zero
Matt Corallo [Sat, 4 Mar 2023 00:06:29 +0000 (00:06 +0000)]
Merge pull request #2072 from jkczyz/2023-01-fix-scoring-div-by-zero

Fix division by zero in `ProbabilisticScorer`

20 months agoMerge pull request #2071 from TheBlueMatt/2023-01-fix-fast-extra-ready-panic
Matt Corallo [Fri, 3 Mar 2023 23:32:42 +0000 (23:32 +0000)]
Merge pull request #2071 from TheBlueMatt/2023-01-fix-fast-extra-ready-panic

Fix panic on receiving `channel_ready` after 1st commitment update

20 months agoUse ProbabilisticScorer in router fuzzing, to cover overflows there
Matt Corallo [Wed, 18 Jan 2023 00:01:15 +0000 (18:01 -0600)]
Use ProbabilisticScorer in router fuzzing, to cover overflows there

20 months agoGuard against division by zero in scorer
Jeffrey Czyz [Fri, 6 Jan 2023 04:00:31 +0000 (22:00 -0600)]
Guard against division by zero in scorer

Since a node may announce that the htlc_maximum_msat of a channel is
zero, adding one to the denominator in the bucket formulas will prevent
the panic from ever happening. While the routing algorithm may never
select such a channel to score, this precaution may still be useful in
case the algorithm changes or if the scorer is used with a different
routing algorithm.

20 months agoUpdate scoring history buckets when no change
Jeffrey Czyz [Tue, 17 Jan 2023 23:36:03 +0000 (17:36 -0600)]
Update scoring history buckets when no change

Even when there is no change in min/max liquidity knowledge, tracking
should still be updated to include the additional data point.

20 months agoMerge pull request #2068 from jkczyz/2023-03-doc-fixes
Matt Corallo [Fri, 3 Mar 2023 22:19:59 +0000 (22:19 +0000)]
Merge pull request #2068 from jkczyz/2023-03-doc-fixes

Doc and build warning fixes

20 months agoMerge pull request #2069 from TheBlueMatt/2023-03-no-tx-sync-auto-std
Matt Corallo [Fri, 3 Mar 2023 22:19:46 +0000 (22:19 +0000)]
Merge pull request #2069 from TheBlueMatt/2023-03-no-tx-sync-auto-std

Do not auto-select the lightning `std` feature from tx-sync crate

20 months agoMerge pull request #2070 from TheBlueMatt/2023-03-get-key
Matt Corallo [Fri, 3 Mar 2023 22:19:37 +0000 (22:19 +0000)]
Merge pull request #2070 from TheBlueMatt/2023-03-get-key

Expose the node secret key in `{Phantom,}KeysManager`

20 months agoFix build warnings
Jeffrey Czyz [Fri, 3 Mar 2023 16:54:42 +0000 (10:54 -0600)]
Fix build warnings

20 months agoAdd more documentation about BlockSourceError
Jeffrey Czyz [Fri, 3 Mar 2023 16:09:58 +0000 (10:09 -0600)]
Add more documentation about BlockSourceError

Some BlockSource implementations provide more error details. Document
this in case users want to examine it further.

20 months agoExpose the node secret key in `{Phantom,}KeysManager` 2023-03-get-key
Matt Corallo [Fri, 3 Mar 2023 20:03:57 +0000 (20:03 +0000)]
Expose the node secret key in `{Phantom,}KeysManager`

When we removed the private keys from the signing interface we
forgot to re-add them in the public interface of our own
implementations, which users may need.

20 months agoMerge pull request #2067 from benthecarman/fix-typos
Matt Corallo [Fri, 3 Mar 2023 20:00:12 +0000 (20:00 +0000)]
Merge pull request #2067 from benthecarman/fix-typos

Fix typos in lightning-transaction-sync

20 months agoMerge pull request #2066 from TheBlueMatt/2023-02-no-enum-refs
Matt Corallo [Fri, 3 Mar 2023 19:44:40 +0000 (19:44 +0000)]
Merge pull request #2066 from TheBlueMatt/2023-02-no-enum-refs

Pass `FailureCode` to `fail_htlc_backwards` by ownership

20 months agoMerge pull request #2048 from TheBlueMatt/2023-02-send-persist-order-a
Matt Corallo [Fri, 3 Mar 2023 19:37:31 +0000 (19:37 +0000)]
Merge pull request #2048 from TheBlueMatt/2023-02-send-persist-order-a

Track claimed outbound HTLCs in ChannelMonitors

20 months agoDo not auto-select the lightning `std` feature from tx-sync crate 2023-03-no-tx-sync-auto-std
Matt Corallo [Fri, 3 Mar 2023 05:14:04 +0000 (05:14 +0000)]
Do not auto-select the lightning `std` feature from tx-sync crate

We have some downstream folks who are using LDK in wasm compiled
via the normal rust wasm path. To ensure nothing breaks they want
to use `no-std` on the lightning crate, disabling time calls as
those panic. However, the HTTP logic in
`lightning-transaction-sync` gets automatically stubbed out by the
HTTP client crates when targeting wasm via `wasm_bindgen`, so it
works fine despite the std restrictions.

In order to make both work, `lightning-transaction-sync` can remain
`std`, but needs to not automatically enable the `std` flag on the
`lightning` crate, ie by setting `default-features = false`. We do
so here.