Matt Corallo [Sat, 20 May 2023 23:31:57 +0000 (23:31 +0000)]
Move the bucketed history tracking logic into a scoring submodule
Matt Corallo [Sat, 20 May 2023 23:28:18 +0000 (23:28 +0000)]
Expose the historical success probability calculation itself
In
3f32f60ae7e75a4be96d3d5adc8d18b53445e5e5 we exposed the
historical success probability buckets directly, with a long method
doc explaining how to use it. While this is great for logging
exactly what the internal model thinks, its also helpful to let
users know what the internal model thinks the success probability
is directly, allowing them to compare route success probabilities.
Here we do so but only for the historical tracking buckets.
Matt Corallo [Sun, 9 Apr 2023 04:43:23 +0000 (04:43 +0000)]
Find payment bucket in calculate_success_probability_times_billion
This simply moves code which will simplify the next commit
somewhat.
Matt Corallo [Mon, 10 Apr 2023 22:54:48 +0000 (22:54 +0000)]
Correctly apply penalty bounds on the per-amount penalties
When we attempt to score a channel which has a success probability
very low, we may have a log well above our cut-off of two. For the
liquidity penalties this works great, we bound it by
`NEGATIVE_LOG10_UPPER_BOUND` and `min` the two scores. For the
amount liquidity penalty we didn't do any `min`ing at all.
This fix is to min the log itself first and then reuse the min'd
log in both calculations.
Matt Corallo [Mon, 10 Apr 2023 07:05:31 +0000 (07:05 +0000)]
Don't rely on `calculate_success_probability*` to handle amt > cap
Currently we let an `htlc_amount >= channel_capacity` pass through
from `penalty_msat` to
`calculate_success_probability_times_billion`, but only if its only
marginally bigger (less than 65/64ths). This is fine as
`calculate_success_probability_times_billion` handles bogus values
just fine (it will always return a zero probability in such cases).
However, this is risky, and in fact breaks in the coming commits,
so instead check it before ever calling through to the historical
bucket probability calculations.
Matt Corallo [Wed, 23 Aug 2023 20:05:40 +0000 (20:05 +0000)]
Merge pull request #2337 from alecchendev/2023-06-watchtower-support
Support third-party watchtowers in persistence pipeline
Matt Corallo [Wed, 23 Aug 2023 17:35:06 +0000 (17:35 +0000)]
Merge pull request #2412 from valentinewallace/2023-07-construct-blinded-paths
Add API for constructing blinded payment paths
Alec Chen [Tue, 11 Jul 2023 22:20:54 +0000 (17:20 -0500)]
Test justice tx formation from persistence
Here we implement `WatchtowerPersister`, which provides a test-only
sample implementation of `Persist` similar to how we might imagine a
user to build watchtower-like functionality in the persistence pipeline.
We test that the `WatchtowerPersister` is able to successfully build and
sign a valid justice transaction that sweeps a counterparty's funds if
they broadcast an old commitment.
Alec Chen [Thu, 15 Jun 2023 03:58:10 +0000 (22:58 -0500)]
Enable signing a justice tx using the channel monitor
Alec Chen [Tue, 11 Jul 2023 22:15:11 +0000 (17:15 -0500)]
Expose revokeable output index and building a justice tx from commitment
For watchtowers to be able to build justice transactions for our
counterparty's revoked commitments, they need to be able to find the
revokeable output for them to sweep. Here we cache `to_self_delay` in
`CommitmentTransaction` to allow for finding this output on the struct
directly. We also add a simple helper method to aid in building the
initial spending transaction.
This also adds a unit test for both of these helpers, and
refactors a bit of a previous `CommitmentTransaction` unit test to make
adding these easier.
Alec Chen [Wed, 12 Jul 2023 18:14:10 +0000 (13:14 -0500)]
Enable monitor to rebuild initial counterparty commitment tx
Upon creating a channel monitor, it is provided with the initial
counterparty commitment transaction info directly before the very first
time it is persisted. Because of this, the very first counterparty
commitment is not seen as an update in the persistence pipeline, and so
our previous changes to the monitor and updates cannot be used to
reconstruct this commitment.
To be able to expose the counterparty's transaction for the very first
commitment, we add a thin wrapper around
`provide_latest_counterparty_commitment_tx`, that stores the necessary
data needed to reconstruct the initial commitment transaction in the
monitor.
Alec Chen [Wed, 9 Aug 2023 20:23:24 +0000 (15:23 -0500)]
Build and expose counterparty commitments from monitor update
Matt Corallo [Wed, 23 Aug 2023 03:30:56 +0000 (03:30 +0000)]
Remove redundant payment preimag hashing in HTLC claim pipeline
Currently, when we receive an HTLC claim from a peer, we first hash
the preimage they gave us before removing the HTLC, then
immediately pass the preimage to the inbound channel and hash the
preimage again before removing the HTLC and sending our peer an
`update_fulfill_htlc`. This second hash is actually only asserted
on, never used in any meaningful way as we have the htlc data
present in the same code.
Here we simply drop this second hash and move it into a
`debug_assert`.
Matt Corallo [Wed, 23 Aug 2023 02:57:35 +0000 (02:57 +0000)]
Include payment hash in more early payment logs
If a user has issues with a payment, the most obvious thing they'll
do is check logs for the payment hash. Thus, we should ensure our
logs that show a payment's lifecycle include the payment hash and
are emitted (a) as soon as LDK learns of the payment, (b) once the
payment goes out to the peer (which is already reasonably covered
in the commitment transaction building logs) and (c) when the
payment ultimately is fulfilled or fails.
Here we improve our logs for both (a) and (c).
Alec Chen [Wed, 14 Jun 2023 20:14:14 +0000 (15:14 -0500)]
Add feerate and balances to `LatestCounterpartyCommitmentTXInfo`
This adds the feerate and local and remote output values to this channel
monitor update step so that a monitor can reconstruct the counterparty's
commitment transaction from an update. These commitment transactions
will be exposed to users in the following commits to support third-party
watchtowers in the persistence pipeline.
With only the HTLC outputs currently available in the monitor update, we
can tell how much of the channel balance is in-flight and towards which
side, however it doesn't tell us the amount that resides on either side.
Because of dust, we can't reliably derive the remote value from the
local value and visa versa. Thus, it seems these are the minimum fields
that need to be added.
valentinewallace [Wed, 23 Aug 2023 15:32:46 +0000 (11:32 -0400)]
Merge pull request #2492 from optout21/payment-hash-display
[minor] Add Display to Payment ID types
Valentine Wallace [Wed, 23 Aug 2023 15:24:25 +0000 (11:24 -0400)]
Document _init_and_read_* ser macro requirements
Valentine Wallace [Wed, 9 Aug 2023 21:29:35 +0000 (14:29 -0700)]
Fix documentation on onion message packet ControlTlvs
Valentine Wallace [Tue, 1 Aug 2023 18:55:27 +0000 (11:55 -0700)]
Blinded paths: rename encrypted_tlvs_ss to *_rho for precision
The previous name can be confused for the shared secret that the rho is derived
from.
Valentine Wallace [Fri, 16 Jun 2023 19:43:13 +0000 (15:43 -0400)]
Support constructing BlindedPaths for payments.
Valentine Wallace [Wed, 9 Aug 2023 21:07:58 +0000 (14:07 -0700)]
Simplify onion message blinded hop construction
Also adds a util for general blinded hop creation to be reused for blinded
payment paths.
Valentine Wallace [Fri, 23 Jun 2023 18:55:43 +0000 (14:55 -0400)]
Add new _init_and_read_tlv_stream ser macro
Useful for when you want to use _init_and_read_len_prefixed_tlv_fields but there is no
length byte at the start of the TLV stream.
optout [Wed, 23 Aug 2023 04:03:15 +0000 (06:03 +0200)]
Use Display of PaymentId&PaymentPreimage; avoid log_bytes macro
Arik [Wed, 23 Aug 2023 00:49:24 +0000 (17:49 -0700)]
Merge pull request #2441 from arik-so/2023-07-taproot-signer-wrapped
Wrapped Channel Signer Type
Arik Sosman [Wed, 16 Aug 2023 15:48:17 +0000 (08:48 -0700)]
Remove unused imports.
Remove a bunch of unnecessary ChannelManager
imports.
Arik Sosman [Fri, 21 Jul 2023 19:11:20 +0000 (12:11 -0700)]
Introduce ChannelSignerType.
Rather than using a holder_signer of a specific
signer type in Channel and ChannelContext, this
allows us to hold an enum such that depending on
the type of channel, the appropriate signer could
be held in its respective variant.
Doing so required the reparametrization of Channel
from using a Signer to using the SignerProvider
trait. This percolated down to the ChannelManager
and multiple tests.
Now, when accessign various signer methods, there
is a distinction between accessing methods defined
for all signers on ChannelSigner, and accessing
type-specific methods using accessors such as
`as_ecdsa`.
Arik Sosman [Thu, 17 Aug 2023 21:19:32 +0000 (14:19 -0700)]
Fix bench lifetimes.
Benchmarks were failing because node config and
channel monitor configs were tied to the same
lifetime.
Introducing a separate lifetime allows to avoid
out-of-order deallocation errors.
Arik Sosman [Fri, 21 Jul 2023 19:11:02 +0000 (12:11 -0700)]
Add Taproot feature support.
Introduce a Taproot feature on bits 30/31 for
initialization, node, and channel type contexts.
Arik Sosman [Tue, 22 Aug 2023 02:24:49 +0000 (19:24 -0700)]
Fix persister/chain_monitor lifetimes.
The persister and chain_monitor variables must
be declared before the node channel manager is
initialized to avoid out of order deallocation.
Matt Corallo [Tue, 22 Aug 2023 20:38:40 +0000 (20:38 +0000)]
Merge pull request #2511 from jbesraa/add-channel-id-to-spendableoutputs-event
Add channel_id to SpendableOutputs event
valentinewallace [Tue, 22 Aug 2023 20:22:16 +0000 (16:22 -0400)]
Merge pull request #2432 from jkczyz/2023-07-bolt12-node-signer
Support signing BOLT 12 messages in `NodeSigner`
Valentine Wallace [Mon, 14 Aug 2023 23:54:31 +0000 (19:54 -0400)]
Rename ser macro
We want a similar macro for reading TLV streams without a length prefix, so
rename this one to disambiguate.
Valentine Wallace [Fri, 16 Jun 2023 19:42:38 +0000 (15:42 -0400)]
Minor BlindedHop docs update
Valentine Wallace [Fri, 16 Jun 2023 18:40:28 +0000 (14:40 -0400)]
Update blinded path util to take iterator instead of slice
Useful for blinded payment path construction.
Valentine Wallace [Thu, 30 Mar 2023 03:55:59 +0000 (23:55 -0400)]
Move Padding into blinded_path module for use in blinded payments
Valentine Wallace [Fri, 16 Jun 2023 17:59:31 +0000 (13:59 -0400)]
Move blinded message path util into message submodule
Valentine Wallace [Fri, 16 Jun 2023 17:42:57 +0000 (13:42 -0400)]
Move some blinded path message code into message submodule.
We'll similarly separate blinded path payments code into its own module.
Valentine Wallace [Fri, 16 Jun 2023 17:22:53 +0000 (13:22 -0400)]
Move blinded path util into blinded_path::utils
This way it can be more easily reused for blinded payment paths.
Matt Corallo [Tue, 22 Aug 2023 17:10:59 +0000 (17:10 +0000)]
Merge pull request #2411 from valentinewallace/2023-07-blinded-onion-keys
Support constructing blinded path onion keys
optout [Tue, 22 Aug 2023 16:05:27 +0000 (18:05 +0200)]
Add Display to PaymentId & PaymentPreimage
optout [Tue, 22 Aug 2023 15:59:24 +0000 (17:59 +0200)]
Use Display of PaymentHash; avoid log_bytes macro
optout [Tue, 22 Aug 2023 15:58:39 +0000 (17:58 +0200)]
Add Display to PaymentHash
jbesraa [Mon, 21 Aug 2023 19:45:02 +0000 (22:45 +0300)]
Add channel_id to SpendableOutputs event
This will make it possible to
link between SpendableOuts and ChannelMonitor
- change channel_id to option so we dont break upgrade
- remove unused channel_id
- document channel_id
- extract channel id dynamically to pass test
- use contains to check channel_id in test as the events are not ordered
- update docs framing
- specify ldk version channel_id will be introduced in
Co-authored-by: Elias Rohrer <dev@tnull.de>
Update lightning/src/events/mod.rs
Co-authored-by: Elias Rohrer <dev@tnull.de>
Elias Rohrer [Tue, 22 Aug 2023 08:20:02 +0000 (10:20 +0200)]
Merge pull request #2507 from TheBlueMatt/2023-08-lnd-6039
Work around LND bug 6039
Jeffrey Czyz [Mon, 27 Feb 2023 18:10:32 +0000 (12:10 -0600)]
Support signing BOLT 12 invoices in NodeSigner
BOLT 12 messages need to be signed in the following scenarios:
- constructing an InvoiceRequest after scanning an Offer,
- constructing an Invoice after scanning a Refund, and
- constructing an Invoice when handling an InvoiceRequest.
Extend the NodeSigner trait to support signing BOLT 12 invoices such
that it can be used in the latter contexts. The method could be used
in an OffersMessageHandler.
Jeffrey Czyz [Tue, 11 Jul 2023 20:08:23 +0000 (15:08 -0500)]
Use TaggedHash in merkle::verify_signature
An earlier commit introduced TaggedHash for use in sign_message. For
consistency, use it in verify_signature, too.
Jeffrey Czyz [Wed, 16 Aug 2023 21:35:16 +0000 (16:35 -0500)]
Expose Offer/InvoiceRequest methods in Invoice
Bolt12Invoice can either be for an Offer (via an InvoiceRequest) or a
Refund. It wraps those types, so expose their methods on both
Bolt12Invoice and UnsignedBolt12Invoice.
Since Refund does not have all the Offer/InvoiceRequest methods, use an
Option return type such that None can returned for refund-based
invoices.
For methods that are duplicated between Offer/InvoiceRequest and
Bolt12Invoice, prefer the (non-Option, if applicable) method from
Bolt12Invoice (e.g., amount_msats, signing_pubkey).
Jeffrey Czyz [Tue, 15 Aug 2023 18:09:06 +0000 (13:09 -0500)]
Expose invoice accessors in UnsignedBolt12Invoice
Jeffrey Czyz [Tue, 15 Aug 2023 18:02:02 +0000 (13:02 -0500)]
Expose Offer accessor functions in InvoiceRequest
Also, expose both Offer and InvoiceRequest functions in
UnsignedInvoiceRequest.
Jeffrey Czyz [Tue, 15 Aug 2023 13:24:40 +0000 (08:24 -0500)]
Macro-ize InvoiceRequest accessors for reuse
Various messages wrap InvoiceRequestContents, which shouldn't be exposed
as it is an implementation detail. Define a macro for InvoiceRequest
accessor methods so that these messages can also define them.
Jeffrey Czyz [Tue, 15 Aug 2023 12:45:06 +0000 (07:45 -0500)]
Macro-ize Offer accessors for reuse
InvoiceRequest wraps OfferContents, which shouldn't be exposed as it is
an implementation detail. Define a macro for Offer accessor methods so
that InvoiceRequest and UnsignedInvoiceRequest can also define them.
Jeffrey Czyz [Sun, 13 Aug 2023 18:29:45 +0000 (13:29 -0500)]
Move BOLT 12 invoice method implementations
Jeffrey Czyz [Mon, 14 Aug 2023 17:55:34 +0000 (12:55 -0500)]
Move BOLT 12 InvoiceRequest method implementations
Jeffrey Czyz [Tue, 15 Aug 2023 02:09:57 +0000 (21:09 -0500)]
Move BOLT 12 offer method implementations
Jeffrey Czyz [Sat, 12 Aug 2023 03:13:36 +0000 (22:13 -0500)]
Unsigned BOLT 12 message parsing and serialization
Jeffrey Czyz [Sat, 12 Aug 2023 02:56:21 +0000 (21:56 -0500)]
Rename field of unsigned BOLT message contents
Using `contents` for the field name is more consistent with the signed
messages.
Jeffrey Czyz [Fri, 11 Aug 2023 18:11:14 +0000 (13:11 -0500)]
Wrap KeyPair by DerivedSigningPubkey
InvoiceBuilder is parameterized by a SigningPubkeyStrategy, either
ExplicitSigningPubkey and DerivedSigningPubkey. It also holds an
Option<KeyPair>, which may be None and Some for those strategies,
respectively. This leads to methods for InvoiceBuilder parameterized by
DerivedSigningPubkey needing to blindly unwrap the Option<KeyPair>.
Instead, have DerivedSigningPubkey wrap KeyPair.
Jeffrey Czyz [Mon, 27 Feb 2023 20:23:05 +0000 (14:23 -0600)]
TaggedHash for BOLT 12 signing function
The function used to sign BOLT 12 messages only takes a message digest.
This doesn't allow signers to independently verify the message before
signing nor does it allow them to derive the necessary signing keys, if
needed.
Introduce a TaggedHash wrapper for a message digest, which each unsigned
BOLT 12 message type constructs upon initialization. Change the signing
function to take AsRef<TaggedHash>, which each unsigned type implements.
This allows the signing function to take any unsigned message and obtain
its tagged hash.
Matt Corallo [Mon, 21 Aug 2023 23:04:47 +0000 (23:04 +0000)]
Send warning messages when repeating shutdown messages at volume
Matt Corallo [Mon, 21 Aug 2023 22:34:34 +0000 (22:34 +0000)]
Merge pull request #2498 from arik-so/arik/2023-08-gossip-logging
Improve network graph update logging
Matt Corallo [Mon, 21 Aug 2023 22:32:54 +0000 (22:32 +0000)]
Merge pull request #2478 from waterson/settle-htlcs
Provide the HTLCs that settled a payment.
Matt Corallo [Mon, 21 Aug 2023 18:02:56 +0000 (18:02 +0000)]
Merge pull request #2112 from TheBlueMatt/2023-02-sent-persist-order
Delay RAA-after-next processing until PaymentSent is are handled
Chris Waterson [Sun, 6 Aug 2023 22:39:21 +0000 (15:39 -0700)]
Provide the HTLCs that settled a payment.
Creates a new `events::ClaimedHTLC` struct that contains the relevant
information about a claimed HTLC; e.g., the channel it arrived on, its ID, the
amount of the HTLC, the overall amount of the payment, etc. Adds appropriate
serialization support.
Adds a `Vec<events::ClaimedHTLC>` to the `ClaimingPayment`
structure. Populates this when creating the struct by converting the
`payment.htlcs` (which are `ClaimingHTLC` structs) into `event::ClaimedHTLC`
structs. This is a straightforward transformation.
Adds a `Vec<events::ClaimedHTLC>` to the `events::Event::PaymentClaimed`
enum. This is populated directly from the `ClaimingPayment`'s `htlcs` vec.
Fixes #2477.
Valentine Wallace [Thu, 20 Jul 2023 17:59:23 +0000 (13:59 -0400)]
Struct-ify decoded onion failures
To avoid several long hard-to-read tuple return values.
Valentine Wallace [Sun, 13 Aug 2023 00:27:35 +0000 (20:27 -0400)]
Document and test 0-len channel update onion error case
Valentine Wallace [Thu, 20 Jul 2023 17:42:12 +0000 (13:42 -0400)]
Add missing test coverage for bogus err packet with valid hmac
Valentine Wallace [Tue, 27 Jun 2023 16:35:03 +0000 (12:35 -0400)]
Generalize next_hop_packet_pubkey onion util
Useful for generating a next hop blinding point when forwarding a blinded
payment.
Valentine Wallace [Fri, 7 Jul 2023 17:35:42 +0000 (13:35 -0400)]
Blinded paths: support constructing onion keys + handling onion errors
We don't bother actually parsing errors from within a blinded path, since all
errors should be wiped by the introduction node by the time it gets back to us
(the sender).
Matt Corallo [Thu, 17 Aug 2023 22:34:24 +0000 (22:34 +0000)]
Work around LND bug 6039
LND hasn't properly handled shutdown messages ever, and
force-closes any time we send one while HTLCs are still present.
The issue is tracked at
https://github.com/lightningnetwork/lnd/issues/6039 and has had
multiple patches to fix it but none so far have managed to land
upstream. The issue appears to be very low priority for the LND
team despite being marked "P1".
We're not going to bother handling this in a sensible way, instead
simply repeated the Shutdown message on repeat until morale
improves.
Matt Corallo [Fri, 28 Jul 2023 05:30:24 +0000 (05:30 +0000)]
Delay RAA-after-next processing until PaymentSent is are handled
In
0ad1f4c943bdc9037d0c43d1b74c745befa065f0 we fixed a nasty bug
where a failure to persist a `ChannelManager` faster than a
`ChannelMonitor` could result in the loss of a `PaymentSent` event,
eventually resulting in a `PaymentFailed` instead!
As noted in that commit, there's still some risk, though its been
substantially reduced - if we receive an `update_fulfill_htlc`
message for an outbound payment, and persist the initial removal
`ChannelMonitorUpdate`, then respond with our own
`commitment_signed` + `revoke_and_ack`, followed by receiving our
peer's final `revoke_and_ack`, and then persist the
`ChannelMonitorUpdate` generated from that, all prior to completing
a `ChannelManager` persistence, we'll still forget the HTLC and
eventually trigger a `PaymentFailed` rather than the correct
`PaymentSent`.
Here we fully fix the issue by delaying the final
`ChannelMonitorUpdate` persistence until the `PaymentSent` event
has been processed and document the fact that a spurious
`PaymentFailed` event can still be generated for a sent payment.
The original fix in
0ad1f4c943bdc9037d0c43d1b74c745befa065f0 is
still incredibly useful here, allowing us to avoid blocking the
first `ChannelMonitorUpdate` until the event processing completes,
as this would cause us to add event-processing delay in our general
commitment update latency. Instead, we ultimately race the user
handling the `PaymentSent` event with how long it takes our
`revoke_and_ack` + `commitment_signed` to make it to our
counterparty and receive the response `revoke_and_ack`. This should
give the user plenty of time to handle the event before we need to
make progress.
Sadly, because we change our `ChannelMonitorUpdate` semantics, this
change requires a number of test changes, avoiding checking for a
post-RAA `ChannelMonitorUpdate` until after we process a
`PaymentSent` event. Note that this does not apply to payments we
learned the preimage for on-chain - ensuring `PaymentSent` events
from such resolutions will be addressed in a future PR. Thus, tests
which resolve payments on-chain switch to a direct call to the
`expect_payment_sent` function with the claim-expected flag unset.
Matt Corallo [Fri, 28 Jul 2023 05:29:04 +0000 (05:29 +0000)]
Pass `OutPoint`, rather than channel id to `claim_funds_internal`
This is a trivial refactor which will be used in the next commit.
Matt Corallo [Thu, 17 Aug 2023 19:45:40 +0000 (19:45 +0000)]
Merge pull request #2506 from tnull/2023-08-dont-leak-internal-macros
Don't require import of internal macro for `impl_writeable_tlv_based`
Arik Sosman [Tue, 15 Aug 2023 05:32:09 +0000 (22:32 -0700)]
Improve network graph update logging.
Elias Rohrer [Thu, 17 Aug 2023 08:50:23 +0000 (10:50 +0200)]
Don't require import of internal macros
Commit
f560320b introduced changes that require users of
`impl_writeable_tlv_based`/`impl_writeable_tlv_based_enum` to import
`_encode_varint_length_prefixed_tlv` and `alloc` separately.
Here, we take care of the necessary imports in
`_encode_varint_length_prefixed_tlv` itself, allowing users to just
import the `impl_writeable_tlv_based` variant they need.
Elias Rohrer [Thu, 17 Aug 2023 07:05:08 +0000 (09:05 +0200)]
Merge pull request #2501 from TheBlueMatt/2023-08-err-pre-accept
Ensure we wipe pending un-accepted channel requests on err/discon.
Matt Corallo [Thu, 17 Aug 2023 03:35:56 +0000 (03:35 +0000)]
Update documentation on `Channel::set_outbound_scid_alias`
...and replace an assertion with a debug_assertion
Matt Corallo [Thu, 17 Aug 2023 03:34:22 +0000 (03:34 +0000)]
Merge pull request #2504 from alecchendev/2023-08-custom-tlvs-followup
Followup: custom HTLC TLVs
Alec Chen [Wed, 16 Aug 2023 19:02:21 +0000 (14:02 -0500)]
Address custom HTLC TLV fixups
Don't collect iterators to compare, minorly simplify encoding the
keysend TLV, combine the _encode_tlv_stream variants to check that the
ordering of TLVs is correct including custom TLVs.
Alec Chen [Wed, 16 Aug 2023 18:04:33 +0000 (13:04 -0500)]
Simplify custom HTLC TLV tests
Remove print statement, remove some unnecessary checks copied over from
test utils, make minor simplifications, wrap especially long lines.
Matt Corallo [Wed, 16 Aug 2023 05:39:50 +0000 (05:39 +0000)]
Merge pull request #2500 from TheBlueMatt/2023-08-fix-test-lifetimes
Matt Corallo [Tue, 15 Aug 2023 20:00:07 +0000 (20:00 +0000)]
Use more human-readable lifetime names in test structs
Matt Corallo [Tue, 15 Aug 2023 19:19:03 +0000 (19:19 +0000)]
Correct test struct initialization ordering
When reloading a node in the test framework, we end up with a new
`ChannelManager` that has references to various test util structs.
In order for the tests to compile reliably in the face of unrelated
changes, those test structs need to always be initialized before
both the new but also the original `ChannelManager`.
Here we make that change.
Matt Corallo [Tue, 15 Aug 2023 22:31:31 +0000 (22:31 +0000)]
Drop now-unused `outbound_scid_alias` param to channel constructor
01847277b957ec94129141a7e7439ae539c094f1 switched around the logic
for inbound channel construction to assign the outbound SCID alias
after constructing the `InboundV1Channel` object. Thus, the SCID
alias argument is now unused, and we remove it here.
Matt Corallo [Tue, 15 Aug 2023 22:22:45 +0000 (22:22 +0000)]
Ensure we wipe pending un-accepted channel requests on err/discon.
If we have a pending inbound un-accepted channel but receive an
error message for it from our peer, or our peer disconnects, we
should remove the pending entry, ensuring any attempts to accept
it fail.
Matt Corallo [Tue, 15 Aug 2023 22:15:09 +0000 (22:15 +0000)]
Merge pull request #2428 from waterson/create-channel-after-accept
Wait to create a channel until after accepting.
Matt Corallo [Tue, 15 Aug 2023 20:59:45 +0000 (20:59 +0000)]
Merge pull request #2476 from wvanlint/remove_balance_msat
Remove AvailableBalances::balance_msat
Matt Corallo [Tue, 15 Aug 2023 19:17:31 +0000 (19:17 +0000)]
Correct lifetimes on `_reload_node`
For some reason an unrelated PR caused all our tests with
`reload_node` calls to fail to compile. This is due, in part, to
the lifetimes on `reload_node` implying that the new and original
`ChannelManager` (or some of the structs they reference) must live
for the same lifetime.
This fixes that issue by correcting the lifetimes to be consistent
across `Node` and `_reload_node`.
Willem Van Lint [Sun, 6 Aug 2023 00:26:49 +0000 (17:26 -0700)]
Remove AvailableBalances::balance_msat
The ChannelMonitor::get_claimable_balances method provides a more
straightforward approach to the balance of a channel, which satisfies
most use cases. The computation of AvailableBalances::balance_msat is
complex and originally had a different purpose that is not applicable
anymore.
Matt Corallo [Mon, 14 Aug 2023 19:39:23 +0000 (19:39 +0000)]
Merge pull request #2496 from dunxen/2023-08-fix2488
Send error message to peer if we drop an unfunded channel on timeout
Valentine Wallace [Sat, 12 Aug 2023 23:11:07 +0000 (19:11 -0400)]
Wrap process_onion_failure comments at 100chars
And fix an its vs it's grammar
Valentine Wallace [Sat, 12 Aug 2023 23:02:56 +0000 (19:02 -0400)]
Clean up process_onion_failure
Get rid of a bunch of indentation and be more idiomatic.
valentinewallace [Mon, 14 Aug 2023 15:44:24 +0000 (11:44 -0400)]
Merge pull request #2458 from valentinewallace/2023-07-om-test-vectors
Onion message test vectors
Duncan Dean [Mon, 14 Aug 2023 14:21:35 +0000 (16:21 +0200)]
Send error message to peer if we drop an unfunded channel on timeout
Chris Waterson [Tue, 18 Jul 2023 14:47:44 +0000 (07:47 -0700)]
Wait to create a channel until after accepting.
Create a new table in 'peer_state' to maintain unaccepted inbound
channels; i.e., a channel for which we've received an 'open_channel'
message but that user code has not yet confirmed for acceptance. When
user code accepts the channel (e.g. via 'accept_inbound_channel'),
create the channel object and as before.
Currently, the 'open_channel' message eagerly creates an
InboundV1Channel object before determining if the channel should be
accepted. Because this happens /before/ the channel has been assigned
a user identity (which happens in the handler for OpenChannelRequest),
the channel is assigned a random user identity. As part of the
creation process, the channel's cryptographic material is initialized,
which then uses this randomly generated value for the user's channel
identity e.g. in SignerProvider::generate_channel_keys_id.
By delaying the creation of the InboundV1Channel until /after/ the
channel has been accepted, we ensure that we defer cryptographic
initialization until we have given the user the opportunity to assign
an identity to the channel.
Matt Corallo [Thu, 10 Aug 2023 22:43:21 +0000 (22:43 +0000)]
Merge pull request #2387 from vladimirfomene/add_extra_fields_to_ChannelClosed_event
Add counterparty_node_id & channel_capacity to ChannelClosed event
Matt Corallo [Thu, 10 Aug 2023 17:26:30 +0000 (17:26 +0000)]
Merge pull request #2308 from alecchendev/2023-05-custom-htlc-tlvs
Add support for custom HTLC TLVs
Matt Corallo [Wed, 9 Aug 2023 16:34:33 +0000 (16:34 +0000)]
Merge pull request #1789 from jkczyz/2022-10-scorer-decay
Smooth out channel liquidity bounds decay
Matt Corallo [Wed, 9 Aug 2023 00:40:53 +0000 (00:40 +0000)]
Merge pull request #2481 from TheBlueMatt/2023-08-keysend-robust-test
Scope payment preimage in do_test_keysend_payments
Alec Chen [Thu, 8 Jun 2023 17:08:25 +0000 (12:08 -0500)]
Enforce explicit claims on payments with even custom TLVs
Because we don't know which custom TLV type numbers the user is
expecting (and it would be cumbersome for them to tell us), instead of
failing unknown even custom TLVs on deserialization, we accept all
custom TLVs, and pass them to the user to check whether they recognize
them and choose to fail back if they don't. However, a user may not
check for custom TLVs, in which case we should reject any even custom
TLVs as unknown.
This commit makes sure a user must explicitly accept a payment with
even custom TLVs, by (1) making the default
`ChannelManager::claim_funds` fail if the payment had even custom TLVs
and (2) adding a new function
`ChannelManager::claim_funds_with_known_custom_tlvs` that accepts them.
This commit also refactors our custom TLVs test and updates various
documentation to account for this.
Alec Chen [Thu, 8 Jun 2023 04:17:09 +0000 (23:17 -0500)]
Add `FailureCode::InvalidOnionPayload` variant
When a user decodes custom TLVs, if they fail to recognize even type
numbers they should fail back with the correct failure code and fail
data. This new variant adds the proper failure variant for the user to
pass into `ChannelManager::fail_htlc_backwards_with_reason`.
Note that the enum discriminants were removed because when adding a
struct variant we can no longer make use of the discriminant through
casting like we previously did, and instead have to manually define the
associated failure code anyway.