Jeffrey Czyz [Thu, 19 Jan 2023 04:14:35 +0000 (22:14 -0600)]
Fix unused_imports warning in no-std tests
Jeffrey Czyz [Mon, 16 Jan 2023 05:59:49 +0000 (23:59 -0600)]
Invoice parsing tests
Tests for checking invoice semantics when parsing invoice bytes as
defined by BOLT 12.
Jeffrey Czyz [Mon, 16 Jan 2023 04:26:52 +0000 (22:26 -0600)]
Invoice building tests
Tests for checking invoice message semantics when building an invoice as
defined by BOLT 12.
Jeffrey Czyz [Wed, 18 Jan 2023 15:54:13 +0000 (09:54 -0600)]
Expand invoice module docs and include an example
Jeffrey Czyz [Fri, 13 Jan 2023 05:02:39 +0000 (23:02 -0600)]
Use SystemTime::now() for Invoice creation time
For std builds, Invoice::created_at can be automatically set upon
construction using SystemTime::now() offset by SystemTime::UNIX_EPOCH.
Change InvoiceRequest::respond_with and Refund::respond_with to only
take a created_at parameter in no-std builds.
Jeffrey Czyz [Tue, 20 Dec 2022 15:33:11 +0000 (09:33 -0600)]
Builder for creating invoices for refunds
Add a builder for creating invoices for a refund and required fields.
Other settings are optional and duplicative settings will override
previous settings. Building produces a semantically valid `invoice`
message for the refund, which then can be signed with the key associated
with the provided signing pubkey.
Jeffrey Czyz [Tue, 20 Dec 2022 04:23:39 +0000 (22:23 -0600)]
Builder for creating invoices for offers
Add a builder for creating invoices for an offer from a given request
and required fields. Other settings are optional and duplicative
settings will override previous settings. Building produces a
semantically valid `invoice` message for the offer, which then can be
signed with the key associated with the offer's signing pubkey.
Jeffrey Czyz [Mon, 12 Sep 2022 14:30:06 +0000 (09:30 -0500)]
Invoice encoding and parsing
Define an interface for BOLT 12 `invoice` messages. The underlying
format consists of the original bytes and the parsed contents.
The bytes are later needed for serialization. This is because it must
mirror all the `offer` and `invoice_request` TLV records, including
unknown ones, which aren't represented in the contents.
Invoices may be created for an Offer (from an InvoiceRequest) or for a
Refund. The primary difference is how the signing pubkey is given -- by
the writer of the offer or the reader of the refund.
Matt Corallo [Thu, 19 Jan 2023 18:24:30 +0000 (18:24 +0000)]
Update min-inbound-fee values on `NetworkGraph` load
Historically we've had various bugs in keeping the
`lowest_inbound_channel_fees` field in `NodeInfo` up-to-date as we
go. This leaves the A* routing less efficient as it can't prune
hops as aggressively.
In order to get accurate benchmarks, this commit updates the
minimum-inbound-fees field on load. This is not the most efficient
way of doing so, but suffices for fetching benchmarks and will be
removed in the coming commits.
Note that this is *slower* than the non-updating version in the
previous commit. While I haven't dug into this incredibly deeply,
the graph snapshot in use has min-fee info for only 9,618 of
20,818 nodes. Thus, it is my guess that with the graph snapshot
as-is the branch predictor is able to largely remove the A*
heuristic lookups, but with this change it is forced to wait for
A* heuristic map lookups to complete, causing a performance
regression.
```
test routing::router::benches::generate_mpp_routes_with_probabilistic_scorer ... bench: 182,980,059 ns/iter (+/- 32,662,047)
test routing::router::benches::generate_mpp_routes_with_zero_penalty_scorer ... bench: 151,170,457 ns/iter (+/- 75,351,011)
test routing::router::benches::generate_routes_with_probabilistic_scorer ... bench: 58,187,277 ns/iter (+/- 11,606,440)
test routing::router::benches::generate_routes_with_zero_penalty_scorer ... bench: 41,210,193 ns/iter (+/- 18,103,320)
```
Matt Corallo [Thu, 19 Jan 2023 04:41:02 +0000 (04:41 +0000)]
Update the lightning graph snapshot used in benchmarks
The previous copy was more than one and a half years old, the
lightning network has changed a lot since!
As of this commit, performance on my Xeon W-10885M with a
SK hynix Gold P31 storing a BTRFS volume is as follows:
```
test ln::channelmanager::bench::bench_sends ... bench: 5,896,492 ns/iter (+/- 512,421)
test routing::gossip::benches::read_network_graph ... bench: 1,645,740,604 ns/iter (+/- 47,611,514)
test routing::gossip::benches::write_network_graph ... bench: 234,870,775 ns/iter (+/- 8,301,775)
test routing::router::benches::generate_mpp_routes_with_probabilistic_scorer ... bench: 166,155,032 ns/iter (+/- 30,206,162)
test routing::router::benches::generate_mpp_routes_with_zero_penalty_scorer ... bench: 136,843,661 ns/iter (+/- 67,111,218)
test routing::router::benches::generate_routes_with_probabilistic_scorer ... bench: 52,954,598 ns/iter (+/- 11,360,547)
test routing::router::benches::generate_routes_with_zero_penalty_scorer ... bench: 37,598,126 ns/iter (+/- 17,262,519)
test bench::bench_sends ... bench: 37,760,922 ns/iter (+/- 5,179,123)
test bench::bench_reading_full_graph_from_file ... bench: 25,615 ns/iter (+/- 1,149)
```
Matt Corallo [Thu, 19 Jan 2023 03:49:15 +0000 (03:49 +0000)]
Merge pull request #1951 from wpaulino/remove-get-node-secret
Arik [Thu, 19 Jan 2023 01:41:54 +0000 (17:41 -0800)]
Merge pull request #1964 from TheBlueMatt/2023-01-no-debug-panics
Use test/_test_utils to enable single-threaded debug assertions
Wilmer Paulino [Wed, 18 Jan 2023 21:43:32 +0000 (13:43 -0800)]
Remove NodeSigner::get_node_secret
Secrets should not be exposed in-memory at the interface level as it
would be impossible the implement it against a hardware security
module/secure element.
Wilmer Paulino [Wed, 18 Jan 2023 21:41:27 +0000 (13:41 -0800)]
Use NodeSigner::ecdh to compute SharedSecrets
Wilmer Paulino [Wed, 18 Jan 2023 21:03:20 +0000 (13:03 -0800)]
Sign gossip messages with NodeSigner
Wilmer Paulino [Wed, 18 Jan 2023 21:03:06 +0000 (13:03 -0800)]
Add NodeSigner::sign_gossip_message
Adds signing capability to NodeSigner for all gossip messages that
require a node signature.
Matt Corallo [Thu, 19 Jan 2023 01:00:44 +0000 (01:00 +0000)]
Merge pull request #1860 from wpaulino/open-channel-anchors-support
Support opening anchor channels and test end-to-end unilateral close
Wilmer Paulino [Wed, 18 Jan 2023 20:28:42 +0000 (12:28 -0800)]
Remove unused NodeSigner implementations in tests
These implementations have every method panic, so assuming that the test
suite passes, these implementations are never used.
Matt Corallo [Tue, 17 Jan 2023 23:39:41 +0000 (23:39 +0000)]
Always set `_test_utils` when building lightning for some tests
This ensures that we hit additional assertions which are intended
to always be run in tests.
Wilmer Paulino [Thu, 25 Aug 2022 20:39:46 +0000 (13:39 -0700)]
Add test yielding anchor-related events
Wilmer Paulino [Thu, 25 Aug 2022 20:39:09 +0000 (13:39 -0700)]
Add mine_transactions test util
Wilmer Paulino [Thu, 4 Aug 2022 20:22:59 +0000 (13:22 -0700)]
Support negotiating anchors throughout channel open
Jeffrey Czyz [Thu, 22 Dec 2022 15:33:41 +0000 (09:33 -0600)]
Encoding for TLV stream without signature records
When using bytes from an InvoiceRequest to constructing bytes for an
Invoice, any signature TLV records in the bytes must be excluded. Define
a wrapper for encoding such pre-serialized bytes in this manner. This
will allow the forthcoming InvoiceBuilder to construct bytes for an
Invoice properly.
Jeffrey Czyz [Thu, 22 Dec 2022 15:10:21 +0000 (09:10 -0600)]
Define TlvStream::skip_signatures
Provide a helper for skipping signature TLV records from a TLV stream.
This prevents needing to duplicate the check for signature TLV records
when writing a TLV stream without signatures in an upcoming commit.
Jeffrey Czyz [Thu, 22 Dec 2022 15:04:48 +0000 (09:04 -0600)]
Drop AsRef<[u8]> implementation for TlvRecord
Explicitly using TlvRecord::record_bytes makes reading the code more
obvious than hiding which bytes are used in AsRef<[u8]>::as_ref.
Matt Corallo [Wed, 18 Jan 2023 21:31:07 +0000 (21:31 +0000)]
Merge pull request #1956 from TheBlueMatt/2023-01-ser-cleanups
Trivial Serialization Tweaks
Jeffrey Czyz [Wed, 18 Jan 2023 16:26:39 +0000 (10:26 -0600)]
Merge pull request #1968 from lexe-tech/max/net-tokio-no-arc
lightning-net-tokio: Don't require `Arc<PeerManager>`
Max Fang [Wed, 18 Jan 2023 04:37:10 +0000 (20:37 -0800)]
lightning-net-tokio: Don't require `Arc<PeerManager>`
Matt Corallo [Tue, 17 Jan 2023 23:48:48 +0000 (23:48 +0000)]
Merge pull request #1962 from TheBlueMatt/2023-01-bp-no-std
Use the user-provided `SleepFuture` for interval checks in `background-processor`
Matt Corallo [Tue, 17 Jan 2023 23:40:44 +0000 (23:40 +0000)]
Use `test`/`_test_utils` to enable single-threaded debug assertions
We have a number of debug assertions which are expected to never
fire when running in a single thread. This is just fine in tests,
and gives us good coverage of our lockorder requirements, but is
not-irregularly surprising to users, who may run with their own
debug assertions in test environments.
Instead, we gate these checks by the `cfg(test)` setting as well as
the `_test_utils` feature, ensuring they run in our own tests, but
not downstream tests.
Matt Corallo [Tue, 17 Jan 2023 23:39:41 +0000 (23:39 +0000)]
Always set `_test_utils` when building lightning for some tests
This ensures that we hit additional assertions which are intended
to always be run in tests.
Matt Corallo [Tue, 17 Jan 2023 23:21:22 +0000 (23:21 +0000)]
Merge pull request #1960 from tnull/2023-01-deref-router-in-invoicepayer
Make `InvoicePayer`'s `Router` `Deref`
Matt Corallo [Tue, 17 Jan 2023 23:09:05 +0000 (23:09 +0000)]
Merge pull request #1957 from TheBlueMatt/2022-01-mon-ref-lockorder
Pass MonitorUpdates by ref and tweak manager lockorder
Wilmer Paulino [Tue, 2 Aug 2022 21:48:38 +0000 (14:48 -0700)]
Define option_anchors_zero_fee_htlc_tx feature bit
Wilmer Paulino [Mon, 12 Dec 2022 23:43:40 +0000 (15:43 -0800)]
Fix stale reference to BaseSign::ready_channel
Wilmer Paulino [Thu, 8 Dec 2022 18:59:20 +0000 (10:59 -0800)]
Add missing space in DebugTx logging
Matt Corallo [Mon, 28 Nov 2022 01:00:38 +0000 (01:00 +0000)]
Use a variable-length integer for many serialization wrappers
The lightning protocol uses u16s for lengths in most cases. As our
serialization framework primarily targets that, we must as well.
However, because we may serialize objects that have more than 65K
entries, we want to be able to store larger values. Thus, we define
a variable length integer here which is backwards-compatible but
treats 0xffff as "read eight more bytes".
This doesn't address any specific known issue, but feels like good
practice just in case.
Matt Corallo [Tue, 17 Jan 2023 00:16:48 +0000 (00:16 +0000)]
Make `background-processor` no-std-friendly (ish)
This makes `background-processor` build without `std` at all. This
isn't particularly useful in the general no-std case as
`background-processor` is only useful with the `futures` feature,
and async will generally need `std` in some way or another. Still,
it ensures we don't end up reintroducing a dependency on the
current time, which breaks `wasm` use-cases.
Matt Corallo [Tue, 17 Jan 2023 17:49:29 +0000 (17:49 +0000)]
Merge pull request #1955 from TheBlueMatt/2023-01-1950-message-text
Fix link text in `reply_short_channel_ids_end`
Matt Corallo [Tue, 17 Jan 2023 17:03:13 +0000 (17:03 +0000)]
Merge pull request #1963 from lexe-tech/max/derive-debug
derive `Debug` for `ConfirmationTarget`
Max Fang [Tue, 17 Jan 2023 04:15:01 +0000 (20:15 -0800)]
derive `Debug` for `ConfirmationTarget`
Matt Corallo [Tue, 17 Jan 2023 01:26:31 +0000 (01:26 +0000)]
Merge pull request #1959 from danielgranhao/stop-passing-init-features-in-msg-handlers
Stop passing `InitFeatures` in msg handlers
Matt Corallo [Tue, 17 Jan 2023 00:55:37 +0000 (00:55 +0000)]
Merge pull request #1939 from TheBlueMatt/2022-01-fuzz-hashbrown
Misc fuzzing tweaks
Matt Corallo [Tue, 17 Jan 2023 00:03:43 +0000 (00:03 +0000)]
Use the user-provided `SleepFuture` for interval checks in BP
`background-processor` does a number of jobs on various timers.
Instead of doing those by interrogating `std::time::Instant`, this
change swaps to using the existing user-provided sleep future.
Fixes #1864.
Matt Corallo [Mon, 16 Jan 2023 23:47:11 +0000 (23:47 +0000)]
Use flexible timer types in background processor's regular jobs
`background-processor` does a number of jobs on various timers.
Currently, those are all done by checking the timers every 100ms
by interrogating `std::time::Instant`. This is fine for the
threaded version, but we'd like more flexibility in the `futures`-
based `background-processor`.
Here we swap the `std::time::Instant` interrogation for a lambda
which we will switch out to the user-provided sleeper in the next
commit.
Elias Rohrer [Mon, 16 Jan 2023 22:54:53 +0000 (16:54 -0600)]
Make `InvoicePayer`'s `Router` `Deref`
As of HEAD the `ChannelManager` is parametrized by a `Router`, while
`InvoicePayer` also owns a `Router`. In order to allow for a single
object being reused, we make the `InvoicePayer` side `Deref`.
Daniel Granhão [Mon, 16 Jan 2023 20:34:59 +0000 (20:34 +0000)]
Stop passing `InitFeatures` in msg handlers
Matt Corallo [Thu, 12 Jan 2023 02:14:20 +0000 (02:14 +0000)]
Swap per_peer_state lock order
Matt Corallo [Sat, 12 Nov 2022 18:26:38 +0000 (18:26 +0000)]
Pass monitor updates by reference, not owned
In the next commit(s) we'll start holding `ChannelMonitorUpdate`s
that are being persisted in `Channel`s until they're done
persisting. In order to do that, switch to applying the updates by
reference instead of value.
Matt Corallo [Sun, 15 Jan 2023 23:37:00 +0000 (23:37 +0000)]
Use `ChannelUnavailable` for a peer disconnecting not `MisuseError`
This fixes a crash in the `full_stack_target` fuzz test (found by
Chaincode's generous fuzzing infrastructure!) but ultimately is a
better error code - a peer disconnecting before we can fund a
channel isn't a "misuse error" its an unavailable channel.
Matt Corallo [Fri, 6 Jan 2023 20:11:27 +0000 (20:11 +0000)]
Make fuzz assertions explicit in Cargo.toml
Matt Corallo [Fri, 6 Jan 2023 20:05:07 +0000 (20:05 +0000)]
Do not rely on auto-deref'ing when aaccessing a `Hash{Map,Set}`
In newer versions of `hashbrown` this code would be broken. While
we aren't updating `hashbrown` any time soon (as it requires an
MSRV bump), it is useful to swap for a newer `hashbrown` when
fuzzing, which this makes easier.
Matt Corallo [Fri, 6 Jan 2023 19:53:47 +0000 (19:53 +0000)]
Switch to hashbrown in fuzzing
hashbrown by default uses ahash, which may be a bit faster, but
more importantly, if we upgrade to hashbrown 0.13/ahash 0.8 we can
make it use a constant randomization factor, making fuzzers happier.
Matt Corallo [Fri, 6 Jan 2023 19:52:24 +0000 (19:52 +0000)]
Bump fuzz `afl` dependency to latest upstream version
Matt Corallo [Mon, 28 Nov 2022 00:42:15 +0000 (00:42 +0000)]
Convert `Vec` de/serialization impl to a macro and impl for tuples
...to make it easier to add new implementations and implement it
for all tuples which implement `Readabe` + `Writeable`. Note that
we don't want to just convert to a blanket implementation as we'd
really like to keep our optimized `Vec<u8>` wrapper or we'll end
up spinning way too much when writing vecs of bytes.
Matt Corallo [Tue, 22 Nov 2022 22:41:13 +0000 (22:41 +0000)]
Add support for including `ignorable` types in enum de/ser macros
An enum implements de/serialization via
`impl_writeable_tlv_based_enum_upgradable` currently cannot contain
an object that only implements `MaybeReadable`.
This solves that by implementing the required blocks for
`ignorable`, opting to return `Ok(None)` in the top-level read in
cases where the inner field read returns `Ok(None)`.
Matt Corallo [Tue, 22 Nov 2022 21:55:39 +0000 (21:55 +0000)]
Implement (de)serialization for BTreeMap same as HashMap
Matt Corallo [Sun, 15 Jan 2023 07:01:30 +0000 (07:01 +0000)]
Fix link text in `reply_short_channel_ids_end`
Matt Corallo [Sun, 15 Jan 2023 07:03:14 +0000 (07:03 +0000)]
Merge pull request #1950 from tnull/2023-01-fix-doc-warnings-and-nits
Fix doc warnings and doc cleanup in `msgs.rs`/`ser.rs`
Matt Corallo [Sun, 15 Jan 2023 04:00:11 +0000 (04:00 +0000)]
Merge pull request #1946 from wpaulino/init-features-user-config
Use UserConfig to determine advertised InitFeatures by ChannelManager
Matt Corallo [Sat, 14 Jan 2023 22:43:26 +0000 (22:43 +0000)]
Merge pull request #1953 from arik-so/2023-01-debug-gossip-heisenbug
Arik Sosman [Sat, 14 Jan 2023 16:22:50 +0000 (08:22 -0800)]
Allow manually passing a timestamp to `channel_failed`. Fixes #1914.
Arik Sosman [Sat, 14 Jan 2023 15:17:12 +0000 (07:17 -0800)]
Add error messages to stale gossip cleanup assertions.
Should help debug #1914.
Wilmer Paulino [Wed, 11 Jan 2023 18:21:29 +0000 (10:21 -0800)]
Use UserConfig to determine advertised InitFeatures by ChannelManager
This is purely a refactor that does not change the InitFeatures
advertised by a ChannelManager. This allows users to configure which
features should be advertised based on the values of `UserConfig`. While
there aren't any existing features currently leveraging this behavior,
it will be used by the upcoming anchors_zero_fee_htlc_tx feature.
The UserConfig dependency on provided_init_features caused most
callsites of the main test methods responsible for opening channels to
be updated. This commit foregos that completely by no longer requiring
the InitFeatures of each side to be provided to these methods. The
methods already require a reference to each node's ChannelManager to
open the channel, so we use that same reference to obtain their
InitFeatures. A way to override such features was required for some
tests, so a new `override_init_features` config option now exists on
the test harness.
Matt Corallo [Sat, 14 Jan 2023 04:59:27 +0000 (04:59 +0000)]
Merge pull request #1930 from arik-so/2022-12-remove-keysinterface
Remove KeysInterface
Elias Rohrer [Fri, 13 Jan 2023 22:02:41 +0000 (16:02 -0600)]
Fix misc. warnings from `--document-private-items`
Elias Rohrer [Fri, 13 Jan 2023 21:54:14 +0000 (15:54 -0600)]
Fix docs and export `impl_tlv_based_enum` variants
Elias Rohrer [Fri, 13 Jan 2023 15:18:34 +0000 (09:18 -0600)]
Fix misc doc warnings.
Elias Rohrer [Fri, 13 Jan 2023 15:18:26 +0000 (09:18 -0600)]
Fix doc warnings and cleanup in `msgs.rs`
Elias Rohrer [Fri, 13 Jan 2023 13:16:18 +0000 (07:16 -0600)]
Fix doc warnings and cleanup in `ser.rs`
Arik Sosman [Fri, 13 Jan 2023 00:10:44 +0000 (16:10 -0800)]
Decouple lifetimes for trait implementations that used to comprise KeysInterface.
Arik Sosman [Tue, 20 Dec 2022 22:46:08 +0000 (14:46 -0800)]
Split up generic parameters that used to comprise KeysInterface.
Arik Sosman [Tue, 20 Dec 2022 22:46:08 +0000 (14:46 -0800)]
Remove KeysInterface trait.
Matt Corallo [Wed, 11 Jan 2023 21:02:25 +0000 (21:02 +0000)]
Merge pull request #1823 from mariocynicys/expose-tlv-macros2
Expose `impl_writeable_tlv_based` macro
Matt Corallo [Tue, 10 Jan 2023 19:19:35 +0000 (19:19 +0000)]
Merge pull request #1507 from ViktorTigerstrom/2022-05-store-channels-per-peer
Store `channels` per-peer
Matt Corallo [Tue, 10 Jan 2023 19:19:25 +0000 (19:19 +0000)]
Merge pull request #1944 from TheBlueMatt/2022-01-lockorder-windows-robust
Make `debug_sync` regex more robust
Matt Corallo [Tue, 10 Jan 2023 17:23:31 +0000 (17:23 +0000)]
Merge pull request #1943 from andrei-21/feature/handle-read-dir-errors
Handle `read_dir()` errors in persister
Matt Corallo [Tue, 10 Jan 2023 06:37:39 +0000 (06:37 +0000)]
Make `debug_sync` regex more robust
On windows the symbol names appear to sometimes be truncated,
which causes the symbol name to not include the `::new` at the end.
This causes the regex to mis-match and track the wrong location
for the mutex construction, leading to bogus lockorder violations.
For example, in testing the following symbol name appeared on
Windows, without the function name itself:
`lightning::debug_sync::RwLock<std::collections::hash::map::HashMap<lightning::chain::transaction::OutPoint,lightning::chain::chainmonitor::MonitorHolder<lightning::util::enforcing_trait_impls::EnforcingSigner>,std::collections::hash::map::RandomState> >::`
Matt Corallo [Tue, 10 Jan 2023 06:34:30 +0000 (06:34 +0000)]
Move tests from debug_sync to a new submodule
This will allow us to change the module regex match in debug_sync
to make it more robust.
Matt Corallo [Tue, 10 Jan 2023 06:29:58 +0000 (06:29 +0000)]
Move `debug_sync` to the new `sync` folder
Matt Corallo [Tue, 10 Jan 2023 06:26:46 +0000 (06:26 +0000)]
Move `no-std` sync implementations to a folder to clean up
Andrei [Tue, 10 Jan 2023 00:00:00 +0000 (00:00 +0000)]
Handle read_dir() errors in persister
Viktor Tigerström [Fri, 6 Jan 2023 23:31:10 +0000 (00:31 +0100)]
Remove the `ChannelManager::channel_state`
Viktor Tigerström [Tue, 3 Jan 2023 09:52:10 +0000 (10:52 +0100)]
Expect `pending_msg_events` to be in random peer order in tests
Viktor Tigerström [Mon, 19 Dec 2022 19:51:07 +0000 (20:51 +0100)]
Store `pending_msg_events` per peer
Viktor Tigerström [Tue, 3 Jan 2023 09:52:41 +0000 (10:52 +0100)]
Use correct node in `test_invalid_upfront_shutdown_script`
Viktor Tigerström [Sat, 10 Dec 2022 22:02:00 +0000 (23:02 +0100)]
Avoid unnecessary looping over all peers' channels
Viktor Tigerström [Sat, 10 Dec 2022 21:20:05 +0000 (22:20 +0100)]
Update `id_to_peer` docs with consistency guarantees info
Viktor Tigerström [Sat, 10 Dec 2022 17:54:01 +0000 (18:54 +0100)]
Remove one tab level when accessing a `peer_state`
Viktor Tigerström [Sat, 10 Dec 2022 17:03:22 +0000 (18:03 +0100)]
Remove unnecessary channel counterparty checks
Viktor Tigerström [Mon, 13 Jun 2022 19:24:51 +0000 (21:24 +0200)]
Add handle unkown peer test
Viktor Tigerström [Tue, 31 May 2022 19:20:55 +0000 (21:20 +0200)]
Add duplicate temporary_channel_id for 2 peers test
Viktor Tigerström [Mon, 6 Jun 2022 21:57:24 +0000 (23:57 +0200)]
Unify failure to query `Channel` error messages
Viktor Tigerström [Thu, 8 Dec 2022 23:59:21 +0000 (00:59 +0100)]
Avoid unnecessary immediate retake `per_peer_state` lock
Viktor Tigerström [Fri, 10 Jun 2022 00:01:36 +0000 (02:01 +0200)]
Remove unnecessary `per_peer_state` branch
After `channels` are now stored in the `per_peer_state`, some logic can
be simplified and extra accessing of the `per_peer_state` can be
removed.
Viktor Tigerström [Sat, 26 Nov 2022 08:02:20 +0000 (09:02 +0100)]
Store channels per peer
Matt Corallo [Mon, 9 Jan 2023 19:35:57 +0000 (19:35 +0000)]
Merge pull request #1941 from andrei-21/feature/rework-unwrap
Rework `unwrap()` call in persistence
Omer Yacine [Wed, 2 Nov 2022 15:32:47 +0000 (17:32 +0200)]
Fix an incorrect assertion in tlv stream encoding
Types must be unique and monotonically increasing (using < instead of <=)
Omer Yacine [Fri, 6 Jan 2023 08:18:26 +0000 (10:18 +0200)]
Expose `impl_writeable_tlv_based` macro
Every exported macro needed to have all the macros used inside it:
1- to be exported as well.
2- be called from the `$crate` namespace so it works in other crates.
Some structs in `lightning::util::ser` needed to be made public as they were used inside the exported macros.
Use the macros like this:
```Rust
lightning::impl_writeable_tlv_based!(...)
```
Matt Corallo [Mon, 9 Jan 2023 16:22:34 +0000 (16:22 +0000)]
Merge pull request #1940 from TheBlueMatt/2023-01-nostd-try-lock