Jeffrey Czyz [Tue, 5 Sep 2023 19:32:53 +0000 (14:32 -0500)]
Configure BOLT 12 invoice payment retry strategy
Replace a constant three retry attempts for BOLT 12 invoice payments
with a retry strategy specified when creating a pending outbound
payment. This is configured by users in a later commit when constructing
an InvoiceRequest or a Refund.
Jeffrey Czyz [Tue, 5 Sep 2023 20:21:35 +0000 (15:21 -0500)]
Use u32 instead of usize in Retry::Attempts
An upcoming commit requires serializing Retry, so use a type with a
fixed byte length. Otherwise, using eight bytes to serialize a usize
would fail to read on 32-bit machines.
Jeffrey Czyz [Thu, 31 Aug 2023 22:22:31 +0000 (17:22 -0500)]
Add tests for send_payment_for_bolt12_invoice
Jeffrey Czyz [Thu, 31 Aug 2023 22:19:29 +0000 (17:19 -0500)]
pub(crate) visibility for offers/test_utils.rs
The test utilities for Offers are needed for testing message handling in
ChannelManager and OutboundPayments.
Jeffrey Czyz [Fri, 1 Sep 2023 19:01:24 +0000 (14:01 -0500)]
Support paying BOLT 12 invoices
Add a send_payment_for_bolt12_invoice method to OutboundPayments for
initiating payment of a BOLT 12 invoice. This will be called from an
OffersMessageHandler, after which any retries are handled using the
Retryable logic.
Jeffrey Czyz [Wed, 6 Sep 2023 19:31:57 +0000 (14:31 -0500)]
Rename OutboundPayments::retry_payment_internal
It will be used for initial attempts at paying BOLT 12 invoices, so
rename it something that covers both that and retries.
Jeffrey Czyz [Fri, 1 Sep 2023 21:23:27 +0000 (16:23 -0500)]
Refactor OutboundPayments::retry_payment_internal
Consolidate the creation and insertion of onion_session_privs to the
PendingOutboundPayment::Retryable arm. In an upcoming commit, this
method will be reused for an initial BOLT 12 invoice payment. However,
onion_session_privs are created using a different helper.
Jeffrey Czyz [Wed, 30 Aug 2023 17:01:15 +0000 (12:01 -0500)]
Add PendingOutboundPayment::InvoiceReceived
When a BOLT 12 invoice has been received, a payment attempt is made and
any errors result in abandoning the PendingOutboundPayment. This results
in generating at PaymentFailed event, which has a PaymentHash. Thus,
when receiving an invoice, transition from AwaitingInvoice to a new
InvoiceReceived state, the latter of which contains a PaymentHash such
the abandon_payment helper can still be used.
Jeffrey Czyz [Wed, 6 Sep 2023 20:17:01 +0000 (15:17 -0500)]
Test removing abandoned AwaitingInvoice payments
Jeffrey Czyz [Thu, 31 Aug 2023 01:22:18 +0000 (20:22 -0500)]
Test for removing stale AwaitingInvoice payments
Jeffrey Czyz [Wed, 6 Sep 2023 18:56:46 +0000 (13:56 -0500)]
Move IDEMPOTENCY_TIMEOUT_TICKS to where it is used
Jeffrey Czyz [Mon, 17 Jul 2023 21:55:22 +0000 (16:55 -0500)]
Add PendingOutboundPayment::AwaitingInvoice
When a BOLT 12 invoice has been requested, in order to guarantee
invoice payment idempotency the future payment needs to be tracked. Add
an AwaitingInvoice variant to PendingOutboundPayment such that only
requested invoices are paid only once. Timeout after a few timer ticks
if a request has not been received.
Elias Rohrer [Mon, 21 Aug 2023 14:17:35 +0000 (16:17 +0200)]
Add `TestStore` implementation of `KVStore`
Elias Rohrer [Fri, 4 Aug 2023 09:34:45 +0000 (11:34 +0200)]
Add benchmarking for `FilesystemStore`
We re-add benchmarking for `FilesystemStore` now that we switched over
to it.
Elias Rohrer [Fri, 4 Aug 2023 14:27:39 +0000 (16:27 +0200)]
Migrate `FilesystemPersister` tests to `FilesystemStore`
Elias Rohrer [Tue, 1 Aug 2023 11:37:46 +0000 (13:37 +0200)]
Migrate to `KVStore`/`FilesystemStore`
Firstly, we switch our BP over to use `FilesystemStore`, which also gives us test
coverage and ensures the compatibility.
Then, we remove the superseded `KVStorePersister` trait and
the `FilesystemPersister` code.
Elias Rohrer [Fri, 4 Aug 2023 14:20:50 +0000 (16:20 +0200)]
Add `read_channel_monitors` utility
This replaces the `FilesystemPersister::read_channelmonitors` method, as
we can now implement a single utility for all `KVStore`s.
Elias Rohrer [Tue, 1 Aug 2023 08:46:51 +0000 (10:46 +0200)]
Add `FilesystemStore`
We upstream the `FilesystemStore` implementation, which is backwards
compatible with `lightning-persister::FilesystemPersister`.
Elias Rohrer [Fri, 4 Aug 2023 08:09:55 +0000 (10:09 +0200)]
Add `test_utils`
We add a utility function needed by upcoming `KVStore` implementation
tests.
Elias Rohrer [Mon, 21 Aug 2023 11:13:56 +0000 (13:13 +0200)]
Update `lightning-persister` crate
Elias Rohrer [Tue, 1 Aug 2023 08:24:53 +0000 (10:24 +0200)]
Add `KVStore` interface trait
We upstream the `KVStore` interface trait from LDK Node, which will
replace `KVStorePersister` in the coming commits.
Besides persistence, `KVStore` implementations will also offer to `list`
keys present in a given `namespace` and `read` the stored values.
Jeffrey Czyz [Tue, 18 Jul 2023 19:41:50 +0000 (14:41 -0500)]
Add an InvoiceRequestFailed event
When an invoice is requested but either receives an error or never
receives a response, surface an event to indicate to the user that the
corresponding future payment has failed.
Elias Rohrer [Thu, 7 Sep 2023 12:16:25 +0000 (14:16 +0200)]
Merge pull request #2134 from jbesraa/add_fromstr_to_netaddress
implement fromstr trait to netaddress
Matt Corallo [Thu, 7 Sep 2023 04:10:59 +0000 (04:10 +0000)]
Merge pull request #2557 from waterson/stale-monitor-force-close-debugging
Log each condition that was violated for a stale monitor
Chris Waterson [Wed, 6 Sep 2023 22:10:51 +0000 (15:10 -0700)]
Fix misspelling, s/and/but/.
Matt Corallo [Wed, 6 Sep 2023 20:22:08 +0000 (20:22 +0000)]
Merge pull request #2555 from tnull/2023-08-have-get-route-take-params
Have `get_route` and `Route` take `RouteParameters`
Elias Rohrer [Wed, 6 Sep 2023 09:26:13 +0000 (11:26 +0200)]
Improve `Route::get_total_amount` docs
Elias Rohrer [Wed, 6 Sep 2023 09:17:51 +0000 (11:17 +0200)]
Include overpaid value in `Route::get_total_fees`
Elias Rohrer [Thu, 31 Aug 2023 13:10:09 +0000 (15:10 +0200)]
Have `Route` hold `RouteParameters`
Elias Rohrer [Thu, 31 Aug 2023 10:25:38 +0000 (12:25 +0200)]
Have `get_route` take `RouteParameters`
jbesraa [Fri, 25 Aug 2023 02:57:56 +0000 (05:57 +0300)]
Implement `from_str` trait for `NetAddress`
- Add fuzz test for `NetAddress` `from_str` function
Chris Waterson [Wed, 6 Sep 2023 15:38:08 +0000 (08:38 -0700)]
Log each condition that was violated for a stale monitor
There are several conditions that can be violated which indicate a stale
monitor. This logs each that doesn't hold.
jbesraa [Mon, 4 Sep 2023 15:29:19 +0000 (18:29 +0300)]
Fix indent in `message_signing.rs`
jbesraa [Fri, 25 Aug 2023 02:57:06 +0000 (05:57 +0300)]
Move `zbase32` implementation to `base32` file
jbesraa [Fri, 25 Aug 2023 02:52:38 +0000 (05:52 +0300)]
Add RFC4648 base32 `encode` and `decode` functions
Matt Corallo [Tue, 5 Sep 2023 16:56:35 +0000 (16:56 +0000)]
Merge pull request #1924 from benthecarman/handle-coinbase-funding-channel
Handle if funding output is in a coinbase transaction
Elias Rohrer [Tue, 5 Sep 2023 07:19:27 +0000 (09:19 +0200)]
Merge pull request #2548 from JosephGoulden/chain-monitor-logging
Downgrade log message "Channel Monitor sync is still in progress" from info to debug
Duncan Dean [Fri, 1 Sep 2023 09:13:57 +0000 (11:13 +0200)]
Add test for coinbase funding transactions
benthecarman [Wed, 19 Apr 2023 08:53:54 +0000 (03:53 -0500)]
Support creating coinbase funding transactions in tests
benthecarman [Mon, 19 Dec 2022 08:02:22 +0000 (02:02 -0600)]
Handle if funding output is in a coinbase transaction
Joseph Goulden [Sun, 3 Sep 2023 11:48:56 +0000 (12:48 +0100)]
Downgrade log message regarding Channel Monitor sync still being in progress from info to debug
Matt Corallo [Fri, 1 Sep 2023 18:25:53 +0000 (18:25 +0000)]
Merge pull request #2522 from sr-gi/202308-set-feature
Adds a set of convenience methods to set non-custom features
Matt Corallo [Fri, 1 Sep 2023 15:13:54 +0000 (15:13 +0000)]
Merge pull request #2543 from optout21/txabort-typo
[minor] Fix wrong msg type in SendTxAbort, typo
Sergi Delgado Segura [Fri, 25 Aug 2023 08:30:07 +0000 (10:30 +0200)]
Adds a set of convenience methods to set non-custom features
Currently only custom features can be set by specifying the feature bit. Add also the
ability to do so for regular features.
Elias Rohrer [Thu, 31 Aug 2023 14:04:33 +0000 (16:04 +0200)]
Add constructor to `RouteParameters`
optout [Thu, 31 Aug 2023 22:00:13 +0000 (00:00 +0200)]
Fix wrong msg type in SendTxAbort, typo
Matt Corallo [Tue, 29 Aug 2023 19:29:21 +0000 (19:29 +0000)]
Merge pull request #2468 from jkczyz/2023-08-offer-payment-id
Offer outbound payments
Jeffrey Czyz [Fri, 21 Jul 2023 20:28:36 +0000 (15:28 -0500)]
Include PaymentId in payer metadata
When receiving a BOLT 12 invoice originating from either an invoice
request or a refund, the invoice should only be paid once. To accomplish
this, require that the invoice includes an encrypted payment id in the
payer metadata. This allows ChannelManager to track a payment when
requesting but prior to receiving the invoice. Thus, it can determine if
the invoice has already been paid.
Jeffrey Czyz [Thu, 24 Aug 2023 21:43:39 +0000 (16:43 -0500)]
Add a ChaCha20 utility for encrypting in place
Similar to ChaCha20::encrypt_single_block only encrypts in-place.
Jeffrey Czyz [Thu, 24 Aug 2023 21:31:16 +0000 (16:31 -0500)]
Add a ChaCha20 utility for encrypting a block
This hides an encryption implementation detail from callers.
Jeffrey Czyz [Thu, 24 Aug 2023 20:16:53 +0000 (15:16 -0500)]
Add an encryption key to ExpandedKey for Offers
Metadata such as the PaymentId should be encrypted when included in an
InvoiceRequest or a Refund, as it is user data and is exposed to the
payment recipient. Add an encryption key to ExpandedKey for this purpose
instead of reusing offers_base_key.
Jeffrey Czyz [Thu, 20 Jul 2023 19:50:02 +0000 (14:50 -0500)]
Remove unnecessary #[allow(unused)]
Jeffrey Czyz [Thu, 15 Jun 2023 22:13:55 +0000 (17:13 -0500)]
Split InvoiceRequest::verify_and_respond_using_derived_keys
InvoiceRequest::verify_and_respond_using_derived_keys takes a payment
hash. To avoid generating one for invoice requests that ultimately
cannot be verified, split the method into one for verifying and another
for responding.
Elias Rohrer [Tue, 29 Aug 2023 11:30:46 +0000 (13:30 +0200)]
Merge pull request #2531 from optout21/channel-id-breaking
Add ChannelId pending change note; formatting
Matt Corallo [Tue, 29 Aug 2023 00:20:44 +0000 (00:20 +0000)]
Merge pull request #2537 from TheBlueMatt/2023-08-one-less-feature-dep
Drop dep `tokio`'s `io-util` feat as it broke MSRV and isn't useful
Matt Corallo [Mon, 28 Aug 2023 19:45:37 +0000 (19:45 +0000)]
Pin the `memchr` test-only transitive dependency of `regex`
Matt Corallo [Mon, 28 Aug 2023 18:39:04 +0000 (18:39 +0000)]
Drop dep `tokio`'s `io-util` feat as it broke MSRV and isn't useful
We use `tokio`'s `io-util` feature to provide the
`Async{Read,Write}Ext` traits, which allow us to simply launch a
read future or `poll_write` directly as well as `split` the
`TcpStream` into a read/write half. However, these traits aren't
actually doing much for us - they are really just wrapping the
`readable` future (which we can trivially use ourselves) and
`poll_write` isn't doing anything for us that `poll_write_ready`
can't.
Similarly, the split logic is actually just `Arc`ing the
`TcpStream` and busy-waiting when an operation is busy to prevent
concurrent reads/writes. However, there's no reason to prevent
concurrent access at the stream level - we aren't ever concurrently
writing or reading (though we may concurrently read and write,
which is fine).
Worse, the `io-util` feature broke MSRV (though they're likely to
fix this upstream) and carries two additional dependencies (only
one on the latest upstream tokio).
Thus, we simply drop the dependency here.
Fixes #2527.
Matt Corallo [Mon, 28 Aug 2023 20:43:08 +0000 (20:43 +0000)]
Merge pull request #2536 from waterson/test-channel-signer
Rename EnforcingSigner to TestChannelSigner
Valentine Wallace [Mon, 28 Aug 2023 17:20:11 +0000 (13:20 -0400)]
Fix BlindedPath::new_for_payment docs
Matt Corallo [Mon, 28 Aug 2023 17:07:03 +0000 (17:07 +0000)]
Merge pull request #2528 from arik-so/arik/2023-08-2470-shorter-term-monitor-locks
Release monitor write lock in between update iterations
Chris Waterson [Mon, 28 Aug 2023 16:37:33 +0000 (09:37 -0700)]
Rename EnforcingSigner to TestChannelSigner
Since the advent of VLS, EnforcingSigner is only used now for testing.
optout [Mon, 28 Aug 2023 05:20:23 +0000 (07:20 +0200)]
Add ChannelId pending change note; formatting
Arik Sosman [Sat, 26 Aug 2023 00:34:10 +0000 (17:34 -0700)]
Fix flaky aggregated HTLC revocation test.
Releasing write locks in between monitor updates
requires storing a set of cloned keys to iterate
over. For efficiency purposes, that set of keys
is an actual set, as opposed to array, which means
that the iteration order may not be consistent.
The test was relying on an event array index to
access the revocation transaction. We change that
to accessing a hash map keyed by the txid, fixing
the test.
Arik Sosman [Fri, 25 Aug 2023 19:31:33 +0000 (12:31 -0700)]
Release write lock between monitor update iterations.
Previously, updating block data on a chain monitor
would acquire a write lock on all of its associated
channel monitors and not release it until the loop
completed.
Now, we instead acquire it on each iteration,
fixing #2470.
Matt Corallo [Sun, 27 Aug 2023 05:18:00 +0000 (05:18 +0000)]
Merge pull request #2485 from optout21/channel-id-4struct1
Introduce new ChannelId struct
optout [Fri, 25 Aug 2023 23:30:40 +0000 (01:30 +0200)]
Use new ChannelId type
optout [Fri, 25 Aug 2023 23:15:46 +0000 (01:15 +0200)]
Add new ChannelId type; unused
Matt Corallo [Fri, 25 Aug 2023 18:48:49 +0000 (18:48 +0000)]
Merge pull request #2197 from jbesraa/feat/lockable_score_rw
add another lock to lockable_score
Elias Rohrer [Fri, 25 Aug 2023 12:10:39 +0000 (14:10 +0200)]
Merge pull request #2248 from TheBlueMatt/2023-04-gossip-check
Implement the UtxoSource interface for REST/RPC clients
Elias Rohrer [Fri, 25 Aug 2023 10:46:37 +0000 (12:46 +0200)]
Merge pull request #2503 from valentinewallace/2023-08-fix-router-debug-panic
Fix debug panic in the case where a first hop has a channel with an introduction node
Elias Rohrer [Fri, 25 Aug 2023 10:40:36 +0000 (12:40 +0200)]
Merge pull request #2466 from TheBlueMatt/2023-07-expose-success-prob
Expose the historical success probability calculation itself
jbesraa [Tue, 22 Aug 2023 15:57:06 +0000 (18:57 +0300)]
Split LockableScore responsibilities between read & write operations
- Split Score from LockableScore to ScoreLookUp to handle read
operations and ScoreUpdate to handle write operations
- Change all struct that implemented Score to implement ScoreLookUp
and/or ScoreUpdate
- Change Mutex's to RwLocks to allow multiple data readers
- Change LockableScore to Deref in ScorerAccountingForInFlightHtlcs
as we only need to read
- Add ScoreLookUp and ScoreUpdate docs
- Remove reference(&'a) and Sized from Score in ScorerAccountingForInFlightHtlcs
as Score implements Deref
- Split MultiThreadedScoreLock into MultiThreadedScoreLockWrite and MultiThreadedScoreLockRead.
After splitting LockableScore, we split MultiThreadedScoreLock following
the same way, splitting a single score into two srtucts, one for read and
other for write.
MultiThreadedScoreLock is used in c_bindings.
Matt Corallo [Thu, 24 Aug 2023 23:28:52 +0000 (23:28 +0000)]
Merge pull request #2519 from Sharmalm/main
Print contents of our own channel updates for broadcast in non-gossip logs
Valentine Wallace [Tue, 15 Aug 2023 21:32:46 +0000 (17:32 -0400)]
Router: account for blinded path fee, etc on first_hop<>intro hop add
This previously led to a debug panic in the router because we wouldn't account
for the blinded path fee when calculating first_hop<>intro_node hop's available
liquidity and construct an invalid path that forwarded more over said hop than
was actually available.
This also led to us hitting unreachable code, see direct_to_matching_intro_nodes
test description.
Lalitmohansharma1 [Thu, 24 Aug 2023 14:51:08 +0000 (20:21 +0530)]
improving message in log
Matt Corallo [Mon, 5 Jun 2023 17:22:36 +0000 (17:22 +0000)]
Fail UTXO lookups if the block doesn't have five confirmations
The BOLT spec mandates that channels not be announced until they
have at least six confirmations. This is important to enforce not
because we particularly care about any specific DoS concerns, but
because if we do not we may have to handle reorgs of channel
funding transactions which change their SCID or have conflicting
SCIDs.
Matt Corallo [Sun, 30 Apr 2023 02:06:19 +0000 (02:06 +0000)]
Add a simple naive block cache in gossip sync lookups
Matt Corallo [Sun, 30 Apr 2023 00:48:57 +0000 (00:48 +0000)]
Make the `P2PGossipSync` `UtxoLookup` exchangable without &mut self
Because a `UtxoLookup` implementation is likely to need a reference
to the `PeerManager` which contains a reference to the
`P2PGossipSync`, it is likely to be impossible to get a mutable
reference to the `P2PGossipSync` by the time we want to add a
`UtxoLookup` without a ton of boilerplate and trait wrapping.
Instead, we simply place the `UtxoLookup` in a `RwLock`, allowing
us to modify it without a mutable self reference.
The lifetime bounds updates in tests required in this commit are
entirely unclear to me, but do allow tests to continue building, so
somehow make rustc happier.
Matt Corallo [Sat, 29 Apr 2023 22:32:57 +0000 (22:32 +0000)]
Implement the `UtxoSource` interface for REST/RPC clients
In LDK, we expect users operating nodes on the public network to
implement the `UtxoSource` interface in order to validate the
gossip they receive from the network.
Sadly, because the DoS attack of flooding a node's gossip store
isn't a common issue, and because we do not provide an
implementation off-the-shelf to make doing so easily, many of our
downstream users do not have a `UtxoSource` implementation.
In order to change that, here we implement an async `UtxoSource`
in the `lightning-block-sync` crate, providing one for users who
sync the chain from Bitcoin Core's RPC or REST interfaces.
Matt Corallo [Wed, 23 Aug 2023 21:46:23 +0000 (21:46 +0000)]
Merge pull request #2515 from TheBlueMatt/2023-08-earlier-payment-hash-log
Include payment hash in more early payment logs
Matt Corallo [Wed, 23 Aug 2023 00:46:18 +0000 (00:46 +0000)]
Store a `HistoricalMinMaxBuckets` in `DirectedChannelLiquidity`
This removes the need to reconstruct the struct in a number of
places by simply creating it up front.
Matt Corallo [Sat, 20 May 2023 23:31:57 +0000 (23:31 +0000)]
Move the bucketed history tracking logic into a scoring submodule
Matt Corallo [Sat, 20 May 2023 23:28:18 +0000 (23:28 +0000)]
Expose the historical success probability calculation itself
In
3f32f60ae7e75a4be96d3d5adc8d18b53445e5e5 we exposed the
historical success probability buckets directly, with a long method
doc explaining how to use it. While this is great for logging
exactly what the internal model thinks, its also helpful to let
users know what the internal model thinks the success probability
is directly, allowing them to compare route success probabilities.
Here we do so but only for the historical tracking buckets.
Matt Corallo [Sun, 9 Apr 2023 04:43:23 +0000 (04:43 +0000)]
Find payment bucket in calculate_success_probability_times_billion
This simply moves code which will simplify the next commit
somewhat.
Matt Corallo [Mon, 10 Apr 2023 22:54:48 +0000 (22:54 +0000)]
Correctly apply penalty bounds on the per-amount penalties
When we attempt to score a channel which has a success probability
very low, we may have a log well above our cut-off of two. For the
liquidity penalties this works great, we bound it by
`NEGATIVE_LOG10_UPPER_BOUND` and `min` the two scores. For the
amount liquidity penalty we didn't do any `min`ing at all.
This fix is to min the log itself first and then reuse the min'd
log in both calculations.
Matt Corallo [Mon, 10 Apr 2023 07:05:31 +0000 (07:05 +0000)]
Don't rely on `calculate_success_probability*` to handle amt > cap
Currently we let an `htlc_amount >= channel_capacity` pass through
from `penalty_msat` to
`calculate_success_probability_times_billion`, but only if its only
marginally bigger (less than 65/64ths). This is fine as
`calculate_success_probability_times_billion` handles bogus values
just fine (it will always return a zero probability in such cases).
However, this is risky, and in fact breaks in the coming commits,
so instead check it before ever calling through to the historical
bucket probability calculations.
Matt Corallo [Wed, 23 Aug 2023 20:05:40 +0000 (20:05 +0000)]
Merge pull request #2337 from alecchendev/2023-06-watchtower-support
Support third-party watchtowers in persistence pipeline
Matt Corallo [Wed, 23 Aug 2023 17:35:06 +0000 (17:35 +0000)]
Merge pull request #2412 from valentinewallace/2023-07-construct-blinded-paths
Add API for constructing blinded payment paths
Alec Chen [Tue, 11 Jul 2023 22:20:54 +0000 (17:20 -0500)]
Test justice tx formation from persistence
Here we implement `WatchtowerPersister`, which provides a test-only
sample implementation of `Persist` similar to how we might imagine a
user to build watchtower-like functionality in the persistence pipeline.
We test that the `WatchtowerPersister` is able to successfully build and
sign a valid justice transaction that sweeps a counterparty's funds if
they broadcast an old commitment.
Alec Chen [Thu, 15 Jun 2023 03:58:10 +0000 (22:58 -0500)]
Enable signing a justice tx using the channel monitor
Alec Chen [Tue, 11 Jul 2023 22:15:11 +0000 (17:15 -0500)]
Expose revokeable output index and building a justice tx from commitment
For watchtowers to be able to build justice transactions for our
counterparty's revoked commitments, they need to be able to find the
revokeable output for them to sweep. Here we cache `to_self_delay` in
`CommitmentTransaction` to allow for finding this output on the struct
directly. We also add a simple helper method to aid in building the
initial spending transaction.
This also adds a unit test for both of these helpers, and
refactors a bit of a previous `CommitmentTransaction` unit test to make
adding these easier.
Alec Chen [Wed, 12 Jul 2023 18:14:10 +0000 (13:14 -0500)]
Enable monitor to rebuild initial counterparty commitment tx
Upon creating a channel monitor, it is provided with the initial
counterparty commitment transaction info directly before the very first
time it is persisted. Because of this, the very first counterparty
commitment is not seen as an update in the persistence pipeline, and so
our previous changes to the monitor and updates cannot be used to
reconstruct this commitment.
To be able to expose the counterparty's transaction for the very first
commitment, we add a thin wrapper around
`provide_latest_counterparty_commitment_tx`, that stores the necessary
data needed to reconstruct the initial commitment transaction in the
monitor.
Alec Chen [Wed, 9 Aug 2023 20:23:24 +0000 (15:23 -0500)]
Build and expose counterparty commitments from monitor update
Matt Corallo [Wed, 23 Aug 2023 03:30:56 +0000 (03:30 +0000)]
Remove redundant payment preimag hashing in HTLC claim pipeline
Currently, when we receive an HTLC claim from a peer, we first hash
the preimage they gave us before removing the HTLC, then
immediately pass the preimage to the inbound channel and hash the
preimage again before removing the HTLC and sending our peer an
`update_fulfill_htlc`. This second hash is actually only asserted
on, never used in any meaningful way as we have the htlc data
present in the same code.
Here we simply drop this second hash and move it into a
`debug_assert`.
Matt Corallo [Wed, 23 Aug 2023 02:57:35 +0000 (02:57 +0000)]
Include payment hash in more early payment logs
If a user has issues with a payment, the most obvious thing they'll
do is check logs for the payment hash. Thus, we should ensure our
logs that show a payment's lifecycle include the payment hash and
are emitted (a) as soon as LDK learns of the payment, (b) once the
payment goes out to the peer (which is already reasonably covered
in the commitment transaction building logs) and (c) when the
payment ultimately is fulfilled or fails.
Here we improve our logs for both (a) and (c).
Alec Chen [Wed, 14 Jun 2023 20:14:14 +0000 (15:14 -0500)]
Add feerate and balances to `LatestCounterpartyCommitmentTXInfo`
This adds the feerate and local and remote output values to this channel
monitor update step so that a monitor can reconstruct the counterparty's
commitment transaction from an update. These commitment transactions
will be exposed to users in the following commits to support third-party
watchtowers in the persistence pipeline.
With only the HTLC outputs currently available in the monitor update, we
can tell how much of the channel balance is in-flight and towards which
side, however it doesn't tell us the amount that resides on either side.
Because of dust, we can't reliably derive the remote value from the
local value and visa versa. Thus, it seems these are the minimum fields
that need to be added.
valentinewallace [Wed, 23 Aug 2023 15:32:46 +0000 (11:32 -0400)]
Merge pull request #2492 from optout21/payment-hash-display
[minor] Add Display to Payment ID types
Valentine Wallace [Wed, 23 Aug 2023 15:24:25 +0000 (11:24 -0400)]
Document _init_and_read_* ser macro requirements
Valentine Wallace [Wed, 9 Aug 2023 21:29:35 +0000 (14:29 -0700)]
Fix documentation on onion message packet ControlTlvs
Valentine Wallace [Tue, 1 Aug 2023 18:55:27 +0000 (11:55 -0700)]
Blinded paths: rename encrypted_tlvs_ss to *_rho for precision
The previous name can be confused for the shared secret that the rho is derived
from.