]> git.bitcoin.ninja Git - rust-lightning/log
rust-lightning
14 months agoSupport constructing BlindedPaths for payments.
Valentine Wallace [Fri, 16 Jun 2023 19:43:13 +0000 (15:43 -0400)]
Support constructing BlindedPaths for payments.

14 months agoSimplify onion message blinded hop construction
Valentine Wallace [Wed, 9 Aug 2023 21:07:58 +0000 (14:07 -0700)]
Simplify onion message blinded hop construction

Also adds a util for general blinded hop creation to be reused for blinded
payment paths.

14 months agoAdd new _init_and_read_tlv_stream ser macro
Valentine Wallace [Fri, 23 Jun 2023 18:55:43 +0000 (14:55 -0400)]
Add new _init_and_read_tlv_stream ser macro

Useful for when you want to use _init_and_read_len_prefixed_tlv_fields but there is no
length byte at the start of the TLV stream.

14 months agoRename ser macro
Valentine Wallace [Mon, 14 Aug 2023 23:54:31 +0000 (19:54 -0400)]
Rename ser macro

We want a similar macro for reading TLV streams without a length prefix, so
rename this one to disambiguate.

14 months agoMinor BlindedHop docs update
Valentine Wallace [Fri, 16 Jun 2023 19:42:38 +0000 (15:42 -0400)]
Minor BlindedHop docs update

14 months agoUpdate blinded path util to take iterator instead of slice
Valentine Wallace [Fri, 16 Jun 2023 18:40:28 +0000 (14:40 -0400)]
Update blinded path util to take iterator instead of slice

Useful for blinded payment path construction.

14 months agoMove Padding into blinded_path module for use in blinded payments
Valentine Wallace [Thu, 30 Mar 2023 03:55:59 +0000 (23:55 -0400)]
Move Padding into blinded_path module for use in blinded payments

14 months agoMove blinded message path util into message submodule
Valentine Wallace [Fri, 16 Jun 2023 17:59:31 +0000 (13:59 -0400)]
Move blinded message path util into message submodule

14 months agoMove some blinded path message code into message submodule.
Valentine Wallace [Fri, 16 Jun 2023 17:42:57 +0000 (13:42 -0400)]
Move some blinded path message code into message submodule.

We'll similarly separate blinded path payments code into its own module.

14 months agoMove blinded path util into blinded_path::utils
Valentine Wallace [Fri, 16 Jun 2023 17:22:53 +0000 (13:22 -0400)]
Move blinded path util into blinded_path::utils

This way it can be more easily reused for blinded payment paths.

14 months agoMerge pull request #2411 from valentinewallace/2023-07-blinded-onion-keys
Matt Corallo [Tue, 22 Aug 2023 17:10:59 +0000 (17:10 +0000)]
Merge pull request #2411 from valentinewallace/2023-07-blinded-onion-keys

Support constructing blinded path onion keys

14 months agoMerge pull request #2507 from TheBlueMatt/2023-08-lnd-6039
Elias Rohrer [Tue, 22 Aug 2023 08:20:02 +0000 (10:20 +0200)]
Merge pull request #2507 from TheBlueMatt/2023-08-lnd-6039

Work around LND bug 6039

14 months agoSend warning messages when repeating shutdown messages at volume 2023-08-lnd-6039
Matt Corallo [Mon, 21 Aug 2023 23:04:47 +0000 (23:04 +0000)]
Send warning messages when repeating shutdown messages at volume

14 months agoMerge pull request #2498 from arik-so/arik/2023-08-gossip-logging
Matt Corallo [Mon, 21 Aug 2023 22:34:34 +0000 (22:34 +0000)]
Merge pull request #2498 from arik-so/arik/2023-08-gossip-logging

Improve network graph update logging

14 months agoMerge pull request #2478 from waterson/settle-htlcs
Matt Corallo [Mon, 21 Aug 2023 22:32:54 +0000 (22:32 +0000)]
Merge pull request #2478 from waterson/settle-htlcs

Provide the HTLCs that settled a payment.

14 months agoMerge pull request #2112 from TheBlueMatt/2023-02-sent-persist-order
Matt Corallo [Mon, 21 Aug 2023 18:02:56 +0000 (18:02 +0000)]
Merge pull request #2112 from TheBlueMatt/2023-02-sent-persist-order

Delay RAA-after-next processing until PaymentSent is are handled

14 months agoProvide the HTLCs that settled a payment.
Chris Waterson [Sun, 6 Aug 2023 22:39:21 +0000 (15:39 -0700)]
Provide the HTLCs that settled a payment.

Creates a new `events::ClaimedHTLC` struct that contains the relevant
information about a claimed HTLC; e.g., the channel it arrived on, its ID, the
amount of the HTLC, the overall amount of the payment, etc. Adds appropriate
serialization support.

Adds a `Vec<events::ClaimedHTLC>` to the `ClaimingPayment`
structure. Populates this when creating the struct by converting the
`payment.htlcs` (which are `ClaimingHTLC` structs) into `event::ClaimedHTLC`
structs. This is a straightforward transformation.

Adds a `Vec<events::ClaimedHTLC>` to the `events::Event::PaymentClaimed`
enum. This is populated directly from the `ClaimingPayment`'s `htlcs` vec.

Fixes #2477.

14 months agoStruct-ify decoded onion failures
Valentine Wallace [Thu, 20 Jul 2023 17:59:23 +0000 (13:59 -0400)]
Struct-ify decoded onion failures

To avoid several long hard-to-read tuple return values.

14 months agoDocument and test 0-len channel update onion error case
Valentine Wallace [Sun, 13 Aug 2023 00:27:35 +0000 (20:27 -0400)]
Document and test 0-len channel update onion error case

14 months agoAdd missing test coverage for bogus err packet with valid hmac
Valentine Wallace [Thu, 20 Jul 2023 17:42:12 +0000 (13:42 -0400)]
Add missing test coverage for bogus err packet with valid hmac

14 months agoGeneralize next_hop_packet_pubkey onion util
Valentine Wallace [Tue, 27 Jun 2023 16:35:03 +0000 (12:35 -0400)]
Generalize next_hop_packet_pubkey onion util

Useful for generating a next hop blinding point when forwarding a blinded
payment.

14 months agoBlinded paths: support constructing onion keys + handling onion errors
Valentine Wallace [Fri, 7 Jul 2023 17:35:42 +0000 (13:35 -0400)]
Blinded paths: support constructing onion keys + handling onion errors

We don't bother actually parsing errors from within a blinded path, since all
errors should be wiped by the introduction node by the time it gets back to us
(the sender).

14 months agoWork around LND bug 6039
Matt Corallo [Thu, 17 Aug 2023 22:34:24 +0000 (22:34 +0000)]
Work around LND bug 6039

LND hasn't properly handled shutdown messages ever, and
force-closes any time we send one while HTLCs are still present.
The issue is tracked at
https://github.com/lightningnetwork/lnd/issues/6039 and has had
multiple patches to fix it but none so far have managed to land
upstream. The issue appears to be very low priority for the LND
team despite being marked "P1".

We're not going to bother handling this in a sensible way, instead
simply repeated the Shutdown message on repeat until morale
improves.

14 months agoDelay RAA-after-next processing until PaymentSent is are handled 2023-02-sent-persist-order
Matt Corallo [Fri, 28 Jul 2023 05:30:24 +0000 (05:30 +0000)]
Delay RAA-after-next processing until PaymentSent is are handled

In 0ad1f4c943bdc9037d0c43d1b74c745befa065f0 we fixed a nasty bug
where a failure to persist a `ChannelManager` faster than a
`ChannelMonitor` could result in the loss of a `PaymentSent` event,
eventually resulting in a `PaymentFailed` instead!

As noted in that commit, there's still some risk, though its been
substantially reduced - if we receive an `update_fulfill_htlc`
message for an outbound payment, and persist the initial removal
`ChannelMonitorUpdate`, then respond with our own
`commitment_signed` + `revoke_and_ack`, followed by receiving our
peer's final `revoke_and_ack`, and then persist the
`ChannelMonitorUpdate` generated from that, all prior to completing
a `ChannelManager` persistence, we'll still forget the HTLC and
eventually trigger a `PaymentFailed` rather than the correct
`PaymentSent`.

Here we fully fix the issue by delaying the final
`ChannelMonitorUpdate` persistence until the `PaymentSent` event
has been processed and document the fact that a spurious
`PaymentFailed` event can still be generated for a sent payment.

The original fix in 0ad1f4c943bdc9037d0c43d1b74c745befa065f0 is
still incredibly useful here, allowing us to avoid blocking the
first `ChannelMonitorUpdate` until the event processing completes,
as this would cause us to add event-processing delay in our general
commitment update latency. Instead, we ultimately race the user
handling the `PaymentSent` event with how long it takes our
`revoke_and_ack` + `commitment_signed` to make it to our
counterparty and receive the response `revoke_and_ack`. This should
give the user plenty of time to handle the event before we need to
make progress.

Sadly, because we change our `ChannelMonitorUpdate` semantics, this
change requires a number of test changes, avoiding checking for a
post-RAA `ChannelMonitorUpdate` until after we process a
`PaymentSent` event. Note that this does not apply to payments we
learned the preimage for on-chain - ensuring `PaymentSent` events
from such resolutions will be addressed in a future PR. Thus, tests
which resolve payments on-chain switch to a direct call to the
`expect_payment_sent` function with the claim-expected flag unset.

14 months agoPass `OutPoint`, rather than channel id to `claim_funds_internal`
Matt Corallo [Fri, 28 Jul 2023 05:29:04 +0000 (05:29 +0000)]
Pass `OutPoint`, rather than channel id to `claim_funds_internal`

This is a trivial refactor which will be used in the next commit.

14 months agoMerge pull request #2506 from tnull/2023-08-dont-leak-internal-macros
Matt Corallo [Thu, 17 Aug 2023 19:45:40 +0000 (19:45 +0000)]
Merge pull request #2506 from tnull/2023-08-dont-leak-internal-macros

Don't require import of internal macro for `impl_writeable_tlv_based`

14 months agoImprove network graph update logging.
Arik Sosman [Tue, 15 Aug 2023 05:32:09 +0000 (22:32 -0700)]
Improve network graph update logging.

14 months agoDon't require import of internal macros
Elias Rohrer [Thu, 17 Aug 2023 08:50:23 +0000 (10:50 +0200)]
Don't require import of internal macros

Commit f560320b introduced changes that require users of
`impl_writeable_tlv_based`/`impl_writeable_tlv_based_enum` to import
`_encode_varint_length_prefixed_tlv` and `alloc` separately.

Here, we take care of the necessary imports in
`_encode_varint_length_prefixed_tlv` itself, allowing users to just
import the `impl_writeable_tlv_based` variant they need.

14 months agoMerge pull request #2501 from TheBlueMatt/2023-08-err-pre-accept
Elias Rohrer [Thu, 17 Aug 2023 07:05:08 +0000 (09:05 +0200)]
Merge pull request #2501 from TheBlueMatt/2023-08-err-pre-accept

Ensure we wipe pending un-accepted channel requests on err/discon.

14 months agoUpdate documentation on `Channel::set_outbound_scid_alias` 2023-08-err-pre-accept
Matt Corallo [Thu, 17 Aug 2023 03:35:56 +0000 (03:35 +0000)]
Update documentation on `Channel::set_outbound_scid_alias`

...and replace an assertion with a debug_assertion

14 months agoMerge pull request #2504 from alecchendev/2023-08-custom-tlvs-followup
Matt Corallo [Thu, 17 Aug 2023 03:34:22 +0000 (03:34 +0000)]
Merge pull request #2504 from alecchendev/2023-08-custom-tlvs-followup

Followup: custom HTLC TLVs

14 months agoAddress custom HTLC TLV fixups
Alec Chen [Wed, 16 Aug 2023 19:02:21 +0000 (14:02 -0500)]
Address custom HTLC TLV fixups

Don't collect iterators to compare, minorly simplify encoding the
keysend TLV, combine the _encode_tlv_stream variants to check that the
ordering of TLVs is correct including custom TLVs.

14 months agoSimplify custom HTLC TLV tests
Alec Chen [Wed, 16 Aug 2023 18:04:33 +0000 (13:04 -0500)]
Simplify custom HTLC TLV tests

Remove print statement, remove some unnecessary checks copied over from
test utils, make minor simplifications, wrap especially long lines.

14 months agoMerge pull request #2500 from TheBlueMatt/2023-08-fix-test-lifetimes
Matt Corallo [Wed, 16 Aug 2023 05:39:50 +0000 (05:39 +0000)]
Merge pull request #2500 from TheBlueMatt/2023-08-fix-test-lifetimes

14 months agoUse more human-readable lifetime names in test structs 2023-08-fix-test-lifetimes
Matt Corallo [Tue, 15 Aug 2023 20:00:07 +0000 (20:00 +0000)]
Use more human-readable lifetime names in test structs

14 months agoCorrect test struct initialization ordering
Matt Corallo [Tue, 15 Aug 2023 19:19:03 +0000 (19:19 +0000)]
Correct test struct initialization ordering

When reloading a node in the test framework, we end up with a new
`ChannelManager` that has references to various test util structs.
In order for the tests to compile reliably in the face of unrelated
changes, those test structs need to always be initialized before
both the new but also the original `ChannelManager`.

Here we make that change.

14 months agoDrop now-unused `outbound_scid_alias` param to channel constructor
Matt Corallo [Tue, 15 Aug 2023 22:31:31 +0000 (22:31 +0000)]
Drop now-unused `outbound_scid_alias` param to channel constructor

01847277b957ec94129141a7e7439ae539c094f1 switched around the logic
for inbound channel construction to assign the outbound SCID alias
after constructing the `InboundV1Channel` object. Thus, the SCID
alias argument is now unused, and we remove it here.

14 months agoEnsure we wipe pending un-accepted channel requests on err/discon.
Matt Corallo [Tue, 15 Aug 2023 22:22:45 +0000 (22:22 +0000)]
Ensure we wipe pending un-accepted channel requests on err/discon.

If we have a pending inbound un-accepted channel but receive an
error message for it from our peer, or our peer disconnects, we
should remove the pending entry, ensuring any attempts to accept
it fail.

14 months agoMerge pull request #2428 from waterson/create-channel-after-accept
Matt Corallo [Tue, 15 Aug 2023 22:15:09 +0000 (22:15 +0000)]
Merge pull request #2428 from waterson/create-channel-after-accept

Wait to create a channel until after accepting.

14 months agoMerge pull request #2476 from wvanlint/remove_balance_msat
Matt Corallo [Tue, 15 Aug 2023 20:59:45 +0000 (20:59 +0000)]
Merge pull request #2476 from wvanlint/remove_balance_msat

Remove AvailableBalances::balance_msat

14 months agoCorrect lifetimes on `_reload_node`
Matt Corallo [Tue, 15 Aug 2023 19:17:31 +0000 (19:17 +0000)]
Correct lifetimes on `_reload_node`

For some reason an unrelated PR caused all our tests with
`reload_node` calls to fail to compile. This is due, in part, to
the lifetimes on `reload_node` implying that the new and original
`ChannelManager` (or some of the structs they reference) must live
for the same lifetime.

This fixes that issue by correcting the lifetimes to be consistent
across `Node` and `_reload_node`.

14 months agoRemove AvailableBalances::balance_msat
Willem Van Lint [Sun, 6 Aug 2023 00:26:49 +0000 (17:26 -0700)]
Remove AvailableBalances::balance_msat

The ChannelMonitor::get_claimable_balances method provides a more
straightforward approach to the balance of a channel, which satisfies
most use cases. The computation of AvailableBalances::balance_msat is
complex and originally had a different purpose that is not applicable
anymore.

14 months agoMerge pull request #2496 from dunxen/2023-08-fix2488
Matt Corallo [Mon, 14 Aug 2023 19:39:23 +0000 (19:39 +0000)]
Merge pull request #2496 from dunxen/2023-08-fix2488

Send error message to peer if we drop an unfunded channel on timeout

14 months agoWrap process_onion_failure comments at 100chars
Valentine Wallace [Sat, 12 Aug 2023 23:11:07 +0000 (19:11 -0400)]
Wrap process_onion_failure comments at 100chars

And fix an its vs it's grammar

14 months agoClean up process_onion_failure
Valentine Wallace [Sat, 12 Aug 2023 23:02:56 +0000 (19:02 -0400)]
Clean up process_onion_failure

Get rid of a bunch of indentation and be more idiomatic.

14 months agoMerge pull request #2458 from valentinewallace/2023-07-om-test-vectors
valentinewallace [Mon, 14 Aug 2023 15:44:24 +0000 (11:44 -0400)]
Merge pull request #2458 from valentinewallace/2023-07-om-test-vectors

Onion message test vectors

14 months agoSend error message to peer if we drop an unfunded channel on timeout
Duncan Dean [Mon, 14 Aug 2023 14:21:35 +0000 (16:21 +0200)]
Send error message to peer if we drop an unfunded channel on timeout

14 months agoWait to create a channel until after accepting.
Chris Waterson [Tue, 18 Jul 2023 14:47:44 +0000 (07:47 -0700)]
Wait to create a channel until after accepting.

Create a new table in 'peer_state' to maintain unaccepted inbound
channels; i.e., a channel for which we've received an 'open_channel'
message but that user code has not yet confirmed for acceptance. When
user code accepts the channel (e.g. via 'accept_inbound_channel'),
create the channel object and as before.

Currently, the 'open_channel' message eagerly creates an
InboundV1Channel object before determining if the channel should be
accepted. Because this happens /before/ the channel has been assigned
a user identity (which happens in the handler for OpenChannelRequest),
the channel is assigned a random user identity. As part of the
creation process, the channel's cryptographic material is initialized,
which then uses this randomly generated value for the user's channel
identity e.g. in SignerProvider::generate_channel_keys_id.

By delaying the creation of the InboundV1Channel until /after/ the
channel has been accepted, we ensure that we defer cryptographic
initialization until we have given the user the opportunity to assign
an identity to the channel.

14 months agoMerge pull request #2387 from vladimirfomene/add_extra_fields_to_ChannelClosed_event
Matt Corallo [Thu, 10 Aug 2023 22:43:21 +0000 (22:43 +0000)]
Merge pull request #2387 from vladimirfomene/add_extra_fields_to_ChannelClosed_event

Add counterparty_node_id & channel_capacity to ChannelClosed event

14 months agoMerge pull request #2308 from alecchendev/2023-05-custom-htlc-tlvs
Matt Corallo [Thu, 10 Aug 2023 17:26:30 +0000 (17:26 +0000)]
Merge pull request #2308 from alecchendev/2023-05-custom-htlc-tlvs

Add support for custom HTLC TLVs

14 months agoMerge pull request #1789 from jkczyz/2022-10-scorer-decay
Matt Corallo [Wed, 9 Aug 2023 16:34:33 +0000 (16:34 +0000)]
Merge pull request #1789 from jkczyz/2022-10-scorer-decay

Smooth out channel liquidity bounds decay

14 months agoMerge pull request #2481 from TheBlueMatt/2023-08-keysend-robust-test
Matt Corallo [Wed, 9 Aug 2023 00:40:53 +0000 (00:40 +0000)]
Merge pull request #2481 from TheBlueMatt/2023-08-keysend-robust-test

Scope payment preimage in do_test_keysend_payments

14 months agoEnforce explicit claims on payments with even custom TLVs
Alec Chen [Thu, 8 Jun 2023 17:08:25 +0000 (12:08 -0500)]
Enforce explicit claims on payments with even custom TLVs

Because we don't know which custom TLV type numbers the user is
expecting (and it would be cumbersome for them to tell us), instead of
failing unknown even custom TLVs on deserialization, we accept all
custom TLVs, and pass them to the user to check whether they recognize
them and choose to fail back if they don't. However, a user may not
check for custom TLVs, in which case we should reject any even custom
TLVs as unknown.

This commit makes sure a user must explicitly accept a payment with
even custom TLVs, by (1) making the default
`ChannelManager::claim_funds` fail if the payment had even custom TLVs
and (2) adding a new function
`ChannelManager::claim_funds_with_known_custom_tlvs` that accepts them.

This commit also refactors our custom TLVs test and updates various
documentation to account for this.

14 months agoAdd `FailureCode::InvalidOnionPayload` variant
Alec Chen [Thu, 8 Jun 2023 04:17:09 +0000 (23:17 -0500)]
Add `FailureCode::InvalidOnionPayload` variant

When a user decodes custom TLVs, if they fail to recognize even type
numbers they should fail back with the correct failure code and fail
data. This new variant adds the proper failure variant for the user to
pass into `ChannelManager::fail_htlc_backwards_with_reason`.

Note that the enum discriminants were removed because when adding a
struct variant we can no longer make use of the discriminant through
casting like we previously did, and instead have to manually define the
associated failure code anyway.

14 months agoDrop non-matching custom TLVs when receiving MPP
Alec Chen [Fri, 19 May 2023 20:37:47 +0000 (15:37 -0500)]
Drop non-matching custom TLVs when receiving MPP

Upon receiving multiple payment parts with custom TLVs, we fail payments
if they have any non-matching or missing even TLVs, and otherwise just
drop non-matching TLVs if they're odd.

14 months agoHandle receiving custom HTLC TLVs
Alec Chen [Wed, 17 May 2023 23:40:18 +0000 (18:40 -0500)]
Handle receiving custom HTLC TLVs

This completes basic receiver-side support for custom TLVs and adds
functional testing for sending and receiving.

14 months agoDe/serialize custom TLVs on `{Inbound,Outbound}OnionPayload`
Alec Chen [Fri, 19 May 2023 04:16:29 +0000 (23:16 -0500)]
De/serialize custom TLVs on `{Inbound,Outbound}OnionPayload`

When serialized, the TLVs in `OutboundOnionPayload`, unlike a normal
TLV stream, are prefixed with the length of the stream. To allow a user
to add arbitrary custom TLVs, we aren't able to communicate to our
serialization macros exactly which fields to expect, so this commit
adds new macro variants to allow appending an extra set of bytes (and
modifying the prefixed length accordingly).

Because the keysend preimage TLV has a type number in the custom type
range, and a user's TLVs may have type numbers above and/or below
keysend's type number, and because TLV streams must be serialized in
increasing order by type number, this commit also ensures the keysend
TLV is properly sorted/serialized amongst the custom TLVs.

14 months agoAdd custom tlvs to `PendingOutboundPayment::Retryable`
Alec Chen [Mon, 24 Jul 2023 19:04:18 +0000 (14:04 -0500)]
Add custom tlvs to `PendingOutboundPayment::Retryable`

14 months agoAllow users to provide custom TLVs through `RecipientOnionFields`
Alec Chen [Tue, 16 May 2023 22:56:28 +0000 (17:56 -0500)]
Allow users to provide custom TLVs through `RecipientOnionFields`

Custom TLVs allow users to send extra application-specific data with
a payment. These have the additional flexibility compared to
`payment_metadata` that they don't have to reflect recipient generated
data provided in an invoice, in which `payment_metadata` could be
reused.

We ensure provided type numbers are unique, increasing, and within the
experimental range with the `RecipientOnionFields::with_custom_tlvs`
method.

This begins sender-side support for custom TLVs.

14 months agoMerge pull request #2128 from valentinewallace/2023-03-route-blinding-groundwork
Matt Corallo [Tue, 8 Aug 2023 19:59:05 +0000 (19:59 +0000)]
Merge pull request #2128 from valentinewallace/2023-03-route-blinding-groundwork

Route blinding groundwork

14 months agoSmooth out channel liquidity bounds decay
Jeffrey Czyz [Fri, 21 Oct 2022 05:12:42 +0000 (00:12 -0500)]
Smooth out channel liquidity bounds decay

Decaying the channel liquidity bounds by a half life can result in a
large decrease, which may have an oscillating affect on whether a
channel is retried. Approximate an additional three-quarter life when
half of the next half life has passed to help smooth out the decay.

14 months agoAdd test coverage ChannelClosed event fields
Vladimir Fomene [Wed, 12 Jul 2023 11:58:22 +0000 (14:58 +0300)]
Add test coverage ChannelClosed event fields

14 months agoAdd counterparty_node_id & channel_capacity to ChannelClosed
Vladimir Fomene [Fri, 30 Jun 2023 10:03:26 +0000 (13:03 +0300)]
Add counterparty_node_id & channel_capacity to ChannelClosed

The current ChannelClosed event does not let
you know the counterparty during a channel close
event. This change adds the counterparty_node_id
and the channel_capacity to the ChannelClosed event.
This helps users to have more context during a
channel close event. Solves #2343

14 months agoMake CI build -> test flows test -> build. 2023-08-keysend-robust-test
Matt Corallo [Tue, 8 Aug 2023 04:19:51 +0000 (04:19 +0000)]
Make CI build -> test flows test -> build.

Doing `cargo test` causes us to build both the crate(s) themselves
and the test binaries, which depend on the main builds. However, it
can start building the test code while the actual program code for
the main crate(s) themselves are being built, making a
build -> test flow slightly slower than test -> build.

Its not really a huge deal, but I'm using `ci/ci-tests.sh` more
locally and it meaningfully changes the time-to-test-run.

14 months agoScope payment preimage in do_test_keysend_payments
Matt Corallo [Tue, 8 Aug 2023 04:15:20 +0000 (04:15 +0000)]
Scope payment preimage in do_test_keysend_payments

b0d4ab8cf8c93740674a00546be38a1a5f0a83c3 fixed a nasty bug where
we'd failed to include the payment preimage in keysend onions at
all. Ultimately, this was a test failure - the existing test suite
should which did keysend payments were not structured in a way that
would fail in this case, instead using the same preimage variable
both for sending and receiving.

Here we improve the main keysend test tweaked by b0d4ab8cf8c9374067
to make absolutely sure it cannot work if the preimage doesn't come
from the onion. We make the payment preimage on the sending side a
variable inside a scope which only exists for the send call. Once
that scope completes the payment preimage only exists in the
sending `ChannelManager`, which must have put it in the onion in
order for the receiving node to have it.

14 months agoMerge pull request #2475 from alecchendev/2023-08-actually-fix-keysend
valentinewallace [Mon, 7 Aug 2023 22:56:09 +0000 (15:56 -0700)]
Merge pull request #2475 from alecchendev/2023-08-actually-fix-keysend

Fix keysend not being sent in `OutboundPayment::send_payment_internal`

15 months agoSend keysend preimage through OutboundPayment::send_payment_internal
Alec Chen [Sat, 5 Aug 2023 00:20:46 +0000 (19:20 -0500)]
Send keysend preimage through OutboundPayment::send_payment_internal

Fixes a bug where we wouldn't use the provided keysend preimage when
piping through OutboundPayment::pay_route_internal.

Also simplifies and refactors existing keysend tests to make sure this
gets hit.

15 months agoMove keysend tests to payment_tests.rs
Alec Chen [Fri, 4 Aug 2023 23:59:05 +0000 (18:59 -0500)]
Move keysend tests to payment_tests.rs

15 months agoRemove unnecessary vecs in channel.rs
Valentine Wallace [Thu, 13 Jul 2023 02:13:06 +0000 (22:13 -0400)]
Remove unnecessary vecs in channel.rs

15 months agoReplace OnionHopData with OutboundPayload for outbound onions
Valentine Wallace [Fri, 24 Mar 2023 18:35:52 +0000 (14:35 -0400)]
Replace OnionHopData with OutboundPayload for outbound onions

Follows on from the previous commit, see its message

15 months agoReceive payment onions as new InboundPayload instead of OnionHopData
Valentine Wallace [Fri, 24 Mar 2023 16:46:16 +0000 (12:46 -0400)]
Receive payment onions as new InboundPayload instead of OnionHopData

To support route blinding, we want to split OnionHopData into two separate
structs, one for inbound onions and one for outbound onions. This is because
blinded payloads change the fields present in the onion hop data struct based
on whether we're sending vs receiving (outbound onions include encrypted blobs,
inbound onions can decrypt those blobs and contain the decrypted fields
themselves).

In upcoming commits, we'll add variants for blinded payloads to the new
InboundPayload enum.

15 months agoRemove outdated documentation of a panic
Valentine Wallace [Tue, 1 Aug 2023 21:07:51 +0000 (14:07 -0700)]
Remove outdated documentation of a panic

15 months agoRemove indentation in payment receive util
Valentine Wallace [Wed, 3 May 2023 23:15:30 +0000 (19:15 -0400)]
Remove indentation in payment receive util

This also set us up for supporting receiving blinded onion payloads.

15 months agoMerge pull request #2366 from valentinewallace/2023-05-blinded-pathfinding-fuzz
valentinewallace [Mon, 31 Jul 2023 22:27:47 +0000 (15:27 -0700)]
Merge pull request #2366 from valentinewallace/2023-05-blinded-pathfinding-fuzz

Blinded pathfinding fuzzing

15 months agoMerge pull request #2460 from TheBlueMatt/2023-07-claimable-clarify
Matt Corallo [Mon, 31 Jul 2023 17:47:33 +0000 (17:47 +0000)]
Merge pull request #2460 from TheBlueMatt/2023-07-claimable-clarify

Rename `Balance::claimable_amount_satoshis` to have a unique name

15 months agoMerge pull request #2463 from TheBlueMatt/2023-07-no-rustdoc-unicode
Matt Corallo [Mon, 31 Jul 2023 17:47:19 +0000 (17:47 +0000)]
Merge pull request #2463 from TheBlueMatt/2023-07-no-rustdoc-unicode

Drop unicode in documentation

15 months agoMerge pull request #2465 from alecchendev/2023-07-flip-keysend-feature-bit
Matt Corallo [Mon, 31 Jul 2023 17:46:57 +0000 (17:46 +0000)]
Merge pull request #2465 from alecchendev/2023-07-flip-keysend-feature-bit

Flip keysend feature bit on

15 months agoMerge pull request #2454 from optout21/unused-use
valentinewallace [Mon, 31 Jul 2023 17:35:15 +0000 (10:35 -0700)]
Merge pull request #2454 from optout21/unused-use

(Minor) Remove an unused import (ChannelSigner)

15 months agoMerge pull request #2459 from valentinewallace/2023-07-reconnect-peers-test-util
Elias Rohrer [Mon, 31 Jul 2023 13:25:05 +0000 (15:25 +0200)]
Merge pull request #2459 from valentinewallace/2023-07-reconnect-peers-test-util

Struct-ify `reconnect_nodes` test util args

15 months agoFlip keysend feature bit in node features
Alec Chen [Mon, 31 Jul 2023 02:18:43 +0000 (21:18 -0500)]
Flip keysend feature bit in node features

15 months agoDrop unicode in documentation 2023-07-no-rustdoc-unicode
Matt Corallo [Sun, 30 Jul 2023 17:10:38 +0000 (17:10 +0000)]
Drop unicode in documentation

Javadocs refuse unicode and as our rustdocs get copied over to Java
bindings (and thus get run through javadocs) we can't have unicode
in our rustdocs.

15 months agoDrop `claimable` from `Balance::claimable_amount_satoshis` fields 2023-07-claimable-clarify
Matt Corallo [Fri, 28 Jul 2023 06:20:43 +0000 (06:20 +0000)]
Drop `claimable` from `Balance::claimable_amount_satoshis` fields

In Java/TypeScript, we map enums as a base class and each variant
as a class which extends the base. In Java/TypeScript, functions
and fields share the same namespace, which means we cannot have
functions on an enum which have the same name as any fields in any
enum variants.

`Balance`'s `claimable_amount_satoshis` method aliases with fields
in each variant, and thus ultimately doesn't compile in TypeScript.

Because `Balance::claimable_amount_satoshis` has the same name as
the fields, it's also a bit confusing, as it doesn't return the
field for each variant, but sometimes returns zero if we're not
sure we can claim the balance.

Instead, we rename the fields in each enum variant to simply
`amount_satoshis`, to avoid implying that we can definitely claim
the balance.

15 months agoStruct-ify reconnect_nodes test util args
Valentine Wallace [Thu, 27 Jul 2023 22:58:07 +0000 (15:58 -0700)]
Struct-ify reconnect_nodes test util args

Makes it easier to add new arguments without a ton of resulting test changes.
Useful for route blinding testing because we need to check for malformed HTLCs,
which is not currently supported by reconnect_nodes. It also makes it easier to
tell what is being checked in relevant tests.

15 months agoAdd onion message test vectors
Valentine Wallace [Wed, 26 Jul 2023 22:13:23 +0000 (15:13 -0700)]
Add onion message test vectors

Also re-alphabetize the imports in the onion message functional tests.

Co-authored-by: Carla Kirk-Cohen <kirkcohenc@gmail.com>
15 months agoMerge pull request #2104 from douglaz/docs_fixes_channel
valentinewallace [Wed, 26 Jul 2023 21:52:15 +0000 (14:52 -0700)]
Merge pull request #2104 from douglaz/docs_fixes_channel

Docs improvements for channel

15 months agoRemove an unused use (ChannelSigner)
optout [Wed, 26 Jul 2023 19:47:40 +0000 (21:47 +0200)]
Remove an unused use (ChannelSigner)

15 months agoFuzz test blinded payment pathfinding
Valentine Wallace [Tue, 20 Jun 2023 16:59:35 +0000 (12:59 -0400)]
Fuzz test blinded payment pathfinding

15 months agoRouter fuzz: macroize first/last hops construction and pathfinding call
Valentine Wallace [Tue, 20 Jun 2023 16:54:33 +0000 (12:54 -0400)]
Router fuzz: macroize first/last hops construction and pathfinding call

For reuse in fuzzing blinded payment pathfinding, and to ensure fuzz input
values are fetched in the same order in both match arms.

15 months agoDocs improvements for channel
Allan Douglas R. de Oliveira [Tue, 14 Mar 2023 19:55:47 +0000 (19:55 +0000)]
Docs improvements for channel

15 months agoMerge pull request #2446 from TheBlueMatt/2023-07-ci-more-test
valentinewallace [Tue, 25 Jul 2023 18:07:41 +0000 (11:07 -0700)]
Merge pull request #2446 from TheBlueMatt/2023-07-ci-more-test

Run all tests first before testing more esoteric flags in CI

15 months agoMerge pull request #2448 from TheBlueMatt/2023-07-cm-clone
valentinewallace [Tue, 25 Jul 2023 17:46:48 +0000 (10:46 -0700)]
Merge pull request #2448 from TheBlueMatt/2023-07-cm-clone

Impl clone for ChannelMonitor

15 months agoMerge pull request #2370 from valentinewallace/2023-06-send-along-path-args
Matt Corallo [Mon, 24 Jul 2023 22:43:58 +0000 (22:43 +0000)]
Merge pull request #2370 from valentinewallace/2023-06-send-along-path-args

Update `send_payment_along_path` to take its args as struct

15 months agoImpl clone for ChannelMonitor 2023-07-cm-clone
benthecarman [Fri, 2 Jun 2023 16:27:51 +0000 (11:27 -0500)]
Impl clone for ChannelMonitor

This gives people more freedom with the channel monitors. For Mutiny
this would be nice for us to be able to create copies of them and pass
aorund in memory without having to serialize until we actually want to.

Originally by benthecarman <benthecarman@live.com>
Small bugfix from Matt Corallo <git@bluematt.me>

15 months agoRun all tests first before testing more esoteric flags in CI 2023-07-ci-more-test
Matt Corallo [Mon, 24 Jul 2023 22:03:15 +0000 (22:03 +0000)]
Run all tests first before testing more esoteric flags in CI

This should at least marginally more aggressively target things
which are more likely to have changed in CI, making `ci-tests.sh`
more useful as a "default" script for developers to run locally.

15 months agoMerge pull request #2431 from arik-so/2023-07-public-excess-data
Matt Corallo [Mon, 24 Jul 2023 03:52:27 +0000 (03:52 +0000)]
Merge pull request #2431 from arik-so/2023-07-public-excess-data

15 months agoMerge pull request #2444 from szabgab/https
Elias Rohrer [Sun, 23 Jul 2023 17:28:17 +0000 (19:28 +0200)]
Merge pull request #2444 from szabgab/https

http => https

15 months agohttp => https
Gabor Szabo [Sun, 23 Jul 2023 05:58:41 +0000 (08:58 +0300)]
http => https

15 months agoMerge pull request #2427 from TheBlueMatt/2023-07-cut-116 v0.0.116
Matt Corallo [Fri, 21 Jul 2023 23:15:05 +0000 (23:15 +0000)]
Merge pull request #2427 from TheBlueMatt/2023-07-cut-116

Release 0.0.116

15 months agoBump crate versions to 0.0.116 release 2023-07-cut-116
Matt Corallo [Mon, 17 Jul 2023 22:34:44 +0000 (22:34 +0000)]
Bump crate versions to 0.0.116 release

15 months agoAdd a warning on anchors and update 116 changelog for release
Matt Corallo [Mon, 17 Jul 2023 22:32:45 +0000 (22:32 +0000)]
Add a warning on anchors and update 116 changelog for release