Matt Corallo [Tue, 3 Oct 2023 17:12:08 +0000 (17:12 +0000)]
Merge pull request #2634 from TheBlueMatt/2023-09-claimable-unwrap
Avoid unwrap'ing `channel_parameters` in to_counterparty signing
Matt Corallo [Tue, 3 Oct 2023 03:52:53 +0000 (03:52 +0000)]
Clean up at least some lifetimes on `SimpleRefPeerManager`
Rather than simply a, b, c, d...we at least use names for a few
things, also splitting the reused 'f lifetime.
Matt Corallo [Tue, 3 Oct 2023 04:32:40 +0000 (04:32 +0000)]
Note when we're allowed to unwrap channel parameters in docs
This further documents the parameter-fetching utilities in
`InMemorySigner` to hopefully make them more robust against future
spurious `unwrap`s.
Matt Corallo [Tue, 3 Oct 2023 04:12:28 +0000 (04:12 +0000)]
Make `InMemorySigner` parameter-fetching utilities return `Option`s
In the previous commit we fixed a bug where we were spuriously
(indirectly) `unwrap`ing the `channel_parameters` in
`InMemorySigner`. Here we make such bugs much less likely in the
future by having the utilities which do the `unwrap`ing internally
return `Option`s instead.
This makes the `unwrap`s clear at the callsite.
Matt Corallo [Tue, 3 Oct 2023 03:56:46 +0000 (03:56 +0000)]
Merge pull request #2595 from TheBlueMatt/2023-09-117-bindings-part1
Various cleanups to make bindings generation simpler
Matt Corallo [Tue, 3 Oct 2023 03:45:03 +0000 (03:45 +0000)]
Merge pull request #2632 from TheBlueMatt/2023-09-writeable-rwlock
Implement Readable/Writeable for RwLock wrappers
Jeffrey Czyz [Tue, 3 Oct 2023 01:16:13 +0000 (20:16 -0500)]
Merge pull request #2633 from TheBlueMatt/2023-09-expose-onion-parse
Expose `parse_onion_address` publicly in `no-std`
Matt Corallo [Sun, 1 Oct 2023 00:15:22 +0000 (00:15 +0000)]
Avoid unwrap'ing `channel_parameters` in to_counterparty signing
Previously, `StaticPaymentOutputDescriptor`s did not include
`channel_parameters` for the signer. As a result, when going to
spend old `StaticPaymentOutputDescriptor`s,
`InMemorySigner::sign_counterparty_payment_input` may be called
with `channel_parameters` set to `None`. This should be fine, but
in
fa2a2efef47b5da48ac7a239f3d8a835a7f28164 we started relying on
it (indirectly via `channel_features`) for signing. This caused an
`unwrap` when spending old output descriptors.
This is fixed here by simply avoiding the unwrap and assuming old
`StaticPaymentOutputDescriptor`s represent non-anchor channels.
Matt Corallo [Sun, 1 Oct 2023 00:00:37 +0000 (00:00 +0000)]
Remove unused `mem::drop` which drops a reference
Matt Corallo [Sat, 30 Sep 2023 17:47:45 +0000 (17:47 +0000)]
Fix new unused variable warning in `test_utils.rs`
Matt Corallo [Thu, 28 Sep 2023 02:45:00 +0000 (02:45 +0000)]
Use `crate::prelude::*` to load `Vec`, rather than `crate::Vec`
This is kinda dumb, but the bindings get confused when referring
to `Vec` absolutely in a `use` statement, and there's no reason not
to load our prelude everywhere.
Matt Corallo [Wed, 27 Sep 2023 23:02:50 +0000 (23:02 +0000)]
Drop various bounds on types passed to `MonitorUpdatingPersister`
The new `MonitorUpdatingPersister` has a few redundant type bounds
(re-specified on functions after having been specified on the
struct itself), which we remove here.
Further, it requires a `Deref<FeeEstimator>` which is `Clone`able.
This is generally fine in rust, but annoying in bindings, so we
simply elide it in favor if a `&Deref<FeeEstimator>`.
Matt Corallo [Mon, 25 Sep 2023 22:10:27 +0000 (22:10 +0000)]
Make `create_onion_message` a freestanding function
The new `create_onion_message` function in `OnionMessenger` is hard
to handle - it has various generic requirements indirectly via the
struct, but they're not bounded by any of the method parameters.
Thus, you can't simply call `OnionMessenger::create_onion_message`,
as various bounds are not specified.
Instead, we move it to a freestanding function so that it can be
called directly without explicitly setting bounds.
Matt Corallo [Mon, 25 Sep 2023 22:14:04 +0000 (22:14 +0000)]
Mark `AChannelManager` no-export
The trait itself has no purpose for bindings, as all structs are
concretized anyway. Further, the bindings have specific handling
for generic bounding traits like this.
Matt Corallo [Sun, 24 Sep 2023 23:41:10 +0000 (23:41 +0000)]
Mark `SpendableOutputDescriptor::to_psbt_input` as no-export
Its honestly likely not all that useful as its not materially
interoperable with other PSBT libraries. Instead, users should
simply fetch the full PSBT and use the inputs from it as they see
fit.
Matt Corallo [Sat, 23 Sep 2023 23:34:33 +0000 (23:34 +0000)]
Drop unnecessary crate:: prefix when accessing `bitcoin` in macro
Unexported macros don't need to use the `$crate` prefix.
Matt Corallo [Fri, 22 Sep 2023 01:44:57 +0000 (01:44 +0000)]
Avoid ref to a `Vec` when accessing custom onion TLVs
The bindings can't easily return a reference to a `Vec`, so we
instead split the implementation into vec/slice depending on the
`c_bindings` flag.
Matt Corallo [Mon, 25 Sep 2023 01:05:45 +0000 (01:05 +0000)]
Avoid blanket impls in bindings builds
The C bindings implements `Deref` for all traits, so having a
blanket `Deref` implementation ends up conflicting with this.
Matt Corallo [Sun, 24 Sep 2023 23:59:13 +0000 (23:59 +0000)]
Simplify score bounding with a unified type
In a few places we require a unified scorer, which implements both
`ScoreLookUp` and `ScoreUpdate`. Rather than double-bounding (which
the bindings generator can't handle directly), we use a top-level
`Score` trait which requires both and is implemented for all
implementers of both supertraits.
Matt Corallo [Thu, 21 Sep 2023 22:54:14 +0000 (22:54 +0000)]
Remove unnecessary bounds in scoring
In our scoring logic we have a handful of unnecessary bounds,
leading to extra diff in the bindings branch when those bounds have
to be removed as well as a few cases where bindings generation
simply gets confused.
Here we remove a number of bounds across the scoring traits and
impls, cleaning things up and simplifying bindings changes.
Matt Corallo [Thu, 21 Sep 2023 22:22:18 +0000 (22:22 +0000)]
Use `Default::default()` to construct `()` as score-updating param
In
6b0d94a3029f74de3a7542cbba0d48c2f7e5866b we switched most tests
to `Default::default()` for scoring parameters passed to
route-fetching. Here we do the same for the scoring parameters when
passed to score-updating.
Matt Corallo [Sat, 30 Sep 2023 18:05:10 +0000 (18:05 +0000)]
Expose `parse_onion_address` publicly in `no-std`
The reason for having a separate `parse_onion_address` from
`FromStr` is to have an onion parsing function in `no-std`, but
when we added it we forgot to make it public. We do this here, as
well as fix a few compilation warnings in `no-std`.
Matt Corallo [Sat, 30 Sep 2023 17:40:42 +0000 (17:40 +0000)]
Switch `Simple*ChannelManager` locks around `Score` to `RwLock`
This switches the locks used around `ProbabilisticScorer` in
`Simple*ChannelManager` type aliases to `RwLock`.
Matt Corallo [Sat, 30 Sep 2023 17:32:28 +0000 (17:32 +0000)]
Fix `Simple*PeerManager` to not require refs to the `UtxoLookup`
`UtxoLookup` doesn't strictly need to be referenced from the
`PeerManager`, and in fact the new `GossipVerifier` in
`lightning-block-sync` requires itself to be owned by the
`PeerManager` (for circular type reasons).
This allows us to use `lightning-block-sync`'s `GossipVerifier`
with `SimpleArcPeerManager` in ldk-sample.
Matt Corallo [Sat, 30 Sep 2023 17:35:21 +0000 (17:35 +0000)]
Implement `Readable`/`Writeable` for `RwLock` wrappers
We now support separate R/W locks in `LockableScore`, which allow
us to do routefinding in parallel, however in order to support
`WriteableScore` for such users we need to implement `Writeable`
for `RwLock` wrappers around `Writeable` types, which we do here.
Matt Corallo [Sat, 30 Sep 2023 00:38:27 +0000 (00:38 +0000)]
Merge pull request #2630 from TheBlueMatt/2023-09-117-rc1
Bump crate versions to 0.0.117-rc1/invoice 0.25-rc1
Matt Corallo [Fri, 29 Sep 2023 23:55:04 +0000 (23:55 +0000)]
Merge pull request #2610 from wpaulino/missing-htlc-claim-balance
Fix matching of second-stage HTLC claim in get_htlc_balance
Matt Corallo [Fri, 29 Sep 2023 23:45:57 +0000 (23:45 +0000)]
Merge pull request #2621 from G8XSU/dont-persist-erroneous-update
Persist entire monitor if there is an error while applying monitor_update
Matt Corallo [Fri, 29 Sep 2023 23:39:18 +0000 (23:39 +0000)]
Bump crate versions to 0.0.117-rc1/invoice 0.25-rc1
Wilmer Paulino [Fri, 29 Sep 2023 23:00:35 +0000 (16:00 -0700)]
Fix wrong node broadcaster in test_yield_anchors_events
Wilmer Paulino [Tue, 26 Sep 2023 20:05:16 +0000 (13:05 -0700)]
Add anchors coverage to test_revoked_counterparty_aggregated_claims
Wilmer Paulino [Tue, 26 Sep 2023 18:59:12 +0000 (11:59 -0700)]
Add anchors coverage to test_revoked_counterparty_htlc_tx_balances
Gursharan Singh [Fri, 29 Sep 2023 20:41:18 +0000 (13:41 -0700)]
Add update_persisted_channel doc to indicate rare case for None update
Gursharan Singh [Fri, 29 Sep 2023 03:30:53 +0000 (20:30 -0700)]
Persist full monitor if there is an error while applying monitor_update
Motivation: When there is an error while applying monitor_update to a
channel_monitor, we don't want to persist a 'monitor_update' which
results in a failure to apply later while reading 'channel_monitor' with
updates from storage. Instead, we should persist the entire 'channel_monitor'
here.
Gursharan Singh [Fri, 29 Sep 2023 04:18:47 +0000 (21:18 -0700)]
Correctly mark chain_sync updates in test_utils
We were incorrectly marking updates as chain_sync
or not in test_utils based on whether monitor_update
is None or not. Instead, use UpdateOrigin to determine it.
Wilmer Paulino [Tue, 26 Sep 2023 17:31:09 +0000 (10:31 -0700)]
Add anchors coverage to test_revoked_counterparty_commitment_balances
Wilmer Paulino [Tue, 26 Sep 2023 00:01:31 +0000 (17:01 -0700)]
Add anchors coverage to test_balances_on_local_commitment_htlcs
Wilmer Paulino [Mon, 25 Sep 2023 23:59:05 +0000 (16:59 -0700)]
Add anchors coverage to test_claim_value_force_close
Wilmer Paulino [Wed, 27 Sep 2023 21:11:35 +0000 (14:11 -0700)]
Add anchors coverage to chanmon_claim_value_coop_close
Wilmer Paulino [Tue, 26 Sep 2023 18:59:42 +0000 (11:59 -0700)]
Add test util to handle bump HTLC events
Matt Corallo [Sun, 24 Sep 2023 02:32:08 +0000 (02:32 +0000)]
Fix matching of second-stage HTLC claim in get_htlc_balance
We incorrectly assumed that the descriptor's output index from
second-stage HTLC transaction would always match the HTLC's output index
in the commitment transaction. This doesn't make any sense though, we
need to make sure we map the descriptor to it's corresponding HTLC in
the commitment. Instead, we check that the transaction from which the
descriptor originated from spends the HTLC in question.
Note that pre-anchors, second-stage HTLC transactions are always 1
input-1 output, so previously we would only match if the HTLC was the
first output in the commitment transaction. Post-anchors, they are
malleable, so we can aggregate multiple HTLC claims into a single
transaction making this even more likely to happen. Unfortunately, we
lacked proper coverage in this area so the bug went unnoticed. To
address this, we aim to extend our existing coverage of
`get_claimable_balances` to anchor outputs channels in the following
commits.
Matt Corallo [Fri, 29 Sep 2023 22:42:50 +0000 (22:42 +0000)]
Merge pull request #2629 from jkczyz/2023-09-invreqfailed
Config-guard `Event::InvoiceRequestFailed`
Matt Corallo [Fri, 29 Sep 2023 22:06:58 +0000 (22:06 +0000)]
Merge pull request #2605 from wpaulino/anchors-monitor-track-to-remote-script
Use correct to_remote script in counterparty commitments
Jeffrey Czyz [Fri, 29 Sep 2023 21:04:21 +0000 (14:04 -0700)]
Remove unused imports
Jeffrey Czyz [Fri, 29 Sep 2023 21:03:39 +0000 (14:03 -0700)]
Fix build warning for unused method
Jeffrey Czyz [Fri, 29 Sep 2023 20:58:34 +0000 (13:58 -0700)]
Remove an unnecessary enumerate
Jeffrey Czyz [Fri, 29 Sep 2023 20:47:25 +0000 (13:47 -0700)]
Config-guard Event::InvoiceRequestFailed
The event cannot be generated publicly, so remove it for now to avoid
users needing to handle it.
Matt Corallo [Fri, 29 Sep 2023 21:25:51 +0000 (21:25 +0000)]
Merge pull request #2628 from wvanlint/fix_multiple_shutdown_results
Fix handling multiple ShutdownResults
Wilmer Paulino [Thu, 28 Sep 2023 19:31:43 +0000 (12:31 -0700)]
Expose witness_script for StaticPaymentOutputDescriptor
Wilmer Paulino [Thu, 28 Sep 2023 19:12:19 +0000 (12:12 -0700)]
Fix incorrect anchors `counterparty_payment_script` upon deserialization
Matt Corallo [Fri, 29 Sep 2023 21:06:55 +0000 (21:06 +0000)]
Merge pull request #2622 from wpaulino/funding-and-commitment-tx-confirm-same-block
Avoid early return upon confirmation of channel funding
Matt Corallo [Fri, 29 Sep 2023 21:06:41 +0000 (21:06 +0000)]
Merge pull request #2626 from TheBlueMatt/2023-09-revert-2476
Revert "Remove AvailableBalances::balance_msat"
Wilmer Paulino [Thu, 28 Sep 2023 16:07:10 +0000 (09:07 -0700)]
Fix off-by-one max witness estimate for P2WPKH StaticPaymentDescriptor
We were not accounting for the extra byte denoting the number of items
in the witness stack.
Wilmer Paulino [Mon, 25 Sep 2023 23:55:22 +0000 (16:55 -0700)]
Support signing to_remote anchors variant for StaticPaymentOutput
`to_remote` outputs on commitment transactions with anchor outputs have
an additional `1 CSV` constraint on its spending condition,
transitioning away from the previous P2WPKH script to a P2WSH.
Since our `ChannelMonitor` was never updated to track the proper
`to_remote` script on anchor outputs channels, we also missed updating
our signer to handle the new script changes.
Wilmer Paulino [Mon, 25 Sep 2023 23:53:42 +0000 (16:53 -0700)]
Use correct to_remote script in counterparty commitments
While our commitment transactions did use the correct `to_remote`
script, the `ChannelMonitor`'s was not as it is tracked separately. This
would lead to users never receiving an `Event::SpendableOutputs` with a
`StaticPaymentOutput` descriptor to claim the funds.
Luckily, any users affected which had channel closures confirmed by a
counterparty commitment just need to replay the closing transaction to
receive the event.
Matt Corallo [Fri, 29 Sep 2023 20:07:16 +0000 (20:07 +0000)]
Merge pull request #2624 from wpaulino/2609-follow-up
Address 2609 follow-up comments
Willem Van Lint [Fri, 29 Sep 2023 19:06:36 +0000 (12:06 -0700)]
Fix handling multiple ShutdownResults
Matt Corallo [Fri, 29 Sep 2023 18:53:44 +0000 (18:53 +0000)]
Merge pull request #2623 from wpaulino/htlc-claim-receive-preimage-after-close
Claim HTLCs with preimage from currently confirmed commitment
Wilmer Paulino [Fri, 22 Sep 2023 17:39:10 +0000 (10:39 -0700)]
Avoid early return upon confirmation of channel funding
This early return is only possible if the channel requires a single
confirmation, allowing a `channel_ready` message to go out. This can be
problematic though if a commitment transaction (specifically from the
counterparty, as the channel would be immediately closed if a local
commitment is broadcast) also confirms within the same block. The
`ChannelMonitor` will detect both, but it won't inform the
`ChannelManager` at all. Luckily, while the channel still is considered
open to the `ChannelManager`, the `ChannelMonitor` will reject any
further updates to the channel state.
Matt Corallo [Fri, 29 Sep 2023 18:32:25 +0000 (18:32 +0000)]
Revert "Remove AvailableBalances::balance_msat"
While removing the `balance_msat` field absolutely makes sense -
it is, at best, confusing - we really need a solid replacement for
it before we can do so. While one such replacement is in progress,
it is not complete and we'd like to not block our current release
on its completion.
This reverts commit
ef5be580f51d6756612fea710516c0297203f4dc.
Elias Rohrer [Fri, 29 Sep 2023 14:44:20 +0000 (16:44 +0200)]
Test we consider route hints if we are the src of the first hop
Previously, we would only consider route hints if the entry point was
in our first hops or in the network graph. We fixed this by also
considering hints if our own node ID was the first src.
Here, we add test coverage for this behavior.
Elias Rohrer [Fri, 29 Sep 2023 14:09:44 +0000 (16:09 +0200)]
Test we prefer first hops over route hints
We previously added logic that would avoid adding superflous candidates
for route hints if we detect that we have a first hop for this channel.
Here we add test coverage that we actually prefer the first hop over the
route hint, but still consider the remaining hints.
Wilmer Paulino [Fri, 29 Sep 2023 16:40:34 +0000 (09:40 -0700)]
Only yield DelayedPaymentOutput descriptors once their delay expires
Otherwise, we could give users a descriptor ahead of time that will
result in an invalid transaction spend/broadcast.
Matt Corallo [Fri, 29 Sep 2023 17:39:49 +0000 (17:39 +0000)]
Merge pull request #2617 from wpaulino/no-persist-same-channel-update
Avoid persisting on same counterparty's ChannelUpdate
Elias Rohrer [Fri, 29 Sep 2023 17:08:36 +0000 (19:08 +0200)]
Merge pull request #2591 from TheBlueMatt/2023-09-2562-followups
Doc and comment followups to #2562
Wilmer Paulino [Fri, 29 Sep 2023 16:16:48 +0000 (09:16 -0700)]
Note required levels of descendant transactions in get_spendable_outputs
Three levels of descendant transactions starting from the channel's
funding transaction should cover all potential spendable outputs.
The first level covers the commitment transaction.
The second level covers the to_self claims, to_remote claims,
second-stage HTLC claims and justice transactions.
The third levels covers the justice transactions on second-stage HTLCs,
and to_self claims on second-stage HTLCs.
Wilmer Paulino [Mon, 14 Aug 2023 19:12:54 +0000 (12:12 -0700)]
Test preimage claim after reorg of counterparty commitment
This test adds coverage for receiving a preimage after seeing a
counterparty commitment confirm, followed by a reorg and the
confirmation of a different commitment instead.
The first test covers the case where a holder commitment confirms after
the counterparty commitment reorg.
The second test covers the case where a previous counterparty commitment
confirms after the latest counterparty commitment reorg.
Wilmer Paulino [Fri, 28 Jul 2023 22:32:29 +0000 (15:32 -0700)]
Claim HTLCs with preimage from currently confirmed commitment
We should always claim HTLCs from the currently confirmed commitment,
rather than always claiming from the latest or previous counterparty
commitment if we've seen either confirm onchain at a prior point.
Wilmer Paulino [Thu, 28 Sep 2023 23:02:25 +0000 (16:02 -0700)]
Avoid persisting on same counterparty's ChannelUpdate
Some nodes may rebroadcast their `ChannelUpdate` to their counterparty
on every connection establishment, which leads to us doing an additional
persist most of the time when nothing has changed. Now, we'll only
persist if we receive an update that changes anything.
Elias Rohrer [Fri, 29 Sep 2023 06:53:19 +0000 (08:53 +0200)]
Assert equality of route params in tests
Previously we only asserted the `final_value_msat` matches. Looking at
it again we can _of course_ assert the full equality of looked-for and
included route params after all (duh, not sure what I was thinking...).
This cleans up the prior misunderstanding and fixes a bunch of tests
that would now fail otherwise.
Matt Corallo [Fri, 29 Sep 2023 01:29:47 +0000 (01:29 +0000)]
Merge pull request #2609 from wpaulino/monitor-get-spendable-output
Allow retrieval of SpendableOutputDescriptors from relevant transactions
Matt Corallo [Fri, 29 Sep 2023 00:19:04 +0000 (00:19 +0000)]
Merge pull request #2604 from TheBlueMatt/2023-09-route-overpay-limit
Try to overpay the recipient if we fail to find a path at all and limit overpay
Wilmer Paulino [Thu, 28 Sep 2023 18:42:13 +0000 (11:42 -0700)]
Retrieve all possible spendable outputs from transactions
Assuming our keys haven't been compromised, and that random transactions
aren't learning of these scripts somehow and sending funds to them, it
was only possible for one spendable output to exist within a
transaction.
- `shutdown_script` can only exist in co-op close transactions.
- `counterparty_payment_script` can only exist in counterparty
commitment transactions.
- `broadcasted_holder_revokable_script` can only exist in holder
commitment/HTLC transactions.
- `destination_script` can exist in any other type of claim we support.
Now that we're exposing this API to users such that they can rescan any
relevant transactions, there's no harm in allowing them to claim more
funds from spendable outputs than we expected.
Wilmer Paulino [Wed, 27 Sep 2023 17:27:44 +0000 (10:27 -0700)]
Allow retrieval of SpendableOutputDescriptors from relevant transactions
Currently, our API will only expose `SpendableOutputDescriptor`s once
after they are no longer under reorg risk (see `ANTI_REORG_DELAY`).
Users have often requested they'd like the ability to retrieve these in
some other way, either for historical purposes, or to handle replaying
any in the event of a failure.
Matt Corallo [Thu, 28 Sep 2023 20:45:27 +0000 (20:45 +0000)]
Add more details about async persistence completion/backgrounding
This clarifies somewhat that async persistence should run
indefinitely or keep trying via polling, and that either is
acceptable.
Matt Corallo [Thu, 28 Sep 2023 17:51:05 +0000 (17:51 +0000)]
Log max routing fee before we start pathfinding
This may be useful in debugging routing failures in the future.
Matt Corallo [Thu, 28 Sep 2023 18:19:36 +0000 (18:19 +0000)]
Include any recipient overpayment amounts in the route fee limit
If the user told us to limit their total fee exposure, we should
do so including any potential overpayment to the recipient, which
is ultimately a part of the "fee" as far as the user is concerned.
Matt Corallo [Tue, 26 Sep 2023 21:58:53 +0000 (21:58 +0000)]
Try to overpay the recipient if we fail to find a path at all
Previously we'd only try to overpay if we managed to find a path
to the recipient which was sufficient. However, if we fail to find
any path to the recipient at all we should still retry overpaying
the recipient. Ultimately we should be silling to pay whatever
reasonable performance penalty if the alternative is not finding a
path at all, which we do here.
Matt Corallo [Thu, 28 Sep 2023 18:19:50 +0000 (18:19 +0000)]
Allow routefinding again due to HTLC limit based on >= not >
While this doesn't matter much in practice, if we go around again
when route-finding to try to meet an htlc_minimum_msat, we use the
`recommended_value_msat` which can work if we meet the
`htlc_minimum_msat` on a channel exactly, so using >= rather than >
can capture cases with 1msat more.
Matt Corallo [Thu, 28 Sep 2023 20:37:54 +0000 (20:37 +0000)]
Merge pull request #2612 from TheBlueMatt/2023-09-namespace-split
Refer to top-level persistence namespaces as primary_namespace
Matt Corallo [Thu, 28 Sep 2023 20:30:29 +0000 (20:30 +0000)]
Merge pull request #2575 from tnull/2023-09-fix-debug-panic
Various router fixes and #2417 follow-ups
Matt Corallo [Thu, 28 Sep 2023 19:06:24 +0000 (19:06 +0000)]
Merge pull request #2611 from TheBlueMatt/2023-09-no-close-on-bad-update
Don't FC when a `channel_update` has a bogus `htlc_minimum_msat`
Matt Corallo [Thu, 28 Sep 2023 17:28:04 +0000 (17:28 +0000)]
Update remaining references to primary/secondary namespaces
Update various variables, error strings, and the pending changelog
entry to refer to new namespace terminology.
Matt Corallo [Thu, 28 Sep 2023 17:06:20 +0000 (17:06 +0000)]
Update storage constants to new PRIMARY/SECONDARY namespace terms
Matt Corallo [Thu, 28 Sep 2023 16:36:52 +0000 (16:36 +0000)]
Rename the persistence `sub_namespace` to `secondary_namespace`
With the top-level namespace now called "primary", "secondary"
makes more sense than "sub".
Elias Rohrer [Wed, 27 Sep 2023 10:43:31 +0000 (12:43 +0200)]
Don't retry overpaid values for `PartialFailure`s
Previously, if an overpaid path would fail immediately, we'd retry a
`PartialFailure` with the full path amount, _including_ any overpayment.
Here, we now subtract the succeeded paths' values from the
net. value to exclude the overpaid amounts on retry.
Elias Rohrer [Thu, 28 Sep 2023 08:04:35 +0000 (10:04 +0200)]
Assert query's and route's `final_value_msat` are equal
Elias Rohrer [Wed, 27 Sep 2023 07:57:20 +0000 (09:57 +0200)]
Refactor `mpp_retry[_overpay]` tests to use `SendEvent::from_event`
.. as a follow-up from #2417.
Elias Rohrer [Wed, 27 Sep 2023 07:28:43 +0000 (09:28 +0200)]
Make ignored candidate counts `u32`
.. as a follow-up from #2417.
Elias Rohrer [Fri, 22 Sep 2023 14:38:30 +0000 (16:38 +0200)]
Avoid adding duplicate hint candidates if they are first hops
If we have a direct channel to a node generating an invoice with route
hints, we'd previously happily add multiple candidates that all refer to
the same channel. To keep our candidate set small and unify our tracking
where possible, we now check if its `short_channel_id` is an
`outbound_scid_alias` of any of our first hops and refrain from adding
another candidate if it's the case.
Elias Rohrer [Fri, 22 Sep 2023 13:56:07 +0000 (15:56 +0200)]
Also add route hints if we are the source
Previously, we would only consider route hints if we had a direct
channel to the first node in the hint or if the first node in the hint
was part of the public network graph.
However, this left out the possiblity of us being part of the first hop,
especially if our own node is not announced and part of the graph.
Matt Corallo [Thu, 28 Sep 2023 16:54:44 +0000 (16:54 +0000)]
Merge pull request #2607 from DhananjayPurohit/civkit-branch
Issue in adding rust lightning as dependency on windows
Matt Corallo [Thu, 28 Sep 2023 16:32:18 +0000 (16:32 +0000)]
Merge pull request #2606 from wpaulino/anchors-counterparty-htlc-claim-sequence
Use correct input sequence for HTLC claims from counterparty commitments
Matt Corallo [Thu, 28 Sep 2023 16:30:02 +0000 (16:30 +0000)]
Log full channel_update messages received for our channels
Elias Rohrer [Fri, 22 Sep 2023 13:00:43 +0000 (15:00 +0200)]
Extend logging of ignored candidates
Elias Rohrer [Thu, 14 Sep 2023 12:14:03 +0000 (14:14 +0200)]
Use `saturating_add` when adding inflight HTLCs values
Previously this calculation could overflow, leading to panicking in `debug`.
DhananjayPurohit [Tue, 26 Sep 2023 09:24:00 +0000 (14:54 +0530)]
chore: remove time_utils.rs
No longer needed time_utils in lightning-invoice
Matt Corallo [Thu, 28 Sep 2023 02:40:07 +0000 (02:40 +0000)]
Refer to top-level persistence namespaces as `primary_namespace`
This fixes a bindings build error as `namespace` is a C++ keyword
which cannot be used as an argument, and while this could be fixed
in the bindings rather than here, separating the term `namespace`
between the concept (which refers to the primary and sub
namespaces) and the primary namespace makes the documentation more
readable.
Matt Corallo [Wed, 27 Sep 2023 22:26:57 +0000 (22:26 +0000)]
Use `Result<_, io::Error>` over `io::Result<_>`
Personally I've always found the overload of a prelude enum to be
confusing, and never bothered to handle it properly in bindings as
a result. To avoid needing to do so now, we simply move the
newly-introduced `io::Result` usages over to
`Result<_, io::Error>`.
Matt Corallo [Thu, 28 Sep 2023 00:46:31 +0000 (00:46 +0000)]
Don't FC when a `channel_update` has a bogus `htlc_minimum_msat`
If a peer sends us a `channel_update` for our own channel with an
`htlc_minimum_msat` which is more than the channel's amount, that's
dumb, but there's no reason to force-close the channel. We don't
even use the field.
Here we simply drop the unnecessary check.