Duncan Dean [Tue, 12 Sep 2023 08:52:50 +0000 (10:52 +0200)]
Add V2 constructors to `ChannelId`
Matt Corallo [Mon, 19 Feb 2024 22:17:35 +0000 (22:17 +0000)]
Merge pull request #2891 from TheBlueMatt/2024-02-no-ahash
Drop the `ahash` dependency
Elias Rohrer [Fri, 16 Feb 2024 10:33:37 +0000 (11:33 +0100)]
Have CI's `cargo audit` ignore `RUSTSEC-2021-0125`
This advisory is only relevant for a downstream dependency of
`criterion`, which we currently don't want to bump in order to continue
benchmarking with our MSRV 1.63.0.
We therefore just add it to our ignore list for now.
Matt Corallo [Fri, 16 Feb 2024 21:15:45 +0000 (21:15 +0000)]
Merge pull request #2897 from TheBlueMatt/2024-02-fix-route-ser
Fix `Route` serialization round-trip
Matt Corallo [Tue, 13 Feb 2024 18:15:20 +0000 (18:15 +0000)]
Drop `lightning-invoice` dependency on hashbrown`
Matt Corallo [Mon, 12 Feb 2024 22:40:49 +0000 (22:40 +0000)]
Drop `ahash` dependency in favor of core's `SipHasher`
https://github.com/tkaitchuck/aHash/pull/196 bumped the MSRV of
`ahash` in a patch release, which makes it rather difficult for us
to have it as a dependency.
Further, it seems that `ahash` hasn't been particularly robust in
the past, notably
https://github.com/tkaitchuck/aHash/issues/163 and
https://github.com/tkaitchuck/aHash/issues/166.
Luckily, `core` provides `SipHasher` even on no-std (sadly its
SipHash-2-4 unlike the SipHash-1-3 used by the `DefaultHasher` in
`std`). Thus, we drop the `ahash` dependency entirely here and
simply wrap `SipHasher` for our `no-std` HashMaps.
Matt Corallo [Mon, 12 Feb 2024 22:37:09 +0000 (22:37 +0000)]
Add a crate which wraps `getrandom` but always compiles
In the next commit we'll drop the `ahash` dependency in favor of
directly calling `getrandom` to seed our hash tables. However,
we'd like to depend on `getrandom` only on certain platforms *and*
only when certain features (no-std) are set.
This introduces an indirection crate to do so, allowing us to
depend on it only when `no-std` is set but only depending on
`getrandom` on platforms which it supports.
Matt Corallo [Fri, 16 Feb 2024 19:26:32 +0000 (19:26 +0000)]
Test `Route` serialization round-trip
This adds testing for the previous two commits by testing that all
routes generated in testing are able to survive a serialization
round-trip.
Matt Corallo [Fri, 16 Feb 2024 19:26:22 +0000 (19:26 +0000)]
Fix `Route` serialization round-trip
When the `max_total_routing_fee_msat` parameter was added to
`RouteParameters`, the serialization used `map` to get the max fee,
accidentally writing an `Option<Option<u64>>`, but then read it as
an `Option<u64>`. Thus, any `Route`s with a `route_params` written
will fail to be read back.
Luckily, this is an incredibly rarely-used bit of code, so only one
user managed to hit it.
Matt Corallo [Fri, 16 Feb 2024 18:41:54 +0000 (18:41 +0000)]
Fix blinded path serialization in `Route`
`Route`'s blinded_path serialization logic writes a blinded path
`Option` per path hop, however on read we (correctly) only read one
blinded path `Option` per path. This causes serialization of
`Route`s with blinded paths to fail to round-trip.
Here we fix this by writing blinded paths per path.
Matt Corallo [Fri, 16 Feb 2024 18:33:53 +0000 (18:33 +0000)]
Drop the `fails_paying_for_bolt12_invoice` test
`fails_paying_for_bolt12_invoice` tests that we fail to send a
payment if the router returns `Ok` but includes a bogus route (one
with 0-length paths). While this marginally increases our test
coverage, in the next commit we'll be testing that all routes
round-trip serialization, which fails here as bogus routes are not
supported in deserialization.
Because this isn't particularly critical test coverage, we simply
opt to drop the test entirely here.
Elias Rohrer [Tue, 6 Feb 2024 15:22:04 +0000 (16:22 +0100)]
Remove `onion_utils.rs` from exclusion list
.. now continously checking its formatting in CI.
Elias Rohrer [Mon, 12 Feb 2024 13:14:53 +0000 (14:14 +0100)]
Run `rustfmt` on `onion_utils.rs`
Elias Rohrer [Tue, 6 Feb 2024 15:26:39 +0000 (16:26 +0100)]
Add `rustfmt::skip` and small adjustments where needed
Elias Rohrer [Fri, 16 Feb 2024 10:55:56 +0000 (11:55 +0100)]
Merge pull request #2894 from TheBlueMatt/2024-02-future-poll-leak
Never store more than one StdWaker per live Future
Matt Corallo [Tue, 13 Feb 2024 22:43:51 +0000 (22:43 +0000)]
Never store more than one `StdWaker` per live `Future`
When an `std::future::Future` is `poll()`ed, we're only supposed to
use the latest `Waker` provided. However, we currently push an
`StdWaker` onto our callback list every time `poll` is called,
waking every `Waker` but also using more and more memory until the
`Future` itself is woken.
Here we fix this by removing any `StdWaker`s stored for a given
`Future` when it is `drop`ped or prior to pushing a new `StdWaker`
onto the list when `poll`ed.
Sadly, the introduction of a `Drop` impl for `Future` means we
can't trivially destructure the struct any longer, causing a few
methods to need to take `Future`s by reference rather than
ownership and `clone` a few `Arc`s.
Fixes #2874
Matt Corallo [Tue, 13 Feb 2024 22:08:55 +0000 (22:08 +0000)]
Give `Future`s for a `FutureState` an idx and track `StdWaker` idxn
When an `std::future::Future` is `poll()`ed, we're only supposed to
use the latest `Waker` provided. However, we currently push an
`StdWaker` onto our callback list every time `poll` is called,
waking every `Waker` but also using more and more memory until the
`Future` itself is woken.
Here we take a step towards fixing this by giving each `Future` a
unique index and storing which `Future` an `StdWaker` came from in
the callback list. This sets us up to deduplicate `StdWaker`s by
`Future`s in the next commit.
Matt Corallo [Tue, 13 Feb 2024 21:58:46 +0000 (21:58 +0000)]
Split lists of `Waker` and directly-registered `Future` callbacks
In the next commit we'll fix a memory leak due to keeping too many
`std::task::Waker` callbacks in `FutureState` from redundant `poll`
calls, but first we need to split handling of `StdWaker`-based
future wake callbacks from normal ones, which we do here.
Elias Rohrer [Wed, 14 Feb 2024 09:29:09 +0000 (10:29 +0100)]
Merge pull request #2895 from TheBlueMatt/2024-02-logging-tweaks
Minor Logging tweaks
Elias Rohrer [Tue, 6 Feb 2024 18:16:54 +0000 (19:16 +0100)]
Add `rustfmt` instructions to CONTRIBUTING.md
Elias Rohrer [Mon, 5 Feb 2024 14:44:08 +0000 (15:44 +0100)]
Add `rustfmt` to CI, ignore all files
We add the previously discussed `rustfmt.toml` and enforce it in CI for
any files that are not contained in an exclusion list.
To start, we add all current Rust files to this exclusion list. This
means that formatter rules will be enforced for any newly introduced
files, and we'll then start going through the codebase file-by-file,
removing them from the list as we go.
Elias Rohrer [Wed, 14 Feb 2024 08:01:51 +0000 (09:01 +0100)]
Merge pull request #2883 from tnull/2024-02-dyn-kvstore-blanket-impls
Add blanket `Persist`/`Persister` impls for `dyn KVStore + Send + Sync`
Matt Corallo [Tue, 13 Feb 2024 23:43:19 +0000 (23:43 +0000)]
Opportunistically skip log in `update_claims_view_from_matched_txn`
On each block, for each `ChannelMonitor`, we log two status
statements in `OnChainTx::update_claims_view_from_matched_txn`.
This can add up to quite a bit, and is generally not very
interesting when we don't actually do anything if there's no claims
to bump.
Here we drop both logs if we have no claims to work with, but
retain it if we process any claims.
Matt Corallo [Tue, 13 Feb 2024 23:33:18 +0000 (23:33 +0000)]
Opportunistically skip log in `update_claims_view_from_requests`
On each block, for each `ChannelMonitor`, we log a status statement
in `OnChainTx::update_claims_view_from_requests`. This can add up
to quite a bit, and is generally not very interesting when we don't
actually do anything if there's no claims to bump.
Here we drop the log if we have no claims to work with, but retain
it if we process any claims.
Matt Corallo [Tue, 13 Feb 2024 23:00:38 +0000 (23:00 +0000)]
Drop some "Channel does not qualify for a feerate change" logs
On a high-traffic/channel node, `Channel .* does not qualify for a
feerate change.*` is our most common log, and it doesn't provide
much useful information. It's logged in two cases - (a) where the
estimator feerate is less than the current channel feerate but not
by more than half twice and (b) where we'd like to update the
channel feerate but the peer is disconnected or channel not
available for updates.
Because these conditions can persist and we log them once a minute
the volume of logs can add up quickly. Here we simply remove the
log in case (a), though leave (b) as its anticipated to be somewhat
quieter and does indicate a persistent issue that should be
addressed (possibly by closing the channel).
Matt Corallo [Tue, 13 Feb 2024 22:57:18 +0000 (22:57 +0000)]
Make peers sending gossip out of order logging less scary
Multiple times we've had users wonder why they see `Error handling
message from.*; ignoring: Couldn't find channel for update` in
their logs and wonder if its related to their channel
force-closing. While this does indicate a peer is sending us gossip
our of order (and thus misbehaving), its not relevant to channel
operation and the logged message and level should indicate that.
Thus, here, we move the level to Gossip and add "gossip" between
"handling" and "message" (so it reads "Error handling gossip
message from.*").
Fixes #2471
Matt Corallo [Tue, 13 Feb 2024 21:35:51 +0000 (21:35 +0000)]
Merge pull request #2861 from tnull/2024-01-introduce-cargo-audit
Introduce CI workflow running `cargo audit`
Matt Corallo [Tue, 13 Feb 2024 21:22:55 +0000 (21:22 +0000)]
Merge pull request #2816 from wpaulino/retryable-holder-sigs
Allow holder commitment and HTLC signature requests to fail
Elias Rohrer [Tue, 13 Feb 2024 08:21:04 +0000 (09:21 +0100)]
Merge pull request #2892 from TheBlueMatt/2024-02-destination-eq
Add further standard derives to various onion message structs
Elias Rohrer [Tue, 30 Jan 2024 11:41:05 +0000 (12:41 +0100)]
Introduce CI workflow running `cargo audit`
In order to continuously monitor our dependencies for security
vulnerabilities, we introduce a new CI job that will use `cargo audit`
to check for any known vulnerabilities.
This job is run on a daily schedule. For each new advisory, a new issue
will be created.
Matt Corallo [Mon, 12 Feb 2024 23:54:14 +0000 (23:54 +0000)]
Add further standard derives to various onion message structs
Elias Rohrer [Mon, 12 Feb 2024 12:29:15 +0000 (13:29 +0100)]
Merge pull request #2888 from TheBlueMatt/2024-02-destination-eq
Implement `Debug`/`PartialEq`/`Eq` for `Destination`
Elias Rohrer [Thu, 1 Feb 2024 08:41:01 +0000 (09:41 +0100)]
Drop `reqwest` pin
.. since a version with fixed MSRV was released by now.
Elias Rohrer [Thu, 1 Feb 2024 08:31:06 +0000 (09:31 +0100)]
Move `lightning-transaction-sync` to main workspace
.. so it's actually included in the audit.
Elias Rohrer [Thu, 1 Feb 2024 08:57:05 +0000 (09:57 +0100)]
Disable `lightning-transaction-sync` integration tests on Windows
.. as the `electrsd` crate doesn't support it.
While we previously did so in our CI script, we now also `cfg`-gate the
tests and dependencies for easier handling.
Matt Corallo [Sat, 10 Feb 2024 02:27:59 +0000 (02:27 +0000)]
Implement `Debug`/`PartialEq`/`Eq` for `Destination`
Matt Corallo [Fri, 9 Feb 2024 00:49:33 +0000 (00:49 +0000)]
Merge pull request #2850 from TheBlueMatt/2024-01-fuzz-gossip
Matt Corallo [Fri, 9 Feb 2024 00:08:28 +0000 (00:08 +0000)]
Merge pull request #2886 from TheBlueMatt/2024-02-actually-fix-build
Fix silent merge conflict introduced in
d3ddf15 @TheBlueMatt
Matt Corallo [Thu, 8 Feb 2024 23:03:44 +0000 (23:03 +0000)]
Replace spaces with tabs in msgs.rs
Matt Corallo [Thu, 8 Feb 2024 23:04:19 +0000 (23:04 +0000)]
Fix silent merge conflict introduced in
d3ddf15357589ed10f4c844dc22
Matt Corallo [Thu, 8 Feb 2024 22:55:53 +0000 (22:55 +0000)]
Merge pull request #2885 from benthecarman/tiny-opt
Worlds smallest optimization
benthecarman [Thu, 8 Feb 2024 17:57:13 +0000 (17:57 +0000)]
Worlds smallest optimization
Preallocate for 8 items in the vec. I chose this value for
1. features
2. description
3. payment hash
4. expire time
5. min_final_cltv
6. payment secret
7. route hint
8. for the memes
Matt Corallo [Thu, 8 Feb 2024 21:50:27 +0000 (21:50 +0000)]
Merge pull request #2871 from dunxen/2024-02-msgcommonfields
Combine common fields for OpenChannel and AcceptChannel V1 & V2
Wilmer Paulino [Tue, 30 Jan 2024 22:45:46 +0000 (14:45 -0800)]
Allow holder commitment and HTLC signature requests to fail
As part of the ongoing async signer work, our holder signatures must
also be capable of being obtained asynchronously. We expose a new
`ChannelMonitor::signer_unblocked` method to retry pending onchain
claims by re-signing and rebroadcasting transactions. Unfortunately, we
cannot retry said claims without them being registered first, so if
we're not able to obtain the signature synchronously, we must return the
transaction as unsigned and ensure it is not broadcast.
Wilmer Paulino [Tue, 30 Jan 2024 22:45:44 +0000 (14:45 -0800)]
Introduce FeerateStrategy enum for onchain claims
This refactors the existing `force_feerate_bump` flag into an enum as we
plan to introduce a new flag/enum variant in a future commit.
Wilmer Paulino [Tue, 30 Jan 2024 22:45:44 +0000 (14:45 -0800)]
Rework get_latest_holder_commitment_txn to broadcast for users
This method is meant to be used as a last resort when a user is forced
to broadcast the current state, even if it is stale, in an attempt to
claim their funds in the channel. Previously, we'd return the commitment
and HTLC transactions such that they broadcast them themselves. Doing so
required a different code path, one which was not tested, to obtain
these transactions than our usual path when force closing. It's not
worth maintaining both, and it's much simpler for us to broadcast
instead.
Matt Corallo [Wed, 7 Feb 2024 22:12:59 +0000 (22:12 +0000)]
Merge pull request #2856 from valentinewallace/2024-01-blinded-payinfo-min-final-cltv
Route blinding: add `min_final_cltv_delta` to aggregated CLTV delta
Valentine Wallace [Fri, 26 Jan 2024 20:17:27 +0000 (15:17 -0500)]
Add min_final_cltv_delta to aggregated CLTV delta.
The spec was previously missing this requirement.
Valentine Wallace [Fri, 26 Jan 2024 19:34:40 +0000 (14:34 -0500)]
Parameterize BlindedPath::new_for_payment by min final CLTV delta.
Currently we are not including this value in the aggregated CLTV delta, which
is wrong.
Elias Rohrer [Wed, 7 Feb 2024 11:54:21 +0000 (12:54 +0100)]
Impl `Sync` and `Send` for `TestStore`
Elias Rohrer [Wed, 7 Feb 2024 11:52:20 +0000 (12:52 +0100)]
Add blanket `Persist`/`Persister` impls for `dyn KVStore + Send + Sync`
Previously, we only had blanket impls for `KVStore`. However, in order
to enable the use of `dyn KVStore + Send + Sync` instead of a `KVStore`
generic, we here also add the corresponding blanket implementations for
said type signature.
Matt Corallo [Wed, 7 Feb 2024 02:27:22 +0000 (02:27 +0000)]
[fuzz] Add fst coverage for `ChannelManager::update_channel_config`
Matt Corallo [Sat, 20 Jan 2024 08:27:23 +0000 (08:27 +0000)]
[fuzz] Add a second full_stack_target seed test for gossip
Matt Corallo [Sat, 20 Jan 2024 08:26:07 +0000 (08:26 +0000)]
[fuzz] De-dup hex in test_no_existing_test_breakage
This will make test_no_existing_test_breakage marginally easier to
update.
Matt Corallo [Fri, 19 Jan 2024 00:42:17 +0000 (00:42 +0000)]
[fuzz] Add additional method calls in full_stack_target
The whole point of full_stack_target is to just expose our entire
API to the fuzzer and see what happens. Sadly, we're really only
exposing a small subset of our API. This improves that by exposing
a handful of other assorted methods from ChannelManager and
PeerManager.
Matt Corallo [Fri, 19 Jan 2024 00:41:57 +0000 (00:41 +0000)]
[fuzz] Use batch funding in full_stack_target
To potentially get more test coverage
Matt Corallo [Wed, 7 Feb 2024 00:57:01 +0000 (00:57 +0000)]
Merge pull request #2873 from tnull/2024-02-expose-channel-details-in-bte
Expose `channel_id` / `counterparty_node_id` in `BumpTransaction` event
Matt Corallo [Wed, 7 Feb 2024 00:28:50 +0000 (00:28 +0000)]
Merge pull request #2878 from TheBlueMatt/2024-02-fix-build
Small comment tweaks
Elias Rohrer [Mon, 5 Feb 2024 13:47:39 +0000 (14:47 +0100)]
Expose `channel_id` / `counterparty_node_id` in `BumpTransaction` event
A client node might choose not to handle `Event::BumptTransaction`
events and leave bumping / Anchor output spending to a trusted
counterparty.
However, `Event::BumptTransaction` currently doesn't offer any clear
indication what channel and/or counterparty it is referring to. In order
to allow filtering these events, we here expose the `channel_id` and
`counterparty_node_id` fields.
Matt Corallo [Tue, 6 Feb 2024 18:53:56 +0000 (18:53 +0000)]
Note when new HTLC state can be `None`
Matt Corallo [Mon, 5 Feb 2024 23:54:56 +0000 (23:54 +0000)]
Fix comment spelling
Matt Corallo [Tue, 6 Feb 2024 18:45:36 +0000 (18:45 +0000)]
Merge pull request #2442 from wvanlint/list_pending_htlcs
Include pending HTLC's in ChannelDetails
Elias Rohrer [Tue, 6 Feb 2024 10:44:32 +0000 (11:44 +0100)]
Merge pull request #2876 from TheBlueMatt/2024-02-2863-doc-nits
Minor doc nits on the new coop close reason variants
Willem Van Lint [Sat, 5 Aug 2023 00:07:04 +0000 (17:07 -0700)]
Include pending HTLCs in ChannelDetails
This exposes details around pending HTLCs in ChannelDetails. The state
of the HTLC in the state machine is also included, so it can be
determined which protocol message the HTLC is waiting for to advance.
Matt Corallo [Fri, 19 Jan 2024 01:12:14 +0000 (01:12 +0000)]
[fuzz] Fix misc warnings in full_stack_target
Matt Corallo [Fri, 19 Jan 2024 00:41:25 +0000 (00:41 +0000)]
[fuzz] Reduce size of `payments_sent` in full_stack_target
Slightly reducing the amount of data we read to do things.
Matt Corallo [Mon, 5 Feb 2024 23:53:06 +0000 (23:53 +0000)]
Merge pull request #2810 from TheBlueMatt/2023-12-arbitrary-fuzz-config
Update `full_stack_target` to take an arbitrary config object
Matt Corallo [Mon, 5 Feb 2024 23:49:19 +0000 (23:49 +0000)]
Merge pull request #2847 from TheBlueMatt/2024-01-bindings-upstream
Misc Tweaks for bindings
Matt Corallo [Mon, 5 Feb 2024 23:47:36 +0000 (23:47 +0000)]
Minor doc nits on the new coop close reason variants
Matt Corallo [Mon, 5 Feb 2024 23:44:36 +0000 (23:44 +0000)]
Merge pull request #2725 from shaavan/issue2096
Ensure successful message propagation in case of disconnection mid-handshake
Matt Corallo [Mon, 5 Feb 2024 23:43:26 +0000 (23:43 +0000)]
Merge pull request #2863 from benthecarman/breakup-coop-close
Breakup CooperativeClosure into Local/Remote initiated
Matt Corallo [Mon, 5 Feb 2024 19:58:51 +0000 (19:58 +0000)]
Merge pull request #2872 from tnull/2024-02-add-features-to-channel-pending
Expose `channel_type` in `Event::ChannelPending`
Elias Rohrer [Mon, 5 Feb 2024 13:32:33 +0000 (14:32 +0100)]
Expose `channel_type` in `Event::ChannelPending`
It is useful to immediately know what kind of channel is being opened,
and not having to wait until `ChannelReady`.
benthecarman [Sun, 4 Feb 2024 16:33:08 +0000 (16:33 +0000)]
Rename old CooperativeClosure to LegacyCooperativeClosure
benthecarman [Wed, 31 Jan 2024 00:32:37 +0000 (00:32 +0000)]
Breakup CooperativeClosure into Local/Remote initiated
Matt Corallo [Wed, 31 Jan 2024 19:48:44 +0000 (19:48 +0000)]
[fuzz] Fix slice copy in `peer_crypt_target`
This has apparently been broken for quite some time...I guess
`peer_crypt_target` doesn't get much CPU anymore.
Matt Corallo [Thu, 11 Jan 2024 21:33:53 +0000 (21:33 +0000)]
Fix test variable typos
Matt Corallo [Thu, 18 Jan 2024 22:39:26 +0000 (22:39 +0000)]
Bump `hashbrown` dependency to 0.13
While this isn't expected to materially improve performance, it
does get us ahash 0.8, which allows us to reduce fuzzing
randomness, making our fuzzers much happier.
Sadly, by default `ahash` no longer tries to autodetect a
randomness source, so we cannot simply rely on `hashbrown` to do
randomization for us, but rather have to also explicitly depend on
`ahash`.
Matt Corallo [Thu, 18 Jan 2024 20:27:57 +0000 (20:27 +0000)]
Stop relying on `Hash{Set,Map}::from_iter` directly
In the next commit we'll bump the `hashbrown` version, which no
longer randomizes its hasher by default. Thus, we'll need to call
a different constructor in no-std builds from std builds.
Here we do a quick prefactor to use wrappers for `FromIterator`
constructors instead of calling the tables directly to make the
version bump changeset smaller.
Matt Corallo [Mon, 1 Jan 2024 21:53:36 +0000 (21:53 +0000)]
Use utility methods to construct `HashMap`s and `HashSet`s
In the next commit we'll bump the `hashbrown` version, which no
longer randomizes its hasher by default. Thus, we'll need to call
a different constructor in no-std builds from std builds.
Here we do a quick prefactor to use wrappers for constructors
instead of calling the tables directly to make the version bump
changeset smaller.
Matt Corallo [Thu, 18 Jan 2024 20:34:56 +0000 (20:34 +0000)]
Update fuzz CI job to use our MSRV rather than 1.58
Matt Corallo [Sat, 23 Dec 2023 19:13:34 +0000 (19:13 +0000)]
Use arbitrary config object in full_stack_target fuzzer
As we've added more and more configuration parameters which change
our behavior, we're increasingly missing coverage in the general
`full_stack_target` fuzzer. Sadly, a reachable `unwrap` slipped in
uncaught that should have been stopped by the `full_stack_target`.
Here, we update the `full_stack_target` fuzzer to read a full
config object to substantially increase coverage.
Matt Corallo [Mon, 25 Dec 2023 00:54:45 +0000 (00:54 +0000)]
Disable fuzzing-reachable debug assertions in `ChannelMonitor`s
Matt Corallo [Sun, 24 Dec 2023 17:12:18 +0000 (17:12 +0000)]
Disable fuzzing-reachable debug assertion
Because of txid conflicts, a txid can match both a local and remote
commitment transaction when fuzzing. Thus, we disable this
assertion when fuzzing.
Jeffrey Czyz [Fri, 2 Feb 2024 17:18:24 +0000 (11:18 -0600)]
Merge pull request #2868 from orbitalturtle/export-send-onion-path
export send_onion_message_using_path for testing
Matt Corallo [Fri, 2 Feb 2024 17:08:52 +0000 (17:08 +0000)]
Merge pull request #2870 from benthecarman/pub-source-target
Make DirectedChannelInfo `source` and `target` public
Duncan Dean [Fri, 2 Feb 2024 14:54:23 +0000 (16:54 +0200)]
Combine common fields of `AcceptChannel` & `AcceptChannelV2` into struct
benthecarman [Fri, 2 Feb 2024 14:14:51 +0000 (14:14 +0000)]
Make DirectedChannelInfo `source` and `target` public
We use these params for our HubPreferentialScorer and without these
utility functions then we have to manually do this and calculate which
is the source and which is the target node.
Duncan Dean [Fri, 2 Feb 2024 12:39:42 +0000 (14:39 +0200)]
Combine common fields of `OpenChannel` & `OpenChannelV2` into struct
Orbital [Fri, 2 Feb 2024 02:22:53 +0000 (20:22 -0600)]
export send_onion_message_using_path for testing
valentinewallace [Thu, 1 Feb 2024 14:42:22 +0000 (09:42 -0500)]
Merge pull request #2858 from tnull/2024-01-expose-skimmed-fee-msat
Expose withheld amount for underpaying HTLCs in `PaymentForwarded`
Elias Rohrer [Mon, 29 Jan 2024 15:16:08 +0000 (16:16 +0100)]
Expose `skimmed_fee_msat` in `PaymentForwarded`
We generally allow routing nodes to forward less than the expected HTLC
amount, if the receiver knowingly accepts this and claims the
underpaying HTLC (see `ChannelConfig::accept_underpaying_htlcs`). This
use case is in particular useful for the LSPS2/JIT channel setting where
the intial underpaying HTLC pays for the channel open.
While we previously exposed the withheld amount as
`PaymentClaimable::counterparty_skimmed_fee_msat` on the receiver side,
we did not individually provide it on the forwarding node's side.
Here, we therefore expose this additionally withheld amount via
`PaymentForwarded::skimmed_fee_msat`.
dunxen [Thu, 1 Feb 2024 08:19:13 +0000 (10:19 +0200)]
Merge pull request #2864 from dunxen/2024-01-2797followups
Fix followups to PR2797
shaavan [Wed, 31 Jan 2024 12:14:58 +0000 (17:44 +0530)]
Add tests to check the introduced behaviour
- The first test make sure that the OutboundV1Channel is not
immediately removed when peers disconnect, but is removed after N timer
ticks.
- The second test makes sure that the SendOpenChannel is rebroadcasted
for the OutboundV1Channel if peer reconnects within time.
shaavan [Sun, 10 Dec 2023 12:47:32 +0000 (18:17 +0530)]
Do not remove Outbound Channel immediately when peer disconnects
- Do not remove channel immediately when peer_disconnect, instead
removed it after some time if peer doesn't reconnect soon (handled in
previous commit).
- Do not mark per ok_to_remove if we have some OutboundV1Channels too.
- Rebroadcast SendOpenChannel for outboundV1Channel when peer
reconnects.
- Update the relevant tests to account for the behavior change.
- Repurpose the test_disconnect_in_funding_batch to test that all
channels in the batch close when one them closes.
Elias Rohrer [Tue, 30 Jan 2024 08:18:28 +0000 (09:18 +0100)]
Rename `PaymentForwarded::fee_earned_msat` to `total_fee_earned_msat`
Valentine Wallace [Tue, 30 Jan 2024 19:43:59 +0000 (14:43 -0500)]
Track min HTLC overpay separately from skimmed fees in test utils
Valentine Wallace [Wed, 20 Dec 2023 20:45:34 +0000 (15:45 -0500)]
Struct-ify claim_along_route args.
Lays groundwork to make claim_payment* test utils easier to adapt without
changing a million callsites.
Duncan Dean [Wed, 31 Jan 2024 05:58:56 +0000 (07:58 +0200)]
Fix followups to PR2797
Matt Corallo [Tue, 23 Jan 2024 06:19:24 +0000 (06:19 +0000)]
[bindings] Move additional score params from `&()` to `Default`
In
26c1639ab69d6780c97a118f09e42cb42304088a (and later in
50c55dcf32466e3ccf17acea50697fc664950deb) we switched to using
`Default::default()` to initialize `()` for scoring parameters in
tests. A number of `()`s slipped back in recently, which we replace
here.