]>
git.bitcoin.ninja Git - rust-lightning/log
Savil Srivastava [Tue, 24 Jul 2018 20:05:43 +0000 (13:05 -0700)]
adding BIP69 test-cases
Savil Srivastava [Mon, 23 Jul 2018 00:03:13 +0000 (17:03 -0700)]
[RFC][Tx Sort] Implement sorting of inputs
Follows BIP69: https://github.com/bitcoin/bips/blob/master/bip-0069.mediawiki
1. Implements sorting of transactoin inputs.
- BIP says to use "reversed byte-order" for the `prev_hash`. I interpreted this as: little-endian.
- TODO need to add tests
2. Re: improve sorting of TxOut's script_pubkey to use lexicographic ordering, and not length.
From the test-cases i've included it seems that the current code already does lexicographic ordering (and not length based). Am i missing something?
Matt Corallo [Fri, 20 Jul 2018 02:44:42 +0000 (22:44 -0400)]
Merge pull request #64 from TheBlueMatt/master
Expose the script_pubkey being monitored in chain watch (fixes #44)
Matt Corallo [Fri, 20 Jul 2018 02:06:56 +0000 (22:06 -0400)]
Remove in-repo TODOs (they're now tracked in GitHub)
Matt Corallo [Fri, 20 Jul 2018 02:06:07 +0000 (22:06 -0400)]
Expose the script_pubkey being monitored in chain watch (fixes #44)
Matt Corallo [Thu, 19 Jul 2018 21:48:58 +0000 (17:48 -0400)]
Merge pull request #52 from TheBlueMatt/master
Fix various spec bugs, can now open channels with real nodes!
Matt Corallo [Thu, 19 Jul 2018 21:17:06 +0000 (17:17 -0400)]
Fix various spec bugs, can now open channels with real nodes!
* commitment transaction number, as used in locktime/sequence
fields is actually different from commitment transaction number,
as used for revocation state. This is confusing and never stated
in the spec, so we have to do the conversion.
* max_htlc_value_in_flight is never constrained in the spec, but
we were requiring it be <= channel size. Instead just clamp the
values the peer sends us when storing.
* channel_id calculation was incorrect, we now do some crazy
conversion hops, which we shouldn't, but will need to change our
types to fix.
* Our channel_reserve_satoshis value was too low, just change the
constant and leave the TODO to figure out what it really should
be for now.
Matt Corallo [Wed, 18 Jul 2018 20:55:06 +0000 (16:55 -0400)]
Merge pull request #49 from ariard/bad_failure_codes
Erroneous failure codes, replace PERM|7 by UPDATE|7
Matt Corallo [Wed, 18 Jul 2018 19:00:49 +0000 (15:00 -0400)]
Merge pull request #51 from TheBlueMatt/master
Shorten channelmonitor_deserialize_target's name for AFL
Matt Corallo [Wed, 18 Jul 2018 18:36:24 +0000 (14:36 -0400)]
Shorten channelmonitor_deserialize_target's name for AFL
Matt Corallo [Wed, 18 Jul 2018 18:30:00 +0000 (14:30 -0400)]
Merge pull request #50 from TheBlueMatt/master
Fix channelmonitor fuzz test failure
Matt Corallo [Wed, 18 Jul 2018 17:36:00 +0000 (13:36 -0400)]
Fix channelmonitor fuzz test failure
Matt Corallo [Wed, 18 Jul 2018 13:53:15 +0000 (06:53 -0700)]
Merge pull request #48 from TheBlueMatt/2018-07-monitor-serialize
Implement channelmonitor (de)serialization
Antoine Riard [Wed, 18 Jul 2018 00:59:52 +0000 (00:59 +0000)]
Erroneous failure codes, replace PERM|7 by UPDATE|7
Matt Corallo [Tue, 17 Jul 2018 04:12:54 +0000 (21:12 -0700)]
Test channelmonitor serialization roundtrip doesn't mutate state
Matt Corallo [Mon, 9 Jul 2018 20:40:21 +0000 (16:40 -0400)]
Implement channelmonitor (de)serialization (fixes #45)
Matt Corallo [Sun, 8 Jul 2018 20:31:48 +0000 (16:31 -0400)]
Clarify ChannelMonitor remote commitment tracking and fix a race
Matt Corallo [Sat, 7 Jul 2018 20:51:20 +0000 (16:51 -0400)]
Move channelmonitor-update functions to pub(ln) from pub
Matt Corallo [Sat, 7 Jul 2018 20:51:05 +0000 (16:51 -0400)]
Update TODOs in README
Matt Corallo [Sat, 14 Jul 2018 04:30:22 +0000 (21:30 -0700)]
Merge pull request #46 from ariard/useless_todo_channelmanager
TODO already cleaned by #16
Antoine Riard [Fri, 13 Jul 2018 02:49:06 +0000 (02:49 +0000)]
TODO already cleaned by #16
Matt Corallo [Fri, 6 Jul 2018 21:54:01 +0000 (17:54 -0400)]
Merge pull request #41 from TheBlueMatt/master
Move open_channel message handling into an event
Matt Corallo [Fri, 6 Jul 2018 21:29:34 +0000 (17:29 -0400)]
Move open_channel message handling into an event
This simplifies client usage cause peer_handler doesn't have an
interface to shove arbitrary messages in.
Matt Corallo [Thu, 5 Jul 2018 03:17:44 +0000 (23:17 -0400)]
Merge pull request #39 from TheBlueMatt/master
Add warning about aut-close()-fd-races for peer_handler impls
Matt Corallo [Tue, 3 Jul 2018 00:07:37 +0000 (20:07 -0400)]
Add warning about aut-close()-fd-races for peer_handler impls
Matt Corallo [Sat, 30 Jun 2018 20:54:13 +0000 (16:54 -0400)]
Merge pull request #38 from jeandudey/max-funding-satoshis
Add `MAX_FUNDING_SATOSHIS` constant.
Jean Pierre Dudey [Sat, 30 Jun 2018 14:32:23 +0000 (10:32 -0400)]
Add `MAX_FUNDING_SATOSHIS` constant.
This constants defines the maximum value of `open_channel.funding_satoshis`,
currently it's defined to be 2^24 according to the BOLT #2 specification.
Also a test was added to check that the constant is never over 2,1x10^15
(maximum satoshis in bitcoin) if modified.
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
Matt Corallo [Fri, 29 Jun 2018 22:26:41 +0000 (18:26 -0400)]
Merge pull request #37 from TheBlueMatt/master
Fix additional 1.22 rustc warning
Matt Corallo [Fri, 29 Jun 2018 22:26:25 +0000 (18:26 -0400)]
Merge pull request #36 from TheBlueMatt/2018-08-33-cleanups
Cleanups after #33, plus one unrelated bugfix spotted in #33 review
Matt Corallo [Fri, 29 Jun 2018 21:44:33 +0000 (17:44 -0400)]
Fix additional 1.22 rustc warning
Matt Corallo [Fri, 29 Jun 2018 21:38:05 +0000 (17:38 -0400)]
Add more docs to transaction::OutPoint
Matt Corallo [Fri, 29 Jun 2018 21:23:50 +0000 (17:23 -0400)]
Cleanups after #33, plus one unrelated bugfix spotted in #33 review
Matt Corallo [Fri, 29 Jun 2018 21:23:43 +0000 (17:23 -0400)]
Merge pull request #35 from TheBlueMatt/2018-06-post-32
Some cleanups after #32
Matt Corallo [Fri, 29 Jun 2018 21:23:34 +0000 (17:23 -0400)]
Merge pull request #33 from jeandudey/funding_txo
Use the `TxOutRef` type for the `ChannelMonitor`'s funding_txo field.
Matt Corallo [Fri, 29 Jun 2018 20:42:44 +0000 (16:42 -0400)]
Greatly simplify channelmonitor pruning tests, and use real funcs
Instead of hooking into internal data structures and modifying
those, call the actual functions Channel will call and then check
that the preimages map is correct.
Matt Corallo [Fri, 29 Jun 2018 20:37:45 +0000 (16:37 -0400)]
Also avoid pruning preimages for previous local tx in ChannelMonitor
Matt Corallo [Fri, 29 Jun 2018 20:02:19 +0000 (16:02 -0400)]
Fix chan_utils indentation issue
Matt Corallo [Fri, 29 Jun 2018 19:41:18 +0000 (15:41 -0400)]
A few minor test cleanups and remove new warnings from #32
Matt Corallo [Fri, 29 Jun 2018 19:40:47 +0000 (15:40 -0400)]
Skip some a needless temporary vec and clean indentation after #32
Matt Corallo [Fri, 29 Jun 2018 20:43:56 +0000 (16:43 -0400)]
Merge pull request #32 from ariard/prune_payment_preimages
Add pruning of preimages no longer needed + tests
Jean Pierre Dudey [Wed, 27 Jun 2018 13:11:58 +0000 (09:11 -0400)]
Add the `OutPoint` type for the `ChannelMonitor`'s funding_txo field.
This structure replaces the (Sha256dHash, u16) tuple that was being used
for the funding output.
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
Antoine Riard [Fri, 8 Jun 2018 23:18:00 +0000 (01:18 +0200)]
Add pruning of preimages no longer needed + tests
Matt Corallo [Wed, 27 Jun 2018 21:26:56 +0000 (17:26 -0400)]
Merge pull request #34 from TheBlueMatt/master
Fix Pong response attempt-to-encode-oversize-msg panic
Matt Corallo [Wed, 27 Jun 2018 20:59:21 +0000 (16:59 -0400)]
Fix Pong response attempt-to-encode-oversize-msg panic
Matt Corallo [Sun, 17 Jun 2018 04:09:21 +0000 (00:09 -0400)]
Merge pull request #30 from TheBlueMatt/master
Working initial routing sync from lnd node
Matt Corallo [Sun, 17 Jun 2018 03:11:37 +0000 (23:11 -0400)]
Fix message targets to not have an internal loop
Matt Corallo [Sat, 16 Jun 2018 23:48:09 +0000 (19:48 -0400)]
Add ping/pong fuzz targets
Matt Corallo [Sat, 16 Jun 2018 23:39:40 +0000 (19:39 -0400)]
Send initial_routing_sync-filled Init messages to the first 5 peers
Matt Corallo [Sat, 16 Jun 2018 23:39:21 +0000 (19:39 -0400)]
Support responding to Ping messages in peer_handler
Matt Corallo [Sat, 16 Jun 2018 23:20:50 +0000 (19:20 -0400)]
Work around lnd sending invalid messages
Matt Corallo [Sat, 16 Jun 2018 23:04:42 +0000 (19:04 -0400)]
Support ignoring some errors, deserialize empty flags types
Matt Corallo [Thu, 14 Jun 2018 22:31:36 +0000 (18:31 -0400)]
Merge pull request #29 from TheBlueMatt/2018-06-api-quirks
Some API Quirks
Matt Corallo [Thu, 14 Jun 2018 22:03:16 +0000 (18:03 -0400)]
Make PeerHandleError Error impl public
Matt Corallo [Thu, 14 Jun 2018 20:48:06 +0000 (16:48 -0400)]
Remove bitcoincorerpcchain, as it belongs in a separate crate
Matt Corallo [Thu, 14 Jun 2018 18:21:20 +0000 (14:21 -0400)]
Provide Send + Sync on message handlers (just changes trait)
Matt Corallo [Tue, 5 Jun 2018 00:42:30 +0000 (20:42 -0400)]
Merge pull request #28 from TheBlueMatt/master
fuzztarget sha -> XOR, crates secp256k1
Matt Corallo [Thu, 26 Apr 2018 23:44:24 +0000 (19:44 -0400)]
fuzztarget sha -> XOR, crates secp256k1
Matt Corallo [Sun, 13 May 2018 17:54:29 +0000 (13:54 -0400)]
Merge pull request #26 from TheBlueMatt/master
Small style tweaks for new message targets for my own style preferences
Matt Corallo [Sun, 13 May 2018 17:22:56 +0000 (13:22 -0400)]
Update msg_target_template to note auto-generation
Matt Corallo [Sun, 13 May 2018 17:22:43 +0000 (13:22 -0400)]
Fix indentation in fuzz_target utils
Matt Corallo [Sun, 13 May 2018 17:17:18 +0000 (13:17 -0400)]
Make travis check that msg_targets match the template
Matt Corallo [Sun, 13 May 2018 17:13:01 +0000 (13:13 -0400)]
Merge pull request #24 from yuntai/master
fill decode/encode routines for many messages with fuzz targets
Yuntai Kyong [Tue, 8 May 2018 12:57:20 +0000 (21:57 +0900)]
add fuzz target for messages
[[bin]] section for each new target in Cargo.toml
glob chanbes in travis-fuzz.sh
Yuntai Kyong [Sat, 12 May 2018 20:09:46 +0000 (05:09 +0900)]
add script to generate msg test target
Yuntai Kyong [Tue, 8 May 2018 12:43:34 +0000 (21:43 +0900)]
Update dependency on secp256k1 pointing to https://github.com/rust-bitcoin/rust-secp256k1
Yuntai Kyong [Tue, 8 May 2018 12:40:30 +0000 (21:40 +0900)]
filling unimplemented!() for many messages' encoding/decoding routines
Yuntai Kyong [Mon, 7 May 2018 05:54:13 +0000 (14:54 +0900)]
add .gitignore
Matt Corallo [Thu, 10 May 2018 14:56:22 +0000 (10:56 -0400)]
Merge pull request #25 from TheBlueMatt/master
Fix channel_target crash fp
Matt Corallo [Thu, 10 May 2018 14:35:39 +0000 (10:35 -0400)]
Make channel_target return as channelmanager removes on shutdown
Matt Corallo [Thu, 26 Apr 2018 23:43:50 +0000 (19:43 -0400)]
Some with_capacity's
Matt Corallo [Thu, 26 Apr 2018 23:45:23 +0000 (19:45 -0400)]
Merge pull request #23 from TheBlueMatt/master
Fix repo link in Cargo
Matt Corallo [Thu, 26 Apr 2018 21:34:55 +0000 (17:34 -0400)]
Fix repo link in Cargo
Matt Corallo [Thu, 26 Apr 2018 16:19:40 +0000 (12:19 -0400)]
Merge pull request #22 from TheBlueMatt/master
Bump version for API changes.
Matt Corallo [Thu, 26 Apr 2018 15:39:41 +0000 (11:39 -0400)]
Bump version for API changes.
Matt Corallo [Thu, 26 Apr 2018 15:37:46 +0000 (11:37 -0400)]
Merge pull request #21 from TheBlueMatt/master
Begin handling errors/tx broadcasts robustly
Matt Corallo [Wed, 25 Apr 2018 00:40:22 +0000 (20:40 -0400)]
Fix local route update broadcasts, annouce channel closures
Matt Corallo [Tue, 24 Apr 2018 04:19:52 +0000 (00:19 -0400)]
Rewrite channelmonitor framework and implement a bunch of it
Matt Corallo [Tue, 24 Apr 2018 04:21:38 +0000 (00:21 -0400)]
Fix some channel remove channelmanager consistency bugs
Matt Corallo [Tue, 24 Apr 2018 04:18:54 +0000 (00:18 -0400)]
HTLC Failure message handling
Matt Corallo [Tue, 17 Apr 2018 16:32:52 +0000 (12:32 -0400)]
Move ChannelKeys creation into channelmanager
Matt Corallo [Tue, 17 Apr 2018 02:03:35 +0000 (22:03 -0400)]
Merge pull request #20 from TheBlueMatt/master
Rewrite parts of channel, cleanup a bunch of stuff
Matt Corallo [Mon, 16 Apr 2018 20:55:03 +0000 (16:55 -0400)]
Provide fallback for crypto's fixed_time_eq on non-x86/arm targets
Matt Corallo [Mon, 9 Apr 2018 01:01:13 +0000 (21:01 -0400)]
Minor cleanups
Matt Corallo [Sun, 8 Apr 2018 18:24:12 +0000 (14:24 -0400)]
Fix commitment transaction number/per_commitment_point tracking
Matt Corallo [Thu, 5 Apr 2018 21:21:50 +0000 (17:21 -0400)]
Refactor channelmanager network tests significantly
Matt Corallo [Wed, 4 Apr 2018 15:44:33 +0000 (11:44 -0400)]
impl more message encodings
Matt Corallo [Wed, 4 Apr 2018 15:56:54 +0000 (11:56 -0400)]
Completely rewrite channel HTLC tracking and processing
It obviously was nonsensical prior, though its now way more
complicated...there's refactoring work to be done here, but it
should at least kinda sorta work now.
Matt Corallo [Tue, 3 Apr 2018 18:59:23 +0000 (14:59 -0400)]
Prep HTLCFailReason for Channel holding it until revoke_and_ack
Matt Corallo [Mon, 2 Apr 2018 22:28:50 +0000 (18:28 -0400)]
Use libbitcoinconsensus to check tx validity in some tests
Matt Corallo [Mon, 2 Apr 2018 16:06:22 +0000 (12:06 -0400)]
Test that channel monitors get updated appropriately
Matt Corallo [Mon, 2 Apr 2018 15:45:40 +0000 (11:45 -0400)]
Hand payment preimages into channel monitors when claimed
Matt Corallo [Tue, 17 Apr 2018 00:33:39 +0000 (20:33 -0400)]
Switch back to crates.io rust-bitcoin for 0.13 release
Matt Corallo [Mon, 2 Apr 2018 23:43:46 +0000 (19:43 -0400)]
Merge pull request #19 from TheBlueMatt/2018-04-error-handling-framework
Clean up peer_handler error handling a bit, clean up channel error handling a ton
Matt Corallo [Mon, 2 Apr 2018 22:39:26 +0000 (18:39 -0400)]
Fix travis-fuzz upgrade-handling
Matt Corallo [Mon, 2 Apr 2018 22:00:55 +0000 (18:00 -0400)]
Remove useless htlc_redeemscript argument
Matt Corallo [Sun, 1 Apr 2018 23:54:14 +0000 (19:54 -0400)]
Clean up channel error handling a ton
Matt Corallo [Sun, 1 Apr 2018 23:23:09 +0000 (19:23 -0400)]
Basic error handling framework in peer_handler
Matt Corallo [Sun, 1 Apr 2018 23:21:26 +0000 (19:21 -0400)]
Require Init as first message, send our own Init for outbound
Matt Corallo [Sun, 1 Apr 2018 21:20:59 +0000 (17:20 -0400)]
Rename ErrorMessage
Matt Corallo [Mon, 2 Apr 2018 22:27:23 +0000 (18:27 -0400)]
Merge pull request #18 from TheBlueMatt/2018-04-fuzzing-expansion
Expand full_stack_target from uselessly-large to laughably-large