Removed unused_mut rejection and fix some unused `mut`s
authorMatt Corallo <git@bluematt.me>
Mon, 5 Jun 2023 23:26:38 +0000 (23:26 +0000)
committerMatt Corallo <git@bluematt.me>
Mon, 5 Jun 2023 23:26:38 +0000 (23:26 +0000)
Making warnings a hard failure is generally bad practice as it can
result in new compiler versions failing to compile
otherwise-totally-acceptable code, which in this case is happening
on rustc beta, which is now warning for new cases of unused mut.

src/lib.rs
src/lookup.rs

index b655c563e1ebe0f61501ce1b62efda912f4e43a3..cd91a4e2d6d5e1fade3f4d57588065283e06505d 100644 (file)
@@ -4,7 +4,6 @@
 #![deny(non_upper_case_globals)]
 #![deny(non_camel_case_types)]
 #![deny(non_snake_case)]
-#![deny(unused_mut)]
 #![deny(unused_variables)]
 #![deny(unused_imports)]
 
index 1bac79f94fb1755de8d0128ec5aa8571fc1c7aaf..25ea85422bf3ffdae4ee0acc7a7d07eb838269d1 100644 (file)
@@ -90,7 +90,7 @@ pub(super) async fn fetch_channel_announcements(delta_set: &mut DeltaSet, networ
                let current_seen_timestamp_object: SystemTime = current_announcement_row.get("seen");
                let current_seen_timestamp: u32 = current_seen_timestamp_object.duration_since(SystemTime::UNIX_EPOCH).unwrap().as_secs() as u32;
 
-               let mut current_channel_delta = delta_set.entry(scid).or_insert(ChannelDelta::default());
+               let current_channel_delta = delta_set.entry(scid).or_insert(ChannelDelta::default());
                (*current_channel_delta).announcement = Some(AnnouncementDelta {
                        announcement: unsigned_announcement,
                        seen: current_seen_timestamp,
@@ -111,7 +111,7 @@ pub(super) async fn fetch_channel_announcements(delta_set: &mut DeltaSet, networ
                let current_seen_timestamp_object: SystemTime = current_row.get("seen");
                let current_seen_timestamp: u32 = current_seen_timestamp_object.duration_since(SystemTime::UNIX_EPOCH).unwrap().as_secs() as u32;
 
-               let mut current_channel_delta = delta_set.entry(scid).or_insert(ChannelDelta::default());
+               let current_channel_delta = delta_set.entry(scid).or_insert(ChannelDelta::default());
                (*current_channel_delta).first_update_seen = Some(current_seen_timestamp);
        }
 }
@@ -142,7 +142,7 @@ pub(super) async fn fetch_channel_updates(delta_set: &mut DeltaSet, client: &Cli
                let scid = unsigned_channel_update.short_channel_id;
 
                let current_channel_delta = delta_set.entry(scid).or_insert(ChannelDelta::default());
-               let mut update_delta = if !direction {
+               let update_delta = if !direction {
                        (*current_channel_delta).updates.0.get_or_insert(DirectedUpdateDelta::default())
                } else {
                        (*current_channel_delta).updates.1.get_or_insert(DirectedUpdateDelta::default())